Timeline


and

07/22/08:

22:10 Changeset [35291] by ggaren@apple.com
  • 84 edits in trunk

JavaScriptCore:

2008-07-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.


This means a few things:


  1. Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.


  1. Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.


  1. I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.


SunSpider reports no change.

JavaScriptGlue:

2008-07-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

WebCore:

2008-07-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt and Sam Weinig.

Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.

20:11 Changeset [35290] by weinig@apple.com
  • 5 edits
    1 move in trunk

WebCore:

2008-07-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType):

LayoutTests:

2008-07-22 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.

  • Turn on and simplify toDataURL-supportedTypes.html to only test for support of mimeTypes and not fail due to differences in image encoders.
  • fast/canvas/toDataURL-supportedTypes-expected.txt:
  • fast/canvas/toDataURL-supportedTypes.html: Copied from fast/canvas/toDataURL-supportedTypes.html-disabled.
  • fast/canvas/toDataURL-supportedTypes.html-disabled: Removed.
14:45 Changeset [35289] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/6004877> internal anchors on this page are not showing up in the AXLinkedUIElements

14:28 BuildingGtk edited by sebasmagri@gmail.com
(diff)
13:23 Changeset [35288] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-22 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Allocate the empty StringImpl from the heap.


  • platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
10:25 Changeset [35287] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-07-21 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
view (19228)

  • Implement UI for Heavy (Bottom Up) view.
  • English.lproj/localizedStrings.js:
  • page/JavaScriptProfile.cpp: Expose the ability to get a heavy/tree profile from a profile to the Web Inspector's JavaScript. (WebCore::getHeavyProfileCallback): (WebCore::getTreeProfileCallback): (WebCore::ProfileClass):
  • page/inspector/ProfileView.js: Implement the dropdown for changing profile views.
  • page/inspector/inspector.css:
08:51 Changeset [35286] by ap@webkit.org
  • 5 edits in trunk

Reviewed by Adam Roben.

<rdar://problem/5955602> WebKit should support charset name x-windows-949

Test: fast/encoding/char-decoding.html

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added support for this name for Firefox compatibility.
07:26 Changeset [35285] by barraclough@apple.com
  • 3 edits
    1 add in trunk

JavaScriptCore:

2008-07-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Alexey Proskuryakov.

Prevent integer overflow when reallocating storage vector for arrays.

Sunspider reports 1.005x as fast (no change expected).

  • kjs/JSArray.cpp:

WebCore:

2008-07-22 Gavin Barraclough <barraclough@apple.com>

Reviewed by Alexey Proskuryakov.

New test to check that arrays fail gracefully (throw an out of memory exception)
when the vector grows to large.

  • manual-tests/array-out-of-memory.html: Added.

07/21/08:

22:52 Changeset [35284] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=20117
setBaseAndExtent fails to reverse the current selection

Test: editing/selection/setBaseAndExtent-revert-selection.html

  • editing/Selection.h: (WebCore::operator==): Compare direction, too.
21:35 Changeset [35283] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Fix pthread linkage under Linux.

18:43 Changeset [35282] by jchaffraix@webkit.org
  • 6 edits in trunk/WebCore

WebCore:

2008-07-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Sam Weinig.

Bug 19919: Add selectors' string parsing in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=19919

No functional change.

  • css/CSSGrammar.y: Added entry for parsing only a selector.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSelector):
  • css/CSSParser.h: Added m_floatingSelector to hold the Selector parsed in parseSelector.
  • css/tokenizer.flex: Added "@-webkit-selector" token.
  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll): Switched to parseSelector method.
18:19 Changeset [35281] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-21 Kevin Calhoun <kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6081160> REGRESSION: Hang loading many pages if QuickTime isn't installed

  • platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes): Do a Quicktime version minimum version check. (QTMovieWin::initializeQuickTime): Store the Quicktime version globally so in can be used in initializeSupportedTypes as well.
18:09 Changeset [35280] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-21 Kevin Calhoun <kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/5713336> <video> and <audio> elements that use a autoplay attribute fail to start playing when returning back to page

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache): Reset the ready state to DATA_UNAVAILABLE when saving to the cache so that everything starts back up normally when the page is retrieved from the cache.
18:06 Changeset [35279] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Remove unused interface declaration.

  • platform/network/mac/ResourceHandleMac.mm:
18:05 Changeset [35278] by mrowe@apple.com
  • 12 edits in trunk

<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.

Reviewed by Sam Weinig.

18:02 Changeset [35277] by adele@apple.com
  • 5 edits in trunk/WebCore

2008-07-21 Kevin Calhoun <kcalhoun@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::inMediaDocument): Added.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
17:41 Changeset [35276] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-21 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

Don't allow requests to be made when the document loader is stopping all loaders.

  • plugins/PluginView.cpp: (WebCore::PluginView::load):
16:07 Changeset [35275] by andersca@apple.com
  • 3 edits
    2 adds in trunk

WebKit/mac:

2008-07-21 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load


Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

LayoutTests:

2008-07-21 Anders Carlsson <andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load

  • http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Added.
  • http/tests/plugins/geturlnotify-from-npp-destroystream.html: Added.
13:23 Changeset [35274] by britto@apple.com
  • 3 edits in trunk/WebCore

2008-07-20 Maxime Britto <britto@apple.com>

Reviewed by John Sullivan.

[PFR] <rdar://problem/6080639> New middle click scrolling speed seems much slower than in FF
Accelerate and enhance the smoothness of the pan scrollling.

  • page/EventHandler.cpp: Changed the TimerInterval from 0.1 to 0.05. The scrolling is way more fluid like this.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): Differentiate the speed within a 200 pixel side square, around the original click location to the speed for farther distances. This way we allow easyier handle when we are close to the center and very fast scrolling when we go far from the original point.
13:16 Changeset [35273] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

2008-07-18 David Hyatt <hyatt@apple.com>

Change the cached clip rects to not assume they should be infinite when the root layer has been
shifted as the result of a transformation.

Reviewed by Maciej

Added fast/transforms/overflow-with-transform.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
13:15 Changeset [35272] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Mitz.

https://bugs.webkit.org/show_bug.cgi?id=19966
CSS variables crash when using hex notation for colors

Support hex colors as values for the css variables.

Test: fast/css/variables/color-hex-test.html

11:29 Changeset [35271] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Update Akismet plugin to 2.1.6.

11:16 Changeset [35270] by mrowe@apple.com
  • 225 edits
    43 adds in trunk/WebKitSite

Update to WordPress 2.6.

10:43 Changeset [35269] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Add Vector::find

This is a convenience wrapper around std::find.

Reviewed by Anders Carlsson.

  • wtf/Vector.h:
08:13 Changeset [35268] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64

Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
This prevents a garbage value being used for the scale factor that the NSView print machinery applies.

Reviewed by Adam Roben.

  • WebView/WebHTMLView.mm:
08:13 Changeset [35267] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix CallDelegateReturningFloat for x86_64.

The x86_64 Objective-C runtime only uses objc_msgSend_fpret for
long double return values. For float return values the standard
objc_msgSend is used, as on ppc and ppc64.

Reviewed by Adam Roben.

  • WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of

objc_msgSend with the correct return type. We can no longer call it objc_msgSend_fpret
as that method is defined by the Objective-C runtime for x86_64.
(CallDelegateReturningFloat):

07:45 Changeset [35266] by barraclough@apple.com
  • 9 edits
    3 deletes in trunk

Roll out r35261

06:47 Changeset [35265] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-21 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Fix drawing of windowless plugins on Windows with the Qt port by
avoiding the reset of the translation of the HDC to 0, 0.

06:46 Changeset [35264] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-21 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Fix rendering of transparent windowless netscape plugins by passing
the right conversion parameter to QPixmap::fromWinHBITMAP when
converting from HBITMAP to QPixmap.

06:46 Changeset [35263] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-21 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

In the implementation of getValue for NPNVnetscapeWindow treat
windowHandleForPlatformWidget on the return value of
containingWindow() to receive the correct HWND for the Qt port.

06:46 Changeset [35262] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-21 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Fix windowHandleForPlatformWidget to return 0 as HWND if we don't have
a QWidget. This can happen on page/view destruction for example.

02:34 Changeset [35261] by ddkilzer@apple.com
  • 12 edits in trunk

WebCore:

2008-07-21 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:

  • not to fail when closing braces are not found for a declaration at the end of the file
  • not to accept "!important fail" as valid
  • to keep accepting @import when it comes after invalid @ rules
  • not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.
  • css/CSSGrammar.y:

LayoutTests:

2008-07-21 Anatoli Papirovski <apapirovski@mac.com>

Reviewed by Dave Hyatt.

Updated layout CSS2.1 test suite tests related to css parsing:
https://bugs.webkit.org/show_bug.cgi?id=14346

  • platform/mac/css2.1/t040105-import-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-import-01-b-expected.png:
  • platform/mac/css2.1/t040105-import-01-b-expected.txt:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.txt:

07/20/08:

20:39 Changeset [35260] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Touch file to force rebuild for vsprops change.

  • WebCorePrefix.h:
20:38 Changeset [35259] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Build fix.

  • win/tools/vsprops/common.vsprops:
18:37 Changeset [35258] by oliver@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Whoops, forgot to commit expected output for this test.

RS=Dan Bernstein

16:39 Changeset [35257] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-20 Sam Weinig <sam@webkit.org>

Remove extra space Oliver Hunt left in.

  • page/Console.cpp: (WebCore::Console::reportException): (WebCore::Console::reportCurrentException):
14:31 Changeset [35256] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 19757: Crash when an ondragstart handler hides the element
<https://bugs.webkit.org/show_bug.cgi?id=19757>

Reviewed by Dan Bernstein.

The solution to this is problem is just to null check the renderer
immediately before launching the system drag, and terminate the
drag if the renderer is gone.

13:48 Changeset [35255] by zimmermann@webkit.org
  • 6 edits
    4 adds in trunk

Reviewed by Oliver.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=12171

Remove manual SVG property <-> XML attribute synchronization in SVGPolyElement.
Added svg/custom/poly-points-attribute-changes.svg (testcase from Rob)

13:40 Changeset [35254] by zimmermann@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Oliver.
Cleanup JSSVGPODTypeWrapper code.

05:43 Changeset [35253] by oliver@apple.com
  • 28 edits
    2 adds in trunk

Bug 15979: Console logs in a database callback lose line number information
<https://bugs.webkit.org/show_bug.cgi?id=15979>

Reviewed by Mark Rowe

The problem was that there were multiple versions of the logic to
log an exception to the console, many of which were incorrect. We
resolve this by making one single shared reportException method,
which handles the exceptions correctly.

This improves fidelity of callback errors, and ensures that
exceptions thrown in timer callbacks correctly report line numbers,
etc.

Test: fast/js/exceptions-thrown-in-callbacks.html

04:46 Changeset [35252] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Rubber stamped by Oliver.
Another attempt to fix the win build.

02:24 Changeset [35251] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by David Kilzer.

Fix high CPU usage on testmyiphone.com.

  • Made the logic for determining when to stop looking for meta charset more strainghtforward. Previously, this happened if a tag that's disallowed in HEAD was seen past the first 512 bytes. Now, the algorithm bails out at the boundary if we are lo longer in HEAD (i.e, an offending tag was seen at any point before).
  • The above change made one of our regression tests fail, because it had its <meta> declaration past the 512 byte boundary. Fixed it by raising the boundary to 1024 bytes.
  • Made the algorithm bail out quickly if a comment that's not in HEAD crosses the boundary.
  • Moved a check for XML content type out of the loop.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
00:05 FAQ edited by pewtermoose@webkit.org
(diff)

07/19/08:

22:29 Changeset [35250] by oliver@apple.com
  • 8 edits in trunk

Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression
<https://bugs.webkit.org/show_bug.cgi?id=20104>

Reviewed by Cameron Zwarich

To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.

15:05 Changeset [35249] by oliver@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix windows build.

08:46 Changeset [35248] by zimmermann@webkit.org
  • 116 edits
    1 add in trunk/WebCore

Reviewed by Oliver & parts by Eric.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051

Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)

07/18/08:

21:40 Changeset [35247] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):
21:11 Changeset [35246] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):
18:44 Changeset [35245] by oliver@apple.com
  • 37 edits
    2 adds in trunk

Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Cameron Zwarich

Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.

18:36 Changeset [35244] by britto@apple.com
  • 8 edits
    3 adds in trunk

2008-07-18 Maxime Britto <britto@apple.com>

Reviewed by Adele.


Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.

Test: fast/events/autoscroll-with-non-scrollable-parent.html

  • ChangeLog:
  • page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
  • rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>

Reviewed by Adele.

Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes

  • ChangeLog:
  • fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
  • fast/events/autoscroll-with-non-scrollable-parent.html: Added.
  • fast/events/resources/big-page-with-input.html: Added.
17:22 Changeset [35243] by weinig@apple.com
  • 4 edits in trunk/WebCore

2008-07-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest

  • Overload XMLHttpRequests send() method to accept File tokens.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
  • xml/XMLHttpRequest.h:
15:18 Changeset [35242] by ggaren@apple.com
  • 34 edits in trunk

JavaScriptCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

JavaScriptGlue:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

  • ChangeLog:
  • JSObject.cpp: (JSUserObject::getCallData):

WebCore:

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Three renames:


"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"

15:15 Changeset [35241] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-18 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.

  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
15:04 Changeset [35240] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-07-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by mitz

Remove braces around single-line conditional.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
14:59 Changeset [35239] by simon.fraser@apple.com
  • 5 edits in trunk

2008-07-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.

https://bugs.webkit.org/show_bug.cgi?id=20008

Testcase: LayoutTests/fast/css/computed-style-without-renderer

LayoutTests/fast/css/computed-style-expected.txt

14:44 Changeset [35238] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-07-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086

14:25 Changeset [35237] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized <= for immediate number cases.


SunSpider reports no overall change, but a 10% speedup on access-nsieve.

14:03 Changeset [35236] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix some casts added in a previous build fix to match the style used
throughout WebKit.

Rubber-stamped by Sam Weinig.

  • VM/Machine.cpp:

(KJS::Machine::initializeCallFrame):

  • VM/Register.h:

(KJS::Register::Register):

11:31 Changeset [35235] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Update expected results for a recently added test to what is seen when running the
full test suite.

  • fast/forms/form-and-frame-interaction-retains-values-expected.txt:
08:31 Changeset [35234] by ddkilzer@apple.com
  • 7 edits in trunk

Bug 19975: [OpenBSD] Patches to enable build of WebKit

JavaScriptCore:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

Support for OpenBSD, mostly threading and libm tweaks.

  • kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
  • kjs/config.h: OpenBSD also provides <pthread_np.h>
  • wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
  • wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro

WebKitTools:

2008-07-18 Landry Breuil <landry@openbsd.org>

Bug 19975: [OpenBSD] Patches to enable build of WebKit

<https://bugs.webkit.org/show_bug.cgi?id=19975>

Reviewed by David Kilzer.

  • DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
08:21 Changeset [35233] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitSite

Fixed indentation of example code for C++ pointers/references!

  • coding/coding-style.html:
08:15 Changeset [35232] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-18 Robert Blaut <webkit@blaut.biz>

Reviewed by David Kilzer.

Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions

  • coding/coding-style.html:
Note: See TracTimeline for information about the timeline view.