Timeline


and

08/04/08:

23:03 Changeset [35554] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.2

Versioning.

23:03 Changeset [35553] by mrowe@apple.com
  • 7 edits
    1 add in tags/Safari-6528.0.2/WebKit

Merge r35546 and r35547.

22:13 Changeset [35552] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-04 Alice Liu <alice.liu@apple.com>

Reviewed by Steve Falkenburg.

Fix CFDictionary leak

  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Write): m_dictionary is a RetainPtr and should adopt the CF type created
21:09 Changeset [35551] by mitz@apple.com
  • 5 edits in trunk

WebCore:

2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Corrected offsetTop for table cells by subtracting borderTopExtra

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop):

LayoutTests:

2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Tests for offsetTop of table cells updated so that they don't include borderExtraTop

  • fast/dom/Element/offsetTop-table-cell-expected.txt:
  • fast/dom/Element/offsetTop-table-cell.html:
20:58 Changeset [35550] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

2008-08-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Fix typo in Skipped lists.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
20:19 Changeset [35549] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.2

New tag.

20:16 Changeset [35548] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

19:02 Changeset [35547] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.

Reviewed by Kevin Decker.

19:02 Changeset [35546] by mrowe@apple.com
  • 4 edits
    1 add in trunk/WebKit

Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.

Reviewed by Darin Adler.

18:54 Changeset [35545] by dino@apple.com
  • 28 edits
    3 adds in trunk

2008-08-04 Dean Jackson <dino@apple.com>

Reviewed by Dave Hyatt.

Improve AnimationController
https://bugs.webkit.org/show_bug.cgi?id=19938

  • Transition class is now called Animation
  • new state-based AnimationController that can support CSS Animations
  • add support for -webkit-transition-delay
  • remove -webkit-transition-repeat-count (since it never existed officially)
  • updates the -webkit-transition shorthand to reflect removing repeat count
  • updates the Transition class so that properties can be shared with animations
  • adds a "now" keyword for -webkit-transition-delay
  • adds a new change type for style (changed by animation)
  • adds new event names (although they are not dispatched yet)
  • makes text stroke and text fill colors returned by RenderStyle const

Tests:

  • manual-tests/transition-left.html
  • manual-tests/transition-delay.html
  • manual-tests/transition-timing-functions.html
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • css/WebKitCSSTransformValue.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.cpp:
  • dom/EventNames.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • history/CachedPage.cpp:
  • page/AnimationController.cpp:
  • page/AnimationController.h:
  • page/Frame.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderWidget.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
17:39 Changeset [35544] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Antti.

Currently we create two copies of script in the HTMLTokenizer.
One copy gets passed into the javascript engine, the other gets
stored in the DOM. Modify the HTMLParser so that it does not
chunk the string into it's normal 64K chunks for script code,
and modify the HTMLTokenizer to pass that same string into the
JS engine. On some sites (e.g. GMail), which have hundreds of
KB of inline JS, this saves more than a MB of RAM to run the page.
(Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)

  • html\HTMLParser.cpp
  • html\HTMLTokenizer.cpp
16:01 Changeset [35543] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix warning seen in MSVC converting ints to floats.

  • rendering/Length.h: (WebCore::Length::calcFloatValue):
14:24 Changeset [35542] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extra braces left in from JSLock removal.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
13:29 Changeset [35541] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Update skipped lists for renamed tests.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
13:21 Changeset [35540] by weinig@apple.com
  • 6 edits
    14 adds in trunk

WebCore:

2008-08-02 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Implement the Access-control for Cross Site requests
preflight cache.

Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html

http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.h: (WTF::):
  • platform/KURLHash.h: Added. (WebCore::KURLHash::hash): (WebCore::KURLHash::equal): (WTF::):
  • xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::preflightResultCache): (WebCore::appendPreflightResultCacheEntry): (WebCore::canSkipPrelight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::parseAccessControlAllowList): (WebCore::parseAccessControlMaxAge): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for the Access-control for Cross Site requests
preflight cache.

  • ChangeLog:
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
  • http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
  • http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.
12:59 Changeset [35539] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt.

Clean up Gradient constructors, make sure all members are initialized.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
12:53 Changeset [35538] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-04 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel

Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.

This broke in r31355 when we stopped returning nil WebResources when there was nil
resource data.

  • WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil when the resource data is null.
09:02 Changeset [35537] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20221

Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.

07:31 Changeset [35536] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

A bunch of improvements to the QtLauncher.

Among others:

  • Unify and unclutter the toolbar, use menu for addition actions
  • Simplify URL edit, just use QLineEdit (no fancy close button etc)
  • Guess the URL from the command line so now we can run ./QtLauncher www.google.com
  • Shortcut keys for most actions
  • Simple autocomplete for the URL edit
  • Actions for zooming, New Window and Close Window
  • Show Format menu only when the content is set to editable
07:03 Changeset [35535] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20198

Allow Copy key sequence to work in non-editable areas.

08/03/08:

19:34 Changeset [35534] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Future-proof fast/cookies/local-file-can-set-cookies.html

Reviewed by Anders Carlsson.

  • fast/cookies/local-file-can-set-cookies.html: Set cookie expiration date 60 seconds into the future instead of a hard-coded date.
02:58 Changeset [35533] by oliver@apple.com
  • 10 edits
    3 adds in trunk

Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement
<https://bugs.webkit.org/show_bug.cgi?id=19359>

Reviewed by Cameron Zwarich

Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node. We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.

01:34 Changeset [35532] by britto@apple.com
  • 13 edits
    8 adds in trunk

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6118969>
https://bugs.webkit.org/show_bug.cgi?id=19971
Modifiy the cursor interactively when on panning mode (middle click auto scroll)
When the panning is in progress the cursor is an arrow representing the direction of the current scroll

  • page/EventHandler.cpp: (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
  • platform/Cursor.h: Add propotypes for the new cursor functions
  • platform/gtk/CursorGtk.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/mac/CursorMac.mm: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/qt/CursorQt.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/wx/CursorWx.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.


These icons are copies from the resizers in WebCore/Ressources

  • ChangeLog:
  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/panEastCursor.png: Added.
  • WebKit.vcproj/panNorthCursor.png: Added.
  • WebKit.vcproj/panNorthEastCursor.png: Added.
  • WebKit.vcproj/panNorthWestCursor.png: Added.
  • WebKit.vcproj/panSouthCursor.png: Added.
  • WebKit.vcproj/panSouthEastCursor.png: Added.
  • WebKit.vcproj/panSouthWestCursor.png: Added.
  • WebKit.vcproj/panWestCursor.png: Added.
  • WebKit.vcproj/resource.h:
  • WebKitDLL.cpp: (loadResourceIntoBuffer):

08/02/08:

18:47 Changeset [35531] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-02 Rob Gowin <robg@gowin.net>

Reviewed by Eric Seidel.

Added JavaScriptCore/API/WebKitAvailability to list of files in
javascriptcore_h_api.

  • GNUmakefile.am:
15:34 Changeset [35530] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit/mac

2008-08-02 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update the window gradient offset to match the inspector toolbar's new height.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):
15:24 Changeset [35529] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Forgot to commit licensing correction in last commit.

14:50 Changeset [35528] by kevino@webkit.org
  • 1 edit
    3 adds in trunk/WebKitTools

Reviewed by Eric Seidel.

Scripts for building a wxWebKit installer for wxPython on Win, eventually will
be used for nightlies.

https://bugs.webkit.org/show_bug.cgi?id=20036

14:33 Changeset [35527] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Move to using constants in accordance with discussions about wx renderer commit.

02:38 Changeset [35526] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-02 Wouter Bolsterlee <wbolster@svn.gnome.org>

Reviewed by Eric Seidel.

  • plugins/gtk/gtk2xtbin.h:

https://bugs.webkit.org/show_bug.cgi?id=20034
Fix malformed Vim modeline.

02:38 Changeset [35525] by jmalonzo@webkit.org
  • 1 edit
    1 delete in trunk/WebKit/gtk

2008-08-02 Christian Dywan <christian@twotoasts.de>

Reviewed by Eric Seidel.

Remove webkit-marshal.list, which was made obsolete in #19742

  • webkit/webkit-marshal.list: Removed.

08/01/08:

23:10 Changeset [35524] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • tweak a comment
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
22:48 ApplicationsGtk edited by alp@atoker.com
Updates (diff)
22:19 Changeset [35523] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKit/gtk/ChangeLog

Forgot to add the reviewer of r35522.

  • WebKit/gtk/ChangeLog:
22:12 Changeset [35522] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-08-01 Wouter Bolsterlee <uws@xs4all.nl>

https://bugs.webkit.org/show_bug.cgi?id=20035
[GTK] Fix return value for webkit_web_view_go_to_back_forward_item()

  • webkit/webkitwebview.cpp:
22:11 Changeset [35521] by jmalonzo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2008-08-01 Jan Michael Alonzo <jmalonzo@webkit.org>

  • ChangeLog: Fix date of previous commit (r35520)
22:01 Changeset [35520] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-06-17 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=19603
[SOUP] segfault when closing a file using gio

Call client->didFinishLoading() only after releasing all the gio
resources.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
17:29 Changeset [35519] by andersca@apple.com
  • 4 edits in trunk

../../../../../../WebCore:

2008-08-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.


  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):

../../../../../../WebKit/mac:

2008-08-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream wantsAllStreams]):
17:06 Changeset [35518] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Native rendering implementations for form elements in the wx port.

https://bugs.webkit.org/show_bug.cgi?id=19069

14:50 Changeset [35517] by bdakin@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-01 Beth Dakin <bdakin@apple.com>

Reviewed by Adam Roben.

Fix for <rdar://problem/6119382> Need to hook up WebFrame's
disconnected frame API on Windows.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setIsDisconnected):
  • WebFrame.h:
14:32 Changeset [35516] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form

Reviewed by Darin Adler.

  • COMPropertyBag.h: (COMPropertyBag::QueryInterface): Cast to an appropriate type before assigning into ppvObject.
13:24 Changeset [35515] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-07-30 David Hyatt <hyatt@apple.com>

Improvements to selection drawing.

Clip out floating and positioned objects when drawing selection so
that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
object and the positioned/floating object itself. Improves most Web pages.

Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
position). Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.

Reviewed by Dan

Covered by existing selection pixel tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::paintSelection): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
13:23 Changeset [35514] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the ability to disable individual properties of a CSS rule.
When hovering over a rule, checkboxes show up to the right of all
properties and toggling a checkbox disables/enables the property.
Behind the scenes the property is removed from the rule when disabled,
but still remains in the list and in the computed style. When disabled
the property has a line through it, and is faded in computed style.

<rdar://problem/5712828> Support disabling individual CSS properties
https://bugs.webkit.org/show_bug.cgi?id=14377

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Include the inline style when it also has disabled properties. Call deleteDisabledProperty for any property that is in the style, since it might have been added back by the page. Remember all disabled properties so they show up in computed style. (deleteDisabledProperty): Helper function to delete all the right properties that track disabled properties. (WebInspector.StylePropertiesSection): Add the computed-style class when the section is Computed Style. (WebInspector.StylePropertiesSection.prototype.onpopulate): Include disabled properties. (WebInspector.StylePropertyTreeElement): Added a disabled argument. (WebInspector.StylePropertyTreeElement.prototype.get/set disabled): Sets the _disabled property and calls updateState. (WebInspector.StylePropertyTreeElement.prototype.get priority): Return the priority of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.get value): Return the value of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the priority and value getter. Append the checkbox for root elements of an editable section. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Add or remove properties from the rule and remember removed ones by adding three objects to the style: disabledProperties, disabledPropertyValues and disabledPropertyPriorities. The disabledProperties object will include all longhand properties of a shorthand for use by Computed Style. (WebInspector.StylePropertyTreeElement.prototype.updateState): Use the value getter. Update the disabled state.
  • page/inspector/inspector.css:
  • page/inspector/utilities.js: (Object.hasProperties): Added. Helper to test if an object has any properties.
12:23 Changeset [35513] by andersca@apple.com
  • 13 edits in trunk

../../../../../../WebCore:

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.


  • WebCore.base.exp: Export ApplicationCacheStorage::storeCopyOfCache.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::~ApplicationCache): Don't call cacheDestroyed for our special "copy" groups.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special and can only be stored to disk.


  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::isCopy): New getter.


  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Make sure to set the storageID when storing an application resource.


(WebCore::ApplicationCacheStorage::storeNewestCache):
Change this to return true/false depending on whether storing the cache succeeded or not.


(WebCore::ApplicationCacheStorage::storeCopyOfCache):
New method which stores a given cache in a new storage (database file).


  • loader/appcache/ApplicationCacheStorage.h: Add new methods.

../../../../../../WebKit/mac:

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]): New method which returns the appopriate cache directory for a given bundle identifier.


  • WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): Transfer the application cache.


  • WebView/WebDataSourcePrivate.h:
  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
11:20 Changeset [35512] by aroben@apple.com
  • 2 edits in trunk/WebKitSite

Add a link to the instructions to use Apple's Safari for Windows symbol server

Reviewed by Eric Seidel.

  • building/debug.html:
01:38 Changeset [35511] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej.

Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
instances.

  • kjs/JSGlobalData.h:
01:06 Changeset [35510] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.1

Versioning.

01:06 Changeset [35509] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.0.1/WebKit/mac

Build fix.

00:53 Changeset [35508] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.1

New tag.

07/31/08:

20:10 Changeset [35507] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

19:52 Changeset [35506] by mrowe@apple.com
  • 4 edits in tags/Safari-6528

Versioning.

19:52 Changeset [35505] by mrowe@apple.com
  • 3 edits in tags/Safari-6528/WebKit/mac

Merge r35428 and r35430.

19:32 Changeset [35504] by mrowe@apple.com
  • 1 copy in tags/Safari-6528

New tag.

17:08 Changeset [35503] by ddkilzer@apple.com
  • 5 edits in trunk/LayoutTests

Updated test results for DumpRenderTree fix in r35497

  • svg/custom/image-with-prefix-in-webarchive-expected.webarchive: Contents of the main resource are now displayed instead of encoded data.
  • svg/webarchive/svg-cursor-subresources-expected.webarchive: Ditto.
  • svg/webarchive/svg-feimage-subresources-expected.webarchive: Ditto.
  • svg/webarchive/svg-script-subresouces-expected.webarchive: Ditto. Also updated MIME types for JavaScript source now that we don't mangle application/x-javascript into text/javascript.
16:16 Changeset [35502] by andersca@apple.com
  • 5 edits
    2 deletes in trunk/WebKit/win

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Get rid of FormValuesPropertyBag and use COMPropertyBag instead.


  • COMPropertyBag.h: Implement parts of IPropertyBag2. Currently just one method (CountProperties) is implemented.


  • WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
  • WebCoreSupport/FormValuesPropertyBag.h: Removed.


  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Create a COMPropertyBag instead.


  • WebKit.vcproj/WebKit.vcproj:
15:18 Changeset [35501] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Follow-up to r35500

  • WinLauncher/WinLauncher.vcproj: Set the manifest properties for the Release configuration, too.
15:12 Changeset [35500] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-31 Stefan Landvogt <stefan.landvogt@gmail.com>

Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
the box

<https://bugs.webkit.org/show_bug.cgi?id=20245>

Reviewed by Adam Roben.

  • WinLauncher/WinLauncher.vcproj: adding the following properties to WinLauncher > Properties > Manifest Tool > Isolated COM Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb Component File Name: WebKit$(WebKitDLLConfigSuffix) Doing the change on "All Configurations"
14:42 Changeset [35499] by sullivan@apple.com
  • 11 edits in trunk

WebCore:

2008-07-31 John Sullivan <sullivan@apple.com>

WebCore part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

Reviewed by Hyatt

  • WebCore.base.exp: export symbol for WebCoreSettings::setZoomsTextOnly()


  • page/Frame.cpp: (WebCore::Frame::isZoomFactorTextOnly): use value from Settings instead of data member (WebCore::Frame::shouldApplyTextZoom): call isZoomFactorTextOnly() to get value instead of accessing now-removed data member (WebCore::Frame::shouldApplyPageZoom): ditto (WebCore::Frame::setZoomFactor): set value into Settings rather than into data member (WebCore::FramePrivate::FramePrivate): don't set initial value of now-removed data member; this is managed by Settings now


  • page/FramePrivate.h: removed m_zoomFactorIsTextOnly


  • page/Settings.cpp: (WebCore::Settings::setZoomsTextOnly): new function, sets values and reapplies styles in all frames


  • page/Settings.h: (WebCore::Settings::zoomsTextOnly): new function, returns value of new data member

WebKit/mac:

2008-07-31 John Sullivan <sullivan@apple.com>

WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs

Reviewed by Hyatt

  • WebView/WebPreferenceKeysPrivate.h: added WebKitZoomsTextOnlyPreferenceKey


  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): default value of YES for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences zoomsTextOnly]): getter for WebKitZoomsTextOnlyPreferenceKey (-[WebPreferences setZoomsTextOnly:]): setter for WebKitZoomsTextOnlyPreferenceKey


  • WebView/WebPreferencesPrivate.h: declare zoomsTextOnly/setZoomsTextOnly:


  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): update WebCore::Settings value for zoomsTextOnly
14:35 Changeset [35498] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build bot fix

  • DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only exist for people at Apple can't be found. Also updated the ICU version to 3.8.
14:21 Changeset [35497] by ddkilzer@apple.com
  • 10 edits
    1 add
    1 delete in trunk

Fix layout test results for webarchive/test-xml-stylesheet.xml

WebKit:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • WebKit.xcodeproj/project.pbxproj: Added WebHTMLRepresentationInternal.h. Changed WebHTMLRepresentationInternal.h and WebHTMLRepresentationPrivate.h to private so they're copied into PrivateHeaders.

WebKit/mac:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
for DumpRenderTree.

  • WebView/WebHTMLRepresentationInternal.h: Added.

WebKitTools:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • DumpRenderTree/mac/DumpRenderTree.mm: (convertMIMEType): Work around the "text/xml" local file type regression in Leopard using the BUILDING_ON_LEOPARD macro. Also stop mangling "application/x-javascript" into "text/javascript". (convertWebResourceDataToString): When checking whether to dump a resource as text, also check to see if the MIME type is in the -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
  • DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD macro.

LayoutTests:

Fix layout test results for webarchive/test-xml-stylesheet.xml

Reviewed by Darin.

  • platform/mac/webarchive/test-xml-stylesheet-expected.txt: Removed unused test results.
  • webarchive/test-duplicate-resources-expected.webarchive: Updated results now that we don't mangle application/x-javascript into text/javascript.
  • webarchive/test-script-src-expected.webarchive: Ditto.
  • webarchive/test-xml-stylesheet-expected.webarchive: Updated results now that we handle application/xml correctly.
14:10 Changeset [35496] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-07-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Null-check parent clip rects, because they may not have been
set up yet.
https://bugs.webkit.org/show_bug.cgi?id=20243

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
13:55 Changeset [35495] by andersca@apple.com
  • 2 copies in trunk/WebKit/win/WebCoreSupport

Did not mean to remove these files.

13:54 Changeset [35494] by andersca@apple.com
  • 2 edits
    2 deletes in trunk/WebKit/win

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.


Tweak the names.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
13:48 Changeset [35493] by andersca@apple.com
  • 5 edits
    3 adds in trunk/WebKit/win

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

<rdar://problem/5826110>


Add a way for WebKit clients to embed custom content in web pages.


  • Interfaces/IWebEmbeddedView.idl: Added. New interface which an embedded view must implement.


  • Interfaces/IWebUIDelegatePrivate.idl: Add new UI delegate method for creating an embedded view.


  • Interfaces/WebKit.idl: Include IWebEmbeddedView.idl.


  • WebCoreSupport/EmbeddedWidget.cpp: Added.
  • WebCoreSupport/EmbeddedWidget.h: Added. Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Check if the UI delegate wants to create an embedded view.


  • WebKit.vcproj/WebKit.vcproj: Add EmbeddedWidget.{cpp|h}
13:46 Changeset [35492] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6058958> REGRESSION (r34210): Seams are visible in border-image
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): To work around a Core Graphics interpolation issue, reverted to using a temporary subimage for drawing a portion of the image with scaling and high-quality interpolation in effect.
13:44 Changeset [35491] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/3563671> VO doesn't highlight characters when interacting when static text in web areas

Add ability to get bounds for individual characters through accessibility

13:39 Changeset [35490] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Removed da BOM from the ChangeLog.

12:15 Changeset [35489] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Release build fix.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]): Don't define to npErr in release builds, as it is only used for logging.
10:50 Changeset [35488] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-31 John Sullivan <sullivan@apple.com>

Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard

Reviewed by Dan

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): include Leopard in the #ifdef that forces a layout if needed
10:33 Changeset [35487] by kevino@webkit.org
  • 7 edits in trunk

Second attempt at Windows/wx build fix. Instead of avoiding inclusion of windows.h, use defines, etc. to avoid conflicts in each affected file.

10:20 Changeset [35486] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-31 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20224

Include the Writing Direction sub-menu in the context menu of all
platforms but GTK. This fixes a regression introduced by revision
34426.

10:14 Changeset [35485] by beidson@apple.com
  • 9 edits in trunk

WebCore:

2008-07-31 Brady Eidson <beidson@apple.com>

Reviewed by Adam and Hyatt

Fix for <rdar://problem/6099748>

Adds a "don't enforce CSS mime type in strict mode" quirk for iWeb 2

  • WebCore.base.exp:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::canUseSheet):
  • loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::sheetText):
  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setEnforceCSSMIMETypeInStrictMode):

  • page/Settings.h: (WebCore::Settings::enforceCSSMIMETypeInStrictMode):

WebKit/mac:

2008-07-30 Brady Eidson <beidson@apple.com>

Reviewed by Adam and Hyatt

Fix for <rdar://problem/6099748>

  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" quirk when running under iWeb 2
09:56 Changeset [35484] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Fix Windows build.


  • kjs/collector.h:
  • wtf/FastMalloc.cpp:
08:11 Changeset [35483] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-07-31 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

Added the ability to get SQLite headers and source from the location·
specified via the SQLITE3SRCDIR environtment variable.

08:10 Changeset [35482] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2008-07-31 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.

08:03 Changeset [35481] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-31 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

Make sure edit actions get updated when the contents change.

08:00 Changeset [35480] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-31 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

Add simple edit test abilities to QtLauncher.

08:00 Changeset [35479] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-31 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon.

Bug 20170: [Qt] missing namespace defines in JavaScriptCore.pro
<https://bugs.webkit.org/show_bug.cgi?id=20170>

05:19 Changeset [35478] by ap@webkit.org
  • 102 edits
    5 deletes in trunk

Rubber-stamped by Maciej.

Eliminate JSLock (it was already disabled, removing the stub implementaion and all
call sites now).

02:58 Changeset [35477] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Oliver Hunt.

Fix the Mac project to not display "test/" as part of file name for tests.

01:44 Changeset [35476] by eric@webkit.org
  • 10 edits in trunk/JavaScriptCore

Reviewed by Alexey Proskuryakov.

Rename USE(MULTIPLE_THREADS) to ENABLE(JSC_MULTIPLE_THREADS)
to better match the use/enable pattern (and better describe
the usage of the feature in question.)

I also fixed a couple other ENABLE_ macros to be pre-processor
definition override-able to match the rest of the ENABLE_ macros
since it seems to be our convention that build systems can set
ENABLE_ macros in Makefiles.

  • kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::JSGlobalData): (KJS::JSGlobalData::~JSGlobalData):
  • kjs/MathObject.cpp:
  • kjs/collector.cpp: (KJS::Heap::Heap): (KJS::Heap::~Heap): (KJS::allocateBlock): (KJS::Heap::markStackObjectsConservatively):
  • kjs/collector.h:
  • kjs/dtoa.cpp: (KJS::pow5mult): (KJS::rv_alloc): (KJS::freedtoa): (KJS::dtoa):
  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/RefCountedLeakCounter.cpp:
00:37 Changeset [35475] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

Note: See TracTimeline for information about the timeline view.