Timeline


and

08/05/08:

21:33 Changeset [35587] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Fix last timer fix.
Add null check, clear timer using InterlockedExchange.


Reviewed by Alice Liu.

  • platform/win/SharedTimerWin.cpp: (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::stopSharedTimer):
21:29 Changeset [35586] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-08-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron.

  • add fast path for immediates to % operator, as we have for many other math ops


This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
still a 1.4x win on Oliver's prime test.


  • VM/Machine.cpp: (KJS::Machine::privateExecute):
17:57 Changeset [35585] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Fix timer leak, flag.


Timers need to be deleted explicitly, even if they fire.
Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.


Reviewed by Ada Chan.

  • platform/win/SharedTimerWin.cpp: (WebCore::queueTimerProc):
17:39 Changeset [35584] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 20293: Crash in JavaScript codegen for eval("const a;")
<https://bugs.webkit.org/show_bug.cgi?id=20293>

Correctly handle constant declarations in eval code with no initializer.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):

LayoutTests:

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:
17:36 Changeset [35583] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-05 Anders Carlsson <andersca@apple.com>

Pass in the correct class here.


  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
17:19 Changeset [35582] by andersca@apple.com
  • 15 edits in trunk

WebCore:

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread


Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.


  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]):
  • platform/mac/SharedBufferMac.mm: (-[WebCoreSharedBufferData dealloc]):

WebKit/mac:

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/6037398>
ER: Deallocate WebKit objects on the main thread, even if released on secondary thread


Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter dealloc]):
  • History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem dealloc]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary dealloc]):
  • WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand dealloc]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm: (-[WebArchivePrivate dealloc]):
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]):
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView dealloc]):
  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
16:43 Changeset [35581] by andersca@apple.com
  • 9 edits
    2 deletes in trunk

../../../../../../WebCore:

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Move the main thread deallocator here from WebKit.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreObjCExtras.c: (method_getImplementation): (deallocCallback): (WebCoreObjCScheduleDeallocateOnMainThread):
  • platform/mac/WebCoreObjCExtras.h:

../../../../../../WebKit:

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.


  • WebKit.xcodeproj/project.pbxproj:

../../../../../../WebKit/mac:

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.

  • WebView/MainThreadObjectDeallocator.h: Removed.
  • WebView/MainThreadObjectDeallocator.mm: Removed.


  • WebView/WebView.mm: (-[WebView dealloc]): Call WebCoreObjCScheduleDeallocateOnMainThread instead.
16:01 Changeset [35580] by dino@apple.com
  • 16 edits
    4 adds in trunk/WebCore

Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.

https://bugs.webkit.org/show_bug.cgi?id=20088

Reviewed by David Hyatt.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

build config for new files

  • css/tokenizer.flex:
  • css/CSSGrammar.y:
  • css/CSSParser.cpp:
  • css/CSSParser.h:

new @-webkit-keyframes parsing

  • css/CSSPropertyNames.in:

-webkit-animation properties

  • css/CSSRule.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
  • css/StyleBase.h:
  • css/WebKitCSSKeyframeRule.cpp: Added.
  • css/WebKitCSSKeyframeRule.h: Added.
  • css/WebKitCSSKeyframesRule.cpp: Added.
  • css/WebKitCSSKeyframesRule.h: Added.
15:57 Changeset [35579] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Make the main thread object deallocator work with subclasses.


  • WebView/MainThreadObjectDeallocator.h:
  • WebView/MainThreadObjectDeallocator.mm: (deallocCallback): Call the correct dealloc method.


(scheduleDeallocateOnMainThread):
Store both the class and the instance, so we know which dealloc method to call.


  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Schedule deallocation on the main thread.
15:50 Changeset [35578] by adachan@apple.com
  • 4 edits in trunk/WebKit/win

Add a getter for CFURLRequestRef in WebMutableURLRequest.

Reviewed by Anders Carlsson.

  • Interfaces/IWebMutableURLRequestPrivate.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::cfRequest):
  • WebMutableURLRequest.h:
15:35 Changeset [35577] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • LayoutTests fix. Log only to the Inspector because other listeners may not want XHR notifications, including DRT and the numerous tests that don't expect them.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
15:34 Changeset [35576] by timothy@apple.com
  • 5 edits in trunk/WebCore

Makes DOM attribute editing start on double-click to match the styles
pane. Links in attributes are now triggered with a single click again.

https://bugs.webkit.org/show_bug.cgi?id=20281

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Removed some strings.
  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype.onattach): Call _preventFollowingLinksOnDoubleClick. (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick): Renamed from _makeURLsActivateOnModifiedClick. Simply sets the preventFollowOnDoubleClick property on all links. (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed _selectedByCurrentMouseDown. (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved editing code to ondblclick. (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls _startEditing. Removed URL check. (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls _preventFollowingLinksOnDoubleClick.
  • page/inspector/inspector.css: (.editing): Removed the text-decoration property. (.editing, .editing *): Added the text-decoration property here so it removes underlines on child elements.
  • page/inspector/inspector.js: (WebInspector.documentClick): Removed the followOnAltClick code. Added support for preventFollowOnDoubleClick, which sets a timeout on the first click where future clicks will cancel it (double click). If the timeout isn't canceled, the link is followed.
15:10 Changeset [35575] by antti@apple.com
  • 3 edits in trunk/WebCore

2008-08-05 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6112219> Video in standalone media document flashes when navigating away

When navigating out from a page, MediaPlayer was set invisible and then immediately
made visible again causing flicker in some cases.


The document is not yet marked being in page cache when willSaveToCache() is called.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
15:06 Changeset [35574] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix typo
  • page/mac/FrameMac.mm:
15:04 Changeset [35573] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Mark Rowe and Anders Carlsson.

  • fix WebMemorySize() reporting a value capped at 2GB
  • misc/WebKitSystemBits.m: (WebMemorySize): Changed to return the max_mem field, which, unlike memory_size, is not capped at 2GB.
  • WebView/WebView.mm: (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the same as for 2GB, so that behavior on machines that have more than 2GB RAM is not affected by the fix to WebMemorySize().
15:03 Changeset [35572] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • try to fix the 64-bit build
  • page/mac/FrameMac.mm:
14:41 Changeset [35571] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-08-05 Alp Toker <alp@nuanti.com>

Remove leftover mark pragma from r35568 to fix compiler warning spew.

  • rendering/style/RenderStyle.h:
14:33 Changeset [35570] by alp@webkit.org
  • 3 edits in trunk

2008-08-05 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability

Check for the .pc file for Xt instead of hard coding -lXt in the
GNUmakefile.am.

Thanks to Dominik Röttsches for the initial patch.

  • GNUmakefile.am:
  • configure.ac:
12:15 Changeset [35569] by kmccullough@apple.com
  • 1 edit
    1 add in trunk/WebCore

2008-08-05 Kevin McCullough <kmccullough@apple.com>

  • Added a test that checks for several edge cases (see description in test.
  • manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.
12:08 Changeset [35568] by dino@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Dave Hyatt

Add support for CSS Animation properties to RenderStyle
https://bugs.webkit.org/show_bug.cgi?id=20068

(also fix some minor whitespace issues and remove debugging code)

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • page/AnimationController.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
12:07 Changeset [35567] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <kmccullough@apple.com>

  • Updated a manual test to be an accurate description of what it is actually testing.
  • manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:
12:06 Changeset [35566] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Don't invalidate a WebView in the process of being closed when prefs change.


Reviewed by Ada Chan.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
11:00 Changeset [35565] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5732836> XMLHttpRequest: Inspector should show network
activity/XHR in Console (17233)

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
10:48 Changeset [35564] by dino@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix the ChangeLog that was corrupted by r34545.

09:47 Changeset [35563] by timothy@apple.com
  • 2 edits in trunk/WebCore

Makes the selection surround just the name or value that was
double clicked when editing CSS properties. This regressed when
the Inspector started using focus/blur events, since a focus on
a content editable region changes the selection.

https://bugs.webkit.org/show_bug.cgi?id=20280

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Change the selection after calling WebInspector.startEditing, since WebInspector.startEditing will set an initial selection due to a focus event.
09:47 Changeset [35562] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changes the editing behavior in the Inspector to commit changes
when focus is lost, instead of reverting the changes.

https://bugs.webkit.org/show_bug.cgi?id=20279

Reviewed by Adam Roben.

  • page/inspector/inspector.js: (WebInspector.startEditing): Call editingCommitted in blurEventListener instead of editingCancelled.
09:47 Changeset [35561] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the ability to increment/decrement numbers in editable style
properties with the arrow and page keys.

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=20273

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateAll): Updates all properties in the current section, or all sections depending in the argument passed. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Call updateAll instead of having duplicate code. (WebInspector.StylePropertyTreeElement.prototype.startEditing): Assign the list element's handleKeyEvent to editingKeyDown. (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown): Handles the Up and Down arrows keys. Finds the word based on the selection and extracts the number, prefix and suffix. Increments or decrements the number based on the key and modifiers. Replaces the original word with the new value and selects it. Also applies the style so the page reflects the changes live. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Delete the handleKeyEvent and originalCSSText properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): If originalCSSText exists, set the cssText to that value and call updateAll. Otherwise just call updateTitle like before. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Factored out the style applying code to applyStyleText. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Factored out from editingCommitted. Takes an argument that specifies if the interface should be updated when the style is applied.
  • page/inspector/inspector.js: (WebInspector.startEditing): Call the original key handler, if one existed before interrupting key events.
  • page/inspector/utilities.js: (getStyleTextWithShorthands): Helper to return CSS text that preserves shorthand values, since the cssText property only outputs longhands.
09:46 Changeset [35560] by timothy@apple.com
  • 4 edits in trunk/WebCore

Factors out the TextPrompt.scanBackwards function into a generic
helper function on the Node prototype, named rangeOfWord.

Reviewed by Adam Roben.

  • page/inspector/Console.js: (WebInspector.Console.prototype.completions): Use rangeOfWord.
  • page/inspector/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): Ditto. (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
  • page/inspector/utilities.js: (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards, and added a direction argument allowing scanning forward, backward or both directions from the offset.
09:46 Changeset [35559] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where the property toggle button would not be hidden
during editing.

Reviewed by Adam Roben.

  • page/inspector/inspector.css: (li.editing .swatch, li.editing .enabled-button): Make the display !important, since a more specific rule for .enabledbutton overrides display.
06:40 Changeset [35558] by vestbo@webkit.org
  • 4 edits in trunk/WebKit/qt

2008-08-05 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Move event handling of the return-key from EditorClientQt to QWebPage.

https://bugs.webkit.org/show_bug.cgi?id=20191

This is a first step in refactoring the big switch block
in EditorClientQt::handleKeyboardEvent to using WebActions
instead.

The new logic uses two new StandardKeys from QKeySequence:

  • InsertParagraphSeparator
  • InsertLineSeparator

Which translate to the commands InsertNewline and InsertLineBreak
respectivly. On Windows/X11 pressing the shift modifier will invoke
the latter action. For Mac this is triggered by pressing the meta
modifier (Ctrl).

Initial patch by: Erik Bunce

05:51 S60CheckoutAndBuild edited by kvmayank@gmail.com
(diff)
04:00 Changeset [35557] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Roll out r35555 because of correctness issues.

JavaScriptCore:

  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

  • fast/js/mod-crash-expected.txt: Added.
  • fast/js/mod-crash.html: Added.
  • fast/js/resources/mod-crash.js: Added.
00:40 Changeset [35556] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • remove redundant #imports from FrameMac.mm
  • page/mac/FrameMac.mm:
00:15 Changeset [35555] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-08-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.


  • add fast path for immediates to % operator, as we have for many other math ops


0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):

08/04/08:

23:03 Changeset [35554] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.2

Versioning.

23:03 Changeset [35553] by mrowe@apple.com
  • 7 edits
    1 add in tags/Safari-6528.0.2/WebKit

Merge r35546 and r35547.

22:13 Changeset [35552] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2008-08-04 Alice Liu <alice.liu@apple.com>

Reviewed by Steve Falkenburg.

Fix CFDictionary leak

  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Write): m_dictionary is a RetainPtr and should adopt the CF type created
21:09 Changeset [35551] by mitz@apple.com
  • 5 edits in trunk

WebCore:

2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Corrected offsetTop for table cells by subtracting borderTopExtra

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop):

LayoutTests:

2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Tests for offsetTop of table cells updated so that they don't include borderExtraTop

  • fast/dom/Element/offsetTop-table-cell-expected.txt:
  • fast/dom/Element/offsetTop-table-cell.html:
20:58 Changeset [35550] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

2008-08-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Fix typo in Skipped lists.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
20:19 Changeset [35549] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.2

New tag.

20:16 Changeset [35548] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

19:02 Changeset [35547] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.

Reviewed by Kevin Decker.

19:02 Changeset [35546] by mrowe@apple.com
  • 4 edits
    1 add in trunk/WebKit

Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.

Reviewed by Darin Adler.

18:54 Changeset [35545] by dino@apple.com
  • 28 edits
    3 adds in trunk

2008-08-04 Dean Jackson <dino@apple.com>

Reviewed by Dave Hyatt.

Improve AnimationController
https://bugs.webkit.org/show_bug.cgi?id=19938

  • Transition class is now called Animation
  • new state-based AnimationController that can support CSS Animations
  • add support for -webkit-transition-delay
  • remove -webkit-transition-repeat-count (since it never existed officially)
  • updates the -webkit-transition shorthand to reflect removing repeat count
  • updates the Transition class so that properties can be shared with animations
  • adds a "now" keyword for -webkit-transition-delay
  • adds a new change type for style (changed by animation)
  • adds new event names (although they are not dispatched yet)
  • makes text stroke and text fill colors returned by RenderStyle const

Tests:

  • manual-tests/transition-left.html
  • manual-tests/transition-delay.html
  • manual-tests/transition-timing-functions.html
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • css/WebKitCSSTransformValue.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.cpp:
  • dom/EventNames.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • history/CachedPage.cpp:
  • page/AnimationController.cpp:
  • page/AnimationController.h:
  • page/Frame.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderWidget.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
17:39 Changeset [35544] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Antti.

Currently we create two copies of script in the HTMLTokenizer.
One copy gets passed into the javascript engine, the other gets
stored in the DOM. Modify the HTMLParser so that it does not
chunk the string into it's normal 64K chunks for script code,
and modify the HTMLTokenizer to pass that same string into the
JS engine. On some sites (e.g. GMail), which have hundreds of
KB of inline JS, this saves more than a MB of RAM to run the page.
(Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)

  • html\HTMLParser.cpp
  • html\HTMLTokenizer.cpp
16:01 Changeset [35543] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix warning seen in MSVC converting ints to floats.

  • rendering/Length.h: (WebCore::Length::calcFloatValue):
14:24 Changeset [35542] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extra braces left in from JSLock removal.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
13:29 Changeset [35541] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Update skipped lists for renamed tests.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
13:21 Changeset [35540] by weinig@apple.com
  • 6 edits
    14 adds in trunk

WebCore:

2008-08-02 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Implement the Access-control for Cross Site requests
preflight cache.

Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html

http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html
http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.h: (WTF::):
  • platform/KURLHash.h: Added. (WebCore::KURLHash::hash): (WebCore::KURLHash::equal): (WTF::):
  • xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::preflightResultCache): (WebCore::appendPreflightResultCacheEntry): (WebCore::canSkipPrelight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::parseAccessControlAllowList): (WebCore::parseAccessControlMaxAge): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for the Access-control for Cross Site requests
preflight cache.

  • ChangeLog:
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
  • http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
  • http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.
12:59 Changeset [35539] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by hyatt.

Clean up Gradient constructors, make sure all members are initialized.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
12:53 Changeset [35538] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-04 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel

Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.

This broke in r31355 when we stopped returning nil WebResources when there was nil
resource data.

  • WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil when the resource data is null.
09:02 Changeset [35537] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20221

Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.

07:31 Changeset [35536] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

A bunch of improvements to the QtLauncher.

Among others:

  • Unify and unclutter the toolbar, use menu for addition actions
  • Simplify URL edit, just use QLineEdit (no fancy close button etc)
  • Guess the URL from the command line so now we can run ./QtLauncher www.google.com
  • Shortcut keys for most actions
  • Simple autocomplete for the URL edit
  • Actions for zooming, New Window and Close Window
  • Show Format menu only when the content is set to editable
07:03 Changeset [35535] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20198

Allow Copy key sequence to work in non-editable areas.

08/03/08:

19:34 Changeset [35534] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Future-proof fast/cookies/local-file-can-set-cookies.html

Reviewed by Anders Carlsson.

  • fast/cookies/local-file-can-set-cookies.html: Set cookie expiration date 60 seconds into the future instead of a hard-coded date.
02:58 Changeset [35533] by oliver@apple.com
  • 10 edits
    3 adds in trunk

Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement
<https://bugs.webkit.org/show_bug.cgi?id=19359>

Reviewed by Cameron Zwarich

Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node. We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.

01:34 Changeset [35532] by britto@apple.com
  • 13 edits
    8 adds in trunk

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.

<rdar://problem/6118969>
https://bugs.webkit.org/show_bug.cgi?id=19971
Modifiy the cursor interactively when on panning mode (middle click auto scroll)
When the panning is in progress the cursor is an arrow representing the direction of the current scroll

  • page/EventHandler.cpp: (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
  • platform/Cursor.h: Add propotypes for the new cursor functions
  • platform/gtk/CursorGtk.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/mac/CursorMac.mm: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/qt/CursorQt.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/wx/CursorWx.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.


These icons are copies from the resizers in WebCore/Ressources

  • ChangeLog:
  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/panEastCursor.png: Added.
  • WebKit.vcproj/panNorthCursor.png: Added.
  • WebKit.vcproj/panNorthEastCursor.png: Added.
  • WebKit.vcproj/panNorthWestCursor.png: Added.
  • WebKit.vcproj/panSouthCursor.png: Added.
  • WebKit.vcproj/panSouthEastCursor.png: Added.
  • WebKit.vcproj/panSouthWestCursor.png: Added.
  • WebKit.vcproj/panWestCursor.png: Added.
  • WebKit.vcproj/resource.h:
  • WebKitDLL.cpp: (loadResourceIntoBuffer):

08/02/08:

18:47 Changeset [35531] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-02 Rob Gowin <robg@gowin.net>

Reviewed by Eric Seidel.

Added JavaScriptCore/API/WebKitAvailability to list of files in
javascriptcore_h_api.

  • GNUmakefile.am:
15:34 Changeset [35530] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit/mac

2008-08-02 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Update the window gradient offset to match the inspector toolbar's new height.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]):
15:24 Changeset [35529] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Forgot to commit licensing correction in last commit.

14:50 Changeset [35528] by kevino@webkit.org
  • 1 edit
    3 adds in trunk/WebKitTools

Reviewed by Eric Seidel.

Scripts for building a wxWebKit installer for wxPython on Win, eventually will
be used for nightlies.

https://bugs.webkit.org/show_bug.cgi?id=20036

14:33 Changeset [35527] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Move to using constants in accordance with discussions about wx renderer commit.

02:38 Changeset [35526] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-02 Wouter Bolsterlee <wbolster@svn.gnome.org>

Reviewed by Eric Seidel.

  • plugins/gtk/gtk2xtbin.h:

https://bugs.webkit.org/show_bug.cgi?id=20034
Fix malformed Vim modeline.

02:38 Changeset [35525] by jmalonzo@webkit.org
  • 1 edit
    1 delete in trunk/WebKit/gtk

2008-08-02 Christian Dywan <christian@twotoasts.de>

Reviewed by Eric Seidel.

Remove webkit-marshal.list, which was made obsolete in #19742

  • webkit/webkit-marshal.list: Removed.

08/01/08:

23:10 Changeset [35524] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • tweak a comment
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
22:48 ApplicationsGtk edited by alp@atoker.com
Updates (diff)
22:19 Changeset [35523] by jmalonzo@webkit.org
  • 1 edit in trunk/WebKit/gtk/ChangeLog

Forgot to add the reviewer of r35522.

  • WebKit/gtk/ChangeLog:
22:12 Changeset [35522] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-08-01 Wouter Bolsterlee <uws@xs4all.nl>

https://bugs.webkit.org/show_bug.cgi?id=20035
[GTK] Fix return value for webkit_web_view_go_to_back_forward_item()

  • webkit/webkitwebview.cpp:
22:11 Changeset [35521] by jmalonzo@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2008-08-01 Jan Michael Alonzo <jmalonzo@webkit.org>

  • ChangeLog: Fix date of previous commit (r35520)
22:01 Changeset [35520] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-06-17 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=19603
[SOUP] segfault when closing a file using gio

Call client->didFinishLoading() only after releasing all the gio
resources.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
17:29 Changeset [35519] by andersca@apple.com
  • 4 edits in trunk

../../../../../../WebCore:

2008-08-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.


  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):

../../../../../../WebKit/mac:

2008-08-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6120206>
Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.


Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.

  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream wantsAllStreams]):
17:06 Changeset [35518] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

Native rendering implementations for form elements in the wx port.

https://bugs.webkit.org/show_bug.cgi?id=19069

14:50 Changeset [35517] by bdakin@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-01 Beth Dakin <bdakin@apple.com>

Reviewed by Adam Roben.

Fix for <rdar://problem/6119382> Need to hook up WebFrame's
disconnected frame API on Windows.

  • Interfaces/IWebFrame.idl:
  • WebFrame.cpp: (WebFrame::setIsDisconnected):
  • WebFrame.h:
14:32 Changeset [35516] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any form

Reviewed by Darin Adler.

  • COMPropertyBag.h: (COMPropertyBag::QueryInterface): Cast to an appropriate type before assigning into ppvObject.
13:24 Changeset [35515] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-07-30 David Hyatt <hyatt@apple.com>

Improvements to selection drawing.

Clip out floating and positioned objects when drawing selection so
that there is no "double painting" of selection when the selection spans both the space behind the positioned/floating
object and the positioned/floating object itself. Improves most Web pages.

Do not paint left/right selection gaps if the object's edge is already outside the boundary (at a negative
position). Significantly improves the look of selections on digg.com, since it uses giant negative text-indent.

Reviewed by Dan

Covered by existing selection pixel tests.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): (WebCore::RenderBlock::paintSelection): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
13:23 Changeset [35514] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds the ability to disable individual properties of a CSS rule.
When hovering over a rule, checkboxes show up to the right of all
properties and toggling a checkbox disables/enables the property.
Behind the scenes the property is removed from the rule when disabled,
but still remains in the list and in the computed style. When disabled
the property has a line through it, and is faded in computed style.

<rdar://problem/5712828> Support disabling individual CSS properties
https://bugs.webkit.org/show_bug.cgi?id=14377

Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Include the inline style when it also has disabled properties. Call deleteDisabledProperty for any property that is in the style, since it might have been added back by the page. Remember all disabled properties so they show up in computed style. (deleteDisabledProperty): Helper function to delete all the right properties that track disabled properties. (WebInspector.StylePropertiesSection): Add the computed-style class when the section is Computed Style. (WebInspector.StylePropertiesSection.prototype.onpopulate): Include disabled properties. (WebInspector.StylePropertyTreeElement): Added a disabled argument. (WebInspector.StylePropertyTreeElement.prototype.get/set disabled): Sets the _disabled property and calls updateState. (WebInspector.StylePropertyTreeElement.prototype.get priority): Return the priority of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.get value): Return the value of enabled or disabled properties. (WebInspector.StylePropertyTreeElement.prototype.updateTitle): Use the priority and value getter. Append the checkbox for root elements of an editable section. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Add or remove properties from the rule and remember removed ones by adding three objects to the style: disabledProperties, disabledPropertyValues and disabledPropertyPriorities. The disabledProperties object will include all longhand properties of a shorthand for use by Computed Style. (WebInspector.StylePropertyTreeElement.prototype.updateState): Use the value getter. Update the disabled state.
  • page/inspector/inspector.css:
  • page/inspector/utilities.js: (Object.hasProperties): Added. Helper to test if an object has any properties.
12:23 Changeset [35513] by andersca@apple.com
  • 13 edits in trunk

../../../../../../WebCore:

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.


  • WebCore.base.exp: Export ApplicationCacheStorage::storeCopyOfCache.


  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::~ApplicationCache): Don't call cacheDestroyed for our special "copy" groups.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Add a "copy" flag to the ApplicationCacheGroup constructor. A "copied" group is special and can only be stored to disk.


  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::isCopy): New getter.


  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Make sure to set the storageID when storing an application resource.


(WebCore::ApplicationCacheStorage::storeNewestCache):
Change this to return true/false depending on whether storing the cache succeeded or not.


(WebCore::ApplicationCacheStorage::storeCopyOfCache):
New method which stores a given cache in a new storage (database file).


  • loader/appcache/ApplicationCacheStorage.h: Add new methods.

../../../../../../WebKit/mac:

2008-07-31 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

<rdar://problem/5949410>
Add the ability to transfer a given application cache to a new database.

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]): New method which returns the appopriate cache directory for a given bundle identifier.


  • WebView/WebDataSource.mm: (-[WebDataSource _transferApplicationCache:]): Transfer the application cache.


  • WebView/WebDataSourcePrivate.h:
  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
11:20 Changeset [35512] by aroben@apple.com
  • 2 edits in trunk/WebKitSite

Add a link to the instructions to use Apple's Safari for Windows symbol server

Reviewed by Eric Seidel.

  • building/debug.html:
01:38 Changeset [35511] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Maciej.

Remove JSGlobalData::DataInstance. It was only needed when we had per-thread JSGlobalData
instances.

  • kjs/JSGlobalData.h:
01:06 Changeset [35510] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.1

Versioning.

01:06 Changeset [35509] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.0.1/WebKit/mac

Build fix.

00:53 Changeset [35508] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.1

New tag.

Note: See TracTimeline for information about the timeline view.