21:05 Changeset [35636] by timothy@apple.com

Fix bug numbers.

21:04 Changeset [35635] by mrowe@apple.com

Build fix.

21:04 Changeset [35634] by mrowe@apple.com


20:56 Changeset [35633] by timothy@apple.com

Change highlight time from 300ms to 500ms and fade effect from 1s to 2s


Reviewed by Timothy Hatcher.

  • page/inspector/SourceFrame.js:
20:55 Changeset [35632] by timothy@apple.com

The search is only performed if the field contains more than 3
letters or if Enter is pressed.

Search is now performed through a keyup event.

Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).


Reviewed by Timothy Hatcher.

  • page/inspector/inspector.html: Removed the onsearch and incremental attributes
  • page/inspector/inspector.js:
20:30 Changeset [35631] by mrowe@apple.com

New tag.

17:35 Changeset [35630] by mrowe@apple.com

Merge r35629.

16:38 Changeset [35629] by sfalken@apple.com

Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.

Reviewed by Mark Rowe.

  • DerivedSources.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj:
15:29 Changeset [35628] by kmccullough@apple.com

2008-08-07 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages

  • page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/InspectorController.h:
  • page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
14:55 Changeset [35627] by simon.fraser@apple.com

2008-08-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig

Rename Marquee to RenderMarquee and move to its own file.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLMarqueeElement.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
13:32 Changeset [35626] by mitz@apple.com

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
10:28 Changeset [35625] by kmccullough@apple.com

2008-08-07 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6115981> Start the profiler in Heavy view

  • page/inspector/ProfileView.js:
09:04 Changeset [35624] by sfalken@apple.com

Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.

WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.

Reviewed by Geoff Garen.

  • WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
05:09 Changeset [35623] by jmalonzo@webkit.org

2008-08-07 Alp Toker <alp@nuanti.com>

Reviewed by Eric Seidel.

Add null check in String::fromUTF8()

Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.

  • platform/text/String.cpp: (WebCore::String::fromUTF8):
05:08 Changeset [35622] by jmalonzo@webkit.org

2008-08-07 Kalle Vahlman <zuh@iki.fi>

Reviewed by David Kilzer.

Check for correct flex version to avoid faulty builds

A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it

acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version

  • acinclude.m4:
  • configure.ac:
04:31 Changeset [35621] by hausmann@webkit.org

2008-08-07 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Lars.

Added API tests for QWebPage/QWebFrame based on QTestLib.


20:52 Changeset [35620] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Create a wxWebFrame API to match other ports and to prepare for frames support.
Also fixes a frame leak in wx port on trunk.


17:46 Changeset [35619] by mrowe@apple.com


16:48 Changeset [35618] by kevino@webkit.org

wx build fix after Frame -> ScriptController moves. Also, remove a character which was in an unknown encoding and replace it with an ANSI representation (which the author used for their Bugzilla account too).

16:08 Changeset [35617] by kmccullough@apple.com

2008-08-06 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • Make XHR console message clearer.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
16:07 Changeset [35616] by kmccullough@apple.com

2008-08-06 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • Created a new function to create DOM links from text without converting back and forth from HTML and messing with escaping special characters.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
15:39 Changeset [35615] by eric@webkit.org

Reviewed by hyatt.

Fix a large animation leak found on the buildbot
(m_animations and m_transitions were never deleted)
Drag RenderStyle (kicking and screaming) into the 21st century
of memory management with a little application of OwnPtr.

  • rendering/style/RenderStyle.cpp: (WebCore::FillLayer::cullEmptyLayers): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::contentDataEquivalent): (WebCore::RenderStyle::setContent): (WebCore::BindingURI::BindingURI): (WebCore::RenderStyle::setBoxShadow): (WebCore::ShadowData::ShadowData): (WebCore::RenderStyle::counterDirectives): (WebCore::RenderStyle::accessCounterDirectives): (WebCore::RenderStyle::adjustAnimations): (WebCore::RenderStyle::adjustTransitions): (WebCore::RenderStyle::accessAnimations): (WebCore::RenderStyle::accessTransitions):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::clearAnimations): (WebCore::RenderStyle::clearTransitions):
15:17 Changeset [35614] by beidson@apple.com

2008-08-06 Brady Eidson <beidson@apple.com>

Reviewed by MitzPettel

<rdar://problem/6078543> - Many LocalStorageThreads may be started

The original decision to key LocalStorage sets to PageGroups was a poor one.

It seems a much better solution is to key them to the actual path of on-disk storage,
which also solves all of the avenues that could lead to a boundless number of threads.

In this patch, I am not attempting to completely sever the attachment of LocalStorage
to PageGroups as that would require a more substantial re-working of the lifetime
between pages, groups, and local storage threads.

  • page/PageGroup.cpp: (WebCore::PageGroup::addPage):
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Map paths to LocalStorage objects here. (WebCore::LocalStorage::localStorage): Return the shared LocalStorage object for this path, or create a new one if it doesn't yet exist. (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::~LocalStorage): Add to remove the path->LocalStorage mapping
  • storage/LocalStorage.h:
15:12 Changeset [35613] by bdakin@apple.com

2008-08-06 Beth Dakin <bdakin@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6130724>

Disconnected frames should not be allowed to resize the window.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
14:27 Changeset [35612] by mitz@apple.com

Added bug URLs

14:15 Changeset [35611] by ddkilzer@apple.com


Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com


Reviewed by Eric Seidel.

Test: fast/forms/submit-to-url-fragment.html

The problem was that isFormSubmission was not being set to true in
FrameLoader::loadWithDocumentLoader() when we were actually
submitting a form, causing the page to scroll instead of the form to
be submitted.

The isFormSubmission variable wasn't set to true because a FormState
object was not being created in

The FormState object was not being created because
HTMLFormElement::submit(Event*, bool activateSubmitButton) would
only set FrameLoader::m_formAboutToBeSubmitted to the current form
if there was a "text field" element in the form (type = text,
password, search or isindex).

Thus when FrameLoader::submitForm(const FrameLoadRequest&, Event*)
called FrameLoader::loadFrameRequestWithFormAndValues(), a null
HTMLFormElement pointer would be sent and cause the above failures.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Call new FrameLoader::setFormAboutToBeSubmitted() method outside the for loop so we always set FrameLoader::m_formAboutToBeSubmitted exactly once for any form submission. The FrameLoader::recordFormValue() method is only called with the name/value pair of each text field.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setFormAboutToBeSubmitted): Added method that only sets m_formAboutToBeSubmitted. (WebCore::FrameLoader::recordFormValue): Removed PassRefPtr<HTMLFormElement> argument since this method only sets name/value pairs on m_formValuesAboutToBeSubmitted now. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Create a FormState object as long as submitForm is not null so that other FrameLoader methods know when a form is being submitted.
  • loader/FrameLoader.h:


Bug 20038: REGRESSION (r35151): Can't post comments on flickr.com


Reviewed by Eric Seidel.

  • fast/forms/submit-to-url-fragment-expected.txt: Added.
  • fast/forms/submit-to-url-fragment.html: Added.
13:26 Changeset [35610] by ddkilzer@apple.com

BUILD FIX: Add HTMLPlugInImageElement.cpp to all other build systems

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
13:22 Changeset [35609] by mitz@apple.com
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj: Added PlugInImageElement.*
13:01 Changeset [35608] by eric@webkit.org

Reviewed by darin.

Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.

I've made AccessibilityUIElement a stack object for now. It could be
made RefCounted, but I figured that might be overkill for the moment.
Essentially it's just a RefPtr itself. :)

I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
which was causing additional leaks. :)

I added toAXElement to remove a bunch of copy/paste code.

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (lineForIndexCallback): (boundsForRangeCallback): (childAtIndexCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (getInsertionPointLineNumberCallback): (finalize):
  • DumpRenderTree/AccessibilityUIElement.h: (AccessibilityUIElement::platformUIElement):
  • DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::focusedElement):
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren):
11:47 Changeset [35607] by kmccullough@apple.com

2008-08-06 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim and Darin.

<rdar://problem/6126160> URLs in the console should be clickable.

  • Implemented and now use linkifyString() to parse console messages for URLs.
  • page/inspector/Console.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
10:23 Changeset [35606] by ddkilzer@apple.com


Images using QT plugin do not display correctly


Reviewed by Darin.

Tests: fast/images/embed-image.html


Use RenderImage instead of RenderPartObject for a renderer when
the <embed> tag references an image. Extract common code from
HTMLEmbedElement and HTMLObjectElement into HTMLPlugInImageElement.

  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • html/HTMLEmbedElement.cpp: Cleaned up #include statements. (WebCore::HTMLEmbedElement::HTMLEmbedElement): Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::parseMappedAttribute): Split codeAttr and srcAttr cases. Create or clear HTMLImageLoader as needed for srcAttr. (WebCore::HTMLEmbedElement::rendererIsNeeded): Use HTMLPlugInElement::rendererIsNeeded() for images. (WebCore::HTMLEmbedElement::createRenderer): Create a RenderImage instead of a RenderPartObject for images. (WebCore::HTMLEmbedElement::attach): Create HTMLImageLoader, load image and populate RenderImage for images. (WebCore::HTMLEmbedElement::updateWidget): Don't call RenderPartObject::updateWidget() for images. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added.
  • html/HTMLEmbedElement.h: Removed unneeded namespace and class declarations. Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLEmbedElement::imageSourceAttributeName): Added. (WebCore::HTMLEmbedElement::serviceType): Moved to HTMLPlugInImageElement. (WebCore::HTMLEmbedElement::url): Ditto.
  • html/HTMLObjectElement.cpp: Cleaned up #include statements. (WebCore::HTMLObjectElement::attach): Removed local variable. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement.
  • html/HTMLObjectElement.h: Extend HTMLPlugInImageElement which extends HTMLPlugInElement. (WebCore::HTMLObjectElement::isImageType): Moved to HTMLPlugInImageElement. (WebCore::HTMLObjectElement::serviceType): Ditto. (WebCore::HTMLObjectElement::url): Ditto.
  • html/HTMLPlugInImageElement.cpp: Added. (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::~HTMLPlugInImageElement): Added. (WebCore::HTMLPlugInImageElement::isImageType): Moved from HTMLObjectElement.
  • html/HTMLPlugInImageElement.h: Added. (WebCore::HTMLPlugInImageElement::isImageType): Added from HTMLObjectElement. (WebCore::HTMLPlugInImageElement::serviceType): Ditto. (WebCore::HTMLPlugInImageElement::url): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): Return urlString for embed elements with images.


Images using QT plugin do not display correctly


Reviewed by Darin.

Test images rendered by both embed and object elements.

  • fast/images/embed-image.html: Added.
  • fast/images/object-image.html: Added.
  • platform/mac/fast/images/embed-image-expected.checksum: Added.
  • platform/mac/fast/images/embed-image-expected.png: Added.
  • platform/mac/fast/images/embed-image-expected.txt: Added.
  • platform/mac/fast/images/object-image-expected.checksum: Added.
  • platform/mac/fast/images/object-image-expected.png: Added.
  • platform/mac/fast/images/object-image-expected.txt: Added.
09:33 Changeset [35605] by cfleizach@apple.com

Fix an accessibility layout test that was failing on different platforms

07:50 Changeset [35604] by aroben@apple.com

Try to fix the Windows build bots

  • API/JSBase.cpp: Touch this to force JSC to rebuild and re-copy the WTF headers.
06:30 Changeset [35603] by hausmann@webkit.org

2008-08-06 Benjamin C Meyer <ben@meyerhome.net>

Reviewed by Simon.

During the drag operation only accept the event if the action is not ignore action.

06:02 Changeset [35602] by vestbo@webkit.org

Revert change 35595.

05:46 Changeset [35601] by jmalonzo@webkit.org

2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

RegularExpression::match should not crash when a null string is passed

RegularExpression::match used to pass null subject strings to
jsRegExpExecute causing an ASSERT failure and then a crash.
There is no need to fix also RegularExpression:search and
RegularExpression::searchRev as they just call

  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::match): Return -1 if the string is null.
05:40 Changeset [35600] by jmalonzo@webkit.org

2008-08-06 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Eric Seidel.

[GTK] Makefile rules for the enum GTypes files depend on Makefile
instead of GNUmakefile

The patch committed in revision 34649 added the code needed to
generate GTypes for enums but the makefile rules for
stamp-webkitenumtypes.h and webkitenumtypes.cpp were depending on
Makefile (used by other ports) instead of GNUmakefile.

  • GNUmakefile.am: Depend on GNUmakefile instead of Makefile.
05:35 Changeset [35599] by jmalonzo@webkit.org

2008-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix only

  • bindings/js/ScriptControllerGtk.cpp:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
05:11 Changeset [35598] by eric@webkit.org

Reviewed by Cameron Zwarich.

Fix warnings and errors seen on Qt bot.
Including one correctness fix for ThreadingQt.
According to the Qt 4.4 docs, we were always passing
seconds to "wait()" when we should have been passing

Lots of float <-> int conversion warnings.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
  • dom/Element.cpp: (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
  • loader/CachedImage.cpp: (WebCore::CachedImage::imageRect):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
  • plugins/npapi.cpp:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::intrinsicSizeChanged):
04:46 Changeset [35597] by vestbo@webkit.org

2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix the Qt build due to recent ScriptController refactoring.

04:46 Changeset [35596] by vestbo@webkit.org

Fix non-Mac build.

04:17 Changeset [35595] by vestbo@webkit.org

2008-08-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Fix non-Mac build.

03:50 Changeset [35594] by cwzwarich@webkit.org

2008-08-06 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Darin. Landed by Cameron.

Bug 20272: typo in JavaScriptCore

Correct the documentation for op_not. (typo)
Fix #undef. (typo)

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
03:37 Changeset [35593] by cwzwarich@webkit.org

2008-08-06 Cameron Zwarich <cwzwarich@webkit.org>

Reviewed by Maciej.

Bug 20286: Load constants all at once instead of using op_load

Load constants all at once into temporary registers instead of using
individual instances of op_load.

This is a 2.6% speedup on SunSpider.


  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): (KJS::CodeBlock::mark):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): (KJS::CodeGenerator::newTemporary): (KJS::CodeGenerator::addConstant): (KJS::CodeGenerator::addUnexpectedConstant): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitUnexpectedLoad): (KJS::CodeGenerator::emitNewError):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::Machine::unwindCallFrame): (KJS::Machine::throwException): (KJS::Machine::execute): (KJS::Machine::privateExecute):
  • VM/Machine.h:
  • VM/Opcode.h:
  • VM/RegisterID.h: (KJS::RegisterID::RegisterID): (KJS::RegisterID::makeConstant): (KJS::RegisterID::isTemporary):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing):
  • kjs/Parser.h: (KJS::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): (KJS::BooleanNode::emitCode): (KJS::NumberNode::emitCode): (KJS::StringNode::emitCode): (KJS::ArrayNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteValueNode::emitCode): (KJS::VoidNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ReturnNode::emitCode): (KJS::ScopeNode::ScopeNode): (KJS::ProgramNode::ProgramNode): (KJS::ProgramNode::create): (KJS::EvalNode::EvalNode): (KJS::EvalNode::create): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::FunctionBodyNode::create): (KJS::FunctionBodyNode::emitCode):
  • kjs/nodes.h: (KJS::ScopeNode::neededConstants):


  • fast/js/constant-count-expected.txt: Added.
  • fast/js/constant-count.html: Added.
  • fast/js/deep-recursion-test.html:
  • fast/js/resources/constant-count.js: Added.
03:34 Changeset [35592] by eric@webkit.org

Build fix only, no review.

Attempt to fix the Windows and Qt builds.

  • bindings/js/ScriptControllerWin.cpp: add runtime.h include
  • bindings/js/ScriptControllerQt.cpp: add QWidget include
  • page/win/FrameWin.cpp: remove bogus using namespace
  • plugins/PluginView.cpp: (WebCore::PluginView::bindingInstance): use script()
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): use script() (WebCore::PluginView::~PluginView): use script()
03:17 Changeset [35591] by eric@webkit.org

Build fix only, no review.

Attempt to fix the Linux and --no-svg builds.

  • bindings/js/ScriptController.h: wrap RetainPtr include in PLATFORM(MAC)
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): add missing CSSProperties to switch
03:01 Changeset [35590] by eric@webkit.org

Reviewed by Cameron Zwarich.

Move more methods from Frame into ScriptController

Finally finish more of the work which Darin started long ago
Move a few more Frame methods into ScriptController.
I also took this opportunity to clean up some of the plugin
code as well, and moved some of that into ScriptController.

I removed Frame::clearScriptController() and ScriptController::clear() is now clearWindowShell()

No functional changes, thus no test cases.

  • GNUmakefile.am:
  • WebCore.NPAPI.exp:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::~ScriptController): (WebCore::ScriptController::bindingRootObject): (WebCore::ScriptController::createRootObject): (WebCore::ScriptController::windowScriptNPObject): (WebCore::ScriptController::createScriptObjectForPluginElement): New method. (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::ScriptController::cleanupScriptObjectsForPlugin): (WebCore::ScriptController::clearScriptObjects):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::sourceURL): (WebCore::ScriptController::clearFormerWindow):
  • bindings/js/ScriptControllerGtk.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::Frame::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerMac.mm: Added. (WebCore::ScriptController::createScriptInstanceForWidget): (WebCore::ScriptController::windowScriptObject): (WebCore::ScriptController::clearPlatformScriptObjects): (WebCore::ScriptController::disconnectPlatformScriptObjects): (WebCore::updateRenderingForBindings): (WebCore::ScriptController::initJavaJSBindings):
  • bindings/js/ScriptControllerQt.cpp: Copied from WebCore/page/gtk/FrameGtk.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/js/ScriptControllerWin.cpp: Copied from WebCore/svg/graphics/cg/SVGResourceMaskerCg.cpp. (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/jni/jni_jsobject.mm: (createRootObject):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer): (WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::renderWidgetForJSBindings): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::detach): (WebCore::HTMLPlugInElement::getInstance): (WebCore::HTMLPlugInElement::parseMappedAttribute): (WebCore::HTMLPlugInElement::getNPObject):
  • html/HTMLPlugInElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/gtk/FrameGtk.cpp:
  • page/mac/FrameMac.mm:
  • page/qt/FrameQt.cpp:
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
02:06 Changeset [35589] by eric@webkit.org

Reviewed by Cameron Zwarich.

Speculative fix for an error I keep seeing in my Cygwin build

  • Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
00:09 Changeset [35588] by mitz@apple.com

Reviewed by Mark Rowe.

  • fix an assertion failure in Cache::setCapacities()
  • Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize() to uint64_t.
  • Misc/WebKitSystemBits.m: (WebMemorySize):
  • WebView/WebView.mm: (+[WebView _setCacheModel:]):


21:33 Changeset [35587] by sfalken@apple.com

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Fix last timer fix.
Add null check, clear timer using InterlockedExchange.

Reviewed by Alice Liu.

  • platform/win/SharedTimerWin.cpp: (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::stopSharedTimer):
21:29 Changeset [35586] by mjs@apple.com

2008-08-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron.

  • add fast path for immediates to % operator, as we have for many other math ops

This fixes handling for a 0 divisor relative to the last patch. Only an 0.2% speedup on SunSpider but
still a 1.4x win on Oliver's prime test.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
17:57 Changeset [35585] by sfalken@apple.com

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Fix timer leak, flag.

Timers need to be deleted explicitly, even if they fire.
Also added WT_EXECUTEONLYONCE flag, since this is not a repeating timer.

Reviewed by Ada Chan.

  • platform/win/SharedTimerWin.cpp: (WebCore::queueTimerProc):
17:39 Changeset [35584] by cwzwarich@webkit.org

2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 20293: Crash in JavaScript codegen for eval("const a;")

Correctly handle constant declarations in eval code with no initializer.


  • kjs/nodes.cpp: (KJS::ConstDeclNode::emitCodeSingle):


  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:
17:36 Changeset [35583] by andersca@apple.com

2008-08-05 Anders Carlsson <andersca@apple.com>

Pass in the correct class here.

  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
17:19 Changeset [35582] by andersca@apple.com


2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject dealloc]):
  • platform/mac/SharedBufferMac.mm: (-[WebCoreSharedBufferData dealloc]):


2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

ER: Deallocate WebKit objects on the main thread, even if released on secondary thread

Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.

  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter dealloc]):
  • History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem dealloc]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary dealloc]):
  • WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand dealloc]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm: (-[WebArchivePrivate dealloc]):
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]):
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLView dealloc]):
  • WebView/WebResource.mm: (-[WebResourcePrivate dealloc]):
16:43 Changeset [35581] by andersca@apple.com


2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Move the main thread deallocator here from WebKit.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/WebCoreObjCExtras.c: (method_getImplementation): (deallocCallback): (WebCoreObjCScheduleDeallocateOnMainThread):
  • platform/mac/WebCoreObjCExtras.h:


2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.

  • WebKit.xcodeproj/project.pbxproj:


2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Remove MainThreadObjectDeallocator.{h|mm}.

  • WebView/MainThreadObjectDeallocator.h: Removed.
  • WebView/MainThreadObjectDeallocator.mm: Removed.

  • WebView/WebView.mm: (-[WebView dealloc]): Call WebCoreObjCScheduleDeallocateOnMainThread instead.
16:01 Changeset [35580] by dino@apple.com

Parse CSS Animations, including the new
-webkit-animation properties and the @-webkit-keyframes rule.
Adds some new interfaces for the style rules.


Reviewed by David Hyatt.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

build config for new files

  • css/tokenizer.flex:
  • css/CSSGrammar.y:
  • css/CSSParser.cpp:
  • css/CSSParser.h:

new @-webkit-keyframes parsing

  • css/CSSPropertyNames.in:

-webkit-animation properties

  • css/CSSRule.h:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSValueKeywords.in:
  • css/StyleBase.h:
  • css/WebKitCSSKeyframeRule.cpp: Added.
  • css/WebKitCSSKeyframeRule.h: Added.
  • css/WebKitCSSKeyframesRule.cpp: Added.
  • css/WebKitCSSKeyframesRule.h: Added.
15:57 Changeset [35579] by andersca@apple.com

2008-08-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Make the main thread object deallocator work with subclasses.

  • WebView/MainThreadObjectDeallocator.h:
  • WebView/MainThreadObjectDeallocator.mm: (deallocCallback): Call the correct dealloc method.

Store both the class and the instance, so we know which dealloc method to call.

  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Schedule deallocation on the main thread.
15:50 Changeset [35578] by adachan@apple.com

Add a getter for CFURLRequestRef in WebMutableURLRequest.

Reviewed by Anders Carlsson.

  • Interfaces/IWebMutableURLRequestPrivate.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::cfRequest):
  • WebMutableURLRequest.h:
15:35 Changeset [35577] by kmccullough@apple.com

2008-08-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • LayoutTests fix. Log only to the Inspector because other listeners may not want XHR notifications, including DRT and the numerous tests that don't expect them.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
15:34 Changeset [35576] by timothy@apple.com

Makes DOM attribute editing start on double-click to match the styles
pane. Links in attributes are now triggered with a single click again.


Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Removed some strings.
  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype.onattach): Call _preventFollowingLinksOnDoubleClick. (WebInspector.DOMNodeTreeElement.prototype._preventFollowingLinksOnDoubleClick): Renamed from _makeURLsActivateOnModifiedClick. Simply sets the preventFollowOnDoubleClick property on all links. (WebInspector.DOMNodeTreeElement.prototype.onselect): Removed _selectedByCurrentMouseDown. (WebInspector.DOMNodeTreeElement.prototype.onmousedown): Moved editing code to ondblclick. (WebInspector.DOMNodeTreeElement.prototype.ondblclick): Calls _startEditing. Removed URL check. (WebInspector.DOMNodeTreeElement.prototype._updateTitle): Calls _preventFollowingLinksOnDoubleClick.
  • page/inspector/inspector.css: (.editing): Removed the text-decoration property. (.editing, .editing *): Added the text-decoration property here so it removes underlines on child elements.
  • page/inspector/inspector.js: (WebInspector.documentClick): Removed the followOnAltClick code. Added support for preventFollowOnDoubleClick, which sets a timeout on the first click where future clicks will cancel it (double click). If the timeout isn't canceled, the link is followed.
15:10 Changeset [35575] by antti@apple.com

2008-08-05 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6112219> Video in standalone media document flashes when navigating away

When navigating out from a page, MediaPlayer was set invisible and then immediately
made visible again causing flicker in some cases.

The document is not yet marked being in page cache when willSaveToCache() is called.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer):
15:06 Changeset [35574] by mitz@apple.com
  • fix typo
  • page/mac/FrameMac.mm:
15:04 Changeset [35573] by mitz@apple.com

Reviewed by Mark Rowe and Anders Carlsson.

  • fix WebMemorySize() reporting a value capped at 2GB
  • misc/WebKitSystemBits.m: (WebMemorySize): Changed to return the max_mem field, which, unlike memory_size, is not capped at 2GB.
  • WebView/WebView.mm: (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the same as for 2GB, so that behavior on machines that have more than 2GB RAM is not affected by the fix to WebMemorySize().
15:03 Changeset [35572] by mitz@apple.com
  • try to fix the 64-bit build
  • page/mac/FrameMac.mm:
14:41 Changeset [35571] by alp@webkit.org

2008-08-05 Alp Toker <alp@nuanti.com>

Remove leftover mark pragma from r35568 to fix compiler warning spew.

  • rendering/style/RenderStyle.h:
14:33 Changeset [35570] by alp@webkit.org

2008-08-05 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

[gtk] ./configure doesn't check for x toolkit availability

Check for the .pc file for Xt instead of hard coding -lXt in the

Thanks to Dominik Röttsches for the initial patch.

  • GNUmakefile.am:
  • configure.ac:
12:15 Changeset [35569] by kmccullough@apple.com

2008-08-05 Kevin McCullough <kmccullough@apple.com>

  • Added a test that checks for several edge cases (see description in test.
  • manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Added.
12:08 Changeset [35568] by dino@apple.com

Reviewed by Dave Hyatt

Add support for CSS Animation properties to RenderStyle

(also fix some minor whitespace issues and remove debugging code)

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • page/AnimationController.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
12:07 Changeset [35567] by kmccullough@apple.com

2008-08-05 Kevin McCullough <kmccullough@apple.com>

  • Updated a manual test to be an accurate description of what it is actually testing.
  • manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html:
12:06 Changeset [35566] by sfalken@apple.com

2008-08-05 Steve Falkenburg <sfalken@apple.com>

Don't invalidate a WebView in the process of being closed when prefs change.

Reviewed by Ada Chan.

  • WebView.cpp: (WebView::notifyPreferencesChanged):
11:00 Changeset [35565] by kmccullough@apple.com

2008-08-05 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/5732836> XMLHttpRequest: Inspector should show network
activity/XHR in Console (17233)

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
10:48 Changeset [35564] by dino@apple.com

Fix the ChangeLog that was corrupted by r34545.

09:47 Changeset [35563] by timothy@apple.com

Makes the selection surround just the name or value that was
double clicked when editing CSS properties. This regressed when
the Inspector started using focus/blur events, since a focus on
a content editable region changes the selection.


Reviewed by Adam Roben.

  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.startEditing): Change the selection after calling WebInspector.startEditing, since WebInspector.startEditing will set an initial selection due to a focus event.
09:47 Changeset [35562] by timothy@apple.com

Changes the editing behavior in the Inspector to commit changes
when focus is lost, instead of reverting the changes.


Reviewed by Adam Roben.

  • page/inspector/inspector.js: (WebInspector.startEditing): Call editingCommitted in blurEventListener instead of editingCancelled.
09:47 Changeset [35561] by timothy@apple.com

Adds the ability to increment/decrement numbers in editable style
properties with the arrow and page keys.

Reviewed by Adam Roben.


  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateAll): Updates all properties in the current section, or all sections depending in the argument passed. (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Call updateAll instead of having duplicate code. (WebInspector.StylePropertyTreeElement.prototype.startEditing): Assign the list element's handleKeyEvent to editingKeyDown. (WebInspector.StylePropertyTreeElement.prototype.editingKeyDown): Handles the Up and Down arrows keys. Finds the word based on the selection and extracts the number, prefix and suffix. Increments or decrements the number based on the key and modifiers. Replaces the original word with the new value and selects it. Also applies the style so the page reflects the changes live. (WebInspector.StylePropertyTreeElement.prototype.editingEnded): Delete the handleKeyEvent and originalCSSText properties. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): If originalCSSText exists, set the cssText to that value and call updateAll. Otherwise just call updateTitle like before. (WebInspector.StylePropertyTreeElement.prototype.editingCommitted): Factored out the style applying code to applyStyleText. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Factored out from editingCommitted. Takes an argument that specifies if the interface should be updated when the style is applied.
  • page/inspector/inspector.js: (WebInspector.startEditing): Call the original key handler, if one existed before interrupting key events.
  • page/inspector/utilities.js: (getStyleTextWithShorthands): Helper to return CSS text that preserves shorthand values, since the cssText property only outputs longhands.
09:46 Changeset [35560] by timothy@apple.com

Factors out the TextPrompt.scanBackwards function into a generic
helper function on the Node prototype, named rangeOfWord.

Reviewed by Adam Roben.

  • page/inspector/Console.js: (WebInspector.Console.prototype.completions): Use rangeOfWord.
  • page/inspector/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): Ditto. (WebInspector.TextPrompt.prototype.scanBackwards): Removed.
  • page/inspector/utilities.js: (Node.prototype.rangeOfWord): Added. Copied from TextPrompt.scanBackwards, and added a direction argument allowing scanning forward, backward or both directions from the offset.
09:46 Changeset [35559] by timothy@apple.com

Fixes a bug where the property toggle button would not be hidden
during editing.

Reviewed by Adam Roben.

  • page/inspector/inspector.css: (li.editing .swatch, li.editing .enabled-button): Make the display !important, since a more specific rule for .enabledbutton overrides display.
06:40 Changeset [35558] by vestbo@webkit.org

2008-08-05 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Move event handling of the return-key from EditorClientQt to QWebPage.


This is a first step in refactoring the big switch block
in EditorClientQt::handleKeyboardEvent to using WebActions

The new logic uses two new StandardKeys from QKeySequence:

  • InsertParagraphSeparator
  • InsertLineSeparator

Which translate to the commands InsertNewline and InsertLineBreak
respectivly. On Windows/X11 pressing the shift modifier will invoke
the latter action. For Mac this is triggered by pressing the meta
modifier (Ctrl).

Initial patch by: Erik Bunce

05:51 S60CheckoutAndBuild edited by kvmayank@gmail.com
04:00 Changeset [35557] by cwzwarich@webkit.org

2008-08-05 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Roll out r35555 because of correctness issues.


  • VM/Machine.cpp: (KJS::Machine::privateExecute):


  • fast/js/mod-crash-expected.txt: Added.
  • fast/js/mod-crash.html: Added.
  • fast/js/resources/mod-crash.js: Added.
00:40 Changeset [35556] by mitz@apple.com

Reviewed by Geoffrey Garen.

  • remove redundant #imports from FrameMac.mm
  • page/mac/FrameMac.mm:
00:15 Changeset [35555] by mjs@apple.com

2008-08-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.

  • add fast path for immediates to % operator, as we have for many other math ops

0.6% speedup on SunSpider. 1.4x speedup on a prime testing torture test that Oliver whipped up.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):


23:03 Changeset [35554] by mrowe@apple.com


23:03 Changeset [35553] by mrowe@apple.com

Merge r35546 and r35547.

22:13 Changeset [35552] by alice.liu@apple.com

2008-08-04 Alice Liu <alice.liu@apple.com>

Reviewed by Steve Falkenburg.

Fix CFDictionary leak

  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Write): m_dictionary is a RetainPtr and should adopt the CF type created
21:09 Changeset [35551] by mitz@apple.com


2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Corrected offsetTop for table cells by subtracting borderTopExtra

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop):


2008-08-04 Bernhard Kruepl <kruepl@dbai.tuwien.ac.at>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=19094
Tests for offsetTop of table cells updated so that they don't include borderExtraTop

  • fast/dom/Element/offsetTop-table-cell-expected.txt:
  • fast/dom/Element/offsetTop-table-cell.html:
20:58 Changeset [35550] by weinig@apple.com

2008-08-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Dan Bernstein.

Fix typo in Skipped lists.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
20:19 Changeset [35549] by mrowe@apple.com

New tag.

20:16 Changeset [35548] by mrowe@apple.com

Build fix.

19:02 Changeset [35547] by mrowe@apple.com

Adopt the formal protocols where necessary.
Final part of fix for <rdar://problem/5853147>.

Reviewed by Kevin Decker.

19:02 Changeset [35546] by mrowe@apple.com

Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
Part one of fix for <rdar://problem/5853147>.

Reviewed by Darin Adler.

18:54 Changeset [35545] by dino@apple.com

2008-08-04 Dean Jackson <dino@apple.com>

Reviewed by Dave Hyatt.

Improve AnimationController

  • Transition class is now called Animation
  • new state-based AnimationController that can support CSS Animations
  • add support for -webkit-transition-delay
  • remove -webkit-transition-repeat-count (since it never existed officially)
  • updates the -webkit-transition shorthand to reflect removing repeat count
  • updates the Transition class so that properties can be shared with animations
  • adds a "now" keyword for -webkit-transition-delay
  • adds a new change type for style (changed by animation)
  • adds new event names (although they are not dispatched yet)
  • makes text stroke and text fill colors returned by RenderStyle const


  • manual-tests/transition-left.html
  • manual-tests/transition-delay.html
  • manual-tests/transition-timing-functions.html
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSParser.cpp:
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSValue.h:
  • css/CSSValueKeywords.in:
  • css/WebKitCSSTransformValue.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.cpp:
  • dom/EventNames.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • history/CachedPage.cpp:
  • page/AnimationController.cpp:
  • page/AnimationController.h:
  • page/Frame.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderWidget.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
17:39 Changeset [35544] by eric@webkit.org

Reviewed by Antti.

Currently we create two copies of script in the HTMLTokenizer.
One copy gets passed into the javascript engine, the other gets
stored in the DOM. Modify the HTMLParser so that it does not
chunk the string into it's normal 64K chunks for script code,
and modify the HTMLTokenizer to pass that same string into the
JS engine. On some sites (e.g. GMail), which have hundreds of
KB of inline JS, this saves more than a MB of RAM to run the page.
(Strings use 16bit strings, so 600KB of JS code == 1.2MB of memory)

  • html\HTMLParser.cpp
  • html\HTMLTokenizer.cpp
16:01 Changeset [35543] by eric@webkit.org

Reviewed by Adam Roben.

Fix warning seen in MSVC converting ints to floats.

  • rendering/Length.h: (WebCore::Length::calcFloatValue):
14:24 Changeset [35542] by weinig@apple.com

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extra braces left in from JSLock removal.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection):
13:29 Changeset [35541] by weinig@apple.com

2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Update skipped lists for renamed tests.

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
13:21 Changeset [35540] by weinig@apple.com


2008-08-02 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Implement the Access-control for Cross Site requests
preflight cache.

Tests: http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.h: (WTF::):
  • platform/KURLHash.h: Added. (WebCore::KURLHash::hash): (WebCore::KURLHash::equal): (WTF::):
  • xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::preflightResultCache): (WebCore::appendPreflightResultCacheEntry): (WebCore::canSkipPrelight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::parseAccessControlAllowList): (WebCore::parseAccessControlMaxAge): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):


2008-08-04 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for the Access-control for Cross Site requests
preflight cache.

  • ChangeLog:
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-header.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-invalidation-by-method.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php: Added.
  • http/tests/xmlhttprequest/resources/portabilityLayer.php: Added.
  • http/tests/xmlhttprequest/resources/reset-temp-file.php: Added.
12:59 Changeset [35539] by eric@webkit.org

Reviewed by hyatt.

Clean up Gradient constructors, make sure all members are initialized.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
12:53 Changeset [35538] by beidson@apple.com

2008-08-04 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel

Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.

This broke in r31355 when we stopped returning nil WebResources when there was nil
resource data.

  • WebView/WebResource.mm: (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil when the resource data is null.
09:02 Changeset [35537] by hausmann@webkit.org

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.


Add updateAction() support to ToggleBold, ToggleItalic, and ToggleUnderline.
Add lookup table for mapping web actions to editor commands.

07:31 Changeset [35536] by hausmann@webkit.org

2008-08-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

A bunch of improvements to the QtLauncher.

Among others:

  • Unify and unclutter the toolbar, use menu for addition actions
  • Simplify URL edit, just use QLineEdit (no fancy close button etc)
  • Guess the URL from the command line so now we can run ./QtLauncher www.google.com
  • Shortcut keys for most actions
  • Simple autocomplete for the URL edit
  • Actions for zooming, New Window and Close Window
  • Show Format menu only when the content is set to editable
07:03 Changeset [35535] by hausmann@webkit.org

2008-08-04 Erik Bunce <elbunce@thehive.com>

Reviewed by Simon.


Allow Copy key sequence to work in non-editable areas.


19:34 Changeset [35534] by ddkilzer@apple.com

Future-proof fast/cookies/local-file-can-set-cookies.html

Reviewed by Anders Carlsson.

  • fast/cookies/local-file-can-set-cookies.html: Set cookie expiration date 60 seconds into the future instead of a hard-coded date.
02:58 Changeset [35533] by oliver@apple.com

Bug 19359: JavaScriptCore behaves differently from FF2/3 and IE when handling context in catch statement

Reviewed by Cameron Zwarich

Make our catch behave like Firefox and IE, we do this by using a StaticScopeObject
instead of a generic JSObject for the scope node. We still don't make use of the
fact that we have a static scope inside the catch block, so the internal performance
of the catch block is not improved, even though technically it would be possible to
do so.

01:34 Changeset [35532] by britto@apple.com

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.

Modifiy the cursor interactively when on panning mode (middle click auto scroll)
When the panning is in progress the cursor is an arrow representing the direction of the current scroll

  • page/EventHandler.cpp: (WebCore::EventHandler::autoscrollTimerFired): Before each scroll we actualize the cursor to match the current direction (WebCore::EventHandler::setPanScrollCursor): determines the direction of the upcoming scroll. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
  • platform/Cursor.h: Add propotypes for the new cursor functions
  • platform/gtk/CursorGtk.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/mac/CursorMac.mm: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/qt/CursorQt.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/win/CursorWin.cpp: Add specific icons for the panning as windows resizing icons are both sides arrows (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):
  • platform/wx/CursorWx.cpp: to avoid build break (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor):

2008-08-02 Maxime Britto <britto@apple.com>

Reviewed by Eric Seidel.

These icons are copies from the resizers in WebCore/Ressources

  • ChangeLog:
  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/panEastCursor.png: Added.
  • WebKit.vcproj/panNorthCursor.png: Added.
  • WebKit.vcproj/panNorthEastCursor.png: Added.
  • WebKit.vcproj/panNorthWestCursor.png: Added.
  • WebKit.vcproj/panSouthCursor.png: Added.
  • WebKit.vcproj/panSouthEastCursor.png: Added.
  • WebKit.vcproj/panSouthWestCursor.png: Added.
  • WebKit.vcproj/panWestCursor.png: Added.
  • WebKit.vcproj/resource.h:
  • WebKitDLL.cpp: (loadResourceIntoBuffer):
Note: See TracTimeline for information about the timeline view.