Timeline


and

08/11/08:

21:28 Changeset [35678] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=20326

  • page/inspector/StylesSidebarPane.js:
21:20 Changeset [35677] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed the line highlight transition for an easier animation.

Reviewed by Tim Hatcher.

  • page/inspector/SourceFrame.js:
20:57 Changeset [35676] by timothy@apple.com
  • 2 edits in trunk/WebCore

Added support for some Firebug Command Line APIs.

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19867
https://bugs.webkit.org/show_bug.cgi?id=19868
https://bugs.webkit.org/show_bug.cgi?id=19869
https://bugs.webkit.org/show_bug.cgi?id=19875
https://bugs.webkit.org/show_bug.cgi?id=19876
https://bugs.webkit.org/show_bug.cgi?id=19880

  • page/inspector/Console.js: (WebInspector.Console.prototype._evalInInspectedWindow): Create an object on the inspected window that holds the console command line API functions. This object is used in a with statement around the typed expression.
19:55 Changeset [35675] by zimmermann@webkit.org
  • 1 edit
    110 adds in trunk/LayoutTests

Rubber stamped by Oliver.

Add a bunch of new dynamic-updates tests covering SVGLineElement & SVGRadialGradientElement.
No functional changes needed, all work out of the box.

19:22 Changeset [35674] by zimmermann@webkit.org
  • 11 edits
    15 adds in trunk

Reviewed by Antti.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736

JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)

Added tests: svg/custom/svg-modify-currentTranslate.html

svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html

Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html

17:34 Changeset [35673] by beidson@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Brady Eidson <beidson@apple.com>

Reviewed by John and Anders

Fix for <rdar://problem/6141797>

When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.

When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.

The guarantee was a good one and should be restored.

Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.

  • loader/SubstituteResource.h: (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This well help any future subclassers not make this mistake.
  • loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): Return 0 if the data is null.
15:44 Changeset [35672] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2008-08-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.

Test: transitions/interrupted-all-transition.html

  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::AnimationControllerPrivate::blendProperties): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::setTransitionStartTime): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::onAnimationEnd): (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::affectsProperty): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
13:45 Changeset [35671] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • Because console messages have group levels now, newly created messages that do not specify the level lose their message since the number of arguments is wrong.


  • page/inspector/Console.js:
  • page/inspector/Resource.js:
12:52 Changeset [35670] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-08-11 Alp Toker <alp@nuanti.com>

Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.

  • GNUmakefile.am:
11:48 Changeset [35669] by timothy@apple.com
  • 2 edits in trunk/WebCore

Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.

https://bugs.webkit.org/show_bug.cgi?id=20346

Reviewed by Adam Roben.

  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Removed, factored into syntaxHighlightJavascript as an inline function. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Pulled in the _syntaxHighlightJavascriptLine so it will create a closure. Generate the finders before iterating the lines.
11:31 Changeset [35668] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file, too.
11:04 Changeset [35667] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc

Test: fast/css/counters/invalidate-cached-counter-node.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all RenderCounters in :before and :after content.
  • rendering/RenderContainer.h:
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this to match the RenderObject method. (WebCore::RenderCounter::invalidate): Added. Resets the cached CounterNode and invalidates the object's layout and preferred widths. (WebCore::destroyCounterNodeChildren): Added a call to invalidateCounters().
  • rendering/RenderCounter.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::invalidateCounters):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
  • fast/css/counters/invalidate-cached-counter-node.html: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
10:24 Changeset [35666] by dino@apple.com
  • 19 edits
    7 adds in trunk/WebCore

Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337

Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.

Reviewed by Tim Hatcher and Dave Hyatt.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Build configs for new files

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventCustom.cpp:
  • dom/Document.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventTarget.cpp:
  • dom/EventTargetNode.cpp:
  • dom/EventTargetNode.h:
  • html/HTMLElement.cpp:
  • page/AnimationController.cpp:

do all the new event stuff

  • html/HTMLAttributeNames.in:

the onwebkitanimation* and onwebkittransitionend attrs

  • dom/WebKitAnimationEvent.cpp: Added.
  • dom/WebKitAnimationEvent.h: Added.
  • dom/WebKitAnimationEvent.idl: Added.
  • dom/WebKitTransitionEvent.cpp: Added.
  • dom/WebKitTransitionEvent.h: Added.
  • dom/WebKitTransitionEvent.idl: Added.

New files for the events

  • manual-tests/transition-events.html: Added.

New testfile

10:21 Changeset [35665] by aroben@apple.com
  • 5 edits
    2 adds in trunk

Move WTF::notFound into its own header so that it can be used independently of Vector

JavaScriptCore:

Move WTF::notFound into its own header so that it can be used
independently of Vector

Rubberstamped by Darin Adler.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NotFound.h to the project.
  • wtf/NotFound.h: Added. Moved the notFound constant here...
  • wtf/Vector.h: ...from here.

WebCore:

Add a ForwardingHeader for wtf/NotFound.h

Rubberstamped by Darin Adler.

  • ForwardingHeaders/wtf/NotFound.h: Added.
09:53 Changeset [35664] by timothy@apple.com
  • 2 edits
    2 adds in trunk/WebCore

Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.

https://bugs.webkit.org/show_bug.cgi?id=20345

Reviewed by Adam Roben.

  • manual-tests/inspector/resources/script-error.js: Added.
  • manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Check the nodeType and not the nodeName, this is less fragile. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Check if the lastChild is an error bubble, if so remove it before getting the line's textContent. Add the error bubble back at the end.
05:01 Changeset [35663] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
  • kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while sweeping the heap.

08/10/08:

22:07 Changeset [35662] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over three large ChangeLogs.

21:51 Changeset [35661] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • dom/make_names.pl: Removed "using namespace WebCore::*Names" from *ElementFactory.cpp files.
19:17 Changeset [35660] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.

Reviewed by Cameron Zwarich.

  • bindings/js/ScriptControllerGtk.cpp: Fix the logic.
  • bindings/js/ScriptControllerWin.cpp: Ditto.
  • bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
15:36 Changeset [35659] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty

Test: fast/tokenizer/ampersand-in-special-tag.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Changed to only advance lastDecodedEntityPosition if an entity was found and decoded.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty
  • fast/tokenizer/ampersand-in-special-tag-expected.txt: Added.
  • fast/tokenizer/ampersand-in-special-tag.html: Added.
11:21 Changeset [35658] by alp@webkit.org
  • 9 edits
    3 deletes in trunk

2008-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed (and updated) by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=16620
[GTK] Autotools make dist and make check support

Get make dist working.

Note that not all possible configurations have been tested yet.

  • GNUmakefile.am:

2008-08-10 Alp Toker <alp@nuanti.com>

Remove leftover qmake/GTK+ build files.

  • DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
  • GtkLauncher/GtkLauncher.pro: Removed.
03:06 Changeset [35657] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Added same heap debug checks to more code paths.

  • kjs/JSActivation.cpp: (KJS::JSActivation::put): (KJS::JSActivation::putWithAttributes):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::putWithAttributes):
  • kjs/JSObject.h: (KJS::JSObject::putDirect):
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePut): (KJS::JSVariableObject::symbolTablePutWithAttributes):

08/09/08:

22:32 CygwinInstallerPackages created by wilsong@gmail.com
A list of all the packages included in the cygwin installer for Windows …
22:19 BuildingOnWindows edited by wilsong@gmail.com
Adding a link to a new list of all packages included in the cygwin … (diff)
20:11 Changeset [35656] by alp@webkit.org
  • 2 edits in trunk

2008-08-09 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=19045
[gtk] ./configure doesn't check for x toolkit availability

Some old versions of Xt do not provide xt.pc, in this case use
AC_CHECK_LIB to check if the library is installed and then fall back
to using just -lXt.

  • configure.ac:
20:00 Changeset [35655] by alp@webkit.org
  • 2 edits in trunk

2008-08-09 Alp Toker <alp@nuanti.com>

GTK+ build fixes.

Back out r20338 libxslt check (conditional check already exists and
this broke the build).

Make the flex version check a warning rather than fatal to fix the
build bot.

  • configure.ac:
19:03 Changeset [35654] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=20338
[Gtk] Autotools should check for libxslt

Autotools check for libxslt

  • configure.ac:
14:14 Changeset [35653] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Fix some style issues in the sampling tool.

  • VM/SamplingTool.cpp: (KJS::sleepForMicroseconds): (KJS::SamplingTool::dump):
04:00 Changeset [35652] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-08-09 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Revision 35651, despite being a rather trivial change, introduced a
large regression on the regexp-dna SunSpider test. This regression
stemmed from an increase in the size of CodeBlock::dump(). There is
no reason for this method (and several related methods) to be compiled
in non-debug builds with the sampling tool disabled. This patch
conditionally compiles them, reversing the regression on SunSpider.

  • JavaScriptCore.exp:
  • VM/CodeBlock.cpp:
  • VM/CodeBlock.h:
  • VM/Machine.cpp:

08/08/08:

20:56 Changeset [35651] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2008-08-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 20330: JSCore crash loading any filehurricane media page
<https://bugs.webkit.org/show_bug.cgi?id=20330>

Fix a typo in the constant loading patch. Also, add a case for
op_unexpected_load to CodeBlock::dump().

JavaScriptCore:

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::addUnexpectedConstant):

LayoutTests:

  • fast/js/resources/unexpected-constant-crash.js: Added.
  • fast/js/unexpected-constant-crash-expected.txt: Added.
  • fast/js/unexpected-constant-crash.html: Added.
20:37 Changeset [35650] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe

This change reintroduces <https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an unsuccessful workaround for <rdar://problem/5668489>, because invoking layout may change the view hierarchy during the drawing operation, which is not supported on Leopard.
18:05 Changeset [35649] by bdakin@apple.com
  • 4 edits in trunk/WebCore

2008-08-08 Beth Dakin <bdakin@apple.com>

Reviewed by Darin.

This patch makes the findString and markAllMatchesForText functions
work with disconnected frames that are contained within
overflow:hidden blocks.

  • editing/Editor.cpp: (WebCore::Editor::rangeVisibility): (WebCore::Editor::firstVisibleRange): (WebCore::Editor::lastVisibleRange):
  • editing/Editor.h: (WebCore::Editor::):
  • page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
17:15 Changeset [35648] by britto@apple.com
  • 15 edits
    2 adds in trunk

2008-08-08 Maxime Britto <britto@apple.com>

Reviewed by Adele.

Test: fast/events/scroll-to-anchor-in-overflow-hidden.html
https://bugs.webkit.org/show_bug.cgi?id=20270
Jump to an anchor wasn't working when the overflow:hidden CSS attribute was set on the page.

  • WebCore.base.exp:
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent):
  • page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Takes a new parameter "scrollToAnchor" since it's a special case of scroll. It passes this new bool to canBeProgrammaticallyScrolled. (WebCore::RenderLayer::autoscroll):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): If the call is coming from a scrollToAnchor we don't need scrollBars to accept.
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):

2008-08-08 Maxime Britto <britto@apple.com>

Reviewed by Adele.

  • WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]):

2008-08-08 Maxime Britto <britto@apple.com>

Reviewed by Adele.
https://bugs.webkit.org/show_bug.cgi?id=20270
This test is automatic and can also be run manually.

  • fast/events/scroll-to-anchor-in-overflow-hidden-expected.txt: Added.
  • fast/events/scroll-to-anchor-in-overflow-hidden.html: Added.
16:40 Changeset [35647] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-08 Maxime Britto <britto@apple.com>

Reviewed by Adele.

<rdar://problem/6137022>
<https://bugs.webkit.org/show_bug.cgi?id=20331>
REGRESSION(r35177-r35203): Scrolling slowly over a scrollable field scrolls the page instead of the field (20331)

  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): fixed the wrong cast for the wheel delta which was truncated to 0 on slow wheel scrolls.
13:44 Changeset [35646] by dino@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Execute CSS Animations using new AnimationController
https://bugs.webkit.org/show_bug.cgi?id=20119

I still need to file some follow-on bugs that EricS noticed.

Reviewed by Dave Hyatt

Some new tests:

  • manual-tests/animate-duration.html: Added.
  • manual-tests/animate-left.html: Added.
  • manual-tests/animate-none.html: Added.
  • css/CSSStyleSelector.cpp:
  • dom/Document.cpp:
    • don't redo style when page is place into cache
  • page/AnimationController.cpp:
  • page/AnimationController.h:
    • execute the animations
  • rendering/RenderObject.cpp:
  • rendering/style/RenderStyle.h:
    • make border radii const (for blending)
13:25 Changeset [35645] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-08-08 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6136326> JSProfiler: Start/stop profiling button in the
Web Inspector does not match the menu.

  • page/InspectorController.cpp: (WebCore::InspectorController::toggleRecordButton): Toggle the record button in the webInspector. (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • page/InspectorController.h:
  • page/inspector/ProfilesPanel.js: Move the UI part of the record button into its funtion so that it can be called from the Inspector controller.
  • page/inspector/inspector.js:
11:57 Changeset [35644] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-08 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fix.

11:48 Changeset [35643] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-08 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Fix for <rdar://problem/5865504>

This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
But with that same patch, it became possible for a WebResource to fail to initialize.
Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
Lets fix that, shall we?

  • WebView/WebArchive.mm: (-[WebArchive subresources]):
11:21 Changeset [35642] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-08 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6131187> Profiles don't show up immediately when run
with the UI.

  • page/InspectorController.cpp: (WebCore::startProfiling): Added so that the inspector's JS code could call through to the same function used by the Develop menu. This way both can call didFinishAllExecution() which puts the profile in the Web Inspector. (WebCore::stopProfiling): Ditto (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::stopUserInitiatedProfiling): Now calls didFinishAllExecution() to put the profile in the Web Inspector. This should be safe since the UIs shouldn't work if JS is still running.
  • page/inspector/ProfilesPanel.js: Use the new functions.
10:38 Changeset [35641] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/5961260> GDI text: transparent fill color text does not render if it it has a stroke or shadow
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
05:59 Changeset [35640] by jchaffraix@webkit.org
  • 11 edits
    7 adds in branches/XBL2

WebCore:

2008-08-08 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Tests: fast/xbl/xbl-crash-inline.xhtml

fast/xbl/xbl-document-sheets-modification.xhtml
fast/xbl/xbl-element-binding.xhtml

Bug 20212: [XBL] Add full support for element="" attachment

  • Add attributeChanged method to XBLBindingElement to catch "element" changes and update the bindings.
  • Translate "element" attribute to a stylesheet that is added to the bound document's sheets.
  • GNUmakefile.am: Add XBLBindingElement.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Add binding sheets.
  • dom/Document.cpp: (WebCore::Document::~Document): Remove binding sheet information.

(WebCore::Document::recalcStyleSelector): When
recalculating the style selector, remove all the bindings
as the removed sheets would never remove theirs.

(WebCore::Document::addBindingSheet): Update binding manager
information.
(WebCore::Document::removeBindingSheet): Ditto.

  • dom/Document.h:
  • xbl/XBLBindingElement.cpp: Added. (WebCore::XBLBindingElement::XBLBindingElement): (WebCore::XBLBindingElement::attributeChanged): Check for "element" changes and update the cached sheet and the bound element's bindings style sheets.

(WebCore::XBLBindingElement::generateBindingSheet): Create
the style sheet from the "element" attribute.

  • xbl/XBLBindingElement.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBindingSheet): (WebCore::XBLBindingManager::removeBindingSheet): (WebCore::XBLBindingManager::clearBindingSheets): (WebCore::XBLBindingManager::getBindingSheets): All 4 previous methods are used to manage the binding sheets.
  • xbl/XBLBindingManager.h:

LayoutTests:

2008-08-08 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20212: [XBL] Add full support for element="" attachment


  • fast/xbl/xbl-crash-inline-expected.txt: Added.
  • fast/xbl/xbl-crash-inline.xhtml: Added.
  • fast/xbl/xbl-document-sheets-modification-expected.txt: Added.
  • fast/xbl/xbl-document-sheets-modification.xhtml: Added.
  • fast/xbl/xbl-element-binding-expected.txt: Added.
  • fast/xbl/xbl-element-binding.xhtml: Added.


02:48 Changeset [35639] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Improve performance of arithmetic operators

Reviewed by Cameron Zwarich

Added a fast (non-virtual) mechanism to determine if a non-immediate JSValue*
is a JSNumberCell. We then use this to allow improved specialisation in many
arithmetic operators. SunSpider reports a 2.5% progression overall, with greater
than 10% progressions on a number of arithmetic heavy tests.

02:32 Changeset [35638] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-08-08 Adam Treat <treat@kde.org>

Reviewed by Simon.

Return the canonical file path in Qt's listDirectory as WebCore::PluginDatabase
uses this method to retrieve a list of possible plugins. Many linux systems
have nested symbolic links scattered throughout the plugin directories which
resulted in the PluginDatabase loading the same plugin N times depending on
the number of symbolic links.

01:21 Changeset [35637] by jchaffraix@webkit.org
  • 5 edits in branches/XBL2/WebCore

008-08-08 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Re-enable last bits of XBLDocument loading
legacy code.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
  • xbl/XBLDocument.h: (WebCore::XBLDocument::create): Removed adoptRef to match other Document 'create' method as it would lead to refcount churn. Also added missing 'const' in isXBLDocument.

08/07/08:

21:05 Changeset [35636] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug numbers.

21:04 Changeset [35635] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.0.3/WebCore/DerivedSources.cpp

Build fix.

21:04 Changeset [35634] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.0.3

Versioning.

20:56 Changeset [35633] by timothy@apple.com
  • 2 edits in trunk/WebCore

Change highlight time from 300ms to 500ms and fade effect from 1s to 2s

https://bugs.webkit.org/show_bug.cgi?id=17589

Reviewed by Timothy Hatcher.

  • page/inspector/SourceFrame.js:
20:55 Changeset [35632] by timothy@apple.com
  • 3 edits in trunk/WebCore

The search is only performed if the field contains more than 3
letters or if Enter is pressed.

Search is now performed through a keyup event.

Added a WebInspector.lastQuery to remember the last query and not
perform it again (eg. the user hits a modifier key).

https://bugs.webkit.org/show_bug.cgi?id=18548

Reviewed by Timothy Hatcher.

  • page/inspector/inspector.html: Removed the onsearch and incremental attributes
  • page/inspector/inspector.js:
20:30 Changeset [35631] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.0.3

New tag.

17:35 Changeset [35630] by mrowe@apple.com
  • 2 edits
    1 add in tags/Safari-6528.0.2/WebCore

Merge r35629.

16:38 Changeset [35629] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebCore

Compile derived sources through an all-in-one cpp file.
Fixes Windows release build on non-x64 systems by reducing the size of WebCore.lib from 1.5GB to 1GB.


Reviewed by Mark Rowe.

  • DerivedSources.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj:
15:29 Changeset [35628] by kmccullough@apple.com
  • 4 edits in trunk/WebCore

2008-08-07 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5712917> Confusing console error message clear
behavior (16791)
https://bugs.webkit.org/show_bug.cgi?id=16791
<rdar://problem/5831899> The Web Inspector does not correctly clear the
console messages

  • page/InspectorController.cpp: Clear the message so they don't show up in the inspector after it has cleared them. (WebCore::clearMessages): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::windowScriptObjectAvailable):
  • page/InspectorController.h:
  • page/inspector/Console.js: Tell the InspectorController to clear the messages it's holding onto.
14:55 Changeset [35627] by simon.fraser@apple.com
  • 10 edits
    2 adds in trunk/WebCore

2008-08-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig

Rename Marquee to RenderMarquee and move to its own file.
https://bugs.webkit.org/show_bug.cgi?id=20319

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLMarqueeElement.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderMarquee.cpp: Added. (WebCore::RenderMarquee::RenderMarquee): (WebCore::RenderMarquee::marqueeSpeed): (WebCore::RenderMarquee::direction): (WebCore::RenderMarquee::isHorizontal): (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::start): (WebCore::RenderMarquee::suspend): (WebCore::RenderMarquee::stop): (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::updateMarqueeStyle): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderMarquee.h: Added. (WebCore::RenderMarquee::speed): (WebCore::RenderMarquee::reverseDirection): (WebCore::RenderMarquee::setEnd):
13:32 Changeset [35626] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6118816> Initial empty page or bookmarks view window has white strip where vertical scrollbar would be (which vanishes on resize)
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor): If the view has never had a layout with the old zoom factor, then there is no need to explicitly call layout() here.
10:28 Changeset [35625] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-08-07 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6115981> Start the profiler in Heavy view

  • page/inspector/ProfileView.js:
09:04 Changeset [35624] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.


WM_TIMER-based timers can be starved if enough other events are keeping
our message loop busy. This change prevents many backing store deletes from stacking
up in this case.


Reviewed by Geoff Garen.

  • WebView.cpp: (WebView::deleteBackingStore): (WebView::deleteBackingStoreSoon): (WebView::cancelDeleteBackingStoreSoon):
05:09 Changeset [35623] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-07 Alp Toker <alp@nuanti.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20313
Add null check in String::fromUTF8()

Make String::fromUTF8() consistent with other constructors by
returning a null String when the input is null instead of crashing.

  • platform/text/String.cpp: (WebCore::String::fromUTF8):
05:08 Changeset [35622] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-08-07 Kalle Vahlman <zuh@iki.fi>

Reviewed by David Kilzer.

Check for correct flex version to avoid faulty builds

A correct Webkit build requires flex 2.5.33 but autotools build doesn't check for it
https://bugs.webkit.org/show_bug.cgi?id=20253

acinclude.m4: Import AX_COMPARE_VERSION macro
configure.ac: Check for flex version

  • acinclude.m4:
  • configure.ac:
04:31 Changeset [35621] by hausmann@webkit.org
  • 3 edits
    8 adds in trunk

2008-08-07 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Lars.

Added API tests for QWebPage/QWebFrame based on QTestLib.

Note: See TracTimeline for information about the timeline view.