Timeline


and

08/14/08:

23:15 Changeset [35774] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Update cache capacities to match values used on Mac.


Reviewed by Dan Bernstein.

  • WebView.cpp: (WebView::setCacheModel):
22:10 Changeset [35773] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)

17:53 Changeset [35772] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache

Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
17:44 Changeset [35771] by weinig@apple.com
  • 4 edits in trunk/WebKit/win

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Jon Honeycutt.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
  • WebView.h:
16:58 Changeset [35770] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add the bug URL to the ChangeLog.

16:57 Changeset [35769] by timothy@apple.com
  • 2 edits
    1 add in trunk/WebCore

Make Firebug command line API respect predefined variables.

Reviewed by Tim Hatcher.

  • page/inspector/Console.js:
16:45 Changeset [35768] by simon.fraser@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2008-08-14 Simon Fraser <simon.fraser@apple.com>

Fix testcase and add pixel results for testcase in
https://bugs.webkit.org/show_bug.cgi?id=20367

  • platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
  • platform/mac/fast/css/font-face-in-media-rule-expected.txt:
16:33 Changeset [35767] by weinig@apple.com
  • 9 edits in trunk

WebCore:

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.

  • WebCore.base.exp:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
  • html/HTMLTokenizer.h:
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
  • page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):

WebKit/mac:

2008-08-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen and Timothy Hatcher.

Add WebView SPI to set HTMLTokenizer yielding parameters.

  • WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
  • WebView/WebViewPrivate.h:
16:20 Changeset [35766] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Beth.

Move us one step closer to cross-platform svg/graphics code

  • WebCore.xcodeproj/project.pbxproj:
  • html/CanvasStyle.cpp:
  • platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
  • platform/graphics/Color.h:
  • svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
  • svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
16:19 Changeset [35765] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Alexey.

Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
  • html/CanvasStyle.cpp:
  • html/HTMLCanvasElement.cpp:
16:19 Changeset [35764] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Clean up GlyphBuffer.h, removing more #ifdefs

  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
16:19 Changeset [35763] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Clean up AffineTransform.h, removing #ifdefs

  • platform/graphics/AffineTransform.h:
  • platform/graphics/cairo/AffineTransformCairo.cpp:
  • platform/graphics/cg/AffineTransformCG.cpp:
  • platform/graphics/qt/AffineTransformQt.cpp:
  • platform/graphics/wx/AffineTransformWx.cpp:
16:12 Changeset [35762] by mitz@apple.com
  • 4 edits in trunk/WebCore

2008-08-14 Dan Bernstein <mitz@apple.com>

  • fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
16:08 Changeset [35761] by mitz@apple.com
  • 6 edits in trunk/WebCore

2008-08-14 Dan Bernstein <mitz@apple.com>

Reviewed by Brady Eidson.

  • fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
  • platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
  • platform/graphics/ImageSource.h: Added frameSizeAtIndex().
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
16:04 Changeset [35760] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2008-08-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367

Test: fast/css/font-face-in-media-rule.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
15:52 Changeset [35759] by kevino@webkit.org
  • 6 edits in trunk/WebCore

wx build fixes after recent changes to Canvas and Image classes.

12:26 Changeset [35758] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-08-14 Maxime Britto <britto@apple.com>

Reviewed by Sam Weinig.

rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.

  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
12:14 Changeset [35757] by christian@webkit.org
  • 4 edits in trunk/WebCore

Gtk+/ Cairo build fix, patch by Dirk Schulze.

11:11 Changeset [35756] by kmccullough@apple.com
  • 16 edits in trunk

JavaScriptCore:

2008-08-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
  • profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
  • profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
  • profiler/Profile.h: (KJS::Profile::uid):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
  • profiler/ProfileGenerator.h:
  • profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
  • profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
  • profiler/TreeProfile.h:

WebCore:

2008-08-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6115819> Notify of profile in console

  • page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
  • page/InspectorController.h:
  • page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
  • page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
  • page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
10:41 Changeset [35755] by timothy@apple.com
  • 3 edits in trunk/WebCore

Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
09:12 Changeset [35754] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.

https://bugs.webkit.org/show_bug.cgi?id=20376

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
08:07 Changeset [35753] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>

partial Gtk build fix, not reviewed

  • platform/graphics/cairo/PatternCairo.cpp:

08/13/08:

21:49 Changeset [35752] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-08-13 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlson.

Fix style issue.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia):
21:26 Changeset [35751] by slewis@apple.com
  • 2 edits in trunk/WebKit/mac

2008-08-13 Stephanie Lewis <slewis@apple.com>

fix 64bit build

  • WebCoreSupport/WebInspectorClient.mm:
20:43 Changeset [35750] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-08-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
fillGetterProperty, which references a global function pointer,
out-of-line.


.2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
custom property access benchmark for objects with one property.

  • kjs/JSObject.cpp: (KJS::JSObject::fillGetterPropertySlot):
20:16 Changeset [35749] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

20:13 Changeset [35748] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.1

New tag.

20:06 Changeset [35747] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.

19:38 Changeset [35746] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.

19:26 Changeset [35745] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.

19:22 Changeset [35744] by zimmermann@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372

Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.

This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)

As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.

No functional changes yet, as SVGScriptElement doesn't yet use the new base class.

19:17 Changeset [35743] by eric@webkit.org
  • 4 edits in trunk/WebCore

Attempt to fix the Gtk build, no review.

I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/qt/GradientQt.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozWidget):
19:06 Changeset [35742] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

Attempt to fix the windows build, not review.

  • WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
19:03 Changeset [35741] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
18:29 Changeset [35740] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/win/CursorWin.cpp: (WebCore::loadCursorByName):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::paint):
18:24 Changeset [35739] by eric@webkit.org
  • 2 edits in trunk/WebCore

Attempt to fix the Qt build, no review.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::image):
18:21 Changeset [35738] by eric@webkit.org
  • 3 edits in trunk/WebCore

Attempt to fix the Windows build, no review.

  • platform/graphics/win/ImageWin.cpp: (WebCore::Image::loadPlatformResource):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintMissingPluginIcon):
18:15 Changeset [35737] by eric@webkit.org
  • 3 edits in trunk/WebCore

Another attempt to fix the Qt build, no review.

  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/StillImageQt.h:
18:05 Changeset [35736] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Fix mac build, due to change in new code since my patch was written.

  • svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
17:59 Changeset [35735] by eric@webkit.org
  • 3 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Qt build.

  • platform/graphics/qt/ImageBufferQt.cpp:
  • platform/graphics/qt/StillImageQt.h: (WebCore::StillImage::create): (WebCore::StillImage::destroyDecodedData): (WebCore::StillImage::decodedSize):
17:42 Changeset [35734] by eric@webkit.org
  • 2 edits in trunk/WebCore

Build fix only, no review.

Attempt to fix the Qt build.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
17:30 Changeset [35733] by eric@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Sam.

Match HTML5 spec by throwing INVALID_STATE_ERR when
createPattern is called and the HTMLImageElement is not
yet done loading the image (!isComplete)
https://bugs.webkit.org/show_bug.cgi?id=20351

Test: http/misc/canvas-pattern-from-incremental-image.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
17:29 Changeset [35732] by eric@webkit.org
  • 16 edits
    5 adds in trunk/WebCore

Reviewed by Niko.

Split out a Pattern class from CanvasPattern
and remove all the Pattern-related #ifdefs
(This will break non-mac platforms! I will fix them.)
https://bugs.webkit.org/show_bug.cgi?id=20351

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::parseRepetitionType): (WebCore::CanvasPattern::CanvasPattern):
  • html/CanvasPattern.h: (WebCore::CanvasPattern::create): (WebCore::CanvasPattern::pattern): (WebCore::CanvasPattern::originClean):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
  • html/CanvasRenderingContext2D.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern):
17:29 Changeset [35731] by eric@webkit.org
  • 26 edits in trunk/WebCore

Reviewed by Niko.

Make Images RefCounted (and clean up callers)
https://bugs.webkit.org/show_bug.cgi?id=20351

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::createImage):
  • loader/CachedImage.h:
  • loader/icon/IconRecord.cpp: (WebCore::IconRecord::setImageData): (WebCore::IconRecord::loadImageFromResource):
  • loader/icon/IconRecord.h:
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::create):
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/Image.cpp: (WebCore::Image::nullImage):
  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
  • platform/graphics/cg/PDFDocumentImage.h: (WebCore::PDFDocumentImage::create): (WebCore::PDFDocumentImage::destroyDecodedData): (WebCore::PDFDocumentImage::decodedSize):
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource):
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::SVGPaintServerPattern::setup):
  • svg/graphics/cairo/SVGResourceMaskerCairo.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/cg/SVGPaintServerPatternCg.cpp: (WebCore::patternCallback):
  • svg/graphics/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
17:28 Changeset [35730] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Sam.

Remove #ifdefs from CanvasStyle by using platform/Color.h

There are some down-sides to this commit.
This commit limits us to 255 levels of grey for calls like:
context.setStrokeStyle(.37, 1.0)
previously CG might have used up to 32bits to store the grey level
Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.

Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
to RGBA32 (like all the rest of colors in WebCore), thus:
context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32

If this is a problem for Dashboard, we can either roll out this commit
or add a beefier Color abstraction, which can be used internally by GraphicsContext
when keeping state, and then GraphicsContext can grow some additional set* routines
for setting the a grey/float/whatever fill and stroke.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::colorWithOverrideAlpha): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/CanvasStyle.h:
  • platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte): (WebCore::makeRGBA32FromFloats):
  • platform/graphics/Color.h:
16:50 Changeset [35729] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-08-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

Fix for <rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Remove all parameters from the MIME type before checking with the MIME type registry

Tests: media/video-source-type-params.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';' to isSupportedMediaMIMEType()

LayoutTests:

2008-08-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6137931>
https://bugs.webkit.org/show_bug.cgi?id=20360
Add test case for parameters on a <source> element 'type' attribute.

  • media/video-source-type-params-expected.txt: Added.
  • media/video-source-type-params.html: Added.
14:36 Changeset [35728] by bdakin@apple.com
  • 4 edits in trunk/WebCore

2008-08-13 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6141345>

This patch refines findString and markAllMatchesForText functions'
interactions with disconnected frames. They no longer rely on
knowing where a range is relative to the visible region and work
with disconnected frames that contain frames.

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Now returns a bool instead of the visiblity enum. (WebCore::Editor::firstVisibleRange): This now returns the very first visible range in the document. It's no longer dependent on searching forward. (WebCore::Editor::lastVisibleRange): This now returns the very last visible range in the document. It's no longer dependent on searching backwards. (WebCore::Editor::nextVisibleRange): This returns the next visible range in the appropriate direction from the current range.
  • editing/Editor.h:
  • page/Frame.cpp: (WebCore::Frame::findString): (WebCore::Frame::markAllMatchesForText):
13:07 Changeset [35727] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for case-sensitive platforms, like Linux.

13:00 Changeset [35726] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-08-13 Alp Toker <alp@nuanti.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20349
WTF::initializeThreading() fails if threading is already initialized

Fix threading initialization logic to support cases where
g_thread_init() has already been called elsewhere.

Resolves database-related crashers reported in several applications.

  • wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
12:56 Changeset [35725] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=16881
[GTK] PlatformScreenGtk is unimplemented

Original patch by Christian Dywan.

  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
12:42 Changeset [35724] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=20318
SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add

g_idle_add is the same as g_idle_add_full with a priority of
G_PRIORITY_DEFAULT_IDLE, so we can safely use that.

  • platform/gtk/SharedTimerGtk.cpp: (WebCore::setSharedTimerFireTime):
12:03 Changeset [35723] by adachan@apple.com
  • 6 edits in trunk/WebKit/win

Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
content into a device context. Changed WebView::paintDocumentRectToContext()
to call that WebFrame method.

Reviewed by Adam Roben.

  • DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::paintDocumentRectToContext): (WebFrame::frameElement):
  • WebFrame.h:
  • WebView.cpp: (WebView::paintDocumentRectToContext):
11:11 Changeset [35722] by timothy@apple.com
  • 7 edits in trunk

Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.

WebCore:

2008-08-13 Timothy Hatcher <timothy@apple.com>

Changed the InspectorController so it can be notified when the
attached state of the Inspector changes in WebKit.

Reviewed by Kevin McCullough.

  • WebCore.base.exp: Updated the symbol for setWindowVisible.
  • page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Added an attached argument, that defaults to false.Call setAttachedWindow with the attached argument. (WebCore::InspectorController::setAttachedWindow): Call the script version of setAttachedWindow.
  • page/InspectorController.h:
  • page/inspector/inspector.js: (WebInspector.setAttachedWindow): Set the attached property.

WebKit/mac:

2008-08-13 Timothy Hatcher <timothy@apple.com>

Remember the docked state of the Web Inspector, so it can be
reopened docked if it was last docked.

https://bugs.webkit.org/show_bug.cgi?id=14271

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Initialize _shouldAttach to the value stored in the user defaults. If there has never been a value stored, default to being attached. (-[WebInspectorWindowController showWindow:]): Pass the attached state to InspectorController::setWindowVisible.
11:10 Changeset [35721] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Remove the Inspector's WebView for the view hierarchy when closed
while attached. This prevents it from showing in the background
while the page changes.

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close:]): Call removeFromSuperview on the Inspector's WebView if it isn't attached, so it will not be visible when navigating pages while closed.
11:10 Changeset [35720] by timothy@apple.com
  • 6 edits
    1 add in trunk/WebCore

Added a close button to the Inspector's toolbar when docked.

https://bugs.webkit.org/show_bug.cgi?id=14270

Reviewed by Kevin McCullough.

  • page/InspectorController.cpp: (WebCore::closeWindow): Call InspectorController::closeWindow. (WebCore::InspectorController::windowScriptObjectAvailable): Added closeWindow to the script class.
  • page/InspectorController.h:
  • page/inspector/Images/closeButtons.png: Added.
  • page/inspector/inspector.css: Added and changed styles.
  • page/inspector/inspector.html: Added the close button.
  • page/inspector/inspector.js: (WebInspector.loaded): Added click event listener to the close button. (WebInspector.close): Call InspectorController.closeWindow.
11:10 Changeset [35719] by timothy@apple.com
  • 23 edits in trunk

Make the docked Web Inspector resizable.

WebCore:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Make the docked Web Inspector resizable. This is the cross platform
portion of the code. Each InspectorClient needs to implement the
real resize code.

https://bugs.webkit.org/show_bug.cgi?id=14282

Reviewed by Kevin McCullough.

  • loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
  • page/InspectorClient.h: Added setAttachedWindowHeight.
  • page/InspectorController.cpp: (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight on the InspectorController. (WebCore::InspectorController::setAttachedWindowHeight): Call setAttachedWindowHeight on the client. (WebCore::InspectorController::windowScriptObjectAvailable): Added setAttachedWindowHeight to the script class.
  • page/InspectorController.h:
  • page/inspector/inspector.css: Make the cursor on the toolbar be row-resize when docked.
  • page/inspector/inspector.js: (WebInspector.loaded): Always add the toolbarDragStart event listener. (WebInspector.toolbarDragStart): Return early if we are not attached and not on Leopard. Call WebInspector.elementDragStart. (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd. (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight, otherwise call moveByUnrestricted.

WebKit/gtk:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::setAttachedWindowHeight): Call notImplemented().
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Make the docked Web Inspector resizable.

https://bugs.webkit.org/show_bug.cgi?id=14282

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight: on the WebInspectorWindowController. (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:. (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code from showWindow: and generalized to allow being called multiple times. Remembers the last height passed, which is used by showWindow: the next time the Inspector attaches.

WebKit/qt:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::setAttachedWindowHeight): Call notImplemented().
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
  • WebCoreSupport/WebInspectorClient.h:

WebKit/wx:

2008-08-12 Timothy Hatcher <timothy@apple.com>

Add a stub for InspectorClient::setAttachedWindowHeight.

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::setAttachedWindowHeight): Call notImplemented().
  • WebKitSupport/InspectorClientWx.h:
07:32 Changeset [35718] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Use full-page zoom in QtLauncher.

  • QtLauncher/main.cpp: (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::resetZoom): (MainWindow::setupUI):
07:32 Changeset [35717] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix linking with QtWebKit.

  • Api/qwebframe.h: remove non-existing function/property.
06:43 Changeset [35716] by hausmann@webkit.org
  • 9 edits in trunk

WebCore:

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Initialize m_zoomsTextOnly in the Settings constructor.

WebKit/qt:

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Based on patch by Siraj razick <siraj.razick@collabora.co.uk>

https://bugs.webkit.org/show_bug.cgi?id=19125

Added functions to get/set the zoom factor.

Added a QWebFrame/QWebView::zoomFactor as well as a boolean
ZoomTextOnly attribute in QWebSettings.

06:33 Changeset [35715] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
this test hasn't been failing locally for a long time.

  • platform/win/Skipped:
06:31 Changeset [35714] by hausmann@webkit.org
  • 4 edits in trunk

2008-08-13 Brad Hughes <bhughes@trolltech.com>

Reviewed by Simon.

Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux

The latest upgrade of the intel compiler allows us to compile all of
Qt with optimizations enabled (yay!).

06:24 Changeset [35713] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>

Reviewed by Simon.

Fix QtWebKit not displaying content on 403 HTTP responses

Just like with 404 responses also display content with 403, as
used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/

06:16 Changeset [35712] by hausmann@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994

Make the formatting of String::format() locale independent through the use of QString::vsprintf.

LayoutTests:

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Holger.

Adjusted the length-list-parser layout test to compensate for the subtle difference of
dropping a sign for a "negative zero" as a result of the QString::vsprintf use.

05:07 Changeset [35711] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Holger.

Revert r31585 and disable http tests for the Qt build again unless
explicitly enabled.

Running the http tests unfortunately currently still triggers
failures in non-http tests due to side-effects. Disable them by default for
now, for more reliable results.

05:02 Changeset [35710] by hausmann@webkit.org
  • 4 edits in trunk

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Reviewed by Lars.

Fix QWebFrame::setHtml() not setting the new contents immediately.

Added a setter to the DocumentLoader to toggle the deferred loading of the main
resource when it comes from substitute data.

Disable deferred loading of the main resource when we have valid substitute data,
as used by QWebFrame::setHtml.

04:51 Changeset [35709] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt

2008-08-13 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Holger.

Fix QWebPage::isModified().

isModified() would return true after loading a new page or it would continue to
return true after undoing modifications. Fix this by eliminating the
QWebPagePrivate::modified variable and use the undoStack's canUndo() property
instead.

https://bugs.webkit.org/show_bug.cgi?id=19252

04:38 Changeset [35708] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-13 David Boddie <dboddie@trolltech.com>

Reviewed by Simon.

Updated docs with the signal emission behavior of urlChanged()

04:35 Changeset [35707] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix Ctrl+Y to work again when editing text in contextEditable mode.

This fixes regression in LayoutTests/editing/pasteboard/emacs-cntl-y-001.html

02:58 Changeset [35706] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speculative GTK build fix.

02:11 Changeset [35705] by hausmann@webkit.org
  • 4 edits in trunk

2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>

Reviewed by Simon.

Fix encoding of [ and ] in the host part of the URL

Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
doesn't encode [ and ] when they are found in the host part. That is, the
following URL:
http://[::1]/
is valid and should not be reencoded to:
http://%5b::1%5d/

08/12/08:

21:35 Changeset [35704] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-08-12 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

  • platform/mac/Skipped: Add fast/dom/cssTarget-crash.html to the skipped list.
20:17 Changeset [35703] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Add peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )

Reviewed by Geoff Garen

This is a very slight win in sunspider, and a fairly substantial win
in hot code that does if(!...), etc.

15:49 Changeset [35702] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

Not reviewed.

Revert the last SVGLineElement commit. It's not needed, the first run on buildbot showed them as failures
the next build doesn't complain anymore (this was before adjusting the offsets.) No idea what's going on,
but if it's fixed I'm happy.

While I'm at it, regenerate struct-image-02-b.svg (invisible differences) to have a clean baseline.
All SVG pixel test results are accurate on Leopard now.

15:26 Changeset [35701] by zimmermann@webkit.org
  • 3 edits in trunk/LayoutTests

Not reviewed. The last SVGLineElement* fix attempt, fixed 4/8 failing tests.
Trying two variations in two tests to find out the right offset to make the other four tests work on Tiger.

15:18 Changeset [35700] by zimmermann@webkit.org
  • 1 edit
    40 adds in trunk/LayoutTests

Rubber stamped by Eric.
Add new dynamic-update layout tests covering SVGRectElement.

15:13 Changeset [35699] by zimmermann@webkit.org
  • 9 edits in trunk/LayoutTests

Not reviewed. Trying to modify mouseevent target location, to work around known CG/Tiger hit test problem.

14:59 Changeset [35698] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

Reviewed by Sam.
Forgot to include these in my last commit.

14:49 Changeset [35697] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.
If we fail to load an image for an object tag and we no longer believe the object tag points at
an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
fall back content.

Reviewed by Dave Hyatt and Alexey Proskuryakov.

Test: http/tests/misc/object-image-error-with-onload.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):
  • page/Frame.cpp: (WebCore::Frame::Frame):

LayoutTests:

2008-08-12 Mihnea Ovidenie <mihnea@adobe.com>

Test for https://bugs.webkit.org/show_bug.cgi?id=19891
Broken HTML object elements cause de-reference of pointer to freed memory.

Reviewed by Dave Hyatt and Alexey Proskuryakov.

  • http/tests/misc/object-image-error-with-onload-expected.txt: Added.
  • http/tests/misc/object-image-error-with-onload.html: Added.
14:46 Changeset [35696] by zimmermann@webkit.org
  • 84 edits in trunk/LayoutTests

Reviewed by Eric.

Fix typo in most files: "mesage" -> "message".
Remove unused code in SVGTestCase.js

14:18 Changeset [35695] by zimmermann@webkit.org
  • 1 edit
    70 adds in trunk/LayoutTests

Rubber stamped by Eric.

Add new dynamic-update layout tests covering SVGPatternElement.

14:11 Changeset [35694] by zimmermann@webkit.org
  • 13 edits in trunk

Reviewed by Dave.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
Masks are translated, and the mask images are swapped on the y-axis.

Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.

Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.

14:05 Changeset [35693] by zimmermann@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Sam.

Speculative fix for hit testing problems in dynamic-updates/SVGLineElement* on Tiger.
Supposed to fix the hanging tests on the buildbot.

14:00 Changeset [35692] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-08-12 Sam Weinig <sam@webkit.org>

  • fast/dom/Window/window-properties-expected.txt: Update results.
13:54 Changeset [35691] by mitz@apple.com
  • 11 edits in trunk

JavaScriptCore:

  • JavaScriptCore part of <rdar://problem/6121636> Make fast*alloc() abort() on failure and add "try" variants that return NULL on failure.

Reviewed by Darin Adler.

  • JavaScriptCore.exp: Exported tryFastCalloc().
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Removed an ASSERT().
  • kjs/JSArray.cpp: (KJS::JSArray::putSlowCase): Changed to use tryFastRealloc(). (KJS::JSArray::increaseVectorLength): Ditto.
  • kjs/ustring.cpp: (KJS::allocChars): Changed to use tryFastMalloc(). (KJS::reallocChars): Changed to use tryFastRealloc().
  • wtf/FastMalloc.cpp: (WTF::fastZeroedMalloc): Removed null checking of fastMalloc()'s result and removed extra call to InvokeNewHook(). (WTF::tryFastZeroedMalloc): Added. Uses tryFastMalloc(). (WTF::tryFastMalloc): Renamed fastMalloc() to this. (WTF::fastMalloc): Added. This version abort()s if allocation fails. (WTF::tryFastCalloc): Renamed fastCalloc() to this. (WTF::fastCalloc): Added. This version abort()s if allocation fails. (WTF::tryFastRealloc): Renamed fastRealloc() to this. (WTF::fastRealloc): Added. This version abort()s if allocation fails. (WTF::do_malloc): Made this a function template. When the abortOnFailure template parameter is set, the function abort()s on failure to allocate. Otherwise, it sets errno to ENOMEM and returns zero. (WTF::TCMallocStats::fastMalloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastMalloc): Added. Does not abort() on failure. (WTF::TCMallocStats::fastCalloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastCalloc): Added. Does not abort() on failure. (WTF::TCMallocStats::fastRealloc): Defined to abort() on failure. (WTF::TCMallocStats::tryFastRealloc): Added. Does not abort() on failure.
  • wtf/FastMalloc.h: Declared the "try" variants.

WebCore:

  • WebCore part of <rdar://problem/6121636> Make fast*alloc() abort() on failure and add "try" variants that return NULL on failure.

Reviewed by Darin Adler.

  • platform/Arena.cpp: (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s result.
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().
11:27 Changeset [35690] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/frames/frameset-style-recalc.html

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base class implementation after marking for layout.

LayoutTests:

Reviewed by Darin Adler.

  • fast/frames/frameset-style-recalc.html: Added.
  • platform/mac/fast/frames/frameset-style-recalc-expected.checksum: Added.
  • platform/mac/fast/frames/frameset-style-recalc-expected.png: Added.
  • platform/mac/fast/frames/frameset-style-recalc-expected.txt: Added.
10:45 Changeset [35689] by timothy@apple.com
  • 4 edits in trunk/WebKit/mac

Remove unneeded header imports from some Web Inspector files.

Reviewed by Adam Roben.

  • WebCoreSupport/WebInspectorClient.mm:
  • WebInspector/WebInspector.mm:
  • WebInspector/WebNodeHighlightView.m:
10:45 Changeset [35688] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Remove the call to WKNSWindowMakeBottomCornersSquare on the
Web Inspector's window. This isn't needed anymore since the
window style masks used always have square bottom corners.

Reviewed by Adam Roben.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Remove the call to WKNSWindowMakeBottomCornersSquare.
10:45 Changeset [35687] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Make attaching and detaching the Web Inspector instantaneous.
This also preserves the current view, other state, and keeps
the script debugger attached.

https://bugs.webkit.org/show_bug.cgi?id=19301

Reviewed by Adam Roben.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Only call setWindowVisible(false) when not moving windows.
10:13 Changeset [35686] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Export WTFLog in Debug builds

Reviewed by John Sullivan.

  • WebKit.vcproj/WebKit_debug.def:
10:04 Changeset [35685] by mitz@apple.com
  • 19 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden
  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileHidden): (WebCore::FrameView::setShouldUpdateWhileHidden):
  • page/FrameView.h:
  • page/Settings.cpp:
  • page/Settings.h:

WebKit/mac:

Reviewed by John Sullivan.

  • replace -[WebPreferences updatesWhenOffscreen] with -[WebView shouldUpdateWhileHidden]
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileHidden]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView _preferencesChangedNotification:]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView shouldUpdateWhileHidden]): (-[WebView setShouldUpdateWhileHidden:]):
  • WebView/WebViewPrivate.h:
07:58 Changeset [35684] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • bindings/js/JSSVGPODTypeWrapper.h: Align JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's members on 16-byte boundaries to avoid an alignment warning.
07:40 Changeset [35683] by zimmermann@webkit.org
  • 3 edits
    20 adds in trunk/LayoutTests

Rubber stamped by Anders.

Add new dynamic-update layout tests covering SVGCursorElement.

Scale svg/webarchive/resources/green-checker.png to a value < 128x128,
as this is the maximum hardcoded cursor size (fixes manual testing of svg-cursor-subresources.png).

05:01 Changeset [35682] by zimmermann@webkit.org
  • 1 edit
    4 moves
    60 adds in trunk/LayoutTests

Rubber stamped by Oliver.

Add new dynamice-update layout tests covering SVGMaskElement.
Move pixel tests results of SVGMarkerElement* to the right positions, while I'm at it.

04:59 Changeset [35681] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-08-12 Urs Wolfer <uwolfer@kde.org>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20357

Fix crash in QWebPage in case contextMenuEvent has been overwritten
because context menu has the view as parent and thus is deleted too early.

Add testcase for this crash.

03:35 Changeset [35680] by zimmermann@webkit.org
  • 3 edits
    75 adds in trunk

Reviewed by Oliver.

Add new dynamice-update layout tests covering SVGMarkerElement.
Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.

03:27 Changeset [35679] by zimmermann@webkit.org
  • 3 edits
    50 adds in trunk

Reviewed by Oliver.

Add new dynamic-update layout tests covering SVGImageElement.
Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.

08/11/08:

21:28 Changeset [35678] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed Option/Alt-Up or Down in CSS editing when the value is
near zero to jump to the next integer.

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=20326

  • page/inspector/StylesSidebarPane.js:
21:20 Changeset [35677] by timothy@apple.com
  • 2 edits in trunk/WebCore

Changed the line highlight transition for an easier animation.

Reviewed by Tim Hatcher.

  • page/inspector/SourceFrame.js:
20:57 Changeset [35676] by timothy@apple.com
  • 2 edits in trunk/WebCore

Added support for some Firebug Command Line APIs.

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=19867
https://bugs.webkit.org/show_bug.cgi?id=19868
https://bugs.webkit.org/show_bug.cgi?id=19869
https://bugs.webkit.org/show_bug.cgi?id=19875
https://bugs.webkit.org/show_bug.cgi?id=19876
https://bugs.webkit.org/show_bug.cgi?id=19880

  • page/inspector/Console.js: (WebInspector.Console.prototype._evalInInspectedWindow): Create an object on the inspected window that holds the console command line API functions. This object is used in a with statement around the typed expression.
19:55 Changeset [35675] by zimmermann@webkit.org
  • 1 edit
    110 adds in trunk/LayoutTests

Rubber stamped by Oliver.

Add a bunch of new dynamic-updates tests covering SVGLineElement & SVGRadialGradientElement.
No functional changes needed, all work out of the box.

19:22 Changeset [35674] by zimmermann@webkit.org
  • 11 edits
    15 adds in trunk

Reviewed by Antti.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736

JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)

Added tests: svg/custom/svg-modify-currentTranslate.html

svg/custom/tearoffs-with-tearoffs.html
svg/custom/immutable-properties.html

Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html

17:34 Changeset [35673] by beidson@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Brady Eidson <beidson@apple.com>

Reviewed by John and Anders

Fix for <rdar://problem/6141797>

When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
would never have nil data.

When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
semantics with some WebKit applications.

The guarantee was a good one and should be restored.

Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
creates an empty data object in the case of null data for its own purposes.

  • loader/SubstituteResource.h: (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null. This well help any future subclassers not make this mistake.
  • loader/archive/ArchiveResource.cpp: (WebCore::ArchiveResource::create): Return 0 if the data is null.
15:44 Changeset [35672] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2008-08-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=20328
Fix a problem when an 'all' transition transition with more than
one property changing is interrupted, and did some AnimationController
cleanup.

Test: transitions/interrupted-all-transition.html

  • page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::AnimationControllerPrivate::blendProperties): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::setTransitionStartTime): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::onAnimationEnd): (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::affectsProperty): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
13:45 Changeset [35671] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-08-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

  • Because console messages have group levels now, newly created messages that do not specify the level lose their message since the number of arguments is wrong.


  • page/inspector/Console.js:
  • page/inspector/Resource.js:
12:52 Changeset [35670] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-08-11 Alp Toker <alp@nuanti.com>

Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
the opportunity to sort the sources lists.

  • GNUmakefile.am:
11:48 Changeset [35669] by timothy@apple.com
  • 2 edits in trunk/WebCore

Speed up the the JavaScript syntax highlighter by generating
the finders only once per script instead of per line.

https://bugs.webkit.org/show_bug.cgi?id=20346

Reviewed by Adam Roben.

  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Removed, factored into syntaxHighlightJavascript as an inline function. (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Pulled in the _syntaxHighlightJavascriptLine so it will create a closure. Generate the finders before iterating the lines.
11:31 Changeset [35668] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file, too.
11:04 Changeset [35667] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc

Test: fast/css/counters/invalidate-cached-counter-node.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all RenderCounters in :before and :after content.
  • rendering/RenderContainer.h:
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this to match the RenderObject method. (WebCore::RenderCounter::invalidate): Added. Resets the cached CounterNode and invalidates the object's layout and preferred widths. (WebCore::destroyCounterNodeChildren): Added a call to invalidateCounters().
  • rendering/RenderCounter.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::invalidateCounters):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc
  • fast/css/counters/invalidate-cached-counter-node.html: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
  • platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.
10:24 Changeset [35666] by dino@apple.com
  • 19 edits
    7 adds in trunk/WebCore

Implement CSS Animation and Transition Events
https://bugs.webkit.org/show_bug.cgi?id=20337

Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.

Reviewed by Tim Hatcher and Dave Hyatt.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Build configs for new files

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventCustom.cpp:
  • dom/Document.h:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventTarget.cpp:
  • dom/EventTargetNode.cpp:
  • dom/EventTargetNode.h:
  • html/HTMLElement.cpp:
  • page/AnimationController.cpp:

do all the new event stuff

  • html/HTMLAttributeNames.in:

the onwebkitanimation* and onwebkittransitionend attrs

  • dom/WebKitAnimationEvent.cpp: Added.
  • dom/WebKitAnimationEvent.h: Added.
  • dom/WebKitAnimationEvent.idl: Added.
  • dom/WebKitTransitionEvent.cpp: Added.
  • dom/WebKitTransitionEvent.h: Added.
  • dom/WebKitTransitionEvent.idl: Added.

New files for the events

  • manual-tests/transition-events.html: Added.

New testfile

10:21 Changeset [35665] by aroben@apple.com
  • 5 edits
    2 adds in trunk

Move WTF::notFound into its own header so that it can be used independently of Vector

JavaScriptCore:

Move WTF::notFound into its own header so that it can be used
independently of Vector

Rubberstamped by Darin Adler.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NotFound.h to the project.
  • wtf/NotFound.h: Added. Moved the notFound constant here...
  • wtf/Vector.h: ...from here.

WebCore:

Add a ForwardingHeader for wtf/NotFound.h

Rubberstamped by Darin Adler.

  • ForwardingHeaders/wtf/NotFound.h: Added.
09:53 Changeset [35664] by timothy@apple.com
  • 2 edits
    2 adds in trunk/WebCore

Fixes a bug where error bubbles in JavaScript resources would
be clobbered by the syntax highlighter.

https://bugs.webkit.org/show_bug.cgi?id=20345

Reviewed by Adam Roben.

  • manual-tests/inspector/resources/script-error.js: Added.
  • manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype._addMessageToSource): Check the nodeType and not the nodeName, this is less fragile. (WebInspector.SourceFrame.prototype._syntaxHighlightJavascriptLine): Check if the lastChild is an error bubble, if so remove it before getting the line's textContent. Add the error bubble back at the end.
05:01 Changeset [35663] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit

  • API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.
  • kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while sweeping the heap.

08/10/08:

22:07 Changeset [35662] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over three large ChangeLogs.

21:51 Changeset [35661] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • dom/make_names.pl: Removed "using namespace WebCore::*Names" from *ElementFactory.cpp files.
19:17 Changeset [35660] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.

Reviewed by Cameron Zwarich.

  • bindings/js/ScriptControllerGtk.cpp: Fix the logic.
  • bindings/js/ScriptControllerWin.cpp: Ditto.
  • bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.
15:36 Changeset [35659] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty

Test: fast/tokenizer/ampersand-in-special-tag.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): Changed to only advance lastDecodedEntityPosition if an entity was found and decoded.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty
  • fast/tokenizer/ampersand-in-special-tag-expected.txt: Added.
  • fast/tokenizer/ampersand-in-special-tag.html: Added.
11:21 Changeset [35658] by alp@webkit.org
  • 9 edits
    3 deletes in trunk

2008-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed (and updated) by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=16620
[GTK] Autotools make dist and make check support

Get make dist working.

Note that not all possible configurations have been tested yet.

  • GNUmakefile.am:

2008-08-10 Alp Toker <alp@nuanti.com>

Remove leftover qmake/GTK+ build files.

  • DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
  • GtkLauncher/GtkLauncher.pro: Removed.
03:06 Changeset [35657] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

Added same heap debug checks to more code paths.

  • kjs/JSActivation.cpp: (KJS::JSActivation::put): (KJS::JSActivation::putWithAttributes):
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::putWithAttributes):
  • kjs/JSObject.h: (KJS::JSObject::putDirect):
  • kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTablePut): (KJS::JSVariableObject::symbolTablePutWithAttributes):
Note: See TracTimeline for information about the timeline view.