Timeline
Aug 18, 2008:
- 9:39 PM Changeset in webkit [35830] by
-
- 47 edits3 adds in trunk
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
This will make it slightly easier to change the JSImmediate design without
having to touch so many call sites.
SunSpider says this change is a wash (looked like a slight speedup, but not
statistically significant).
- API/JSStringRef.cpp: Removed include of JSType.h.
- API/JSValueRef.cpp: Removed include of JSType.h. (JSValueGetType): Replaced use of JSValue::type() with JSValue::is functions.
- JavaScriptCore.exp: Updated.
- VM/JSPropertyNameIterator.cpp: Removed type() implementation. (KJS::JSPropertyNameIterator::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- VM/JSPropertyNameIterator.h: Ditto.
- VM/Machine.cpp: (KJS::fastIsNumber): Updated for name change. (KJS::fastToInt32): Ditto. (KJS::fastToUInt32): Ditto. (KJS::jsAddSlowCase): Updated toPrimitive caller for change from JSType to PreferredPrimitiveType. (KJS::jsAdd): Replaced calls to JSValue::type() with calls to JSValue::isString(). (KJS::jsTypeStringForValue): Replaced calls to JSValue::type() with multiple calls to JSValue::is -- we could make this a virtual function instead if we want to have faster performance. (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32 to JSImmediate::getTruncatedUInt32 for consistency with other functions. Changed two calls of JSValue::type() to JSValue::isString().
- kjs/GetterSetter.cpp: (KJS::GetterSetter::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType. (KJS::GetterSetter::isGetterSetter): Added.
- kjs/GetterSetter.h:
- kjs/JSCell.cpp: (KJS::JSCell::isString): Added. (KJS::JSCell::isGetterSetter): Added. (KJS::JSCell::isObject): Added.
- kjs/JSCell.h: Eliminated type function. Added isGetterSetter. Made isString and isObject virtual. Changed toPrimitive to take PreferredPrimitiveType argument instead of JSType. (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance. (KJS::JSValue::isGetterSetter): Added. (KJS::JSValue::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- kjs/JSImmediate.h: Removed JSValue::type() and replaced JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32. (KJS::JSImmediate::isEitherImmediate): Added.
- kjs/JSNotAnObject.cpp: (KJS::JSNotAnObject::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- kjs/JSNotAnObject.h: Ditto.
- kjs/JSNumberCell.cpp: (KJS::JSNumberCell::toPrimitive): Ditto.
- kjs/JSNumberCell.h: (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no other "slow" version of this once you have a JSNumberCell, so there's no need for "fast" in the name. It's a feature that this hides the base class toInt32, which does the same job less efficiently (and has an additional ExecState argument). (KJS::JSNumberCell::toUInt32): Ditto.
- kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Use isGetterSetter instead of type. (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType. (KJS::JSObject::defaultValue): Ditto. (KJS::JSObject::defineGetter): Use isGetterSetter. (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::lookupGetter): Ditto. (KJS::JSObject::lookupSetter): Ditto. (KJS::JSObject::toNumber): Use PreferredPrimitiveType. (KJS::JSObject::toString): Ditto. (KJS::JSObject::isObject): Added.
- kjs/JSObject.h: (KJS::JSObject::inherits): Call the isObject from JSCell; it's now hidden by our override of isObject. (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter instead of type. (KJS::JSObject::getOwnPropertySlot): Ditto. (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
- kjs/JSString.cpp: (KJS::JSString::toPrimitive): Use PreferredPrimitiveType. (KJS::JSString::isString): Added.
- kjs/JSString.h: Ditto.
- kjs/JSValue.h: Removed type(), added isGetterSetter(). Added PreferredPrimitiveType enum and used it as the argument for the toPrimitive function. (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
- kjs/collector.cpp: (KJS::typeName): Changed to use JSCell::is functions instead of calling JSCell::type.
- kjs/collector.h: (KJS::Heap::isNumber): Renamed from fastIsNumber.
- kjs/nodes.h: Added now-needed include of JSType, since the type is used here to record types of values in the tree.
- kjs/operations.cpp: (KJS::equal): Rewrote to no longer depend on type(). (KJS::strictEqual): Ditto.
JavaScriptGlue:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- JSUtils.cpp: (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with JSValue::is functions.
- UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot): Ditto. (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument instead of JSType argument.
- UserObjectImp.h: Ditto.
WebCore:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- bridge/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean, since that's never passed.
- bridge/c/c_instance.h: Ditto.
- bridge/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions instead of JSValue::type(). Removed unneeded code to handle "unspecified".
- bridge/jni/jni_instance.cpp: (JavaInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
- bridge/jni/jni_instance.h: Ditto.
- bridge/jni/jni_jsobject.mm: (JavaJSObject::convertValueToJObject): Use JSValue::is functions instead of JSValue::type().
- bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed unused argument.
- bridge/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): Removed unused argument. (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean and another dead code path for unknown types.
- bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed override of type() that caused the fallback object to return "UndefinedType" when there is no invokeUndefinedMethodFromWebScript:withArguments: method defined. That didn't accomplish much, since most checks for undefined don't ever call type().
- bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::defaultValue): Ditto.
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
- bridge/qt/qt_instance.h: Ditto.
- bridge/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): Removed unsed argument.
- bridge/runtime_object.cpp: (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument.
- bridge/runtime_object.h: Ditto.
WebKit/mac:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- WebView/WebView.mm: (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead of a switch on JSValue::type().
LayoutTests:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- added a test since I had to rewrite the == and === operators
- fast/js/equality-expected.txt: Added.
- fast/js/equality.html: Added.
- fast/js/resources/equality.js: Added.
- 5:42 PM Changeset in webkit [35829] by
-
- 2 edits in trunk/WebCore
2008-08-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :
FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.
This patch matches FF3 behavior by disabling every key but the esc key.
- page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped. (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
- 5:20 PM Changeset in webkit [35828] by
-
- 10 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
Test: fast/replaced/max-width-percent.html
Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidth):
- rendering/RenderBox.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcPrefWidths):
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcPrefWidths):
- rendering/RenderVideo.h:
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
- fast/replaced/max-width-percent.html: Added.
- platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
- platform/mac/fast/replaced/max-width-percent-expected.png: Added.
- platform/mac/fast/replaced/max-width-percent-expected.txt: Added.
- 4:08 PM Changeset in webkit [35827] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Make transition_shorthand_parsing.html a text-only test.
- fast/css/transition_shorthand_parsing-expected.txt: Added.
- fast/css/transition_shorthand_parsing.html:
- platform/mac/fast/css/transition_shorthand_parsing-expected.txt:
- 3:47 PM Changeset in webkit [35826] by
-
- 2 edits in trunk/WebCore
2008-08-18 Daniel Macks <dmacks@netspace.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.
- platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::read):
- 3:11 PM Changeset in webkit [35825] by
-
- 3 edits2 adds in trunk
Reviewed by Dave Hyatt
Need to make sure we have an Animation in the AnimationList
before setting the initial value.
https://bugs.webkit.org/show_bug.cgi?id=20408
Test: fast/css/transition_shorthand_parsing.html
- css/CSSStyleSelector.cpp:
- 2:55 PM Changeset in webkit [35824] by
-
- 2 edits in trunk/WebKit/wx
Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.
- 1:53 PM Changeset in webkit [35823] by
-
- 3 edits in trunk/JavaScriptCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
If there are no nodes in a profile all the time should be attributed to
(idle)
- profiler/Profile.cpp: If ther are no nodes make sure we still process the head. (KJS::Profile::forEach):
- profiler/ProfileGenerator.cpp: Remove some useless code. (KJS::ProfileGenerator::stopProfiling):
- 1:53 PM Changeset in webkit [35822] by
-
- 8 edits5 adds in branches/XBL2
WebCore:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20347: [XBL] Add support for DocumentXBL interface
- Add a custom NamedNodeMap for document.bindingsDocument as it is a static map that throws NO_MODIFICATIN_ALLOWED_ERR on modification.
Test: fast/xbl/xbl-bindingDocuments.html
- GNUmakefile.am: Add NamedStaticDocumentMap.cpp.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_bindingDocuments. (WebCore::Document::~Document): Zero m_bindingDocuments. (WebCore::Document::bindingDocuments): Getter method. (WebCore::Document::loadBindingDocument): Stub method as we need an helper class to load bindings. (WebCore::Document::createBindingDocumentsIfNeeded):
- dom/Document.h:
- dom/Document.idl: Add documentXBL interface.
- dom/NamedStaticDocumentMap.cpp: Added. (WebCore::NamedStaticDocumentMap::NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::~NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::getNamedItem): (WebCore::NamedStaticDocumentMap::removeNamedItem): (WebCore::NamedStaticDocumentMap::getNamedItemNS): (WebCore::NamedStaticDocumentMap::removeNamedItemNS): (WebCore::NamedStaticDocumentMap::setNamedItem): (WebCore::NamedStaticDocumentMap::item): (WebCore::NamedStaticDocumentMap::addItem):
- dom/NamedStaticDocumentMap.h: Added. (WebCore::NamedStaticDocumentMap::create): (WebCore::NamedStaticDocumentMap::length): (WebCore::NamedStaticDocumentMap::clear): Custom NamedNodeMap that match the specification.
LayoutTests:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20347: [XBL] Add support for DocumentXBL interface
- fast/xbl/resources/bindingDocuments.js: Added.
- fast/xbl/xbl-bindingDocuments-expected.txt: Added.
- fast/xbl/xbl-bindingDocuments.html: Added.
- 1:21 PM Changeset in webkit [35821] by
-
- 2 edits in trunk/WebCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.
- page/inspector/ProfilesPanel.js:
- 12:55 PM Changeset in webkit [35820] by
-
- 2 edits in trunk/WebCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages
- page/inspector/Console.js:
- 8:54 AM Changeset in webkit [35819] by
-
- 8 edits5 adds in branches/XBL2
WebCore:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20263: [XBL] Add loading code for XBLBinding
Test: fast/xbl/xbl-empty-fragment-loadBinding.html
- GNUmakefile.am: Add XBLBinding.cpp.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- xbl/XBLBinding.cpp: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::~XBLBinding): (WebCore::XBLBinding::setXBLDocument): (WebCore::XBLBinding::getBindingElement):
- xbl/XBLBinding.h: Inherit from CachedResourceClient to use the Cache management. Also added the bound element, the <binding> element as members.
- xbl/XBLBindingManager.cpp: Changed Vector<XBLBinding>* to Vector<XBLBinding*>* as we were taking a pointer to a local value.
(WebCore::XBLBindingManager::addBinding): Ditto.
(WebCore::XBLBindingManager::removeBinding): Ditto.
(WebCore::XBLBindingManager::hasBinding): Ditto.
(WebCore::XBLBindingManager::removeAllBindings): Ditto.
- xbl/XBLBindingManager.h: Ditto.
LayoutTests:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20263: [XBL] Add loading code for XBLBinding
- fast/xbl/resources/xbl-failed-binding.xbl: Added.
- fast/xbl/resources/xbl-passed-binding.xbl: Added.
- fast/xbl/xbl-empty-fragment-loadBinding-expected.txt: Added.
- fast/xbl/xbl-empty-fragment-loadBinding.html: Added.
- 7:54 AM Changeset in webkit [35818] by
-
- 77 edits in trunk/WebKitSite
Upgrade to WordPress 2.6.1.
- 4:20 AM Changeset in webkit [35817] by
-
- 2 edits in trunk/WebCore
2008-08-18 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
- 4:14 AM Changeset in webkit [35816] by
-
- 8 edits in trunk
2008-08-18 Alp Toker <alp@nuanti.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=20350
[GTK] Get DumpRenderTree working
WebKit/gtk:
Add a private function to WebFrame to dump the render tree as required
for the DumpRenderTree testing tool.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
WebKitTools/DumpRenderTree/gtk:
Fixes and enhancements to DumpRenderTree. With these changes, the test
suite can now complete a run producing text and render tree dumps.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dump): (runTest): (webViewLoadFinished): (webViewWindowObjectCleared): (webViewConsoleMessage): (webViewScriptAlert): (webViewScriptPrompt): (webViewScriptConfirm): (webViewTitleChanged): (main):
- DumpRenderTree/gtk/DumpRenderTreeGtk.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList): (LayoutTestController::pathToLocalResource): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (waitToDumpWatchdogFired): (LayoutTestController::windowCount):
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (JSStringCopyUTF8CString): (ScriptItem::invoke):
- 1:09 AM Changeset in webkit [35815] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Make JSGlobalContextRetain/Release actually work.
- API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): Ref/deref global data to give checking for globalData.refCount() some sense.
- API/tests/testapi.c: (main): Added a test for this bug.
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData): While checking for memory leaks, found that JSGlobalData::emptyList has changed to a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.
Aug 17, 2008:
- 8:21 PM Changeset in webkit [35814] by
-
- 3 edits in trunk/WebCore
Complete in scope variables in the Console when paused.
Reviewed by Geoffrey Garen.
- page/inspector/Console.js: (WebInspector.Console.prototype.completions): If the expressionString is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame to get an object that declares all the in scope variables. That way "top level" expressions are completed.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame): Return an object that has all the variables that are in scope for the selected call frame. The value of each property is just true. The return object is useful for quick lookups or auto completion.
- 7:42 PM Changeset in webkit [35813] by
-
- 7 edits in trunk
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Change the counting of constants so that preincrement and predecrement of
const local variables are considered unexpected loads.
- kjs/nodes.cpp: (KJS::PrefixResolveNode::emitCode):
- kjs/nodes.h: (KJS::ScopeNode::neededConstants):
LayoutTests:
- fast/js/deep-recursion-test.html:
- 4:38 PM Changeset in webkit [35812] by
-
- 3 edits3 adds in trunk
<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
<https://bugs.webkit.org/show_bug.cgi?id=20386>
Reviewed by Cameron Zwarich.
This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain. Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind. Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution. This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.
- 2:34 PM Changeset in webkit [35811] by
-
- 2 edits in trunk/WebCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Qt build fix.
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- 2:27 PM Changeset in webkit [35810] by
-
- 5 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 20419: Remove op_jless
<https://bugs.webkit.org/show_bug.cgi?id=20419>
Remove op_jless, which is rarely used now that we have op_loop_if_less.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- 2:18 PM Changeset in webkit [35809] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Dan Bernstein.
Fix a typo in r35807 that is also causing build failures for
non-AllInOne builds.
- kjs/NumberConstructor.cpp:
- 1:28 PM Changeset in webkit [35808] by
-
- 9 edits in trunk
JavaScriptGlue:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- WebKit.xcodeproj/project.pbxproj:
WebKitTools:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [35807] by
-
- 85 edits in trunk
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
SunSpider says no change.
I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
store auxiliary data in a secondary structure.
I changed InternalFunction to store the function's name in the property
map.
I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
JSDOMWindowBaseData could inherit from it safely. (It's a strange design
for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
but that's really our only option, given the size constraint.)
I also added a bunch of compile-time ASSERTs, and removed lots of comments
in JSObject.h because they were often out of date, and they got in the
way of reading what was actually going on.
Also renamed JSArray::getLength to JSArray::length, to match our style
guidelines.
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.
Added a bunch of ASSERTs, to help catch over-sized objects.
WebKit/mac:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
(Updated for JavaScriptCore changes.)
- 12:57 AM Changeset in webkit [35806] by
-
- 10 edits in trunk/JavaScriptCore
2007-08-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Sped up property access for array.length and string.length by adding a
mechanism for returning a temporary value directly instead of returning
a pointer to a function that retrieves the value.
Also removed some unused cruft from PropertySlot.
SunSpider says 0.5% - 1.2% faster.
NOTE: This optimization is not a good idea in general, because it's
actually a pessimization in the case of resolve for assignment,
and it may get in the way of other optimizations in the future.
Aug 16, 2008:
- 10:06 PM Changeset in webkit [35805] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:28 PM Changeset in webkit [35804] by
-
- 3 edits in trunk/WebCore
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Aug 15, 2008:
- 11:53 PM Changeset in webkit [35803] by
-
- 2 edits in trunk/JavaScriptCore
<rdar://problem/6143072> FastMallocZone's enumeration code makes assumptions about handling of remote memory regions that overlap
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Don't directly compare pointers mapped into the local process with
a pointer that has not been mapped. Instead, calculate a local address for the pointer and compare with that.
(WTF::TCMallocStats::FreeObjectFinder::findFreeObjects): Pass in the remote address of the central free list so that it can
be used when calculating local addresses.
(WTF::TCMallocStats::FastMallocZone::enumerate): Ditto.
- 11:48 PM Changeset in webkit [35802] by
-
- 15 edits in trunk
<rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
Rubber-stamped by Geoff Garen.
- 3:58 PM Changeset in webkit [35801] by
-
- 6 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Don't start preloading body resources before the head is complete. This prevents
body preloads from slowing down initial display when there is limited amount
of bandwidth available.
Works by queuing up found body preloads to DocLoader and only issuing them
after document has rendering.
With bandwidth capped to 300kbit/s this speeds up cnn.com initial display by ~25% or 5s
without affecting complete load time.
- html/PreloadScanner.cpp: (WebCore::PreloadScanner::PreloadScanner): (WebCore::PreloadScanner::scanningBody): (WebCore::PreloadScanner::emitTag): (WebCore::PreloadScanner::emitCSSRule):
- html/PreloadScanner.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::preload): (WebCore::DocLoader::checkForPendingPreloads): (WebCore::DocLoader::requestPreload):
- loader/DocLoader.h:
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- 2:08 PM Changeset in webkit [35800] by
-
- 2 edits in trunk/WebCore
Use item's computed style if the render style is 0 before falling back to the <select>'s style.
This way style set on an <hr> within a <select> will be honored.
Reviewed by Dave Hyatt and Dan Bernstein.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle):
- 1:48 PM Changeset in webkit [35799] by
-
- 3 edits in trunk/WebCore
2008-08-15 Antti Koivisto <Antti Koivisto>
Reviewed by Oliver.
Some loader performance tweaks:
- Make stylesheets highest priority instead of scripts. We block script execution on stylesheets. Especially if a stylesheet @imports other stylesheets it is important to get them to the front of the queue to not delay rendering.
- Issue the first resource load for a host immediately even if the resource is low priority. TCP connection setup can take long time when latency is high so it is good to get started early.
- When the document is fully parsed and stylesheets have been loaded there is no need to keep managing the load queues. Issue remaining loads to the network layer.
- loader/loader.cpp: (WebCore::Loader::determinePriority): (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests):
- loader/loader.h:
- 11:35 AM Changeset in webkit [35798] by
-
- 2 edits in trunk/WebCore
Detach the script debugger when the Web Inspector's window closes.
This has always been the intended design, but never fully implemented.
Reviewed by Adam Roben.
- page/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): Call stopDebugging() if the window is no longer visible.
- 11:27 AM Changeset in webkit [35797] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Tim Hatcher.
- update results for console.dir
- fast/dom/Window/window-properties-expected.txt:
- 11:12 AM Changeset in webkit [35796] by
-
- 7 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_UNDOCOMMAND/STACK
- 11:12 AM Changeset in webkit [35795] by
-
- 2 edits in trunk/WebKit/qt
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_STYLE_STYLESHEET
- 11:12 AM Changeset in webkit [35794] by
-
- 2 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_SHORTCUT
- 11:12 AM Changeset in webkit [35793] by
-
- 9 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_CONTEXTMENU
- 11:11 AM Changeset in webkit [35792] by
-
- 7 edits in trunk
2008-08-15 Håvard Wall <hwall@trolltech.com>
Reviewed by Simon.
Fixes: compile with QT_NO_WHEELEVENT
- 11:11 AM Changeset in webkit [35791] by
-
- 3 edits in trunk/WebKit/qt
Håvard Wall <hwall@trolltech.com>
Fixes: compile with QT_NO_PRINTER
- 11:10 AM Changeset in webkit [35790] by
-
- 3 edits in trunk/WebKit/qt
2008-08-15 David Boddie <dboddie@trolltech.com>
Reviewed by Simon.
Doc: Added documentation for default property values.
- 11:10 AM Changeset in webkit [35789] by
-
- 2 edits in trunk/WebKit/qt
David Boddie <dboddie@trolltech.com>
Doc: Renamed snippets that appear in the code directory.
- 10:48 AM Changeset in webkit [35788] by
-
- 7 edits in trunk/WebCore
Fixed Bug 20210: Console groups are incorrect when closing and reopening the Inspector
Reviewed by Tim Hatcher.
- page/Console.cpp: (WebCore::Console::group): (WebCore::Console::groupEnd):
- page/Console.h: (WebCore::): Removed GroupTitleMessageLevel. Added StartGroupMessaageLevel and EndGroupMessageLevel.
- page/InspectorController.cpp: (WebCore::InspectorController::startGroup): Increments group level by one and adds console message with StartGroupMessaageLevel. (WebCore::InspectorController::endGroup): Decrements group level by one and adds console message with EndGroupMessaageLevel.
- page/InspectorController.h:
- page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Creates new ConsoleGroup if the message is StartGroupMessaageLevel. (WebInspector.ConsoleMessage.prototype.toMessageElement): (WebInspector.ConsoleGroup.prototype.addMessage):
- page/inspector/inspector.js:
- 10:35 AM Changeset in webkit [35787] by
-
- 8 edits in trunk/WebCore
Adds support for console.dir to the Inspector
Reviewed by Tim Hatcher.
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::dir):
- page/Console.cpp: (WebCore::Console::dir):
- page/Console.h: Added ObjectMessageLevel.
- page/Console.idl: Added console.dir.
- page/inspector/Console.js: (WebInspector.ConsoleMessage.prototypet.toMessageElement): Creates an ObjectPropertiesSection if the MessageLevel is Object.
- page/inspector/ObjectPropertiesSection.js: "in" operator can't be used on primitive data types.
- page/inspector/inspector.css:
- 10:06 AM Changeset in webkit [35786] by
-
- 2 edits in trunk/WebCore
Adds support for clear() in the Inspector console.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 10:02 AM Changeset in webkit [35785] by
-
- 2 edits in trunk/WebCore
Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
Platform distinction and modifier key matching adjusted
by Daniel Jalkut <jalkut@red-sweater.com>
Bug 16313: text search (find) keybindings should work in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=16313
Reviewed by Tim Hatcher.
- page/inspector/inspector.js: Added a case for the F key
- 9:50 AM Changeset in webkit [35784] by
-
- 2 edits in trunk/WebCore
Fix for error when the string doesn't contain a webkit-profile link.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 9:33 AM Changeset in webkit [35783] by
-
- 3 edits1 add in trunk/WebCore
Fixes two bugs where JavaScript could be executed from the page
while the debugger is paused.
The first issue was JSLazyEventListener not checking the paused
state before parsing the code.
The second issue was with the PageGroup version of
JavaScriptDebugServer::setJavaScriptPaused always passing false
to the Page version of JavaScriptDebugServer::setJavaScriptPaused,
and not the paused argument.
Reviewed by Adam Roben.
- bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Check the paused state of the ScriptController. Return early if paused.
- manual-tests/inspector/debugger-execution-while-paused.html: Added.
- page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Pass the paused argument to the Page version of setJavaScriptPaused.
- 7:55 AM Changeset in webkit [35782] by
-
- 2 edits in trunk/JavaScriptCore
Fix the 64-bit build.
Add extra cast to avoid warnings about loss of precision when casting from
JSValue* to an integer type.
- kjs/JSImmediate.h:
(KJS::JSImmediate::intValue):
(KJS::JSImmediate::uintValue):
- 4:59 AM Changeset in webkit [35781] by
-
- 2 edits in trunk/JavaScriptCore
Still fixing Windows build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added OpaqueJSString to yet another place.
- 4:41 AM Changeset in webkit [35780] by
-
- 1 edit in trunk/JavaScriptCore/kjs/JSImmediate.h
Windows build fix
- 4:14 AM Changeset in webkit [35779] by
-
- 1 edit1 add in trunk/JavaScriptCore
Trying to fix non-Apple builds.
- ForwardingHeaders/JavaScriptCore/OpaqueJSString.h: Added.
- 3:42 AM Changeset in webkit [35778] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Allow JSImmediate to hold 31 bit signed integer immediate values. The low two bits of a
JSValue* are a tag, with the tag value 00 indicating the JSValue* is a pointer to a
JSCell. Non-zero tag values used to indicate that the JSValue* is not a real pointer,
but instead holds an immediate value encoded within the pointer. This patch changes the
encoding so both the tag values 01 and 11 indicate the value is a signed integer, allowing
a 31 bit value to be stored. All other immediates are tagged with the value 10, and
distinguished by a secondary tag.
Roughly +2% on SunSpider.
- kjs/JSImmediate.h: Encoding of JSImmediates has changed - see comment at head of file for
descption of new layout.
- 3:18 AM Changeset in webkit [35777] by
-
- 4 edits in trunk/JavaScriptCore
More build fixes.
- API/OpaqueJSString.h: Add a namespace to friend declaration to appease MSVC.
- API/JSStringRefCF.h: (JSStringCreateWithCFString) Cast UniChar* to UChar* explicitly.
- JavaScriptCore.exp: Added OpaqueJSString::create(const KJS::UString&) to fix WebCore build.
- 1:32 AM Changeset in webkit [35776] by
-
- 5 edits in trunk/JavaScriptCore
Build fix.
- JavaScriptCore.xcodeproj/project.pbxproj: Marked OpaqueJSString as private
- kjs/identifier.cpp: (KJS::Identifier::checkSameIdentifierTable):
- kjs/identifier.h: (KJS::Identifier::add): Since checkSameIdentifierTable is exported for debug build's sake, gcc wants it to be non-inline in release builds, too.
- JavaScriptCore.exp: Don't export inline OpaqueJSString destructor.
- 12:43 AM Changeset in webkit [35775] by
-
- 19 edits2 adds in trunk
Reviewed by Geoff Garen.
JSStringRef is created context-free, but can get linked to one via an identifier table,
breaking an implicit API contract.
Made JSStringRef point to OpaqueJSString, which is a new string object separate from UString.
Aug 14, 2008:
- 11:15 PM Changeset in webkit [35774] by
-
- 2 edits in trunk/WebKit/win
Update cache capacities to match values used on Mac.
Reviewed by Dan Bernstein.
- WebView.cpp: (WebView::setCacheModel):
- 10:10 PM Changeset in webkit [35773] by
-
- 2 edits in trunk/WebCore
wx !USE(WXGC) build fix. This is necessary until we find a way to replace GDI with an alternative that performs reasonably well. (GDI+ is too slow in many cases.)
- 5:53 PM Changeset in webkit [35772] by
-
- 2 edits in trunk/WebCore
2008-08-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20388
<video> elements on Windows never becomes visible when a page is restored from the cache
Always pass "set" calls down to MediaPlayerPrivate instead of only when the
value is different from the cached value. Let the implementation decide when
to avoid work because nothing has changed.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::setVisible):
- 5:44 PM Changeset in webkit [35771] by
-
- 4 edits in trunk/WebKit/win
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::setCustomHTMLTokenizerTimeDelay): (WebView::setCustomHTMLTokenizerChunkSize):
- WebView.h:
- 4:58 PM Changeset in webkit [35770] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add the bug URL to the ChangeLog.
- 4:57 PM Changeset in webkit [35769] by
-
- 2 edits1 add in trunk/WebCore
Make Firebug command line API respect predefined variables.
Reviewed by Tim Hatcher.
- page/inspector/Console.js:
- 4:45 PM Changeset in webkit [35768] by
-
- 2 edits2 adds in trunk/LayoutTests
2008-08-14 Simon Fraser <Simon Fraser>
Fix testcase and add pixel results for testcase in
https://bugs.webkit.org/show_bug.cgi?id=20367
- platform/mac/fast/css/font-face-in-media-rule-expected.checksum: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.png: Added.
- platform/mac/fast/css/font-face-in-media-rule-expected.txt:
- 4:33 PM Changeset in webkit [35767] by
-
- 9 edits in trunk
WebCore:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Allow programatically setting the HTMLTokenizers time delay and chunk size
which are used for determining how aggressively we yield.
- WebCore.base.exp:
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::continueProcessing):
- html/HTMLTokenizer.h:
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::setCustomHTMLTokenizerTimeDelay): (WebCore::Page::setCustomHTMLTokenizerChunkSize):
- page/Page.h: (WebCore::Page::hasCustomHTMLTokenizerTimeDelay): (WebCore::Page::customHTMLTokenizerTimeDelay): (WebCore::Page::hasCustomHTMLTokenizerChunkSize): (WebCore::Page::customHTMLTokenizerChunkSize):
WebKit/mac:
2008-08-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen and Timothy Hatcher.
Add WebView SPI to set HTMLTokenizer yielding parameters.
- WebView/WebView.mm: (-[WebView _setCustomHTMLTokenizerTimeDelay:]): (-[WebView _setCustomHTMLTokenizerChunkSize:]):
- WebView/WebViewPrivate.h:
- 4:20 PM Changeset in webkit [35766] by
-
- 7 edits in trunk/WebCore
Reviewed by Beth.
Move us one step closer to cross-platform svg/graphics code
- WebCore.xcodeproj/project.pbxproj:
- html/CanvasStyle.cpp:
- platform/graphics/Color.cpp: (WebCore::colorWithOverrideAlpha):
- platform/graphics/Color.h:
- svg/graphics/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
- svg/graphics/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
- 4:19 PM Changeset in webkit [35765] by
-
- 4 edits in trunk/WebCore
Reviewed by Alexey.
Remove un-need includes from HTMLCanvas and use the
Gradient platform abstraction in one place in CanvasStyle
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fillRect):
- html/CanvasStyle.cpp:
- html/HTMLCanvasElement.cpp:
- 4:19 PM Changeset in webkit [35764] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey.
Clean up GlyphBuffer.h, removing more #ifdefs
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
- 4:19 PM Changeset in webkit [35763] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Clean up AffineTransform.h, removing #ifdefs
- platform/graphics/AffineTransform.h:
- platform/graphics/cairo/AffineTransformCairo.cpp:
- platform/graphics/cg/AffineTransformCG.cpp:
- platform/graphics/qt/AffineTransformQt.cpp:
- platform/graphics/wx/AffineTransformWx.cpp:
- 4:12 PM Changeset in webkit [35762] by
-
- 4 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
- fix non-CG builds by adding an ImageSource::frameSizeAtIndex() that returns size().
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameSizeAtIndex):
- 4:08 PM Changeset in webkit [35761] by
-
- 6 edits in trunk/WebCore
2008-08-14 Dan Bernstein <mitz@apple.com>
Reviewed by Brady Eidson.
- fix <rdar://problem/5993323> REGRESSION (r34210): Apple.com favicon appears stretched/clipped
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): Added initialization of m_hasUniformFrameSize. (WebCore::BitmapImage::cacheFrame): Added code to get the size of the cached frame for use in decoded size computation and for setting m_hasUniformFrameSize. (WebCore::BitmapImage::currentFrameSize): Added. (WebCore::BitmapImage::dataChanged): Added code to reset m_hasUniformFrameSize.
- platform/graphics/BitmapImage.h: Added currentFrameSize() and m_hasUniformFrameSize.
- platform/graphics/ImageSource.h: Added frameSizeAtIndex().
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw): Changed to use currentFrameSize(). This fixes the bug, which resulted from assuming that the frame being drawn was the same size as the first frame.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameSizeAtIndex): Renamed size() to this and changed to get the size of the frame at the given index. (WebCore::ImageSource::size): Added. Returns frameSizeAtIndex(0).
- 4:04 PM Changeset in webkit [35760] by
-
- 3 edits2 adds in trunk
2008-08-13 Simon Fraser <Simon Fraser>
Reviewed by Eric Seidel
Fix @font-face inside @media rule crash.
https://bugs.webkit.org/show_bug.cgi?id=20367
Test: fast/css/font-face-in-media-rule.html
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
- 3:52 PM Changeset in webkit [35759] by
-
- 6 edits in trunk/WebCore
wx build fixes after recent changes to Canvas and Image classes.
- 12:26 PM Changeset in webkit [35758] by
-
- 2 edits in trunk/WebCore
2008-08-14 Maxime Britto <britto@apple.com>
Reviewed by Sam Weinig.
rdar://6102511
When pan-scrolling, typing on the keyboard should either stop the pan scroll or be ignored
IE and FF are both preventing the keyboard event to interact with the page while scrolling.
Some differences exist between them concerning the kind of key which is pressed :
IE7 : every key leads to a stop of the panning
FF3 : the ESC and TAB keys leads to a stop, the other keys are inactive.
For WebKit this patch is adopting the FF3 behavior except for the TAB key which is inactive too.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Verifies which key has been hit and decide either to stop the pan scroll or to swallow the key event.
- 12:14 PM Changeset in webkit [35757] by
-
- 4 edits in trunk/WebCore
Gtk+/ Cairo build fix, patch by Dirk Schulze.
- 11:11 AM Changeset in webkit [35756] by
-
- 16 edits in trunk
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- Profiles now have a unique ID so that they can be linked to the console message that announces that a profile completed.
- profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile):
- profiler/Profile.cpp: (KJS::Profile::create): (KJS::Profile::Profile):
- profiler/Profile.h: (KJS::Profile::uid):
- profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
- profiler/ProfileGenerator.h:
- profiler/Profiler.cpp: (KJS::Profiler::startProfiling):
- profiler/TreeProfile.cpp: (KJS::TreeProfile::create): (KJS::TreeProfile::TreeProfile):
- profiler/TreeProfile.h:
WebCore:
2008-08-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6115819> Notify of profile in console
- page/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileMessageToConsole): Called by addProfile this is the function that adds a message to the console that a profile finished.
- page/InspectorController.h:
- page/JavaScriptProfile.cpp: Expose the profiler's unique ID to match the console log to the profile in the web inspector. (WebCore::getUniqueIdCallback): (WebCore::ProfileClass):
- page/inspector/ProfilesPanel.js: Created a map of all the profiles by Id to bring up the requested profile. Also select and reveal the profile in the profile panel. And created displayTitleForProfileLink() which formats a title taking into account if it's user initiated or if there are multiples. Lasty, I put the user initiated profile in a variable.
- page/inspector/inspector.js: Make the profile title be a clickable link that will take the user to the identified profile. Also expose the count of user initiated profiles so they can be displayed in the console with the correct count.
- 10:41 AM Changeset in webkit [35755] by
-
- 3 edits in trunk/WebCore
Avoid formating ConsoleMessages twice unless the message will be
displayed in bubbles of a SourceFrame.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (WebInspector.ConsoleMessage): Only format the plain text message if the URL and line are valid and the level is error or warning. (WebInspector.ConsoleMessage.prototype.isErrorOrWarning): Added. Helper to test for error or warning level.
- page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): Don't add the message if there is no message or valid line or if the msg isn't an error or warning.
- 9:12 AM Changeset in webkit [35754] by
-
- 2 edits in trunk/WebKit/mac
Fixes a bug where Safari's find banner would be permanently hidden
when attaching or closing the Web Inspector while attached.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController close]): Carefully manipulate the WebFrameView's frame when closing to not assume the WebFrameView's frame fills the inspected WebView. (-[WebInspectorWindowController setAttachedWindowHeight:]): Carefully manipulate the WebFrameView's frame when docking to not assume the WebFrameView plus the Web Inspector WebViews fills the full inspected WebView.
- 8:07 AM Changeset in webkit [35753] by
-
- 2 edits in trunk/WebCore
2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
partial Gtk build fix, not reviewed
- platform/graphics/cairo/PatternCairo.cpp:
