Timeline
Aug 20, 2008:
- 11:52 PM Changeset in webkit [35871] by
-
- 2 edits in trunk/WebCore
Fix build failure.
Reviewed by Jon Honeycutt.
- bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.
- 10:03 PM Changeset in webkit [35870] by
-
- 2 edits in trunk/PlanetWebKit
Add Anthony Ricaud's blog.
Reviewed by Tim Hatcher.
- config.ini: Add Anthony Ricaud's blog.
- 9:01 PM Changeset in webkit [35869] by
-
- 3 edits in trunk/WebCore
Build fix.
- 5:33 PM Changeset in webkit [35868] by
-
- 14 edits in trunk
WebCore:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and rename related methods and variables accordingly.
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen):
- page/FrameView.h:
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents):
WebKit/mac:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen, rename related methods and variables accordingly, and make -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen WebView API.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
- WebView/WebView.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView setShouldUpdateWhileOffscreen:]): (-[WebView shouldUpdateWhileOffscreen]):
- WebView/WebViewPrivate.h:
- 5:13 PM Changeset in webkit [35867] by
-
- 2 edits in trunk/WebCore
2008-08-20 Brady Eidson <beidson@apple.com>
Reviewed by Mitzpettel
<rdar://problem/6163636> - Many images broken in Mail
This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.
When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is CachedResource::PreloadReferenced.
- 4:20 PM Changeset in webkit [35866] by
-
- 7 edits in trunk/WebKit/mac
Switch to non-deprecated NSFileManager APIs.
In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.
Reviewed by Darin Adler.
- 4:04 PM Changeset in webkit [35865] by
-
- 2 adds in trunk/LayoutTests/fast/css
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
- fast/css/getComputedStyle-transform-expected.txt: Added.
- fast/css/getComputedStyle-transform.html: Added.
(Missed these test files on last commit)
- 3:50 PM Changeset in webkit [35864] by
-
- 3 edits in trunk/WebCore
2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
Unreviewed compile fix
Catch up with the JSValue::type elimination.
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::defaultValue):
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::QtRuntimeConnectionMethod::call):
- 3:15 PM Changeset in webkit [35863] by
-
- 2 edits in trunk/WebCore
2008-08-20 Chris Teague <chris.teague@gmail.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
- ChangeLog:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 2:57 PM Changeset in webkit [35862] by
-
- 5 edits in trunk
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
Test: fast/css/getComputedStyle-transform.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
- rendering/style/RenderStyle.h:
- 2:04 PM Changeset in webkit [35861] by
-
- 6 edits in trunk
WebCore:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- bridge/npapi.h: (_NPCocoaEvent::):
WebKit/mac:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
WebKitExamplePlugins:
2008-08-20 Josh Aas <joshmoz@gmail.com>
Reviewed and landed by Anders.
<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- NetscapeCocoaPlugin/main.m: (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent):
- 1:46 PM Changeset in webkit [35860] by
-
- 12 edits in trunk
WebCore:
2008-08-20 Beth Dakin <Beth Dakin>
Reviewed by Darin.
Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.
This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.
- dom/Node.cpp: (WebCore::Node::isInShadowTree):
- dom/Node.h:
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Returns false if excludeFromTextSearch() is true.
In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):
- editing/Editor.h:
excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.
- WebCore.base.exp:
- page/Frame.cpp: (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.
WebKit/mac:
2008-08-20 Beth Dakin <Beth Dakin>
Reviewed by Darin.
Fix for <rdar://problem/6145626>
Allows a WebKit client to mark a frame as not-text-searchable
through SPI.
- WebView/WebFrame.mm: (-[WebFrame _setExcludeFromTextSearch:]):
- WebView/WebFramePrivate.h:
- 12:10 PM Changeset in webkit [35859] by
-
- 4 edits in trunk/WebCore
Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.
Reviewed by Kevin McCullough.
- English.lproj/localizedStrings.js: Updated the strings.
- page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Renamed the boxPartValue function to createBoxPartElement and made it create the entire element. Made it understand how to get position style properties. Don't use the figure dash when 0px is used for positions, since the 0 is meaningful there. Instead use the figure dash when a position is auto.
- page/inspector/inspector.css: Added a new rule for position.
- 12:01 PM Changeset in webkit [35858] by
-
- 5 edits in trunk
2008-08-20 Maxime Britto <britto@apple.com>
Reviewed by Ada Chan.
rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
- Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
- WebView.cpp: (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
2008-08-20 Maxime Britto <britto@apple.com>
Reviewed by Ada Chan.
rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
- DumpRenderTree/win/UIDelegate.h: (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
- 11:34 AM Changeset in webkit [35857] by
-
- 2 edits in trunk/WebCore
Qt build fix
- 11:28 AM Changeset in webkit [35856] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- avoid using a deprecated NSScroller method on Leopard
- platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion):
- 4:40 AM Changeset in webkit [35855] by
-
- 3 edits in trunk/WebCore
2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix
- GNUmakefile.am:
- page/AccessibilityTable.cpp: Change nil to 0 (WebCore::AccessibilityTable::cellForColumnAndRow):
- 3:40 AM Changeset in webkit [35854] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
- 12:23 AM Changeset in webkit [35853] by
-
- 100 edits5 adds in trunk
Reviewed by Geoff Garen.
Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
Aug 19, 2008:
- 10:51 PM BuildingOnWindows edited by
- (diff)
- 4:33 PM Changeset in webkit [35852] by
-
- 15 edits in trunk/WebCore
Reviewed by Geoff Garen.
Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.
I'll follow this up with actual *Skia.cpp files in a separate patch.
- platform/graphics/AffineTransform.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.h:
- 3:46 PM Changeset in webkit [35851] by
-
- 2 edits in trunk/WebCore
Fix Windows build more.
- WebCore.vcproj/WebCore.vcproj:
- 3:36 PM Changeset in webkit [35850] by
-
- 2 edits in trunk/WebKit/mac
Fixes the Web Inspector flashing white while resizing after
highlighting a page element. Calling disableScreenUpdatesUntilFlush
when attaching and detaching the Inspector page highlight is bad,
since the browser window might not flush again for a while. So screen
updates could be disabled for long periods of time, causing backing store
flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
when attaching or detaching the child window.
Reviewed by John Sullivan and Kevin McCullough.
- WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush. (-[WebNodeHighlight detach]): Ditto.
- 3:34 PM Changeset in webkit [35849] by
-
- 2 edits in trunk/WebCore
Fix Windows build.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- 3:29 PM Changeset in webkit [35848] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
- 3:22 PM Changeset in webkit [35847] by
-
- 6 edits2 adds in trunk/JavaScriptCore
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim and Mark.
Implement DTrace hooks for dashcode and instruments.
- API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be turned on from a client. The DTrace probes were added within the profiler mechanism for performance reasons so the profiler must be started to enable tracing. (JSStartProfiling): (JSEndProfiling):
- API/JSProfilerPrivate.h: Added. Ditto.
- JavaScriptCore.exp: Exposing the start/stop methods to clients.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Tracing.d: Define the DTrace probes.
- kjs/Tracing.h: Ditto.
- profiler/ProfileGenerator.cpp: Implement the DTrace probes in the profiler. (KJS::ProfileGenerator::willExecute): (KJS::ProfileGenerator::didExecute):
- 3:05 PM Changeset in webkit [35846] by
-
- 12 edits30 adds in trunk
<rdar://problem/4003764> Expose tables as AXTables
Exposes "data" tables in HTML as AXTables through accessibility
- 2:35 PM Changeset in webkit [35845] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- kjs/operations.cpp: (KJS::equal):
- 1:18 PM Changeset in webkit [35844] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
is waiting for crash reporter to let it exit.
The fix does not work on Tiger, because the state of the process is indistinguishable from
other waiting processes, at least not with this technique.
- Scripts/run-webkit-tests:
- 11:39 AM Changeset in webkit [35843] by
-
- 2 edits in trunk/WebCore
Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.
- WebCore.vcproj/QTMovieWin.vcproj:
- 11:33 AM Changeset in webkit [35842] by
-
- 6 edits in trunk/WebCore
Added support for console.count in the inspector.
Reviewed by Geoff Garen.
- page/Console.cpp: (WebCore::Console::count):
- page/Console.h:
- page/Console.idl: Added console.count.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Clears m_counts. (WebCore::InspectorController::count): Updates the count number sing "title@source:line" as the identifier, and adds a message to the console.
- page/InspectorController.h: Added m_counts.
- 11:33 AM Changeset in webkit [35841] by
-
- 2 edits in trunk/WebCore
Clear console.time timers when changing page.
Reviewed by Geoff Garen.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- 10:55 AM Changeset in webkit [35840] by
-
- 3 edits in trunk/WebCore
2008-08-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404
Ignore setVisible() when visibility doesn't change.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::setVisible):
- 10:01 AM Changeset in webkit [35839] by
-
- 2 edits in trunk/WebKit/mac
Correctly remembers the attached state of the Web Inspector so
it opens in that state for the next window, or next launch.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey to YES in the user defaults. (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey to NO in the user defaults.
- 10:01 AM Changeset in webkit [35838] by
-
- 2 edits in trunk/WebCore
Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype._changeView): Call _sortProfile on the next profile before assigning it to this.profile. (WebInspector.ProfileView.prototype._sortData): Call _sortProfile. (WebInspector.ProfileView.prototype._sortProfile): Moves from _sortData and takes a profile argument. If the profile passed in matches the this.profile, then call refresh.
- 10:01 AM Changeset in webkit [35837] by
-
- 2 edits in trunk/WebCore
Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView): Changed the default sort column. Also assign heavyProfile to profile, so the sortSelfTimeDescending call happens on the heavy profile before assigning to this.profile.
- 10:00 AM Changeset in webkit [35836] by
-
- 2 edits in trunk/JavaScriptCore
Fix an assertion when generating a heavy profile because the
empty value and deleted value of CallIdentifier where equal.
Reviewed by Dan Bernstein.
- profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier use empty strings for URL and function name.
- 10:00 AM Changeset in webkit [35835] by
-
- 6 edits in trunk/WebCore
Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.
Reviewed by Kevin McCullough.
- page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Set editable to true by default. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Factored out code into update, and calls update. (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title gets made later in onattach. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early if shouldRefreshChildren is true. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing. (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update. (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for this element (code moved from the constructor.) (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all sibling property elements. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call WebInspector.startEditing after rememebring some context. (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft for the list element, since it might have scrolled during editing. (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded then restore the state from the context. Then call update to restore the title. (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled if the user input and the previous input are the same. Call editingEnded, then call applyExpression to commit the user input. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression and stores the result on the object for the property name of this element. If the expression is empty, delete the property and remove the tree element.
- page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused property on each ObjectPropertiesSection. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach since it is now implemented.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument that defaults to true if omitted. It specifies whether to call update on the scope chain.
- page/inspector/inspector.css: New styles.
- page/inspector/treeoutline.js: (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
- 10:00 AM Changeset in webkit [35834] by
-
- 2 edits in trunk/WebCore
Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Add parenthesis around the expression. And add couple comments.
- 9:38 AM Changeset in webkit [35833] by
-
- 3 edits in trunk/WebCore
2008-08-19 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
-Implement a page() function to extract a common code pattern.
- WebCore.xcodeproj/project.pbxproj:
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::assertCondition): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupEnd): (WebCore::Console::finishedProfiling): (WebCore::Console::warn): (WebCore::Console::framePage):
- page/Console.h:
- 7:35 AM Changeset in webkit [35832] by
-
- 1 edit1 move in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg
Disabling the test while the crash is being investigated.
- 12:27 AM Changeset in webkit [35831] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=19347
<rdar://problem/5977562> Input methods do not work after switching to a password field
and back.
Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
reconversion) in a different way which doesn't conflict with context caching performed
by AppKit.
This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
because input methods are disabled in password fields. Attempting to reconvert text typed
with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
password field behavior and disable reconversion completely.
- WebView/WebHTMLView.mm: (isInPasswordField): Factored out code to determine that the current selection is in a password field. (inputContext): Removed a hack that was breaking TSMGetActiveDocument(). (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields. (-[WebHTMLView textStorage]): Ditto.
Aug 18, 2008:
- 9:39 PM Changeset in webkit [35830] by
-
- 47 edits3 adds in trunk
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
This will make it slightly easier to change the JSImmediate design without
having to touch so many call sites.
SunSpider says this change is a wash (looked like a slight speedup, but not
statistically significant).
- API/JSStringRef.cpp: Removed include of JSType.h.
- API/JSValueRef.cpp: Removed include of JSType.h. (JSValueGetType): Replaced use of JSValue::type() with JSValue::is functions.
- JavaScriptCore.exp: Updated.
- VM/JSPropertyNameIterator.cpp: Removed type() implementation. (KJS::JSPropertyNameIterator::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- VM/JSPropertyNameIterator.h: Ditto.
- VM/Machine.cpp: (KJS::fastIsNumber): Updated for name change. (KJS::fastToInt32): Ditto. (KJS::fastToUInt32): Ditto. (KJS::jsAddSlowCase): Updated toPrimitive caller for change from JSType to PreferredPrimitiveType. (KJS::jsAdd): Replaced calls to JSValue::type() with calls to JSValue::isString(). (KJS::jsTypeStringForValue): Replaced calls to JSValue::type() with multiple calls to JSValue::is -- we could make this a virtual function instead if we want to have faster performance. (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32 to JSImmediate::getTruncatedUInt32 for consistency with other functions. Changed two calls of JSValue::type() to JSValue::isString().
- kjs/GetterSetter.cpp: (KJS::GetterSetter::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType. (KJS::GetterSetter::isGetterSetter): Added.
- kjs/GetterSetter.h:
- kjs/JSCell.cpp: (KJS::JSCell::isString): Added. (KJS::JSCell::isGetterSetter): Added. (KJS::JSCell::isObject): Added.
- kjs/JSCell.h: Eliminated type function. Added isGetterSetter. Made isString and isObject virtual. Changed toPrimitive to take PreferredPrimitiveType argument instead of JSType. (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance. (KJS::JSValue::isGetterSetter): Added. (KJS::JSValue::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- kjs/JSImmediate.h: Removed JSValue::type() and replaced JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32. (KJS::JSImmediate::isEitherImmediate): Added.
- kjs/JSNotAnObject.cpp: (KJS::JSNotAnObject::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
- kjs/JSNotAnObject.h: Ditto.
- kjs/JSNumberCell.cpp: (KJS::JSNumberCell::toPrimitive): Ditto.
- kjs/JSNumberCell.h: (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no other "slow" version of this once you have a JSNumberCell, so there's no need for "fast" in the name. It's a feature that this hides the base class toInt32, which does the same job less efficiently (and has an additional ExecState argument). (KJS::JSNumberCell::toUInt32): Ditto.
- kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Use isGetterSetter instead of type. (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType. (KJS::JSObject::defaultValue): Ditto. (KJS::JSObject::defineGetter): Use isGetterSetter. (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::lookupGetter): Ditto. (KJS::JSObject::lookupSetter): Ditto. (KJS::JSObject::toNumber): Use PreferredPrimitiveType. (KJS::JSObject::toString): Ditto. (KJS::JSObject::isObject): Added.
- kjs/JSObject.h: (KJS::JSObject::inherits): Call the isObject from JSCell; it's now hidden by our override of isObject. (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter instead of type. (KJS::JSObject::getOwnPropertySlot): Ditto. (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
- kjs/JSString.cpp: (KJS::JSString::toPrimitive): Use PreferredPrimitiveType. (KJS::JSString::isString): Added.
- kjs/JSString.h: Ditto.
- kjs/JSValue.h: Removed type(), added isGetterSetter(). Added PreferredPrimitiveType enum and used it as the argument for the toPrimitive function. (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
- kjs/collector.cpp: (KJS::typeName): Changed to use JSCell::is functions instead of calling JSCell::type.
- kjs/collector.h: (KJS::Heap::isNumber): Renamed from fastIsNumber.
- kjs/nodes.h: Added now-needed include of JSType, since the type is used here to record types of values in the tree.
- kjs/operations.cpp: (KJS::equal): Rewrote to no longer depend on type(). (KJS::strictEqual): Ditto.
JavaScriptGlue:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- JSUtils.cpp: (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with JSValue::is functions.
- UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot): Ditto. (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument instead of JSType argument.
- UserObjectImp.h: Ditto.
WebCore:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- bridge/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean, since that's never passed.
- bridge/c/c_instance.h: Ditto.
- bridge/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions instead of JSValue::type(). Removed unneeded code to handle "unspecified".
- bridge/jni/jni_instance.cpp: (JavaInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
- bridge/jni/jni_instance.h: Ditto.
- bridge/jni/jni_jsobject.mm: (JavaJSObject::convertValueToJObject): Use JSValue::is functions instead of JSValue::type().
- bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed unused argument.
- bridge/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): Removed unused argument. (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean and another dead code path for unknown types.
- bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed override of type() that caused the fallback object to return "UndefinedType" when there is no invokeUndefinedMethodFromWebScript:withArguments: method defined. That didn't accomplish much, since most checks for undefined don't ever call type().
- bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::defaultValue): Ditto.
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
- bridge/qt/qt_instance.h: Ditto.
- bridge/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): Removed unsed argument.
- bridge/runtime_object.cpp: (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument.
- bridge/runtime_object.h: Ditto.
WebKit/mac:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- eliminate JSValue::type()
- WebView/WebView.mm: (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead of a switch on JSValue::type().
LayoutTests:
2008-08-12 Darin Adler <Darin Adler>
Reviewed by Geoff.
- added a test since I had to rewrite the == and === operators
- fast/js/equality-expected.txt: Added.
- fast/js/equality.html: Added.
- fast/js/resources/equality.js: Added.
- 5:42 PM Changeset in webkit [35829] by
-
- 2 edits in trunk/WebCore
2008-08-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :
FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.
This patch matches FF3 behavior by disabling every key but the esc key.
- page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped. (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
- 5:20 PM Changeset in webkit [35828] by
-
- 10 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
Test: fast/replaced/max-width-percent.html
Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidth):
- rendering/RenderBox.h:
- rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcPrefWidths):
- rendering/RenderImage.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcPrefWidths):
- rendering/RenderVideo.h:
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
- fast/replaced/max-width-percent.html: Added.
- platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
- platform/mac/fast/replaced/max-width-percent-expected.png: Added.
- platform/mac/fast/replaced/max-width-percent-expected.txt: Added.
- 4:08 PM Changeset in webkit [35827] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
Make transition_shorthand_parsing.html a text-only test.
- fast/css/transition_shorthand_parsing-expected.txt: Added.
- fast/css/transition_shorthand_parsing.html:
- platform/mac/fast/css/transition_shorthand_parsing-expected.txt:
- 3:47 PM Changeset in webkit [35826] by
-
- 2 edits in trunk/WebCore
2008-08-18 Daniel Macks <dmacks@netspace.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.
- platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::read):
- 3:11 PM Changeset in webkit [35825] by
-
- 3 edits2 adds in trunk
Reviewed by Dave Hyatt
Need to make sure we have an Animation in the AnimationList
before setting the initial value.
https://bugs.webkit.org/show_bug.cgi?id=20408
Test: fast/css/transition_shorthand_parsing.html
- css/CSSStyleSelector.cpp:
- 2:55 PM Changeset in webkit [35824] by
-
- 2 edits in trunk/WebKit/wx
Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.
- 1:53 PM Changeset in webkit [35823] by
-
- 3 edits in trunk/JavaScriptCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
If there are no nodes in a profile all the time should be attributed to
(idle)
- profiler/Profile.cpp: If ther are no nodes make sure we still process the head. (KJS::Profile::forEach):
- profiler/ProfileGenerator.cpp: Remove some useless code. (KJS::ProfileGenerator::stopProfiling):
- 1:53 PM Changeset in webkit [35822] by
-
- 8 edits5 adds in branches/XBL2
WebCore:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20347: [XBL] Add support for DocumentXBL interface
- Add a custom NamedNodeMap for document.bindingsDocument as it is a static map that throws NO_MODIFICATIN_ALLOWED_ERR on modification.
Test: fast/xbl/xbl-bindingDocuments.html
- GNUmakefile.am: Add NamedStaticDocumentMap.cpp.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_bindingDocuments. (WebCore::Document::~Document): Zero m_bindingDocuments. (WebCore::Document::bindingDocuments): Getter method. (WebCore::Document::loadBindingDocument): Stub method as we need an helper class to load bindings. (WebCore::Document::createBindingDocumentsIfNeeded):
- dom/Document.h:
- dom/Document.idl: Add documentXBL interface.
- dom/NamedStaticDocumentMap.cpp: Added. (WebCore::NamedStaticDocumentMap::NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::~NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::getNamedItem): (WebCore::NamedStaticDocumentMap::removeNamedItem): (WebCore::NamedStaticDocumentMap::getNamedItemNS): (WebCore::NamedStaticDocumentMap::removeNamedItemNS): (WebCore::NamedStaticDocumentMap::setNamedItem): (WebCore::NamedStaticDocumentMap::item): (WebCore::NamedStaticDocumentMap::addItem):
- dom/NamedStaticDocumentMap.h: Added. (WebCore::NamedStaticDocumentMap::create): (WebCore::NamedStaticDocumentMap::length): (WebCore::NamedStaticDocumentMap::clear): Custom NamedNodeMap that match the specification.
LayoutTests:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20347: [XBL] Add support for DocumentXBL interface
- fast/xbl/resources/bindingDocuments.js: Added.
- fast/xbl/xbl-bindingDocuments-expected.txt: Added.
- fast/xbl/xbl-bindingDocuments.html: Added.
- 1:21 PM Changeset in webkit [35821] by
-
- 2 edits in trunk/WebCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.
- page/inspector/ProfilesPanel.js:
- 12:55 PM Changeset in webkit [35820] by
-
- 2 edits in trunk/WebCore
2008-08-18 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages
- page/inspector/Console.js:
- 8:54 AM Changeset in webkit [35819] by
-
- 8 edits5 adds in branches/XBL2
WebCore:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Bug 20263: [XBL] Add loading code for XBLBinding
Test: fast/xbl/xbl-empty-fragment-loadBinding.html
- GNUmakefile.am: Add XBLBinding.cpp.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- xbl/XBLBinding.cpp: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::~XBLBinding): (WebCore::XBLBinding::setXBLDocument): (WebCore::XBLBinding::getBindingElement):
- xbl/XBLBinding.h: Inherit from CachedResourceClient to use the Cache management. Also added the bound element, the <binding> element as members.
- xbl/XBLBindingManager.cpp: Changed Vector<XBLBinding>* to Vector<XBLBinding*>* as we were taking a pointer to a local value.
(WebCore::XBLBindingManager::addBinding): Ditto.
(WebCore::XBLBindingManager::removeBinding): Ditto.
(WebCore::XBLBindingManager::hasBinding): Ditto.
(WebCore::XBLBindingManager::removeAllBindings): Ditto.
- xbl/XBLBindingManager.h: Ditto.
LayoutTests:
2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric.
Test case for bug 20263: [XBL] Add loading code for XBLBinding
- fast/xbl/resources/xbl-failed-binding.xbl: Added.
- fast/xbl/resources/xbl-passed-binding.xbl: Added.
- fast/xbl/xbl-empty-fragment-loadBinding-expected.txt: Added.
- fast/xbl/xbl-empty-fragment-loadBinding.html: Added.
- 7:54 AM Changeset in webkit [35818] by
-
- 77 edits in trunk/WebKitSite
Upgrade to WordPress 2.6.1.
- 4:20 AM Changeset in webkit [35817] by
-
- 2 edits in trunk/WebCore
2008-08-18 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
- 4:14 AM Changeset in webkit [35816] by
-
- 8 edits in trunk
2008-08-18 Alp Toker <alp@nuanti.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=20350
[GTK] Get DumpRenderTree working
WebKit/gtk:
Add a private function to WebFrame to dump the render tree as required
for the DumpRenderTree testing tool.
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
WebKitTools/DumpRenderTree/gtk:
Fixes and enhancements to DumpRenderTree. With these changes, the test
suite can now complete a run producing text and render tree dumps.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dump): (runTest): (webViewLoadFinished): (webViewWindowObjectCleared): (webViewConsoleMessage): (webViewScriptAlert): (webViewScriptPrompt): (webViewScriptConfirm): (webViewTitleChanged): (main):
- DumpRenderTree/gtk/DumpRenderTreeGtk.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList): (LayoutTestController::pathToLocalResource): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (waitToDumpWatchdogFired): (LayoutTestController::windowCount):
- DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (JSStringCopyUTF8CString): (ScriptItem::invoke):
- 1:09 AM Changeset in webkit [35815] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
Make JSGlobalContextRetain/Release actually work.
- API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): Ref/deref global data to give checking for globalData.refCount() some sense.
- API/tests/testapi.c: (main): Added a test for this bug.
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData): While checking for memory leaks, found that JSGlobalData::emptyList has changed to a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.
Aug 17, 2008:
- 8:21 PM Changeset in webkit [35814] by
-
- 3 edits in trunk/WebCore
Complete in scope variables in the Console when paused.
Reviewed by Geoffrey Garen.
- page/inspector/Console.js: (WebInspector.Console.prototype.completions): If the expressionString is null or empty and the debugger is paused, call variablesInScopeForSelectedCallFrame to get an object that declares all the in scope variables. That way "top level" expressions are completed.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.variablesInScopeForSelectedCallFrame): Return an object that has all the variables that are in scope for the selected call frame. The value of each property is just true. The return object is useful for quick lookups or auto completion.
- 7:42 PM Changeset in webkit [35813] by
-
- 7 edits in trunk
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Change the counting of constants so that preincrement and predecrement of
const local variables are considered unexpected loads.
- kjs/nodes.cpp: (KJS::PrefixResolveNode::emitCode):
- kjs/nodes.h: (KJS::ScopeNode::neededConstants):
LayoutTests:
- fast/js/deep-recursion-test.html:
- 4:38 PM Changeset in webkit [35812] by
-
- 3 edits3 adds in trunk
<rdar://problem/6150322> In Gmail, a crash occurs at KJS::Machine::privateExecute() when applying list styling to text after a quote had been removed
<https://bugs.webkit.org/show_bug.cgi?id=20386>
Reviewed by Cameron Zwarich.
This crash was caused by "depth()" incorrectly determining the scope depth
of a 0 depth function without a full scope chain. Because such a function
would not have an activation the depth function would return the scope depth
of the parent frame, thus triggering an incorrect unwind. Any subsequent
look up that walked the scope chain would result in incorrect behaviour,
leading to a crash or incorrect variable resolution. This can only actually
happen in try...finally statements as that's the only path that can result in
the need to unwind the scope chain, but not force the function to need a
full scope chain.
- 2:34 PM Changeset in webkit [35811] by
-
- 2 edits in trunk/WebCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Speculative Qt build fix.
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertValueToQVariant): (KJS::Bindings::QtRuntimeMethod::QtRuntimeMethod):
- 2:27 PM Changeset in webkit [35810] by
-
- 5 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Bug 20419: Remove op_jless
<https://bugs.webkit.org/show_bug.cgi?id=20419>
Remove op_jless, which is rarely used now that we have op_loop_if_less.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- 2:18 PM Changeset in webkit [35809] by
-
- 2 edits in trunk/JavaScriptCore
2008-08-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Dan Bernstein.
Fix a typo in r35807 that is also causing build failures for
non-AllInOne builds.
- kjs/NumberConstructor.cpp:
- 1:28 PM Changeset in webkit [35808] by
-
- 9 edits in trunk
JavaScriptGlue:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- WebKit.xcodeproj/project.pbxproj:
WebKitTools:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated project files to XCode 3.1.
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 1:23 PM Changeset in webkit [35807] by
-
- 85 edits in trunk
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
SunSpider says no change.
I changed JSCallbackObjectData, Arguments, JSArray, and RegExpObject to
store auxiliary data in a secondary structure.
I changed InternalFunction to store the function's name in the property
map.
I changed JSGlobalObjectData to use a virtual destructor, so WebCore's
JSDOMWindowBaseData could inherit from it safely. (It's a strange design
for JSDOMWindowBase to allocate an object that JSGlobalObject deletes,
but that's really our only option, given the size constraint.)
I also added a bunch of compile-time ASSERTs, and removed lots of comments
in JSObject.h because they were often out of date, and they got in the
way of reading what was actually going on.
Also renamed JSArray::getLength to JSArray::length, to match our style
guidelines.
WebCore:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
Changed JSDOMWindowBase to store its auxiliary data in a subclass of
JSGlobalData, so the two could share a pointer.
Added a bunch of ASSERTs, to help catch over-sized objects.
WebKit/mac:
2008-08-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Made room for a free word in JSCell.
(Updated for JavaScriptCore changes.)
- 12:57 AM Changeset in webkit [35806] by
-
- 10 edits in trunk/JavaScriptCore
2007-08-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Sped up property access for array.length and string.length by adding a
mechanism for returning a temporary value directly instead of returning
a pointer to a function that retrieves the value.
Also removed some unused cruft from PropertySlot.
SunSpider says 0.5% - 1.2% faster.
NOTE: This optimization is not a good idea in general, because it's
actually a pessimization in the case of resolve for assignment,
and it may get in the way of other optimizations in the future.
Aug 16, 2008:
- 10:06 PM Changeset in webkit [35805] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- 8:28 PM Changeset in webkit [35804] by
-
- 3 edits in trunk/WebCore
2008-08-15 Mark Rowe <mrowe@apple.com>
Reviewed by Dan Bernstein.
Disable dead code stripping in debug builds.
- Configurations/Base.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
