Timeline


and

08/22/08:

20:17 Changeset [35898] by cwzwarich@webkit.org

2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Some cleanup to match our coding style.

  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/ExecState.cpp:
  • kjs/ExecState.h:
  • kjs/completion.h:
  • kjs/identifier.cpp: (KJS::Identifier::equal): (KJS::CStringTranslator::hash): (KJS::CStringTranslator::equal): (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::equal): (KJS::UCharBufferTranslator::translate): (KJS::Identifier::remove):
  • kjs/operations.h:
16:44 Changeset [35897] by jhoneycutt@apple.com

2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>

Add SPI to make a Windows WebView transparent.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call updateBackground() when a new frame is attached, matching the Mac.
  • WebFrame.cpp: (WebFrame::updateBackground): Propagate WebView transparency to ourself and our child frames.
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): Pass m_transparent when creating a GraphicsContext, so the context will be created with an alpha channel. (WebView::setTransparent): (WebView::transparent):
  • WebView.h:
16:44 Changeset [35896] by jhoneycutt@apple.com

2008-08-12 Jon Honeycutt <jhoneycutt@apple.com>

Add SPI to get a handle to the WebView's backing store bitmap.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::backingStore):
  • WebView.h:
13:35 Changeset [35895] by timothy@apple.com

Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.

https://bugs.webkit.org/show_bug.cgi?id=20487

  • page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Removes parenthesis around the expression.
12:39 Changeset [35894] by andersca@apple.com

2008-08-22 Anders Carlsson <andersca@apple.com>

Fix build for real this time.


  • UserObjectImp.h:
12:14 Changeset [35893] by andersca@apple.com

2008-08-22 Anders Carlsson <andersca@apple.com>

Fix build.


  • UserObjectImp.cpp: (UserObjectImp::toPrimitive):
  • UserObjectImp.h:
11:39 Changeset [35892] by timothy@apple.com

Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.

WebCore:

2008-08-22 Timothy Hatcher <timothy@apple.com>

Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.

https://bugs.webkit.org/show_bug.cgi?id=20485

Reviewed by Dan Bernstein.

Test: fast/css/overflow-property.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

LayoutTests:

2008-08-22 Timothy Hatcher <timothy@apple.com>

Test for the tests the parsing and retrieval of the overflow,
overflow-x and overflow-y properties

https://bugs.webkit.org/show_bug.cgi?id=20485

Reviewed by Dan Bernstein.

  • fast/css/overflow-property-expected.txt: Added.
  • fast/css/overflow-property.html: Added.
11:39 Changeset [35891] by timothy@apple.com

Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.

https://bugs.webkit.org/show_bug.cgi?id=20484

Reviewed by Darin Adler.

  • page/inspector/treeoutline.js: (TreeOutline._removeChildren): Remove the offsetTop call that was forcing a layout, since layout causes scroll positions to be clamped to the new scrollHeight/Width. Layout will happen normally when needed.
10:38 Changeset [35890] by simon.fraser@apple.com

Reviewed by Darin Adler

css3/transform-computed-style-001.html is better tested
by fast/css/getComputedStyle-transform.html, so removed.
https://bugs.webkit.org/show_bug.cgi?id=20477

  • css3/transform-computed-style-001-expected.txt: Removed.
  • css3/transform-computed-style-001.fhtml: Removed.
09:25 Changeset [35889] by kevino@webkit.org

wx build fix. Add AccessibilityTable sources.

08/21/08:

23:29 Changeset [35888] by mitz@apple.com

WebCore:

Reviewed by Jon Honeycutt and Alexey Proskuryakov.

  • fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported ascent and 100% to its reported descent.

LayoutTests:

Reviewed by Jon Honeycutt and Alexey Proskuryakov.

  • test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.
19:20 Changeset [35887] by mrowe@apple.com

2008-08-21 Jonas Klink <klinktech@gmail.com>

Reviewed by Jon Honeycutt.

Fix https://bugs.webkit.org/show_bug.cgi?id=20231
Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE

Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
from accNavigate if no screen element is found in the specified direction.

  • AccessibleBase.cpp: (AccessibleBase::accNavigate):
19:20 Changeset [35886] by mrowe@apple.com

2008-08-21 Jonas Klink <klinktech@gmail.com>

Reviewed by Jon Honeycutt.

Fix http://bugs.webkit.org/show_bug.cgi?id=20230
Bug 20230: get_accState should be testing state on childObj

Also initializes output parameter action to 0 in get_accDefaultAction.

  • AccessibleBase.cpp: (AccessibleBase::get_accState): (AccessibleBase::get_accDefaultAction):
19:10 Changeset [35885] by mrowe@apple.com

Fix bug number in ChangeLog.

19:07 Changeset [35884] by mrowe@apple.com

2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] Crash on some pages due to a plugin

Fix handling of badly formatted and empty plugin mime descriptions

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
19:07 Changeset [35883] by mrowe@apple.com

2008-08-21 Kevin Watters <kevinwatters@gmail.com>

Reviewed by Darin Adler.

Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.

  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameDurationAtIndex):
17:39 Changeset [35882] by britto@apple.com

2008-08-21 Maxime Britto <britto@apple.com>

Reviewed by Kevin McCullough.

Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
https://bugs.webkit.org/show_bug.cgi?id=20451


rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.

(WebCore::EventHandler::handleMousePressEvent): ditto

2008-08-21 Maxime Britto <britto@apple.com>

Reviewed by Kevin McCullough.

rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
https://bugs.webkit.org/show_bug.cgi?id=20451

This test can be run automatically or manually as well.

  • fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
  • fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
  • fast/events/resources/big-page-with-overflow-hidden.html: Added.
16:54 Changeset [35881] by timothy@apple.com

Small optimization for when the dividers in the Inspector's
Resources panel are updated.

Reviewed by Tim Hatcher.

  • page/inspector/ResourcesPanel.js: (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Combind a for loop and clone the divider element.
16:44 Changeset [35880] by simon.fraser@apple.com

Reviewed by Mark Rowe

Make build-launcher-app work when run from a git repository.
https://bugs.webkit.org/show_bug.cgi?id=20478

  • BuildSlaveSupport/build-launcher-app:
16:35 Changeset [35879] by dino@apple.com

2008-08-21 Chris Marrin <cmarrin@apple.com>

Allow 0 (without units) for Time eg. duration
Fix for https://bugs.webkit.org/show_bug.cgi?id=20467

Reviewed by Dave Hyatt.

Test: css1/units/zero-duration-without-units.html

  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
13:13 Changeset [35878] by timothy@apple.com

Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.

https://bugs.webkit.org/show_bug.cgi?id=20472

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted): Don't check for hasAttributes on the parseElement, continuing through the function will correctly remove the attribute. If the parseElement is null, call _editingCancelled not editingCancelled, this fixes an exception.
13:12 Changeset [35877] by timothy@apple.com

Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.

https://bugs.webkit.org/show_bug.cgi?id=20470

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add event listeners for the "style edited" and "style property toggled" events, so the Metrics pane is updated. (WebInspector.ElementsPanel.prototype._stylesPaneEdited): Update the Metrics pane.
  • page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Dispatch the "style property toggled" event. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Dispatch the "style edited" event when the CSS text is restored. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Dispatch the "style edited" event.
13:12 Changeset [35876] by timothy@apple.com

Make the Inspector's Metrics sidebar pane editable.

https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add an event listener for the "metrics edited" event, so the Styles pane is updated.
  • page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Remember the node so future updates work. Add a double click event listener for the metric values to start editing. (WebInspector.MetricsSidebarPane.prototype.startEditing): Call WebInspector.startEditing with some context. (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype.editingCommitted): Set the user input on the elements inline style. Fire the "metrics edited" event.
11:42 Changeset [35875] by sfalken@apple.com

Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.


Don't post a timer message if one is already pending.


Reviewed by Ada Chan.

  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::setSharedTimerFireTime):
09:36 Changeset [35874] by timothy@apple.com

After trying to add the expression, try again with quotes for
easier edition.

https://bugs.webkit.org/show_bug.cgi?id=20466

Reviewed by Tim Hatcher.

  • page/inspector/ObjectPropertiesSection.js: Added an evaluateExpression function.
09:33 Changeset [35873] by timothy@apple.com

Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.

https://bugs.webkit.org/show_bug.cgi?id=20462

Reviewed by Tim Hatcher.

  • page/inspector/inspector.js:
04:22 Changeset [35872] by jmalonzo@webkit.org

2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error

In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):

08/20/08:

23:52 Changeset [35871] by mrowe@apple.com

Fix build failure.

Reviewed by Jon Honeycutt.

  • bridge/c/c_instance.cpp:

(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.

22:03 Changeset [35870] by timothy@apple.com

Add Anthony Ricaud's blog.

Reviewed by Tim Hatcher.

  • config.ini: Add Anthony Ricaud's blog.
21:01 Changeset [35869] by mrowe@apple.com

Build fix.

17:33 Changeset [35868] by mitz@apple.com

WebCore:

Rubber-stamped by John Sullivan.

  • rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and rename related methods and variables accordingly.
  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents):

WebKit/mac:

Rubber-stamped by John Sullivan.

  • rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen, rename related methods and variables accordingly, and make -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen WebView API.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
  • WebView/WebView.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView setShouldUpdateWhileOffscreen:]): (-[WebView shouldUpdateWhileOffscreen]):
  • WebView/WebViewPrivate.h:
17:13 Changeset [35867] by beidson@apple.com

2008-08-20 Brady Eidson <beidson@apple.com>

Reviewed by Mitzpettel

<rdar://problem/6163636> - Many images broken in Mail

This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.

When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is CachedResource::PreloadReferenced.
16:20 Changeset [35866] by mrowe@apple.com

Switch to non-deprecated NSFileManager APIs.

In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.

Reviewed by Darin Adler.

16:04 Changeset [35865] by simon.fraser@apple.com

Reviewed by Dave Hyatt

getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464

  • fast/css/getComputedStyle-transform-expected.txt: Added.
  • fast/css/getComputedStyle-transform.html: Added.

(Missed these test files on last commit)

15:50 Changeset [35864] by zecke@webkit.org

2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed compile fix

Catch up with the JSValue::type elimination.

  • bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::defaultValue):
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::QtRuntimeConnectionMethod::call):
15:15 Changeset [35863] by mrowe@apple.com

2008-08-20 Chris Teague <chris.teague@gmail.com>

Reviewed by Mark Rowe.

Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined

  • ChangeLog:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
14:57 Changeset [35862] by simon.fraser@apple.com

Reviewed by Dave Hyatt

getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464

Test: fast/css/getComputedStyle-transform.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
  • rendering/style/RenderStyle.h:
14:04 Changeset [35861] by andersca@apple.com

WebCore:

2008-08-20 Josh Aas <joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit/mac:

2008-08-20 Josh Aas <joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)

  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):

WebKitExamplePlugins:

2008-08-20 Josh Aas <joshmoz@gmail.com>

Reviewed and landed by Anders.

<rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)

  • NetscapeCocoaPlugin/main.m: (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent):
13:46 Changeset [35860] by bdakin@apple.com

WebCore:

2008-08-20 Beth Dakin <bdakin@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.

This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.

  • dom/Node.cpp: (WebCore::Node::isInShadowTree):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Returns false if excludeFromTextSearch() is true.

In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):

Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):

  • editing/Editor.h:

excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:

(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.

WebKit/mac:

2008-08-20 Beth Dakin <bdakin@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/6145626>
Allows a WebKit client to mark a frame as not-text-searchable
through SPI.

  • WebView/WebFrame.mm: (-[WebFrame _setExcludeFromTextSearch:]):
  • WebView/WebFramePrivate.h:
12:10 Changeset [35859] by timothy@apple.com

Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.

Reviewed by Kevin McCullough.

  • English.lproj/localizedStrings.js: Updated the strings.
  • page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Renamed the boxPartValue function to createBoxPartElement and made it create the entire element. Made it understand how to get position style properties. Don't use the figure dash when 0px is used for positions, since the 0 is meaningful there. Instead use the figure dash when a position is auto.
  • page/inspector/inspector.css: Added a new rule for position.
12:01 Changeset [35858] by britto@apple.com

2008-08-20 Maxime Britto <britto@apple.com>

Reviewed by Ada Chan.

rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.

  • Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
  • WebView.cpp: (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns

2008-08-20 Maxime Britto <britto@apple.com>

Reviewed by Ada Chan.

rdar://5259746

Mouse events are sent to page while resizing window (affects Gmail)

  • DumpRenderTree/win/UIDelegate.h: (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
11:34 Changeset [35857] by cfleizach@apple.com

Qt build fix

11:28 Changeset [35856] by mitz@apple.com

Reviewed by Anders Carlsson.

  • avoid using a deprecated NSScroller method on Leopard
  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion):
04:40 Changeset [35855] by jmalonzo@webkit.org

2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk build fix

  • GNUmakefile.am:
  • page/AccessibilityTable.cpp: Change nil to 0 (WebCore::AccessibilityTable::cellForColumnAndRow):
03:40 Changeset [35854] by ap@webkit.org

Windows build fix.

  • API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
00:23 Changeset [35853] by ap@webkit.org

Reviewed by Geoff Garen.

Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.

08/19/08:

22:51 BuildingOnWindows edited by wilsong@gmail.com
(diff)
16:33 Changeset [35852] by eric@webkit.org

Reviewed by Geoff Garen.

Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.

I'll follow this up with actual *Skia.cpp files in a separate patch.

  • platform/graphics/AffineTransform.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • svg/graphics/SVGPaintServerPattern.h:
  • svg/graphics/SVGPaintServerSolid.h:
15:46 Changeset [35851] by sfalken@apple.com

Fix Windows build more.

  • WebCore.vcproj/WebCore.vcproj:
15:36 Changeset [35850] by timothy@apple.com

Fixes the Web Inspector flashing white while resizing after
highlighting a page element. Calling disableScreenUpdatesUntilFlush
when attaching and detaching the Inspector page highlight is bad,
since the browser window might not flush again for a while. So screen
updates could be disabled for long periods of time, causing backing store
flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
when attaching or detaching the child window.

Reviewed by John Sullivan and Kevin McCullough.

  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush. (-[WebNodeHighlight detach]): Ditto.
15:34 Changeset [35849] by sfalken@apple.com

Fix Windows build.

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
15:29 Changeset [35848] by sfalken@apple.com

Fix build.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
15:22 Changeset [35847] by kmccullough@apple.com

2008-08-19 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim and Mark.

Implement DTrace hooks for dashcode and instruments.

  • API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be turned on from a client. The DTrace probes were added within the profiler mechanism for performance reasons so the profiler must be started to enable tracing. (JSStartProfiling): (JSEndProfiling):
  • API/JSProfilerPrivate.h: Added. Ditto.
  • JavaScriptCore.exp: Exposing the start/stop methods to clients.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Tracing.d: Define the DTrace probes.
  • kjs/Tracing.h: Ditto.
  • profiler/ProfileGenerator.cpp: Implement the DTrace probes in the profiler. (KJS::ProfileGenerator::willExecute): (KJS::ProfileGenerator::didExecute):
15:05 Changeset [35846] by cfleizach@apple.com

<rdar://problem/4003764> Expose tables as AXTables

Exposes "data" tables in HTML as AXTables through accessibility

14:35 Changeset [35845] by sfalken@apple.com

Build fix.


  • kjs/operations.cpp: (KJS::equal):
13:18 Changeset [35844] by ap@webkit.org

Reviewed by Darin.

Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
is waiting for crash reporter to let it exit.

The fix does not work on Tiger, because the state of the process is indistinguishable from
other waiting processes, at least not with this technique.

  • Scripts/run-webkit-tests:
11:39 Changeset [35843] by sfalken@apple.com

Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.

  • WebCore.vcproj/QTMovieWin.vcproj:
11:33 Changeset [35842] by timothy@apple.com

Added support for console.count in the inspector.

Reviewed by Geoff Garen.

  • page/Console.cpp: (WebCore::Console::count):
  • page/Console.h:
  • page/Console.idl: Added console.count.
  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Clears m_counts. (WebCore::InspectorController::count): Updates the count number sing "title@source:line" as the identifier, and adds a message to the console.
  • page/InspectorController.h: Added m_counts.
11:33 Changeset [35841] by timothy@apple.com

Clear console.time timers when changing page.

Reviewed by Geoff Garen.

  • page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
10:55 Changeset [35840] by adele@apple.com

2008-08-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele.

Fix for <rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404

Ignore setVisible() when visibility doesn't change.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::setVisible):
10:01 Changeset [35839] by timothy@apple.com

Correctly remembers the attached state of the Web Inspector so
it opens in that state for the next window, or next launch.

Reviewed by Kevin McCullough.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey to YES in the user defaults. (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey to NO in the user defaults.
10:01 Changeset [35838] by timothy@apple.com

Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.

https://bugs.webkit.org/show_bug.cgi?id=20441

Reviewed by Kevin McCullough.

  • page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype._changeView): Call _sortProfile on the next profile before assigning it to this.profile. (WebInspector.ProfileView.prototype._sortData): Call _sortProfile. (WebInspector.ProfileView.prototype._sortProfile): Moves from _sortData and takes a profile argument. If the profile passed in matches the this.profile, then call refresh.
10:01 Changeset [35837] by timothy@apple.com

Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.

https://bugs.webkit.org/show_bug.cgi?id=20440

Reviewed by Kevin McCullough.

  • page/inspector/ProfileView.js: (WebInspector.ProfileView): Changed the default sort column. Also assign heavyProfile to profile, so the sortSelfTimeDescending call happens on the heavy profile before assigning to this.profile.
10:00 Changeset [35836] by timothy@apple.com

Fix an assertion when generating a heavy profile because the
empty value and deleted value of CallIdentifier where equal.

https://bugs.webkit.org/show_bug.cgi?id=20439

Reviewed by Dan Bernstein.

  • profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier use empty strings for URL and function name.
10:00 Changeset [35835] by timothy@apple.com

Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.

https://bugs.webkit.org/show_bug.cgi?id=20415

Reviewed by Kevin McCullough.

  • page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Set editable to true by default. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Factored out code into update, and calls update. (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title gets made later in onattach. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early if shouldRefreshChildren is true. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing. (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update. (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for this element (code moved from the constructor.) (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all sibling property elements. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call WebInspector.startEditing after rememebring some context. (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft for the list element, since it might have scrolled during editing. (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded then restore the state from the context. Then call update to restore the title. (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled if the user input and the previous input are the same. Call editingEnded, then call applyExpression to commit the user input. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression and stores the result on the object for the property name of this element. If the expression is empty, delete the property and remove the tree element.
  • page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused property on each ObjectPropertiesSection. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach since it is now implemented.
  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument that defaults to true if omitted. It specifies whether to call update on the scope chain.
  • page/inspector/inspector.css: New styles.
  • page/inspector/treeoutline.js: (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
10:00 Changeset [35834] by timothy@apple.com

Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.

https://bugs.webkit.org/show_bug.cgi?id=20428

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Add parenthesis around the expression. And add couple comments.
09:38 Changeset [35833] by kmccullough@apple.com

2008-08-19 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

-Implement a page() function to extract a common code pattern.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::assertCondition): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupEnd): (WebCore::Console::finishedProfiling): (WebCore::Console::warn): (WebCore::Console::framePage):
  • page/Console.h:
07:35 Changeset [35832] by ap@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg

Disabling the test while the crash is being investigated.

00:27 Changeset [35831] by ap@webkit.org

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=19347
<rdar://problem/5977562> Input methods do not work after switching to a password field
and back.

Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
reconversion) in a different way which doesn't conflict with context caching performed
by AppKit.

This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
because input methods are disabled in password fields. Attempting to reconvert text typed
with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
password field behavior and disable reconversion completely.

  • WebView/WebHTMLView.mm: (isInPasswordField): Factored out code to determine that the current selection is in a password field. (inputContext): Removed a hack that was breaking TSMGetActiveDocument(). (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields. (-[WebHTMLView textStorage]): Ditto.

08/18/08:

21:39 Changeset [35830] by darin@apple.com

JavaScriptCore:

2008-08-12 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • eliminate JSValue::type()

This will make it slightly easier to change the JSImmediate design without
having to touch so many call sites.

SunSpider says this change is a wash (looked like a slight speedup, but not
statistically significant).

  • API/JSStringRef.cpp: Removed include of JSType.h.
  • API/JSValueRef.cpp: Removed include of JSType.h. (JSValueGetType): Replaced use of JSValue::type() with JSValue::is functions.
  • VM/JSPropertyNameIterator.cpp: Removed type() implementation. (KJS::JSPropertyNameIterator::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • VM/JSPropertyNameIterator.h: Ditto.
  • VM/Machine.cpp: (KJS::fastIsNumber): Updated for name change. (KJS::fastToInt32): Ditto. (KJS::fastToUInt32): Ditto. (KJS::jsAddSlowCase): Updated toPrimitive caller for change from JSType to PreferredPrimitiveType. (KJS::jsAdd): Replaced calls to JSValue::type() with calls to JSValue::isString(). (KJS::jsTypeStringForValue): Replaced calls to JSValue::type() with multiple calls to JSValue::is -- we could make this a virtual function instead if we want to have faster performance. (KJS::Machine::privateExecute): Renamed JSImmediate::toTruncatedUInt32 to JSImmediate::getTruncatedUInt32 for consistency with other functions. Changed two calls of JSValue::type() to JSValue::isString().
  • kjs/GetterSetter.cpp: (KJS::GetterSetter::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType. (KJS::GetterSetter::isGetterSetter): Added.
  • kjs/GetterSetter.h:
  • kjs/JSCell.cpp: (KJS::JSCell::isString): Added. (KJS::JSCell::isGetterSetter): Added. (KJS::JSCell::isObject): Added.
  • kjs/JSCell.h: Eliminated type function. Added isGetterSetter. Made isString and isObject virtual. Changed toPrimitive to take PreferredPrimitiveType argument instead of JSType. (KJS::JSCell::isNumber): Use Heap::isNumber for faster performance. (KJS::JSValue::isGetterSetter): Added. (KJS::JSValue::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • kjs/JSImmediate.h: Removed JSValue::type() and replaced JSValue::toTruncatedUInt32 with JSValue::getTruncatedUInt32. (KJS::JSImmediate::isEitherImmediate): Added.
  • kjs/JSNotAnObject.cpp: (KJS::JSNotAnObject::toPrimitive): Changed to take PreferredPrimitiveType argument instead of JSType.
  • kjs/JSNotAnObject.h: Ditto.
  • kjs/JSNumberCell.cpp: (KJS::JSNumberCell::toPrimitive): Ditto.
  • kjs/JSNumberCell.h: (KJS::JSNumberCell::toInt32): Renamed from fastToInt32. There's no other "slow" version of this once you have a JSNumberCell, so there's no need for "fast" in the name. It's a feature that this hides the base class toInt32, which does the same job less efficiently (and has an additional ExecState argument). (KJS::JSNumberCell::toUInt32): Ditto.
  • kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Use isGetterSetter instead of type. (KJS::JSObject::getPrimitiveNumber): Use PreferredPrimitiveType. (KJS::JSObject::defaultValue): Ditto. (KJS::JSObject::defineGetter): Use isGetterSetter. (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::lookupGetter): Ditto. (KJS::JSObject::lookupSetter): Ditto. (KJS::JSObject::toNumber): Use PreferredPrimitiveType. (KJS::JSObject::toString): Ditto. (KJS::JSObject::isObject): Added.
  • kjs/JSObject.h: (KJS::JSObject::inherits): Call the isObject from JSCell; it's now hidden by our override of isObject. (KJS::JSObject::getOwnPropertySlotForWrite): Use isGetterSetter instead of type. (KJS::JSObject::getOwnPropertySlot): Ditto. (KJS::JSObject::toPrimitive): Use PreferredPrimitiveType.
  • kjs/JSString.cpp: (KJS::JSString::toPrimitive): Use PreferredPrimitiveType. (KJS::JSString::isString): Added.
  • kjs/JSString.h: Ditto.
  • kjs/JSValue.h: Removed type(), added isGetterSetter(). Added PreferredPrimitiveType enum and used it as the argument for the toPrimitive function. (KJS::JSValue::getBoolean): Simplified a bit an removed a branch.
  • kjs/collector.cpp: (KJS::typeName): Changed to use JSCell::is functions instead of calling JSCell::type.
  • kjs/collector.h: (KJS::Heap::isNumber): Renamed from fastIsNumber.
  • kjs/nodes.h: Added now-needed include of JSType, since the type is used here to record types of values in the tree.
  • kjs/operations.cpp: (KJS::equal): Rewrote to no longer depend on type(). (KJS::strictEqual): Ditto.

JavaScriptGlue:

2008-08-12 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • JSUtils.cpp: (KJSValueToCFTypeInternal): Replaced uses of JSValue::type() with JSValue::is functions.
  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot): Ditto. (UserObjectImp::toPrimitive): Take PreferredPrimitiveType argument instead of JSType argument.
  • UserObjectImp.h: Ditto.

WebCore:

2008-08-12 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • bridge/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean, since that's never passed.
  • bridge/c/c_instance.h: Ditto.
  • bridge/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use JSValue::is functions instead of JSValue::type(). Removed unneeded code to handle "unspecified".
  • bridge/jni/jni_instance.cpp: (JavaInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
  • bridge/jni/jni_instance.h: Ditto.
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::convertValueToJObject): Use JSValue::is functions instead of JSValue::type().
  • bridge/objc/objc_instance.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed unused argument.
  • bridge/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): Removed unused argument. (ObjcInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean and another dead code path for unknown types.
  • bridge/objc/objc_runtime.h: Take PreferredPrimitiveType argument instead of JSType argument. Removed override of type() that caused the fallback object to return "UndefinedType" when there is no invokeUndefinedMethodFromWebScript:withArguments: method defined. That didn't accomplish much, since most checks for undefined don't ever call type().
  • bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::defaultValue): Ditto.
  • bridge/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument. Removed unneeded code to handle boolean.
  • bridge/qt/qt_instance.h: Ditto.
  • bridge/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): Removed unsed argument.
  • bridge/runtime_object.cpp: (RuntimeObjectImp::defaultValue): Take PreferredPrimitiveType argument instead of JSType argument.
  • bridge/runtime_object.h: Ditto.

WebKit/mac:

2008-08-12 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • eliminate JSValue::type()
  • WebView/WebView.mm: (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead of a switch on JSValue::type().

LayoutTests:

2008-08-12 Darin Adler <darin@apple.com>

Reviewed by Geoff.

  • added a test since I had to rewrite the == and === operators
  • fast/js/equality-expected.txt: Added.
  • fast/js/equality.html: Added.
  • fast/js/resources/equality.js: Added.
17:42 Changeset [35829] by britto@apple.com

2008-08-18 Maxime Britto <britto@apple.com>

Reviewed by Adele.

<rdar://6157207> Mouse pointer does not change when new window is opened after pan-scrolling original window
Related to the discussion from rdar://6102511 , we should disable every key event (except for the esc key which stops the panning).
We shouldn't be able to create another window while we are in pan scrolling.
Other browsers behaviors :

FF3 : Most of the keys are disabled, there is no way to create another window while in panscroll mode
IE7 : Keys are not disabled but stops immediately the panning.

This patch matches FF3 behavior by disabling every key but the esc key.

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Change the cursor back to the regular arrow cursor when the pannning is stopped. (WebCore::EventHandler::keyEvent): When a key event is received while in panning or autoscroll we swallow the event early.
17:20 Changeset [35828] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received

Test: fast/replaced/max-width-percent.html

Added an includeMaxWidth boolean to RenderBox::calcReplaedWidth().
When false, max-width is not factored into the
calculation.
Changed RenderReplaced and subclasses' calcPrefWidths() to call
calcReplacedWidth(false) and then apply max-width only if it has a
fixed, positive value.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidth):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcPrefWidths):
  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::calcPrefWidths):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): (WebCore::RenderVideo::calcPrefWidths):
  • rendering/RenderVideo.h:

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5862634> REGRESSION (3.1.1): In iChat, inline image not resizable past current size after another IM is received
  • fast/replaced/max-width-percent.html: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.checksum: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.png: Added.
  • platform/mac/fast/replaced/max-width-percent-expected.txt: Added.
16:08 Changeset [35827] by simon.fraser@apple.com

Make transition_shorthand_parsing.html a text-only test.

  • fast/css/transition_shorthand_parsing-expected.txt: Added.
  • fast/css/transition_shorthand_parsing.html:
  • platform/mac/fast/css/transition_shorthand_parsing-expected.txt:
15:47 Changeset [35826] by mrowe@apple.com

2008-08-18 Daniel Macks <dmacks@netspace.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=20410
More portable/self-documenting replacement for SIZE_MAX.

  • platform/network/curl/FormDataStreamCurl.cpp: (WebCore::FormDataStream::read):
15:11 Changeset [35825] by simon.fraser@apple.com

Reviewed by Dave Hyatt

Need to make sure we have an Animation in the AnimationList
before setting the initial value.
https://bugs.webkit.org/show_bug.cgi?id=20408

Test: fast/css/transition_shorthand_parsing.html

  • css/CSSStyleSelector.cpp:
14:55 Changeset [35824] by kevino@webkit.org

Build fix for Win. Don't include the libxml/libxslt directories in the
include path, it picks up the wrong Pattern.h in that case.

13:53 Changeset [35823] by kmccullough@apple.com

2008-08-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

If there are no nodes in a profile all the time should be attributed to
(idle)

  • profiler/Profile.cpp: If ther are no nodes make sure we still process the head. (KJS::Profile::forEach):
  • profiler/ProfileGenerator.cpp: Remove some useless code. (KJS::ProfileGenerator::stopProfiling):
13:53 Changeset [35822] by jchaffraix@webkit.org

WebCore:

2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20347: [XBL] Add support for DocumentXBL interface

  • Add a custom NamedNodeMap for document.bindingsDocument as it is a static map that throws NO_MODIFICATIN_ALLOWED_ERR on modification.

Test: fast/xbl/xbl-bindingDocuments.html

  • GNUmakefile.am: Add NamedStaticDocumentMap.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Initialize m_bindingDocuments. (WebCore::Document::~Document): Zero m_bindingDocuments. (WebCore::Document::bindingDocuments): Getter method. (WebCore::Document::loadBindingDocument): Stub method as we need an helper class to load bindings. (WebCore::Document::createBindingDocumentsIfNeeded):
  • dom/Document.h:
  • dom/Document.idl: Add documentXBL interface.
  • dom/NamedStaticDocumentMap.cpp: Added. (WebCore::NamedStaticDocumentMap::NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::~NamedStaticDocumentMap): (WebCore::NamedStaticDocumentMap::getNamedItem): (WebCore::NamedStaticDocumentMap::removeNamedItem): (WebCore::NamedStaticDocumentMap::getNamedItemNS): (WebCore::NamedStaticDocumentMap::removeNamedItemNS): (WebCore::NamedStaticDocumentMap::setNamedItem): (WebCore::NamedStaticDocumentMap::item): (WebCore::NamedStaticDocumentMap::addItem):
  • dom/NamedStaticDocumentMap.h: Added. (WebCore::NamedStaticDocumentMap::create): (WebCore::NamedStaticDocumentMap::length): (WebCore::NamedStaticDocumentMap::clear): Custom NamedNodeMap that match the specification.

LayoutTests:

2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20347: [XBL] Add support for DocumentXBL interface

  • fast/xbl/resources/bindingDocuments.js: Added.
  • fast/xbl/xbl-bindingDocuments-expected.txt: Added.
  • fast/xbl/xbl-bindingDocuments.html: Added.
13:21 Changeset [35821] by kmccullough@apple.com

2008-08-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

<rdar://problem/6150593> JSProfiler: Empty profiles disappear when there
is another profile.

  • page/inspector/ProfilesPanel.js:
12:55 Changeset [35820] by kmccullough@apple.com

2008-08-18 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6150642> REGRESSION: Closing the Web Inspector clears
all console messages

  • page/inspector/Console.js:
08:54 Changeset [35819] by jchaffraix@webkit.org

WebCore:

2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20263: [XBL] Add loading code for XBLBinding

Test: fast/xbl/xbl-empty-fragment-loadBinding.html

  • GNUmakefile.am: Add XBLBinding.cpp.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • xbl/XBLBinding.cpp: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::~XBLBinding): (WebCore::XBLBinding::setXBLDocument): (WebCore::XBLBinding::getBindingElement):
  • xbl/XBLBinding.h: Inherit from CachedResourceClient to use the Cache management. Also added the bound element, the <binding> element as members.


  • xbl/XBLBindingManager.cpp: Changed Vector<XBLBinding>* to Vector<XBLBinding*>* as we were taking a pointer to a local value.


(WebCore::XBLBindingManager::addBinding): Ditto.
(WebCore::XBLBindingManager::removeBinding): Ditto.
(WebCore::XBLBindingManager::hasBinding): Ditto.
(WebCore::XBLBindingManager::removeAllBindings): Ditto.

  • xbl/XBLBindingManager.h: Ditto.

LayoutTests:

2008-08-18 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.


Test case for bug 20263: [XBL] Add loading code for XBLBinding


  • fast/xbl/resources/xbl-failed-binding.xbl: Added.
  • fast/xbl/resources/xbl-passed-binding.xbl: Added.
  • fast/xbl/xbl-empty-fragment-loadBinding-expected.txt: Added.
  • fast/xbl/xbl-empty-fragment-loadBinding.html: Added.


07:54 Changeset [35818] by mrowe@apple.com

Upgrade to WordPress 2.6.1.

04:20 Changeset [35817] by jmalonzo@webkit.org

2008-08-18 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Fixed Canvas for Cairo. Stroke and fill colors didn't work after
the canvas clean up.

https://bugs.webkit.org/show_bug.cgi?id=20405

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect):
04:14 Changeset [35816] by jmalonzo@webkit.org

2008-08-18 Alp Toker <alp@nuanti.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20350
[GTK] Get DumpRenderTree working

WebKit/gtk:

Add a private function to WebFrame to dump the render tree as required
for the DumpRenderTree testing tool.

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

WebKitTools/DumpRenderTree/gtk:

Fixes and enhancements to DumpRenderTree. With these changes, the test
suite can now complete a run producing text and render tree dumps.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpFramesAsText): (dump): (runTest): (webViewLoadFinished): (webViewWindowObjectCleared): (webViewConsoleMessage): (webViewScriptAlert): (webViewScriptPrompt): (webViewScriptConfirm): (webViewTitleChanged): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList): (LayoutTestController::pathToLocalResource): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (waitToDumpWatchdogFired): (LayoutTestController::windowCount):
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (JSStringCopyUTF8CString): (ScriptItem::invoke):
01:09 Changeset [35815] by ap@webkit.org

Reviewed by Maciej.

Make JSGlobalContextRetain/Release actually work.

  • API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): Ref/deref global data to give checking for globalData.refCount() some sense.
  • API/tests/testapi.c: (main): Added a test for this bug.
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData): While checking for memory leaks, found that JSGlobalData::emptyList has changed to a pointer, but it was not destructed, causing a huge leak in run-webkit-tests --threaded.
Note: See TracTimeline for information about the timeline view.