Timeline
08/23/08:
- 01:16 Changeset [35900] by
-
2008-08-23 Cameron Zwarich < cwzwarich@uwaterloo.ca>
Rubber-stamped by Mark Rowe.
Remove modelines.
JavaScriptCore:
- API/APICast.h:
- API/JSBase.cpp:
- API/JSCallbackConstructor.cpp:
- API/JSCallbackConstructor.h:
- API/JSCallbackFunction.cpp:
- API/JSCallbackFunction.h:
- API/JSCallbackObject.cpp:
- API/JSCallbackObject.h:
- API/JSCallbackObjectFunctions.h:
- API/JSClassRef.cpp:
- API/JSContextRef.cpp:
- API/JSObjectRef.cpp:
- API/JSProfilerPrivate.cpp:
- API/JSStringRef.cpp:
- API/JSStringRefBSTR.cpp:
- API/JSStringRefCF.cpp:
- API/JSValueRef.cpp:
- API/tests/JSNode.c:
- API/tests/JSNode.h:
- API/tests/JSNodeList.c:
- API/tests/JSNodeList.h:
- API/tests/Node.c:
- API/tests/Node.h:
- API/tests/NodeList.c:
- API/tests/NodeList.h:
- API/tests/minidom.c:
- API/tests/minidom.js:
- API/tests/testapi.c:
- API/tests/testapi.js:
- JavaScriptCore.pro:
- kjs/FunctionConstructor.h:
- kjs/FunctionPrototype.h:
- kjs/JSArray.h:
- kjs/JSString.h:
- kjs/JSWrapperObject.cpp:
- kjs/NumberConstructor.h:
- kjs/NumberObject.h:
- kjs/NumberPrototype.h:
- kjs/lexer.h:
- kjs/lookup.h:
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/HashCountedSet.h:
- wtf/HashFunctions.h:
- wtf/HashIterators.h:
- wtf/HashMap.h:
- wtf/HashSet.h:
- wtf/HashTable.h:
- wtf/HashTraits.h:
- wtf/ListHashSet.h:
- wtf/ListRefPtr.h:
- wtf/Noncopyable.h:
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/Platform.h:
- wtf/RefPtr.h:
- wtf/RefPtrHashMap.h:
- wtf/RetainPtr.h:
- wtf/UnusedParam.h:
- wtf/Vector.h:
- wtf/VectorTraits.h:
- wtf/unicode/Unicode.h:
- wtf/unicode/icu/UnicodeIcu.h:
WebCore:
- WebCore.pro:
- bridge/testbindings.cpp:
- dom/DocPtr.h:
- loader/SubstituteData.h:
- page/Chrome.cpp:
- page/Chrome.h:
- page/ChromeClient.h:
- page/Frame.h:
- page/FrameLoadRequest.h:
- page/FrameTree.cpp:
- page/FrameTree.h:
- page/Page.h:
- page/mac/ChromeMac.mm:
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceErrorBase.cpp:
- platform/network/ResourceErrorBase.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/ResourceRequestBase.cpp:
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceError.h:
- platform/network/cf/ResourceRequest.h:
- platform/network/cf/ResourceRequestCFNet.h:
- platform/network/cf/ResourceResponse.h:
- platform/network/cf/ResourceResponseCFNet.h:
- platform/network/curl/ResourceError.h:
- platform/network/curl/ResourceRequest.h:
- platform/network/curl/ResourceResponse.h:
- platform/network/mac/ResourceError.h:
- platform/network/mac/ResourceErrorMac.mm:
- platform/network/mac/ResourceRequest.h:
- platform/network/mac/ResourceRequestMac.mm:
- platform/network/mac/ResourceResponse.h:
- platform/network/mac/ResourceResponseMac.mm:
- platform/network/qt/ResourceError.h:
- platform/network/qt/ResourceRequest.h:
- platform/network/qt/ResourceResponse.h:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/soup/ResourceError.h:
- platform/network/soup/ResourceRequest.h:
- platform/network/soup/ResourceResponse.h:
- 00:16 Changeset [35899] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix < rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
Test: fast/table/vertical-align-baseline.html
- rendering/RenderTable.cpp: (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the baseline of the first table row, if there is one, -1 otherwise.
- rendering/RenderTable.h:
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::baselinePosition): Changed to follow the CSS2.1 definition of the baseline of a table cell.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns the baseline of the first row in the section.
- rendering/RenderTableSection.h:
LayoutTests:
Reviewed by Dave Hyatt.
- test and updated results for < rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline
- fast/table/vertical-align-baseline.html: Added.
- platform/mac/fast/table/form-with-table-style-expected.checksum:
- platform/mac/fast/table/form-with-table-style-expected.png:
- platform/mac/fast/table/form-with-table-style-expected.txt:
- platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
- platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
- platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
- platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
08/22/08:
- 20:17 Changeset [35898] by
-
2008-08-22 Cameron Zwarich < cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Some cleanup to match our coding style.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/ExecState.cpp:
- kjs/ExecState.h:
- kjs/completion.h:
- kjs/identifier.cpp: (KJS::Identifier::equal): (KJS::CStringTranslator::hash): (KJS::CStringTranslator::equal): (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::equal): (KJS::UCharBufferTranslator::translate): (KJS::Identifier::remove):
- kjs/operations.h:
- 16:44 Changeset [35897] by
-
2008-08-18 Jon Honeycutt < jhoneycutt@apple.com>
Add SPI to make a Windows WebView transparent.
Reviewed by Dan Bernstein.
- Interfaces/IWebViewPrivate.idl:
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage): Call updateBackground() when a new frame is attached, matching the Mac.
- WebFrame.cpp: (WebFrame::updateBackground): Propagate WebView transparency to ourself and our child frames.
- WebFrame.h:
- WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): Pass m_transparent when creating a GraphicsContext, so the context will be created with an alpha channel. (WebView::setTransparent): (WebView::transparent):
- WebView.h:
- 16:44 Changeset [35896] by
-
2008-08-12 Jon Honeycutt < jhoneycutt@apple.com>
Add SPI to get a handle to the WebView's backing store bitmap.
Reviewed by Dan Bernstein.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::backingStore):
- WebView.h:
- 13:35 Changeset [35895] by
-
Rolls out r35834 because it caused a regression in the Inspector's
Console where some expressions always threw a syntax error.
- page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Removes parenthesis around the expression.
- 12:39 Changeset [35894] by
-
2008-08-22 Anders Carlsson < andersca@apple.com>
Fix build for real this time.
- UserObjectImp.h:
- 12:14 Changeset [35893] by
-
2008-08-22 Anders Carlsson < andersca@apple.com>
Fix build.
- UserObjectImp.cpp: (UserObjectImp::toPrimitive):
- UserObjectImp.h:
- 11:39 Changeset [35892] by
-
Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.
WebCore:
2008-08-22 Timothy Hatcher < timothy@apple.com>
Makes getStyleProperty return a value for the overflow property
when overflow-x and overflow-y are equal.
Reviewed by Dan Bernstein.
Test: fast/css/overflow-property.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
LayoutTests:
2008-08-22 Timothy Hatcher < timothy@apple.com>
Test for the tests the parsing and retrieval of the overflow,
overflow-x and overflow-y properties
Reviewed by Dan Bernstein.
- fast/css/overflow-property-expected.txt: Added.
- fast/css/overflow-property.html: Added.
- 11:39 Changeset [35891] by
-
Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.
Reviewed by Darin Adler.
- page/inspector/treeoutline.js: (TreeOutline._removeChildren): Remove the offsetTop call that was forcing a layout, since layout causes scroll positions to be clamped to the new scrollHeight/Width. Layout will happen normally when needed.
- 10:38 Changeset [35890] by
-
Reviewed by Darin Adler
css3/transform-computed-style-001.html is better tested
by fast/css/getComputedStyle-transform.html, so removed.
https://bugs.webkit.org/show_bug.cgi?id=20477
- css3/transform-computed-style-001-expected.txt: Removed.
- css3/transform-computed-style-001.fhtml: Removed.
- 09:25 Changeset [35889] by
-
wx build fix. Add AccessibilityTable sources.
08/21/08:
- 23:29 Changeset [35888] by
-
WebCore:
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- fix < rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported ascent and 100% to its reported descent.
LayoutTests:
Reviewed by Jon Honeycutt and Alexey Proskuryakov.
- test for < rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
- platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.
- 19:20 Changeset [35887] by
-
2008-08-21 Jonas Klink < klinktech@gmail.com>
Reviewed by Jon Honeycutt.
Fix https://bugs.webkit.org/show_bug.cgi?id=20231
Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
Per < http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
from accNavigate if no screen element is found in the specified direction.
- AccessibleBase.cpp: (AccessibleBase::accNavigate):
- 19:20 Changeset [35886] by
-
2008-08-21 Jonas Klink < klinktech@gmail.com>
Reviewed by Jon Honeycutt.
Fix http://bugs.webkit.org/show_bug.cgi?id=20230
Bug 20230: get_accState should be testing state on childObj
Also initializes output parameter action to 0 in get_accDefaultAction.
- AccessibleBase.cpp: (AccessibleBase::get_accState): (AccessibleBase::get_accDefaultAction):
- 19:10 Changeset [35885] by
-
Fix bug number in ChangeLog.
- 19:07 Changeset [35884] by
-
2008-08-21 Kalle Vahlman < kalle.vahlman@movial.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] Crash on some pages due to a plugin
Fix handling of badly formatted and empty plugin mime descriptions
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
- 19:07 Changeset [35883] by
-
2008-08-21 Kevin Watters < kevinwatters@gmail.com>
Reviewed by Darin Adler.
Follow other ports (and IE) in ImageSourceWx.cpp never to return an
animated GIF frame duration of less than 50ms.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::frameDurationAtIndex):
- 17:39 Changeset [35882] by
-
2008-08-21 Maxime Britto < britto@apple.com>
Reviewed by Kevin McCullough.
Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
https://bugs.webkit.org/show_bug.cgi?id=20451
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.
(WebCore::EventHandler::handleMousePressEvent): ditto
2008-08-21 Maxime Britto < britto@apple.com>
Reviewed by Kevin McCullough.
rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
https://bugs.webkit.org/show_bug.cgi?id=20451
This test can be run automatically or manually as well.
- fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
- fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
- fast/events/resources/big-page-with-overflow-hidden.html: Added.
- 16:54 Changeset [35881] by
-
Small optimization for when the dividers in the Inspector's
Resources panel are updated.
Reviewed by Tim Hatcher.
- page/inspector/ResourcesPanel.js: (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Combind a for loop and clone the divider element.
- 16:44 Changeset [35880] by
-
Reviewed by Mark Rowe
Make build-launcher-app work when run from a git repository.
https://bugs.webkit.org/show_bug.cgi?id=20478
* BuildSlaveSupport/build-launcher-app:
- 16:35 Changeset [35879] by
-
2008-08-21 Chris Marrin < cmarrin@apple.com>
Allow 0 (without units) for Time eg. duration
Fix for https://bugs.webkit.org/show_bug.cgi?id=20467
Reviewed by Dave Hyatt.
Test: css1/units/zero-duration-without-units.html
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit):
- 13:13 Changeset [35878] by
-
Make deleting all text while editing a DOM attribute in
the Inspector delete the attribute. This also fixes
an exception that would happen before.
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted): Don't check for hasAttributes on the parseElement, continuing through the function will correctly remove the attribute. If the parseElement is null, call _editingCancelled not editingCancelled, this fixes an exception.
- 13:12 Changeset [35877] by
-
Update the Inspector's Metrics pane when editing in
the Styles pane. This makes sure the metrics shown
always match what the Styles pane shows.
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add event listeners for the "style edited" and "style property toggled" events, so the Metrics pane is updated. (WebInspector.ElementsPanel.prototype._stylesPaneEdited): Update the Metrics pane.
- page/inspector/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled): Dispatch the "style property toggled" event. (WebInspector.StylePropertyTreeElement.prototype.editingCancelled): Dispatch the "style edited" event when the CSS text is restored. (WebInspector.StylePropertyTreeElement.prototype.applyStyleText): Dispatch the "style edited" event.
- 13:12 Changeset [35876] by
-
Make the Inspector's Metrics sidebar pane editable.
https://bugs.webkit.org/show_bug.cgi?id=17218
rdar://problem/5732818
Reviewed by Kevin McCullough.
- page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add an event listener for the "metrics edited" event, so the Styles pane is updated.
- page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Remember the node so future updates work. Add a double click event listener for the metric values to start editing. (WebInspector.MetricsSidebarPane.prototype.startEditing): Call WebInspector.startEditing with some context. (WebInspector.MetricsSidebarPane.prototype.editingCancelled): (WebInspector.MetricsSidebarPane.prototype.editingCommitted): Set the user input on the elements inline style. Fire the "metrics edited" event.
- 11:42 Changeset [35875] by
-
Fix a race condition in Windows timer code.
Timer function could end up being called with a 0 timer, leading to a Windows exception.
Don't post a timer message if one is already pending.
Reviewed by Ada Chan.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::clearTimer): (WebCore::queueTimerProc): (WebCore::setSharedTimerFireTime):
- 09:36 Changeset [35874] by
-
After trying to add the expression, try again with quotes for
easier edition.
Reviewed by Tim Hatcher.
- page/inspector/ObjectPropertiesSection.js: Added an evaluateExpression function.
- 09:33 Changeset [35873] by
-
Perform Inspector searches on search event to clear results when
clicking the cross to empty it. Delete the lastQuery when the field
is emptied in order to perform the search if exactly the same query
is entered next.
Reviewed by Tim Hatcher.
- page/inspector/inspector.js:
- 04:22 Changeset [35872] by
-
2008-08-21 Marco Barisione < marco.barisione@collabora.co.uk>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=19656
[SOUP] The gio code should call didFail() instead of
didFinishLoading() in case of error
In case of error call didFail() instead of didReceiveResponse() and
didFinishLoading().
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
08/20/08:
- 23:52 Changeset [35871] by
-
Fix build failure.
Reviewed by Jon Honeycutt.
* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.
- 22:03 Changeset [35870] by
-
Add Anthony Ricaud's blog.
Reviewed by Tim Hatcher.
- config.ini: Add Anthony Ricaud's blog.
- 21:01 Changeset [35869] by
-
Build fix.
- 17:33 Changeset [35868] by
-
WebCore:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and rename related methods and variables accordingly.
- WebCore.base.exp:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen):
- page/FrameView.h:
- platform/ScrollView.h:
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::updateContents):
WebKit/mac:
Rubber-stamped by John Sullivan.
- rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen, rename related methods and variables accordingly, and make -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen WebView API.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
- WebView/WebFrameInternal.h:
- WebView/WebHTMLView.mm: (-[WebHTMLView windowWillOrderOnScreen:]):
- WebView/WebView.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView setBackgroundColor:]): (-[WebView setDrawsBackground:]): (-[WebView setShouldUpdateWhileOffscreen:]): (-[WebView shouldUpdateWhileOffscreen]):
- WebView/WebViewPrivate.h:
- 17:13 Changeset [35867] by
-
2008-08-20 Brady Eidson < beidson@apple.com>
Reviewed by Mitzpettel
< rdar://problem/6163636> - Many images broken in Mail
This can be traced back to the preload scanner. With that change, CachedResources are created a lot
sooner than before and confuse the WebArchive machinery.
When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
machinery and nothing is known about where the data will eventually come from.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Ignore a CachedResource if its preloadResult is CachedResource::PreloadReferenced.
- 16:20 Changeset [35866] by
-
Switch to non-deprecated NSFileManager APIs.
In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.
Reviewed by Darin Adler.
- 16:04 Changeset [35865] by
-
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
- fast/css/getComputedStyle-transform-expected.txt: Added.
- fast/css/getComputedStyle-transform.html: Added.
(Missed these test files on last commit)
- 15:50 Changeset [35864] by
-
2008-08-20 Holger Hans Peter Freyther < zecke@selfish.org>
Unreviewed compile fix
Catch up with the JSValue::type elimination.
- bridge/qt/qt_instance.cpp: (KJS::Bindings::QtRuntimeObjectImp::construct): (KJS::Bindings::QtInstance::defaultValue):
- bridge/qt/qt_runtime.cpp: (KJS::Bindings::QtRuntimeConnectionMethod::call):
- 15:15 Changeset [35863] by
-
2008-08-20 Chris Teague < chris.teague@gmail.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=20449
Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined
- ChangeLog:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 14:57 Changeset [35862] by
-
Reviewed by Dave Hyatt
getComputedStyle() for webkitTransform should return a transform
that does not have the transform origin baked into it.
https://bugs.webkit.org/show_bug.cgi?id=20464
Test: fast/css/getComputedStyle-transform.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
- rendering/style/RenderStyle.h:
- 14:04 Changeset [35861] by
-
WebCore:
2008-08-20 Josh Aas < joshmoz@gmail.com>
Reviewed and landed by Anders.
< rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- bridge/npapi.h: (_NPCocoaEvent::):
WebKit/mac:
2008-08-20 Josh Aas < joshmoz@gmail.com>
Reviewed and landed by Anders.
< rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
WebKitExamplePlugins:
2008-08-20 Josh Aas < joshmoz@gmail.com>
Reviewed and landed by Anders.
< rdar://problem/6163636>
rename NPCocoaEvent's "event" struct to "data" (20446)
- NetscapeCocoaPlugin/main.m: (handleMouseEvent): (handleKeyboardEvent): (NPP_HandleEvent):
- 13:46 Changeset [35860] by
-
WebCore:
2008-08-20 Beth Dakin < bdakin@apple.com>
Reviewed by Darin.
Fix for < rdar://problem/6145626>
This patch fixes a number of remaining problems getting
disconnected frames to work correctly with markAllMatchesForText()
and findString(). Details inline.
This was a static helper function in Frame, but this patch requires
the same functionality in Editor, so I just added it as a function
on Node.
- dom/Node.cpp: (WebCore::Node::isInShadowTree):
- dom/Node.h:
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea): Returns false if excludeFromTextSearch() is true.
In a normal (non-disconnected) frame, findString returns a range of
the document node if the text is not found in the frame. I changed
firstVisibleRange and lastVisibleRange to match that behavior when
the text is not found
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
Here are the bulk of the changes in the patch. A lot of text was
not being found in disconnected frames because I failed to account
for all of the possible problems associated with shadow trees. That
is fixed here.
(WebCore::Editor::nextVisibleRange):
- editing/Editor.h:
excludeFromTextSearch() is new. It allows a WebKit client to mark a
frame as not-text-searchable through SPI.
- WebCore.base.exp:
- page/Frame.cpp: (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
(WebCore::Frame::findString):
(WebCore::Frame::markAllMatchesForText): I kept running into an
assertion failure in paining code because of the forced paint on
empty visible rects.
WebKit/mac:
2008-08-20 Beth Dakin < bdakin@apple.com>
Reviewed by Darin.
Fix for < rdar://problem/6145626>
Allows a WebKit client to mark a frame as not-text-searchable
through SPI.
- WebView/WebFrame.mm: (-[WebFrame _setExcludeFromTextSearch:]):
- WebView/WebFramePrivate.h:
- 12:10 Changeset [35859] by
-
Adds a positon box to the Inspector's Metrics sidebar
pane. When an element is not statically positioned, there
is now a position box that show top, right, bottom and
left computed values.
Reviewed by Kevin McCullough.
- English.lproj/localizedStrings.js: Updated the strings.
- page/inspector/MetricsSidebarPane.js: (WebInspector.MetricsSidebarPane.prototype.update): Renamed the boxPartValue function to createBoxPartElement and made it create the entire element. Made it understand how to get position style properties. Don't use the figure dash when 0px is used for positions, since the 0 is meaningful there. Instead use the figure dash when a position is auto.
- page/inspector/inspector.css: Added a new rule for position.
- 12:01 Changeset [35858] by
-
2008-08-20 Maxime Britto < britto@apple.com>
Reviewed by Ada Chan.
rdar://5259746
Mouse events are sent to page while resizing window (affects Gmail)
In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
- Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
- WebView.cpp: (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
2008-08-20 Maxime Britto < britto@apple.com>
Reviewed by Ada Chan.
Mouse events are sent to page while resizing window (affects Gmail)
- DumpRenderTree/win/UIDelegate.h: (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
- 11:34 Changeset [35857] by
-
Qt build fix
- 11:28 Changeset [35856] by
-
Reviewed by Anders Carlsson.
- avoid using a deprecated NSScroller method on Leopard
- platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion):
- 04:40 Changeset [35855] by
-
2008-08-20 Jan Michael Alonzo < jmalonzo@webkit.org>
Reviewed by Oliver Hunt.
Gtk build fix
- GNUmakefile.am:
- page/AccessibilityTable.cpp: Change nil to 0 (WebCore::AccessibilityTable::cellForColumnAndRow):
- 03:40 Changeset [35854] by
-
Windows build fix.
- API/WebKitAvailability.h: Define DEPRECATED_ATTRIBUTE.
- 00:23 Changeset [35853] by
-
Reviewed by Geoff Garen.
Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
08/19/08:
- 22:51 BuildingOnWindows edited by
- (diff)
- 16:33 Changeset [35852] by
-
Reviewed by Geoff Garen.
Add the beginnings of Skia graphics support to WebCore
as I try to begin the long process of un-forking the changes
needed to WebCore to make Andriod's WebCore build.
I'll follow this up with actual *Skia.cpp files in a separate patch.
- platform/graphics/AffineTransform.h:
- platform/graphics/FloatPoint.h:
- platform/graphics/FloatRect.h:
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntPoint.h:
- platform/graphics/IntRect.h:
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.h:
- 15:46 Changeset [35851] by
-
Fix Windows build more.
- WebCore.vcproj/WebCore.vcproj:
- 15:36 Changeset [35850] by
-
Fixes the Web Inspector flashing white while resizing after
highlighting a page element. Calling disableScreenUpdatesUntilFlush
when attaching and detaching the Inspector page highlight is bad,
since the browser window might not flush again for a while. So screen
updates could be disabled for long periods of time, causing backing store
flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
when attaching or detaching the child window.
Reviewed by John Sullivan and Kevin McCullough.
- WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush. (-[WebNodeHighlight detach]): Ditto.
- 15:34 Changeset [35849] by
-
Fix Windows build.
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
- 15:29 Changeset [35848] by
-
Fix build.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
- 15:22 Changeset [35847] by
-
2008-08-19 Kevin McCullough < kmccullough@apple.com>
Reviewed by Tim and Mark.
Implement DTrace hooks for dashcode and instruments.
- API/JSProfilerPrivate.cpp: Added. Expose SPI so that profiling can be turned on from a client. The DTrace probes were added within the profiler mechanism for performance reasons so the profiler must be started to enable tracing. (JSStartProfiling): (JSEndProfiling):
- API/JSProfilerPrivate.h: Added. Ditto.
- JavaScriptCore.exp: Exposing the start/stop methods to clients.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/Tracing.d: Define the DTrace probes.
- kjs/Tracing.h: Ditto.
- profiler/ProfileGenerator.cpp: Implement the DTrace probes in the profiler. (KJS::ProfileGenerator::willExecute): (KJS::ProfileGenerator::didExecute):
- 15:05 Changeset [35846] by
-
< rdar://problem/4003764> Expose tables as AXTables
Exposes "data" tables in HTML as AXTables through accessibility
- 14:35 Changeset [35845] by
-
Build fix.
- kjs/operations.cpp: (KJS::equal):
- 13:18 Changeset [35844] by
-
Reviewed by Darin.
Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
is waiting for crash reporter to let it exit.
The fix does not work on Tiger, because the state of the process is indistinguishable from
other waiting processes, at least not with this technique.
- Scripts/run-webkit-tests:
- 11:39 Changeset [35843] by
-
Build fix.
Add buildfailed support to stop builds early (preventing inaccurate error messages).
Add missing post-build rule to Release.
- WebCore.vcproj/QTMovieWin.vcproj:
- 11:33 Changeset [35842] by
-
Added support for console.count in the inspector.
Reviewed by Geoff Garen.
- page/Console.cpp: (WebCore::Console::count):
- page/Console.h:
- page/Console.idl: Added console.count.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): Clears m_counts. (WebCore::InspectorController::count): Updates the count number sing "title@source:line" as the identifier, and adds a message to the console.
- page/InspectorController.h: Added m_counts.
- 11:33 Changeset [35841] by
-
Clear console.time timers when changing page.
Reviewed by Geoff Garen.
- page/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
- 10:55 Changeset [35840] by
-
2008-08-19 Eric Carlson < eric.carlson@apple.com>
Reviewed by Adele.
Fix for < rdar://problem/6154695> Full-page movies flicker while playing
https://bugs.webkit.org/show_bug.cgi?id=20404
Ignore setVisible() when visibility doesn't change.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::setVisible):
- 10:01 Changeset [35839] by
-
Correctly remembers the attached state of the Web Inspector so
it opens in that state for the next window, or next launch.
Reviewed by Kevin McCullough.
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey to YES in the user defaults. (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey to NO in the user defaults.
- 10:01 Changeset [35838] by
-
Fixes a bug in the Profile view where switching sort order, then
switching from heavy to tree mode would show the tree in the
previous sort order.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype._changeView): Call _sortProfile on the next profile before assigning it to this.profile. (WebInspector.ProfileView.prototype._sortData): Call _sortProfile. (WebInspector.ProfileView.prototype._sortProfile): Moves from _sortData and takes a profile argument. If the profile passed in matches the this.profile, then call refresh.
- 10:01 Changeset [35837] by
-
Changed the default sort order now that heavy view is the default.
Also fixes a bug where the heavy profile was not sorted at first.
Reviewed by Kevin McCullough.
- page/inspector/ProfileView.js: (WebInspector.ProfileView): Changed the default sort column. Also assign heavyProfile to profile, so the sortSelfTimeDescending call happens on the heavy profile before assigning to this.profile.
- 10:00 Changeset [35836] by
-
Fix an assertion when generating a heavy profile because the
empty value and deleted value of CallIdentifier where equal.
Reviewed by Dan Bernstein.
- profiler/CallIdentifier.h: Make the emptyValue for CallIdentifier use empty strings for URL and function name.
- 10:00 Changeset [35835] by
-
Add support for editing DOM properties and scope variables by double
clicking a property to enter edit mode.
Reviewed by Kevin McCullough.
- page/inspector/ObjectPropertiesSection.js: (WebInspector.ObjectPropertiesSection): Set editable to true by default. (WebInspector.ObjectPropertiesSection.prototype.onpopulate): Factored out code into update, and calls update. (WebInspector.ObjectPropertiesSection.prototype.update): Moved from onpopulate. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement): Pass an empty title, the title gets made later in onattach. (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): Don't return early if shouldRefreshChildren is true. Call removeChildren since this method can be called multiple times now. (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick): Call startEditing. (WebInspector.ObjectPropertyTreeElement.prototype.onattach): Call update. (WebInspector.ObjectPropertyTreeElement.prototype.update): Update the title for this element (code moved from the constructor.) (WebInspector.ObjectPropertyTreeElement.prototype.updateSiblings): Recreate all sibling property elements. (WebInspector.ObjectPropertyTreeElement.prototype.startEditing): Call WebInspector.startEditing after rememebring some context. (WebInspector.ObjectPropertyTreeElement.prototype.editingEnded): Reset the scrollLeft for the list element, since it might have scrolled during editing. (WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled): Call editingEnded then restore the state from the context. Then call update to restore the title. (WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted): Call editingCancelled if the user input and the previous input are the same. Call editingEnded, then call applyExpression to commit the user input. (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression): Evaluates the input expression and stores the result on the object for the property name of this element. If the expression is empty, delete the property and remove the tree element.
- page/inspector/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane.prototype.update): Set the editInSelectedCallFrameWhenPaused property on each ObjectPropertiesSection. (WebInspector.ScopeVariableTreeElement.prototype.onattach): Call ObjectPropertyTreeElement's onattach since it is now implemented.
- page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame): Added an updateInterface argument that defaults to true if omitted. It specifies whether to call update on the scope chain.
- page/inspector/inspector.css: New styles.
- page/inspector/treeoutline.js: (TreeElement.prototype._attach): Fixed an exception that fired when handling the shouldRefreshChildren change. The nextSibling would exist but have a _listItemNode that didn't match the new parent.
- 10:00 Changeset [35834] by
-
Surround the expression to be evaluated in parenthesis so the
result of the eval is the result of the whole expression not
the last potential sub-expression. So evaluating {x: 123}
will show the Object not 123.
Reviewed by Kevin McCullough.
- page/inspector/Console.js: (Console.prototype._evalInInspectedWindow): Add parenthesis around the expression. And add couple comments.
- 09:38 Changeset [35833] by
-
2008-08-19 Kevin McCullough < kmccullough@apple.com>
Reviewed by Geoff.
-Implement a page() function to extract a common code pattern.
- WebCore.xcodeproj/project.pbxproj:
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::assertCondition): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupEnd): (WebCore::Console::finishedProfiling): (WebCore::Console::warn): (WebCore::Console::framePage):
- page/Console.h:
- 07:35 Changeset [35832] by
-
https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg
Disabling the test while the crash is being investigated.
- 00:27 Changeset [35831] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=19347
< rdar://problem/5977562> Input methods do not work after switching to a password field
and back.
Fix < rdar://problem/5522011> (The content of the password field of Safari is displayed by
reconversion) in a different way which doesn't conflict with context caching performed
by AppKit.
This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
because input methods are disabled in password fields. Attempting to reconvert text typed
with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
password field behavior and disable reconversion completely.
- WebView/WebHTMLView.mm: (isInPasswordField): Factored out code to determine that the current selection is in a password field. (inputContext): Removed a hack that was breaking TSMGetActiveDocument(). (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields. (-[WebHTMLView textStorage]): Ditto.
