Timeline


and

09/14/08:

23:33 Changeset [36428] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.

23:26 Changeset [36427] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • speed up JS construction by extracting "prototype" lookup so PIC applies.


~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
22:38 Changeset [36426] by timothy@apple.com
  • 3 edits in trunk/WebCore

Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.

https://bugs.webkit.org/show_bug.cgi?id=20555

Reviewed by Timothy Hatcher.

  • page/inspector/ResourcesPanel.js: Added a container for all resource graphs. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
  • page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
22:05 Changeset [36425] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.

Add a protected destructor for RefCounted.

It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.

No change in behavior.

  • wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
22:00 Changeset [36424] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

21:52 Changeset [36423] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results

Test: fast/dom/Range/compareBoundaryPoints-2.html

  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END and END_TO_START.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
20:10 Changeset [36422] by mjs@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Unreviewed build fix.

Trying again.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
19:55 Changeset [36421] by mjs@apple.com
  • 3 edits in trunk/WebCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Unreviewed build fix.

Blind attempt to fix build. Correct parameters for hasInstance.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
  • bindings/js/JSQuarantinedObjectWrapper.h:
19:23 Changeset [36420] by mitz@apple.com
  • 3 edits
    4 deletes in trunk

WebCore:

Rubber-stamped by Sam Weinig.

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont):

LayoutTests:

Rubber-stamped by Sam Weinig.

  • platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
  • platform/mac/fast/text/last-resort-font-expected.png: Removed.
  • platform/mac/fast/text/last-resort-font-expected.txt: Removed.
  • platform/mac/fast/text/last-resort-font.html: Removed.
19:21 Changeset [36419] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Now with all new and improved Changelog in the correct order.

19:18 Changeset [36418] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • split the "prototype" lookup for hasInstance into opcode stream so it can be cached


~5% speedup on v8 earley-boyer test

  • API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
  • kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
  • kjs/JSObject.h:
  • kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
  • kjs/nodes.h:
19:13 Changeset [36417] by mjs@apple.com
  • 14 edits in trunk/JavaScriptCore

2008-09-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • split the "prototype" lookup for hasInstance into opcode stream so it can be cached


~5% speedup on v8 earley-boyer test

  • API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
  • kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
  • kjs/JSObject.h:
  • kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
  • kjs/nodes.h:
17:56 Changeset [36416] by hyatt@apple.com
  • 4 edits
    2 adds in trunk/WebCore

Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin

17:53 Changeset [36415] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt build bustage.

17:36 Changeset [36414] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollbarThemeSafari.h

Fix Win build bustage.

17:35 Changeset [36413] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.

  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):
17:26 Changeset [36412] by cwzwarich@webkit.org
  • 11 edits
    3 adds in trunk

2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>

Optimize the 'typeof' operator when its result is compared to a constant
string.

This is a 5.5% speedup on the V8 Earley-Boyer test.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
  • VM/Machine.h:
  • VM/Opcode.h:
  • kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
  • kjs/nodes.h:

LayoutTests:

  • fast/js/resources/typeof-codegen-crash.js: Added.
  • fast/js/typeof-codegen-crash-expected.txt: Added.
  • fast/js/typeof-codegen-crash.html: Added.
17:20 Changeset [36411] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-09-14 Alp Toker <alp@nuanti.com>

https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners

Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).

Requested by Michael Monreal.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk):
  • platform/gtk/gtk2drawing.c: (moz_gtk_set_widget_name): (ensure_window_widget): (setup_widget_prototype): (ensure_button_arrow_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_tooltip_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (ensure_scrolled_window_widget): (moz_gtk_button_paint): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_toolbar_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_item_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_shutdown):
  • platform/gtk/gtkdrawing.h:
17:12 Changeset [36410] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers

Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.

  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Don't convert numbers to strings just to convert them back to numbers.
16:55 Changeset [36409] by hyatt@apple.com
  • 17 edits in trunk/WebCore

2008-09-14 David Hyatt <hyatt@apple.com>

Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.

Reviewed by Sam Weinig

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::paint):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value): (WebCore::Scrollbar::visibleSize): (WebCore::Scrollbar::maximum): (WebCore::Scrollbar::lineStep): (WebCore::Scrollbar::pageStep): (WebCore::Scrollbar::pixelStep): (WebCore::Scrollbar::pressedPart): (WebCore::Scrollbar::hoveredPart): (WebCore::Scrollbar::theme):
  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paint): (WebCore::ScrollbarTheme::scrollbarThickness): (WebCore::ScrollbarTheme::supportsControlTints): (WebCore::ScrollbarTheme::themeChanged):
  • platform/gtk/PlatformScrollBar.h:
  • platform/gtk/PlatformScrollBarGtk.cpp:
  • platform/mac/PlatformScrollBar.h:
  • platform/mac/PlatformScrollBarMac.mm:
  • platform/qt/PlatformScrollBar.h:
  • platform/qt/PlatformScrollBarQt.cpp:
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
  • platform/qt/ScrollbarThemeQt.h: (WebCore::ScrollbarThemeQt::paint):
  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
  • platform/win/ScrollbarThemeSafari.h: (WebCore::ScrollbarThemeSafari::supportsControlTints):
  • platform/wx/PlatformScrollBar.h:
  • platform/wx/TemporaryLinkStubs.cpp: (PlatformScrollbar::~PlatformScrollbar):
16:01 Changeset [36408] by cwzwarich@webkit.org
  • 7 edits in trunk/JavaScriptCore

2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20816: op_lesseq should be optimized
<https://bugs.webkit.org/show_bug.cgi?id=20816>

Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.

This is a 9.4% speedup on the V8 Crypto benchmark.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
  • VM/Machine.h:
  • VM/Opcode.h:
15:15 Changeset [36407] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/PlatformScrollBarQt.cpp:
15:12 Changeset [36406] by weinig@apple.com
  • 12 edits in trunk

JavaScriptCore:

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extraneous semicolons.

  • kjs/nodes.cpp: (JSC::PrefixResolveNode::emitCode):
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GrowHeap):

WebCore:

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove extraneous semicolons.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::charsetAttributeValue): (WebCore::HTMLScriptElement::typeAttributeValue):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
  • svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
15:00 Changeset [36405] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
14:36 Changeset [36404] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-14 Sam Weinig <sam@webkit.org>

Qt build fix.

  • platform/qt/PlatformScrollBarQt.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::paint):
02:33 Changeset [36403] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Build fix.

01:33 Changeset [36402] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-14 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Cleanup Sampling code.

  • VM/CTI.cpp: (JSC::CTI::emitCall): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h: (JSC::CTI::execute):
  • VM/SamplingTool.cpp: (JSC::): (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
  • VM/SamplingTool.h: (JSC::SamplingTool::callingHostFunction):
01:18 Changeset [36401] by oliver@apple.com
  • 13 edits in trunk/JavaScriptCore

Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821

Reviewed by Cameron Zwarich.

Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)

09/13/08:

23:23 ProposedWebInspectorRearchitecting edited by timothy@apple.com
(diff)
23:21 ProposedWebInspectorRearchitecting edited by timothy@apple.com
Further define the message types and callback functions. (diff)
22:53 ProposedWebInspectorRearchitecting edited by timothy@apple.com
Defines some messages for Console. (diff)
22:29 Changeset [36400] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBar.h

Fix Qt bustage.

22:05 Changeset [36399] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebScrollBar.cpp

Fix Windows bustage.

21:53 Changeset [36398] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/PlatformScrollBar.h

Fix Mac build bustage.

21:25 ProposedWebInspectorRearchitecting edited by timothy@apple.com
Define some of the Console API. (diff)
18:57 Changeset [36397] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix, not reviewed.

  • platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
18:26 Changeset [36396] by hyatt@apple.com
  • 17 edits in trunk/WebCore

Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.

18:06 Changeset [36395] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.

17:58 Changeset [36394] by hyatt@apple.com
  • 10 edits in trunk/WebCore

Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.

17:50 Changeset [36393] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBar.h

Remove now unused methods from GTK scrollbars.

17:49 Changeset [36392] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/PlatformScrollBarGtk.cpp

Remove now unused methods from GTK scrollbars.

17:32 Changeset [36391] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.

17:22 Changeset [36390] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollBar.h

Fix Qt build bustage.

16:57 Changeset [36389] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-09-13 David Hyatt <hyatt@apple.com>

Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.

Reviewed by Sam Weinig

  • platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
  • platform/qt/PlatformScrollBar.h:
16:47 Changeset [36388] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt bustage.

16:34 Changeset [36387] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/TemporaryLinkStubs.cpp

Fix wx bustage.

16:32 Changeset [36386] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

16:21 Changeset [36385] by hyatt@apple.com
  • 3 edits in trunk/WebCore/platform

Fix Qt, Gtk, and Mac build bustage.

16:10 Changeset [36384] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.pro

Fix Qt bustage.

16:08 Changeset [36383] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

16:06 Changeset [36382] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • use the LastResort font for missing glyphs instead of showing the primary font's missing glyph

Test: platform/mac/fast/text/last-resort-font.html

  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.

LayoutTests:

Reviewed by Sam Weinig.

  • test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
  • platform/mac/fast/text/last-resort-font-expected.checksum: Added.
  • platform/mac/fast/text/last-resort-font-expected.png: Added.
  • platform/mac/fast/text/last-resort-font-expected.txt: Added.
  • platform/mac/fast/text/last-resort-font.html: Added.
15:59 Changeset [36381] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

15:59 Changeset [36380] by hyatt@apple.com
  • 16 edits
    11 adds in trunk/WebCore

Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.

14:30 Changeset [36379] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-13 Adrien Nader <camaradetux@gmail.com>

Gtk build fix, not reviewed.

  • webkit/webkitwebview.cpp:
14:05 Changeset [36378] by cfleizach@apple.com
  • 20 edits in trunk

<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement

expose AXTopLevelUIElement as an attribute

13:51 Changeset [36377] by hyatt@apple.com
  • 2 edits in trunk/WebKit/qt/Api

Fix Qt build bustage.

13:37 Changeset [36376] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx build bustage.

13:33 Changeset [36375] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PlatformScrollBarQt.cpp

Fix Qt build bustage.

13:27 Changeset [36374] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

  • fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache

No regression test because the back/forward cache is disabled in DumpRenderTree

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
12:14 Changeset [36373] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix Mac build bustage.

11:52 Changeset [36372] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix Qt build bustage.

11:48 Changeset [36371] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes for new methods recently introduced.

11:41 Changeset [36370] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

more scrollbar refactoring.

11:39 Changeset [36369] by hyatt@apple.com
  • 29 edits
    1 add in trunk/WebCore

More scrollbar refactoring.

09/12/08:

21:57 Changeset [36368] by cwzwarich@webkit.org
  • 9 edits in trunk/JavaScriptCore

2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20819: JSValue::isObject() is slow
<https://bugs.webkit.org/show_bug.cgi?id=20819>

Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.

This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.

  • JavaScriptCore.exp:
  • kjs/JSCell.cpp:
  • kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/JSString.cpp:
  • kjs/JSString.h: (JSC::JSString::JSString):
  • kjs/StructureID.h: (JSC::StructureID::type):
19:59 Changeset [36367] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Fix Mac build.

  • css/CSSStyleSelector.cpp: (WebCore::getTransformOperationType):
18:10 Changeset [36366] by hyatt@apple.com
  • 1 edit in trunk/WebCore/css/CSSStyleSelector.cpp

Fix Windows build bustage.

17:47 Changeset [36365] by dino@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Cleaning up LayoutTests/ChangeLog.

17:45 Changeset [36364] by dino@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Cleaning up WebCore/ChangeLog

17:41 Changeset [36363] by mrowe@apple.com
  • 15 edits
    5 deletes in trunk

Roll out r36360 as it broke all non-Mac builds.

17:33 Changeset [36362] by dino@apple.com
  • 13 edits in trunk

2008-09-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt.

Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770

Tests: transitions/transform-op-list-match.html

transitions/transform-op-list-no-match.html

  • css/CSSStyleSelector.cpp:
  • css/CSSStyleSelector.h:
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
  • rendering/RenderLayer.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
16:30 Changeset [36361] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-09-12 John Sullivan <sullivan@apple.com>

Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing

Reviewed by Darin Adler

  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewPerformPrint:]): Implemented PDFKit delegate method that's called after a Print action in the PDF content
16:27 Changeset [36360] by cfleizach@apple.com
  • 15 edits
    5 adds in trunk

<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari

Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility

15:43 Changeset [36359] by timothy@apple.com
  • 4 edits
    1 add in trunk/WebCore

Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=20684

  • manual-tests/inspector/escape-links.html: Added.
  • page/inspector/StylesSidebarPane.js:
  • page/inspector/inspector.js:
  • page/inspector/utilities.js:
15:14 Changeset [36358] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-09-12 Adele Peterson <adele@apple.com>

Reviewed by John Sullivan and Kevin McCullough.

Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames

  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
15:08 Changeset [36357] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-12 Kevin McCullough <kmccullough@apple.com>

RS by Tim .

Re-introducing the code since it was not the cause of the crash.
See r36343.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-12 Kevin McCullough <kmccullough@apple.com>

RS by Tim.

Re-introducing the code since it was not the cause of the crash.
See r36343.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
14:54 Changeset [36356] by dino@apple.com
  • 7 edits
    2 adds in trunk

2008-09-12 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt.

When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675

Test: animations/change-one-anim.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getNumProperties):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h: (WebCore::KeyframeAnimation::setIndex):
14:43 Changeset [36355] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk build bustage.

14:42 Changeset [36354] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qtbuild bustage.

11:47 ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
11:40 Changeset [36353] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-09-12 Brady Eidson <beidson@apple.com>

Reviewed by Mitz Pettel

Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior. Subresources can never be created from nil data, but there is always a MainResource, whether or not there's any data. So in the case where the main resource has no data, fake it for the sake of creating the ArchiveResource.
11:39 ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
11:37 Changeset [36352] by hyatt@apple.com
  • 10 edits in trunk/WebCore

Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.

11:22 Changeset [36351] by mitz@apple.com
  • 9 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • page/animation/AnimationController.cpp:
  • page/animation/AnimationController.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
10:58 Changeset [36350] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix a crash in -visibleRect when it is called during WebFrameView deallocation
  • WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added an early return if _private is 0.

09/11/08:

21:44 Changeset [36349] by timothy@apple.com
  • 5 edits in trunk/WebCore

Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.

<rdar://problem/5849349> Would like API to create
an image for a DOM node

Reviewed by Oliver Hunt.

  • bindings/objc/DOM.mm: (-[DOMNode renderedImage]): Call Frame::nodeImage.
  • bindings/objc/DOMPrivate.h:
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::Frame::nodeImage):
18:25 Changeset [36348] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2008-09-11 Dean Jackson <dino@apple.com>

Unfortunately the fix for
https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test

  • css3/keyframes-rule-expected.txt:
  • css3/keyframes-rule.html:
17:36 Changeset [36347] by dino@apple.com
  • 11 edits
    2 adds in trunk

2008-09-08 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680

Test: animations/keyframes-comma-separated.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createKeyframeRule):
  • css/CSSParser.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
  • css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::cssText): (WebCore::WebKitCSSKeyframeRule::parseKeyString):
  • css/WebKitCSSKeyframeRule.h: (WebCore::WebKitCSSKeyframeRule::keyText): (WebCore::WebKitCSSKeyframeRule::setKeyText): (WebCore::WebKitCSSKeyframeRule::getKeys):
  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::insertRule): (WebCore::WebKitCSSKeyframesRule::deleteRule): (WebCore::WebKitCSSKeyframesRule::findRule): (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
  • css/WebKitCSSKeyframesRule.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::blendProperties):
17:24 Changeset [36346] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.3.1

Versioning.

17:24 Changeset [36345] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.3.1/JavaScriptCore

Merge r36292.

17:15 Changeset [36344] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.3.1

New tag.

15:57 Changeset [36343] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS by Tim.

Reverting because this caused a crash.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): (WebCore::RenderObject::hasScrollableView):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

RS = Tim.

Reverted because this caused a crash.

  • fast/events/autoscroll-with-non-scrollable-parent.html:
15:32 Changeset [36342] by slewis@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-11 Stephanie Lewis <slewis@apple.com>

Reviewed by Oliver Hunt.

Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.

14:59 Changeset [36341] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-09-11 Dean Jackson <dino@apple.com>

Reviewed by Dan Bernstein.

Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751

Test: transitions/transition-end-event-set-none.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
14:54 Changeset [36340] by dsmith@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Rubber-stamped by mitzpettel.

Remove an accidentally added extra file.

  • WebCore: Removed.
14:41 Changeset [36339] by dsmith@webkit.org
  • 13 edits
    4 adds in trunk/WebCore

2008-09-11 David Smith <catfish.man@gmail.com>

Reviewed by Darin

https://bugs.webkit.org/show_bug.cgi?id=20180


This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.

  • WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
  • css/CSSStyleSelector.cpp: include NodeRenderStyle.h
  • dom/Element.cpp: include NodeRenderStyle.h
  • dom/Node.cpp: Remove the definition of renderStyle() (WebCore::Node::nonRendererRenderStyle):
  • dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
  • dom/NodeRenderStyle.h: Added. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
  • html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptGroupElement.h: (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
  • html/HTMLOptionElement.cpp: include NodeRenderStyle.h
  • html/HTMLOptionElement.h: (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
  • rendering/RenderListBox.cpp: include NodeRenderStyle.h
  • rendering/RenderMenuList.cpp: include NodeRenderStyle.h
  • svg/SVGUseElement.cpp: include NodeRenderStyle.h
14:15 Changeset [36338] by cwzwarich@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Correct an SVN problem with the last commit and actually add the new
files.

  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
14:13 Changeset [36337] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20788: Split CharacterClassConstructor into its own file
<https://bugs.webkit.org/show_bug.cgi?id=20788>

Split CharacterClassConstructor into its own file and clean up some
style issues.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
  • wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
  • wrec/WREC.cpp: (JSC::WRECParser::parseCharacterClass):
13:29 Changeset [36336] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)
  • WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart and has layout, gets the visible rect of the RenderPart and returns YES. Returns NO otherwise.
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added. Overrides this NSView method to take clipping in the render tree into account.
10:45 ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
10:39 Changeset [36335] by kmccullough@apple.com
  • 5 edits in trunk

WebCore:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix auto scrolling but is not correct for the whole web: rdar://problem/6213098
  • rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
  • rendering/RenderObject.h:

LayoutTests:

2008-09-11 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele and Tim.

<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)

  • This was put in by Max to fix some auto scroll behavior but is not correct for the whole web: rdar://problem/6213098
  • fast/events/autoscroll-with-non-scrollable-parent.html:
09:24 Changeset [36334] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title

03:50 Changeset [36333] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon.

Prevent leaking pages and frames in QWebKit autotest

02:53 Changeset [36332] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon

Fix QtWebKit autotest

01:03 Changeset [36331] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.

[Qt] Canvas stroke don't work for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=20749

00:37 Changeset [36330] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20729

Fixed canvas gradients for Qt

00:34 Changeset [36329] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-09-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Simon.

https://bugs.webkit.org/show_bug.cgi?id=20568

Add support for patterns to Qt.

00:09 Changeset [36328] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Simon Hausmann <hausmann@webkit.org>

Not reviewed but trivial one-liner for yet unused macro.

Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.

(part of https://bugs.webkit.org/show_bug.cgi?id=20746)

09/10/08:

22:28 Changeset [36327] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver Hunt.

Fix a typo by renaming the overloaded orl_rr that takes an immediate to
orl_i32r.

  • VM/CTI.cpp: (JSC::CTI::emitFastArithPotentiallyReTagImmediate):
  • masm/X86Assembler.h: (JSC::X86Assembler::orl_i32r):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generatePatternCharacter): (JSC::WRECGenerator::generateCharacterClassInverted):
21:01 Changeset [36326] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-09-10 Sam Weinig <sam@webkit.org>

Rubber-stamped by David Hyatt.

Add additional test by Feng Qian.

  • fast/dom/StyleSheet/ownerNode-lifetime-2-expected.txt: Added.
  • fast/dom/StyleSheet/ownerNode-lifetime-2.html: Added.
19:42 Changeset [36325] by weinig@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-09-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoff Garen.

Add inline property storage for JSObject.

1.2% progression on Sunspider. .5% progression on the v8 test suite.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • kjs/JSObject.cpp: (JSC::JSObject::mark): There is no reason to check storageSize now that we start from 0. (JSC::JSObject::allocatePropertyStorage): Allocates/reallocates heap storage.
  • kjs/JSObject.h: (JSC::JSObject::offsetForLocation): m_propertyStorage is not an OwnArrayPtr now so there is no reason to .get() (JSC::JSObject::usingInlineStorage): (JSC::JSObject::JSObject): Start with m_propertyStorage pointing to the inline storage. (JSC::JSObject::~JSObject): Free the heap storage if not using the inline storage. (JSC::JSObject::putDirect): Switch to the heap storage only when we know we know that we are about to add a property that will overflow the inline storage.
  • kjs/PropertyMap.cpp: (JSC::PropertyMap::createTable): Don't allocate the propertyStorage, that is now handled by JSObject. (JSC::PropertyMap::rehash): PropertyStorage is not a OwnArrayPtr anymore.
  • kjs/PropertyMap.h: (JSC::PropertyMap::storageSize): Rename from markingCount.
  • kjs/StructureID.cpp: (JSC::StructureID::addPropertyTransition): Don't resize the property storage if we are using inline storage.
  • kjs/StructureID.h:
19:10 Changeset [36324] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Inline immediate number version of op_mul.

Reviewed by Geoff Garen

Renamed mull_rr to imull_rr as that's what it's
actually doing, and added imull_i32r for the constant
case immediate multiply.

1.1% improvement to SunSpider.

13:30 Changeset [36323] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-09-10 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Implement primary selection support (copying only, no paste yet).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_get_contents_cb): (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
13:22 ProposedWebInspectorRearchitecting edited by ojan@chromium.org
(diff)
12:48 ProposedWebInspectorRearchitecting created by ojan@chromium.org
12:30 Web Inspector edited by ojan@chromium.org
(diff)
11:21 Changeset [36322] by mitz@apple.com
  • 8 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
11:19 Changeset [36321] by mitz@apple.com
  • 17 edits in trunk/WebCore

Revert erroneous checkin

11:17 Changeset [36320] by mitz@apple.com
  • 15 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • clean up AnimationBase
  • page/animation/AnimationBase.cpp:
  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp:
  • page/animation/KeyframeAnimation.h:
09:42 Changeset [36319] by ap@webkit.org
  • 4 edits
    15 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20741
REGRESSION: ISO-8859-8-I encoding is registered incorrectly

Turns out that there were no real behavior changes for 8859-8, as it was only a debug-only
check to ignore this specific registration that was failing. Yet, I decided to add a bunch of
tests for ISO-8859-8 encoding aliases, as we handle them in a quite complicated manner.

I also found and fixed a potential crasher for non-Mac ports.

Tests: fast/encoding/hebrew/8859-8-e.html

fast/encoding/hebrew/8859-8-i.html
fast/encoding/hebrew/8859-8.html
fast/encoding/hebrew/csISO88598I.html
fast/encoding/hebrew/hebrew.html
fast/encoding/hebrew/iso-ir-138.html
fast/encoding/hebrew/logical.html

  • platform/text/TextEncodingRegistry.cpp: (WebCore::checkExistingName): Check for iso-8859-8 (case-insensitively, because different versions of ICU report this MIME name in different case).
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated some comments. (WebCore::TextCodecICU::registerExtendedCodecs): Try both MIME and IANA names here, too. There are four names in ICU that only have MIME names (x-mac-* ones), so we could end up with an encoding map entry, but no codec for these. This was not an issue on the Mac, as we also support these via TEC (which we should stop doing), but on Windows, this would likely crash.
03:15 Changeset [36318] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Not reviewed.

Mac build fix.

02:23 Changeset [36317] by oliver@apple.com
  • 9 edits in trunk/JavaScriptCore

Add optimised access to known properties on the global object.

Reviewed by Maciej Stachowiak

Improve cross scope access to the global object by emitting
code to access it directly rather than by walking the scope chain.

This is a 0.8% win in SunSpider and a 1.7% win in the v8 benchmarks.

01:42 Changeset [36316] by mjs@apple.com
  • 17 edits in trunk/JavaScriptCore

2008-09-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • enable polymorphic inline caching of properties of primitives


1.012x speedup on SunSpider.

We create special structure IDs for JSString and
JSNumberCell. Unlike normal structure IDs, these cannot hold the
true prototype. Due to JS autoboxing semantics, the prototype used
when looking up string or number properties depends on the lexical
global object of the call site, not the creation site. Thus we
enable StructureIDs to handle this quirk for primitives.


Everything else should be straightforward.


  • VM/CTI.cpp: (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain):
  • VM/CTI.h: (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain):
  • VM/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
  • VM/Machine.cpp: (JSC::Machine::Machine): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID):
  • kjs/GetterSetter.h: (JSC::GetterSetter::GetterSetter):
  • kjs/JSCell.h:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalData.h:
  • kjs/JSGlobalObject.h: (JSC::StructureID::prototypeForLookup):
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::JSNumberCell): (JSC::jsNumberCell):
  • kjs/JSObject.h: (JSC::JSObject::prototype):
  • kjs/JSString.cpp: (JSC::jsString): (JSC::jsSubstring): (JSC::jsOwnedString):
  • kjs/JSString.h: (JSC::JSString::JSString): (JSC::JSString::): (JSC::jsSingleCharacterString): (JSC::jsSingleCharacterSubstring): (JSC::jsNontrivialString):
  • kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): (JSC::SmallStrings::createSingleCharacterString):
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::getterSetterTransition): (JSC::StructureIDChain::StructureIDChain):
  • kjs/StructureID.h: (JSC::StructureID::create): (JSC::StructureID::storedPrototype):
01:09 Changeset [36315] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-09 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20746

Added WINCE platform macro.

  • wtf/Platform.h:
00:03 Changeset [36314] by weinig@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-09 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Remove unnecessary override of getOffset.

Sunspider reports this as a .6% progression.

  • JavaScriptCore.exp:
  • kjs/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::putDirect):
  • kjs/PropertyMap.cpp:
  • kjs/PropertyMap.h:
Note: See TracTimeline for information about the timeline view.