Timeline
09/15/08:
- 23:53 Changeset [36488] by
-
Convert Qt to ScrollbarTheme. Add cross-platform support for jumping a scrollbar thumb directly to a position on the track (Shift+Click on Windows, Middle Click on Qt)
- 23:48 Changeset [36487] by
-
Fix Qt build bustage in Localizations.
- 23:39 Changeset [36486] by
-
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=20860 REGRESSION: Crash in RenderLayer::hasVisibleContent() loading wavy.com
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Changed to check if the RenderPart has layout before accessing it, instead of checking if the frame inside it has layout.
- 23:14 Changeset [36485] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Sam Weinig.
Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
- GNUmakefile.am: Add CSSNthSelector
- WebCore.pro: Add CSSNthSelector
- WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
- WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
- css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
- css/CSSNthSelector.cpp: Added. (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
- css/CSSNthSelector.h: Added. (WebCore::CSSNthSelector::CSSNthSelector): (WebCore::CSSNthSelector::~CSSNthSelector):
- css/CSSParser.cpp: (WebCore::CSSParser::createFloatingNthSelector):
- css/CSSParser.h:
- css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector (WebCore::CSSSelector::CSSSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
- 23:12 Changeset [36484] by
-
Complete my previous changelog entry
- 23:08 Changeset [36483] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up the === and !== operators by choosing the fast cases better
No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq):
- kjs/JSImmediate.h: (JSC::JSImmediate::areBothImmediate):
- kjs/operations.cpp: (JSC::strictEqual): (JSC::strictEqualSlowCase):
- kjs/operations.h:
- 23:06 Changeset [36482] by
-
Coding style cleanup.
RS=Sam
- 22:54 Changeset [36481] by
-
2008-09-15 Alice Liu <alice.liu@apple.com>
A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
Reviewed by Stephanie Lewis.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, but not Intel. Add a check for nil before calling. (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange):
- 22:53 Changeset [36480] by
-
Bug 20874: op_resolve does not do any form of caching
<https://bugs.webkit.org/show_bug.cgi?id=20874>
Reviewed by Cameron Zwarich
This patch adds an op_resolve_global opcode to handle (and cache)
property lookup we can statically determine must occur on the global
object (if at all).
3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
10% in math-partial-sums
- 22:39 Changeset [36479] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36478. It did little to help the issue either.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 22:14 Changeset [36478] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Avoid the single character optimization.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 21:34 Changeset [36477] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36476. It did little to help the issue.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 20:59 Changeset [36476] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Make this test a little more forgiving.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 20:46 Changeset [36475] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36462. It broke document.all.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::isJSString):
- kjs/JSCell.h:
- kjs/JSWrapperObject.h:
- kjs/StringObject.h:
- kjs/StringObjectThatMasqueradesAsUndefined.h:
- 20:27 Changeset [36474] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
now passes on Leopard in 10.5.5.
- platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- 19:46 Changeset [36473] by
-
2008-09-15 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Clean up some inspector JS callbacks to remove an extra return.
- page/InspectorController.cpp: (WebCore::hideDOMNodeHighlight): (WebCore::loaded): (WebCore::unloading): (WebCore::attach): (WebCore::detach): (WebCore::startDebuggingAndReloadInspectedPage): (WebCore::stopDebugging): (WebCore::debuggerAttached): (WebCore::pauseOnExceptions): (WebCore::pauseInDebugger): (WebCore::resumeDebugger): (WebCore::stepOverStatementInDebugger): (WebCore::stepIntoStatementInDebugger): (WebCore::stepOutOfFunctionInDebugger): (WebCore::isWindowVisible): (WebCore::closeWindow):
- 19:44 Changeset [36472] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
<https://bugs.webkit.org/show_bug.cgi?id=20863>
r36427 changed the number of arguments to op_construct without changing
the argument index for the vPC in the call to initializeCallFrame() in
the CTI case. This caused a JSC test failure. Correcting the argument
index fixes the test failure.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_JSConstruct):
- 19:30 Changeset [36471] by
-
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 19:29 Changeset [36470] by
-
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 18:34 Changeset [36469] by
-
Fix GCC 4.2 build.
- 17:46 Changeset [36468] by
-
2008-09-15 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
- transitions/transform-op-list-match-expected.txt: Added.
- transitions/transform-op-list-match.html: Added.
- transitions/transform-op-list-no-match-expected.txt: Added.
- transitions/transform-op-list-no-match.html: Added.
- 17:17 Changeset [36467] by
-
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
https://bugs.webkit.org/show_bug.cgi?id=20808
Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
Inside the definition list, each <dt> "term" has an accessibility description ("term"),
as does each <dd> tag ("definition")
- 17:01 Changeset [36466] by
-
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
Several renames:
dispatchHTMLEvent -> dispatchEventForType
setHTMLEventListener -> setEventListenerForType
getHTMLEventListener -> eventListenerForType
removeHTMLEventListener -> removeEventListenerForType
isHTMLEventListener -> isAttachedToEventTargetNode
...
Similar renames for the dispatch/get/set/*Window*Event functions.
Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
SVG is able to use the code as well now. This affects most files in html/.
No functional changes.
- 16:44 Changeset [36465] by
-
Switch PlatformScrollbarWin's hit testing to use ScrollbarTheme. The file is now nearly completely empty. PlatformScrollbarSafari and PlatformScrollbarQt still need to be converted.
- 16:38 Changeset [36464] by
-
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a typo in op_get_by_id_chain that caused it to miss every time
in the interpreter.
Also, a little cleanup.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Set up baseObject before entering the loop, so we compare against the right values.
- 16:37 Changeset [36463] by
-
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the CalledAsConstructor flag from the call frame header. Now,
we use an explicit opcode at the call site to fix up constructor results.
SunSpider says 0.4% faster.
cti_op_construct_verify is an out-of-line function call for now, but we
can fix that once StructureID holds type information like isObject.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: Codegen for the new opcode. Also... (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value. (JSC::CodeGenerator::emitConstruct): ... ditto.
- VM/Machine.cpp: No more CalledAsConstructor (JSC::Machine::privateExecute): Implementation for the new opcode. (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were called as a constructor. (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
- VM/Machine.h:
- VM/Opcode.h: Declare new opcode.
- VM/RegisterFile.h: (JSC::RegisterFile::): No more CalledAsConstructor
- 16:33 Changeset [36462] by
-
2008-09-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
masquerading may be handled differently (through the StructureIDs - see bug
#20823).
1% on v8-tests.
- VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfIsJSCell): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::doesMasqueradesAsUndefined):
- kjs/JSWrapperObject.h: (JSC::JSWrapperObject::): (JSC::JSWrapperObject::JSWrapperObject):
- kjs/StringObject.h: (JSC::StringObject::StringObject):
- kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- 16:08 Changeset [36461] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
"Just do it"'d by Mark Rowe
https://bugs.webkit.org/show_bug.cgi?id=20856
Add missing license header
- dom/NodeRenderStyle.h:
- 15:17 Changeset [36460] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Oliver Hunt.
r36427 broke CodeBlock::dump() by changing the number of arguments to
op_construct without changing the code that prints it. This patch fixes
it by printing the additional argument.
- JavaScriptCore.xcodeproj/project.pbxproj:
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- 14:52 Changeset [36459] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Add default constructor for ShadowData
https://bugs.webkit.org/show_bug.cgi?id=20757
Test: transitions/shadow.html
- rendering/style/RenderStyle.h:
- 14:40 Changeset [36458] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
RenderStyle should update keyframes.
http://bugs.webkit.org/show_bug.cgi?id=20756
- rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::updateKeyframes):
- 14:31 Changeset [36457] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Unnecessary ASSERT in ImplicitAnimation destructor.
https://bugs.webkit.org/show_bug.cgi?id=20817
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation):
- 14:27 Changeset [36456] by
-
WebKit:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream start]): (-[WebBaseNetscapePluginStream stop]): (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebNetscapePluginEmbeddedView.mm:
- Plugins/WebNetscapePluginStream.h: Removed.
- Plugins/WebNetscapePluginStream.mm: Removed.
- 14:22 Changeset [36455] by
-
Oops. Forgot this file in previous commit.
- 14:21 Changeset [36454] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Tests for -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=20771
- transforms/2d/compound-2d-transforms-expected.txt: Added.
- transforms/2d/compound-2d-transforms.html: Added.
- transforms/2d/compound-transforms-vs-containers.html: Added.
- transforms/2d/transform-2d-expected.txt: Added.
- transforms/2d/transform-2d.html: Added.
- transforms/2d/transform-accuracy-expected.txt: Added.
- transforms/2d/transform-accuracy.html: Added.
- transforms/2d/transform-borderbox.html: Added.
- transforms/2d/transform-origin-borderbox.html: Added.
- transforms/2d/resources/transform-test-utils.js: Added.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.txt: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
- 14:06 Changeset [36453] by
-
Fix Win build bustage.
- 14:02 Changeset [36452] by
-
Reviewed by Simon.
Yahoo assumes non-RFC compliant HTTP redirect behaviour. QtWebKit is (more)
compliant, so broken. I think the Yahoo-assumed behaviour is real-world standard.
Basically, Yahoo's login procedure for flickr looks like this:
- load flickr.com, click "sign in"
- this is a Yahoo page with a form
(https://login.yahoo.com/config/login?.src=flickr...)
when you click the "Sign In" button, the form submits to a yahoo.com POST URL
- The POST returns with a 302 (redirect) to another yahoo.com URL
- If you POST the redirected Location:, it all breaks. Yahoo assumes you will
convert the method to GET, which works fine but is definitely not
RFC-compliant. It would be compliant for 303, and the RFC says that many
implementations treat 302 and 303 the same way (for HTTP/1.0 compliance), but
converting to GET is explicitly wrong for 302.
- 13:59 Changeset [36451] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Tests for animations.
https://bugs.webkit.org/show_bug.cgi?id=20789
- animations/animation-test-helpers.js: Added.
- animations/generic-from-to-expected.txt: Added.
- animations/generic-from-to.html: Added.
- animations/multiple-animations-expected.txt: Added.
- animations/multiple-animations.html: Added.
- animations/multiple-keyframes-expected.txt: Added.
- animations/multiple-keyframes.html: Added.
- 13:53 Changeset [36450] by
-
Reviewed by Simon.
Fix plugin extension info. It was returning the mimetype where the
extension was given.
- 13:40 Changeset [36449] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Coding style violation!!!! Cleanup AnimationBase.cpp
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- 13:03 Changeset [36448] by
-
2008-09-15 David Hyatt <hyatt@apple.com>
Move all hit testing code for scrollbars into the base class. Refactor
it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
functions.
No platform is using this code yet. Although it has been moved and compiles
(even on Mac), it is not being used on any platform.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent): (WebCore::Scrollbar::handleMouseReleaseEvent): (WebCore::Scrollbar::handleMousePressEvent):
- platform/ScrollBar.h: (WebCore::Scrollbar::handleContextMenuEvent):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::hitTest): (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit): (WebCore::ScrollbarTheme::invalidatePart): (WebCore::ScrollbarTheme::shouldCenterOnThumb): (WebCore::ScrollbarTheme::centerOnThumb): (WebCore::ScrollbarTheme::thumbPosition): (WebCore::ScrollbarTheme::thumbLength): (WebCore::ScrollbarTheme::trackLength): (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::ScrollbarTheme::autoscrollTimerDelay):
- platform/Widget.h: (WebCore::Widget::parent):
- platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow):
- platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
- platform/win/ScrollbarThemeWin.h:
- 11:48 Changeset [36447] by
-
Reviewed by Sam Weinig.
- fix <rdar://problem/5842247> Single long breakable word takes O(n2) to lay out
Cache the next breakable position for text nodes in InlineIterator.
- rendering/bidi.cpp: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::increment): (WebCore::RenderBlock::findNextLineBreak):
- 10:10 Changeset [36446] by
-
2008-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Fix assertion and integral pixel issue when creating subimages.
https://bugs.webkit.org/show_bug.cgi?id=20786
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 08:16 Changeset [36445] by
-
Build fix
- kjs/StructureID.cpp: Removed a stray semicolon.
- 05:43 Changeset [36444] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Implment seek() and clean up and improve debugging output
- 04:40 Changeset [36443] by
-
2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
m_mediaObject, m_audioOutput, m_videoWidget get created in the
c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
only check if we use the MediaPlayerPrivate after it has been deleted.
Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
- 04:35 Changeset [36442] by
-
WebCore:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Check the width and height and throw an exception if any of them are 0.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
LayoutTests:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Add test for createPattern where the canvas passed in has a zero height/width.
- fast/canvas/canvas-with-incorrect-args-expected.txt:
- fast/canvas/canvas-with-incorrect-args.html:
- 04:28 Changeset [36441] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Render media element controls with antialiasing enabled
- 04:27 Changeset [36440] by
-
2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Upon non fatal error, switch to the pause state (so that playback can continue)
- 04:22 Changeset [36439] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
- 04:16 Changeset [36438] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Make QtInstance::create() private and fix caching
- 03:43 Changeset [36437] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Fix a crash in fast/js/exception-expression-offset.html caused by not
updating all mentions of the length of op_construct in r36427.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_NotJSConstruct):
- 03:20 Changeset [36436] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix layout test failure introduced by fix for 20849
(The failing test was fast/js/delete-then-put.html)
- kjs/JSObject.cpp: (JSC::JSObject::removeDirect): Clear enumeration cache in the dictionary case.
- kjs/JSObject.h: (JSC::JSObject::putDirect): Ditto.
- kjs/StructureID.h: (JSC::StructureID::clearEnumerationCache): Inline to handle the clear.
- 03:02 Changeset [36435] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix JSC test failures introduced by fix for 20849
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
- 02:39 Changeset [36434] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20851>
r36410 introduced an optimization for parseInt() that is incorrect when
its argument is larger than the range of a 32-bit integer. If the
argument is a number that is not an immediate integer, then the correct
behaviour is to return the floor of its value, unless it is an infinite
value, in which case the correct behaviour is to return 0.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 02:13 Changeset [36433] by
-
Fix Qt build bustage.
- 01:45 Changeset [36432] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
- css/CSSStyleSelector.h:
- 01:34 Changeset [36431] by
-
Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp
- 01:31 Changeset [36430] by
-
Fix Qt build bustage.
- 00:27 Changeset [36429] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.
~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.
- kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
- kjs/PropertyMap.h:
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
- kjs/StructureID.h:
09/14/08:
- 23:33 Changeset [36428] by
-
Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.
- 23:26 Changeset [36427] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up JS construction by extracting "prototype" lookup so PIC applies.
~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.
- VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
- 22:38 Changeset [36426] by
-
Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.
Reviewed by Timothy Hatcher.
- page/inspector/ResourcesPanel.js: Added a container for all resource graphs. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
- page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
- 22:05 Changeset [36425] by
-
Reviewed by Eric Seidel.
Add a protected destructor for RefCounted.
It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.
No change in behavior.
- wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
- 22:00 Changeset [36424] by
-
Fix Qt bustage.
- 21:52 Changeset [36423] by
-
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results
Test: fast/dom/Range/compareBoundaryPoints-2.html
- dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END and END_TO_START.
- page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
- 20:10 Changeset [36422] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Trying again.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- 19:55 Changeset [36421] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Blind attempt to fix build. Correct parameters for hasInstance.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- bindings/js/JSQuarantinedObjectWrapper.h:
- 19:23 Changeset [36420] by
-
WebCore:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont):
LayoutTests:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
- platform/mac/fast/text/last-resort-font-expected.png: Removed.
- platform/mac/fast/text/last-resort-font-expected.txt: Removed.
- platform/mac/fast/text/last-resort-font.html: Removed.
- 19:21 Changeset [36419] by
-
Now with all new and improved Changelog in the correct order.
- 19:18 Changeset [36418] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 19:13 Changeset [36417] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 17:56 Changeset [36416] by
-
Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin
- 17:53 Changeset [36415] by
-
Fix Qt build bustage.
- 17:36 Changeset [36414] by
-
Fix Win build bustage.
- 17:35 Changeset [36413] by
-
2008-09-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):
- 17:26 Changeset [36412] by
-
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>
Optimize the 'typeof' operator when its result is compared to a constant
string.
This is a 5.5% speedup on the V8 Earley-Boyer test.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
- VM/Machine.h:
- VM/Opcode.h:
- kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
- kjs/nodes.h:
LayoutTests:
- fast/js/resources/typeof-codegen-crash.js: Added.
- fast/js/typeof-codegen-crash-expected.txt: Added.
- fast/js/typeof-codegen-crash.html: Added.
- 17:20 Changeset [36411] by
-
2008-09-14 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners
Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).
Requested by Michael Monreal.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk):
- platform/gtk/gtk2drawing.c: (moz_gtk_set_widget_name): (ensure_window_widget): (setup_widget_prototype): (ensure_button_arrow_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_tooltip_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (ensure_scrolled_window_widget): (moz_gtk_button_paint): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_toolbar_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_item_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_shutdown):
- platform/gtk/gtkdrawing.h:
- 17:12 Changeset [36410] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers
Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Don't convert numbers to strings just to convert them back to numbers.
- 16:55 Changeset [36409] by
-
2008-09-14 David Hyatt <hyatt@apple.com>
Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::paint):
- platform/ScrollBar.h: (WebCore::Scrollbar::value): (WebCore::Scrollbar::visibleSize): (WebCore::Scrollbar::maximum): (WebCore::Scrollbar::lineStep): (WebCore::Scrollbar::pageStep): (WebCore::Scrollbar::pixelStep): (WebCore::Scrollbar::pressedPart): (WebCore::Scrollbar::hoveredPart): (WebCore::Scrollbar::theme):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paint): (WebCore::ScrollbarTheme::scrollbarThickness): (WebCore::ScrollbarTheme::supportsControlTints): (WebCore::ScrollbarTheme::themeChanged):
- platform/gtk/PlatformScrollBar.h:
- platform/gtk/PlatformScrollBarGtk.cpp:
- platform/mac/PlatformScrollBar.h:
- platform/mac/PlatformScrollBarMac.mm:
- platform/qt/PlatformScrollBar.h:
- platform/qt/PlatformScrollBarQt.cpp:
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
- platform/qt/ScrollbarThemeQt.h: (WebCore::ScrollbarThemeQt::paint):
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
- platform/win/ScrollbarThemeSafari.h: (WebCore::ScrollbarThemeSafari::supportsControlTints):
- platform/wx/PlatformScrollBar.h:
- platform/wx/TemporaryLinkStubs.cpp: (PlatformScrollbar::~PlatformScrollbar):
- 16:01 Changeset [36408] by
-
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 20816: op_lesseq should be optimized
<https://bugs.webkit.org/show_bug.cgi?id=20816>
Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.
This is a 9.4% speedup on the V8 Crypto benchmark.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
- VM/Machine.h:
- VM/Opcode.h:
- 15:15 Changeset [36407] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp:
- 15:12 Changeset [36406] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- kjs/nodes.cpp: (JSC::PrefixResolveNode::emitCode):
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GrowHeap):
WebCore:
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- bindings/scripts/CodeGeneratorObjC.pm:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::charsetAttributeValue): (WebCore::HTMLScriptElement::typeAttributeValue):
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
- 15:00 Changeset [36405] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
- 14:36 Changeset [36404] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::paint):
- 02:33 Changeset [36403] by
-
Build fix.
- 01:33 Changeset [36402] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Cleanup Sampling code.
- VM/CTI.cpp: (JSC::CTI::emitCall): (JSC::CTI::privateCompileMainPass):
- VM/CTI.h: (JSC::CTI::execute):
- VM/SamplingTool.cpp: (JSC::): (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
- VM/SamplingTool.h: (JSC::SamplingTool::callingHostFunction):
- 01:18 Changeset [36401] by
-
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821
Reviewed by Cameron Zwarich.
Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)
09/13/08:
- 23:23 ProposedWebInspectorRearchitecting edited by
- (diff)
- 23:21 ProposedWebInspectorRearchitecting edited by
- Further define the message types and callback functions. (diff)
- 22:53 ProposedWebInspectorRearchitecting edited by
- Defines some messages for Console. (diff)
- 22:29 Changeset [36400] by
-
Fix Qt bustage.
- 22:05 Changeset [36399] by
-
Fix Windows bustage.
- 21:53 Changeset [36398] by
-
Fix Mac build bustage.
- 21:25 ProposedWebInspectorRearchitecting edited by
- Define some of the Console API. (diff)
- 18:57 Changeset [36397] by
-
2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix, not reviewed.
- platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
- 18:26 Changeset [36396] by
-
Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.
- 18:06 Changeset [36395] by
-
Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.
- 17:58 Changeset [36394] by
-
Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.
- 17:50 Changeset [36393] by
-
Remove now unused methods from GTK scrollbars.
- 17:49 Changeset [36392] by
-
Remove now unused methods from GTK scrollbars.
- 17:32 Changeset [36391] by
-
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.
- 17:22 Changeset [36390] by
-
Fix Qt build bustage.
- 16:57 Changeset [36389] by
-
2008-09-13 David Hyatt <hyatt@apple.com>
Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.
Reviewed by Sam Weinig
- platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
- platform/qt/PlatformScrollBar.h:
- 16:47 Changeset [36388] by
-
Fix Qt bustage.
- 16:34 Changeset [36387] by
-
Fix wx bustage.
- 16:32 Changeset [36386] by
-
Fix Qt bustage.
- 16:21 Changeset [36385] by
-
Fix Qt, Gtk, and Mac build bustage.
- 16:10 Changeset [36384] by
-
Fix Qt bustage.
- 16:08 Changeset [36383] by
-
Fix Mac bustage.
- 16:06 Changeset [36382] by
-
WebCore:
Reviewed by Sam Weinig.
- use the LastResort font for missing glyphs instead of showing the primary font's missing glyph
Test: platform/mac/fast/text/last-resort-font.html
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.
LayoutTests:
Reviewed by Sam Weinig.
- test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
- platform/mac/fast/text/last-resort-font-expected.checksum: Added.
- platform/mac/fast/text/last-resort-font-expected.png: Added.
- platform/mac/fast/text/last-resort-font-expected.txt: Added.
- platform/mac/fast/text/last-resort-font.html: Added.
- 15:59 Changeset [36381] by
-
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 15:59 Changeset [36380] by
-
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 14:30 Changeset [36379] by
-
2008-09-13 Adrien Nader <camaradetux@gmail.com>
Gtk build fix, not reviewed.
- webkit/webkitwebview.cpp:
- 14:05 Changeset [36378] by
-
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
expose AXTopLevelUIElement as an attribute
- 13:51 Changeset [36377] by
-
Fix Qt build bustage.
- 13:37 Changeset [36376] by
-
Fix wx build bustage.
- 13:33 Changeset [36375] by
-
Fix Qt build bustage.
- 13:27 Changeset [36374] by
-
Reviewed by Timothy Hatcher.
- fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
No regression test because the back/forward cache is disabled in DumpRenderTree
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
- 12:14 Changeset [36373] by
-
Fix Mac build bustage.
- 11:52 Changeset [36372] by
-
Fix Qt build bustage.
- 11:48 Changeset [36371] by
-
wx build fixes for new methods recently introduced.
- 11:41 Changeset [36370] by
-
more scrollbar refactoring.
- 11:39 Changeset [36369] by
-
More scrollbar refactoring.
09/12/08:
- 21:57 Changeset [36368] by
-
2008-09-12 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20819: JSValue::isObject() is slow
<https://bugs.webkit.org/show_bug.cgi?id=20819>
Optimize JSCell::isObject() and JSCell::isString() by making them
non-virtual calls that rely on the StructureID type information.
This is a 0.7% speedup on SunSpider and a 1.0% speedup on the V8
benchmark suite.
- JavaScriptCore.exp:
- kjs/JSCell.cpp:
- kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
- kjs/JSObject.cpp:
- kjs/JSObject.h:
- kjs/JSString.cpp:
- kjs/JSString.h: (JSC::JSString::JSString):
- kjs/StructureID.h: (JSC::StructureID::type):
- 19:59 Changeset [36367] by
-
Fix Mac build.
- css/CSSStyleSelector.cpp: (WebCore::getTransformOperationType):
- 18:10 Changeset [36366] by
-
Fix Windows build bustage.
- 17:47 Changeset [36365] by
-
Cleaning up LayoutTests/ChangeLog.
- 17:45 Changeset [36364] by
-
Cleaning up WebCore/ChangeLog
- 17:41 Changeset [36363] by
-
Roll out r36360 as it broke all non-Mac builds.
- 17:33 Changeset [36362] by
-
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
Tests: transitions/transform-op-list-match.html
transitions/transform-op-list-no-match.html
- css/CSSStyleSelector.cpp:
- css/CSSStyleSelector.h:
- page/animation/AnimationBase.cpp:
- page/animation/AnimationBase.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- rendering/RenderLayer.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- 16:30 Changeset [36361] by
-
2008-09-12 John Sullivan <sullivan@apple.com>
Fixed <rdar://problem/6110941> Clicking the print button in PDF content does nothing
Reviewed by Darin Adler
- WebView/WebPDFView.mm: (-[WebPDFView PDFViewPerformPrint:]): Implemented PDFKit delegate method that's called after a Print action in the PDF content
- 16:27 Changeset [36360] by
-
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
Exposes <ol>, <ul> and <dl> lists as AXLists through accessibility
- 15:43 Changeset [36359] by
-
Properly escape contents of links added to the inspector.
For now, just build the link with the DOM and get the
outerHTML. Eventually, we probably just want to do
this entirely with the DOM.
Reviewed by Timothy Hatcher.
- manual-tests/inspector/escape-links.html: Added.
- page/inspector/StylesSidebarPane.js:
- page/inspector/inspector.js:
- page/inspector/utilities.js:
- 15:14 Changeset [36358] by
-
2008-09-12 Adele Peterson <adele@apple.com>
Reviewed by John Sullivan and Kevin McCullough.
Fix for <rdar://problem/6216951> REGRESSION (r36000?): Crash due to infinite recursion into EventHandler::hitTestResultAtPoint() with disconnected frames
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): Hit testing again on the main frame will only work if we aren't already on the main frame. If we are already on the main frame, that will cause infinite recursion. This change checks that we're not already on the main frame before hit testing again.
- 15:08 Changeset [36357] by
-
WebCore:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim .
Re-introducing the code since it was not the cause of the crash.
See r36343.
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
- rendering/RenderObject.h:
LayoutTests:
2008-09-12 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Re-introducing the code since it was not the cause of the crash.
See r36343.
- fast/events/autoscroll-with-non-scrollable-parent.html:
- 14:54 Changeset [36356] by
-
2008-09-12 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
When changing one animation in a list, don't reset other animations
https://bugs.webkit.org/show_bug.cgi?id=20675
Test: animations/change-one-anim.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getNumProperties):
- page/animation/AnimationBase.h:
- page/animation/AnimationController.cpp:
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h: (WebCore::KeyframeAnimation::setIndex):
- 14:43 Changeset [36355] by
-
Fix Gtk build bustage.
- 14:42 Changeset [36354] by
-
Fix Qtbuild bustage.
- 11:47 ProposedWebInspectorRearchitecting edited by
- (diff)
- 11:40 Changeset [36353] by
-
2008-09-12 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel
Fix the ASSERT and failure in webarchive/archive-empty-frame-source.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Further restoration of original WebArchive behavior. Subresources can never be created from nil data, but there is always a MainResource, whether or not there's any data. So in the case where the main resource has no data, fake it for the sake of creating the ArchiveResource.
- 11:39 ProposedWebInspectorRearchitecting edited by
- (diff)
- 11:37 Changeset [36352] by
-
Make Scrollbar derive from Widget. Remove isWidget guards on Scrollbars.
- 11:22 Changeset [36351] by
-
Reviewed by Sam Weinig.
- https://bugs.webkit.org/show_bug.cgi?id=20793 clean up page/animation
- page/animation/AnimationController.cpp:
- page/animation/AnimationController.h:
- page/animation/CompositeAnimation.cpp:
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- 10:58 Changeset [36350] by
-
Reviewed by John Sullivan.
- fix a crash in -visibleRect when it is called during WebFrameView deallocation
- WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added an early return if _private is 0.
09/11/08:
- 21:44 Changeset [36349] by
-
Add a renderedImage method to DOMNode to get an image
of the rendering for the node and it's descendants.
<rdar://problem/5849349> Would like API to create
an image for a DOM node
Reviewed by Oliver Hunt.
- bindings/objc/DOM.mm: (-[DOMNode renderedImage]): Call Frame::nodeImage.
- bindings/objc/DOMPrivate.h:
- page/Frame.h:
- page/mac/FrameMac.mm: (WebCore::Frame::nodeImage):
- 18:25 Changeset [36348] by
-
2008-09-11 Dean Jackson <dino@apple.com>
Unfortunately the fix for
https://bugs.webkit.org/show_bug.cgi?id=20680
didn't update the relevant test
- css3/keyframes-rule-expected.txt:
- css3/keyframes-rule.html:
- 17:36 Changeset [36347] by
-
2008-09-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt
Need to support comma separated list of key times in keyframes selectors
https://bugs.webkit.org/show_bug.cgi?id=20680
Test: animations/keyframes-comma-separated.html
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::createKeyframeRule):
- css/CSSParser.h:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle):
- css/WebKitCSSKeyframeRule.cpp: (WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule): (WebCore::WebKitCSSKeyframeRule::cssText): (WebCore::WebKitCSSKeyframeRule::parseKeyString):
- css/WebKitCSSKeyframeRule.h: (WebCore::WebKitCSSKeyframeRule::keyText): (WebCore::WebKitCSSKeyframeRule::setKeyText): (WebCore::WebKitCSSKeyframeRule::getKeys):
- css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::insertRule): (WebCore::WebKitCSSKeyframesRule::deleteRule): (WebCore::WebKitCSSKeyframesRule::findRule): (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
- css/WebKitCSSKeyframesRule.h:
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::blendProperties):
- 17:24 Changeset [36346] by
-
Versioning.
- 17:24 Changeset [36345] by
-
Merge r36292.
- 17:15 Changeset [36344] by
-
New tag.
- 15:57 Changeset [36343] by
-
WebCore:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
RS by Tim.
Reverting because this caused a crash.
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): (WebCore::RenderObject::hasScrollableView):
- rendering/RenderObject.h:
LayoutTests:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
RS = Tim.
Reverted because this caused a crash.
- fast/events/autoscroll-with-non-scrollable-parent.html:
- 15:32 Changeset [36342] by
-
2008-09-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
Turn off PGO Optimization on CTI.cpp -> <rdar://problem/6207709>. Fixes
crash on CNN and on Dromaeo.
Fix Missing close tag in vcproj.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 14:59 Changeset [36341] by
-
2008-09-11 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Fix assertion on transition property "none"
https://bugs.webkit.org/show_bug.cgi?id=20751
Test: transitions/transition-end-event-set-none.html
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
- 14:54 Changeset [36340] by
-
2008-09-11 David Smith <catfish.man@gmail.com>
Rubber-stamped by mitzpettel.
Remove an accidentally added extra file.
- WebCore: Removed.
- 14:41 Changeset [36339] by
-
2008-09-11 David Smith <catfish.man@gmail.com>
Reviewed by Darin
This speeds up :nth-child matching as tested by querySelectorAll by around 10% by inlining the common case of Node::renderStyle(). Many thanks to mitzpettel and othermaciej for suggestions and help.
- WebCore.xcodeproj/project.pbxproj: Add NodeRenderStyle.h
- css/CSSStyleSelector.cpp: include NodeRenderStyle.h
- dom/Element.cpp: include NodeRenderStyle.h
- dom/Node.cpp: Remove the definition of renderStyle() (WebCore::Node::nonRendererRenderStyle):
- dom/Node.h: Make renderStyle() nonvirtual and add nonRendererRenderStyle()
- dom/NodeRenderStyle.h: Added. (WebCore::Node::renderStyle): Inline the common case of this, call nonRendererRenderStyle for the part that needed to be virtual
- html/HTMLOptGroupElement.cpp: include NodeRenderStyle.h
- html/HTMLOptGroupElement.h: (WebCore::HTMLOptGroupElement::nonRendererRenderStyle): override to return m_style
- html/HTMLOptionElement.cpp: include NodeRenderStyle.h
- html/HTMLOptionElement.h: (WebCore::HTMLOptionElement::nonRendererRenderStyle): override to return m_style
- rendering/RenderListBox.cpp: include NodeRenderStyle.h
- rendering/RenderMenuList.cpp: include NodeRenderStyle.h
- svg/SVGUseElement.cpp: include NodeRenderStyle.h
- 14:15 Changeset [36338] by
-
2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Not reviewed.
Correct an SVN problem with the last commit and actually add the new
files.
- wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
- wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
- 14:13 Changeset [36337] by
-
2008-09-11 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20788: Split CharacterClassConstructor into its own file
<https://bugs.webkit.org/show_bug.cgi?id=20788>
Split CharacterClassConstructor into its own file and clean up some
style issues.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wrec/CharacterClassConstructor.cpp: Added. (JSC::): (JSC::getCharacterClassNewline): (JSC::getCharacterClassDigits): (JSC::getCharacterClassSpaces): (JSC::getCharacterClassWordchar): (JSC::getCharacterClassNondigits): (JSC::getCharacterClassNonspaces): (JSC::getCharacterClassNonwordchar): (JSC::CharacterClassConstructor::addSorted): (JSC::CharacterClassConstructor::addSortedRange): (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush): (JSC::CharacterClassConstructor::append):
- wrec/CharacterClassConstructor.h: Added. (JSC::CharacterClassConstructor::CharacterClassConstructor): (JSC::CharacterClassConstructor::isUpsideDown): (JSC::CharacterClassConstructor::charClass):
- wrec/WREC.cpp: (JSC::WRECParser::parseCharacterClass):
- 13:29 Changeset [36336] by
-
Reviewed by John Sullivan.
- eliminate excessive repainting when a clipped iframe is moved (noticed in <rdar://problem/6204032>)
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Added. If the frame is in a RenderPart and has layout, gets the visible rect of the RenderPart and returns YES. Returns NO otherwise.
- WebView/WebFrameInternal.h:
- WebView/WebFrameView.mm: (-[WebFrameView visibleRect]): Added. Overrides this NSView method to take clipping in the render tree into account.
- 10:45 ProposedWebInspectorRearchitecting edited by
- (diff)
- 10:39 Changeset [36335] by
-
WebCore:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele and Tim.
<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)
- This was put in by Max to fix auto scrolling but is not correct for the whole web: rdar://problem/6213098
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled):
- rendering/RenderObject.h:
LayoutTests:
2008-09-11 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele and Tim.
<rdar://problem/6100597> REGRESSION: clicking on search results in Web
Inspector does not scroll to the line of the results (20167)
- This was put in by Max to fix some auto scroll behavior but is not correct for the whole web: rdar://problem/6213098
- fast/events/autoscroll-with-non-scrollable-parent.html:
- 09:24 Changeset [36334] by
-
<rdar://problem/6210511> AX: if a frame has a title, that should be reported as the AXWebArea's title
- 03:50 Changeset [36333] by
-
2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon.
Prevent leaking pages and frames in QWebKit autotest
- 02:53 Changeset [36332] by
-
2008-09-11 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon
Fix QtWebKit autotest
- 01:03 Changeset [36331] by
-
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Fixed stroke() and strokeRect() to support gradients
and patterns on Qt.
[Qt] Canvas stroke don't work for gradients and patterns
https://bugs.webkit.org/show_bug.cgi?id=20749
- 00:37 Changeset [36330] by
-
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Fixed canvas gradients for Qt
- 00:34 Changeset [36329] by
-
2008-09-11 Dirk Schulze <vbs85@gmx.de>
Reviewed by Simon.
Add support for patterns to Qt.
- 00:09 Changeset [36328] by
-
2008-09-10 Simon Hausmann <hausmann@webkit.org>
Not reviewed but trivial one-liner for yet unused macro.
Changed PLATFORM(WINCE) to PLATFORM(WIN_CE) as requested by Mark.
