Timeline
09/17/08:
- 23:45 Changeset [36605] by
-
2008-09-17 Oliver Hunt <oliver@apple.com>
Correctly restore argument reference prior to SFX runtime calls.
Reviewed by Steve Falkenburg.
- VM/CTI.cpp: (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
- 23:20 Changeset [36604] by
-
2008-09-17 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20876: REGRESSION (r36417, r36427): fast/js/exception-expression-offset.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20876>
r36417 and r36427 caused an get_by_id opcode to be emitted before the
instanceof and construct opcodes, in order to enable inline caching of
the prototype property. Unfortunately, this regressed some tests dealing
with exceptions thrown by 'instanceof' and the 'new' operator. We fix
these problems by detecting whether an "is not an object" exception is
thrown before op_instanceof or op_construct, and emit the proper
exception in those cases.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct):
- VM/CodeGenerator.h:
- VM/ExceptionHelpers.cpp: (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAnObjectError):
- VM/ExceptionHelpers.h:
- VM/Machine.cpp: (JSC::Machine::getOpcode): (JSC::Machine::privateExecute):
- VM/Machine.h:
- kjs/nodes.cpp: (JSC::NewExprNode::emitCode): (JSC::InstanceOfNode::emitCode):
- 22:51 Changeset [36603] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- 22:28 Changeset [36602] by
-
Fix mysterious Mac bustage.
- 22:10 Changeset [36601] by
-
2008-09-17 David Hyatt <hyatt@apple.com>
Switch back to having frameGeometry be virtual in order to keep Mac
the way it used to be.
Reviewed by Sam Weinig
- WebCore.base.exp:
- platform/Widget.cpp: (WebCore::Widget::setParent):
- platform/Widget.h:
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/mac/WidgetMac.mm: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/qt/WidgetQt.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/win/WidgetWin.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::frameGeometry): (WebCore::Widget::setFrameGeometry):
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget):
- 22:03 Changeset [36600] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix assertion in DOMWindow::adjustWindowRect where we were passing
in garbage values and were getting lucky that they were a not Nan.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncOpen):
- 21:28 Changeset [36599] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Fix gtk build.
- rendering/style/MatrixTransformOperation.cpp:
- 20:36 Changeset [36598] by
-
Fix Mac bustage.
- 20:34 Changeset [36597] by
-
New tag.
- 20:32 Changeset [36596] by
-
Fix build bustage on Qt, Gtk, Win.
- 20:32 Changeset [36595] by
-
New tag.
- 20:28 Changeset [36594] by
-
Fix build bustage on Qt, Gtk, Win.
- 20:23 Changeset [36593] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped with love by David Hyatt.
Split IdentityTransformOperation, MatrixTransformOperation, RotateTransformOperation,
ScaleTransformOperation, SkewTransformOperation, StyleTransformData, TransformOperation,
TransformOperations and TranslateTransformOperation out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/CSSStyleSelector.cpp:
- page/animation/AnimationBase.cpp: (WebCore::solveEpsilon):
- rendering/RenderLayer.cpp:
- rendering/style/IdentityTransformOperation.h: Copied from rendering/style/RenderStyle.h.
- rendering/style/MatrixTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/MatrixTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::MatrixTransformOperation::MatrixTransformOperation):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/RotateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/RotateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::RotateTransformOperation::RotateTransformOperation):
- rendering/style/ScaleTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/ScaleTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::ScaleTransformOperation::ScaleTransformOperation):
- rendering/style/SkewTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/SkewTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::SkewTransformOperation::SkewTransformOperation):
- rendering/style/StyleTransformData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleTransformData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleTransformData::operator!=):
- rendering/style/TransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperation::):
- rendering/style/TransformOperations.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::TransformOperations::TransformOperations):
- rendering/style/TransformOperations.h: Copied from rendering/style/RenderStyle.h. (WebCore::TransformOperations::operator!=):
- rendering/style/TranslateTransformOperation.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/TranslateTransformOperation.h: Copied from rendering/style/RenderStyle.h. (WebCore::TranslateTransformOperation::TranslateTransformOperation):
- 20:06 Changeset [36592] by
-
Fix Mac bustage.
- 20:00 Changeset [36591] by
-
Fix Qt bustage.
- 19:59 Changeset [36590] by
-
Build fix.
- 19:48 Changeset [36589] by
-
2008-09-17 David Hyatt <hyatt@apple.com>
(1) Inline a bunch of methods for accessing frame geometry.
(2) Make sure frameGeometry() works even when you have no underlying
native widget.
(3) Cache a frame geometry rect cross-platform (even for widgets that
have underlying native widgets.
(4) PluginView's updateWindow call is now a virtual function on Widget.
Reviewed by Sam Weinig
- ChangeLog:
- WebCore.base.exp:
- platform/Widget.cpp: (WebCore::Widget::setFrameGeometry):
- platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::frameGeometry): (WebCore::Widget::resize): (WebCore::Widget::move): (WebCore::Widget::isFrameView): (WebCore::Widget::windowClipRect):
- platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget): (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- platform/win/WidgetWin.cpp: (WebCore::Widget::updatePlatformWidgetFrameGeometry):
- plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): (WebCore::PluginView::geometryChanged):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePlatformWidgetFrameGeometry):
- plugins/wx/PluginViewWx.cpp:
- 19:47 Changeset [36588] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by David "Waterman" Hyatt.
Fix a leak of NSViews in WidgetMac.mm.
- platform/mac/WidgetMac.mm: (WebCore::Widget::~Widget):
- 18:46 Changeset [36587] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Waterman Hyatt.
Split FillLayer, StyleBackgroundData, StyleBoxData, StyleDashboardRegion, StyleMarqueeData
StyleMultiColData and StyleVisualData out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/style/FillLayer.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/FillLayer.h: Copied from rendering/style/RenderStyle.h. (WebCore::FillLayer::operator!=): (WebCore::FillLayer::hasImage): (WebCore::FillLayer::hasFixedImage):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/StyleBackgroundData.cpp: Copied from rendering/style/RenderStyle.cpp. (WebCore::StyleBackgroundData::StyleBackgroundData):
- rendering/style/StyleBackgroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleBackgroundData::operator!=):
- rendering/style/StyleBoxData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleBoxData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleBoxData::operator!=):
- rendering/style/StyleDashboardRegion.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleDashboardRegion::operator!=):
- rendering/style/StyleMarqueeData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleMarqueeData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMarqueeData::operator!=):
- rendering/style/StyleMultiColData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleMultiColData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleMultiColData::operator!=): (WebCore::StyleMultiColData::ruleWidth):
- rendering/style/StyleVisualData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleVisualData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleVisualData::operator==):
- 18:32 Changeset [36586] by
-
Fix Win build bustage.
- 18:17 Changeset [36585] by
-
Fix Win and Qt build bustage.
- 17:56 Changeset [36584] by
-
2008-09-17 David Hyatt <hyatt@apple.com>
Remove WidgetClient from Widget.
Reviewed by Sam Weinig
- WebCore.xcodeproj/project.pbxproj:
- platform/Widget.h: (WebCore::Widget::setClient): (WebCore::Widget::client):
- platform/WidgetClient.h: Removed.
- platform/gtk/WidgetGtk.cpp:
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::show): (WebCore::Widget::hide):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
- 17:40 Changeset [36583] by
-
Versioning.
- 17:39 Changeset [36582] by
-
2008-09-17 David Hyatt <hyatt@apple.com>
Remove isEnabled/setEnabled from Widget. The concept of being enabled now
only applies to Scrollbars so the method has been moved there and made
cross-platform. Scrollbar subclasses that have a corresponding native
widget can subclass setEnabled to change the enabled state of the native
widget.
Reviewed by Sam Weinig & Darin Adler
- WebCore.base.exp:
- platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h: (WebCore::Scrollbar::enabled): (WebCore::Scrollbar::setEnabled):
- platform/Widget.h:
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setEnabled):
- platform/gtk/ScrollbarGtk.h:
- platform/gtk/WidgetGtk.cpp:
- platform/mac/ScrollbarMac.h:
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::scrollbarHit): (WebCore::ScrollbarMac::setEnabled):
- platform/mac/WidgetMac.mm:
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp:
- 17:36 Changeset [36581] by
-
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
JIT generation cti_op_construct_verify.
Quarter to half percent progression on v8-tests.
Roughly not change on SunSpider (possible minor progression).
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/Machine.cpp:
- VM/Machine.h:
- 17:05 Changeset [36580] by
-
Land a comment in Widget.h to help describe the class.
- 16:56 Changeset [36579] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Split all RenderStyle enums into their own file.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/style/BorderValue.h:
- rendering/style/CollapsedBorderValue.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Copied from rendering/style/RenderStyle.h. (WebCore::):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
- 16:54 Changeset [36578] by
-
Improve timer accuracy for JavaScript Date object on Windows.
Use a combination of ftime and QueryPerformanceCounter.
ftime returns the information we want, but doesn't have sufficient resolution.
QueryPerformanceCounter has high resolution, but is only usable to measure time intervals.
To combine them, we call ftime and QueryPerformanceCounter initially. Later calls will use
QueryPerformanceCounter by itself, adding the delta to the saved ftime. We re-sync to
correct for drift if the low-res and high-res elapsed time between calls differs by more
than twice the low-resolution timer resolution.
QueryPerformanceCounter may be inaccurate due to a problems with:
- some PCI bridge chipsets (http://support.microsoft.com/kb/274323)
- BIOS bugs (http://support.microsoft.com/kb/895980/)
- BIOS/HAL bugs on multiprocessor/multicore systems (http://msdn.microsoft.com/en-us/library/ms644904.aspx)
Reviewed by Darin Adler.
- kjs/DateMath.cpp: (JSC::highResUpTime): (JSC::lowResUTCTime): (JSC::qpcAvailable): (JSC::getCurrentUTCTimeWithMicroseconds):
- 16:53 Changeset [36577] by
-
Add back isFrameView check to fix failed assertion during scroll bar teardown.
Reviewed by Dave Hyatt.
- platform/Scrollbar.cpp: (WebCore::Scrollbar::setParent):
- 16:41 Changeset [36576] by
-
2008-09-17 Simon Fraser <simon.fraser@apple.com>
Add pixel test expecteds for transform tests.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.checksum: Added.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.png: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.checksum: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.png: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
- 16:39 Changeset [36575] by
-
Fix win bustage.
- 16:30 Changeset [36574] by
-
2008-09-17 Brady Eidson <beidson@apple.com>
Reviewed by Mac build fix
- WebCore.xcodeproj/project.pbxproj: Send appropriate headers to WebKit
- 16:28 Changeset [36573] by
-
Fix build.
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setParentVisible):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::init):
- 16:25 Changeset [36572] by
-
[QtWebKit] Implement error handling in TextCodecQt::decode
Use the QTextCodec parsing state to set the sawError out variable. This
is needed to pass Test 70 of acid3. The test case for this bug is
fast/encoding/invalid-xml.html that is now partially passed. To pass
it completely the Qt text codecs need to be adjusted to have proper
error handling.
- 16:12 Changeset [36571] by
-
Fix Windows bustage.
- 16:11 Changeset [36570] by
-
Fix Windows bustage.
- 16:07 Changeset [36569] by
-
Fix Windows bustage.
- 16:03 Changeset [36568] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Rubber-stamped by Dave Hyatt.
Split BorderData, BorderValue, CollapsedBorderValue, OutlineValue and StyleSurroundData
out of RenderStyle.h/cpp
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- rendering/style/BorderData.h: Copied from rendering/style/RenderStyle.h. (WebCore::BorderData::hasBorderRadius): (WebCore::BorderData::borderLeftWidth): (WebCore::BorderData::borderRightWidth): (WebCore::BorderData::borderTopWidth): (WebCore::BorderData::borderBottomWidth): (WebCore::BorderData::operator!=):
- rendering/style/BorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::nonZero): (WebCore::BorderValue::isTransparent): (WebCore::BorderValue::isVisible):
- rendering/style/CollapsedBorderValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::): (WebCore::CollapsedBorderValue::CollapsedBorderValue): (WebCore::CollapsedBorderValue::operator==):
- rendering/style/OutlineValue.h: Copied from rendering/style/RenderStyle.h. (WebCore::OutlineValue::OutlineValue):
- rendering/style/RenderStyle.cpp:
- rendering/style/RenderStyle.h:
- rendering/style/StyleSurroundData.cpp: Copied from rendering/style/RenderStyle.cpp.
- rendering/style/StyleSurroundData.h: Copied from rendering/style/RenderStyle.h. (WebCore::StyleSurroundData::operator!=):
- 16:00 Changeset [36567] by
-
2008-09-17 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
This is a better fix for: Invalid CSS code crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=20512
The spec indicates that the only valid input for a counter is a
number or an identifier. So that is exactly what we allow.
- css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):
- 15:40 Changeset [36566] by
-
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Implement JIT generation of CallFrame initialization, for op_call.
1% sunspider 2.5% v8-tests.
- VM/CTI.cpp: (JSC::CTI::compileOpCall):
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_NotJSFunction):
- 15:22 Changeset [36565] by
-
Fix Qt bustage.
- 15:21 Changeset [36564] by
-
Fix Qt bustage.
- 15:16 Changeset [36563] by
-
2008-09-17 Alp Toker <alp@nuanti.com>
GTK+ build fix. Adapt to use PlatformWidget functions.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
- platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::geometryChanged):
- 15:07 Changeset [36562] by
-
Fix wx bustage.
- 15:07 Changeset [36561] by
-
Fix Qt bustage.
- 15:00 Changeset [36560] by
-
WebCore:
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Patch for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size
Test: fast/dom/Window/window-resize-and-move-sub-frame.html
- page/DOMWindow.cpp: (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
LayoutTests:
2008-09-17 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Test for <rdar://problem/6133884>
Calling window.resizeTo() on a subframe shouldn't change the window size
- fast/dom/Window/resources/blank.html: Added.
- fast/dom/Window/window-resize-and-move-sub-frame-expected.txt: Added.
- fast/dom/Window/window-resize-and-move-sub-frame.html: Added.
- 14:49 ProposedWebInspectorRearchitecting edited by
- (diff)
- 14:45 ProposedWebInspectorRearchitecting edited by
- (diff)
- 14:43 ProposedWebInspectorRearchitecting edited by
- added random notes (diff)
- 14:35 Changeset [36559] by
-
WebCore:
2008-09-17 Beth Dakin <bdakin@apple.com>
Reviewed by Adam Roben.
Fix for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>
Reading through the spec, it seems like a function is not valid
input for a counter. So this patch checks for that and bails in the
case of invalid input.
- css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent):
LayoutTests:
2008-09-17 Beth Dakin <bdakin@apple.com>
Reviewed by Adam Roben.
Test for https://bugs.webkit.org/show_bug.cgi?id=20512 Invalid CSS
code crashes Safari
and corresponding: <rdar://problem/6173832>
- fast/css/counters/counter-function-input-2-expected.txt: Added.
- fast/css/counters/counter-function-input-2.html: Added.
- fast/css/counters/counter-function-input-expected.txt: Added.
- fast/css/counters/counter-function-input.html: Added.
- 14:30 Changeset [36558] by
-
Fix Gtk bustage.
- 14:28 Changeset [36557] by
-
Fix Qt bustage.
- 14:17 Changeset [36556] by
-
Fix Mac bustage.
- 14:16 Changeset [36555] by
-
Fix Qt bustage
- 14:14 Changeset [36554] by
-
2008-09-17 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Antti Koivisto.
Fix <rdar://problem/6227089>
Crash in WebCore::Frame::setNeedsReapplyStyles()
View is null checked elsewhere too.
- page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles):
- 13:59 Changeset [36553] by
-
WebCore:
2008-09-17 David Hyatt <hyatt@apple.com>
Make the notion of having a native widget backing a Widget cross-platform.
The PlatformWidget abstraction (which already existed) is used for this.
Windows = HWND
Qt = QWidget
Mac = NSView
wx = wxWindow
Gtk = GtkWidget
There are new cross-platform methods that replace all of the unique
platform-specific methods.
platformWidget()
setPlatformWidget()
For plugins, on every platform except Qt on Windows, the plugin's native
widget is now stored in the Widget base class. Since Qt on Windows uses
HWNDs for plugins instead of QWidget, it is the only platform to keep the
m_window variable in PluginView.
Reviewed by Sam Weinig
- WebCore.base.exp:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- page/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper attachmentView]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::mouseDownViewIfStillGood): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
- platform/Widget.h: (WebCore::Widget::platformWidget): (WebCore::Widget::setPlatformWidget):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setFocus): (WebCore::gdkDrawable): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::paint):
- platform/mac/PlatformScreenMac.mm: (WebCore::screenRect): (WebCore::screenAvailableRect):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollView): (WebCore::ScrollView::update): (WebCore::ScrollView::inWindow):
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::~ScrollbarMac): (WebCore::ScrollbarMac::updateThumbPosition): (WebCore::ScrollbarMac::updateThumbProportion): (WebCore::ScrollbarMac::scrollbarHit):
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setFocus): (WebCore::Widget::getOuterView): (WebCore::Widget::paint): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::setIsSelected): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::isEnabled): (WebCore::Widget::setEnabled): (WebCore::Widget::invalidateRect): (WebCore::Widget::containingWindow):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget): (WebCore::Widget::frameGeometry): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect): (WebCore::Widget::paint):
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h: (WebCore::PluginView::platformPluginWidget):
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParent): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::getValue): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updateWindow): (WebCore::PluginView::setFocus): (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::paint): (WebCore::PluginView::setParent): (WebCore::PluginView::setParentVisible): (WebCore::PluginView::setNPWindowRect): (WebCore::PluginView::stop): (WebCore::PluginView::invalidateRect): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::~PluginView): (WebCore::PluginView::init):
WebKit/mac:
2008-09-17 David Hyatt <hyatt@apple.com>
Make the notion of Widget having an underlying native widget cross-platform.
Reviewed by Sam Weinig
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent):
- WebView/WebFrame.mm: (-[WebFrame _dragSourceMovedTo:]): (-[WebFrame _dragSourceEndedAt:operation:]):
- WebView/WebFrameView.mm: (-[WebFrameView _install]):
- WebView/WebRenderNode.mm: (copyRenderNode):
- 13:27 Changeset [36552] by
-
Merge r36126.
- 13:27 Changeset [36551] by
-
Merge r35950.
- 13:27 Changeset [36550] by
-
Merge r32881.
- 13:27 Changeset [36549] by
-
Versioning.
- 13:27 Changeset [36548] by
-
Merge new Vector::remove variant from r30593.
- 13:27 Changeset [36547] by
-
Versioning.
- 13:17 Changeset [36546] by
-
build fix
- 13:16 Changeset [36545] by
-
2008-09-17 Sam Weinig <sam@webkit.org>
Fix assert.
- platform/Widget.cpp: (WebCore::Widget::setParent):
- 12:29 Changeset [36544] by
-
2008-09-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Optimizations for op_call in CTI. Move check for (ctiCode == 0) into JIT code,
move copying of scopeChain for CodeBlocks that needFullScopeChain into head of
functions, instead of checking prior to making the call.
3% on v8-tests (4% on richards, 6% in delta-blue)
- VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
- VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_vm_updateScopeChain): (JSC::Machine::cti_op_construct_JSConstruct):
- VM/Machine.h:
- 11:46 Changeset [36543] by
-
2008-09-17 David Hyatt <hyatt@apple.com>
Beginnings of Widget refactoring (in order to make the mixing of
widgets with and without corresponding native widgets more cross-platform).
This first patch makes the concept of a parent ScrollView cross-platform.
Note the similarity of the show/hide methods on the three PluginViews. This
will be refactored better in a later patch so that they can all share
a base class Widget show/hide method. For now the changes were made
simply to be able to bring WidgetWin's setParent method up into Widget.
Reviewed by Sam Weinig
- WebCore.base.exp:
- platform/ScrollView.h:
- platform/Widget.cpp: (WebCore::Widget::init): (WebCore::Widget::setParent):
- platform/Widget.h: (WebCore::Widget::isSelfVisible): (WebCore::Widget::isParentVisible): (WebCore::Widget::isVisible): (WebCore::Widget::setParentVisible): (WebCore::Widget::isPluginView): (WebCore::Widget::parent): (WebCore::Widget::handleEvent): (WebCore::Widget::geometryChanged):
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget):
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
- platform/mac/ScrollbarMac.mm: (WebCore::ScrollbarMac::~ScrollbarMac):
- platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget):
- platform/qt/WidgetQt.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::topLevel):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::setAncestorVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
- platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setParent):
- platform/wx/WidgetWx.cpp: (WebCore::Widget::Widget):
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::show): (WebCore::PluginView::hide): (WebCore::PluginView::setParentVisible):
- 11:16 ProposedWebInspectorRearchitecting edited by
- added a note on fetchMessages (diff)
- 11:08 ProposedWebInspectorRearchitecting edited by
- minor tweaking of the description. (diff)
- 11:02 ProposedWebInspectorRearchitecting edited by
- added a bit of background description on current InspectorController … (diff)
- 09:50 Changeset [36542] by
-
Reviewed by Adam Roben.
<rdar://problem/6219577> Spew in console at launch about encoding mappings when running with ICU 4.0
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Updated for new encoding names.
- 06:29 Changeset [36541] by
-
2008-09-17 Tor Arne Vestbø <tavestbo@trolltech.com>
Fix the QtWebKit/Mac build
- 01:34 Changeset [36540] by
-
Fix Gtk bustage.
- 01:17 Changeset [36539] by
-
\2008-09-17 David Hyatt <hyatt@apple.com>
Add a #define to control whether or not to use an NSScroller on Mac.
This ifdef will allow the new NSView-less NSScroller on Mac to be
developed side by side with the current one.
The new scroller paints a debug red if turned on (although due to
Widget issues you won't see anything paint yet).
Reviewed by olliej
- platform/Scrollbar.cpp:
- platform/Scrollbar.h:
- platform/mac/ScrollbarMac.h:
- platform/mac/ScrollbarMac.mm:
- platform/mac/ScrollbarThemeMac.cpp: (WebCore::ScrollbarThemeMac::paint):
- platform/mac/ScrollbarThemeMac.h:
09/16/08:
- 23:48 Changeset [36538] by
-
Fix Qt bustage.
- 23:32 Changeset [36537] by
-
Fix Qt bustage.
- 22:50 Changeset [36536] by
-
Fix gtk bustage.
- 22:06 Changeset [36535] by
-
2008-09-16 Alp Toker <alp@nuanti.com>
Prospective Qt build fix. ScrollBar.h -> Scrollbar.h
- Api/qwebframe.cpp:
- Api/qwebpage.cpp:
- 21:35 Changeset [36534] by
-
Fix Qt build bustage.
- 21:30 Changeset [36533] by
-
2008-09-16 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=20854
[GTK] Windows can be not realized in ScrollView::update
Do not call gdk_window_invalidate_rect on a non-realized GtkWidget.
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::update):
- 21:22 Changeset [36532] by
-
2008-09-16 Alp Toker <alp@nuanti.com>
Suggested by Dave Hyatt.
Build fix and cleanup. Rename ScrollBar to Scrollbar.
- 21:22 Changeset [36531] by
-
Fix Qt build bustage.
- 20:54 Changeset [36530] by
-
Fix Gtk/Qt build bustage.
- 20:49 Changeset [36529] by
-
2008-09-16 David Hyatt <hyatt@apple.com>
Fix Qt build bustage by making moveThumb a member of Scrollbar so that
it can be called from ScrollbarQt.
- platform/ScrollBar.cpp: (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMousePressEvent):
- platform/ScrollBar.h:
- platform/qt/ScrollViewQt.cpp:
- platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::handleContextMenuEvent):
- 20:17 Changeset [36528] by
-
2008-09-16 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20857: REGRESSION (r36427): ASSERTION FAILED: m_refCount >= 0 in RegisterID::deref()
<https://bugs.webkit.org/show_bug.cgi?id=20857>
Fix a problem stemming from the slightly unsafe behaviour of the
CodeGenerator::finalDestination() method by putting the "func" argument
of the emitConstruct() method in a RefPtr in its caller. Also, add an
assertion guaranteeing that this is always the case.
CodeGenerator::finalDestination() is still incorrect and can cause
problems with a different allocator; see bug 20340 for more details.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct):
- kjs/nodes.cpp: (JSC::NewExprNode::emitCode):
LayoutTests:
- fast/js/codegen-temporaries-expected.txt:
- fast/js/resources/codegen-temporaries.js:
- 20:17 Changeset [36527] by
-
WebCore:
2008-09-16 David Hyatt <hyatt@apple.com>
Eliminate PlatformScrollbar. Mac and Gtk now have subclasses for their
native-widget scrollbars (ScrollbarMac and ScrollbarGtk). Other platforms
now just use Scrollbar.
Reviewed by Sam Weinig
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/mac/FrameMac.mm:
- platform/PopupMenu.h: (WebCore::PopupMenu::scrollbar):
- platform/ScrollBar.cpp: (WebCore::createNativeScrollbar):
- platform/ScrollBar.h:
- platform/gtk/PlatformScrollBar.h: Removed.
- platform/gtk/PlatformScrollBarGtk.cpp: Removed.
- platform/gtk/ScrollbarGtk.cpp: Copied from platform/gtk/PlatformScrollBarGtk.cpp. (gtkScrollEventCallback): (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk): (ScrollbarGtk::updateThumbPosition): (ScrollbarGtk::updateThumbProportion): (ScrollbarGtk::setFrameGeometry): (ScrollbarGtk::geometryChanged): (ScrollbarGtk::gtkValueChanged):
- platform/gtk/ScrollbarGtk.h: Copied from platform/gtk/PlatformScrollBar.h.
- platform/mac/PlatformScrollBar.h: Removed.
- platform/mac/PlatformScrollBarMac.mm: Removed.
- platform/mac/ScrollbarMac.h: Copied from platform/mac/PlatformScrollBar.h.
- platform/mac/ScrollbarMac.mm: Copied from platform/mac/PlatformScrollBarMac.mm. (-[WebCoreScrollBar initWithScrollbarMac:]): (-[WebCoreScrollBar detachScrollbarMac]): (WebCore::Scrollbar::createNativeScrollbar): (WebCore::ScrollbarMac::ScrollbarMac): (WebCore::ScrollbarMac::~ScrollbarMac): (WebCore::ScrollbarMac::updateThumbPosition): (WebCore::ScrollbarMac::updateThumbProportion): (WebCore::ScrollbarMac::scrollbarHit):
- platform/qt/PlatformScrollBar.h: Removed.
- platform/qt/PlatformScrollBarQt.cpp: Removed.
- platform/qt/ScrollbarQt.cpp: Copied from platform/qt/PlatformScrollBarQt.cpp. (WebCore::Scrollbar::handleContextMenuEvent):
- rendering/HitTestResult.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderObject.h:
- rendering/RenderTextControl.cpp:
WebKit/win:
2008-09-16 David Hyatt <hyatt@apple.com>
Eliminate PlatformScrollbar.
Reviewed by Sam Weinig
- WebScrollBar.cpp: (WebScrollBar::init):
- WebScrollBar.h:
- 19:15 Changeset [36526] by
-
2008-09-16 David Hyatt <hyatt@apple.com>
Make the scrollbar resizer-dodging logic cross-platform in the
Scrollbar class.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::setFrameGeometry): (WebCore::Scrollbar::setParent): (WebCore::Scrollbar::windowClipRect):
- platform/ScrollBar.h:
- platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustOverlappingScrollbarCount):
- platform/Widget.h: (WebCore::Widget::setParent):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertToContainingWindow):
- platform/win/PlatformScrollBar.h:
- platform/win/PlatformScrollBarWin.cpp:
- 17:18 Changeset [36525] by
-
Disable fast/js/garbage-collect-after-string-appends.html.
- 16:04 Changeset [36524] by
-
Tweak garbage-collect-after-string-appends.js to not fail when run twice or more in a row.
This will hopefully address the intermittent failures seen on the build bot.
Rubber-stamped by Sam Weinig.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 15:28 Changeset [36523] by
-
2008-09-16 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add flag to disable running sample on tests that timeout.
- Scripts/run-webkit-tests:
- 14:46 Changeset [36522] by
-
2008-09-16 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
New tests for keyframe animations
https://bugs.webkit.org/show_bug.cgi?id=20891
- animations/keyframes-expected.txt: Added.
- animations/keyframes-out-of-order-expected.txt: Added.
- animations/keyframes-out-of-order.html: Added.
- animations/keyframes.html: Added.
- 13:43 Changeset [36521] by
-
2008-09-16 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Update layout test results for tests changed by http://trac.webkit.org/changeset/35799
- platform/mac-leopard/security/block-test-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- security/block-test-expected.txt:
- 13:15 Changeset [36520] by
-
2008-09-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Mark Rowe
Fix test cases that call notifyDone() twice
https://bugs.webkit.org/show_bug.cgi?id=20884
- animations/change-one-anim.html:
Only respond to one of the two running animations, to avoid
doing things twice.
https://bugs.webkit.org/show_bug.cgi?id=20881
- svg/custom/gradient-attr-update.svg:
Fix the test to not run code both on an onload handler,
and on the synthetic click handler.
https://bugs.webkit.org/show_bug.cgi?id=20884
- 12:40 Changeset [36519] by
-
Windows build fix after r36511
Update for rename of layoutTestController to gLayoutTestController.
- DumpRenderTree/LayoutTestController.cpp:
- DumpRenderTree/win/EditingDelegate.cpp:
- DumpRenderTree/win/FrameLoadDelegate.cpp:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/UIDelegate.cpp:
- 12:32 Changeset [36518] by
-
2008-09-16 Alice Liu <alice.liu@apple.com>
build fix.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- 11:47 Changeset [36517] by
-
Add a script to print out the dependency tree of a Visual Studio solution file
- Scripts/print-msvc-project-dependencies: Added.
- 11:01 Changeset [36516] by
-
Fix the build.
- DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Call fprintf in a safer manner.
- 10:40 Changeset [36515] by
-
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=15129 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
Covered by fast/repaint/4776765.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Avoid repainting this object if it did not have layout in the beginning. (WebCore::RenderBlock::layoutBlockChildren): If a child did not have layout in the beginning, repaint it in its new position, to compensate for the above (regardless of whether it "moved").
- rendering/RenderObject.cpp: (WebCore::RenderObject::checkForRepaintDuringLayout): Added a comment about generalizing this fix in the future.
LayoutTests:
Reviewed by Darin Adler.
- updated results for https://bugs.webkit.org/show_bug.cgi?id=15129 <rdar://problem/4644824> adding a new line with DOM does unnecessary additional repaint
- platform/mac/fast/repaint/4776765-expected.checksum:
- platform/mac/fast/repaint/4776765-expected.png:
- 10:40 Changeset [36514] by
-
2008-09-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
CTI code generation for op_ret. The majority of the work
(updating variables on the stack & on exec) can be performed
directly in generated code.
We still need to check, & to call out to C-code to handle
activation records, profiling, and full scope chains.
+1.5% Sunspider, +5/6% v8 tests.
- VM/CTI.cpp: (JSC::CTI::emitPutCTIParam): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::cti_op_ret_activation): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain):
- VM/Machine.h:
- 10:34 Changeset [36513] by
-
WebCore:
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=15384 Div does not notice when grandparent changes height
Test: fast/block/basic/quirk-percent-height-grandchild.html
- fix https://bugs.webkit.org/show_bug.cgi?id=20714 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
Test: fast/replaced/percent-height-in-anonymous-block.html
Added a two-way mapping between boxes with percentage heights and
their non-parent ancestors up to the one the height is computed relative
to. In quirks mode (the first bug), this can be any number of containing
block with auto height. In strict mode (the second bug) this can be
the containing block of an anonymous block containing a replaced
element.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Added code to remove the all the mapping to/from this block to percentage-height descendants. (WebCore::RenderBlock::layoutBlockChildren): Added code to mark percentage-height descendants (and their containing block ancestry chain up to this block) for layout. This ensures that those descendants whose height depends on the height of this block (or an ancestor) are updated. (WebCore::RenderBlock::addPercentHeightDescendant): Added. Establishes a two-way mapping between this block and the given box. (WebCore::RenderBlock::removePercentHeightDescendant): Added. Removes all the mapping to/from this box.
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Added calls to removePercentHeightDescendant() when style changes and the box previously had a percentage height. An exception is when the style change does not require layout, in which case the box still has a percentage height and the mappings are valid. In all other cases, any required mappings will be (re-)established during layout. (WebCore::RenderBox::destroy): Added a call to removePercentHeightDescendant. (WebCore::RenderBox::calcPercentageHeight): Added code that, in quirks mode, if a higher-than-parent containing block is affecting the box's height, creates a mapping between the box and that block. (WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over anonymous containing blocks, if any, and when that happens, use addPercentHeightDescendant() to ensure that the non-anonymous block is aware of the dependent percent-height box.
LayoutTests:
Reviewed by Dave Hyatt.
- test for https://bugs.webkit.org/show_bug.cgi?id=15384 Div does not notice when grandparent changes height
- test for https://bugs.webkit.org/show_bug.cgi?id=20714 Resizing Gmail inbox vertically results in whitespace at the bottom of the window
- fast/block/basic/quirk-percent-height-grandchild.html: Added.
- fast/replaced/percent-height-in-anonymous-block.html: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.checksum: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.png: Added.
- platform/mac/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.checksum: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.png: Added.
- platform/mac/fast/replaced/percent-height-in-anonymous-block-expected.txt: Added.
- 10:27 Changeset [36512] by
-
2008-09-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Protect against tests that call layoutTestController.notifyDone()
more than once, which would lead to memory corruption, by nulling
out the LayoutTestController on the JSObjectRef on destruction. Also
add a finalize callback on the class so that if the LTC outlives
the JSObjectRef, the JSObjectRef backpointer on the LTC can be
nulled out.
- 10:22 Changeset [36511] by
-
2008-09-16 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel
Step 1 patch: rename global variable for clarity.
https://bugs.webkit.org/show_bug.cgi?id=20875
- 10:02 Changeset [36510] by
-
Fix typo in Dimitri's email address.
- 09:59 Changeset [36509] by
-
2008-09-16 Dimitri Glazkov <dlglazkov@chromium.org>
Fix the Windows build.
Add some extra parentheses to stop MSVC from complaining so much.
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq):
- kjs/operations.cpp: (JSC::strictEqual):
- 09:59 Changeset [36508] by
-
2008-09-16 Dirk Schulze <vbs85@gmx.de>
Reviewed by Oliver Hunt and Alp Toker.
Implemented toDataURL in Cairo. Only PNG support
at the moment.
Qt, Cairo and wx require toDataURL implementations
https://bugs.webkit.org/show_bug.cgi?id=17719
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::writeFunction): (WebCore::ImageBuffer::toDataURL):
- 09:52 GlibBindings edited by
- It's "Mac OS X"… (diff)
- 09:47 Changeset [36507] by
-
Revert r36505 ("Only forward events to media element controls if they are visible")
Sorry, it snuck in while trying to commit something else.
- 09:45 Changeset [36506] by
-
2008-09-16 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Hide unused media element controls in the QtWebKit port
- 09:40 Changeset [36505] by
-
Only forward events to media element controls if they are visible
- 09:12 Changeset [36504] by
-
New branch.
- 07:19 Changeset [36503] by
-
2008-09-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix compilation of the Qt scrollbar code.
- 07:15 Changeset [36502] by
-
Reviewed by Anders Carlsson.
Prevent accesses off of the end of the buffer introduced in r36450
and when checking for descriptions of mime. Also, coding style fix.
- 05:50 GlibBindings created by
- 05:34 WikiStart edited by
- (diff)
- 05:29 ApplicationsGtk edited by
- (diff)
- 04:12 Changeset [36501] by
-
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=20634
SVG transform attribute is ignored by <use> in <clipPath>
Transform the paths with the local transform when part
of a clip path.
Test: svg/custom/use-clipped-transform.svg
- 04:07 Changeset [36500] by
-
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
Move more instance variables down to the C++ class.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream transferMode]): (-[WebBaseNetscapePluginStream plugin]): (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]): (-[WebBaseNetscapePluginStream _deliverDataToFile:]): (-[WebBaseNetscapePluginStream finishedLoading]): (-[WebBaseNetscapePluginStream receivedData:]):
- 02:48 Changeset [36499] by
-
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Move a bunch of instance variables into the C++ class.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): (-[WebBaseNetscapePluginStream errorForReason:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream setRequestURL:]): (-[WebBaseNetscapePluginStream setResponseURL:]): (-[WebBaseNetscapePluginStream setMIMEType:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]): (-[WebBaseNetscapePluginStream receivedData:]):
- 02:47 Changeset [36498] by
-
Fix Qt build bustage in PlatformScrollbarQt.cpp
- 02:33 Changeset [36497] by
-
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Add a new WebNetscapePluginStream C++ class. The idea is that it is supposed to replace the Obj-C
WebBaseNetscapePluginStream class. The plan is to gradually move/rewrite code from the Obj-C class to the C++ class
until the C++ class can replace the Obj-C class.
- Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create): (WebNetscapePluginStream::WebNetscapePluginStream):
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
- 02:27 Changeset [36496] by
-
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 02:21 Changeset [36495] by
-
Speculative fix for scrollbar issues on GTK.
- 02:17 Changeset [36494] by
-
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 02:16 Changeset [36493] by
-
Fix Qt build bustage in ScrollbarThemeQt.cpp
- 02:15 Changeset [36492] by
-
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Instead of storing a pointer to NPP method individually, just store a pointer to the NPNetscapeFuncs vtable.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream wantsAllStreams]): (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _deliverData]):
- Plugins/WebNetscapePluginPackage.h:
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage pluginFuncs]):
- 02:11 Changeset [36491] by
-
Fix Qt build bustage in PlatformScrollbarQt.cpp
- 02:06 Changeset [36490] by
-
2008-09-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dave Hyatt.
Remove references to WebNetscapePluginStream.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebNetscapePluginEmbeddedView.h:
- 02:00 Changeset [36489] by
-
Fix GTK bustage. Maybe. Cleaning up after Chris Fleizach's checkin...
09/15/08:
- 23:53 Changeset [36488] by
-
Convert Qt to ScrollbarTheme. Add cross-platform support for jumping a scrollbar thumb directly to a position on the track (Shift+Click on Windows, Middle Click on Qt)
- 23:48 Changeset [36487] by
-
Fix Qt build bustage in Localizations.
- 23:39 Changeset [36486] by
-
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=20860 REGRESSION: Crash in RenderLayer::hasVisibleContent() loading wavy.com
- WebView/WebFrame.mm: (-[WebFrame _getVisibleRect:]): Changed to check if the RenderPart has layout before accessing it, instead of checking if the frame inside it has layout.
- 23:14 Changeset [36485] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Sam Weinig.
Cache the result of parsing the an+b expression in :nth-child(an+b). Roughly a 2x speedup for :nth-child on SlickSpeed.
- GNUmakefile.am: Add CSSNthSelector
- WebCore.pro: Add CSSNthSelector
- WebCore.vcproj/WebCore.vcproj: Add CSSNthSelector
- WebCore.xcodeproj/project.pbxproj: Add CSSNthSelector
- css/CSSGrammar.y: Create CSSNthSelectors instead of CSSSelectors for :nth-*
- css/CSSNthSelector.cpp: Added. (WebCore::CSSNthSelector::parseNth): Moved from CSSStyleSelector and modified to cache (WebCore::CSSNthSelector::matchNth): Moved from CSSStyleSelector and modified to use the cache
- css/CSSNthSelector.h: Added. (WebCore::CSSNthSelector::CSSNthSelector): (WebCore::CSSNthSelector::~CSSNthSelector):
- css/CSSParser.cpp: (WebCore::CSSParser::createFloatingNthSelector):
- css/CSSParser.h:
- css/CSSSelector.h: Use the free bit here to store a flag for CSSNthSelector (WebCore::CSSSelector::CSSSelector):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Take advantage of knowing that all :nth-* selectors are CSSNthSelectors
- 23:12 Changeset [36484] by
-
Complete my previous changelog entry
- 23:08 Changeset [36483] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up the === and !== operators by choosing the fast cases better
No effect on SunSpider but speeds up the V8 EarlyBoyer benchmark about 4%.
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq):
- kjs/JSImmediate.h: (JSC::JSImmediate::areBothImmediate):
- kjs/operations.cpp: (JSC::strictEqual): (JSC::strictEqualSlowCase):
- kjs/operations.h:
- 23:06 Changeset [36482] by
-
Coding style cleanup.
RS=Sam
- 22:54 Changeset [36481] by
-
2008-09-15 Alice Liu <alice.liu@apple.com>
A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
Reviewed by Stephanie Lewis.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, but not Intel. Add a check for nil before calling. (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange):
- 22:53 Changeset [36480] by
-
Bug 20874: op_resolve does not do any form of caching
<https://bugs.webkit.org/show_bug.cgi?id=20874>
Reviewed by Cameron Zwarich
This patch adds an op_resolve_global opcode to handle (and cache)
property lookup we can statically determine must occur on the global
object (if at all).
3% progression on sunspider, 3.2x improvement to bitops-bitwise-and, and
10% in math-partial-sums
- 22:39 Changeset [36479] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36478. It did little to help the issue either.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 22:14 Changeset [36478] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Avoid the single character optimization.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 21:34 Changeset [36477] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36476. It did little to help the issue.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 20:59 Changeset [36476] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Make this test a little more forgiving.
- fast/js/resources/garbage-collect-after-string-appends.js:
- 20:46 Changeset [36475] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Roll out r36462. It broke document.all.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::isJSString):
- kjs/JSCell.h:
- kjs/JSWrapperObject.h:
- kjs/StringObject.h:
- kjs/StringObjectThatMasqueradesAsUndefined.h:
- 20:27 Changeset [36474] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase.html
now passes on Leopard in 10.5.5.
- platform/mac-leopard/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
- 19:46 Changeset [36473] by
-
2008-09-15 Matt Lilek <webkit@mattlilek.com>
Reviewed by Tim Hatcher.
Clean up some inspector JS callbacks to remove an extra return.
- page/InspectorController.cpp: (WebCore::hideDOMNodeHighlight): (WebCore::loaded): (WebCore::unloading): (WebCore::attach): (WebCore::detach): (WebCore::startDebuggingAndReloadInspectedPage): (WebCore::stopDebugging): (WebCore::debuggerAttached): (WebCore::pauseOnExceptions): (WebCore::pauseInDebugger): (WebCore::resumeDebugger): (WebCore::stepOverStatementInDebugger): (WebCore::stepIntoStatementInDebugger): (WebCore::stepOutOfFunctionInDebugger): (WebCore::isWindowVisible): (WebCore::closeWindow):
- 19:44 Changeset [36472] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20863: ASSERTION FAILED: addressOffset < instructions.size() in CodeBlock::getHandlerForVPC
<https://bugs.webkit.org/show_bug.cgi?id=20863>
r36427 changed the number of arguments to op_construct without changing
the argument index for the vPC in the call to initializeCallFrame() in
the CTI case. This caused a JSC test failure. Correcting the argument
index fixes the test failure.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_JSConstruct):
- 19:30 Changeset [36471] by
-
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 19:29 Changeset [36470] by
-
Scrollbars on Windows are now completely under the control of their theme classes. It is now possible to switch between Aqua scrollbars and native scrollbars via a preferences setting (the same one used for controls.
- 18:34 Changeset [36469] by
-
Fix GCC 4.2 build.
- 17:46 Changeset [36468] by
-
2008-09-15 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Make transform animation behavior match spec
https://bugs.webkit.org/show_bug.cgi?id=20770
- transitions/transform-op-list-match-expected.txt: Added.
- transitions/transform-op-list-match.html: Added.
- transitions/transform-op-list-no-match-expected.txt: Added.
- transitions/transform-op-list-no-match.html: Added.
- 17:17 Changeset [36467] by
-
<rdar://problem/4003789> Expose lists as AXList
<rdar://problem/5707399> VO: Definition lists not announced in Safari
https://bugs.webkit.org/show_bug.cgi?id=20808
Lists are now exposed through AX. On the mac (in SnowLeopard) they use two new subroles
AXContentList for <ul>, <ol> and AXDefinitionList for <dl>
Inside the definition list, each <dt> "term" has an accessibility description ("term"),
as does each <dd> tag ("definition")
- 17:01 Changeset [36466] by
-
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20865
Prepare HTMLScriptElement & SVGScriptElement unification, and unification of event handling.
Several renames:
dispatchHTMLEvent -> dispatchEventForType
setHTMLEventListener -> setEventListenerForType
getHTMLEventListener -> eventListenerForType
removeHTMLEventListener -> removeEventListenerForType
isHTMLEventListener -> isAttachedToEventTargetNode
...
Similar renames for the dispatch/get/set/*Window*Event functions.
Kill JSSVGLazyEventListener and merge with JSLazyEventListener.
Most important change: Rename setHTMLEventListener to setEventListenerForTypeAndAttribute,
as there exists a generic createEventListener() method now, taking care of JSLazyEventListener creation.
setHTMLEventListener() used createHTMLEventListener() before and was HTML specific.
SVG is able to use the code as well now. This affects most files in html/.
No functional changes.
- 16:44 Changeset [36465] by
-
Switch PlatformScrollbarWin's hit testing to use ScrollbarTheme. The file is now nearly completely empty. PlatformScrollbarSafari and PlatformScrollbarQt still need to be converted.
- 16:38 Changeset [36464] by
-
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed a typo in op_get_by_id_chain that caused it to miss every time
in the interpreter.
Also, a little cleanup.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Set up baseObject before entering the loop, so we compare against the right values.
- 16:37 Changeset [36463] by
-
2008-09-15 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed the CalledAsConstructor flag from the call frame header. Now,
we use an explicit opcode at the call site to fix up constructor results.
SunSpider says 0.4% faster.
cti_op_construct_verify is an out-of-line function call for now, but we
can fix that once StructureID holds type information like isObject.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Codegen for the new opcode.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: Codegen for the new opcode. Also... (JSC::CodeGenerator::emitCall): ... don't test for known non-zero value. (JSC::CodeGenerator::emitConstruct): ... ditto.
- VM/Machine.cpp: No more CalledAsConstructor (JSC::Machine::privateExecute): Implementation for the new opcode. (JSC::Machine::cti_op_ret): The speedup: no need to check whether we were called as a constructor. (JSC::Machine::cti_op_construct_verify): Implementation for the new opcode.
- VM/Machine.h:
- VM/Opcode.h: Declare new opcode.
- VM/RegisterFile.h: (JSC::RegisterFile::): No more CalledAsConstructor
- 16:33 Changeset [36462] by
-
2008-09-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Inline code generation of eq_null/neq_null for CTI. Uses vptr checking for
StringObjectsThatAreMasqueradingAsBeingUndefined. In the long run, the
masquerading may be handled differently (through the StructureIDs - see bug
#20823).
1% on v8-tests.
- VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfIsJSCell): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CTI.h:
- VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_op_eq_null): (JSC::Machine::cti_op_neq_null):
- VM/Machine.h: (JSC::Machine::doesMasqueradesAsUndefined):
- kjs/JSWrapperObject.h: (JSC::JSWrapperObject::): (JSC::JSWrapperObject::JSWrapperObject):
- kjs/StringObject.h: (JSC::StringObject::StringObject):
- kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
- 16:08 Changeset [36461] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
"Just do it"'d by Mark Rowe
https://bugs.webkit.org/show_bug.cgi?id=20856
Add missing license header
- dom/NodeRenderStyle.h:
- 15:17 Changeset [36460] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Rubber-stamped by Oliver Hunt.
r36427 broke CodeBlock::dump() by changing the number of arguments to
op_construct without changing the code that prints it. This patch fixes
it by printing the additional argument.
- JavaScriptCore.xcodeproj/project.pbxproj:
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- 14:52 Changeset [36459] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Add default constructor for ShadowData
https://bugs.webkit.org/show_bug.cgi?id=20757
Test: transitions/shadow.html
- rendering/style/RenderStyle.h:
- 14:40 Changeset [36458] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
RenderStyle should update keyframes.
http://bugs.webkit.org/show_bug.cgi?id=20756
- rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::updateKeyframes):
- 14:31 Changeset [36457] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Unnecessary ASSERT in ImplicitAnimation destructor.
https://bugs.webkit.org/show_bug.cgi?id=20817
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation):
- 14:27 Changeset [36456] by
-
WebKit:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Merge WebNetscapePluginStream into WebBaseNetscapePluginStream.
- Plugins/WebBaseNetscapePluginStream.h:
- Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream start]): (-[WebBaseNetscapePluginStream stop]): (-[WebBaseNetscapePluginStream cancelLoadWithError:]):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- Plugins/WebNetscapePluginEmbeddedView.mm:
- Plugins/WebNetscapePluginStream.h: Removed.
- Plugins/WebNetscapePluginStream.mm: Removed.
- 14:22 Changeset [36455] by
-
Oops. Forgot this file in previous commit.
- 14:21 Changeset [36454] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher.
Tests for -webkit-transform
https://bugs.webkit.org/show_bug.cgi?id=20771
- transforms/2d/compound-2d-transforms-expected.txt: Added.
- transforms/2d/compound-2d-transforms.html: Added.
- transforms/2d/compound-transforms-vs-containers.html: Added.
- transforms/2d/transform-2d-expected.txt: Added.
- transforms/2d/transform-2d.html: Added.
- transforms/2d/transform-accuracy-expected.txt: Added.
- transforms/2d/transform-accuracy.html: Added.
- transforms/2d/transform-borderbox.html: Added.
- transforms/2d/transform-origin-borderbox.html: Added.
- transforms/2d/resources/transform-test-utils.js: Added.
- platform/mac/transforms/2d/compound-transforms-vs-containers-expected.txt: Added.
- platform/mac/transforms/2d/transform-borderbox-expected.txt: Added.
- platform/mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
- 14:06 Changeset [36453] by
-
Fix Win build bustage.
- 14:02 Changeset [36452] by
-
Reviewed by Simon.
Yahoo assumes non-RFC compliant HTTP redirect behaviour. QtWebKit is (more)
compliant, so broken. I think the Yahoo-assumed behaviour is real-world standard.
Basically, Yahoo's login procedure for flickr looks like this:
- load flickr.com, click "sign in"
- this is a Yahoo page with a form
(https://login.yahoo.com/config/login?.src=flickr...)
when you click the "Sign In" button, the form submits to a yahoo.com POST URL
- The POST returns with a 302 (redirect) to another yahoo.com URL
- If you POST the redirected Location:, it all breaks. Yahoo assumes you will
convert the method to GET, which works fine but is definitely not
RFC-compliant. It would be compliant for 303, and the RFC says that many
implementations treat 302 and 303 the same way (for HTTP/1.0 compliance), but
converting to GET is explicitly wrong for 302.
- 13:59 Changeset [36451] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Tests for animations.
https://bugs.webkit.org/show_bug.cgi?id=20789
- animations/animation-test-helpers.js: Added.
- animations/generic-from-to-expected.txt: Added.
- animations/generic-from-to.html: Added.
- animations/multiple-animations-expected.txt: Added.
- animations/multiple-animations.html: Added.
- animations/multiple-keyframes-expected.txt: Added.
- animations/multiple-keyframes.html: Added.
- 13:53 Changeset [36450] by
-
Reviewed by Simon.
Fix plugin extension info. It was returning the mimetype where the
extension was given.
- 13:40 Changeset [36449] by
-
2008-09-15 Dean Jackson <dino@apple.com>
Reviewed by Tim Hatcher
Coding style violation!!!! Cleanup AnimationBase.cpp
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- 13:03 Changeset [36448] by
-
2008-09-15 David Hyatt <hyatt@apple.com>
Move all hit testing code for scrollbars into the base class. Refactor
it to accommodate all platform-specific behaviors using virtual ScrollbarTheme
functions.
No platform is using this code yet. Although it has been moved and compiles
(even on Mac), it is not being used on any platform.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent): (WebCore::Scrollbar::handleMouseReleaseEvent): (WebCore::Scrollbar::handleMousePressEvent):
- platform/ScrollBar.h: (WebCore::Scrollbar::handleContextMenuEvent):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::hitTest): (WebCore::ScrollbarTheme::invalidateOnMouseEnterExit): (WebCore::ScrollbarTheme::invalidatePart): (WebCore::ScrollbarTheme::shouldCenterOnThumb): (WebCore::ScrollbarTheme::centerOnThumb): (WebCore::ScrollbarTheme::thumbPosition): (WebCore::ScrollbarTheme::thumbLength): (WebCore::ScrollbarTheme::trackLength): (WebCore::ScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::ScrollbarTheme::autoscrollTimerDelay):
- platform/Widget.h: (WebCore::Widget::parent):
- platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
- platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow):
- platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::invalidateOnMouseEnterExit):
- platform/win/ScrollbarThemeWin.h:
- 11:48 Changeset [36447] by
-
Reviewed by Sam Weinig.
- fix <rdar://problem/5842247> Single long breakable word takes O(n2) to lay out
Cache the next breakable position for text nodes in InlineIterator.
- rendering/bidi.cpp: (WebCore::InlineIterator::InlineIterator): (WebCore::InlineIterator::increment): (WebCore::RenderBlock::findNextLineBreak):
- 10:10 Changeset [36446] by
-
2008-09-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Fix assertion and integral pixel issue when creating subimages.
https://bugs.webkit.org/show_bug.cgi?id=20786
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 08:16 Changeset [36445] by
-
Build fix
- kjs/StructureID.cpp: Removed a stray semicolon.
- 05:43 Changeset [36444] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Implment seek() and clean up and improve debugging output
- 04:40 Changeset [36443] by
-
2008-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon.
Remove bogus Q_ASSERTs from the MediaPlayer Phonon implementation
m_mediaObject, m_audioOutput, m_videoWidget get created in the
c'tor and will only be deleted in the c'tor. The Q_ASSERTs would
only check if we use the MediaPlayerPrivate after it has been deleted.
Acked-by: Tor Arne Vestbø <tavestbo@trolltech.com>
- 04:35 Changeset [36442] by
-
WebCore:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Check the width and height and throw an exception if any of them are 0.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
LayoutTests:
2008-09-15 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej.
<rdar://problem/6163988>
https://bugs.webkit.org/show_bug.cgi?id=20457
Canvas: createPattern crashes WebKit in WTF::RefPtr<WebCore::Image>::operator!() const + 9 with a 1D pattern
Add test for createPattern where the canvas passed in has a zero height/width.
- fast/canvas/canvas-with-incorrect-args-expected.txt:
- fast/canvas/canvas-with-incorrect-args.html:
- 04:28 Changeset [36441] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Render media element controls with antialiasing enabled
- 04:27 Changeset [36440] by
-
2008-09-15 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Upon non fatal error, switch to the pause state (so that playback can continue)
- 04:22 Changeset [36439] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Don't set WTF_USE_JSC in WebCore.pro now that it's set in config.h
- 04:16 Changeset [36438] by
-
2008-09-15 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon.
Make QtInstance::create() private and fix caching
- 03:43 Changeset [36437] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Fix a crash in fast/js/exception-expression-offset.html caused by not
updating all mentions of the length of op_construct in r36427.
- VM/Machine.cpp: (JSC::Machine::cti_op_construct_NotJSConstruct):
- 03:20 Changeset [36436] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix layout test failure introduced by fix for 20849
(The failing test was fast/js/delete-then-put.html)
- kjs/JSObject.cpp: (JSC::JSObject::removeDirect): Clear enumeration cache in the dictionary case.
- kjs/JSObject.h: (JSC::JSObject::putDirect): Ditto.
- kjs/StructureID.h: (JSC::StructureID::clearEnumerationCache): Inline to handle the clear.
- 03:02 Changeset [36435] by
-
2008-09-15 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- fix JSC test failures introduced by fix for 20849
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames): Use the correct count.
- 02:39 Changeset [36434] by
-
2008-09-15 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20851: REGRESSION (r36410): fast/js/kde/GlobalObject.html fails
<https://bugs.webkit.org/show_bug.cgi?id=20851>
r36410 introduced an optimization for parseInt() that is incorrect when
its argument is larger than the range of a 32-bit integer. If the
argument is a number that is not an immediate integer, then the correct
behaviour is to return the floor of its value, unless it is an infinite
value, in which case the correct behaviour is to return 0.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 02:13 Changeset [36433] by
-
Fix Qt build bustage.
- 01:45 Changeset [36432] by
-
2008-09-15 David Smith <catfish.man@gmail.com>
Reviewed by Dave Hyatt.
2x speedup on querySelector[All] with :nth-child by removing the collectRulesOnly argument on SelectorChecker.
With collectRulesOnly set to true (the default) an optimization is turned off, and no callers were intentionally leaving it true.
querySelector[All] assumed that the default was probably the right way to go, and so ended up being slow.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
- css/CSSStyleSelector.h:
- 01:34 Changeset [36431] by
-
Make sure ScrollbarThemeQt.cpp accurately reflects copyright information, since it contains code from PlatformScrollbarQt.cpp
- 01:31 Changeset [36430] by
-
Fix Qt build bustage.
- 00:27 Changeset [36429] by
-
2008-09-15 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20849
Cache property names for getEnumerablePropertyNames in the StructureID.
~0.5% speedup on Sunspider overall (9.7% speedup on string-fasta). ~1% speedup
on the v8 test suite.
- kjs/JSObject.cpp: (JSC::JSObject::getPropertyNames):
- kjs/PropertyMap.cpp: (JSC::PropertyMap::getEnumerablePropertyNames):
- kjs/PropertyMap.h:
- kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::getEnumerablePropertyNames):
- kjs/StructureID.h:
09/14/08:
- 23:33 Changeset [36428] by
-
Refactor painting of the native windows scrollbar and prepare for code sharing with the Aqua windows scrollbar.
- 23:26 Changeset [36427] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- speed up JS construction by extracting "prototype" lookup so PIC applies.
~0.5% speedup on SunSpider
Speeds up some of the V8 tests as well, most notably earley-boyer.
- VM/CTI.cpp: (JSC::CTI::compileOpCall): Account for extra arg for prototype. (JSC::CTI::privateCompileMainPass): Account for increased size of op_construct.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitConstruct): Emit separate lookup to get prototype property.
- VM/Machine.cpp: (JSC::Machine::privateExecute): Expect prototype arg in op_construct. (JSC::Machine::cti_op_construct_JSConstruct): ditto (JSC::Machine::cti_op_construct_NotJSConstruct): ditto
- 22:38 Changeset [36426] by
-
Moving all resource graphs under the same container for future scalable feature.
This is a speedup on resize but maybe a loss on changing the sorting function.
Reviewed by Timothy Hatcher.
- page/inspector/ResourcesPanel.js: Added a container for all resource graphs. Added WebInspector.ResourceGraph. No more _updateGraphBars on resize.
- page/inspector/inspector.css: Edited corresponding rules and removed unnecessaries.
- 22:05 Changeset [36425] by
-
Reviewed by Eric Seidel.
Add a protected destructor for RefCounted.
It is wrong to call its destructor directly, because (1) this should be taken care of by
deref(), and (2) many classes that use RefCounted have non-virtual destructors.
No change in behavior.
- wtf/RefCounted.h: (WTF::RefCounted::~RefCounted):
- 22:00 Changeset [36424] by
-
Fix Qt bustage.
- 21:52 Changeset [36423] by
-
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=20738
compareBoundaryPoints gives incorrect results
Test: fast/dom/Range/compareBoundaryPoints-2.html
- dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Correct meanings of START_TO_END and END_TO_START.
- page/DOMSelection.cpp: (WebCore::DOMSelection::addRange): Updated for this change.
- 20:10 Changeset [36422] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Trying again.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- 19:55 Changeset [36421] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Unreviewed build fix.
Blind attempt to fix build. Correct parameters for hasInstance.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::hasInstance):
- bindings/js/JSQuarantinedObjectWrapper.h:
- 19:23 Changeset [36420] by
-
WebCore:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getLastResortFallbackFont):
LayoutTests:
Rubber-stamped by Sam Weinig.
- revert <http://trac.webkit.org/changeset/36382> because it exposed <https://bugs.webkit.org/show_bug.cgi?id=20846> and resulted in crashes on Tiger.
- platform/mac/fast/text/last-resort-font-expected.checksum: Removed.
- platform/mac/fast/text/last-resort-font-expected.png: Removed.
- platform/mac/fast/text/last-resort-font-expected.txt: Removed.
- platform/mac/fast/text/last-resort-font.html: Removed.
- 19:21 Changeset [36419] by
-
Now with all new and improved Changelog in the correct order.
- 19:18 Changeset [36418] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 19:13 Changeset [36417] by
-
2008-09-14 Maciej Stachowiak <mjs@apple.com>
Reviewed by Cameron Zwarich.
- split the "prototype" lookup for hasInstance into opcode stream so it can be cached
~5% speedup on v8 earley-boyer test
- API/JSCallbackObject.h: Add a parameter for the pre-looked-up prototype.
- API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): Ditto.
- API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor): Look up and pass in prototype.
- JavaScriptCore.exp:
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Pass along prototype.
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Print third arg.
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitInstanceOf): Implement this, now that there is a third argument.
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::Machine::privateExecute): Pass along the prototype. (JSC::Machine::cti_op_instanceof): ditto
- kjs/JSObject.cpp: (JSC::JSObject::hasInstance): Expect to get a pre-looked-up prototype.
- kjs/JSObject.h:
- kjs/nodes.cpp: (JSC::InstanceOfNode::emitCode): Emit a get_by_id of the prototype property and pass that register to instanceof.
- kjs/nodes.h:
- 17:56 Changeset [36416] by
-
Add ScrollbarThemeComposite for use by ScrollbarThemeSafari and ScrollbarThemeWin
- 17:53 Changeset [36415] by
-
Fix Qt build bustage.
- 17:36 Changeset [36414] by
-
Fix Win build bustage.
- 17:35 Changeset [36413] by
-
2008-09-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove unnecessary virtual function call from cti_op_call_JSFunction -
~5% on richards, ~2.5% on v8-tests, ~0.5% on sunspider.
- VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction):
- 17:26 Changeset [36412] by
-
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej Stachowiak.
Bug 20827: the 'typeof' operator is slow
<https://bugs.webkit.org/show_bug.cgi?id=20827>
Optimize the 'typeof' operator when its result is compared to a constant
string.
This is a 5.5% speedup on the V8 Earley-Boyer test.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function):
- VM/Machine.h:
- VM/Opcode.h:
- kjs/nodes.cpp: (JSC::BinaryOpNode::emitCode): (JSC::EqualNode::emitCode): (JSC::StrictEqualNode::emitCode):
- kjs/nodes.h:
LayoutTests:
- fast/js/resources/typeof-codegen-crash.js: Added.
- fast/js/typeof-codegen-crash-expected.txt: Added.
- fast/js/typeof-codegen-crash.html: Added.
- 17:20 Changeset [36411] by
-
2008-09-14 Alp Toker <alp@nuanti.com>
https://bugs.webkit.org/show_bug.cgi?id=20320
[GTK] A white rectangle is visible behind widgets with rounded corners
Sync bundled gtk2drawing.c to the latest version from Mozilla (coding
style exempt).
Requested by Michael Monreal.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk):
- platform/gtk/gtk2drawing.c: (moz_gtk_set_widget_name): (ensure_window_widget): (setup_widget_prototype): (ensure_button_arrow_widget): (moz_gtk_get_combo_box_inner_button): (moz_gtk_get_combo_box_button_inner_widgets): (ensure_combo_box_widgets): (moz_gtk_get_combo_box_entry_inner_widgets): (moz_gtk_get_combo_box_entry_arrow): (ensure_combo_box_entry_widgets): (ensure_toolbar_widget): (ensure_tooltip_widget): (ensure_menu_bar_widget): (ensure_menu_bar_item_widget): (ensure_menu_popup_widget): (ensure_menu_item_widget): (ensure_image_menu_item_widget): (ensure_menu_separator_widget): (ensure_check_menu_item_widget): (ensure_tree_header_cell_widget): (ensure_scrolled_window_widget): (moz_gtk_button_paint): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (calculate_button_inner_rect): (calculate_arrow_rect): (moz_gtk_scrollbar_button_paint): (moz_gtk_scrollbar_thumb_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_treeview_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_downarrow_paint): (moz_gtk_combo_box_entry_button_paint): (moz_gtk_toolbar_paint): (moz_gtk_tab_scroll_arrow_paint): (moz_gtk_menu_bar_paint): (moz_gtk_menu_item_paint): (moz_gtk_get_widget_border): (moz_gtk_get_combo_box_entry_button_size): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_downarrow_size): (moz_gtk_images_in_menus): (moz_gtk_widget_paint): (moz_gtk_shutdown):
- platform/gtk/gtkdrawing.h:
- 17:12 Changeset [36410] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Patch for https://bugs.webkit.org/show_bug.cgi?id=20844
Speed up parseInt for numbers
Sunspider reports this as 1.029x as fast overall and 1.37x as fast on string-unpack-code.
No change on the v8 suite.
- kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Don't convert numbers to strings just to convert them back to numbers.
- 16:55 Changeset [36409] by
-
2008-09-14 David Hyatt <hyatt@apple.com>
Convert Mac, Gtk, wx and Qt over to the new ScrollbarTheme for
painting. Mac and Gtk themes don't do anything and just let the
underlying widget paint. Qt now uses the theme to paint. wx doesn't
do anything yet.
Reviewed by Sam Weinig
- platform/ScrollBar.cpp: (WebCore::Scrollbar::paint):
- platform/ScrollBar.h: (WebCore::Scrollbar::value): (WebCore::Scrollbar::visibleSize): (WebCore::Scrollbar::maximum): (WebCore::Scrollbar::lineStep): (WebCore::Scrollbar::pageStep): (WebCore::Scrollbar::pixelStep): (WebCore::Scrollbar::pressedPart): (WebCore::Scrollbar::hoveredPart): (WebCore::Scrollbar::theme):
- platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::paint): (WebCore::ScrollbarTheme::scrollbarThickness): (WebCore::ScrollbarTheme::supportsControlTints): (WebCore::ScrollbarTheme::themeChanged):
- platform/gtk/PlatformScrollBar.h:
- platform/gtk/PlatformScrollBarGtk.cpp:
- platform/mac/PlatformScrollBar.h:
- platform/mac/PlatformScrollBarMac.mm:
- platform/qt/PlatformScrollBar.h:
- platform/qt/PlatformScrollBarQt.cpp:
- platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
- platform/qt/ScrollbarThemeQt.h: (WebCore::ScrollbarThemeQt::paint):
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
- platform/win/ScrollbarThemeSafari.h: (WebCore::ScrollbarThemeSafari::supportsControlTints):
- platform/wx/PlatformScrollBar.h:
- platform/wx/TemporaryLinkStubs.cpp: (PlatformScrollbar::~PlatformScrollbar):
- 16:01 Changeset [36408] by
-
2008-09-14 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Bug 20816: op_lesseq should be optimized
<https://bugs.webkit.org/show_bug.cgi?id=20816>
Add a loop_if_lesseq opcode that is similar to the loop_if_less opcode.
This is a 9.4% speedup on the V8 Crypto benchmark.
- VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
- VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
- VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitJumpIfTrue):
- VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_lesseq):
- VM/Machine.h:
- VM/Opcode.h:
- 15:15 Changeset [36407] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp:
- 15:12 Changeset [36406] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- kjs/nodes.cpp: (JSC::PrefixResolveNode::emitCode):
- wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::GrowHeap):
WebCore:
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove extraneous semicolons.
- bindings/scripts/CodeGeneratorObjC.pm:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::charsetAttributeValue): (WebCore::HTMLScriptElement::typeAttributeValue):
- platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar):
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::toPathData):
- 15:00 Changeset [36405] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
- 14:36 Changeset [36404] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Qt build fix.
- platform/qt/PlatformScrollBarQt.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::paint):
- 02:33 Changeset [36403] by
-
Build fix.
- 01:33 Changeset [36402] by
-
2008-09-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Cleanup Sampling code.
- VM/CTI.cpp: (JSC::CTI::emitCall): (JSC::CTI::privateCompileMainPass):
- VM/CTI.h: (JSC::CTI::execute):
- VM/SamplingTool.cpp: (JSC::): (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
- VM/SamplingTool.h: (JSC::SamplingTool::callingHostFunction):
- 01:18 Changeset [36401] by
-
Bug 20821: Cache property transitions to speed up object initialization
https://bugs.webkit.org/show_bug.cgi?id=20821
Reviewed by Cameron Zwarich.
Implement a transition cache to improve the performance of new properties
being added to objects. This is extremely beneficial in constructors and
shows up as a 34% improvement on access-binary-trees in SunSpider (0.8%
overall)
09/13/08:
- 23:23 ProposedWebInspectorRearchitecting edited by
- (diff)
- 23:21 ProposedWebInspectorRearchitecting edited by
- Further define the message types and callback functions. (diff)
- 22:53 ProposedWebInspectorRearchitecting edited by
- Defines some messages for Console. (diff)
- 22:29 Changeset [36400] by
-
Fix Qt bustage.
- 22:05 Changeset [36399] by
-
Fix Windows bustage.
- 21:53 Changeset [36398] by
-
Fix Mac build bustage.
- 21:25 ProposedWebInspectorRearchitecting edited by
- Define some of the Console API. (diff)
- 18:57 Changeset [36397] by
-
2008-09-13 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix, not reviewed.
- platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar):
- platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
- 18:26 Changeset [36396] by
-
Eliminate Scrollbar's setRect method. Clients can now just use the Widget base class method, setFrameGeometry instead.
- 18:06 Changeset [36395] by
-
Remove setEnabled from all Scrollbar subclasses that were just using their Widget base class methods.
- 17:58 Changeset [36394] by
-
Remove width()/height() from Scrollbar and subclasses that just need to use the Widget method.
- 17:50 Changeset [36393] by
-
Remove now unused methods from GTK scrollbars.
- 17:49 Changeset [36392] by
-
Remove now unused methods from GTK scrollbars.
- 17:32 Changeset [36391] by
-
Move stopTimerIfNeeded out of PlatformScrollbar destructors and into Scrollbar's destructor.
- 17:22 Changeset [36390] by
-
Fix Qt build bustage.
- 16:57 Changeset [36389] by
-
2008-09-13 David Hyatt <hyatt@apple.com>
Move maximum() from Qt's PlatformScrollbar to be a cross-platform
function on Scrollbar. Fixes Qt build bustage.
Reviewed by Sam Weinig
- platform/ScrollBar.h: (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::value): (WebCore::Scrollbar::maximum):
- platform/qt/PlatformScrollBar.h:
- 16:47 Changeset [36388] by
-
Fix Qt bustage.
- 16:34 Changeset [36387] by
-
Fix wx bustage.
- 16:32 Changeset [36386] by
-
Fix Qt bustage.
- 16:21 Changeset [36385] by
-
Fix Qt, Gtk, and Mac build bustage.
- 16:10 Changeset [36384] by
-
Fix Qt bustage.
- 16:08 Changeset [36383] by
-
Fix Mac bustage.
- 16:06 Changeset [36382] by
-
WebCore:
Reviewed by Sam Weinig.
- use the LastResort font for missing glyphs instead of showing the primary font's missing glyph
Test: platform/mac/fast/text/last-resort-font.html
- platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to return the last resort font if a substitute font cannot be found. (WebCore::FontCache::getLastResortFallbackFont): Removed an outdated comment (the user's preferred standard font is included in the search thanks to code in FontCache::getFontData()) and changed to return the LastResort font.
LayoutTests:
Reviewed by Sam Weinig.
- test that the LastResort font is used for missing glyphs rather than the primary font's missing glyph
- platform/mac/fast/text/last-resort-font-expected.checksum: Added.
- platform/mac/fast/text/last-resort-font-expected.png: Added.
- platform/mac/fast/text/last-resort-font-expected.txt: Added.
- platform/mac/fast/text/last-resort-font.html: Added.
- 15:59 Changeset [36381] by
-
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 15:59 Changeset [36380] by
-
Add ScrollbarTheme to control scrollbar metrics (and eventually hit testing and rendering.
- 14:30 Changeset [36379] by
-
2008-09-13 Adrien Nader <camaradetux@gmail.com>
Gtk build fix, not reviewed.
- webkit/webkitwebview.cpp:
- 14:05 Changeset [36378] by
-
<rdar://problem/5060439> Web elements should have an AXTopLevelUIElement
expose AXTopLevelUIElement as an attribute
- 13:51 Changeset [36377] by
-
Fix Qt build bustage.
- 13:37 Changeset [36376] by
-
Fix wx build bustage.
- 13:33 Changeset [36375] by
-
Fix Qt build bustage.
- 13:27 Changeset [36374] by
-
Reviewed by Timothy Hatcher.
- fix <rdar://problem/6171280> REGRESSION (r35667): Assertion failure in WebCore::FrameView::scheduleRelayout() when releasing a page with counters from the b/f cache
No regression test because the back/forward cache is disabled in DumpRenderTree
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::invalidateCounters): Bail out if the document is being destroyed.
- 12:14 Changeset [36373] by
-
Fix Mac build bustage.
- 11:52 Changeset [36372] by
-
Fix Qt build bustage.
- 11:48 Changeset [36371] by
-
wx build fixes for new methods recently introduced.
- 11:41 Changeset [36370] by
-
more scrollbar refactoring.
- 11:39 Changeset [36369] by
-
More scrollbar refactoring.
