Timeline


and

09/24/08:

20:32 Changeset [36884] by mrowe@apple.com
  • 9 edits in branches/Safari-3-2-branch

Merge r35897.

20:32 Changeset [36883] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch/WebKit/win

Merge r35896.

19:46 Changeset [36882] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Move most of the return code back into the callee, now that the callee
doesn't have to calculate anything dynamically.


11.5% speedup on empty function call benchmark.


SunSpider says 0.3% faster. SunSpider --v8 says no change.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
18:10 Changeset [36881] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit/win

2008-09-24 Matt Lilek <webkit@mattlilek.com>

Reviewed by Darin Adler.

Bug 20999: Inspector hover to select does not work properly on Windows
https://bugs.webkit.org/show_bug.cgi?id=20999
<rdar://problem/6236524>

  • WebNodeHighlight.cpp: (WebNodeHighlight::show):
18:08 Changeset [36880] by darin@apple.com
  • 5 edits in trunk/WebKit/mac

2008-09-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Use the new +[WebView _canHandleRequest:forMainFrame:] so we can give a different answer for the main frame and subframes.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest): Ditto.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:forMainFrame:]): Added forMainFrame. Only look for scheme-specific representations for the main frame, not subframes. (+[WebView _canHandleRequest:]): Give answer for main frame -- calls the method above with YES for main frame.
  • WebView/WebViewInternal.h: Added _canHandleRequest:forMainFrame:.
17:53 Changeset [36879] by darin@apple.com
  • 4 edits in trunk/WebKit

..:

2008-09-24 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes.

../win:

2008-09-24 Darin Adler <darin@apple.com>

  • English.lproj/Localizable.strings: Updated for recent changes.
17:50 Changeset [36878] by mitz@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Sam Weinig.

  • create a "style" subfolder under "rendering" and move style files to that folder
  • WebCore.vcproj/WebCore.vcproj:
17:39 Changeset [36877] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Remove staticFunctionGetter. There is only one remaining user of
staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.

WebCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Remove staticFunctionGetter. There is only one remaining user of
staticFunctionGetter and it can be converted to use setUpStaticFunctionSlot.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot):
17:26 Changeset [36876] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • inline JIT fast case of op_neq
  • remove extra level of function call indirection from slow cases of eq and neq


1% speedup on Richards

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_neq):
  • kjs/operations.cpp: (JSC::equal): (JSC::equalSlowCase):
  • kjs/operations.h: (JSC::equalSlowCaseInline):
17:07 Changeset [36875] by weinig@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

Test: plugins/bindings-array-apply-crash.html

  • kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): Revert to the slow case if the object inherits from JSArray (via ClassInfo) but is not a JSArray.

WebKitTools:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

Add method to ObjCController to return a runtime array.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController testArray]):

LayoutTests:

2008-09-24 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=21080
<rdar://problem/6243534>
Crash below Function.apply when using a runtime array as the argument list

  • platform/mac/plugins/bindings-array-apply-crash-expected.txt: Added.
  • platform/mac/plugins/bindings-array-apply-crash.html: Added.
16:40 Changeset [36874] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-09-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.

Test: editing/spelling/inline_spelling_markers.html


Measure spelling markers with selectionRectForText() to fix RTL.

This patch also fixes hit-testing for spelling marker tool tips,
which used to work only on the first line.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):

LayoutTests:

2008-09-24 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dan Bernstein.


  • editing/spelling/inline_spelling_markers.html: Added.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Added.
15:26 Changeset [36873] by darin@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Removed a stray line from a recent ChangeLog entry.

15:24 Changeset [36872] by kmccullough@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Style change.

  • kjs/nodes.cpp: (JSC::statementListEmitCode):
15:19 Changeset [36871] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Reviewed by Geoff.

Bug 21031: Breakpoints in the condition of loops only breaks the first
time

  • Now when setting breakpoints in the condition of a loop (for, while, for in, and do while) will successfully break each time throught the loop.
  • For 'for' loops we need a little more complicated behavior that cannot be accomplished without some more significant changes: https://bugs.webkit.org/show_bug.cgi?id=21073
  • kjs/nodes.cpp: (JSC::statementListEmitCode): We don't want to blindly emit a debug hook at the first line of loops, instead let the loop emit the debug hooks. (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode):
  • kjs/nodes.h: (JSC::StatementNode::): (JSC::DoWhileNode::): (JSC::WhileNode::): (JSC::ForInNode::):
14:48 Changeset [36870] by bdakin@apple.com
  • 2 edits in trunk/WebKitTools

2008-09-24 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

Speculative build fix.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::supportsPressAction):
14:45 Changeset [36869] by hyatt@apple.com
  • 7 edits
    2 deletes in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21074

Make sure the viewless scrollbar knows how to paint properly when transformed.

Reviewed by Sam Weinig

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::paint):
14:28 Changeset [36868] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

Make sure the viewless scrollbar knows how to paint properly when transformed.

Reviewed by Sam Weinig

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::paint):
14:18 Changeset [36867] by timothy@apple.com
  • 1 edit
    3 adds in trunk/WebKitSite

Add new screenshots of the Web Inspector's Scope Variables pane.

Not reviewed.

  • blog-files/inspector-closure-scope.png: Added.
  • blog-files/inspector-event-scope.png: Added.
  • blog-files/inspector-with-scope.png: Added.
14:17 Changeset [36866] by zimmermann@webkit.org
  • 3 edits in trunk/WebCore

Not reviewed. Try to fix win build.
Add missing ChangeLog entry from last commit.

14:13 Changeset [36865] by darin@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray characters Maciej pointed out in log.

14:08 Changeset [36864] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2008-09-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

Wrap up dirtying the z-order list of the stacking context
RenderLayer into a method.
https://bugs.webkit.org/show_bug.cgi?id=21072

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::dirtyStackingContextZOrderLists): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
13:38 Changeset [36863] by ggaren@apple.com
  • 5 edits
    1 add in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/5605532> Need a SPI for telling JS the size of
the objects it retains

  • API/JSBase.h: Filled in some missing function names.
  • API/tests/testapi.c: Test the new SPI a little.
  • API/JSSPI.cpp: Add the new SPI.
  • API/JSSPI.h: Add the new SPI.
  • JavaScriptCore.exp: Add the new SPI.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the new SPI.
13:37 Changeset [36862] by timothy@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

Add another screenshot of the Web Inspector.

Not reviewed.

  • blog-files/inspector-disabling-properties.png: Added.
13:22 Changeset [36861] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-09-24 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim.

Bug 21070: REGRESSION Repeated messages with arguments are not repeated
or displayed multiple times

  • The Insepctor Controller was comparing JSValue pointers so thought the message was not a repeat, but the JS of the inspector compared the strings and so knew it was the same message and so overwrote the old message.
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::isEqual): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
  • page/InspectorController.h:
13:19 Changeset [36860] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-09-24 David Hyatt <hyatt@apple.com>

Make sure the viewless Mac scrollbar responds properly to system preference changes (including the
arrow placement preference and the thumb jump preference).

Reviewed by Adam Roben

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::~Scrollbar):
  • platform/ScrollbarTheme.h: (WebCore::ScrollbarTheme::registerScrollbar): (WebCore::ScrollbarTheme::unregisterScrollbar):
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): (+[ScrollbarPrefsObserver registerAsObserver]): (WebCore::ScrollbarThemeMac::registerScrollbar): (WebCore::ScrollbarThemeMac::unregisterScrollbar): (WebCore::ScrollbarThemeMac::ScrollbarThemeMac): (WebCore::ScrollbarThemeMac::preferencesChanged):
13:13 Changeset [36859] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

  • API/JSBase.h: Filled in some missing function names.
13:06 Changeset [36858] by zimmermann@webkit.org
  • 2 edits
    1 add in trunk/WebCore/dom

Reviewed by Oliver.

Add ContainerNodeAlgorithms.h, as central place to share algorithms
operating on TreeShared-derived classes with a Node-style interface.

This allows SVGElementInstance & ContainerNode to share code.

12:50 Changeset [36857] by timothy@apple.com
  • 1 edit
    10 adds in trunk/WebKitSite

Add new screenshots of the Web Inspector.

Not reviewed.

  • blog-files/inspector-console-autocomplete.png: Added.
  • blog-files/inspector-databases-panel-query-view.png: Added.
  • blog-files/inspector-databases-panel.png: Added.
  • blog-files/inspector-elements-panel.png: Added.
  • blog-files/inspector-numeric-style-stepping.gif: Added.
  • blog-files/inspector-profiles-panel.png: Added.
  • blog-files/inspector-resources-panel.png: Added.
  • blog-files/inspector-scripts-panel.png: Added.
  • blog-files/inspector-status-bar-with-errors.png: Added.
  • blog-files/inspector-toolbar.png: Added.
12:23 Changeset [36856] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=20557
getScreenCTM() returns wrong values

Use the absolute position of the svg root when
determining the screen ctm.

Test: svg/custom/getscreenctm-in-mixed-content2.xhtml

11:26 Changeset [36855] by hyatt@apple.com
  • 52 edits in trunk

2008-09-24 David Hyatt <hyatt@apple.com>

Turn off support for CSS variables.

  • ChangeLog:
  • css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::addVariable): (WebCore::CSSParser::addVariableDeclarationBlock):
11:15 Changeset [36854] by hyatt@apple.com
  • 5 edits
    1 delete in trunk

2008-09-24 David Hyatt <hyatt@apple.com>

Back out the alternate forms of CSS variable call syntax (leaving only the -webkit-var version).

  • css/CSSGrammar.y:
  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::isVariable):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isVariable):
10:54 Changeset [36853] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21057
Crash in RegisterID::deref() running fast/canvas/canvas-putImageData.html

  • VM/CodeGenerator.h: Changed declaration order to ensure the m_lastConstant, which is a RefPtr that points into m_calleeRegisters, has its destructor called before the destructor for m_calleeRegisters.
10:40 Changeset [36852] by timothy@apple.com
  • 2 edits in trunk/WebKitSite
  • demos/drosera/demo.js: Add some console.profile() calls.
10:02 Changeset [36851] by darin@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-09-24 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

About 1% on v8-raytrace.

  • kjs/JSActivation.cpp: Moved copyRegisters to the header to make it inline.
  • kjs/JSActivation.h: (JSC::JSActivation::copyRegisters): Moved here. Also removed the registerArraySize argument to setRegisters, since the object doesn't need to store the number of registers.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): Removed unnecessary clearing left over from when we used this on objects that weren't brand new. These days, this function is really just part of the constructor.
  • kjs/JSGlobalObject.h: Added registerArraySize to JSGlobalObjectData, since JSVariableObjectData no longer needs it. Added a setRegisters override here that handles storing the size.
  • kjs/JSStaticScopeObject.h: Removed code to set registerArraySize, since it no longer exists.
  • kjs/JSVariableObject.cpp: Moved copyRegisterArray and setRegisters to the header to make them inline.
  • kjs/JSVariableObject.h: Removed registerArraySize from JSVariableObjectData, since it was only used for the global object. (JSC::JSVariableObject::copyRegisterArray): Moved here ot make it inline. (JSC::JSVariableObject::setRegisters): Moved here to make it inline. Also removed the code to set registerArraySize and changed an if statement into an assert to save an unnnecessary branch.
09:39 Changeset [36850] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Added bug URLs for r36001

09:23 Changeset [36849] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a regression where the "incorrect MIME-type" warning would not
show up correctly in the Console or the resources sidebar.

Reviewed by Kevin McCullough.

  • page/inspector/Resource.js: (WebInspector.Resource.prototype._addTip): Add the repeat count argument to the WebInspector.ConsoleMessage constructor call. (WebInspector.Resource.prototype._checkWarning): Ditto.
06:47 Changeset [36848] by vestbo@webkit.org
  • 5 edits in trunk

2008-09-23 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Remove deprecated JS Qt bindings object call/construct code and fix autotests

01:11 Changeset [36847] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • inline PropertyMap::getOffset to speed up polymorphic lookups


~1.5% speedup on v8 benchmark
no effect on SunSpider

  • JavaScriptCore.exp:
  • kjs/PropertyMap.cpp:
  • kjs/PropertyMap.h: (JSC::PropertyMap::getOffset):
00:43 Changeset [36846] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=20992
Build fails on GTK+ Mac OS

  • wtf/ThreadingGtk.cpp: Remove platform ifdef as suggested by Richard Hult. (WTF::initializeThreading):
00:42 Changeset [36845] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-09-23 Richard Hult <richard@imendio.com>

Reviewed by Alp Toker. Landed by Jan Alonzo.

http://bugs.webkit.org/show_bug.cgi?id=20582
[Gtk] Link error on Mac OS X

  • GNUmakefile.am: Only use the -version-script flag for the gnu linker.
  • configure.ac: Check for GNU OSes.
00:42 Changeset [36844] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-09-23 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Alp Toker. Landed by Jan Alonzo.

Bug 20883: [CURL] Add deferred loading
https://bugs.webkit.org/show_bug.cgi?id=20883

Implement deferred loading for the libcURL backend using curl_easy_pause.
As the method was introduced in version 7.18.0, all the code checks for libcURL
version.

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): Add an assertion that deferred loading is not activated. (WebCore::headerCallback): Ditto. (WebCore::readCallback): Ditto. (WebCore::ResourceHandleManager::dispatchSynchronousJob): Force defersLoading to be false in order to avoid triggering an assertion. (WebCore::ResourceHandleManager::initializeHandle): If deferred loading is activated, pause the easy handle.
00:32 Changeset [36843] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 19968: Slow Script at www.huffingtonpost.com
<https://bugs.webkit.org/show_bug.cgi?id=19968>

Reviewed by Maciej Stachowiak

Finally found the cause of this accursed issue. It is triggered
by synchronous creation of a new global object from JS. The new
global object resets the timer state in this execution group's
Machine, taking timerCheckCount to 0. Then when JS returns the
timerCheckCount is decremented making it non-zero. The next time
we execute JS we will start the timeout counter, however the non-zero
timeoutCheckCount means we don't reset the timer information. This
means that the timeout check is now checking the cumulative time
since the creation of the global object rather than the time since
JS was last entered. At this point the slow script dialog is guaranteed
to eventually be displayed incorrectly unless a page is loaded
asynchronously (which will reset everything into a sane state).

The fix for this is rather trivial -- the JSGlobalObject constructor
should not be resetting the machine timer state.

09/23/08:

23:44 Changeset [36842] by ggaren@apple.com
  • 4 edits
    2 adds in trunk

JavaScriptCore:

2008-09-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21038 | <rdar://problem/6240812>
Uncaught exceptions in regex replace callbacks crash webkit


This was a combination of two problems:


(1) the replace function would continue execution after an exception
had been thrown.


(2) In some cases, the Machine would return 0 in the case of an exception,
despite the fact that a few clients dereference the Machine's return
value without first checking for an exception.


  • VM/Machine.cpp: (JSC::Machine::execute):


Return jsNull() instead of 0 in the case of an exception, since some
clients depend on using our return value.


ASSERT that execution does not continue after an exception has been
thrown, to help catch problems like this in the future.

  • kjs/StringPrototype.cpp: (JSC::stringProtoFuncReplace):


Stop execution if an exception has been thrown.

LayoutTests:

2008-09-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Test for https://bugs.webkit.org/show_bug.cgi?id=21038
Uncaught exceptions in regex replace callbacks crash webkit

  • fast/js/string-replace-exception-crash-expected.txt: Added.
  • fast/js/string-replace-exception-crash.html: Added.
22:49 Changeset [36841] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-23 Geoffrey Garen <ggaren@apple.com>

Try to fix the windows build.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass):
20:36 Changeset [36840] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-23 Alp Toker <alp@nuanti.com>

Build fix.

  • VM/CTI.h:
20:24 Changeset [36839] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-09-23 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Inspector search field style tweaks.

  • page/inspector/inspector.css:
19:23 Changeset [36838] by zimmermann@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=21046 (Several LayoutTests crash)

Fix missing negation in EventTargetNode::insertedIntoDocument.
Made handleLocalEvents() virtual again, HTMLFormElement overrides it.
Remove code, that wasn't supposed to go in in dispatchGenericEvent().

19:08 Changeset [36837] by timothy@apple.com
  • 4 edits in trunk/WebCore

Adds search support to the Profiles panel.

The Profiles panel supports a few types of queries:

  • Standard string matching for function names and file URLs.
  • Greater than and less than search for numeric columns. So a query of ">24" will match all rows that have calls greater than 24. Or "<=42" will match all 42 or less.
  • Percent and time units. Adding a unit of "s", "ms" or "%" is supported and will match only the Self and Total columns. So a query of ">1.25s" will match all rows that took longer than 1.25 seconds.

Reviewed by Oliver Hunt.

  • page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time it will start at the first result. (WebInspector.ProfileView.prototype.refreshShowAsPercents): Moved from the bottom of the file. (WebInspector.ProfileView.prototype.searchCanceled): Clear the search properties and refresh highlighted data grid nodes. (WebInspector.ProfileView.prototype.performSearch): Search the profile nodes. (WebInspector.ProfileView.prototype.jumpToFirstSearchResult): Does what the function says. Calls _jumpToSearchResult. (WebInspector.ProfileView.prototype.jumpToLastSearchResult): Ditto. (WebInspector.ProfileView.prototype.jumpToNextSearchResult): Ditto. (WebInspector.ProfileView.prototype.jumpToPreviousSearchResult): Ditto. (WebInspector.ProfileView.prototype.showingFirstSearchResult): Does what the function says. (WebInspector.ProfileView.prototype.showingLastSearchResult): Ditto. (WebInspector.ProfileView.prototype._jumpToSearchResult): Select and reveal the profile node. Expand all the ancestors first so the profile node will have a DataGridNode. (WebInspector.ProfileView.prototype._changeView): Perform the search again on the new tree. (WebInspector.ProfileDataGridNode.prototype.createCell): Add the highlight class to cells that have search matches.
  • page/inspector/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.reset): Call searchCanceled and delete the currentQuery. (WebInspector.ProfilesPanel.prototype.showProfile): Use profileViewForProfile. (WebInspector.ProfilesPanel.prototype.showView): Call showProfile. Used by Panel to show a view. (WebInspector.ProfilesPanel.prototype.profileViewForProfile): Create the ProfileView if needed. (WebInspector.ProfilesPanel.prototype.closeVisibleView): Renamed visibleProfileView to visibleView. (WebInspector.ProfilesPanel.prototype.get searchableViews): Return all the views. (WebInspector.ProfilesPanel.prototype.searchMatchFound): Update the sidebar search matches. (WebInspector.ProfilesPanel.prototype.searchCanceled): Clear all the sidebar search matches. (WebInspector.ProfileSidebarTreeElement.prototype.set searchMatches): Set the class and bubbleText.
  • page/inspector/inspector.css: New style rules for the cell highlight color.
19:08 Changeset [36836] by timothy@apple.com
  • 8 edits
    4 adds in trunk/WebCore

Adds search support to the Resources and Scripts panels.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • page/inspector/Images/searchSmallBlue.png: Added.
  • page/inspector/Images/searchSmallBrightBlue.png: Added.
  • page/inspector/Images/searchSmallGray.png: Added.
  • page/inspector/Images/searchSmallWhite.png: Added.
  • page/inspector/ResourceView.js: (WebInspector.ResourceView.prototype.attach): Attempt to attach to "resource-views" or "script-resource-views" since one might not be created yet.
  • page/inspector/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): Hide any views that are visible that are not this panel's current visible view. This can happen when a ResourceView is visible in the Scripts panel then switched to the this panel. (WebInspector.ResourcesPanel.prototype.get searchableViews): Return all views, with the visibleView first. (WebInspector.ResourcesPanel.prototype.searchResultsSortFunction): Return a sort function that uses the current graph search function. So cycling through results will be in the order things appear in the sidebar. (WebInspector.ResourcesPanel.prototype.searchMatchFound): Update the search matches on the resource's sidebar tree element. (WebInspector.ResourcesPanel.prototype.searchCanceled): Restore the error and warning bubbles in the sidebar. Calls the Panel prototype's searchCanceled. (WebInspector.ResourcesPanel.prototype.performSearch): Hide all the error and warning bubbles in the sidebar. Calls the Panel prototype's performSearch. (WebInspector.ResourcesPanel.prototype.reset): Call searchCanceled and delete the currentQuery. (WebInspector.ResourcesPanel.prototype.addMessageToResource): Don't call updateErrorsAndWarnings if there is a current search query. (WebInspector.ResourcesPanel.prototype.clearMessages): Ditto. (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): Ditto. (WebInspector.ResourcesPanel.prototype.showView): Call showResource. Used by Panel to show a view. (WebInspector.ResourceSidebarTreeElement.prototype.resetBubble): Clear all the classes and content. (WebInspector.ResourceSidebarTreeElement.prototype.set searchMatches): Set the bubbleText and class. (WebInspector.ResourceSidebarTreeElement.prototype.updateErrorsAndWarnings): Call resetBubble.
  • page/inspector/ScriptView.js: (WebInspector.ScriptView): Set _sourceFrameSetup to flase. (WebInspector.ScriptView.prototype.hide): Reset _currentSearchResultIndex to -1. So the next time it will start at the first result. (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded): Add an event listener for "syntax highlighting complete". (WebInspector.ScriptView.prototype): Share many methods with SourceView.
  • page/inspector/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): Hide any views that are visible that are not this This can happen when a ResourceView is visible in the Resources panel then switched to the this panel. (WebInspector.ScriptsPanel.prototype.get searchableViews): Return all views, with the visibleView first. (WebInspector.ScriptsPanel.prototype.reset): Call searchCanceled and delete the currentQuery. (WebInspector.ScriptsPanel.prototype.showView): Call _showScriptOrResource. Used by Panel to show a view. (WebInspector.ScriptsPanel.prototype._sourceViewForScriptOrResource): Added helper.
  • page/inspector/SourceFrame.js: (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript): Dispatch a "syntax highlighting complete" event.
  • page/inspector/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.detach): (WebInspector.SourceView.prototype._resourceLoadingFinished): Moved from the bottom of the file. (WebInspector.SourceView.prototype._addBreakpoint): Ditto. (WebInspector.SourceView.prototype.searchCanceled): Delete search properties. (WebInspector.SourceView.prototype.performSearch): Search the frame if it is loaded, otherwise store the worker function as _delayedFindSearchMatches and call it later in _sourceFrameSetupFinished. (WebInspector.SourceView.prototype.jumpToFirstSearchResult): (WebInspector.SourceView.prototype.jumpToLastSearchResult): (WebInspector.SourceView.prototype.jumpToNextSearchResult): (WebInspector.SourceView.prototype.jumpToPreviousSearchResult): (WebInspector.SourceView.prototype.showingFirstSearchResult): (WebInspector.SourceView.prototype.showingLastSearchResult): (WebInspector.SourceView.prototype._jumpToSearchResult): Selects the found Range. (WebInspector.SourceView.prototype._sourceFrameSetupFinished): Calls _delayedFindSearchMatches. (WebInspector.SourceView.prototype._syntaxHighlightingComplete): Call _sourceFrameSetupFinished.
  • page/inspector/inspector.css:
19:08 Changeset [36835] by timothy@apple.com
  • 3 edits in trunk/WebCore

Rename some properties of ResourcesPanel and ScriptsPanel to be the same,
so future code can be shared.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • page/inspector/ResourcesPanel.js: Renamed resourceViews to viewsContainerElement. And visibleResourceView to visibleView.
  • page/inspector/ScriptsPanel.js: Renamed scriptResourceViews to viewsContainerElement.
19:08 Changeset [36834] by timothy@apple.com
  • 4 edits in trunk/WebCore

Highlight all matched search results in the Elements panel DOM tree.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): Clear the highlight on all previous search results. (WebInspector.ElementsPanel.prototype.performSearch): Set the hihglight on all new search results.
  • page/inspector/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): Delay setting the title until onattach. (WebInspector.ElementsTreeElement.prototype.get/set highlighted): Sets or removes the highlighted class on the listItemElement. (WebInspector.ElementsTreeElement.prototype.onattach): Set the highlighted class if needed. Calls _updateTitle. (WebInspector.ElementsTreeElement.prototype._updateTitle): Adds a span with the highlight class so it can be styled when the highlighted class is present.
  • page/inspector/inspector.css: New style rules for the hihglight.
19:08 Changeset [36833] by timothy@apple.com
  • 2 edits in trunk/WebCore

Add search support to the Elements panel.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.searchCanceled): Call updateSearchMatchesCount with a 0 match count to rest. Reset the other search properties. (WebInspector.ElementsPanel.prototype.performSearch): Evaluates the search as an XPath query and a CSS selector on all the Documents in the page. Remembers the found nodes and avoids duplicates. Focuses the first result. (WebInspector.ElementsPanel.prototype.jumpToNextSearchResult): Focuses the next result. (WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult): Focuses the previous result.
19:08 Changeset [36832] by timothy@apple.com
  • 2 edits in trunk/WebCore

Add support to Panel that allows easy searching of sub-views.

Reviewed by Oliver Hunt.

  • page/inspector/Panel.js: (WebInspector.Panel.prototype.searchCanceled): Call searchCanceled on all the views in the search results and delete the currentQuery property. Call WebInspector.updateSearchMatchesCount wit ha 0 match count to rest. Reset the other search properties. (WebInspector.Panel.prototype.performSearch): Call searchCanceled since it will reset everything we need before doing a new search. Get an array of searchableViews from the panel, implemented by sub-classes. Iterate over the views one-by-one with an interval to prevent blocking the UI for large lists of searchableViews. This keeps the interface really responsive. Pass a finishedCallback function to the performSearch on each view so it can notify the panel of results. (WebInspector.Panel.prototype.jumpToNextSearchResult): Finds the index in the searchResults of the visibleView, so we know where in the results we are. This is done every time incase the user manually navigates to a new view. If the view is showing the last result, jump to the next view and show it's first result. Otherwise jump to the next result in the current view. (WebInspector.Panel.prototype.jumpToPreviousSearchResult): Ditto, but in reverse.
19:08 Changeset [36831] by timothy@apple.com
  • 5 edits in trunk/WebCore

Add support for asking the current panel to perform a search, find next/previous and clear.
A search is performed on the new new current panel when switching between panels. The search
label/placeholder in the toolbar now includes the panel name to make it clear that panel will
be searched. The search field contents are selected when Command/Control-F or Enter/Return
is pressed, so the user can easily type an entirely new query. The search match count shows
up in the toolbar next to the search field.

Also changed:

  • Rename lastQuery to currentQuery since it better matches the truth.
  • Set the search field "results" attribute to zero since results arn't saved for how we use the search field.
  • Make repeated presses of the Return key jump to the next search result instead of doing nothing.
  • Increased the search field width.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • English.lproj/localizedStrings.js: New strings.
  • page/inspector/inspector.css: New styles.
  • page/inspector/inspector.html: Add the search-results-matches element. Add the incremental attribute to the search field and set the results attribute to zero.
  • page/inspector/inspector.js: (WebInspector.set currentPanel): perform the search on the new panel. (WebInspector.loaded): Change the event listeners and remove code that changes the search label text. (WebInspector.documentKeyDown): Add support for Command/Control-G and Command/Control-Shift-G. To jump to the next and previous search results. (WebInspector.updateSearchLabel): Added. Update the search placeholder/label. This does different things depending on the attached state. (WebInspector.searchKeyDown): Call preventDefault since this was the Enter key. This prevents a "search" event from firing for key down. We handle the Enter key on key up in searchKeyUp. This stops performSearch from being called twice in a row. (WebInspector.searchKeyUp): Calls performSearch when it is the Enter key. (WebInspector.performSearch): Delete the currentQuery property and call searchCanceled on all the panels. Call jumpToNextSearchResult when this is the same query or a forced search. Call updateSearchMatchesCount to reset the matches count in the toolbar. (WebInspector.updateSearchMatchesCount): Added. Updates the matches count in the toolbar.
19:08 Changeset [36830] by timothy@apple.com
  • 4 edits in trunk/WebCore

Remove the previous Inspector search code to make room for the new stuff.

https://bugs.webkit.org/show_bug.cgi?id=21005

Reviewed by Oliver Hunt.

  • page/inspector/inspector.css:
  • page/inspector/inspector.html:
  • page/inspector/inspector.js: (WebInspector.get/set showingSearchResults): Removed. (WebInspector.searchResultsKeyDown): Removed. (WebInspector.searchResultsResizerDragStart): Removed. (WebInspector.searchResultsResizerDragEnd): Removed. (WebInspector.searchResultsResizerDrag): Removed. (WebInspector.performSearch): Removed searching parts.
19:07 Changeset [36829] by timothy@apple.com
  • 4 edits in trunk/WebCore

Use the Array.remove helper function in more places.

https://bugs.webkit.org/show_bug.cgi?id=21037

Reviewed by Kevin McCullough.

  • page/inspector/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.removeResource): Use Array.remove.
  • page/inspector/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.removeResource): Ditto.
  • page/inspector/inspector.js: (WebInspector.removeResource): Ditto.
19:07 Changeset [36828] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a bug where inspecting a node after reloading the page
would not reveal the node in the DOM tree. The TreeOutline
was not being told to forget decendants of a removed child.
So old TreeElements would be found that are not in the tree.

https://bugs.webkit.org/show_bug.cgi?id=21036

Reviewed by Kevin McCullough.

  • page/inspector/treeoutline.js: (TreeOutline._removeChildAtIndex): Call _forgetChildrenRecursive in addition to _forgetTreeElement. (TreeOutline._removeChildren): Call _forgetChildrenRecursive in addition to _forgetTreeElement. (TreeOutline._rememberTreeElement): Use Array.indexOf to quickly search for known elements. (TreeOutline._forgetTreeElement): Use Array.remove to remove elements. (TreeOutline._forgetChildrenRecursive): Recursively traverse the descendants and call _forgetTreeElement.
  • page/inspector/utilities.js: (Array.prototype.remove): Speed up this function by using Array.indexOf when onlyFirst is true.
19:07 Changeset [36827] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where inspecting some short text nodes does
not reveal them in the Elements panel DOM tree.

https://bugs.webkit.org/show_bug.cgi?id=21035

Reviewed by Oliver Hunt.

  • page/inspector/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): The revealAndSelectNode() method might find a different element if there is inlined text, and the select() call would change the focusedDOMNode and reenter this setter. So to avoid calling focusedNodeChanged() twice, first check if _focusedDOMNode is the same node as the one passed in. (WebInspector.ElementsTreeOutline.prototype.update): Remove use of this.treeOutline, since this is the TreeOutline. (WebInspector.ElementsTreeOutline.prototype.findTreeElement): Added. Provides default functions for isAncestor, getParet and equal. Calls the base protoype's findTreeElement. If that returns null and the node is a text node, try finding it's parent. (WebInspector.ElementsTreeOutline.prototype.revealNode): Removed. Renamed to revealAndSelectNode. (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode): Selects and reveals the node passed in. Use the simple findTreeElement. (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent): Remove use of this.treeOutline, since this is the TreeOutline.
19:07 Changeset [36826] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes an exception that happened when removing a Resource
from the ResourcesPanel.

https://bugs.webkit.org/show_bug.cgi?id=21034

Reviewed by Kevin McCullough.

  • page/inspector/ResourcesPanel.js: (WebInspctor.ResourcesPanel.prototype.removeResource): Remove the graphElement.
18:52 Changeset [36825] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

  • wtf/Platform.h: Removed duplicate #if.
18:18 Changeset [36824] by kmccullough@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2008-09-23 Kevin McCullough <kmccullough@apple.com>

Fixed "Time" to "Tim"

  • ChangeLog:
18:00 Changeset [36823] by zimmermann@webkit.org
  • 12 edits in trunk/WebCore

Reviewed by Oliver.

Move mapInstanceToElement/removeInstanceMapping/instancesForElement
from SVGDocumentExtensions to SVGElement. It's more useful to store
the list of SVGElementInstances per SVGElement, instead of using
a document-wide hash for this purpose.

17:53 Changeset [36822] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

17:27 Changeset [36821] by ggaren@apple.com
  • 27 edits in trunk/JavaScriptCore

2008-09-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Changed the layout of the call frame from


{ header, parameters, locals | constants, temporaries }


to


{ parameters, header | locals, constants, temporaries }


This simplifies function entry+exit, and enables a number of future
optimizations.


13.5% speedup on empty call benchmark for bytecode; 23.6% speedup on
empty call benchmark for CTI.


SunSpider says no change. SunSpider --v8 says 1% faster.

  • VM/CTI.cpp:


Added a bit of abstraction for calculating whether a register is a
constant, since this patch changes that calculation:
(JSC::CTI::isConstant):
(JSC::CTI::getConstant):
(JSC::CTI::emitGetArg):
(JSC::CTI::emitGetPutArg):
(JSC::CTI::getConstantImmediateNumericArg):

Updated for changes to callframe header location:
(JSC::CTI::emitPutToCallFrameHeader):
(JSC::CTI::emitGetFromCallFrameHeader):
(JSC::CTI::printOpcodeOperandTypes):


Renamed to spite Oliver:
(JSC::CTI::emitInitRegister):


Added an abstraction for emitting a call through a register, so that
calls through registers generate exception info, too:
(JSC::CTI::emitCall):

Updated to match the new callframe header layout, and to support calls
through registers, which have no destination address:
(JSC::CTI::compileOpCall):
(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases):
(JSC::CTI::privateCompile):

  • VM/CTI.h:

More of the above:
(JSC::CallRecord::CallRecord):

  • VM/CodeBlock.cpp:

Updated for new register layout:
(JSC::registerName):
(JSC::CodeBlock::dump):

  • VM/CodeBlock.h:


Updated CodeBlock to track slightly different information about the
register frame, and tweaked the style of an ASSERT_NOT_REACHED.
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::getStubInfo):

  • VM/CodeGenerator.cpp:


Added some abstraction around constant register allocation, since this
patch changes it, changed codegen to account for the new callframe
layout, and added abstraction around register fetching code
that used to assume that all local registers lived at negative indices,
since vars now live at positive indices:
(JSC::CodeGenerator::generate):
(JSC::CodeGenerator::addVar):
(JSC::CodeGenerator::addGlobalVar):
(JSC::CodeGenerator::allocateConstants):
(JSC::CodeGenerator::CodeGenerator):
(JSC::CodeGenerator::addParameter):
(JSC::CodeGenerator::registerFor):
(JSC::CodeGenerator::constRegisterFor):
(JSC::CodeGenerator::newRegister):
(JSC::CodeGenerator::newTemporary):
(JSC::CodeGenerator::highestUsedRegister):
(JSC::CodeGenerator::addConstant):


ASSERT that our caller referenced the registers it passed to us.
Otherwise, we might overwrite them with parameters:
(JSC::CodeGenerator::emitCall):
(JSC::CodeGenerator::emitConstruct):

  • VM/CodeGenerator.h:


Added some abstraction for getting a RegisterID for a given index,
since the rules are a little weird:
(JSC::CodeGenerator::registerFor):

  • VM/Machine.cpp:

Utility function to transform a machine return PC to a virtual machine
return VPC, for the sake of stack unwinding, since both PCs are stored
in the same location now:
(JSC::vPCForPC):

Tweaked to account for new call frame:
(JSC::Machine::initializeCallFrame):


Tweaked to account for registerOffset supplied by caller:
(JSC::slideRegisterWindowForCall):

Tweaked to account for new register layout:
(JSC::scopeChainForCall):
(JSC::Machine::callEval):
(JSC::Machine::dumpRegisters):
(JSC::Machine::unwindCallFrame):
(JSC::Machine::execute):

Changed op_call and op_construct to implement the new calling convention:
(JSC::Machine::privateExecute):

Tweaked to account for the new register layout:
(JSC::Machine::retrieveArguments):
(JSC::Machine::retrieveCaller):
(JSC::Machine::retrieveLastCaller):
(JSC::Machine::callFrame):
(JSC::Machine::getArgumentsData):

Changed CTI call helpers to implement the new calling convention:
(JSC::Machine::cti_op_call_JSFunction):
(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_ret_activation):
(JSC::Machine::cti_op_ret_profiler):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_call_eval):

  • VM/Machine.h:
  • VM/Opcode.h:


Renamed op_initialise_locals to op_init, because this opcode
doesn't initialize all locals, and it doesn't initialize only locals.
Also, to spite Oliver.


  • VM/RegisterFile.h:


New call frame enumeration values:
(JSC::RegisterFile::):

Simplified the calculation of whether a RegisterID is a temporary,
since we can no longer assume that all positive non-constant registers
are temporaries:

  • VM/RegisterID.h: (JSC::RegisterID::RegisterID): (JSC::RegisterID::setTemporary): (JSC::RegisterID::isTemporary):

Renamed firstArgumentIndex to firstParameterIndex because the assumption
that this variable pertained to the actual arguments supplied by the
caller caused me to write some buggy code:

  • kjs/Arguments.cpp: (JSC::ArgumentsData::ArgumentsData): (JSC::Arguments::Arguments): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put):

Updated for new call frame layout:

  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::type):
  • kjs/DebuggerCallFrame.h:

Changed the activation object to account for the fact that a call frame
header now sits between parameters and local variables. This change
requires all variable objects to do their own marking, since they
now use their register storage differently:

  • kjs/JSActivation.cpp: (JSC::JSActivation::mark): (JSC::JSActivation::copyRegisters): (JSC::JSActivation::createArgumentsObject):
  • kjs/JSActivation.h:

Updated global object to use the new interfaces required by the change
to JSActivation above:

  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::mark): (JSC::JSGlobalObject::copyGlobalsFrom): (JSC::JSGlobalObject::copyGlobalsTo):
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::addStaticGlobals):

Updated static scope object to use the new interfaces required by the
change to JSActivation above:

  • kjs/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::mark): (JSC::JSStaticScopeObject::~JSStaticScopeObject):
  • kjs/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::d):

Updated variable object to use the new interfaces required by the
change to JSActivation above:

  • kjs/JSVariableObject.cpp: (JSC::JSVariableObject::copyRegisterArray): (JSC::JSVariableObject::setRegisters):
  • kjs/JSVariableObject.h:

Changed the bit twiddling in symbol table not to assume that all indices
are negative, since they can be positive now:

  • kjs/SymbolTable.h: (JSC::SymbolTableEntry::SymbolTableEntry): (JSC::SymbolTableEntry::isNull): (JSC::SymbolTableEntry::getIndex): (JSC::SymbolTableEntry::getAttributes): (JSC::SymbolTableEntry::setAttributes): (JSC::SymbolTableEntry::isReadOnly): (JSC::SymbolTableEntry::pack): (JSC::SymbolTableEntry::isValidIndex):

Changed call and construct nodes to ref their functions and/or bases,
so that emitCall/emitConstruct doesn't overwrite them with parameters.
Also, updated for rename to registerFor:

  • kjs/nodes.cpp: (JSC::ResolveNode::emitCode): (JSC::NewExprNode::emitCode): (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode): (JSC::PostfixResolveNode::emitCode): (JSC::DeleteResolveNode::emitCode): (JSC::TypeOfResolveNode::emitCode): (JSC::PrefixResolveNode::emitCode): (JSC::ReadModifyResolveNode::emitCode): (JSC::AssignResolveNode::emitCode): (JSC::ConstDeclNode::emitCodeSingle): (JSC::ForInNode::emitCode):

Added abstraction for getting exception info out of a call through a
register:

  • masm/X86Assembler.h: (JSC::X86Assembler::emitCall):


Removed duplicate #if:

  • wtf/Platform.h:
17:23 Changeset [36820] by zimmermann@webkit.org
  • 10 edits in trunk/WebCore

Rubber stamped by Sam.

Move code from EventTarget to EventTargetNode.

I refactored most parts to live in EventTarget, a year ago,
though the implementation of EventTargetSVGElementInstance is
done in another way, that obsoletes this.

17:14 Changeset [36819] by hyatt@apple.com
  • 3 edits in trunk/WebCore

Fix horizontal scrollbars on windows.

17:09 Changeset [36818] by bdakin@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

2008-09-23 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add Contact"
link at gmail does not support AXPress action
and corresponding: <rdar://problem/6216178>

I fixed this bug by making AccessibilityObject::anchorElement
support ARIA links.

  • page/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::anchorElement):
  • page/AccessibilityImageMapLink.h:
  • page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::anchorElement):
  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::isNativeAnchor):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isNativeAnchor): (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::internalLinkElement): (WebCore::AccessibilityRenderObject::url):
  • page/AccessibilityRenderObject.h:
  • page/mac/AccessibilityObjectWrapper.mm: (AXLinkElementForNode):

WebKitTools:

2008-09-23 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

This patch extends DumpRenderTree's AccessibilityController to ask
if the focused element supports the press action.

  • DumpRenderTree/AccessibilityUIElement.cpp: (getSupportsPressActionCallback): (AccessibilityUIElement::getJSClass):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::supportsPressAction):

LayoutTests:

2008-09-23 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=21041 "Add
Contact" link at gmail does not support AXPress action
and corresponding: <rdar://problem/6216178>

  • accessibility/aria-link-supports-press-expected.txt: Added.
  • accessibility/aria-link-supports-press.html: Added.
17:05 Changeset [36817] by kmccullough@apple.com
  • 7 edits in trunk/WebCore

2008-09-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Time and Oliver.

Bug 20949: Catch repeated messages in Inspector Controller to limit
memory usage

  • Store the repeat count in the Console Message object, in the Inspector Controller and JS ConsoleMessage object.
  • page/InspectorController.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::operator==): (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::addScriptConsoleMessage):
  • page/InspectorController.h:
  • page/inspector/Console.js:
  • page/inspector/Resource.js:
  • page/inspector/ResourcesPanel.js:
  • page/inspector/SourceFrame.js:
16:44 Changeset [36816] by zimmermann@webkit.org
  • 16 edits
    2 moves
    5 adds in trunk

Reviewed by Eric.

Working on proper EventTarget support for SVGElementInstance.

Add new EventTargetSVGElementInstance class, and it's corresponding JS wrapper.
Finally JSEventTargetBase, is actually used for another class than JSEventTargetnode.

Remove EventTarget inheritance from SVGElementInstance, and the manual "TreeShared"
implementation. Let it use TreeShared directly.

It's not activated so far (SVGUseElement still creating SVGElementInstance objects).
The transition to EventTargetSVGElementInstance will be done in a few individual patches.

14:47 Changeset [36815] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::getCTFont):
14:43 Changeset [36814] by hyatt@apple.com
  • 9 edits in trunk

WebCore:

2008-09-23 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21039

Teach the viewless Mac scrollbar how to avoid NSWindow's resizer.

Reviewed by Sam Weinig

  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::setFrameGeometry):
  • platform/Scrollbar.h:
  • platform/Widget.cpp: (WebCore::Widget::convertFromContainingWindow):
  • platform/Widget.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustOverlappingScrollbarCount): (WebCore::ScrollView::setParent):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow):

WebKit/mac:

2008-09-23 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21039

Teach the viewless Mac scrollbar how to avoid the NSWindow resizer.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::windowResizerRect):
14:33 Changeset [36813] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-09-23 Dirk Schulze <vbs85@gmx.de>

Reviewed by Darin Adler. Landed by Jan Alonzo.

Added support for getImageData() and putImageData()
to Cairo.

[CAIRO] needs getImageData and putImageData support
https://bugs.webkit.org/show_bug.cgi?id=20838

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
14:07 Changeset [36812] by jmalonzo@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2008-09-23 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=18987
[GTK] Implement SharedBuffer::createWithContentsOfFile and
KURL::fileSystemPath

  • GNUmakefile.am: Add KURLGtk.cpp and SharedBufferGtk.cpp.
  • platform/gtk/KURLGtk.cpp: Added. (WebCore::KURL::fileSystemPath): Implemented.
  • platform/gtk/SharedBufferGtk.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile): Implemented.
  • platform/gtk/TemporaryLinkStubs.cpp: Remove the old stubs.
13:39 Changeset [36811] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt, okayed by Darin Adler.

<rdar://problem/5575547> REGRESSION: ATOK has no phrase boundary on Safari/Mail.app

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCompositionUnderline): Add 2 pixel spacing between clauses.
13:30 Changeset [36810] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebKit/mac:

Reviewed by Beth Dakin.

  • fix <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]

Test: fast/events/keydown-remove-frame.html

  • WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Added a null check.

LayoutTests:

Reviewed by Beth Dakin.

  • test for <rdar://problem/6233388> Crash beneath -[WebFrameView keyDown:]
  • fast/events/keydown-remove-frame-expected.txt: Added.
  • fast/events/keydown-remove-frame.html: Added.
  • fast/events/resources/keydown-remove-frame-iframe.html: Added.
11:37 Changeset [36809] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Darin.

Bug 21030: The JS debugger breaks on the do of a do-while not the while
(where the conditional statement is)
https://bugs.webkit.org/show_bug.cgi?id=21030
Now the statementListEmitCode detects if a do-while node is being
emited and emits the debug hook on the last line instead of the first.

This change had no effect on sunspider.

  • kjs/nodes.cpp: (JSC::statementListEmitCode):
  • kjs/nodes.h: (JSC::StatementNode::isDoWhile): (JSC::DoWhileNode::isDoWhile):
10:30 Changeset [36808] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Camron Zwarich.

~2% speedup on EarleyBoyer test.


  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/Machine.cpp: (JSC::Machine::cti_op_instanceof):
09:34 Changeset [36807] by ap@webkit.org
  • 8 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21023
Don't use TEC for encodings supported by ICU

  • platform/text/mac/mac-encodings.txt: Removed x-mac-centraleurroman, x-mac-cyrillic, x-mac-greek, and x-mac-turkish.
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register aliases for these encodings that are not registered automatically; updated comments.
07:18 Changeset [36806] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • add forgotten slow case logic for !==
  • VM/CTI.cpp: (JSC::CTI::privateCompileSlowCases):
06:20 Changeset [36805] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

  • inline the fast cases of !==, same as for ===


2.9% speedup on EarleyBoyer benchmark

  • VM/CTI.cpp: (JSC::CTI::compileOpStrictEq): Factored stricteq codegen into this function, and parameterized so it can do the reverse version as well. (JSC::CTI::privateCompileMainPass): Use the above for stricteq and nstricteq.
  • VM/CTI.h: (JSC::CTI::): Declare above stuff.
  • VM/Machine.cpp: (JSC::Machine::cti_op_nstricteq): Removed fast cases, now handled inline.
03:59 Changeset [36804] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 20989: Aguments constructor should put 'callee' and 'length' properties in a more efficient way
<https://bugs.webkit.org/show_bug.cgi?id=20989>

Make special cases for the 'callee' and 'length' properties in the
Arguments object.

This is somewhere between a 7.8% speedup and a 10% speedup on the V8
Raytrace benchmark, depending on whether it is run alone or with the
other V8 benchmarks.

  • kjs/Arguments.cpp: (JSC::ArgumentsData::ArgumentsData): (JSC::Arguments::Arguments): (JSC::Arguments::mark): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
03:03 Changeset [36803] by oliver@apple.com
  • 1 add in trunk/WebCore/bindings/js/JSCanvasPixelArrayCustom.h

Build fix (add file i forgot in r36801)

00:46 Changeset [36802] by mjs@apple.com
  • 7 edits in trunk

JavaScriptCore:

2008-09-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.


~2% speedup on EarleyBoyer

The idea here is to record in the StructureID whether the class
needs a special hasInstance or if it can use the normal logic from
JSObject.


Based on this I inlined the real work directly into
cti_op_instanceof and put the fastest checks up front and the
error handling at the end (so it should be fairly straightforward
to split off the beginning to be inlined if desired).

I only did this for CTI, not the bytecode interpreter.


  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructureID):
  • ChangeLog:
  • VM/Machine.cpp: (JSC::Machine::cti_op_instanceof):
  • kjs/JSImmediate.h: (JSC::JSImmediate::isAnyImmediate):
  • kjs/TypeInfo.h: (JSC::TypeInfo::overridesHasInstance): (JSC::TypeInfo::flags):

WebCore:

2008-09-23 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

~2% speedup on EarleyBoyer

(WebCore updates.)


  • bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructureID):
00:40 Changeset [36801] by oliver@apple.com
  • 7 edits in trunk/WebCore

2008-09-22 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt

  • GNUmakefile.am: Added JSCanvasPixelArrayCustom.h.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSCanvasPixelArrayCustom.cpp: Removed indexGetter and indexSetter. These are now both inlined, so in the header.
  • bindings/js/JSCanvasPixelArrayCustom.h: Added. The getByIndex function is what's used for HasCustomIndexGetter. Also moved the indexSetter function here.
  • bindings/scripts/CodeGeneratorJS.pm: Changed HasCustomIndexGetter to use a getByIndex member function rather than an indexGetter stat member function in a property slot. This lets us avoid the property slot mechanism's rule where it turns numeric property names into strings in the identifier table, which is good because that's slow. Also added a new property CustomHeader that allows IDL files to introduce headers to be included -- useful when we have functions that we want to inline into the binding.
  • html/CanvasPixelArray.idl: Added CustomHeader attribute.
00:23 Changeset [36800] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Another blind stab in the dark.

  • svg/graphics/cg/SVGResourceClipperCg.cpp: Add missing header.
00:04 Changeset [36799] by eric@webkit.org
  • 3 edits in trunk/WebCore

No review, build fix only.

Third time's the charm, eh? My local build is sadly still not done...

  • platform/graphics/AffineTransform.cpp: remove extra &
  • platform/graphics/AffineTransform.h: remove extra &

09/22/08:

23:47 Changeset [36798] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-09-22 Eric Seidel <eric@webkit.org>

No review, build fix only.

  • platform/graphics/AffineTransform.cpp: remove extra ;
23:38 Changeset [36797] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Speculative fix for the build while I wait for my compile to finish.

  • platform/graphics/AffineTransform.cpp:
23:25 Changeset [36796] by alice.liu@apple.com
  • 3 edits
    3 adds in trunk

WebKit/win:

2008-09-22 Alice Liu <alice.liu@apple.com>

Added record-memory-win.vcproj tool to the solution

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

2008-09-22 Alice Liu <alice.liu@apple.com>

Adding a stand-alone Windows console application to record a process's memory usage

Reviewed by Steve Falkenburg.

  • record-memory-win: Added.
  • record-memory-win/main.cpp: Added.
  • record-memory-win/record-memory-win.vcproj: Added.
23:05 Changeset [36795] by eric@webkit.org
  • 7 edits in trunk/WebCore

2008-09-22 Dirk Schulze <vbs85@gmx.de>

Reviewed by eseidel. Landed by eseidel.

Moved makeMapBetweenRects from SVG/CG to AffineTransform
Make SVGResourceClipper::applyClip more cross-platform

  • platform/graphics/AffineTransform.cpp:
  • platform/graphics/AffineTransform.h:
  • svg/graphics/cg/CgSupport.cpp:
  • svg/graphics/cg/CgSupport.h:
  • svg/graphics/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  • svg/graphics/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
22:45 Introducing SquirrelFish Extreme.ja edited by omo@dodgson.org
(diff)
22:22 Changeset [36794] by darin@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Speeds up v8-raytrace by 7.2%.

  • kjs/nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): Initialize m_refCount to 0.
  • kjs/nodes.h: (JSC::FunctionBodyNode::ref): Call base class ref once, and thereafter use m_refCount. (JSC::FunctionBodyNode::deref): Ditto, but the deref side.
22:12 Changeset [36793] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-22 Darin Adler <darin@apple.com>

Pointed out by Sam Weinig.

  • kjs/Arguments.cpp: (JSC::Arguments::fillArgList): Fix bad copy and paste. Oops!
21:55 Changeset [36792] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-22 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Speeds up v8-raytrace by 5%.

  • kjs/Arguments.cpp: (JSC::ArgumentsData::ArgumentsData): Use a fixed buffer if there are 4 or fewer extra arguments. (JSC::Arguments::Arguments): Use a fixed buffer if there are 4 or fewer extra arguments. (JSC::Arguments::~Arguments): Delete the buffer if necessary. (JSC::Arguments::mark): Update since extraArguments are now Register. (JSC::Arguments::fillArgList): Added special case for the only case that's actually used in the practice, when there are no parameters. There are some other special cases in there too, but that's the only one that matters. (JSC::Arguments::getOwnPropertySlot): Updated to use setValueSlot since there's no operation to get you at the JSValue* inside a Register as a "slot".
20:08 Changeset [36791] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-09-22 Alp Toker <alp@nuanti.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=16331
[Gtk] no focus when button/checkbox/radiobutton clicked, only when tabbed

Obey GTK+ focusing conventions for controls and anchor elements.

It could be interesting to push these decisions up to Settings or
ChromeClient some day but this gets things working.

Right and middle click events still need some work to match GTK+
conventions.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isMouseFocusable):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable):
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
19:46 Changeset [36790] by weinig@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo in ChangeLog

19:44 Changeset [36789] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-09-22 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21014
Speed up for..in by using StructureID to avoid call hasProperty

Speeds up fasta by 8%.

  • VM/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::invalidate):
  • VM/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
  • kjs/PropertyNameArray.h: (JSC::PropertyNameArrayData::begin): (JSC::PropertyNameArrayData::end): (JSC::PropertyNameArrayData::setCachedStructureID): (JSC::PropertyNameArrayData::cachedStructureID):
  • kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames): (JSC::structureIDChainsAreEqual):
  • kjs/StructureID.h:
18:24 Changeset [36788] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-09-22 Darin Adler <darin@apple.com>

  • page/mac/FrameMac.mm: (WebCore::Frame::baseWritingDirectionForSelectionStart): Fix indentation.
18:19 Changeset [36787] by weinig@apple.com
  • 10 edits
    2 adds
    2 deletes in trunk

WebCore:

2008-09-22 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21013
Match Firefox in how we hide HTMLInputElement.selectionStart, selectionEnd
and setSelectionRange. This also allows us to remove the legacy JSHTMLInputElementBase
class!

  • selectionStart, selectionEnd and setSelectionRange now are visible in iteration of non-selectable input types, but return undefined when accessed.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSHTMLInputElementBase.cpp: Removed.
  • bindings/js/JSHTMLInputElementBase.h: Removed.
  • bindings/js/JSHTMLInputElementCustom.cpp: Added. (WebCore::JSHTMLInputElement::customGetOwnPropertySlot): (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::selectionEnd):
  • bindings/js/JSHTMLInputElementCustom.h: Added.
  • html/HTMLInputElement.idl:

LayoutTests:

2008-09-22 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for https://bugs.webkit.org/show_bug.cgi?id=21013

  • fast/forms/selection-functions.html: Update test to match new behavior that we now share with Firefox.
17:48 Changeset [36786] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/5699571> Mail: Unable to change writing direction to LTR in an empty message

Not testable in DumpRenderTree or in Safari

  • page/mac/FrameMac.mm: (WebCore::Frame::baseWritingDirectionForSelectionStart): Account for the case that the selection start node is a block.
16:18 Changeset [36785] by weinig@apple.com
  • 2 edits in trunk/WebKitSite

2008-09-22 Alexander Orlov <alexander.orlov@loxal.net>

Reviewed by Darin Adler.

  • projects/performance/index.html: Remove dead link to the 24fun test.
16:01 Changeset [36784] by weinig@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-09-22 Kelvin Sherlock <ksherlock@gmail.com>

Updated and tweaked by Sam Weinig.

Reviewed by Geoffrey Garen.

Bug 20020: Proposed enhancement to JavaScriptCore API
<https://bugs.webkit.org/show_bug.cgi?id=20020>

Add JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError, and JSObjectMakeRegExp
functions to create JavaScript Array, Date, Error, and RegExp objects, respectively.

  • API/JSObjectRef.cpp: The functions
  • API/JSObjectRef.h: Function prototype and documentation
  • JavaScriptCore.exp: Added functions to exported function list
  • API/tests/testapi.c: Added basic functionality tests.
  • kjs/DateConstructor.cpp: Replaced static JSObject* constructDate(ExecState* exec, JSObject*, const ArgList& args) with JSObject* constructDate(ExecState* exec, const ArgList& args). Added static JSObject* constructWithDateConstructor(ExecState* exec, JSObject*, const ArgList& args) function
  • kjs/DateConstructor.h: added prototype for JSObject* constructDate(ExecState* exec, const ArgList& args)
  • kjs/ErrorConstructor.cpp: removed static qualifier from ErrorInstance* constructError(ExecState* exec, const ArgList& args)
  • kjs/ErrorConstructor.h: added prototype for ErrorInstance* constructError(ExecState* exec, const ArgList& args)
  • kjs/RegExpConstructor.cpp: removed static qualifier from JSObject* constructRegExp(ExecState* exec, const ArgList& args)
  • kjs/RegExpConstructor.h: added prototype for JSObject* constructRegExp(ExecState* exec, const ArgList& args)
15:17 Changeset [36783] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-09-22 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21007

Make sure that the scrollbar gets sent a release event on platforms that call handleMouseDoubleClickEvent.

Reviewed by Sam Weinig

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):

LayoutTests:

2008-09-22 David Hyatt <hyatt@apple.com>

Layout test for double click scrollbar bug.

Reviewed by Sam Weinig

  • fast/events/scrollbar-double-click-expected.txt: Added.
  • fast/events/scrollbar-double-click.html: Added.
14:59 Changeset [36782] by pewtermoose@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-09-22 Matt Lilek <webkit@mattlilek.com>

Not reviewed, Windows build fix.

  • kjs/Arguments.cpp:
  • kjs/FunctionPrototype.cpp:
14:44 Changeset [36781] by eric@webkit.org
  • 7 edits in trunk/WebCore

No review, rollback only.

Roll out Peter's change (per his request)
http://trac.webkit.org/changeset/36069
https://bugs.webkit.org/show_bug.cgi?id=19663
This change has been the source of numerous regressions
(several of which were latent bugs revealed by this change,
others were bugs in this change)

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::startAnimation): (WebCore::BitmapImage::advanceAnimation):
  • platform/graphics/BitmapImage.h:
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::draw):
14:32 Changeset [36780] by mitz@apple.com
  • 3 edits
    16 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5158514> Switch the complex text code path to Core Text

Tests: platform/mac-snowleopard/fast/text/myanmar-shaping.html

platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html

  • config.h: Use Core Text if not building for Leopard or Tiger.

LayoutTests:

Reviewed by Sam Weinig.

  • tests and updated results for <rdar://problem/5158514> Switch the complex text code path to Core Text
  • platform/mac-snowleopard/fast: Added.
  • platform/mac-snowleopard/fast/text: Added.
  • platform/mac-snowleopard/fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/mac-snowleopard/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/mac-snowleopard/fast/text/myanmar-shaping-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/myanmar-shaping-expected.png: Added.
  • platform/mac-snowleopard/fast/text/myanmar-shaping-expected.txt: Added.
  • platform/mac-snowleopard/fast/text/myanmar-shaping.html: Added.
  • platform/mac-snowleopard/fast/text/resources: Added.
  • platform/mac-snowleopard/fast/text/resources/Garuda.ttf: Added from http://www.w3.org/International/tests/test-webfonts/test-thai-tibetan-myanmar.html.
  • platform/mac-snowleopard/fast/text/resources/mm3.ttf: Added from http://www.w3.org/International/tests/test-webfonts/test-thai-tibetan-myanmar.html.
  • platform/mac-snowleopard/fast/text/thai-combining-mark-positioning-expected.checksum: Added.
  • platform/mac-snowleopard/fast/text/thai-combining-mark-positioning-expected.png: Added.
  • platform/mac-snowleopard/fast/text/thai-combining-mark-positioning-expected.txt: Added.
  • platform/mac-snowleopard/fast/text/thai-combining-mark-positioning.html: Added.
14:20 Changeset [36779] by weinig@apple.com
  • 8 edits
    3 adds in trunk

JavaScriptCore:

2008-09-22 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Patch for https://bugs.webkit.org/show_bug.cgi?id=20982
Speed up the apply method of functions by special-casing array and 'arguments' objects

1% speedup on v8-raytrace.

Test: fast/js/function-apply.html

  • kjs/Arguments.cpp: (JSC::Arguments::fillArgList):
  • kjs/Arguments.h:
  • kjs/FunctionPrototype.cpp: (JSC::functionProtoFuncApply):
  • kjs/JSArray.cpp: (JSC::JSArray::fillArgList):
  • kjs/JSArray.h:

LayoutTests:

2008-09-22 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=20982

  • fast/js/function-apply-expected.txt: Added.
  • fast/js/function-apply.html: Added.
  • fast/js/resources/function-apply.js: Added.
14:04 Changeset [36778] by darin@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-22 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

3% or so speedup on DeltaBlue benchmark.

  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): Call JSArray::pop when appropriate. (JSC::arrayProtoFuncPush): Call JSArray::push when appropriate.
  • kjs/JSArray.cpp: (JSC::JSArray::putSlowCase): Set m_fastAccessCutoff when appropriate, getting us into the fast code path. (JSC::JSArray::pop): Added. (JSC::JSArray::push): Added.
  • kjs/JSArray.h: Added push and pop.
  • kjs/operations.cpp: (JSC::throwOutOfMemoryError): Don't inline this. Helps us avoid PIC branches.
14:03 Changeset [36777] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2008-09-22 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21006

Add code that paints an NSView-less scroller using HIThemeDrawTrack. This scrollbar is still not
switched on. There are still a few more refinements to make to the rendering and behavior.

Reviewed by Darin Adler

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintTrack): (WebCore::ScrollbarThemeComposite::paintButton): (WebCore::ScrollbarThemeComposite::paintThumb):
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::backButtonRect): (WebCore::ScrollbarThemeMac::forwardButtonRect): (WebCore::scrollbarPartToHIPressedState): (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::invalidateRect):
13:38 Changeset [36776] by sfalken@apple.com
  • 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merged r36578

13:35 Changeset [36775] by sfalken@apple.com
  • 3 edits in branches/Safari-3-2-branch/WebCore

Merge r36748, r36750.

13:19 Changeset [36774] by simon.fraser@apple.com
  • 5 edits in trunk

2008-09-22 Chris Marrin <cmarrin@apple.com>

Reviewed by Sam Weinig

transition end event when -webkit-transition-property: all puts wrong
propertyName in event
https://bugs.webkit.org/show_bug.cgi?id=20903

  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
11:47 Changeset [36773] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/6230234> AXTable should probably not be exposed in there's only one cell

11:30 Changeset [36772] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

<rdar://problem/6167779> Setting AXSelectedTextRange for TextAreas in a WebView behaves incorrectly

11:21 Changeset [36771] by hyatt@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2008-09-22 David Hyatt <hyatt@apple.com>

Clean up some parent relationships in the back end stylesheet code. Make sure parentStyleSheet
properly walks up nested rule blocks to reach the parent sheet instead of giving up at the immediate
parent. Also fix the doc() method so that it is properly set when the parent of the sheet is an import
rule.

Reviewed by Sam Weinig

Added fast/css/nested-rule-parent-sheet.html

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::insertedIntoParent):

  • css/CSSRule.cpp: (WebCore::CSSRule::parentStyleSheet): (WebCore::CSSRule::parentRule):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
  • css/CSSStyleSheet.h:

LayoutTests:

2008-09-22 David Hyatt <hyatt@apple.com>

Add new test for .parentStyleSheet.

Reviewed by Sam Weinig

  • fast/css/nested-rule-parent-sheet.html: Added.
11:17 Changeset [36770] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fixes svg/text/text-spacing-01-b.svg in run-webkit-tests --complex-text

  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation):
10:10 Changeset [36769] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Versioning.

09:39 Changeset [36768] by mrowe@apple.com
  • 3 edits in branches/Safari-3-2-branch/WebKit/win

Merge r34834.

09:39 Changeset [36767] by mrowe@apple.com
  • 9 edits in branches/Safari-3-2-branch

Merge r35182.

08:03 Changeset [36766] by mjs@apple.com
  • 19 edits in trunk

JavaScriptCore:

2008-09-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>


2.2% speedup on EarleyBoyer benchmark.

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructureID):
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructureID):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructureID):
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance):
  • API/JSValueRef.cpp: (JSValueIsInstanceOfConstructor):
  • JavaScriptCore.exp:
  • VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_instanceof):
  • kjs/InternalFunction.cpp:
  • kjs/InternalFunction.h: (JSC::InternalFunction::createStructureID):
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/TypeInfo.h: (JSC::TypeInfo::implementsHasInstance):

WebCore:

2008-09-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

  • speed up instanceof operator by replacing implementsHasInstance method with a TypeInfo flag

Partial work towards <https://bugs.webkit.org/show_bug.cgi?id=20818>


2.2% speedup on EarleyBoyer benchmark.

  • bindings/js/JSQuarantinedObjectWrapper.cpp:
  • bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructureID):
  • bindings/scripts/CodeGeneratorJS.pm:
07:31 Changeset [36765] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag.
06:59 Changeset [36764] by mjs@apple.com
  • 19 edits
    1 add in trunk

JavaScriptCore:

2008-09-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dave Hyatt.


Based on initial work by Darin Adler.


0.5% speedup on SunSpider
~4% speedup on Richards benchmark


  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/Machine.cpp: (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_is_undefined):
  • VM/Machine.h:
  • kjs/JSCell.h:
  • kjs/JSValue.h:
  • kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::create): (JSC::StringObjectThatMasqueradesAsUndefined::createStructureID):
  • kjs/StructureID.h: (JSC::StructureID::mutableTypeInfo):
  • kjs/TypeInfo.h: (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::masqueradesAsUndefined):
  • kjs/operations.cpp: (JSC::equal):
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::setnz_r): (JSC::X86Assembler::testl_i32m):

WebCore:

2008-09-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dave Hyatt.

Based on initial work by Darin Adler.



  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
  • bindings/js/JSHTMLAllCollection.cpp: Added. (WebCore::):
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructureID): (WebCore::JSHTMLAllCollection::toBoolean):
06:27 Changeset [36763] by vestbo@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Initialize QCoreApplication in kjs binary/Shell.cpp

This allows us to use QCoreApplication::instance() to
get the main thread in ThreadingQt.cpp

06:27 Changeset [36762] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-09-22 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Fix the QtWebKit build

01:53 Changeset [36761] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-09-22 Alp Toker <alp@nuanti.com>

Suggested by David Hyatt.

Build fix: ScrollView::update() is still used by Document.cpp on !MAC
so make it public.

  • platform/ScrollView.h:
01:36 Changeset [36760] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-09-22 David Hyatt <hyatt@apple.com>

Fix a regression in Windows scrollbar painting. (Also fix the same
bug in my new viewless Mac scrollbar painting code). The track rect
was being improperly inflated when painting resulting in the scrollbar
being too tall and painting in the border of overflow sections.

Reviewed by Oliver Hunt

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::trackRect):
  • platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::trackRect):
00:57 Changeset [36759] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-09-22 David Hyatt <hyatt@apple.com>

Fix a hit testing bug where events are mistakenly passed to subframes
if the mouse is over the border or padding area of the frame. Add
a boolean flag, isOverWidget(), to hit test results so that EventHandler
can check it to tell if the mouse is really over the content box of a
RenderWidget and not just in the border/padding area.

This is not testable, since the old code properly recovered when it detected
that the mouse was outside the bounds of the view, but this prevents
the extra passdown from even occurring (and is basically a nice cleanup).

Reviewed by Oliver Hunt

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::subframeForHitTestResult): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handleWheelEvent):
  • page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::isOverWidget):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::operator=):
  • rendering/HitTestResult.h: (WebCore::HitTestResult::isOverWidget): (WebCore::HitTestResult::setIsOverWidget):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RenderWidget.h:

09/21/08:

22:54 Changeset [36758] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2008-09-21 David Hyatt <hyatt@apple.com>

Rename FrameView's repaintRectangle method to repaintContentRectangle. Make
both it and ScrollView's updateContents method be off-limits to everyone in
WebCore except for RenderView.

Make repaintViewRectangle the only possible method for WebCore code to do
an invalidation. This ensures that all invalidates triggered by WebCore
cross-platform code that cross ownerElement() boundaries are transform-aware.

Make sure that iframes/frames contained inside objects that have transforms
or reflections are not allowed to blit (this was already true for transparency).

It is not possible to make a test for any of this, since iframe scrolling
still doesn't work on Mac (since the invalidates are not being done
through WebCore's cross-platform invalidation code but are instead going
through NSScrollView's setNeedsDisplay still).

Reviewed by Oliver Hunt

  • editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): (WebCore::SelectionController::invalidateCaretRect): (WebCore::SelectionController::focusedOrActiveStateChanged):
  • page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::endDeferredRepaints):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintFillLayerExtended):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::requiresSlowRepaints):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasTransform):
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): (WebCore::RenderView::repaintViewRectangle): (WebCore::RenderView::setSelection):
21:07 Changeset [36757] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

  • blind attempt to fix non-all-in-one builds
  • kjs/JSGlobalObject.cpp: Added includes of Arguments.h and RegExpObject.h.
20:35 Changeset [36756] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

  • fix debug build
  • kjs/StructureID.cpp: (JSC::StructureID::addPropertyTransition): Use typeInfo().type() instead of m_type. (JSC::StructureID::createCachedPrototypeChain): Ditto.
20:15 Changeset [36755] by mjs@apple.com
  • 30 edits
    2 adds in trunk

JavaScriptCore:

2008-09-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.


  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompilePutByIdTransition):
  • VM/Machine.cpp: (JSC::jsIsObjectType): (JSC::Machine::Machine):
  • kjs/AllInOneFile.cpp:
  • kjs/JSCell.h: (JSC::JSCell::isObject): (JSC::JSCell::isString):
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • kjs/JSGlobalObject.h: (JSC::StructureID::prototypeForLookup):
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::createStructureID):
  • kjs/JSObject.cpp: (JSC::JSObject::createInheritorID):
  • kjs/JSObject.h: (JSC::JSObject::createStructureID):
  • kjs/JSString.h: (JSC::JSString::createStructureID):
  • kjs/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • kjs/RegExpConstructor.cpp:
  • kjs/RegExpMatchesArray.h: Added. (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition):
  • kjs/StructureID.h: (JSC::StructureID::create): (JSC::StructureID::typeInfo):
  • kjs/TypeInfo.h: Added. (JSC::TypeInfo::TypeInfo): (JSC::TypeInfo::type):

WebCore:

2008-09-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.


  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter):
  • bindings/js/JSDOMBinding.cpp: (WebCore::createDOMStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMStructure):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::createPrototype):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/scripts/CodeGeneratorJS.pm:
19:12 Changeset [36754] by darin@apple.com
  • 3 edits in trunk/WebCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

  • fix problem Maciej noticed where every JSNamedNodesCollection gets its own StructureID
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::JSNamedNodesCollection): Use getDOMStructure to get the structure.
  • bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createPrototype): Return the object prototype.
17:42 Changeset [36753] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

  • fix crash logging into Gmail due to recent Arguments change
  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): Fix window where mark() function could see d->extraArguments with uninitialized contents. (JSC::Arguments::mark): Check d->extraArguments for 0 to handle two cases: 1) Inside the constructor before it's initialized. 2) numArguments <= numParameters.
17:33 Changeset [36752] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-09-20 David Hyatt <hyatt@apple.com>

Make sure transformed scrollbars in overflow sections position
properly. This patch mimics the same behavior that works for
iframes, namely making sure that the same code that dynamically
adjusts iframe widget positions at paint time for fixed positioning
and transforms also applies to scrollbars. (This is as simple as passing
in the current translation factor at paint time rather than crawling
up the layer tree to compute a "false" absolute position.)

An existing transform test covers this (although only a pixel result
reveals the correct rendering).

Reviewed by Darin Adler

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h:
17:18 Changeset [36751] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

  • fix loose end from the "duplicate constant values" patch
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitLoad): Add a special case for values the hash table can't handle.
17:12 Changeset [36750] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Removed unnecessary nested timer check.


Rubber-stamped by Dan Bernstein.

  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc):
17:12 Changeset [36749] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix the non-AllInOneFile build.

17:08 Changeset [36748] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Improve timer resolution on WinXP.
https://bugs.webkit.org/show_bug.cgi?id=20979


Removed last-chance timer. It should not be necessary.
Change timeEndPeriod timer to fire in 300ms instead of 20ms. Calling timeBeginPeriod/timeEndPeriod too often throws off accuracy.
Remove Vista checks. We now run the same code on both XP and Vista.


Call through to JSC::getCurrentUTCTimeWithMicroseconds from WebCore::currentTime.
The code previously called GetSystemTimeAsFileTime, which is always low-resolution on XP, even within timeBeginPeriod(1).


Reviewed by Maciej Stachowiak.

  • platform/win/SharedTimerWin.cpp: (WebCore::): (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
  • platform/win/SystemTimeWin.cpp: (WebCore::currentTime):
17:01 Changeset [36747] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich and Mark Rowe.

  • fix test failure caused by my recent IndexToNameMap patch
  • kjs/Arguments.cpp: (JSC::Arguments::deleteProperty): Added the accidentally-omitted check of the boolean result from toArrayIndex.
16:08 Changeset [36746] by darin@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

  • VM/CTI.h: Renamed emitJumpSlowCaseIfNotImm to emitJumpSlowCaseIfNotImmNum, since the old name was incorrect.
  • VM/CTI.cpp: Updated for new name. (JSC::CTI::privateCompileMainPass): Added op_eq. (JSC::CTI::privateCompileSlowCases): Added op_eq.
  • VM/Machine.cpp: (JSC::Machine::cti_op_eq): Removed fast case, since it's now compiled.
14:53 Changeset [36745] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Peter Gal <galpter@inf.u-szeged.hu>

Reviewed by Tim Hatcher and Eric Seidel.

Fix the QT/Linux JavaScriptCore segmentation fault.
https://bugs.webkit.org/show_bug.cgi?id=20914

  • wtf/ThreadingQt.cpp: (WTF::initializeThreading): Use currentThread() if platform is not a MAC (like in pre 36541 revisions)
14:36 Changeset [36744] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • kjs/debugger.h: Removed some unneeded includes and declarations.
14:35 Changeset [36743] by darin@apple.com
  • 10 edits
    2 deletes in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

No change on SunSpider. 1.29x as fast on V8 Raytrace.

  • kjs/Arguments.cpp: Moved ArgumentsData in here. Eliminated the indexToNameMap and hadDeletes data members. Changed extraArguments into an OwnArrayPtr and added deletedArguments, another OwnArrayPtr. Replaced numExtraArguments with numParameters, since that's what's used more directly in hot code paths. (JSC::Arguments::Arguments): Pass in argument count instead of ArgList. Initialize ArgumentsData the new way. (JSC::Arguments::mark): Updated. (JSC::Arguments::getOwnPropertySlot): Overload for the integer form so we don't have to convert integers to identifiers just to get an argument. Integrated the deleted case with the fast case. (JSC::Arguments::put): Ditto. (JSC::Arguments::deleteProperty): Ditto.
  • kjs/Arguments.h: Minimized includes. Made everything private. Added overloads for the integral property name case. Eliminated mappedIndexSetter. Moved ArgumentsData into the .cpp file.
  • kjs/IndexToNameMap.cpp: Emptied out and prepared for deletion.
  • kjs/IndexToNameMap.h: Ditto.
  • kjs/JSActivation.cpp: (JSC::JSActivation::createArgumentsObject): Elminated ArgList.
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp: Removed IndexToNameMap.
13:41 Changeset [36742] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Darin Adler <darin@apple.com>

  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitLoad): One more tweak: Wrote this in a slightly clearer style.
13:35 Changeset [36741] by darin@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-21 Judit Jasz <jasy@inf.u-szeged.hu>

Reviewed and tweaked by Darin Adler.

Seems to be a wash on SunSpider.

  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitLoad): Use m_numberMap and m_stringMap to guarantee we emit the same JSValue* for identical numbers and strings.
  • VM/CodeGenerator.h: Added overload of emitLoad for const Identifier&. Add NumberMap and IdentifierStringMap types and m_numberMap and m_stringMap.
  • kjs/nodes.cpp: (JSC::StringNode::emitCode): Call the new emitLoad and let it do the JSString creation.
13:17 Changeset [36740] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-21 Paul Pedriana <webkit@pedriana.com>

Reviewed and tweaked by Darin Adler.

  • wtf/Vector.h: Added WTF_ALIGH_ON, WTF_ALIGNED, AlignedBufferChar, and AlignedBuffer. Use AlignedBuffer insteadof an array of char in VectorBuffer.
12:15 Changeset [36739] by darin@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-09-21 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

1.008x as fast on SunSpider.

  • kjs/grammar.y: (makeNegateNode): Fold if expression is a number > 0. (makeBitwiseNotNode): Fold if expression is a number. (makeMultNode): Fold if expressions are both numbers. (makeDivNode): Fold if expressions are both numbers. (makeAddNode): Fold if expressions are both numbers. (makeLeftShiftNode): Fold if expressions are both numbers. (makeRightShiftNode): Fold if expressions are both numbers.

LayoutTests:

2008-09-21 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed and tweaked by Darin Adler.

  • fast/js/constant-folding-expected.txt: Added.
  • fast/js/constant-folding.html: Added.
  • fast/js/resources/constant-folding.js: Added.
03:39 Changeset [36738] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-09-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.


  • VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumber): (JSC::CTI::emitJumpSlowCaseIfNotImmediateNumbers): (JSC::CTI::emitJumpSlowCaseIfNotImmediates): (JSC::CTI::emitTagAsBoolImmediate): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_stricteq):
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setz_r): (JSC::X86Assembler::movzbl_rr): (JSC::X86Assembler::emitUnlinkedJnz):
03:37 Changeset [36737] by eric@webkit.org
  • 8 edits in trunk/WebCore

2008-09-21 Dirk Schulze <vbs85@gmx.de>

Reviewed by eseidel. Landed by eseidel.

All platforms use the DashArray in the GraphicsContext.

  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::SVGPaintServerPattern::setup):
  • svg/graphics/cairo/SVGPaintServerSolidCairo.cpp: (WebCore::SVGPaintServerSolid::setup):
  • svg/graphics/qt/SVGPaintServerGradientQt.cpp: (WebCore::SVGPaintServerGradient::setup):
  • svg/graphics/qt/SVGPaintServerQt.cpp:
  • svg/graphics/qt/SVGPaintServerSolidQt.cpp: (WebCore::SVGPaintServerSolid::setup):
01:46 Changeset [36736] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Free memory allocated for extra arguments in the destructor of the
Arguments object.

  • kjs/Arguments.cpp: (JSC::Arguments::~Arguments):
  • kjs/Arguments.h:
01:37 Changeset [36735] by cwzwarich@webkit.org
  • 8 edits
    3 adds in trunk

2008-09-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 20815: 'arguments' object creation is non-optimal
<https://bugs.webkit.org/show_bug.cgi?id=20815>

Fix our inefficient way of creating the arguments object by only
creating named properties for each of the arguments after a use of the
'delete' statement. This patch also speeds up access to the 'arguments'
object slightly, but it still does not use the array fast path for
indexed access that exists for many opcodes.

This is about a 20% improvement on the V8 Raytrace benchmark, and a 1.5%
improvement on the Earley-Boyer benchmark, which gives a 4% improvement
overall.

JavaScriptCore:

  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): (JSC::Arguments::mark): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • kjs/Arguments.h: (JSC::Arguments::ArgumentsData::ArgumentsData):
  • kjs/IndexToNameMap.h: (JSC::IndexToNameMap::size):
  • kjs/JSActivation.cpp: (JSC::JSActivation::createArgumentsObject):
  • kjs/JSActivation.h: (JSC::JSActivation::uncheckedSymbolTableGet): (JSC::JSActivation::uncheckedSymbolTableGetValue): (JSC::JSActivation::uncheckedSymbolTablePut):
  • kjs/JSFunction.h: (JSC::JSFunction::numParameters):

LayoutTests:

  • fast/js/arguments-expected.txt: Added.
  • fast/js/arguments.html: Added.
  • fast/js/resources/arguments.js: Added.
00:59 Changeset [36734] by eric@webkit.org
  • 14 edits
    1 copy in trunk

2008-09-21 Dirk Schulze <vbs85@gmx.de>

Reviewed by eseidel. Landed by eseidel.

Moved DashArray to GraphicsContext.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/DashArray.h: Added.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setLineDash):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/cg/CgSupport.cpp:
  • svg/graphics/cg/CgSupport.h:
00:16 Changeset [36733] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix linker warnings
  • WebCore.base.exp:

09/20/08:

23:50 Changeset [36732] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-09-20 Darin Adler <darin@apple.com>

  • another try at fixing Qt
  • bridge/qt/qt_runtime.cpp: "using namespce WebCore"
23:34 Changeset [36731] by darin@apple.com
  • 3 edits in trunk/WebCore

2008-09-20 Darin Adler <darin@apple.com>

  • blind attempt to fix Qt build
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): Use regExpStructure instead of regExpPrototype to make a RegExpObject. There should really be some sort of public helper function for this. Same thing for DateInstance and dateStructure. For JSObject, use constructEmptyObject. (JSC::Bindings::): (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod): Use getDOMStructure. It is not correct to do this inside the constructor because it could cause a garbage collect while the QtRuntimeMethod object is half- allocated, which could lead to a crash; note that RuntimeMethod, QtRuntimeObjectImp, and RuntimeObjectImp have the same bug.
  • bridge/qt/qt_runtime.h: Add s_info and createPrototype.
23:26 Changeset [36730] by collinj@webkit.org
  • 2 edits in trunk/WebCore

2008-09-20 Collin Jackson <collinj@webkit.org>

Prefetch DNS for hyperlinks that the user mouses over.

https://bugs.webkit.org/show_bug.cgi?id=20931

Reviewed by Sam Weinig.

  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
23:21 Changeset [36729] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-20 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • fix crash seen on buildbot
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::mark): Add back mark of arrayPrototype, deleted by accident in my recent check-in.
23:16 Changeset [36728] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-20 Maciej Stachowiak <mjs@apple.com>

Not reviewed, build fix.


  • speculative fix for non-AllInOne builds
  • kjs/operations.h:
22:54 Changeset [36727] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.



2.5% speedup on earley-boyer test

  • VM/Machine.cpp: (JSC::Machine::cti_op_stricteq): Use inline version of strictEqualSlowCase; remove unneeded exception check. (JSC::Machine::cti_op_nstricteq): ditto
  • kjs/operations.cpp: (JSC::strictEqual): Use strictEqualSlowCaseInline (JSC::strictEqualSlowCase): ditto
  • kjs/operations.h: (JSC::strictEqualSlowCaseInline): Version of strictEqualSlowCase that can be inlined, since the extra function call indirection is a lose for CTI.
21:53 FAQ edited by hahn.seb@web.de
(diff)
19:29 Changeset [36726] by darin@apple.com
  • 93 edits in trunk

JavaScriptCore:

2008-09-20 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

This also includes some optimizations that make the change an overall
small speedup. Without those it was a bit of a slowdown.

  • API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::JSCallbackConstructor): Take a structure.
  • API/JSCallbackConstructor.h: Ditto.
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::JSCallbackFunction): Pass a structure.
  • API/JSCallbackObject.h: Take a structure.
  • API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::JSCallbackObject): Ditto.
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype): Pass in a structure. Call setPrototype if there's a custom prototype involved.
  • API/JSObjectRef.cpp: (JSObjectMake): Ditto. (JSObjectMakeConstructor): Pass in a structure.
  • VM/Machine.cpp: (JSC::jsLess): Added a special case for when both arguments are strings. This avoids converting both strings to with UString::toDouble. (JSC::jsLessEq): Ditto. (JSC::Machine::privateExecute): Pass in a structure. (JSC::Machine::cti_op_construct_JSConstruct): Ditto. (JSC::Machine::cti_op_new_regexp): Ditto. (JSC::Machine::cti_op_is_string): Ditto.
  • VM/Machine.h: Made isJSString public so it can be used in the CTI.
  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): Pass in a structure.
  • kjs/JSCell.h: Mark constructor explicit.
  • kjs/JSGlobalObject.cpp: (JSC::markIfNeeded): Added an overload for marking structures. (JSC::JSGlobalObject::reset): Eliminate code to set data members to zero. We now do that in the constructor, and we no longer use this anywhere except in the constructor. Added code to create structures. Pass structures rather than prototypes when creating objects. (JSC::JSGlobalObject::mark): Mark the structures.
  • kjs/JSGlobalObject.h: Removed unneeded class declarations. Added initializers for raw pointers in JSGlobalObjectData so everything starts with a 0. Added structure data and accessor functions.
  • kjs/JSImmediate.cpp: (JSC::JSImmediate::nonInlineNaN): Added.
  • kjs/JSImmediate.h: (JSC::JSImmediate::toDouble): Rewrote to avoid PIC branches.
  • kjs/JSNumberCell.cpp: (JSC::jsNumberCell): Made non-inline to avoid PIC branches in functions that call this one. (JSC::jsNaN): Ditto.
  • kjs/JSNumberCell.h: Ditto.
  • kjs/JSObject.h: Removed constructor that takes a prototype. All callers now pass structures.
  • kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • kjs/ArrayConstructor.h:
  • kjs/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
  • kjs/ArrayPrototype.h:
  • kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • kjs/BooleanConstructor.h:
  • kjs/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • kjs/BooleanObject.h:
  • kjs/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • kjs/BooleanPrototype.h:
  • kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): (JSC::constructDate):
  • kjs/DateConstructor.h:
  • kjs/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • kjs/DateInstance.h:
  • kjs/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • kjs/DatePrototype.h:
  • kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): (JSC::constructError):
  • kjs/ErrorConstructor.h:
  • kjs/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • kjs/ErrorInstance.h:
  • kjs/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • kjs/ErrorPrototype.h:
  • kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): (JSC::FunctionPrototype::addFunctionProperties):
  • kjs/FunctionPrototype.h:
  • kjs/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction):
  • kjs/GlobalEvalFunction.h:
  • kjs/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • kjs/InternalFunction.h: (JSC::InternalFunction::InternalFunction):
  • kjs/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::constructEmptyArray): (JSC::constructArray):
  • kjs/JSArray.h:
  • kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::construct):
  • kjs/JSObject.cpp: (JSC::constructEmptyObject):
  • kjs/JSString.cpp: (JSC::StringObject::create):
  • kjs/JSWrapperObject.h:
  • kjs/MathObject.cpp: (JSC::MathObject::MathObject):
  • kjs/MathObject.h:
  • kjs/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
  • kjs/NativeErrorConstructor.h:
  • kjs/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • kjs/NativeErrorPrototype.h:
  • kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • kjs/NumberConstructor.h:
  • kjs/NumberObject.cpp: (JSC::NumberObject::NumberObject): (JSC::constructNumber): (JSC::constructNumberFromImmediateNumber):
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • kjs/NumberPrototype.h:
  • kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::constructObject):
  • kjs/ObjectConstructor.h:
  • kjs/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
  • kjs/ObjectPrototype.h:
  • kjs/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • kjs/PrototypeFunction.h:
  • kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::constructRegExp):
  • kjs/RegExpConstructor.h:
  • kjs/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject):
  • kjs/RegExpObject.h:
  • kjs/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • kjs/RegExpPrototype.h:
  • kjs/Shell.cpp: (GlobalObject::GlobalObject):
  • kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): (JSC::constructWithStringConstructor):
  • kjs/StringConstructor.h:
  • kjs/StringObject.cpp: (JSC::StringObject::StringObject):
  • kjs/StringObject.h:
  • kjs/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
  • kjs/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • kjs/StringPrototype.h: Take and pass structures.

WebCore:

2008-09-20 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): Pass in a structure ID. Note that this makes a new structure every time -- we could optimize this slightly be caching and reusing a single one.
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod): Create a unique structure using getDOMStructure.
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createPrototype): Added createPrototype so getDOMStructure will work.
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): Initialize m_window to 0; needed in case garbage collection happens while creating the JSDOMWindow.
18:29 Changeset [36725] by mrowe@apple.com
  • 12 edits
    1 delete in trunk/WebCore

Roll out r36719 and attempted build fixes r36121 and r36722 due to massive build breakage.

17:52 Changeset [36724] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Added Radar link

17:49 Changeset [36723] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • svg/SVGTextContentElement.cpp: (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback): Changed to not include the first character in the extraCharsAvailable count.
17:42 Changeset [36722] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Mac build fix
  • WebCore.xcodeproj/project.pbxproj: Made DashArray.h a private header.
17:36 Changeset [36721] by mitz@apple.com
  • 1 add in trunk/WebCore/platform/graphics/DashArray.h

Added a file that was missing from r36719

16:56 Changeset [36720] by kevino@webkit.org
  • 2 edits in trunk

Add missing bug reference to ChangeLog.

16:46 Changeset [36719] by eric@webkit.org
  • 12 edits in trunk/WebCore

2008-09-20 Dirk Schulze <vbs85@gmx.de>

Reviewed by eseidel. Landed by eseidel.

Moved DashArray to the GraphicsContext.

  • GNUmakefile.am:
  • platform/graphics/DashArray.h: Added.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setLineDash):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setLineDash):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::applyStrokeStyleToContext):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/cg/CgSupport.cpp:
  • svg/graphics/cg/CgSupport.h:
16:39 Changeset [36718] by kevino@webkit.org
  • 4 edits in trunk

Reviewed by Dan Bernstein.

Fix two memory leaks.

15:31 Changeset [36717] by kevino@webkit.org
  • 11 edits in trunk

wx build fixes. Added/removed build sources, and nativeWindow->platformWidget updates.

15:21 Changeset [36716] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix the new Node Search button image to not be blurry.

  • page/inspector/Images/nodeSearchButtons.png:
14:53 Changeset [36715] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-09-20 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Cut down some of the inspector javascript -> InspectorController glue code
with two new macros. Also rearrange the exposed function list to be grouped
by implementation and to all explicitly use the WebCore namespace.

  • page/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable):
14:53 Changeset [36714] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit/mac

2008-09-20 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Revert r35688. We use a textured window on Leopard, which does not have the
square corners of the standard Aqua window on Tiger.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController window]): Add back the call to WKNSWindowMakeBottomCornersSquare.
14:30 Changeset [36713] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-09-20 Matt Lilek <webkit@mattlilek.com>

Reviewed by Tim Hatcher.

Fix regression from my previous patch where the breadcrumbs bar was not displayed.

  • page/inspector/inspector.css:
13:19 Changeset [36712] by zimmermann@webkit.org
  • 15 edits
    2 copies in trunk/WebCore

Reviewed by Eric.

Refactor HTMLImageLoader/SVGImageLoader code.
Move html/HTMLImageLoader.* to loader/ImageLoader.*

Let HTMLImageLoader & SVGImageLoader inherit from the new base class.
SVGImageLoader used to inherit from HTMLImageLoader which is awkward.

07:36 Changeset [36711] by darin@apple.com
  • 2 edits in trunk/WebKit/win

2008-09-20 Darin Adler <darin@apple.com>

  • fix build
  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::paintCustomScrollbar): Tweaked constant names to make this compile, but it may not be working correctly. Hyatt should do the real fix.
07:29 Changeset [36710] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2008-09-20 Darin Adler <darin@apple.com>

  • DumpRenderTree/mac/DumpRenderTree.mm: (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
07:24 Changeset [36709] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[qtwebkit] ScrollBar build fix after r36684.

BackButtonPart was split into Start and End Part
ForwardButtonPart was split into Start and End Part

07:24 Changeset [36708] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[qtwebkit] Make qt_instance.cpp compile.

Revision of 36675 introduced getDOMStructure to give unique
structure id's to C++ classes. Catch up. RuntimeObjectImp assigns
the the StructureID inside the c'tor, do the same in QtRuntimeObjectImp

07:24 Changeset [36707] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[svg] Change SVGLocatable to deal with a plain SVGElement

There is no requirement in the code that we have to have a
SVGStyledElement. Remove that artificial limitation and compile
with SVGElement.

07:23 Changeset [36706] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[svg] Use OwnPtr for the SVGExtensions

Use OwnPtr to avoid custom lifetime management.

Note: See TracTimeline for information about the timeline view.