Timeline


and

10/01/08:

23:44 Changeset [37184] by ggaren@apple.com
  • 54 edits
    1 copy in trunk

JavaScriptCore:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Preliminary step toward dynamic recompilation: Standardized and
simplified the parsing interface.


The main goal in this patch is to make it easy to ask for a duplicate
compilation, and get back a duplicate result -- same source URL, same
debugger / profiler ID, same toString behavior, etc.


The basic unit of compilation and evaluation is now SourceCode, which
encompasses a SourceProvider, a range in that provider, and a starting
line number.

A SourceProvider now encompasses a source URL, and *is* a source ID,
since a pointer is a unique identifier.

  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.


  • VM/CodeBlock.h: (JSC::EvalCodeCache::get): Provide a SourceCode to the Interpreter, since other APIs are no longer supported. (JSC::CodeBlock::CodeBlock): ASSERT something that used to be ASSERTed by our caller -- this is a better bottleneck.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Updated for the fact that FunctionBodyNode's parameters are no longer a WTF::Vector.
  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): ditto
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction): Provide a SourceCode to the Parser, since other APIs are no longer supported. Adopt FunctionBodyNode's new "finishParsing" API.
  • kjs/JSFunction.cpp: (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getParameterName): Updated for the fact that FunctionBodyNode's parameters are no longer a wtf::Vector.
  • kjs/JSFunction.h: Nixed some cruft.
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/Parser.cpp: (JSC::Parser::parse): Require a SourceCode argument, instead of a bunch of broken out parameters. Stop tracking sourceId as an integer, since we use the SourceProvider pointer for this now. Don't clamp the startingLineNumber, since SourceCode does that now.
  • kjs/Parser.h: (JSC::Parser::parse): Standardized the parsing interface to require a SourceCode.
  • kjs/Shell.cpp: (functionRun): (functionLoad): (prettyPrintScript): (runWithScripts): (runInteractive): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.
  • kjs/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::url): (JSC::SourceProvider::asId): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::UStringSourceProvider): Added new responsibilities described above.
  • kjs/SourceRange.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::toString): (JSC::SourceCode::provider): (JSC::SourceCode::firstLine): (JSC::SourceCode::data): (JSC::SourceCode::length): Added new responsibilities described above. Renamed SourceRange to SourceCode, based on review feedback. Added a makeSource function for convenience.
  • kjs/debugger.h: Provide a SourceCode to the client, since other APIs are no longer supported.
  • kjs/grammar.y: Provide startingLineNumber when creating a SourceCode.
  • kjs/debugger.h: Treat sourceId as intptr_t to avoid loss of precision on 64bit platforms.
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/interpreter.h: Require a SourceCode instead of broken out arguments.
  • kjs/lexer.cpp: (JSC::Lexer::setCode):
  • kjs/lexer.h: (JSC::Lexer::sourceRange): Fold together the SourceProvider and line number into a SourceCode. Fixed a bug where the Lexer would accidentally keep alive the last SourceProvider forever.
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::generateCode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::finishParsing): (JSC::FunctionBodyNode::create): (JSC::FunctionBodyNode::generateCode): (JSC::ProgramNode::generateCode): (JSC::FunctionBodyNode::paramString):
  • kjs/nodes.h: (JSC::ScopeNode::): (JSC::ScopeNode::sourceId): (JSC::FunctionBodyNode::): (JSC::FunctionBodyNode::parameterCount): (JSC::FuncExprNode::): (JSC::FuncDeclNode::): Store a SourceCode in all ScopeNodes, since SourceCode is now responsible for tracking URL, ID, etc. Streamlined some ad hoc FunctionBodyNode fixups into a "finishParsing" function, to help make clear what you need to do in order to finish parsing a FunctionBodyNode.
  • wtf/Vector.h: (WTF::::releaseBuffer): Don't ASSERT that releaseBuffer() is only called when buffer is not 0, since FunctionBodyNode is more than happy to get back a 0 buffer, and other functions like RefPtr::release() allow for 0, too.

JavaScriptGlue:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

  • JSRun.cpp: (JSRun::Evaluate): (JSRun::CheckSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.

WebCore:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.

  • ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::StringSourceProvider):

(WebCore::makeSource): Added a makeSource function for convenience.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]):
  • bridge/NP_jsobject.cpp: (_NPN_Evaluate):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jni_runtime.h: (JSC::Bindings::JavaString::operator UString): Replaced the explicit ustring() function with an implicit operator because this class already holds a UString::rep.
  • page/Console.cpp: (WebCore::retrieveLastCaller): (WebCore::Console::trace):
  • page/InspectorController.cpp: (WebCore::jsStringRef): (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource):
  • page/InspectorController.h:
  • page/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • page/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::sourceIdentifier): (WebCore::JavaScriptCallFrame::update):
  • page/JavaScriptDebugListener.h:
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::addBreakpoint): (WebCore::JavaScriptDebugServer::removeBreakpoint): (WebCore::JavaScriptDebugServer::hasBreakpoint): (WebCore::dispatchDidParseSource): (WebCore::dispatchFailedToParseSource): (WebCore::JavaScriptDebugServer::sourceParsed): (WebCore::JavaScriptDebugServer::callEvent): (WebCore::JavaScriptDebugServer::atStatement): (WebCore::JavaScriptDebugServer::returnEvent): (WebCore::JavaScriptDebugServer::exception): (WebCore::JavaScriptDebugServer::willExecuteProgram): (WebCore::JavaScriptDebugServer::didExecuteProgram): (WebCore::JavaScriptDebugServer::didReachBreakpoint):
  • page/JavaScriptDebugServer.h:
  • page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and sourceIdentifier to sourceID.

WebKit/mac:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.


We still treat sourceId as int in some cases because of DashCode. See
<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for
sourceId, not int.

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (toNSString): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram): (WebScriptDebugger::didReachBreakpoint):
23:08 Changeset [37183] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html

Broke a ref cycle by changing the m_svgFontFaceElement members of
CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
pointers. Also made sure that the @font-face rule added by
SVGFontFaceElement to the document's mapped element sheet is removed
when the font-face element is deleted or moved to another document.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h: (WebCore::CSSFontFaceSource::svgFontFaceElement):
  • css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::svgFontFaceElement): (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:
22:06 Changeset [37182] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21289: REGRESSION (r37160): Inspector crashes on load
<https://bugs.webkit.org/show_bug.cgi?id=21289>

The code in Arguments::mark() in r37160 was wrong. It marks indices in
d->registers, but that makes no sense (they are local variables, not
arguments). It should mark those indices in d->registerArray instead.

This patch also changes Arguments::copyRegisters() to use d->numParameters
instead of recomputing it.

  • kjs/Arguments.cpp: (JSC::Arguments::mark):
  • kjs/Arguments.h: (JSC::Arguments::copyRegisters):
22:02 Changeset [37181] by oliver@apple.com
  • 5 edits
    1 add
    1 delete in trunk/WebCore

Bug 20315: Memory leak with Canvas getImageData
<https://bugs.webkit.org/show_bug.cgi?id=20315>

Reviewed by Maciej Stachowiak

This wasn't a leak, the issue was that we were reporting the cost
of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
and we should have been reporting the cost when we create the
JSImageData wrapper.

21:54 Changeset [37180] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so that renderer destruction happens before the SVGMarkerElement is destroyed.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
19:48 Changeset [37179] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

18:47 Changeset [37178] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20669

  • css/makeprop.pl: Die if gperf fails.
18:43 Changeset [37177] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

  • loader/icon/IconDatabase.h: IconDatabase uses HashMap, so it needs to #include the header.
18:35 Changeset [37176] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
  • loader/Cache.cpp: (WebCore::Cache::remove): Disable pruning temporarily during CachedResource deletion.
18:30 Changeset [37175] by darin@apple.com
  • 8 edits in trunk/JavaScriptCore

2008-09-30 Darin Adler <darin@apple.com>

Reviewed by Eric Seidel.

Eliminate some unneeded uses of dynamicGlobalObject.

  • API/JSClassRef.cpp: (OpaqueJSClass::contextData): Changed to use a map in the global data instead of on the global object. Also fixed to use only a single hash table lookup.
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use lexicalGlobalObject rather than dynamicGlobalObject to get the object prototype.
  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use arrayVisitedElements set in global data rather than in the global object. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Don't initialize opaqueJSClassData, since it's no longer a pointer. (JSC::JSGlobalData::~JSGlobalData): We still need to delete all the values, but we don't need to delete the map since it's no longer a pointer.
  • kjs/JSGlobalData.h: Made opaqueJSClassData a map instead of a pointer to a map. Also added arrayVisitedElements.
  • kjs/JSGlobalObject.h: Removed arrayVisitedElements.
  • kjs/Shell.cpp: (functionRun): Use lexicalGlobalObject instead of dynamicGlobalObject. (functionLoad): Ditto.
18:05 Changeset [37174] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Fix Gtk repaint method finally. Should fix build bustage.

17:56 Changeset [37173] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update(). Make sure to include HostWindow.h

17:56 Changeset [37172] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update().

17:48 Changeset [37171] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
  • svg/SVGFontFaceElement.h: (WebCore::SVGFontFaceElement::associatedFontElement):
17:40 Changeset [37170] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Win bustage.

17:22 Changeset [37169] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h

Fix Gtk bustage.

17:21 Changeset [37168] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

17:20 Changeset [37167] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp

Fix Win bustage.

16:38 Changeset [37166] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculative Windows build fix.

  • kjs/grammar.y:
15:43 Changeset [37165] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

15:43 Changeset [37164] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

15:34 Changeset [37163] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Document the rounding behavior of the mapRect(IntRect) function in
AffineTransform.h.

  • platform/graphics/AffineTransform.h:
15:30 Changeset [37162] by hyatt@apple.com
  • 13 edits in trunk

WebCore:

2008-10-01 David Hyatt <hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively): (WebCore::FrameView::setScrollPosition):
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h: (WebCore::ScrollView::setProhibitsScrolling): (WebCore::ScrollView::prohibitsScrolling):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2008-10-01 David Hyatt <hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebView/WebView.mm: (-[WebView setProhibitsMainFrameScrolling:]):
15:24 Changeset [37161] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.

Reviewed by Geoff Garen.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
that we do during the loadRequestAsynchronously of the preflight request with a deref and
GC unprotect.

15:18 Changeset [37160] by cwzwarich@webkit.org
  • 19 edits in trunk

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 21123: using "arguments" in a function should not force creation of an activation object
<https://bugs.webkit.org/show_bug.cgi?id=21123>

Make the 'arguments' object not require a JSActivation. We store the
'arguments' object in the OptionalCalleeArguments call frame slot. We
need to be able to get the original 'arguments' object to tear it off
when returning from a function, but 'arguments' may be assigned to in a
number of ways.

Therefore, we use the OptionalCalleeArguments slot when we want to get
the original activation or we know that 'arguments' was not assigned a
different value. When 'arguments' may have been assigned a new value,
we use a new local variable that is initialized with 'arguments'. Since
a function parameter named 'arguments' may overwrite the value of
'arguments', we also need to be careful to look up 'arguments' in the
symbol table, so we get the parameter named 'arguments' instead of the
local variable that we have added for holding the 'arguments' object.

This is a 19.1% win on the V8 Raytrace benchmark using the SunSpider
harness, and a 20.7% win using the V8 harness. This amounts to a 6.5%
total speedup on the V8 benchmark suite using the V8 harness.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
  • VM/Machine.cpp: (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_init_arguments): (JSC::Machine::cti_op_ret_activation_arguments):
  • VM/Machine.h:
  • VM/RegisterFile.h: (JSC::RegisterFile::):
  • kjs/Arguments.cpp: (JSC::Arguments::mark): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put):
  • kjs/Arguments.h: (JSC::Arguments::setRegisters): (JSC::Arguments::init): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
  • kjs/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • kjs/grammar.y:
  • kjs/nodes.h: (JSC::ScopeNode::setUsesArguments):
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::orl_mr):

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/resources/arguments.js:
  • fast/js/resources/function-dot-arguments.js:
15:12 Changeset [37159] by hyatt@apple.com
  • 12 edits in trunk

2008-10-01 David Hyatt <hyatt@apple.com>

Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.

Reviewed by Tim Hatcher

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::setCanHaveScrollbars):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setCanHaveScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::canHaveScrollbars):
14:48 Changeset [37158] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

Fix Win bustage.

14:19 Changeset [37157] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix some CachedResource leaks seen on buildbot

The issue here was that emptying the cache was a no-op when it only
contained resources with no data. Changed to go after those
resources when the desired cache capacity is zero.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h: (WebCore::Cache::prune):
14:11 Changeset [37156] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::isOffscreen): (WebCore::ScrollView::platformIsOffscreen):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformIsOffscreen):
  • platform/qt/ScrollViewQt.cpp:
  • platform/wx/ScrollViewWx.cpp:
13:58 Changeset [37155] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make show/hide/setParentVisible cross-platform on ScrollView.

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::setParentVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
  • platform/ScrollView.h:
  • platform/win/ScrollViewWin.cpp:
13:41 Changeset [37154] by kmccullough@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • Added layout test fast/css/max-height-and-max-width.html
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • fast/css/max-height-and-max-width-expected.txt: Added.
  • fast/css/max-height-and-max-width.html: Added.
13:34 Changeset [37153] by hyatt@apple.com
  • 25 edits in trunk

WebCore:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::screenToWindow): (WebCore::EmptyChromeClient::windowToScreen):
  • page/Chrome.cpp: (WebCore::Chrome::screenToWindow): (WebCore::Chrome::windowToScreen):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::screenToWindow): (WebChromeClient::windowToScreen):

WebKit/qt:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowToScreen): (WebCore::ChromeClientQt::screenToWindow):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::windowToScreen): (WebChromeClient::screenToWindow):
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::windowToScreen): (WebCore::ChromeClientWx::screenToWindow):
  • WebKitSupport/ChromeClientWx.h:
13:31 Changeset [37152] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)

Test: fast/parser/residual-style-close-across-removed-block.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an assertion that turned out to be wrong in this case, and changed to terminate the algorithm at the first empty block.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
  • fast/parser/residual-style-close-across-removed-block-expected.txt: Added.
  • fast/parser/residual-style-close-across-removed-block.html: Added.
12:24 Changeset [37151] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.h

Fix Mac bustage. Make sure the setFrameRect method is moved outside the ifdef in the header.

12:23 Changeset [37150] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make setFrameRect on ScrollView cross-platform.

Reviewed by Sam Weinig

  • page/FrameView.h: (WebCore::FrameView::contentsResized):
  • platform/ScrollView.cpp: (WebCore::ScrollView::setFrameRect):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
12:17 Changeset [37149] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-10-01 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
to JSDOMWindow from JSDOMWindowBase.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::removeTimeout):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa):
  • page/DOMWindow.idl:
11:40 Changeset [37148] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Rubberstamped by Geoff .

Remove BreakpointCheckStatement because it's not used anymore.
No effect on sunspider or the jsc tests.

  • kjs/nodes.cpp:
  • kjs/nodes.h:
11:12 Changeset [37147] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Mac build fix
  • WebCore.base.exp:
10:51 Changeset [37146] by hyatt@apple.com
  • 25 edits in trunk

Make ScrollView::paint cross-platform.

10:33 Changeset [37145] by timothy@apple.com
  • 2 edits in trunk/WebCore

Prevent stealing focus from the search field when focusing a DOM node.

https://bugs.webkit.org/show_bug.cgi?id=21275

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged): Don't steal focus if the current focus element is the search field.
06:32 QtWebKitJournal edited by hausmann@webkit.org
(diff)
00:59 Changeset [37144] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Speculative fix for Gtk bustage.

00:55 Changeset [37143] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

00:27 Changeset [37142] by weinig@apple.com
  • 16 edits in trunk/WebCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.

Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Generate getting/setting of EventListeners.
  • Adding a new named EventListener now has the same process as adding any other DOM attribute. (Add a method with the same name in the c++ file).

(The EventListeners for MessagePort have been intentionally left custom so that we
can continue to experiment with making those EventListeners work in a frame-less world.)

  • bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
  • bindings/js/JSDOMWindowCustom.cpp: ditto.
  • bindings/js/JSEventTargetNodeCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener getter/setters
  • dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
  • dom/EventTargetNode.h: ditto.
  • dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
  • page/DOMWindow.cpp: Add getter/setters for named EventListener
  • page/DOMWindow.h: ditto.
  • page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • xml/XMLHttpRequest.idl: Remove custom attributes.
  • xml/XMLHttpRequestUpload.idl: ditto.

09/30/08:

23:57 Changeset [37141] by mrowe@apple.com
  • 1 edit in trunk/WebCore/loader/CachedResource.cpp

A-Z.

23:53 Changeset [37140] by mrowe@apple.com
  • 4 edits in trunk

Add a leak counter for CachedResources since we've had two recent leaks involving them.

Reviewed by Dan Bernstein.

23:25 Changeset [37139] by mitz@apple.com
  • 4 edits
    2 moves in trunk/WebCore

Reviewed by Dave Hyatt.

If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
the font name in memory.

  • WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to OpenTypeUtilities.*.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is used. (WebCore::FontCustomPlatformData::fontPlatformData): Added a code path for fonts loaded using AddFontMemResourceEx. (WebCore::createFontCustomPlatformData): Added a call to renameAndActivateFont() if TTLoadEmbeddedFont fails. If TTLoadEmbeddedFont succeeds, set the font name to the null string, as fontPlatformData() will retrieve the name from the font reference.
  • platform/graphics/win/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a font name member.
  • platform/graphics/win/GetEOTHeader.cpp: Renamed.
  • platform/graphics/win/GetEOTHeader.h: Renamed.
  • platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp. (WebCore::BigEndianUShort::BigEndianUShort): Added a constructor. (WebCore::BigEndianULong::BigEndianULong): Ditto. (WebCore::renameAndActivateFont): Added. Creates an in-memory copy of the font data and modifies it to have the given name, then activates it using AddFontMemResourceEx.
  • platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
23:16 Changeset [37138] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Improve performance of CTI on windows.

Reviewed by Geoff Garen

Currently on platforms where the compiler doesn't allow us to safely
index relative to the address of a parameter we need to actually
provide a pointer to CTI runtime call arguments. This patch improves
performance in this case by making the CTI logic for restoring this
parameter much less conservative by only resetting it before we actually
make a call, rather than between each and every SF bytecode we generate
code for.

This results in a 3.6% on the v8 benchmark when compiled with MSVC.

23:09 Changeset [37137] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix many leaks seen on fast/backgrounds/svg-as-mask.html.

Reviewed by Dan Bernstein.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
with calls to removeClient when we're being destroyed.

22:45 Changeset [37136] by eric.carlson@apple.com
  • 4 edits
    4 adds in trunk

2008-09-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21243

Fix loopstart and loopend default values.

Tests: media/loopend-limits.html

media/loopstart-limits.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value (WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value

2008-09-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21243

Test default loopstart and loopend values.

  • media/loopend-limits-expected.txt: Added.
  • media/loopend-limits.html: Added.
  • media/loopstart-limits-expected.txt: Added.
  • media/loopstart-limits.html: Added.
  • media/video-test.js:
22:29 Changeset [37135] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.

JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
torn down before we exit.

Rubber-stamped by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(main):

22:04 Changeset [37134] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.

21:43 Changeset [37133] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix HTMLViewSourceDocument leaks by breaking a ref cycle which was fixed in r17249 and re-introduced in r31435.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
19:57 Changeset [37132] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

  • track uses of "this", "with" and "catch" in the parser


Knowing this up front will be useful for future optimizations.


Perf and correctness remain the same.


  • kjs/NodeInfo.h:
  • kjs/grammar.y:
18:05 Changeset [37131] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Remove the NPDrawingModelOpenGL entirely. To my knowledge no shipping plug-in ever used it, and no other browser engine
ever supported it.


  • Plugins/WebBaseNetscapePluginView.h: Removed AGL.h import and OpenGL related ivars.
  • Plugins/WebBaseNetscapePluginView.mm: Removed soft linking for OpenGL and AGL frameworks. Also removed many methods AGL/CGL support methods that are no longer necessary. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed NPDrawingModelOpenGL related code. (-[WebBaseNetscapePluginView restorePortState:]): Ditto. (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Ditto. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Ditto. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto. (-[WebBaseNetscapePluginView stop]): Ditto. (-[WebBaseNetscapePluginView dealloc]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Ditto. (-[WebBaseNetscapePluginView invalidateRegion:]): Ditto. (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins WebKit does not support NPDrawingModelOpenGL. (-[WebBaseNetscapePluginView setVariable:value:]): Removed NPDrawingModelOpenGL related code. (-[WebBaseNetscapePluginView _viewHasMoved]): Ditto.
18:00 Changeset [37130] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2008-09-30 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Remove console output that can cause test to fail on slow
machines.

  • animations/transition-and-animation-2-expected.txt:
  • animations/transition-and-animation-2.html:
17:43 Changeset [37129] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitTools

2008-09-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

Don't run pixel comparison for text-only tests.
https://bugs.webkit.org/show_bug.cgi?id=21124

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • Scripts/run-webkit-tests:
17:39 Changeset [37128] by weinig@apple.com
  • 24 edits in trunk/WebCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

More for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Make EventListener getter/setters names in c++ files match those in JS (ie. onLoadListener -> onload).
  • Add standard way to access the frame associated with the EventTarget for EventListener lookup.
  • Autogenerate dispatchEvent, it wasn't doing anything custom.
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener): (WebCore::JSDOMApplicationCache::setOnchecking): (WebCore::JSDOMApplicationCache::onchecking): (WebCore::JSDOMApplicationCache::setOnerror): (WebCore::JSDOMApplicationCache::onerror): (WebCore::JSDOMApplicationCache::setOnnoupdate): (WebCore::JSDOMApplicationCache::onnoupdate): (WebCore::JSDOMApplicationCache::setOndownloading): (WebCore::JSDOMApplicationCache::ondownloading): (WebCore::JSDOMApplicationCache::setOnprogress): (WebCore::JSDOMApplicationCache::onprogress): (WebCore::JSDOMApplicationCache::setOnupdateready): (WebCore::JSDOMApplicationCache::onupdateready): (WebCore::JSDOMApplicationCache::setOncached): (WebCore::JSDOMApplicationCache::oncached):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::setListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::onmessage): (WebCore::JSMessagePort::setOnclose): (WebCore::JSMessagePort::onclose):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::onreadystatechange): (WebCore::JSXMLHttpRequest::setOnreadystatechange): (WebCore::JSXMLHttpRequest::onabort): (WebCore::JSXMLHttpRequest::setOnabort): (WebCore::JSXMLHttpRequest::onerror): (WebCore::JSXMLHttpRequest::setOnerror): (WebCore::JSXMLHttpRequest::onload): (WebCore::JSXMLHttpRequest::setOnload): (WebCore::JSXMLHttpRequest::onloadstart): (WebCore::JSXMLHttpRequest::setOnloadstart): (WebCore::JSXMLHttpRequest::onprogress): (WebCore::JSXMLHttpRequest::setOnprogress): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::onabort): (WebCore::JSXMLHttpRequestUpload::setOnabort): (WebCore::JSXMLHttpRequestUpload::onerror): (WebCore::JSXMLHttpRequestUpload::setOnerror): (WebCore::JSXMLHttpRequestUpload::onload): (WebCore::JSXMLHttpRequestUpload::setOnload): (WebCore::JSXMLHttpRequestUpload::onloadstart): (WebCore::JSXMLHttpRequestUpload::setOnloadstart): (WebCore::JSXMLHttpRequestUpload::onprogress): (WebCore::JSXMLHttpRequestUpload::setOnprogress): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::associatedFrame):
  • dom/EventTargetNode.h:
  • dom/EventTargetNode.idl:
  • dom/MessagePort.cpp: (WebCore::MessagePort::associatedFrame):
  • dom/MessagePort.h: (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::onmessage): (WebCore::MessagePort::setOnclose): (WebCore::MessagePort::onclose):
  • dom/MessagePort.idl:
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::associatedFrame):
  • loader/appcache/DOMApplicationCache.idl:
  • svg/EventTargetSVGElementInstance.cpp: (WebCore::EventTargetSVGElementInstance::associatedFrame): (WebCore::EventTargetSVGElementInstance::addEventListener): (WebCore::EventTargetSVGElementInstance::removeEventListener): (WebCore::EventTargetSVGElementInstance::dispatchEvent):
  • svg/EventTargetSVGElementInstance.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::associatedFrame):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setOnreadystatechange): (WebCore::XMLHttpRequest::onreadystatechange): (WebCore::XMLHttpRequest::setOnabort): (WebCore::XMLHttpRequest::onabort): (WebCore::XMLHttpRequest::setOnerror): (WebCore::XMLHttpRequest::onerror): (WebCore::XMLHttpRequest::setOnload): (WebCore::XMLHttpRequest::onload): (WebCore::XMLHttpRequest::setOnloadstart): (WebCore::XMLHttpRequest::onloadstart): (WebCore::XMLHttpRequest::setOnprogress): (WebCore::XMLHttpRequest::onprogress):
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::associatedFrame):
  • xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::setOnabort): (WebCore::XMLHttpRequestUpload::onabort): (WebCore::XMLHttpRequestUpload::setOnerror): (WebCore::XMLHttpRequestUpload::onerror): (WebCore::XMLHttpRequestUpload::setOnload): (WebCore::XMLHttpRequestUpload::onload): (WebCore::XMLHttpRequestUpload::setOnloadstart): (WebCore::XMLHttpRequestUpload::onloadstart): (WebCore::XMLHttpRequestUpload::setOnprogress): (WebCore::XMLHttpRequestUpload::onprogress):
  • xml/XMLHttpRequestUpload.idl:
17:38 Changeset [37127] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-09-30 Darin Adler <darin@apple.com>

  • roll out assertion breaking regression tests
  • platform/ScrollView.cpp: (WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion that fires in regression tests. Hyatt can add it back later. The assertion fires in the regression test because of layout that triggers repaint occuring during the process of removing a frame.
16:58 Changeset [37126] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add WebKitAvailability macros for JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError,
and JSObjectMakeRegExp

  • API/JSObjectRef.h:
16:46 Changeset [37125] by darin@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-30 Darin Adler <darin@apple.com>

Reviewed by Geoff Garen.

Replaced the m_prev field of ExecState with a bit in the
call frame pointer to indicate "host" call frames.

  • VM/Machine.cpp: (JSC::makeHostCallFramePointer): Added. Sets low bit. (JSC::isHostCallFrame): Added. Checks low bit. (JSC::stripHostCallFrameBit): Added. Clears low bit. (JSC::Machine::unwindCallFrame): Replaced null check that was formerly used to detect host call frames with an isHostCallFrame check. (JSC::Machine::execute): Pass in a host call frame pointer rather than always passing 0 when starting execution from the host. This allows us to follow the entire call frame pointer chain when desired, or to stop at the host calls when that's desired. (JSC::Machine::privateExecute): Replaced null check that was formerly used to detect host call frames with an isHostCallFrame check. (JSC::Machine::retrieveCaller): Ditto. (JSC::Machine::retrieveLastCaller): Ditto. (JSC::Machine::callFrame): Removed the code to walk up m_prev pointers and replaced it with code that uses the caller pointer and uses the stripHostCallFrameBit function.
  • kjs/ExecState.cpp: Removed m_prev.
  • kjs/ExecState.h: Ditto.
16:24 Changeset [37124] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

16:21 Changeset [37123] by adele@apple.com
  • 19 edits
    8 adds in trunk

WebCore:

2008-09-30 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
<rdar://problem/6222134> add a way to set color for input placeholder text

Test: fast/forms/placeholder-pseudo-style.html

This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
input elements when they are displaying the placeholder text.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
  • css/html4.css: Add rule to make placeholder text default to darkGray.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible. (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility. (WebCore::HTMLInputElement::dispatchBlurEvent): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): ditto. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state. This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the renderer will just ask the node if it should draw the placeholder.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color, just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast. If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme. (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none". This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which is called directly from updateFromElement. updateFromElement will immediately update the text displayed. (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed. (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-09-30 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Tests for https://bugs.webkit.org/show_bug.cgi?id=21227
<rdar://problem/6222134> add a way to set color for input placeholder text

  • fast/forms/password-placeholder-text-security.html: Added.
  • fast/forms/placeholder-pseudo-style.html: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: Added.

Updated results. The placeholder color is now reflected on the RenderTextControl, not just on an inner element.

  • platform/mac/fast/forms/input-disabled-color-expected.checksum:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-expected.png:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
16:19 Changeset [37122] by bdakin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-09-30 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
by failed allocation due to invalid counter/attr
and corresponding: <rdar://problem/6152371>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent): The spec indicates that only identifiers should be accepted here.

LayoutTests:

2008-09-30 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
by failed allocation due to invalid counter/attr
and corresponding: <rdar://problem/6152371>

  • fast/css/counters/counter-number-input-expected.txt: Added.
  • fast/css/counters/counter-number-input.html: Added.
15:33 Changeset [37121] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

Bug 21255: console.profileEnd() without a console.profile() crashes the
web inspector

  • page/Console.cpp: (WebCore::Console::profileEnd):
15:31 Changeset [37120] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21252: calling console.profile() with a title that is 2 chars or
shorter does not linkify it

  • Previously we tried to not linkify very short URLs but since profile titles can be any length this is not always true.
  • page/inspector/inspector.js:
15:30 Changeset [37119] by mrowe@apple.com
  • 20 edits in tags/Safari-6528.4.1/WebCore/platform

Remove bogus executable bit from some source files.

15:28 Changeset [37118] by mrowe@apple.com
  • 20 edits in trunk/WebCore/platform

Remove bogus executable bit from some source files.

15:17 Changeset [37117] by cwzwarich@webkit.org
  • 7 edits
    3 adds in trunk

2008-09-30 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move all detection of 'arguments' in a lexical scope to the parser, in
preparation for fixing

Bug 21123: using "arguments" in a function should not force creation of an activation object
<https://bugs.webkit.org/show_bug.cgi?id=21123>

JavaScriptCore:

  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
  • kjs/NodeInfo.h:
  • kjs/grammar.y:

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/function-dot-arguments-expected.txt: Added.
  • fast/js/function-dot-arguments.html: Added.
  • fast/js/resources/arguments.js:
  • fast/js/resources/function-dot-arguments.js: Added.
14:46 Changeset [37116] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-30 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

  • kjs/Shell.cpp: (runWithScripts): Fixed indentation.
14:34 Changeset [37115] by timothy@apple.com
  • 67 edits in trunk/WebCore/page/inspector/Images

Add the image/png mime-type to the Web Inspector images to make Mark and Dan happy.

14:31 Changeset [37114] by hyatt@apple.com
  • 2 edits in trunk/WebKit

Tweak the Gtk/Qt ChromeClient methods structurally to make sure immediate displays/flushes can happen even if the content doesn't change.

14:30 Changeset [37113] by hyatt@apple.com
  • 9 edits in trunk/WebCore

Eliminate the ScrollView update() method.

14:04 Changeset [37112] by mrowe@apple.com
  • 11 edits
    2 deletes in trunk

Roll out r37060 as it introduced many, many leaks.

13:57 Changeset [37111] by timothy@apple.com
  • 3 edits in trunk/WebCore

Focus the DOM tree in the Web Inspector when a node is inspected.
So when the search field has focus, the focus moves to the tree,
allowing the arrow keys work. This can happen when using the new
find in page feature.

https://bugs.webkit.org/show_bug.cgi?id=21251

Reviewed by Geoff Garen.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Set currentFocusElement to the main-panels element if the panel is visible. (WebInspector.ElementsPanel.prototype.updateBreadcrumb): Remove a set of currentFocusElement since this moved.
  • page/inspector/inspector.js: (WebInspector.set currentFocusElement): Always focus the element. This ensures that when focus changes in the page and we don't catch it, we will still focus the elements even if we think it was already focused.
13:57 Changeset [37110] by timothy@apple.com
  • 8 edits in trunk/WebCore

Make the Web Inspector's toolbar icons darker when the mouse is
pressed on them. This matches the standard NSToolbar look.

https://bugs.webkit.org/show_bug.cgi?id=21249
rdar://problem/6033752

Reviewed by Adam Roben.

  • page/inspector/Images/databasesIcon.png:
  • page/inspector/Images/elementsIcon.png:
  • page/inspector/Images/profilesIcon.png:
  • page/inspector/Images/resourcesIcon.png:
  • page/inspector/Images/scriptsIcon.png:
  • page/inspector/Panel.js:
  • page/inspector/inspector.css:
13:56 Changeset [37109] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix qt bustage.

13:27 Changeset [37108] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.4.1/JavaScriptCore/JavaScriptCore.exp

Build fix.

13:27 Changeset [37107] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Build fix.

13:26 Changeset [37106] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21139: Profiler log message is wrong

  • Correctly fix =( Don't call _format twice.
  • page/Page.h:
  • page/inspector/Console.js:
  • page/inspector/ProfilesPanel.js:
  • page/inspector/inspector.js:
13:09 Changeset [37105] by hyatt@apple.com
  • 32 edits in trunk

Make ScrollView's updateContents method cross-platform.

12:42 Changeset [37104] by mrowe@apple.com
  • 3 edits in tags/Safari-6528.4.1/JavaScriptCore

Merge r37103.

12:38 Changeset [37103] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix.

Move InternalFunction::classInfo implementation into the .cpp file to
prevent the vtable for InternalFunction being generated as a weak symbol.
Has no effect on SunSpider.

Rubber-stamped by Sam Weinig.

  • kjs/InternalFunction.cpp:

(JSC::InternalFunction::classInfo):

  • kjs/InternalFunction.h:
12:29 Changeset [37102] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-09-30 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe and Adam Roben.

No need to use pointers to store C++ objects as pointers in WebViewPrivate, we can just
store them directly.


  • Configurations/Base.xcconfig: Set GCC_OBJC_CALL_CXX_CDTORS to YES.


  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView WebCore::_userAgentForURL:WebCore::]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:05 Changeset [37101] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.4.1

Versioning.

11:02 Changeset [37100] by mrowe@apple.com
  • 6 edits
    2 deletes in tags/Safari-6528.4.1

Merge r36902.

11:00 Changeset [37099] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4.1

New tag.

10:58 Changeset [37098] by ap@webkit.org
  • 6 edits in trunk/WebCore

Non-Mac build fixes.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • webcore-base.bkl: Added DOMProtect.{cpp,h}.
10:40 Changeset [37097] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
10:05 Changeset [37096] by jchaffraix@webkit.org
  • 11 edits in trunk/WebCore

2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

  • Removed "cppNamespace" global parameter and hard-coded "WebCore" as it is the only namespace used.
  • Removed "generateFactory" and "generateWrapperFactory" parameters and re-introduced the command line options.
  • Cleaned up the output of make_names.pl (removed unneeded new line).
  • DerivedSources.make: Added factories command line options.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto and removed some arguments that were migrated to the .in files.
  • dom/make_names.pl: Clean up (see above).
  • html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory" and "generateWrapperFactory" occurences.
  • html/HTMLTagNames.in: Ditto.
  • svg/svgattrs.in: Ditto.
  • svg/svgtags.in: Ditto.
  • svg/xlinkattrs.in: Ditto.
  • xml/xmlattrs.in: Ditto.
09:19 Changeset [37095] by cfleizach@apple.com
  • 5 edits
    2 adds in trunk

<rdar://problem/6255456> AX: <file> input button shouldn't have children exposed

08:52 Changeset [37094] by ap@webkit.org
  • 7 edits
    6 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21213
MessagePort crash when GC collects an object with a pending close event

Test: fast/events/message-channel-gc-2.html

fast/events/message-channel-listener-circular-ownership.html

  • bindings/DOMProtect.cpp: Added. (WebCore::gcProtectDOMObject): (WebCore::gcUnprotectDOMObject):
  • bindings/DOMProtect.h: Added. Added an abstraction for GC protection to avoid the need to call JS bindings code from DOM objects directly.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::queueCloseEvent): GC protect MessagePort wrapper while there is a pending close event. This may be necessary for message events, too, but that case is not a crasher, and actually behaves to the letter of the current HTML5 text, so I'll consider it later.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::dropProtection): Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose): Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not from XMLHttpRequest.
07:17 Changeset [37093] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • DerivedSources.cpp: Add JSEventTargetNode.cpp.
00:42 Changeset [37092] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix gtk qt bustage.

00:10 Changeset [37091] by cwzwarich@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2008-09-30 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Add the performance improvement to the ChangeLog entry for r37050.

  • ChangeLog
00:01 Changeset [37090] by weinig@apple.com
  • 12 edits
    4 adds
    3 deletes in trunk/WebCore

2008-09-29 Sam Weinig <sam@webkit.org>

Reviewed by Tim Hatcher.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Generate EventTargetNode.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventTarget.cpp: Added. (WebCore::toJS):
  • bindings/js/JSEventTarget.h: Added.
  • bindings/js/JSEventTargetBase.cpp: Removed.
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSEventTargetNode.cpp: Removed.
  • bindings/js/JSEventTargetNode.h: Removed.
  • bindings/js/JSEventTargetNodeCustom.cpp: Added. (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener): (WebCore::JSEventTargetNode::dispatchEvent): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNode::pushEventHandlerScope):
  • bindings/js/JSEventTargetSVGElementInstance.cpp: (WebCore::): (WebCore::JSEventTargetSVGElementInstancePrototype::self): (WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot): (jsEventTargetAddEventListener): (jsEventTargetRemoveEventListener): (jsEventTargetDispatchEvent):
  • bindings/js/JSEventTargetSVGElementInstance.h: (WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype): (WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTargetNode.idl: Added.

09/29/08:

18:31 Changeset [37089] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.



It's pretty common in real-world code (and on some of the v8
benchmarks) to append a number to a string, so I made this one of
the fast cases, and also added support to UString to do it
directly without allocating a temporary UString.


~1% speedup on v8 benchmark.

  • VM/Machine.cpp: (JSC::jsAddSlowCase): Make this NEVER_INLINE because somehow otherwise the change is a regression. (JSC::jsAdd): Handle number + string special case. (JSC::Machine::cti_op_add): Integrate much of the logic of jsAdd to avoid exception check in the str + str, num + num and str + num cases.
  • kjs/ustring.cpp: (JSC::expandedSize): Make this a non-member function, since it needs to be called in non-member functions but not outside this file. (JSC::expandCapacity): Ditto. (JSC::UString::expandCapacity): Call the non-member version. (JSC::createRep): Helper to make a rep from a char*. (JSC::UString::UString): Use above helper. (JSC::concatenate): Guts of concatenating constructor for cases where first item is a UString::Rep, and second is a UChar* and length, or a char*. (JSC::UString::append): Implement for cases where first item is a UString::Rep, and second is an int or double. Sadly duplicates logic of UString::from(int) and UString::from(double).
  • kjs/ustring.h:
18:14 Changeset [37088] by darin@apple.com
  • 10 edits in trunk

JavaScriptCore:

2008-09-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • JavaScriptCore.exp: Updated since JSGlobalObject::init no longer takes a parameter.
  • VM/Machine.cpp: (JSC::Machine::execute): Removed m_registerFile argument for ExecState constructors.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue argument for ExecState constructor.
  • kjs/ExecState.cpp: (JSC::ExecState::ExecState): Removed globalThisValue and registerFile arguments to constructors.
  • kjs/ExecState.h: Removed m_globalThisValue and m_registerFile data members.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Removed globalThisValue argument for ExecState constructor.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter for the init function.

WebCore:

2008-09-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument for base class constructor.
18:03 Changeset [37087] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Rubber-stamped by Cameron Zwarich.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21225
Machine::retrieveLastCaller should check for a NULL codeBlock


In order to crash, you would need to call retrieveCaller in a situation
where you had two host call frames in a row in the register file. I
don't know how to make that happen, or if it's even possible, so I don't
have a test case -- but better safe than sorry!

  • VM/Machine.cpp: (JSC::Machine::retrieveLastCaller):
17:46 Changeset [37086] by ggaren@apple.com
  • 13 edits
    2 copies
    6 adds in trunk

JavaScriptCore:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Store the callee ScopeChain, not the caller ScopeChain, in the call frame
header. Nix the "scopeChain" local variable and ExecState::m_scopeChain, and
access the callee ScopeChain through the call frame header instead.

Profit: call + return are simpler, because they don't have to update the
"scopeChain" local variable, or ExecState::m_scopeChain.


Because CTI keeps "r" in a register, reading the callee ScopeChain relative
to "r" can be very fast, in any cases we care to optimize.

0% speedup on empty function call benchmark. (5.5% speedup in bytecode.)
0% speedup on SunSpider. (7.5% speedup on controlflow-recursive.)
2% speedup on SunSpider --v8.
2% speedup on v8 benchmark.

  • VM/CTI.cpp: Changed scope chain access to read the scope chain from the call frame header. Sped up op_ret by changing it not to fuss with the "scopeChain" local variable or ExecState::m_scopeChain.
  • VM/CTI.h: Updated CTI trampolines not to take a ScopeChainNode* argument, since that's stored in the call frame header now.
  • VM/Machine.cpp: Access "scopeChain" and "codeBlock" through new helper functions that read from the call frame header. Updated functions operating on ExecState::m_callFrame to account for / take advantage of the fact that Exec:m_callFrame is now never NULL.


Fixed a bug in op_construct, where it would use the caller's default
object prototype, rather than the callee's, when constructing a new object.

  • VM/Machine.h: Made some helper functions available. Removed ScopeChainNode* arguments to a lot of functions, since the ScopeChainNode* is now stored in the call frame header.
  • VM/RegisterFile.h: Renamed "CallerScopeChain" to "ScopeChain", since that's what it is now.
  • kjs/DebuggerCallFrame.cpp: Updated for change to ExecState signature.
  • kjs/ExecState.cpp:
  • kjs/ExecState.h: Nixed ExecState::m_callFrame, along with the unused isGlobalObject function.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObject.h: Gave the global object a fake call frame in which to store the global scope chain, since our code now assumes that it can always read the scope chain out of the ExecState's call frame.

JavaScriptGlue:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Forwarding headers to fix the build.

  • ForwardingHeaders/kjs/CTI.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/kjs/ustring.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/masm: Added.
  • ForwardingHeaders/masm/X86Assembler.h: Added.
  • ForwardingHeaders/profiler: Added.
  • ForwardingHeaders/profiler/Profiler.h: Added.

LayoutTests:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Test case for which prototype is used when calling "new" across windows.

  • fast/js/construct-global-object-expected.txt: Added.
  • fast/js/construct-global-object.html: Added.
17:42 Changeset [37085] by hyatt@apple.com
  • 4 edits
    1 add in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
(Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.h:
  • platform/HostWindow.h: Added. (WebCore::HostWindow::HostWindow): (WebCore::HostWindow::~HostWindow):
17:17 Changeset [37084] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
16:42 Changeset [37083] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added. (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being unloaded, to avoid calling uxtheme.dll functions after that library has been unloaded.
  • rendering/RenderThemeWin.h:

WebKit/win:

Reviewed by Adam Roben.

  • WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • WebKitDLL.cpp: (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit is being unloaded.
16:10 Changeset [37082] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas

15:50 Changeset [37081] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

15:49 Changeset [37080] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4

New tag.

15:34 Changeset [37079] by timothy@apple.com
  • 6 edits in trunk/WebCore

Makes the node highlight always show up when hovering a node in
the Web Inspector now that the highlight does not scroll to reveal
the node. Also adds a hover effect in the inspector when hovering
causes a highlight in the page. This ties the user hovering action
to the highlight so it is clear what causes the highlight to appear.

Also the highlight now temporarily shows up for 2 seconds after
selecting a node in the DOM tree. So arrowing around in the tree
will show the node on the page, providing feedback to the user.

Plus fixes an issue where quickly moving away from hovering
a node would keep showing the page highlight. This was happening
in breadcrumbs and the DOM tree.

https://bugs.webkit.org/show_bug.cgi?id=21220

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.Console.prototype._mouseOverNode): Added. Used for hovering DOM nodes in the console. (WebInspector.Console.prototype._mouseOutOfNode): Ditto. (WebInspector.Console.prototype._formatnode): Use the new event listeners and add a class name to the anchor element.
  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add new event listeners to the crumbs element to do the node hovering highlight. (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs): (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • page/inspector/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): Show the node hishlight for 2 seconds then restore the highlight to the current hovered node. (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the hovered node and set the hovered state on the tree element. (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the hovered node to null and removed the hovered state from the previous hovered tree element. (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds the hovered class to the list item. (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
  • page/inspector/inspector.css:
  • page/inspector/inspector.js: (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon based on the showingDOMNodeHighlight property of 50ms or 500ms. This causes the highlight to change sooner if there is one already showing and appear later if there isn't one showing. This is like tooltips, hovering a node for 500ms will cause highlight then mousing between nodes will keep the highlight and change to the new node. (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and always reset the timeout so continuous mousing does not keep flasshing the highlight on the screen. (WebInspector._updateHoverHighlight): Removed the alt key check and added the showingDOMNodeHighlight property. (WebInspector.documentKeyDown): Removed the alt key check. (WebInspector.documentKeyUp): Ditto. (WebInspector.reset): Clear the hoveredDOMNode.
15:04 Changeset [37078] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2008-09-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Fix RenderStyle leak in animation code, and assert that
keyframe resolution in CSSStyleSelector is not going to clobber
m_style.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation):
14:31 Changeset [37077] by simon.fraser@apple.com
  • 14 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
Rewrite keyframe resolution to be like styleForElement()

Test: animations/lineheight-animation.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::keyframeStylesForAnimation): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::mapAnimationName):
  • css/CSSStyleSelector.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation): (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::hasAnimationForProperty): (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::overrideAnimations): (WebCore::KeyframeAnimation::resumeOverriddenAnimations): (WebCore::KeyframeAnimation::affectsProperty): (WebCore::KeyframeAnimation::validateTransformFunctionList):
  • page/animation/KeyframeAnimation.h:
  • rendering/style/Animation.cpp: (WebCore::Animation::animationsMatch):
  • rendering/style/Animation.h:
  • rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::~KeyframeList): (WebCore::KeyframeList::clear): (WebCore::KeyframeList::insert):
  • rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): (WebCore::KeyframeList::KeyframeList): (WebCore::KeyframeList::operator!=): (WebCore::KeyframeList::animationName): (WebCore::KeyframeList::addProperty): (WebCore::KeyframeList::containsProperty): (WebCore::KeyframeList::beginProperties): (WebCore::KeyframeList::endProperties): (WebCore::KeyframeList::isEmpty): (WebCore::KeyframeList::size): (WebCore::KeyframeList::beginKeyframes): (WebCore::KeyframeList::endKeyframes):
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
14:24 Changeset [37076] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel

Clean up fix in PropertyWrapperGetter::equals
https://bugs.webkit.org/show_bug.cgi?id=21011

Test: transitions/override-transition-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperGetter::equals):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
14:21 Changeset [37075] by simon.fraser@apple.com
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=21001
Starting transition after animation, when animation
is finished, transition is wrong.

Test: animations/transition-and-animation-2.html

  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::resetTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::reset):
  • page/animation/ImplicitAnimation.h:
14:18 Changeset [37074] by simon.fraser@apple.com
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=20921
-webkit-animation-timing-function: inside of keyframes is ignored

Test: animations/keyframe-timing-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress):
  • page/animation/AnimationBase.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
14:09 Changeset [37073] by simon.fraser@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler

Testcase for crash when parsing keyframes from an @imported
CSS file
https://bugs.webkit.org/show_bug.cgi?id=20855

  • animations/import-crash-expected.txt: Added.
  • animations/import-crash.html: Added.
  • animations/import-expected.txt: Added.
  • animations/import.html: Added.
  • animations/resources/keyframes.css: Added.
14:04 Changeset [37072] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 3

13:57 Changeset [37071] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 2

13:52 Changeset [37070] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

13:09 Changeset [37069] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21218

Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
It's silly that the code was this fragile, but for now just put the check back in.

Reviewed by Dan Bernstein

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollbarModes):
12:49 Changeset [37068] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-09-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Sam Weinig.

Remove the isActivationObject() virtual method on JSObject and use
StructureID information instead. This should be slightly faster, but
isActivationObject() is only used in assertions and unwinding the stack
for exceptions.

  • VM/Machine.cpp: (JSC::depth): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_ret_activation):
  • kjs/JSActivation.cpp:
  • kjs/JSActivation.h:
  • kjs/JSObject.h:
12:46 Changeset [37067] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21216

Make setScrollPosition and scroll() cross-platform.

Reviewed by Anders

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scroll):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
12:09 Changeset [37066] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-09-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver.

Bug 21139: Profiler log message is wrong

  • Because _format was called twice the number in the log was incremented too many times, but we were passing it around in the link the whole time
  • page/inspector/ProfilesPanel.js:
  • page/inspector/inspector.js:
12:09 Changeset [37065] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-09-29 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Autogenerate EventListeners, addEventListener and removeEventListener
for JSDOMWindow.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::onwebkitanimationstart): (WebCore::JSDOMWindow::setOnwebkitanimationstart): (WebCore::JSDOMWindow::onwebkitanimationiteration): (WebCore::JSDOMWindow::setOnwebkitanimationiteration): (WebCore::JSDOMWindow::onwebkitanimationend): (WebCore::JSDOMWindow::setOnwebkitanimationend): (WebCore::JSDOMWindow::onwebkittransitionend): (WebCore::JSDOMWindow::setOnwebkittransitionend): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::JSDOMWindow::setListener): (WebCore::JSDOMWindow::getListener):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
09:08 Changeset [37064] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-29 Gunnar Sletta <gunnar@trolltech.com>

Reviewed by Simon

Compile on windows using MSVC 2005

For the PCH We need to define _WIN32_WINNT and include windows.h early on,
otherwise we'll miss several functions.

09:03 Changeset [37063] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed and tweaked by Darin Adler.

Fix build for non-all-in-one platforms.

  • kjs/StringPrototype.cpp: Added missing ASCIICType.h include.
07:55 Changeset [37062] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Bradley T. Hughes <bradley.hughes@nokia.com>

Reviewed by Simon.

Fix compilation with icpc

05:47 Changeset [37061] by hausmann@webkit.org
  • 139 edits in trunk

2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon.

Changed copyright from Trolltech ASA to Nokia.

Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.

04:48 Changeset [37060] by jchaffraix@webkit.org
  • 11 edits
    2 adds in trunk

WebCore:

2008-09-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 5727: We want to evaluate scripts in viewless documents
https://bugs.webkit.org/show_bug.cgi?id=5727

Add the posibility to evaluate script or fetch resources on viewless
document using the EmptyClient workaround.

Test: fast/loader/viewless-document.html

  • dom/Document.h: (WebCore::Document::setFrame): Method to set the Document's Frame, added a warning that it should be used under special circumstances.
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::requestScript): If the frame is empty (viewless document), get a dummy Frame to be able to evalute the script. (WebCore::ScriptElementData::evaluateScript): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Take a bool to toogle empty Document creation.

(WebCore::FrameLoader::fakeLoad): Fake remote resource load.

(WebCore::FrameLoader::createDummyFrame):

  • loader/FrameLoader.h:
  • page/Frame.cpp: (WebCore::Frame::isDummyFrame): (WebCore::Frame::setIsDummyFrame): (WebCore::Frame::setDocument):

(WebCore::FramePrivate::FramePrivate): Added m_isDummyFrame.
(WebCore::FramePrivate::~FramePrivate): We have to free the Page if it is a dummyFrame
(a dummyFrame own its Page).

  • page/Frame.h:
  • page/FramePrivate.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::dataChanged): Use the dummy Frame work-around.
  • svg/graphics/SVGImage.h: Removed unused members.

LayoutTests:

2008-09-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.


Bug 5727: We want to evaluate scripts in viewless documents
https://bugs.webkit.org/show_bug.cgi?id=5727


  • fast/loader/viewless-document-expected.txt: Added.
  • fast/loader/viewless-document.html: Added.


04:46 QtWebKitContrib edited by ariya.hidayat@trolltech.com
(diff)
04:24 QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
04:24 QtWebKitJournal created by ariya.hidayat@trolltech.com
04:14 QtWebKitTodo edited by ariya.hidayat@trolltech.com
(diff)
02:03 Changeset [37059] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>

Reviewed by Simon

Fix compilation with gcc 4.3

gcc 4.3 is stricter and ctype.h isn't getting included

automatically here by dependencies. So do it directly.

02:02 Changeset [37058] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-09-29 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon.

Fix compilation with Qt/Mac without plugins.

02:02 Changeset [37057] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Simon Hausmann <hausmann@webkit.org>

Reviewed by Lars.

Don't accidentially install libJavaScriptCore.a for the build inside
Qt.

01:20 Changeset [37056] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
In the few places that we call .upper() in WebCore the strings represent things like
tag and attribute names, which are nearly always going to be ASCII.

Reviewed by Sam Weinig.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
in to Unicode::toLower the second time.
(WebCore::StringImpl::upper):

01:19 Changeset [37055] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
rather than String::operator+=.

Reviewed by Sam Weinig.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

01:19 Changeset [37054] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Speed up computedStyle.getPropertyValue('color') by 4.5x.

Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
as it avoids many memory reallocations.

This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
unrelated properties on an element.

Reviewed by Oliver Hunt.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
and use appendNumber rather than the String::number in order to cut down on memory allocations.

  • platform/text/PlatformString.h:

(WebCore::appendNumber): A helper function for formatting an unsigned character as a number
into a Vector<UChar>.

09/28/08:

21:17 Changeset [37053] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix spelling

21:16 Changeset [37052] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Remove spurious call to lower().

  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator):
20:41 Changeset [37051] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-09-28 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Use a CaseFoldingHash instead of calling lower on family strings.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::CSSFontSelector::getFontData):
  • css/CSSFontSelector.h:
20:04 Changeset [37050] by cwzwarich@webkit.org
  • 18 edits in trunk/JavaScriptCore

2008-09-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 21200: Allow direct access to 'arguments' without using op_resolve
<https://bugs.webkit.org/show_bug.cgi?id=21200>

Allow fast access to the 'arguments' object by adding an extra slot to
the callframe to store it.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::registerFor):
  • VM/CodeGenerator.h: (JSC::CodeGenerator::registerFor):
  • VM/Machine.cpp: (JSC::Machine::initializeCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • VM/Opcode.h:
  • VM/RegisterFile.h: (JSC::RegisterFile::):
  • kjs/JSActivation.cpp: (JSC::JSActivation::mark): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
  • kjs/Parser.h: (JSC::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • kjs/nodes.h: (JSC::ScopeNode::usesArguments):
19:45 Changeset [37049] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Add an ASCII fast-path to toLowerCase and toUpperCase.

The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
to the less common non-ASCII case.

This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
to the non-locale variants of the functions. toLocaleLowerCase and toLocaleUpperCase now use the non-locale
variants of the functions directly.

Reviewed by Sam Weinig.

  • kjs/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

19:00 Changeset [37048] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speed up parseInt and parseFloat.

Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
and use that instead. This is a 7% win on a parseInt/parseFloat micro-benchmark.

Reviewed by Cameron Zwarich.

16:57 Changeset [37047] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase

<https://bugs.webkit.org/show_bug.cgi?id=21185>

Reviewed by Adam.

Scripts/resolve-ChangeLogs: Added new -ffix-merge switch that

will attempt to reapply the last commit to a ChangeLog file such
that the ChangeLog entry appears at the top of the file.
(findChangeLog): Added prototype and moved method below the exit
statement.
(fixMergedChangeLog): Added. Method to fix incorrectly merged
ChangeLog entries.

16:31 Changeset [37046] by timothy@apple.com
  • 9 edits in trunk

Improves the Web Inspector node highlight so it does not scroll to reveal the node in the page.

WebCore:

2008-09-28 Timothy Hatcher <timothy@apple.com>

Remove the scrollIntoViewIfNeeded() call when drawing the
Inspector node highlight.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):

WebKit/mac:

2008-09-28 Timothy Hatcher <timothy@apple.com>

Improves the Web Inspector node highlight so it does not scroll
to reveal the node in the page. This makes the highlight less
invasive and causes less things to change on screen. Also makes
the highlight redraw when the WebView draws, so it stays current
if the node changes on the page for any reason.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController highlightNode:]): Call setNeedsDisplay:YES if there is an existing highlight. (-[WebInspectorWindowController didAttachWebNodeHighlight:]): Set the current highlight node on the inspected WebView. (-[WebInspectorWindowController willDetachWebNodeHighlight:]): Set the current highlight node on the inspected WebView to nil.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Disable screen updates until flush for the inspected window. Invalidate the whole highlight view since we don't know the rect that needs updated since the highlight can be larger than the highlighted element due to the margins and other factors.
  • WebInspector/WebNodeHighlightView.m:
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): Call setNeedsUpdateInTargetViewRect: on the current highlight node.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the current highlight node. (-[WebView setCurrentNodeHighlight:]): Set the current highlight node. (-[WebView currentNodeHighlight]): Return the current highlight node.
  • WebView/WebViewInternal.h:
12:58 Changeset [37045] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
changed.

Reviewed by Dan Bernstein

  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
12:52 Changeset [37044] by timothy@apple.com
  • 2 edits in trunk/WebCore

Clear the current search results in the Inspector when
the search query is less than 3 characters long. Incremental
searches only occur for 3 characters or longer, but deleting
under this limit would not clear the results unless the whole
query was deleted.

https://bugs.webkit.org/show_bug.cgi?id=21196

Reviewed by Dan Bernstein.

  • page/inspector/inspector.js: (WebInspector.performSearch): Check for short queries in the if statement that triggers the clear.
12:41 Changeset [37043] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo noticed by Hyatt in review, which I forgot to fix before checking in.

12:38 Changeset [37042] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and overlayLength parameters. (WebCore::EOTStream::read): Added code to overlay the the m_overlayLength bytes starting at m_overlayDst with the same number of bytes from m_overlaySrc. (WebCore::createFontCustomPlatformData): Changed to get overlay parameters from getEOTHeader.
  • platform/graphics/win/GetEOTHeader.cpp: (WebCore::getEOTHeader): Added code to specify overlaying of the family name with the prefix of the full name if they differ, because that such a difference causes TTLoadEmbeddedFont to fail.
  • platform/graphics/win/GetEOTHeader.h:
12:17 QtWebKitTodo edited by hausmann@webkit.org
(diff)
11:57 Changeset [37041] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-28 Simon Hausmann <hausmann@webkit.org>

Reviewed by David Hyatt.

Ensure the mainThreadIdentifier is set as well as other bits and pieces of
the threading machinery, by calling JSC::initializeThreading().

11:56 Changeset [37040] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-09-28 Simon Hausmann <hausmann@webkit.org>

Reviewed by David Hyatt.

In Qt's initializeThreading re-use an existing thread identifier for the main
thread if it exists.

currentThread() implicitly creates new identifiers and it could be that
it is called before initializeThreading().

11:48 QtWebKitGitInstructions edited by hausmann@webkit.org
Update to the current branch situation (diff)
11:43 QtWebKitTodo edited by hausmann@webkit.org
Cleanups and start of 4.5 plan (diff)
11:22 Changeset [37039] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Fix build warning in WebDefaultUIDelegate.m

Reviewed by Dan Bernstein.

This fixes a warning noticed by the clang static analyzer:
.../WebDefaultUIDelegate.m: In function ‘-[WebDefaultUIDelegate webViewFirstResponder:]’:
.../WebDefaultUIDelegate.m:92: warning: initialization from distinct Objective-C type

Note that this doesn't actually cause any change in behavior since
the gcc compiler ignores the semi-colon anyway.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewFirstResponder:]): Removed semi-colon from method signature.
06:23 Changeset [37038] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20366
Reproducible test failure for editing/undo/undo-iframe-location-change.html

This does not fix the problem, but makes the test more predictable by using iframe onload.
Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
even without any special steps needed in DRT.

  • editing/undo/undo-iframe-location-change-expected.txt:
  • editing/undo/undo-iframe-location-change.html:
  • ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.

WebCore:

  • ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
02:35 Changeset [37037] by darin@apple.com
  • 28 edits in trunk/WebCore

2008-09-28 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig (except for a few comment and header tweaks).

Speeds up Dromaeo a bit less than 1%.

  • bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of Node.h now that some inlines are in there.
  • dom/Attr.h: Override both the virtual and non-virtual name functions.
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
  • dom/ChildNodeList.h: Ditto.
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::nodeMatches): Ditto.
  • dom/ClassNodeList.h: Ditto.
  • dom/Document.h: Put the Node::isDocumentNode() function's inline definition here where it can see the Document class definition.
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::length): Changed to pass an Element. (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemWithName): Ditto.
  • dom/DynamicNodeList.h: Ditto.
  • dom/Element.cpp: Removed virtualHasTagName.
  • dom/Element.h: Made localName, prefix, namespaceURI, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, virtualNamespaceURI, and removed virtualHasTagName. Put the Node::hasTagName, Node::hasAttributes, and Node::attributes functions' inline definitions here where they can see the Element class definition.
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
  • dom/NameNodeList.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::virtualPrefix): Renamed from prefix. (WebCore::Node::virtualLocalName): Renamed from localName. (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI. (WebCore::Node::styleForRenderer): Handle the Element case here.
  • dom/Node.h: Removed definition of hasTagName that calls virtual, since we now have a non-virtual version. Made hasAttributes, attributes, remove, localName, namespaceURI, prefix, isDocumentNode, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, and virtualNamespaceURI. Removed isMalformed and setMalformed, which are used only on HTMLFormElement objects.
  • dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
  • dom/TagNodeList.h: Ditto.
  • html/HTMLAnchorElement.cpp: Added a comment.
  • html/HTMLFormControlElement.cpp: Ditto.
  • html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex function. Marked tabIndex function virtual explicitly for clarity.
  • html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex function. Marked isFocusable function virtual explicitly for clarity.
  • html/HTMLElement.h: Marked tabIndex function virtual explicitly for clarity.
  • html/HTMLFormControlElement.h: Ditto.
  • html/HTMLFormElement.h: Made isMalformed non-virtual.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement pointer to call localName since that one does not need to call a virtual function.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before calling isMalformed. We already did a tag name check so we know it's an HTMLFormELement.
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls to nodeType(), since it's a virtual function.
02:33 Changeset [37036] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/MouseWheelEventWx.cpp

Fix wx bustage.

01:52 Changeset [37035] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Make frameRectsChanged() cross-platform on ScrollView.

Reviewed by Oliver Hunt

  • platform/ScrollView.cpp: (WebCore::ScrollView::frameRectsChanged):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp:
01:36 Changeset [37034] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 21141: REGRESSION: Exception messages for user entered commands are poor
<https://bugs.webkit.org/show_bug.cgi?id=21141>

Reviewed by Maciej Stachowiak.

The bug repsonsible for this was the the JSInspectedObjectWrapper instances
were not initialising their StructureID's to indicate that the wrapper
overrides hasInstance, etc. The solution is simply to use the createStructureID
helper on JSQuarantinedObjectWrapper to create a correct StructureID.

01:30 Changeset [37033] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/webkit/webkitwebview.cpp

Fix GTK bustage.

01:29 Changeset [37032] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
terms of lines.

Reviewed by Oliver Hunt

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):
01:21 Changeset [37031] by hyatt@apple.com
  • 16 edits in trunk/WebCore

2008-09-28 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21191

Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
on ScrollView to be cross-platform.

Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
events are now pixel wheel events.

Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
(1) Page scrolling has been corrected to be properly detected (on Windows
page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
you could page scroll horizontally.
(2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
This caused the scroll amount for page scrolling to be way too large on layers.

Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.

Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).

Reviewed by Oliver Hunt

  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::): (WebCore::PlatformWheelEvent::pos): (WebCore::PlatformWheelEvent::globalPos): (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::granularity): (WebCore::PlatformWheelEvent::x): (WebCore::PlatformWheelEvent::globalX): (WebCore::PlatformWheelEvent::ignore): (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/Scrollbar.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): (WebCore::ScrollView::wheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):

09/27/08:

22:38 Changeset [37030] by eric.carlson@apple.com
  • 5 edits in trunk/WebCore

2008-09-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=20994
<rdar://problem/6171023> HTMLVideoElement width and height attributes are now unsigned


HTML5 spec says HTMLVideoElement width and height attributes should be unsigned. Convert
all unsigned media attributes from string with toUInt() instead of toInt().


  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playCount): convert from attribute with toUInt().
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight): return unsigned to match idl. (WebCore::HTMLVideoElement::width): convert from attribute with toUInt() and return unsigned value. (WebCore::HTMLVideoElement::height): Ditto. (WebCore::HTMLVideoElement::setWidth): take unsigned value. (WebCore::HTMLVideoElement::setHeight): Ditto.
  • html/HTMLVideoElement.h: width, height, videoWidth, and videoHeight are unsigned.
  • html/HTMLVideoElement.idl: make width and height unsigned to match HTML5 spec.
21:59 Changeset [37029] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/mac/WheelEventMac.mm

Fix indentation error from bug 17589 fix made in WheelEventMac.mm

21:57 Changeset [37028] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/PlatformWheelEvent.h

It's SENSITIVE. SENSITIVE. Not SENSIBLE.

21:40 Changeset [37027] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes an exception when typing a command in the Console.

Reviewed by Oliver Hunt.

  • page/inspector/Console.js: (WebInspector.Console.prototype.addMessage): Null check this.previosMessage.
21:40 Changeset [37026] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where the Profiles panel sidebar would be empty
after closing and reopening the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=21179

Reviewed by Sam Weinig.

  • page/inspector/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.reset): Don't call populateInterface, it is called automatically. (WebInspector.ProfilesPanel.prototype._populateProfiles): Return early if the sidebar is already populated.
21:38 Changeset [37025] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for line step being too small on Windows.

20:51 Changeset [37024] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Make the scrollbarUnderMouse method cross-platform.

Reviewed by Sam Weinig

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp:
18:50 Changeset [37023] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Gtk+ build fix.

18:49 Changeset [37022] by zecke@webkit.org
  • 5 edits in trunk

/
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

  • configure.ac: Do not check for cairo-ft for directfb builds.

WebCore
2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=20287
[Gtk] disable plugins for gtk/directfb target

Introduce WTF_PLATFORM_X11 for X11 builds.
Also use target-specific packages when building the port

  • platform/gtk/PlatformScreenGtk.cpp:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::getValueStatic): (WebCore::PluginView::getValue): (WebCore::PluginView::init):
18:08 Changeset [37021] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Missed WebKit single line change.

18:07 Changeset [37020] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.cpp

Oops. Checked in stale file.

18:07 Changeset [37019] by hyatt@apple.com
  • 12 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21188

Make scrollbar suppression and resizer avoidance cross-platform.

Reviewed by Anders

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
  • page/FrameView.cpp: (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::windowResizerRect):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::ScrollView::adjustScrollbarsAvoidingResizerCount): (WebCore::ScrollView::setParent): (WebCore::ScrollView::setScrollbarsSuppressed): (WebCore::ScrollView::platformSetScrollbarsSuppressed):
  • platform/ScrollView.h: (WebCore::ScrollView::scrollbarsSuppressed): (WebCore::ScrollView::windowResizerRect):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::setFrameRect): (WebCore::Scrollbar::setParent):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::adjustmentChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformSetScrollbarsSuppressed): (WebCore::ScrollView::setScrollPosition):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::paint):
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
16:58 Changeset [37018] by timothy@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update a layout test result to add console.trace.

16:46 Changeset [37017] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-09-27 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber-stamped by Anders Carlsson.

Compile fix.

  • plugins/PluginView.cpp: (WebCore::PluginView::load):
16:23 Changeset [37016] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=21184>.
Bug 21184: REGRESSION: Reproducible crash below StringImpl::hash while running editing/deleting/5408255.html

Remove an assertion that was incorrect and that if made correct would have duplicated a check that occurred earlier in the function.

Rubber-stamped by Sam Weinig.

  • loader/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

15:56 Changeset [37015] by zecke@webkit.org
  • 2 edits in trunk

2008-09-27 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=21174
[GTK][AUTOTOOLS] Enable large file support at configure time

  • configure.ac: Enable large file support with AC_SYS_LARGEFILE.
15:46 Changeset [37014] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[qt] Use QImageReader to figure out which image formats are supported

  • Qt can have many different plugins for different image formats. Instead of checking only for a few in WebCore use Qt to determine if this data can be treated as an image.
15:45 Changeset [37013] by zecke@webkit.org
  • 3 edits in trunk/WebCore

[qt] Clean the pattern code

  • Use save/restore on the painter after manipulating the pen/brush
  • Make the context and object null checking consistent. CG is using the object unconditionally so the Qt webkit platform can do the same.
  • Move code below the early exit. Only use the m_ownerElement before the early exit as the CG code is doing it.
15:18 Changeset [37012] by timothy@apple.com
  • 8 edits in trunk

Added support for console.trace.

JavaScriptCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added Machine::retrieveCaller to the export list.

Reviewed by Kevin McCullough and Tim Hatcher.

WebCore:

2008-09-27 Keishi Hattori <casey.hattori@gmail.com>

Added support for console.trace.

https://bugs.webkit.org/show_bug.cgi?id=19157

Reviewed by Kevin McCullough and Tim Hatcher.

  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::trace):
  • page/Console.cpp: (WebCore::Console::trace): Calls Machine::retrieveCaller to get a stack trace.
  • page/Console.h: (WebCore::): Added TraceMessageLevel.
  • page/Console.idl: Added console.trace.
  • page/inspector/Console.js: (ConsoleMessage): Added case for TraceMessageLevel.
15:18 Changeset [37011] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2008-09-27 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=21182

Make sure Mac null checks the view like the other platforms do now that Mac goes through WebCore
to call setAllowsScrolling.

Reviewed by Mark Rowe

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createFrame):
15:15 Changeset [37010] by hyatt@apple.com
  • 5 edits in trunk/WebKit

WebKit/qt:

2008-09-27 David Hyatt <hyatt@apple.com>

Forgot to land renaming changes in WebKit.

  • Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):
  • Api/qwebpage.cpp: (QWebPage::viewportSize): (QWebPage::setViewportSize):

WebKit/win:

2008-09-27 David Hyatt <hyatt@apple.com>

Land the frameGeometry->frameRect changes that I forgot to land in WebKit.

  • Interfaces/IWebScrollBarPrivate.idl:
  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
  • WebCoreSupport/EmbeddedWidget.h:
  • WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameRect):
  • WebScrollBar.h:
14:30 Changeset [37009] by mitz@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • fix typo in test name
  • media/video-click-dblckick-standalone-expected.txt: Copied from media/video-click-dlbclick-standalone-expected.txt.
  • media/video-click-dblckick-standalone.html: Copied from media/video-click-dlbclick-standalone.html.
  • media/video-click-dlbclick-standalone-expected.txt: Removed.
  • media/video-click-dlbclick-standalone.html: Removed.
14:28 Changeset [37008] by andersca@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.

Test: http/tests/plugins/local-geturl-from-remote.html

  • plugins/PluginView.cpp: (WebCore::PluginView::load):

WebKit/mac:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>

Check if the plug-in is allowed to load the resource. This matches Firefox.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

WebKitTools:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.


https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>


Return the result value from getURL.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (getURL):

LayoutTests:

2008-09-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21178
<rdar://problem/6248651>


Add tests.


  • http/tests/plugins/local-geturl-from-remote-expected.txt: Added.
  • http/tests/plugins/local-geturl-from-remote.html: Added.
14:13 Changeset [37007] by andersca@apple.com
  • 4 edits in trunk/WebKit/win

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::setFrameRect): (EmbeddedWidget::frameRectsChanged):
  • WebCoreSupport/EmbeddedWidget.h:
  • WebScrollBar.cpp: (WebScrollBar::setRect): (WebScrollBar::frameGeometry):
14:06 Changeset [37006] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2008-09-22 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added SVG pattern support to Qt.

[Qt] SVG patterns are missing
https://bugs.webkit.org/show_bug.cgi?id=20973

  • svg/graphics/qt/SVGPaintServerPatternQt.cpp: (WebCore::SVGPaintServerPattern::setup):
13:18 Changeset [37005] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixed a bug in the JS syntax highlighter with multiple line tokens.

https://bugs.webkit.org/show_bug.cgi?id=21171

Reviewed by Tim Hatcher.

  • page/inspector/SourceFrame.js: (syntaxHighlightJavascriptLine): Initialize previousMatchLength.
13:18 Changeset [37004] by timothy@apple.com
  • 2 edits in trunk/WebCore

Change searching in the Profiles panel to not match the
Self and Total columns when there are no units. The only
column that is matched for unitless number searches is
now the Calls column.

https://bugs.webkit.org/show_bug.cgi?id=21169

Reviewed by Sam Weinig.

  • page/inspector/ProfileView.js: (WebInspector.ProfileView.prototype.performSearch):
12:56 Changeset [37003] by hyatt@apple.com
  • 11 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename boundsGeometry -> boundsRect. Rename geometryChanged -> frameRectsChanged.

Reviewed by Sam Weinig

  • platform/ScrollView.h:
  • platform/Widget.h: (WebCore::Widget::boundsRect): (WebCore::Widget::invalidate): (WebCore::Widget::frameRectsChanged):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::frameRectsChanged): (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::frameRectsChanged):
  • platform/gtk/ScrollbarGtk.h:
  • platform/gtk/WidgetGtk.cpp:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::frameRectsChanged): (WebCore::ScrollView::updateScrollbars):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::scrollBackingStore): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::frameRectsChanged):
  • plugins/PluginView.cpp: (WebCore::PluginView::frameRectsChanged):
  • plugins/PluginView.h:
12:49 Changeset [37002] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2008-09-27 Simon Hausmann <hausmann@webkit.org>

Refix the previous build fix to compile on non-Qt platforms, too.

12:15 Changeset [37001] by hausmann@webkit.org
  • 6 edits in trunk/WebCore

2008-09-27 Simon Hausmann <hausmann@webkit.org>

Fix compilation with gcc 4.3 (probably > 4.0)

11:32 Changeset [37000] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-09-27 Simon Hausmann <hausmann@webkit.org>

Qt build fix - use frameRect instead of frameGeometry, adapt
to renamed scrollbar frameview methods.

10:41 Changeset [36999] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-27 Anders Carlsson <andersca@apple.com>

Fix build.

  • VM/CTI.cpp: (JSC::):
10:20 Changeset [36998] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added bug #

10:19 Changeset [36997] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-09-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Store the callee CodeBlock, not the caller CodeBlock, in the call frame
header. Nix the "codeBlock" local variable, and access the callee
CodeBlock through the call frame header instead.


Profit: call + return are simpler, because they don't have to update the
"codeBlock" local variable.


Because CTI keeps "r" in a register, reading the callee CodeBlock relative
to "r" can be very fast, in any cases we care to optimize. Presently,
no such cases seem important.


Also, stop writing "dst" to the call frame header. CTI doesn't use it.


21.6% speedup on empty function call benchmark.
3.8% speedup on SunSpider --v8.
2.1% speedup on v8 benchmark.
0.7% speedup on SunSpider (6% speedup on controlflow-recursive).


Small regression in bytecode, because currently every op_ret reads the
callee CodeBlock to check needsFullScopeChain, and bytecode does not
keep "r" in a register. On-balance, this is probably OK, since CTI is
our high-performance execution model. Also, this should go away once
we make needsFullScopeChain statically determinable at parse time.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall): The speedup! (JSC::CTI::privateCompileSlowCases): ditto
  • VM/CTI.h: (JSC::): Fixed up magic trampoline constants to account for the nixed "codeBlock" argument. (JSC::CTI::execute): Changed trampoline function not to take a "codeBlock" argument, since codeBlock is now stored in the call frame header.


  • VM/Machine.cpp: Read the callee CodeBlock from the register file. Use a NULL CallerRegisters in the call frame header to signal a built-in caller, since CodeBlock is now never NULL.
  • VM/Machine.h: Made some stand-alone functions Machine member functions so they could call the private codeBlock() accessor in the Register class, of which Machine is a friend. Renamed "CallerCodeBlock" to "CodeBlock", since it's no longer the caller's CodeBlock.
  • VM/RegisterFile.h: Marked some methods const to accommodate a const RegisterFile* being passed around in Machine.cpp.
01:23 Changeset [36996] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Qt build fix - rename frameGeometry to frameRect per r36995.

  • Api/qwebframe.cpp: (QWebFrame::render): (QWebFrame::pos): (QWebFrame::geometry):
01:01 Changeset [36995] by hyatt@apple.com
  • 31 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

Rename frameGeometry to frameRect. Rename setFrameGeometry to setFrameRect.

Reviewed by Dan Bernstein

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::updateControlTints):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::paint): (WebCore::Scrollbar::setFrameRect):
  • platform/Scrollbar.h:
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/Widget.h: (WebCore::Widget::x): (WebCore::Widget::y): (WebCore::Widget::width): (WebCore::Widget::height): (WebCore::Widget::size): (WebCore::Widget::pos): (WebCore::Widget::resize): (WebCore::Widget::move):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): (WebCore::ScrollView::update): (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::setFrameRect): (ScrollbarGtk::geometryChanged):
  • platform/gtk/ScrollbarGtk.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::trackRect): (WebCore::ScrollbarThemeMac::paint):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::styleOptionSlider):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateItem): (WebCore::PopupMenu::valueChanged): (WebCore::PopupWndProc):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameRect): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint):
  • platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::trackRect):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • platform/wx/WidgetWx.cpp: (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::init):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::init):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paintMissingPluginIcon): (WebCore::PluginView::paint): (WebCore::PluginView::init):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::positionOverflowControls):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintScrollbar):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): (WebCore::RenderWidget::updateWidgetPosition):
00:51 Changeset [36994] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/ScrollViewWx.cpp

Fix wx bustage.

00:43 Changeset [36993] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/FocusController.cpp
00:43 Changeset [36992] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-27 David Hyatt <hyatt@apple.com>

<rdar://problem/6252041> REGRESSION (4dp-TOT): Crash in Widget::platformWidget() when closing a PDF

This crash was lurking for a while and basically got exposed by my changes to visibleContentRect() to
access an actual member variable.

Reviewed by Dan Bernstein

  • page/FocusController.cpp: (WebCore::FocusController::setFocusedFrame):
00:38 Changeset [36991] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-09-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Attempt to fix QT Build. Not reviewed.

  • WebCore.pro: add -n WebCore parameter to create_hash_table
Note: See TracTimeline for information about the timeline view.