Timeline



Oct 3, 2008:

11:40 PM Changeset in webkit [37284] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/WidgetQt.cpp

Fix Qt bustage.

10:47 PM Changeset in webkit [37283] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21356: The size of the RegisterFile differs depending on 32-bit / 64-bit and Debug / Release
<https://bugs.webkit.org/show_bug.cgi?id=21356>

The RegisterFile decreases in size (measured in terms of numbers of
Registers) as the size of a Register increases. This causes

js1_5/Regress/regress-159334.js

to fail in 64-bit debug builds. This fix makes the RegisterFile on all
platforms the same size that it is in 32-bit Release builds.

  • VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile):
10:16 PM Changeset in webkit [37282] by weinig@apple.com
  • 6 edits
    3 moves in trunk/WebCore

2008-10-03 Sam Weinig <sam@webkit.org>

Reviewed by David "The Motivator" Hyatt.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21355
Move SecurityOrigin out of platform/ to page/.

It was a layering violation for SecurityOrigin to be in platform
as it depended on FrameLoader.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • page/SecurityOrigin.cpp: Copied from platform/SecurityOrigin.cpp.
  • page/SecurityOrigin.h: Copied from platform/SecurityOrigin.h.
  • page/SecurityOriginHash.h: Copied from platform/SecurityOriginHash.h.
  • platform/SecurityOrigin.cpp: Removed.
  • platform/SecurityOrigin.h: Removed.
  • platform/SecurityOriginHash.h: Removed.
9:24 PM Changeset in webkit [37281] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-03 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=18832
[curl] file upload does not work

The curl_off_t integer type has a different size depending if large
file support is enabled or not. There is no different public API for
the two cases, so the same function accepts a different type based on
a compilation option the could be different in WebKit and libcurl.
To fix the bug we query libcurl at runtime for large file support and
pass the right type based on that.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
9:02 PM Changeset in webkit [37280] by jmalonzo@webkit.org
  • 7 edits in trunk/WebCore

2008-10-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by David Hyatt.

Gtk build fixes.

  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::openFileChooser):
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenAvailableRect):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setCursor):
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
8:31 PM Changeset in webkit [37279] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/PopupMenuQt.cpp

Fix Qt bustage.

7:02 PM Changeset in webkit [37278] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

Fix Windows bustage in WebKit side.

7:01 PM Changeset in webkit [37277] by hyatt@apple.com
  • 3 edits in trunk/WebKit/win

Fix Windows bustage in WebKit side.

6:50 PM Changeset in webkit [37276] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/FileChooserWin.cpp

Fix Win bustage.

6:39 PM Changeset in webkit [37275] by mjs@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-10-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • Some code cleanup to how we handle code features.


1) Rename FeatureInfo typedef to CodeFeatures.
2) Rename NodeFeatureInfo template to NodeInfo.
3) Keep CodeFeature bitmask in ScopeNode instead of trying to break it out into individual bools.
4) Rename misleadingly named "needsClosure" method to "containsClosures", which better describes the meaning
of ClosureFeature.
5) Make setUsersArguments() not take an argument since it only goes one way.

  • JavaScriptCore.exp:
  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
  • kjs/Parser.h: (JSC::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • kjs/nodes.h: (JSC::ScopeNode::usesEval): (JSC::ScopeNode::containsClosures): (JSC::ScopeNode::usesArguments): (JSC::ScopeNode::setUsesArguments):
6:11 PM Changeset in webkit [37274] by hyatt@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-10-03 David Hyatt <hyatt@apple.com>

Fix Gtk bustage from use of containingWindow() over on the WebKit side. Replace with HostWindow use.

  • webkit/webkitwebview.cpp:
6:09 PM Changeset in webkit [37273] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Fix Qt bustage from missing include.

  • platform/qt/PlatformScreenQt.cpp:
6:08 PM Changeset in webkit [37272] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Fix Windows scrollbar bustage in popup menus.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
6:07 PM Changeset in webkit [37271] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Fix Windows bustage.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser):
  • platform/win/PlatformScreenWin.cpp: (WebCore::monitorInfoForWidget):
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue): (WebCore::PluginView::forceRedraw): (WebCore::PluginView::init):
5:21 PM Changeset in webkit [37270] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2008-10-03 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Darin Adler

Render images to RGBA8 bitmaps independently of platform endianness.

Create image difference bitmap in reference image colorspace instead of device colorspace
(which depends on the main display profile), so that no color matching happens.

https://bugs.webkit.org/show_bug.cgi?id=21336

  • DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceBitmap): (computePercentageDifferent): (compareImages):
5:16 PM Changeset in webkit [37269] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2008-10-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Fix hang when running with --pixel --reset, which occurs
because DRT spews PNG data when the script does not expect it.

https://bugs.webkit.org/show_bug.cgi?id=21323

  • Scripts/run-webkit-tests:
5:10 PM Changeset in webkit [37268] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<https://bugs.webkit.org/show_bug.cgi?id=21343>

A fix was landed for this issue in r37253, and the ChangeLog assumes
that it is a compiler bug, but it turns out that it is a subtle issue
with mixing signed and unsigned 32-bit values in a 64-bit environment.
In order to properly fix this bug, we should convert our signed offsets
into the register file to use ptrdiff_t.

This may not be the only instance of this issue, but I will land this
fix first and look for more later.

  • VM/Machine.cpp: (JSC::Machine::getArgumentsData):
  • VM/Machine.h:
  • kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
  • kjs/Arguments.h: (JSC::Arguments::init):
4:15 PM Changeset in webkit [37267] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-03 John Sullivan <sullivan@apple.com>

Fixed Release build

  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): added !LOG_DISABLED guard around declaration of npErr used only in LOG
3:55 PM Changeset in webkit [37266] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-03 Darin Adler <Darin Adler>

  • bindings/js/JSInspectedObjectWrapper.cpp: Try to fix a build failure seen on some machines but not others by adding an include.
3:41 PM Changeset in webkit [37265] by Darin Adler
  • 3 edits in trunk/WebCore

2008-10-03 Darin Adler <Darin Adler>

  • Qt build fix
  • bridge/qt/qt_runtime.cpp: Remove long-obsolete codeType and execute functions. Declarations for these relied on the CodeType enumeration, which used to be in ExecState.h; but the functions aren't needed at all.
  • bridge/qt/qt_runtime.h: Ditto.
3:29 PM Changeset in webkit [37264] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

  • VM/CTI.cpp: Another Windows build fix. Change the args of ctiTrampoline.
  • kjs/JSNumberCell.h: A build fix for newer versions of gcc. Added declarations of JSGlobalData overloads of jsNumberCell.
3:24 PM Changeset in webkit [37263] by hyatt@apple.com
  • 1 edit in trunk/WebKit/wx/WebKitSupport/ChromeClientWx.cpp

Fix wx bustage.

3:24 PM Changeset in webkit [37262] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

3:23 PM Changeset in webkit [37261] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Fix Gtk bustage.

2:58 PM Changeset in webkit [37260] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.


Convert destroyStream over to C++.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::destroyStream): (-[WebBaseNetscapePluginStream _destroyStreamWithReason:]): (-[WebBaseNetscapePluginStream _deliverData]):
2:54 PM Changeset in webkit [37259] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

  • try to fix Windows build
  • kjs/ScopeChain.h: Add forward declaration of JSGlobalData.
2:45 PM Changeset in webkit [37258] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Use a Timer instead of -[NSObject performSelector:withObject:afterDelay];


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream _destroyStream]): (-[WebBaseNetscapePluginStream _deliverData]): (WebNetscapePluginStream::deliverDataTimerFired):
2:39 PM Changeset in webkit [37257] by Darin Adler
  • 42 edits in trunk

JavaScriptCore:

2008-10-03 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Remove m_globalObject and m_globalData from ExecState.

SunSpider says this is a wash (slightly faster but not statistically
significant); which is good enough since it's a preparation step and
not supposed to be a spedup.

  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::JSCallbackFunction):
  • kjs/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • kjs/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • kjs/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • kjs/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • kjs/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • kjs/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • kjs/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • kjs/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • kjs/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • kjs/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • kjs/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • kjs/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
  • API/OpaqueJSString.cpp: Added now-needed include.
  • VM/CTI.cpp: (JSC::CTI::emitSlowScriptCheck): Changed to use ARGS_globalData instead of ARGS_exec.
  • VM/CTI.h: Added a new argument to the CTI, the global data pointer. While it's possible to get to the global data pointer using the ExecState pointer, it's slow enough that it's better to just keep it around in the CTI arguments.
  • VM/CodeBlock.h: Moved the CodeType enum here from ExecState.h.
  • VM/Machine.cpp: (JSC::Machine::execute): Pass fewer arguments when constructing ExecState, and pass the global data pointer when invoking CTI. (JSC::Machine::firstCallFrame): Added. Used to get the dynamic global object, which is in the scope chain of the first call frame. (JSC::Machine::cti_op_add): Use globalData instead of exec when possible, to keep fast cases fast, since it's now more expensive to get to it through the exec pointer. (JSC::Machine::cti_timeout_check): Ditto. (JSC::Machine::cti_op_put_by_id_second): Ditto. (JSC::Machine::cti_op_get_by_id_second): Ditto. (JSC::Machine::cti_op_mul): Ditto. (JSC::Machine::cti_vm_compile): Ditto. (JSC::Machine::cti_op_get_by_val): Ditto. (JSC::Machine::cti_op_sub): Ditto. (JSC::Machine::cti_op_put_by_val): Ditto. (JSC::Machine::cti_op_put_by_val_array): Ditto. (JSC::Machine::cti_op_negate): Ditto. (JSC::Machine::cti_op_div): Ditto. (JSC::Machine::cti_op_pre_dec): Ditto. (JSC::Machine::cti_op_post_inc): Ditto. (JSC::Machine::cti_op_lshift): Ditto. (JSC::Machine::cti_op_bitand): Ditto. (JSC::Machine::cti_op_rshift): Ditto. (JSC::Machine::cti_op_bitnot): Ditto. (JSC::Machine::cti_op_mod): Ditto. (JSC::Machine::cti_op_post_dec): Ditto. (JSC::Machine::cti_op_urshift): Ditto. (JSC::Machine::cti_op_bitxor): Ditto. (JSC::Machine::cti_op_bitor): Ditto. (JSC::Machine::cti_op_call_eval): Ditto. (JSC::Machine::cti_op_throw): Ditto. (JSC::Machine::cti_op_is_string): Ditto. (JSC::Machine::cti_op_debug): Ditto. (JSC::Machine::cti_vm_throw): Ditto.
  • VM/Machine.h: Added firstCallFrame.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Pass fewer arguments when constructing ExecState.
  • kjs/ExecState.cpp: Deleted contents. Later we'll remove the file altogether.
  • kjs/ExecState.h: Removed m_globalObject and m_globalData. Moved CodeType into another header. (JSC::ExecState::ExecState): Take only a single argument, a call frame pointer. (JSC::ExecState::dynamicGlobalObject): Get the object from the first call frame since it's no longer stored. (JSC::ExecState::globalData): Get the global data from the scope chain, since we no longer store a pointer to it here. (JSC::ExecState::identifierTable): Ditto. (JSC::ExecState::propertyNames): Ditto. (JSC::ExecState::emptyList): Ditto. (JSC::ExecState::lexer): Ditto. (JSC::ExecState::parser): Ditto. (JSC::ExecState::machine): Ditto. (JSC::ExecState::arrayTable): Ditto. (JSC::ExecState::dateTable): Ditto. (JSC::ExecState::mathTable): Ditto. (JSC::ExecState::numberTable): Ditto. (JSC::ExecState::regExpTable): Ditto. (JSC::ExecState::regExpConstructorTable): Ditto. (JSC::ExecState::stringTable): Ditto. (JSC::ExecState::heap): Ditto.
  • kjs/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor. (JSC::constructFunction): Pass the global data pointer when constructing a new scope chain.
  • kjs/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction): Take a JSGlobalData* instead of an ExecState*. Later we can change more places to work this way -- it's more efficient to take the type you need since the caller might already have it.
  • kjs/InternalFunction.h: Ditto.
  • kjs/JSCell.h: (JSC::JSCell::operator new): Added an overload that takes a JSGlobalData* so you can construct without an ExecState*.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Moved creation of the global scope chain in here, since it now requires a pointer to the global data. Moved the initialization of the call frame in here since it requires the global scope chain node. Removed the extra argument to ExecState when creating the global ExecState*.
  • kjs/JSGlobalObject.h: Removed initialization of globalScopeChain and the call frame from the JSGlobalObjectData constructor. Added a thisValue argument to the init function.
  • kjs/JSNumberCell.cpp: Added versions of jsNumberCell that take JSGlobalData* rather than ExecState*.
  • kjs/JSNumberCell.h: (JSC::JSNumberCell::operator new): Added a version that takes JSGlobalData*. (JSC::JSNumberCell::JSNumberCell): Ditto. (JSC::jsNumber): Ditto.
  • kjs/JSString.cpp: (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • kjs/JSString.h: (JSC::JSString::JSString): Changed to take JSGlobalData*. (JSC::jsEmptyString): Added a version that takes JSGlobalData*. (JSC::jsSingleCharacterString): Ditto. (JSC::jsSingleCharacterSubstring): Ditto. (JSC::jsNontrivialString): Ditto. (JSC::JSString::getIndex): Ditto. (JSC::jsString): Ditto. (JSC::jsSubstring): Ditto. (JSC::jsOwnedString): Ditto.
  • kjs/ScopeChain.h: Added a globalData pointer to each node. (JSC::ScopeChainNode::ScopeChainNode): Initialize the globalData pointer. (JSC::ScopeChainNode::push): Set the global data pointer in the new node. (JSC::ScopeChain::ScopeChain): Take a globalData argument.
  • kjs/SmallStrings.cpp: (JSC::SmallStrings::createEmptyString): Take JSGlobalData* instead of ExecState*. (JSC::SmallStrings::createSingleCharacterString): Ditto.
  • kjs/SmallStrings.h: (JSC::SmallStrings::emptyString): Ditto. (JSC::SmallStrings::singleCharacterString): Ditto.

WebCore:

2008-10-03 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Remove m_globalObject and m_globalData from ExecState.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): Removed an argument now that JSGlobalObject doesn't need it any more. (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed the argument from the JSDOMWindowBaseData constructor, and added the this argument to the JSGlobalObject constructor. This is because a couple key bits of initialization moved from the data constructor to the JSGlobalObject constructor.
  • bindings/js/JSDOMWindowBase.h: Ditto.
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod): Pass JSGlobalData* instead of ExecState* to the InternalFunction constructor.
2:34 PM Changeset in webkit [37256] by Simon Fraser
  • 1 edit
    2 adds in trunk/LayoutTests

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Testcase for "white-space: -webkit-nowrap" only being converted to
"white-space: nowrap" on <td> and <th> now, not any element with a table-cell
dispay type.

See https://bugs.webkit.org/show_bug.cgi?id=21287#c3

  • fast/table/td-display-nowrap-expected.txt: Added.
  • fast/table/td-display-nowrap.html: Added.
2:34 PM Changeset in webkit [37255] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-03 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

More plug-in stream cleanup.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create): (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): (-[WebBaseNetscapePluginStream setPlugin:]): (WebNetscapePluginStream::setPlugin): (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): (-[WebBaseNetscapePluginStream _destroyStream]):
2:16 PM Changeset in webkit [37254] by hyatt@apple.com
  • 19 edits in trunk

2008-10-03 David Hyatt <hyatt@apple.com>

Fix Windows/Qt build bustage.

Reviewed by ggaren

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::platformWindow):
  • page/Chrome.cpp: (WebCore::Chrome::platformWindow):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::show):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupWndProc):
1:56 PM Changeset in webkit [37253] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21343: REGRESSSION (r37160): ecma_3/ExecutionContexts/10.1.3-1.js and js1_4/Functions/function-001.js fail on 64-bit
<https://bugs.webkit.org/show_bug.cgi?id=21343>

Add a workaround for a bug in GCC, which affects GCC 4.0, GCC 4.2, and
llvm-gcc 4.2. I put it in an #ifdef because it was a slight regression
on SunSpider in 32-bit, although that might be entirely random.

  • kjs/Arguments.cpp: (JSC::Arguments::getOwnPropertySlot):
1:20 PM Changeset in webkit [37252] by Simon Fraser
  • 46 edits in trunk/WebCore

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Make setStyle() take a const RenderStyle, to ensure that an
earlier RenderStyle::diff() remains valid.

1:10 PM Changeset in webkit [37251] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Preparation for enabling scrollbars to hit test properly inside transforms. Clean up the scrollbar
event handlers to no longer be virtual. Don't pass a mouse event where none is needed. Add a new
method on Scrollbars called transformEvent that will apply all of the transforms to make a new event
that will work properly for hit testing. This patch just stubs out that method to return the same
event untransformed.

Reviewed by Darin Adler

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • page/gtk/EventHandlerGtk.cpp:
  • page/mac/EventHandlerMac.mm:
  • page/qt/EventHandlerQt.cpp:
  • page/win/EventHandlerWin.cpp:
  • page/wx/EventHandlerWx.cpp:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown): (WebCore::Scrollbar::transformEvent):
  • platform/Scrollbar.h:
1:00 PM Changeset in webkit [37250] by Simon Fraser
  • 1 edit
    6 adds in trunk/LayoutTests

2008-10-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyat

Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.

https://bugs.webkit.org/show_bug.cgi?id=21287

  • fast/table/floating-th.html: Added.
  • fast/table/table-display-types-strict.html: Added.
  • fast/table/table-display-types.html: Added.
  • platform/mac/fast/table/floating-th-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-strict-expected.txt: Added.
12:17 PM Changeset in webkit [37249] by hyatt@apple.com
  • 12 edits in trunk

WebCore:

2008-10-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.


Reviewed by Dan Bernstein & Darin Adler


  • platform/ScrollView.cpp: (WebCore::ScrollView::addChild):
  • platform/Widget.cpp: (WebCore::Widget::init):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):

WebKit/gtk:

2008-10-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.

Reviewed by Dan Bernstein & Darin Adler


  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

WebKit/win:

2008-10-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21340


Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.


Reviewed by Dan Bernstein & Darin Adler

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebScrollBar.cpp: (WebScrollBar::WebScrollBar): (WebScrollBar::init): (WebScrollBar::invalidateScrollbarRect):
  • WebScrollBar.h:
12:06 PM Changeset in webkit [37248] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

  • css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if settings is nil.
12:00 PM Changeset in webkit [37247] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=20134
REGRESSION (2.0.4-3.0.4): No default value set for <input type=range> with an even difference of (max - min)

Make sure the input element gets the right default value when no value is set.

Test: fast/forms/range-default-value.html

11:50 AM Changeset in webkit [37246] by hyatt@apple.com
  • 3 edits in trunk/WebKit/qt

2008-10-03 David Hyatt <hyatt@apple.com>

Fix scroll method on Qt. The delta was supposed to use .width()/.height() and not .x()/.y().

Fix the QtPluginWidget to do an invalidate properly.

Reviewed by ggaren

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::):
11:42 AM Changeset in webkit [37245] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/WidgetWin.cpp

Remove commented out method.

11:29 AM Changeset in webkit [37244] by hyatt@apple.com
  • 9 edits
    1 delete in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Instead of a cross-platform init/destroy that forces every ScrollView platform to have a constructor/
destructor that calls them, switch to having a cross-platform constructor/destructor that calls
platform-specific init/destroy methods.

With this change, ScrollViewWin.cpp can be removed from the build (yay!).

Reviewed by Darin Adler

  • WebCore.vcproj/WebCore.vcproj:
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
  • platform/mac/ScrollViewMac.mm:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy):
  • platform/win/ScrollViewWin.cpp: Removed.
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::setPlatformWidget):
11:13 AM Changeset in webkit [37243] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-10-03 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6012018>
https://bugs.webkit.org/show_bug.cgi?id=21335
CrashTracer: [USER] 4959 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 8

  • css/CSSFontSelector.cpp: (WebCore::fontDataForGenericFamily): Return early if the frame is nil.
10:27 AM Changeset in webkit [37242] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

Rubber stamped by Alexey Proskuryakov.

  • kjs/Shell.cpp: (main): Don't delete JSGlobalData. Later, we need to change this tool to use public JavaScriptCore API instead.
10:01 AM Changeset in webkit [37241] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Build fix. Remove addToDirtyRegion from the header file.

  • WebCoreSupport/ChromeClientQt.h:
9:09 AM Changeset in webkit [37240] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Darin Adler <Darin Adler>

Suggested by Alexey Proskuryakov.

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Remove call to heap.destroy() because it's too late to ref the JSGlobalData object once it's already being destroyed. In practice this is not a problem because WebCore's JSGlobalData is never destroyed and JSGlobalContextRelease takes care of calling heap.destroy() in advance.
9:02 AM Changeset in webkit [37239] by Simon Hausmann
  • 5 edits in trunk

2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Build fix.

  • platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidateRect):

2008-10-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Build fix.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::): (WebCore::FrameLoaderClientQt::createPlugin):
6:36 AM Changeset in webkit [37238] by alp@webkit.org
  • 6 edits in trunk

2008-10-03 Alp Toker <alp@nuanti.com>

Remove some left-over GTK+ includes. No change in functionality.

5:59 AM Changeset in webkit [37237] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-10-03 Alp Toker <alp@nuanti.com>

Build fix following r37234. Remove addToDirtyRegion from the header
too.

  • WebCoreSupport/ChromeClientGtk.h:
5:38 AM Changeset in webkit [37236] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-10-03 Alp Toker <alp@nuanti.com>

Build fix for trailing comment after #endif

  • dom/ElementRareData.h:
4:11 AM Changeset in webkit [37235] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Replace SSE3 check with an SSE2 check, and implement SSE2 check on windows.

Reviewed by Maciej Stachowiak

5.6% win on SunSpider on windows.

2:03 AM Changeset in webkit [37234] by hyatt@apple.com
  • 19 edits in trunk

WebCore:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/ChromeClientGtk.cpp:

WebKit/mac:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/qt:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/ChromeClientQt.cpp:

WebKit/win:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebCoreSupport/WebChromeClient.cpp:

WebKit/wx:

2008-10-03 David Hyatt <hyatt@apple.com>

Remove addToDirtyRegion.


Reviewed by Oliver Hunt

  • WebKitSupport/ChromeClientWx.cpp:
2:00 AM Changeset in webkit [37233] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

  • fix a CachedResource leak introduced in r37176

Undo r37176 and instead allow pruneDeadResources() to be re-entered, but
afterwards bail out of the outer pruneDeadResources().

  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::remove):
  • loader/Cache.h:
1:50 AM Changeset in webkit [37232] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21330

Fix Gtk adjustments so that they are properly checked again before creating horizontal/vertical
scrollbars.


Reviewed by Oliver Hunt

  • platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::platformHasHorizontalAdjustment): (WebCore::ScrollView::platformHasVerticalAdjustment):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::adjustmentChanged): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::setGtkAdjustments): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
1:15 AM Changeset in webkit [37231] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-10-03 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

Change "upperCase" to "interfaceName" per-tag parameter as
discussed on the mailing list. Removed the per-attribute version
as it was not used.

Also add the "Element" suffix to all interfaceName parameter to match
the class name (and thus remove it from make_names.pl).

  • dom/make_names.pl:
  • html/HTMLTagNames.in:
  • svg/svgtags.in:
12:52 AM Changeset in webkit [37230] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:52 AM Changeset in webkit [37229] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:51 AM Changeset in webkit [37228] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Another speculative Gtk scrolling fix.

12:47 AM Changeset in webkit [37227] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-03 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Cameron Zwarich.


fix mistaken change of | to
which caused a big perf regression on EarleyBoyer
  • kjs/grammar.y:
12:44 AM Changeset in webkit [37226] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.h

Fix Qt bustage.

12:41 AM Changeset in webkit [37225] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Speculative fix for gtk not painting on scroll.

12:38 AM Changeset in webkit [37224] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-10-03 David Hyatt <hyatt@apple.com>

Preserve Qt's disabling of blitting when any native widgets are present anywhere on the page (ick).
Hopefully this is a temporary hack that could eventually be removed.

Reviewed by Sam Weinig

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h: (WebCore::ScrollView::rootPreventsBlitting):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
12:06 AM Changeset in webkit [37223] by hyatt@apple.com
  • 31 edits in trunk

WebCore:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::invalidateScrollbarRect):
  • page/FrameView.h:
  • platform/PopupMenu.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::setEnabled): (WebCore::Scrollbar::invalidateRect):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.h:
  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/WidgetMac.mm:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::invalidateScrollbarRect):
  • platform/win/WidgetWin.cpp:
  • plugins/PluginView.cpp: (WebCore::PluginView::invalidateTimerFired): (WebCore::PluginView::invalidateWindowlessPluginRect):
  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::invalidateRect):
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::invalidateRegion):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::invalidateScrollbarRect):
  • rendering/RenderListBox.h:

WebKit/mac:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.mm: (PluginWidget::PluginWidget): (PluginWidget::invalidateRect): (NetscapePluginWidget::NetscapePluginWidget): (WebFrameLoaderClient::createPlugin):

WebKit/win:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21328


Make widget invalidation more cross-platform.


(1) Make invalidateRect a pure virtual function on Widget. All leaf widgets must now implement this function.


(2) Scrollbars now send invalidations through the ScrollbarClient. windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.


(3) Plugins now have the native window invalidation code for windowed plugins. Windowless plugins do a repaintRectangle on the plugin's renderer.


(4) FrameViews now do a repaintRectangle on their owner element's renderer.

Reviewed by Sam Weinig

  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::invalidateRect):
  • WebCoreSupport/EmbeddedWidget.h:
  • WebScrollBar.cpp: (WebScrollBar::invalidateScrollbarRect):
  • WebScrollBar.h:

Oct 2, 2008:

11:20 PM Changeset in webkit [37222] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Geoffrey Garen and Sam Weinig.

  • fix SVGFontFaceElement leaks seen in Acid3
  • make font-face elements take effect only when they are in the document tree

Test: svg/custom/font-face-not-in-document.svg

  • svg/SVGFontData.h: Changed the m_svgFontFaceElement member from a RefPtr to a plain pointer to break a ref cycle. (WebCore::SVGFontData::svgFontFaceElement):
  • svg/SVGFontFaceElement.cpp: Changed to insert and remove the @font-face rule from the document's mapped element sheet when the element is inserted and removed from the document, and to update it only when the element is in the document. (WebCore::SVGFontFaceElement::SVGFontFaceElement): (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::insertedIntoDocument): (WebCore::SVGFontFaceElement::removedFromDocument): (WebCore::SVGFontFaceElement::childrenChanged): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:

LayoutTests:

Reviewed by Geoffrey Garen and Sam Weinig.

  • svg/custom/font-face-not-in-document-expected.txt: Added.
  • svg/custom/font-face-not-in-document.svg: Added.
6:59 PM Changeset in webkit [37221] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/JavaScriptCore

Merge r31824.

5:43 PM Changeset in webkit [37220] by Simon Fraser
  • 6 edits in trunk/WebCore

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Fix RenderFileUploadControl::setStyle() and
RenderMenuList::setStyle() to not touch the style; replace
with html4.css and CSSStyleSelector changes.

https://bugs.webkit.org/show_bug.cgi?id=21287

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle):
5:41 PM Changeset in webkit [37219] by Simon Fraser
  • 7 edits in trunk

2008-10-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Clean up code that changes the RenderStyle passed in to
table renderer setStyle() methods.

https://bugs.webkit.org/show_bug.cgi?id=21287

Tests: fast/table/floating-th.html

fast/table/table-display-types-strict.html
fast/table/table-display-types.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::setStyle):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::setStyle):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setStyle):
5:28 PM Changeset in webkit [37218] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-02 Darin Adler <Darin Adler>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Need to replace the -> with a . here too. Not just locally in my generated file!
5:25 PM Changeset in webkit [37217] by adele@apple.com
  • 15 edits in trunk

WebCore:

2008-10-02 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

I recently added a pseudo-class for the placeholder, but that can be overridden by inline style changes. A pseudo-element
is more appropriate. This change adds "-webkit-input-placeholder".

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added definition for "-webkit-input-placeholder" pseudo element.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoInputPlaceholder.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added case for PseudoInputPlaceholder.
  • css/html4.css: Added rule for -webkit-input-placeholder pseudo-element.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::): Added INPUT_PLACEHOLDER.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Check that its a text field before calling updatePlaceholderVisibility. (WebCore::HTMLInputElement::setValueFromRenderer): ditto. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Instead of calling setChanged(), call updatePlaceholderVisibility on the renderer. setChanged wouldn't actually trigger setStyle since the style for the input element won't actually change.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Get the pseudoStyle when the placeholder is visible. (WebCore::RenderTextControl::updatePlaceholderVisibility): Sets the style on the inner text block, and calls updateFromElement so the text will be updated correctly.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-10-02 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Update tests for https://bugs.webkit.org/show_bug.cgi?id=21299
REGRESSION: <input> color specified in inline style applies to placeholder

  • fast/forms/placeholder-pseudo-style.html:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
4:59 PM Changeset in webkit [37216] by Chris Fleizach
  • 6 edits in trunk

<rdar://problem/6227690> There are a bunch of tables on this page that don't seem to be real tables

4:48 PM Changeset in webkit [37215] by Darin Adler
  • 20 edits in trunk

JavaScriptCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

1.019x as fast on SunSpider.

  • API/JSBase.cpp: (JSEvaluateScript): Use heap. instead of heap-> to work with the heap. (JSCheckScriptSyntax): Ditto. (JSGarbageCollect): Ditto. (JSReportExtraMemoryCost): Ditto.
  • API/JSContextRef.cpp: (JSGlobalContextRetain): Ditto. (JSGlobalContextRelease): Destroy the heap with the destroy function instead of the delete operator. (JSContextGetGlobalObject): Use heap. instead of heap-> to work with the heap.
  • API/JSObjectRef.cpp: (JSObjectMake): Use heap. instead of heap-> to work with the heap. (JSObjectMakeFunctionWithCallback): Ditto. (JSObjectMakeConstructor): Ditto. (JSObjectMakeFunction): Ditto. (JSObjectMakeArray): Ditto. (JSObjectMakeDate): Ditto. (JSObjectMakeError): Ditto. (JSObjectMakeRegExp): Ditto. (JSObjectHasProperty): Ditto. (JSObjectGetProperty): Ditto. (JSObjectSetProperty): Ditto. (JSObjectGetPropertyAtIndex): Ditto. (JSObjectSetPropertyAtIndex): Ditto. (JSObjectDeleteProperty): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto. (JSObjectCopyPropertyNames): Ditto. (JSPropertyNameAccumulatorAddName): Ditto.
  • API/JSValueRef.cpp: (JSValueIsEqual): Ditto. (JSValueIsInstanceOfConstructor): Ditto. (JSValueMakeNumber): Ditto. (JSValueMakeString): Ditto. (JSValueToNumber): Ditto. (JSValueToStringCopy): Ditto. (JSValueToObject): Ditto. (JSValueProtect): Ditto. (JSValueUnprotect): Ditto.
  • kjs/ExecState.h: (JSC::ExecState::heap): Update to use the & operator.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Update to initialize a heap member instead of calling new to make a heap. (JSC::JSGlobalData::~JSGlobalData): Destroy the heap with the destroy function instead of the delete operator.
  • kjs/JSGlobalData.h: Change from Heap* to a Heap.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::mark): Use the & operator here. (JSC::JSGlobalObject::operator new): Use heap. instead of heap-> to work with the heap.

WebCore:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • bindings/js/GCController.cpp: (WebCore::collect): Use heap. instead of heap-> to work with the heap. (WebCore::GCController::gcTimerFired): Ditto. (WebCore::GCController::garbageCollectNow): Ditto.
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::operator new): Ditto.
  • storage/Database.cpp: (WebCore::Database::Database): Ditto.

WebKit/mac:

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): Use heap. instead of heap-> to work with the heap. (+[WebCoreStatistics javaScriptGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]): Ditto. (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]): Ditto. (+[WebCoreStatistics javaScriptReferencedObjectsCount]): Ditto.

WebKit/win:

2008-10-02 Darin Adler <Darin Adler>

  • WebCoreStatistics.cpp: (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to work with the heap. (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto. (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Ditto.
4:05 PM Changeset in webkit [37214] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage.

3:19 PM Changeset in webkit [37213] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21317: Replace RegisterFile size and capacity information with Register pointers
<https://bugs.webkit.org/show_bug.cgi?id=21317>

This is a 2.3% speedup on the V8 DeltaBlue benchmark, a 3.3% speedup on
the V8 Raytrace benchmark, and a 1.0% speedup on SunSpider.

  • VM/Machine.cpp: (JSC::slideRegisterWindowForCall): (JSC::Machine::callEval): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/RegisterFile.cpp: (JSC::RegisterFile::~RegisterFile):
  • VM/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::start): (JSC::RegisterFile::end): (JSC::RegisterFile::size): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow): (JSC::RegisterFile::lastGlobal): (JSC::RegisterFile::markGlobals): (JSC::RegisterFile::markCallFrames):
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::copyGlobalsTo):
2:54 PM Changeset in webkit [37212] by adele@apple.com
  • 8 edits in trunk/LayoutTests

2008-10-02 Adele Peterson <adele@apple.com>

Update results for mac-tiger.

  • platform/mac-tiger/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/001-expected.txt:
  • platform/mac-tiger/svg/hixie/perf/002-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003-expected.txt:
  • platform/mac-tiger/svg/hixie/text/003a-expected.txt:
  • platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
2:33 PM Changeset in webkit [37211] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix scrolling=no iframe regression on Windows.

2:03 PM Changeset in webkit [37210] by hyatt@apple.com
  • 2 edits in trunk/WebKit/win

Fix Win build bustage.

1:46 PM Changeset in webkit [37209] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

  • fix a Database leak that resulted in Document leaks
  • storage/Database.cpp: (WebCore::Database::openDatabase): Account for the fact that RefCounted objects start out with a ref count of 1.
1:29 PM Changeset in webkit [37208] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Sam Weinig <sam@webkit.org>

Reviewed by Mr. Geoffrey Garen.

Always mark your parent before marking members.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark):
1:26 PM Changeset in webkit [37207] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/reviewform.html.tmpl: Fix typo.
1:23 PM Changeset in webkit [37206] by Adam Roben
  • 2 edits in trunk/BugsSite
  • template/en/custom/attachment/review.html.tmpl: Fix URLs
1:21 PM Changeset in webkit [37205] by Adam Roben
  • 3 edits
    2 adds in trunk/BugsSite

Fix Bug 21315: bugs.webkit.org should have a nicer patch review interface

https://bugs.webkit.org/show_bug.cgi?id=21315

Reviewed by Tim Hatcher.

  • attachment.cgi: (top level): Added support for the "review" and "reviewform" actions. (sub edit): Accept the template name as a parameter. If no name is give, use "edit" as before.
  • template/en/custom/attachment/list.html.tmpl: Added a "Review Patch" link for all patch attachments.
  • template/en/custom/attachment/review.html.tmpl: Added. Simple <frameset> page to show the patch on the top and a comment form on the bottom.
  • template/en/custom/attachment/reviewform.html.tmpl: Added. Simple comment form for reviewing patches.
1:17 PM Changeset in webkit [37204] by hyatt@apple.com
  • 26 edits in trunk

WebCore:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::repaint): (WebCore::EmptyChromeClient::scroll):
  • page/Chrome.cpp: (WebCore::Chrome::repaint): (WebCore::Chrome::scroll):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll):
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::addPanScrollIcon): (WebCore::ScrollView::removePanScrollIcon):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::~ScrollView):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView):

WebKit/gtk:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::scroll):

WebKit/qt:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::repaint): (WebCore::ChromeClientQt::scroll):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-02 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21314


Make scrollBackingStore cross-platform.

Reviewed by Sam Weinig

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::repaint): (WebChromeClient::scroll):
  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: (WebView::repaint):
  • WebView.h:
12:59 PM Changeset in webkit [37203] by kevino@webkit.org
  • 5 edits in trunk

wx build fixes after Frame/ScrollView changes.

12:33 PM Changeset in webkit [37202] by brettw@chromium.org
  • 92 edits in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21292

Revert the changes to enclosingIntRect made in r12530 since the new code
doesn't round correctly.

11:48 AM Changeset in webkit [37201] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Anders Carlsson and Eric Seidel.

  • fix HTMLCanvaseElement leak from -webkit-canvas() values

Changed the m_element member of CSSCanvasValue from a RefPtr to a plain
pointer, as the document owns the canvas elements. Added code to release
those elements in Document::removedLastRef() because they reference
the document.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::element):
  • css/CSSCanvasValue.h: (WebCore::CSSCanvasValue::CSSCanvasValue):
  • dom/Document.cpp: (WebCore::Document::removedLastRef):
11:40 AM Changeset in webkit [37200] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

A typo fix for ChangeLog.

11:39 AM Changeset in webkit [37199] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Build fix for platform that don't implement WTF::ThreadSpecific.

  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Guard ThreadSpecific use with #if ENABLE(WORKERS). No platform defines this yet, but this code is only needed for JS bindings in worker threads.
11:23 AM Changeset in webkit [37198] by hyatt@apple.com
  • 23 edits in trunk

WebCore:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).


Reviewed by Sam Weinig

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::isActive):
  • page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
  • platform/PopupMenu.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::destroy): (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollContents): (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::windowClipRect):
  • platform/ScrollbarClient.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollContents):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::windowClipRect):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollContents):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::windowClipRect):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::panScroll): (WebCore::RenderListBox::windowClipRect):
  • rendering/RenderListBox.h:

WebKit/win:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21298


Make updateScrollbars cross-platform. For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store. Next patch
will make that cross-platform.


The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
multiple inheritance. For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).

Reviewed by Sam Weinig

  • WebScrollBar.cpp: (WebScrollBar::windowClipRect):
  • WebScrollBar.h:
10:54 AM Changeset in webkit [37197] by sfalken@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/win

Merge r31212 for fix <rdar://problem/6168976> visitCount not updated in History.plist

10:03 AM Changeset in webkit [37196] by Adam Roben
  • 2 edits
    2 deletes in trunk/BugsSite

Remove references to some backup files I created when implementing PrettyPatch in Bugzilla

Reviewed by Tim Hatcher.

  • attachment-aroben.cgi: Removed.
  • template/en/default/attachment/edit-aroben.html.tmpl: Removed.
  • template/en/custom/attachment/edit.html.tmpl: Removed an erroneous reference to attachment-aroben.cgi. attachment.cgi will work just fine.
10:00 AM Changeset in webkit [37195] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Darin Adler.

Change bitwise operations introduced in r37166 to boolean operations. We
only use bitwise operations over boolean operations for increasing
performance in extremely hot code, but that does not apply to anything
in the parser.

  • kjs/grammar.y:
9:45 AM Changeset in webkit [37194] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-10-02 Gavin Barraclough <barraclough@apple.com>

Reviewed by Darin Adler.

Fix for bug #21232 - should reset m_isPendingDash on flush,
and should allow '\-' as beginning or end of a range (though
not to specifiy a range itself).

  • ChangeLog:
  • wrec/CharacterClassConstructor.cpp: (JSC::CharacterClassConstructor::put): (JSC::CharacterClassConstructor::flush):
  • wrec/CharacterClassConstructor.h: (JSC::CharacterClassConstructor::flushBeforeEscapedHyphen):
  • wrec/WREC.cpp: (JSC::WRECGenerator::generateDisjunction): (JSC::WRECParser::parseCharacterClass): (JSC::WRECParser::parseDisjunction):
  • wrec/WREC.h:

LayoutTests:

2008-10-02 Gavin Barraclough <barraclough@apple.com>

Reviewed by Darin Adler.

Layout tests for for bug #21232 - plus a range of tests for, um, ranges.

  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt: Added.
  • fast/js/regexp-ranges-and-escaped-hyphens.html: Added.
  • fast/js/resources/regexp-ranges-and-escaped-hyphens.js: Added.
9:45 AM Changeset in webkit [37193] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Forgot to land JavaScriptCore.exp with the previous check-in.

9:39 AM Changeset in webkit [37192] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • remove the "static" from declarations in a header file, since we don't want them to have internal linkage
  • VM/Machine.h: Remove the static keyword from the constant and the three inline functions that Geoff just moved here.
9:22 AM Changeset in webkit [37191] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21283.
Profiler Crashes When Started

  • VM/Machine.cpp:
  • VM/Machine.h: (JSC::makeHostCallFramePointer): (JSC::isHostCallFrame): (JSC::stripHostCallFrameBit): Moved some things to the header so JSGlobalObject could use them.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Call the new makeHostCallFramePointer API, since 0 no longer indicates a host call frame.
9:18 AM Changeset in webkit [37190] by ap@webkit.org
  • 35 edits
    2 deletes in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21304
Stop using a static wrapper map for WebCore JS bindings

The static domObjects map was not thread safe.

  • dom/Document.h: (WebCore::Document::messagePorts): Added an accessor for JSDocument to iterate over message ports. (WebCore::Document::xmlHttpRequests): Ditto for XMLHttpRequests.
  • dom/Document.cpp: (WebCore::Document::createdXMLHttpRequest): (WebCore::Document::destroyedXMLHttpRequest): Moved XMLHttpRequest tracking from a global map to Document.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • bindings/DOMProtect.cpp: Removed.
  • bindings/DOMProtect.h: Removed. Removed gcProtect(Unprotect)DOMObject - its callers do not have a JSGlobalData reference, so they can no longer protect bindings objects.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::queueCloseEvent): (WebCore::MessagePort::setPendingActivity): (WebCore::MessagePort::unsetPendingActivity):
  • dom/MessagePort.h: (WebCore::MessagePort::hasPendingActivity): MessagePort now counts outstanding async events, so JSDocument::mark can decide whether to protect it.
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::hasPendingActivity):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::dropProtection): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests): (WebCore::XMLHttpRequest::setPendingActivity): (WebCore::XMLHttpRequest::unsetPendingActivity): Moved XMLHttpRequest tracking from a global map to Document.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): (WebCore::DOMObjectWrapperMap::mapFor): (WebCore::DOMObjectWrapperMap::get): (WebCore::DOMObjectWrapperMap::set): (WebCore::DOMObjectWrapperMap::remove): (WebCore::getCachedDOMObjectWrapper): (WebCore::cacheDOMObjectWrapper): (WebCore::forgetDOMObject): (WebCore::getCachedDOMNodeWrapper): (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper): (WebCore::markActiveObjectsForDocument):
  • bindings/js/JSDOMBinding.h: (WebCore::createDOMObjectWrapper): (WebCore::getDOMObjectWrapper): Wrapper map is now kept as JSGlobalData::clientData. Also changed debug-only wrapperSet to be per-thread (this is slower than going to JSGlobalData, but fast enough for debug). WebCore objects can never migrate between threads.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForDocument() from JSDOMBinding.
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): (WebCore::JSDOMWindow::mark):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSMessageChannelCustom.cpp: (WebCore::JSMessageChannel::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::finishedWithEvent):
  • bindings/scripts/CodeGeneratorJS.pm: Pass a JSGlobalData reference to functions that track JS wrapper objects.

JavaScriptCore:

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): (JSC::JSGlobalData::ClientData::~ClientData):
  • kjs/JSGlobalData.h: Added a client data member to JSGlobalData. WebCore will use it to store bindings-related global data.
12:52 AM Changeset in webkit [37189] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • page/JavaScriptCallFrame.idl:
12:35 AM Changeset in webkit [37188] by oliver@apple.com
  • 4 edits in trunk/WebCore

Add new file to project files

Reviewed by NOBODY (Build fix)

12:15 AM Changeset in webkit [37187] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

Try to fix some more builds.

  • GNUmakefile.am:
  • WebCore.pro:
12:13 AM Changeset in webkit [37186] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2008-10-02 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
12:04 AM Changeset in webkit [37185] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-02 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Qt build.

  • kjs/Error.h:

Oct 1, 2008:

11:44 PM Changeset in webkit [37184] by ggaren@apple.com
  • 54 edits
    1 copy in trunk

JavaScriptCore:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Preliminary step toward dynamic recompilation: Standardized and
simplified the parsing interface.


The main goal in this patch is to make it easy to ask for a duplicate
compilation, and get back a duplicate result -- same source URL, same
debugger / profiler ID, same toString behavior, etc.


The basic unit of compilation and evaluation is now SourceCode, which
encompasses a SourceProvider, a range in that provider, and a starting
line number.

A SourceProvider now encompasses a source URL, and *is* a source ID,
since a pointer is a unique identifier.

  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.


  • VM/CodeBlock.h: (JSC::EvalCodeCache::get): Provide a SourceCode to the Interpreter, since other APIs are no longer supported. (JSC::CodeBlock::CodeBlock): ASSERT something that used to be ASSERTed by our caller -- this is a better bottleneck.
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Updated for the fact that FunctionBodyNode's parameters are no longer a WTF::Vector.
  • kjs/Arguments.cpp: (JSC::Arguments::Arguments): ditto
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction): Provide a SourceCode to the Parser, since other APIs are no longer supported. Adopt FunctionBodyNode's new "finishParsing" API.
  • kjs/JSFunction.cpp: (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getParameterName): Updated for the fact that FunctionBodyNode's parameters are no longer a wtf::Vector.
  • kjs/JSFunction.h: Nixed some cruft.
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): Provide a SourceCode to the Parser, since other APIs are no longer supported.
  • kjs/Parser.cpp: (JSC::Parser::parse): Require a SourceCode argument, instead of a bunch of broken out parameters. Stop tracking sourceId as an integer, since we use the SourceProvider pointer for this now. Don't clamp the startingLineNumber, since SourceCode does that now.
  • kjs/Parser.h: (JSC::Parser::parse): Standardized the parsing interface to require a SourceCode.
  • kjs/Shell.cpp: (functionRun): (functionLoad): (prettyPrintScript): (runWithScripts): (runInteractive): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.
  • kjs/SourceProvider.h: (JSC::SourceProvider::SourceProvider): (JSC::SourceProvider::url): (JSC::SourceProvider::asId): (JSC::UStringSourceProvider::create): (JSC::UStringSourceProvider::UStringSourceProvider): Added new responsibilities described above.
  • kjs/SourceRange.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::toString): (JSC::SourceCode::provider): (JSC::SourceCode::firstLine): (JSC::SourceCode::data): (JSC::SourceCode::length): Added new responsibilities described above. Renamed SourceRange to SourceCode, based on review feedback. Added a makeSource function for convenience.
  • kjs/debugger.h: Provide a SourceCode to the client, since other APIs are no longer supported.
  • kjs/grammar.y: Provide startingLineNumber when creating a SourceCode.
  • kjs/debugger.h: Treat sourceId as intptr_t to avoid loss of precision on 64bit platforms.
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/interpreter.h: Require a SourceCode instead of broken out arguments.
  • kjs/lexer.cpp: (JSC::Lexer::setCode):
  • kjs/lexer.h: (JSC::Lexer::sourceRange): Fold together the SourceProvider and line number into a SourceCode. Fixed a bug where the Lexer would accidentally keep alive the last SourceProvider forever.
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::generateCode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::finishParsing): (JSC::FunctionBodyNode::create): (JSC::FunctionBodyNode::generateCode): (JSC::ProgramNode::generateCode): (JSC::FunctionBodyNode::paramString):
  • kjs/nodes.h: (JSC::ScopeNode::): (JSC::ScopeNode::sourceId): (JSC::FunctionBodyNode::): (JSC::FunctionBodyNode::parameterCount): (JSC::FuncExprNode::): (JSC::FuncDeclNode::): Store a SourceCode in all ScopeNodes, since SourceCode is now responsible for tracking URL, ID, etc. Streamlined some ad hoc FunctionBodyNode fixups into a "finishParsing" function, to help make clear what you need to do in order to finish parsing a FunctionBodyNode.
  • wtf/Vector.h: (WTF::::releaseBuffer): Don't ASSERT that releaseBuffer() is only called when buffer is not 0, since FunctionBodyNode is more than happy to get back a 0 buffer, and other functions like RefPtr::release() allow for 0, too.

JavaScriptGlue:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

  • JSRun.cpp: (JSRun::Evaluate): (JSRun::CheckSyntax): Provide a SourceCode to the Interpreter, since other APIs are no longer supported.

WebCore:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.

  • ForwardingHeaders/kjs/SourceRange.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::StringSourceProvider):

(WebCore::makeSource): Added a makeSource function for convenience.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject evaluateWebScript:]):
  • bridge/NP_jsobject.cpp: (_NPN_Evaluate):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::setMember): (JavaJSObject::removeMember):
  • bridge/jni/jni_runtime.h: (JSC::Bindings::JavaString::operator UString): Replaced the explicit ustring() function with an implicit operator because this class already holds a UString::rep.
  • page/Console.cpp: (WebCore::retrieveLastCaller): (WebCore::Console::trace):
  • page/InspectorController.cpp: (WebCore::jsStringRef): (WebCore::InspectorController::addBreakpoint): (WebCore::InspectorController::removeBreakpoint): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource):
  • page/InspectorController.h:
  • page/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • page/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::sourceIdentifier): (WebCore::JavaScriptCallFrame::update):
  • page/JavaScriptDebugListener.h:
  • page/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::addBreakpoint): (WebCore::JavaScriptDebugServer::removeBreakpoint): (WebCore::JavaScriptDebugServer::hasBreakpoint): (WebCore::dispatchDidParseSource): (WebCore::dispatchFailedToParseSource): (WebCore::JavaScriptDebugServer::sourceParsed): (WebCore::JavaScriptDebugServer::callEvent): (WebCore::JavaScriptDebugServer::atStatement): (WebCore::JavaScriptDebugServer::returnEvent): (WebCore::JavaScriptDebugServer::exception): (WebCore::JavaScriptDebugServer::willExecuteProgram): (WebCore::JavaScriptDebugServer::didExecuteProgram): (WebCore::JavaScriptDebugServer::didReachBreakpoint):
  • page/JavaScriptDebugServer.h:
  • page/inspector/ScriptsPanel.js: Renamed internal uses of sourceId and sourceIdentifier to sourceID.

WebKit/mac:

2008-10-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler and Cameron Zwarich.

Updated for JavaScriptCore API changes: use a SourceCode instead of
broken out parameters; treat sourceId as intptr_t.


We still treat sourceId as int in some cases because of DashCode. See
<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for
sourceId, not int.

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (toNSString): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception): (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram): (WebScriptDebugger::didReachBreakpoint):
11:08 PM Changeset in webkit [37183] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • fix SVGFontFaceElement leak seen on svg/custom/acid3-test-77.html

Broke a ref cycle by changing the m_svgFontFaceElement members of
CSSFontFaceSource and CSSFontFaceSrcValue from RefPtrs to plain
pointers. Also made sure that the @font-face rule added by
SVGFontFaceElement to the document's mapped element sheet is removed
when the font-face element is deleted or moved to another document.

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h: (WebCore::CSSFontFaceSource::svgFontFaceElement):
  • css/CSSFontFaceSrcValue.h: (WebCore::CSSFontFaceSrcValue::svgFontFaceElement): (WebCore::CSSFontFaceSrcValue::CSSFontFaceSrcValue):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::~SVGFontFaceElement): (WebCore::SVGFontFaceElement::willMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::didMoveToNewOwnerDocument): (WebCore::SVGFontFaceElement::removeFromMappedElementSheet):
  • svg/SVGFontFaceElement.h:
10:06 PM Changeset in webkit [37182] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21289: REGRESSION (r37160): Inspector crashes on load
<https://bugs.webkit.org/show_bug.cgi?id=21289>

The code in Arguments::mark() in r37160 was wrong. It marks indices in
d->registers, but that makes no sense (they are local variables, not
arguments). It should mark those indices in d->registerArray instead.

This patch also changes Arguments::copyRegisters() to use d->numParameters
instead of recomputing it.

  • kjs/Arguments.cpp: (JSC::Arguments::mark):
  • kjs/Arguments.h: (JSC::Arguments::copyRegisters):
10:02 PM Changeset in webkit [37181] by oliver@apple.com
  • 5 edits
    1 add
    1 delete in trunk/WebCore

Bug 20315: Memory leak with Canvas getImageData
<https://bugs.webkit.org/show_bug.cgi?id=20315>

Reviewed by Maciej Stachowiak

This wasn't a leak, the issue was that we were reporting the cost
of the CanvasPixelArray when creating the JSCanvasPixelArray wrapper
and we should have been reporting the cost when we create the
JSImageData wrapper.

9:54 PM Changeset in webkit [37180] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::~SVGMarkerElement): Call detach() here so that renderer destruction happens before the SVGMarkerElement is destroyed.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::~SVGSVGElement): Ditto for SVGSVGElement.
7:48 PM Changeset in webkit [37179] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

6:47 PM Changeset in webkit [37178] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20669

  • css/makeprop.pl: Die if gperf fails.
6:43 PM Changeset in webkit [37177] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-01 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

  • loader/icon/IconDatabase.h: IconDatabase uses HashMap, so it needs to #include the header.
6:35 PM Changeset in webkit [37176] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix an assertion failure in http/tests/security/canvas-remote-read-svg-image.html due to re-entry into Cache::pruneDeadResources()
  • loader/Cache.cpp: (WebCore::Cache::remove): Disable pruning temporarily during CachedResource deletion.
6:30 PM Changeset in webkit [37175] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-09-30 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Eliminate some unneeded uses of dynamicGlobalObject.

  • API/JSClassRef.cpp: (OpaqueJSClass::contextData): Changed to use a map in the global data instead of on the global object. Also fixed to use only a single hash table lookup.
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): Use lexicalGlobalObject rather than dynamicGlobalObject to get the object prototype.
  • kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use arrayVisitedElements set in global data rather than in the global object. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Don't initialize opaqueJSClassData, since it's no longer a pointer. (JSC::JSGlobalData::~JSGlobalData): We still need to delete all the values, but we don't need to delete the map since it's no longer a pointer.
  • kjs/JSGlobalData.h: Made opaqueJSClassData a map instead of a pointer to a map. Also added arrayVisitedElements.
  • kjs/JSGlobalObject.h: Removed arrayVisitedElements.
  • kjs/Shell.cpp: (functionRun): Use lexicalGlobalObject instead of dynamicGlobalObject. (functionLoad): Ditto.
6:05 PM Changeset in webkit [37174] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Fix Gtk repaint method finally. Should fix build bustage.

5:56 PM Changeset in webkit [37173] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update(). Make sure to include HostWindow.h

5:56 PM Changeset in webkit [37172] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/gtk/ScrollViewGtk.cpp

Fix Gtk bustage from removal of update().

5:48 PM Changeset in webkit [37171] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix SVGFontElement leaks seen on buildbot by breaking a ref cycle
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
  • svg/SVGFontFaceElement.h: (WebCore::SVGFontFaceElement::associatedFontElement):
5:40 PM Changeset in webkit [37170] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebView.cpp

Fix Win bustage.

5:22 PM Changeset in webkit [37169] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h

Fix Gtk bustage.

5:21 PM Changeset in webkit [37168] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollbarThemeQt.cpp

Fix Qt bustage.

5:20 PM Changeset in webkit [37167] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp

Fix Win bustage.

4:38 PM Changeset in webkit [37166] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculative Windows build fix.

  • kjs/grammar.y:
3:43 PM Changeset in webkit [37165] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

3:43 PM Changeset in webkit [37164] by hyatt@apple.com
  • 1 edit in trunk/WebCore/page/PrintContext.cpp

Fix Qt bustage.

3:34 PM Changeset in webkit [37163] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Document the rounding behavior of the mapRect(IntRect) function in
AffineTransform.h.

  • platform/graphics/AffineTransform.h:
3:30 PM Changeset in webkit [37162] by hyatt@apple.com
  • 13 edits in trunk

WebCore:

2008-10-01 David Hyatt <hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebCore.base.exp:
  • page/Frame.cpp: (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively): (WebCore::FrameView::setScrollPosition):
  • platform/ScrollView.cpp: (WebCore::ScrollView::init): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h: (WebCore::ScrollView::setProhibitsScrolling): (WebCore::ScrollView::prohibitsScrolling):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2008-10-01 David Hyatt <hyatt@apple.com>

Move prohibitsScrolling from the Frame to the ScrollView.

Reviewed by Sam Weinig

  • WebView/WebView.mm: (-[WebView setProhibitsMainFrameScrolling:]):
3:24 PM Changeset in webkit [37161] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix leaks seen during http/tests/xmlhttprequest/access-control-basic-non-simple-allow.html.

Reviewed by Geoff Garen.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoadingPreflight): Balance the ref and GC protect
that we do during the loadRequestAsynchronously of the preflight request with a deref and
GC unprotect.

3:18 PM Changeset in webkit [37160] by cwzwarich@webkit.org
  • 19 edits in trunk

2008-10-01 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 21123: using "arguments" in a function should not force creation of an activation object
<https://bugs.webkit.org/show_bug.cgi?id=21123>

Make the 'arguments' object not require a JSActivation. We store the
'arguments' object in the OptionalCalleeArguments call frame slot. We
need to be able to get the original 'arguments' object to tear it off
when returning from a function, but 'arguments' may be assigned to in a
number of ways.

Therefore, we use the OptionalCalleeArguments slot when we want to get
the original activation or we know that 'arguments' was not assigned a
different value. When 'arguments' may have been assigned a new value,
we use a new local variable that is initialized with 'arguments'. Since
a function parameter named 'arguments' may overwrite the value of
'arguments', we also need to be careful to look up 'arguments' in the
symbol table, so we get the parameter named 'arguments' instead of the
local variable that we have added for holding the 'arguments' object.

This is a 19.1% win on the V8 Raytrace benchmark using the SunSpider
harness, and a 20.7% win using the V8 harness. This amounts to a 6.5%
total speedup on the V8 benchmark suite using the V8 harness.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
  • VM/Machine.cpp: (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_init_arguments): (JSC::Machine::cti_op_ret_activation_arguments):
  • VM/Machine.h:
  • VM/RegisterFile.h: (JSC::RegisterFile::):
  • kjs/Arguments.cpp: (JSC::Arguments::mark): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::put):
  • kjs/Arguments.h: (JSC::Arguments::setRegisters): (JSC::Arguments::init): (JSC::Arguments::Arguments): (JSC::Arguments::copyRegisters): (JSC::JSActivation::copyRegisters):
  • kjs/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • kjs/grammar.y:
  • kjs/nodes.h: (JSC::ScopeNode::setUsesArguments):
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::orl_mr):

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/resources/arguments.js:
  • fast/js/resources/function-dot-arguments.js:
3:12 PM Changeset in webkit [37159] by hyatt@apple.com
  • 12 edits in trunk

2008-10-01 David Hyatt <hyatt@apple.com>

Rename allowsScrolling/setAllowsScrolling to canHaveScrollbars/setCanHaveScrollbars to make it more
clear that the boolean doesn't actually stop all scrolling. It just gets rid of scrollbars.

Reviewed by Tim Hatcher

  • WebCore.base.exp:
  • page/FrameView.cpp: (WebCore::FrameView::setCanHaveScrollbars):
  • page/FrameView.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setCanHaveScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::canHaveScrollbars):
2:48 PM Changeset in webkit [37158] by hyatt@apple.com
  • 1 edit in trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

Fix Win bustage.

2:19 PM Changeset in webkit [37157] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix some CachedResource leaks seen on buildbot

The issue here was that emptying the cache was a no-op when it only
contained resources with no data. Changed to go after those
resources when the desired cache capacity is zero.

  • loader/Cache.cpp: (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources):
  • loader/Cache.h: (WebCore::Cache::prune):
2:11 PM Changeset in webkit [37156] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make isOffscreen cross-platform. Only Mac implements this method, so hold off on adding API to the
HostWindow object until other platforms decide they want this method. (We need it for Win though at some point.)

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::isOffscreen): (WebCore::ScrollView::platformIsOffscreen):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformIsOffscreen):
  • platform/qt/ScrollViewQt.cpp:
  • platform/wx/ScrollViewWx.cpp:
1:58 PM Changeset in webkit [37155] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make show/hide/setParentVisible cross-platform on ScrollView.

Reviewed by Adam Roben

  • platform/ScrollView.cpp: (WebCore::ScrollView::setParentVisible): (WebCore::ScrollView::show): (WebCore::ScrollView::hide):
  • platform/ScrollView.h:
  • platform/win/ScrollViewWin.cpp:
1:41 PM Changeset in webkit [37154] by kmccullough@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • Added layout test fast/css/max-height-and-max-width.html
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21284
Bug 21284: Max height affects max width

  • Looks like a cut and paste bug
  • fast/css/max-height-and-max-width-expected.txt: Added.
  • fast/css/max-height-and-max-width.html: Added.
1:34 PM Changeset in webkit [37153] by hyatt@apple.com
  • 25 edits in trunk

WebCore:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::screenToWindow): (WebCore::EmptyChromeClient::windowToScreen):
  • page/Chrome.cpp: (WebCore::Chrome::screenToWindow): (WebCore::Chrome::windowToScreen):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::contentsToScreen): (WebCore::ScrollView::screenToContents): (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformContentsToScreen): (WebCore::ScrollView::platformScreenToContents):
  • platform/win/ScrollViewWin.cpp:

WebKit/gtk:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowToScreen): (WebKit::ChromeClient::screenToWindow):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::repaint): (WebChromeClient::screenToWindow): (WebChromeClient::windowToScreen):

WebKit/qt:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::windowToScreen): (WebCore::ChromeClientQt::screenToWindow):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::windowToScreen): (WebChromeClient::screenToWindow):
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-01 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21282


Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.


Reviewed by Adam Roben

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::windowToScreen): (WebCore::ChromeClientWx::screenToWindow):
  • WebKitSupport/ChromeClientWx.h:
1:31 PM Changeset in webkit [37152] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)

Test: fast/parser/residual-style-close-across-removed-block.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an assertion that turned out to be wrong in this case, and changed to terminate the algorithm at the first empty block.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6255862> domfuzz: null deref in WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks(WebCore::HTMLStackElem*)
  • fast/parser/residual-style-close-across-removed-block-expected.txt: Added.
  • fast/parser/residual-style-close-across-removed-block.html: Added.
12:24 PM Changeset in webkit [37151] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollView.h

Fix Mac bustage. Make sure the setFrameRect method is moved outside the ifdef in the header.

12:23 PM Changeset in webkit [37150] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-10-01 David Hyatt <hyatt@apple.com>

Make setFrameRect on ScrollView cross-platform.

Reviewed by Sam Weinig

  • page/FrameView.h: (WebCore::FrameView::contentsResized):
  • platform/ScrollView.cpp: (WebCore::ScrollView::setFrameRect):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
12:17 PM Changeset in webkit [37149] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-10-01 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Move setTimeout, clearTimeout, setInterval, clearInterval, atob and btoa
to JSDOMWindow from JSDOMWindowBase.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::removeTimeout):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa):
  • page/DOMWindow.idl:
11:40 AM Changeset in webkit [37148] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-01 Kevin McCullough <kmccullough@apple.com>

Rubberstamped by Geoff .

Remove BreakpointCheckStatement because it's not used anymore.
No effect on sunspider or the jsc tests.

  • kjs/nodes.cpp:
  • kjs/nodes.h:
11:12 AM Changeset in webkit [37147] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Mac build fix
  • WebCore.base.exp:
10:51 AM Changeset in webkit [37146] by hyatt@apple.com
  • 25 edits in trunk

Make ScrollView::paint cross-platform.

10:33 AM Changeset in webkit [37145] by timothy@apple.com
  • 2 edits in trunk/WebCore

Prevent stealing focus from the search field when focusing a DOM node.

https://bugs.webkit.org/show_bug.cgi?id=21275

Reviewed by Kevin McCullough.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel.treeOutline.focusedNodeChanged): Don't steal focus if the current focus element is the search field.
6:32 AM QtWebKitJournal edited by Simon Hausmann
(diff)
12:59 AM Changeset in webkit [37144] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

Speculative fix for Gtk bustage.

12:55 AM Changeset in webkit [37143] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

12:27 AM Changeset in webkit [37142] by weinig@apple.com
  • 16 edits in trunk/WebCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Nikolas Zimmermann and Alexey Proskuryakov.

Final patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Generate getting/setting of EventListeners.
  • Adding a new named EventListener now has the same process as adding any other DOM attribute. (Add a method with the same name in the c++ file).

(The EventListeners for MessagePort have been intentionally left custom so that we
can continue to experiment with making those EventListeners work in a frame-less world.)

  • bindings/js/JSDOMApplicationCacheCustom.cpp: Remove custom methods.
  • bindings/js/JSDOMWindowCustom.cpp: ditto.
  • bindings/js/JSEventTargetNodeCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestCustom.cpp: ditto.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Add code to generate EventListener getter/setters
  • dom/EventTargetNode.cpp: Add getter/setters for named EventListener.
  • dom/EventTargetNode.h: ditto.
  • dom/EventTargetNode.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • loader/appcache/DOMApplicationCache.idl: Remove custom attributes..
  • page/DOMWindow.cpp: Add getter/setters for named EventListener
  • page/DOMWindow.h: ditto.
  • page/DOMWindow.idl: Mark EventListeners as Protected so that the codegenerator will use JSEventListerner instead of JSUnprotectedEventListener.
  • xml/XMLHttpRequest.idl: Remove custom attributes.
  • xml/XMLHttpRequestUpload.idl: ditto.

Sep 30, 2008:

11:57 PM Changeset in webkit [37141] by mrowe@apple.com
  • 1 edit in trunk/WebCore/loader/CachedResource.cpp

A-Z.

11:53 PM Changeset in webkit [37140] by mrowe@apple.com
  • 4 edits in trunk

Add a leak counter for CachedResources since we've had two recent leaks involving them.

Reviewed by Dan Bernstein.

11:25 PM Changeset in webkit [37139] by mitz@apple.com
  • 4 edits
    2 moves in trunk/WebCore

Reviewed by Dave Hyatt.

If TTLoadEmbeddedFont fails, use AddFontMemResourceEx after changing
the font name in memory.

  • WebCore.vcproj/WebCore.vcproj: Renamed GetEOTHeader.* to OpenTypeUtilities.*.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): Added a call to RemoveFontMemResourceEx to match AddFontMemResourceEx when it is used. (WebCore::FontCustomPlatformData::fontPlatformData): Added a code path for fonts loaded using AddFontMemResourceEx. (WebCore::createFontCustomPlatformData): Added a call to renameAndActivateFont() if TTLoadEmbeddedFont fails. If TTLoadEmbeddedFont succeeds, set the font name to the null string, as fontPlatformData() will retrieve the name from the font reference.
  • platform/graphics/win/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Added a font name member.
  • platform/graphics/win/GetEOTHeader.cpp: Renamed.
  • platform/graphics/win/GetEOTHeader.h: Renamed.
  • platform/graphics/win/OpenTypeUtilities.cpp: Copied from platform/graphics/win/GetEOTHeader.cpp. (WebCore::BigEndianUShort::BigEndianUShort): Added a constructor. (WebCore::BigEndianULong::BigEndianULong): Ditto. (WebCore::renameAndActivateFont): Added. Creates an in-memory copy of the font data and modifies it to have the given name, then activates it using AddFontMemResourceEx.
  • platform/graphics/win/OpenTypeUtilities.h: Copied from platform/graphics/win/GetEOTHeader.h.
11:16 PM Changeset in webkit [37138] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Improve performance of CTI on windows.

Reviewed by Geoff Garen

Currently on platforms where the compiler doesn't allow us to safely
index relative to the address of a parameter we need to actually
provide a pointer to CTI runtime call arguments. This patch improves
performance in this case by making the CTI logic for restoring this
parameter much less conservative by only resetting it before we actually
make a call, rather than between each and every SF bytecode we generate
code for.

This results in a 3.6% on the v8 benchmark when compiled with MSVC.

11:09 PM Changeset in webkit [37137] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix many leaks seen on fast/backgrounds/svg-as-mask.html.

Reviewed by Dan Bernstein.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::arenaDelete): Balance the calls to addClient on maskLayer's images
with calls to removeClient when we're being destroyed.

10:45 PM Changeset in webkit [37136] by eric.carlson@apple.com
  • 4 edits
    4 adds in trunk

2008-09-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21243

Fix loopstart and loopend default values.

Tests: media/loopend-limits.html

media/loopstart-limits.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::loopStart): the spec says start() is the default value (WebCore::HTMLMediaElement::loopEnd): the spec says end() is the default value

2008-09-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti

https://bugs.webkit.org/show_bug.cgi?id=21243

Test default loopstart and loopend values.

  • media/loopend-limits-expected.txt: Added.
  • media/loopend-limits.html: Added.
  • media/loopstart-limits-expected.txt: Added.
  • media/loopstart-limits.html: Added.
  • media/video-test.js:
10:29 PM Changeset in webkit [37135] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.

JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
torn down before we exit.

Rubber-stamped by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(main):

10:04 PM Changeset in webkit [37134] by kevino@webkit.org
  • 3 edits in trunk/WebCore

wx build fixes. Add file to build and remove call to (now gone) ScrollView::update.

9:43 PM Changeset in webkit [37133] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix HTMLViewSourceDocument leaks by breaking a ref cycle which was fixed in r17249 and re-introduced in r31435.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLine): (WebCore::HTMLViewSourceDocument::addLink):
  • html/HTMLViewSourceDocument.h:
7:57 PM Changeset in webkit [37132] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-09-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

  • track uses of "this", "with" and "catch" in the parser


Knowing this up front will be useful for future optimizations.


Perf and correctness remain the same.


  • kjs/NodeInfo.h:
  • kjs/grammar.y:
6:05 PM Changeset in webkit [37131] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Remove the NPDrawingModelOpenGL entirely. To my knowledge no shipping plug-in ever used it, and no other browser engine
ever supported it.


  • Plugins/WebBaseNetscapePluginView.h: Removed AGL.h import and OpenGL related ivars.
  • Plugins/WebBaseNetscapePluginView.mm: Removed soft linking for OpenGL and AGL frameworks. Also removed many methods AGL/CGL support methods that are no longer necessary. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed NPDrawingModelOpenGL related code. (-[WebBaseNetscapePluginView restorePortState:]): Ditto. (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Ditto. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Ditto. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto. (-[WebBaseNetscapePluginView stop]): Ditto. (-[WebBaseNetscapePluginView dealloc]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Ditto. (-[WebBaseNetscapePluginView invalidateRegion:]): Ditto. (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins WebKit does not support NPDrawingModelOpenGL. (-[WebBaseNetscapePluginView setVariable:value:]): Removed NPDrawingModelOpenGL related code. (-[WebBaseNetscapePluginView _viewHasMoved]): Ditto.
6:00 PM Changeset in webkit [37130] by dino@apple.com
  • 3 edits in trunk/LayoutTests

2008-09-30 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Remove console output that can cause test to fail on slow
machines.

  • animations/transition-and-animation-2-expected.txt:
  • animations/transition-and-animation-2.html:
5:43 PM Changeset in webkit [37129] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2008-09-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

Don't run pixel comparison for text-only tests.
https://bugs.webkit.org/show_bug.cgi?id=21124

  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • Scripts/run-webkit-tests:
5:39 PM Changeset in webkit [37128] by weinig@apple.com
  • 24 edits in trunk/WebCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

More for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Make EventListener getter/setters names in c++ files match those in JS (ie. onLoadListener -> onload).
  • Add standard way to access the frame associated with the EventTarget for EventListener lookup.
  • Autogenerate dispatchEvent, it wasn't doing anything custom.
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener): (WebCore::JSDOMApplicationCache::setOnchecking): (WebCore::JSDOMApplicationCache::onchecking): (WebCore::JSDOMApplicationCache::setOnerror): (WebCore::JSDOMApplicationCache::onerror): (WebCore::JSDOMApplicationCache::setOnnoupdate): (WebCore::JSDOMApplicationCache::onnoupdate): (WebCore::JSDOMApplicationCache::setOndownloading): (WebCore::JSDOMApplicationCache::ondownloading): (WebCore::JSDOMApplicationCache::setOnprogress): (WebCore::JSDOMApplicationCache::onprogress): (WebCore::JSDOMApplicationCache::setOnupdateready): (WebCore::JSDOMApplicationCache::onupdateready): (WebCore::JSDOMApplicationCache::setOncached): (WebCore::JSDOMApplicationCache::oncached):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::setListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::onmessage): (WebCore::JSMessagePort::setOnclose): (WebCore::JSMessagePort::onclose):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::mark): (WebCore::JSXMLHttpRequest::onreadystatechange): (WebCore::JSXMLHttpRequest::setOnreadystatechange): (WebCore::JSXMLHttpRequest::onabort): (WebCore::JSXMLHttpRequest::setOnabort): (WebCore::JSXMLHttpRequest::onerror): (WebCore::JSXMLHttpRequest::setOnerror): (WebCore::JSXMLHttpRequest::onload): (WebCore::JSXMLHttpRequest::setOnload): (WebCore::JSXMLHttpRequest::onloadstart): (WebCore::JSXMLHttpRequest::setOnloadstart): (WebCore::JSXMLHttpRequest::onprogress): (WebCore::JSXMLHttpRequest::setOnprogress): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): (WebCore::JSXMLHttpRequestUpload::onabort): (WebCore::JSXMLHttpRequestUpload::setOnabort): (WebCore::JSXMLHttpRequestUpload::onerror): (WebCore::JSXMLHttpRequestUpload::setOnerror): (WebCore::JSXMLHttpRequestUpload::onload): (WebCore::JSXMLHttpRequestUpload::setOnload): (WebCore::JSXMLHttpRequestUpload::onloadstart): (WebCore::JSXMLHttpRequestUpload::setOnloadstart): (WebCore::JSXMLHttpRequestUpload::onprogress): (WebCore::JSXMLHttpRequestUpload::setOnprogress): (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::associatedFrame):
  • dom/EventTargetNode.h:
  • dom/EventTargetNode.idl:
  • dom/MessagePort.cpp: (WebCore::MessagePort::associatedFrame):
  • dom/MessagePort.h: (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::onmessage): (WebCore::MessagePort::setOnclose): (WebCore::MessagePort::onclose):
  • dom/MessagePort.idl:
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::associatedFrame):
  • loader/appcache/DOMApplicationCache.idl:
  • svg/EventTargetSVGElementInstance.cpp: (WebCore::EventTargetSVGElementInstance::associatedFrame): (WebCore::EventTargetSVGElementInstance::addEventListener): (WebCore::EventTargetSVGElementInstance::removeEventListener): (WebCore::EventTargetSVGElementInstance::dispatchEvent):
  • svg/EventTargetSVGElementInstance.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::associatedFrame):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setOnreadystatechange): (WebCore::XMLHttpRequest::onreadystatechange): (WebCore::XMLHttpRequest::setOnabort): (WebCore::XMLHttpRequest::onabort): (WebCore::XMLHttpRequest::setOnerror): (WebCore::XMLHttpRequest::onerror): (WebCore::XMLHttpRequest::setOnload): (WebCore::XMLHttpRequest::onload): (WebCore::XMLHttpRequest::setOnloadstart): (WebCore::XMLHttpRequest::onloadstart): (WebCore::XMLHttpRequest::setOnprogress): (WebCore::XMLHttpRequest::onprogress):
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::associatedFrame):
  • xml/XMLHttpRequestUpload.h: (WebCore::XMLHttpRequestUpload::setOnabort): (WebCore::XMLHttpRequestUpload::onabort): (WebCore::XMLHttpRequestUpload::setOnerror): (WebCore::XMLHttpRequestUpload::onerror): (WebCore::XMLHttpRequestUpload::setOnload): (WebCore::XMLHttpRequestUpload::onload): (WebCore::XMLHttpRequestUpload::setOnloadstart): (WebCore::XMLHttpRequestUpload::onloadstart): (WebCore::XMLHttpRequestUpload::setOnprogress): (WebCore::XMLHttpRequestUpload::onprogress):
  • xml/XMLHttpRequestUpload.idl:
5:38 PM Changeset in webkit [37127] by Darin Adler
  • 2 edits in trunk/WebCore

2008-09-30 Darin Adler <Darin Adler>

  • roll out assertion breaking regression tests
  • platform/ScrollView.cpp: (WebCore::ScrollView::repaintContentRectangle): Temporarily remove assertion that fires in regression tests. Hyatt can add it back later. The assertion fires in the regression test because of layout that triggers repaint occuring during the process of removing a frame.
4:58 PM Changeset in webkit [37126] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-30 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add WebKitAvailability macros for JSObjectMakeArray, JSObjectMakeDate, JSObjectMakeError,
and JSObjectMakeRegExp

  • API/JSObjectRef.h:
4:46 PM Changeset in webkit [37125] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2008-09-30 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Replaced the m_prev field of ExecState with a bit in the
call frame pointer to indicate "host" call frames.

  • VM/Machine.cpp: (JSC::makeHostCallFramePointer): Added. Sets low bit. (JSC::isHostCallFrame): Added. Checks low bit. (JSC::stripHostCallFrameBit): Added. Clears low bit. (JSC::Machine::unwindCallFrame): Replaced null check that was formerly used to detect host call frames with an isHostCallFrame check. (JSC::Machine::execute): Pass in a host call frame pointer rather than always passing 0 when starting execution from the host. This allows us to follow the entire call frame pointer chain when desired, or to stop at the host calls when that's desired. (JSC::Machine::privateExecute): Replaced null check that was formerly used to detect host call frames with an isHostCallFrame check. (JSC::Machine::retrieveCaller): Ditto. (JSC::Machine::retrieveLastCaller): Ditto. (JSC::Machine::callFrame): Removed the code to walk up m_prev pointers and replaced it with code that uses the caller pointer and uses the stripHostCallFrameBit function.
  • kjs/ExecState.cpp: Removed m_prev.
  • kjs/ExecState.h: Ditto.
4:24 PM Changeset in webkit [37124] by hyatt@apple.com
  • 1 edit in trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

Fix Qt bustage.

4:21 PM Changeset in webkit [37123] by adele@apple.com
  • 19 edits
    8 adds in trunk

WebCore:

2008-09-30 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21227
<rdar://problem/6222134> add a way to set color for input placeholder text

Test: fast/forms/placeholder-pseudo-style.html

This change adds "-webkit-input-placeholder-mode" as a pseudo class that can be used to style
input elements when they are displaying the placeholder text.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Add case for inputPlaceholderMode.
  • css/CSSSelector.h: (WebCore::CSSSelector::): Add PseudoInputPlaceholderMode.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add check for PseudoInputPlaceholderMode that asks the node if placeholderShouldBeVisible is true.
  • css/html4.css: Add rule to make placeholder text default to darkGray.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initialize m_placeholderShouldBeVisible. (WebCore::HTMLInputElement::dispatchFocusEvent): Call updatePlaceholderVisibility. (WebCore::HTMLInputElement::dispatchBlurEvent): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): ditto. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Sets m_placeholderShouldBeVisible based on the current value and the focus state. This calculation used to be done in the renderer, but since the node knows everything about the state, it can make that decision, and the renderer will just ask the node if it should draw the placeholder.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::placeholderShouldBeVisible):
  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Moved to the top of the file. If there's not very much contrast between the disabled color and the background color, just leave the text color alone. We don't want to change a good contrast color scheme so that it has really bad contrast. If the the contrast was already poor, then it doesn't do any good to change it to a different poor contrast color scheme. (WebCore::RenderTextControl::createInnerTextStyle): If the node says the placeholder should be visible, prepare by overriding the text security to be "none". This can only happen as a result of either a setStyle call (which will be followed by a call to updateFromElement) or from createSubtreeIfNeeded, which is called directly from updateFromElement. updateFromElement will immediately update the text displayed. (WebCore::RenderTextControl::updateFromElement): If the placeholder visibility has changed, update the text that is displayed. (WebCore::RenderTextControl::forwardEvent): Remove calls to update the placeholder state. This is now done in HTMLInputElement.
  • rendering/RenderTextControl.h:

LayoutTests:

2008-09-30 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Tests for https://bugs.webkit.org/show_bug.cgi?id=21227
<rdar://problem/6222134> add a way to set color for input placeholder text

  • fast/forms/password-placeholder-text-security.html: Added.
  • fast/forms/placeholder-pseudo-style.html: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: Added.

Updated results. The placeholder color is now reflected on the RenderTextControl, not just on an inner element.

  • platform/mac/fast/forms/input-disabled-color-expected.checksum:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.checksum:
  • platform/mac/fast/forms/password-placeholder-expected.png:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.png:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
4:19 PM Changeset in webkit [37122] by Beth Dakin
  • 3 edits
    2 adds in trunk

WebCore:

2008-09-30 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
by failed allocation due to invalid counter/attr
and corresponding: <rdar://problem/6152371>

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounterContent): The spec indicates that only identifiers should be accepted here.

LayoutTests:

2008-09-30 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=20396 Abort caused
by failed allocation due to invalid counter/attr
and corresponding: <rdar://problem/6152371>

  • fast/css/counters/counter-number-input-expected.txt: Added.
  • fast/css/counters/counter-number-input.html: Added.
3:33 PM Changeset in webkit [37121] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

Bug 21255: console.profileEnd() without a console.profile() crashes the
web inspector

  • page/Console.cpp: (WebCore::Console::profileEnd):
3:31 PM Changeset in webkit [37120] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21252: calling console.profile() with a title that is 2 chars or
shorter does not linkify it

  • Previously we tried to not linkify very short URLs but since profile titles can be any length this is not always true.
  • page/inspector/inspector.js:
3:30 PM Changeset in webkit [37119] by mrowe@apple.com
  • 20 edits in tags/Safari-6528.4.1/WebCore/platform

Remove bogus executable bit from some source files.

3:28 PM Changeset in webkit [37118] by mrowe@apple.com
  • 20 edits in trunk/WebCore/platform

Remove bogus executable bit from some source files.

3:17 PM Changeset in webkit [37117] by cwzwarich@webkit.org
  • 7 edits
    3 adds in trunk

2008-09-30 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move all detection of 'arguments' in a lexical scope to the parser, in
preparation for fixing

Bug 21123: using "arguments" in a function should not force creation of an activation object
<https://bugs.webkit.org/show_bug.cgi?id=21123>

JavaScriptCore:

  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator):
  • kjs/NodeInfo.h:
  • kjs/grammar.y:

LayoutTests:

  • fast/js/arguments-expected.txt:
  • fast/js/function-dot-arguments-expected.txt: Added.
  • fast/js/function-dot-arguments.html: Added.
  • fast/js/resources/arguments.js:
  • fast/js/resources/function-dot-arguments.js: Added.
2:46 PM Changeset in webkit [37116] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-30 Geoffrey Garen <ggaren@apple.com>

Not reviewed.

  • kjs/Shell.cpp: (runWithScripts): Fixed indentation.
2:34 PM Changeset in webkit [37115] by timothy@apple.com
  • 67 edits in trunk/WebCore/page/inspector/Images

Add the image/png mime-type to the Web Inspector images to make Mark and Dan happy.

2:31 PM Changeset in webkit [37114] by hyatt@apple.com
  • 2 edits in trunk/WebKit

Tweak the Gtk/Qt ChromeClient methods structurally to make sure immediate displays/flushes can happen even if the content doesn't change.

2:30 PM Changeset in webkit [37113] by hyatt@apple.com
  • 9 edits in trunk/WebCore

Eliminate the ScrollView update() method.

2:04 PM Changeset in webkit [37112] by mrowe@apple.com
  • 11 edits
    2 deletes in trunk

Roll out r37060 as it introduced many, many leaks.

1:57 PM Changeset in webkit [37111] by timothy@apple.com
  • 3 edits in trunk/WebCore

Focus the DOM tree in the Web Inspector when a node is inspected.
So when the search field has focus, the focus moves to the tree,
allowing the arrow keys work. This can happen when using the new
find in page feature.

https://bugs.webkit.org/show_bug.cgi?id=21251

Reviewed by Geoff Garen.

  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Set currentFocusElement to the main-panels element if the panel is visible. (WebInspector.ElementsPanel.prototype.updateBreadcrumb): Remove a set of currentFocusElement since this moved.
  • page/inspector/inspector.js: (WebInspector.set currentFocusElement): Always focus the element. This ensures that when focus changes in the page and we don't catch it, we will still focus the elements even if we think it was already focused.
1:57 PM Changeset in webkit [37110] by timothy@apple.com
  • 8 edits in trunk/WebCore

Make the Web Inspector's toolbar icons darker when the mouse is
pressed on them. This matches the standard NSToolbar look.

https://bugs.webkit.org/show_bug.cgi?id=21249
rdar://problem/6033752

Reviewed by Adam Roben.

  • page/inspector/Images/databasesIcon.png:
  • page/inspector/Images/elementsIcon.png:
  • page/inspector/Images/profilesIcon.png:
  • page/inspector/Images/resourcesIcon.png:
  • page/inspector/Images/scriptsIcon.png:
  • page/inspector/Panel.js:
  • page/inspector/inspector.css:
1:56 PM Changeset in webkit [37109] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix qt bustage.

1:27 PM Changeset in webkit [37108] by mrowe@apple.com
  • 1 edit in tags/Safari-6528.4.1/JavaScriptCore/JavaScriptCore.exp

Build fix.

1:27 PM Changeset in webkit [37107] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.exp

Build fix.

1:26 PM Changeset in webkit [37106] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-09-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

Bug 21139: Profiler log message is wrong

  • Correctly fix =( Don't call _format twice.
  • page/Page.h:
  • page/inspector/Console.js:
  • page/inspector/ProfilesPanel.js:
  • page/inspector/inspector.js:
1:09 PM Changeset in webkit [37105] by hyatt@apple.com
  • 32 edits in trunk

Make ScrollView's updateContents method cross-platform.

12:42 PM Changeset in webkit [37104] by mrowe@apple.com
  • 3 edits in tags/Safari-6528.4.1/JavaScriptCore

Merge r37103.

12:38 PM Changeset in webkit [37103] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Build fix.

Move InternalFunction::classInfo implementation into the .cpp file to
prevent the vtable for InternalFunction being generated as a weak symbol.
Has no effect on SunSpider.

Rubber-stamped by Sam Weinig.

  • kjs/InternalFunction.cpp:

(JSC::InternalFunction::classInfo):

  • kjs/InternalFunction.h:
12:29 PM Changeset in webkit [37102] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-09-30 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe and Adam Roben.

No need to use pointers to store C++ objects as pointers in WebViewPrivate, we can just
store them directly.


  • Configurations/Base.xcconfig: Set GCC_OBJC_CALL_CXX_CDTORS to YES.


  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView WebCore::_userAgentForURL:WebCore::]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:05 AM Changeset in webkit [37101] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.4.1

Versioning.

11:02 AM Changeset in webkit [37100] by mrowe@apple.com
  • 6 edits
    2 deletes in tags/Safari-6528.4.1

Merge r36902.

11:00 AM Changeset in webkit [37099] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4.1

New tag.

10:58 AM Changeset in webkit [37098] by ap@webkit.org
  • 6 edits in trunk/WebCore

Non-Mac build fixes.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl:
  • webcore-base.bkl: Added DOMProtect.{cpp,h}.
10:40 AM Changeset in webkit [37097] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • bridge/npapi.h: Added skeleton for a new plug-in drawing model, the NPCoreAnimationDrawingModel. This model will eventually pave the way for hardware accelerated drawing in plug-ins and out of process plug-in rendering.
10:05 AM Changeset in webkit [37096] by jchaffraix@webkit.org
  • 11 edits in trunk/WebCore

2008-09-29 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

  • Removed "cppNamespace" global parameter and hard-coded "WebCore" as it is the only namespace used.
  • Removed "generateFactory" and "generateWrapperFactory" parameters and re-introduced the command line options.
  • Cleaned up the output of make_names.pl (removed unneeded new line).
  • DerivedSources.make: Added factories command line options.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto and removed some arguments that were migrated to the .in files.
  • dom/make_names.pl: Clean up (see above).
  • html/HTMLAttributeNames.in: Removed "cppNamespace", "generateFactory" and "generateWrapperFactory" occurences.
  • html/HTMLTagNames.in: Ditto.
  • svg/svgattrs.in: Ditto.
  • svg/svgtags.in: Ditto.
  • svg/xlinkattrs.in: Ditto.
  • xml/xmlattrs.in: Ditto.
9:19 AM Changeset in webkit [37095] by Chris Fleizach
  • 5 edits
    2 adds in trunk

<rdar://problem/6255456> AX: <file> input button shouldn't have children exposed

8:52 AM Changeset in webkit [37094] by ap@webkit.org
  • 7 edits
    6 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21213
MessagePort crash when GC collects an object with a pending close event

Test: fast/events/message-channel-gc-2.html

fast/events/message-channel-listener-circular-ownership.html

  • bindings/DOMProtect.cpp: Added. (WebCore::gcProtectDOMObject): (WebCore::gcUnprotectDOMObject):
  • bindings/DOMProtect.h: Added. Added an abstraction for GC protection to avoid the need to call JS bindings code from DOM objects directly.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::fired): (WebCore::MessagePort::queueCloseEvent): GC protect MessagePort wrapper while there is a pending close event. This may be necessary for message events, too, but that case is not a crasher, and actually behaves to the letter of the current HTML5 text, so I'll consider it later.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::dropProtection): Use gcProtectDOMObject here, too. Unfortunately, XMLHttpRequest has more dependencies on JSC.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose): Don't tell DOMWindowBase that MessagePort is a NodeEventTarget, this is not true. I do not know if this was causing any real issues, but we shouldn't lie to DOMWindowBase.
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::mark): While at it, changed to use a typedef for event listeners from XMLHttpRequestUpload, not from XMLHttpRequest.
7:17 AM Changeset in webkit [37093] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • DerivedSources.cpp: Add JSEventTargetNode.cpp.
12:42 AM Changeset in webkit [37092] by hyatt@apple.com
  • 2 edits in trunk/WebCore/platform

Fix gtk qt bustage.

12:10 AM Changeset in webkit [37091] by cwzwarich@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

2008-09-30 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Add the performance improvement to the ChangeLog entry for r37050.

  • ChangeLog
12:01 AM Changeset in webkit [37090] by weinig@apple.com
  • 12 edits
    4 adds
    3 deletes in trunk/WebCore

2008-09-29 Sam Weinig <sam@webkit.org>

Reviewed by Tim Hatcher.

Patch for https://bugs.webkit.org/show_bug.cgi?id=21122
Autogenerate JS event listeners

  • Generate EventTargetNode.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventTarget.cpp: Added. (WebCore::toJS):
  • bindings/js/JSEventTarget.h: Added.
  • bindings/js/JSEventTargetBase.cpp: Removed.
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSEventTargetNode.cpp: Removed.
  • bindings/js/JSEventTargetNode.h: Removed.
  • bindings/js/JSEventTargetNodeCustom.cpp: Added. (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener): (WebCore::JSEventTargetNode::dispatchEvent): (WebCore::JSEventTargetNode::getListener): (WebCore::JSEventTargetNode::setListener): (WebCore::JSEventTargetNode::pushEventHandlerScope):
  • bindings/js/JSEventTargetSVGElementInstance.cpp: (WebCore::): (WebCore::JSEventTargetSVGElementInstancePrototype::self): (WebCore::JSEventTargetSVGElementInstancePrototype::getOwnPropertySlot): (jsEventTargetAddEventListener): (jsEventTargetRemoveEventListener): (jsEventTargetDispatchEvent):
  • bindings/js/JSEventTargetSVGElementInstance.h: (WebCore::JSEventTargetSVGElementInstancePrototype::JSEventTargetSVGElementInstancePrototype): (WebCore::JSEventTargetSVGElementInstancePrototype::classInfo):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/EventTargetNode.idl: Added.

Sep 29, 2008:

6:31 PM Changeset in webkit [37089] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.



It's pretty common in real-world code (and on some of the v8
benchmarks) to append a number to a string, so I made this one of
the fast cases, and also added support to UString to do it
directly without allocating a temporary UString.


~1% speedup on v8 benchmark.

  • VM/Machine.cpp: (JSC::jsAddSlowCase): Make this NEVER_INLINE because somehow otherwise the change is a regression. (JSC::jsAdd): Handle number + string special case. (JSC::Machine::cti_op_add): Integrate much of the logic of jsAdd to avoid exception check in the str + str, num + num and str + num cases.
  • kjs/ustring.cpp: (JSC::expandedSize): Make this a non-member function, since it needs to be called in non-member functions but not outside this file. (JSC::expandCapacity): Ditto. (JSC::UString::expandCapacity): Call the non-member version. (JSC::createRep): Helper to make a rep from a char*. (JSC::UString::UString): Use above helper. (JSC::concatenate): Guts of concatenating constructor for cases where first item is a UString::Rep, and second is a UChar* and length, or a char*. (JSC::UString::append): Implement for cases where first item is a UString::Rep, and second is an int or double. Sadly duplicates logic of UString::from(int) and UString::from(double).
  • kjs/ustring.h:
6:14 PM Changeset in webkit [37088] by Darin Adler
  • 10 edits in trunk

JavaScriptCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • JavaScriptCore.exp: Updated since JSGlobalObject::init no longer takes a parameter.
  • VM/Machine.cpp: (JSC::Machine::execute): Removed m_registerFile argument for ExecState constructors.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue argument for ExecState constructor.
  • kjs/ExecState.cpp: (JSC::ExecState::ExecState): Removed globalThisValue and registerFile arguments to constructors.
  • kjs/ExecState.h: Removed m_globalThisValue and m_registerFile data members.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Removed globalThisValue argument for ExecState constructor.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter for the init function.

WebCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument for base class constructor.
6:03 PM Changeset in webkit [37087] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Rubber-stamped by Cameron Zwarich.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21225
Machine::retrieveLastCaller should check for a NULL codeBlock


In order to crash, you would need to call retrieveCaller in a situation
where you had two host call frames in a row in the register file. I
don't know how to make that happen, or if it's even possible, so I don't
have a test case -- but better safe than sorry!

  • VM/Machine.cpp: (JSC::Machine::retrieveLastCaller):
5:46 PM Changeset in webkit [37086] by ggaren@apple.com
  • 13 edits
    2 copies
    6 adds in trunk

JavaScriptCore:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Store the callee ScopeChain, not the caller ScopeChain, in the call frame
header. Nix the "scopeChain" local variable and ExecState::m_scopeChain, and
access the callee ScopeChain through the call frame header instead.

Profit: call + return are simpler, because they don't have to update the
"scopeChain" local variable, or ExecState::m_scopeChain.


Because CTI keeps "r" in a register, reading the callee ScopeChain relative
to "r" can be very fast, in any cases we care to optimize.

0% speedup on empty function call benchmark. (5.5% speedup in bytecode.)
0% speedup on SunSpider. (7.5% speedup on controlflow-recursive.)
2% speedup on SunSpider --v8.
2% speedup on v8 benchmark.

  • VM/CTI.cpp: Changed scope chain access to read the scope chain from the call frame header. Sped up op_ret by changing it not to fuss with the "scopeChain" local variable or ExecState::m_scopeChain.
  • VM/CTI.h: Updated CTI trampolines not to take a ScopeChainNode* argument, since that's stored in the call frame header now.
  • VM/Machine.cpp: Access "scopeChain" and "codeBlock" through new helper functions that read from the call frame header. Updated functions operating on ExecState::m_callFrame to account for / take advantage of the fact that Exec:m_callFrame is now never NULL.


Fixed a bug in op_construct, where it would use the caller's default
object prototype, rather than the callee's, when constructing a new object.

  • VM/Machine.h: Made some helper functions available. Removed ScopeChainNode* arguments to a lot of functions, since the ScopeChainNode* is now stored in the call frame header.
  • VM/RegisterFile.h: Renamed "CallerScopeChain" to "ScopeChain", since that's what it is now.
  • kjs/DebuggerCallFrame.cpp: Updated for change to ExecState signature.
  • kjs/ExecState.cpp:
  • kjs/ExecState.h: Nixed ExecState::m_callFrame, along with the unused isGlobalObject function.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObject.h: Gave the global object a fake call frame in which to store the global scope chain, since our code now assumes that it can always read the scope chain out of the ExecState's call frame.

JavaScriptGlue:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Forwarding headers to fix the build.

  • ForwardingHeaders/kjs/CTI.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/kjs/ustring.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/masm: Added.
  • ForwardingHeaders/masm/X86Assembler.h: Added.
  • ForwardingHeaders/profiler: Added.
  • ForwardingHeaders/profiler/Profiler.h: Added.

LayoutTests:

2008-09-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Test case for which prototype is used when calling "new" across windows.

  • fast/js/construct-global-object-expected.txt: Added.
  • fast/js/construct-global-object.html: Added.
5:42 PM Changeset in webkit [37085] by hyatt@apple.com
  • 4 edits
    1 add in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
(Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.h:
  • platform/HostWindow.h: Added. (WebCore::HostWindow::HostWindow): (WebCore::HostWindow::~HostWindow):
5:17 PM Changeset in webkit [37084] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
4:42 PM Changeset in webkit [37083] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added. (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being unloaded, to avoid calling uxtheme.dll functions after that library has been unloaded.
  • rendering/RenderThemeWin.h:

WebKit/win:

Reviewed by Adam Roben.

  • WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • WebKitDLL.cpp: (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit is being unloaded.
4:10 PM Changeset in webkit [37082] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas

3:50 PM Changeset in webkit [37081] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:49 PM Changeset in webkit [37080] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4

New tag.

3:34 PM Changeset in webkit [37079] by timothy@apple.com
  • 6 edits in trunk/WebCore

Makes the node highlight always show up when hovering a node in
the Web Inspector now that the highlight does not scroll to reveal
the node. Also adds a hover effect in the inspector when hovering
causes a highlight in the page. This ties the user hovering action
to the highlight so it is clear what causes the highlight to appear.

Also the highlight now temporarily shows up for 2 seconds after
selecting a node in the DOM tree. So arrowing around in the tree
will show the node on the page, providing feedback to the user.

Plus fixes an issue where quickly moving away from hovering
a node would keep showing the page highlight. This was happening
in breadcrumbs and the DOM tree.

https://bugs.webkit.org/show_bug.cgi?id=21220

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.Console.prototype._mouseOverNode): Added. Used for hovering DOM nodes in the console. (WebInspector.Console.prototype._mouseOutOfNode): Ditto. (WebInspector.Console.prototype._formatnode): Use the new event listeners and add a class name to the anchor element.
  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add new event listeners to the crumbs element to do the node hovering highlight. (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs): (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • page/inspector/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): Show the node hishlight for 2 seconds then restore the highlight to the current hovered node. (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the hovered node and set the hovered state on the tree element. (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the hovered node to null and removed the hovered state from the previous hovered tree element. (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds the hovered class to the list item. (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
  • page/inspector/inspector.css:
  • page/inspector/inspector.js: (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon based on the showingDOMNodeHighlight property of 50ms or 500ms. This causes the highlight to change sooner if there is one already showing and appear later if there isn't one showing. This is like tooltips, hovering a node for 500ms will cause highlight then mousing between nodes will keep the highlight and change to the new node. (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and always reset the timeout so continuous mousing does not keep flasshing the highlight on the screen. (WebInspector._updateHoverHighlight): Removed the alt key check and added the showingDOMNodeHighlight property. (WebInspector.documentKeyDown): Removed the alt key check. (WebInspector.documentKeyUp): Ditto. (WebInspector.reset): Clear the hoveredDOMNode.
3:04 PM Changeset in webkit [37078] by Simon Fraser
  • 3 edits in trunk/WebCore

2008-09-29 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

Fix RenderStyle leak in animation code, and assert that
keyframe resolution in CSSStyleSelector is not going to clobber
m_style.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation):
2:31 PM Changeset in webkit [37077] by Simon Fraser
  • 14 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Fixed https://bugs.webkit.org/show_bug.cgi?id=20995
Rewrite keyframe resolution to be like styleForElement()

Test: animations/lineheight-animation.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::keyframeStylesForAnimation): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::mapAnimationName):
  • css/CSSStyleSelector.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation): (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::hasAnimationForProperty): (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::overrideAnimations): (WebCore::KeyframeAnimation::resumeOverriddenAnimations): (WebCore::KeyframeAnimation::affectsProperty): (WebCore::KeyframeAnimation::validateTransformFunctionList):
  • page/animation/KeyframeAnimation.h:
  • rendering/style/Animation.cpp: (WebCore::Animation::animationsMatch):
  • rendering/style/Animation.h:
  • rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::~KeyframeList): (WebCore::KeyframeList::clear): (WebCore::KeyframeList::insert):
  • rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): (WebCore::KeyframeList::KeyframeList): (WebCore::KeyframeList::operator!=): (WebCore::KeyframeList::animationName): (WebCore::KeyframeList::addProperty): (WebCore::KeyframeList::containsProperty): (WebCore::KeyframeList::beginProperties): (WebCore::KeyframeList::endProperties): (WebCore::KeyframeList::isEmpty): (WebCore::KeyframeList::size): (WebCore::KeyframeList::beginKeyframes): (WebCore::KeyframeList::endKeyframes):
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
2:24 PM Changeset in webkit [37076] by Simon Fraser
  • 4 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel

Clean up fix in PropertyWrapperGetter::equals
https://bugs.webkit.org/show_bug.cgi?id=21011

Test: transitions/override-transition-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperGetter::equals):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
2:21 PM Changeset in webkit [37075] by Simon Fraser
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=21001
Starting transition after animation, when animation
is finished, transition is wrong.

Test: animations/transition-and-animation-2.html

  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::resetTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::reset):
  • page/animation/ImplicitAnimation.h:
2:18 PM Changeset in webkit [37074] by Simon Fraser
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=20921
-webkit-animation-timing-function: inside of keyframes is ignored

Test: animations/keyframe-timing-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress):
  • page/animation/AnimationBase.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
2:09 PM Changeset in webkit [37073] by Simon Fraser
  • 1 edit
    5 adds in trunk/LayoutTests

2008-09-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler

Testcase for crash when parsing keyframes from an @imported
CSS file
https://bugs.webkit.org/show_bug.cgi?id=20855

  • animations/import-crash-expected.txt: Added.
  • animations/import-crash.html: Added.
  • animations/import-expected.txt: Added.
  • animations/import.html: Added.
  • animations/resources/keyframes.css: Added.
2:04 PM Changeset in webkit [37072] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 3

1:57 PM Changeset in webkit [37071] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 2

1:52 PM Changeset in webkit [37070] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

1:09 PM Changeset in webkit [37069] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21218

Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
It's silly that the code was this fragile, but for now just put the check back in.

Reviewed by Dan Bernstein

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollbarModes):
12:49 PM Changeset in webkit [37068] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-09-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Sam Weinig.

Remove the isActivationObject() virtual method on JSObject and use
StructureID information instead. This should be slightly faster, but
isActivationObject() is only used in assertions and unwinding the stack
for exceptions.

  • VM/Machine.cpp: (JSC::depth): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_ret_activation):
  • kjs/JSActivation.cpp:
  • kjs/JSActivation.h:
  • kjs/JSObject.h:
12:46 PM Changeset in webkit [37067] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-29 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21216

Make setScrollPosition and scroll() cross-platform.

Reviewed by Anders

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scroll):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
12:09 PM Changeset in webkit [37066] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-09-29 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver.

Bug 21139: Profiler log message is wrong

  • Because _format was called twice the number in the log was incremented too many times, but we were passing it around in the link the whole time
  • page/inspector/ProfilesPanel.js:
  • page/inspector/inspector.js:
12:09 PM Changeset in webkit [37065] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-09-29 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Autogenerate EventListeners, addEventListener and removeEventListener
for JSDOMWindow.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::onwebkitanimationstart): (WebCore::JSDOMWindow::setOnwebkitanimationstart): (WebCore::JSDOMWindow::onwebkitanimationiteration): (WebCore::JSDOMWindow::setOnwebkitanimationiteration): (WebCore::JSDOMWindow::onwebkitanimationend): (WebCore::JSDOMWindow::setOnwebkitanimationend): (WebCore::JSDOMWindow::onwebkittransitionend): (WebCore::JSDOMWindow::setOnwebkittransitionend): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::JSDOMWindow::setListener): (WebCore::JSDOMWindow::getListener):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
9:08 AM Changeset in webkit [37064] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-09-29 Gunnar Sletta <gunnar@trolltech.com>

Reviewed by Simon

Compile on windows using MSVC 2005

For the PCH We need to define _WIN32_WINNT and include windows.h early on,
otherwise we'll miss several functions.

9:03 AM Changeset in webkit [37063] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed and tweaked by Darin Adler.

Fix build for non-all-in-one platforms.

  • kjs/StringPrototype.cpp: Added missing ASCIICType.h include.
7:55 AM Changeset in webkit [37062] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Bradley T. Hughes <bradley.hughes@nokia.com>

Reviewed by Simon.

Fix compilation with icpc

5:47 AM Changeset in webkit [37061] by Simon Hausmann
  • 139 edits in trunk

2008-09-29 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon.

Changed copyright from Trolltech ASA to Nokia.

Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.

4:48 AM Changeset in webkit [37060] by jchaffraix@webkit.org
  • 11 edits
    2 adds in trunk

WebCore:

2008-09-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 5727: We want to evaluate scripts in viewless documents
https://bugs.webkit.org/show_bug.cgi?id=5727

Add the posibility to evaluate script or fetch resources on viewless
document using the EmptyClient workaround.

Test: fast/loader/viewless-document.html

  • dom/Document.h: (WebCore::Document::setFrame): Method to set the Document's Frame, added a warning that it should be used under special circumstances.
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::requestScript): If the frame is empty (viewless document), get a dummy Frame to be able to evalute the script. (WebCore::ScriptElementData::evaluateScript): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Take a bool to toogle empty Document creation.

(WebCore::FrameLoader::fakeLoad): Fake remote resource load.

(WebCore::FrameLoader::createDummyFrame):

  • loader/FrameLoader.h:
  • page/Frame.cpp: (WebCore::Frame::isDummyFrame): (WebCore::Frame::setIsDummyFrame): (WebCore::Frame::setDocument):

(WebCore::FramePrivate::FramePrivate): Added m_isDummyFrame.
(WebCore::FramePrivate::~FramePrivate): We have to free the Page if it is a dummyFrame
(a dummyFrame own its Page).

  • page/Frame.h:
  • page/FramePrivate.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::dataChanged): Use the dummy Frame work-around.
  • svg/graphics/SVGImage.h: Removed unused members.

LayoutTests:

2008-09-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.


Bug 5727: We want to evaluate scripts in viewless documents
https://bugs.webkit.org/show_bug.cgi?id=5727


  • fast/loader/viewless-document-expected.txt: Added.
  • fast/loader/viewless-document.html: Added.


4:46 AM QtWebKitContrib edited by ariya.hidayat@trolltech.com
(diff)
4:24 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
4:24 AM QtWebKitJournal created by ariya.hidayat@trolltech.com
4:14 AM QtWebKitTodo edited by ariya.hidayat@trolltech.com
(diff)
2:03 AM Changeset in webkit [37059] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-29 Thiago Macieira <thiago.macieira@trolltech.com>

Reviewed by Simon

Fix compilation with gcc 4.3

gcc 4.3 is stricter and ctype.h isn't getting included

automatically here by dependencies. So do it directly.

2:02 AM Changeset in webkit [37058] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-29 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon.

Fix compilation with Qt/Mac without plugins.

2:02 AM Changeset in webkit [37057] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Simon Hausmann <Simon Hausmann>

Reviewed by Lars.

Don't accidentially install libJavaScriptCore.a for the build inside
Qt.

1:20 AM Changeset in webkit [37056] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
In the few places that we call .upper() in WebCore the strings represent things like
tag and attribute names, which are nearly always going to be ASCII.

Reviewed by Sam Weinig.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
in to Unicode::toLower the second time.
(WebCore::StringImpl::upper):

1:19 AM Changeset in webkit [37055] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
rather than String::operator+=.

Reviewed by Sam Weinig.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

1:19 AM Changeset in webkit [37054] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Speed up computedStyle.getPropertyValue('color') by 4.5x.

Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
as it avoids many memory reallocations.

This also speeds up the jQuery .offset() benchmark at <http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
unrelated properties on an element.

Reviewed by Oliver Hunt.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
and use appendNumber rather than the String::number in order to cut down on memory allocations.

  • platform/text/PlatformString.h:

(WebCore::appendNumber): A helper function for formatting an unsigned character as a number
into a Vector<UChar>.

Note: See TracTimeline for information about the timeline view.