Timeline


and

10/11/08:

23:50 Changeset [37521] by alp@webkit.org

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages

Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.

This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.

Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/gtk/TemporaryLinkStubs.cpp: (WebCore::focusRingColor):
22:00 Changeset [37520] by cwzwarich@webkit.org

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Clean up RegExpMatchesArray.h to match our coding style.

  • kjs/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):
21:56 Changeset [37519] by mitz@apple.com

Rubber-stamped by Sam Weinig.

  • change all internal callers to use Cache::evict() instead of remove()
  • loader/Cache.cpp: (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setDisabled):
21:26 Changeset [37518] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
21:20 Changeset [37517] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).

Also fixed resizer positioning problems.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
  • rendering/RenderLayer.cpp: (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
  • rendering/RenderScrollbarTheme.h:
20:48 Changeset [37516] by mrowe@apple.com

Merge ASCIICType.h portion of r36244.

20:33 Changeset [37515] by alp@webkit.org

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by David Hyatt.

Implement release/retain for Widget GTK+.

  • platform/Widget.cpp:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
18:38 Changeset [37514] by mrowe@apple.com

Fix ChangeLog header that was mangled in r37484.

18:31 Changeset [37513] by mrowe@apple.com

Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

16:10 Changeset [37512] by mitz@apple.com

Reviewed by Sam Weinig and Anders Carlsson.

  • update Mac DumpRenderTree to use the new WebView SPI for forcing the complex text code path
  • add --complex-text support to Windows DumpRenderTree
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
  • DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main):
  • Scripts/run-webkit-tests:
15:53 Changeset [37511] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

  • rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath and add a corresponding getter; add the same functions on Windows
  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::setCodePath): (WebCore::codePath): (WebCore::Font::canUseGlyphCache):
  • platform/graphics/Font.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUsesComplexTextCodePath): (WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.h:

WebKit/mac:

Reviewed by Sam Weinig.

  • rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and update it for the renamed WebCoreTextRenderer method; keep the old method around for clients that use it
  • WebView/WebView.mm: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setAlwaysUsesComplexTextCodePath:]):
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Sam Weinig.

  • add SPI for forcing the complex text code path to be used for all text
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): (WebView::alwaysUsesComplexTextCodePath):
  • WebView.h:
15:20 Changeset [37510] by weinig@apple.com

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.

  • bindings/js/JSEventListener.cpp: (WebCore::eventParameterName):
15:10 Changeset [37509] by weinig@apple.com

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove unused function getNodeEventListener.

  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
13:58 Changeset [37508] by cwzwarich@webkit.org

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21525: 55 StructureID leaks on Wikitravel's main page
<https://bugs.webkit.org/show_bug.cgi?id=21525>

Bug 21533: Simple JavaScript code leaks StructureIDs
<https://bugs.webkit.org/show_bug.cgi?id=21533>

StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.

This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.

  • kjs/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setCacheable): (JSC::PropertyNameArray::cacheable):
  • kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):
00:50 Changeset [37507] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

Add support for both positive and negative margins to tracks and track pieces.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPieceRects): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::trackRect): (WebCore::RenderScrollbar::trackPieceRectWithMargins):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
  • rendering/RenderScrollbarTheme.h:

10/10/08:

23:33 Changeset [37506] by hyatt@apple.com

Update scrollbars layout tests to new syntax.

23:30 Changeset [37505] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
23:26 Changeset [37504] by mitz@apple.com

Reviewed by Sam Weinig.

  • separate Cache::remove() into a private method and a public interface, then make Cache::pruneDeadResources() use the private method.
  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): (WebCore::Cache::evict):
  • loader/Cache.h: (WebCore::Cache::remove):
23:12 Changeset [37503] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
23:04 Changeset [37502] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack):
22:54 Changeset [37501] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
22:49 Changeset [37500] by oliver@apple.com

Use fastcall calling convention on GCC > 4.0

Reviewed by Cameron Zwarich

Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0

22:30 Changeset [37499] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure scrollbar background images cause proper part invalidation to occur.

Reviewed by Tim Hatcher

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
  • rendering/RenderScrollbarPart.h:
19:53 Changeset [37498] by weinig@apple.com

JavaScriptCore:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

  • Add a workaround for a bug in ceil in Darwin libc.
  • Remove old workarounds for JS math functions that are not needed anymore.

The math functions are heavily tested by fast/js/math.html.

  • kjs/MathObject.cpp: (JSC::mathProtoFuncAbs): Remove workaround. (JSC::mathProtoFuncCeil): Ditto. (JSC::mathProtoFuncFloor): Ditto.
  • wtf/MathExtras.h: (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

  • Update tests after fixing ceil(-0.1) behavior on darwin.
  • fast/js/math-expected.txt:
  • fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
  • fast/xpath/4XPath/Core/test_core_functions-expected.txt:
  • fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.
19:05 Changeset [37497] by weinig@apple.com

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler

Add Assertions to JSObject constructor.

  • kjs/JSObject.h: (JSC::JSObject::JSObject):
17:35 Changeset [37496] by simon.fraser@apple.com

2008-10-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21538

The blendFunc() for TransformOperations should never mess with the
operation lists by replacing some ops with identity, otherwise the lists
no longer match and transitions break.

Test: transitions/matched-transform-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
17:32 Changeset [37495] by simon.fraser@apple.com

2008-10-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21537

Fix re-targetting a running transition; if the target property
changes, we do need to make a new ImplicitAnimation.

Test: transitions/retargetted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):
16:21 Changeset [37494] by oliver@apple.com

Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion

Reviewed by Cameron Zwarich

When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging. This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS. The solution is just to
clear the exception state after attempting to record the exception.

15:24 Changeset [37493] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
when looking for pseudo styles.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
15:19 Changeset [37492] by dino@apple.com

2008-10-10 Dean Jackson <dino@apple.com>

Keyframe example had "0" rather than "0%".

  • WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:
15:16 Changeset [37491] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Add the ability to style the scroll corner and the resizer from CSS.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
14:05 Changeset [37490] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make CSS scrollbars respect the OS setting regarding where buttons should be placed.

Reviewed by Sam Weinig

No test case possible, since the OS setting can vary.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::ScrollbarThemeMac::preferencesChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarTheme.h: (WebCore::RenderScrollbarTheme::buttonsPlacement):
13:43 Changeset [37489] by adachan@apple.com

Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
potentially hold onto stale instances of WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=21526


webPreferencesInstances now keeps a reference to all the instances it holds.
Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
it after they have released their references to the WebPreferences objects.

Reviewed by Adam Roben.

  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::removeReferenceForIdentifier):
  • WebView.cpp: (WebView::close): (WebView::setPreferences):
13:27 Changeset [37488] by timothy@apple.com

Fixes a regression with input search fields, where the placeholder text
would not be updated when the value of the placeholder attribute changed.

https://bugs.webkit.org/show_bug.cgi?id=21521

Reviewed by Adele Peterson.

Test: fast/forms/search-placeholder-value-changed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the placeholderValueChanged parameter of updatePlaceholderVisibility. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter for placeholderValueChanged that informs the method that the value changed.
  • html/HTMLInputElement.h: Add the placeholderValueChanged to the updatePlaceholderVisibility method. Made it default to false.
13:12 Changeset [37487] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Allow the track part to have negative margins so that it can slightly overlap buttons. This
is necessary to emulate the Aqua look in CSS.

Reviewed by Sam Weinig

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::trackRect):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect):
12:32 Changeset [37486] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21527

Make CSS scrollbars support :not, :hover and :active.

Reviewed by Adam Roben

Added WebCore/manual-tests/scrollbar-hover-active.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::setHoveredPart): (WebCore::Scrollbar::setPressedPart): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::pseudoForScrollbarPart): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
11:43 Changeset [37485] by cmarrin@apple.com

2008-10-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
CSS transition with duration=0 and delay=0 doesn't override ongoing transition

Test: transitions/interrupt-zero-duration.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
11:04 Changeset [37484] by cmarrin@apple.com

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21310

Redesigned how animation events are sent in order to get rid of
AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
are now ref counted. While calling the event handler, I keep a
reference to this class to avoid it getting destroyed out from under me.

I also moved most of the functionality of CompositeAnimation to
and internal class (CompositeAnimationPrivate) to reduce the exposure
of the internals of the various animation classes.

We have several transition and animation LayoutTests which verify that
this fix works as expected and continues to avoid crashes.

10:13 Changeset [37483] by kevino@webkit.org

wx build fix. Add new scrollbar-related sources.

09:59 Changeset [37482] by hyatt@apple.com

WebCore:

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21522

Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
created. (Just :hover/:active left to finish it up.)

Reviewed by Adam Roben

Added scrollbars/scrollbar-buttons.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

LayoutTests:

2008-10-10 David Hyatt <hyatt@apple.com>

Add test for scrollbar buttons and track supporting increment/decrement/start/end.

Reviewed by Adam Roben

  • platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
  • scrollbars/scrollbar-buttons.html: Added.
09:40 Changeset [37481] by hyatt@apple.com

Land updated layout test after pseudoclass rename.

09:40 Changeset [37480] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
back/forward to decrement/increment. Adding start/end pseudoclasses.

Reviewed by Eric Seidel

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
00:18 Changeset [37479] by weinig@apple.com

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove now unused m_getterSetterFlag variable from PropertyMap.

  • kjs/PropertyMap.cpp: (JSC::PropertyMap::operator=):
  • kjs/PropertyMap.h: (JSC::PropertyMap::PropertyMap):
00:15 Changeset [37478] by hyatt@apple.com

Fix build.

00:15 Changeset [37477] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Switch window-active to window-inactive, since that will work better as far as degrading in other
browsers.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
00:06 Changeset [37476] by timothy@apple.com

Yet another Tiger build fix.

00:04 Changeset [37475] by hyatt@apple.com

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
is active as well.

Reviewed by Tim Hatcher

Added scrollbars/scrollbar-orientation.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint): (WebCore::RenderScrollbar::partForStyleResolve):
  • rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Add layout test for scrollbars honoring orientation and window active state.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
  • scrollbars/scrollbar-orientation.html: Added.

10/09/08:

23:39 Changeset [37474] by timothy@apple.com

Another build fix.

23:12 Changeset [37473] by timothy@apple.com

Full build fix for the fail on Tiger.

22:56 Changeset [37472] by hyatt@apple.com

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

Add support for pseudo classes on scrollbar pseudo elements. As an initial proof of concept only
:enabled/:disabled are supported. More pseudo classes will follow quickly now that this works.

Reviewed by Tim Hatcher

Added scrollbars/disabled-scrollbar.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • css/CSSStyleSelector.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle):
  • rendering/RenderObject.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setEnabled): (WebCore::RenderScrollbar::scrollbarForStyleResolve): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Add test case for disabled scrollbars.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/disabled-scrollbar-expected.checksum: Added.
  • platform/mac/scrollbars/disabled-scrollbar-expected.png: Added.
  • platform/mac/scrollbars/disabled-scrollbar-expected.txt: Added.
  • scrollbars/disabled-scrollbar.html: Added.
21:34 Changeset [37471] by timothy@apple.com

Tiger build fix.

21:04 Changeset [37470] by eric.carlson@apple.com

2008-10-09 Eric Carlson <eric.carlson@apple.com>

Media controls should not show when element is not visible

https://bugs.webkit.org/show_bug.cgi?id=21155


Reviewed by Adele Peterson.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::recalcStyle): New, call renderer()->updateFromElement to stay in sync with visibility changes
  • html/HTMLMediaElement.h:
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): initialize m_previousVisible (WebCore::RenderMedia::updateControlVisibility): consider style()->visibility() when determining if element is visible or not. Don't animate controller visibility when change triggered by showing or hiding media element.
  • rendering/RenderMedia.h: declare m_previousVisible
20:42 Changeset [37469] by hyatt@apple.com

Fix Gtk bustage.

20:41 Changeset [37468] by hyatt@apple.com

Fix Qt bustage.

20:37 Changeset [37467] by hyatt@apple.com

Fix Windows bustage.

20:25 Changeset [37466] by hyatt@apple.com

Fix typo in my Changelog comment

20:23 Changeset [37465] by timothy@apple.com

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availability macros and version macros.

WebCore:

2008-10-09 Timothy Hatcher <timothy@apple.com>

Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
availability macros and version macros.

https://bugs.webkit.org/show_bug.cgi?id=21496
rdar://problem/6259225

Reviewed by Sam Weinig.

  • bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
  • bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h and add an #if around the enum.
  • bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the comment to match the other headers.
  • bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
  • bindings/objc/DOMObject.h: Add a version #if around class interface.
  • bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h and add a version #if around the enum.
  • bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
  • bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
  • bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for when they where added to WebKit. Also annotate individual methods that are deprecated or where added after the class was added to WebKit.
  • bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h since this header is included by most DOM headers. Annotate the JSObject method.
  • bindings/scripts/CodeGeneratorObjC.pm: (ReadPublicInterfaces): Parse out the availability macro for each function/property. And parse out the availability version for the class/protocol. Default to WEBKIT_VERSION_LATEST if the class is new. (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the interface availability version check if the class has a required version. Create a public interface key (used to lookup in $publicInterfaces) and make a declaration suffix that includes the availability macro (if needed). Use the "available in 1.3 and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as the default availability macro for old style methods. Tweak line breaks in the generated headers to look good and not have too many extra lines.

WebKit/mac:

2008-10-09 Timothy Hatcher <timothy@apple.com>

Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
JavaScriptCore from the VPATH.

Reviewed by Sam Weinig.

  • MigrateHeaders.make:
20:15 Changeset [37464] by simon.fraser@apple.com

2008-10-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=20947

Refactor setStyle() methods into styleWillChange()
and styleDidChange(), so most of the setStyle() overrides can
be removed.

20:13 Changeset [37463] by hyatt@apple.com

2008-10-09 David Hyatt <hyatt@apple.com>

Make sure to destroy a custom scrollbar's RenderObject's before the arena goes away. When our widget
parent is nulled out is a good time.

Reviewed by Oliver Hunt

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
19:33 Changeset [37462] by hyatt@apple.com

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21446

This patch gets CSS scrollbars up and limping. There's no way to distinguish between states or between
orientation and back vs. forward on the buttons, but it's a start.

Reviewed by Oliver Hunt

Added scrollbars/basic-scrollbar.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • platform/ScrollTypes.h: (WebCore::):
  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintScrollbarBackground): (WebCore::ScrollbarThemeComposite::paintTrackBackground): (WebCore::ScrollbarThemeComposite::paintTrackPiece):
  • platform/win/ScrollbarThemeSafari.cpp: (WebCore::ScrollbarThemeSafari::paintTrackBackground):
  • platform/win/ScrollbarThemeSafari.h:
  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrack):
  • platform/win/ScrollbarThemeWin.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderScrollbar.cpp: Added. (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::~RenderScrollbar): (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart): (WebCore::RenderScrollbar::buttonRect): (WebCore::RenderScrollbar::minimumThumbLength):
  • rendering/RenderScrollbar.h: Added. (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::owningRenderer):
  • rendering/RenderScrollbarPart.cpp: Added. (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::~RenderScrollbarPart): (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::calcScrollbarThicknessUsing): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::calcPrefWidths): (WebCore::RenderScrollbarPart::setStyle):
  • rendering/RenderScrollbarPart.h: Added. (WebCore::RenderScrollbarPart::renderName): (WebCore::RenderScrollbarPart::requiresLayer):
  • rendering/RenderScrollbarTheme.cpp: Added. (WebCore::RenderScrollbarTheme::renderScrollbarTheme): (WebCore::RenderScrollbarTheme::buttonSizesAlongTrackAxis): (WebCore::RenderScrollbarTheme::hasButtons): (WebCore::RenderScrollbarTheme::hasThumb): (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::paintScrollCorner): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
  • rendering/RenderScrollbarTheme.h: Added. (WebCore::RenderScrollbarTheme::~RenderScrollbarTheme): (WebCore::RenderScrollbarTheme::scrollbarThickness): (WebCore::RenderScrollbarTheme::buttonsPlacement): (WebCore::RenderScrollbarTheme::supportsControlTints): (WebCore::RenderScrollbarTheme::shouldCenterOnThumb): (WebCore::RenderScrollbarTheme::initialAutoscrollTimerDelay): (WebCore::RenderScrollbarTheme::autoscrollTimerDelay): (WebCore::RenderScrollbarTheme::registerScrollbar): (WebCore::RenderScrollbarTheme::unregisterScrollbar):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Land layout test for CSS scrollbars.

Reviewed by Oliver Hunt

  • platform/mac/scrollbars: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.checksum: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.png: Added.
  • platform/mac/scrollbars/basic-scrollbar-expected.txt: Added.
  • scrollbars: Added.
  • scrollbars/basic-scrollbar.html: Added.
19:27 Changeset [37461] by eric@webkit.org

Reviewed by Oliver Hunt.

Test cases for https://bugs.webkit.org/show_bug.cgi?id=21498

  • fast/canvas/gradient-with-clip-expected.txt: Added.
  • fast/canvas/gradient-with-clip.html: Added.
  • fast/canvas/pattern-with-transform-expected.txt: Added.
  • fast/canvas/pattern-with-transform.html: Added.
  • fast/canvas/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/resources/TEMPLATE.html.
  • fast/canvas/resources/gradient-with-clip.js: Added.
  • fast/canvas/resources/pattern-with-transform.js: Added.
19:26 Changeset [37460] by eric@webkit.org

Reviewed by Oliver Hunt.

Fix Canvex DOOM Game
Gradient clips were not getting cleared after filling the
gradient, this was causing nothing to draw in Canvex
https://bugs.webkit.org/show_bug.cgi?id=21498

Tests forthcoming.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
19:17 Changeset [37459] by cwzwarich@webkit.org

2008-10-09 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Add StructureID.o to the exclusion list in the global initializers
script to fix the Debug build.

  • Scripts/check-for-global-initializers:
18:21 Changeset [37458] by weinig@apple.com

2008-10-09 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Add leaks checking to StructureID.

  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID):
17:50 Changeset [37457] by alp@webkit.org

2008-10-09 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=20760
Implement support for x86 Linux in CTI

Prepare to enable CTI/WREC on supported architectures.

Make it possible to use the CTI_ARGUMENT workaround with GCC as well
as MSVC by fixing some preprocessor conditionals.

Note that CTI/WREC no longer requires CTI_ARGUMENT on Linux so we
don't actually enable it except when building with MSVC. GCC on Win32
remains untested.

Adapt inline ASM code to use the global symbol underscore prefix only
on Darwin and to call the properly mangled Machine::cti_vm_throw
symbol name depending on CTI_ARGUMENT.

Also avoid global inclusion of the JIT infrastructure headers
throughout WebCore and WebKit causing recompilation of about ~1500
source files after modification to X86Assembler.h, CTI.h, WREC.h,
which are only used deep inside JavaScriptCore.

17:08 Changeset [37456] by eric@webkit.org

Reviewed by Oliver Hunt.

Fix transformed patterns
https://bugs.webkit.org/show_bug.cgi?id=21498

Test: fast/canvas/patternfill-repeat.html

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::applyStrokePattern): (WebCore::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
17:04 Changeset [37455] by cmarrin@apple.com

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

More testcases for animation using font metrics
https://bugs.webkit.org/show_bug.cgi?id=21246

  • animations/font-size-using-ems-expected.txt: Added.
  • animations/font-size-using-ems.html: Added.
  • animations/width-using-ems-expected.txt: Added.
  • animations/width-using-ems.html: Added.
16:59 Changeset [37454] by cmarrin@apple.com

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21217
Animations assert when navigating from page

Changed assertions to test the right flag for the paused state

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
16:59 Changeset [37453] by barraclough@apple.com

JavaScriptCore:

2008-10-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for bug #21160, x=0;1/(x*-1) == -Infinity

  • ChangeLog:
  • VM/CTI.cpp: (JSC::CTI::emitFastArithDeTagImmediate): (JSC::CTI::emitFastArithDeTagImmediateJumpIfZero): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::emitUnlinkedJs):

LayoutTests:

2008-10-09 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Correct results for -0 cases.

  • fast/js/math-transforms-expected.txt:
16:44 Changeset [37452] by kevino@webkit.org

wx build fixes.

16:04 Changeset [37451] by cmarrin@apple.com

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fixed > 180 degree rotation bug
Ensure that validateTransformFunctionList() is called after updating keyframe styles

https://bugs.webkit.org/show_bug.cgi?id=21420

Test: animations/big-rotation.html

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation):
14:47 Changeset [37450] by cwzwarich@webkit.org

2008-10-09 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21459: REGRESSION (r37324): Safari crashes inside JavaScriptCore while browsing hulu.com
<https://bugs.webkit.org/show_bug.cgi?id=21459>

After r37324, an Arguments object does not mark an associated activation
object. This change was made because Arguments no longer directly used
the activation object in any way. However, if an activation is torn off,
then the backing store of Arguments becomes the register array of the
activation object. Arguments directly marks all of the arguments, but
the activation object is being collected, which causes its register
array to be freed and new memory to be allocated in its place.

Unfortunately, it does not seem possible to reproduce this issue in a
layout test.

  • kjs/Arguments.cpp: (JSC::Arguments::mark):
  • kjs/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): (JSC::JSActivation::copyRegisters):
13:43 Changeset [37449] by beidson@apple.com

2008-10-09 Brady Eidson <beidson@apple.com>

Reviewed by Anders

<rdar://problem/6250856> - Calling [WebView close] from within a redirection callback can cause bad things

The API usage to reveal this crash was so particular that a layout test is not possible with our current infrastructure.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): Protect the Frame from deletion (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): stopAllLoaders() might clear the Frame's page, so perform a second null check on the page. Bail if it has been cleared.
09:21 Changeset [37448] by alp@webkit.org

2008-10-09 Alp Toker <alp@nuanti.com>

Build fix for recent DOM generation Makefile changes when custom
CFLAGS/CXXFLAGS are passed in.

  • GNUmakefile.am:
09:13 Changeset [37447] by alp@webkit.org

2008-10-09 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21390
[Gtk] Linux/Gtk: GtkLauncher crashes on Acid3 (but after test 80 this time)

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformRemoveChild):
07:26 Changeset [37446] by hausmann@webkit.org

2008-10-09 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Build fix for MinGW.

  • wtf/AlwaysInline.h:
01:37 Changeset [37445] by darin@apple.com

2008-10-09 Darin Adler <darin@apple.com>

  • try to fix Qt build
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): Pass JSGlobalData instead of ExecState to RegExp constructor.
00:25 Changeset [37444] by darin@apple.com

2008-10-09 Darin Adler <darin@apple.com>

  • checked in a missing expected result
  • fast/dom/css-RGBValue-expected.txt: Added.

10/08/08:

22:38 Changeset [37443] by mrowe@apple.com

Merge r37442.

22:36 Changeset [37442] by mrowe@apple.com

Remove restriction on version number ending in a 4.

Rubber-stamped by Jon Honeycutt.

  • win/tools/scripts/auto-version.sh:
22:30 Changeset [37441] by cwzwarich@webkit.org

2008-10-08 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21497: REGRESSION (r37433): Bytecode JSC tests are severely broken
<https://bugs.webkit.org/show_bug.cgi?id=21497>

Fix a typo in r37433 that causes the failure of a large number of JSC
tests with the bytecode interpreter enabled.

  • VM/Machine.cpp: (JSC::Machine::privateExecute):
22:19 Changeset [37440] by mrowe@apple.com

Fix the Windows build after r37434.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump): Update code to approximate valid C++ syntax.

21:34 Changeset [37439] by timothy@apple.com

Add SVGElementInstance to the list of exceptions that have
global initializers in debug builds.

Rubber-stamped by Mark Rowe.

  • Scripts/check-for-global-initializers: Add SVGElementInstance.o.
21:05 Changeset [37438] by mrowe@apple.com

Windows build fix.

  • VM/CTI.cpp:

(JSC::): Update type of argument to ctiTrampoline.

20:57 Changeset [37437] by mitz@apple.com

Correct MIME types

20:54 Changeset [37436] by zimmermann@webkit.org

Not reviewed. Fix Sams name :-)

20:34 Changeset [37435] by zimmermann@webkit.org

Reviewed by Oliver Hunt & Sam Weining.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=15413 (SVGElementInstance does not implement EventTarget)
Fixes: https://bugs.webkit.org/show_bug.cgi?id=15430 (SVGElementInstances should rebuild themselves lazily)
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20550 (SVGUseElement.setAttribute crashes Safari)

Rebuild SVG use element shadow tree lazily. Mark SVGElementInstance with the "needsUpdate" flag.
Next time SVGUseElement::recalcStyle is invoked (ie. via Document::updateDocumentsRendering()) the
use tree is rebuild.

Make SVGElementInstance a real EventTarget, as the SVG specification demands.
When dispatching events to a shadow tree element of a use element, the associated SVGElementInstance
is used as event target. The SVGElementInstance, the shadow tree element and the corresponding element
share an event listener list. Every event listener change on the SVGElementInstance object is forwared
to the corresponding element. Each change marks the SVGElementInstance tree dirty, and causes a reclone.
Each event listener defined via attributes (onclick/onkeydown/...) is copied from the correspondingElement
to the shadow tree element - through the cloneNode calls - if the use element's shadow tree gets rebuild.
Each listener, dynamically created using addEventListener, gets copied to the corersponding element as well.

Now that the target/currentTarget properties of the Events are correct, event bubbling works as expected,
see resources/use-instanceRoot-event-bubbling.js for details.

Tests: svg/custom/use-elementInstance-event-target.svg (reenabled)

svg/custom/use-elementInstance-methods.svg (reenabled)
svg/custom/use-setAttribute-crash.svg (covers bug 20550)
svg/custom/use-instanceRoot-as-event-target.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-bubbling.xhtml (covers bug 15413)
svg/custom/use-instanceRoot-event-listeners.xhtml (covers bug 15413 & 15430)

17:45 Changeset [37434] by simon.fraser@apple.com

2008-10-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

Avoid disconnect between DRT and run-webkit-tests
about whether to expect PNG dumps by having DRT always
print two blocks terminated by #EOF, the second of which
may be empty.

https://bugs.webkit.org/show_bug.cgi?id=21483

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump):
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump):
  • Scripts/run-webkit-tests:
17:40 Changeset [37433] by darin@apple.com

JavaScriptCore:

2008-10-08 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
client over to the new name.

Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
accessor functions to get at things in the frame.

Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
JSGlobalData* and in other cases eliminating them entirely.

  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty):
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::compileRegExp):
  • VM/CTI.h:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp): (JSC::CodeGenerator::emitLoad): (JSC::CodeGenerator::emitUnexpectedLoad): (JSC::CodeGenerator::emitConstruct):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::Machine::resolve): (JSC::Machine::resolveSkip): (JSC::Machine::resolveGlobal): (JSC::inlineResolveBase): (JSC::Machine::resolveBase): (JSC::Machine::resolveBaseAndProperty): (JSC::Machine::resolveBaseAndFunc): (JSC::Machine::slideRegisterWindowForCall): (JSC::isNotObject): (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::throwException): (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope): (JSC::Machine::execute): (JSC::Machine::debug): (JSC::Machine::createExceptionScope): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::retrieveCaller): (JSC::Machine::retrieveLastCaller): (JSC::Machine::findFunctionCallFrame): (JSC::Machine::getArgumentsData): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::getCTIArrayLengthTrampoline): (JSC::Machine::getCTIStringLengthTrampoline): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • VM/Register.h:
  • VM/RegisterFile.h:
  • kjs/Arguments.h:
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::type): (JSC::DebuggerCallFrame::thisObject): (JSC::DebuggerCallFrame::evaluate):
  • kjs/DebuggerCallFrame.h:
  • kjs/ExecState.cpp: (JSC::CallFrame::thisValue):
  • kjs/ExecState.h:
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction):
  • kjs/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h:
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • kjs/JSVariableObject.h:
  • kjs/Parser.cpp: (JSC::Parser::parse):
  • kjs/RegExpConstructor.cpp: (JSC::constructRegExp):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • kjs/Shell.cpp: (prettyPrintScript):
  • kjs/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • kjs/identifier.cpp: (JSC::Identifier::checkSameIdentifierTable):
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): (JSC::RegExpNode::emitCode): (JSC::ArrayNode::emitCode): (JSC::InstanceOfNode::emitCode):
  • kjs/nodes.h:
  • kjs/regexp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • kjs/regexp.h:
  • profiler/HeavyProfile.h:
  • profiler/Profile.h:
  • wrec/WREC.cpp:
  • wrec/WREC.h:

WebKit/mac:

2008-10-08 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.
17:14 Changeset [37432] by weinig@apple.com

WebCore:

2008-10-08 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21241
REGRESSION (r36977): getRGBColorValue().red returning incorrect value

Update JSRGBColor to use the new static function per getter approach.

Test: fast/dom/css-RGBValue.html

  • bindings/js/JSRGBColor.cpp: (WebCore::): (jsRGBColorRed): (jsRGBColorGreen): (jsRGBColorBlue):
  • bindings/js/JSRGBColor.h:

LayoutTests:

2008-10-08 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Test for https://bugs.webkit.org/show_bug.cgi?id=21241
REGRESSION (r36977): getRGBColorValue().red returning incorrect value

  • fast/dom/css-RGBValue.html: Added.
  • fast/dom/resources/css-RGBValue.js: Added.
15:48 Changeset [37431] by eric@webkit.org

Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.

svgElement.className.baseValue = "foo" does not work
https://bugs.webkit.org/show_bug.cgi?id=20651

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/StyledElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):
15:38 Changeset [37430] by mrowe@apple.com

Fix crash in fast/js/constant-folding.html with CTI disabled.

Typed by Maciej Stachowiak, reviewed by Mark Rowe.

  • VM/Machine.cpp:

(JSC::Machine::privateExecute):

13:30 Changeset [37429] by mjs@apple.com

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Not reviewed, trying to fix bot.


Update -0 expectations better.

  • fast/xpath/4XPath/Core/test_numeric_expr-expected.txt:
  • fast/xpath/4XPath/Core/test_numeric_expr.html:
10:50 Changeset [37428] by timothy@apple.com

Roll out r37427 because it causes an infinite recursion loading about:blank.

https://bugs.webkit.org/show_bug.cgi?id=21476

10:03 Changeset [37427] by darin@apple.com

JavaScriptCore:

2008-10-08 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Add CallFrame as a synonym for ExecState. Arguably, some day we should switch every
client over to the new name.

Use CallFrame* consistently rather than Register* or ExecState* in low-level code such
as Machine.cpp and CTI.cpp. Similarly, use callFrame rather than r as its name and use
accessor functions to get at things in the frame.

Eliminate other uses of ExecState* that aren't needed, replacing in some cases with
JSGlobalData* and in other cases eliminating them entirely.

  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty):
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompile): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::compileRegExp):
  • VM/CTI.h:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp): (JSC::CodeGenerator::emitLoad): (JSC::CodeGenerator::emitUnexpectedLoad): (JSC::CodeGenerator::emitConstruct):
  • VM/CodeGenerator.h:
  • VM/Machine.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::Machine::resolve): (JSC::Machine::resolveSkip): (JSC::Machine::resolveGlobal): (JSC::inlineResolveBase): (JSC::Machine::resolveBase): (JSC::Machine::resolveBaseAndProperty): (JSC::Machine::resolveBaseAndFunc): (JSC::Machine::slideRegisterWindowForCall): (JSC::isNotObject): (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::throwException): (JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): (JSC::DynamicGlobalObjectScope::~DynamicGlobalObjectScope): (JSC::Machine::execute): (JSC::Machine::debug): (JSC::Machine::createExceptionScope): (JSC::cachePrototypeChain): (JSC::Machine::tryCachePutByID): (JSC::Machine::tryCacheGetByID): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::retrieveCaller): (JSC::Machine::retrieveLastCaller): (JSC::Machine::findFunctionCallFrame): (JSC::Machine::getArgumentsData): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::getCTIArrayLengthTrampoline): (JSC::Machine::getCTIStringLengthTrampoline): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • VM/Register.h:
  • VM/RegisterFile.h:
  • kjs/Arguments.h:
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::functionName): (JSC::DebuggerCallFrame::type): (JSC::DebuggerCallFrame::thisObject): (JSC::DebuggerCallFrame::evaluate):
  • kjs/DebuggerCallFrame.h:
  • kjs/ExecState.cpp: (JSC::CallFrame::thisValue):
  • kjs/ExecState.h:
  • kjs/FunctionConstructor.cpp: (JSC::constructFunction):
  • kjs/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h:
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init):
  • kjs/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • kjs/JSVariableObject.h:
  • kjs/Parser.cpp: (JSC::Parser::parse):
  • kjs/RegExpConstructor.cpp: (JSC::constructRegExp):
  • kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • kjs/Shell.cpp: (prettyPrintScript):
  • kjs/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
  • kjs/identifier.cpp: (JSC::Identifier::checkSameIdentifierTable):
  • kjs/interpreter.cpp: (JSC::Interpreter::checkSyntax): (JSC::Interpreter::evaluate):
  • kjs/nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): (JSC::RegExpNode::emitCode): (JSC::ArrayNode::emitCode): (JSC::InstanceOfNode::emitCode):
  • kjs/nodes.h:
  • kjs/regexp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • kjs/regexp.h:
  • profiler/HeavyProfile.h:
  • profiler/Profile.h:
  • wrec/WREC.cpp:
  • wrec/WREC.h:

WebKit/mac:

2008-10-08 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): Update since DebuggerCallFrame is simpler now.
09:41 Changeset [37426] by timothy@apple.com

Make the toolbar label text-shadow not disappear when clicking on the
search result count or around the search field.

Reviewed by Timothy Hatcher.

  • inspector/front-end/inspector.css: (.toolbar-item:active .toolbar-label): Make this rule also require the toggleable class with the toolbar-item class.
08:06 QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
06:30 Changeset [37425] by hausmann@webkit.org

2008-10-08 Matthias Ettrich <ettrich@nokia.com>

Reviewed by Simon.

Make QWebView ignore focus changes with PopupFocusReason to avoid
massive updates when menus open and close.

06:13 Changeset [37424] by hausmann@webkit.org

2008-10-08 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Updated the qrc file for the Web Inspector to contain the current set
of images.

05:43 Changeset [37423] by hausmann@webkit.org

2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>

Reviewed by Simon.

Fix the linking of applications against WebKit on Qt/Windows.

The prl files that qmake creates are buggy on Unix, but we they're
fine on Windows and we have to have them there in order to get the
dependencies correct.

05:20 Changeset [37422] by hausmann@webkit.org

2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>

Reviewed by Oliver Hunt.

Avoid endless loops when compiling without the computed goto
optimization.

NEXT_OPCODE expands to "continue", which will not work inside
loops.

05:11 Changeset [37421] by hausmann@webkit.org

2008-10-08 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon.

Speed up rectangle filling by not re-creating a QBrush all the time.

This triggers faster path in QPainter where the brush is reused.

05:08 Changeset [37420] by hausmann@webkit.org

2008-10-08 Kavindra Palaraja <kdpalara@trolltech.com>

Reviewed by Simon.

Fixed a qdoc warning and adjusted some spacing

04:33 Changeset [37419] by mjs@apple.com

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • update for new -0 handling in shouldBe


(I confirmed the correctness of this change against other browsers, too.)

  • fast/xpath/4XPath/Core/test_numeric_expr.html:
04:01 Changeset [37418] by dino@apple.com

2008-10-08 Dean Jackson <dino@apple.com>

Forgot to set the date on the spec documents with last commit.

  • CSSAnimations.html:
  • CSSTransforms.html:
  • CSSTransitions.html:
03:53 Changeset [37417] by mjs@apple.com

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

Re-landing the following fix with the crashing bug in it fixed (r37405):


  • optimize away multiplication by constant 1.0


2.3% speedup on v8 RayTrace benchmark

Apparently it's not uncommon for JavaScript code to multiply by
constant 1.0 in the mistaken belief that this converts integer to
floating point and that there is any operational difference.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for case where parameter is already number. (JSC::CTI::privateCompileSlowCases): ditto
  • VM/Machine.cpp: (JSC::Machine::privateExecute): ditto
  • kjs/grammar.y: (makeMultNode): Transform as follows: +FOO * BAR ==> FOO * BAR FOO * +BAR ==> FOO * BAR FOO * 1 ==> +FOO 1 * FOO ==> +FOO (makeDivNode): Transform as follows: +FOO / BAR ==> FOO / BAR FOO / +BAR ==> FOO / BAR (makeSubNode): Transform as follows: +FOO - BAR ==> FOO - BAR FOO - +BAR ==> FOO - BAR
  • kjs/nodes.h: (JSC::ExpressionNode::stripUnaryPlus): Helper for above grammar.y changes (JSC::UnaryPlusNode::stripUnaryPlus): ditto
03:27 Changeset [37416] by mjs@apple.com

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • update regression testing system to be able to tell 0 from -0


  • fast/js/resources/js-test-pre.js:

Update tests and results appropriately.

  • fast/js/resources/constant-folding.js:
  • fast/js/constant-folding-expected.txt:
  • fast/js/math-transforms-expected.txt:
  • fast/js/resources/math-transforms.js:
02:18 Changeset [37415] by mjs@apple.com

JavaScriptCore:

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • correctly handle appending -0 to a string, it should stringify as just 0
  • kjs/ustring.cpp: (JSC::concatenate):

LayoutTests:

2008-10-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

  • added test case for: correctly handle appending -0 to a string, it should stringify as just 0 (added to existing test)


  • fast/js/number-toString-expected.txt:
  • fast/js/resources/number-toString.js:
  • updated results in light of above fix


  • fast/js/math-transforms-expected.txt:
02:10 Changeset [37414] by hausmann@webkit.org

2008-10-08 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon.

Fixes: Encoding of Qt URLs

This encoding was added by Simon and I because QUrl's
tolerant parser wasn't tolerant enough. Now it is, so we don't need
this anymore.

02:10 Changeset [37413] by hausmann@webkit.org

2008-10-08 Marius Storm-Olsen <marius@trolltech.com>

Reviewed by Simon.

Fixes dependencies in qmake generated visual studio projects.

Only add debug lib name if we're in the debug build_pass, else the release version.
The MSVC solution generator would pick up the debug javascriptcore lib as a dependency.

02:10 Changeset [37412] by hausmann@webkit.org

2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>

Reviewed by Simon.

Fix WebKit compilation with VC2008SP1

Apply the TR1 workaround for JavaScriptCore, too.

02:10 Changeset [37411] by hausmann@webkit.org

2008-10-08 Rhys Weatherley <rhys.weatherley@nokia.com>

Reviewed by Simon.

Compile for platforms without context menus.

02:10 Changeset [37410] by hausmann@webkit.org

2008-10-08 Prasanth Ullattil <pullatti@trolltech.com>

Reviewed by Simon.

Fix compilation errors on VS2008 64Bit

02:09 Changeset [37409] by hausmann@webkit.org

2008-10-08 André Pönitz <apoenitz@trolltech.com>

Reviewed by Simon.

Fix compilation with Qt namespaces.

00:35 QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
00:34 QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)

10/07/08:

23:36 Changeset [37408] by weinig@apple.com

2008-10-07 Sam Weinig <sam@webkit.org>

Roll out r37405.

22:24 Changeset [37407] by mrowe@apple.com

New tag.

21:56 Changeset [37406] by oliver@apple.com

Switch CTI runtime calls to the fastcall calling convention

Reviewed by Cameron Zwarich

Basically this means that we get to store the argument for CTI
calls in the ECX register, which saves a register->memory write
and subsequent memory->register read.

This is a 1.7% progression in SunSpider and 2.4% on commandline
v8 tests on Windows

20:46 Changeset [37405] by mjs@apple.com

2008-10-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.


  • optimize away multiplication by constant 1.0


2.3% speedup on v8 RayTrace benchmark

Apparently it's not uncommon for JavaScript code to multiply by
constant 1.0 in the mistaken belief that this converts integer to
floating point and that there is any operational difference.


  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): Optimize to_jsnumber for case where parameter is already number. (JSC::CTI::privateCompileSlowCases): ditto
  • VM/Machine.cpp: (JSC::Machine::privateExecute): ditto
  • kjs/grammar.y: (makeMultNode): Transform as follows: +FOO * BAR ==> FOO * BAR FOO * +BAR ==> FOO * BAR FOO * 1 ==> +FOO 1 * FOO ==> +FOO (makeDivNode): Transform as follows: +FOO / BAR ==> FOO / BAR FOO / +BAR ==> FOO / BAR (makeSubNode): Transform as follows: +FOO - BAR ==> FOO - BAR FOO - +BAR ==> FOO - BAR
  • kjs/nodes.h: (JSC::ExpressionNode::stripUnaryPlus): Helper for above grammar.y changes (JSC::UnaryPlusNode::stripUnaryPlus): ditto
20:46 Changeset [37404] by mjs@apple.com

2008-10-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.


  • test cases that will check some possible edge cases for math optimizations
  • fast/js/math-transforms-expected.txt: Added.
  • fast/js/math-transforms.html: Added.
  • fast/js/resources/math-transforms.js: Added.
17:42 Changeset [37403] by alp@webkit.org

2008-10-07 Alp Toker <alp@nuanti.com>

GTK+ build fix for older automake versions (1.7). Discussed in bug
#21392.

17:15 Changeset [37402] by mjs@apple.com

2008-10-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • make constant folding code more consistent


Added a makeSubNode to match add, mult and div; use the makeFooNode functions always,
instead of allocating nodes directly in other places in the grammar.

  • kjs/grammar.y:
17:12 Changeset [37401] by mrowe@apple.com

Roll out r37391 as it appears to have broken 40+ regression tests.

16:49 Changeset [37400] by weinig@apple.com

2008-10-07 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Move hasGetterSetterProperties flag from PropertyMap to StructureID.

  • kjs/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter):
  • kjs/JSObject.h: (JSC::JSObject::hasGetterSetterProperties): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getOwnPropertySlot):
  • kjs/PropertyMap.h:
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition):
  • kjs/StructureID.h: (JSC::StructureID::hasGetterSetterProperties): (JSC::StructureID::setHasGetterSetterProperties):
16:31 Changeset [37399] by andersca@apple.com

2008-10-07 Anders Carlsson <andersca@apple.com>

Reviewed by Antti Koivisto.

<rdar://problem/6273887> Crash in ApplicationCacheGroup


Make sure to stop loading even before a cache update is in progress so that the
manifest load will be stopped.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::stopLoading): (WebCore::ApplicationCacheGroup::cacheUpdateFailed):
15:09 Changeset [37398] by timothy@apple.com

Fix the build due to a bad patch apply.

15:08 Changeset [37397] by timothy@apple.com

Fix the build due to a bad patch apply.

14:49 Changeset [37396] by timothy@apple.com

Auto-generate DOMDocument's createNodeIterator: and createTreeWalker: methods.

https://bugs.webkit.org/show_bug.cgi?id=21433

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj: Add ObjCNodeFilterCondition.{mm,h}.
  • bindings/objc/DOM.mm: Remove previous category implementations on DOMDocument for createNodeIterator: and createTreeWalker:. Also moves ObjCNodeFilterCondition to its own file.
  • bindings/objc/DOMTraversal.h: Remove the category methods that added createNodeIterator: and createTreeWalker: to DOMDocument. This is fine to do since DOmDocument.h is included still, and has these methods.
  • bindings/objc/DOMUtility.mm: (JSC::createDOMWrapper): Remove special case for JSNodeIterator and JSTreeWalker now that the ObjC binding conforms to the standard wrap.
  • bindings/objc/ObjCNodeFilterCondition.h: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::create): Moved from DOM.mm. (WebCore::ObjCNodeFilterCondition::ObjCNodeFilterCondition): Ditto.
  • bindings/objc/ObjCNodeFilterCondition.mm: Split out from DOM.mm. (WebCore::ObjCNodeFilterCondition::acceptNode): Moved from DOM.mm.
  • bindings/objc/PublicDOMInterfaces.h: Add the createNodeIterator: and createTreeWalker: methods to DOMDocument.
  • bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for NodeFilter. (AddIncludesForType): Include ObjCNodeFilterCondition.h for NodeFilter. (GenerateImplementation): Remove existing NodeFilter special case that used the m_filter member variable. Add a new special getter for protocol types that aren't EventTarget, so the right class is used for NodeFilter. Add a special case for NodeFilter where it creates an ObjCNodeFilterCondition.
  • dom/Document.idl: Remove the #ifdef LANGUAGE_OBJECTIVE_C. Add the OldStyleObjC extended attribute to createNodeIterator and createTreeWalker. Rename the entityReferenceExpansion parameter to expandEntityReferences to match the previous ObjC API.
  • dom/NodeIterator.idl: Remove ObjCIvar from the filter attribute. The m_filter member variable was never used in practice, it was always nil! We can remove it and not pad the object because this can't be subclassed.
  • dom/TreeWalker.idl: Ditto.
14:49 Changeset [37395] by timothy@apple.com

Auto-generate the DOMEventTarget protocol implementation for
DOMNode and DOMSVGElementInstance.

https://bugs.webkit.org/show_bug.cgi?id=21432

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Add ObjCEventListener.{mm,h}.
  • bindings/objc/DOM.mm: Remove many unneeded header includes. Move ObjCEventListener to it's own file. Remove the manual impelmentations of the DOMEventTarget protocol for DOMNode and DOMSVGElementInstance.
  • bindings/objc/DOMEvents.h: Remove the categories that defined DOMEventTarget for DOMNode and DOMSVGElementInstance.
  • bindings/objc/ObjCEventListener.h: Split out from DOM.mm.
  • bindings/objc/ObjCEventListener.mm: Split out from DOM.mm. (WebCore::ObjCEventListener::find): Moved from DOM.mm. (WebCore::ObjCEventListener::wrap): Use PassRefPtr to prevent the callers from doing a manual deref. (WebCore::ObjCEventListener::ObjCEventListener): Moved from DOM.mm. (WebCore::ObjCEventListener::~ObjCEventListener): Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: (GetObjCTypeGetter): Add a case for EventListener and use WTF::getPtr. (AddIncludesForType): Include ObjCEventListener.h for EventListener. And include EventTargetSVGElementInstance.h for SVGElementInstance. (GenerateHeader): Remove the check for multiple parents. (GenerateImplementation): Remove the check for multiple parents. Remove the @deprecatedFunctions array since deprecated methods get generated into the main @interface now to work with protocols. Add support for the EventTargetNodeCast extended attribute. Add support for EventListener parameters.
  • dom/Node.idl: Define superclasses for ObjC so the implementation and interface implement the DOMEventTarget protocol. Explicitly specify Object as a superclass to use DOMEventTarget. Object will turn into DOMObject. This is needed to take the code generator down the right path of multiple super-classes as protocols. It is ObjC only for legacy reasons. The event target methods are normally on NodeEventTarget, a subclass of Node. But the ObjC API has never has this subclass and they are on DOMNode.
  • svg/SVGElementInstance.idl: Ditto.
14:36 Changeset [37394] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Add new pseudo-elements and pseudo-classes that will enable scrollbars to be styled by CSS.

The new pseudo-elements are:

scrollbar
scrollbar-button
scrollbar-corner
scrollbar-thumb
scrollbar-track


These elements will work with all the usual pseudo-classes (:hover, :active, :enabled, :disabled, etc.) and with
the following new pseudo-classes:

scrollbar-active
scrollbar-back
scrollbar-forward
scrollbar-horizontal
scrollbar-vertical


Reviewed by Adele

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
14:35 Changeset [37393] by aroben@apple.com

Make sure short functions get included in ChangeLog output for git repositories

Reviewed by Dave Kilzer.

  • Scripts/prepare-ChangeLog: (sub diffCommand): Pass -U0 to git diff so that each contiguous change will get its own chunk without any surrounding context. (sub extractLineRange): Use the line numbers from the chunk header without modifying them now that they're accurate.
14:29 Changeset [37392] by andersca@apple.com

2008-10-07 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.

Update WebKitSystemInterface.


  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
14:27 Changeset [37391] by eric@webkit.org

Reviewed by Darin Adler, Nikolas Zimmermann and Dave Hyatt.

svgElement.className.baseValue = "foo" does not work
https://bugs.webkit.org/show_bug.cgi?id=20651

  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/StyledElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::svgAttributeChanged):
14:22 Changeset [37390] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=18989

Remove global substitution from SunSpider regexp test, since only Firefox was honoring it and
we want all browsers to be doing the same thing on the test.

Reviewed by Maciej

  • tests/regexp-dna.js:
14:08 Changeset [37389] by timothy@apple.com

Add support to the Resources panel for queries like "#123", "foo #123",
"line: 123" and "foo line: 123". These will match the query limiting
the search only to the line specified. If only a line is specified,
the whole line is matched.

https://bugs.webkit.org/show_bug.cgi?id=21422

Reviewed by Darin Adler.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.sourceRow): Don't return the last row if the index is greater than the rows collection. Let it return undefined by indexing out-of-bounds.
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.performSearch): Add support for queries like "#123", "foo #123", "line: 123" and "foo line: 123". Also match the whole query to the whole document in case there are colors like "#333".
13:49 Changeset [37388] by weinig@apple.com

2008-10-07 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Roll r37370 back in with bug fixes.

  • PropertyMap::storageSize() should reflect the number of keys + deletedOffsets and has nothing to do with the internal deletedSentinel count anymore.
13:32 Changeset [37387] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Move viewless WebKit methods that Safari needs from WebViewInternal to WebViewPrivate.

Reviewed by Tim Hatcher

  • WebView/WebView.mm: (WebKitInitializeApplicationCachePathIfNecessary): (-[WebView _registerDraggedTypes]): (-[WebView _usesDocumentViews]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _initWithFrame:frameName:groupName:usesDocumentViews:]): (-[WebView isFlipped]): (-[WebView viewWillDraw]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
13:27 Changeset [37386] by barraclough@apple.com

2008-10-07 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Move callframe initialization into JIT code, again.


As a part of the restructuring the second result from functions is now
returned in edx, allowing the new value of 'r' to be returned via a
register, and stored to the stack from JIT code, too.

4.5% progression on v8-tests. (3% in their harness)

  • VM/CTI.cpp: (JSC::): (JSC::CTI::emitCall): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
  • VM/CTI.h: (JSC::CallRecord::CallRecord):
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
  • VM/Machine.h:
  • kjs/JSFunction.h:
  • kjs/ScopeChain.h:
13:17 Changeset [37385] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Fix crash in isFlipped. Null check _private since isFlipped can get called from within AppKit
machinery during teardown of the WebView.

Reviewed by Adam Roben

  • WebView/WebView.mm: (-[WebView isFlipped]):
13:15 Changeset [37384] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Make viewless WebKit update focused and active state when the window becomes and loses key.
The focus controller has been patched to understand that in viewless mode it can recur down and
update all of the frames, which is why this code works now when placed just on the WebView.

Reviewed by Adam Roben

  • WebView/WebView.mm: (-[WebView addWindowObservers]): (-[WebView removeWindowObservers]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView _updateFocusedAndActiveState]): (-[WebView _windowDidBecomeKey:]): (-[WebView _windowDidResignKey:]): (-[WebView _windowWillOrderOnScreen:]):
12:35 Changeset [37383] by mrowe@apple.com

Fix typo in method name.

11:28 Changeset [37382] by alp@webkit.org

2008-10-07 Alp Toker <alp@nuanti.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=21392
[GTK] Auto-generate JS DOM binding sources list

Remove the huge lists of generated DOM binding sources and headers in
the build system. These are difficult to maintain and can be derived
automatically.

The new strategy is to re-use the existing lists of IDL sources (which
are needed for dist support anyway). This will also ease the addition
of new language bindings.

11:17 Changeset [37381] by cwzwarich@webkit.org

2008-10-07 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r37370.

10:30 Changeset [37380] by mrowe@apple.com

Merge r35415.

10:30 Changeset [37379] by mrowe@apple.com

Merge r35362.

10:27 Changeset [37378] by darin@apple.com

2008-10-07 Darin Adler <darin@apple.com>

  • coding/RefPtr.html: Second draft.
09:30 Changeset [37377] by vestbo@webkit.org

2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Don't attempt to paint when updating control tints

We don't have a valid PlatformGraphicsContext so schedule
the dirty scrollbar/scrollview area for repaint instead.

04:20 Changeset [37376] by vestbo@webkit.org

2008-10-07 Tor Arne Vestbø <tavestbo@trolltech.com>

QtWebKit build fix after changes to FrameLoaderClient.h in r37371

03:39 QtWebKitContrib edited by ariya.hidayat@trolltech.com
add irc nicks (diff)
03:36 QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
01:09 Changeset [37375] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Make sure the parent visibility state is set up properly on the outermost ScrollView widget.
This fixes the repainting issues with viewless WebKit on Mac.

Reviewed by Sam Weinig

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage):
00:54 Changeset [37374] by zecke@webkit.org

[qt] Build fix after Scrollbar.h and Widget.h changes.

00:50 Changeset [37373] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Make sure viewless Mac WebKit does a layout if needed before drawing.

Reviewed by Sam Weinig

  • WebView/WebView.mm: (-[WebView viewWillDraw]):
00:47 Changeset [37372] by hyatt@apple.com

2008-10-07 David Hyatt <hyatt@apple.com>

Make sure observers get hooked up to watch for size changes in viewless WebKit mode.

Reviewed by Sam Weinig

  • ChangeLog:
  • WebView/WebFrame.mm: (-[WebFrame _drawRect:contentsOnly:]):
  • WebView/WebView.mm: (-[WebView viewWillDraw]): (-[WebView _boundsChanged]): (-[WebView addSizeObservers]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):
Note: See TracTimeline for information about the timeline view.