Timeline


and

10/27/08:

22:24 Changeset [37922] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

Clear the window shell when destroying a page to allow documents
which have no way of being reached anymore, to be torn down.

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed):
20:06 Changeset [37921] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

20:05 Changeset [37920] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.26.6

New tag.

19:40 Changeset [37919] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Stop discarding CodeBlock samples that can't be charged to a specific
opcode. Instead, charge the relevant CodeBlock, and provide a footnote
explaining the situation.


This will help us tell which CodeBlocks are hot, even if we can't
identify specific lines of code within the CodeBlocks.

  • VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::compareScopeSampleRecords): (JSC::SamplingTool::dump):
  • VM/SamplingTool.h: (JSC::ScopeSampleRecord::ScopeSampleRecord): (JSC::ScopeSampleRecord::~ScopeSampleRecord):
19:21 Changeset [37918] by antti@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-10-27 Antti Koivisto <antti@apple.com>

Add a file.

  • blog-files/squirrelfish-link-animated.svg: Added.
18:40 Changeset [37917] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/Plugins/WebBaseNetscapePluginStream.h

Whoops, did not mean to commit this.

18:39 Changeset [37916] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Use the C++ stream object for JS requests as well.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):
18:31 Changeset [37915] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.


  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::destroyStream): (WebNetscapePluginStream::destroyStreamWithReason): (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError): (WebNetscapePluginStream::deliverData):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView disconnectStream:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
18:07 Changeset [37914] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Mitz Pettel.


Move code from dealloc and finalize to the WebNetscapePluginStream destructor.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::~WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
18:01 Changeset [37913] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView destroyStream:reason:]):
17:43 Changeset [37912] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Change the Obj-C init methods to simply call WebNetscapePluginStream::create.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream initWithFrameLoader:]): (WebNetscapePluginStream::WebNetscapePluginStream): (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
17:18 Changeset [37911] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Convert more code over to C++.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::plugin): (WebNetscapePluginStream::setRequestURL): Convert to C++.
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::start): (WebNetscapePluginStream::stop): Ditto.


(WebNetscapePluginStream::startStreamWithResponse):
Ditto.


(-[WebBaseNetscapePluginStream startStreamWithResponse:]):
Call the C++ version.


(-[WebBaseNetscapePluginStream impl]):
New accessor for the C++ class.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): Call the C++ methods.
16:48 Changeset [37910] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r37628.

16:47 Changeset [37909] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r37897.

16:25 Changeset [37908] by antti@apple.com
  • 1 edit
    2 adds in trunk/WebKitSite

2008-10-27 Antti Koivisto <antti@apple.com>

Add some svg files.

  • blog-files/cubes-7.svg: Added.
  • blog-files/number-morph.svg: Added.
15:57 Changeset [37907] by darin@apple.com
  • 2 edits in trunk/WebKit

2008-10-27 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
15:15 Changeset [37906] by kevino@webkit.org
  • 2 edits in trunk

Reviewed by Kevin Ollivier.

Update the active state as well as the focused state as both need to be true
for the caret to be drawn.

https://bugs.webkit.org/show_bug.cgi?id=21900

15:10 Changeset [37905] by darin@apple.com
  • 2 edits in trunk/BugsSite

2008-10-27 Darin Adler <darin@apple.com>

  • template/en/custom/attachment/reviewform.html.tmpl: Leave out the comment if it's untouched.
15:07 Changeset [37904] by kevino@webkit.org
  • 6 edits in trunk

wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.

14:45 Changeset [37903] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-10-27 Michael Tross <michael@tross.org>

Reviewed by Alp Toker. Landed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=21827
[GTK] Fix memory leak in webkit_web_view_load_string

  • webkit/webkitwebview.cpp:
14:20 Changeset [37902] by darin@apple.com
  • 13 edits in trunk/WebCore

2008-10-27 Michael Knaup <michael.knaup@mac.com>

Reviewed and tweaked by Darin Adler.

Bug 8988: Add support for Mozilla CSS custom cursors.
Added -webkit-grab and -webkit-grabbing cursor suppport
for the Mac, dummy implementations for other platforms.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Updated since the -webkit-grabbing cursor is now the last one.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  • css/CSSValueKeywords.in: Added -webkit-grab and -webkit-grabbing.
  • manual-tests/cursor.html: Added -webkit-zoom-in, webkit-zoom-out, -webkit-grab, and -webkit-grabbing.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING.
  • platform/Cursor.h: Added grabCursor and grabbingCursor.
  • platform/gtk/CursorGtk.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/mac/CursorMac.mm: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/qt/CursorQt.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/win/CursorWin.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • platform/wx/CursorWx.cpp: (WebCore::grabCursor): Added. (WebCore::grabbingCursor): Added.
  • rendering/style/RenderStyleConstants.h: Added CURSOR_WEBKIT_GRAB and CURSOR_WEBKIT_GRABBING. Also broke ECursor out into a single constant per line. Also added a couple of comments.
13:37 Changeset [37901] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-10-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

  • VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
  • VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.
13:07 Changeset [37900] by eric@webkit.org
  • 2 edits in trunk/WebCore

2008-10-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

  • svg/SVGAnimatedTemplate.h: needed a HashMap define
12:49 Changeset [37899] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dave Hyatt.

Infinite recursion crash in WebCore::RenderSVGRoot::absoluteClippedOverflowRect on a <stop> element outside of a gradient block
https://bugs.webkit.org/show_bug.cgi?id=20400

Test: svg/custom/stop-crash.svg

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::absoluteClippedOverflowRect):
11:55 Changeset [37898] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

No need to call release if the connection is null.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
11:52 Changeset [37897] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-10-27 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6322650> Crash in fast/loader/simultaneous-reloads-assert.html


Make sure to null check the NSURLConnection object.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):
01:53 Changeset [37896] by ap@webkit.org
  • 5 edits in trunk/WebCore

Fix non-Mac builds.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCoreSources.bkl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
00:59 Changeset [37895] by ap@webkit.org
  • 10 edits
    2 moves
    2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21886
window.HTMLOptionElement == "[object HTMLElementConstructor]" instead of HTMLOptionElementConstructor

Test: fast/dom/HTMLOptionElement/option-prototype.html

We now have separate objects for window.Option and window.HTMLOptionElement - the latter
"constructor" cannot be used to construct anything. This matches Firefox behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseOption):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: Removed.
  • bindings/js/JSHTMLOptionElementConstructor.h: Removed.
  • bindings/js/JSOptionConstructor.cpp: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.cpp.
  • bindings/js/JSOptionConstructor.h: Copied from WebCore/bindings/js/JSHTMLOptionElementConstructor.h.
  • html/HTMLOptionElement.idl: Renamed JSHTMLOptionElementConstructor to JSOptionConstructor.
  • html/HTMLOptionElement.idl: Generate a constructor.

10/25/08:

13:26 Changeset [37894] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • VM/Machine.cpp: (JSC::Machine::privateExecute): Provide a dummy value to the HostCallRecord in CTI non-sampling builds, to silence compiler warning.
13:21 Changeset [37893] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Windows build.

  • VM/SamplingTool.h: (JSC::SamplingTool::encodeSample): Explicitly cast bool to int, to silence compiler warning.
13:03 Changeset [37892] by ggaren@apple.com
  • 3 edits in trunk/WebCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Not reviewed.


Try to fix Mac debug build on the buildbot.

  • platform/FileChooser.cpp: (WebCore::FileChooserClient::~FileChooserClient):
  • platform/FileChooser.h: Moved destructor to .cpp file, to avoid a weak exported symbol.
12:59 Changeset [37891] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-10-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig, with Gavin Barraclough's help.


Fixed Sampling Tool:

  • Made CodeBlock sampling work with CTI
  • Improved accuracy by unifying most sampling data into a single 32bit word, which can be written / read atomically.
  • Split out three different #ifdefs for modularity: OPCODE_SAMPLING; CODEBLOCK_SAMPLING; OPCODE_STATS.
  • Improved reporting clarity
  • Refactored for code clarity
  • VM/CTI.cpp: (JSC::CTI::emitCTICall): (JSC::CTI::compileOpCall): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile):
  • VM/CTI.h: Updated CTI codegen to use the unified SamplingTool interface for encoding samples. (This required passing the current vPC to a lot more functions, since the unified interface samples the current vPC.) Added hooks for writing the current CodeBlock* on function entry and after a function call, for the sake of the CodeBlock sampler. Removed obsolete hook for clearing the current sample inside op_end. Also removed the custom enum used to differentiate flavors of op_call, since the OpcodeID enum works just as well. (This was important in an earlier version of the patch, but now it's just cleanup.)
  • VM/CodeBlock.cpp: (JSC::CodeBlock::lineNumberForVPC):
  • VM/CodeBlock.h: Upated for refactored #ifdefs. Changed lineNumberForVPC to be robust against vPCs not recorded for exception handling, since the Sampler may ask for an arbitrary vPC.
  • VM/Machine.cpp: (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_NotJSConstruct):
  • VM/Machine.h: (JSC::Machine::setSampler): (JSC::Machine::sampler): (JSC::Machine::jitCodeBuffer): Upated for refactored #ifdefs. Changed Machine to use SamplingTool helper objects to record movement in and out of host code. This makes samples a bit more precise.


  • VM/Opcode.cpp: (JSC::OpcodeStats::~OpcodeStats):
  • VM/Opcode.h: Upated for refactored #ifdefs. Added a little more padding, to accomodate our more verbose opcode names.
  • VM/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): Only count a sample toward our total if we actually record it. This solves cases where a CodeBlock will claim to have been sampled many times, with reported samples that don't match.

(JSC::SamplingTool::run): Read the current sample into a Sample helper
object, to ensure that the data doesn't change while we're analyzing it,
and to help decode the data. Only access the CodeBlock sampling hash
table if CodeBlock sampling has been enabled, so non-CodeBlock sampling
runs can operate with even less overhead.

(JSC::SamplingTool::dump): I reorganized this code a lot to print the
most important info at the top, print as a table, annotate and document
the stuff I didn't understand when I started, etc.

  • VM/SamplingTool.h: New helper classes, described above.
  • kjs/Parser.h:
  • kjs/Shell.cpp: (runWithScripts):
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): Updated for new sampling APIs.
  • wtf/Platform.h: Moved sampling #defines here, since our custom is to put ENABLE #defines into Platform.h. Made explicit the fact that CODEBLOCK_SAMPLING depends on OPCODE_SAMPLING.
12:11 Changeset [37890] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix.

08:22 Changeset [37889] by vestbo@webkit.org
  • 4 edits in trunk

2008-10-25 Jade Han <jade.han@nokia.com>

Reviewed by Anders.

Enable custom properties for Qt runtime objects in QtWebKit

https://bugs.webkit.org/show_bug.cgi?id=21813

02:37 Changeset [37888] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

JSC Build fix, not reviewed.

  • VM/CTI.cpp: add missing include stdio.h for debug builds
00:24 Changeset [37887] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-10-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: add '-' to Wl which was missed in r36845

  • GNUmakefile.am:

10/24/08:

23:58 Changeset [37886] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Yet another windows build fix.

  • WebCoreSupport/WebChromeClient.cpp:
23:39 Changeset [37885] by weinig@apple.com
  • 2 edits in trunk/WebKit/qt

2008-10-24 Sam Weinig <sam@webkit.org>

Another Qt build fix.

  • WebCoreSupport/ChromeClientQt.cpp:
23:38 Changeset [37884] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

2008-10-24 Sam Weinig <sam@webkit.org>

Another windows build fix.

  • WebCoreSupport/WebChromeClient.cpp:
23:36 Changeset [37883] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix windows build.

  • page/Chrome.cpp:
  • page/Chrome.h:
23:31 Changeset [37882] by weinig@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-10-24 Sam Weinig <sam@webkit.org>

Fix the Gtk build.

  • WebCoreSupport/ChromeClientGtk.cpp:
23:29 Changeset [37881] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-24 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • platform/qt/FileChooserQt.cpp:
23:02 Changeset [37880] by weinig@apple.com
  • 28 edits in trunk

WebCore:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

Move file choosing into WebKit ChromeClient.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::runOpenPanel):
  • page/Chrome.cpp: (WebCore::Chrome::runOpenPanel):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/mac/ChromeMac.mm:
  • platform/FileChooser.h:
  • platform/mac/FileChooserMac.mm:
  • platform/qt/FileChooserQt.cpp:
  • platform/win/FileChooserWin.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

WebKit/gtk:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel):

WebKit/qt:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runOpenPanel):
  • WebCoreSupport/ChromeClientQt.h:

WebKit/win:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel):
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2008-10-24 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=21759
Layering violation: FileChooser should not depend on Document/Frame/Page

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::runOpenPanel):
  • WebKitSupport/ChromeClientWx.h:
21:48 Changeset [37879] by eric@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Sam Weinig.

Add missing results.

  • fast/js/global-constructors-expected.txt: Added.
18:34 Changeset [37878] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix - add newIconForFiles stub.

18:15 Changeset [37877] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use the CGFont metrics APIs for more accurate measurements, and tweak the y
value the text is drawn at (it was a couple pixels off before because wx
internally adds to the y value.

https://bugs.webkit.org/show_bug.cgi?id=21853

17:09 Changeset [37876] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Get rid of a bonus ASSERT when using a null string as a regexp.
Specifically calling: RegularExpression::match() with String::empty()
will hit this ASSERT.
Chromium hits this, but I don't know of any way to make a layout test.

  • pcre/pcre_exec.cpp: (jsRegExpExecute):
16:46 Changeset [37875] by eric@webkit.org
  • 9 edits
    2 adds
    1 delete in trunk

Reviewed by Sam Weinig.

Generate missing constructors and add test to prevent missing ones in the future
https://bugs.webkit.org/show_bug.cgi?id=21846

fast/dom/wrapper-classes-expected.txt results were incorrectly platform-specific
that test used to be platform-dependent, but isn't anymore

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/js/global-constructors.html: Added.
  • fast/js/resources/global-constructors.js: Added.
  • platform/mac/fast/dom/wrapper-classes-expected.txt: Removed.
16:39 Changeset [37874] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21836
REGRESSION: Sign-in on Fancast.com causes crash in Webkit nightly

Test: http/tests/xmlhttprequest/detaching-frame.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Null check the window - even though XHR needs a context (AKA frame) to be serviced, the frame may be disconnected when dispatching the same callback that results in this function being called.
16:07 Changeset [37873] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2008-10-24 Anders Carlsson <andersca@apple.com>

Try fixing the 64-bit build.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty):
16:06 Changeset [37872] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-24 Anders Carlsson <andersca@apple.com>

Fix Tiger build.


  • WebView/WebUIDelegate.h:
16:04 Changeset [37871] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Gtk build fix.

  • platform/gtk/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
15:20 Changeset [37870] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6164952> Use constant kCGInterpolationMedium in GraphicsContextCG.cpp rather than hard-coded values.

Reviewed by Sam Weinig.

15:16 Changeset [37869] by andersca@apple.com
  • 19 edits
    2 adds in trunk

WebCore:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct


  • WebCore.NPAPI.exp: Export _NPN_Construct.


  • bridge/NP_jsobject.cpp: (_NPN_Construct): Implement this.


  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::supportsConstruct): (JSC::Bindings::CInstance::invokeConstruct): Have this call the appropriate NPClass method.


  • bridge/npruntime.h: Add NPN_Construct.
  • bridge/npruntime_impl.h: Add _NPN_Construct.


  • bridge/runtime.h: (JSC::Bindings::Instance::supportsConstruct): (JSC::Bindings::Instance::invokeConstruct): New methods.


  • bridge/runtime_object.cpp: (JSC::callRuntimeConstructor): Call the native instance.


(JSC::RuntimeObjectImp::getConstructData):
Implement this.


  • bridge/runtime_object.h: Add new method declarations.


  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize m_pluginFuncs.construct.

WebKit/mac:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct


Set construct.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

WebKitTools:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.


<rdar://problem/5440917> Support NPN_Construct


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testCallback): Fix a memory leak.


(testConstruct):
New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.


(pluginInvoke):
Handle testConstruct.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testGetProperty): Add objectPointer property.


(testEnumerate):
Only enumerate the two first properties.


(testConstruct):
Add a simple construct implementation that just returns the test object.

LayoutTests:

2008-10-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5440917> Support NPN_Construct


Add testcase.


  • plugins/netscape-construct-expected.txt: Added.
  • plugins/netscape-construct.html: Added.
15:16 Changeset [37868] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Suggested and rubber-stamped by Geoff Garen.

Fix a crash when opening Font Picker.

The change also hopefully fixes this bug, which I could never reproduce:
https://bugs.webkit.org/show_bug.cgi?id=20241
<rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close

  • API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of dynamic one.
15:09 Changeset [37867] by adele@apple.com
  • 3 edits in trunk/WebCore

2008-10-24 Adele Peterson <adele@apple.com>

Build fix.

  • platform/FileChooser.h: (WebCore::FileChooserClient::~FileChooserClient):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles):
14:51 Changeset [37866] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Fix GTK build break.

Reviewed by David Kilzer.

  • GNUmakefile.am: Do not include .idl files whose generated files should not be compiled.
14:46 Changeset [37865] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Wx build fix.

  • platform/wx/TemporaryLinkStubs.cpp: (WebCore::setFocusRingColorChangeFunction): Removed in r37858.
14:44 Changeset [37864] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6119711> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS define.

Rubber-stamped by Tim Hatcher.

14:12 Changeset [37863] by adele@apple.com
  • 23 edits
    6 adds in trunk

WebCore:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
This is consistent with the direction HTML5 will be going in the future.

The initial implementation here will show "n files" as the text next to the control when multiple files are selected. You can view
the individual files in a tooltip for now. Improvements to this control will come later.

Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.
These FileList Files can also be sent in an XMLHTTPRequest.

  • manual-tests/post-multi-file-upload.html: Added.
  • manual-tests/resources/multiFileResources: Added.
  • manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
  • manual-tests/resources/multiFileResources/testFile1.html: Added.
  • manual-tests/resources/multiFileResources/testFile2.html: Added.
  • manual-tests/resources/multiFileResources/testFile3.html: Added.
  • WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute. (WebCore::HTMLInputElement::value): Added comments. The HTML5 spec says that value shouldn't apply for the file upload control, but we don't want to break the behavior for existing websites that may rely on this. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead. (WebCore::HTMLInputElement::setFileListFromRenderer): Added.
  • html/HTMLInputElement.h:
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
  • page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
  • platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::create): (WebCore::FileChooser::clear): (WebCore::FileChooser::chooseFile): (WebCore::FileChooser::chooseFiles): (WebCore::FileChooser::chooseIcon):
  • platform/FileChooser.h: (WebCore::FileChooser::filePaths): (WebCore::FileChooser::allowsMultipleFiles):
  • platform/graphics/Icon.h:
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
  • platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth): Updated to deal with new filenames vector.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle): Removed unnecessary assertion. This can get hit when connectionDidFinishLoading and cancel both get called for the same ResourceHandle. This getting called twice has no negative effect.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Calls setFileListFromRenderer. (WebCore::RenderFileUploadControl::allowsMultipleFiles): Added. (WebCore::RenderFileUploadControl::updateFromElement): Uses the new filenames call from FileChooser. (WebCore::RenderFileUploadControl::receiveDroppedFiles): Updated to support multiple files.
  • rendering/RenderFileUploadControl.h:

WebKit/mac:

2008-10-24 Adele Peterson <adele@apple.com>

Reviewed by Sam Weinig.

WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runOpenPanel): (-[WebOpenPanelResultListener chooseFilenames:]):
  • WebView/WebUIDelegate.h:
14:09 Changeset [37862] by aroben@apple.com
  • 2 edits in trunk/WebKit/cf

Windows build fix

  • WebCoreSupport/WebInspectorClientCF.cpp: Define WTF_PLATFORM_CF manually. Normally this gets defined on Windows by including config.h, but Mac has no config.h for WebKit, so we can't do that here.
14:07 Changeset [37861] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove ScopeChainNode::bottom() and inline it into its only caller,
ScopeChainnode::globalObject().

  • kjs/JSGlobalObject.h: (JSC::ScopeChainNode::globalObject):
  • kjs/ScopeChain.h: (JSC::ScopeChain::bottom):
13:54 Changeset [37860] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/wx

Build fix.

Reviewed by Greg Bolsinga.

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClientWx::populateSetting): Changed
InspectorClient
to InspectorClientWx::. (WebCore::InspectorClientWx::storeSetting): Ditto. (WebCore::InspectorClientWx::removeSetting): Ditto.
13:44 Changeset [37859] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21862: Create JSFunction prototype property lazily
<https://bugs.webkit.org/show_bug.cgi?id=21862>

This is a 1.5% speedup on SunSpider and a 1.4% speedup on the V8
benchmark suite, including a 3.8% speedup on Earley-Boyer.

  • kjs/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • kjs/nodes.cpp: (JSC::FuncDeclNode::makeFunction): (JSC::FuncExprNode::makeFunction):
13:43 Changeset [37858] by pkasting@chromium.org
  • 6 edits in trunk/WebCore

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=21844
Remove setFocusRingColorChangeFunction.

  • page/Page.cpp: (WebCore::Page::Page):
  • platform/graphics/Color.h:
  • platform/graphics/mac/ColorMac.mm: (WebCore::focusRingColor):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/win/ColorSafari.cpp:
13:32 Changeset [37857] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Build fix for Qt.

Reviewed by Greg.

  • WebCore.pro: Added missing *.idl files.
13:27 Changeset [37856] by timothy@apple.com
  • 1 edit in trunk/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp

Fix the Windows build.

13:23 Changeset [37855] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig

Add to the comment some new CSSRule types that are not yet tested.

  • fast/dom/wrapper-classes.html:
13:10 Changeset [37854] by ddkilzer@apple.com
  • 20 edits
    24 adds in trunk

JavaScriptCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

  • wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

  • DerivedSources.make:
  • GNUmakefile.am: Added Geolocation support
  • WebCore.pro: Added Geolocation support
  • WebCore.vcproj/WebCore.vcproj: Added Geolocation support
  • WebCore.xcodeproj/project.pbxproj: Added Geolocation support
  • WebCoreSources.bkl: Added Geolocation support
  • bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
  • bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
  • bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
  • bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
  • bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
  • loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
  • page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
  • page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
  • page/Geolocation.idl: Added.
  • page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
  • page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
  • page/Geoposition.idl: Added.
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
  • page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
  • page/Navigator.idl: accessor for Geolocation
  • page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
  • page/PositionCallback.idl: Added.
  • page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
  • page/PositionError.idl: Added.
  • page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
  • page/PositionErrorCallback.idl: Added.
  • page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
  • page/PositionOptions.idl: Added.
  • platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
  • platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-24 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

  • geolocation: Added.
  • geolocation/geolocation-not-implemented-expected.txt: Added.
  • geolocation/geolocation-not-implemented.html: Added.
  • geolocation/geolocation-test.js: Copied from LayoutTests/media/video-test.js. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):
12:59 Changeset [37853] by simon.fraser@apple.com
  • 4 edits in trunk/LayoutTests

2008-10-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21858

Add additional CSSRule types to the DOM-wrapper tests.

  • fast/dom/resources/wrapper-identity-base.js:
  • fast/dom/wrapper-identity-expected.txt:
  • platform/mac/fast/dom/objc-wrapper-identity-expected.txt:
12:32 Changeset [37852] by simon.fraser@apple.com
  • 7 edits
    1 add in trunk/WebCore

2008-10-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21818

Add HashTraits for AtomicString so that AtomicString can be used as
the key for a HashMap or HashSet.

  • GNUmakefile.am: add AtomicStringHash.h
  • WebCore.vcproj/WebCore.vcproj: add AtomicStringHash.h
  • WebCore.xcodeproj/project.pbxproj: add AtomicStringHash.h
  • platform/text/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::isHashTableDeletedValue):

specialize DefaultHash for AtomicString to use AtomicStringHash

  • platform/text/AtomicStringHash.h: Added.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::StringImpl):

compute the hash up-front for the empty string

  • platform/text/StringImpl.h: (WebCore::StringImpl::existingHash):

method to get the hash without a test and branch, for callers like
AtomicStringHash who can guarantee that the hash has already been computed.

12:15 Changeset [37851] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-10-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig

https://bugs.webkit.org/show_bug.cgi?id=21857

Add WebKitCSSKeyframeRule and WebKitCSSKeyframesRule to the
switch in _wrapCSSRule.

  • bindings/objc/DOMCSS.mm: (+[DOMCSSRule _wrapCSSRule:WebCore::]):
12:14 Changeset [37850] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • plugins/PluginView.cpp:
12:10 Changeset [37849] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/replaced/percent-height-in-anonymous-block-widget.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Copied code added to RenderBox::destroy() in r36513 into this function.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/replaced/percent-height-in-anonymous-block-widget.html: Added.
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.checksum: Added.
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.png: Added.
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-widget-expected.txt: Added.
11:49 Changeset [37848] by timothy@apple.com
  • 22 edits
    4 adds in trunk

Add a mechanism to store and retrieve preferences for the Web Inspector.

WebCore:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Add a mechanism to ask the InspectorClient for key/value setting pairs.
These settings can be strings, numbers, booleans or string vectors. The
settings are also bridged to and from JavaScript.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebCore.base.exp: Expose the String CFStringRef constructor.
  • inspector/InspectorClient.h: (WebCore::InspectorClient::populateSetting): Added, pure virtual. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
  • inspector/InspectorController.cpp: (WebCore::setting): Calls InspectorController::setting and wraps the result in script types. (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types. (WebCore::InspectorController::InspectorController): Increment a global static to track the number of live InspectorControllers. (WebCore::InspectorController::~InspectorController): Decrement the global static that tracks the number of live InspectorControllers. Delete the setting cache if there are no more live controllers. (WebCore::InspectorController::setting): Check the cache and return the setting from there, otherwise make a new Setting and ask the client to populate it. (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it. (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting to the InspectorController script class.
  • inspector/InspectorController.h: (WebCore::InspectorController::Setting::Setting): (WebCore::InspectorController::Setting::operator=): (WebCore::InspectorController::Setting::type): Return m_type. (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct. (WebCore::InspectorController::Setting::stringVector): Return m_stringVector. Assert the type is correct. (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double. Assert the type is correct. (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer. Assert the type is correct. (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean. Assert the type is correct. (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right field and the type.
  • loader/EmptyClients.h: (WebCore::EmptyInspectorClient::populateSetting): Added, empty method. (WebCore::EmptyInspectorClient::storeSetting): Ditto. (WebCore::EmptyInspectorClient::removeSetting): Ditto.

WebKit:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.

WebKit/gtk:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::populateSetting): Not implemented. (WebKit::InspectorClient::storeSetting): Ditto. (WebKit::InspectorClient::removeSetting): Ditto.
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebCoreSupport/WebInspectorClient.h: Add the new methods and guard the ObjC parts of the header.

WebKit/qt:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::populateSetting): Not implemented. (WebCore::InspectorClientQt::storeSetting): Ditto. (WebCore::InspectorClientQt::removeSetting): Ditto.
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Implement new InspectorClient methods to work with Settings.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Adam Roben.

  • WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
  • WebCoreSupport/WebInspectorClient.h: Add the new methods.

WebKit/wx:

2008-10-24 Timothy Hatcher <timothy@apple.com>

Stub out new InspectorClient methods.

https://bugs.webkit.org/show_bug.cgi?id=21856

Reviewed by Darin Adler.

  • WebKitSupport/InspectorClientWx.cpp: (WebCore::InspectorClient::populateSetting): Not implemented. (WebCore::InspectorClient::storeSetting): Ditto. (WebCore::InspectorClient::removeSetting): Ditto.
  • WebKitSupport/InspectorClientWx.h:
11:19 Changeset [37847] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Bug 21850: svn-apply and svn-unapply should preserve patch line endings

<https://bugs.webkit.org/show_bug.cgi?id=21850>

Reviewed by Adam Roben.

  • Scripts/svn-apply: Save end-of-line characters when stripping them off each line of a patch so that they may be restored after processing the line.
  • Scripts/svn-unapply: Ditto.
11:10 Changeset [37846] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-10-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove some C-style casts.

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):
09:22 Changeset [37845] by darin@apple.com
  • 301 edits in trunk

JavaScriptCore:

2008-10-24 Darin Adler <darin@apple.com>

  • API/APICast.h:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSValueRef.cpp:
  • VM/CTI.cpp:
  • VM/CTI.h:
  • VM/CodeBlock.cpp:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp:
  • VM/CodeGenerator.h:
  • VM/ExceptionHelpers.cpp:
  • VM/ExceptionHelpers.h:
  • VM/JSPropertyNameIterator.cpp:
  • VM/JSPropertyNameIterator.h:
  • VM/Machine.cpp:
  • VM/Machine.h:
  • VM/Register.h:
  • kjs/ArgList.cpp:
  • kjs/ArgList.h:
  • kjs/Arguments.cpp:
  • kjs/Arguments.h:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanConstructor.cpp:
  • kjs/BooleanConstructor.h:
  • kjs/BooleanObject.h:
  • kjs/BooleanPrototype.cpp:
  • kjs/CallData.cpp:
  • kjs/CallData.h:
  • kjs/ConstructData.cpp:
  • kjs/ConstructData.h:
  • kjs/DateConstructor.cpp:
  • kjs/DateInstance.h:
  • kjs/DatePrototype.cpp:
  • kjs/DatePrototype.h:
  • kjs/DebuggerCallFrame.cpp:
  • kjs/DebuggerCallFrame.h:
  • kjs/ErrorConstructor.cpp:
  • kjs/ErrorPrototype.cpp:
  • kjs/ExecState.cpp:
  • kjs/ExecState.h:
  • kjs/FunctionConstructor.cpp:
  • kjs/FunctionPrototype.cpp:
  • kjs/FunctionPrototype.h:
  • kjs/GetterSetter.cpp:
  • kjs/GetterSetter.h:
  • kjs/InternalFunction.h:
  • kjs/JSActivation.cpp:
  • kjs/JSActivation.h:
  • kjs/JSArray.cpp:
  • kjs/JSArray.h:
  • kjs/JSCell.cpp:
  • kjs/JSCell.h:
  • kjs/JSFunction.cpp:
  • kjs/JSFunction.h:
  • kjs/JSGlobalData.h:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObject.h:
  • kjs/JSGlobalObjectFunctions.cpp:
  • kjs/JSGlobalObjectFunctions.h:
  • kjs/JSImmediate.cpp:
  • kjs/JSImmediate.h:
  • kjs/JSNotAnObject.cpp:
  • kjs/JSNotAnObject.h:
  • kjs/JSNumberCell.cpp:
  • kjs/JSNumberCell.h:
  • kjs/JSObject.cpp:
  • kjs/JSObject.h:
  • kjs/JSStaticScopeObject.cpp:
  • kjs/JSStaticScopeObject.h:
  • kjs/JSString.cpp:
  • kjs/JSString.h:
  • kjs/JSValue.h:
  • kjs/JSVariableObject.h:
  • kjs/JSWrapperObject.h:
  • kjs/MathObject.cpp:
  • kjs/MathObject.h:
  • kjs/NativeErrorConstructor.cpp:
  • kjs/NumberConstructor.cpp:
  • kjs/NumberConstructor.h:
  • kjs/NumberObject.cpp:
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.cpp:
  • kjs/ObjectConstructor.cpp:
  • kjs/ObjectPrototype.cpp:
  • kjs/ObjectPrototype.h:
  • kjs/PropertyMap.h:
  • kjs/PropertySlot.cpp:
  • kjs/PropertySlot.h:
  • kjs/RegExpConstructor.cpp:
  • kjs/RegExpConstructor.h:
  • kjs/RegExpMatchesArray.h:
  • kjs/RegExpObject.cpp:
  • kjs/RegExpObject.h:
  • kjs/RegExpPrototype.cpp:
  • kjs/Shell.cpp:
  • kjs/StringConstructor.cpp:
  • kjs/StringObject.cpp:
  • kjs/StringObject.h:
  • kjs/StringObjectThatMasqueradesAsUndefined.h:
  • kjs/StringPrototype.cpp:
  • kjs/StructureID.cpp:
  • kjs/StructureID.h:
  • kjs/collector.cpp:
  • kjs/collector.h:
  • kjs/completion.h:
  • kjs/grammar.y:
  • kjs/interpreter.cpp:
  • kjs/interpreter.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/nodes.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/protect.h:
  • profiler/ProfileGenerator.cpp:
  • profiler/Profiler.cpp:
  • profiler/Profiler.h: Use JSValue* instead of JSValuePtr.

JavaScriptGlue:

2008-10-24 Darin Adler <darin@apple.com>

  • JSObject.cpp: (nativeCallFunction):
  • JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction):
  • JSValueWrapper.h:
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive):
  • UserObjectImp.h: (UserObjectImp::createStructureID): Use JSValue* instead of JSValuePtr.

WebCore:

2008-10-24 Darin Adler <darin@apple.com>

  • bindings/js/JSAttrCustom.cpp:
  • bindings/js/JSCSSRuleCustom.cpp:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
  • bindings/js/JSCSSValueCustom.cpp:
  • bindings/js/JSCanvasPixelArrayCustom.h:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp:
  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDatabaseCustom.cpp:
  • bindings/js/JSDedicatedWorkerCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventTarget.cpp:
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSEventTargetNodeCustom.cpp:
  • bindings/js/JSHTMLAllCollection.h:
  • bindings/js/JSHTMLAppletElementCustom.cpp:
  • bindings/js/JSHTMLCollectionCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLEmbedElementCustom.cpp:
  • bindings/js/JSHTMLFormElementCustom.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLFrameSetElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp:
  • bindings/js/JSHTMLInputElementCustom.cpp:
  • bindings/js/JSHTMLObjectElementCustom.cpp:
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:
  • bindings/js/JSHTMLSelectElementCustom.cpp:
  • bindings/js/JSHTMLSelectElementCustom.h:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSImageDataCustom.cpp:
  • bindings/js/JSInspectedObjectWrapper.cpp:
  • bindings/js/JSInspectedObjectWrapper.h:
  • bindings/js/JSInspectorCallbackWrapper.cpp:
  • bindings/js/JSInspectorCallbackWrapper.h:
  • bindings/js/JSJavaScriptCallFrameCustom.cpp:
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSMimeTypeArrayCustom.cpp:
  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/js/JSNamedNodesCollection.cpp:
  • bindings/js/JSNamedNodesCollection.h:
  • bindings/js/JSNavigatorCustom.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSNodeFilterCondition.cpp:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSNodeIteratorCustom.cpp:
  • bindings/js/JSNodeListCustom.cpp:
  • bindings/js/JSPluginArrayCustom.cpp:
  • bindings/js/JSPluginCustom.cpp:
  • bindings/js/JSPluginElementFunctions.cpp:
  • bindings/js/JSPluginElementFunctions.h:
  • bindings/js/JSQuarantinedObjectWrapper.cpp:
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/js/JSRGBColor.cpp:
  • bindings/js/JSRGBColor.h:
  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/js/JSSQLTransactionCustom.cpp:
  • bindings/js/JSSVGElementInstanceCustom.cpp:
  • bindings/js/JSSVGLengthCustom.cpp:
  • bindings/js/JSSVGMatrixCustom.cpp:
  • bindings/js/JSSVGPathSegCustom.cpp:
  • bindings/js/JSSVGPathSegListCustom.cpp:
  • bindings/js/JSSVGPointListCustom.cpp:
  • bindings/js/JSSVGTransformListCustom.cpp:
  • bindings/js/JSStorageCustom.cpp:
  • bindings/js/JSStyleSheetCustom.cpp:
  • bindings/js/JSStyleSheetListCustom.cpp:
  • bindings/js/JSTextCustom.cpp:
  • bindings/js/JSTreeWalkerCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp:
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp:
  • bindings/js/JSXSLTProcessorCustom.cpp:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/c/c_instance.h:
  • bridge/c/c_runtime.cpp:
  • bridge/c/c_runtime.h:
  • bridge/c/c_utility.cpp:
  • bridge/c/c_utility.h:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_instance.h:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jni_objc.mm:
  • bridge/jni/jni_runtime.cpp:
  • bridge/jni/jni_runtime.h:
  • bridge/jni/jni_utility.cpp:
  • bridge/jni/jni_utility.h:
  • bridge/objc/WebScriptObject.h:
  • bridge/objc/objc_class.h:
  • bridge/objc/objc_class.mm:
  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm:
  • bridge/qt/qt_class.cpp:
  • bridge/qt/qt_class.h:
  • bridge/qt/qt_instance.cpp:
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
  • bridge/runtime.cpp:
  • bridge/runtime.h:
  • bridge/runtime_array.cpp:
  • bridge/runtime_array.h:
  • bridge/runtime_method.cpp:
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:
  • bridge/runtime_object.h:
  • bridge/testqtbindings.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptProfile.cpp:
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp:
  • inspector/JavaScriptProfileNode.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • page/Console.cpp:
  • page/Console.h:
  • plugins/MimeTypeArray.h:
  • plugins/Plugin.h:
  • plugins/PluginArray.h:
  • plugins/PluginView.cpp:
  • xml/XMLHttpRequest.cpp: Use JSValue* instead of JSValuePtr.

WebKit/mac:

2008-10-24 Darin Adler <darin@apple.com>

  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
  • WebView/WebView.mm: (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Use JSValue* instead of JSValuePtr.

WebKit/qt:

2008-10-24 Darin Adler <darin@apple.com>

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript): Use JSValue* instead of JSValuePtr.

WebKit/win:

2008-10-24 Darin Adler <darin@apple.com>

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString): (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): (WebScriptCallFrame::valueForVariable): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
  • WebScriptCallFrame.h:
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Use JSValue* instead of JSValuePtr.

WebKit/wx:

2008-10-24 Darin Adler <darin@apple.com>

  • WebFrame.cpp: (wxWebFrame::RunScript): Use JSValue* instead of JSValuePtr.
07:43 Changeset [37844] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-10-24 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build.

06:55 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:54 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:42 Changeset [37843] by hausmann@webkit.org
  • 5 edits in trunk/WebKit/qt

2008-10-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Invalid history entries could cause a crash in QT Webkit

00:39 Changeset [37842] by ddkilzer@apple.com
  • 20 edits
    24 deletes in trunk

Rolled out r37840 and r37841.

JavaScriptCore:

Rolled out r37840.

  • wtf/Platform.h:

WebCore:

Rolled out r37840 and r37841.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSCustomPositionCallback.cpp: Removed.
  • bindings/js/JSCustomPositionCallback.h: Removed.
  • bindings/js/JSCustomPositionErrorCallback.cpp: Removed.
  • bindings/js/JSCustomPositionErrorCallback.h: Removed.
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper):
  • bindings/js/JSGeolocationCustom.cpp: Removed.
  • bindings/js/JSNavigatorCustom.cpp:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
  • page/Geolocation.cpp: Removed.
  • page/Geolocation.h: Removed.
  • page/Geolocation.idl: Removed.
  • page/Geoposition.cpp: Removed.
  • page/Geoposition.h: Removed.
  • page/Geoposition.idl: Removed.
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame):
  • page/Navigator.h:
  • page/Navigator.idl:
  • page/PositionCallback.h: Removed.
  • page/PositionCallback.idl: Removed.
  • page/PositionError.h: Removed.
  • page/PositionError.idl: Removed.
  • page/PositionErrorCallback.h: Removed.
  • page/PositionErrorCallback.idl: Removed.
  • page/PositionOptions.h: Removed.
  • page/PositionOptions.idl: Removed.
  • platform/GeolocationService.cpp: Removed.
  • platform/GeolocationService.h: Removed.

LayoutTests:

Rolled out r37840.

  • geolocation/geolocation-not-implemented-expected.txt: Removed.
  • geolocation/geolocation-not-implemented.html: Removed.
  • geolocation/geolocation-test.js: Removed.

10/23/08:

22:39 Changeset [37841] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Attempt to fix GTK build.

  • GNUmakefile.am: Added new *.idl files that were missing.
22:05 Changeset [37840] by ddkilzer@apple.com
  • 20 edits
    25 adds in trunk

JavaScriptCore:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

  • wtf/Platform.h: ENABLE_GEOLOCATION defaults to 0

WebCore:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

Test: geolocation/geolocation-not-implemented.html

  • DerivedSources.make:
  • GNUmakefile.am: Added Geolocation support
  • WebCore.pro: Added Geolocation support
  • WebCore.vcproj/WebCore.vcproj: Added Geolocation support
  • WebCore.xcodeproj/project.pbxproj: Added Geolocation support
  • WebCoreSources.bkl: Added Geolocation support
  • bindings/js/JSCustomPositionCallback.cpp: Added. (WebCore::JSCustomPositionCallback::JSCustomPositionCallback): (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionCallback.h: Added. (WebCore::JSCustomPositionCallback::create):
  • bindings/js/JSCustomPositionErrorCallback.cpp: Added. (WebCore::JSCustomPositionErrorCallback::JSCustomPositionErrorCallback): (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.h: Added. (WebCore::JSCustomPositionErrorCallback::create):
  • bindings/js/JSDOMBinding.cpp: move markDOMObjectWrapper here from JSDOMWindowCustom (WebCore::markDOMObjectWrapper):
  • bindings/js/JSDOMBinding.h: move markDOMObjectWrapper here from JSDOMWindowCustom
  • bindings/js/JSDOMWindowCustom.cpp: move markDOMObjectWrapper to JSDOMBinding
  • bindings/js/JSGeolocationCustom.cpp: Added. (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSNavigatorCustom.cpp: handle marking Geolocation (WebCore::JSNavigator::mark):
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::setUsingGeolocation): (WebCore::Document::usingGeolocation):
  • loader/FrameLoader.cpp: don't add to back forward cache if using Geolocation (WebCore::FrameLoader::canCachePage):
  • page/Geolocation.cpp: Added. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::clearWatch): (WebCore::Geolocation::stopUpdatingIfEmpty): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers): (WebCore::Geolocation::handleError): (WebCore::Geolocation::geolocationServicePositionChanged): (WebCore::Geolocation::geolocationServiceErrorOccurred):
  • page/Geolocation.h: Added. (WebCore::Geolocation::create): (WebCore::Geolocation::~Geolocation): (WebCore::Geolocation::lastPosition): (WebCore::Geolocation::GeoNotifier::create):
  • page/Geolocation.idl: Added.
  • page/Geoposition.cpp: Added. (WebCore::Geoposition::toString):
  • page/Geoposition.h: Added. (WebCore::Geoposition::create): (WebCore::Geoposition::latitude): (WebCore::Geoposition::longitude): (WebCore::Geoposition::altitude): (WebCore::Geoposition::accuracy): (WebCore::Geoposition::altitudeAccuracy): (WebCore::Geoposition::heading): (WebCore::Geoposition::velocity): (WebCore::Geoposition::timestamp): (WebCore::Geoposition::Geoposition):
  • page/Geoposition.idl: Added.
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): disconnect Geolocation (WebCore::Navigator::geolocation): accessor for Geolocation
  • page/Navigator.h: (WebCore::Navigator::optionalGeolocation): accessor for Geolocation
  • page/Navigator.idl: accessor for Geolocation
  • page/PositionCallback.h: Added. (WebCore::PositionCallback::~PositionCallback):
  • page/PositionCallback.idl: Added.
  • page/PositionError.h: Added. (WebCore::PositionError::): (WebCore::PositionError::create): (WebCore::PositionError::code): (WebCore::PositionError::message): (WebCore::PositionError::PositionError):
  • page/PositionError.idl: Added.
  • page/PositionErrorCallback.h: Added. (WebCore::PositionErrorCallback::~PositionErrorCallback):
  • page/PositionErrorCallback.idl: Added.
  • page/PositionOptions.h: Added. (WebCore::PositionOptions::create): (WebCore::PositionOptions::enableHighAccuracy): (WebCore::PositionOptions::setEnableHighAccuracy): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
  • page/PositionOptions.idl: Added.
  • platform/GeolocationService.cpp: Added. (WebCore::GeolocationService::GeolocationService): (WebCore::GeolocationService::positionChanged): (WebCore::GeolocationService::errorOccurred):
  • platform/GeolocationService.h: Added. (WebCore::GeolocationServiceClient::~GeolocationServiceClient): (WebCore::GeolocationServiceClient::geolocationServicePositionChanged): (WebCore::GeolocationServiceClient::geolocationServiceErrorOccurred): (WebCore::GeolocationService::~GeolocationService):

LayoutTests:

2008-10-23 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21475


Provide support for the Geolocation API


http://dev.w3.org/geo/api/spec-source.html

Tests to verify Geolocation isn't implemented (so that it didn't leak into
WebCore for platforms that do not support it).

  • geolocation: Added.
  • geolocation/geolocation-not-implemented-expected.txt: Added.
  • geolocation/geolocation-not-implemented.html: Added.
  • geolocation/geolocation-test.js: Added. (reset): (hanged): (watchPositionAndEnd): (watchPosition._positionCallback): (watchPosition): (watchPositionTestAndEnd): (watchPositionAndFail): (watchPositionAndTest._positionCallback): (watchPositionAndTest): (getCurrentPositionAndEnd): (getCurrentPosition._positionCallback): (getCurrentPosition): (getCurrentPositionTestAndEnd): (getCurrentPositionAndFail): (getCurrentPositionAndTest._positionCallback): (getCurrentPositionAndTest): (endTest): (relativeURL):
21:52 Changeset [37839] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-10-23 Alp Toker <alp@nuanti.com>

Fix typo in comment in previous commit. GTK -> GLIB

  • platform/gtk/guriescape.c:
21:32 Changeset [37838] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-10-23 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=21824
[GTK] FileSystem abstraction uses features from Glib 2.16

Wrap g_uri_unescape_string() to fix building with pre-2.16 Glib

  • platform/gtk/guriescape.c: (unescape_character): (_webcore_g_uri_unescape_segment): (_webcore_g_uri_unescape_string):
  • platform/gtk/guriescape.h:
20:44 Changeset [37837] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.

  • GNUmakefile.am:
20:23 Changeset [37836] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

20:23 Changeset [37835] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.26.5

New tag.

18:04 Changeset [37834] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-10-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

m_frame null checked but then dereferenced
https://bugs.webkit.org/show_bug.cgi?id=21845

This error was found using a static analysis tool, and so I do not know
how to produce a null m_frame on entry to this method. Hence, I have
not included a regression test.

  • page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): Add an early return.
17:18 Changeset [37833] by kmccullough@apple.com
  • 2 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Rubber stamped by Mark Rowe.

-Skipping the profiler tests until we know why they fail on tiger:
<rdar://problem/6316530> Profiler tests fail on tiger

  • platform/mac-tiger/Skipped:
16:58 Changeset [37832] by ddkilzer@apple.com
  • 5 edits in trunk

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

JavaScriptCore:

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21832>

Reviewed by Sam Weinig.

  • pcre/dftables: Use imported tempfile() from File::Temp instead of 'new File::Temp' to make the script work with Perl 5.10.

WebKitTools:

Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21832>

Reviewed by Sam Weinig.

  • Scripts/bisect-builds: Use imported tempfile() from File::Temp instead of 'new File::Temp' to make the script work with Perl 5.10.
  • Scripts/sort-Xcode-project-file: Ditto.
15:29 Changeset [37831] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-10-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix hideous pathological case performance when looking up repatch info, bug #21727.

When repatching JIT code to optimize we look up records providing information about
the generated code (also used to track recsources used in linking to be later released).
The lookup was being performed using a linear scan of all such records.

(1) Split up the different types of reptach information. This means we can search them

separately, and in some cases should reduce their size.

(2) In the case of property accesses, search with a binary chop over the data.
(3) In the case of calls, pass a pointer to the repatch info into the relink function.

  • VM/CTI.cpp: (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompile): (JSC::CTI::unlinkCall): (JSC::CTI::linkCall):
  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers): (JSC::CodeBlock::derefStructureIDs):
  • VM/CodeBlock.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::setUnlinked): (JSC::CallLinkInfo::isLinked): (JSC::getStructureStubInfoReturnLocation): (JSC::binaryChop): (JSC::CodeBlock::addCaller): (JSC::CodeBlock::getStubInfo):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::emitResolve): (JSC::CodeGenerator::emitGetById): (JSC::CodeGenerator::emitPutById): (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct):
  • VM/Machine.cpp: (JSC::Machine::cti_vm_lazyLinkCall):
15:12 Changeset [37830] by kmccullough@apple.com
  • 5 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Forgot to remove the tests from the skipped lists, this should have been
apart of the last checkin.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
15:10 Changeset [37829] by kmccullough@apple.com
  • 39 edits
    42 adds
    2 deletes in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

  • Added the expected results for the profiler tests and removed the tests from the skipped list.
  • Also removed two tests that were accidentally checked in previously.
  • Also changed the text on the tests to be more apparent how to run them manually.
  • fast/profiler/anonymous-event-handler-expected.txt: Added.
  • fast/profiler/anonymous-event-handler.html:
  • fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
  • fast/profiler/anonymous-function-called-from-different-contexts.html:
  • fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
  • fast/profiler/anonymous-function-calls-built-in-functions.html:
  • fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
  • fast/profiler/anonymous-function-calls-eval.html:
  • fast/profiler/apply-expected.txt: Added.
  • fast/profiler/apply.html:
  • fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
  • fast/profiler/built-in-function-calls-anonymous.html:
  • fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
  • fast/profiler/built-in-function-calls-user-defined-function.html:
  • fast/profiler/call-expected.txt: Added.
  • fast/profiler/call-nodelist-as-function-expected.txt: Added.
  • fast/profiler/call-nodelist-as-function.html:
  • fast/profiler/call.html: Added.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
  • fast/profiler/compare-multiple-profiles-expected.txt: Added.
  • fast/profiler/compare-multiple-profiles.html:
  • fast/profiler/constructor-expected.txt: Added.
  • fast/profiler/constructor.html:
  • fast/profiler/dead-time-expected.txt: Added.
  • fast/profiler/dead-time.html:
  • fast/profiler/deep-recursion.html: Removed.
  • fast/profiler/document-dot-write-expected.txt: Added.
  • fast/profiler/document-dot-write.html:
  • fast/profiler/event-handler-expected.txt: Added.
  • fast/profiler/event-handler.html:
  • fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
  • fast/profiler/execution-context-and-eval-on-same-line.html:
  • fast/profiler/heavy-view-expected.txt: Added.
  • fast/profiler/heavy-view.html:
  • fast/profiler/inline-event-handler-expected.txt: Added.
  • fast/profiler/inline-event-handler.html:
  • fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
  • fast/profiler/many-calls-in-the-same-scope.html: Added.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
  • fast/profiler/multiple-and-different-scoped-function-calls.html:
  • fast/profiler/multiple-frames-expected.txt: Added.
  • fast/profiler/multiple-frames.html:
  • fast/profiler/multiple-windows.html: Removed.
  • fast/profiler/nested-anonymous-functon-expected.txt: Added.
  • fast/profiler/nested-anonymous-functon.html:
  • fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
  • fast/profiler/nested-start-and-stop-profiler.html:
  • fast/profiler/no-execution-context-expected.txt: Added.
  • fast/profiler/no-execution-context.html:
  • fast/profiler/one-execution-context-expected.txt: Added.
  • fast/profiler/one-execution-context.html:
  • fast/profiler/profile-calls-in-included-file-expected.txt: Added.
  • fast/profiler/profile-calls-in-included-file.html:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
  • fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
  • fast/profiler/profiling-from-a-nested-location.html:
  • fast/profiler/simple-event-call-expected.txt: Added.
  • fast/profiler/simple-event-call.html:
  • fast/profiler/simple-no-level-change-expected.txt: Added.
  • fast/profiler/simple-no-level-change.html:
  • fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
  • fast/profiler/start-and-stop-profiler-multiple-times.html:
  • fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html:
  • fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
  • fast/profiler/start-but-dont-stop-profiling.html:
  • fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
  • fast/profiler/stop-profiling-after-setTimeout.html:
  • fast/profiler/stop-then-function-call-expected.txt: Added.
  • fast/profiler/stop-then-function-call.html:
  • fast/profiler/throw-exception-from-eval-expected.txt: Added.
  • fast/profiler/throw-exception-from-eval.html:
  • fast/profiler/two-execution-contexts-expected.txt: Added.
  • fast/profiler/two-execution-contexts.html:
  • fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
  • fast/profiler/user-defined-function-calls-built-in-functions.html:
  • fast/profiler/window-dot-eval-expected.txt: Added.
  • fast/profiler/window-dot-eval.html:
14:56 Changeset [37828] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig with no hesitation.

Test: fast/text/bidi-embedding-pop-and-push-same.html

  • platform/text/BidiResolver.h: (WebCore::BidiResolver::embed): Changed to only add the embedding operation to a vector of pending operations.

(WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
code that used to be in the PDF case of embed() here, except the part
that sets the context.

(WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
code that used to be in the non-PDF case of embed() here, except the
part the sets the context.

(WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
explicit embedding operations in the vector by creating an updated
context and determining the old and new embedding levels. If the levels
are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
sets the context to the new one.

(WebCore::BidiResolver::createBidiRunsForLine): Added calls to
commitExplicitEmbedding() after calling embed() and after calling
increment().

  • rendering/bidi.cpp: (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because this function increments the resolver.

(WebCore::RenderBlock::skipLeadingWhitespace): Ditto.

LayoutTests:

Reviewed by Sam Weinig with no hesitation.

  • fast/text/bidi-embedding-pop-and-push-same.html: Added.
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
14:35 Changeset [37827] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

14:24 Changeset [37826] by jmalonzo@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Add DNSCurl and DNSSoup to the Gtk build

  • GNUmakefile.am:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp. (WebCore::prefetchDNS):
14:17 Changeset [37825] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Sam Weinig.

Un-break the Darwin build.

  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/ImageCG.cpp:
14:13 Changeset [37824] by darin@chromium.org
  • 3 edits in trunk/WebCore

2008-10-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix forward decls to be struct instead of class.
https://bugs.webkit.org/show_bug.cgi?id=21838

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.h:
13:36 Changeset [37823] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-10-23 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Oliver Hunt.

  • platform/network/curl/ResourceRequest.h: A better implementation of CFURLRequest, rather than void*. This gives better compatibility with the WebKit.idl interface. (WebCore::ResourceRequest::cfURLRequest):
13:28 Changeset [37822] by kmccullough@apple.com
  • 41 edits in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

  • Here are the changes to the tests. The most significant part is the change to profiler-test-JS-resources.js where endTest will now notify the layout test controller if it was waiting and call the print function to iterate over all of the profiles and log their structure.
  • Most of these tests changed to include the layoutTestController, use endTest() or call the print function directly if there was some reason that they could not use endTest().
  • fast/profiler/resources/profiler-test-JS-resources.js: (endTest): Stop any waits and print the profile information. (printHeavyProfilesDataWithoutTime): Print all profile information in heavy view, without time. (printProfilesDataWithoutTime): Print all profile information in tree view, without time. (printProfileNodeWithoutTime): Print a profile node's informmation and all of it's children's information.
  • fast/profiler/anonymous-event-handler.html:
  • fast/profiler/anonymous-function-called-from-different-contexts.html:
  • fast/profiler/anonymous-function-calls-built-in-functions.html:
  • fast/profiler/anonymous-function-calls-eval.html:
  • fast/profiler/apply.html:
  • fast/profiler/built-in-function-calls-anonymous.html:
  • fast/profiler/built-in-function-calls-user-defined-function.html:
  • fast/profiler/call-nodelist-as-function.html:
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
  • fast/profiler/compare-multiple-profiles.html:
  • fast/profiler/constructor.html:
  • fast/profiler/dead-time.html:
  • fast/profiler/deep-recursion.html:
  • fast/profiler/document-dot-write.html:
  • fast/profiler/event-handler.html:
  • fast/profiler/execution-context-and-eval-on-same-line.html:
  • fast/profiler/heavy-view.html:
  • fast/profiler/inline-event-handler.html:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
  • fast/profiler/multiple-and-different-scoped-function-calls.html:
  • fast/profiler/multiple-frames.html:
  • fast/profiler/nested-anonymous-functon.html:
  • fast/profiler/nested-start-and-stop-profiler.html:
  • fast/profiler/no-execution-context.html:
  • fast/profiler/one-execution-context.html:
  • fast/profiler/profile-calls-in-included-file.html:
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
  • fast/profiler/profiling-from-a-nested-location.html:
  • fast/profiler/simple-event-call.html:
  • fast/profiler/simple-no-level-change.html:
  • fast/profiler/start-and-stop-profiler-multiple-times.html:
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html:
  • fast/profiler/start-but-dont-stop-profiling.html:
  • fast/profiler/stop-profiling-after-setTimeout.html:
  • fast/profiler/stop-then-function-call.html:
  • fast/profiler/throw-exception-from-eval.html:
  • fast/profiler/two-execution-contexts.html:
  • fast/profiler/user-defined-function-calls-built-in-functions.html:
  • fast/profiler/window-dot-eval.html:
12:59 Changeset [37821] by eric@webkit.org
  • 3 edits in trunk/WebCore

2008-10-23 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Eric Seidel.

PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
ifdefs to reflect that.

  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/ImageCG.cpp:
12:37 Changeset [37820] by pkasting@chromium.org
  • 6 edits in trunk

JavaScriptCore:

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=21833
Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

  • wtf/Platform.h:

WebCore:

2008-10-23 Peter Kasting <pkasting@google.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=21833
Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::close):
  • inspector/InspectorController.h:
  • page/Page.cpp: (WebCore::Page::Page):
12:24 Changeset [37819] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 21831: Fix create_hash_table for Perl 5.10

<https://bugs.webkit.org/show_bug.cgi?id=21831>

Reviewed by Sam Weinig.

  • kjs/create_hash_table: Escaped square brackets so that Perl 5.10 doesn't try to use @nameEntries.
12:20 Changeset [37818] by darin@apple.com
  • 5 edits in trunk/LayoutTests

2008-10-23 Darin Adler <darin@apple.com>

  • try to get buildbot green again
  • platform/gtk/Skipped: Added fast/profiler.
  • platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
  • platform/qt/Skipped: Added fast/profiler.
  • platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.
11:43 Changeset [37817] by kmccullough@apple.com
  • 1 edit
    43 copies
    2 adds in trunk/LayoutTests

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Forgot to actually check these files in from last time :(

  • fast/profiler: Added.
  • fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
  • fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
  • fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
  • fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
  • fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
  • fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
  • fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
  • fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
  • fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
  • fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
  • fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
  • fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
  • fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
  • fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
  • fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
  • fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
  • fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
  • fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
  • fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
  • fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
  • fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
  • fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
  • fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
  • fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
  • fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
  • fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
  • fast/profiler/resources: Added.
  • fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
  • fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
  • fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
  • fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
  • fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
  • fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
  • fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
  • fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
  • fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
  • fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
  • fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
  • fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
  • fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.
11:33 Changeset [37816] by kmccullough@apple.com
  • 4 edits
    43 deletes in trunk

WebCore:

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

-Moving the tests before diffing so that it's clear what changed.

  • manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
  • manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
  • manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
  • manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
  • manual-tests/inspector/profiler-test-apply.html: Removed.
  • manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
  • manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
  • manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
  • manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
  • manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
  • manual-tests/inspector/profiler-test-constructor.html: Removed.
  • manual-tests/inspector/profiler-test-dead-time.html: Removed.
  • manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
  • manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
  • manual-tests/inspector/profiler-test-event-handler.html: Removed.
  • manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
  • manual-tests/inspector/profiler-test-heavy-view.html: Removed.
  • manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
  • manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
  • manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
  • manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
  • manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
  • manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
  • manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
  • manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
  • manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
  • manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
  • manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
  • manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
  • manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
  • manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
  • manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
  • manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
  • manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
  • manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
  • manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
  • manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
  • manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
  • manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
  • manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
  • manual-tests/inspector/resources/other-frame.html: Removed.
  • manual-tests/inspector/resources/other-window.html: Removed.
  • manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.

LayoutTests:

2008-10-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=21817
Bug 21817: Manual profiler tests should be made into layout tests

-Moving the tests before diffing so that it's clear what changed.

  • platform/mac/Skipped: Skipping until the new files are in place.
  • platform/win/Skipped:
  • fast/profiler: Added.
  • fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
  • fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
  • fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
  • fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
  • fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
  • fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
  • fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
  • fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
  • fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
  • fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
  • fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
  • fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
  • fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
  • fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
  • fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
  • fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
  • fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
  • fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
  • fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
  • fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
  • fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
  • fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
  • fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
  • fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
  • fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
  • fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
  • fast/profiler/resources: Added.
  • fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
  • fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
  • fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
  • fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
  • fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
  • fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
  • fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
  • fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
  • fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
  • fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
  • fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
  • fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
  • fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.
10:52 Changeset [37815] by andersca@apple.com
  • 3 edits in trunk/WebKitLibraries

2008-10-23 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Fix <rdar://problem/6306513> by adding a workaround for <rdar://problem/6304600>.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
10:07 Changeset [37814] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21826

Add accessor for SecurityOrigin::m_domainWasSetInDOM.

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::domainWasSetInDOM):
09:49 Changeset [37813] by aroben@apple.com
  • 3 edits in trunk/BugsSite

Fix Bug 21401: Comments field on "Review Patch" page should be initially filled with quoted patch

<https://bugs.webkit.org/show_bug.cgi?id=21401>

Reviewed by Dave Hyatt.

  • attachment.cgi: (edit): Retrieve the attachment data from the database instead of just its length. When the attachment is a patch, create a quotedpatch template variable that contains the patch data with each line prepended with "> ".
  • template/en/custom/attachment/reviewform.html.tmpl:
    • Changed the comments field to have a monospace font
    • Added an "Enter comments below:" caption above the comments field to make it clearer that this is where comments should go, now that the comments field is not initially empty
    • Fill the comments field with the quoted patch
08:55 Changeset [37812] by darin@apple.com
  • 19 edits in trunk

JavaScriptCore:

2008-10-23 Darin Adler <darin@apple.com>

1) slowness under MSVC, since it doesn't handle a

class with a single pointer in it as efficiently
as a pointer

2) uninitialized pointers in Vector

  • API/APICast.h: (toRef):
  • VM/CTI.cpp: (JSC::CTI::asInteger):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::addConstant):
  • VM/CodeGenerator.h: (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
  • VM/Machine.cpp: (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_vm_throw): Removed calls to payload functions.
  • VM/Register.h: (JSC::Register::Register): Removed overload for JSCell and call to payload function.
  • kjs/JSCell.h: Changed JSCell to derive from JSValue again. Removed JSValuePtr constructor. (JSC::asCell): Changed cast from reinterpret_cast to static_cast.
  • kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.
  • kjs/JSValue.h: (JSC::JSValue::JSValue): Added empty protected inline constructor back. (JSC::JSValue::~JSValue): Same for destructor. Removed == and != operator for JSValuePtr.
  • kjs/PropertySlot.h: (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue* and added a const_cast.
  • kjs/protect.h: Removed overloads and specialization for JSValuePtr.

JavaScriptGlue:

2008-10-23 Darin Adler <darin@apple.com>

  • JSValueWrapper.cpp: (JSValueWrapper::GetValue): Added missing call to .get().
  • JSValueWrapper.h: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.

WebCore:

2008-10-23 Darin Adler <darin@apple.com>

  • bindings/js/ScheduledAction.h:
  • inspector/InspectorController.cpp: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
06:27 Changeset [37811] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

emit scrollRequested unconditionally when scrolling.

See https://bugs.webkit.org/show_bug.cgi?id=21790

06:26 Changeset [37810] by hausmann@webkit.org
  • 2 edits in trunk/WebKit

Fix the ChangeLog after in r37761 I changed the wrong file accidentially.

06:18 Changeset [37809] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-23 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne.

Fix handling of mouse events when embedding QWebView into the
QGraphicsView.

QWebPage accepts or ignores events to indicate whether the web page
handled the event. However for QWebView to behave like a good widget
it should always accept the mouse events to indicate that it handled
them and that they should not be subject to event propagation.

The graphics view relies on acceptance of the initial mouse click to
make the embedded widget the focus item.

05:27 Changeset [37808] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2008-10-23 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build.

05:23 Changeset [37807] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Maciej Stachowiak.

Fix fast/events/message-port.html to not be timing-dependent (it was failing on some bots).

  • fast/events/message-port.html:
  • fast/events/message-port-expected.txt:
03:15 Changeset [37806] by ap@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=21825
JSDOMBinding should not blindly cast the global object to JSDOMWindow

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure): (WebCore::getCachedDOMConstructor): (WebCore::cacheDOMConstructor): Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Moved constructor and structure tracking to JSDOMGlobalObject.
02:43 Changeset [37805] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21787

Update postMessage to send origin = "null" for non-serializable
origins to match latest spec. Merge SecurityOrigin::toString and
SecurityOrigin::toHTTPOrigin because they are now the same.

Test: http/tests/security/postMessage/data-url-sends-null-origin.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::outgoingOrigin): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::addHTTPOriginIfNeeded): (WebCore::FrameLoader::loadItem):
  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • page/SecurityOrigin.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):

LayoutTests:

2008-10-23 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=21787

Add test coverage for postMessaging from a data URL.

  • http/tests/security/postMessage/data-url-sends-null-origin-expected.txt: Added.
  • http/tests/security/postMessage/data-url-sends-null-origin.html: Added.
Note: See TracTimeline for information about the timeline view.