Timeline


and

11/08/08:

23:36 WikiStart edited by mjs@apple.com
(diff)
20:11 Changeset [38240] by antti@apple.com

WebCore:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.


Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache


Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.


Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

  • fast/encoding/css-cached-bom.html: Added.
  • fast/encoding/css-cached-bom-expected.txt: Added.
  • fast/encoding/resources/css-cached-bom-frame.html: Added.
  • fast/encoding/resources/utf-16-little-endian.css: Added.
19:14 Changeset [38239] by kevino@webkit.org

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

18:35 Changeset [38238] by kevino@webkit.org

wx build fixes after addition of JSCore parser and bycompiler dirs.

17:09 Changeset [38237] by simon.fraser@apple.com

2008-11-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
  • rendering/RenderTextControl.h:
16:33 Changeset [38236] by timothy@apple.com

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

  • inspector/front-end/inspector.css:
11:42 Changeset [38235] by ddkilzer@apple.com

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
  • page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
  • page/mac/AccessibilityObjectMac.mm: Ditto.
  • page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

  • WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.
11:12 Changeset [38234] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • WebCore part of adding WebPreferences for controlling databases and local storage
  • WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
  • page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit/mac part of adding WebPreferences for controlling databases and local storage
  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

  • WebKit/win part of adding WebPreferences for controlling databases and local storage
  • Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
  • WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.
05:57 Changeset [38233] by staikos@webkit.org

Just adjusting email address in changelog.

11/07/08:

14:29 Changeset [38232] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/gtk/MouseEventGtk.cpp:
  • platform/gtk/WheelEventGtk.cpp:
  • platform/gtk/gtkdrawing.h:
  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:
13:34 Changeset [38231] by andersca@apple.com

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

  • bridge/npapi.h:
13:15 Changeset [38230] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

  • fast/js/resources/typeof-constant-string.js: Added.
  • fast/js/typeof-constant-string-expected.txt: Added.
  • fast/js/typeof-constant-string.html: Added.
12:41 Changeset [38229] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstant):
11:35 Changeset [38228] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 Changeset [38227] by simon.fraser@apple.com

2008-11-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):
10:07 Changeset [38226] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

  • DerivedSources.make:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCoreSources.bkl:
09:48 Changeset [38225] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
07:39 Changeset [38224] by vestbo@webkit.org

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

07:01 Changeset [38223] by vestbo@webkit.org

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

06:47 Changeset [38222] by vestbo@webkit.org

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
06:11 Changeset [38221] by hausmann@webkit.org

2008-11-07 Simon Hausmann <hausmann@webkit.org>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

03:32 Changeset [38220] by hausmann@webkit.org

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

01:22 Changeset [38219] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
  • bytecompiler/CodeGenerator.h:
01:22 Changeset [38218] by ap@webkit.org

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.
01:20 Applications using WebKit edited by barbarosa100@hotmail.com
Added DVDpedia, Bookpedia, CDpedia and Gamepedia as apps that use WebKit (diff)
00:59 Changeset [38217] by zecke@webkit.org

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Enable text only and succeeding fast tests for the gtk port

Enable the tests from the fast directory that succeed. Classify the
remaining tests from the fast directory.

  • platform/gtk/Skipped:
00:53 Changeset [38216] by zecke@webkit.org

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Skip every test on the Gtk+ platform

Add every test directory to the Skipped list in order to create
a baseline for the Gtk+ port.

  • platform/gtk/Skipped:

11/06/08:

23:41 Changeset [38215] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
23:26 Changeset [38214] by antti@apple.com

2008-11-06 Antti Koivisto <antti@apple.com>

Eh, this trivial last minute change was wrong.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText):
23:22 Changeset [38213] by antti@apple.com

2008-11-06 Antti Koivisto <antti@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22093


Delaying the text decoding caused regression since the decoding
also determines the encoding in case of @charset rule.


Decode immediately in data() and keep the decoded string around
during the checkNotify().

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
21:54 Changeset [38212] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22097
Expose MessageEvent constructor on WorkerContext

  • bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextMessageEvent): (WebCore::setJSWorkerContextMessageEvent):
21:52 Changeset [38211] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21107
<rdar://problem/6264219> New access key combination conflicts with VoiceOver

  • page/EventHandler.h:
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::accessKeyModifiers): Access access key modifiers via a function, not a static variable.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers): Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is less troublesome than one with VO keys.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Also fix an access key matching bug introduced in r32424 - Any superset of specified modifier set invoked access keys. We can use simple equality comparison instead because CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
20:04 Changeset [38210] by andersca@apple.com

WebCore:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL

Export _NPN_HasMethod and _NPN_HasProperty.


  • WebCore.NPAPI.exp:

WebKit/mac:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL


Initialize the browser funcs correctly.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
17:30 Changeset [38209] by barraclough@apple.com

2008-11-06 Gavin Barraclough barraclough@apple.com

Reviewed by Oliver Hunt.

Do not make a cti_* call to perform an op_call unless either:
(1) The codeblock for the function body has not been generated.
(2) The number of arguments passed does not match the callee arity.

~1% progression on sunspider --v8

  • VM/CTI.cpp: (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • kjs/nodes.h:
17:11 Changeset [38208] by simon.fraser@apple.com

2008-11-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=15678

Fix transformed menu selects to show the popup in the correct
location.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup):
16:55 Changeset [38207] by ddkilzer@apple.com

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

WebCore:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKit/mac:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKitTools:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

16:47 Changeset [38206] by jchaffraix@webkit.org

2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

Include the namespace into the interfaceName.

  • dom/make_names.pl: Do not append the namespace when using the interfaceName.
  • html/HTMLTagNames.in: Added namespace prefix for custom interfaceName.
  • svg/svgtags.in: Ditto.
16:18 Changeset [38205] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
16:17 Changeset [38204] by weinig@apple.com

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix test that would fail if it had the wrong set of plugins.

  • plugins/plugin-javascript-access.html:
15:46 Changeset [38203] by ddkilzer@apple.com

BUILD WAS NOT BROKEN: Rolling r38189 back in.

WebCore:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKit/mac:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKitTools:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

15:10 Changeset [38202] by ddkilzer@apple.com

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebCore:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKit/mac:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKitTools:

BUILD FIX: Backed out r38189 since it apparently broke the world.

14:23 Changeset [38201] by ddkilzer@apple.com

Fix indentation.

14:16 Changeset [38200] by cfleizach@apple.com

Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112

14:03 Changeset [38199] by aroben@apple.com

Windows build fix after r38196

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the include path.
13:55 Changeset [38198] by weinig@apple.com

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Alice Liu.

Fix failed assert at launch caused by unintialized data member on the mac.

  • platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
13:47 Changeset [38197] by sfalken@apple.com

2008-11-06 Steve Falkenburg <sfalken@apple.com>

Fix failed assert at launch caused by unintialized data member.


Reviewed by Maciej Stachowiak.

  • platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
13:43 Changeset [38196] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a new bytecompiler subdirectory of JavaScriptCore and move some
relevant files to it.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeGenerator.cpp: Removed.
  • VM/CodeGenerator.h: Removed.
  • bytecompiler: Added.
  • bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
  • bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
  • bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
  • jscore.bkl:
  • kjs/LabelScope.h: Removed.
13:35 Changeset [38195] by sullivan@apple.com

2008-11-06 John Sullivan <sullivan@apple.com>

Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.


Reviewed by Adam Roben

  • WebView.h: removed m_zoomMultiplierIsTextOnly


  • WebView.cpp: (WebView::WebView): removed initialization of m_zoomMultiplierIsTextOnly (WebView::setZoomMultiplier): use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly (WebView::zoomMultiplier): use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
13:22 Changeset [38194] by sullivan@apple.com

2008-11-06 John Sullivan <sullivan@apple.com>

Fixed problem with switching between text-only zoom and full-content zoom


There were two booleans tracking whether zoom was text-only, one in WebCore settings
and one in WebViewPrivate. Fixed by eliminating the one in WebViewPrivate.

Reviewed by Adam Roben

  • WebView/WebView.mm: remove declaration of zoomMultiplierIsTextOnly instance variable in WebViewPrivate (-[WebViewPrivate init]): removed initialization of zoomMultiplierIsTextOnly (-[WebView textSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _setZoomMultiplier:isTextOnly:]): update WebCore settings rather than WebViewPrivate instance variable (-[WebView _zoomMultiplier:]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _realZoomMultiplierIsTextOnly]): return value from WebCore settings instead of accessing WebViewPrivate instance variable (-[WebView pageSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable
12:55 Changeset [38193] by simon.fraser@apple.com

2008-11-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=22109
Make <input type="range"> work correctly with transforms

Test: fast/forms/slider-transformed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

Compute a correct local point when the event is retargeted

  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

Compute m_initialClickPoint in slider-local coords, so that
deltas are computed correctly with transforms

(WebCore::RenderSlider::mouseEventIsInThumb):

Rather than computing an absolute bounds for the thumb,
convert the point to local coords and compare it with the border box.

12:36 Changeset [38192] by aroben@apple.com

Windows clean build fix after r38155

Rubberstamped by Cameron Zwarich.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the post-build event for the move of create_hash_table out of kjs/.
12:35 Changeset [38191] by adele@apple.com

2008-11-06 Adele Peterson <adele@apple.com>

Reviewed by Adam Roben.

Add support for a WebKitZoomsTextOnly preference.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::setZoomsTextOnly): (WebPreferences::zoomsTextOnly):
  • WebPreferences.h:
  • WebView.cpp: (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this. (WebView::makeTextLarger): ditto. (WebView::canMakeTextSmaller): ditto. (WebView::makeTextSmaller): ditto. (WebView::canMakeTextStandardSize): Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting. (WebView::makeTextStandardSize): (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
11:30 Changeset [38190] by hausmann@webkit.org

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22107

Bug uncovered during RVCT port in functions not used. get_lt() and
get_gt() takes only one argument - remove second argument where
applicable.

11:28 Changeset [38189] by ddkilzer@apple.com

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)

WebCore:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • bindings/js/GCController.cpp: (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Ditto
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::wrappers): Ditto
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::wrappers): Ditto
  • bridge/runtime_root.cpp: (JSC::Bindings::rootObjectSet): Ditto
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Ditto
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto
  • css/CSSStyleSelector.cpp: (WebCore::screenEval): Ditto (WebCore::printEval): Ditto
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): Ditto (WebCore::isSVG11Feature): Ditto (WebCore::DOMImplementation::isXMLMIMEType): Ditto
  • dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
  • dom/ScriptElement.cpp: (WebCore::isSupportedJavaScriptLanguage): Ditto
  • editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): Ditto
  • editing/HTMLInterchange.cpp: (WebCore::): Ditto
  • editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Ditto
  • editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): Ditto (WebCore::isInterchangeConvertedSpaceSpan): Ditto
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Ditto (WebCore::nonBreakingSpaceString): Ditto
  • editing/markup.cpp: (WebCore::appendAttributeValue): Ditto (WebCore::appendEscapedContent): Ditto (WebCore::shouldAddNamespaceAttr): Ditto (WebCore::appendNamespace): Ditto (WebCore::appendStartMarkup): Ditto (WebCore::createMarkup): Ditto
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): Ditto (WebCore::inlineTagList): Ditto (WebCore::blockTagList): Ditto
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): Ditto
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type): Ditto
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Ditto (WebCore::HTMLParser::isHeaderTag): Ditto (WebCore::HTMLParser::isResidualStyleTag): Ditto (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::type): Ditto
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::type): Ditto
  • inspector/InspectorController.cpp: (WebCore::platform): Ditto
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::shared): Ditto
  • inspector/JavaScriptProfile.cpp: (WebCore::profileCache): Ditto
  • inspector/JavaScriptProfileNode.cpp: (WebCore::profileNodeCache): Ditto
  • loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::cacheStorage): Ditto
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes): Ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): Ditto
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Ditto (WebCore::keepAliveSet): Ditto
  • page/Page.cpp: (WebCore::Page::groupName): Ditto
  • page/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): Ditto (WebCore::SecurityOrigin::databaseIdentifier): Ditto
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto
  • platform/KURL.cpp: (WebCore::blankURL): Ditto
  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName): Ditto
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getSimilarFontPlatformData): Ditto (WebCore::FontCache::getLastResortFallbackFont): Ditto
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarTheme::nativeTheme): Ditto
  • platform/mac/ThemeMac.mm: (WebCore::platformTheme): Ditto
  • platform/mac/ThreadCheck.mm: (WebCoreReportThreadViolation): Ditto
  • platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Ditto
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): Ditto (WebCore::getStreamResourceHandleMap): Ditto
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Ditto
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isJapanese): Ditto
  • rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): Ditto
  • rendering/RenderCounter.cpp: (WebCore::counterMaps): Ditto
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerText): Ditto
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemFont): Ditto
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::initialDashboardRegions): Ditto (WebCore::RenderStyle::noneDashboardRegions): Ditto
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Ditto
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calcMode): Ditto (WebCore::SVGAnimationElement::attributeType): Ditto (WebCore::SVGAnimationElement::isAdditive): Ditto (WebCore::SVGAnimationElement::isAccumulated): Ditto
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::xmlspace): Ditto
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): Ditto (WebCore::SVGSVGElement::contentStyleType): Ditto
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): Ditto (WebCore::SVGStyleElement::media): Ditto
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseClockValue): Ditto (WebCore::SVGSMILElement::restart): Ditto (WebCore::SVGSMILElement::fill): Ditto (WebCore::SVGSMILElement::repeatCount): Ditto (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
  • svg/graphics/SVGResource.cpp: (WebCore::clientMap): Ditto
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Ditto
  • xml/XMLHttpRequest.cpp: (WebCore::preflightResultCache): Ditto (WebCore::isSafeRequestHeader): Ditto (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::evaluationContext): Ditto
  • xml/XPathParser.cpp: (WebCore::XPath::isAxisName): Ditto (WebCore::XPath::isNodeTypeName): Ditto
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Ditto

WebKit/mac:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • History/WebBackForwardList.mm: (backForwardLists): Changed to leak an object to avoid an exit-time destructor.
  • History/WebHistoryItem.mm: (historyItemWrappers): Ditto
  • Misc/WebStringTruncator.m: (fontFromNSFont): Ditto
  • Plugins/WebBaseNetscapePluginStream.mm: (streams): Ditto
  • WebView/WebView.mm: (aeDescFromJSValue): Ditto

WebKitTools:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Remove .o files from the exclude list that have had their exit-time destructors removed.

  • Scripts/check-for-exit-time-destructors:
11:04 Changeset [38188] by vestbo@webkit.org

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Remove a bunch of unused methods in the Qt media element implementation

10:47 Changeset [38187] by alp@webkit.org

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22033
[GTK] CTI/Linux r38064 crashes; JIT requires executable memory

Mark pages allocated by the FastMalloc mmap code path executable with
PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
non-executable memory (like ExecShield on Fedora Linux) when the JIT
is enabled.

This patch does not resolve the issue on debug builds so affected
developers may still need to pass --disable-jit to configure.

  • wtf/TCSystemAlloc.cpp: (TryMmap): (TryDevMem): (TCMalloc_SystemRelease):
10:42 Changeset [38186] by simon.fraser@apple.com

2008-11-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21870

Implement absoluteToLocal() to convert a point from absolute
to local coordinates, optionally taking transforms into account.

Use this to set offsetX/offsetY in mouse events, thus fixing
offsetX/offsetY in events on elements with transforms.

Test: fast/events/offsetX-offsetY.html

10:41 Changeset [38185] by cwzwarich@webkit.org

2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

Bug 22099: Make the Qt port build the JSC shell in the correct place
<https://bugs.webkit.org/show_bug.cgi?id=22099>

Adjust include paths and build destination dir for the 'jsc' executable
in the Qt build.

  • jsc.pro:
10:41 Changeset [38184] by alp@webkit.org

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22067
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()

null-check symbols loaded from plugin modules, initialize the function
table (like Win already does) and update it with the latest
additions. Adjust whitespace for easy diff'ing with the Win port code
from which it was forked.

This fixes crashes with libnspr4.so and any other plugins that don't
provide the symbols we expect.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
10:38 Changeset [38183] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Removed dead (and broken) code from an ancient Symbian port.

10:38 Changeset [38182] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use QLibrary as PlatformModule when compiling with Qt for S60.

10:38 Changeset [38181] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Implemented the block allocation on Symbian through heap allocation.

Unfortunately there is no way to allocate virtual memory. The Posix
layer provides mmap() but no anonymous mapping. So this is a very slow
solution but it should work as a start.

10:38 Changeset [38180] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Compile fix for Symbian.
The snprintf function is defined in stdio.h, the inclusion
of snprintf.h inside this PLATFORM(SYMBIAN) block does not
compile.

10:36 Changeset [38179] by alp@webkit.org

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22047
GTK: Add support for multiple file selection in the file upload control

Implemented with GtkFileChooser.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
10:12 Changeset [38178] by hausmann@webkit.org

Removed misplaced fixme comment that doesn't belong there.
Noticed by Darin

10:03 Changeset [38177] by hausmann@webkit.org

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Borrow some math functions from the MSVC port to the build with the
RVCT compiler.

10:03 Changeset [38176] by hausmann@webkit.org

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Include strings.h for strncasecmp().
This is needed for compilation inside Symbian and it is also
confirmed by the man-page on Linux.

09:48 Changeset [38175] by hausmann@webkit.org

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Implemented currentThreadStackBase for Symbian.

09:48 Changeset [38174] by hausmann@webkit.org

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

RVCT does not support tm_gmtoff field, so disable that code just like
for MSVC.

09:47 Changeset [38173] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
MINSCW compiler.

09:42 Changeset [38172] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define capabilities of the SYMBIAN platform. Some of the system
headers are actually dependent on RVCT.

09:42 Changeset [38171] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Add missing stddef.h header needed for compilation in Symbian.

08:50 Changeset [38170] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
on top of the Posix layer.

08:50 Changeset [38169] by hausmann@webkit.org

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Added SYMBIAN32 condition for defining PLATFORM(SYMBIAN).

08:39 Changeset [38168] by hausmann@webkit.org

2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Added WINSCW compiler define for Symbian S60.

08:39 Changeset [38167] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.

08:38 Changeset [38166] by hausmann@webkit.org

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Disable webkit plugins for Symbian.

04:15 Changeset [38165] by vestbo@webkit.org

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix build break in debug mode when XSLT is not enabled

04:14 Changeset [38164] by vestbo@webkit.org

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Repaint video on UpdateRequest to prevent recursive painting

Calling QWidget::render() to update the video generates a paint
event that's then picked up by the event filter once more :(

We're really only interested in updates from Phonon, which we
get through the UpdateRequest for each new frame.

03:46 Changeset [38163] by hausmann@webkit.org

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build, adjust include paths after move of jsc.pro.

02:21 Changeset [38162] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
rename it to jsc.cpp to reflect the name of the binary compiled from it.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jsc.cpp: Copied from kjs/Shell.cpp.
  • jsc.pro:
  • jscore.bkl:
  • kjs/Shell.cpp: Removed.
01:50 Changeset [38161] by hausmann@webkit.org

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Added a unit tests for QWebFrame::metaData().

01:49 Changeset [38160] by hausmann@webkit.org

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Improved documentation for QWebFrame::metaData().

01:49 Changeset [38159] by hausmann@webkit.org

2008-11-05 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

Added QWebFrame::metaData() to provide a way in the public API
to retrieve the values of the <meta> tags.

See https://bugs.webkit.org/show_bug.cgi?id=22071

01:22 Changeset [38158] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the WebCore build for some platforms by changing build scripts to
account for the recent move of the create_hash_table script from the kjs
subdirectory of JavaScriptCore to the root directory.

  • WebCore.pro:
  • make-generated-sources.sh:
00:58 Changeset [38157] by alp@webkit.org

2008-11-06 Alp Toker <alp@nuanti.com>

GTK build fix for r38155. create_hash_table was moved out of kjs/

  • GNUmakefile.am:
00:55 Changeset [38156] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Correct the date on previous ChangeLogs.

  • ChangeLog:
  • JavaScriptCore/ChangeLog:
00:53 Changeset [38155] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move create_hash_table and jsc.pro out of the kjs directory and into the
root directory of JavaScriptCore.

JavaScriptCore:

  • DerivedSources.make:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table: Copied from kjs/create_hash_table.
  • jsc.pro: Copied from kjs/jsc.pro.
  • kjs/create_hash_table: Removed.
  • kjs/jsc.pro: Removed.
  • make-generated-sources.sh:
  • WebKit.pro:
00:18 Changeset [38154] by cwzwarich@webkit.org

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix a case-sensitivity issue in Mac forwarding headers. Strangely
enough, this does not always cause the build to break, even with a
case-sensitive filesystem.

  • ForwardingHeaders/runtime/Interpreter.h:

11/05/08:

23:28 Changeset [38153] by alp@webkit.org

2008-11-05 Alp Toker <alp@nuanti.com>

GTK build script tweak.

Make the path relative since it will appear in all -I compiler flags.
Long argument lists cause bizarre slowdowns in libtool and result
in huge build logs.

  • Scripts/webkitdirs.pm:
23:24 Changeset [38152] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the JavaScriptGlue build. This wouldn't show up unless one was
doing a clean build, because changes in JavaScriptCore don't cause
anything in JavaScriptGlue to get rebuilt.

  • JSRun.cpp:
  • JSUtils.h:
  • JavaScriptGlue.cpp:
23:07 Changeset [38151] by ap@webkit.org

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=22083
MessageEvents cannot be used across threads

  • dom/Event.idl:
  • dom/MessageEvent.idl: Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables won't work.
  • dom/MessagePort.cpp: (WebCore::MessagePort::EventData::EventData): (WebCore::MessagePort::EventData::~EventData): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::dispatchMessages):
  • dom/MessagePort.h: Don't create a MessageEvent until dispatch time - messages can be posted across threads, but MessageEvents are tied to the thread that they were created in.
23:04 Changeset [38150] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22066
Implement Worker global object

  • DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.
  • WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker support is still disabled by default.
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.
  • bindings/js/JSWorkerContext.cpp: Added.
  • bindings/js/JSWorkerContext.h: Added.
  • bindings/js/WorkerScriptController.cpp: Added.
  • bindings/js/WorkerScriptController.h: Added.
  • dom/WorkerContext.cpp: Added.
  • dom/WorkerContext.h: Added. Added an implementation of worker contexts.
  • dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests. (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership and lifetime is not clear at all.
  • dom/WorkerLocation.cpp: Added.
  • dom/WorkerLocation.h: Added.
  • dom/WorkerLocation.idl: Added. Added WorkerLocation, which is one of the objects available to workers.
  • dom/WorkerThread.cpp: Added. (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start): (WebCore::WorkerThread::workerThreadStart): (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h: Added. (WebCore::WorkerThread::create): Run some code in a worker thread (no message loop yet).
20:38 Changeset [38149] by alp@webkit.org

Attempt to fix the GTK build bot after the latest kjs -> runtime move:
Remove the built products directory completely rather than using distclean.

19:26 Changeset [38148] by barraclough@apple.com

JavaScriptCore:

2008-11-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=22094

Fix for bug where the callee incorrectly recieves the caller's lexical
global object as this, rather than its own. Implementation closely
follows the spec, passing jsNull, checking in the callee and replacing
with the global object where necessary.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall):
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_call_eval):
  • runtime/JSCell.h: (JSC::JSValue::toThisObject):
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject):
  • runtime/JSImmediate.h:

LayoutTests:

2008-11-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

Previosly the test 'cross-site-this' checked that the second level deep method called
across frames recieved the correct this pointer, when no base object is provided.


Test updated so that it check that the code in the child frame, and both the first
and second functions called in the parent frame recieve the correct this values.

  • fast/frames/cross-site-this.html:
  • fast/frames/resources/cross-site-this-helper.html:
18:40 Changeset [38147] by antti@apple.com

2008-11-05 Antti Koivisto <antti@apple.com>

Reviewed by Dan Bernstein.


https://bugs.webkit.org/show_bug.cgi?id=22093
Don't keep decoded stylesheet data in cache


<rdar://problem/6343588>

Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
style sheet data in cache by 2/3 in common case.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
18:02 Changeset [38146] by kevino@webkit.org

wx build fix after Operations.cpp move.

18:00 Changeset [38145] by ddkilzer@apple.com

Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers

<https://bugs.webkit.org/show_bug.cgi?id=21596>

Reviewed by Antti.

This patch adds real parsing for Pragma and Cache-Control headers
based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
new String and StringImpl methods to assist with the parsing.

  • loader/Cache.cpp: (WebCore::Cache::dumpStats): Added. Convenience method for dumping stats outside of Safari.
  • loader/Cache.h: Declared dumpStats().
  • loader/CachedResource.cpp: (WebCore::CachedResource::mustRevalidate): Updated to use ResourceResponseBase::cacheControlDirectives() instead of substring matching of the entire Cache-Control header.
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveResponse): Used the local 'resource' variable instead of 'request->cachedResource()'.
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::setHTTPHeaderField): Set m_haveParsedCacheControlHeader to false when a "Cache-Control" header is set. Ditto for m_haveParsedPragmaHeader and "Pragma". (WebCore::ResourceResponseBase::parsePragmaDirectives): Added. Provides parsed Pragma header directives. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added. Provides parsed Cache-Control header directives. (WebCore::isCacheHeaderSeparator): Added. Returns true if a character is a separator character per RFC 2616, Section 2.2, else returns false. (WebCore::isControlCharacter): Added. Returns true if a character is a control character per RFC 2616 Section 2.2, else returns false. (WebCore::trimToNextSeparator): Added. Returns a string truncated at the first separator character per isCacheHeaderSeparator(). (WebCore::parseCacheHeader): Added. This is the main parsing routine for both Cache-Control and Pragma headers. (WebCore::parseCacheControlDirectiveValues): Added. This splits certain Cache-Control directive values into a vector of strings.
  • platform/network/ResourceResponseBase.h: (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed Cache-Control header. (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma header. (WebCore::ResourceResponseBase::parsePragmaDirectives): Added declaration. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto. (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader): Added. Boolean to describe when the "Cache-Control" header needs to be reparsed. (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added. Boolean to describe when the "Pragma" header needs to be reparsed. (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added. Cached map to hold parsed "Cache-Control" headers. (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added. Cached map to hold parsed "Pragma" headers.
  • platform/text/PlatformString.h: (WebCore::String::find): Added. Returns the first match based on the character-matching function pointer passed in. (WebCore::String::removeCharacters): Added declaration. (WebCore::find): Added. Inline method that takes a character- matching function pointer. Called by StringImpl::find().
  • platform/text/String.cpp: (WebCore::String::removeCharacters): Added. Calls StringImpl::removeCharacters().
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::removeCharacters): Added. Returns a string with all characters removed that match the character-matching function pointer passed in. If there is no change to the string, it returns itself. Based heavily on StringImpl::simplifyWhitespace(). (WebCore::StringImpl::find): Added. Calls WebCore::find().
  • platform/text/StringImpl.h: (WebCore::FindMatchFunctionPtr): Added. Typedef for a character- matching function pointer. (WebCore::StringImpl::removeCharacters): Added declaration. (WebCore::StringImpl::find): Ditto.
17:48 Changeset [38144] by justin.garcia@apple.com

WebCore:

2008-11-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break


As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
between two blockquotes. Because the start merge moves the text node into a blockquote, when we
determine whether or not we should do the end merge, it incorrectly appears as though the end merge
is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
before we do the start merge, so that the start merge doesn't effect our decision.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean. (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity. (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
  • editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.

LayoutTests:

2008-11-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

  • editing/pasteboard/5480736-expected.txt: Added.
  • editing/pasteboard/5480736.html: Added.
17:08 Changeset [38143] by andersca@apple.com

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Keep track of which plug-in host architecture would be needed for a given plug-in package.


  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
  • WebKitPrefix.h:
16:41 Changeset [38142] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculatively fix the Windows build, even though these changes may not
actually matter for anything in the build, because the Windows bots are
behind.

  • WebCore.vcproj/WebCore.vcproj:
16:30 Changeset [38141] by cwzwarich@webkit.org

2008-11-05 Cameron <zwarich@apple.com>

Not reviewed.

Fix the Qt build.

  • bridge/qt/qt_class.cpp:
  • bridge/qt/qt_runtime.h:
16:00 Changeset [38140] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems and wxWindows.

  • JavaScriptCoreSources.bkl:
  • kjs/create_hash_table:
15:48 Changeset [38139] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

  • JavaScriptCoreSources.bkl:
  • kjs/Shell.cpp:
  • runtime/Interpreter.cpp:
  • runtime/JSArray.cpp:
15:37 Changeset [38138] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

  • API/JSBase.cpp:
  • API/JSObjectRef.cpp:
  • runtime/CommonIdentifiers.h:
  • runtime/Identifier.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/InternalFunction.h:
  • runtime/JSString.h:
  • runtime/Lookup.h:
  • runtime/PropertyNameArray.h:
  • runtime/PropertySlot.h:
  • runtime/StructureID.cpp:
  • runtime/StructureID.h:
  • runtime/UString.cpp:
15:21 Changeset [38137] by cwzwarich@webkit.org

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files to the runtime subdirectory of JavaScriptCore.

JavaScriptCore:

  • API/APICast.h:
  • API/JSBase.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSClassRef.h:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp:
  • VM/Machine.cpp:
  • VM/RegisterFile.h:
  • debugger/Debugger.h:
  • kjs/SourceProvider.h:
  • kjs/TypeInfo.h: Removed.
  • kjs/collector.cpp: Removed.
  • kjs/collector.h: Removed.
  • kjs/completion.h: Removed.
  • kjs/create_hash_table:
  • kjs/identifier.cpp: Removed.
  • kjs/identifier.h: Removed.
  • kjs/interpreter.cpp: Removed.
  • kjs/interpreter.h: Removed.
  • kjs/lexer.cpp:
  • kjs/lexer.h:
  • kjs/lookup.cpp: Removed.
  • kjs/lookup.h: Removed.
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/operations.cpp: Removed.
  • kjs/operations.h: Removed.
  • kjs/protect.h: Removed.
  • kjs/regexp.cpp: Removed.
  • kjs/regexp.h: Removed.
  • kjs/ustring.cpp: Removed.
  • kjs/ustring.h: Removed.
  • pcre/pcre_exec.cpp:
  • profiler/CallIdentifier.h:
  • profiler/Profile.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/Collector.cpp: Copied from kjs/collector.cpp.
  • runtime/Collector.h: Copied from kjs/collector.h.
  • runtime/CollectorHeapIterator.h:
  • runtime/Completion.h: Copied from kjs/completion.h.
  • runtime/ErrorPrototype.cpp:
  • runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
  • runtime/Identifier.h: Copied from kjs/identifier.h.
  • runtime/InitializeThreading.cpp:
  • runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
  • runtime/Interpreter.h: Copied from kjs/interpreter.h.
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSObject.cpp:
  • runtime/JSValue.h:
  • runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
  • runtime/Lookup.h: Copied from kjs/lookup.h.
  • runtime/MathObject.cpp:
  • runtime/NativeErrorPrototype.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/Operations.cpp: Copied from kjs/operations.cpp.
  • runtime/Operations.h: Copied from kjs/operations.h.
  • runtime/PropertyMapHashTable.h:
  • runtime/Protect.h: Copied from kjs/protect.h.
  • runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
  • runtime/RegExp.h: Copied from kjs/regexp.h.
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/SmallStrings.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StructureID.cpp:
  • runtime/StructureID.h:
  • runtime/StructureIDTransitionTable.h:
  • runtime/SymbolTable.h:
  • runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
  • runtime/UString.cpp: Copied from kjs/ustring.cpp.
  • runtime/UString.h: Copied from kjs/ustring.h.
  • wrec/CharacterClassConstructor.h:
  • wrec/WREC.h:

WebCore:

  • ForwardingHeaders/kjs/collector.h: Removed.
  • ForwardingHeaders/kjs/completion.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/interpreter.h: Removed.
  • ForwardingHeaders/kjs/lookup.h: Removed.
  • ForwardingHeaders/kjs/operations.h: Removed.
  • ForwardingHeaders/kjs/protect.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
  • ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
  • ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
  • ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
  • ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
  • ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
  • ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
  • ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
  • bindings/js/GCController.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventListener.h:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_class.cpp:
  • bridge/jni/jni_class.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/npruntime.cpp:
  • bridge/runtime_root.h:
  • history/CachedPage.h:
  • html/CanvasRenderingContext2D.cpp:
  • html/HTMLCanvasElement.cpp:
  • inspector/InspectorController.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • page/Console.cpp:
  • page/Page.cpp:
  • platform/text/AtomicString.cpp:
  • platform/text/PlatformString.h:

WebKit/mac:

  • ForwardingHeaders/kjs/collector.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/interpreter.h: Removed.
  • ForwardingHeaders/kjs/lookup.h: Removed.
  • ForwardingHeaders/kjs/operations.h: Removed.
  • ForwardingHeaders/kjs/protect.h: Removed.
  • ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
  • WebView/WebScriptDebugDelegate.mm:

WebKit/wx:

  • WebFrame.cpp:
  • WebView.cpp:
15:19 Changeset [38136] by andersca@apple.com

2008-11-05 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
12:51 Changeset [38135] by mitz@apple.com

Reviewed by John Sullivan.

  • make the {protocol,proxyType} argument of WebURLProtectionSpace::initWith{Proxy}Host actually work and fix assertion failures.
  • WebURLProtectionSpace.cpp: (WebURLProtectionSpace::initWithHost): The BString comparisons were applying the BString==BSTR operator to a right hand side that was actually a WCHAR string. Fixed by using BStrings on both sides. (WebURLProtectionSpace::initWithProxyHost): Ditto.
12:03 Changeset [38134] by weinig@apple.com

WebCore:

2008-11-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

  • bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
  • plugins/Plugin.cpp: (WebCore::Plugin::namedItem):
  • plugins/Plugin.h:
  • plugins/Plugin.idl:

LayoutTests:

2008-11-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Update tests for https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

  • fast/dom/Window/window-properties-expected.txt:
  • plugins/plugin-javascript-access-expected.txt:
  • plugins/plugin-javascript-access.html:
11:51 Changeset [38133] by ggaren@apple.com

2008-11-05 Geoffrey Garen <ggaren@apple.com>

Suggested by Darin Adler.


Removed two copy constructors that the compiler can generate for us
automatically.

  • VM/LabelID.h: (JSC::LabelID::setLocation): (JSC::LabelID::offsetFrom): (JSC::LabelID::ref): (JSC::LabelID::refCount):
  • kjs/LabelScope.h:
11:19 Changeset [38132] by ap@webkit.org

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=21060
Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR

Test: fast/dom/Range/surroundContents-check-boundary-points.html

  • dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.
10:42 Changeset [38131] by andersca@apple.com

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove two global destructors from CoreTextController.


  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
10:41 Changeset [38130] by darin@chromium.org

2008-11-05 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

CRASH at Scrollbar::invalidateRect due to null m_client
https://bugs.webkit.org/show_bug.cgi?id=22080

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive): (WebCore::Scrollbar::invalidateRect):
10:30 Changeset [38129] by weinig@apple.com

WebCore:

2008-11-04 Sam Weinig <sam@webkit.org>

Reviewed by Simon Hausmann.

Fix https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

  • Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.
  • bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
  • bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
  • page/DOMWindow.idl:
  • plugins/MimeType.idl:
  • plugins/MimeTypeArray.cpp: (WebCore::MimeTypeArray::namedItem):
  • plugins/MimeTypeArray.h:
  • plugins/MimeTypeArray.idl:
  • plugins/Plugin.idl:
  • plugins/PluginArray.cpp: (WebCore::PluginArray::namedItem):
  • plugins/PluginArray.h:
  • plugins/PluginArray.idl:

LayoutTests:

2008-11-04 Sam Weinig <sam@webkit.org>

Reviewed by Simon Hausmann.

Update tests for https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • plugins/plugin-javascript-access-expected.txt:
  • plugins/plugin-javascript-access.html:
10:24 Changeset [38128] by andersca@apple.com

2008-11-05 Anders Carlsson <andersca@apple.com>

Fix Snow Leopard build.


10:23 Changeset [38127] by sfalken@apple.com

2008-11-05 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • plugins/PluginPackage.cpp:
10:22 Changeset [38126] by andersca@apple.com

WebKit:

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-05 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebPlugInStreamLoaderDelegate.h: Removed.
07:31 Changeset [38125] by hausmann@webkit.org

2008-11-05 Jeff Cook <cookiecaper@gmail.com>

Reviewed by Simon Hausmann and Tor Arne.

Fix crash in the Qt port when unloading swfdec and Flash 10
by reordering window destruction and plugin stop.

See https://bugs.webkit.org/show_bug.cgi?id=20779

07:31 Changeset [38124] by hausmann@webkit.org

2008-11-05 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø

Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.

Otherwise Flash refuses to load and function :(

07:31 Changeset [38123] by hausmann@webkit.org

2008-11-05 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø

Unify determineQuirks between the Qt and the Gtk PluginPackage.
Share the code for parsing the module version from the description.
This is currently used to determine Flash based quirks.

01:25 Changeset [38122] by mitz@apple.com

2008-11-05 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Another set of updated expected pixel results generated with the same
setup. Includes accessiblity/, animations/, css1/, css2.1/, css3/,
dom/ and editing/.

(file listing elided)

01:07 Changeset [38121] by mitz@apple.com

2008-11-05 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Imported more image bases for a representative set of pixel tests in order to
fully validate latest DRT and test script changes. These results were generated
by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
QuickTime 7.5.5.

(file listing elided)

00:45 Changeset [38120] by mitz@apple.com
  • Tiger build fix
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]):

11/04/08:

17:44 Changeset [38119] by andersca@apple.com

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Don't leak the CALayer.


  • Plugins/WebBaseNetscapePluginView.h: Make the layer a RetainPtr.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):


(-[WebBaseNetscapePluginView stop]):
Make sure to clear out the layer here.

16:58 Changeset [38118] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Steve Falkenburg.

Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
their movement in the filesystem.

16:49 Changeset [38117] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore, and remove
its unused forwarding header in WebKit/mac.

JavaScriptCore:

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/dtoa.cpp: Removed.
  • kjs/dtoa.h: Removed.
  • wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
  • wtf/dtoa.h: Copied from kjs/dtoa.h.

WebCore:

  • ForwardingHeaders/kjs/dtoa.h: Removed.
  • ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
  • css/CSSParser.cpp:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs/dtoa.h: Removed.
16:45 Changeset [38116] by andersca@apple.com

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

More cleanup. Make a bunch of instance variables RetainPtrs.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView didStart]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView pluginPackage]): (-[WebBaseNetscapePluginView setPluginPackage:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView userAgent]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView _createPlugin]): (-[WebBaseNetscapePluginView _redeliverStream]):
16:24 Changeset [38115] by pam@chromium.org

2008-11-04 Jonathan Haas <myrdred@gmail.com>

Addiitonal tweaks and patch prep by Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Fixed an issue which could cause memory corruption using ToT libxml.
See https://bugs.webkit.org/show_bug.cgi?id=15715

Test: fast/xsl/xslt-nested-stylesheets.xml

  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary (WebCore::XSLStyleSheet::setParentStyleSheet): Added
  • xml/XSLStyleSheet.h: Added m_parentStyleSheet member

2008-11-04 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Added test for crash resulting from nested stylesheets using certain
builds of libxml2. See https://bugs.webkit.org/show_bug.cgi?id=15715 .

  • fast/xsl/resources/xslt-nested-stylesheets0.xsl: Added.
  • fast/xsl/resources/xslt-nested-stylesheets1.xsl: Added.
  • fast/xsl/xslt-nested-stylesheets-expected.txt: Added.
  • fast/xsl/xslt-nested-stylesheets.xml: Added.
15:44 Changeset [38114] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/config.h to the top level of JavaScriptCore.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h: Copied from kjs/config.h.
  • kjs/config.h: Removed.
15:00 Changeset [38113] by simon.fraser@apple.com

2008-11-04 Simon Fraser <simon.fraser@apple.com>

Add AccessibilityObject.o to the exclude list for the
check for global destructors.

  • Scripts/check-for-exit-time-destructors:
14:40 Changeset [38112] by simon.fraser@apple.com

2008-11-04 Simon Fraser <simon.fraser@apple.com>

No review.

Improved buid fix: include MathExtras.h to get roundf on all platforms.

  • platform/graphics/FloatPoint.h:
14:08 Changeset [38111] by darin@apple.com

2008-11-04 Darin Adler <darin@apple.com>

  • Scripts/check-for-exit-time-destructors: Fix failures seen on the bot, but for some reason not on my computer.
12:55 Changeset [38110] by beidson@apple.com

WebCore:

2008-11-04 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan

Add a simple "visited" method to HistoryItem for use by global history

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::visited): Update the title on the item, set last visited time, and bump the visit count. All things that should happen when a url is visited again!
  • history/HistoryItem.h:

WebKit/mac:

2008-11-04 Brady Eidson <beidson@apple.com>

Reviewed by John Sullivan

Cleanup global history a tad.

Used to _addItemForURL always create a new item and merge it with a previous item if one existed.

It is more efficient and less complicated to update the previous item if one exists.

  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): (-[WebHistory _visitedURL:withTitle:]): Instead of calling the general purpose [WebHistoryPrivate addItem:] with a new history item, call the new special purposed visitedURL:withTitle:
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:]): Call "visited()" on the WebCore history item with the pertinent info.
  • History/WebHistoryItemInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):
12:08 Changeset [38109] by andersca@apple.com

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22065

Only create the plug-in stream loader when the stream is started.


  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::start):
11:43 Changeset [38108] by jmalonzo@webkit.org

2008-11-04 Jan Michael Alonzo <jmalonzo@webkit.org>

Build fix. Not reviewed.

  • platform/graphics/FloatPoint.h: include math.h. reported by zdobersek in #webkit.
11:40 Changeset [38107] by darin@chromium.org

2008-11-04 Darin Fisher <darin@chromium.org>

Reviewed by Anders Carlsson.

No need to clobber all ResourceRequest fields in FrameLoader::reload()
https://bugs.webkit.org/show_bug.cgi?id=21949

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload):
11:00 Changeset [38106] by darin@apple.com

2008-11-04 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • storage/Database.cpp: (WebCore::databaseVersionKey): Tweaked formatting.
10:59 Changeset [38105] by darin@apple.com

2008-11-04 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • wtf/ThreadingNone.cpp: Tweak formatting.
10:58 Changeset [38104] by darin@apple.com

2008-11-03 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
  • html/HTMLAttributeNames.in: Removed some unused attribute names.
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that sets the write-only m_pluginPage.
  • html/HTMLEmbedElement.h: Ditto.
  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Changed to return a Cursor&. (WebCore::pointerCursor): Changed to leak an object to avoid an exit-time destructor. (WebCore::crossCursor): Ditto. (WebCore::handCursor): Ditto. (WebCore::moveCursor): Ditto. (WebCore::verticalTextCursor): Ditto. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto. (WebCore::aliasCursor): Ditto. (WebCore::zoomInCursor): Ditto. (WebCore::zoomOutCursor): Ditto. (WebCore::copyCursor): Ditto. (WebCore::noneCursor): Ditto. (WebCore::progressCursor): Ditto. (WebCore::noDropCursor): Ditto. (WebCore::notAllowedCursor): Ditto. (WebCore::iBeamCursor): Ditto. (WebCore::waitCursor): Ditto. (WebCore::helpCursor): Ditto. (WebCore::eastResizeCursor): Ditto. (WebCore::northResizeCursor): Ditto. (WebCore::northEastResizeCursor): Ditto. (WebCore::northWestResizeCursor): Ditto. (WebCore::southResizeCursor): Ditto. (WebCore::southEastResizeCursor): Ditto. (WebCore::southWestResizeCursor): Ditto. (WebCore::westResizeCursor): Ditto. (WebCore::northSouthResizeCursor): Ditto. (WebCore::eastWestResizeCursor): Ditto. (WebCore::northEastSouthWestResizeCursor): Ditto. (WebCore::northWestSouthEastResizeCursor): Ditto. (WebCore::columnResizeCursor): Ditto. (WebCore::rowResizeCursor): Ditto. (WebCore::grabCursor): Ditto. (WebCore::grabbingCursor): Ditto.
  • storage/Database.cpp: (WebCore::guidMutex): Changed to leak an object to avoid an exit-time destructor. Also added a comment explaining why it's thread safe. (WebCore::guidToVersionMap): Ditto. (WebCore::guidToDatabaseMap): Ditto. (WebCore::Database::databaseInfoTableName): Ditto. (WebCore::databaseVersionKey): Ditto. (WebCore::Database::getVersionFromDatabase): Ditto. (WebCore::Database::setVersionInDatabase): Ditto. (WebCore::guidForOriginAndName): Ditto.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::tracker): Ditto. (WebCore::notificationMutex): Ditto. (WebCore::notificationQueue): Ditto. (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.
10:57 Changeset [38103] by mitz@apple.com

2008-11-04 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

  • part of https://bugs.webkit.org/show_bug.cgi?id=21821 Removed pixel results in platform/mac-tiger that were only slightly different (within 1% tolerance) from the platform/mac results. Removed results in platform/mac-tiger where the results in platform/mac were also correct for Tiger.

(file listing elided)

10:57 Changeset [38102] by darin@apple.com

2008-11-03 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • WebKit.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
10:57 Changeset [38101] by darin@apple.com

2008-11-03 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • JavaScriptCore.exp: Changed to export functions rather than a global for the atomically initialized static mutex.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
  • wtf/MainThread.cpp: (WTF::mainThreadFunctionQueueMutex): Changed to leak an object rather than using an exit time destructor. (WTF::functionQueue): Ditto.
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::cachedCollatorMutex): Ditto.
  • wtf/Threading.h: Changed other platforms to share the Windows approach where the mutex is internal and the functions are exported.
  • wtf/ThreadingGtk.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingNone.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): Changed to leak an object rather than using an exit time destructor. (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto. (WTF::threadMap): Changed to leak an object rather than using an exit time destructor.
  • wtf/ThreadingQt.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.
10:56 Changeset [38100] by darin@apple.com

2008-11-03 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • Scripts/check-for-exit-time-destructors: Added. Started as a copy of check-for-global-initializers.
  • Scripts/check-for-global-initializers: Added code to make this script rerun any time it's modified, and also to properly run again after the first time it reports an error.
10:55 Changeset [38099] by andersca@apple.com

2008-11-04 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.


https://bugs.webkit.org/show_bug.cgi?id=22065


Remove some old, unused plug-in code.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView setVariable:value:]):
10:54 Changeset [38098] by simon.fraser@apple.com

2008-11-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21941

Rename absolutePosition() to localToAbsolute(), and add the ability
to optionally take transforms into account (which will eventually be the
default behavior).

08:22 Changeset [38097] by hausmann@webkit.org

WebCore:

2008-11-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add methods for getting and setting user data on History Item.
This change is limited to QT port only. Tests were added in
the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.

Minor change by Simon: made the functions inline and added a missing
const.

WebKit/qt:

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add userData() and setUserData() to QWebHistoryItem.
Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
Add currentItemIndex() to QWebHistory.

See also https://bugs.webkit.org/show_bug.cgi?id=21864

Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

06:15 Changeset [38096] by aroben@apple.com

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the location of JSStaticScopeObject.{cpp,h}.
04:49 QtWebKitJournal edited by ariya.hidayat@trolltech.com
update (diff)
02:59 Changeset [38095] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Move AllInOneFile.cpp to the top level of JavaScriptCore.

  • AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
  • GNUmakefile.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp: Removed.
02:46 Changeset [38094] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22030
Make EventNames usable from multiple threads

  • platform/text/AtomicString.cpp: (WebCore::stringTable): (WebCore::AtomicString::add): (WebCore::AtomicString::remove): (WebCore::AtomicString::find): (WebCore::AtomicString::init):
  • platform/text/AtomicString.h: Atomic string table is now per-thread. Individual strings cannot be shared between threads, so global AtomicString constants cannot be used from threads other than the main one.
  • dom/EventNames.cpp: (WebCore::EventNames::EventNames): (WebCore::eventNames): (WebCore::EventNames::init):
  • dom/EventNames.h: Made EventNames a ThreadSpecific struct. Individual event names are now accessed as eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all threads.
  • <Many files>: Access event names via eventNames() function.
02:40 Changeset [38093] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Alexey Proskuryakov.

Add NodeInfo.h to the JavaScriptCore Xcode project.

01:43 Changeset [38092] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Delete unused forwarding headers.

WebCore:

  • ForwardingHeaders/kjs/Activation.h: Removed.
  • ForwardingHeaders/kjs/Register.h: Removed.
  • ForwardingHeaders/kjs/RegisterID.h: Removed.

WebKit/mac:

  • ForwardingHeaders/kjs/string_object.h: Removed.
00:58 Changeset [38091] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Remove JavaScriptGlue forwarding headers that are no longer necessary,
and correct the path of the ExecState.h forwarding header.

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/CTI.h: Removed.
  • ForwardingHeaders/kjs/ExecState.h: Removed.
  • ForwardingHeaders/kjs/JSValue.h: Removed.
  • ForwardingHeaders/kjs/PutPropertySlot.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/runtime: Added.
  • ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • config.h:
00:07 Changeset [38090] by cwzwarich@webkit.org

2008-11-04 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix stupid typo in previous build fix.

  • bindings/js/JSStorageCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
Note: See TracTimeline for information about the timeline view.