Timeline


and

11/10/08:

23:57 Changeset [38294] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.

  • VM/CTI.cpp: (JSC::asInteger):
  • VM/CTI.h:
23:06 Changeset [38293] by slewis@apple.com
  • 3 edits in trunk/WebCore

2008-11-10 Stephanie Lewis <slewis@apple.com>

Reviewed by Dan Bernstein.

Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.

  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
22:04 Changeset [38292] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes):
21:55 Changeset [38291] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Make CTI::getConstant() a member function of CodeBlock instead.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::getConstant):
21:45 Changeset [38290] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Rename CodeBlock::isConstant() to isConstantRegisterIndex().

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstantRegisterIndex):
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
21:40 Changeset [38289] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

non-CTI build fix take 2

21:31 Changeset [38288] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/VM/Machine.cpp

non-CTI build fix

21:22 Changeset [38287] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the unused labels member variable of CodeBlock.

  • VM/CodeBlock.h:
  • VM/LabelID.h: (JSC::LabelID::setLocation):
21:09 Changeset [38286] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-11-10 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.

  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines):
  • VM/CTI.h: (JSC::CTI::compile): (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition): (JSC::CTI::compileCTIMachineTrampolines): (JSC::CTI::compilePatchGetArrayLength):
  • VM/Machine.cpp: (JSC::Machine::initialize): (JSC::Machine::~Machine): (JSC::Machine::execute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_lazyLinkCall):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::JITCodeBuffer::isAligned): (JSC::X86Assembler::): (JSC::X86Assembler::align):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
19:51 Changeset [38285] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.


  • wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as well as size, otherwise shrinking capacity to 0 can fail to reset the capacity and thus cause a future crash. (WTF::Vector::~Vector): Shrink size not capacity; we only need to call destructors, the buffer will be freed anyway. (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0). (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where the size is greater than the new capacity, to work with types that have no default constructor.
19:38 Changeset [38284] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Split multiple definitions into separate lines.

  • VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp):
17:26 Changeset [38283] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move renewGState to the base class.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView renewGState]):
  • Plugins/WebNetscapePluginView.mm:
17:23 Changeset [38282] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move start, stop and all the related methods down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:
17:13 Changeset [38281] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowFocusChanged:]): (-[WebBaseNetscapePluginView createPlugin]): (-[WebBaseNetscapePluginView loadStream]): (-[WebBaseNetscapePluginView destroyPlugin]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView windowFocusChanged:]):
16:51 Changeset [38280] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView shouldStop]): (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView stop]):
16:38 Changeset [38279] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Fix Tiger build.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
16:29 Changeset [38278] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView focusChanged]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView focusChanged]): (-[WebNetscapePluginView tellQuickTimeToChill]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView viewWillMoveToWindow:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView pluginView:receivedError:]): (-[WebNetscapePluginView pluginViewFinishedLoading:]): (-[WebNetscapePluginView inputContext]): (-[WebNetscapePluginView hasMarkedText]): (-[WebNetscapePluginView insertText:]): (-[WebNetscapePluginView markedRange]): (-[WebNetscapePluginView selectedRange]): (-[WebNetscapePluginView setMarkedText:selectedRange:]): (-[WebNetscapePluginView unmarkText]): (-[WebNetscapePluginView validAttributesForMarkedText]): (-[WebNetscapePluginView attributedSubstringFromRange:]): (-[WebNetscapePluginView characterIndexForPoint:]): (-[WebNetscapePluginView doCommandBySelector:]): (-[WebNetscapePluginView firstRectForCharacterRange:]): (-[WebNetscapePluginView _viewHasMoved]): (-[WebNetscapePluginView _redeliverStream]):
15:43 Changeset [38277] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move timer handling code down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView startTimers]): (-[WebBaseNetscapePluginView restartTimers]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
14:59 Changeset [38276] by andersca@apple.com
  • 8 edits in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.


Add WebHostedNetscapePluginView to the project.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move a bunch of methods and ivars up to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView finalize]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView webView]): (-[WebBaseNetscapePluginView currentWindow]):
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView sendActivateEvent:]): (-[WebNetscapePluginView restartTimers]): (-[WebNetscapePluginView setHasFocus:]): (-[WebNetscapePluginView mouseDown:]): (-[WebNetscapePluginView mouseUp:]): (-[WebNetscapePluginView mouseEntered:]): (-[WebNetscapePluginView mouseExited:]): (-[WebNetscapePluginView handleMouseMoved:]): (-[WebNetscapePluginView mouseDragged:]): (-[WebNetscapePluginView scrollWheel:]): (-[WebNetscapePluginView keyUp:]): (-[WebNetscapePluginView keyDown:]): (-[WebNetscapePluginView flagsChanged:]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView isStarted]): (-[WebNetscapePluginView dealloc]): (-[WebNetscapePluginView finalize]): (-[WebNetscapePluginView drawRect:]): (-[WebNetscapePluginView windowBecameKey:]): (-[WebNetscapePluginView preferencesHaveChanged:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebNetscapePluginView _viewHasMoved]):
14:27 Changeset [38275] by andersca@apple.com
  • 8 edits
    2 adds in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Mark Rowe.

Add a WebHostedNetscapePluginView class.


  • Plugins/WebHostedNetscapePluginView.h: Added.
  • Plugins/WebHostedNetscapePluginView.mm: Added.
  • Plugins/WebNetscapePluginPackage.h: Use the right define.


  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Check for WebBaseNetscapePluginView.


(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.


  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): Use WebBaseNetscapePluginView.


(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.


(WebFrameLoaderClient::createPlugin):
Get the right class.


  • WebKitPrefix.h: Prefix the #define with WTF_.


  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): Check for WebBaseNetscapePluginView.


  • WebView/WebView.mm: Remove an unnecessary include.
14:12 Changeset [38274] by aroben@apple.com
  • 3 edits
    2 adds in trunk

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com

WebCore:

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Reviewed by Dan Bernstein.

Test: fast/css/outline-invert-assertion.html

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::systemColor): If we can't determine a good Win32 system color to use, defer to RenderTheme instead of asserting. This matches what RenderThemeMac does.

LayoutTests:

Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.

Reviewed by Dan Bernstein.

  • fast/css/outline-invert-assertion-expected.txt: Added.
  • fast/css/outline-invert-assertion.html: Added.
13:51 Changeset [38273] by bdakin@apple.com
  • 6 edits
    8 adds in trunk

WebCore:

2008-11-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting


Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from -> source and to -> destination. (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-10 Beth Dakin <bdakin@apple.com>

Rubber stamped by Justin Garcia.

New tests for <rdar://problem/4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting

  • editing/pasteboard/paste-blockquote-into-blockquote-2.html: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt: Added.


Test with new results because of this patch:

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
13:47 Changeset [38272] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

Commit the current configuration of build.webkit.org.

13:45 Changeset [38271] by mrowe@apple.com
  • 5 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/webkit

Commit the current configuration of build.webkit.org.

13:33 Changeset [38270] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): (-[WebNetscapePluginView _printedPluginBitmap]):
13:00 Changeset [38269] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

  • Plugins/WebBaseNetscapePluginView.h: Added.
  • Plugins/WebBaseNetscapePluginView.mm: Added. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView handleMouseMoved:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView cut:]): (-[WebNetscapePluginView copy:]): (-[WebNetscapePluginView paste:]): (-[WebNetscapePluginView selectAll:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
12:25 Changeset [38268] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<https://bugs.webkit.org/show_bug.cgi?id=22162>

There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot):
12:20 Changeset [38267] by andersca@apple.com
  • 17 edits
    2 moves in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • StringsNotToBeLocalized.txt:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin):
  • Plugins/WebBaseNetscapePluginView.h: Removed.
  • Plugins/WebBaseNetscapePluginView.mm: Removed.
  • Plugins/WebNetscapePluginEventHandler.h: (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
  • Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
  • Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
  • Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm. (+[WebNetscapePluginView setCurrentPluginView:]): (+[WebNetscapePluginView currentPluginView]): (-[WebNetscapePluginView loadPluginRequest:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]):
  • Plugins/npapi.mm: (pluginViewForInstance): (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged):
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
  • WebView/WebView.mm:
10:38 Changeset [38266] by aroben@apple.com
  • 4 edits
    1 add in trunk

Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable

WebCore:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
  • platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel environment variable, parse its value as a hexadecimal number, and turn the channel on/off based on whether the mask bit is set. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each logging channel in turn.

WebKit/win:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Reviewed by Anders Carlsson.

  • WebView.cpp: (WebView::initWithFrame): Call WebCore's InitializeLoggingChannelsIfNecessary.
10:17 Changeset [38265] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

  • API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):
09:06 Changeset [38264] by darin@apple.com
  • 4 edits in trunk/WebCore

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.

  • dom/Document.cpp: (WebCore::Document::shouldScheduleLayout): Removed the part of this function that duplicated what's already in FrameView::needsLayout, since the copy here left out a few key things. For example, it didn't handle the fact that "needs reapply styles" counts as needing layout.
  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called FrameView::invalidate before. There were two things wrong with that. 1) It requested that the entire view repaint even if the style change didn't necessitate that. 2) FrameView::invalidate no longer causes any repainting at all in certain cases, because of Hyatt's changes to how widgets and the host window are involved in the repainting process. So call FrameView::scheduleRelayout instead, which is more precisely what we want and need here.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here so that Document::shouldScheduleLayout doesn't have to replicate the logic that's in needsLayout and can instead rely on the fact that it was already called. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting in this function.
09:03 Changeset [38263] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

  • speculative fix for <rdar://problem/5557243> crashes in Safari at WebCore::HTMLSelectElement::updateListBoxSelection + 280
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): Check index against size of vector before indexing into the vector.
07:55 Changeset [38262] by vestbo@webkit.org
  • 2 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Distinguish between building from trunk and as part of Qt

07:42 Changeset [38261] by darin@apple.com
  • 4 edits in trunk/BugsSite

2008-11-10 Darin Adler <darin@apple.com>

  • globals.pl: Fix cases that are automatically generated, such as links in comments in bugs.
  • template/en/custom/attachment/created.html.tmpl: Fix the link on the "I just created an attachment" page.
  • template/en/custom/request/queue.html.tmpl: Fix the link in the queue page.
07:31 Changeset [38260] by darin@apple.com
  • 2 edits in trunk/BugsSite

2008-11-10 Darin Adler <darin@apple.com>

  • template/en/custom/request/email.txt.tmpl: Send review links instead of edit links when flags are set on a bug.
07:03 Changeset [38259] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

A few coding style fixes for AVLTree.

  • wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards. (WTF::AVLTree::Iterator::start_iter): Fixed indentation
  • runtime/JSArray.cpp: Added "using namepace WTF".
06:37 Changeset [38258] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

To fit Qt API, scroll offset is a QPoint instead of a QSize.

  • Api/qwebframe.cpp: (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
  • Api/qwebframe.h:
03:46 Changeset [38257] by hausmann@webkit.org
  • 2 edits in trunk

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Make tests/auto/qwebframe compile on Qt/Mac.

03:46 Changeset [38256] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed qdoc warnings by supplying function documentation.

03:45 Changeset [38255] by hausmann@webkit.org
  • 1 edit
    1 delete in trunk/WebKit/qt

2008-11-10 Tobias Koenig <tobias.koenig@trolltech.com>

Reviewed by Simon Hausmann.

Removed old and stale prf file that breaks the MingW build.

03:45 Changeset [38254] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix QtWebkit build failure on arm.

pen.widthF() is a qreal, which means it's a float on arm.

03:45 Changeset [38253] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 Kavindra Palaraja <kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Clarify QWebFrame/View::setHTML docs with regards to relative URLs

03:45 Changeset [38252] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-10 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Simon Hausmann

Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.

03:45 Changeset [38251] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.

This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.

11/09/08:

22:26 Changeset [38250] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculatively fix the non-AllInOne build.

  • runtime/NativeErrorConstructor.cpp:
17:28 Changeset [38249] by darin@apple.com
  • 15 edits
    1 delete in trunk/JavaScriptCore

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

  • VM/CodeBlock.h: Added include.
  • VM/Machine.cpp: (JSC::Machine::execute): Use the types from
DeclarationStacks as DeclarationStacks
rather than Node:: since "Node" really has little to do with it.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Ditto.
  • jsc.cpp: (Options::Options): Removed prettyPrint option. (runWithScripts): Ditto. (printUsageStatement): Ditto. (parseArguments): Ditto. (jscmain): Ditto.
  • parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.
  • parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): Use inline functions instead of direct member access for ThrowableExpressionData values. (JSC::BracketAccessorNode::emitCode): Ditto. (JSC::DotAccessorNode::emitCode): Ditto. (JSC::NewExprNode::emitCode): Ditto. (JSC::EvalFunctionCallNode::emitCode): Ditto. (JSC::FunctionCallValueNode::emitCode): Ditto. (JSC::FunctionCallResolveNode::emitCode): Ditto. (JSC::FunctionCallBracketNode::emitCode): Ditto. (JSC::FunctionCallDotNode::emitCode): Ditto. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PostfixBracketNode::emitCode): Ditto. (JSC::PostfixDotNode::emitCode): Ditto. (JSC::DeleteResolveNode::emitCode): Ditto. (JSC::DeleteBracketNode::emitCode): Ditto. (JSC::DeleteDotNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::PrefixBracketNode::emitCode): Ditto. (JSC::PrefixDotNode::emitCode): Ditto. (JSC::ThrowableBinaryOpNode::emitCode): Ditto. (JSC::InstanceOfNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto. (JSC::AssignDotNode::emitCode): Ditto. (JSC::ReadModifyDotNode::emitCode): Ditto. (JSC::AssignBracketNode::emitCode): Ditto. (JSC::ReadModifyBracketNode::emitCode): Ditto. (JSC::statementListEmitCode): Take a const StatementVector instead of a non-const one. Also removed unused statementListPushFIFO. (JSC::ForInNode::emitCode): Inline functions instead of member access. (JSC::ThrowNode::emitCode): Ditto. (JSC::EvalNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Ditto. (JSC::ProgramNode::emitCode): Ditto.
  • parser/Nodes.h: Removed unused includes and forward declarations. Removed Precedence enum. Made many more members private instead of protected or public. Removed unused NodeStack typedef. Moved the VarStack and FunctionStack typedefs from Node to ScopeNode. Made Node::emitCode pure virtual and changed classes that don't emit any code to inherit from ParserRefCounted rather than Node. Moved isReturnNode from Node to StatementNode. Removed the streamTo, precedence, and needsParensIfLeftmost functions from all classes. Removed the ImmediateNumberNode class and make NumberNode::setValue nonvirtual.
  • parser/nodes2string.cpp: Removed.
17:19 Changeset [38248] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 19541: Null pointer in showModalDialog()
<https://bugs.webkit.org/show_bug.cgi?id=19541>

Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::canShowModalDialog): (WebCore::canShowModalDialogNow):

LayoutTests:

  • fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
  • fast/dom/null-page-show-modal-dialog-crash.html: Added.
17:04 Changeset [38247] by darin@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.

Test: fast/js/large-expressions.html

1) Code generation is recursive, so takes stack proportional to the complexity

of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.

2) Destruction of the syntax tree was recursive. Fixed by introducing a

non-recursive mechanism for destroying the tree.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0. (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code to throw a "too deep" exception.
  • bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed the maximum depth.
  • parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors to avoid recursive calls to destructors for nodes inside this one. (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions. Also added releaseNodes functions and calls to releaseAllNodes inside destructors for each class derived from Node that has RefPtr to other nodes. (JSC::NodeReleaser::adopt): Added. Used by the release function. (JSC::NodeReleaser::adoptFunctionBodyNode): Added.
  • parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts of an older solution to the non-recursive destruction problem that works only for lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode to use BinaryOpNode as a base class to avoid some duplicated code.

LayoutTests:

2008-11-09 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

  • fast/loader/javascript-url-encoding-2-expected.txt:
  • fast/loader/javascript-url-encoding-2.html:
16:22 Changeset [38246] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-11-09 Darin Adler <darin@apple.com>

  • try to fix Windows build
  • platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules about needed a separate definition for static const integer data members. Until I get to the bottom of this, put the definitions inside an ifdef.
12:19 Changeset [38245] by darin@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of a local variable to make this code match the code in the function below more closely. (WebFrameLoaderClient::provisionalLoadStarted): Added comments.
  • WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollView]): Tweaked formatting. (-[WebFrameView initWithFrame:]): Ditto. (-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting. (-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes the bug. Calls setDrawsBackground:YES as appropriate since moving the view out of the window to switch to another view disrupts the special technique for showing the old page during the start of loading. This is the identical reason for the setFrameSize: method above, and the code is almost the same.
11:50 Changeset [38244] by ddkilzer@apple.com
  • 6 edits in trunk/WebCore

BUILD FIX: Qt build broke after r38235.

Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.

  • page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY) guards.
  • page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
  • page/qt/AccessibilityObjectQt.cpp: Ditto.
  • page/win/AccessibilityObjectWin.cpp: Ditto.
  • page/wx/AccessibilityObjectWx.cpp: Ditto.
11:08 Changeset [38243] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

Test: fast/loader/javascript-url-encoding-2.html

  • platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.
10:20 Changeset [38242] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed and tweaked by Darin Adler.

  • platform/graphics/Color.cpp: Added definitions for the static data members in this class. Static data members need a definition, even when they are the simple integer constant kind that can be initialized in the header.
07:50 Changeset [38241] by darin@apple.com
  • 8 edits in trunk/LayoutTests

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Fixed spelling error: "gradieints".
  • fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with make-js-test-wrappers script; removes the canvas element that was in here.
  • fast/canvas/linearGradient-infinite-values.html: Ditto.
  • fast/canvas/radialGradient-infinite-values.html: Ditto.
  • fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Fixed spelling error and changed code to use createElement to make a canvas element rather than using getElementById to find an existing canvas element.
  • fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
  • fast/canvas/resources/radialGradient-infinite-values.js: Ditto.
04:56 Companies and Organizations that have contributed to WebKit edited by ddkilzer@webkit.org
Added reference to KSVG2 (diff)
02:36 Companies and Organizations that have contributed to WebKit edited by staikos@kde.org
(diff)
00:04 Companies and Organizations that have contributed to WebKit edited by mjs@apple.com
(diff)
00:02 Companies and Organizations that have contributed to WebKit created by mjs@apple.com

11/08/08:

23:36 WikiStart edited by mjs@apple.com
(diff)
20:11 Changeset [38240] by antti@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.


Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache


Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.


Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

  • fast/encoding/css-cached-bom.html: Added.
  • fast/encoding/css-cached-bom-expected.txt: Added.
  • fast/encoding/resources/css-cached-bom-frame.html: Added.
  • fast/encoding/resources/utf-16-little-endian.css: Added.
19:14 Changeset [38239] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

18:35 Changeset [38238] by kevino@webkit.org
  • 8 edits in trunk

wx build fixes after addition of JSCore parser and bycompiler dirs.

17:09 Changeset [38237] by simon.fraser@apple.com
  • 5 edits
    4 adds in trunk

2008-11-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
  • rendering/RenderTextControl.h:
16:33 Changeset [38236] by timothy@apple.com
  • 2 edits in trunk/WebCore

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

  • inspector/front-end/inspector.css:
11:42 Changeset [38235] by ddkilzer@apple.com
  • 7 edits in trunk

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

  • page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
  • page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
  • page/mac/AccessibilityObjectMac.mm: Ditto.
  • page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

  • WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.
11:12 Changeset [38234] by mitz@apple.com
  • 16 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • WebCore part of adding WebPreferences for controlling databases and local storage
  • WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
  • page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit/mac part of adding WebPreferences for controlling databases and local storage
  • WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

  • WebKit/win part of adding WebPreferences for controlling databases and local storage
  • Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
  • WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.
05:57 Changeset [38233] by staikos@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog-2008-08-10

Just adjusting email address in changelog.

11/07/08:

14:29 Changeset [38232] by alp@webkit.org
  • 8 edits in trunk/WebCore

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

  • platform/gtk/FileSystemGtk.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/gtk/MouseEventGtk.cpp:
  • platform/gtk/WheelEventGtk.cpp:
  • platform/gtk/gtkdrawing.h:
  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:
13:34 Changeset [38231] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

  • bridge/npapi.h:
13:15 Changeset [38230] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

  • fast/js/resources/typeof-constant-string.js: Added.
  • fast/js/typeof-constant-string-expected.txt: Added.
  • fast/js/typeof-constant-string.html: Added.
12:41 Changeset [38229] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstant):
11:35 Changeset [38228] by alp@webkit.org
  • 4 edits in trunk

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 Changeset [38227] by simon.fraser@apple.com
  • 8 edits in trunk/WebCore

2008-11-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):
10:07 Changeset [38226] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

  • DerivedSources.make:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCoreSources.bkl:
09:48 Changeset [38225] by alp@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
07:39 Changeset [38224] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

07:01 Changeset [38223] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

06:47 Changeset [38222] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
06:11 Changeset [38221] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-07 Simon Hausmann <hausmann@webkit.org>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

03:32 Changeset [38220] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

01:22 Changeset [38219] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
  • bytecompiler/CodeGenerator.h:
01:22 Changeset [38218] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.
01:20 Applications using WebKit edited by barbarosa100@hotmail.com
Added DVDpedia, Bookpedia, CDpedia and Gamepedia as apps that use WebKit (diff)
00:59 Changeset [38217] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Enable text only and succeeding fast tests for the gtk port

Enable the tests from the fast directory that succeed. Classify the
remaining tests from the fast directory.

  • platform/gtk/Skipped:
00:53 Changeset [38216] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-07 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22039

Skip every test on the Gtk+ platform

Add every test directory to the Skipped list in order to create
a baseline for the Gtk+ port.

  • platform/gtk/Skipped:

11/06/08:

23:41 Changeset [38215] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
23:26 Changeset [38214] by antti@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Antti Koivisto <antti@apple.com>

Eh, this trivial last minute change was wrong.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText):
23:22 Changeset [38213] by antti@apple.com
  • 3 edits in trunk/WebCore

2008-11-06 Antti Koivisto <antti@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22093


Delaying the text decoding caused regression since the decoding
also determines the encoding in case of @charset rule.


Decode immediately in data() and keep the decoded string around
during the checkNotify().

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
21:54 Changeset [38212] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22097
Expose MessageEvent constructor on WorkerContext

  • bindings/js/JSWorkerContext.cpp: (WebCore::jsWorkerContextMessageEvent): (WebCore::setJSWorkerContextMessageEvent):
21:52 Changeset [38211] by ap@webkit.org
  • 8 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21107
<rdar://problem/6264219> New access key combination conflicts with VoiceOver

  • page/EventHandler.h:
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::accessKeyModifiers):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::accessKeyModifiers): Access access key modifiers via a function, not a static variable.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers): Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is less troublesome than one with VO keys.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Also fix an access key matching bug introduced in r32424 - Any superset of specified modifier set invoked access keys. We can use simple equality comparison instead because CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
20:04 Changeset [38210] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL

Export _NPN_HasMethod and _NPN_HasProperty.


  • WebCore.NPAPI.exp:

WebKit/mac:

2008-11-06 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

https://bugs.webkit.org/show_bug.cgi?id=22115
NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL


Initialize the browser funcs correctly.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
17:30 Changeset [38209] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-06 Gavin Barraclough barraclough@apple.com

Reviewed by Oliver Hunt.

Do not make a cti_* call to perform an op_call unless either:
(1) The codeblock for the function body has not been generated.
(2) The number of arguments passed does not match the callee arity.

~1% progression on sunspider --v8

  • VM/CTI.cpp: (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • kjs/nodes.h:
17:11 Changeset [38208] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=15678

Fix transformed menu selects to show the popup in the correct
location.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::showPopup):
16:55 Changeset [38207] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

WebCore:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKit/mac:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

WebKitTools:

BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.

Apparently older versions of gcc have issues with this patch.
Backing out a second time until the issues are resolved.

16:47 Changeset [38206] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com>

Reviewed by Maciej Stachowiak.

Bug 21106: .in format discussed changes
https://bugs.webkit.org/show_bug.cgi?id=21106

Include the namespace into the interfaceName.

  • dom/make_names.pl: Do not append the namespace when using the interfaceName.
  • html/HTMLTagNames.in: Added namespace prefix for custom interfaceName.
  • svg/svgtags.in: Ditto.
16:18 Changeset [38205] by cwzwarich@webkit.org
  • 35 edits
    16 copies
    2 adds
    3 deletes in trunk

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Move the remaining files in the kjs subdirectory of JavaScriptCore to
a new parser subdirectory, and remove the kjs subdirectory entirely.

JavaScriptCore:

  • AllInOneFile.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/ExceptionHelpers.cpp:
  • VM/SamplingTool.h:
  • bytecompiler/CodeGenerator.h:
  • jsc.pro:
  • jscore.bkl:
  • kjs: Removed.
  • kjs/NodeInfo.h: Removed.
  • kjs/Parser.cpp: Removed.
  • kjs/Parser.h: Removed.
  • kjs/ResultType.h: Removed.
  • kjs/SourceCode.h: Removed.
  • kjs/SourceProvider.h: Removed.
  • kjs/grammar.y: Removed.
  • kjs/keywords.table: Removed.
  • kjs/lexer.cpp: Removed.
  • kjs/lexer.h: Removed.
  • kjs/nodes.cpp: Removed.
  • kjs/nodes.h: Removed.
  • kjs/nodes2string.cpp: Removed.
  • parser: Added.
  • parser/Grammar.y: Copied from kjs/grammar.y.
  • parser/Keywords.table: Copied from kjs/keywords.table.
  • parser/Lexer.cpp: Copied from kjs/lexer.cpp.
  • parser/Lexer.h: Copied from kjs/lexer.h.
  • parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
  • parser/Nodes.cpp: Copied from kjs/nodes.cpp.
  • parser/Nodes.h: Copied from kjs/nodes.h.
  • parser/Parser.cpp: Copied from kjs/Parser.cpp.
  • parser/Parser.h: Copied from kjs/Parser.h.
  • parser/ResultType.h: Copied from kjs/ResultType.h.
  • parser/SourceCode.h: Copied from kjs/SourceCode.h.
  • parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
  • parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
  • pcre/pcre.pri:
  • pcre/pcre_exec.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSActivation.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSObject.cpp: (JSC::JSObject::toNumber):
  • runtime/RegExp.cpp:

WebCore:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/Parser.h: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
  • ForwardingHeaders/kjs/SourceCode.h: Removed.
  • ForwardingHeaders/kjs/SourceProvider.h: Removed.
  • ForwardingHeaders/parser: Added.
  • ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
  • ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
  • ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/StringSourceProvider.h:
  • bindings/js/WorkerScriptController.cpp:
  • bridge/NP_jsobject.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/testbindings.pro:
  • inspector/JavaScriptDebugServer.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
16:17 Changeset [38204] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix test that would fail if it had the wrong set of plugins.

  • plugins/plugin-javascript-access.html:
15:46 Changeset [38203] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD WAS NOT BROKEN: Rolling r38189 back in.

WebCore:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKit/mac:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

WebKitTools:

BUILD WAS NOT BROKEN: Rolling r38189 back in.

Please perform a clean build if you see crashes.

15:10 Changeset [38202] by ddkilzer@apple.com
  • 83 edits in trunk

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebCore:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKit/mac:

BUILD FIX: Backed out r38189 since it apparently broke the world.

WebKitTools:

BUILD FIX: Backed out r38189 since it apparently broke the world.

14:23 Changeset [38201] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/loader/FrameLoader.cpp

Fix indentation.

14:16 Changeset [38200] by cfleizach@apple.com
  • 8 edits
    2 adds in trunk

Bug 22112: if a <body> has contenteditable=true, it should report a writable AXValue
https://bugs.webkit.org/show_bug.cgi?id=22112

14:03 Changeset [38199] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix after r38196

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Added bytecompiler/ to the include path.
13:55 Changeset [38198] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Sam Weinig <sam@webkit.org>

Reviewed by Alice Liu.

Fix failed assert at launch caused by unintialized data member on the mac.

  • platform/network/mac/NetworkStateNotifierMac.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
13:47 Changeset [38197] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-11-06 Steve Falkenburg <sfalken@apple.com>

Fix failed assert at launch caused by unintialized data member.


Reviewed by Maciej Stachowiak.

  • platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::NetworkStateNotifier):
13:43 Changeset [38196] by cwzwarich@webkit.org
  • 8 edits
    3 moves
    1 add in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a new bytecompiler subdirectory of JavaScriptCore and move some
relevant files to it.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeGenerator.cpp: Removed.
  • VM/CodeGenerator.h: Removed.
  • bytecompiler: Added.
  • bytecompiler/CodeGenerator.cpp: Copied from VM/CodeGenerator.cpp.
  • bytecompiler/CodeGenerator.h: Copied from VM/CodeGenerator.h.
  • bytecompiler/LabelScope.h: Copied from kjs/LabelScope.h.
  • jscore.bkl:
  • kjs/LabelScope.h: Removed.
13:35 Changeset [38195] by sullivan@apple.com
  • 3 edits in trunk/WebKit/win

2008-11-06 John Sullivan <sullivan@apple.com>

Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.


Reviewed by Adam Roben

  • WebView.h: removed m_zoomMultiplierIsTextOnly


  • WebView.cpp: (WebView::WebView): removed initialization of m_zoomMultiplierIsTextOnly (WebView::setZoomMultiplier): use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly (WebView::zoomMultiplier): use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
13:22 Changeset [38194] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-06 John Sullivan <sullivan@apple.com>

Fixed problem with switching between text-only zoom and full-content zoom


There were two booleans tracking whether zoom was text-only, one in WebCore settings
and one in WebViewPrivate. Fixed by eliminating the one in WebViewPrivate.

Reviewed by Adam Roben

  • WebView/WebView.mm: remove declaration of zoomMultiplierIsTextOnly instance variable in WebViewPrivate (-[WebViewPrivate init]): removed initialization of zoomMultiplierIsTextOnly (-[WebView textSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _setZoomMultiplier:isTextOnly:]): update WebCore settings rather than WebViewPrivate instance variable (-[WebView _zoomMultiplier:]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable (-[WebView _realZoomMultiplierIsTextOnly]): return value from WebCore settings instead of accessing WebViewPrivate instance variable (-[WebView pageSizeMultiplier]): call [self _realZoomMultiplierIsTextOnly] instead of accessing WebViewPrivate instance variable
12:55 Changeset [38193] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2008-11-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=22109
Make <input type="range"> work correctly with transforms

Test: fast/forms/slider-transformed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

Compute a correct local point when the event is retargeted

  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):

Compute m_initialClickPoint in slider-local coords, so that
deltas are computed correctly with transforms

(WebCore::RenderSlider::mouseEventIsInThumb):

Rather than computing an absolute bounds for the thumb,
convert the point to local coords and compare it with the border box.

12:36 Changeset [38192] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows clean build fix after r38155

Rubberstamped by Cameron Zwarich.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the post-build event for the move of create_hash_table out of kjs/.
12:35 Changeset [38191] by adele@apple.com
  • 6 edits in trunk/WebKit/win

2008-11-06 Adele Peterson <adele@apple.com>

Reviewed by Adam Roben.

Add support for a WebKitZoomsTextOnly preference.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::setZoomsTextOnly): (WebPreferences::zoomsTextOnly):
  • WebPreferences.h:
  • WebView.cpp: (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this. (WebView::makeTextLarger): ditto. (WebView::canMakeTextSmaller): ditto. (WebView::makeTextSmaller): ditto. (WebView::canMakeTextStandardSize): Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting. (WebView::makeTextStandardSize): (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
11:30 Changeset [38190] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22107

Bug uncovered during RVCT port in functions not used. get_lt() and
get_gt() takes only one argument - remove second argument where
applicable.

11:28 Changeset [38189] by ddkilzer@apple.com
  • 83 edits in trunk

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)

WebCore:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • bindings/js/GCController.cpp: (WebCore::gcController): Changed to leak an object to avoid an exit-time destructor.
  • bindings/js/JSDOMBinding.cpp: (WebCore::wrapperSet): Ditto
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::wrappers): Ditto
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::wrappers): Ditto
  • bridge/runtime_root.cpp: (JSC::Bindings::rootObjectSet): Ditto
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): Ditto
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Ditto
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto
  • css/CSSStyleSelector.cpp: (WebCore::screenEval): Ditto (WebCore::printEval): Ditto
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): Ditto (WebCore::isSVG11Feature): Ditto (WebCore::DOMImplementation::isXMLMIMEType): Ditto
  • dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): Ditto
  • dom/ScriptElement.cpp: (WebCore::isSupportedJavaScriptLanguage): Ditto
  • editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): Ditto
  • editing/HTMLInterchange.cpp: (WebCore::): Ditto
  • editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Ditto
  • editing/ReplaceSelectionCommand.cpp: (WebCore::isInterchangeNewlineNode): Ditto (WebCore::isInterchangeConvertedSpaceSpan): Ditto
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Ditto (WebCore::nonBreakingSpaceString): Ditto
  • editing/markup.cpp: (WebCore::appendAttributeValue): Ditto (WebCore::appendEscapedContent): Ditto (WebCore::shouldAddNamespaceAttr): Ditto (WebCore::appendNamespace): Ditto (WebCore::appendStartMarkup): Ditto (WebCore::createMarkup): Ditto
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Ditto
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName): Ditto (WebCore::inlineTagList): Ditto (WebCore::blockTagList): Ditto
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::type): Ditto
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type): Ditto
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Ditto (WebCore::HTMLParser::isHeaderTag): Ditto (WebCore::HTMLParser::isResidualStyleTag): Ditto (WebCore::HTMLParser::isAffectedByResidualStyle): Ditto
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::type): Ditto
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::type): Ditto
  • inspector/InspectorController.cpp: (WebCore::platform): Ditto
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::shared): Ditto
  • inspector/JavaScriptProfile.cpp: (WebCore::profileCache): Ditto
  • inspector/JavaScriptProfileNode.cpp: (WebCore::profileNodeCache): Ditto
  • loader/FrameLoader.cpp: (WebCore::localSchemes): Ditto
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::cacheStorage): Ditto
  • loader/archive/ArchiveFactory.cpp: (WebCore::archiveMIMETypes): Ditto
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Ditto
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): Ditto
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Ditto (WebCore::keepAliveSet): Ditto
  • page/Page.cpp: (WebCore::Page::groupName): Ditto
  • page/SecurityOrigin.cpp: (WebCore::isDefaultPortForProtocol): Ditto (WebCore::SecurityOrigin::databaseIdentifier): Ditto
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto
  • platform/KURL.cpp: (WebCore::blankURL): Ditto
  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName): Ditto
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::getSimilarFontPlatformData): Ditto (WebCore::FontCache::getLastResortFallbackFont): Ditto
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarTheme::nativeTheme): Ditto
  • platform/mac/ThemeMac.mm: (WebCore::platformTheme): Ditto
  • platform/mac/ThreadCheck.mm: (WebCoreReportThreadViolation): Ditto
  • platform/network/NetworkStateNotifier.cpp: (WebCore::networkStateNotifier): Ditto
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDataMap): Ditto (WebCore::getStreamResourceHandleMap): Ditto
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Ditto
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isJapanese): Ditto
  • rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): Ditto
  • rendering/RenderCounter.cpp: (WebCore::counterMaps): Ditto
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerText): Ditto
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::renderScrollbarTheme): Ditto
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::systemFont): Ditto
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::initialDashboardRegions): Ditto (WebCore::RenderStyle::noneDashboardRegions): Ditto
  • storage/LocalStorage.cpp: (WebCore::localStorageMap): Ditto
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::rotateMode): Ditto
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calcMode): Ditto (WebCore::SVGAnimationElement::attributeType): Ditto (WebCore::SVGAnimationElement::isAdditive): Ditto (WebCore::SVGAnimationElement::isAccumulated): Ditto
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::xmlspace): Ditto
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::contentScriptType): Ditto (WebCore::SVGSVGElement::contentStyleType): Ditto
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type): Ditto (WebCore::SVGStyleElement::media): Ditto
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::parseMappedAttribute): Ditto
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::parseClockValue): Ditto (WebCore::SVGSMILElement::restart): Ditto (WebCore::SVGSMILElement::fill): Ditto (WebCore::SVGSMILElement::repeatCount): Ditto (WebCore::SVGSMILElement::notifyDependentsIntervalChanged): Ditto
  • svg/graphics/SVGResource.cpp: (WebCore::clientMap): Ditto
  • svg/graphics/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Ditto
  • xml/XMLHttpRequest.cpp: (WebCore::preflightResultCache): Ditto (WebCore::isSafeRequestHeader): Ditto (WebCore::isOnAccessControlResponseHeaderWhitelist): Ditto
  • xml/XPathExpressionNode.cpp: (WebCore::XPath::Expression::evaluationContext): Ditto
  • xml/XPathParser.cpp: (WebCore::XPath::isAxisName): Ditto (WebCore::XPath::isNodeTypeName): Ditto
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Ditto

WebKit/mac:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

  • History/WebBackForwardList.mm: (backForwardLists): Changed to leak an object to avoid an exit-time destructor.
  • History/WebHistoryItem.mm: (historyItemWrappers): Ditto
  • Misc/WebStringTruncator.m: (fontFromNSFont): Ditto
  • Plugins/WebBaseNetscapePluginStream.mm: (streams): Ditto
  • WebView/WebView.mm: (aeDescFromJSValue): Ditto

WebKitTools:

2008-11-06 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Remove .o files from the exclude list that have had their exit-time destructors removed.

  • Scripts/check-for-exit-time-destructors:
11:04 Changeset [38188] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Remove a bunch of unused methods in the Qt media element implementation

10:47 Changeset [38187] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22033
[GTK] CTI/Linux r38064 crashes; JIT requires executable memory

Mark pages allocated by the FastMalloc mmap code path executable with
PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
non-executable memory (like ExecShield on Fedora Linux) when the JIT
is enabled.

This patch does not resolve the issue on debug builds so affected
developers may still need to pass --disable-jit to configure.

  • wtf/TCSystemAlloc.cpp: (TryMmap): (TryDevMem): (TCMalloc_SystemRelease):
10:42 Changeset [38186] by simon.fraser@apple.com
  • 11 edits
    2 adds in trunk

2008-11-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21870

Implement absoluteToLocal() to convert a point from absolute
to local coordinates, optionally taking transforms into account.

Use this to set offsetX/offsetY in mouse events, thus fixing
offsetX/offsetY in events on elements with transforms.

Test: fast/events/offsetX-offsetY.html

10:41 Changeset [38185] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Cameron Zwarich.

Bug 22099: Make the Qt port build the JSC shell in the correct place
<https://bugs.webkit.org/show_bug.cgi?id=22099>

Adjust include paths and build destination dir for the 'jsc' executable
in the Qt build.

  • jsc.pro:
10:41 Changeset [38184] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Cameron Zwarich.

https://bugs.webkit.org/show_bug.cgi?id=22067
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()

null-check symbols loaded from plugin modules, initialize the function
table (like Win already does) and update it with the latest
additions. Adjust whitespace for easy diff'ing with the Win port code
from which it was forked.

This fixes crashes with libnspr4.so and any other plugins that don't
provide the symbols we expect.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo): (WebCore::PluginPackage::load):
10:38 Changeset [38183] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Removed dead (and broken) code from an ancient Symbian port.

10:38 Changeset [38182] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use QLibrary as PlatformModule when compiling with Qt for S60.

10:38 Changeset [38181] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Implemented the block allocation on Symbian through heap allocation.

Unfortunately there is no way to allocate virtual memory. The Posix
layer provides mmap() but no anonymous mapping. So this is a very slow
solution but it should work as a start.

10:38 Changeset [38180] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Compile fix for Symbian.
The snprintf function is defined in stdio.h, the inclusion
of snprintf.h inside this PLATFORM(SYMBIAN) block does not
compile.

10:36 Changeset [38179] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-06 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22047
GTK: Add support for multiple file selection in the file upload control

Implemented with GtkFileChooser.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runOpenPanel):
10:12 Changeset [38178] by hausmann@webkit.org
  • 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp

Removed misplaced fixme comment that doesn't belong there.
Noticed by Darin

10:03 Changeset [38177] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Borrow some math functions from the MSVC port to the build with the
RVCT compiler.

10:03 Changeset [38176] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Include strings.h for strncasecmp().
This is needed for compilation inside Symbian and it is also
confirmed by the man-page on Linux.

09:48 Changeset [38175] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Implemented currentThreadStackBase for Symbian.

09:48 Changeset [38174] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

RVCT does not support tm_gmtoff field, so disable that code just like
for MSVC.

09:47 Changeset [38173] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Use the GCC defines of the WTF_ALIGN* macros for the RVCT and the
MINSCW compiler.

09:42 Changeset [38172] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define capabilities of the SYMBIAN platform. Some of the system
headers are actually dependent on RVCT.

09:42 Changeset [38171] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Add missing stddef.h header needed for compilation in Symbian.

08:50 Changeset [38170] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Define PLATFORM(UNIX) for S60. Effectively WebKit on S60 is compiled
on top of the Posix layer.

08:50 Changeset [38169] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Added SYMBIAN32 condition for defining PLATFORM(SYMBIAN).

08:39 Changeset [38168] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Added WINSCW compiler define for Symbian S60.

08:39 Changeset [38167] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Added COMPILER(RVCT) to detect the ARM RVCT compiler used in the Symbian environment.

08:38 Changeset [38166] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Simon Hausmann.

Disable webkit plugins for Symbian.

04:15 Changeset [38165] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix build break in debug mode when XSLT is not enabled

04:14 Changeset [38164] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Repaint video on UpdateRequest to prevent recursive painting

Calling QWidget::render() to update the video generates a paint
event that's then picked up by the event filter once more :(

We're really only interested in updates from Phonon, which we
get through the UpdateRequest for each new frame.

03:46 Changeset [38163] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build, adjust include paths after move of jsc.pro.

02:21 Changeset [38162] by cwzwarich@webkit.org
  • 6 edits
    1 move in trunk/JavaScriptCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/Shell.cpp to the top level of the JavaScriptCore directory and
rename it to jsc.cpp to reflect the name of the binary compiled from it.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jsc.cpp: Copied from kjs/Shell.cpp.
  • jsc.pro:
  • jscore.bkl:
  • kjs/Shell.cpp: Removed.
01:50 Changeset [38161] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Added a unit tests for QWebFrame::metaData().

01:49 Changeset [38160] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-06 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Improved documentation for QWebFrame::metaData().

01:49 Changeset [38159] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-05 Sriram Yadavalli <sriram.yadavalli@nokia.com>

Reviewed by Simon Hausmann.

Added QWebFrame::metaData() to provide a way in the public API
to retrieve the values of the <meta> tags.

See https://bugs.webkit.org/show_bug.cgi?id=22071

01:22 Changeset [38158] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix the WebCore build for some platforms by changing build scripts to
account for the recent move of the create_hash_table script from the kjs
subdirectory of JavaScriptCore to the root directory.

  • WebCore.pro:
  • make-generated-sources.sh:
00:58 Changeset [38157] by alp@webkit.org
  • 2 edits in trunk

2008-11-06 Alp Toker <alp@nuanti.com>

GTK build fix for r38155. create_hash_table was moved out of kjs/

  • GNUmakefile.am:
00:55 Changeset [38156] by cwzwarich@webkit.org
  • 2 edits in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Correct the date on previous ChangeLogs.

  • ChangeLog:
  • JavaScriptCore/ChangeLog:
00:53 Changeset [38155] by cwzwarich@webkit.org
  • 7 edits
    2 moves in trunk

2008-11-05 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move create_hash_table and jsc.pro out of the kjs directory and into the
root directory of JavaScriptCore.

JavaScriptCore:

  • DerivedSources.make:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • create_hash_table: Copied from kjs/create_hash_table.
  • jsc.pro: Copied from kjs/jsc.pro.
  • kjs/create_hash_table: Removed.
  • kjs/jsc.pro: Removed.
  • make-generated-sources.sh:
  • WebKit.pro:
00:18 Changeset [38154] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-11-06 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Fix a case-sensitivity issue in Mac forwarding headers. Strangely
enough, this does not always cause the build to break, even with a
case-sensitive filesystem.

  • ForwardingHeaders/runtime/Interpreter.h:
Note: See TracTimeline for information about the timeline view.