Context Navigation

Rename pendingScripts to m_pendingScripts
Rename scriptNode to m_scriptNode make the type specific
Rename pendingSrc to m_pendingSrc
Rename currentPrependingSrc to m_currentPrependingSrc
Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
Remove long-since-dead kdDebug and qDebug calls
Rename brokenComments to m_brokenComments
Remove HTMLTokenizer includes and document the rest
Rename src to m_src
Rename parser to m_parser and make it an OwnPtr
Rename inWrite to m_inWrite and jsProxy to scriptController
Rename brokenServer to m_brokenServer
Rename buffer to m_buffer and dest to m_dest
Rename size to m_bufferSize
Rename attrName to m_attrName
Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
Rename flat to selfClosingTag
Rename currToken to m_currentToken

css/CSSParser.cpp:
dom/XMLTokenizer.cpp:
dom/XMLTokenizerLibxml2.cpp:
html/HTMLDocument.cpp:
html/HTMLElement.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLParser.h:
html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processingData): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::processDoctypeToken): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::setSrc):
html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::reset): (WebCore::HTMLTokenizer::processingContentWrittenByScript): (WebCore::HTMLTokenizer::htmlParser): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer):
html/HTMLViewSourceDocument.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth):
xml/XSLTProcessor.cpp:

17:37 Changeset [38326] by simon.fraser@apple.com

2008-11-11 Simon Fraser <simon.fraser@apple.com>

Update leaves animation sample.

blog-files/leaves/index.html:
blog-files/leaves/leaves.css:

17:35 Changeset [38325] by dino@apple.com

2008-11-11 Dean Jackson <dino@apple.com>

Removed quotes in animation name value.

blog-files/pulse.html:

16:49 Changeset [38324] by dino@apple.com

2008-11-11 Dean Jackson <dino@apple.com>

Added a smaller version of a screenshot.

blog-files/leaves-screenshot-small.jpg: Added.

16:32 Changeset [38323] by dino@apple.com

2008-11-11 Dean Jackson <dino@apple.com>

Add a bunch of examples for CSS Animation blog draft.

blog-files/bounce.html: Added.
blog-files/bounce.png: Added.
blog-files/leaves-screenshot.jpg: Added.
blog-files/leaves/images/apple-touch-icon.png: Added.
blog-files/leaves/images/backgroundLeaves.jpg: Added.
blog-files/leaves/images/realLeaf1.png: Added.
blog-files/leaves/images/realLeaf2.png: Added.
blog-files/leaves/images/realLeaf3.png: Added.
blog-files/leaves/images/realLeaf4.png: Added.
blog-files/leaves/images/textBackground.png: Added.
blog-files/leaves/index.html: Added.
blog-files/leaves/leaves.css: Added.
blog-files/leaves/leaves.js: Added.
blog-files/pulse.html: Added.
blog-files/pulse.png: Added.

16:32 Changeset [38322] by ggaren@apple.com

2008-11-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

Instead, the caller emits an explicit load or mov instruction, or relies
on implicit knowledge that "this" is already in the first argument slot.
As a result, two operands to op_call are gone: firstArg and thisVal.

SunSpider and v8 tests show no change in bytecode or CTI.

VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions of setting up arguments to op_call, because they're more different than they are the same -- even more so with this patch.

(JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
match op_call anymore.

(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
for changes mentioned above.

VM/CTI.h:

VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.

VM/Machine.cpp: (JSC::Machine::callEval): Updated for new bytecode format of call / construct.

(JSC::Machine::dumpCallFrame):
(JSC::Machine::dumpRegisters): Simplified these debugging functions,
taking advantage of the new call frame layout.

(JSC::Machine::execute): Fixed up the eval version of execute to be
friendlier to calls in the new format.

(JSC::Machine::privateExecute): Implemented the new call format in
bytecode.

(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
call format.

Fixed a latent bug in stack overflow checking that is now hit because
the register layout has changed a bit -- namely: when throwing a stack
overflow exception inside an op_call helper, we need to account for the
fact that the current call frame is only half-constructed, and use the
parent call frame instead.

VM/Machine.h:

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
bytecompiler/CodeGenerator.h: Updated codegen to match the new call format.

parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
parser/Nodes.h: (JSC::ScopeNode::neededConstants): ditto

2008-11-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Updated a test after fixing https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

fast/js/global-recursion-on-full-stack-expected.txt: This test passes a little differently now, because the register layout has changed. Specifically, the stack overflow now happens in the call to f() instead of the initiation of the <script> tag, so it is caught, and it does not log an exception to the console.

16:28 Changeset [38321] by weinig@apple.com

2008-11-11 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
Track CachedScript decoded data

We now track the decoded size of CachedScripts in the Cache allowing
them to accounted for when deciding when to evict data. The decoded
data itself can be evicted when Cache pressure gets high enough through
CachedScript::destroyDecodedData.

loader/CachedResource.h: (WebCore::CachedResource::allClientsRemoved): (WebCore::CachedResource::destroyDecodedData):
loader/CachedScript.cpp: (WebCore::CachedScript::script): (WebCore::CachedScript::data): (WebCore::CachedScript::destroyDecodedData):
loader/CachedScript.h:

15:39 Changeset [38320] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove pointless dependencies on the now-deleted kjs directory and
mentions of it in comments that are no longer relevant.

JavaScriptCore:

ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.

WebCore:

WebCore.pro:
webcore-base.bkl:

WebKit/qt:

WebKit_pch.h:

WebKit/wx:

presets/wxwebkit.bkl:

15:26 Changeset [38319] by adachan@apple.com

Fix: https://bugs.webkit.org/show_bug.cgi?id=22187
Bug 22187: CLEARTYPE_QUALITY flag is not supported on Win2000

Update window versions to correspond to Windows XP.

Reviewed by Steve Falkenburg.

win/tools/vsprops/common.vsprops:

14:45 Changeset [38318] by mitz@apple.com

WebCore:

Reviewed by Adam Roben.

WebCore part of adding a master volume control for media elements in a WebView

WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
dom/Document.cpp: (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page when the media volume is changed. (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows elements to register for a callback when the media volume is changed. (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows elements to unregister for the callback.
dom/Document.h:
dom/Element.h: (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to registerForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to unregisterForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the element's intrinsic volume by the master volume from the page. (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls updateVolume().
html/HTMLMediaElement.h:
page/Page.cpp: (WebCore::Page::Page): Initialize m_mediaVolume to 1. (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on every document in the page when the master volume changes.
page/Page.h: (WebCore::Page::mediaVolume): Added this getter.

WebKit/mac:

Reviewed by Adam Roben.

WebKit/mac part of adding a master volume control for media elements in a WebView

WebView/WebView.mm: (-[WebView setMediaVolume:]): Added. (-[WebView mediaVolume]): Added.
WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Adam Roben.

WebKit/win part of adding a master volume control for media elements in a WebView

Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and mediaVolume().
WebView.cpp: (WebView::setMediaVolume): Added. (WebView::mediaVolume): Added.
WebView.h:

14:31 Changeset [38317] by andersca@apple.com

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Mark Rowe.

Removed invalid bases incorrectly checked-in in r38305.

https://bugs.webkit.org/show_bug.cgi?id=22185

platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.png: Removed.
platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.txt: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.checksum: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.png: Removed.
platform/mac-tiger/fast/text/international/hindi-spacing-expected.txt: Removed.

14:25 Changeset [38316] by mrowe@apple.com

Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
by failure to update all instances of "kjs" to their new locations.

JavaScriptCore.xcodeproj/project.pbxproj:

14:13 Changeset [38315] by ddkilzer@apple.com

2008-11-11 Aaron Golden <agolden@apple.com>

Bug 22134: -[WebHistoryItem dictionaryRepresentation] accesses past the end of a vector

<https://bugs.webkit.org/show_bug.cgi?id=22134>

Reviewed by Geoff Garen.

History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]):

13:49 Changeset [38314] by ap@webkit.org

Rubber-stamped by Adam Roben.

wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter): Fix indentation a little more.

13:11 Changeset [38313] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Clean up EvalCodeCache to match our coding style a bit more.

VM/EvalCodeCache.h: (JSC::EvalCodeCache::get):

12:43 Changeset [38312] by hyatt@apple.com

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=22182

Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.

Reviewed by Adele

platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseDown):

12:06 Changeset [38311] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
<https://bugs.webkit.org/show_bug.cgi?id=22179>

GNUmakefile.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
VM/CodeBlock.h:
VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
VM/Machine.cpp:

11:58 Changeset [38310] by bdakin@apple.com

WebCore:

2008-11-11 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Too much indentation when pasting
quoted paragraphs

This patch re-addresses pasting blockquotes into blockquotes. It
backs out most of revision 38273. 38273 fixed the bug by inserting
the pasted content as a sibling blockquote node to the pre-existing
blockquote node. The problem with that is that by default,
blockquotes have a giant margin, so visually, this can be weird.
This patch instead inserts the pasted content as siblings of the
the content already inside the outer blockquote, and then removes
the blockquote node from the pasted content itself, so that it
doesn't nest itself into the outer blockquote.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Move contains() from Element to Node since there is nothing
Element-specific about it.

dom/Element.cpp:
dom/Element.h:
dom/Node.cpp: (WebCore::Node::contains):
dom/Node.h:

LayoutTests:

2008-11-11 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This is a new test:

editing/pasteboard/paste-blockquote-into-blockquote-3.html: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt: Added.

The results for these tests previously reflected the behavior
implemented in revision 38273. We have since decided that that
behavior is wrong and we changed it with this patch.

platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:

11:50 Changeset [38309] by hyatt@apple.com

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=17997

Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
is a Leopard-only workaround, since the API has been fixed on Snow Leopard.

Reviewed by John Sullivan

platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):

11:41 Changeset [38308] by krit@webkit.org

2008-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Dave Hyatt.

Pattern transform check was too strict for Cg. Scaling can cause a wrong
color on the borders of the scaled object.

Correct expected result of the tests.

fast/canvas/canvas-pattern-transform-expected.txt:
fast/canvas/canvas-pattern-transform.html:
fast/canvas/canvas-pattern-transform.js:
fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt:

11:18 Changeset [38307] by hyatt@apple.com

2008-11-10 David Hyatt <hyatt@apple.com>

Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.

Reviewed by Adam Roben

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

10:31 Changeset [38306] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the 'm_' prefix from the fields of the SwitchRecord struct.

VM/CTI.cpp: (JSC::CTI::privateCompile):
VM/CTI.h: (JSC::SwitchRecord): (JSC::SwitchRecord::SwitchRecord):

10:26 Changeset [38305] by mitz@apple.com

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Removed pixel results in platform/mac-tiger that were only slightly different
(within 1% tolerance) from the platform/mac results.
Removed results in platform/mac-tiger where the results in platform/mac were
also correct for Tiger.
Also updated results in platform/mac-tiger that were out of date.

Made sure every test that has a specific mac-tiger render tree output also has matching images.

(file listing elided)

09:59 Changeset [38304] by darin@apple.com

2008-11-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22160 speculative fix for <rdar://problem/5995450> Nil deref because nextLinePosition (previousLinePosition, too) uses a nil node

editing/visible_units.cpp: (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element to check editingIgnoresContent. It makes sense to use the associated DOM node for this, even in cases of anonymous content, and it avoids the case where element() can be 0. (WebCore::previousLinePosition): Ditto.

09:54 Changeset [38303] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Make asInteger() a static function so that it has internal linkage.

VM/CTI.cpp: (JSC::asInteger):

09:40 Changeset [38302] by krit@webkit.org

2008-11-11 Dirk Schulze <vbs85@gmx.de>

WebCore:

Reviewed by Darin Adler.

Removed default: in applySpreadMethod. This causes the problems
in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
or CSS.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of default spreadMethod on radial gradients.

fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt: Added.
fast/canvas/canvas-radial-gradient-spreadMethod.html: Added.
fast/canvas/canvas-radial-gradient-spreadMethod.js: Added.

05:32 Changeset [38301] by vestbo@webkit.org

2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix crash when rendering the file chooser.
Also proper implementation for multi-selected files.

platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::basenameForWidth):

03:35 Changeset [38300] by krit@webkit.org

2008-11-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Oliver Hunter.

Added test to check behavior on transformations of patterns in canvas.

fast/canvas/canvas-pattern-transform-expected.txt: Added.
fast/canvas/canvas-pattern-transform.html: Added.
fast/canvas/canvas-pattern-transform.js: Added.

03:05 Changeset [38299] by krit@webkit.org

01:51 Changeset [38298] by mjs@apple.com

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)

No perf regression combined with the last patch (each seems like a small regression individually)

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate):
parser/Nodes.h: (JSC::SourceElements::releaseContentsIntoVector):
wtf/Vector.h: (WTF::Vector::shrinkToFit):

01:11 Changeset [38297] by mitz@apple.com

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21821

Remaining set of updated expected pixel results. This includes http/,
media/, plugins/, scrollbars/, tables/, transforms/, transitions/ and
webarchive/.

(file listing elided)

01:10 Changeset [38296] by mjs@apple.com

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

remove inline capacity from declaration stacks (15M savings on membuster test)

No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.

JavaScriptCore.exp:
parser/Nodes.h:

00:06 Changeset [38295] by cwzwarich@webkit.org

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

While r38286 removed the need for the m_callFrame member variable of
CTI, it should be also be removed.

VM/CTI.h:

11/10/08:

23:57 Changeset [38294] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.

VM/CTI.cpp: (JSC::asInteger):
VM/CTI.h:

23:06 Changeset [38293] by slewis@apple.com

2008-11-10 Stephanie Lewis <slewis@apple.com>

Reviewed by Dan Bernstein.

Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.

loader/Cache.cpp: (WebCore::Cache::pruneDeadResources):
platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

22:04 Changeset [38292] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes):

21:55 Changeset [38291] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Make CTI::getConstant() a member function of CodeBlock instead.

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::getConstant):

21:45 Changeset [38290] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Rename CodeBlock::isConstant() to isConstantRegisterIndex().

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CodeBlock.h: (JSC::CodeBlock::isConstantRegisterIndex):
bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

21:40 Changeset [38289] by barraclough@apple.com

non-CTI build fix take 2

21:31 Changeset [38288] by barraclough@apple.com

non-CTI build fix

21:22 Changeset [38287] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the unused labels member variable of CodeBlock.

VM/CodeBlock.h:
VM/LabelID.h: (JSC::LabelID::setLocation):

21:09 Changeset [38286] by barraclough@apple.com

2008-11-10 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.

VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines):
VM/CTI.h: (JSC::CTI::compile): (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition): (JSC::CTI::compileCTIMachineTrampolines): (JSC::CTI::compilePatchGetArrayLength):
VM/Machine.cpp: (JSC::Machine::initialize): (JSC::Machine::~Machine): (JSC::Machine::execute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_lazyLinkCall):
VM/Machine.h:
masm/X86Assembler.h: (JSC::JITCodeBuffer::isAligned): (JSC::X86Assembler::): (JSC::X86Assembler::align):
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):

19:51 Changeset [38285] by mjs@apple.com

2008-11-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Make Vector::clear() release the Vector's memory (1MB savings on membuster) https://bugs.webkit.org/show_bug.cgi?id=22170

wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as well as size, otherwise shrinking capacity to 0 can fail to reset the capacity and thus cause a future crash. (WTF::Vector::~Vector): Shrink size not capacity; we only need to call destructors, the buffer will be freed anyway. (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0). (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where the size is greater than the new capacity, to work with types that have no default constructor.

19:38 Changeset [38284] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Split multiple definitions into separate lines.

VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp):

17:26 Changeset [38283] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move renewGState to the base class.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView renewGState]):
Plugins/WebNetscapePluginView.mm:

17:23 Changeset [38282] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move start, stop and all the related methods down to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm:

17:13 Changeset [38281] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowFocusChanged:]): (-[WebBaseNetscapePluginView createPlugin]): (-[WebBaseNetscapePluginView loadStream]): (-[WebBaseNetscapePluginView destroyPlugin]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView windowFocusChanged:]):

16:51 Changeset [38280] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView shouldStop]): (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView stop]):

16:38 Changeset [38279] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Fix Tiger build.

Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):

16:29 Changeset [38278] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView focusChanged]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView focusChanged]): (-[WebNetscapePluginView tellQuickTimeToChill]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView viewWillMoveToWindow:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView pluginView:receivedError:]): (-[WebNetscapePluginView pluginViewFinishedLoading:]): (-[WebNetscapePluginView inputContext]): (-[WebNetscapePluginView hasMarkedText]): (-[WebNetscapePluginView insertText:]): (-[WebNetscapePluginView markedRange]): (-[WebNetscapePluginView selectedRange]): (-[WebNetscapePluginView setMarkedText:selectedRange:]): (-[WebNetscapePluginView unmarkText]): (-[WebNetscapePluginView validAttributesForMarkedText]): (-[WebNetscapePluginView attributedSubstringFromRange:]): (-[WebNetscapePluginView characterIndexForPoint:]): (-[WebNetscapePluginView doCommandBySelector:]): (-[WebNetscapePluginView firstRectForCharacterRange:]): (-[WebNetscapePluginView _viewHasMoved]): (-[WebNetscapePluginView _redeliverStream]):

15:43 Changeset [38277] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move timer handling code down to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView startTimers]): (-[WebBaseNetscapePluginView restartTimers]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
WebView/WebHTMLView.mm: (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):

14:59 Changeset [38276] by andersca@apple.com

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add WebHostedNetscapePluginView to the project.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move a bunch of methods and ivars up to WebBaseNetscapePluginView.

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView finalize]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView webView]): (-[WebBaseNetscapePluginView currentWindow]):
Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView sendActivateEvent:]): (-[WebNetscapePluginView restartTimers]): (-[WebNetscapePluginView setHasFocus:]): (-[WebNetscapePluginView mouseDown:]): (-[WebNetscapePluginView mouseUp:]): (-[WebNetscapePluginView mouseEntered:]): (-[WebNetscapePluginView mouseExited:]): (-[WebNetscapePluginView handleMouseMoved:]): (-[WebNetscapePluginView mouseDragged:]): (-[WebNetscapePluginView scrollWheel:]): (-[WebNetscapePluginView keyUp:]): (-[WebNetscapePluginView keyDown:]): (-[WebNetscapePluginView flagsChanged:]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView isStarted]): (-[WebNetscapePluginView dealloc]): (-[WebNetscapePluginView finalize]): (-[WebNetscapePluginView drawRect:]): (-[WebNetscapePluginView windowBecameKey:]): (-[WebNetscapePluginView preferencesHaveChanged:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebNetscapePluginView _viewHasMoved]):

14:27 Changeset [38275] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Mark Rowe.

Add a WebHostedNetscapePluginView class.

Plugins/WebHostedNetscapePluginView.h: Added.
Plugins/WebHostedNetscapePluginView.mm: Added.

Plugins/WebNetscapePluginPackage.h: Use the right define.

Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Check for WebBaseNetscapePluginView.

(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.

WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): Use WebBaseNetscapePluginView.

(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.

(WebFrameLoaderClient::createPlugin):
Get the right class.

WebKitPrefix.h: Prefix the #define with WTF_.

WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): Check for WebBaseNetscapePluginView.

WebView/WebView.mm: Remove an unnecessary include.

14:12 Changeset [38274] by aroben@apple.com

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com

WebCore:

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Reviewed by Dan Bernstein.

Test: fast/css/outline-invert-assertion.html

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::systemColor): If we can't determine a good Win32 system color to use, defer to RenderTheme instead of asserting. This matches what RenderThemeMac does.

LayoutTests:

Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.

Reviewed by Dan Bernstein.

fast/css/outline-invert-assertion-expected.txt: Added.
fast/css/outline-invert-assertion.html: Added.

13:51 Changeset [38273] by bdakin@apple.com

WebCore:

2008-11-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting

Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from -> source and to -> destination. (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-10 Beth Dakin <bdakin@apple.com>

Rubber stamped by Justin Garcia.

New tests for <rdar://problem/4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting

editing/pasteboard/paste-blockquote-into-blockquote-2.html: Added.
editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.checksum: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.png: Added.
platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt: Added.

Test with new results because of this patch:

platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:

13:47 Changeset [38272] by mrowe@apple.com

Commit the current configuration of build.webkit.org.

13:45 Changeset [38271] by mrowe@apple.com

Commit the current configuration of build.webkit.org.

13:33 Changeset [38270] by andersca@apple.com

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
Plugins/WebNetscapePluginPackage.h:
Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): (-[WebNetscapePluginView _printedPluginBitmap]):

13:00 Changeset [38269] by andersca@apple.com

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

Plugins/WebBaseNetscapePluginView.h: Added.
Plugins/WebBaseNetscapePluginView.mm: Added. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView handleMouseMoved:]):
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView cut:]): (-[WebNetscapePluginView copy:]): (-[WebNetscapePluginView paste:]): (-[WebNetscapePluginView selectAll:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):

12:25 Changeset [38268] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<https://bugs.webkit.org/show_bug.cgi?id=22162>

There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot):

12:20 Changeset [38267] by andersca@apple.com

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Rename WebBaseNetscapePluginView to WebNetscapePluginView.

StringsNotToBeLocalized.txt:
WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Rename WebBaseNetscapePluginView to WebNetscapePluginView.

Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin):
Plugins/WebBaseNetscapePluginView.h: Removed.
Plugins/WebBaseNetscapePluginView.mm: Removed.
Plugins/WebNetscapePluginEventHandler.h: (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
Plugins/WebNetscapePluginEventHandlerCarbon.h:
Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
Plugins/WebNetscapePluginEventHandlerCocoa.h:
Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm. (+[WebNetscapePluginView setCurrentPluginView:]): (+[WebNetscapePluginView currentPluginView]): (-[WebNetscapePluginView loadPluginRequest:]):
Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]):
Plugins/npapi.mm: (pluginViewForInstance): (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged):
WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
WebView/WebView.mm:

10:38 Changeset [38266] by aroben@apple.com

Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable

WebCore:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.

Reviewed by Anders Carlsson.

WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel environment variable, parse its value as a hexadecimal number, and turn the channel on/off based on whether the mask bit is set. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each logging channel in turn.

WebKit/win:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Reviewed by Anders Carlsson.

WebView.cpp: (WebView::initWithFrame): Call WebCore's InitializeLoggingChannelsIfNecessary.

10:17 Changeset [38265] by cwzwarich@webkit.org

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):

09:06 Changeset [38264] by darin@apple.com

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

fix https://bugs.webkit.org/show_bug.cgi?id=22103 Changing fonts in preferences does not immediately update WebViews

This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.

dom/Document.cpp: (WebCore::Document::shouldScheduleLayout): Removed the part of this function that duplicated what's already in FrameView::needsLayout, since the copy here left out a few key things. For example, it didn't handle the fact that "needs reapply styles" counts as needing layout.

page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called FrameView::invalidate before. There were two things wrong with that. 1) It requested that the entire view repaint even if the style change didn't necessitate that. 2) FrameView::invalidate no longer causes any repainting at all in certain cases, because of Hyatt's changes to how widgets and the host window are involved in the repainting process. So call FrameView::scheduleRelayout instead, which is more precisely what we want and need here.

page/FrameView.cpp: (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here so that Document::shouldScheduleLayout doesn't have to replicate the logic that's in needsLayout and can instead rely on the fact that it was already called. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting in this function.

09:03 Changeset [38263] by darin@apple.com

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

speculative fix for <rdar://problem/5557243> crashes in Safari at WebCore::HTMLSelectElement::updateListBoxSelection + 280

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): Check index against size of vector before indexing into the vector.

07:55 Changeset [38262] by vestbo@webkit.org

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Distinguish between building from trunk and as part of Qt

07:42 Changeset [38261] by darin@apple.com

2008-11-10 Darin Adler <darin@apple.com>

fix more of https://bugs.webkit.org/show_bug.cgi?id=21400 "Edit" links for patches in comments, review queue, review emails should be replaced by "Review Patch" links

globals.pl: Fix cases that are automatically generated, such as links in comments in bugs.

template/en/custom/attachment/created.html.tmpl: Fix the link on the "I just created an attachment" page.

template/en/custom/request/queue.html.tmpl: Fix the link in the queue page.

07:31 Changeset [38260] by darin@apple.com

2008-11-10 Darin Adler <darin@apple.com>

template/en/custom/request/email.txt.tmpl: Send review links instead of edit links when flags are set on a bug.

07:03 Changeset [38259] by ap@webkit.org

Reviewed by Adam Roben.

A few coding style fixes for AVLTree.

wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards. (WTF::AVLTree::Iterator::start_iter): Fixed indentation

runtime/JSArray.cpp: Added "using namepace WTF".

06:37 Changeset [38258] by hausmann@webkit.org

2008-11-10 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

To fit Qt API, scroll offset is a QPoint instead of a QSize.

Api/qwebframe.cpp: (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
Api/qwebframe.h:

03:46 Changeset [38257] by hausmann@webkit.org

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Make tests/auto/qwebframe compile on Qt/Mac.

03:46 Changeset [38256] by hausmann@webkit.org

2008-11-10 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed qdoc warnings by supplying function documentation.

03:45 Changeset [38255] by hausmann@webkit.org

2008-11-10 Tobias Koenig <tobias.koenig@trolltech.com>

Reviewed by Simon Hausmann.

Removed old and stale prf file that breaks the MingW build.

03:45 Changeset [38254] by hausmann@webkit.org

2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix QtWebkit build failure on arm.

pen.widthF() is a qreal, which means it's a float on arm.

03:45 Changeset [38253] by hausmann@webkit.org

2008-11-10 Kavindra Palaraja <kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Clarify QWebFrame/View::setHTML docs with regards to relative URLs

03:45 Changeset [38252] by hausmann@webkit.org

2008-11-10 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Simon Hausmann

Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.

03:45 Changeset [38251] by hausmann@webkit.org

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.

This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.

11/09/08:

22:26 Changeset [38250] by cwzwarich@webkit.org

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Speculatively fix the non-AllInOne build.

runtime/NativeErrorConstructor.cpp:

17:28 Changeset [38249] by darin@apple.com

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Tim Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=22149 remove unused code from the parser

AllInOneFile.cpp: Removed nodes2string.cpp.
GNUmakefile.am: Ditto.
JavaScriptCore.exp: Ditto.
JavaScriptCore.pri: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
JavaScriptCoreSources.bkl: Ditto.

VM/CodeBlock.h: Added include.

VM/Machine.cpp: (JSC::Machine::execute): Use the types from

DeclarationStacks as DeclarationStacks

rather than Node:: since "Node" really has little to do with it.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Ditto.

jsc.cpp: (Options::Options): Removed prettyPrint option. (runWithScripts): Ditto. (printUsageStatement): Ditto. (parseArguments): Ditto. (jscmain): Ditto.

parser/Grammar.y: Removed use of obsolete ImmediateNumberNode.

parser/Nodes.cpp: (JSC::ThrowableExpressionData::emitThrowError): Use inline functions instead of direct member access for ThrowableExpressionData values. (JSC::BracketAccessorNode::emitCode): Ditto. (JSC::DotAccessorNode::emitCode): Ditto. (JSC::NewExprNode::emitCode): Ditto. (JSC::EvalFunctionCallNode::emitCode): Ditto. (JSC::FunctionCallValueNode::emitCode): Ditto. (JSC::FunctionCallResolveNode::emitCode): Ditto. (JSC::FunctionCallBracketNode::emitCode): Ditto. (JSC::FunctionCallDotNode::emitCode): Ditto. (JSC::PostfixResolveNode::emitCode): Ditto. (JSC::PostfixBracketNode::emitCode): Ditto. (JSC::PostfixDotNode::emitCode): Ditto. (JSC::DeleteResolveNode::emitCode): Ditto. (JSC::DeleteBracketNode::emitCode): Ditto. (JSC::DeleteDotNode::emitCode): Ditto. (JSC::PrefixResolveNode::emitCode): Ditto. (JSC::PrefixBracketNode::emitCode): Ditto. (JSC::PrefixDotNode::emitCode): Ditto. (JSC::ThrowableBinaryOpNode::emitCode): Ditto. (JSC::InstanceOfNode::emitCode): Ditto. (JSC::ReadModifyResolveNode::emitCode): Ditto. (JSC::AssignResolveNode::emitCode): Ditto. (JSC::AssignDotNode::emitCode): Ditto. (JSC::ReadModifyDotNode::emitCode): Ditto. (JSC::AssignBracketNode::emitCode): Ditto. (JSC::ReadModifyBracketNode::emitCode): Ditto. (JSC::statementListEmitCode): Take a const StatementVector instead of a non-const one. Also removed unused statementListPushFIFO. (JSC::ForInNode::emitCode): Inline functions instead of member access. (JSC::ThrowNode::emitCode): Ditto. (JSC::EvalNode::emitCode): Ditto. (JSC::FunctionBodyNode::emitCode): Ditto. (JSC::ProgramNode::emitCode): Ditto.

parser/Nodes.h: Removed unused includes and forward declarations. Removed Precedence enum. Made many more members private instead of protected or public. Removed unused NodeStack typedef. Moved the VarStack and FunctionStack typedefs from Node to ScopeNode. Made Node::emitCode pure virtual and changed classes that don't emit any code to inherit from ParserRefCounted rather than Node. Moved isReturnNode from Node to StatementNode. Removed the streamTo, precedence, and needsParensIfLeftmost functions from all classes. Removed the ImmediateNumberNode class and make NumberNode::setValue nonvirtual.

parser/nodes2string.cpp: Removed.

17:19 Changeset [38248] by cwzwarich@webkit.org

2008-11-09 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 19541: Null pointer in showModalDialog()
<https://bugs.webkit.org/show_bug.cgi?id=19541>

Add null frame->page() checks to JSDOMWindowBase::canShowModalDialog()
and JSDOMWindowBase::canShowModalDialogNow()C

WebCore:

bindings/js/JSDOMWindowBase.cpp: (WebCore::canShowModalDialog): (WebCore::canShowModalDialogNow):

LayoutTests:

fast/dom/null-page-show-modal-dialog-crash-expected.txt: Added.
fast/dom/null-page-show-modal-dialog-crash.html: Added.

17:04 Changeset [38247] by darin@apple.com

JavaScriptCore:

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig and Maciej Stachowiak.
Includes some work done by Chris Brichford.

fix https://bugs.webkit.org/show_bug.cgi?id=14886 Stack overflow due to deeply nested parse tree doing repeated string concatentation

Test: fast/js/large-expressions.html

1) Code generation is recursive, so takes stack proportional to the complexity

of the source code expression. Fixed by setting an arbitrary recursion limit
of 10,000 nodes.

2) Destruction of the syntax tree was recursive. Fixed by introducing a

non-recursive mechanism for destroying the tree.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): Initialize depth to 0. (JSC::CodeGenerator::emitThrowExpressionTooDeepException): Added. Emits the code to throw a "too deep" exception.
bytecompiler/CodeGenerator.h: (JSC::CodeGenerator::emitNode): Check depth and emit an exception if we exceed the maximum depth.

parser/Nodes.cpp: (JSC::NodeReleaser::releaseAllNodes): Added. To be called inside node destructors to avoid recursive calls to destructors for nodes inside this one. (JSC::NodeReleaser::release): Added. To be called inside releaseNodes functions. Also added releaseNodes functions and calls to releaseAllNodes inside destructors for each class derived from Node that has RefPtr to other nodes. (JSC::NodeReleaser::adopt): Added. Used by the release function. (JSC::NodeReleaser::adoptFunctionBodyNode): Added.

parser/Nodes.h: Added declarations of releaseNodes and destructors in all classes that needed it. Eliminated use of ListRefPtr and releaseNext, which are the two parts of an older solution to the non-recursive destruction problem that works only for lists, whereas the new solution works for other graphs. Changed ReverseBinaryOpNode to use BinaryOpNode as a base class to avoid some duplicated code.

LayoutTests:

2008-11-09 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

fast/loader/javascript-url-encoding-2-expected.txt:
fast/loader/javascript-url-encoding-2.html:

16:22 Changeset [38246] by darin@apple.com

2008-11-09 Darin Adler <darin@apple.com>

try to fix Windows build

platform/graphics/Color.cpp: For some reason MSVC doesn't follow the rules about needed a separate definition for static const integer data members. Until I get to the bottom of this, put the definitions inside an ifdef.

12:19 Changeset [38245] by darin@apple.com

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

fix https://bugs.webkit.org/show_bug.cgi?id=15063 <rdar://problem/5452227> REGRESSION (r25151): Switching to a tab waiting for first data does not clear the window

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted): Added comments, and got rid of a local variable to make this code match the code in the function below more closely. (WebFrameLoaderClient::provisionalLoadStarted): Added comments.

WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Improved comment.

WebView/WebFrameView.mm: (-[WebFrameView _scrollView]): Tweaked formatting. (-[WebFrameView initWithFrame:]): Ditto. (-[WebFrameView setFrameSize:]): Added a comment and tweaked formatting. (-[WebFrameView viewDidMoveToWindow]): Added. This is the change that fixes the bug. Calls setDrawsBackground:YES as appropriate since moving the view out of the window to switch to another view disrupts the special technique for showing the old page during the start of loading. This is the identical reason for the setFrameSize: method above, and the code is almost the same.

11:50 Changeset [38244] by ddkilzer@apple.com

BUILD FIX: Qt build broke after r38235.

Added HAVE(ACCESSIBILITY) header guards to platform implementation
source files.

page/gtk/AccessibilityObjectAtk.cpp: Added HAVE(ACCESSIBILITY) guards.
page/gtk/AccessibilityObjectWrapperAtk.cpp: Ditto.
page/qt/AccessibilityObjectQt.cpp: Ditto.
page/win/AccessibilityObjectWin.cpp: Ditto.
page/wx/AccessibilityObjectWx.cpp: Ditto.

11:08 Changeset [38243] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22104
Javascript URL percent encoding/decoding broken by some characters

Test: fast/loader/javascript-url-encoding-2.html

platform/KURL.cpp: (WebCore::encodeRelativeString): Don't try to break down javascript URLs.

10:20 Changeset [38242] by darin@apple.com

2008-11-09 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed and tweaked by Darin Adler.

platform/graphics/Color.cpp: Added definitions for the static data members in this class. Static data members need a definition, even when they are the simple integer constant kind that can be initialized in the header.

07:50 Changeset [38241] by darin@apple.com

2008-11-09 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

fix https://bugs.webkit.org/show_bug.cgi?id=22142 a few fast/canvas tests use non-standard HTML wrappers but don't need to

fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Fixed spelling error: "gradieints".

fast/canvas/gradient-addColorStop-with-invalid-color.html: Regenerated with make-js-test-wrappers script; removes the canvas element that was in here.
fast/canvas/linearGradient-infinite-values.html: Ditto.
fast/canvas/radialGradient-infinite-values.html: Ditto.

fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Fixed spelling error and changed code to use createElement to make a canvas element rather than using getElementById to find an existing canvas element.
fast/canvas/resources/linearGradient-infinite-values.js: Ditto.
fast/canvas/resources/radialGradient-infinite-values.js: Ditto.

04:56 Companies and Organizations that have contributed to WebKit edited by ddkilzer@webkit.org

Added reference to KSVG2 (diff)

02:36 Companies and Organizations that have contributed to WebKit edited by staikos@kde.org

(diff)

00:04 Companies and Organizations that have contributed to WebKit edited by mjs@apple.com

(diff)

00:02 Companies and Organizations that have contributed to WebKit created by mjs@apple.com

11/08/08:

23:36 WikiStart edited by mjs@apple.com

(diff)

20:11 Changeset [38240] by antti@apple.com

WebCore:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.

Fix https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

Reset text decoder on flush so it does not pass through the BOM when it is reused.

Test: fast/encoding/css-cached-bom.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::flush):

LayoutTests:

2008-11-08 Antti Koivisto <antti@apple.com>

Reviewed by Sam Weinig.

Test for https://bugs.webkit.org/show_bug.cgi?id=22141
REGRESSION: Safari error page is not fully styled when loaded from cache

fast/encoding/css-cached-bom.html: Added.
fast/encoding/css-cached-bom-expected.txt: Added.
fast/encoding/resources/css-cached-bom-frame.html: Added.
fast/encoding/resources/utf-16-little-endian.css: Added.

19:14 Changeset [38239] by kevino@webkit.org

Reviewed by Mark Rowe.

Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
it was causing these errors to end up in the page's text representation.

18:35 Changeset [38238] by kevino@webkit.org

wx build fixes after addition of JSCore parser and bycompiler dirs.

17:09 Changeset [38237] by simon.fraser@apple.com

2008-11-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21906

Override addFocusRingRects() in RenderTextControl to avoid
the RenderFlow behavior of recursing on descendent renderers.
RenderTextControl should only ever need a simple focus rect.

This fixes focus ring issues with transforms on text controls.

Test: fast/transforms/transformed-focused-text-input.html

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects):
rendering/RenderTextControl.h:

16:33 Changeset [38236] by timothy@apple.com

Make sure the icon thumbnail width/height is at least 1px in
the Web Inspector's resource panel.

<rdar://problem/5988888>

Reviewed by Tim Hatcher.

inspector/front-end/inspector.css:

11:42 Changeset [38235] by ddkilzer@apple.com

Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled

<https://bugs.webkit.org/show_bug.cgi?id=22137>

Reviewed by Darin Adler.

WebCore:

page/AccessibilityObject.h: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment): Provide a default implementation when HAVE(ACCESSIBILITY) is false.
page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
page/mac/AccessibilityObjectMac.mm: Ditto.
page/mac/AccessibilityObjectWrapper.mm: Ditto.

WebKit/mac:

WebView/WebFrame.mm: (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY) is false.

11:12 Changeset [38234] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

WebCore part of adding WebPreferences for controlling databases and local storage

WebCore.base.exp: Exported Settings::setDatabasesEnabled() and Settings::setLocalStorageEnabled().
page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage is disabled in settings. (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases are disabled in settings.
page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_databasesEnabled and m_localStorageEnabled. (WebCore::Settings::setDatabasesEnabled): Added. (WebCore::Settings::setLocalStorageEnabled): Added.
page/Settings.h: (WebCore::Settings::databasesEnabled): Added. (WebCore::Settings::localStorageEnabled): Added.

WebKit/mac:

Reviewed by Darin Adler.

WebKit/mac part of adding WebPreferences for controlling databases and local storage

WebView/WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebView/WebPreferences.mm: (+[WebPreferences initialize]): Made databases and local storage enabled by default. (-[WebPreferences databasesEnabled]): Added. (-[WebPreferences setDatabasesEnabled:]): Added. (-[WebPreferences localStorageEnabled]): Added. (-[WebPreferences setLocalStorageEnabled:]): Added.
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Transfer the databases and local storage preferences to WebCore settings.

WebKit/win:

Reviewed by Darin Adler.

WebKit/win part of adding WebPreferences for controlling databases and local storage

Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled, databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey and WebKitLocalStorageEnabledPreferenceKey.
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Made databases and local storage enabled by default. (WebPreferences::setDatabasesEnabled): Added. (WebPreferences::databasesEnabled): Added. (WebPreferences::setLocalStorageEnabled): Added. (WebPreferences::localStorageEnabled): Added.
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged): Transfer the databases and local storage preferences to WebCore settings.

05:57 Changeset [38233] by staikos@webkit.org

Just adjusting email address in changelog.

11/07/08:

14:29 Changeset [38232] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

Fix build with bleeding edge GTK+ versions. GTK+ and other libraries
now require that only their top-level header file is included.

Patch tested and still builds fine with older GTK+ versions (back to
2.8).

Future WebKit GTK+ contributions are required to adhere to this
policy.

platform/gtk/FileSystemGtk.cpp:
platform/gtk/KeyEventGtk.cpp:
platform/gtk/MouseEventGtk.cpp:
platform/gtk/WheelEventGtk.cpp:
platform/gtk/gtkdrawing.h:
plugins/gtk/gtk2xtbin.c:
plugins/gtk/gtk2xtbin.h:

13:34 Changeset [38231] by andersca@apple.com

2008-11-07 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker

Explicitly initialize the NPDrawingModelCoreAnimation.

bridge/npapi.h:

13:15 Changeset [38230] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21801: REGRESSION (r37821): YUI date formatting JavaScript puts the letter 'd' in place of the day
<https://bugs.webkit.org/show_bug.cgi?id=21801>

Fix the constant register check in the 'typeof' optimization in
CodeGenerator, which was completely broken after r37821.

JavaScriptCore:

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):

LayoutTests:

fast/js/resources/typeof-constant-string.js: Added.
fast/js/typeof-constant-string-expected.txt: Added.
fast/js/typeof-constant-string.html: Added.

12:41 Changeset [38229] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22129: Move CTI::isConstant() to CodeBlock
<https://bugs.webkit.org/show_bug.cgi?id=22129>

VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
VM/CTI.h:
VM/CodeBlock.h: (JSC::CodeBlock::isConstant):

11:35 Changeset [38228] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

autotools fix. Always use the configured perl binary (which may be
different to the one in $PATH) when generating sources.

11:17 Changeset [38227] by simon.fraser@apple.com

2008-11-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22122

Use a stack-based object to simplify the pushLayoutState/popLayoutState
code. LayoutStateMaintainer either pushes in the constructor, or allows
an explicit push() later. Both cases require an explicit pop().

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
rendering/RenderView.h: (WebCore::LayoutStateMaintainer::LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::~LayoutStateMaintainer): (WebCore::LayoutStateMaintainer::pop): (WebCore::LayoutStateMaintainer::push): (WebCore::LayoutStateMaintainer::didPush):

10:07 Changeset [38226] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

Change grammar.cpp to Grammar.cpp and grammar.h to Grammar.h in several
build scripts.

DerivedSources.make:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCoreSources.bkl:

09:48 Changeset [38225] by alp@webkit.org

2008-11-07 Alp Toker <alp@nuanti.com>

More grammar.cpp -> Grammar.cpp build fixes.

AllInOneFile.cpp:
GNUmakefile.am:

07:39 Changeset [38224] by vestbo@webkit.org

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Fix the QtWebKit build on Mac

07:01 Changeset [38223] by vestbo@webkit.org

2008-11-07 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Don't allow Phonon's invisible video widget to keep the app running

06:47 Changeset [38222] by vestbo@webkit.org

2008-11-07 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Added an option to allow printing the background color and images.
Mostly reworked from a patch by Holger.
This setting is enabled by default.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

06:11 Changeset [38221] by hausmann@webkit.org

2008-11-07 Simon Hausmann <hausmann@webkit.org>

Fix the build on case-sensitive file systems. grammar.y was renamed to
Grammar.y but Lexer.cpp includes grammar.h. The build bots didn't
notice this change because of stale files.

03:32 Changeset [38220] by hausmann@webkit.org

2008-11-07 Henrik Hartz <henrik.hartz@nokia.com>

Reviewed by Simon Hausmann.

Fix valgrind warning about uninitialized lastStop variable.

01:22 Changeset [38219] by cwzwarich@webkit.org

2008-11-07 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Rename the m_nextGlobal, m_nextParameter, and m_nextConstant member
variables of CodeGenerator to m_nextGlobalIndex, m_nextParameterIndex,
and m_nextConstantIndex respectively. This is to distinguish these from
member variables like m_lastConstant, which are actually RefPtrs to
Registers.

bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::addGlobalVar): (JSC::CodeGenerator::allocateConstants): (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::addParameter): (JSC::CodeGenerator::addConstant):
bytecompiler/CodeGenerator.h:

01:22 Changeset [38218] by ap@webkit.org

Reviewed by Maciej Stachowiak.

Fix layout test brokenness following r38211.

page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey): Restore old Shift key behavior. We ignore Shift key state when matching access keys (which matches neither IE nor Firefox), and this patch made WebKit behave like Firefox inadvertently. This may or may not be a good thing, but it's certainly not something that should change by accident.

01:20 Applications using WebKit edited by barbarosa100@hotmail.com