Timeline


and

11/14/08:

23:43 Changeset [38419] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22259: Make all opcodes use eax as their final result register
<https://bugs.webkit.org/show_bug.cgi?id=22259>

Change one case of op_add (and the corresponding slow case) to use eax
rather than edx. Also, change the order in which the two results of
resolve_func and resolve_base are emitted so that the retrieved value is
put last into eax.

This gives no performance change on SunSpider or the V8 benchmark suite
when run in either harness.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
20:47 Changeset [38418] by bolsinga@apple.com
  • 80 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

20:24 Changeset [38417] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • attempt to fix the Qt build
  • platform/qt/Localizations.cpp: (WebCore::contextMenuItemTagTextDirectionMenu): Added. Maybe this string needs to go somewhere else in addition to here.
20:19 Changeset [38416] by mitz@apple.com
  • 2 edits in trunk/WebKit/win
  • try to fix the Windows build
  • WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagTextDirectionMenu): Added.
19:25 Changeset [38415] by kevino@webkit.org
  • 4 edits in trunk

wx build (and buildbot) fix.

18:51 Changeset [38414] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Geoff has this wacky notion that emitGetArg and emitPutArg should be related to
doing the same thing. Crazy.


Rename the methods for accessing virtual registers to say 'VirtualRegister' in the
name, and those for setting up the arguments for CTI methods to contain 'CTIArg'.

  • VM/CTI.cpp: (JSC::CTI::emitGetVirtualRegister): (JSC::CTI::emitGetVirtualRegisters): (JSC::CTI::emitPutCTIArgFromVirtualRegister): (JSC::CTI::emitPutCTIArg): (JSC::CTI::emitGetCTIArg): (JSC::CTI::emitPutCTIArgConstant): (JSC::CTI::emitPutVirtualRegister): (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileCTIMachineTrampolines):
  • VM/CTI.h:
17:37 Changeset [38413] by bolsinga@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Antti Koivisto

Fix potential build break by adding StdLibExtras.h

17:33 Changeset [38412] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Generate less code for the slow cases of op_call and op_construct.
https://bugs.webkit.org/show_bug.cgi?id=22272

1% progression on v8 tests.

  • VM/CTI.cpp: (JSC::CTI::emitRetrieveArg): (JSC::CTI::emitNakedCall): (JSC::CTI::compileOpCallInitializeCallFrame): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileCTIMachineTrampolines):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::getCallLinkInfoReturnLocation): (JSC::CodeBlock::getCallLinkInfo):
  • VM/Machine.cpp: (JSC::Machine::Machine): (JSC::Machine::cti_vm_dontLazyLinkCall): (JSC::Machine::cti_vm_lazyLinkCall):
  • VM/Machine.h:
17:29 Changeset [38411] by bolsinga@apple.com
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=21810
Remove use of static C++ objects that are destroyed at exit time (destructors)

Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
exit-time destructor. Update code that was changed to fix this issue that ran
into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
in gcc build 5465). Also typdefs for template types needed to be added in some
cases so the type could make it through the macro successfully.

Basically code of the form:
static T m;
becomes:
DEFINE_STATIC_LOCAL(T, m, ());

Also any code of the form:
static T& m = *new T;
also becomes:
DEFINE_STATIC_LOCAL(T, m, ());

15:50 Changeset [38410] by mitz@apple.com
  • 31 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • <rdar://problem/6234307> Support action methods for setting and clearing character-level directionality
  • WebCore part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
  • WebCore.base.exp: Exported WebCore::Settings::setTextDirectionSubmenuInclusionBehavior().
  • editing/ApplyStyleCommand.cpp: (StyleChange::init): Changed to always include the direction property in the result if the unicode-bidi property is included. (ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Added. Finds the highest ancestor of the given node that establishes bidi embedding. If that embedding agrees with the given allowed direction, finds the second-highest embedding ancestor. Splits all nodes through that ancestor. If the highest embedding ancestor did not need to be split, it is returned. (ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Added. Removes bidi embedding attributes and styles from all ancestors of the given node up to its enclosing block or the given node. (ApplyStyleCommand::applyInlineStyle): Added code to handle the unicode-bidi property. Applying style the includes this property involves removing all bidi embedding in effect, except for one-level embedding that agrees with the desired embedding, then applying the desired embedding where it is not already in effect. (ApplyStyleCommand::applyInlineStyleToRange): Factored out from applyInlineStyle(). (ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): Added. Removed the "dir" attribute if necessary and the element if it becomes an unstyled style span. (ApplyStyleCommand::removeCSSStyle): Changed to remove the direction property when removing the unicode-bidi property. (ApplyStyleCommand::removeInlineStyle): Added a call to removeHTMLBidiEmbeddingStyle().
  • editing/ApplyStyleCommand.h:
  • editing/Editor.cpp: (Editor::textDirectionForSelection): Added. Returns the character-level writing direction of the selection if it is uniform and simple (at most one level of embedding). (Editor::hasBidiSelection): Added. Returns true if the selection lies entirely within a single block, and that block has direction:rtl or contains any inline boxes with non-zero bidi embedding level.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (stateTextWritingDirection): Added this helper function for deciding the state of Text Direction submenu items. (executeMakeTextWritingDirectionLeftToRight): Added. Applies "unicode-bidi: embed; direction: ltr;". (executeMakeTextWritingDirectionNatural): Added. Applies "unicode-bidi: normal;" (executeMakeTextWritingDirectionRightToLeft): Added. Applies "unicode-bidi: embed; direction: rtl;". (stateTextWritingDirectionLeftToRight): Added. (stateTextWritingDirectionNatural): Added. (stateTextWritingDirectionRightToLeft): Added. (createCommandMap): Added "MakeTextWritingDirectionLeftToRight", "MakeTextWritingDirectionNatural", and "MakeTextWritingDirectionRightToLeft".
  • editing/InsertTextCommand.cpp: (InsertTextCommand::input): Added code to maintain the unicode-bidi and direction properties in the typing style. Even if they have the same values as the computed style at the caret, they need to be included in the typing style so that inserted text will not inherit any nested embedding.
  • page/ContextMenuController.cpp: (ContextMenuController::contextMenuItemSelected): Added calls to the editor for the text direction menu items.
  • page/Frame.cpp (Frame::computeAndSetTypingStyle): Added code to maintain the unicode-bidi and direction properties in the typing style.
  • page/Settings.cpp: (Settings::setTextDirectionSubmenuInclusionBehavior): Added this setter.
  • page/Settings.h: Added a TextDirectionSubmenuInclusionBehavior enum, an m_textDirectionSubmenuInclusionBehavior member, and accessors.
  • page/mac/WebCoreViewFactory.h:
  • platform/ContextMenu.cpp: (WebCore::createAndAppendTextDirectionSubMenu): Added. (ContextMenu::populate): Added the Text Direction submenu item based on the inclusion behavior and the existence of a bidi selection. (ContextMenu::checkOrEnableIfNeeded): Added code for the text direction menu items.
  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h: Declared contextMenuItemTagTextDirectionMenu().
  • platform/mac/LocalizedStringsMac.mm: Defined contextMenuItemTagTextDirectionMenu().
  • rendering/RenderBlock.cpp: (RenderBlock::containsNonZeroBidiLevel): Added.
  • rendering/RenderBlock.h:

WebKit:

Reviewed by Darin Adler.

  • part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
  • English.lproj/Localizable.strings: Added the Text Direction submenu title.

WebKit/mac:

Reviewed by Darin Adler.

  • <rdar://problem/6234333> Implement action methods for setting and clearing character-level directionality
  • part of <rdar://problem/6234337> Add a Text Direction menu to the default context menu when appropriate
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagTextDirectionMenu]): Added.
  • WebView/WebFrame.mm: (core): Added a convertor from WebTextDirectionSubmenuInclusionBehavior to WebCore::TextDirectionSubmenuInclusionBehavior.
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: Added makeTextWritingDirectionLeftToRight:, makeTextWritingDirectionNatural: and makeTextWritingDirectionRightToLeft: using the WEBCORE_COMMAND macro.
  • WebView/WebPreferenceKeysPrivate.h: Added WebKitTextDirectionSubmenuInclusionBehaviorPreferenceKey.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Set the default Text Direction submenu inclusion behavior to never include. (-[WebPreferences textDirectionSubmenuInclusionBehavior]): Added this accessor. (-[WebPreferences setTextDirectionSubmenuInclusionBehavior:]): Ditto.
  • WebView/WebPreferencesPrivate.h: Defined the WebTextDirectionSubmenuInclusionBehavior enum and declared accessors.
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Added code to transfer the Text Direction submenu inclusion behavior preference to WebCore settings.
15:48 Changeset [38409] by bolsinga@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22264
Need to update to latest Geolocation spec (13 November 2008)


Update to new error code constants and values.

  • page/Geolocation.cpp: Use new named ErrorCode enums (WebCore::Geolocation::GeoNotifier::timerFired): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition):
  • page/PositionError.h: Have ErrorCode enum names match new error constant names and values (WebCore::PositionError::):
  • page/PositionError.idl: Add new named error constants
15:37 Changeset [38408] by bdakin@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

2008-11-14 Beth Dakin <bdakin@apple.com>

Reviewed by Justin Garcia.

Fix (again) for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This patch goes back to Justin's original approach to fix this bug,
written in revision 38273. That fix was mostly rolled out by
revision 38310 because of styling issues created by the addition of
extra blockquote nodes. This patch again goes back to Justin's
original fix because of cases we discovered the newer fix could not
possibly cover. This version of the patch minimizes the styling
issues of extra blockquotes by opting into the merge start code.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::hasMatchingQuoteLevel): We want shouldMergeStart to return true when the quoting level of the end of the inserted content matches the quoting level of the end of the existing content. (WebCore::ReplaceSelectionCommand::shouldMergeStart): Now calls hasMatchingQuoteLevel (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-14 Beth Dakin <bdakin@apple.com>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

New test:

  • editing/pasteboard/paste-blockquote-into-blockquote-4.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-4-expected.txt: Added.

Changes results for existing tests:

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:
15:36 Changeset [38407] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-13 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=22269
Reduce PropertyMap usage

From observation of StructureID statistics, it became clear that many
StructureID's were not being used as StructureIDs themselves, but rather
only being necessary as links in the transition chain. Acknowledging this
and that PropertyMaps stored in StructureIDs can be treated as caches, that
is that they can be reconstructed on demand, it became clear that we could
reduce the memory consumption of StructureIDs by only keeping PropertyMaps
for the StructureIDs that need them the most.

The specific strategy used to reduce the number of StructureIDs with
PropertyMaps is to take the previous StructureIDs PropertyMap when initially
transitioning (addPropertyTransition) from it and clearing out the pointer
in the process. The next time we need to do the same transition, for instance
repeated calls to the same constructor, we use the new addPropertyTransitionToExistingStructure
first, which allows us not to need the PropertyMap to determine if the property
exists already, since a transition to that property would require it not already
be present in the StructureID. Should there be no transition, the PropertyMap
can be constructed on demand (via materializePropertyMap) to determine if the put is a
replace or a transition to a new StructureID.

Reduces memory use on Membuster head test (30 pages open) by ~15MB.

  • JavaScriptCore.exp:
  • runtime/JSObject.h: (JSC::JSObject::putDirect): First use addPropertyTransitionToExistingStructure so that we can avoid building the PropertyMap on subsequent similar object creations.
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry): Add version of constructor which takes all values to be used when lazily building the PropertyMap.
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): Add statistics on the number of StructureIDs with PropertyMaps. (JSC::StructureID::StructureID): Rename m_cachedTransistionOffset to m_offset (JSC::isPowerOf2): (JSC::nextPowerOf2): (JSC::sizeForKeyCount): Returns the expected size of a PropertyMap for a key count. (JSC::StructureID::materializePropertyMap): Builds the PropertyMap out of its previous pointer chain. (JSC::StructureID::addPropertyTransitionToExistingStructure): Only transitions if there is a an existing transition. (JSC::StructureID::addPropertyTransition): Instead of always copying the ProperyMap, try and take it from it previous pointer. (JSC::StructureID::removePropertyTransition): Simplify by calling toDictionaryTransition() to do transition work. (JSC::StructureID::changePrototypeTransition): Build the PropertyMap if necessary before transitioning because once you have transitioned, you will not be able to reconstruct it afterwards as there is no previous pointer, pinning the ProperyMap as well. (JSC::StructureID::getterSetterTransition): Ditto. (JSC::StructureID::toDictionaryTransition): Pin the PropertyMap so that it is not destroyed on further transitions. (JSC::StructureID::fromDictionaryTransition): We can only transition back from a dictionary transition if there are no deleted offsets. (JSC::StructureID::addPropertyWithoutTransition): Build PropertyMap on demands and pin. (JSC::StructureID::removePropertyWithoutTransition): Ditto. (JSC::StructureID::get): Build on demand. (JSC::StructureID::createPropertyMapHashTable): Add version of create that takes a size for on demand building. (JSC::StructureID::expandPropertyMapHashTable): (JSC::StructureID::rehashPropertyMapHashTable): (JSC::StructureID::getEnumerablePropertyNamesInternal): Build PropertyMap on demand.
  • runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): Account for StructureIDs without PropertyMaps. (JSC::StructureID::isEmpty): Ditto. (JSC::StructureID::materializePropertyMapIfNecessary): (JSC::StructureID::get): Build PropertyMap on demand
14:58 Changeset [38406] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-14 Alp Toker <alp@nuanti.com>

GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.

Fixes Debian bug #505723
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
13:41 Changeset [38405] by eric@webkit.org
  • 10 edits
    3 deletes in trunk/WebCore

Reviewed by Eric Seidel.

Made SVGResourceClipper platform independent.
https://bugs.webkit.org/show_bug.cgi?id=21444

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipPath):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipPath):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::clipPath):
  • svg/graphics/SVGResourceClipper.cpp: (WebCore::SVGResourceClipper::applyClip):
  • svg/graphics/cairo/SVGResourceClipperCairo.cpp: Removed.
  • svg/graphics/cg/SVGResourceClipperCg.cpp: Removed.
  • svg/graphics/qt/SVGResourceClipperQt.cpp: Removed.
13:34 Changeset [38404] by antti@apple.com
  • 3 edits in trunk/WebCore

2008-11-14 Antti Koivisto <antti@apple.com>

Reviewed by Anders Carlsson.

Combine loadFrameRequestWithFormState to loadFrameRequestWithFormAndValues.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
  • loader/FrameLoader.h:
12:02 Changeset [38403] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-11-14 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Remove unneeded forward declaration.

  • plugins/Plugin.h:
11:32 Changeset [38402] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-14 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm: (-[WebFrameView becomeFirstResponder]): Moved the acceptsFirstResponder special case inside the if statement so it won't run in the "selecting previous" case. Also removed the "just before shipping Tiger" code that doesn't need to be here any more.
11:29 Changeset [38401] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Added some basic unit tests for the public database API.

11:01 Changeset [38400] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-14 Simon Hausmann <hausmann@webkit.org>

Fix the Qt build, add missing export macros for the new classes.

10:53 Changeset [38399] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-14 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22251
HTMLCanvasElement.cpp unnecessarily includes runtime/Interpreter.h

  • html/HTMLCanvasElement.cpp:
10:52 Changeset [38398] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-14 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

<https://bugs.webkit.org/show_bug.cgi?id=21500>

JavaScriptCore build with -O3 flag instead of -O2 (gcc).
2.02% speedup on SunSpider (Qt-port on Linux)
1.10% speedup on V8 (Qt-port on Linux)
3.45% speedup on WindScorpion (Qt-port on Linux)

10:44 Changeset [38397] by hausmann@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-14 Krishna <krishnamurty.podipireddy@nokia.com>

Reviewed by Simon Hausmann.

Fix hanging DRT with Qt.

https://bugs.webkit.org/show_bug.cgi?id=22209

10:40 Changeset [38396] by hausmann@webkit.org
  • 11 edits
    6 adds in trunk

WebCore:

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add new files from the Qt port to the build.

  • WebCore.pro:

WebKit/qt:

2008-10-24 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Adding public API to provide access to the security origin
(QWebSecurityOrigin) and the databases used for the offline
storage (QWebDatabase).

In addition QWebSettings gains configuration functions for
enabling/disabling offline storage, web application cache
and DOM local storage.

This commits lands the core feature(s), the unit tests and the
documentation are going to follow in the comming days/weeks.

Note: The API is not frozen yet.

10:39 Changeset [38395] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Make it possible to get the cache directory set in the application
cache storage.

10:39 Changeset [38394] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2008-11-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Make it possible to get the cache directory set in the application
cache storage.

10:30 Changeset [38393] by justin.garcia@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-11-14 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages


When applying block styles, we would add block properties to the body element, and Mail's
Make Plain Text feature isn't equipped to remove those. This could have been fixed on our side,
but this change has the advantage that it fixes the bug on Tiger, where Mail does not plan future updates.


We have code that puts the paragraphs that we're operating on into blocks of their own before
adding or removing block properties from the blocks that enclose them. We need to run this code
when the enclosing block is the body element.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Added, moved code from moveParagraphContents to here. (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Renamed some variables for clarity. Added a few comments. Fixed bug by not bailing out when the block about to be used is the body element.
  • editing/CompositeEditCommand.h:

LayoutTests:

2008-11-14 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4230923> "Make Plain Text" doesn't reset text alignment in single paragraph messages

  • editing/style/4230923-expected.txt: Added.
  • editing/style/4230923.html: Added.
09:54 Changeset [38392] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>

Reviewed by Darin Adler.

Compile fix for RVCT.

In reality, it is two fixes:

  1. Remove typename. I believe typename can only be used when the named type depends on the template parameters, which it doesn't in this case, so I think this is more correct.
  2. Replace ::iterator scope with specialized typedef. This is to work around a bug in RVCT.

https://bugs.webkit.org/show_bug.cgi?id=22260

09:53 Changeset [38391] by hausmann@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-14 Kristian Amlie <kristian.amlie@trolltech.com>

Reviewed by Darin Adler.

Compile fix for WINSCW.

This fix doesn't protect against implicit conversions from bool to
integers, but most likely that will be caught on another platform.

https://bugs.webkit.org/show_bug.cgi?id=22260

09:49 Changeset [38390] by cwzwarich@webkit.org
  • 11 edits in trunk

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22245: Move wtf/dtoa.h into the WTF namespace
<https://bugs.webkit.org/show_bug.cgi?id=22245>

Move wtf/dtoa.h into the WTF namespace from the JSC namespace. This
introduces some ambiguities in name lookups, so I changed all uses of
the functions in wtf/dtoa.h to explicitly state the namespace.

JavaScriptCore:

  • JavaScriptCore.exp:
  • parser/Lexer.cpp: (JSC::Lexer::lex):
  • runtime/InitializeThreading.cpp:
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::parseInt):
  • runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): (JSC::numberProtoFuncToExponential):
  • runtime/UString.cpp: (JSC::concatenate): (JSC::UString::from): (JSC::UString::toDouble):
  • wtf/dtoa.cpp:
  • wtf/dtoa.h:

WebCore:

  • platform/text/String.cpp: (WebCore::charactersToDouble):
03:21 Changeset [38389] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Make sure Qt scrollbars follow the style with regard to context menus

03:20 Changeset [38388] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Make scrollbar look active when the window is active on Qt/Mac

00:21 Changeset [38387] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-14 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 22257: Enable redundant read optimizations for results generated by compileBinaryArithOp()
<https://bugs.webkit.org/show_bug.cgi?id=22257>

This shows no change in performance on either SunSpider or the V8
benchmark suite, but it removes an ugly special case and allows for
future optimizations to be implemented in a cleaner fashion.

This patch was essentially given to me by Gavin Barraclough upon my
request, but I did regression and performance testing so that he could
work on something else.

  • VM/CTI.cpp: (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate): Move the final result to eax if it is not already there. (JSC::CTI::compileBinaryArithOp): Remove the killing of the final result register that disables the optimization.

11/13/08:

20:39 Changeset [38386] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

Fix the build.

Don't use NSPICTPboardType on systems where it is deprecated. The system will take care of converting
from this format to a format that we can understand.

  • WebCoreSupport/WebPasteboardHelper.mm:

(WebPasteboardHelper::insertablePasteboardTypes):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

20:29 Changeset [38385] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Fix Bug 22244: Webkit nightly builds crash with Safari 3.2

<https://bugs.webkit.org/show_bug.cgi?id=22244>

r36652 added IWebViewPrivate::clearMainFrameName into the middle of
the IWebViewPrivate interface, which modifies the part of the
IWebViewPrivate vtable that Safari 3.2 relies on.

Reviewed by Dan Bernstein.

  • Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end of the interface.
20:26 Changeset [38384] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

Reviewed by Adam Roben.

Add a basic Scons-based build system for building
Chromium-Mac WebCore.
https://bugs.webkit.org/show_bug.cgi?id=21991

The build currently fails due to missing files from our
platform directory (platform skia and platform chromium)
I will be sending those up shortly in separate patches.
I expect it will be a while before our WebCore build links.

  • SConstruct: Added.
  • WebCore.scons: Added.
20:26 Changeset [38383] by eric@webkit.org
  • 1 edit
    2 adds in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add a Scons-based build system for building
the Chromium-Mac build of JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=21991

19:54 Changeset [38382] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Add PLATFORM(CHROMIUM) to the "we don't use cairo" blacklist
until https://bugs.webkit.org/show_bug.cgi?id=22250 is fixed.

  • wtf/Platform.h:
19:45 Changeset [38381] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

In r38375 the 'jsc' shell was changed to improve teardown on quit. The
main() function in jsc.cpp uses Structured Exception Handling, so Visual
C++ emits a warning when destructors are used.


In order to speculatively fix the Windows build, this patch changes that
code to use explicit pointer manipulation and locking rather than smart
pointers and RAII.

  • jsc.cpp: (main):
17:54 Changeset [38380] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-13 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22248
AtomicString.cpp uses JSC types outside of #if USE(JSC)

  • platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
17:40 Changeset [38379] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22246: Get arguments for opcodes together to eliminate more redundant memory reads
<https://bugs.webkit.org/show_bug.cgi?id=22246>

It is common for opcodes to read their first operand into eax and their
second operand into edx. If the value intended for the second operand is
in eax, we should first move eax to the register for the second operand
and then read the first operand into eax.

This is a 0.5% speedup on SunSpider and a 2.0% speedup on the V8
benchmark suite when measured using the V8 harness.

  • VM/CTI.cpp: (JSC::CTI::emitGetArgs): (JSC::CTI::compileOpStrictEq): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
14:54 Changeset [38378] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Safari 3.2

Tag the Safari 3.2 release.

This release consists of JavaScriptCore-x525.26.2, JavaScriptGlue-x525.26.2, WebCore-x525.26.6 and WebKit-x525.26.2.

14:27 Changeset [38377] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22238: Avoid unnecessary reads of temporaries when the target machine register is not eax
<https://bugs.webkit.org/show_bug.cgi?id=22238>

Enable the optimization of not reading a value back from memory that we
just wrote when the target machine register is not eax. In order to do
this, the code generation for op_put_global_var must be changed to
read its argument into a register before overwriting eax.

This is a 0.5% speedup on SunSpider and shows no change on the V8
benchmark suite when run in either harness.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::privateCompileMainPass):
13:04 Changeset [38376] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-11-13 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=18620
Long hang under TextIterator::advance() when loading http://www.lsvd.de/

A huge section at the beginning of this document is invisible. As we iterate through it,
we create VisiblePositions unnecessarily.

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Don't proceed to VisiblePosition creation if m_node is unrendered or invisible. The answers wouldn't have much meaning and would be wasteful. Also fixed some comments to reflect the fact that this function isn't specifically about emitting a newline.
11:50 Changeset [38375] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Perform teardown in the 'jsc' shell in order to suppress annoying and
misleading leak messages. There is still a lone JSC::Node leaking when
quit() is called, but hopefully that can be fixed as well.

  • jsc.cpp: (functionQuit): (main):
10:49 Changeset [38374] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

2008-11-13 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Sam Weinig.

Remove unused or unnecessary code from AnimationBase class.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::AnimationBase): (WebCore::AnimationBase::playStatePlaying):
  • page/animation/AnimationBase.h:
10:35 Changeset [38373] by sullivan@apple.com
  • 8 edits
    1 add
    1 delete in trunk/WebKit

WebKit:

2008-11-13 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

  • English.lproj/Localizable.strings: updated for these changes


  • StringsNotToBeLocalized.txt: removed unused exception

WebKit/mac:

2008-11-13 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6361578> Web Kit UI strings: a few edits

Reviewed by Tim Hatcher

  • Misc/WebKitErrors.m: "Cannot show content with specified mime type" -> "Content with specified MIME type can't be shown" "Cannot show URL" -> "The URL can't be shown" "Cannot find plug-in" -> "The plug-in can't be found" "Cannot load plug-in" -> "The plug-in can't be loaded"


  • Panels/English.lproj/WebAuthenticationPanel.nib/classes.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/info.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Added.
  • Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Removed. Changed placeholder fine print in the nib to match one of the two strings it might be replaced by. This automagically updated the nib to a newer format, hence the objects -> keyedobjects change. I could have changed the placeholder fine print to be empty but this lets localizers understand the dialog layout better.


  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): "you need to log in" -> "you must log in" "Your log-in information" -> "Your login information" "The name or password entered" -> "The user name or password you entered" "Please try again." -> "Make sure you're entering them correctly, and then try again."
10:09 Changeset [38372] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-13 Mike Pinkerton <pinkerton@chromium.org>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22087
Need correct platform defines for Mac Chromium

Set the appropriate platform defines for Mac Chromium, which is
similar to PLATFORM(MAC), but isn't.

  • wtf/Platform.h:
07:20 Changeset [38371] by vestbo@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2008-11-12 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Inital implementation of PluginPackage and PluginView for Mac NPAPI support in WebCore

Currently only used by QtWebKit. See also:

https://bugs.webkit.org/show_bug.cgi?id=21427

07:20 Changeset [38370] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-12 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Mention the color role change (r38331) in the API doc.

  • Api/qwebpage.cpp:
04:53 Changeset [38369] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-11-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • remove immediate checks from native codegen for known non-immediate cases like "this"


~.5% speedup on v8 benchmarks


In the future we can extend this model to remove all sorts of
typechecks based on local type info or type inference.


I also added an assertion to verify that all slow cases linked as
many slow case jumps as the corresponding fast case generated, and
fixed the pre-existing cases where this was not true.


  • VM/CTI.cpp: (JSC::CTI::emitJumpSlowCaseIfNotJSCell): (JSC::CTI::linkSlowCaseIfNotJSCell): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::compileBinaryArithOpSlowCase): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
03:26 Changeset [38368] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-11-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 21943: Avoid needless reads of temporary values in CTI code
<https://bugs.webkit.org/show_bug.cgi?id=21943>

If an opcode needs to load a virtual register and a previous opcode left
the contents of that virtual register in a machine register, use the
value in the machine register rather than getting it from memory.

In order to perform this optimization, it is necessary to know the
jump tagets in the CodeBlock. For temporaries, the only problematic
jump targets are binary logical operators and the ternary conditional
operator. However, if this optimization were to be extended to local
variable registers as well, other jump targets would need to be
included, like switch statement cases and the beginnings of catch
blocks.

This optimization also requires that the fast case and the slow case
of an opcode use emitPutResult() on the same register, which was chosen
to be eax, as that is the register into which we read the first operand
of opcodes. In order to make this the case, we needed to add some mov
instructions to the slow cases of some instructions.

This optimizaton is not applied whenever compileBinaryArithOp() is used
to compile an opcode, because different machine registers may be used to
store the final result. It seems possible to rewrite the code generation
in compileBinaryArithOp() to allow for this optimization.

This optimization is also not applied when generating slow cases,
because some fast cases overwrite the value of eax before jumping to the
slow case. In the future, it may be possible to apply this optimization
to slow cases as well, but it did not seem to be a speedup when testing
an early version of this patch.

This is a 1.0% speedup on SunSpider and a 6.3% speedup on the V8
benchmark suite.

  • VM/CTI.cpp: (JSC::CTI::killLastResultRegister): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::emitGetCTIParam): (JSC::CTI::emitGetFromCallFrameHeader): (JSC::CTI::emitPutResult): (JSC::CTI::emitCTICall): (JSC::CTI::CTI): (JSC::CTI::compileOpCall): (JSC::CTI::compileOpStrictEq): (JSC::CTI::emitSlowScriptCheck): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompilePatchGetArrayLength):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::isTemporaryRegisterIndex):
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitLabel):

11/12/08:

23:35 Changeset [38367] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-12 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22216

  • Scripts/build-webkit: Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
23:32 Changeset [38366] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22200
Crash when close event is dispatched to MessagePort due to document destruction

Test: fast/events/message-port-onclose.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::contextDestroyed): Don't dispatch close event, even though HTML5 currently says that we should. It is not right for GC to have observable effects.
23:27 Changeset [38365] by ap@webkit.org
  • 24 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22203
Implement Worker messaging

No test cases included, because this functionality is disabled by default.

The implementation is known to still have many race condition, but works quite well for
testing.

  • WebCore.xcodeproj/project.pbxproj: Added WorkerTask.{h,cpp}.
  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Re-worded comments a little. (WebCore::markCrossHeapDependentObjectsForContext): Existing cross-heap GC protocol was incorrect, changed it to a much simpler (but still incorrect) version.
  • dom/WorkerTask.cpp: Added. (WebCore::WorkerTask::~WorkerTask):
  • dom/WorkerTask.h: Added. Tasks posted to workers implement this new interface.
  • bindings/js/JSDedicatedWorkerCustom.cpp: (WebCore::JSDedicatedWorker::mark): (WebCore::JSDedicatedWorker::connect):
  • dom/DedicatedWorker.h:
  • dom/DedicatedWorker.idl: Auto-generate event listener attributes. Renamed startConversation() to connect(), tracking WHATWG discussions.
  • dom/DedicatedWorker.cpp: (WebCore::WorkerConnectTask::WorkerConnectTask): A task that performs worker-side connect() operations. (WebCore::DedicatedWorker::DedicatedWorker): Initialize WorkerThread pointer. (WebCore::DedicatedWorker::connect): Connect() creates a pair of entangled ports, and posts one to worker. Since message port registration in ScriptExecutionContext is not thread safe, this port starts with a null context pointer. (WebCore::DedicatedWorker::notifyFinished): Since Worker methods should work immediately after creation, we have to queue tasks until after a WorkerThread object is created. Then we forward all queued tasks to its queue.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toWorkerContext):
  • dom/EventTarget.h:
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added cases for WorkerContext, which is now an EventTarget, too.
  • bindings/js/JSWorkerContext.h: Added JSWorkerContext::put() to make onconnect settable.
  • bindings/js/JSWorkerContext.cpp: (WebCore::JSWorkerContext::mark): Mark event listeners. (WebCore::JSWorkerContext::createPrototype): Fixed a typo, use the right StructureID. (WebCore::JSWorkerContext::put): Implemented. (WebCore::jsWorkerContextPrototypeFunctionAddEventListener): Added an EventTarget implementation. (WebCore::jsWorkerContextPrototypeFunctionRemoveEventListener): Ditto. (WebCore::jsWorkerContextPrototypeFunctionDispatchEvent): Ditto. (WebCore::jsWorkerContextOnconnect): Added. (WebCore::setJSWorkerContextOnconnect): Added.
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): Made it actually work by adding necessary setup.
  • bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::initScriptIfNeeded): Check the right variable - it is the wrapper that may not be initialized yet.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): Assert being called from the correct thread, as active DOM object tracking is not thread safe.
  • dom/ScriptExecutionContext.h: Added a Task interface and a postTask() method, to be used for asynchronously executing tasks in context's thread.
  • dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask): Changed from a Timer to a Task (WebCore::ScriptExecutionContext::ScriptExecutionContext): Removed m_firedMessagePortTimer. It was an optimization that couldn't be easily preserved without introducing race conditions in multithreading case. (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): Use postTask(). (WebCore::ScriptExecutionContext::dispatchMessagePortEvents): Added a comment explaining why it's OK to not ref() ports in a frozen copy. (WebCore::ScriptExecutionContext::createdMessagePort): Assert that we're not being called from a wrong thread. (WebCore::ScriptExecutionContext::destroyedMessagePort): Ditto. (WebCore::ScriptExecutionContextTaskTimer): Part of ScriptExecutionContext::Task implementation - use Timer if posting from main thread to main thread. (WebCore::ScriptExecutionContextTaskWorkerTask): Another part - use WorkerTask if posting to a worker. (WebCore::PerformTaskContext::PerformTaskContext): Finally, use callOnMainThread() if posting to main thread from a secondary one. (WebCore::performTask): A helper function for callOnMainThread(). (WebCore::ScriptExecutionContext::postTask): Use one of the above implementations.
  • dom/MessagePort.h: Fixed message queue to keep EventData pointers - otherwise, we would ref/deref EventData::message from different threads, which is not allowed.
  • dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask): Use a task instead of a timer to work across threads. (WebCore::MessagePort::EventData::create): Updated for EventData being refcountable now. (WebCore::MessagePort::EventData::EventData): Ditto. (WebCore::MessagePort::MessagePort): ScriptExecutionContext is now allowed to be null at first, because we need to create ports for posting to other threads, and it is not possible to register in a context from another thread. (WebCore::MessagePort::clone): Always create ports with null contexts - it is now message receiver's job to set the context. (WebCore::MessagePort::postMessage): Enable posting to ports that are not attached to any context yet. (WebCore::MessagePort::startConversation): Ditto. Data port is always posted unattached. (WebCore::MessagePort::contextDestroyed): Assert that we had a context. (WebCore::MessagePort::attachToContext): Called when receiving a data port to register in context. (WebCore::MessagePort::scriptExecutionContext): Moved from header, as the function is virtual. (WebCore::MessagePort::dispatchMessages): Attach data port to receiving context. Use postTask(). (WebCore::MessagePort::queueCloseEvent): Use postTask(). (WebCore::MessagePort::hasPendingActivity): Reworded comment a little. As mentioned above, MessagePort cross-heap GC is still quite wrong.
  • dom/WorkerContext.h: Made WorkerContext an event target, added onconnect attribute.
  • dom/WorkerContext.cpp: Keep a pointer to WorkerThread. It is only used for debug assertions now, but there is no harm in tracking it in release builds, too.
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): WorkerThread is refcountable, construct with create(). (WebCore::WorkerThread::workerThread): Implemented a message loop.
  • dom/WorkerThread.h: (WebCore::WorkerThread::threadID): Also only used for assertions. (WebCore::WorkerThread::messageQueue): Return a reference to queue, so clients can post to it.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): MessagePort::clone() no longer takes a context, as it always sets it to null. (WebCore::DOMWindow::postMessageTimerFired): Attach data port to receiving context.
23:17 Changeset [38364] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-12 Dirk Schulze <vbs85@gmx.de>

WebCore:

Reviewed Darin Adler.

use strokeColor.alpha() instead of fillColor.alpha()
on GraphicsContext::strokePath()

[Canvas] Transparent fillStyle stops line rendering
https://bugs.webkit.org/show_bug.cgi?id=21888

Test: fast/canvas/canvas-stroke-empty-fill.html

  • ChangeLog:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokePath):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of canvas.stroke() on transparent fillStyle()

  • fast/canvas/canvas-stroke-empty-fill-expected.txt: Added.
  • fast/canvas/canvas-stroke-empty-fill.html: Added.
  • fast/canvas/canvas-stroke-empty-fill.js: Added.
23:17 Changeset [38363] by slewis@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-12 Stephanie Lewis <slewis@apple.com>

Fix Mac build.

  • Panels/WebAuthenticationPanel.m:
22:08 Changeset [38362] by slewis@apple.com
  • 2 edits in trunk/WebCore

2008-11-12 Stephanie <slewis@apple.com>

Reviewed by Mark Rowe.

Fix context leak in XSLStyleSheets.
See bug https://bugs.webkit.org/show_bug.cgi?id=15715

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString):
20:47 Changeset [38361] by sullivan@apple.com
  • 5 edits in trunk/WebKit

WebKit:

2008-11-12 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • English.lproj/Localizable.strings:
  • StringsNotToBeLocalized.txt: updated for this change

WebKit/mac:

2008-11-12 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/3839110> Authentication dialogs talk about passwords being sent "in the clear"

Reviewed by Tim Hatcher

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]): use "unencrypted" instead of "in the clear". Also, use the "Your log-in information will be sent securely" version when the receiving server is https, regardless of whether it uses basic or digest authentication.
20:26 Changeset [38360] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <alp@nuanti.com>

autotools: List web worker-related headers needed for a successful
build. distcheck is passing again with this change.

  • GNUmakefile.am:
19:57 Changeset [38359] by mrowe@apple.com
  • 4 edits in tags/Safari-6528.4.3

Versioning.

19:57 Changeset [38358] by mrowe@apple.com
  • 2 edits in tags/Safari-6528.4.3/WebKit/mac

Merge r37827.

19:39 Changeset [38357] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4.3

New tag.

18:30 Changeset [38356] by alp@webkit.org
  • 4 edits in trunk

2008-11-12 Alp Toker <alp@nuanti.com>

autotools build system fix-up only. Add FloatQuad.h to the source
lists and sort them.

18:04 Changeset [38355] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-12 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • WebView/WebFrameView.mm: (-[WebFrameView viewDidMoveToWindow]): Add missing null check.
17:41 Changeset [38354] by mitz@apple.com
  • 5 edits
    40 adds in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.4.11 PowerPC + r38347.
https://bugs.webkit.org/show_bug.cgi?id=21821

Checked-in specific reference images for pixel tests that are valid on Tiger but fail
because difference with reference image due to text rendering is greater than 1.0%

  • platform/mac-tiger/svg/carto.net: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/mac-tiger/svg/carto.net/selectionlist-expected.png: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/feComponentTransfer-Gamma-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-02-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-align-04-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-text-03-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.png: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.checksum: Added.
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum: Added.
  • platform/mac-tiger/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.

svg/batik/paints/gradientLimit.svg is rendering different on Tiger and Leopard
https://bugs.webkit.org/show_bug.cgi?id=22219

  • platform/mac-tiger/svg/batik: Added.
  • platform/mac-tiger/svg/batik/paints: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.checksum: Added.
  • platform/mac-tiger/svg/batik/paints/gradientLimit-expected.png: Added.

svg/custom/mask-excessive-malloc.svg is failing on Tiger
https://bugs.webkit.org/show_bug.cgi?id=22218

  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum: Added.
  • platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.png: Added.

svg/W3C-SVG-1.1/pservers-grad-17-b.svg is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=22220

  • platform/mac-leopard/svg: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:

svg/custom/foreign-object-skew.svg is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=22221

  • platform/mac-leopard/svg/custom: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/foreign-object-skew-expected.png: Added.
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
17:32 Changeset [38353] by simon.fraser@apple.com
  • 17 edits
    4 adds in trunk

2008-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=22212

Rename absoluteOutlineBox() to absoluteOutlineBounds(), to indicate that
it may be the bounding outline box of a transformed element, and fix it
to respect transforms by mapping the outline box to an absolute quad and
taking the enclosing rect.

RenderBox::localToAbsoluteQuad() can no longer assert that there is no
LayoutState, but LayoutState cannot be used during quad mapping (it knows
nothing about transforms).

Finally, fix a bug in RenderBox::localToAbsoluteQuad() which was getting
borderTopExtra() from the object, rather than its container (as localToAbsolute()
does).

Test: fast/repaint/transform-absolute-child.html

17:22 Changeset [38352] by ggaren@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

dyslexics untie\!

17:20 Changeset [38351] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Geoffrey Garen <ggaren@apple.com>

Roll in r38322, onw that test failures have been fixed.


  • fast/js/global-recursion-on-full-stack-expected.txt:
16:51 Changeset [38350] by jchaffraix@webkit.org
  • 6 edits in branches/XBL2/WebCore

2008-11-12 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22133: [XBL] Add shorter method to get the global XBLBindingManager

Renamed XBBindingManager::sharedInstance() to bindingManager().

Suggested by Eric Seidel.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings):
  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector): (WebCore::Document::addBindingSheet): (WebCore::Document::removeBindingSheet):
  • dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::addBinding): (WebCore::Element::removeBinding): (WebCore::Element::hasBinding):
  • xbl/XBLBindingManager.cpp: (WebCore::bindingManager):
  • xbl/XBLBindingManager.h:
16:48 Changeset [38349] by ggaren@apple.com
  • 11 edits in trunk/JavaScriptCore

2008-11-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed https://bugs.webkit.org/show_bug.cgi?id=22192
+37 failures in fast/profiler


along with Darin's review comments in
https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot

  • VM/Machine.cpp: (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since functions are better than macros.
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Ensure that the function register is preserved if profiling is enabled, since the profiler uses that register.
  • runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation, because I had a hard time understanding what "throwReturnAddress" meant.
16:44 Changeset [38348] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-12 Alp Toker <alp@nuanti.com>

Build fixes for r38346. FloatQuad.cpp is missing:

1) #include "config.h"
2) #include <algorithm> for various mathematical definitions it uses.

  • platform/graphics/FloatQuad.cpp:
16:24 Changeset [38347] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Skip fast/repaint/body-background-image.html test as it is not reliable.

https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/Skipped:
15:43 Changeset [38346] by simon.fraser@apple.com
  • 41 edits
    2 adds in trunk/WebCore

2008-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=21942
https://bugs.webkit.org/show_bug.cgi?id=18557

Add methods which can be used to map renderer-local rectangles
to quads in absolute coordinates, taking transforms into account:

localToAbsoluteQuad() converts a local rect into an absolute quad.
collectAbsoluteLineBoxQuads() is an analogue of addLineBoxRects()

that works with quads.

absoluteQuads() is an analogue of absoluteRects(), for quads.

Use the quad methods to fix the inspector highlight for transformed
elements.

15:04 Changeset [38345] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-12 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix stupid bug.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]):
14:53 Changeset [38344] by mitz@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2008-11-12 Dan Bernstein <mitz@apple.com>

  • remove an empty directory
  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.
13:54 Changeset [38343] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix Bug 22178: Build errors in WebKit Cairo port

<https://bugs.webkit.org/show_bug.cgi?id=22178>

Reviewed by Mark Rowe.

  • platform/graphics/cairo/PatternCairo.cpp: Correct build error under Visual Studio. (WebCore::Pattern::createPlatformPattern):
13:49 Changeset [38342] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix a typo in the include path for the Release_Cairo configuration

  • WebCore.vcproj/WebCore.vcproj: Fixed "caro" -> "cairo" typo.
13:02 Changeset [38341] by sfalken@apple.com
  • 1 edit in trunk/WebKit/win/WebKitPrefix.cpp

Touch precompiled header wrapper to fix build.

12:44 Changeset [38340] by mitz@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac/fast

Set svn:mime-type to image/png on .png files that did not have it

12:28 Changeset [38339] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2008-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=17840
Patch 2

Code cleanup in RenderBox::computeAbsoluteRepaintRect().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:22 Changeset [38338] by simon.fraser@apple.com
  • 3 edits
    8 adds in trunk

2008-11-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=17840

Fix repainting when the transform on a positioned element changes.
In computeAbsoluteRepaintRect(), add the offsets due to relative positioning,
and being in a positioned container after applying the transform to the local
rect.

Tests: fast/repaint/transform-absolute-in-positioned-container.html

fast/repaint/transform-relative-position.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
12:08 Changeset [38337] by justin.garcia@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2008-11-12 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted


We don't want to merge into a block if it will mean changing the quote level of content after deleting
selections that contain a whole number paragraphs plus a line break, since it is unclear to most users
that such a selection actually ends at the start of the next paragraph. Instead we want to completely
remove the selected paragraph(s) and all evidence of the first one's quote level. This matches TextEdit behavior
for indented paragraphs.


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not try to merge after the deletion. Instead try and prune the start block or blocks if they've been emptied so that we remove evidence of the deleted paragraphs' quote level. (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary. Also make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection started on, instead of one higher.
  • editing/DeleteSelectionCommand.h:
  • editing/htmlediting.cpp: (WebCore::numEnclosingMailBlockquotes): Added.
  • editing/htmlediting.h:

LayoutTests:

2008-11-12 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5495723> Selecting and deleting quoted text quotes other text
<rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted

  • editing/deleting/5495723-expected.txt: Added.
  • editing/deleting/5495723.html: Added.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Change demonstrates that we now behave correctly when pressing delete when the caret is just after empty quoted paragraphs.
11:40 Changeset [38336] by sfalken@apple.com
  • 1 edit in trunk/WebCore/WebCorePrefix.cpp

Touch precompiled header wrapper to try and fix build.

10:35 Changeset [38335] by mitz@apple.com
  • 50 edits in trunk/LayoutTests

2008-11-12 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Dan Bernstein.

Updated reference images so that all pixel tests now "pass" on 10.5.5 Intel + r38318.
https://bugs.webkit.org/show_bug.cgi?id=21821

Removed empty directory.

  • platform/mac-leopard/http: Removed.
  • platform/mac-leopard/http/tests: Removed.
  • platform/mac-leopard/http/tests/security: Removed.
  • platform/mac-leopard/http/tests/security/dataURL: Removed.

Test doesn't repaint entire view so result is corrupted by previous test
https://bugs.webkit.org/show_bug.cgi?id=21916

  • platform/mac/Skipped:

Test is passing but original reference image was invalid.

  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:

Invalid image tiling
https://bugs.webkit.org/show_bug.cgi?id=21915

  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:

SVG not rendering
https://bugs.webkit.org/show_bug.cgi?id=21910

  • platform/mac/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-2-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-3-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-4-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-5-expected.png:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-background-6-expected.png:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.checksum:
  • platform/mac/fast/backgrounds/svg-as-mask-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-2-expected.png:
  • platform/mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/mac/fast/borders/svg-as-border-image-expected.png:
  • platform/mac/fast/images/svg-as-background-expected.checksum:
  • platform/mac/fast/images/svg-as-background-expected.png:
  • platform/mac/fast/images/svg-as-image-expected.checksum:
  • platform/mac/fast/images/svg-as-image-expected.png:
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum:
  • platform/mac/fast/images/svg-as-relative-image-expected.png:
  • platform/mac/fast/images/svg-as-tiled-background-expected.checksum:
  • platform/mac/fast/images/svg-as-tiled-background-expected.png:

Possible Flash failure
https://bugs.webkit.org/show_bug.cgi?id=21912

  • platform/mac/fast/dynamic/flash-replacement-test-expected.checksum:
  • platform/mac/fast/dynamic/flash-replacement-test-expected.png:

Repaint failure
https://bugs.webkit.org/show_bug.cgi?id=21913

  • platform/mac/fast/repaint/body-background-image-expected.checksum:
  • platform/mac/fast/repaint/body-background-image-expected.png:

Excessive repainting
https://bugs.webkit.org/show_bug.cgi?id=21914

  • platform/mac/fast/repaint/float-overflow-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-expected.png:
  • platform/mac/fast/repaint/float-overflow-right-expected.checksum:
  • platform/mac/fast/repaint/float-overflow-right-expected.png:

No video images
https://bugs.webkit.org/show_bug.cgi?id=21911

  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-layer-crash-expected.checksum:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
03:31 Changeset [38334] by barraclough@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-11-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22201
Integer conversion in array.length was safe signed values,
but the length is unsigned.

  • VM/CTI.cpp: (JSC::CTI::privateCompilePatchGetArrayLength):

LayoutTests:

2008-11-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Test for https://bugs.webkit.org/show_bug.cgi?id=22201

  • fast/js/pic/cached-array-length-access-expected.txt: Added.
  • fast/js/pic/cached-array-length-access.html: Added.
02:51 Changeset [38333] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Move _web_encodingForResource from WebKit into WebCore and change return type

This change is needed to implement NSAPI in WebCore for Mac, see:

https://bugs.webkit.org/show_bug.cgi?id=21427

02:44 Changeset [38332] by vestbo@webkit.org
  • 6 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Moved the implementation of _webkit_isCaseInsensitiveEqualToString to
WebCore's WebCoreNSStringExtras as _stringIsCaseInsensitiveEqualToString.

This change is needed to implement NSAPI in WebCore for Mac, see:

https://bugs.webkit.org/show_bug.cgi?id=21427

01:51 Changeset [38331] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø and Simon Hausmann.

Use QPalette::Base (instead of QPalette::Background) for the page
background.

  • Api/qwebframe.cpp: (QWebFramePrivate::updateBackground):
  • Api/qwebview.cpp: (QWebView::QWebView):
01:34 Changeset [38330] by cwzwarich@webkit.org
  • 12 edits in trunk

2008-11-12 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Roll out r38322 due to test failures on the bots.

JavaScriptCore:

  • VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCall): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileSlowCases):
  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/Machine.cpp: (JSC::Machine::callEval): (JSC::Machine::dumpCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::execute): (JSC::Machine::privateExecute): (JSC::Machine::throwStackOverflowPreviousFrame): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
  • bytecompiler/CodeGenerator.h:
  • parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
  • parser/Nodes.h: (JSC::ScopeNode::neededConstants):

LayoutTests:

  • fast/js/global-recursion-on-full-stack-expected.txt:

11/11/08:

19:30 Changeset [38329] by slewis@apple.com
  • 3 edits
    2 adds in trunk

2008-11-11 Stephanie <slewis@apple.com>

Reviewed by Dan Bernstein.

Null check image data before setting it as image source.

Test: fast/images/image-empty-data.html

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):

Test loading an image with no data.

  • fast/images/image-empty-data-expected.txt: Added.
  • fast/images/image-empty-data.html: Added.
19:09 Changeset [38328] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 Adele Peterson <adele@apple.com>

Reviewed by Tim Hatcher.

Remove ifdef so future OS versions can use the new delegate method.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didSendBodyDataDelegateExists):
17:53 Changeset [38327] by eric@webkit.org
  • 14 edits in trunk/WebCore

Reviewed by Antti Koivisto and Sam Weinig.

Clean up HTMLTokenizer a litle
https://bugs.webkit.org/show_bug.cgi?id=22188

Rename pendingScripts to m_pendingScripts
Rename scriptNode to m_scriptNode make the type specific
Rename pendingSrc to m_pendingSrc
Rename currentPrependingSrc to m_currentPrependingSrc
Rename noMoreData to m_noMoreData and cBuffer to m_cBuffer
Remove long-since-dead kdDebug and qDebug calls
Rename brokenComments to m_brokenComments
Remove HTMLTokenizer includes and document the rest
Rename src to m_src
Rename parser to m_parser and make it an OwnPtr
Rename inWrite to m_inWrite and jsProxy to scriptController
Rename brokenServer to m_brokenServer
Rename buffer to m_buffer and dest to m_dest
Rename size to m_bufferSize
Rename attrName to m_attrName
Rename searchStopper to m_searchStopper and searchStopperLen to m_searchStopperLen
Rename scriptCode* to m_scriptCode* and change scriptCodeMax to m_scriptCodeCapacity
Rename scriptStartLineno to m_currentScriptTagStartLineNumber and tagStartLineno to m_currentTagStartLineNumber
Rename scriptSrc to m_scriptTagSrcAttrValue and scriptSrcCharset to m_scriptTagCharsetAttrValue -- a bit unwieldy, but more precise
Rename flat to selfClosingTag
Rename currToken to m_currentToken

  • css/CSSParser.cpp:
  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizerLibxml2.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParser.h:
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::begin): (WebCore::HTMLTokenizer::processListing): (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseServer): (WebCore::HTMLTokenizer::parseProcessingInstruction): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::processingData): (WebCore::HTMLTokenizer::end): (WebCore::HTMLTokenizer::finish): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::processDoctypeToken): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer): (WebCore::HTMLTokenizer::notifyFinished): (WebCore::HTMLTokenizer::setSrc):
  • html/HTMLTokenizer.h: (WebCore::Token::Token): (WebCore::Token::reset): (WebCore::HTMLTokenizer::processingContentWrittenByScript): (WebCore::HTMLTokenizer::htmlParser): (WebCore::HTMLTokenizer::checkBuffer): (WebCore::HTMLTokenizer::checkScriptBuffer):
  • html/HTMLViewSourceDocument.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth):
  • xml/XSLTProcessor.cpp:
17:37 Changeset [38326] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitSite

2008-11-11 Simon Fraser <simon.fraser@apple.com>

Update leaves animation sample.

  • blog-files/leaves/index.html:
  • blog-files/leaves/leaves.css:
17:35 Changeset [38325] by dino@apple.com
  • 2 edits in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Removed quotes in animation name value.

  • blog-files/pulse.html:
16:49 Changeset [38324] by dino@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Added a smaller version of a screenshot.

  • blog-files/leaves-screenshot-small.jpg: Added.
16:32 Changeset [38323] by dino@apple.com
  • 1 edit
    17 adds in trunk/WebKitSite

2008-11-11 Dean Jackson <dino@apple.com>

Add a bunch of examples for CSS Animation blog draft.

  • blog-files/bounce.html: Added.
  • blog-files/bounce.png: Added.
  • blog-files/leaves-screenshot.jpg: Added.
  • blog-files/leaves/images/apple-touch-icon.png: Added.
  • blog-files/leaves/images/backgroundLeaves.jpg: Added.
  • blog-files/leaves/images/realLeaf1.png: Added.
  • blog-files/leaves/images/realLeaf2.png: Added.
  • blog-files/leaves/images/realLeaf3.png: Added.
  • blog-files/leaves/images/realLeaf4.png: Added.
  • blog-files/leaves/images/textBackground.png: Added.
  • blog-files/leaves/index.html: Added.
  • blog-files/leaves/leaves.css: Added.
  • blog-files/leaves/leaves.js: Added.
  • blog-files/pulse.html: Added.
  • blog-files/pulse.png: Added.
16:32 Changeset [38322] by ggaren@apple.com
  • 12 edits in trunk

2008-11-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Fixed https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

Instead, the caller emits an explicit load or mov instruction, or relies
on implicit knowledge that "this" is already in the first argument slot.
As a result, two operands to op_call are gone: firstArg and thisVal.


SunSpider and v8 tests show no change in bytecode or CTI.

  • VM/CTI.cpp: (JSC::CTI::compileOpCallSetupArgs): (JSC::CTI::compileOpCallEvalSetupArgs): (JSC::CTI::compileOpConstructSetupArgs): Split apart these three versions of setting up arguments to op_call, because they're more different than they are the same -- even more so with this patch.

(JSC::CTI::compileOpCall): Updated for the fact that op_construct doesn't
match op_call anymore.

(JSC::CTI::privateCompileMainPass):
(JSC::CTI::privateCompileSlowCases): Merged a few call cases. Updated
for changes mentioned above.

  • VM/CTI.h:
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump): Updated for new bytecode format of call / construct.
  • VM/Machine.cpp: (JSC::Machine::callEval): Updated for new bytecode format of call / construct.

(JSC::Machine::dumpCallFrame):
(JSC::Machine::dumpRegisters): Simplified these debugging functions,
taking advantage of the new call frame layout.

(JSC::Machine::execute): Fixed up the eval version of execute to be
friendlier to calls in the new format.

(JSC::Machine::privateExecute): Implemented the new call format in
bytecode.

(JSC::Machine::cti_op_call_NotJSFunction):
(JSC::Machine::cti_op_construct_JSConstruct):
(JSC::Machine::cti_op_construct_NotJSConstruct):
(JSC::Machine::cti_op_call_eval): Updated CTI helpers to match the new
call format.


Fixed a latent bug in stack overflow checking that is now hit because
the register layout has changed a bit -- namely: when throwing a stack
overflow exception inside an op_call helper, we need to account for the
fact that the current call frame is only half-constructed, and use the
parent call frame instead.

  • VM/Machine.h:
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitCallEval): (JSC::CodeGenerator::emitConstruct):
  • bytecompiler/CodeGenerator.h: Updated codegen to match the new call format.
  • parser/Nodes.cpp: (JSC::EvalFunctionCallNode::emitCode): (JSC::FunctionCallValueNode::emitCode): (JSC::FunctionCallResolveNode::emitCode): (JSC::FunctionCallBracketNode::emitCode): (JSC::FunctionCallDotNode::emitCode):
  • parser/Nodes.h: (JSC::ScopeNode::neededConstants): ditto

2008-11-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Updated a test after fixing https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot.

  • fast/js/global-recursion-on-full-stack-expected.txt: This test passes a little differently now, because the register layout has changed. Specifically, the stack overflow now happens in the call to f() instead of the initiation of the <script> tag, so it is caught, and it does not log an exception to the console.
16:28 Changeset [38321] by weinig@apple.com
  • 4 edits in trunk/WebCore

2008-11-11 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
Track CachedScript decoded data

We now track the decoded size of CachedScripts in the Cache allowing
them to accounted for when deciding when to evict data. The decoded
data itself can be evicted when Cache pressure gets high enough through
CachedScript::destroyDecodedData.

  • loader/CachedResource.h: (WebCore::CachedResource::allClientsRemoved): (WebCore::CachedResource::destroyDecodedData):
  • loader/CachedScript.cpp: (WebCore::CachedScript::script): (WebCore::CachedScript::data): (WebCore::CachedScript::destroyDecodedData):
  • loader/CachedScript.h:
15:39 Changeset [38320] by cwzwarich@webkit.org
  • 8 edits
    1 delete in trunk

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Remove pointless dependencies on the now-deleted kjs directory and
mentions of it in comments that are no longer relevant.

JavaScriptCore:

  • ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.

WebCore:

  • WebCore.pro:
  • webcore-base.bkl:

WebKit/qt:

  • WebKit_pch.h:

WebKit/wx:

  • presets/wxwebkit.bkl:
15:26 Changeset [38319] by adachan@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix: https://bugs.webkit.org/show_bug.cgi?id=22187
Bug 22187: CLEARTYPE_QUALITY flag is not supported on Win2000


Update window versions to correspond to Windows XP.

Reviewed by Steve Falkenburg.

  • win/tools/vsprops/common.vsprops:
14:45 Changeset [38318] by mitz@apple.com
  • 16 edits in trunk

WebCore:

Reviewed by Adam Roben.

WebCore part of adding a master volume control for media elements in a WebView

  • WebCore.base.exp: Exported WebCore::Page::setMediaVolume().
  • dom/Document.cpp: (WebCore::Document::mediaVolumeDidChange): Added. Called by the Page when the media volume is changed. (WebCore::Document::registerForMediaVolumeCallbacks): Added. Allows elements to register for a callback when the media volume is changed. (WebCore::Document::unregisterForMediaVolumeCallbacks): Added. Allows elements to unregister for the callback.
  • dom/Document.h:
  • dom/Element.h: (WebCore::Element::mediaVolumeDidChange): Added an empty implementation.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Added a call to registerForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::~HTMLMediaElement): Added a call to unregisterForMediaVolumeCallbacks(). (WebCore::HTMLMediaElement::updateVolume): Changed to multiply the element's intrinsic volume by the master volume from the page. (WebCore::HTMLMediaElement::mediaVolumeDidChange): Added. Calls updateVolume().
  • html/HTMLMediaElement.h:
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_mediaVolume to 1. (WebCore::Page::setMediaVolume): Added. Calls mediaVolumeDidChange() on every document in the page when the master volume changes.
  • page/Page.h: (WebCore::Page::mediaVolume): Added this getter.

WebKit/mac:

Reviewed by Adam Roben.

WebKit/mac part of adding a master volume control for media elements in a WebView

  • WebView/WebView.mm: (-[WebView setMediaVolume:]): Added. (-[WebView mediaVolume]): Added.
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Adam Roben.

WebKit/win part of adding a master volume control for media elements in a WebView

  • Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and mediaVolume().
  • WebView.cpp: (WebView::setMediaVolume): Added. (WebView::mediaVolume): Added.
  • WebView.h:
14:31 Changeset [38317] by andersca@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Mark Rowe.

Removed invalid bases incorrectly checked-in in r38305.

https://bugs.webkit.org/show_bug.cgi?id=22185

  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.png: Removed.
  • platform/mac-tiger/fast/text/international/complex-character-based-fallback-expected.txt: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/mac-tiger/fast/text/international/hindi-spacing-expected.txt: Removed.
14:25 Changeset [38316] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix broken dependencies building JavaScriptCore on a freezing cold cat, caused
by failure to update all instances of "kjs" to their new locations.

14:13 Changeset [38315] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-11 Aaron Golden <agolden@apple.com>

Bug 22134: -[WebHistoryItem dictionaryRepresentation] accesses past the end of a vector

<https://bugs.webkit.org/show_bug.cgi?id=22134>

Reviewed by Geoff Garen.

  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]):
13:49 Changeset [38314] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Rubber-stamped by Adam Roben.

  • wtf/AVLTree.h: (WTF::AVLTree::Iterator::start_iter): Fix indentation a little more.
13:11 Changeset [38313] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Clean up EvalCodeCache to match our coding style a bit more.

  • VM/EvalCodeCache.h: (JSC::EvalCodeCache::get):
12:43 Changeset [38312] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=22182

Fix problems with scrollbars when the OS setting for clicks in the track jumping the thumb to that location
is turned on. Make sure to only jump the thumb if the click happens in the track. Also fix some math
errors when jumping the thumb that cause dragging after the jump to incorrectly jump the thumb again.

Reviewed by Adele

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::mouseDown):
12:06 Changeset [38311] by cwzwarich@webkit.org
  • 6 edits
    1 copy in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
<https://bugs.webkit.org/show_bug.cgi?id=22179>

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CodeBlock.h:
  • VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
  • VM/Machine.cpp:
11:58 Changeset [38310] by bdakin@apple.com
  • 12 edits
    4 adds in trunk

WebCore:

2008-11-11 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Too much indentation when pasting
quoted paragraphs

This patch re-addresses pasting blockquotes into blockquotes. It
backs out most of revision 38273. 38273 fixed the bug by inserting
the pasted content as a sibling blockquote node to the pre-existing
blockquote node. The problem with that is that by default,
blockquotes have a giant margin, so visually, this can be weird.
This patch instead inserts the pasted content as siblings of the
the content already inside the outer blockquote, and then removes
the blockquote node from the pasted content itself, so that it
doesn't nest itself into the outer blockquote.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Move contains() from Element to Node since there is nothing
Element-specific about it.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Node.cpp: (WebCore::Node::contains):
  • dom/Node.h:

LayoutTests:

2008-11-11 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Tests for <rdar://problem/5089327> Too much indentation when
pasting quoted paragraphs

This is a new test:

  • editing/pasteboard/paste-blockquote-into-blockquote-3.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-3-expected.txt: Added.

The results for these tests previously reflected the behavior
implemented in revision 38273. We have since decided that that
behavior is wrong and we changed it with this patch.

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt:
11:50 Changeset [38309] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=17997

Stop using the new Leopard API tiling call for scaled tiles when drawing background images. The method
is buggy. Fall back to using the slower (and more correct) pattern tiling that Tiger still uses. This
is a Leopard-only workaround, since the API has been fixed on Snow Leopard.

Reviewed by John Sullivan

  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):
11:41 Changeset [38308] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

2008-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Dave Hyatt.

Pattern transform check was too strict for Cg. Scaling can cause a wrong
color on the borders of the scaled object.

Correct expected result of the tests.

  • fast/canvas/canvas-pattern-transform-expected.txt:
  • fast/canvas/canvas-pattern-transform.html:
  • fast/canvas/canvas-pattern-transform.js:
  • fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt:
11:18 Changeset [38307] by hyatt@apple.com
  • 2 edits
    4 adds in trunk

2008-11-10 David Hyatt <hyatt@apple.com>

Disable the Aqua look for menu lists when full page zoom is turned on. Because the control is buggy
when scaling and because it's impossible to paint into an offscreen bitmap without completely rewriting
how we draw the control on Mac, our only real option for now is to just switch to our styled look when zoomed.

Reviewed by Adam Roben

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
10:31 Changeset [38306] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the 'm_' prefix from the fields of the SwitchRecord struct.

  • VM/CTI.cpp: (JSC::CTI::privateCompile):
  • VM/CTI.h: (JSC::SwitchRecord): (JSC::SwitchRecord::SwitchRecord):
10:26 Changeset [38305] by mitz@apple.com
  • 27 edits
    18 adds
    640 deletes in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21821

Removed pixel results in platform/mac-tiger that were only slightly different
(within 1% tolerance) from the platform/mac results.
Removed results in platform/mac-tiger where the results in platform/mac were
also correct for Tiger.
Also updated results in platform/mac-tiger that were out of date.

Made sure every test that has a specific mac-tiger render tree output also has matching images.

(file listing elided)

09:59 Changeset [38304] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-11-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • editing/visible_units.cpp: (WebCore::nextLinePosition): Use RenderObject::node instead of RenderObject::element to check editingIgnoresContent. It makes sense to use the associated DOM node for this, even in cases of anonymous content, and it avoids the case where element() can be 0. (WebCore::previousLinePosition): Ditto.
09:54 Changeset [38303] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Make asInteger() a static function so that it has internal linkage.

  • VM/CTI.cpp: (JSC::asInteger):
09:40 Changeset [38302] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2008-11-11 Dirk Schulze <vbs85@gmx.de>

WebCore:

Reviewed by Darin Adler.

Removed default: in applySpreadMethod. This causes the problems
in radial gradients. We don't need CAIRO_EXTEND_NONE in SVG, Canvas
or CSS.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::applySpreadMethod):

LayoutTests:

Reviewed by Darin Adler.

Check behavior of default spreadMethod on radial gradients.

  • fast/canvas/canvas-radial-gradient-spreadMethod-expected.txt: Added.
  • fast/canvas/canvas-radial-gradient-spreadMethod.html: Added.
  • fast/canvas/canvas-radial-gradient-spreadMethod.js: Added.
05:32 Changeset [38301] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-11 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix crash when rendering the file chooser.
Also proper implementation for multi-selected files.

  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::basenameForWidth):
03:35 Changeset [38300] by krit@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2008-11-11 Dirk Schulze <vbs85@gmx.de>

Reviewed by Oliver Hunter.

Added test to check behavior on transformations of patterns in canvas.

  • fast/canvas/canvas-pattern-transform-expected.txt: Added.
  • fast/canvas/canvas-pattern-transform.html: Added.
  • fast/canvas/canvas-pattern-transform.js: Added.
03:05 Changeset [38299] by krit@webkit.org
  • 4 edits in trunk/WebCore
01:51 Changeset [38298] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.


  • shrink CodeBlock and AST related Vectors to exact fit (5-10M savings on membuster test)


No perf regression combined with the last patch (each seems like a small regression individually)

  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::generate):
  • parser/Nodes.h: (JSC::SourceElements::releaseContentsIntoVector):
  • wtf/Vector.h: (WTF::Vector::shrinkToFit):
01:11 Changeset [38297] by mitz@apple.com
  • 2023 edits
    35 adds in trunk/LayoutTests

2008-11-11 Pierre-Olivier Latour <pol@apple.com>

Rubber-stamped by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=21821

Remaining set of updated expected pixel results. This includes http/,
media/, plugins/, scrollbars/, tables/, transforms/, transitions/ and
webarchive/.

(file listing elided)

01:10 Changeset [38296] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.


  • remove inline capacity from declaration stacks (15M savings on membuster test)

No perf regression on SunSpider or V8 test combined with other upcoming memory improvement patch.


00:06 Changeset [38295] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

While r38286 removed the need for the m_callFrame member variable of
CTI, it should be also be removed.

  • VM/CTI.h:

11/10/08:

23:57 Changeset [38294] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Oliver Hunt.

Make CTI::asInteger() a non-member function, since it needs no access to
any of CTI's member variables.

  • VM/CTI.cpp: (JSC::asInteger):
  • VM/CTI.h:
23:06 Changeset [38293] by slewis@apple.com
  • 3 edits in trunk/WebCore

2008-11-10 Stephanie Lewis <slewis@apple.com>

Reviewed by Dan Bernstein.

Clear the image source cache even if we haven't decoded any of the image data.
We use the image source cache when calculating layout.

  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
22:04 Changeset [38292] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Use 'value' instead of 'js' in CTI as a name for JSValue* to match our
usual convention elsewhere.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes):
21:55 Changeset [38291] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Make CTI::getConstant() a member function of CodeBlock instead.

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CTI.h:
  • VM/CodeBlock.h: (JSC::CodeBlock::getConstant):
21:45 Changeset [38290] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Rename CodeBlock::isConstant() to isConstantRegisterIndex().

  • VM/CTI.cpp: (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.h: (JSC::CodeBlock::isConstantRegisterIndex):
  • bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitEqualityOp):
21:40 Changeset [38289] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

non-CTI build fix take 2

21:31 Changeset [38288] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/VM/Machine.cpp

non-CTI build fix

21:22 Changeset [38287] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the unused labels member variable of CodeBlock.

  • VM/CodeBlock.h:
  • VM/LabelID.h: (JSC::LabelID::setLocation):
21:09 Changeset [38286] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

2008-11-10 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Batch compile the set of static trampolines at the point Machine is constructed, using a single allocation.
Refactor out m_callFrame from CTI, since this is only needed to access the global data (instead store a
pointer to the global data directly, since this is available at the point the Machine is constructed).
Add a method to align the code buffer, to allow JIT generation for multiple trampolines in one block.

  • VM/CTI.cpp: (JSC::CTI::getConstant): (JSC::CTI::emitGetArg): (JSC::CTI::emitGetPutArg): (JSC::CTI::getConstantImmediateNumericArg): (JSC::CTI::printOpcodeOperandTypes): (JSC::CTI::CTI): (JSC::CTI::compileBinaryArithOp): (JSC::CTI::privateCompileMainPass): (JSC::CTI::privateCompileGetByIdProto): (JSC::CTI::privateCompileGetByIdChain): (JSC::CTI::privateCompileCTIMachineTrampolines): (JSC::CTI::freeCTIMachineTrampolines):
  • VM/CTI.h: (JSC::CTI::compile): (JSC::CTI::compileGetByIdSelf): (JSC::CTI::compileGetByIdProto): (JSC::CTI::compileGetByIdChain): (JSC::CTI::compilePutByIdReplace): (JSC::CTI::compilePutByIdTransition): (JSC::CTI::compileCTIMachineTrampolines): (JSC::CTI::compilePatchGetArrayLength):
  • VM/Machine.cpp: (JSC::Machine::initialize): (JSC::Machine::~Machine): (JSC::Machine::execute): (JSC::Machine::tryCTICachePutByID): (JSC::Machine::tryCTICacheGetByID): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_lazyLinkCall):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::JITCodeBuffer::isAligned): (JSC::X86Assembler::): (JSC::X86Assembler::align):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
19:51 Changeset [38285] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.


  • wtf/Vector.h: (WTF::VectorBufferBase::deallocateBuffer): Set capacity to 0 as well as size, otherwise shrinking capacity to 0 can fail to reset the capacity and thus cause a future crash. (WTF::Vector::~Vector): Shrink size not capacity; we only need to call destructors, the buffer will be freed anyway. (WTF::Vector::clear): Change this to shrinkCapacity(0), not just shrink(0). (WTF::::shrinkCapacity): Use shrink() instead of resize() for case where the size is greater than the new capacity, to work with types that have no default constructor.
19:38 Changeset [38284] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Split multiple definitions into separate lines.

  • VM/CTI.cpp: (JSC::CTI::compileBinaryArithOp):
17:26 Changeset [38283] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move renewGState to the base class.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView renewGState]):
  • Plugins/WebNetscapePluginView.mm:
17:23 Changeset [38282] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move start, stop and all the related methods down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView addWindowObservers]): (-[WebBaseNetscapePluginView removeWindowObservers]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewWillMoveToHostWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToHostWindow]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView windowDidMiniaturize:]): (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]): (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:
17:13 Changeset [38281] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move rightMouseDown, rightMouseUp and sendActivateEvent to the base plugin view.
Add stubs for createPlugin, loadStream, shouldStop and destroyPlugin.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowFocusChanged:]): (-[WebBaseNetscapePluginView createPlugin]): (-[WebBaseNetscapePluginView loadStream]): (-[WebBaseNetscapePluginView destroyPlugin]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView rightMouseDown:]): (-[WebBaseNetscapePluginView rightMouseUp:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView windowFocusChanged:]):
16:51 Changeset [38280] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Factor plug-in type specific code out to three new methods, createPlugin, destroyPlugin and loadStream.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView createPlugin]): (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView shouldStop]): (-[WebNetscapePluginView destroyPlugin]): (-[WebNetscapePluginView stop]):
16:38 Changeset [38279] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Fix Tiger build.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
16:29 Changeset [38278] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move even more code down to WebBaseNetscapePluginView, get rid of some unnecessary methods.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView focusChanged]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView focusChanged]): (-[WebNetscapePluginView tellQuickTimeToChill]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView viewWillMoveToWindow:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView pluginView:receivedError:]): (-[WebNetscapePluginView pluginViewFinishedLoading:]): (-[WebNetscapePluginView inputContext]): (-[WebNetscapePluginView hasMarkedText]): (-[WebNetscapePluginView insertText:]): (-[WebNetscapePluginView markedRange]): (-[WebNetscapePluginView selectedRange]): (-[WebNetscapePluginView setMarkedText:selectedRange:]): (-[WebNetscapePluginView unmarkText]): (-[WebNetscapePluginView validAttributesForMarkedText]): (-[WebNetscapePluginView attributedSubstringFromRange:]): (-[WebNetscapePluginView characterIndexForPoint:]): (-[WebNetscapePluginView doCommandBySelector:]): (-[WebNetscapePluginView firstRectForCharacterRange:]): (-[WebNetscapePluginView _viewHasMoved]): (-[WebNetscapePluginView _redeliverStream]):
15:43 Changeset [38277] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move timer handling code down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView startTimers]): (-[WebBaseNetscapePluginView restartTimers]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView stopTimers]): (-[WebNetscapePluginView startTimers]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
14:59 Changeset [38276] by andersca@apple.com
  • 8 edits in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.


Add WebHostedNetscapePluginView to the project.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Move a bunch of methods and ivars up to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView finalize]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView webView]): (-[WebBaseNetscapePluginView currentWindow]):
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView sendActivateEvent:]): (-[WebNetscapePluginView restartTimers]): (-[WebNetscapePluginView setHasFocus:]): (-[WebNetscapePluginView mouseDown:]): (-[WebNetscapePluginView mouseUp:]): (-[WebNetscapePluginView mouseEntered:]): (-[WebNetscapePluginView mouseExited:]): (-[WebNetscapePluginView handleMouseMoved:]): (-[WebNetscapePluginView mouseDragged:]): (-[WebNetscapePluginView scrollWheel:]): (-[WebNetscapePluginView keyUp:]): (-[WebNetscapePluginView keyDown:]): (-[WebNetscapePluginView flagsChanged:]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView stop]): (-[WebNetscapePluginView isStarted]): (-[WebNetscapePluginView dealloc]): (-[WebNetscapePluginView finalize]): (-[WebNetscapePluginView drawRect:]): (-[WebNetscapePluginView windowBecameKey:]): (-[WebNetscapePluginView preferencesHaveChanged:]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): (-[WebNetscapePluginView _viewHasMoved]):
14:27 Changeset [38275] by andersca@apple.com
  • 8 edits
    2 adds in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Mark Rowe.

Add a WebHostedNetscapePluginView class.


  • Plugins/WebHostedNetscapePluginView.h: Added.
  • Plugins/WebHostedNetscapePluginView.mm: Added.
  • Plugins/WebNetscapePluginPackage.h: Use the right define.


  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): Check for WebBaseNetscapePluginView.


(-[WebPluginDatabase destroyAllPluginInstanceViews]):
Check for WebBaseNetscapePluginView.


  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): Use WebBaseNetscapePluginView.


(netscapePluginViewClass):
New function that returns the right netscape plugin view type to use.


(WebFrameLoaderClient::createPlugin):
Get the right class.


  • WebKitPrefix.h: Prefix the #define with WTF_.


  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]): Check for WebBaseNetscapePluginView.


  • WebView/WebView.mm: Remove an unnecessary include.
14:12 Changeset [38274] by aroben@apple.com
  • 3 edits
    2 adds in trunk

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when loading microsoftpdc.com

WebCore:

Fix Bug 22161: Assertion failure in RenderThemeWin::systemColor when
loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Reviewed by Dan Bernstein.

Test: fast/css/outline-invert-assertion.html

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::systemColor): If we can't determine a good Win32 system color to use, defer to RenderTheme instead of asserting. This matches what RenderThemeMac does.

LayoutTests:

Test for Bug 22161: Assertion failure in RenderThemeWin::systemColor
when loading microsoftpdc.com

<https://bugs.webkit.org/show_bug.cgi?id=22161>

Note that this test would only fail if DumpRenderTree used
RenderThemeWin, which it doesn't. I did test that locally, though.

Reviewed by Dan Bernstein.

  • fast/css/outline-invert-assertion-expected.txt: Added.
  • fast/css/outline-invert-assertion.html: Added.
13:51 Changeset [38273] by bdakin@apple.com
  • 6 edits
    8 adds in trunk

WebCore:

2008-11-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/4037481> REGRESSION (Mail): pasting quoted text
into quoted text yields double-quoting


Don't nest inserted content in Mail blockquotes. Perform a
BreakBlockquoteCommand if we're in
one and insert the incoming fragment between the split blockquotes.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Renamed from -> source and to -> destination. (WebCore::ReplaceSelectionCommand::doApply):

LayoutTests:

2008-11-10 Beth Dakin <bdakin@apple.com>

Rubber stamped by Justin Garcia.

New tests for <rdar://problem/4037481> REGRESSION (Mail): pasting
quoted text into quoted text yields double-quoting

  • editing/pasteboard/paste-blockquote-into-blockquote-2.html: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into- blockquote-2-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote- expected.txt: Added.


Test with new results because of this patch:

  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote- expected.txt:
13:47 Changeset [38272] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

Commit the current configuration of build.webkit.org.

13:45 Changeset [38271] by mrowe@apple.com
  • 5 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/webkit

Commit the current configuration of build.webkit.org.

13:33 Changeset [38270] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't use individual ivars for each plug-in vtable function. Instead, get them from the plugin package.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]): (-[WebNetscapePluginView setWindowIfNecessary]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebNetscapePluginView createPluginScriptableObject]): (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebNetscapePluginView loadPluginRequest:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): (-[WebNetscapePluginView _printedPluginBitmap]):
13:00 Changeset [38269] by andersca@apple.com
  • 5 edits
    2 adds in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Add a new WebBaseNetscapePluginView class.

  • Plugins/WebBaseNetscapePluginView.h: Added.
  • Plugins/WebBaseNetscapePluginView.mm: Added. (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView handleMouseMoved:]):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView cut:]): (-[WebNetscapePluginView copy:]): (-[WebNetscapePluginView paste:]): (-[WebNetscapePluginView selectAll:]): (-[WebNetscapePluginView start]): (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
12:25 Changeset [38268] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 22162: Remove cachedValueGetter from the JavaScriptCore API implementation
<https://bugs.webkit.org/show_bug.cgi?id=22162>

There is no more need for the cachedValueGetter hack now that we have
PropertySlot::setValue(), so we should remove it.

  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot):
12:20 Changeset [38267] by andersca@apple.com
  • 17 edits
    2 moves in trunk/WebKit

WebKit:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • StringsNotToBeLocalized.txt:
  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-10 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.


Rename WebBaseNetscapePluginView to WebNetscapePluginView.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::setPlugin):
  • Plugins/WebBaseNetscapePluginView.h: Removed.
  • Plugins/WebBaseNetscapePluginView.mm: Removed.
  • Plugins/WebNetscapePluginEventHandler.h: (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
  • Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
  • Plugins/WebNetscapePluginEventHandlerCarbon.h:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
  • Plugins/WebNetscapePluginView.h: Copied from mac/Plugins/WebBaseNetscapePluginView.h.
  • Plugins/WebNetscapePluginView.mm: Copied from mac/Plugins/WebBaseNetscapePluginView.mm. (+[WebNetscapePluginView setCurrentPluginView:]): (+[WebNetscapePluginView currentPluginView]): (-[WebNetscapePluginView loadPluginRequest:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase removePluginInstanceViewsFor:]): (-[WebPluginDatabase destroyAllPluginInstanceViews]):
  • Plugins/npapi.mm: (pluginViewForInstance): (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged):
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
  • WebView/WebView.mm:
10:38 Changeset [38266] by aroben@apple.com
  • 4 edits
    1 add in trunk

Fix Bug 22158: Would like to turn on WebCore logging channels via an environment variable

WebCore:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Logging channels can now be enabled by setting the WebCoreLogLevel
environment variable to a hexadecimal number.

Reviewed by Anders Carlsson.

  • WebCore.vcproj/WebCore.vcproj: Added LoggingWin.cpp.
  • platform/win/LoggingWin.cpp: Copied from WebCore/platform/mac/LoggingMac.mm. (WebCore::initializeWithUserDefault): Read in the WebCoreLogLevel environment variable, parse its value as a hexadecimal number, and turn the channel on/off based on whether the mask bit is set. (WebCore::InitializeLoggingChannelsIfNecessary): Initialize each logging channel in turn.

WebKit/win:

Fix Bug 22158: Would like to turn on WebCore logging channels via an
environment variable

<https://bugs.webkit.org/show_bug.cgi?id=22158>

Reviewed by Anders Carlsson.

  • WebView.cpp: (WebView::initWithFrame): Call WebCore's InitializeLoggingChannelsIfNecessary.
10:17 Changeset [38265] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-10 Cameron Zwarich <zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22152: Remove asObject() call from JSCallbackObject::getOwnPropertySlot()
<https://bugs.webkit.org/show_bug.cgi?id=22152>

With the recent change to adopt asType() style cast functions with
assertions instead of static_casts in many places, the assertion for
the asObject() call in JSCallbackObject::getOwnPropertySlot() has been
failing when using any nontrivial client of the JavaScriptCore API.
The cast isn't even necessary to call slot.setCustom(), so it should
be removed.

  • API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject::getOwnPropertySlot):
09:06 Changeset [38264] by darin@apple.com
  • 4 edits in trunk/WebCore

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

This broke when the meaning of FrameView::invalidate changed.
I changed setNeedsReapplyStyles to no longer depend on invalidate.

  • dom/Document.cpp: (WebCore::Document::shouldScheduleLayout): Removed the part of this function that duplicated what's already in FrameView::needsLayout, since the copy here left out a few key things. For example, it didn't handle the fact that "needs reapply styles" counts as needing layout.
  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): This called FrameView::invalidate before. There were two things wrong with that. 1) It requested that the entire view repaint even if the style change didn't necessitate that. 2) FrameView::invalidate no longer causes any repainting at all in certain cases, because of Hyatt's changes to how widgets and the host window are involved in the repainting process. So call FrameView::scheduleRelayout instead, which is more precisely what we want and need here.
  • page/FrameView.cpp: (WebCore::FrameView::scheduleRelayout): Add a call to needsLayout here so that Document::shouldScheduleLayout doesn't have to replicate the logic that's in needsLayout and can instead rely on the fact that it was already called. (WebCore::FrameView::needsLayout): Tweaked the comments and formatting in this function.
09:03 Changeset [38263] by darin@apple.com
  • 2 edits in trunk/WebCore

2008-11-10 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

  • speculative fix for <rdar://problem/5557243> crashes in Safari at WebCore::HTMLSelectElement::updateListBoxSelection + 280
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListBoxSelection): Check index against size of vector before indexing into the vector.
07:55 Changeset [38262] by vestbo@webkit.org
  • 2 edits in trunk

2008-11-10 Tor Arne Vestbø <tavestbo@trolltech.com>

Rubber-stamped by Simon Hausmann.

Distinguish between building from trunk and as part of Qt

07:42 Changeset [38261] by darin@apple.com
  • 4 edits in trunk/BugsSite

2008-11-10 Darin Adler <darin@apple.com>

  • globals.pl: Fix cases that are automatically generated, such as links in comments in bugs.
  • template/en/custom/attachment/created.html.tmpl: Fix the link on the "I just created an attachment" page.
  • template/en/custom/request/queue.html.tmpl: Fix the link in the queue page.
07:31 Changeset [38260] by darin@apple.com
  • 2 edits in trunk/BugsSite

2008-11-10 Darin Adler <darin@apple.com>

  • template/en/custom/request/email.txt.tmpl: Send review links instead of edit links when flags are set on a bug.
07:03 Changeset [38259] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

A few coding style fixes for AVLTree.

  • wtf/AVLTree.h: Moved to WTF namespace, Removed "KJS_" from include guards. (WTF::AVLTree::Iterator::start_iter): Fixed indentation
  • runtime/JSArray.cpp: Added "using namepace WTF".
06:37 Changeset [38258] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

To fit Qt API, scroll offset is a QPoint instead of a QSize.

  • Api/qwebframe.cpp: (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
  • Api/qwebframe.h:
03:46 Changeset [38257] by hausmann@webkit.org
  • 2 edits in trunk

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Make tests/auto/qwebframe compile on Qt/Mac.

03:46 Changeset [38256] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Fixed qdoc warnings by supplying function documentation.

03:45 Changeset [38255] by hausmann@webkit.org
  • 1 edit
    1 delete in trunk/WebKit/qt

2008-11-10 Tobias Koenig <tobias.koenig@trolltech.com>

Reviewed by Simon Hausmann.

Removed old and stale prf file that breaks the MingW build.

03:45 Changeset [38254] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-10 Tom Cooksey <thomas.cooksey@trolltech.com>

Reviewed by Tor Arne Vestbø.

Fix QtWebkit build failure on arm.

pen.widthF() is a qreal, which means it's a float on arm.

03:45 Changeset [38253] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2008-11-10 Kavindra Palaraja <kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Clarify QWebFrame/View::setHTML docs with regards to relative URLs

03:45 Changeset [38252] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-11-10 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Simon Hausmann

Don't define _CRT_RAND_S on Windows CE in the precompiled
header, to fix the CE build.

03:45 Changeset [38251] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2008-11-10 Morten Sørvig <msorvig@trolltech.com>

Reviewed by Simon Hausmann.

Improve mouse wheel scolling on Qt/Cocoa.
Cocoa differs from Carbon (and other platforms I think) in that the
mouse wheel events we get have a much higher acceleration factor.

This submit switches over to scroll-per-pixel from scroll-per-line
for most of our scrolling views. This matches the native views
and works well with the increased acceleration.

Note: See TracTimeline for information about the timeline view.