Timeline
11/25/08:
- 21:47 BuildingCairoOnWindows edited by
- (diff)
- 21:24 Changeset [38778] by
-
Reviewed by Mark Rowe.
- include the text direction submenu in context menus when appropriate
- WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed the default textDirectionSubmenuInclusionBehavior to "automatically", which includes the menu when the selection is confined to a single paragraph the either has right-to-left base writing direction or contains right-to-left or embedded text. Left the default for Tiger and Leopard to be "never".
- 18:19 Changeset [38777] by
-
2008-11-25 Darin Fisher <darin@chromium.org>
Fix bustage.
https://bugs.webkit.org/show_bug.cgi?id=22493
Need to expose bridge/*.h to the WebKit build.
- WebCore.vcproj/WebCore.vcproj:
- 17:38 Changeset [38776] by
-
2008-11-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.
Tests: animations/empty-keyframes.html
animations/fill-unset-properties.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
- 17:21 Changeset [38775] by
-
Not reviewed. Fix build, by removing some wrong last-minute changes.
- 17:19 Changeset [38774] by
-
2008-11-25 Darin Fisher <darin@chromium.org>
Reviewed by Geoffrey Garen.
- Abstract away JSC
- usage in WebCore/html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance):
- bindings/js/ScriptController.h:
- bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/js/ScriptInstance.h: Added.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::getInstance):
- html/HTMLPlugInElement.h:
- 17:15 Changeset [38773] by
-
Reviewed by Sam Weinig.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477
A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.
Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
<template>/<option> or <card> element.
Add complete <onevent> support.
- 17:07 Changeset [38772] by
-
Windows build fix.
- DumpRenderTree/cg/PixelDumpSupportCG.h:
- 17:05 Changeset [38771] by
-
Windows build fix.
- DumpRenderTree/cg/ImageDiffCG.cpp:
- 16:54 Changeset [38770] by
-
2008-11-25 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Mark Rowe.
createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL
- platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
- 16:33 Changeset [38769] by
-
2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441
Element's other than HTML ones take a QualifiedName in their constructors.
To make HTMLElementFactory closer to the other ElementFactory, we need
to make them take the same arguments.
This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
will go into the next patch.
- dom/Document.cpp: (WebCore::Document::implicitClose):
- html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement):
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement):
- html/HTMLBodyElement.h:
- html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor):
- html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement):
- html/HTMLHeadElement.h:
- html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement):
- html/HTMLHtmlElement.h:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
- html/HTMLLinkElement.h:
- html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::HTMLMetaElement):
- html/HTMLMetaElement.h:
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::finished):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
- 16:18 Changeset [38768] by
-
2008-11-25 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler
Fix a crash when an animation or transition end event handler
removes the element upon which the transition/animation is running,
by keeping a reference to the AnimationBase object on the stack.
Tests: animations/transform-animation-event-destroy-element.html
transitions/transform-transition-event-destroy-element.html
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setChanged): (WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h: (WebCore::AnimationBase::clearRenderer):
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear):
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
- page/animation/CompositeAnimation.h:
- 16:09 Changeset [38767] by
-
2008-11-25 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Remove the unused member function JSFunction::getParameterName().
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
- 15:32 Changeset [38766] by
-
Better wx build fix - support PurgeableBuffer on Mac.
- 15:17 Changeset [38765] by
-
Add GeoleocationServiceGtk stubs and integrate it into the buildsystem
Add stubs for a Gtk Implementation.
- 15:17 Changeset [38764] by
-
Add Geolocation support to the configure.ac
Add an option to build WebKit/Gtk+ with Geolocation. The
implementation will be using Gypsy.
- 15:07 Changeset [38763] by
-
2008-11-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Polymorpic caching for get by id chain. Similar to the polymorphic caching already implemented
for self and proto accesses (implemented by allowing multiple trampolines to be JIT genertaed,
and linked together) - the get by id chain caching is implemented as a genericization of the
proto list caching, allowing cached access lists to contain a mix of proto and proto chain
accesses (since in JS style inheritance hierarchies you may commonly see a mix of properties
being overridden on the direct prototype, or higher up its prototype chain).
In order to allow this patch to compile there is a fix to appease gcc 4.2 compiler issues
(removing the jumps between fall-through cases in privateExecute).
This patch also removes redundant immediate checking from the reptach code, and fixes a related
memory leak (failure to deallocate trampolines).
~2% progression on v8 tests (bulk on the win on deltablue)
- bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures):
- interpreter/Interpreter.cpp: (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::getPolymorphicAccessStructureListSlot): (JSC::Interpreter::cti_op_get_by_id_proto_list):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JIT.h: (JSC::JIT::compileGetByIdChainList):
- 15:00 Changeset [38762] by
-
wx build fix - we don't support PurgeableBuffer on Leopard for now.
- 14:46 Changeset [38761] by
-
2008-11-25 Antti Koivisto <antti@apple.com>
Reviewed by Mark Rowe.
Fix https://bugs.webkit.org/show_bug.cgi?id=22483
Assertion failure in CachedResource::makePurgeable during layout tests
Deleting SVG image can re-enter destroyDecodedData.
- loader/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
- 13:24 Changeset [38760] by
-
2008-11-25 Dean Jackson <dino@apple.com>
Add a new work-in-progress proposal for pointer-events in
HTML content. Also note that the Media Queries extensions
are not at all official.
- specs/MediaQueriesExtensions.html:
- specs/PointerEventsProperty.html: Added.
- specs/index.html:
- 13:00 Changeset [38759] by
-
2008-11-25 Darin Fisher <darin@chromium.org>
Disabling these newly added tests since they fail in some configurations.
- http/tests/misc/submit-get-in-utf7.html: Removed.
- http/tests/misc/submit-get-in-utf7.html-disabled: Copied from http/tests/misc/submit-get-in-utf7.html.
- http/tests/misc/submit-post-in-utf7.html: Removed.
- http/tests/misc/submit-post-in-utf7.html-disabled: Copied from http/tests/misc/submit-post-in-utf7.html.
- http/tests/misc/url-in-utf7.html: Removed.
- http/tests/misc/url-in-utf7.html-disabled: Copied from http/tests/misc/url-in-utf7.html.
- 12:43 Changeset [38758] by
-
Build fix. Use WebCore::Frame::loader instead of QWebFrame
- 12:02 Changeset [38757] by
-
Add bug URL to ChangeLog.
- 12:01 Changeset [38756] by
-
2008-11-25 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
Workers on threads.
No observable change in behavior, so no test.
- platform/text/PlatformString.h:
- platform/text/String.cpp: (WebCore::String::substringCopy):
- platform/text/StringImpl.cpp: (WebCore::StringImpl::substringCopy):
- platform/text/StringImpl.h: Added the ability to copy a substring.
- xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::PreflightResultCache::PreflightResultCache): (WebCore::PreflightResultCacheItem::addToAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge): (WebCore::PreflightResultCacheItem::parse): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::PreflightResultCache::shared): (WebCore::PreflightResultCache::appendEntry): (WebCore::PreflightResultCache::canSkipPreflight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponsePreflight): Made the PreflightResultCache threadsafe.
(WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
(WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
Consolidation of duplicate logic.
- 11:31 Changeset [38755] by
-
2008-11-24 Jungshik Shin <jshin@chromium.org>
Reviewed by Darin Adler.
For Unicode encodings other than UTF-8, use UTF-8 for
form submission and URL query part encoding.
Tests: http/tests/misc/submit-get-in-utf16be.html
http/tests/misc/submit-get-in-utf16le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/submit-get-in-utf7.html
http/tests/misc/submit-post-in-utf16be.html
http/tests/misc/submit-post-in-utf16le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-post-in-utf7.html
http/tests/misc/url-in-utf16be.html
http/tests/misc/url-in-utf16le.html
http/tests/misc/url-in-utf32be.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/url-in-utf7.html
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):
- platform/KURL.cpp: (WebCore::KURL::KURL):
- platform/text/TextEncoding.cpp: (WebCore::UTF7Encoding): (WebCore::TextEncoding::isNonByteBasedEncoding): (WebCore::TextEncoding::closestByteBasedEquivalent): (WebCore::TextEncoding::encodingForFormSubmission):
- platform/text/TextEncoding.h:
- 11:21 Changeset [38754] by
-
2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441
- Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
- Tweaked the generated files to better match our coding style.
- dom/make_names.pl:
- 10:25 Changeset [38753] by
-
2008-11-25 Jack Wootten <jackwootton@gmail.com>
Bug 20125: http://webkit.org/ missing link to key documentation for new developers.
Reviewed by David Kilzer.
- projects/documentation/index.html: Added link to "Introduction to WebKit Objective-C Programming Guide".
- 07:49 Changeset [38752] by
-
Actually landing tests for bug 22455 - Add support for Worker.terminate().
- 02:25 Changeset [38751] by
-
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=9001
Javascript stops running before replacement page data arrives
Adding a test for a bug that is longer reproducible.
- http/tests/misc/resources/hang-connection.php: Added.
- http/tests/misc/timer-vs-loading-expected.txt: Added.
- http/tests/misc/timer-vs-loading.html: Added.
- 02:05 Changeset [38750] by
-
2008-11-25 Cameron Zwarich <zwarich@apple.com>
Reviewed by Alexey Proskuryakov.
Move the collect() call in Heap::heapAllocate() that is conditionally
compiled under COLLECT_ON_EVERY_ALLOCATION so that it is before we get
information about the heap. This was causing assertion failures for me
while I was reducing a bug.
- runtime/Collector.cpp: (JSC::Heap::heapAllocate):
- 00:51 Changeset [38749] by
-
2008-11-24 Dean McNamee <deanm@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22350
Allow layout tests to run in php cgi mode
- http/tests/misc/refresh-headers.php:
- http/tests/misc/resources/redirect-result.php:
- http/tests/misc/resources/referrer-result.php:
- http/tests/misc/xhtml.php: Stop using getallheaders(), which is only implemented by mod_php, so that the tests could run through lighttpd.
- 00:13 Changeset [38748] by
-
WebCore:
2008-11-24 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit
HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
there were no scripts left to execute.
If m_hasScriptsWaitingForStylesheets becomes true during script execution
bail out from executing more scripts synchronously.
Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
LayoutTests:
2008-11-24 Antti Koivisto <antti@apple.com>
Reviewed by Darin Adler.
Test for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit
- fast/tokenizer/nested-cached-scripts-and-stylesheet-expected.txt: Added.
- fast/tokenizer/nested-cached-scripts-and-stylesheet.html: Added.
- fast/tokenizer/resources/load-stylesheet-and-document-write-script.js: Added.
11/24/08:
- 23:23 Changeset [38747] by
-
2008-11-24 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 13790: Function declarations are not treated as statements (used to affect starcraft2.com)
<https://bugs.webkit.org/show_bug.cgi?id=13790>
Modify the parser to treat function declarations as statements,
simplifying the grammar in the process. Technically, according to the
grammar in the ECMA spec, function declarations are not statements and
can not be used everywhere that statements can, but it is not worth the
possibility compatibility issues just to stick to the spec in this case.
- parser/Grammar.y:
- parser/Nodes.cpp: (JSC::FuncDeclNode::emitBytecode): Avoid returning ignoredResult() as a result, because it causes a crash in DoWhileNode::emitBytecode().
LayoutTests:
- fast/js/function-declaration-statement-expected.txt: Added.
- fast/js/function-declaration-statement.html: Added.
- fast/js/resources/function-declaration-statement.js: Added.
- 22:47 Changeset [38746] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=22465
Define KURL::copy() and use it in WorkerThread.cpp
- dom/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread):
- platform/KURL.cpp: (WebCore::KURL::copy):
- platform/KURL.h:
- 22:10 Changeset [38745] by
-
2008-11-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Unroll the regexp matching loop by 1. 10% speedup on simple matching
stress test. No change on SunSpider.
(I decided not to unroll to arbitrary levels because the returns diminsh
quickly.)
- wrec/WREC.cpp: (JSC::WREC::compileRegExp):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateJumpIfEndOfInput): (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
- wrec/WRECGenerator.h:
- wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::parsePattern):
- 19:43 Changeset [38744] by
-
Reviewed by Sam Weinig.
Name enum values in a style guide compatible way.
Allow WMLIntrinsicEvent inclusion, without needing other includes.
- 19:36 Changeset [38743] by
-
Reviewed by Sam Weinig.
Add wmlPageStateForDocument() helper function and use it in some places.
- 19:16 Changeset [38742] by
-
Fix ChangeLog spelling plus credit weinig.
- 19:11 Changeset [38741] by
-
2008-11-24 Antti Koivisto <antti@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=22214
Keep dead resourcs in memory cache in purgeable memory.
<rdar://problem/6333088>
OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
areas as less important. Under memory pressure system can steal pages that have
been marked purgeable for (hopefully) better uses. This is ideal for caches.
Only resources larger than 16KB will be moved to the purgsable memory.
- WebCore.base.exp:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::resourceForURL): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpStats):
- loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved): (WebCore::CachedCSSStyleSheet::sheetText):
- loader/CachedCSSStyleSheet.h:
- loader/CachedImage.cpp: (WebCore::CachedImage::addClient): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::destroyDecodedData):
- loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::makePurgeable): (WebCore::CachedResource::isPurgeable): (WebCore::CachedResource::wasPurged):
- loader/CachedResource.h: (WebCore::CachedResource::data):
- loader/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
- platform/PurgeableBuffer.h: Added. (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::size): (WebCore::PurgeableBuffer::): (WebCore::PurgeableBuffer::purgePriority): (WebCore::PurgeableBuffer::isPurgeable): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::data): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::makePurgeable):
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptPurgeableBuffer): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::releasePurgeableBuffer):
- platform/SharedBuffer.h: (WebCore::SharedBuffer::hasPurgeableBuffer):
- platform/cf/SharedBufferCF.cpp:
- platform/mac/PurgeableBufferMac.cpp: Added. (WebCore::PurgeableBuffer::PurgeableBuffer): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::makePurgeable): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::data):
- 18:20 Changeset [38740] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Fix bustage.
- History/WebHistory.mm:
- 17:53 Changeset [38739] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Fix bustage.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled):
- 17:45 Changeset [38738] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Fix bustage.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
- WebCoreSupport/EditorClientQt.h:
- 17:33 Changeset [38737] by
-
2008-11-24 Dean Jackson <dino@apple.com>
Document the work-in-progress proposed extensions to
CSS 3 Media Queries.
- specs/MediaQueriesExtensions.html: Added.
- specs/index.html:
- 16:23 Changeset [38736] by
-
Reviewed by George Staikos & Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22430
Regenerate WML layout test results after implementing WML specific <card> handling:
Only the first <card> element should be visible after loading the document, others
can be shown by using the <go> task element.
- 16:18 Changeset [38735] by
-
2008-11-24 Glenn Wilson <gwilson@chromium.org>
Reviewed by Alexey Proskuryakov.
Added support for clients that wish to disable smart insert/delete
and enable the "trailing whitespace selection" work-around.
Tests: editing/selection/doubleclick-whitespace.html
- editing/Editor.cpp: (WebCore::Editor::selectTrailingWhitespaceEnabled):
- editing/Editor.h:
- editing/Selection.cpp: (WebCore::Selection::includeTrailingWhitespace):
- editing/Selection.h:
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
- page/EditorClient.h:
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
- 16:04 Changeset [38734] by
-
Not reviewed. Forgot to include WMLPageState.h in last commit.
- 16:02 Changeset [38733] by
-
Reviewed by Oliver Hunt & Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22431
Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.
- 15:32 Changeset [38732] by
-
WebCore:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
- loader/FrameLoaderClient.h: Remove argument.
WebKit/gtk:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument.
- WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
WebKit/mac:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.
WebKit/qt:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): Get the URL from the DocumentLoader.
- WebCoreSupport/FrameLoaderClientQt.h: Remove argument.
WebKit/win:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.
- WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
WebKit/wx:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- https://bugs.webkit.org/show_bug.cgi?id=22470 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory): Remove argument.
- WebKitSupport/FrameLoaderClientWx.h: Ditto.
- 15:28 Changeset [38731] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Fix bustage.
- Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
- 15:12 Changeset [38730] by
-
2008-11-24 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Darin Adler.
Add plumbing for tickmark support for the scrollbars. The painting code
for the scrollbar just needed to call paintTickmarks at the right time
and a default no-op implementation is provided, which the ports will
need to override.
- platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
- platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintTickmarks):
- 15:07 Changeset [38729] by
-
2008-11-24 Darin Fisher <darin@chromium.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=22448
Create an abstraction for JSC::SourceCode
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/CachedScriptSourceProvider.h:
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
- bindings/js/ScriptController.h:
- bindings/js/ScriptSourceCode.h: Added. (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::length): (WebCore::ScriptSourceCode::jsSourceCode):
- bindings/js/WorkerScriptController.cpp: (WebCore::Workevn ScriptController::evaluate):
- bindings/js/WorkerScriptController.h:
- dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElementData::evaluateScript): (WebCore::ScriptElementData::notifyFinished):
- dom/ScriptElement.h:
- dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
- dom/WorkerThread.h:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
- dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
- dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::notifyFinished):
- html/HTMLTokenizer.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript):
- loader/FrameLoader.h:
- 14:48 Changeset [38728] by
-
WebCore:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- finish https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures
- WebCore.base.exp: Exported new function.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
- loader/DocumentLoader.h: Ditto.
WebKit/mac:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- finish https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures
Last time around I did this only for the back/forward list and missed the
global history list.
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:wasFailure:]): Added wasFailure argument. Set the flag on the newly created history item. Also eliminated the use of autorelease on the added-items array.
- History/WebHistoryInternal.h: Ditto.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory. Given that this function gets other data from the DocumentLoader, I think we should get rid of the KURL argument, but that's a separate issue so I don't do it in this patch.
WebKit/win:
2008-11-24 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
- finish https://bugs.webkit.org/show_bug.cgi?id=22295 track which history items are from page load failures
Last time around I did this only for the back/forward list and missed the
global history list.
- Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory.
- WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument. Set the flag on the newly created history item.
- WebHistory.h: Ditto.
- WebHistoryItem.cpp: (WebHistoryItem::setLastVisitWasFailure): Added.
- WebHistoryItem.h: Ditto.
- 14:46 Changeset [38727] by
-
Update radar in an old Changelog entry to be "more correct"
- 14:33 Changeset [38726] by
-
Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class
- 14:31 Changeset [38725] by
-
Tag the Safari 3.2.1 release.
JavaScriptCore, JavaScriptGlue and WebCore are unchanged from Safari 3.2. WebKit is WebKit-x525.27.1.
- 13:54 Changeset [38724] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Fix Windows build: selectionRect() -> selectionBounds().
- page/win/FrameCGWin.cpp: (WebCore::imageFromSelection):
- 13:42 Changeset [38723] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Fix call to Frame::selectionBounds in Windows build.
- WebView.cpp: (WebView::selectionRect):
- 13:40 Changeset [38722] by
-
2008-11-24 Glenn Wilson <gwilson@chromium.org>
Reviewed by Darin Adler.
http://bugs.webkit.org/show_bug.cgi?id=18703
"Changing the 'size' property on a text input does not affect its length"
Text fields would not repaint themselves after having their "size"
attributes modified. This fix tells the object to recalculate its
width and repaint itself when its "size" attribute is parsed.
Test: fast/js/text-field-resize.html
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
- 13:35 Changeset [38721] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Fix call to Frame::selectionBounds in Tiger build.
- WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
- 13:25 Changeset [38720] by
-
2008-11-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some unnecessary "Generator::" prefixes.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
- 13:21 Changeset [38719] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
Followup from changes for https://bugs.webkit.org/show_bug.cgi?id=22433
Make RenderView::selectionRect() private to cause compile-time
errors if someone tries to call it.
- rendering/RenderView.h:
- 13:20 Changeset [38718] by
-
2008-11-24 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Made a bunch of WREC::Parser functions private, and added an explicit
"reset()" function, so a parser can be reused.
- wrec/WRECParser.h: (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::generator): (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::multiline): (JSC::WREC::Parser::recordSubpattern): (JSC::WREC::Parser::numSubpatterns): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::parseAlternative): (JSC::WREC::Parser::reset):
- 12:16 Changeset [38717] by
-
2008-11-21 Dean Jackson <dino@apple.com>
CSSAnimation.html:
- animation-name should accept IDENT not <string>
- animation-play-state marked as "about to be removed"
- more description of when an animation is applied, that they snapshot keyframes and values as they start and how they need to be removed to reset.
CSSTransitions.html:
- list of animatable properties and how to animate property types.
- specify that values for bezier points outside of [0,1] are invalid.
CSSTransforms.html:
- split into 2d and 3d specifications
- transform-origin now matches background-position definition.
- describe how to animate between lists of transforms
CSSTransforms3D.html
- new specification which is the 3d parts of transforms
- perspective must be > 0
- perspective-origin also matches background-position
- describe how to animate between lists of transforms, but this time in 3d which is harder.
- 11:58 Changeset [38716] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Rename RenderView::selectionRect() to selectionBounds(), to remove
longstanding ambiguity with the base class selectionRect() method.
Do the same on Frame for consistency with RenderView. Assert
that RenderView::selectionRect() is never called.
- 11:41 Changeset [38715] by
-
2008-11-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=17122
[GTK] Bad font default settings
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Use default font size 12 instead of 10
- 11:29 Changeset [38714] by
-
2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441
- Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of an AtomicString.
- Updated the elements' constructors and the callers to reflect the previous change.
- dom/Document.cpp: (WebCore::Document::createElement):
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
- html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode):
- html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor): (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::keygenConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor): (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::preConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::modConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableColConstructor): (WebCore::tableRowConstructor): (WebCore::tableCellConstructor): (WebCore::tableSectionConstructor): (WebCore::brConstructor): (WebCore::quoteConstructor): (WebCore::marqueeConstructor): (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::HTMLElementFactory::createHTMLElement):
- html/HTMLElementFactory.h:
- html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
- 11:21 Changeset [38713] by
-
2008-11-24 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alexey Proskuryakov.
Correct bad default constructor for Cairo FontPlatformData so that
the m_scaledFont member is initialized. Previously this would be
set to 0xbaadf00d, which would result in infinite loops while
attempting to deal with the font cache.
- platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
- 10:37 Changeset [38712] by
-
2008-11-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
Add script that attempts to detect virtual methods
whose signatures differ only by constness (which can
indicate a programming error).
- Scripts/detect-mismatched-virtual-const: Added.
- 10:21 Changeset [38711] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22455
Add support for Worker.terminate()
Test: fast/workers/worker-terminate.html
- dom/Worker.idl:
- dom/Worker.cpp:
- dom/Worker.h: Added terminate().
- dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
- dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked to terminate (this is not mentioned in draft spec, but makes sense anyway). (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount to only track messages that were posted to worker thread, avoiding a leak if the script could not be loaded. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating. (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context was destroyed, the worker object may still be alive now, so don't delete self in this case. (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or remember to stop it when it is created. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity if the thread asked to stop anyway. (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
- dom/WorkerThread.cpp:
- dom/WorkerThread.h: Fixed a race condition in stop().
- 09:04 Changeset [38710] by
-
[Gtk+] Implement TestNetscapePlugin for Gtk+ port.
LayoutTests:
2008-11-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Some tests in plugins/ directory now pass.
- platform/gtk/Skipped:
WebCore/ChangeLog:
2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark Rowe.
[Gtk+] Add configure option to enable Web Workers and enable it by default
Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.
- GNUmakefile.am:
WebKit/gtk/ChangeLog
2008-11-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
Implement a semi-private function for adding a directory to
PluginDatabase's paths.
- webkit/webkitprivate.h:
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory):
WebKitTools/ChangeLog
2008-11-24 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther.
[Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
build.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
- DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
- DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
- DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
- DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
- DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
- GNUmakefile.am:
- 06:42 Changeset [38709] by
-
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22428
xmlhttprequest-onProgress-open-should-zero-length.html fails intermittently
- http/tests/xmlhttprequest/resources/big-response.php: Reduce the size of big response to make the test faster, but practically guarantee that the response will be delivered in many chunks.
- http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt:
- http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Made the test more reliable by comparing final response position with known resource size.
- 06:40 Changeset [38708] by
-
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22439
Won't load stylesheets with filenames less than 2 characters long in xhtml.
Test: http/tests/misc/single-character-pi-stylesheet.xhtml
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Fix up the logic.
- 05:07 Changeset [38707] by
-
The "WARNING" should not be there, remove it. There was no need to add a test case.
- 05:01 Changeset [38706] by
-
[Gtk+] We are passing all but one worker test. Enable them.
We fail on fast/workers/worker-location.html due some weird
issue with the bidi resolver "skipping" whitespace at the end
of the line.
- 04:56 Changeset [38705] by
-
[Gtk+] Add configure option to enable Web Workers and enable it by default
Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.
- 03:54 Changeset [38704] by
-
Build fix (for Windows Cairo port?)
- page/DOMWindow.idl: Ese ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as the ENABLE macro is not available in idls.
- 03:12 Changeset [38703] by
-
2008-11-24 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Mark Rowe.
Add test cases to ensure the PIC trampolines for prototype and prototype chain
accesses properly check for JSImmediate values, rather than segfaulting.
- fast/js/pic/cached-prototype-then-immediate-expected.txt: Added.
- fast/js/pic/cached-prototype-then-immediate.html: Added.
- 02:59 Changeset [38702] by
-
Let gdb-safari accept the --debug and --release options once more.
Reviewed by Alexey Proskuryakov.
- Scripts/gdb-safari:
- 02:28 Changeset [38701] by
-
tyop fix in jsc Changelog
- 02:14 Changeset [38700] by
-
2008-11-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Implement repatching for get by id chain.
Previously the access is performed in a function stufb, in the reptach form
the trampoline is not called to; instead the hot patch is relinkde to jump
directly to the trampoline, if it fails it will jump to the slow case.
https://bugs.webkit.org/show_bug.cgi?id=22449
3% progression on deltablue.
- jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- 00:09 Changeset [38699] by
-
2008-11-24 Joerg Bornemann <joerg.bornemann@trolltech.com>
Reviewed by Simon Hausmann.
Various small compilation fixes to make the Qt port of WebKit
compile on Windows CE.
- config.h: Don't set _CRT_RAND_S for CE, it's not available.
- jsc.cpp: Disabled use of debugger includes for CE. It does not have the debugging functions.
- runtime/DateMath.cpp: Use localtime() on Windows CE.
- wtf/Assertions.cpp: Compile on Windows CE without debugger.
- wtf/Assertions.h: Include windows.h before defining ASSERT.
- wtf/MathExtras.h: Include stdlib.h instead of xmath.h.
- wtf/Platform.h: Disable ERRNO_H and detect endianess based on the Qt endianess. On Qt for Windows CE the endianess is defined by the vendor specific build spec.
- wtf/Threading.h: Use the volatile-less atomic functions.
- wtf/dtoa.cpp: Compile without errno.
- wtf/win/MainThreadWin.cpp: Don't include windows.h on CE after Assertions.h due to the redefinition of ASSERT.
11/23/08:
- 22:04 Changeset [38698] by
-
2008-11-22 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22421
Added ScriptValue to Visual Studio and XCode projects.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- 22:01 Changeset [38697] by
-
2008-11-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Replace accidentally deleted immediate check from get by id chain trampoline.
https://bugs.webkit.org/show_bug.cgi?id=22413
- jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdChain):
- 14:19 Changeset [38696] by
-
Add gtk-doc configuration/source for the WebKit/Gtk+ Reference Manual
These files will be used by gtk-doc to generate the documentation. They
contain information how to group the symbols of our API, which objects
to inspect during the generation of the manual and how to display the
manual.
- 14:18 Changeset [38695] by
-
Make gtk-doc happy with the existing API documentation
- Mark the *Private pointers in the struct private
- Use Returns: where gtk-doc wants us to
- Fix the parameters to make gtk-doc happy
- Fix signal references
- 00:21 Changeset [38694] by
-
2008-11-23 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Holger Freyther. Landed by Jan Alonzo.
Get SVG tests tested on GTK port.
- Scripts/webkitdirs.pm:
11/22/08:
- 10:47 Changeset [38693] by
-
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22426
Add WMLInstrinsicEvent/EventHandler implementation. Code not yet used.
- 08:37 Changeset [38692] by
-
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22423
Add <go> stub implementation. Add complete <prev>/<refresh> and <setvar> implementation.
Activate code handling <setvar> registration in WMLTaskElement.
- 07:39 Changeset [38691] by
-
Not reviewed. Forgot to include WMLPageState.* in the last commit.
11/21/08:
- 23:46 Changeset [38690] by
-
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=22400
Add a stress test for concurrent JS execution
- fast/workers/resources/stress-js-execution.js: Added.
- fast/workers/stress-js-execution-expected.txt: Added.
- fast/workers/stress-js-execution.html: Added. Tests that the basics don't cause a crash.
- 23:42 Changeset [38689] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22397
Worker threads are not destroyed if running a JS loop
Since the event loop is not ever entered again in this case, the fix necessarily involves
some shared data hackery.
- dom/WorkerThread.cpp: (WebCore::WorkerThread::stop):
- dom/WorkerThread.h: Added a stop() method, which asks the thread to exit as soon as possible. In the future, it may need to abort other kinds of synchronous processing, such as importScripts or XHR.
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
- bindings/js/WorkerScriptController.h: Added a forbidExecution() method, which interrupts currently running JS, and makes any future calls to evaluate() return immediately.
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed): Call WorkerThread::stop().
- 19:34 Changeset [38688] by
-
2008-11-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add (really) polymorphic caching for get by id self.
Very similar to caching of prototype accesses, described below.
Oh, also, probably shouldn't have been leaking those structure list objects.
4% preogression on deltablue.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::PrototypeStructureList::derefStructures):
- bytecode/Instruction.h:
- bytecode/Opcode.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_get_by_id_self_fail):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::patchGetByIdSelf):
- jit/JIT.h: (JSC::JIT::compileGetByIdSelfList):
- 19:24 Changeset [38687] by
-
Reviewed by Kevin Ollivier.
Maintain an EditCommand stack in WebFramePrivate, and expose Undo and
Redo in wxWebView.
https://bugs.webkit.org/show_bug.cgi?id=22403
- 19:21 Changeset [38686] by
-
forgot to update the date when preparing the patch.
- 19:08 Changeset [38685] by
-
Reviewed by Kevin Ollivier.
Improve wx image drawing performance considerably when using wxGraphicsContext
by avoiding unnecessary copies and drawing.
https://bugs.webkit.org/show_bug.cgi?id=22404
- 18:27 Changeset [38684] by
-
Reviewed by Kevin Ollivier.
Implementation of AffineTransform::mapRect for wx.
https://bugs.webkit.org/show_bug.cgi?id=22401
- 17:50 Changeset [38683] by
-
WebCore:
2008-11-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
Change link editing behavior to match TextEdit and MS Word when editing before and after
a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we
used to, so it's difficult to get out of link editing mode):
When inserting before or after a link, always insert content outside of the link. This
makes it impossible to get stuck in link editing mode, while making it slightly more
difficult to edit link labels. WebKit editors that care about this can add UI for editing
link labels, like GMail and GoogleDocs have done. We never actually had any bugs complaining
about how it was difficult to edit link labels at the start/end, the code was just introduced
with another bug fix without much thought.
Don't remember removed links anymore, no other editor does this and it made it
difficult/impossible to get out of link editing mode. This code was added to fix
<rdar://problem/4069359>, which is fixed instead by removing the styles from an
enclosing anchor element from those styles that we remember when we delete content.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
- editing/CompositeEditCommand.h:
- editing/DeleteSelectionCommand.cpp: (WebCore::removeEnclosingAnchorStyle): (WebCore::DeleteSelectionCommand::saveTypingStyleState): (WebCore::DeleteSelectionCommand::doApply):
- editing/DeleteSelectionCommand.h:
- editing/EditCommand.cpp: (WebCore::EditCommand::apply):
- editing/Editor.cpp: (WebCore::Editor::appliedEditing):
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): (WebCore::InsertTextCommand::input):
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
- editing/SelectionController.h:
LayoutTests:
2008-11-21 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin Adler.
<rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
Removed tests for behaviors that we're no longer interested in:
- editing/deleting/delete-link-1.html: Removed.
- platform/mac/editing/deleting/delete-link-1-expected.checksum: Removed.
- platform/mac/editing/deleting/delete-link-1-expected.png: Removed.
- platform/mac/editing/deleting/delete-link-1-expected.txt: Removed.
- editing/execCommand/19653-4-expected.txt: Removed.
- editing/execCommand/19653-4.html: Removed.
Reflects new behavior (don't remember removed anchors):
- platform/mac/editing/deleting/5168598-expected.txt:
Reflects new behavior. Also made this test cross-platform:
- editing/inserting/insert-before-link-1-expected.txt: Added.
- editing/inserting/insert-before-link-1.html:
- platform/mac/editing/inserting/insert-before-link-1-expected.checksum: Removed.
- platform/mac/editing/inserting/insert-before-link-1-expected.png: Removed.
- platform/mac/editing/inserting/insert-before-link-1-expected.txt: Removed.
- 17:48 Changeset [38682] by
-
2008-11-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed many crashes seen 'round the world (but only in release builds).
Update outputParameter offset to reflect slight re-ordering of push
instructions in r38669.
- wrec/WRECGenerator.cpp:
- 17:38 Changeset [38681] by
-
2008-11-21 Alice Liu <alice.liu@apple.com>
Rubber-stamped by Dan Bernstein.
fixed <rdar://6340771> crashing on print preview
- platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawWindowsBitmap):
- 16:11 Changeset [38680] by
-
2008-11-21 Darin Fisher <darin@chromium.org>
Reviewed by Geoffrey Garen.
- Abstract away JSC
- usage in WebCore/xml
- bindings/js/ScriptString.h: Added. (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator JSC::UString): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=):
- inspector/InspectorController.cpp: (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): (WebCore::InspectorResource::setXMLHttpRequestProperties): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
- inspector/InspectorController.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::dropProtection): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
- xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::setLastSendURL):
- 14:54 Changeset [38679] by
-
2008-11-21 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Destroy script decoded data on a zero-delay timer after
decoding. This means we now have no decoded script data
at the end of Membuster.
- loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::decodedDataDeletionTimerFired):
- loader/CachedScript.h:
- 14:49 Changeset [38678] by
-
2008-11-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler
RenderBox::absoluteClippedOverflowRect() needs to inflate the rect by
maximalOutlineSize(), since a child might have an outline which projects
outside the parent overflowRect().
We also need to ensure that maximalOutlineSize() is updated early in styleDidChange,
so that it is valid for these repaints.
Test: fast/repaint/outline-child-repaint.html
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::absoluteClippedOverflowRect):
- 14:03 Changeset [38677] by
-
2008-11-21 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk, Qt, and Wx build fix.
Add LinkHash.cpp in the build scripts.
Add LinkHash.h to Gtk's build script.
LinkHash.cpp/h was introduced in r38661.
- GNUmakefile.am:
- WebCore.pro:
- WebCoreSources.bkl:
- 13:40 Changeset [38676] by
-
2008-11-21 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Third step in https://bugs.webkit.org/show_bug.cgi?id=22394
Be more eager in destroying script decoded data
Destroy the decoded data when all clients are removed from a CachedScript.
- loader/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved):
- loader/CachedScript.h: (WebCore::CachedScript::allClientsRemoved):
- 13:34 Changeset [38675] by
-
2008-11-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more RegExp refactoring.
Deployed a helper function for reading the next character. Used the "link
vector of jumps" helper in a place I missed before.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary):
- wrec/WRECGenerator.h:
- 13:26 Changeset [38674] by
-
2008-11-21 Cameron Zwarich <zwarich@apple.com>
Reviewed by Sam Weinig.
Add a test for <rdar://problem/4268912>, which was fixed in r13294 (!!).
- fast/js/resources/string-sort.js:
- fast/js/string-sort-expected.txt:
- 13:20 Changeset [38673] by
-
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=22402
Replace abort() with CRASH()
- wtf/Assertions.h: Added a different method to crash, which should work even is 0xbbadbeef is a valid memory address.
- runtime/Collector.cpp:
- wtf/FastMalloc.cpp:
- wtf/FastMalloc.h:
- wtf/TCSpinLock.h: Replace abort() with CRASH().
- 12:09 Changeset [38672] by
-
Reverted fix for bug 22042 (Replace abort() with CRASH()), because it was breaking
FOR_EACH_OPCODE_ID macro somehow, making Safari crash.
- 12:01 Changeset [38671] by
-
2008-11-21 Pierre-Olivier Latour <pol@apple.com>
WebKit/mac:
Reviewed by Dan Bernstein.
WebKit should be using Device RGB colorspace everywhere for
consistency.
- WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _colorAsString:]):
WebCore:
Reviewed by Dan Bernstein.
WebKit should be using Device RGB colorspace everywhere for
consistency.
- page/mac/AccessibilityObjectWrapper.mm: (CreateCGColorIfDifferent):
- platform/graphics/mac/ColorMac.h:
- platform/graphics/mac/ColorMac.mm: (WebCore::nsColor): (+[WebCoreControlTintObserver controlTintDidChange]):
- rendering/RenderThemeMac.mm: (WebCore::convertNSColorToColor): (WebCore::menuBackgroundColor):
LayoutTests:
Reviewed by Dan Bernstein.
WebKit should be using Device RGB colorspace everywhere for
consistency.
- platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
- 11:32 Changeset [38670] by
-
2008-11-20 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Darin Adler.
Bug 22388: Add JSInterfaceName to the .in files
https://bugs.webkit.org/show_bug.cgi?id=22388
Add JSInterfaceName that is similar to interfaceName but
for the JS wrappers. JSInterfaceName is always equal to interfaceName
unless explicitly set.
- dom/make_names.pl:
- html/HTMLTagNames.in:
- svg/svgtags.in:
- 11:31 Changeset [38669] by
-
2008-11-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more RegExp refactoring.
Moved all assembly from WREC.cpp into WRECGenerator helper functions.
This should help with portability and readability.
Removed ASSERTs after calls to executableCopy(), and changed
executableCopy() to ASSERT instead.
- assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompilePatchGetArrayLength):
- wrec/WREC.cpp: (JSC::WREC::compileRegExp):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
- wrec/WRECGenerator.h:
- wrec/WRECParser.h: (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::generator):
- 11:27 Changeset [38668] by
-
2008-11-21 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Alexey Proskuryakov.
Debug WebKit crashes on launch because of threading not being initialized early enough.
- WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Call JSC::InitializeThreading().
- 11:25 Changeset [38667] by
-
2008-11-21 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Add missing reference images for tests added as part of
https://bugs.webkit.org/show_bug.cgi?id=21261
- platform/mac/animations/animation-drt-api-expected.checksum: Added.
- platform/mac/animations/animation-drt-api-expected.png: Added.
- platform/mac/transitions/transition-drt-api-expected.checksum: Added.
- platform/mac/transitions/transition-drt-api-expected.png: Added.
- 11:07 Changeset [38666] by
-
Build fix.
- wtf/Assertions.h: Use ::abort for C++ code.
- 10:49 Changeset [38665] by
-
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=22402
Replace abort() with CRASH()
- wtf/Assertions.h: Added abort() after an attempt to crash for extra safety.
- runtime/Collector.cpp:
- wtf/FastMalloc.cpp:
- wtf/FastMalloc.h:
- wtf/TCSpinLock.h: Replace abort() with CRASH().
- 10:44 Changeset [38664] by
-
2008-11-21 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Second step in https://bugs.webkit.org/show_bug.cgi?id=22394
Be more eager in destroying script decoded data
Use a new CachedScriptSourceProvider to keep CachedScripts as
CachedScripts, even down into JSC. This has the added benefit
of showing the CachedScripts as live in the Caches window.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/CachedScriptSourceProvider.h: Added. (WebCore::CachedScriptSourceProvider::create): (WebCore::CachedScriptSourceProvider::~CachedScriptSourceProvider): (WebCore::CachedScriptSourceProvider::getRange): (WebCore::CachedScriptSourceProvider::data): (WebCore::CachedScriptSourceProvider::length): (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider): (WebCore::makeSource):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
- 10:22 Changeset [38663] by
-
Fix debug-only build bustage due to a typo in an assert, and add new
files to the Windows build.
- 10:22 Changeset [38662] by
-
2008-11-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Renamed wrec => generator.
- wrec/WRECFunctors.cpp: (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom): (JSC::WREC::GeneratePatternCharacterFunctor::backtrack): (JSC::WREC::GenerateCharacterClassFunctor::generateAtom): (JSC::WREC::GenerateCharacterClassFunctor::backtrack): (JSC::WREC::GenerateBackreferenceFunctor::generateAtom): (JSC::WREC::GenerateBackreferenceFunctor::backtrack): (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
- 09:07 Changeset [38661] by
-
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22131
Factor out visited link hashing and types into a new file, LinkHash.
This also changes the hash type to 64 bits, but does not actually use
the extra bits yet.
- 08:47 Changeset [38660] by
-
Reviewed by Alexey Proskuryakov.
No need to use getElementsByTagNameNS() in WML documents. Revert to using getElementByTagName() again.
- 07:25 Changeset [38659] by
-
Reviewed by Alexey Proskuryakov.
Fix some coding style/formatting issues in WMLAElement.
- 07:20 Changeset [38658] by
-
Reviewed by Alexey Proskuryakov.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22399
Implement <anchor> support for WML, add WMLVariables file containing helper functions
for variable support, and a WMLTaskElement base class for WMLPrev/Go/RefreshElement.
- 06:30 Changeset [38657] by
-
2008-11-21 Julien Chaffraix <jchaffraix@pleyo.com>
Rubber-stamped by Alexey Proskuryakov.
Build fix when building without WORKERS on non-POSIX, non-WINDOWS
machine.
Spotted by Mario Bensi.
- platform/text/TextCodecICU.cpp:
- 01:39 Changeset [38656] by
-
Fix ChangeLog typos.
