Timeline


and

11/28/08:

20:00 Changeset [38838] by zimmermann@webkit.org

Reviewed by Cameron Zwarich.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550

Add <timer> element support. It provides a way to execute a task with a delay.
The user is notified by firing the task associated with the <card>'s ontimer attribute.
Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)

18:52 Changeset [38837] by zimmermann@webkit.org

Reviewed by Holger Freyther.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549

Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
Changes numerous of layout tests which contain <do> elements, as they render as buttons now.

17:23 Changeset [38836] by zecke@webkit.org

2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Nikolas Zimmermann.

Simplify the code. There is no reason to have code like
if (true) return false; which is using temporary variables.

  • webkit/webkitwebview.cpp:
17:23 Changeset [38835] by zecke@webkit.org

2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Nikolas Zimmermann.

Remove bogus null checks. The WebKitWebView own's a WebCore::Page
which is owning a WebCore::ChromeClient. There is no way that a
WebCore::ChromeClient is still around when the WebKitWebView is gone.

m_webView can only be null when a ChromeClient gets constructed with
a null WebKitWebView which is not allowed.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll): (WebKit::ChromeClient::platformWindow):
16:20 Changeset [38834] by zecke@webkit.org

2008-11-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed and slightly modified by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=19130

ChromeClient::createWindow and friends need to be implemented

Code from Gustavo Noronha and Marco Barisione
<marco.barisione@collabora.co.uk> in this change set.

Implemented all the ChromeClient interfaces needed to have new
window creation functioning and exposed to client code. We
implemented a mirror GObject to the WindowFeatures object provided
by WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::setResizable):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchShow): (WebKit::FrameLoaderClient::dispatchCreatePage):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
  • webkit/webkitwebwindowfeatures.cpp: Added. (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
  • webkit/webkitwebwindowfeatures.h: Added.
13:36 Changeset [38833] by zimmermann@webkit.org

Reviewed by Sam Weinig.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545

Add onenterforward/onenterbackward/ontimer support for <card> elements.

No testing possible at the moment because WMLGoElement is not yet implemented.
After that we can add tests covering the <card> event handling.

10:14 Changeset [38832] by vestbo@webkit.org

2008-11-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Tor Arne Vestbø.

Regression seen on QtWebKit - causes a build failure on Win using MinGW

https://bugs.webkit.org/show_bug.cgi?id=22536

07:19 Changeset [38831] by hausmann@webkit.org

2008-11-28 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Fix compilation on Windows CE

Port away from the use of errno after calling strtol(), instead
detect conversion errors by checking the result and the stop
position.

07:19 Changeset [38830] by hausmann@webkit.org

2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Simon Hausmann.

Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.

07:18 Changeset [38829] by hausmann@webkit.org

2008-11-28 Simon Hausmann <hausmann@webkit.org>

Reviewed by Tor Arne Vestbø.

Fix compilation and linking on Windows CE.

Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
from the Windows'ish build.

Link against the newly required mmtimer.

07:18 Changeset [38828] by hausmann@webkit.org

2008-11-28 Simon Hausmann <hausmann@webkit.org>

Rubber-stamped by Tor Arne Vestbø.

Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.

02:23 Changeset [38827] by ap@webkit.org

2008-11-28 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=22524

Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
of XMLHttpRequest by Workers (on threads).

No observable change in behavior, so no test.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod): (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::createXMLHttpRequestStaticData): (WebCore::initializeXMLHttpRequestStaticData): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::isSafeRequestHeader): (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
  • xml/XMLHttpRequest.h:

11/27/08:

21:03 Changeset [38826] by cwzwarich@webkit.org

2008-11-27 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

r38825 made JSFunction::m_body private, but some inspector code in
WebCore sets the field. Add setters for it, and update the inspector
code to use the new getters and setters.

JavaScriptCore:

  • runtime/JSFunction.h: (JSC::JSFunction::setBody):

WebCore:

  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
18:24 Changeset [38825] by weinig@apple.com

2008-11-27 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix FIXME by adding accessor for JSFunction's m_body property.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall):
  • profiler/Profiler.cpp: (JSC::createCallIdentifierFromFunctionImp):
  • runtime/Arguments.h: (JSC::Arguments::getArgumentsData): (JSC::Arguments::Arguments):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString):
  • runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::body):
17:43 Changeset [38824] by jchaffraix@webkit.org

2008-11-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22468: Coding style: config.h should only be included in implementation files, not in header
https://bugs.webkit.org/show_bug.cgi?id=22468

Clarified the rules about config.h inclusion and added 2 new examples to illustrate it. Also
added an explanation about the implementation files.

  • coding/coding-style.html:
17:26 Changeset [38823] by weinig@apple.com

2008-11-27 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Remove unused member variables from ProgramNode.

  • parser/Nodes.h:
15:30 Changeset [38822] by dsmith@webkit.org

2008-11-26 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

Enable mouse panning feaure on Windows Cairo build.
See http://bugs.webkit.org/show_bug.cgi?id=22525

  • wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
10:03 Changeset [38821] by ap@webkit.org

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22529
Crashes seen on buildbots due to trying to stop a worker thread twice

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed): Don't try to stop the thread if it's already stopping.
08:13 Changeset [38820] by hausmann@webkit.org

WebCore:

2008-11-27 Kent Hansen <khansen@trolltech.com>

Reviewed by Simon Hausmann.

Make JavaScript bindings for Qt plugin widgets work again
this was a regression; need to handle non-NPAPI plugins as in 4.4.

WebKit:

2008-11-27 Kent Hansen <khansen@trolltech.com>

Reviewed by Simon Hausmann.

Added auto tests for making JavaScript bindings for Qt plugin widgets
work again.

05:07 Changeset [38819] by alp@webkit.org

2008-11-27 Alp Toker <alp@nuanti.com>

Change recently introduced C++ comments in Platform.h to C comments to
fix the minidom build with traditional C.

Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
API header breakage at build time.

04:21 Changeset [38818] by ddkilzer@apple.com

Fixed ChangeLog dates.

04:14 Changeset [38817] by alp@webkit.org

2008-11-27 Alp Toker <alp@nuanti.com>

Remove C++ comment from JavaScriptCore API headers (introduced r35449).
Fixes build for ANSI C applications using the public API.

  • API/WebKitAvailability.h:

11/26/08:

21:07 Changeset [38816] by zimmermann@webkit.org

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22522

Catch WML errors (invalid variable name/reference, multiple access elements, etc)
while parsing the document, and stop parsing immediately and wrap the document
fragment in a XHTML error document, just like it's done from XML parsing errors.

Until now all card elements were hidden by default (no renderer created), and
WMLDocument::finishedParsing() took care of showing the right card (either the first,
or any named card in the document, specified by document URL reference). Change this
behaviour to support displaying partially parsed WML document fragments: Mark the first
WMLCardElement inserted into the document as visible. If the document parsing finishes
without problems, WMLDocument::finishedParsing() will be called, which takes care of
showing the desired card (common case: first card in the document, which is already
visible, so nothing actually has to be done). If an error occours, the document is
correctly rendered until the error happened - wrapped in a XHTML document.

Fixes: fast/wml/err-event-binding-conflict.wml

fast/wml/err-invalid-variable-name.wml
fast/wml/err-multi-access.wml
fast/wml/err-unallowed-task-in-anchor.wml

21:04 Changeset [38815] by zimmermann@webkit.org

Not reviewed. Forgot to include this layout test update in the last commit.

19:47 Changeset [38814] by mrowe@apple.com

Fix the Tiger build.

mig.h does not always define MigTypeCheck on Tiger, which leads to problems when the generated
code is built with -Wundef.

  • Plugins/Hosted/WebKitPluginHostTypes.h:
19:23 Changeset [38813] by mrowe@apple.com

Build fix. Fix up the references to files under WebKit/mac/Plugins/Hosted.

19:14 Changeset [38812] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Fix build.


  • Configurations/Base.xcconfig:
19:14 Changeset [38811] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Move WebHostedNetscapePluginView.{h|mm} to Plugins/Hosted.


(-[WebHostedNetscapePluginView handleMouseMoved:]):
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
Fix a leak.


(-[WebHostedNetscapePluginView createPlugin]):
Instantiate the plug-in, store the plug-in proxy in the _proxy ivar.


(-[WebHostedNetscapePluginView loadStream]):
(-[WebHostedNetscapePluginView shouldStop]):
Add stubs for these.


(-[WebHostedNetscapePluginView updateAndSetWindow]):
(-[WebHostedNetscapePluginView windowFocusChanged:]):
(-[WebHostedNetscapePluginView destroyPlugin]):
(-[WebHostedNetscapePluginView startTimers]):
(-[WebHostedNetscapePluginView stopTimers]):
(-[WebHostedNetscapePluginView focusChanged]):
(-[WebHostedNetscapePluginView windowFrameDidChange:]):
(-[WebHostedNetscapePluginView mouseDown:]):
(-[WebHostedNetscapePluginView mouseUp:]):
(-[WebHostedNetscapePluginView mouseDragged:]):
(-[WebHostedNetscapePluginView mouseEntered:]):
(-[WebHostedNetscapePluginView mouseExited:]):
Call the proxy.


(-[WebHostedNetscapePluginView addWindowObservers]):
(-[WebHostedNetscapePluginView removeWindowObservers]):
Add/remove observers for when the window frame changes.


  • Plugins/WebHostedNetscapePluginView.h: Removed.
  • Plugins/WebHostedNetscapePluginView.mm: Removed.
19:00 Changeset [38810] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Add plug-in host related files to the Xcode project.


  • WebKit.xcodeproj/project.pbxproj:
18:48 Changeset [38809] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Add the plug-in host proxy and plug-in instance proxy objects.

These are just simple objects that forward their calls to the plug-in host.


  • Plugins/Hosted/NetscapePluginHostProxy.h: Added. (WebKit::NetscapePluginHostProxy::create): (WebKit::NetscapePluginHostProxy::port):
  • Plugins/Hosted/NetscapePluginHostProxy.mm: Added. (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::instantiatePlugin):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Added. (WebKit::NetscapePluginInstanceProxy::create): (WebKit::NetscapePluginInstanceProxy::renderContextID): (WebKit::NetscapePluginInstanceProxy::useSoftwareRenderer):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: Added. (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::resize): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::focusChanged): (WebKit::NetscapePluginInstanceProxy::windowFocusChanged): (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::startTimers): (WebKit::NetscapePluginInstanceProxy::mouseEvent): (WebKit::NetscapePluginInstanceProxy::stopTimers):
18:32 Changeset [38808] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein, Mark Rowe and Kevin Decker.

Add the plug-in host manager singleton.


  • Plugins/Hosted/NetscapePluginHostManager.h: Added.
  • Plugins/Hosted/NetscapePluginHostManager.mm: Added.


(WebKit::NetscapePluginHostManager::hostForPackage):
If there's an existing host proxy available, just return it. Otherwise spawn a new plug-in host and
create a new plug-in host proxy from the new plug-in host port.


(WebKit::NetscapePluginHostManager::spawnPluginHost):
Pass the plug-in host path and the preferred CPU type to the plug-in agent. When the plug-in host has
finished launching, pass it the path to the plug-in bundle.


(WebKit::NetscapePluginHostManager::initializeVendorPort):
Check in with the plug-in agent and get the new plug-in vendor port back.

18:26 Changeset [38807] by zimmermann@webkit.org

Rubber stamped by Mark Rowe.
Fix nine failing tests on the build bot. Update mac-tiger results.

17:45 Changeset [38806] by darin@chromium.org

2008-11-10 Glenn Wilson <gwilson@chromium.org>

Reviewed by Dan Bernstein.

Fixed bug http://bugs.webkit.org/show_bug.cgi?id=21953

This fixes the crash when the small-caps font variant is used
on a lower-case glyph that does not have a corresponding
upper-case glyph defined in the set of available fonts.

This changes Font.cpp to check if the font being used exists before trying to apply the small-caps variant.


Test: fast/css/small-caps-crash.html

  • platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
17:31 Changeset [38805] by darin@chromium.org

2008-10-31 Tony Chang <tony@chromium.org>

Reviewed by Oliver Hunt.

Add a new platform specific method cleanupAfterSystemDrag
that platforms can ue to clean up drag state after a
system drag. Use this method on PLAFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=21956

  • ChangeLog:
  • page/DragController.cpp: (WebCore::DragController::doSystemDrag):
  • page/DragController.h:
  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/mac/DragControllerMac.mm: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/win/DragControllerWin.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/wx/DragControllerWx.cpp:

(WebCore::DragController::cleanupAfterSystemDrag):

17:25 Changeset [38804] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

  • Plugins/Hosted/WebKitPluginHostTypes.h: Add copyright headers and fix the spacing around the *'s.
17:23 Changeset [38803] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


  • Plugins/Hosted/WebKitPluginHost.defs: Add copyright headers.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Added. Forgot to add this.
17:20 Changeset [38802] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add plug-in host .defs.

  • Plugins/Hosted/WebKitPluginAgent.defs: Added.
  • Plugins/Hosted/WebKitPluginAgentReply.defs: Added.
  • Plugins/Hosted/WebKitPluginClient.defs: Added.
  • Plugins/Hosted/WebKitPluginHost.defs: Added.
  • Plugins/Hosted/WebKitPluginHostTypes.defs: Added.
17:18 Changeset [38801] by mitz@apple.com

Added a folder for hosted plug-ins

17:07 Changeset [38800] by eric@webkit.org

Reviewed by Nikolas Zimmermann and Mark Rowe.

Add support for build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=22515
More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.

  • Scripts/build-dumprendertree:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/gdb-safari:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
17:07 Changeset [38799] by eric@webkit.org

Reviewed by Nikolas Zimmermann.

Add support for build-webkit --chromium (tested on mac)
https://bugs.webkit.org/show_bug.cgi?id=22515
Also simplified some code using checkArgv

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
17:06 Changeset [38798] by eric@webkit.org

Reviewed by Nikolas Zimmermann.

More pre-work for adding a build-webkit --chromium which works on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=22515
Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
in preparation for having a chromium cygwin and chromium mac build

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
17:06 Changeset [38797] by eric@webkit.org

Reviewed by Nikolas Zimmermann.

Pre-work for getting build-webkit --chromium to work
https://bugs.webkit.org/show_bug.cgi?id=22515
Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()

  • Scripts/build-dumprendertree:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/gdb-safari:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
17:06 Changeset [38796] by eric@webkit.org

No review, build fix only.

Fix the JSC Chromium Mac build by adding JavaScriptCore/icu into the include path

16:50 Changeset [38795] by andersca@apple.com

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe and Kevin Decker.

Minor plug-in changes.


  • Plugins/WebBaseNetscapePluginView.h: Add add/remove observer method declarations.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView isFlipped]): Move this down from WebNetscapePluginView.


  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage pluginHostArchitecture]): Getter for the plug-in host architecture.


  • Plugins/WebNetscapePluginView.mm:
16:44 Changeset [38794] by zimmermann@webkit.org

Reviewed by Oliver Hunt.

Fix path to string logic, correctly taking closed (sub-)paths into account.
Code was just broken on cg, observed by Dirk Schulze.

QPainterPath doesn't seem to expose any functionality to detect closed sub paths,
using the elementAt() function. There might be a workaround - Dirk will investigate.

16:26 Changeset [38793] by darin@chromium.org

2008-11-26 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=22519
Remove unnecessary include.

  • dom/XMLTokenizer.cpp:
15:40 Changeset [38792] by zimmermann@webkit.org

Reviewed by Oliver Hunt.
Add <noop> element support, completing the task element support.

15:07 Changeset [38791] by jchaffraix@webkit.org

2008-11-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Make more HTML elements' constructors take a QualifiedName.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLButtonElement.h:
  • html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDListElement.h:
  • html/HTMLDirectoryElement.cpp: (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDirectoryElement.h:
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::HTMLDivElement):
  • html/HTMLDivElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::keygenConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor):
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement):
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  • html/HTMLIsIndexElement.h:
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::HTMLLIElement):
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::HTMLLabelElement):
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement):
  • html/HTMLLegendElement.h:
  • html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMenuElement.h:
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::HTMLOListElement):
  • html/HTMLOListElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::handleIsindex):
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::HTMLTitleElement):
  • html/HTMLTitleElement.h:
  • html/HTMLUListElement.cpp: (WebCore::HTMLUListElement::HTMLUListElement):
  • html/HTMLUListElement.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlInputElement::MediaControlInputElement):
  • rendering/RenderFileUploadControl.cpp: (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createTimeDisplay):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement):
14:23 Changeset [38790] by zimmermann@webkit.org

Reviewed by Sam Weinig.
Fix obvious problem in WMLPageState constructor, m_page was not set to the passed Page pointer.

13:48 Changeset [38789] by darin@chromium.org

2008-11-26 Matt Perry <mpcomplete@gmail.com>

Fix Qt bustage.

See https://bugs.webkit.org/show_bug.cgi?id=22051

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet):
13:07 Changeset [38788] by darin@chromium.org

2008-11-26 Matt Perry <mpcomplete@gmail.com>

Reviewed by Maciej Stachowiak.

Fix https://bugs.webkit.org/show_bug.cgi?id=22051
Renderthemes should be able to supply additional CSS rules to the core
ones.

  • DerivedSources.make:
  • css/CSSStyleSelector.cpp: (WebCore::parseUASheet): (WebCore::loadFullDefaultStyle): (WebCore::loadSimpleDefaultStyle):
  • css/themeWin.css: Added.
  • css/themeWinQuirks.css: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet):
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraDefaultStyleSheet): (WebCore::RenderTheme::extraQuirksStyleSheet):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::extraDefaultStyleSheet): (WebCore::RenderThemeWin::extraQuirksStyleSheet):
  • rendering/RenderThemeWin.h:
13:02 Google Summer of Code 2008 edited by ddkilzer@apple.com
(diff)
13:01 WikiStart edited by ddkilzer@apple.com
(diff)
11:44 Changeset [38787] by ddkilzer@apple.com

Make CSSStyleSheet::addSubresourceURLStrings() iterative

Part of the fix for Bug 11850: Webarchive fails to save images referenced in CSS
<https://bugs.webkit.org/show_bug.cgi?id=11850>

Reviewed by Brady Eidson.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceURLStrings): Switch algorithm from recursive to iterative for gathering the list of all CSS stylesheets referenced in @import statements.
11:38 Changeset [38786] by ddkilzer@apple.com

Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content

<https://bugs.webkit.org/show_bug.cgi?id=22488>

Reviewed by Brady Eidson.

  • DumpRenderTree/mac/DumpRenderTree.mm: (convertWebResourceDataToString): If an IANA charset encoding string is provided, convert it to a CFStringEncoding value and then to an NSStringEncoding value, else fall back to NSUTF8StringEncoding. We also nil-check dataAsString, so the worst-case scenario is that the data won't be decoded to a string (versus crashing DumpRenderTree).
07:07 Changeset [38785] by krit@webkit.org

2008-11-26 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Hausmann.

Transformations to the context shouldn't transform the currentPath.
Fixed this on Qt.

[QT] GraphicsContext's currenPath can be transformed
https://bugs.webkit.org/show_bug.cgi?id=22163

  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::concatCTM):
03:31 Changeset [38784] by jmalonzo@webkit.org

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] add/remove tests from Skipped and fix netscape plugin test
https://bugs.webkit.org/show_bug.cgi?id=22484

Add tests that needs confirmation of new results. Also, remove
some tests that are already passing.

  • platform/gtk/Skipped:
03:31 Changeset [38783] by jmalonzo@webkit.org

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] add/remove tests from Skipped and fix netscape plugin test
https://bugs.webkit.org/show_bug.cgi?id=22484

Remove print'ing to stderr

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_Initialize): (NP_Shutdown):
03:31 Changeset [38782] by jmalonzo@webkit.org

2008-11-26 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Darin Adler. Landed by Jan Alonzo.

Bison versions under 2.2 produce crashing CSSGrammar code for ARM
https://bugs.webkit.org/show_bug.cgi?id=22456

Check for bison version 2.2 or greater on ARM. Earlier versions produce
code that crashes on ARM devices.

  • configure.ac:
03:31 Changeset [38781] by jmalonzo@webkit.org

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build script minor fixes. Not reviewed.

  • GNUmakefile.am:
    • Add ScriptInstance.h (introduced in r38774) to

the build.

  • Move WML and GEOLOCATION conditionals before the SVG

conditional to be consistent with the style of the script.

  • Move GeolocationGtk sources to webcoregtk_sources.
01:10 Changeset [38780] by ap@webkit.org

2008-11-26 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=22469

Move the class DOMWindowTimer from JSDOMWindowBase into its own file in
preparation to making it work for Workers. For now, just move the code and couple
of global variables.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts): (WebCore::JSDOMWindowBase::timerFired):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/DOMTimer.cpp: Added. (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired):
  • bindings/js/DOMTimer.h: Added. (WebCore::DOMTimer::timeoutId): (WebCore::DOMTimer::nestingLevel): (WebCore::DOMTimer::setNestingLevel): (WebCore::DOMTimer::action): (WebCore::DOMTimer::takeAction):
00:13 Changeset [38779] by ap@webkit.org

Reviewed by Geoff Garen.

Add a test for infinite recursion in workers
https://bugs.webkit.org/show_bug.cgi?id=22486

  • fast/workers/resources/use-machine-stack.js: Added.
  • fast/workers/use-machine-stack-expected.txt: Added.
  • fast/workers/use-machine-stack.html: Added.

11/25/08:

21:47 BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
21:24 Changeset [38778] by mitz@apple.com

Reviewed by Mark Rowe.

  • include the text direction submenu in context menus when appropriate
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed the default textDirectionSubmenuInclusionBehavior to "automatically", which includes the menu when the selection is confined to a single paragraph the either has right-to-left base writing direction or contains right-to-left or embedded text. Left the default for Tiger and Leopard to be "never".
18:19 Changeset [38777] by darin@chromium.org

2008-11-25 Darin Fisher <darin@chromium.org>

Fix bustage.

https://bugs.webkit.org/show_bug.cgi?id=22493
Need to expose bridge/*.h to the WebKit build.

  • WebCore.vcproj/WebCore.vcproj:
17:38 Changeset [38776] by cmarrin@apple.com

2008-11-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.

Tests: animations/empty-keyframes.html

animations/fill-unset-properties.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
17:21 Changeset [38775] by zimmermann@webkit.org

Not reviewed. Fix build, by removing some wrong last-minute changes.

17:19 Changeset [38774] by darin@chromium.org

2008-11-25 Darin Fisher <darin@chromium.org>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=22493

Abstract away JSC
usage in WebCore/html
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/js/ScriptInstance.h: Added.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::getInstance):
  • html/HTMLPlugInElement.h:
17:15 Changeset [38773] by zimmermann@webkit.org

Reviewed by Sam Weinig.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477

A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.

Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
<template>/<option> or <card> element.

Add complete <onevent> support.

17:07 Changeset [38772] by sfalken@apple.com

Windows build fix.

  • DumpRenderTree/cg/PixelDumpSupportCG.h:
17:05 Changeset [38771] by sfalken@apple.com

Windows build fix.

  • DumpRenderTree/cg/ImageDiffCG.cpp:
16:54 Changeset [38770] by pol@apple.com

2008-11-25 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Mark Rowe.

createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL

https://bugs.webkit.org/show_bug.cgi?id=22503

  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
16:33 Changeset [38769] by jchaffraix@webkit.org

2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Element's other than HTML ones take a QualifiedName in their constructors.
To make HTMLElementFactory closer to the other ElementFactory, we need
to make them take the same arguments.
This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
will go into the next patch.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement):
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement):
  • html/HTMLBodyElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor):
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHeadElement.h:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLHtmlElement.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
  • html/HTMLLinkElement.h:
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::HTMLMetaElement):
  • html/HTMLMetaElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::finished):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
16:18 Changeset [38768] by simon.fraser@apple.com

2008-11-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=22046

Fix a crash when an animation or transition end event handler
removes the element upon which the transition/animation is running,
by keeping a reference to the AnimationBase object on the stack.

Tests: animations/transform-animation-event-destroy-element.html

transitions/transform-transition-event-destroy-element.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setChanged): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::clearRenderer):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
  • page/animation/CompositeAnimation.h:
16:09 Changeset [38767] by cwzwarich@webkit.org

2008-11-25 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Remove the unused member function JSFunction::getParameterName().

  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
15:32 Changeset [38766] by kevino@webkit.org

Better wx build fix - support PurgeableBuffer on Mac.

15:17 Changeset [38765] by zecke@webkit.org

Add GeoleocationServiceGtk stubs and integrate it into the buildsystem

Add stubs for a Gtk Implementation.

15:17 Changeset [38764] by zecke@webkit.org

Add Geolocation support to the configure.ac

Add an option to build WebKit/Gtk+ with Geolocation. The
implementation will be using Gypsy.

15:07 Changeset [38763] by barraclough@apple.com

2008-11-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Polymorpic caching for get by id chain. Similar to the polymorphic caching already implemented
for self and proto accesses (implemented by allowing multiple trampolines to be JIT genertaed,
and linked together) - the get by id chain caching is implemented as a genericization of the
proto list caching, allowing cached access lists to contain a mix of proto and proto chain
accesses (since in JS style inheritance hierarchies you may commonly see a mix of properties
being overridden on the direct prototype, or higher up its prototype chain).

In order to allow this patch to compile there is a fix to appease gcc 4.2 compiler issues
(removing the jumps between fall-through cases in privateExecute).


This patch also removes redundant immediate checking from the reptach code, and fixes a related
memory leak (failure to deallocate trampolines).

~2% progression on v8 tests (bulk on the win on deltablue)

  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures):
  • interpreter/Interpreter.cpp: (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::getPolymorphicAccessStructureListSlot): (JSC::Interpreter::cti_op_get_by_id_proto_list):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JIT.h: (JSC::JIT::compileGetByIdChainList):
15:00 Changeset [38762] by kevino@webkit.org

wx build fix - we don't support PurgeableBuffer on Leopard for now.

14:46 Changeset [38761] by antti@apple.com

2008-11-25 Antti Koivisto <antti@apple.com>

Reviewed by Mark Rowe.

Fix https://bugs.webkit.org/show_bug.cgi?id=22483
Assertion failure in CachedResource::makePurgeable during layout tests


Deleting SVG image can re-enter destroyDecodedData.

  • loader/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
13:24 Changeset [38760] by dino@apple.com

2008-11-25 Dean Jackson <dino@apple.com>

Add a new work-in-progress proposal for pointer-events in
HTML content. Also note that the Media Queries extensions
are not at all official.

  • specs/MediaQueriesExtensions.html:
  • specs/PointerEventsProperty.html: Added.
  • specs/index.html:
13:00 Changeset [38759] by darin@chromium.org

2008-11-25 Darin Fisher <darin@chromium.org>

Disabling these newly added tests since they fail in some configurations.

See https://bugs.webkit.org/show_bug.cgi?id=21635

  • http/tests/misc/submit-get-in-utf7.html: Removed.
  • http/tests/misc/submit-get-in-utf7.html-disabled: Copied from http/tests/misc/submit-get-in-utf7.html.
  • http/tests/misc/submit-post-in-utf7.html: Removed.
  • http/tests/misc/submit-post-in-utf7.html-disabled: Copied from http/tests/misc/submit-post-in-utf7.html.
  • http/tests/misc/url-in-utf7.html: Removed.
  • http/tests/misc/url-in-utf7.html-disabled: Copied from http/tests/misc/url-in-utf7.html.
12:43 Changeset [38758] by zecke@webkit.org

Build fix. Use WebCore::Frame::loader instead of QWebFrame

12:02 Changeset [38757] by ap@webkit.org

Add bug URL to ChangeLog.

12:01 Changeset [38756] by ap@webkit.org

2008-11-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
Workers on threads.

No observable change in behavior, so no test.

  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::String::substringCopy):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::substringCopy):
  • platform/text/StringImpl.h: Added the ability to copy a substring.
  • xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::PreflightResultCache::PreflightResultCache): (WebCore::PreflightResultCacheItem::addToAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge): (WebCore::PreflightResultCacheItem::parse): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::PreflightResultCache::shared): (WebCore::PreflightResultCache::appendEntry): (WebCore::PreflightResultCache::canSkipPreflight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponsePreflight): Made the PreflightResultCache threadsafe.

(WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
(WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
Consolidation of duplicate logic.

11:31 Changeset [38755] by darin@chromium.org

2008-11-24 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

For Unicode encodings other than UTF-8, use UTF-8 for
form submission and URL query part encoding.

See https://bugs.webkit.org/show_bug.cgi?id=21635

Tests: http/tests/misc/submit-get-in-utf16be.html

http/tests/misc/submit-get-in-utf16le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/submit-get-in-utf7.html
http/tests/misc/submit-post-in-utf16be.html
http/tests/misc/submit-post-in-utf16le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-post-in-utf7.html
http/tests/misc/url-in-utf16be.html
http/tests/misc/url-in-utf16le.html
http/tests/misc/url-in-utf32be.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/url-in-utf7.html


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/text/TextEncoding.cpp: (WebCore::UTF7Encoding): (WebCore::TextEncoding::isNonByteBasedEncoding): (WebCore::TextEncoding::closestByteBasedEquivalent): (WebCore::TextEncoding::encodingForFormSubmission):
  • platform/text/TextEncoding.h:
11:21 Changeset [38754] by jchaffraix@webkit.org

2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

  • Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
  • Tweaked the generated files to better match our coding style.
  • dom/make_names.pl:
10:25 Changeset [38753] by ddkilzer@apple.com

2008-11-25 Jack Wootten <jackwootton@gmail.com>

Bug 20125: http://webkit.org/ missing link to key documentation for new developers.

<https://bugs.webkit.org/show_bug.cgi?id=20125>

Reviewed by David Kilzer.

  • projects/documentation/index.html: Added link to "Introduction to WebKit Objective-C Programming Guide".
07:49 Changeset [38752] by ap@webkit.org

Actually landing tests for bug 22455 - Add support for Worker.terminate().

02:25 Changeset [38751] by ap@webkit.org

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=9001
Javascript stops running before replacement page data arrives

Adding a test for a bug that is longer reproducible.

  • http/tests/misc/resources/hang-connection.php: Added.
  • http/tests/misc/timer-vs-loading-expected.txt: Added.
  • http/tests/misc/timer-vs-loading.html: Added.
02:05 Changeset [38750] by cwzwarich@webkit.org

2008-11-25 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Move the collect() call in Heap::heapAllocate() that is conditionally
compiled under COLLECT_ON_EVERY_ALLOCATION so that it is before we get
information about the heap. This was causing assertion failures for me
while I was reducing a bug.

  • runtime/Collector.cpp: (JSC::Heap::heapAllocate):
00:51 Changeset [38749] by ap@webkit.org

2008-11-24 Dean McNamee <deanm@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22350
Allow layout tests to run in php cgi mode

  • http/tests/misc/refresh-headers.php:
  • http/tests/misc/resources/redirect-result.php:
  • http/tests/misc/resources/referrer-result.php:
  • http/tests/misc/xhtml.php: Stop using getallheaders(), which is only implemented by mod_php, so that the tests could run through lighttpd.
00:13 Changeset [38748] by antti@apple.com

WebCore:

2008-11-24 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit


HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
there were no scripts left to execute.


If m_hasScriptsWaitingForStylesheets becomes true during script execution
bail out from executing more scripts synchronously.

Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):

LayoutTests:

2008-11-24 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


Test for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit

  • fast/tokenizer/nested-cached-scripts-and-stylesheet-expected.txt: Added.
  • fast/tokenizer/nested-cached-scripts-and-stylesheet.html: Added.
  • fast/tokenizer/resources/load-stylesheet-and-document-write-script.js: Added.

11/24/08:

23:23 Changeset [38747] by cwzwarich@webkit.org

2008-11-24 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 13790: Function declarations are not treated as statements (used to affect starcraft2.com)
<https://bugs.webkit.org/show_bug.cgi?id=13790>

Modify the parser to treat function declarations as statements,
simplifying the grammar in the process. Technically, according to the
grammar in the ECMA spec, function declarations are not statements and
can not be used everywhere that statements can, but it is not worth the
possibility compatibility issues just to stick to the spec in this case.

JavaScriptCore:

  • parser/Grammar.y:
  • parser/Nodes.cpp: (JSC::FuncDeclNode::emitBytecode): Avoid returning ignoredResult() as a result, because it causes a crash in DoWhileNode::emitBytecode().

LayoutTests:

  • fast/js/function-declaration-statement-expected.txt: Added.
  • fast/js/function-declaration-statement.html: Added.
  • fast/js/resources/function-declaration-statement.js: Added.
22:47 Changeset [38746] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=22465
Define KURL::copy() and use it in WorkerThread.cpp

  • dom/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread):
  • platform/KURL.cpp: (WebCore::KURL::copy):
  • platform/KURL.h:
22:10 Changeset [38745] by ggaren@apple.com

2008-11-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Unroll the regexp matching loop by 1. 10% speedup on simple matching
stress test. No change on SunSpider.


(I decided not to unroll to arbitrary levels because the returns diminsh
quickly.)

  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateJumpIfEndOfInput): (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
  • wrec/WRECGenerator.h:
  • wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::parsePattern):
19:43 Changeset [38744] by zimmermann@webkit.org

Reviewed by Sam Weinig.

Name enum values in a style guide compatible way.
Allow WMLIntrinsicEvent inclusion, without needing other includes.

19:36 Changeset [38743] by zimmermann@webkit.org

Reviewed by Sam Weinig.

Add wmlPageStateForDocument() helper function and use it in some places.

19:16 Changeset [38742] by antti@apple.com

Fix ChangeLog spelling plus credit weinig.

19:11 Changeset [38741] by antti@apple.com

2008-11-24 Antti Koivisto <antti@apple.com>

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=22214
Keep dead resourcs in memory cache in purgeable memory.
<rdar://problem/6333088>


OS X 10.5 has purgeable memory kernel facility that allows marking reserved memory
areas as less important. Under memory pressure system can steal pages that have
been marked purgeable for (hopefully) better uses. This is ideal for caches.


Only resources larger than 16KB will be moved to the purgsable memory.

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::resourceForURL): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::dumpStats):
  • loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved): (WebCore::CachedCSSStyleSheet::sheetText):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::addClient): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::destroyDecodedData):
  • loader/CachedResource.cpp: (WebCore::CachedResource::addClient): (WebCore::CachedResource::makePurgeable): (WebCore::CachedResource::isPurgeable): (WebCore::CachedResource::wasPurged):
  • loader/CachedResource.h: (WebCore::CachedResource::data):
  • loader/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
  • platform/PurgeableBuffer.h: Added. (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::size): (WebCore::PurgeableBuffer::): (WebCore::PurgeableBuffer::purgePriority): (WebCore::PurgeableBuffer::isPurgeable): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::data): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::makePurgeable):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::~SharedBuffer): (WebCore::SharedBuffer::adoptPurgeableBuffer): (WebCore::SharedBuffer::size): (WebCore::SharedBuffer::data): (WebCore::SharedBuffer::append): (WebCore::SharedBuffer::clear): (WebCore::SharedBuffer::releasePurgeableBuffer):
  • platform/SharedBuffer.h: (WebCore::SharedBuffer::hasPurgeableBuffer):
  • platform/cf/SharedBufferCF.cpp:
  • platform/mac/PurgeableBufferMac.cpp: Added. (WebCore::PurgeableBuffer::PurgeableBuffer): (WebCore::PurgeableBuffer::~PurgeableBuffer): (WebCore::PurgeableBuffer::create): (WebCore::PurgeableBuffer::makePurgeable): (WebCore::PurgeableBuffer::wasPurged): (WebCore::PurgeableBuffer::setPurgePriority): (WebCore::PurgeableBuffer::data):
18:20 Changeset [38740] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Fix bustage.

  • History/WebHistory.mm:
17:53 Changeset [38739] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Fix bustage.

https://bugs.webkit.org/show_bug.cgi?id=15643

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSelectTrailingWhitespaceEnabled):
17:45 Changeset [38738] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Fix bustage.

http://bugs.webkit.org/show_bug.cgi?id=15643

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
  • WebCoreSupport/EditorClientQt.h:
17:33 Changeset [38737] by dino@apple.com

2008-11-24 Dean Jackson <dino@apple.com>

Document the work-in-progress proposed extensions to
CSS 3 Media Queries.

  • specs/MediaQueriesExtensions.html: Added.
  • specs/index.html:
16:23 Changeset [38736] by zimmermann@webkit.org

Reviewed by George Staikos & Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22430

Regenerate WML layout test results after implementing WML specific <card> handling:
Only the first <card> element should be visible after loading the document, others
can be shown by using the <go> task element.

16:18 Changeset [38735] by darin@chromium.org

2008-11-24 Glenn Wilson <gwilson@chromium.org>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=15643

Added support for clients that wish to disable smart insert/delete
and enable the "trailing whitespace selection" work-around.

Tests: editing/selection/doubleclick-whitespace.html

  • editing/Editor.cpp: (WebCore::Editor::selectTrailingWhitespaceEnabled):
  • editing/Editor.h:
  • editing/Selection.cpp: (WebCore::Selection::includeTrailingWhitespace):
  • editing/Selection.h:
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::selectTrailingWhitespaceEnabled):
  • page/EditorClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
16:04 Changeset [38734] by zimmermann@webkit.org

Not reviewed. Forgot to include WMLPageState.h in last commit.

16:02 Changeset [38733] by zimmermann@webkit.org

Reviewed by Oliver Hunt & Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22431

Implement WMLAccessElement. It just propogates two attributes values to WMLPageState.

15:32 Changeset [38732] by darin@apple.com

WebCore:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistory): Remove argument.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): Don't pass the URL. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Ditto.
  • loader/FrameLoaderClient.h: Remove argument.

WebKit/gtk:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument.
  • WebCoreSupport/FrameLoaderClientGtk.h: Ditto.

WebKit/mac:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.

WebKit/qt:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory): Get the URL from the DocumentLoader.
  • WebCoreSupport/FrameLoaderClientQt.h: Remove argument.

WebKit/win:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the DocumentLoader, just as we do the title and the failure flag.
  • WebCoreSupport/WebFrameLoaderClient.h: Remove argument.

WebKit/wx:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory): Remove argument.
  • WebKitSupport/FrameLoaderClientWx.h: Ditto.
15:28 Changeset [38731] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Fix bustage.

https://bugs.webkit.org/show_bug.cgi?id=22448

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
15:12 Changeset [38730] by darin@chromium.org

2008-11-24 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Darin Adler.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22432

Add plumbing for tickmark support for the scrollbars. The painting code
for the scrollbar just needed to call paintTickmarks at the right time
and a default no-op implementation is provided, which the ports will
need to override.

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::paintTickmarks):
15:07 Changeset [38729] by darin@chromium.org

2008-11-24 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=22448
Create an abstraction for JSC::SourceCode

  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/CachedScriptSourceProvider.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptSourceCode.h: Added. (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::length): (WebCore::ScriptSourceCode::jsSourceCode):
  • bindings/js/WorkerScriptController.cpp: (WebCore::Workevn ScriptController::evaluate):
  • bindings/js/WorkerScriptController.h:
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::insertedIntoDocument): (WebCore::ScriptElement::childrenChanged): (WebCore::ScriptElementData::evaluateScript): (WebCore::ScriptElementData::notifyFinished):
  • dom/ScriptElement.h:
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::endElementNs):
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseEndElement):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::notifyFinished):
  • html/HTMLTokenizer.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript):
  • loader/FrameLoader.h:
14:48 Changeset [38728] by darin@apple.com

WebCore:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • WebCore.base.exp: Exported new function.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::urlForHistoryReflectsFailure): Added.
  • loader/DocumentLoader.h: Ditto.

WebKit/mac:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Last time around I did this only for the back/forward list and missed the
global history list.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:wasFailure:]): Added wasFailure argument. Set the flag on the newly created history item. Also eliminated the use of autorelease on the added-items array.
  • History/WebHistoryInternal.h: Ditto.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory. Given that this function gets other data from the DocumentLoader, I think we should get rid of the KURL argument, but that's a separate issue so I don't do it in this patch.

WebKit/win:

2008-11-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Last time around I did this only for the back/forward list and missed the
global history list.

  • Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure and pass the argument in to WebHistory.
  • WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument. Set the flag on the newly created history item.
  • WebHistory.h: Ditto.
  • WebHistoryItem.cpp: (WebHistoryItem::setLastVisitWasFailure): Added.
  • WebHistoryItem.h: Ditto.
14:46 Changeset [38727] by beidson@apple.com

Update radar in an old Changelog entry to be "more correct"

14:33 Changeset [38726] by cfleizach@apple.com

Bug 22461: AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class

14:31 Changeset [38725] by mrowe@apple.com

Tag the Safari 3.2.1 release.

JavaScriptCore, JavaScriptGlue and WebCore are unchanged from Safari 3.2. WebKit is WebKit-x525.27.1.

13:54 Changeset [38724] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Fix Windows build: selectionRect() -> selectionBounds().

  • page/win/FrameCGWin.cpp: (WebCore::imageFromSelection):
13:42 Changeset [38723] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Fix call to Frame::selectionBounds in Windows build.

  • WebView.cpp: (WebView::selectionRect):
13:40 Changeset [38722] by darin@chromium.org

2008-11-24 Glenn Wilson <gwilson@chromium.org>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=18703
"Changing the 'size' property on a text input does not affect its length"

Text fields would not repaint themselves after having their "size"
attributes modified. This fix tells the object to recalculate its
width and repaint itself when its "size" attribute is parsed.

Test: fast/js/text-field-resize.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
13:35 Changeset [38721] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Fix call to Frame::selectionBounds in Tiger build.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
13:25 Changeset [38720] by ggaren@apple.com

2008-11-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Removed some unnecessary "Generator::" prefixes.

  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
13:21 Changeset [38719] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

Followup from changes for https://bugs.webkit.org/show_bug.cgi?id=22433

Make RenderView::selectionRect() private to cause compile-time
errors if someone tries to call it.

  • rendering/RenderView.h:
13:20 Changeset [38718] by ggaren@apple.com

2008-11-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Made a bunch of WREC::Parser functions private, and added an explicit
"reset()" function, so a parser can be reused.

  • wrec/WRECParser.h: (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::generator): (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::multiline): (JSC::WREC::Parser::recordSubpattern): (JSC::WREC::Parser::numSubpatterns): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::parseAlternative): (JSC::WREC::Parser::reset):
12:16 Changeset [38717] by dino@apple.com

2008-11-21 Dean Jackson <dino@apple.com>

CSSAnimation.html:

  • animation-name should accept IDENT not <string>
  • animation-play-state marked as "about to be removed"
  • more description of when an animation is applied, that they snapshot keyframes and values as they start and how they need to be removed to reset.

CSSTransitions.html:

  • list of animatable properties and how to animate property types.
  • specify that values for bezier points outside of [0,1] are invalid.

CSSTransforms.html:

  • split into 2d and 3d specifications
  • transform-origin now matches background-position definition.
  • describe how to animate between lists of transforms

CSSTransforms3D.html

  • new specification which is the 3d parts of transforms
  • perspective must be > 0
  • perspective-origin also matches background-position
  • describe how to animate between lists of transforms, but this time in 3d which is harder.
11:58 Changeset [38716] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

Via: https://bugs.webkit.org/show_bug.cgi?id=22433

Rename RenderView::selectionRect() to selectionBounds(), to remove
longstanding ambiguity with the base class selectionRect() method.
Do the same on Frame for consistency with RenderView. Assert
that RenderView::selectionRect() is never called.

11:41 Changeset [38715] by christian@webkit.org

2008-11-24 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=17122
[GTK] Bad font default settings

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Use default font size 12 instead of 10
11:29 Changeset [38714] by jchaffraix@webkit.org

2008-11-19 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

  • Make HTMLElementFactory::createHTMLElement take a QualifiedName instead of an AtomicString.
  • Updated the elements' constructors and the callers to reflect the previous change.
  • dom/Document.cpp: (WebCore::Document::createElement):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createElement):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode):
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor): (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::keygenConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor): (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::preConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::modConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableColConstructor): (WebCore::tableRowConstructor): (WebCore::tableCellConstructor): (WebCore::tableSectionConstructor): (WebCore::brConstructor): (WebCore::quoteConstructor): (WebCore::marqueeConstructor): (WebCore::audioConstructor): (WebCore::videoConstructor): (WebCore::sourceConstructor): (WebCore::HTMLElementFactory::createHTMLElement):
  • html/HTMLElementFactory.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::getNode):
11:21 Changeset [38713] by ap@webkit.org

2008-11-24 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22444

Correct bad default constructor for Cairo FontPlatformData so that
the m_scaledFont member is initialized. Previously this would be
set to 0xbaadf00d, which would result in infinite loops while
attempting to deal with the font cache.

  • platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize m_scaledFont to 0
10:37 Changeset [38712] by simon.fraser@apple.com

2008-11-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=22433

Add script that attempts to detect virtual methods
whose signatures differ only by constness (which can
indicate a programming error).

  • Scripts/detect-mismatched-virtual-const: Added.
10:21 Changeset [38711] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22455
Add support for Worker.terminate()

Test: fast/workers/worker-terminate.html

  • dom/Worker.idl:
  • dom/Worker.cpp:
  • dom/Worker.h: Added terminate().
  • dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerTask::performTask): Don't dispatch messages if the worker was asked to terminate (this is not mentioned in draft spec, but makes sense anyway). (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): The proxy now remembers if it was asked to terminate in m_askedToTerminate member variable. Also, changed m_unconfirmedMessageCount to only track messages that were posted to worker thread, avoiding a leak if the script could not be loaded. (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): Return early if terminating. (WebCore::WorkerMessagingProxy::workerThreadCreated): Stop the thread if already asked for. (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Even if worker context was destroyed, the worker object may still be alive now, so don't delete self in this case. (WebCore::WorkerMessagingProxy::terminate): Stop the thread if it was already created, or remember to stop it when it is created. (WebCore::WorkerMessagingProxy::reportWorkerThreadActivityInternal): Don't track activity if the thread asked to stop anyway. (WebCore::WorkerMessagingProxy::workerThreadHasPendingActivity): Ditto.
  • dom/WorkerThread.cpp:
  • dom/WorkerThread.h: Fixed a race condition in stop().
09:04 Changeset [38710] by zecke@webkit.org

[Gtk+] Implement TestNetscapePlugin for Gtk+ port.

LayoutTests:
2008-11-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

Some tests in plugins/ directory now pass.

  • platform/gtk/Skipped:

WebCore/ChangeLog:
2008-11-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark Rowe.

[Gtk+] Add configure option to enable Web Workers and enable it by default

Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.

  • GNUmakefile.am:

WebKit/gtk/ChangeLog
2008-11-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22039

Implement a semi-private function for adding a directory to
PluginDatabase's paths.

  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory):

WebKitTools/ChangeLog
2008-11-24 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22039

[Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
build.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
  • GNUmakefile.am:
06:42 Changeset [38709] by ap@webkit.org

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=22428
xmlhttprequest-onProgress-open-should-zero-length.html fails intermittently

  • http/tests/xmlhttprequest/resources/big-response.php: Reduce the size of big response to make the test faster, but practically guarantee that the response will be delivered in many chunks.
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Made the test more reliable by comparing final response position with known resource size.
06:40 Changeset [38708] by ap@webkit.org

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=22439
Won't load stylesheets with filenames less than 2 characters long in xhtml.

Test: http/tests/misc/single-character-pi-stylesheet.xhtml

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Fix up the logic.
05:07 Changeset [38707] by zecke@webkit.org

The "WARNING" should not be there, remove it. There was no need to add a test case.

05:01 Changeset [38706] by zecke@webkit.org

[Gtk+] We are passing all but one worker test. Enable them.

We fail on fast/workers/worker-location.html due some weird
issue with the bidi resolver "skipping" whitespace at the end
of the line.

04:56 Changeset [38705] by zecke@webkit.org

[Gtk+] Add configure option to enable Web Workers and enable it by default

Add --enable-workers to the buildsystem (used by build-webkit) add
the to be build files to the GNUmakefile.am and change build-webkit
to enable Web Workers by default.

03:54 Changeset [38704] by ap@webkit.org

Build fix (for Windows Cairo port?)

  • page/DOMWindow.idl: Ese ENABLE_CHANNEL_MESSAGING instead of ENABLE(CHANNEL_MESSAGING), as the ENABLE macro is not available in idls.
03:12 Changeset [38703] by barraclough@apple.com

2008-11-24 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Mark Rowe.

Add test cases to ensure the PIC trampolines for prototype and prototype chain
accesses properly check for JSImmediate values, rather than segfaulting.

https://bugs.webkit.org/show_bug.cgi?id=22451

  • fast/js/pic/cached-prototype-then-immediate-expected.txt: Added.
  • fast/js/pic/cached-prototype-then-immediate.html: Added.
02:59 Changeset [38702] by mrowe@apple.com

Let gdb-safari accept the --debug and --release options once more.

Reviewed by Alexey Proskuryakov.

  • Scripts/gdb-safari:
02:28 Changeset [38701] by barraclough@apple.com

tyop fix in jsc Changelog

02:14 Changeset [38700] by barraclough@apple.com

2008-11-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Implement repatching for get by id chain.
Previously the access is performed in a function stufb, in the reptach form
the trampoline is not called to; instead the hot patch is relinkde to jump
directly to the trampoline, if it fails it will jump to the slow case.

https://bugs.webkit.org/show_bug.cgi?id=22449
3% progression on deltablue.

  • jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
00:09 Changeset [38699] by hausmann@webkit.org

2008-11-24 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=20746

Various small compilation fixes to make the Qt port of WebKit
compile on Windows CE.

  • config.h: Don't set _CRT_RAND_S for CE, it's not available.
  • jsc.cpp: Disabled use of debugger includes for CE. It does not have the debugging functions.
  • runtime/DateMath.cpp: Use localtime() on Windows CE.
  • wtf/Assertions.cpp: Compile on Windows CE without debugger.
  • wtf/Assertions.h: Include windows.h before defining ASSERT.
  • wtf/MathExtras.h: Include stdlib.h instead of xmath.h.
  • wtf/Platform.h: Disable ERRNO_H and detect endianess based on the Qt endianess. On Qt for Windows CE the endianess is defined by the vendor specific build spec.
  • wtf/Threading.h: Use the volatile-less atomic functions.
  • wtf/dtoa.cpp: Compile without errno.
  • wtf/win/MainThreadWin.cpp: Don't include windows.h on CE after Assertions.h due to the redefinition of ASSERT.
Note: See TracTimeline for information about the timeline view.