Timeline



Nov 29, 2008:

11:09 PM Changeset in webkit [38849] by Antti Koivisto
  • 6 edits in trunk

JavaScriptCore:

2008-11-29 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.


https://bugs.webkit.org/show_bug.cgi?id=22557
Add statistics for JavaScript GC heap.

  • JavaScriptCore.exp:
  • runtime/Collector.cpp: (JSC::Heap::objectCount): (JSC::addToStatistics): (JSC::Heap::statistics):
  • runtime/Collector.h:

WebKit/mac:

2008-11-29 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22557
Add statistics for JavaScript GC heap.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics memoryStatistics]):
4:39 PM Changeset in webkit [38848] by Antti Koivisto
  • 2 edits in trunk/JavaScriptCore

2008-11-29 Antti Koivisto <Antti Koivisto>

Fix debug build by adding a stub method.

  • wtf/FastMalloc.cpp: (WTF::fastMallocStatistics):
3:44 PM Changeset in webkit [38847] by pewtermoose@webkit.org
  • 5 edits in trunk

WebCore:

2008-11-29 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

Remove Visual Studio project dependencies on non-redistributable
components in the Debug_Cairo and Release_Cairo build targets.
See https://bugs.webkit.org/show_bug.cgi?id=22527

  • WebCore.vcproj/WebCore.vcproj:

WebKit/win:

2008-11-29 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

Remove Visual Studio project dependencies on non-redistributable
components in the Debug_Cairo and Release_Cairo build targets.
See https://bugs.webkit.org/show_bug.cgi?id=22527

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother building the unused QuickTime support library.
2:35 PM Changeset in webkit [38846] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-11-29 Sam Weinig <sam@webkit.org>

Rubber-stamped by Alexey Proskuryakov.

Fix some sorting

  • WebCore.xcodeproj/project.pbxproj:
2:33 PM Changeset in webkit [38845] by weinig@apple.com
  • 8 edits
    2 adds in trunk

WebCore:

2008-11-28 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21063
NULL pointer crash in dispatchEvent(null);

Test: fast/events/dispatchEvent-crash.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::dispatchEvent):
  • dom/Worker.cpp: (WebCore::Worker::dispatchEvent):
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::dispatchEvent):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::dispatchEvent):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent):
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::dispatchEvent):

LayoutTests:

2008-11-28 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Test for https://bugs.webkit.org/show_bug.cgi?id=21063
NULL pointer crash in dispatchEvent(null);

  • fast/events/dispatchEvent-crash-expected.txt: Added.
  • fast/events/dispatchEvent-crash.html: Added.
2:10 PM Changeset in webkit [38844] by Antti Koivisto
  • 8 edits in trunk

JavaScriptCore:

2008-11-29 Antti Koivisto <Antti Koivisto>

Reviewed by Alexey Proskuryakov.


https://bugs.webkit.org/show_bug.cgi?id=22557


Add function for getting basic statistics from FastMalloc.

  • JavaScriptCore.exp:
  • wtf/FastMalloc.cpp: (WTF::DLL_Length): (WTF::TCMalloc_PageHeap::ReturnedBytes): (WTF::TCMallocStats::fastMallocStatistics):
  • wtf/FastMalloc.h:

WebKit/mac:

2008-11-29 Antti Koivisto <Antti Koivisto>

Reviewed by Alexey Proskuryakov.


https://bugs.webkit.org/show_bug.cgi?id=22557


  • Add purgeable memory statistics to cache statistics.
  • Add method for getting fastMalloc statistics.
  • Add method to force returning free memory back to system.
  • Misc/WebCache.mm: (+[WebCache statistics]):
  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]): (+[WebCoreStatistics memoryStatistics]): (+[WebCoreStatistics returnFreeMemoryToSystem]):
1:40 PM Changeset in webkit [38843] by mitz@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

Test: http/tests/misc/font-face-in-multiple-segmented-faces.html

The crash happened because style recalculation was invoked by
CSSFontSelector after one CSSSegmentedFontFace had pruned its tables but
before another CSSSegmentedFontFace using the same CSSFontFace had done
so. The fix is to let all CSSSegmentedFontFaces using the CSSFontFace
prune their tables before telling the CSSFontSelector to recalc style.

  • css/CSSFontFace.cpp: (WebCore::CSSFontFace::fontLoaded):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::fontLoaded):
  • css/CSSFontSelector.h:
  • css/CSSSegmentedFontFace.cpp: (WebCore::CSSSegmentedFontFace::fontLoaded):

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • http/tests/misc/font-face-in-multiple-segmented-faces-expected.txt: Added.
  • http/tests/misc/font-face-in-multiple-segmented-faces.html: Added.
10:29 AM Changeset in webkit [38842] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=14968
document.open() erroneously returns void instead of the new Document

Test: fast/dom/HTMLDocument/document-open-return-value.html

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): Return the document on which this method was invoked, per HTML5.
4:14 AM Changeset in webkit [38841] by christian@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-11-29 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=17122
[GTK] Bad font default settings

Implement a property "enforce-96-dpi" in WebKitWebSettings
that can be enabled to force the view to assume 96 DPI.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
  • webkit/webkitwebview.cpp:
4:07 AM Changeset in webkit [38840] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-29 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

The C++ standard does not automatically grant the friendships of an
enclosing class to its nested subclasses, so we should do so explicitly.
This fixes the GCC 4.0 build, although both GCC 4.2 and Visual C++ 2005
accept the incorrect code as it is.

  • assembler/MacroAssembler.h:
3:10 AM Changeset in webkit [38839] by barraclough@apple.com
  • 15 edits
    1 add in trunk/JavaScriptCore

2008-11-29 Gavin Barraclough <barraclough@apple.com>

Reviewed by Camron Zwarich.

Add the class MacroAssembler to provide some abstraction of code generation,
and change WREC to make use of this class, rather than directly accessing
the X86Assembler.

This patch also allows WREC to be compiled without the rest of the JIT enabled.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h: Added. (JSC::MacroAssembler::): (JSC::MacroAssembler::MacroAssembler): (JSC::MacroAssembler::copyCode): (JSC::MacroAssembler::Address::Address): (JSC::MacroAssembler::ImplicitAddress::ImplicitAddress): (JSC::MacroAssembler::BaseIndex::BaseIndex): (JSC::MacroAssembler::Label::Label): (JSC::MacroAssembler::Jump::Jump): (JSC::MacroAssembler::Jump::link): (JSC::MacroAssembler::Jump::linkTo): (JSC::MacroAssembler::JumpList::link): (JSC::MacroAssembler::JumpList::linkTo): (JSC::MacroAssembler::JumpList::append): (JSC::MacroAssembler::Imm32::Imm32): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::or32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::load32): (JSC::MacroAssembler::load16): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::store32): (JSC::MacroAssembler::pop): (JSC::MacroAssembler::push): (JSC::MacroAssembler::peek): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::move): (JSC::MacroAssembler::compareImm32ForBranch): (JSC::MacroAssembler::compareImm32ForBranchEquality): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::je32): (JSC::MacroAssembler::je16): (JSC::MacroAssembler::jg32): (JSC::MacroAssembler::jge32): (JSC::MacroAssembler::jl32): (JSC::MacroAssembler::jle32): (JSC::MacroAssembler::jne32): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::breakpoint): (JSC::MacroAssembler::ret):
  • assembler/X86Assembler.h: (JSC::X86Assembler::cmpw_rm):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
  • interpreter/Interpreter.h: (JSC::Interpreter::assemblerBuffer):
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
  • wrec/WREC.h:
  • wrec/WRECFunctors.cpp: (JSC::WREC::GeneratePatternCharacterFunctor::generateAtom): (JSC::WREC::GenerateCharacterClassFunctor::generateAtom): (JSC::WREC::GenerateBackreferenceFunctor::generateAtom): (JSC::WREC::GenerateParenthesesNonGreedyFunctor::generateAtom):
  • wrec/WRECFunctors.h: (JSC::WREC::GenerateParenthesesNonGreedyFunctor::GenerateParenthesesNonGreedyFunctor):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfEndOfInput): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure): (JSC::WREC::Generator::generateBacktrack1): (JSC::WREC::Generator::generateBacktrackBackreference): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateParentheses): (JSC::WREC::Generator::generateParenthesesNonGreedy): (JSC::WREC::Generator::generateParenthesesResetTrampoline): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference): (JSC::WREC::Generator::terminateAlternative): (JSC::WREC::Generator::terminateDisjunction):
  • wrec/WRECGenerator.h: (JSC::WREC::Generator::Generator):
  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parsePatternCharacterQualifier): (JSC::WREC::Parser::parseCharacterClassQuantifier): (JSC::WREC::Parser::parseBackreferenceQuantifier): (JSC::WREC::Parser::parseParentheses): (JSC::WREC::Parser::parseCharacterClass): (JSC::WREC::Parser::parseOctalEscape): (JSC::WREC::Parser::parseEscape): (JSC::WREC::Parser::parseTerm): (JSC::WREC::Parser::parseDisjunction):
  • wrec/WRECParser.h: (JSC::WREC::Parser::Parser): (JSC::WREC::Parser::parsePattern): (JSC::WREC::Parser::parseAlternative):
  • wtf/Platform.h:

Nov 28, 2008:

8:00 PM Changeset in webkit [38838] by Nikolas Zimmermann
  • 14 edits
    2 adds in trunk

Reviewed by Cameron Zwarich.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22550

Add <timer> element support. It provides a way to execute a task with a delay.
The user is notified by firing the task associated with the <card>'s ontimer attribute.
Only one timer element is allowed per <card> (fix wrong error message in reportWMLError)

6:52 PM Changeset in webkit [38837] by Nikolas Zimmermann
  • 21 edits
    2 adds in trunk

Reviewed by Holger Freyther.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22549

Add <do> element support. It provides a way to bind a task element to a <template>/<card> element.
Changes numerous of layout tests which contain <do> elements, as they render as buttons now.

5:23 PM Changeset in webkit [38836] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Nikolas Zimmermann.

Simplify the code. There is no reason to have code like
if (true) return false; which is using temporary variables.

  • webkit/webkitwebview.cpp:
5:23 PM Changeset in webkit [38835] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Nikolas Zimmermann.

Remove bogus null checks. The WebKitWebView own's a WebCore::Page
which is owning a WebCore::ChromeClient. There is no way that a
WebCore::ChromeClient is still around when the WebKitWebView is gone.

m_webView can only be null when a ChromeClient gets constructed with
a null WebKitWebView which is not allowed.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::pageRect): (WebKit::ChromeClient::focus): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::canTakeFocus): (WebKit::ChromeClient::repaint): (WebKit::ChromeClient::scroll): (WebKit::ChromeClient::platformWindow):
4:20 PM Changeset in webkit [38834] by zecke@webkit.org
  • 13 edits
    2 adds in trunk

2008-11-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed and slightly modified by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=19130

ChromeClient::createWindow and friends need to be implemented

Code from Gustavo Noronha and Marco Barisione
<marco.barisione@collabora.co.uk> in this change set.

Implemented all the ChromeClient interfaces needed to have new
window creation functioning and exposed to client code. We
implemented a mirror GObject to the WindowFeatures object provided
by WebCore.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::windowRect): (WebKit::ChromeClient::setWindowRect): (WebKit::ChromeClient::unfocus): (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::show): (WebKit::ChromeClient::setToolbarsVisible): (WebKit::ChromeClient::toolbarsVisible): (WebKit::ChromeClient::setStatusbarVisible): (WebKit::ChromeClient::statusbarVisible): (WebKit::ChromeClient::setScrollbarsVisible): (WebKit::ChromeClient::scrollbarsVisible): (WebKit::ChromeClient::setMenubarVisible): (WebKit::ChromeClient::menubarVisible): (WebKit::ChromeClient::setResizable):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchShow): (WebKit::FrameLoaderClient::dispatchCreatePage):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
  • webkit/webkitwebwindowfeatures.cpp: Added. (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features): (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
  • webkit/webkitwebwindowfeatures.h: Added.
1:36 PM Changeset in webkit [38833] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22545

Add onenterforward/onenterbackward/ontimer support for <card> elements.

No testing possible at the moment because WMLGoElement is not yet implemented.
After that we can add tests covering the <card> event handling.

10:14 AM Changeset in webkit [38832] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-27 Laszlo Gombos <Laszlo Gombos>

Reviewed by Tor Arne Vestbø.

Regression seen on QtWebKit - causes a build failure on Win using MinGW

https://bugs.webkit.org/show_bug.cgi?id=22536

7:19 AM Changeset in webkit [38831] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-28 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Fix compilation on Windows CE

Port away from the use of errno after calling strtol(), instead
detect conversion errors by checking the result and the stop
position.

7:19 AM Changeset in webkit [38830] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-28 Joerg Bornemann <joerg.bornemann@trolltech.com>

Reviewed by Simon Hausmann.

Implement lowResUTCTime() on Windows CE using GetSystemTime as _ftime() is not available.

7:18 AM Changeset in webkit [38829] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-11-28 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø.

Fix compilation and linking on Windows CE.

Use WIN_OS instead of WIN and therefore exclude determineModuleVersionFromDescription()
from the Windows'ish build.

Link against the newly required mmtimer.

7:18 AM Changeset in webkit [38828] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-11-28 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Tor Arne Vestbø.

Removed unnecessary inclusion of errno.h, which also fixes compilation on Windows CE.

2:23 AM Changeset in webkit [38827] by ap@webkit.org
  • 3 edits in trunk/WebCore

2008-11-28 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

http://bugs.webkit.org/show_bug.cgi?id=22524

Made static initializations in XMLHttpRequest.cpp thread-safe in preparation for usage
of XMLHttpRequest by Workers (on threads).

No observable change in behavior, so no test.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::PreflightResultCacheItem::allowsCrossSiteMethod): (WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::createXMLHttpRequestStaticData): (WebCore::initializeXMLHttpRequestStaticData): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::isSafeRequestHeader): (WebCore::XMLHttpRequest::isOnAccessControlResponseHeaderWhitelist):
  • xml/XMLHttpRequest.h:

Nov 27, 2008:

9:03 PM Changeset in webkit [38826] by cwzwarich@webkit.org
  • 4 edits in trunk

2008-11-27 Cameron Zwarich <zwarich@apple.com>

Not reviewed.

r38825 made JSFunction::m_body private, but some inspector code in
WebCore sets the field. Add setters for it, and update the inspector
code to use the new getters and setters.

JavaScriptCore:

  • runtime/JSFunction.h: (JSC::JSFunction::setBody):

WebCore:

  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
6:24 PM Changeset in webkit [38825] by weinig@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-27 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix FIXME by adding accessor for JSFunction's m_body property.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_vm_dontLazyLinkCall): (JSC::Interpreter::cti_vm_lazyLinkCall):
  • profiler/Profiler.cpp: (JSC::createCallIdentifierFromFunctionImp):
  • runtime/Arguments.h: (JSC::Arguments::getArgumentsData): (JSC::Arguments::Arguments):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString):
  • runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::body):
5:43 PM Changeset in webkit [38824] by jchaffraix@webkit.org
  • 2 edits in trunk/WebKitSite

2008-11-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22468: Coding style: config.h should only be included in implementation files, not in header
https://bugs.webkit.org/show_bug.cgi?id=22468

Clarified the rules about config.h inclusion and added 2 new examples to illustrate it. Also
added an explanation about the implementation files.

  • coding/coding-style.html:
5:26 PM Changeset in webkit [38823] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-27 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Remove unused member variables from ProgramNode.

  • parser/Nodes.h:
3:30 PM Changeset in webkit [38822] by dsmith@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-26 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alexey Proskuryakov.

Enable mouse panning feaure on Windows Cairo build.
See http://bugs.webkit.org/show_bug.cgi?id=22525

  • wtf/Platform.h: Enable mouse panning feaure on Windows Cairo build.
10:03 AM Changeset in webkit [38821] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=22529
Crashes seen on buildbots due to trying to stop a worker thread twice

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerObjectDestroyed): Don't try to stop the thread if it's already stopping.
8:13 AM Changeset in webkit [38820] by Simon Hausmann
  • 4 edits in trunk

WebCore:

2008-11-27 Kent Hansen <khansen@trolltech.com>

Reviewed by Simon Hausmann.

Make JavaScript bindings for Qt plugin widgets work again
this was a regression; need to handle non-NPAPI plugins as in 4.4.

WebKit:

2008-11-27 Kent Hansen <khansen@trolltech.com>

Reviewed by Simon Hausmann.

Added auto tests for making JavaScript bindings for Qt plugin widgets
work again.

5:07 AM Changeset in webkit [38819] by alp@webkit.org
  • 5 edits in trunk

2008-11-27 Alp Toker <alp@nuanti.com>

Change recently introduced C++ comments in Platform.h to C comments to
fix the minidom build with traditional C.

Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
API header breakage at build time.

4:21 AM Changeset in webkit [38818] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog dates.

4:14 AM Changeset in webkit [38817] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-27 Alp Toker <alp@nuanti.com>

Remove C++ comment from JavaScriptCore API headers (introduced r35449).
Fixes build for ANSI C applications using the public API.

  • API/WebKitAvailability.h:

Nov 26, 2008:

9:07 PM Changeset in webkit [38816] by Nikolas Zimmermann
  • 29 edits
    2 adds in trunk

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22522

Catch WML errors (invalid variable name/reference, multiple access elements, etc)
while parsing the document, and stop parsing immediately and wrap the document
fragment in a XHTML error document, just like it's done from XML parsing errors.

Until now all card elements were hidden by default (no renderer created), and
WMLDocument::finishedParsing() took care of showing the right card (either the first,
or any named card in the document, specified by document URL reference). Change this
behaviour to support displaying partially parsed WML document fragments: Mark the first
WMLCardElement inserted into the document as visible. If the document parsing finishes
without problems, WMLDocument::finishedParsing() will be called, which takes care of
showing the desired card (common case: first card in the document, which is already
visible, so nothing actually has to be done). If an error occours, the document is
correctly rendered until the error happened - wrapped in a XHTML document.

Fixes: fast/wml/err-event-binding-conflict.wml

fast/wml/err-invalid-variable-name.wml
fast/wml/err-multi-access.wml
fast/wml/err-unallowed-task-in-anchor.wml

9:04 PM Changeset in webkit [38815] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Forgot to include this layout test update in the last commit.

7:47 PM Changeset in webkit [38814] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build.

mig.h does not always define MigTypeCheck on Tiger, which leads to problems when the generated
code is built with -Wundef.

  • Plugins/Hosted/WebKitPluginHostTypes.h:
7:23 PM Changeset in webkit [38813] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Build fix. Fix up the references to files under WebKit/mac/Plugins/Hosted.

7:14 PM Changeset in webkit [38812] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Fix build.


  • Configurations/Base.xcconfig:
7:14 PM Changeset in webkit [38811] by andersca@apple.com
  • 1 edit
    2 moves in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Move WebHostedNetscapePluginView.{h|mm} to Plugins/Hosted.


(-[WebHostedNetscapePluginView handleMouseMoved:]):
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
Fix a leak.


(-[WebHostedNetscapePluginView createPlugin]):
Instantiate the plug-in, store the plug-in proxy in the _proxy ivar.


(-[WebHostedNetscapePluginView loadStream]):
(-[WebHostedNetscapePluginView shouldStop]):
Add stubs for these.


(-[WebHostedNetscapePluginView updateAndSetWindow]):
(-[WebHostedNetscapePluginView windowFocusChanged:]):
(-[WebHostedNetscapePluginView destroyPlugin]):
(-[WebHostedNetscapePluginView startTimers]):
(-[WebHostedNetscapePluginView stopTimers]):
(-[WebHostedNetscapePluginView focusChanged]):
(-[WebHostedNetscapePluginView windowFrameDidChange:]):
(-[WebHostedNetscapePluginView mouseDown:]):
(-[WebHostedNetscapePluginView mouseUp:]):
(-[WebHostedNetscapePluginView mouseDragged:]):
(-[WebHostedNetscapePluginView mouseEntered:]):
(-[WebHostedNetscapePluginView mouseExited:]):
Call the proxy.


(-[WebHostedNetscapePluginView addWindowObservers]):
(-[WebHostedNetscapePluginView removeWindowObservers]):
Add/remove observers for when the window frame changes.


  • Plugins/WebHostedNetscapePluginView.h: Removed.
  • Plugins/WebHostedNetscapePluginView.mm: Removed.
7:00 PM Changeset in webkit [38810] by andersca@apple.com
  • 2 edits in trunk/WebKit

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Add plug-in host related files to the Xcode project.


  • WebKit.xcodeproj/project.pbxproj:
6:48 PM Changeset in webkit [38809] by andersca@apple.com
  • 1 edit
    4 adds in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Add the plug-in host proxy and plug-in instance proxy objects.

These are just simple objects that forward their calls to the plug-in host.


  • Plugins/Hosted/NetscapePluginHostProxy.h: Added. (WebKit::NetscapePluginHostProxy::create): (WebKit::NetscapePluginHostProxy::port):
  • Plugins/Hosted/NetscapePluginHostProxy.mm: Added. (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::instantiatePlugin):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Added. (WebKit::NetscapePluginInstanceProxy::create): (WebKit::NetscapePluginInstanceProxy::renderContextID): (WebKit::NetscapePluginInstanceProxy::useSoftwareRenderer):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: Added. (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::resize): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::focusChanged): (WebKit::NetscapePluginInstanceProxy::windowFocusChanged): (WebKit::NetscapePluginInstanceProxy::windowFrameChanged): (WebKit::NetscapePluginInstanceProxy::startTimers): (WebKit::NetscapePluginInstanceProxy::mouseEvent): (WebKit::NetscapePluginInstanceProxy::stopTimers):
6:32 PM Changeset in webkit [38808] by andersca@apple.com
  • 1 edit
    2 adds in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein, Mark Rowe and Kevin Decker.

Add the plug-in host manager singleton.


  • Plugins/Hosted/NetscapePluginHostManager.h: Added.
  • Plugins/Hosted/NetscapePluginHostManager.mm: Added.


(WebKit::NetscapePluginHostManager::hostForPackage):
If there's an existing host proxy available, just return it. Otherwise spawn a new plug-in host and
create a new plug-in host proxy from the new plug-in host port.


(WebKit::NetscapePluginHostManager::spawnPluginHost):
Pass the plug-in host path and the preferred CPU type to the plug-in agent. When the plug-in host has
finished launching, pass it the path to the plug-in bundle.


(WebKit::NetscapePluginHostManager::initializeVendorPort):
Check in with the plug-in agent and get the new plug-in vendor port back.

6:26 PM Changeset in webkit [38807] by Nikolas Zimmermann
  • 10 edits in trunk/LayoutTests

Rubber stamped by Mark Rowe.
Fix nine failing tests on the build bot. Update mac-tiger results.

5:45 PM Changeset in webkit [38806] by darin@chromium.org
  • 3 edits
    2 adds in trunk

2008-11-10 Glenn Wilson <gwilson@chromium.org>

Reviewed by Dan Bernstein.

Fixed bug http://bugs.webkit.org/show_bug.cgi?id=21953

This fixes the crash when the small-caps font variant is used
on a lower-case glyph that does not have a corresponding
upper-case glyph defined in the set of available fonts.

This changes Font.cpp to check if the font being used exists before trying to apply the small-caps variant.


Test: fast/css/small-caps-crash.html

  • platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
5:31 PM Changeset in webkit [38805] by darin@chromium.org
  • 8 edits in trunk/WebCore

2008-10-31 Tony Chang <tony@chromium.org>

Reviewed by Oliver Hunt.

Add a new platform specific method cleanupAfterSystemDrag
that platforms can ue to clean up drag state after a
system drag. Use this method on PLAFORM(MAC).
https://bugs.webkit.org/show_bug.cgi?id=21956

  • ChangeLog:
  • page/DragController.cpp: (WebCore::DragController::doSystemDrag):
  • page/DragController.h:
  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/mac/DragControllerMac.mm: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/win/DragControllerWin.cpp: (WebCore::DragController::cleanupAfterSystemDrag):
  • page/wx/DragControllerWx.cpp:

(WebCore::DragController::cleanupAfterSystemDrag):

5:25 PM Changeset in webkit [38804] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

  • Plugins/Hosted/WebKitPluginHostTypes.h: Add copyright headers and fix the spacing around the *'s.
5:23 PM Changeset in webkit [38803] by andersca@apple.com
  • 2 edits
    1 add in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


  • Plugins/Hosted/WebKitPluginHost.defs: Add copyright headers.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Added. Forgot to add this.
5:20 PM Changeset in webkit [38802] by andersca@apple.com
  • 1 edit
    5 adds in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add plug-in host .defs.

  • Plugins/Hosted/WebKitPluginAgent.defs: Added.
  • Plugins/Hosted/WebKitPluginAgentReply.defs: Added.
  • Plugins/Hosted/WebKitPluginClient.defs: Added.
  • Plugins/Hosted/WebKitPluginHost.defs: Added.
  • Plugins/Hosted/WebKitPluginHostTypes.defs: Added.
5:18 PM Changeset in webkit [38801] by mitz@apple.com
  • 1 add in trunk/WebKit/mac/Plugins/Hosted

Added a folder for hosted plug-ins

5:07 PM Changeset in webkit [38800] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

Reviewed by Nikolas Zimmermann and Mark Rowe.

Add support for build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=22515
More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.

  • Scripts/build-dumprendertree:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/gdb-safari:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
5:07 PM Changeset in webkit [38799] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Nikolas Zimmermann.

Add support for build-webkit --chromium (tested on mac)
https://bugs.webkit.org/show_bug.cgi?id=22515
Also simplified some code using checkArgv

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
5:06 PM Changeset in webkit [38798] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Nikolas Zimmermann.

More pre-work for adding a build-webkit --chromium which works on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=22515
Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
in preparation for having a chromium cygwin and chromium mac build

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
5:06 PM Changeset in webkit [38797] by eric@webkit.org
  • 8 edits in trunk/WebKitTools

Reviewed by Nikolas Zimmermann.

Pre-work for getting build-webkit --chromium to work
https://bugs.webkit.org/show_bug.cgi?id=22515
Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()

  • Scripts/build-dumprendertree:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/gdb-safari:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
5:06 PM Changeset in webkit [38796] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

No review, build fix only.

Fix the JSC Chromium Mac build by adding JavaScriptCore/icu into the include path

4:50 PM Changeset in webkit [38795] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2008-11-26 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe and Kevin Decker.

Minor plug-in changes.


  • Plugins/WebBaseNetscapePluginView.h: Add add/remove observer method declarations.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView isFlipped]): Move this down from WebNetscapePluginView.


  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage pluginHostArchitecture]): Getter for the plug-in host architecture.


  • Plugins/WebNetscapePluginView.mm:
4:44 PM Changeset in webkit [38794] by Nikolas Zimmermann
  • 590 edits in trunk

Reviewed by Oliver Hunt.

Fix path to string logic, correctly taking closed (sub-)paths into account.
Code was just broken on cg, observed by Dirk Schulze.

QPainterPath doesn't seem to expose any functionality to detect closed sub paths,
using the elementAt() function. There might be a workaround - Dirk will investigate.

4:26 PM Changeset in webkit [38793] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-26 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=22519
Remove unnecessary include.

  • dom/XMLTokenizer.cpp:
3:40 PM Changeset in webkit [38792] by Nikolas Zimmermann
  • 3 edits
    2 adds in trunk/WebCore

Reviewed by Oliver Hunt.
Add <noop> element support, completing the task element support.

3:07 PM Changeset in webkit [38791] by jchaffraix@webkit.org
  • 60 edits in trunk/WebCore

2008-11-26 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Make more HTML elements' constructors take a QualifiedName.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • html/HTMLBlockquoteElement.cpp: (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLButtonElement.h:
  • html/HTMLDListElement.cpp: (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDListElement.h:
  • html/HTMLDirectoryElement.cpp: (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDirectoryElement.h:
  • html/HTMLDivElement.cpp: (WebCore::HTMLDivElement::HTMLDivElement):
  • html/HTMLDivElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::keygenConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor):
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement):
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
  • html/HTMLFrameSetElement.h:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::HTMLIsIndexElement):
  • html/HTMLIsIndexElement.h:
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement):
  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::HTMLLIElement):
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::HTMLLabelElement):
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement):
  • html/HTMLLegendElement.h:
  • html/HTMLMenuElement.cpp: (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMenuElement.h:
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::HTMLOListElement):
  • html/HTMLOListElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::handleIsindex):
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::HTMLTitleElement):
  • html/HTMLTitleElement.h:
  • html/HTMLUListElement.cpp: (WebCore::HTMLUListElement::HTMLUListElement):
  • html/HTMLUListElement.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement): (WebCore::MediaControlInputElement::MediaControlInputElement):
  • rendering/RenderFileUploadControl.cpp: (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createTimeDisplay):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement):
2:23 PM Changeset in webkit [38790] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.
Fix obvious problem in WMLPageState constructor, m_page was not set to the passed Page pointer.

1:48 PM Changeset in webkit [38789] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-26 Matt Perry <mpcomplete@gmail.com>

Fix Qt bustage.

See https://bugs.webkit.org/show_bug.cgi?id=22051

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet):
1:07 PM Changeset in webkit [38788] by darin@chromium.org
  • 9 edits
    2 adds in trunk/WebCore

2008-11-26 Matt Perry <mpcomplete@gmail.com>

Reviewed by Maciej Stachowiak.

Fix https://bugs.webkit.org/show_bug.cgi?id=22051
Renderthemes should be able to supply additional CSS rules to the core
ones.

  • DerivedSources.make:
  • css/CSSStyleSelector.cpp: (WebCore::parseUASheet): (WebCore::loadFullDefaultStyle): (WebCore::loadSimpleDefaultStyle):
  • css/themeWin.css: Added.
  • css/themeWinQuirks.css: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet):
  • platform/qt/RenderThemeQt.h:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraDefaultStyleSheet): (WebCore::RenderTheme::extraQuirksStyleSheet):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::extraDefaultStyleSheet): (WebCore::RenderThemeWin::extraQuirksStyleSheet):
  • rendering/RenderThemeWin.h:
1:02 PM Google Summer of Code 2008 edited by ddkilzer@apple.com
(diff)
1:01 PM WikiStart edited by ddkilzer@apple.com
(diff)
11:44 AM Changeset in webkit [38787] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Make CSSStyleSheet::addSubresourceURLStrings() iterative

Part of the fix for Bug 11850: Webarchive fails to save images referenced in CSS
<https://bugs.webkit.org/show_bug.cgi?id=11850>

Reviewed by Brady Eidson.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceURLStrings): Switch algorithm from recursive to iterative for gathering the list of all CSS stylesheets referenced in @import statements.
11:38 AM Changeset in webkit [38786] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content

<https://bugs.webkit.org/show_bug.cgi?id=22488>

Reviewed by Brady Eidson.

  • DumpRenderTree/mac/DumpRenderTree.mm: (convertWebResourceDataToString): If an IANA charset encoding string is provided, convert it to a CFStringEncoding value and then to an NSStringEncoding value, else fall back to NSUTF8StringEncoding. We also nil-check dataAsString, so the worst-case scenario is that the data won't be decoded to a string (versus crashing DumpRenderTree).
7:07 AM Changeset in webkit [38785] by krit@webkit.org
  • 3 edits in trunk/WebCore

2008-11-26 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Hausmann.

Transformations to the context shouldn't transform the currentPath.
Fixed this on Qt.

[QT] GraphicsContext's currenPath can be transformed
https://bugs.webkit.org/show_bug.cgi?id=22163

  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::concatCTM):
3:31 AM Changeset in webkit [38784] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] add/remove tests from Skipped and fix netscape plugin test
https://bugs.webkit.org/show_bug.cgi?id=22484

Add tests that needs confirmation of new results. Also, remove
some tests that are already passing.

  • platform/gtk/Skipped:
3:31 AM Changeset in webkit [38783] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] add/remove tests from Skipped and fix netscape plugin test
https://bugs.webkit.org/show_bug.cgi?id=22484

Remove print'ing to stderr

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_Initialize): (NP_Shutdown):
3:31 AM Changeset in webkit [38782] by jmalonzo@webkit.org
  • 2 edits in trunk

2008-11-26 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Darin Adler. Landed by Jan Alonzo.

Bison versions under 2.2 produce crashing CSSGrammar code for ARM
https://bugs.webkit.org/show_bug.cgi?id=22456

Check for bison version 2.2 or greater on ARM. Earlier versions produce
code that crashes on ARM devices.

  • configure.ac:
3:31 AM Changeset in webkit [38781] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-26 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build script minor fixes. Not reviewed.

  • GNUmakefile.am:
    • Add ScriptInstance.h (introduced in r38774) to

the build.

  • Move WML and GEOLOCATION conditionals before the SVG

conditional to be consistent with the style of the script.

  • Move GeolocationGtk sources to webcoregtk_sources.
1:10 AM Changeset in webkit [38780] by ap@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

2008-11-26 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler and Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=22469

Move the class DOMWindowTimer from JSDOMWindowBase into its own file in
preparation to making it work for Workers. For now, just move the code and couple
of global variables.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts): (WebCore::JSDOMWindowBase::timerFired):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/DOMTimer.cpp: Added. (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::fired):
  • bindings/js/DOMTimer.h: Added. (WebCore::DOMTimer::timeoutId): (WebCore::DOMTimer::nestingLevel): (WebCore::DOMTimer::setNestingLevel): (WebCore::DOMTimer::action): (WebCore::DOMTimer::takeAction):
12:13 AM Changeset in webkit [38779] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Geoff Garen.

Add a test for infinite recursion in workers
https://bugs.webkit.org/show_bug.cgi?id=22486

  • fast/workers/resources/use-machine-stack.js: Added.
  • fast/workers/use-machine-stack-expected.txt: Added.
  • fast/workers/use-machine-stack.html: Added.

Nov 25, 2008:

9:47 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
9:24 PM Changeset in webkit [38778] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Mark Rowe.

  • include the text direction submenu in context menus when appropriate
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Changed the default textDirectionSubmenuInclusionBehavior to "automatically", which includes the menu when the selection is confined to a single paragraph the either has right-to-left base writing direction or contains right-to-left or embedded text. Left the default for Tiger and Leopard to be "never".
6:19 PM Changeset in webkit [38777] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-25 Darin Fisher <darin@chromium.org>

Fix bustage.

https://bugs.webkit.org/show_bug.cgi?id=22493
Need to expose bridge/*.h to the WebKit build.

  • WebCore.vcproj/WebCore.vcproj:
5:38 PM Changeset in webkit [38776] by cmarrin@apple.com
  • 3 edits
    4 adds in trunk

2008-11-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22487
I was not checking for the case of 0 length keyframe lists and dereffing a null pointer.

Tests: animations/empty-keyframes.html

animations/fill-unset-properties.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
5:21 PM Changeset in webkit [38775] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Fix build, by removing some wrong last-minute changes.

5:19 PM Changeset in webkit [38774] by darin@chromium.org
  • 8 edits
    1 add in trunk/WebCore

2008-11-25 Darin Fisher <darin@chromium.org>

Reviewed by Geoffrey Garen.

https://bugs.webkit.org/show_bug.cgi?id=22493

Abstract away JSC
usage in WebCore/html
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::pluginInstance):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
  • bindings/js/ScriptInstance.h: Added.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::getInstance):
  • html/HTMLPlugInElement.h:
5:15 PM Changeset in webkit [38773] by Nikolas Zimmermann
  • 10 edits
    4 adds in trunk/WebCore

Reviewed by Sam Weinig.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22477

A WMLTaskElement checks wheter it's parent is an <anchor>/<do>/<onevent> element, and calls registerTask(this) on the parent.
Add a isWMLTaskElement() function to WMLElement, making it possible to cast to WMLTaskElement directly.

Add WMLEventHandlingElement class, inheriting from WMLElement, to serve as common base WMLTemplate/Option/CardElement,
centralizing the eventHandler() / createEventHandlerIfNeeded() implementation. Add a isWMLEventHandlingElement()
function to WMLElement, so WMLOnEventElement can create event handlers, without knowing wheter it's a
<template>/<option> or <card> element.

Add complete <onevent> support.

5:07 PM Changeset in webkit [38772] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix.

  • DumpRenderTree/cg/PixelDumpSupportCG.h:
5:05 PM Changeset in webkit [38771] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix.

  • DumpRenderTree/cg/ImageDiffCG.cpp:
4:54 PM Changeset in webkit [38770] by pol@apple.com
  • 2 edits in trunk/WebCore

2008-11-25 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Mark Rowe.

createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL

https://bugs.webkit.org/show_bug.cgi?id=22503

  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
4:33 PM Changeset in webkit [38769] by jchaffraix@webkit.org
  • 17 edits in trunk/WebCore

2008-11-25 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Element's other than HTML ones take a QualifiedName in their constructors.
To make HTMLElementFactory closer to the other ElementFactory, we need
to make them take the same arguments.
This patch only makes the 5 first one in HTMLElementFactory abide by that. The others
will go into the next patch.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::HTMLBaseElement):
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement):
  • html/HTMLBodyElement.h:
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor):
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHeadElement.h:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLHtmlElement.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement):
  • html/HTMLLinkElement.h:
  • html/HTMLMetaElement.cpp: (WebCore::HTMLMetaElement::HTMLMetaElement):
  • html/HTMLMetaElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::finished):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):
4:18 PM Changeset in webkit [38768] by Simon Fraser
  • 7 edits
    4 adds in trunk

2008-11-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=22046

Fix a crash when an animation or transition end event handler
removes the element upon which the transition/animation is running,
by keeping a reference to the AnimationBase object on the stack.

Tests: animations/transform-animation-event-destroy-element.html

transitions/transform-transition-event-destroy-element.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setChanged): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::clearRenderer):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::~CompositeAnimationPrivate):
  • page/animation/CompositeAnimation.h:
4:09 PM Changeset in webkit [38767] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-25 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Remove the unused member function JSFunction::getParameterName().

  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:
3:32 PM Changeset in webkit [38766] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Better wx build fix - support PurgeableBuffer on Mac.

3:17 PM Changeset in webkit [38765] by zecke@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

Add GeoleocationServiceGtk stubs and integrate it into the buildsystem

Add stubs for a Gtk Implementation.

3:17 PM Changeset in webkit [38764] by zecke@webkit.org
  • 2 edits in trunk

Add Geolocation support to the configure.ac

Add an option to build WebKit/Gtk+ with Geolocation. The
implementation will be using Gypsy.

3:07 PM Changeset in webkit [38763] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-11-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Polymorpic caching for get by id chain. Similar to the polymorphic caching already implemented
for self and proto accesses (implemented by allowing multiple trampolines to be JIT genertaed,
and linked together) - the get by id chain caching is implemented as a genericization of the
proto list caching, allowing cached access lists to contain a mix of proto and proto chain
accesses (since in JS style inheritance hierarchies you may commonly see a mix of properties
being overridden on the direct prototype, or higher up its prototype chain).

In order to allow this patch to compile there is a fix to appease gcc 4.2 compiler issues
(removing the jumps between fall-through cases in privateExecute).


This patch also removes redundant immediate checking from the reptach code, and fixes a related
memory leak (failure to deallocate trampolines).

~2% progression on v8 tests (bulk on the win on deltablue)

  • bytecode/Instruction.h: (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::): (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set): (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList): (JSC::PolymorphicAccessStructureList::derefStructures):
  • interpreter/Interpreter.cpp: (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::getPolymorphicAccessStructureListSlot): (JSC::Interpreter::cti_op_get_by_id_proto_list):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JIT.h: (JSC::JIT::compileGetByIdChainList):
3:00 PM Changeset in webkit [38762] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix - we don't support PurgeableBuffer on Leopard for now.

2:46 PM Changeset in webkit [38761] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-11-25 Antti Koivisto <Antti Koivisto>

Reviewed by Mark Rowe.

Fix https://bugs.webkit.org/show_bug.cgi?id=22483
Assertion failure in CachedResource::makePurgeable during layout tests


Deleting SVG image can re-enter destroyDecodedData.

  • loader/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
1:24 PM Changeset in webkit [38760] by dino@apple.com
  • 3 edits
    1 copy in trunk/WebKitSite

2008-11-25 Dean Jackson <dino@apple.com>

Add a new work-in-progress proposal for pointer-events in
HTML content. Also note that the Media Queries extensions
are not at all official.

  • specs/MediaQueriesExtensions.html:
  • specs/PointerEventsProperty.html: Added.
  • specs/index.html:
1:00 PM Changeset in webkit [38759] by darin@chromium.org
  • 1 edit
    3 moves in trunk/LayoutTests

2008-11-25 Darin Fisher <darin@chromium.org>

Disabling these newly added tests since they fail in some configurations.

See https://bugs.webkit.org/show_bug.cgi?id=21635

  • http/tests/misc/submit-get-in-utf7.html: Removed.
  • http/tests/misc/submit-get-in-utf7.html-disabled: Copied from http/tests/misc/submit-get-in-utf7.html.
  • http/tests/misc/submit-post-in-utf7.html: Removed.
  • http/tests/misc/submit-post-in-utf7.html-disabled: Copied from http/tests/misc/submit-post-in-utf7.html.
  • http/tests/misc/url-in-utf7.html: Removed.
  • http/tests/misc/url-in-utf7.html-disabled: Copied from http/tests/misc/url-in-utf7.html.
12:43 PM Changeset in webkit [38758] by zecke@webkit.org
  • 2 edits in trunk/WebKit/qt

Build fix. Use WebCore::Frame::loader instead of QWebFrame

12:02 PM Changeset in webkit [38757] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Add bug URL to ChangeLog.

12:01 PM Changeset in webkit [38756] by ap@webkit.org
  • 7 edits in trunk/WebCore

2008-11-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Made the PreflightResultCache thread-safe in preparation for usage of XMLHttpRequest by
Workers on threads.

No observable change in behavior, so no test.

  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::String::substringCopy):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::substringCopy):
  • platform/text/StringImpl.h: Added the ability to copy a substring.
  • xml/XMLHttpRequest.cpp: (WebCore::PreflightResultCacheItem::PreflightResultCacheItem): (WebCore::PreflightResultCache::PreflightResultCache): (WebCore::PreflightResultCacheItem::addToAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlAllowList): (WebCore::PreflightResultCacheItem::parseAccessControlMaxAge): (WebCore::PreflightResultCacheItem::parse): (WebCore::PreflightResultCacheItem::allowsRequest): (WebCore::PreflightResultCache::shared): (WebCore::PreflightResultCache::appendEntry): (WebCore::PreflightResultCache::canSkipPreflight): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponsePreflight): Made the PreflightResultCache threadsafe.

(WebCore::PreflightResultCacheItem::allowsCrossSiteMethod):
(WebCore::PreflightResultCacheItem::allowsCrossSiteHeaders):
Consolidation of duplicate logic.

11:31 AM Changeset in webkit [38755] by darin@chromium.org
  • 7 edits
    18 adds in trunk

2008-11-24 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

For Unicode encodings other than UTF-8, use UTF-8 for
form submission and URL query part encoding.

See https://bugs.webkit.org/show_bug.cgi?id=21635

Tests: http/tests/misc/submit-get-in-utf16be.html

http/tests/misc/submit-get-in-utf16le.html
http/tests/misc/submit-get-in-utf32be.html
http/tests/misc/submit-get-in-utf32le.html
http/tests/misc/submit-get-in-utf7.html
http/tests/misc/submit-post-in-utf16be.html
http/tests/misc/submit-post-in-utf16le.html
http/tests/misc/submit-post-in-utf32be.html
http/tests/misc/submit-post-in-utf32le.html
http/tests/misc/submit-post-in-utf7.html
http/tests/misc/url-in-utf16be.html
http/tests/misc/url-in-utf16le.html
http/tests/misc/url-in-utf32be.html
http/tests/misc/url-in-utf32le.html
http/tests/misc/url-in-utf7.html


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/text/TextEncoding.cpp: (WebCore::UTF7Encoding): (WebCore::TextEncoding::isNonByteBasedEncoding): (WebCore::TextEncoding::closestByteBasedEquivalent): (WebCore::TextEncoding::encodingForFormSubmission):
  • platform/text/TextEncoding.h:
11:21 AM Changeset in webkit [38754] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2008-11-24 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 22441: Bridge the gap between the generated ElementFactory and HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

  • Make the generated ElementFactory constructors return PassRefPtr instead of raw pointers.
  • Tweaked the generated files to better match our coding style.
  • dom/make_names.pl:
10:25 AM Changeset in webkit [38753] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitSite

2008-11-25 Jack Wootten <jackwootton@gmail.com>

Bug 20125: http://webkit.org/ missing link to key documentation for new developers.

<https://bugs.webkit.org/show_bug.cgi?id=20125>

Reviewed by David Kilzer.

  • projects/documentation/index.html: Added link to "Introduction to WebKit Objective-C Programming Guide".
7:49 AM Changeset in webkit [38752] by ap@webkit.org
  • 2 adds in trunk/LayoutTests/fast/workers

Actually landing tests for bug 22455 - Add support for Worker.terminate().

2:25 AM Changeset in webkit [38751] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=9001
Javascript stops running before replacement page data arrives

Adding a test for a bug that is longer reproducible.

  • http/tests/misc/resources/hang-connection.php: Added.
  • http/tests/misc/timer-vs-loading-expected.txt: Added.
  • http/tests/misc/timer-vs-loading.html: Added.
2:05 AM Changeset in webkit [38750] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-25 Cameron Zwarich <zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Move the collect() call in Heap::heapAllocate() that is conditionally
compiled under COLLECT_ON_EVERY_ALLOCATION so that it is before we get
information about the heap. This was causing assertion failures for me
while I was reducing a bug.

  • runtime/Collector.cpp: (JSC::Heap::heapAllocate):
12:51 AM Changeset in webkit [38749] by ap@webkit.org
  • 5 edits in trunk/LayoutTests

2008-11-24 Dean McNamee <deanm@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22350
Allow layout tests to run in php cgi mode

  • http/tests/misc/refresh-headers.php:
  • http/tests/misc/resources/redirect-result.php:
  • http/tests/misc/resources/referrer-result.php:
  • http/tests/misc/xhtml.php: Stop using getallheaders(), which is only implemented by mod_php, so that the tests could run through lighttpd.
12:13 AM Changeset in webkit [38748] by Antti Koivisto
  • 3 edits
    3 adds in trunk

WebCore:

2008-11-24 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.


Fix for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit


HTMLTokenizer::m_hasScriptsWaitingForStylesheets would still be set while
there were no scripts left to execute.


If m_hasScriptsWaitingForStylesheets becomes true during script execution
bail out from executing more scripts synchronously.

Test: fast/tokenizer/nested-cached-scripts-and-stylesheet.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):

LayoutTests:

2008-11-24 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.


Test for https://bugs.webkit.org/show_bug.cgi?id=22073
REGRESSION(r33544): Palace in the Sky crashes WebKit

  • fast/tokenizer/nested-cached-scripts-and-stylesheet-expected.txt: Added.
  • fast/tokenizer/nested-cached-scripts-and-stylesheet.html: Added.
  • fast/tokenizer/resources/load-stylesheet-and-document-write-script.js: Added.
Note: See TracTimeline for information about the timeline view.