Timeline


and

01/19/09:

23:01 Changeset [40052] by sfalken@apple.com

Fix Windows release build.
Move SVG files into all-in-one file for Windows build.

  • WebCore.vcproj/WebCore.vcproj:
  • svg/SVGAllInOne.cpp: Added.
19:31 Changeset [40051] by simon.fraser@apple.com

2009-01-19 Simon Fraser <simon.fraser@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=18078

New testcases for transitions of shorthand properties.

  • transitions/shorthand-border-transitions-expected.txt: Added.
  • transitions/shorthand-border-transitions.html: Added.
  • transitions/shorthand-transitions-expected.txt: Added.
  • transitions/shorthand-transitions.html: Added.
19:14 Changeset [40050] by sfalken@apple.com

Partial build fix.
Move new derived sources into all-in-one DerivedSources.cpp

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
18:34 Changeset [40049] by weinig@apple.com

2009-01-19 Sam Weinig <sam@webkit.org>

  • Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
17:29 Changeset [40048] by weinig@apple.com

2009-01-19 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark):
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::execute):
17:15 Changeset [40047] by weinig@apple.com

2009-01-19 Sam Weinig <sam@webkit.org>

Fix wx build.

  • plugins/PluginView.cpp: (WebCore::getString):
16:54 Changeset [40046] by weinig@apple.com

JavaScriptCore:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (JSC::::call): (JSC::::toNumber): (JSC::::toString):
  • API/JSObjectRef.cpp: (JSObjectSetPrototype):
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject):
  • bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::CodeBlock::mark):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp): (JSC::keyForImmediateSwitch):
  • interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_get_by_id_proto_list_full): (JSC::Interpreter::cti_op_get_by_id_proto_fail): (JSC::Interpreter::cti_op_get_by_id_array_fail): (JSC::Interpreter::cti_op_get_by_id_string_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error):
  • interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
  • interpreter/Register.h: (JSC::Register::marked): (JSC::Register::mark):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
  • jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad): (runWithScripts): (runInteractive):
  • parser/Nodes.cpp: (JSC::processClauseList):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
  • profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
  • runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
  • runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap): (JSC::Heap::collect): (JSC::typeName):
  • runtime/Completion.cpp: (JSC::evaluate):
  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
  • runtime/DateInstance.h: (JSC::DateInstance::internalNumber):
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
  • runtime/ErrorConstructor.cpp: (JSC::constructError):
  • runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
  • runtime/ExceptionHelpers.cpp: (JSC::createError): (JSC::createErrorMessage):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::toObject):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSArray.cpp: (JSC::JSArray::put): (JSC::JSArray::mark): (JSC::JSArray::sort): (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key): (JSC::JSArray::compactForSorting):
  • runtime/JSByteArray.h: (JSC::JSByteArray::setIndex):
  • runtime/JSCell.h: (JSC::asCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::construct):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::lastInPrototypeChain):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
  • runtime/JSImmediate.h:
  • runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString):
  • runtime/JSObject.h: (JSC::JSObject::JSObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSValuePtr::get):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
  • runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::mark):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::setInternalValue):
  • runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
  • runtime/ObjectConstructor.cpp: (JSC::constructObject):
  • runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
  • runtime/Operations.h: (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
  • runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
  • runtime/RegExpConstructor.cpp: (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::match):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
  • runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::getEnumerablePropertyNames): (JSC::Structure::createCachedPrototypeChain):
  • runtime/Structure.h: (JSC::Structure::mark):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):

JavaScriptGlue:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • JSUtils.cpp: (KJSValueToJSObject): (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectMark):
  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot):

WebCore:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMBinding.cpp: (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
  • bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot): (windowProtoFuncOpen): (WebCore::toJSDOMWindow):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage): (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNS):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::writeHelper):
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::add):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::construct):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::getString): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_HasMethod): (_NPN_Construct):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::convertValueToJObject):
  • bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance):
  • bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
  • bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue):
  • bridge/runtime_method.cpp: (JSC::callRuntimeMethod):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::callRuntimeConstructor):

WebKit/mac:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::marshalValue):
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebView.mm: (aeDescFromJSValue):

WebKit/win:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

WebKit/wx:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebFrame.cpp: (wxWebFrame::RunScript):
16:33 Changeset [40045] by andersca@apple.com

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make Evaluate an asynchronous method that has a reply method.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
16:27 Changeset [40044] by christian@webkit.org

2009-01-20 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=23419
removal of FramePrivate.h breaks GTK+'s make dist

  • GNUmakefile.am: No longer mention FramePrivate.h in our build, since it was removed.
16:16 Changeset [40043] by christian@webkit.org

2009-01-20 Alexander V. Butenko <alex@digiqube.com>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=23116
[GTK] Fix crash due a callback called from GIO after the
destruction of the ResourceHandle

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel): Only call didFinishLoading if 'client' is set, otherwise cancelling a load could lead to a crash.
15:33 Changeset [40042] by darin@apple.com

JavaScriptCore:

2009-01-19 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

Test: fast/js/string-replace-3.html

  • runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure how this ever worked.

LayoutTests:

2009-01-19 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

  • fast/js/resources/string-replace-3.js:
  • fast/js/string-replace-3-expected.txt:
15:22 Changeset [40041] by simon.fraser@apple.com

ChangeLog typo fix.

15:20 Changeset [40040] by simon.fraser@apple.com

2009-01-19 Simon Fraser <simon.fraser@apple.com>

Build fix: remove duplicate entries in the Xcode project, and
sort the project with ort-Xcode-project-file .

  • WebCore.xcodeproj/project.pbxproj:
14:23 Changeset [40039] by simon.fraser@apple.com

2009-01-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=18078

Support animations and transitions of shorthand properties by creating
PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
equal() and blend(). Build that collection of shorthand wrappers using the
shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
shorthand wrappers during 'all' transitions.

14:16 Changeset [40038] by oliver@apple.com

Actually add the new header.

14:09 Changeset [40037] by oliver@apple.com

2009-01-19 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22720

Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
only works for methods that need 6 parameters but similar classes could be added as needed for
other numbers of parameters.

Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.

Use these methods and others to remove document() from XMLHttpRequest in a few more places.

No observable change in behavior, so no test.

13:43 Changeset [40036] by beidson@apple.com

2009-01-19 Brady Eidson <beidson@apple.com>

Rubberstamped by Tim Hatcher

Fix long standing typo.

  • History/WebBackForwardList.h:
12:55 Changeset [40035] by aroben@apple.com

Add links to some recommended Visual Studio hotfixes

Reviewed by Dave Hyatt.

  • building/tools.html:
12:51 Changeset [40034] by ap@webkit.org

Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.

  • fast/dom/Window/window-properties-expected.txt:
12:31 Changeset [40033] by cfleizach@apple.com

Bug 23422: AX: AXLinks should expose access key information
https://bugs.webkit.org/show_bug.cgi?id=23422

11:15 Changeset [40032] by ap@webkit.org

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=23417
Implement application cache obsolete state

Test: http/tests/appcache/remove-cache.html

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • dom/EventNames.h:
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):
  • loader/appcache/DOMApplicationCache.idl: Added "obsolete" event and status.
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer any need to track what the newest cache was during teardown. (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing confusion with cache group lifecycle status. (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete. (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does not belong to an obsolete group. (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto. (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen via a JS swapCache() call, not only when the loader is destroyed. (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer. (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is a caller responsibility, because this method is also used when loading caches from disk. (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and inform cache storage, so that it could be removed. (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did was call cacheUpdateFailed(). (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure handing. (WebCore::ApplicationCacheGroup::didFail): Ditto. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound() method for 404 and 410 responses. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed() directly, instead of the removed didFailToLoadManifest(). (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage after update successfully finishes (moved from setNewestCache()). (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using an explicitly passed pointer, without the need to save it during teardown.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader): Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
  • loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated some comments.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not obsolete. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete groups, as they cannot be in storage. (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage completely, so that a new one could replace it, if necessary. (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions. (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state. (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the application was removed server-side. (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): Added support for OBSOLETE state and obsolete event.
  • loader/appcache/DOMApplicationCache.idl: Ditto.
11:05 Changeset [40031] by andersca@apple.com

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Allow plug-in views to return an instance directly.


  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
10:18 Changeset [40030] by cfleizach@apple.com

Bug 23399: AX: some buttons don't expose AXPress as an action
https://bugs.webkit.org/show_bug.cgi?id=23399

08:28 Changeset [40029] by aroben@apple.com

Windows build fix

WebCore:

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into $WebKitOutputDir so that WebKit can access them.
  • html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild and header copy.

WebKit/win:

Windows build fix

  • DOMCoreClasses.cpp: Replaced "using namespace WebCore" with individual using directives for each type we need from that namespace, to avoid conflicts between DOMObject and WebCore::DOMObject. (DOMElement::font): Added a now-needed WebCore::.
07:40 Changeset [40028] by ariya@webkit.org

2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry

[Qt] Show focus rect when a button gets the focus for the first time.
This is important at least for Windows style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
05:39 Changeset [40027] by hausmann@webkit.org

2009-01-19 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix calling of onkeypress event handlers on input elements when pressing enter
and other text insertion commands in the Qt port.

Similar to the win and mac ports don't execute text inserting editor
commands on RawKeyDown but continue processing the event first in
WebCore, i.e. also get a keypress event sent. If unhandled it will
come back to EditorClientQt::handleKeyboardEvent later and we execute
it then.

This also fixes search by pressing enter on www.trafikanten.no.

05:00 Changeset [40026] by ariya@webkit.org

2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

[Qt] Build fix after r39971.

  • platform/qt/LoggingQt.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
00:45 Changeset [40025] by mrowe@apple.com

Fix the build!

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

01/18/09:

23:15 Changeset [40024] by weinig@apple.com

2009-01-18 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
Remove FramePrivate

Minor PLT speedup.

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::view): (WebCore::Frame::setView): (WebCore::Frame::script): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::settings): (WebCore::Frame::selection): (WebCore::Frame::editor): (WebCore::Frame::selectionGranularity): (WebCore::Frame::setSelectionGranularity): (WebCore::Frame::dragCaretController): (WebCore::Frame::animation): (WebCore::Frame::mark): (WebCore::Frame::setMark): (WebCore::Frame::setCaretVisible): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor): (WebCore::Frame::setPrinting): (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText): (WebCore::Frame::jsStatusBarText): (WebCore::Frame::jsDefaultStatusBarText): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::needsReapplyStyles): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::updateSecureKeyboardEntryIfActive): (WebCore::Frame::typingStyle): (WebCore::Frame::setTypingStyle): (WebCore::Frame::clearTypingStyle): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::clearDOMWindow): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::isDisconnected): (WebCore::Frame::setIsDisconnected): (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::Frame::selectionBounds): (WebCore::Frame::selectionTextRects): (WebCore::Frame::isFrameSet): (WebCore::Frame::currentForm): (WebCore::Frame::forceLayout): (WebCore::Frame::sendScrollEvent): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::markedTextMatchesAreHighlighted): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::tree): (WebCore::Frame::setDOMWindow): (WebCore::Frame::domWindow): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::page): (WebCore::Frame::eventHandler): (WebCore::Frame::pageDestroyed): (WebCore::Frame::disconnectOwnerElement): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h: Removed.
  • page/FrameTree.h:
  • page/chromium/FrameChromium.cpp:
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::nodeImage): (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/qt/FrameQt.cpp: (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/win/FrameCGWin.cpp: (WebCore::Frame::nodeImage):
  • page/win/FrameWin.cpp:
18:31 Changeset [40023] by mrowe@apple.com

Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled

Reviewed by Anders Carlsson.

  • WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

09:14 Changeset [40022] by eric.carlson@apple.com

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Build fix for !ENABLE(VIDEO) following r40016.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb):

01/17/09:

20:30 Changeset [40021] by sfalken@apple.com

Build fix.

  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink):
20:15 Changeset [40020] by sfalken@apple.com

Build fix.

19:08 Changeset [40019] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
on Node is now non-virtual and just checks a bit that is set at construction time by Text.

Reviewed by Sam Weinig

  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData):
  • dom/CharacterData.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
  • dom/EventTargetNode.h:
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h: (WebCore::Node::isTextNode): (WebCore::Node::isAttributeNode):
  • dom/Text.cpp: (WebCore::Text::Text):
  • dom/Text.h:
14:20 Changeset [40018] by hyatt@apple.com

Fix failing CSS Selector layout test. Don't test first-letter in a text test, since that causes some of the selector text to be lost.

13:38 Changeset [40017] by hyatt@apple.com

WebCore:

2009-01-17 David Hyatt <hyatt@apple.com>

Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
replacement themselves, the exact transformation is instead done by the encoding (indirectly through
a method on Document).

These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
a slight speedup, and also allow encodings to do future alterations to displayed string content without
having to patch call sites again.

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::displayStringModifiedByEncoding): (WebCore::Document::displayBufferModifiedByEncoding):
  • editing/Editor.cpp: (WebCore::Editor::addToKillRing):
  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
  • editing/TextIterator.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle):
  • page/Chrome.cpp: (WebCore::displayString): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusbarText):
  • page/Frame.cpp: (WebCore::Frame::shouldClose):
  • page/Frame.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::TextEncoding):
  • platform/text/TextEncoding.h: (WebCore::TextEncoding::displayString): (WebCore::TextEncoding::displayBuffer):
  • rendering/HitTestResult.cpp: (WebCore::displayString):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setTextInternal):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):

WebKit/mac:

2009-01-17 David Hyatt <hyatt@apple.com>

Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
are done in WebCore instead.

Reviewed by Oliver Hunt

  • WebView/WebFrame.mm: (-[WebFrame _selectedString]): (-[WebFrame _stringForRange:]):

WebKit/win:

2009-01-17 David Hyatt <hyatt@apple.com>

Eliminate dependencies on backslashAsCurrencySymbol from WebKit.

Reviewed by Oliver Hunt

  • WebFrame.cpp: (WebFrame::selectedString):
09:18 Changeset [40016] by eric.carlson@apple.com

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • DerivedSources.make: include mediaControlsQT.css for Mac build.
  • WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart, CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
  • css/CSSSelector.h: (WebCore::CSSSelector::): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media controller element styles
  • css/CSSValueKeywords.in: add keywords for new media time display controls
  • css/mediaControls.css: adjust css for new control elements
  • css/mediaControlsQT.css: Added.
  • platform/ThemeTypes.h: (WebCore::): add media time display controls to ControlPart
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added (WebCore::MediaTextDisplayElement::attachToParent): Added (WebCore::MediaTextDisplayElement::update): Added (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added (WebCore::MediaControlInputElement::MediaControlInputElement): Added (WebCore::MediaControlInputElement::hitTest): Added (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when dragging the thumb
  • rendering/MediaControlElements.h: (WebCore::): Add MediaTextDisplayElement
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createTimelineContainer): Added (WebCore::RenderMedia::createTimeline): Parent is now the timeline container (WebCore::RenderMedia::createCurrentTimeDisplay): Added (WebCore::RenderMedia::createTimeRemainingDisplay): Added (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update timer when the time display elements are not visible (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not visible. Display time remaining as well as current time. (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when visibility changes (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function as we can't assume that all controls are rectangular
  • rendering/RenderMedia.h: Updated
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call element hitTest() method instead of assuming it is rectangular
  • rendering/RenderSlider.h: make mouseEventIsInThumb virtual
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with time display and timeline container
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaTimelineContainer): Updated (WebCore::RenderTheme::paintMediaCurrentTime): Added (WebCore::RenderTheme::paintMediaTimeRemaining): Added
  • rendering/RenderThemeMac.h: Updated
  • rendering/RenderThemeMac.mm: (WebCore::): (WebCore::mediaControllerTheme): (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb size when appropriate (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added (WebCore::RenderThemeMac::paintMediaCurrentTime): Added (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
  • rendering/style/RenderStyle.h: Updated (WebCore::):

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove UseSharedMediaUI

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

<rdar://problem/6293969>
Update media controls rendering results for new controls CSS.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
01:36 Changeset [40015] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Inline a few methods in FrameView for speed.

Reviewed by Oliver Hunt

  • page/FrameView.cpp:
  • page/FrameView.h: (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint):
01:27 Changeset [40014] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
the code that fetches and caches the document element into a separate function and inline the part that
does the null check and the return of the already-cached element.

Reviewed by Oliver Hunt

  • dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
  • dom/Document.h: (WebCore::Document::documentElement):
01:11 Changeset [40013] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Minor tweaks to RenderBox::styleChange to speed it up.

Reviewed by Oliver Hunt

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
00:41 Changeset [40012] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Inline FrameLoader::client().

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::client):
00:30 Changeset [40011] by hyatt@apple.com

isNull() should be size().isEmpty(). Duh.

00:27 Changeset [40010] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
than needlessly creating a rect.

Reviewed by Oliver Hunt

  • loader/CachedImage.cpp: (WebCore::CachedImage::addClient):
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h: (WebCore::Image::isNull): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height):
00:17 Changeset [40009] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.

Reviewed by Oliver Hunt

  • css/CSSParserValues.cpp: (WebCore::CSSParserValueList::addValue):
00:04 Changeset [40008] by hyatt@apple.com

2009-01-17 David Hyatt <hyatt@apple.com>

Inline Document::inPageCache(), since - because of animation code - it is now called every time
styles change on any element and so is now super-hot.

Reviewed by Oliver Hunt

  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::inPageCache):

01/16/09:

23:17 Changeset [40007] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Take Font out of the GraphicsContext. Fonts are moderately expensive to both compare and to assign to.
The Font's presence in the GraphicsContext was making save/restore more expensive than it needed to be,
and was also causing expensive comparison checks to be made before doing alterations of the Font in the
GraphicsContext.

A font must now be passed as a parameter to all text drawing functions.

Reviewed by Oliver Hunt

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont): (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::paintTextWithShadows): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
  • rendering/SVGInlineTextBox.h:
  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
22:54 Changeset [40006] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Fix a regression from the virtualContinuation()/continuation() split where I accidentally changed
two if statements.

Reviewed by Oliver Hunt

  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads):
22:36 Changeset [40005] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Fix a regression from my before/after optimization. Make sure the <q> element puts the document
into a mode where it will respect before/after rules, since <q> implicitly uses such rules.

Make sure view source mode documents also turn on before/after rules, since they are used there also.

Reviewed by Oliver Hunt

  • html/HTMLElementFactory.cpp: (WebCore::quoteConstructor):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
20:57 Changeset [40004] by barraclough@apple.com

2009-01-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

On x86-64 jit, cache JSImmedate::TagMask & JSImmedate::TagTypeNumber in
registers, save reloading them every time they're used.

Draws x86-64 jit performance close to that of i386 jit.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOpSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithIntToImmNoCheck):
17:47 Changeset [40003] by cfleizach@apple.com

Bug 23397: AXURL is not reported for <INPUT type="image"> elements
https://bugs.webkit.org/show_bug.cgi?id=23397

The AXURL of a <INPUT type="image"> element should be the URL of the image

17:14 Changeset [40002] by adele@apple.com

2009-01-16 Adele Peterson <adele@apple.com>

Windows build fix.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::logCanCachePageDecision):
16:50 Changeset [40001] by sfalken@apple.com

<rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.


This was caused by mismatched ENABLE definitions across WebCore and WebKit.


Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
Our Windows ENABLE flags now match Mac.

Reviewed by Adele Peterson.

16:47 Changeset [40000] by mrowe@apple.com

40,000!

16:47 Changeset [39999] by mrowe@apple.com

2009-01-16 Gabor Loki <loki@inf.u-szeged.hu>

Reviewed by Darin Adler.

  • Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional parameters to make command in QMake projects.
16:39 Changeset [39998] by barraclough@apple.com

2009-01-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add support to x86-64 JIT for inline double precision arithmetic ops.
+5/6% on x86-64, JIT enabled, sunspider.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::addPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movq_rr):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileFastArithSlow_op_sub):
  • parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::isInt32): (JSC::ResultType::definitelyIsNumber): (JSC::ResultType::mightBeNumber): (JSC::ResultType::isNotNumber): (JSC::ResultType::unknownType):
16:30 Changeset [39997] by eric@webkit.org

Reviewed by Justin Garcia.

Make surroundNodeRangeWithElement call insertNodeBefore implicitly
Make insertNodeBefore take PassRefPtr
Clean up the use of PassRefPtr vs. raw pointers a few places in the editing code.
https://bugs.webkit.org/show_bug.cgi?id=23389

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::insertTab):
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeNodePreservingChildren): (WebCore::ReplacementFragment::insertNodeBefore): (WebCore::ReplacementFragment::removeInterchangeNodes): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::insertNodeAfterAndUpdateNodesInserted): (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted): (WebCore::ReplaceSelectionCommand::insertNodeBeforeAndUpdateNodesInserted):
  • editing/ReplaceSelectionCommand.h:
16:15 Changeset [39996] by cfleizach@apple.com

Bug 23393: TextField has AXTitle and AXTitleUIElement
https://bugs.webkit.org/show_bug.cgi?id=23393

A control that only has a label can have an AXTitle and an AXTitleUIElement.
It should only have the AXTitleUIElement

15:48 Changeset [39995] by treat@webkit.org

The correct build fix for all platforms.

15:39 Changeset [39994] by treat@webkit.org

Fix the Qt build.

15:34 Changeset [39993] by barraclough@apple.com

2009-01-16 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fixes for SamplingTool.

https://bugs.webkit.org/show_bug.cgi?id=23390

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::storePtr):
  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::dump):
  • bytecode/SamplingTool.h: (JSC::SamplingTool::encodeSample):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
  • jit/JIT.h: (JSC::JIT::samplingToolTrackCodeBlock):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitCTICall_internal):
15:28 Changeset [39992] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Add a new flag (similar to first-line and first-letter) to Document to track whether any before/after rules
are being used. If not, don't waste time probing for those pseudo element styles.

Reviewed by Sam Weinig

  • css/CSSGrammar.y:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::usesBeforeAfterRules): (WebCore::Document::setUsesBeforeAfterRules):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines):
15:26 Changeset [39991] by alp@webkit.org

2009-01-16 Dmitry Titov <dimich@chromium.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=23394
Remove unnecessary calls to setDeferringTimers().

Use of this function was obsoleted by better handling of EINTR.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): removed setDeferringTimers calls.
15:14 Changeset [39990] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Fix badness with the cursor CSS property. For all links and form controls, resetting to a value of auto
was resulting in the creation of a cursor list. clearCursorList was creating a new list rather than just
nulling out the pointer. Since addCursor already lazily recreates the list, in the case of simple cursor types,
the clear method was wastefully creating a completely unnecessary list for all of these elements.

Also optimized the setting of simple cursor values to not alter the RenderStyle's cursor setting if it is already
set to the same value. Since this is the common case, it prevents a fault and copy of StyleInheritedData for
all links and form controls.

This is a PLT speedup.

Reviewed by Oliver Hunt

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::clearCursorList):
14:50 Changeset [39989] by darin@chromium.org

2009-01-16 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23384
PLATFORM(CHROMIUM) needs to delegate BackForwardList.cpp methods to the embedder

  • history/BackForwardList.h: (WebCore::BackForwardListClient::~BackForwardListClient): (WebCore::BackForwardList::setClient):
  • history/BackForwardListChromium.cpp: Added.
14:34 Changeset [39988] by mitz@apple.com

Reviewed by Kevin Decker and Adam Roben.

  • fix a regression that resulted in a crash when plug-ins were disabled.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Added a null check.
14:23 Changeset [39987] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Split continuation() into virtual and non-virtual versions so that the non-virtual version can
be used whereever possible. Eventually the virtual method can be eliminated completely.

Reviewed by Sam Weinig and Oliver Hunt

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::virtualContinuation): (WebCore::RenderFlow::continuation):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::hoverAncestor): (WebCore::RenderObject::updateDragState): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::adjustRectForOutlineAndShadow):
  • rendering/RenderObject.h: (WebCore::RenderObject::virtualContinuation):
13:53 Changeset [39986] by eric@webkit.org

Reviewed by Alexey Proskuryakov.

Add toggle-styles test for editing.
https://bugs.webkit.org/show_bug.cgi?id=23366

This test demonstrates at least these 3 editing bugs:
https://bugs.webkit.org/show_bug.cgi?id=17733
https://bugs.webkit.org/show_bug.cgi?id=20215
https://bugs.webkit.org/show_bug.cgi?id=22810

  • editing/execCommand/resources/toggle-styles.js: Added.
  • editing/execCommand/toggle-styles-expected.txt: Added.
  • editing/execCommand/toggle-styles.html: Added.
13:52 Changeset [39985] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Inline the methods of Font for obtaining metrics such as ascent, descent and line spacing.

Reviewed by ggaren

  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h: (WebCore::Font::width): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::lineGap): (WebCore::Font::xHeight): (WebCore::Font::unitsPerEm): (WebCore::Font::spaceWidth):
13:51 Changeset [39984] by ggaren@apple.com

JavaScriptCore:

2009-01-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
turn "c" into "" when stripping
c_ character

  • wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing control escapes inside character classes.

LayoutTests:

2009-01-16 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Added tests for <rdar://problem/6452301> REGRESSION: Latest WebKit
nightlies turn "c" into "" when stripping
c_ character

  • fast/regex/malformed-escapes-expected.txt:
  • fast/regex/resources/malformed-escapes.js:
13:48 Changeset [39983] by weinig@apple.com

2009-01-16 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23388
Remove FrameViewPrivate

Removes an indirection and is a small speedup on PLT.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::init): (WebCore::FrameView::clear): (WebCore::FrameView::didFirstLayout): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::updateDefaultScrollbarState): (WebCore::FrameView::setCanHaveScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint): (WebCore::FrameView::layoutRoot): (WebCore::FrameView::layout): (WebCore::FrameView::setMediaType): (WebCore::FrameView::mediaType): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::scrollRectIntoViewRecursively): (WebCore::FrameView::setScrollPosition): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout): (WebCore::FrameView::unscheduleRelayout): (WebCore::FrameView::isTransparent): (WebCore::FrameView::setTransparent): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor): (WebCore::FrameView::shouldUpdateWhileOffscreen): (WebCore::FrameView::setShouldUpdateWhileOffscreen): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): (WebCore::FrameView::performPostLayoutTasks): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::wasScrolledByUser): (WebCore::FrameView::setWasScrolledByUser): (WebCore::FrameView::paintContents): (WebCore::FrameView::setPaintRestriction): (WebCore::FrameView::isPainting): (WebCore::FrameView::setNodeToDraw):
  • page/FrameView.h: (WebCore::FrameView::setIsVisuallyNonEmpty): Inline.
13:37 Changeset [39982] by jchaffraix@webkit.org

2009-01-14 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23237: Some HTML constructors in HTMLElementFactory needs
an HTMLFormElement argument

  • Added 'constructorNeedsFormElement' parameter to make_names.pl to account for HTML form elements.
  • Added the new information to HTMLTagNames.in.
  • dom/make_names.pl:
  • html/HTMLTagNames.in:
13:25 Changeset [39981] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Eliminate a bunch of save/restore pairs from commonly used GraphicsContext methods. The most common reason
for needing save/restore in the line-drawing methods was antialiasing, so this has now been made part of
the cross-platform graphics state. By being able to query for the current antialiasing setting, antialiasing
can be temporarily changed and then restored back to the real value without needing to do a save/restore.

The line drawing code also set the fill color to the stroke color and relied on save/restore to prevent
a permanent mutation of the fill color in the CGContext. The new code just restores the fill color back
to its original value without doing the much more expensive save/restore.

Reviewed by Oliver Hunt

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShouldAntialias): (WebCore::GraphicsContext::shouldAntialias):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformShouldAntialias):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::setPlatformShouldAntialias):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
13:01 Changeset [39980] by andersca@apple.com

2009-01-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Clean up the bridge code and get rid of Field::name() and Method::name().


  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod):
  • bridge/c/c_runtime.cpp:
  • bridge/c/c_runtime.h: (JSC::Bindings::CField::identifier): (JSC::Bindings::CMethod::identifier):
  • bridge/jni/jni_class.cpp: (JavaClass::JavaClass):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::methodID):
  • bridge/jni/jni_runtime.h: (JSC::Bindings::JavaField::name): (JSC::Bindings::JavaMethod::name):
  • bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::methodsNamed):
  • bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcMethod::isFallbackMethod): (JSC::Bindings::ObjcMethod::selector):
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcMethod::ObjcMethod): (JSC::Bindings::ObjcMethod::getMethodSignature): (JSC::Bindings::ObjcField::ObjcField): (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::ObjcField::setValueToInstance): (JSC::Bindings::callObjCFallbackObject):
  • bridge/runtime.h:
12:54 Changeset [39979] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Optimize RenderText::styleDidChange. Don't call the base class, which does extra meaningless work.
Instead just do the one check we need to do (for a diff of layout) and mark dirty as appropriate.
Clean up the base class method also to just bail early if no m_parent is set instead of repeatedly checking
for the existence of m_parent in each if clause.

Reviewed by Darin Adler

  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange):
  • rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
12:52 Changeset [39978] by cfleizach@apple.com

Bug 23387: AX hierarchy is incorrect when iframes are present
https://bugs.webkit.org/show_bug.cgi?id=23387

AX hierarchy is incorrect when iframes are present

12:49 Changeset [39977] by dglazkov@chromium.org

2009-01-16 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=16001
Re-land layout test which didn't land as part of r39785
Move pixel results to platforms directory.

  • editing/selection/extend-selection-bidi.html: Added.
  • platform/mac/editing/selection/extend-selection-bidi-expected.checksum: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.checksum.
  • platform/mac/editing/selection/extend-selection-bidi-expected.png: Renamed from LayoutTests/editing/selection/extend-selection-bidi-expected.png.
12:44 Changeset [39976] by andersca@apple.com

2009-01-16 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Set the count to the right number of elements.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: (testEnumerate):
10:54 Changeset [39975] by beidson@apple.com

2009-01-16 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/3541409> - Split up some back/forward cache decision making and add detailed logging to
better understand what the common disqualifiers are.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::canCachePage): Split off what will be per-frame decision making into canCacheSubframe. (WebCore::FrameLoader::logCanCachePageDecision): Detailed logging about why a page may not be considered for the back/forward cache. (WebCore::FrameLoader::logCanCacheFrameDecision): Same detailed logging on the per-frame basis. (WebCore::FrameLoader::commitProvisionalLoad): Move the m_client->canCachePage() call into canCachePageContainingThisFrame().
  • loader/FrameLoader.h:
10:27 Changeset [39974] by cmarrin@apple.com

Fixed https://bugs.webkit.org/show_bug.cgi?id=23088.
This was happening because I was calling setChanged() from inside updateRendering()
which causes an infinite loop. I fixed this by deferring the setChanged to the next
run loop iteration. That made it not infinite loop, but it still retriggers the
transition forever. The problem is that there is both an 'all' and specific transition
on 'opacity'. This tickled a bug in AnimationController which causes the opacity
transition to get constantly cancelled and then retriggered. The problem is that
the specific opacity transition has a duration of 0. I got rid of the logic to
flush out 0 duration transitions and it is no longer constantly triggered. The
logic to flush them was just an optimization, and you really need to keep them
around to make the logic to override earlier animations by later ones work. And there is
very little overhead in this case anyway, so the optimization was not that useful.

I made a LayoutTest from the original testcase which tests both the infinite
loop and constantly triggering animation cases.

10:06 Changeset [39973] by cfleizach@apple.com

Bug 23385: crash at com.apple.WebCore • WebCore::HTMLAnchorElement::isKeyboardFocusable
https://bugs.webkit.org/show_bug.cgi?id=23385

Option-tabbing on page with image map links causes crash

09:13 Changeset [39972] by ariya@webkit.org

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Increase popup focus delay time to a sensible 500 ms.

  • tests/qwebframe/tst_qwebframe.cpp:
07:44 Changeset [39971] by ariya@webkit.org

2009-01-16 Thiago Macieira <thiago.macieira@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fixes QString and 8-bit mix fixes.

Details: Make sure we use QLatin1String where appropriate (and don't
use QString when not necessary)

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::create):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
  • platform/qt/LoggingQt.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
  • plugins/qt/PluginDataQt.cpp: (WebCore::PluginData::initPlugins):
07:27 Changeset [39970] by aroben@apple.com

Windows build fix

  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Removed unreachable code.
07:16 Changeset [39969] by ariya@webkit.org

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=22452

When plugins are disabled, plugin data should not be available for
the page. This ensures that navigator.plugins would not see the
additional MIME types supported by the plugins.

  • page/Page.cpp: (WebCore::Page::pluginData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldUsePlugin):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

[Qt] Prevent crash if plugin data is NULL.

  • WebCoreSupport/FrameLoaderClientQt.cpp: NULL check. (WebCore::FrameLoaderClientQt::objectContentType):
07:09 Changeset [39968] by cmarrin@apple.com

Got rid of .idl file in Resources for bug https://bugs.webkit.org/show_bug.cgi?id=21421.
Also fixed the test case to work on ppc.

03:02 Changeset [39967] by ariya@webkit.org

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Per-line cursor movement tests depend on platform-specific font
metrics. Remove them to avoid test failures on different platforms.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements):
02:12 Changeset [39966] by ariya@webkit.org

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

http://www.qtsoftware.com/developer/task-tracker/index_html?id=219344&method=entry

[Qt] API documentation for QWebPage::WebAction enum.

  • Api/qwebpage.cpp:
02:00 Changeset [39965] by ariya@webkit.org

2009-01-16 Ariya Hidayat <ariya.hidayat@trolltech.com>

Another attempt at fixing the Qt build.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getInstance):
  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
00:35 Changeset [39964] by hyatt@apple.com

2009-01-16 David Hyatt <hyatt@apple.com>

Fix for 1.85% PLT regression. Since asking if a frame is "complete" actually aggressively decodes
the frame, we add an optimization when advancing animations. If we have received all of the animated
image's data, then obviously we can go ahead and advance safely. This prevents the first draw of an image
from decoding two frames' worth of data in the case where all of the image's data has been received.

While this fixes the cached case, there could in fact be a regression on the uncached PLT from this change
as well. It's not immediately clear how that regression would be fixed, though, and it would likely be
a much smaller percentage of that overall uncached time.

Reviewed by Dan Bernstein

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::startAnimation):
00:01 Changeset [39963] by ggaren@apple.com

JavaScriptCore:

2009-01-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Fixed <rdar://problem/6471394> REGRESSION (r39164): Discarding quantifier
on assertion gives incorrect result (23075)


https://bugs.webkit.org/show_bug.cgi?id=23075

  • pcre/pcre_compile.cpp: (compileBranch): Throw away an assertion if it's followed by a quantifier with a 0 minimum, to match SpiderMonkey, v8, and the ECMA spec.
  • wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): Fall back on PCRE for the rare case of an assertion with a quantifier with a 0 minimum, since we don't handle quantified subexpressions yet, and in this special case, we can't just throw away the quantifier.

LayoutTests:

2009-01-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.


Added a test for <rdar://problem/6471394> REGRESSION (r39164): Discarding
quantifier on assertion gives incorrect result (23075)

  • fast/regex/quantified-assertions-expected.txt:
  • fast/regex/resources/quantified-assertions.js:

01/15/09:

23:44 Changeset [39962] by ap@webkit.org

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=23349
Don't store obsolete caches in disk storage

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache):
  • loader/ResourceLoader.h: Don't maintain m_wasLoadedFromApplicationCache, which was never used.
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource): Assert that only implicit and dynamic resources can be added after the cache has been fully loaded and stored to disk database.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't remove non-newest caches from disk database, as this is now done whenever the cache becomes obsolete. (WebCore::ApplicationCacheGroup::setNewestCache): Remove an obsolete cache from disk storage.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): A cache group that has never been saved should not be remembered in m_cacheHostSet. Changed the check to no longer rely on savedNewestCachePointer.
22:52 Changeset [39961] by barraclough@apple.com

2009-01-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add support in ResultType to track that the results of bitops
are always of type int32_t.

  • parser/Nodes.cpp: (JSC::ReadModifyResolveNode::emitBytecode): (JSC::ReadModifyDotNode::emitBytecode): (JSC::ReadModifyBracketNode::emitBytecode):
  • parser/Nodes.h: (JSC::ExpressionNode::): (JSC::BooleanNode::): (JSC::NumberNode::): (JSC::StringNode::): (JSC::PrePostResolveNode::): (JSC::TypeOfResolveNode::): (JSC::TypeOfValueNode::): (JSC::UnaryPlusNode::): (JSC::NegateNode::): (JSC::BitwiseNotNode::): (JSC::LogicalNotNode::): (JSC::MultNode::): (JSC::DivNode::): (JSC::ModNode::): (JSC::SubNode::): (JSC::LeftShiftNode::): (JSC::RightShiftNode::): (JSC::UnsignedRightShiftNode::): (JSC::LessNode::): (JSC::GreaterNode::): (JSC::LessEqNode::): (JSC::GreaterEqNode::): (JSC::InstanceOfNode::): (JSC::EqualNode::): (JSC::NotEqualNode::): (JSC::StrictEqualNode::): (JSC::NotStrictEqualNode::): (JSC::BitAndNode::): (JSC::BitOrNode::): (JSC::BitXOrNode::): (JSC::LogicalOpNode::):
  • parser/ResultType.h: (JSC::ResultType::isInt32): (JSC::ResultType::isNotNumber): (JSC::ResultType::booleanType): (JSC::ResultType::numberType): (JSC::ResultType::numberTypeCanReuse): (JSC::ResultType::numberTypeCanReuseIsInt32): (JSC::ResultType::stringOrNumberTypeCanReuse): (JSC::ResultType::stringType): (JSC::ResultType::unknownType): (JSC::ResultType::forAdd): (JSC::ResultType::forBitOp): (JSC::OperandTypes::OperandTypes):
22:51 Changeset [39960] by barraclough@apple.com

2009-01-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add support for integer addition, subtraction and multiplication
in JIT code on x86-64.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::mul32): (JSC::MacroAssembler::sub32): (JSC::MacroAssembler::joMul32): (JSC::MacroAssembler::joSub32):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArithSlow_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileFastArithSlow_op_sub):
20:53 Changeset [39959] by timothy@apple.com

<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type()

WebCore:

2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>

<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();

Reviewed by Timothy Hatcher.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText):

LayoutTests:

2009-01-15 Dimitri Dupuis-Latour <dupuislatour@apple.com>

Added testcases for all CSS3 pseudo-classes and pseudo-elements

<rdar://problem/5870656> selectorText and cssText are clipped for :nth-child() and :nth-of-type();

Reviewed by Timothy Hatcher.

  • fast/dom/css-selectorText-expected.txt:
  • fast/dom/css-selectorText.html:
19:20 Changeset [39958] by barraclough@apple.com

2009-01-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

On x86-64 allow JSImmediate to encode 64-bit double precision values.
This patch only affects builds that set USE(ALTERNATE_JSIMMEDIATE).

Updates the implementation of JSValuePtr
and JSImmediate:: methods that operate on neumeric values to be be aware of the new representation. When this representation is in use, the class JSNumberCell is redundant and is compiled out.

The format of the new immediate representation is documented in JSImmediate.h.

  • JavaScriptCore.exp:
  • assembler/MacroAssembler.h: (JSC::MacroAssembler::subPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::subq_rr): (JSC::X86Assembler::movq_rr): (JSC::X86Assembler::ucomisd_rr): (JSC::X86Assembler::X86InstructionFormatter::twoByteOp64):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq):
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfBothJSCells): (JSC::JIT::emitJumpIfEitherNumber): (JSC::JIT::emitJumpIfNotEitherNumber): (JSC::JIT::emitJumpIfImmediateIntegerNumber): (JSC::JIT::emitJumpIfNotImmediateIntegerNumber): (JSC::JIT::emitJumpIfNotImmediateIntegerNumbers): (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumber): (JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegerNumbers): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithIntToImmNoCheck):
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::toString):
  • runtime/JSImmediate.h: (JSC::wtf_reinterpret_cast): (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDoubleNumber): (JSC::JSImmediate::isPositiveIntegerNumber): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::doubleValue): (JSC::doubleToBoolean): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::getTruncatedUInt32): (JSC::JSImmediate::makeOutOfIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::getTruncatedInt32): (JSC::JSImmediate::toDouble): (JSC::JSImmediate::getUInt32): (JSC::JSValuePtr::isInt32Fast): (JSC::JSValuePtr::isUInt32Fast): (JSC::JSValuePtr::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers):
  • runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
  • runtime/JSNumberCell.h: (JSC::createNumberStructure): (JSC::isNumberCell): (JSC::asNumberCell): (JSC::jsNumber): (JSC::JSValuePtr::isDoubleNumber): (JSC::JSValuePtr::getDoubleNumber): (JSC::JSValuePtr::isNumber): (JSC::JSValuePtr::uncheckedGetNumber): (JSC::jsNaN): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::numberToInt32): (JSC::JSValuePtr::numberToUInt32):
  • runtime/JSValue.h:
  • runtime/NumberConstructor.cpp: (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/Operations.h: (JSC::JSValuePtr::equal): (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
  • wtf/Platform.h:
18:15 Changeset [39957] by justin.garcia@apple.com

WebCore:

2009-01-15 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver Hunt.


<rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break

If the range to style ended at [node, 0] or inside node (and if for some reason the node didn't get split),
applyInlineStyle would style node.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Rename pastLast to pastEndNode, since it doesn't come from Range::pastLastNode() anymore. pastEndNode is the node after the last one that is fully selected, since the work done in the loop that follows should only be performed on fully selected nodes.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Explicitly handle insertion into containers and after non-text nodes. Those were handled accidently before.
  • editing/htmlediting.cpp: (WebCore::caretMaxOffset): In various places we call this with a container and expect to be given the number of children in that container, so I changed it to match that. RenderBR and RenderObject::caretMaxOffset() should also be eliminated since maxDeepOffset handles non-text nodes.

LayoutTests:

2009-01-15 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver Hunt.


<rdar://problem/6444148> Styling a selection that ends in a line break can sometimes style what's after the break

  • editing/execCommand/6444148-expected.txt: Added.
  • editing/execCommand/6444148.html: Added.
16:53 Changeset [39956] by weinig@apple.com

2009-01-15 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

<rdar://problem/6045018>
REGRESSION (r34838): JavaScript objects appear to be leaked after loading google.com

Subtract the number of JSStrings cached in SmallStrings when calculating the
number of live JSObjects.

  • runtime/Collector.cpp: (JSC::Heap::objectCount):
  • runtime/SmallStrings.cpp: (JSC::SmallStrings::count):
  • runtime/SmallStrings.h:
16:29 Changeset [39955] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Get rid of the dreaded BindingLanguage once and for all. Also get rid of Instance::getInstance.

  • bridge/c/c_instance.h:
  • bridge/jni/jni_instance.h:
  • bridge/objc/objc_instance.h:
  • bridge/qt/qt_instance.h:
  • bridge/runtime.cpp:
  • bridge/runtime.h:
  • bridge/runtime_object.h:
16:24 Changeset [39954] by weinig@apple.com

2009-01-15 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • runtime/Collector.cpp:
16:03 Changeset [39953] by hyatt@apple.com

2009-01-15 David Hyatt <hyatt@apple.com>

Eliminate an extra virtual function call that occurs for every single RenderText by moving the SVG-specific
code that was placed into RenderText::styleDidChange into RenderSVGInlineText::styleDidChange.

Reviewed by Oliver Hunt

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
16:01 Changeset [39952] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Another attempt at fixing the Qt build.


  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getOwnPropertySlot): (JSC::Bindings::QtInstance::put):
  • bridge/qt/qt_instance.h:
  • bridge/runtime.h: (JSC::Bindings::Instance::getOwnPropertySlot): (JSC::Bindings::Instance::put):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::RuntimeObjectImp::put):
15:49 Changeset [39951] by weinig@apple.com

2009-01-15 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Fix crash seen running fast/canvas.

Make sure to mark the ScopeNode and CodeBlock being created
in the re-parse for exception information.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • parser/Nodes.h: (JSC::ScopeNode::mark):
  • runtime/Collector.cpp: (JSC::Heap::collect):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
15:48 Changeset [39950] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add QtInstance::getInstance and start using it.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtRuntimeObjectImp::mark): (JSC::Bindings::QtRuntimeObjectImp::classInfo): (JSC::Bindings::): (JSC::Bindings::QtInstance::getInstance):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
15:38 Changeset [39949] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add the ability for Instance objects to override getOwnPropertySlot/put for runtime objects.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getOwnPropertySlot): (JSC::Bindings::QtInstance::put):
  • bridge/qt/qt_instance.h:
  • bridge/runtime.h: (JSC::Bindings::Instance::getOwnPropertySlot): (JSC::Bindings::Instance::put):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::RuntimeObjectImp::put):
15:30 Changeset [39948] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Fix the QT build.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::createRuntimeObject):
  • bridge/qt/qt_instance.h:
15:11 Changeset [39947] by hyatt@apple.com

2009-01-15 David Hyatt <hyatt@apple.com>

Fix for <rdar://problem/6500278> REGRESSION: 3.5% of samples on iBench in WebCore::Frame::setZoomFactor

setZoomFactor was supposed to bail if both the zoom factor and mode were the same. The mode check was
buggy and doing the wrong thing.

Reviewed by Darin Adler

  • page/Frame.cpp: (WebCore::Frame::setZoomFactor):
14:58 Changeset [39946] by andersca@apple.com

2009-01-15 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Make Instance::createRuntimeObject a virtual function and override it for QtInstance.


  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::getRuntimeObject):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertNPVariantToValue):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::convertJObjectToValue):
  • bridge/jni/jni_runtime.cpp: (JavaField::valueFromInstance): (JavaArray::valueAt):
  • bridge/objc/objc_utility.mm: (JSC::Bindings::convertObjcValueToValue):
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::getRuntimeObject): (JSC::Bindings::QtInstance::createRuntimeObject):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue): (JSC::Bindings::QtConnectionObject::execute):
  • bridge/runtime.cpp: (JSC::Bindings::Instance::createRuntimeObject):
  • bridge/runtime.h:
13:31 Changeset [39945] by ap@webkit.org

2009-01-15 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23347
Compilation of JavaScriptCore/wtf/ThreadingPthreads.cpp fails on Linux

  • wtf/ThreadingPthreads.cpp: included limits.h as INT_MAX is defined there.
13:30 Changeset [39944] by dglazkov@chromium.org

2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23354
Fix up graphics/chromium files to account for Uniscribe style scrubbing.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillNonBMPGlyphs):
13:24 Changeset [39943] by dglazkov@chromium.org

2009-01-15 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23333
Adjust due to a name change that happened in a WebKit.

  • svg/graphics/skia/SVGPaintServerPatternSkia.cpp: (WebCore::SVGPaintServerPattern::setup):
13:15 Changeset [39942] by oliver@apple.com

Bug 23225: REGRESSION: Assertion failure in reparseInPlace() (m_sourceElements) at sfgate.com
<https://bugs.webkit.org/show_bug.cgi?id=23225> <rdar://problem/6487432>

Reviewed by Geoff Garen

Character position for open and closing brace was incorrectly referencing m_position to
record their position in a source document, however this is unsafe as BOMs may lead to
m_position being an arbitrary position from the real position of the current character.

12:52 Changeset [39941] by dglazkov@chromium.org

2009-01-15 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23340
Add remaining bits of graphics/chromium.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Added. (WebCore::scaleEmToUnits): (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: Added. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformDestroy): (WebCore::SimpleFontData::smallCapsFontData): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Added. (WebCore::ThemeHelperWin::ThemeHelperWin): (WebCore::ThemeHelperWin::~ThemeHelperWin):
  • platform/graphics/chromium/ThemeHelperChromiumWin.h: Added. (WebCore::ThemeHelperWin::): (WebCore::ThemeHelperWin::context): (WebCore::ThemeHelperWin::rect):
  • platform/graphics/chromium/UniscribeHelper.cpp: Added. (WebCore::treatAsSpace): (WebCore::containsMissingGlyphs): (WebCore::setLogFontAndStyle): (WebCore::UniscribeHelper::UniscribeHelper): (WebCore::UniscribeHelper::~UniscribeHelper): (WebCore::UniscribeHelper::initWithOptionalLengthProtection): (WebCore::UniscribeHelper::width): (WebCore::UniscribeHelper::justify): (WebCore::UniscribeHelper::characterToX): (WebCore::UniscribeHelper::xToCharacter): (WebCore::UniscribeHelper::draw): (WebCore::UniscribeHelper::firstGlyphForCharacter): (WebCore::UniscribeHelper::fillRuns): (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::fillShapes): (WebCore::UniscribeHelper::fillScreenOrder): (WebCore::UniscribeHelper::adjustSpaceAdvances): (WebCore::UniscribeHelper::applySpacing): (WebCore::UniscribeHelper::advanceForItem):
  • platform/graphics/chromium/UniscribeHelper.h: Added. (WebCore::UniscribeHelper::directionalOverride): (WebCore::UniscribeHelper::setDirectionalOverride): (WebCore::UniscribeHelper::inhibitLigate): (WebCore::UniscribeHelper::setInhibitLigate): (WebCore::UniscribeHelper::letterSpacing): (WebCore::UniscribeHelper::setLetterSpacing): (WebCore::UniscribeHelper::spaceWidth): (WebCore::UniscribeHelper::setSpaceWidth): (WebCore::UniscribeHelper::wordSpacing): (WebCore::UniscribeHelper::setWordSpacing): (WebCore::UniscribeHelper::setAscent): (WebCore::UniscribeHelper::init): (WebCore::UniscribeHelper::tryToPreloadFont): (WebCore::UniscribeHelper::Shaping::Shaping): (WebCore::UniscribeHelper::Shaping::glyphLength): (WebCore::UniscribeHelper::Shaping::charLength): (WebCore::UniscribeHelper::Shaping::effectiveAdvances): (WebCore::UniscribeHelper::nextWinFontData): (WebCore::UniscribeHelper::resetFontIndex):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: Added. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::tryToPreloadFont): (WebCore::UniscribeHelperTextRun::nextWinFontData): (WebCore::UniscribeHelperTextRun::resetFontIndex):
  • platform/graphics/chromium/UniscribeHelperTextRun.h: Added.
11:54 Changeset [39940] by adele@apple.com

2009-01-15 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.


Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
<rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html


Return S_OK or E_FAIL based on the result from CreateInstance.
This was causing DumpRenderTree to not realize it had just gotten a null documentElement.


  • DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent. (DOMNode::parentNode): (DOMNode::ownerDocument): (DOMNodeList::item): (DOMDocument::documentElement): (DOMDocument::createElement): (DOMDocument::getElementsByTagName): (DOMDocument::getElementsByTagNameNS): (DOMDocument::getElementById): (DOMDocument::getComputedStyle): (DOMDocument::createEvent): (DOMElement::style):
11:44 Changeset [39939] by cmarrin@apple.com

Fixed Windows project file after https://bugs.webkit.org/show_bug.cgi?id=21421

11:26 Changeset [39938] by mrowe@apple.com

Merge r39913.

11:25 Changeset [39937] by beidson@apple.com

2009-01-15 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

Fix problem where a URL visited as non-GET once is flagged as non-GET forever.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Always update the HTTPNonGet flag for all loads with an HTTP Method
11:25 Changeset [39936] by dglazkov@chromium.org

2009-01-15 Aaron Boodman <aa@chromium.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=15279
Right clicking over text (or multiple spaces) auto selects the word
(or multiple spaces) under it, which is not a desirable effect for some
platforms.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Don't select words on right-click on Chromium.
11:08 Changeset [39935] by mrowe@apple.com

Versioning.

10:52 Changeset [39934] by mrowe@apple.com

New tag.

01:27 Changeset [39933] by darin@chromium.org

2009-01-15 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23345
SharedBuffer.h should include wtf/OwnPtr.h

  • platform/SharedBuffer.h:
Note: See TracTimeline for information about the timeline view.