Timeline


and

02/03/09:

22:58 WebCoreRendering created by amil.reyes@gmail.com
22:55 WikiStart edited by amil.reyes@gmail.com
(diff)
21:24 Changeset [40607] by oliver@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6554092> Slow script dialog starts coming up over and over again

Reviewed by John Sullivan.

Work around <rdar://problem/6554067> by consuming any exceptions that are
thrown by _web_localizedDescription

21:06 Changeset [40606] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.

Reviewed by Mark Rowe

  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
20:59 Changeset [40605] by bfulgham@webkit.org
  • 4 edits
    3 adds in trunk

2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.

20:26 Changeset [40604] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.

Reviewed by Mark Rowe

  • rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::bidiNext):
20:24 Changeset [40603] by mrowe@apple.com
  • 1 edit in branches/Safari-6528/WebKit/win/WebHistoryItem.cpp

Merge r40394.

20:24 Changeset [40602] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40392.

20:23 Changeset [40601] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40529.

20:23 Changeset [40600] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40528.

20:23 Changeset [40599] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40516.

20:23 Changeset [40598] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Merge r40514.

20:23 Changeset [40597] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40511.

20:23 Changeset [40596] by mrowe@apple.com
  • 37 edits in branches/Safari-6528

Merge r40508.

20:23 Changeset [40595] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebKit/win

Merge r40503.

20:23 Changeset [40594] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebKit

Merge r40382.

20:23 Changeset [40593] by mrowe@apple.com
  • 10 edits in branches/Safari-6528

Merge r40380.

20:23 Changeset [40592] by mrowe@apple.com
  • 9 edits in branches/Safari-6528/WebKit

Merge r40436.

20:23 Changeset [40591] by mrowe@apple.com
  • 16 edits in branches/Safari-6528

Merge r40432.

20:23 Changeset [40590] by mrowe@apple.com
  • 10 edits
    55 adds in branches/Safari-6528

Merge r40424.

20:22 Changeset [40589] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40376.

20:22 Changeset [40588] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40373.

20:22 Changeset [40587] by mrowe@apple.com
  • 9 edits in branches/Safari-6528

Merge r40353.

20:22 Changeset [40586] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40558.

20:22 Changeset [40585] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-6528

Merge r40541.

20:22 Changeset [40584] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-6528

Merge r40522.

20:22 Changeset [40583] by mrowe@apple.com
  • 5 edits in branches/Safari-6528/WebCore

Merge r40472.

20:22 Changeset [40582] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKitLibraries

Merge r40448.

20:22 Changeset [40581] by mrowe@apple.com
  • 6 edits in branches/Safari-6528

Merge r40397.

20:22 Changeset [40580] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40396.

20:22 Changeset [40579] by mrowe@apple.com
  • 5 edits
    2 copies
    5 adds in branches/Safari-6528

Merge r40368.

20:22 Changeset [40578] by mrowe@apple.com
  • 11 edits in branches/Safari-6528

Merge r40366.

20:21 Changeset [40577] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40358.

20:21 Changeset [40576] by mrowe@apple.com
  • 3 edits
    7 adds in branches/Safari-6528

Merge r40356.

20:21 Changeset [40575] by mrowe@apple.com
  • 6 edits
    1 copy
    2 adds in branches/Safari-6528

Merge r40355.

20:21 Changeset [40574] by mrowe@apple.com
  • 24 edits in branches/Safari-6528

Merge r40354.

20:21 Changeset [40573] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Merge r40345.

20:21 Changeset [40572] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40343.

20:21 Changeset [40571] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40339.

20:21 Changeset [40570] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40335.

20:21 Changeset [40569] by mrowe@apple.com
  • 13 edits
    3 adds in branches/Safari-6528

Merge r40332.

20:21 Changeset [40568] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40313.

20:21 Changeset [40567] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40305.

20:20 Changeset [40566] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40304.

18:45 Changeset [40565] by simon.fraser@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in Changelog

18:41 Changeset [40564] by simon.fraser@apple.com
  • 19 edits
    1 add in trunk/WebCore

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23628

Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.

Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.

RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.

18:06 Changeset [40563] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.

Reviewed by Darin Adler & Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
18:02 Changeset [40562] by barraclough@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-02-03 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=23715

Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:

jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32

Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).

This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branchPtrWithPatch): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchTest32): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchAdd32): (JSC::MacroAssembler::branchMul32): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchSub32): (JSC::MacroAssembler::set32): (JSC::MacroAssembler::setTest32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::jccRel32): (JSC::X86Assembler::setccOpcode): (JSC::X86Assembler::cmpq_mr): (JSC::X86Assembler::setcc_r): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::jne): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::jcc): (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference):
17:52 Changeset [40561] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-03 David Hyatt <hyatt@apple.com>

Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.

Reviewed by Maciej

  • wtf/Vector.h: (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::allocateBuffer):
17:18 Changeset [40560] by justin.garcia@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)


Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::clear):
  • editing/Editor.h: (WebCore::Editor::setShouldStyleWithCSS): (WebCore::Editor::shouldStyleWithCSS):
  • editing/EditorCommand.cpp: (WebCore::executeStyleWithCSS): (WebCore::stateStyleWithCSS): (WebCore::CommandEntry::):

LayoutTests:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)

  • editing/execCommand/5685604-1-expected.txt: Added.
  • editing/execCommand/5685604-1.html: Added.
17:05 Changeset [40559] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig.

This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
16:55 Changeset [40558] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

  • Fix for <rdar://problem/6549743>

On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].


  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
16:46 Changeset [40557] by kevino@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

ChangeLog date fix.

16:39 Changeset [40556] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).

https://bugs.webkit.org/show_bug.cgi?id=23701

16:31 Changeset [40555] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Back this change out since it is causing layout tests to crash. There is something subtle going on
here.

Reviewed by Darin Adler

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:57 Changeset [40554] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.

Reviewed by Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:56 Changeset [40553] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.

Reviewed by Darin Adler

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/KURL.cpp: (WebCore::KURL::invalidate): (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::isHTTPOrHTTPS):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::setAllowHTTPCookies):
15:53 Changeset [40552] by bfulgham@webkit.org
  • 3 edits in trunk/LayoutTests

Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.

15:25 Changeset [40551] by zecke@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Add manual test for floating divs with scrollbars.

  • manual-tests/gtk/floatingdiv.html: Added.
15:25 Changeset [40550] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.

Also do not disconnect the signals when destroying the widget,
it's superfluous.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk):
15:25 Changeset [40549] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Declare scrollBar as GtkWidget* to avoid needless
casting.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk):
15:25 Changeset [40548] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Properly calculate the scrollbar location for their
usage in RenderLayout.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
14:14 Changeset [40547] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
of these methods up to RenderObject.


Reviewed by Beth Dakin

  • bindings/objc/DOM.mm: (-[DOMNode lineBoxRects]):
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuadsForRange):
  • rendering/RenderText.h:
13:26 Changeset [40546] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig and Oliver Hunt.

Added getImageData() support for QtWebKit.

[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
13:00 Changeset [40545] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Eric Roman <eroman@chromium.org>

Reviewed by Holger Freyther.

Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
12:43 Changeset [40544] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23358

Hook accelerated compositing into RenderLayer.

12:14 Changeset [40543] by simon.fraser@apple.com
  • 19 edits in trunk

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23365

Hook up accelerated compositing layers the native
view system on Mac.

11:51 Changeset [40542] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Hans Peter Freyther.

Fixed getImageData and putImageData and respect pre-
multiplied colors.

Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
https://bugs.webkit.org/show_bug.cgi?id=21575

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
11:49 Changeset [40541] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Brady Eidson.

  • fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)

Test: fast/history/window-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the missing lockBackForwardList parameter to FrameLoader::changeLocation().

LayoutTests:

Reviewed by Brady Eidson.

  • test for <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
  • fast/history/window-open-expected.txt: Added.
  • fast/history/window-open.html: Added.
11:40 Changeset [40540] by zecke@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22988
[GTK] Need a public method to add a WebKitWebHistoryItem to
WebKitWebBackForwardList.

Wrap WebCore::BackForwardList::addItem.

  • tests/main.c: (test_webkit_web_back_forward_list_add_item): (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.h:
09:46 Changeset [40539] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build after r40536.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
09:41 Changeset [40538] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix -Wmissing-prototypes builds
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidSendData): Marked this function static. (WebCore::workerContextDidReceiveResponse): Ditto. (WebCore::workerContextDidReceiveData): Ditto. (WebCore::workerContextDidFinishLoading): Ditto. (WebCore::workerContextDidFail): Ditto. (WebCore::workerContextDidGetCancelled): Ditto. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
09:29 Changeset [40537] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706

<rdar://problem/6509514>

Reviewed by Adam Roben.

  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Null check the value returned from WebCore::IconDatabase::iconForPageURL().
08:10 Changeset [40536] by hausmann@webkit.org
  • 6 edits in trunk

JavaScriptCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added accessor for JSByteArray storage.

WebCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix conversion of QByteArray to JavaScript and back. Instead of
converting it to a String (data loss!) we now map it to JSByteArray.

WebKit/qt:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added a unit test to verify the succesful conversion from QByteArray to
JSByteArray and back to QByteArray.

07:44 Changeset [40535] by ap@webkit.org
  • 2 edits in trunk/WebCore

Build fix.

  • GNUmakefile.am: Removed WorkerTask.{h,cpp}.
02:32 Changeset [40534] by ap@webkit.org
  • 11 edits
    3 adds in trunk

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22718
Implement WindowTimers interface in Workers.

This patch moves timeoutID from Document to ScriptExecutionContext
and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
Also added a test for those methods.

Test: fast/workers/worker-timeout.html

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::setTimeoutOrInterval): Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.

(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::clearTimeout):
(WebCore::JSWorkerContext::setInterval):
(WebCore::JSWorkerContext::clearInterval):
Added methods exposed to JS.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addTimeout): (WebCore::ScriptExecutionContext::removeTimeout): (WebCore::ScriptExecutionContext::findTimeout):
  • dom/ScriptExecutionContext.h: The timerID map moves from Document to ScriptExecutionContext, to be available to Document and to WorkerContext.
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
  • dom/WorkerContext.h:
  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::removeById): Code change here reflects move of timeoutID map to the ScriptExecutionContext. Some checks and casts are no longer needed.
01:18 Changeset [40533] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer on WorkerRunLoop

  • JavaScriptCore.exp: Forgot to expose ThreadCondition::timedWait() in one of previous patches.
01:11 Changeset [40532] by ap@webkit.org
  • 3 edits in trunk/WebCore

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer for Workers.

  • dom/WorkerRunLoop.cpp: Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads. (WebCore::WorkerSharedTimer::WorkerSharedTimer): (WebCore::WorkerSharedTimer::setFiredFunction): (WebCore::WorkerSharedTimer::setFireTime): (WebCore::WorkerSharedTimer::stop): (WebCore::WorkerSharedTimer::isActive): (WebCore::WorkerSharedTimer::fireTime): (WebCore::WorkerSharedTimer::fire): (WebCore::WorkerRunLoop::WorkerRunLoop): Initializes a WorkerSharedTimer instance. (WebCore::WorkerRunLoop::~WorkerRunLoop): The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer. (WebCore::WorkerRunLoop::run): Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
  • dom/WorkerRunLoop.h: Add member of type OwnPtr<WorkerSharedTimer>
00:57 Changeset [40531] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:24 Changeset [40530] by ap@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix.

  • dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where appropriate.
00:05 Changeset [40529] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-03 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):

02/02/09:

23:57 Changeset [40528] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):
23:41 Changeset [40527] by ap@webkit.org
  • 15 edits
    3 adds in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Part 2 of
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>

Enable the async portion of ThreadableLoader for workers.

No observable change in behavior, so no test.

23:38 Changeset [40526] by ap@webkit.org
  • 12 edits
    2 deletes in trunk/WebCore

2009-02-02 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>

No observable change in behavior, so no test.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Worker.cpp:
  • dom/Worker.h:
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postTask): (WebCore::WorkerContext::postTaskToWorkerObject):
  • dom/WorkerContext.h:
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Expose postTaskToWorkerContext for use by the worker object thread.

(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
with postMessageToWorkerObject.

  • dom/WorkerMessagingProxy.h:
  • dom/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::postTask):
  • dom/WorkerRunLoop.h:
  • dom/WorkerTask.cpp: Removed.
  • dom/WorkerTask.h: Removed. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.

The resulted in the class going away along with an adapter that made
a ScriptExecutionContext::Task look like a WorkerTask.

  • dom/WorkerThread.cpp:
  • dom/WorkerThread.h:
23:36 Changeset [40525] by ap@webkit.org
  • 10 edits
    2 adds in trunk/WebCore

2009-02-02 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23618: Templated worker tasks should be more error proof to use.
<https://bugs.webkit.org/show_bug.cgi?id=23618>

Add the generic worker tasks templates needed for the WorkerThreadableLoader.

No observable change in behavior, so no test.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • dom/CrossThreadCopier.cpp: Added.
  • dom/CrossThreadCopier.h: Added. (WebCore::CrossThreadCopierPassThrough::copy):
  • dom/GenericWorkerTask.h: Stop doing the WorkerMessagingProxy::askedToTerminate call automatically in performTask because was not obvious that it would be done and not always needed.

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask1::GenericWorkerTask1):
(WebCore::GenericWorkerTask1::performTask):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask2::GenericWorkerTask2):
(WebCore::GenericWorkerTask2::performTask):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask3::GenericWorkerTask3):
(WebCore::GenericWorkerTask3::performTask):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask4::GenericWorkerTask4):
(WebCore::GenericWorkerTask4::performTask):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask5::GenericWorkerTask5):
(WebCore::GenericWorkerTask5::performTask):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask6::GenericWorkerTask6):
(WebCore::GenericWorkerTask6::performTask):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask7::GenericWorkerTask7):
(WebCore::GenericWorkerTask7::performTask):
(WebCore::createCallbackTask):

  • dom/WorkerContext.cpp: (WebCore::addMessageTask): (WebCore::WorkerContext::addMessage):
  • dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
22:45 Changeset [40524] by weinig@apple.com
  • 15 edits in trunk/WebCore

2009-02-02 Sam Weinig <sam@webkit.org>

Reviewed by David "The Barnabas Jones" Hyatt.

Move removeChildNode, appendChildNode and insertChildNode from
RenderContainer into RenderObjectChildList. Make moveChildNode
static in RenderBlock, as that was the only user.

  • rendering/RenderBlock.cpp: (WebCore::moveChild): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::handleRunInChild):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild):
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::childBecameNonInline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
  • rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper):
  • rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore::RenderSVGContainer::removeChild):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::removeChild):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChild):
  • rendering/RenderTableSection.h:
22:39 Changeset [40523] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=23697
Leaks seen on Worker tests

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed() is called.
22:08 Changeset [40522] by oliver@apple.com
  • 3 edits
    3 adds in trunk

<https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
<rdar://problem/6543487>

Reviewed by Gavin Barraclough.

In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
itself recursively, it will incorrectly emit (and thus consume) the next single character
match in the current character class. As WREC uses a binary search this out of sequence
codegen could result in a character match being missed and so cause the regex to produce
incorrect results.

21:26 Changeset [40521] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Move positionForCoordinates up from RenderContainer into RenderBox.

Reviewed by Sam Weinig

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForCoordinates):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
20:47 Changeset [40520] by bfulgham@webkit.org
  • 4 edits in trunk

Incorrect handling of findstr results in *.vcproj.
Fixes https://bugs.webkit.org/show_bug.cgi?id=15813

20:46 Changeset [40519] by ggaren@apple.com
  • 3 edits in trunk/WebKit/wx

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
  • WebKitSupport/FrameLoaderClientWx.h:
20:33 Changeset [40518] by hyatt@apple.com
  • 13 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Refactor the handling of before/after content and generated content. Move most of the functions from
RenderContainer into RenderObjectChildList.

Reviewed by Sam Weinig

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::findBeforeAfterParent): (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderObjectChildList.h:
20:23 Changeset [40517] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-02-02 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23661
Fix Chromium build.

  • history/HistoryItem.h: need to include <wtf/OwnPtr.h>
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
19:08 Changeset [40516] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
19:06 Changeset [40515] by ggaren@apple.com
  • 4 edits in trunk/WebKit

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame): (QWebFrame::load): (QWebFrame::setHtml): (QWebFrame::setContent):

WebKit/wx:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebFrame.cpp: (wxWebFrame::LoadURL):
19:03 Changeset [40514] by ggaren@apple.com
  • 4 edits in trunk

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCore.base.exp:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
18:56 Changeset [40513] by ggaren@apple.com
  • 2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • webkit/webkitwebview.cpp:
18:54 Changeset [40512] by ggaren@apple.com
  • 2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • webkit/webkitwebframe.cpp:
18:52 Changeset [40511] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
18:52 Changeset [40510] by ggaren@apple.com
  • 2 edits in trunk/WebKit/qt

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
18:49 Changeset [40509] by ggaren@apple.com
  • 2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
18:31 Changeset [40508] by ggaren@apple.com
  • 37 edits in trunk

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • WebCore.base.exp: Renamed some exports.


  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (windowProtoFuncOpen):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::assign): Treat any navigation that is not initiated by the user as a redirect from the perspective of global history.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect chain.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect): (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect): (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly, added yet another way to track redirect state during loading, since none of the others did what I wanted, and I didn't want to cause behavior changes in existing code.
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Stubbed out a client function to keep things building.


  • loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect => FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all the other meanings of "redirect" in the loading code.

(WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
redirect as a redirect from the perspective of global history.

(WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
parameter.

(WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.

(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load): Updated for rename and extra parameter.

(WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
in the DocumentLoader, so it's accessible to WebKit's global history code.

(WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
only has meaning to global history, and m_quickRedirectComing pertains
to other kinds of history.

(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.


(WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
navigations even if they don't create new history items, so we can track
the redirect in the existing history item.

  • loader/FrameLoader.h: See above.


  • loader/FrameLoaderClient.h: New client interface used by FrameLoader::updateHistory* to record a redirect even if it doesn't create a new history item of its own.
  • loader/FrameLoaderTypes.h: See above. (WebCore::):
  • page/DragController.cpp: (WebCore::DragController::performDrag):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Updated for extra parameter.

WebKit/gtk:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Track redirects in global history.

Keep GTK building.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate lastVisitedEntry]): (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history entry in case we're asked to add redirect information to it later.

(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
(-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
information in global history.

  • History/WebHistoryInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.h: See above and below.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect information in global history.
  • WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
  • WebView/WebFramePrivate.h: Updated for rename and extra parameter.

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

Keep Qt building.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientQt::createFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Store redirect information in global history.

(WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.

  • WebCoreSupport/WebFrameLoaderClient.h: See above.
  • WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::loadData): Updated for extra parameter.
  • WebHistory.cpp: (WebHistory::visitedURL): (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect information in global history.
  • WebHistory.h: See above.
17:35 Changeset [40507] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Work around a limitation in MIG where two functions can't have the same name even if they're
not in the same subsystem.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
17:21 Changeset [40506] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
Remove RenderSVGContainer's implementation, since it was never called.

Reviewed by Beth Dakin

  • rendering/RenderBox.cpp: (WebCore::RenderBox::minPrefWidth):
  • rendering/RenderBox.h: (WebCore::RenderBox::calcPrefWidths):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
  • rendering/RenderSVGContainer.h:
16:59 Changeset [40505] by andersca@apple.com
  • 11 edits in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.


  • WebCore.LP64.exp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement): (WebCore::ScriptController::jsObjectForPluginElement):
  • bindings/js/ScriptController.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement WKPCGetPluginElementObject.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetPluginElementNPObject):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView WebCore::]):
16:45 Changeset [40504] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-02 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel (and Ojan Vafai).

https://bugs.webkit.org/show_bug.cgi?id=23696
Select element doesn't show new value when focus is switched in
onchange event.

Fix PopupMenuChromium to hide itself before calling valueChanged. This
better matches the behavior of the other ports.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
16:28 Changeset [40503] by beidson@apple.com
  • 7 edits in trunk/WebKit/win

2009-02-02 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.

  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
  • WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
  • WebHistoryItem.h:
16:27 Changeset [40502] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Make sure scrollWidth/Height just return 0 for inline flows.

Reviewed by Beth Dakin

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
16:27 Changeset [40501] by darin@apple.com
  • 25 edits in trunk

JavaScriptCore:

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

  • API/JSObjectRef.cpp: (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
  • parser/Lexer.cpp: (JSC::Lexer::Lexer): Ditto. (JSC::Lexer::clear): Ditto.
  • wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of reserveCapacity for use when the vector is brand new (still size 0 with no capacity other than the inline capacity).

WebCore:

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::sortMatchedRules):
  • dom/Document.cpp: (WebCore::Document::formElementsState):
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::reserveInitialCapacity):
  • editing/TextIterator.cpp: (WebCore::CharacterIterator::string): (WebCore::SearchBuffer::SearchBuffer): (WebCore::plainTextToMallocAllocatedBuffer):
  • editing/markup.cpp: (WebCore::joinMarkups):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • page/mac/AccessibilityObjectWrapper.mm: (convertToVector):
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::invalidate):
  • platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
  • platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::copyData):
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::formCreate):
  • xml/XPathNodeSet.cpp: (WebCore::XPath::NodeSet::sort): Use reserveInitialCapacity instead of of reserveCapacity in all these call sites, which are working on new vectors that are guaranteed not to be empty.
16:22 Changeset [40500] by jhoneycutt@apple.com
  • 7 edits in trunk/WebCore

2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>

Build fix after r40486.

Rubber-stamped by Ada Chan.

  • dom/Document.h:
  • page/EventHandler.h:
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/RenderLayer.h:
16:07 Changeset [40499] by darin@apple.com
  • 4 edits in trunk/WebCore

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode. (WebCore::ContainerNode::removedFromDocument): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node. (WebCore::EventTargetNode::removedFromDocument): Ditto.
  • dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Updated comment. (WebCore::Node::removedFromDocument): Ditto.
15:57 Changeset [40498] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • WebView/WebHTMLView.mm:
15:48 Changeset [40497] by andersca@apple.com
  • 14 edits
    2 deletes in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More plug-in cleanup.


  • WebCore.NPAPI.exp: Add new symbols.


  • bindings/objc/DOM.mm:
  • bindings/objc/DOMPrivate.h: Remove methods that WebKit doesn't use anymore.

WebKit:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.


  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView dataSource]):
  • Plugins/WebKitPluginContainerView.h: Removed.
  • Plugins/WebKitPluginContainerView.mm: Removed.
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView getVariable:value:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
15:44 Changeset [40496] by andersca@apple.com
  • 2 edits in trunk/WebKit/gtk

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • WebCoreSupport/FrameLoaderClientGtk.h:
15:30 Changeset [40495] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-02-02 Anders Carlsson <andersca@apple.com>

Fix build.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
15:07 Changeset [40494] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-02-02 Jay Campan <jcampan@chromium.org>

Reviewed by Eric Seidel.

Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653

No functional changes, only code cleanup, thus no tests.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h:
14:36 Changeset [40493] by andersca@apple.com
  • 18 edits in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
  • loader/FrameLoader.cpp: (WebCore::toPlugInElement): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/gtk:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
  • WebFrame.h:
14:10 Changeset [40492] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Adding bug URL for a recent check-in.

13:48 Changeset [40491] by staikos@webkit.org
  • 2 edits in trunk/WebCore

Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank

Applies to Torch Mobile platform only right now, as per request.

13:35 Changeset [40490] by bfulgham@webkit.org
  • 5 edits in trunk/WebCore
13:15 Changeset [40489] by christian@webkit.org
  • 2 edits in trunk

2009-02-02 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Holger Freyther.

Don't require Geolocation by default.

  • configure.ac:
12:59 Changeset [40488] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-02-02 Darin Adler <darin@apple.com>

Try to fix Wx build, and maybe Chromium build too.

  • WebCore.scons: Added IdentifierRep.cpp.
  • WebCoreSources.bkl: Ditto.
12:55 Changeset [40487] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-02-02 Darin Adler <darin@apple.com>

Try to fix Wx build.

  • html/HTMLAreaElement.cpp: Added missing include of "Path.h".
12:46 Changeset [40486] by treat@webkit.org
  • 11 edits in trunk

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp: (WebCore::SelectionController::contains):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
  • rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::HitTestRequest): (WebCore::HitTestRequest::readOnly): (WebCore::HitTestRequest::active): (WebCore::HitTestRequest::mouseMove): (WebCore::HitTestRequest::mouseUp): (WebCore::HitTestRequest::ignoreClipping):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState):
12:41 Changeset [40485] by staikos@webkit.org
  • 3 edits in trunk/WebCore

Fix the WML build by including the inlined renderStyle().

12:11 Changeset [40484] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Niko Zimmermann.

Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971

Also fix other XPath tests that are crashing.

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we need to make Attr nodes here. Yuck!
11:53 Changeset [40483] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

When a new Web View was not created, report back to the plug-in host.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest):
  • Plugins/Hosted/WebKitPluginHost.defs:
11:29 Changeset [40482] by staikos@webkit.org
  • 4 edits
    3 adds in trunk

Implement WML specific attributes of WMLInputElement.

11:14 Changeset [40481] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
11:12 Changeset [40480] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-01-29 Scott Violet <sky@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails

Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.

  • transitions/transition-end-event-helpers.js: (recordTransitionEndEvent): (runTransitionTest.startTest._endFunction): (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-nested.html:
11:10 Changeset [40479] by zimmermann@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to update ChangeLog in my last commit.

11:03 Changeset [40478] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct build regression.

10:45 Changeset [40477] by zimmermann@webkit.org
  • 1 edit in trunk/WebCore/wml/WMLAElement.cpp

Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.

10:12 Changeset [40476] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server

Not easily testable.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource handle in a manner that is closer to what CachedResource does. We now make conditional requests for better performance, and set max-age to ensure that stale responses are not used. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource is 304, take it from the newest cache. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for the manifest if the response code was 304 - it won't be needed. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that m_manifestResource is not null with a check. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as an indication that the response was 304. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
  • loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
09:29 Changeset [40475] by darin@apple.com
  • 31 edits in trunk/WebCore

2009-02-01 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead of the old name, getCSSTarget. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than calling through to EventTargetNode::insertedIntoDocument. (WebCore::ContainerNode::removedFromDocument): Ditto. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit. (WebCore::ContainerNode::removedFromTree): Ditto.
  • dom/ContainerNode.h: Moved the constructor definition here and made it inline.
  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and its contents only to avoid the document type node. This allows us to remove the virtual function call to isEventTargetNode from the loop. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
  • dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed getCSSTarget to cssTarget.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the rare data check into an assertion.
  • dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline. Also moved the constructor definition here and made it inline. And added toEventTargetNode, matching the design of the render tree checked casts. Later we can migrate all callers from EventTargetNodeCast to toEventTargetNode.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from clearAttributes, so we could use this loop in cases where we're not clearing the attributes. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of clearAttributes here. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of clearAttributes. We don't need to clear the attributes array just because the element is going away, so don't. (WebCore::NamedAttrMap::virtualLength): Added.
  • dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a non-virtual function. This was a fairly hot function.
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the m_element data member is private.
  • dom/NamedMappedAttrMap.h: Made a few functions private. Made the hasMappedAttributes function non-virtual.
  • dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
  • dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's only non-empty in subclasses of ContainerNode. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
  • dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and setPrefix function definitions into the header and made them inline.
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now an OwnPtr. (WebCore::HTMLAreaElement::accessKey): Use AtomicString. (WebCore::HTMLAreaElement::setAccessKey): Ditto. (WebCore::HTMLAreaElement::alt): Ditto. (WebCore::HTMLAreaElement::setAlt): Ditto. (WebCore::HTMLAreaElement::coords): Ditto. (WebCore::HTMLAreaElement::setCoords): Ditto. (WebCore::HTMLAreaElement::setHref): Ditto. (WebCore::HTMLAreaElement::shape): Ditto. (WebCore::HTMLAreaElement::setShape): Ditto. (WebCore::HTMLAreaElement::setTarget): Ditto.
  • html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize the common case where an area element is parsed but never hit-tested. This could also have been done by changing the Path class's null case to be more efficient, but this seems fine.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead of insertAttribute. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead of its old name getCSSTarget.
  • platform/graphics/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
  • platform/graphics/GlyphWidthMap.h: Made most of this class inline. Changed m_pages to use OwnPtr.
  • platform/text/PlatformString.h: Remove include no longer needed since StringImpl.h includes it.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored from createStrippingNullCharacters.
  • platform/text/StringImpl.h: Moved the definition of createStrippingNullCharacters here and made it inline.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from firstLineStyle.
  • rendering/RenderObject.h: Moved the definition of the firstLineStyle function here and made it inline. Moved the definition of the documentBeingDestroyed function here and made it inline.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of getNamedItem here since it accomplishes the same thing but is more efficient. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of getNamedItemNS.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
07:29 Changeset [40474] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build to call forceLayout on the view instead.

  • Api/qwebpage.cpp: (QWebPage::setFixedLayoutSize): (QWebPage::setUseFixedLayout):
05:16 Changeset [40473] by zecke@webkit.org
  • 18 edits in trunk

Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView

https://bugs.webkit.org/show_bug.cgi?id=23428

FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...

Adjust the WebCore/WebKit consumers of these methods.

02/01/09:

12:30 Changeset [40472] by mitz@apple.com
  • 5 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il

Fixes http/tests/navigation/multiple-back-forward-entries.html

r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.

01/31/09:

22:23 Changeset [40471] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()

On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().

  • rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
  • rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.
21:07 Changeset [40470] by pewtermoose@webkit.org
  • 4 edits in trunk/WebKit/win

2009-01-31 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fixes.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
  • WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
  • WebView.cpp: (WebView::notifyPreferencesChanged):
17:30 Changeset [40469] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.

Reviewed by Dan Bernstein

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):
16:59 Changeset [40468] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-31 John Sullivan <sullivan@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=23665

Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.

Reviewed by Darin Adler

  • WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes
16:55 Changeset [40467] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-01-31 Darin Adler <darin@apple.com>

Fix Mac build.

  • loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.
  • loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.
16:52 Changeset [40466] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix WIndows bustage.

16:14 Changeset [40465] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-31 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Fix code that assumes all command selectors end in colons.
rdar://problem/6545874

  • WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.
15:55 Changeset [40464] by treat@webkit.org
  • 3 edits in trunk/WebCore

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
  • rendering/RenderTable.h:
14:03 Changeset [40463] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt

Update layout test results for 11363.

13:40 Changeset [40462] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Add RenderObjectChildList.cpp to all projects.

13:38 Changeset [40461] by hyatt@apple.com
  • 18 edits
    1 add in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
  • rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
  • rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
  • rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
  • rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):
13:34 Changeset [40460] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt

Update layout test results for 11363.

13:34 Changeset [40459] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt

Update layout test results for 11363.

13:30 Changeset [40458] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs

Update layout test results for 11363.

13:28 Changeset [40457] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

13:28 Changeset [40456] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

13:26 Changeset [40455] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/editing/deleting/5408255.html

Update layout test results for 11363.

13:23 Changeset [40454] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt

Update layout test results for 11363.

13:20 Changeset [40453] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=11363


Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.

Reviewed by Oliver Hunt

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
  • rendering/RenderTableSection.h:
10:07 Changeset [40452] by treat@webkit.org
  • 6 edits in trunk/WebCore

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
08:02 Changeset [40451] by darin@apple.com
  • 2 edits in trunk/WebKit/wx

2009-01-31 Darin Adler <darin@apple.com>

Build fix.

  • WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.
01:36 Changeset [40450] by jmalonzo@webkit.org
  • 4 edits
    1 move
    4 adds
    1 delete in trunk

2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Nikolas Zimmermann.

[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136

  • GNUmakefile.am:
  • acinclude.m4: Removed.
  • autogen.sh:
  • autotools/acinclude.m4: Added.
  • autotools/dolt.m4: Added.
  • autotools/symbols.filter: Renamed from symbols.filter.
  • autotools/webkit.m4: Added.
  • configure.ac:
00:42 Changeset [40449] by abarth@webkit.org
  • 18 edits in trunk

WebCore:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
  • page/SecurityOrigin.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
  • page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):

WebKit/win:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit/mac:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

01/30/09:

22:24 Changeset [40448] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Reviewed by Timothy Hatcher.

  • <rdar://problem/6545912> expose the build number in autoversion.h
  • win/tools/scripts/auto-version.sh: Added a #define BUILD_NUMBER with the full build number.
21:12 Changeset [40447] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>

Build fix.

Move the inline virtual destructor after a non-inline virtual
function so that the symbol for the vtable is not marked as a
weakly exported symbol.

This trick was previously used at revision 36122 in JSObject.h

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::~FrameLoaderClient):
20:43 Changeset [40446] by oliver@apple.com
  • 3 edits in trunk/WebCore

Inline SimpleFontData::widthForGlyph for a minor page load improvement.

Reviewed by Stephanie Lewis

20:40 Changeset [40445] by zecke@webkit.org
  • 3 edits in trunk/WebCore

Build fix for WX and maybe even Windows.

20:12 Changeset [40444] by zecke@webkit.org
  • 9 edits in trunk

Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler

Carry out the move and catch up in two call sites.

19:51 Changeset [40443] by zecke@webkit.org
  • 11 edits in trunk

Move Frame::isFrameSet to Document::isFrameSet

Changed the FrameLoader callsite. I assume that as this
point m_frame.document() might return a null pointer. Change
the condition to either not having a document or not having a
frame set. This should be semantically equivalent to the
old code.

Make Document::body() const to be able to call it from within
Document::isFrameSet. Leave the isHTMLDocument() check as this
is a stronger condition than simply having a HTMLElement in the
DOM.

19:51 Changeset [40442] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Logic fixes and build fixes

https://bugs.webkit.org/show_bug.cgi?id=22022

Catch up with the internal GeoLocation API and fix the logic of
the previous version.

19:51 Changeset [40441] by zecke@webkit.org
  • 6 edits in trunk

[GTK] Implement GeolocationService using the Geoclue library

https://bugs.webkit.org/show_bug.cgi?id=22022

Untested implementation of the GeolocationService using the geoclue
library. Velocity handling is completely missing and the accuracy
handling might be wrong.

19:48 Changeset [40440] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix. Declare preferredSize as static.

  • platform/text/cf/StringImplCF.cpp:

(WebCore::StringWrapperCFAllocator::preferredSize):

19:11 Changeset [40439] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

<rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.

Rubber-stamped by Oliver Hunt.

  • wtf/Platform.h:
18:31 Changeset [40438] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-01-30 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
https://bugs.webkit.org/show_bug.cgi?id=23622

  • platform/text/cf/StringImplCF.cpp: (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator. (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator. (WebCore::StringWrapperCFAllocator::release): Ditto. (WebCore::StringWrapperCFAllocator::copyDescription): Ditto. (WebCore::StringWrapperCFAllocator::allocate): Ditto. (WebCore::StringWrapperCFAllocator::reallocate): Ditto. (WebCore::StringWrapperCFAllocator::deallocate): Ditto. (WebCore::StringWrapperCFAllocator::preferredSize): Ditto. (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but returns 0 if garbage collection is enabled. (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.
  • platform/text/mac/StringImplMac.mm: (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging, rather than using NSString directly. This lets NSString benefit from the above.
18:31 Changeset [40437] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-01-30 Darin Adler <darin@apple.com>

  • page/Frame.cpp: (WebCore::Frame::createView): Fix debug build by removing get() from assert.
18:13 Changeset [40436] by ggaren@apple.com
  • 9 edits in trunk/WebKit

WebKit/gtk:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

WebKit/mac:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebView/WebFramePrivate.h:

WebKit/qt:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

WebKit/win:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • Interfaces/IWebFramePrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
17:57 Changeset [40435] by zecke@webkit.org
  • 14 edits
    1 delete in trunk

Kill FrameLoaderClient.cpp, move the code over to Frame::createView

FrameLoaderClient is supposed to be an interface, move the
to be shared code to Frame which is a controller and is
allowed to create a FrameView.

17:47 Changeset [40434] by simon.fraser@apple.com
  • 2 edits
    4 adds in trunk/WebCore

2009-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23357

New files to support accelerated compositing at the RenderLayer
level.

  • WebCore.xcodeproj/project.pbxproj: New files added to project, and run through the sort script.
  • rendering/RenderLayerBacking.cpp: Added.
  • rendering/RenderLayerBacking.h: Added. New object to store compositing-related data for a single RenderLayer.
  • rendering/RenderLayerCompositor.cpp: Added.
  • rendering/RenderLayerCompositor.h: Added. Per-RenderView controller object for compositing hierarchy maintenance.
17:42 Changeset [40433] by simon.fraser@apple.com
  • 2 edits
    9 adds in trunk/WebCore

2009-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23356

Add new files related to accelerated compositing.

17:28 Changeset [40432] by ggaren@apple.com
  • 16 edits in trunk

WebCore:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

  • WebCore.base.exp:
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h: (WebCore::):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):

WebKit/mac:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

WebKit/qt:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
16:42 Changeset [40431] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6545095>

ASSERTION FAILED: RenderBlock.h:519: !o
o->isRenderBlock()

Test: fast/block/float/crash-replaced-display-block.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into isRenderBlock if-statement.

LayoutTests:

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Test for <rdar://problem/6545095>

ASSERTION FAILED: RenderBlock.h:519: !o
o->isRenderBlock()
  • fast/block/float/crash-replaced-display-block-expected.txt: Added.
  • fast/block/float/crash-replaced-display-block.html: Added.
15:46 Changeset [40430] by cfleizach@apple.com
  • 6 edits in trunk

Bug 23656: AX hierarchy for iFrames is incorrect
https://bugs.webkit.org/show_bug.cgi?id=23656

The AX hierarchy when an iFrame was present was incorrect. A different scroll area was returned when going down compared to when going up.

15:43 Changeset [40429] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-01-30 Adam Treat <adam.treat@torchmobile.com>

Fix Qt build to include new class IdentifierRep introduced in revision 40412.

  • WebCore.pro:
15:32 Changeset [40428] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6544048>


Have NetscapePluginInstanceProxy keep track of all the ProxyInstance objects associated.


When the plug-in instance is destroyed, invalidate all proxy instances.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::addInstance): (WebKit::NetscapePluginInstanceProxy::removeInstance):
  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::ProxyInstance): (WebKit::ProxyInstance::~ProxyInstance): (WebKit::ProxyInstance::invalidate):
15:16 Changeset [40427] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.

  • WebCore.LP64.exp:
  • WebCore.xcodeproj/project.pbxproj:
15:13 Changeset [40426] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[Gtk+] Use AccessibilityObject::stringValue for the AtkObject name

https://bugs.webkit.org/show_bug.cgi?id=21546

The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
states that: "AtkObjects whose text content is simple, unattributed, and very
brief may expose that content via atk_object_get_name instead"

As we are currently not able to always provide a AtkTextInterface
implementation this will make the whole content available to accerciser,
and other tools.

15:11 Changeset [40425] by weinig@apple.com
  • 8 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Commit files I forgot to in the previous commit.

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::layoutCount):
  • page/Frame.cpp: (WebCore::Frame::contentRenderer): (WebCore::Frame::forceLayoutWithPageWidthRange):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::view): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::maximalOutlineSize):
  • rendering/SVGRenderSupport.cpp: (WebCore::clampImageBufferSizeToViewport):
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
15:09 Changeset [40424] by ggaren@apple.com
  • 57 edits
    6 adds in trunk

WebCore:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


More scaffolding for redirect tracking. No behavior change yet.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through JS. (Currently, we just specify "no redirect.")
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::processingUserGestureEvent): (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored user gesture check to make it more clear.

(WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
for checking if there's a user gesture in any frame on the page (a more
relaxed rule than our popup blocking rule, which requires the user
gesture to occur in the frame that's executing JavaScript.)

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through the DOM. (Currently, we just specify "no redirect.")
  • html/HTMLFormElement.idl: Made submit custom so it can participate in redirect checking.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): Clarified some names, and added a "lockHistory" parameter to form submissions, to match other navigations.

(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm): Use the lockHistory parameter.

(WebCore::FrameLoader::userGestureHint): Refactored this function for
clarity, and added a FIXME for a change I was too scared to make myself.
(Really, we should just get rid of this function.)

(WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
to pass a FrameLoadType to form posts, too, so they can participate in
redirect tracking.

(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::loadItem): Use the lockHistory parameter.

LayoutTests:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

More redirect layout test work.


Added tests (expected to fail) for form submission via JavaScript:


  • http/tests/history/redirect-js-form-submit-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-form-submit-0-seconds.html: Added.
  • http/tests/history/redirect-js-form-submit-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-form-submit-2-seconds.html: Added.
  • http/tests/history/redirect-js-form-submit-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-form-submit-before-load.html: Added.


Updated these tests to dump their back/forward lists, to check for
back/forward regressions, and to use # instead of ? to communicate between
URLs, since, to my surprise, form submissions can't use query strings.

  • http/tests/history/redirect-200-refresh-0-seconds-expected.txt:
  • http/tests/history/redirect-200-refresh-0-seconds.pl:
  • http/tests/history/redirect-200-refresh-2-seconds-expected.txt:
  • http/tests/history/redirect-200-refresh-2-seconds.pl:
  • http/tests/history/redirect-301-expected.txt:
  • http/tests/history/redirect-301.pl:
  • http/tests/history/redirect-302-expected.txt:
  • http/tests/history/redirect-302.pl:
  • http/tests/history/redirect-303-expected.txt:
  • http/tests/history/redirect-303.pl:
  • http/tests/history/redirect-307-expected.txt:
  • http/tests/history/redirect-307.pl:
  • http/tests/history/redirect-js-document-location-0-seconds-expected.txt:
  • http/tests/history/redirect-js-document-location-0-seconds.html:
  • http/tests/history/redirect-js-document-location-2-seconds-expected.txt:
  • http/tests/history/redirect-js-document-location-2-seconds.html:
  • http/tests/history/redirect-js-document-location-before-load-expected.txt:
  • http/tests/history/redirect-js-document-location-before-load.html:
  • http/tests/history/redirect-js-location-0-seconds-expected.txt:
  • http/tests/history/redirect-js-location-0-seconds.html:
  • http/tests/history/redirect-js-location-2-seconds-expected.txt:
  • http/tests/history/redirect-js-location-2-seconds.html:
  • http/tests/history/redirect-js-location-assign-0-seconds-expected.txt:
  • http/tests/history/redirect-js-location-assign-0-seconds.html:
  • http/tests/history/redirect-js-location-assign-2-seconds-expected.txt:
  • http/tests/history/redirect-js-location-assign-2-seconds.html:
  • http/tests/history/redirect-js-location-assign-before-load-expected.txt:
  • http/tests/history/redirect-js-location-assign-before-load.html:
  • http/tests/history/redirect-js-location-before-load-expected.txt:
  • http/tests/history/redirect-js-location-before-load.html:
  • http/tests/history/redirect-js-location-href-0-seconds-expected.txt:
  • http/tests/history/redirect-js-location-href-0-seconds.html:
  • http/tests/history/redirect-js-location-href-2-seconds-expected.txt:
  • http/tests/history/redirect-js-location-href-2-seconds.html:
  • http/tests/history/redirect-js-location-href-before-load-expected.txt:
  • http/tests/history/redirect-js-location-href-before-load.html:
  • http/tests/history/redirect-js-location-replace-0-seconds-expected.txt:
  • http/tests/history/redirect-js-location-replace-0-seconds.html:
  • http/tests/history/redirect-js-location-replace-2-seconds-expected.txt:
  • http/tests/history/redirect-js-location-replace-2-seconds.html:
  • http/tests/history/redirect-js-location-replace-before-load-expected.txt:
  • http/tests/history/redirect-js-location-replace-before-load.html:
  • http/tests/history/redirect-meta-refresh-0-seconds-expected.txt:
  • http/tests/history/redirect-meta-refresh-0-seconds.html:
  • http/tests/history/redirect-meta-refresh-2-seconds-expected.txt:
  • http/tests/history/redirect-meta-refresh-2-seconds.html:
  • http/tests/history/resources/redirect-target.html:
15:00 Changeset [40423] by pol@apple.com
  • 1 edit
    13 adds in trunk/LayoutTests

2009-01-30 Pierre-Olivier Latour <pol@apple.com>

Updated the references images for the media layout tests on Tiger since they now differ from Leopard after installing QuickTime 7.6.

  • platform/mac-tiger/media: Added.
  • platform/mac-tiger/media/video-aspect-ratio-expected.checksum: Added.
  • platform/mac-tiger/media/video-aspect-ratio-expected.png: Added.
  • platform/mac-tiger/media/video-controls-rendering-expected.checksum: Added.
  • platform/mac-tiger/media/video-controls-rendering-expected.png: Added.
  • platform/mac-tiger/media/video-display-toggle-expected.checksum: Added.
  • platform/mac-tiger/media/video-display-toggle-expected.png: Added.
  • platform/mac-tiger/media/video-layer-crash-expected.checksum: Added.
  • platform/mac-tiger/media/video-layer-crash-expected.png: Added.
  • platform/mac-tiger/media/video-transformed-expected.checksum: Added.
  • platform/mac-tiger/media/video-transformed-expected.png: Added.
  • platform/mac-tiger/media/video-zoom-expected.checksum: Added.
  • platform/mac-tiger/media/video-zoom-expected.png: Added.
14:57 Changeset [40422] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6490778>.


Change the NPRuntime related functions to use IdentifierRep directly, and make sure to always
validate IdentifierReps before dereferencing them.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCGetStringIdentifier): (WKPCGetIntIdentifier): (identifierFromIdentifierRep): (WKPCInvoke): (WKPCGetProperty): (WKPCSetProperty): (WKPCRemoveProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCIdentifierInfo):
14:42 Changeset [40421] by dglazkov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2009-01-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Correct mis-applied http://trac.webkit.org/changeset/40413 by actually
removing the test file.

  • fast/dom/Window/timeout-released-on-close.html: Removed.
14:19 Changeset [40420] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Build fix for Gtk+

14:16 Changeset [40419] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Finally fix load() to propagate exceptions correctly.

Reviewed by Mark Rowe and Sam Weinig.

14:02 Changeset [40418] by dglazkov@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-01-30 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23618
Templated worker tasks should be more error proof to use.
Fix Chromium build.

  • wtf/TypeTraits.h: (WTF::IsConvertibleToInteger::IsConvertibleToDouble): Avoid "possible loss of data" warning when using Microsoft's C++ compiler by avoiding an implicit conversion of int types to doubles.
13:57 Changeset [40417] by weinig@apple.com
  • 6 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
is not a RenderView.

  • dom/Document.cpp: (WebCore::Document::renderView):
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::recomputeCaretRect): (WebCore::SelectionController::invalidateCaretRect): (WebCore::SelectionController::focusedOrActiveStateChanged):
  • editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::availableHeightUsing):
  • rendering/RenderView.h: (WebCore::toRenderView):
13:48 Changeset [40416] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23360

Really use the container-relative repaint rect methods
for repaint during layout

  • rendering/RenderObject.h: (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):
13:47 Changeset [40415] by andersca@apple.com
  • 6 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PrivateIdentifier and use IdentifierRep instead.

  • bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertNPStringToUTF16):
  • bridge/c/c_utility.h:
  • bridge/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetStringIdentifiers): (_NPN_GetIntIdentifier): (_NPN_IdentifierIsString): (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier):
13:25 Changeset [40414] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Darin Adler.

Make IdentifierRep a real class, add necessary class methods.

  • bridge/IdentifierRep.cpp: (WebCore::identifierSet): Returns a set of all identifiers.


(WebCore::IdentifierRep::isValid):
Return whether an identifier is valid, meaning that it's present in the
set of identifiers.


  • bridge/IdentifierRep.h: (WebCore::IdentifierRep::isString): (WebCore::IdentifierRep::number): (WebCore::IdentifierRep::string): (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::):
12:17 Changeset [40413] by treat@webkit.org
  • 2 edits
    1 copy in trunk/LayoutTests

2009-01-30 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23650
LayoutTests/fast/dom/Window/timeout-released-on-close.html fails intermittently.
Disable this test to keep buildbots green. Need more time to investigate the cause.

  • fast/dom/Window/timeout-released-on-close.html: Removed.
  • fast/dom/Window/timeout-released-on-close.html-disabled: Copied from LayoutTests/fast/dom/Window/timeout-released-on-close.html.
11:57 Changeset [40412] by andersca@apple.com
  • 7 edits
    2 adds in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add IdentifierRep which will be used by both plug-in implementations.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/IdentifierRep.cpp: Added. (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::): (WebCore::intIdentifierMap): (WebCore::identifierRep): (WebCore::stringIdentifierMap):
  • bridge/IdentifierRep.h: Added.
  • bridge/c/c_utility.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp: (WebCore::String::fromUTF8WithLatin1Fallback):
11:55 Changeset [40411] by weinig@apple.com
  • 13 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
is not a RenderInline.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLineBoxToRenderObject): (WebCore::InlineFlowBox::rendererLineBoxes): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
  • rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addFocusRingRects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::splitInlines):
  • rendering/RenderInline.h: (WebCore::toRenderInline):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::boundingBox):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
  • rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::layoutInlineChildren):
10:20 Changeset [40410] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-01-30 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23647
Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::clear):
10:16 Changeset [40409] by hyatt@apple.com
  • 18 edits in trunk/WebCore

2009-01-30 David Hyatt <hyatt@apple.com>

Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.

Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
patch with a containsFloats() check.

Reviewed by Darin Adler

  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • editing/Editor.cpp: (WebCore::Editor::hasBidiSelection):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::firstLineBlock): (WebCore::getLineAtIndex): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::lineCount): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::clearTruncation):
  • rendering/RenderBlock.h: (WebCore::toRenderBlock):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::calcReplacedHeightUsing):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::getTextDecorationColors):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::recalcSections):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::block):
  • rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes):
09:30 Changeset [40408] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

  • Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of relying on some outside force.
  • Clear the previous history item inside FrameLoader instead of relying on multiple FrameLoaderClients to do it.
  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here. (WebCore::CachedFrame::restore): Resume those DOM objects here.
  • history/CachedFrame.h: (WebCore::CachedFrame::domWindow):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the suspending of active DOM objects. (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead of performing a client call by itself. (WebCore::FrameLoader::frameLoadCompleted):

WebKit/mac:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted):

WebKit/qt:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::frameLoadCompleted):

WebKit/win:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

  • WebFrame.cpp: (WebFrame::frameLoadCompleted):
09:13 Changeset [40407] by ap@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin Adler.

Test that documents loaded from application cache cannot load local resources.

  • http/tests/appcache/local-content-expected.txt: Added.
  • http/tests/appcache/local-content.html: Added.
  • http/tests/appcache/resources/local-content.manifest: Added.
09:11 Changeset [40406] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6448823> Application Cache is kept after a private browsing session

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::update): Cache update will not be started if private browsing is enabled. Existing cache version from disk database will be used.
  • loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call it when refusing to update from selectCache().
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addDynamicEntry): (WebCore::ApplicationCache::removeDynamicEntry): Added reminders about private browsing to unimplemented methods.
09:06 Changeset [40405] by darin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-01-30 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23615
Try to make this test reliable on buildbots.

  • fast/dom/Window/resources/long_timeout.html: Allocate more objects to make detection more reliable.
  • fast/dom/Window/timeout-released-on-close.html: Use threshold to account for objects allocated by the running scripts. Add debug output in case of failure to help understand possible failures.
07:17 Changeset [40404] by hausmann@webkit.org
  • 6 edits in trunk

2009-01-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

Bug 23580: GNU mode RVCT compilation support
<https://bugs.webkit.org/show_bug.cgi?id=23580>

07:17 Changeset [40403] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-01-30 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Hide the Offline Web Application Cache path API from the public API
for now.

05:15 Changeset [40402] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=23639
Test that appcache ignores Cache-Control: no-store

  • http/tests/resources/network-simulator.php: Send no-store with all responses.
05:13 Changeset [40401] by ap@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=23640
Test that non-HTML main resources work with application cache correctly

  • http/tests/appcache/non-html-expected.txt: Added.
  • http/tests/appcache/non-html.xhtml: Added.
  • http/tests/appcache/resources/abe.png: Added.
  • http/tests/appcache/resources/non-html.manifest: Added.
  • http/tests/resources/network-simulator.php: Support more file extensions.
03:12 QtWebKitFeatures45 created by hausmann@webkit.org
02:48 QtWebKit edited by hausmann@webkit.org
(diff)
00:38 Changeset [40400] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-01-30 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23618: Templated worker tasks should be more error proof to use
<https://bugs.webkit.org/show_bug.cgi?id=23618>

Add the type traits needed for the generic worker tasks
and compile asserts for them.

Add a summary header to the TypeTraits.h file to explain what is in there.

Add a note to explain IsPod's deficiencies.

  • wtf/TypeTraits.h:
00:34 Changeset [40399] by ap@webkit.org
  • 9 edits
    2 adds in trunk

2009-01-30 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23616: Various "template helpers" should be consolidated from isolated files in JavaScriptCore.
<https://bugs.webkit.org/show_bug.cgi?id=23616>

  • wtf/TypeTraits.h: Moved RemovePointer, IsPod, IsInteger to this file.
  • wtf/OwnPtr.h: Use RemovePointer from TypeTraits.h.
  • wtf/RetainPtr.h: Ditto.
  • wtf/HashTraits.h: Use IsInteger from TypeTraits.h.
  • wtf/VectorTraits.h: Use IsPod from TypeTraits.h.
00:18 Changeset [40398] by ap@webkit.org
  • 3 edits in trunk/WebCore

2009-01-30 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23599: ResourceError needs to be copyable for use in another thread.
<https://bugs.webkit.org/show_bug.cgi?id=23599>

Add ResourceErrorBase::copy method. (Not yet used.)

  • platform/network/ResourceErrorBase.cpp: (WebCore::ResourceErrorBase::copy):
  • platform/network/ResourceErrorBase.h:
Note: See TracTimeline for information about the timeline view.