Timeline


and

02/04/09:

23:27 Changeset [40668] by bfulgham@webkit.org

2009-02-04 Feng Qian <feng@chromium.org>

Reviewed by Darin Adler.

Add Android-specific files to WebCore/editing directory.
https://bugs.webkit.org/show_bug.cgi?id=23294

  • editing/android: Added.
  • editing/android/EditorAndroid.cpp: Added. (WebCore::Editor::newGeneralClipboard):
23:23 Changeset [40667] by bfulgham@webkit.org

WebCore:

2009-02-04 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Remove -webkit-animation-play-state
The AnimationController still has the code to execute the property, but
it is no longer parsed or recorded.
https://bugs.webkit.org/show_bug.cgi?id=22907

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationProperty):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSStyleSelector.h:
  • platform/animation/Animation.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

2009-02-04 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Remove animation-play-state from expected properties.
https://bugs.webkit.org/show_bug.cgi?id=22907

  • animations/computed-style-expected.txt:
  • animations/computed-style.html:
  • fast/css/computed-style-display-none-expected.txt:
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/computed-style-without-renderer.html:
  • svg/css/getComputedStyle-basic-expected.txt:
22:41 Changeset [40666] by bfulgham@webkit.org

WebCore:

2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Darin Adler.

Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105

Test: media/remove-from-document-no-load.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Darin Adler.

Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105.

  • media/remove-from-document-no-load-expected.txt: Added.
  • media/remove-from-document-no-load.html: Added.
22:15 Changeset [40665] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
derived from RenderBox for now.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: Added. (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
  • rendering/RenderBoxModelObject.h: Added.
  • rendering/RenderObject.h:
22:07 Changeset [40664] by simon.fraser@apple.com

2009-02-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Added accelerated animation support to AnimationController and friends. The primary
changes are:

  • accelerated animations get their start time from the compositing engine, so we wait for a callback (notifyAnimationStarted()) in order to get the start time.
  • if software and accelerated animations start in the same cycle, they all need to use the same start time, which is that of the accelerated animations.

Added AnimationControllerPrivate to preserve the encapsulation under
AnimationController.

21:31 Changeset [40663] by barraclough@apple.com

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver 'the nun' Hunt.

Add -e switch to jsc to enable evaluation of scripts passed on the command line.

  • jsc.cpp: (Script::Script): (runWithScripts): (printUsageStatement): (parseArguments): (jscmain):
21:11 Moving to Git edited by ben@meyerhome.net
(diff)
20:18 Changeset [40662] by dglazkov@chromium.org

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Not reviewed, build fix.

Remove duplicate definition of msSans in FontCache::alternateFamilyName.

  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
20:07 Changeset [40661] by dglazkov@chromium.org

2009-02-04 Dmitry Titov <dimich@chromium.org>

Not reviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=22806
Reverting the test that should not yet be landed since it depends on
changes in DRT which were not yet landed.

  • fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Removed.
  • fast/dom/Window/cached-timeout-stopped-on-close.html: Removed.
  • fast/dom/Window/resources/cached-timeout-page-1.html: Removed.
  • fast/dom/Window/resources/cached-timeout-page-2.html: Removed.
19:40 Changeset [40660] by barraclough@apple.com

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Sam 'Big Mac' Weinig.

  • assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
19:34 Changeset [40659] by mrowe@apple.com

Versioning.

19:33 Changeset [40658] by mrowe@apple.com

New tag.

19:32 Changeset [40657] by mrowe@apple.com

Versioning.

18:40 WebCoreRendering edited by amil.reyes@gmail.com
(diff)
18:01 Changeset [40656] by barraclough@apple.com

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
the plaform-specific code generation forming a big meaty patty of methods like 'add32',
'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
and backwards branch methods, all of which can be described in a platform independent
way using methods from the base class. The AbstractMacroAssembler is templated on the
type of the assembler class that will be used for code generation, and the three layers
are held together with the cocktail stick of inheritance.

The above description is a slight simplification since the MacroAssemblerX86 is actually
formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
specific to the given platform).

I'm landing these changes first without splitting the classes across multiple files,
I will follow up with a second patch to split up the file MacroAssembler.h.

  • assembler/MacroAssembler.h: (JSC::AbstractMacroAssembler::): (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr): (JSC::AbstractMacroAssembler::DataLabelPtr::patch): (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32): (JSC::AbstractMacroAssembler::DataLabel32::patch): (JSC::AbstractMacroAssembler::Label::Label): (JSC::AbstractMacroAssembler::Jump::Jump): (JSC::AbstractMacroAssembler::Jump::link): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::Jump::patch): (JSC::AbstractMacroAssembler::JumpList::link): (JSC::AbstractMacroAssembler::JumpList::linkTo): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::addressOf): (JSC::AbstractMacroAssembler::PatchBuffer::setPtr): (JSC::AbstractMacroAssembler::size): (JSC::AbstractMacroAssembler::copyCode): (JSC::AbstractMacroAssembler::label): (JSC::AbstractMacroAssembler::align): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::swap): (JSC::MacroAssemblerX86Common::signExtend32ToPtr): (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::jump): (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::load32): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::addPtr): (JSC::MacroAssemblerX86_64::andPtr): (JSC::MacroAssemblerX86_64::orPtr): (JSC::MacroAssemblerX86_64::rshiftPtr): (JSC::MacroAssemblerX86_64::subPtr): (JSC::MacroAssemblerX86_64::xorPtr): (JSC::MacroAssemblerX86_64::loadPtr): (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::storePtr): (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86::add32): (JSC::MacroAssemblerX86::sub32): (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::storePtrWithPatch): (JSC::MacroAssembler::pop): (JSC::MacroAssembler::peek): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::rshiftPtr): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchSubPtr):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
17:49 Changeset [40655] by andersca@apple.com

2009-02-04 Anders Carlsson <andersca@apple.com>

Build fix fix.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
17:26 Changeset [40654] by eric@webkit.org

Reviewed by George Staikos.

Reverse the meaning of the if check so that Android
(dpad devices) do not scroll on focus and normal platforms do
http://trac.webkit.org/changeset/40647

This was caught by George Staikos, and I wrote the patch.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
17:18 Changeset [40653] by andersca@apple.com

2009-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.


Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.


Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
17:02 Changeset [40652] by ggaren@apple.com

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):
16:53 Changeset [40651] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Eliminate RenderContainer.

Reviewed by Sam and Anders

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::dirtyLineBoxes): (WebCore::RenderBlock::createInlineBox): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState): (WebCore::RenderBlock::localCaretRect):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::virtualChildren): (WebCore::RenderBlock::children):
  • rendering/RenderContainer.cpp: Removed.
  • rendering/RenderContainer.h: Removed.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::nodeAtPoint): (WebCore::RenderFrameSet::layout):
  • rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::virtualChildren): (WebCore::RenderFrameSet::children):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline):
  • rendering/RenderInline.h: (WebCore::RenderInline::virtualChildren): (WebCore::RenderInline::children): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint): (WebCore::RenderSVGRoot::position):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::virtualChildren): (WebCore::RenderSVGRoot::children):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::removeChild):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::RenderTableCol):
  • rendering/RenderTableCol.h: (WebCore::RenderTableCol::virtualChildren): (WebCore::RenderTableCol::children):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableRow): (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::styleWillChange): (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::virtualChildren): (WebCore::RenderTableRow::children):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::removeChild): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::virtualChildren): (WebCore::RenderTableSection::children):
16:49 Changeset [40650] by dglazkov@chromium.org

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Rename layout test result to the correct name.

  • storage/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash.txt.
16:40 Changeset [40649] by andersca@apple.com

2009-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Fix 64-bit build.


  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
16:40 Changeset [40648] by eric@webkit.org

2009-02-04 Mads Adger <mad@chromium.org>

Reviewed by Antti Koivisto.

Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
https://bugs.webkit.org/show_bug.cgi?id=23180

Added a protector for the document potentially holding on the last reference to the loader we are interating with.

  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
16:35 Changeset [40647] by eric@webkit.org

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23163
Don't scroll to show current focus on devices that use
directional pads for navigation.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
16:31 Changeset [40646] by eric@webkit.org

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Darin Adler.

Change RenderBlock::columnGap() access permissions from protected to
public. ANDROID creates an array of focus rectangles for navigation
with a trackball or directional pad, and needs access to the column gap
to implement this logic.

Android has no testing harness @ webkit.org, thus no tests.

  • rendering/RenderBlock.h:
16:27 Changeset [40645] by eric@webkit.org

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917

Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
platform to select all when focusing on a textarea. This matches
the user interface guidelines other applications on the platform.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
16:19 Changeset [40644] by bdakin@apple.com

2009-02-04 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6386112> Some inline-elements are not
becoming proper dashboard-regions

RenderInline needs its own implementation of addDashboardRegions
because otherwise all of the coordinate calculations are
inaccurate.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::addDashboardRegions):
  • rendering/RenderInline.h:
  • rendering/RenderObject.h:
16:12 Changeset [40643] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Move addChild/removeChild from RenderContainer to RenderObject.

Reviewed by Sam Weinig

  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChild):
  • rendering/RenderObject.h: (WebCore::RenderObject::addChildIgnoringContinuation):
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
16:05 Changeset [40642] by beidson@apple.com

2009-02-04 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/3541409> - Further HistoryItem / BF cache cleanup

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::restore):
  • history/CachedFrame.h:
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
  • history/CachedPage.h: (WebCore::CachedPage::mainFrameView):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::isInPageCache):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open):
16:00 Changeset [40641] by pkasting@chromium.org

2009-02-04 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23743
Fix memory corruption with open-source GIF decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache):
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
15:56 Changeset [40640] by simon.fraser@apple.com

2009-02-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23360

When using accelerated compositing, make repaints use the correct
repaint container. Hook up the RenderLayerCompositor in RenderView,
and add to RenderView a method that repaints both the view
contents, and any intersecting composited layers.

Make enclosingCompositingLayer() a method on RenderObject, and update
the compositor to use that. Add a helper method on the compositor to
get the non-self compositing ancestor: ancestorCompositingLayer().

Call repaintRectangleInViewAndCompositedLayers() in places that don't do
container-relative repainting: selection redraw on focus change, caret,
and widget updates.

Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
would get cleared for partial updates, thus preventing subsequent full updates.

Fix a bug in RenderLayer::ensureBacking() that made new backing every time.

15:55 Changeset [40639] by eric@webkit.org

2009-02-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

Regression test for https://bugs.webkit.org/show_bug.cgi?id=22753

  • fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Added.
  • fast/dom/Window/cached-timeout-stopped-on-close.html: Added.
  • fast/dom/Window/resources/cached-timeout-page-1.html: Added.
  • fast/dom/Window/resources/cached-timeout-page-2.html: Added.
15:44 Changeset [40638] by weinig@apple.com

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::notifyFinished):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::addChildren):
  • page/DragController.cpp: (WebCore::getCachedImage): (WebCore::getImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • rendering/RenderImage.h: (WebCore::toRenderImage):
  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::parseMappedAttribute): (WebCore::WMLImageElement::attach):
15:28 Changeset [40637] by ggaren@apple.com

WebKit/mac:

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Part I of <rdar://problem/6552272>.

Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):

WebKit/win:

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Part I of <rdar://problem/6552272>.

Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.

  • WebHistory.cpp: (WebHistory::visitedURL):
15:25 Changeset [40636] by eric@webkit.org

2009-02-04 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel and Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=20531

Make alternateFamilyName customized for Windows and Chromium.

  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
15:22 Changeset [40635] by eric@webkit.org

2009-02-04 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

This comes from Chromium patch (http://codereview.chromium.org/17624).

Add m_disableFontFallback to UniscriberHelper class and set it
to true when filling up glyph pages for non-BMP code points.
When it's set true, UniscriberHelper does not do its own font
fallback. Neither does it do glyph placement. Font fallback
will be taken care of in the simple script font path and glyph
placement is not necessary for simple scripts.

Layout test is missing at the moment due to the lack of freely
distributable font covering a non-BMP code page. A test page
is available at http://i18nl10n.com/webkit/nonbmp2.html

See also https://bugs.webkit.org/show_bug.cgi?id=23602

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillNonBMPGlyphs):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::UniscribeHelper): (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::fillShapes):
  • platform/graphics/chromium/UniscribeHelper.h: (WebCore::UniscribeHelper::setDisableFontFallback):
15:20 Changeset [40634] by weinig@apple.com

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove some unnecessary #includes of RenderStyle.h

  • css/CSSPrimitiveValueMappings.h:
  • css/SVGCSSComputedStyleDeclaration.cpp:
  • dom/Node.h:
  • rendering/PointerEventsHitRules.h:
  • rendering/RenderImageGeneratedContent.h:
  • rendering/RenderMarquee.h:
  • rendering/RenderScrollbar.h:
14:59 Changeset [40633] by dglazkov@chromium.org

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23657
Clean up WebCore/storage IDLs.

  • storage/SQLError.idl: Changed to match spec.
  • storage/SQLResultSet.idl: Changed to match spec.
  • storage/SQLStatementCallback.idl: Removed.
  • storage/SQLStatementErrorCallback.idl: Removed.
  • storage/SQLTransactionCallback.idl: Removed.
  • storage/SQLTransactionErrorCallback.idl: Removed.
14:52 Changeset [40632] by dglazkov@chromium.org

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23655
Clean up storage layout tests a bit.

  • storage/close-during-stress-test.html: Moved brace to new line.
  • storage/empty-statement.html: Moved brace to new line.
  • storage/execute-sql-args.html: Moved brace to new line.
  • storage/quota-tracking.html: Moved brace to new line.
  • storage/success-callback.html: Moved brace to new line, removed erroneous callback argument.
  • storage/transaction-callback-exception-crash.html: Added.
  • storage/transaction-callback-exception-crash.txt: Renamed from LayoutTests/storage/transaction_callback_exception_crash-expected.txt.
  • storage/transaction_callback_exception_crash.html: Removed.
14:34 Changeset [40631] by timothy@apple.com

Change the WebSourceId typedef from int to intptr_t now that <rdar://problem/6263297> is fixed.

<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for sourceId, not int

Reviewed by Oliver Hunt.

  • WebView/WebScriptDebugDelegate.h:
14:34 Changeset [40630] by timothy@apple.com

Switched over from using the WebSafeForwarder for the Script Debug delegate and added high performance CallScriptDebugDelegate functions.

WebKit:

2009-02-04 Timothy Hatcher <timothy@apple.com>

Removed the WebDefaultScriptDebugDelegate now that we have CallScriptDebugDelegate.

<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate

Reviewed by Oliver Hunt.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-02-04 Timothy Hatcher <timothy@apple.com>

Switched over from using the WebSafeForwarder for the Script Debug
delegate and added high performance CallScriptDebugDelegate functions.

<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate

Reviewed by Oliver Hunt.

  • DefaultDelegates/WebDefaultScriptDebugDelegate.h: Removed.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: Removed.
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame): Use CallScriptDebugDelegate. (WebScriptDebugger::sourceParsed): Ditto. (WebScriptDebugger::callEvent): Ditto. (WebScriptDebugger::atStatement): Ditto. (WebScriptDebugger::returnEvent): Ditto. (WebScriptDebugger::exception): Ditto.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Removed scriptDebugDelegateForwarder. (-[WebView _cacheScriptDebugDelegateImplementations]): Added. Gets the method implementations for the script debug delegate. Also caches what didParseSource method to use. (WebViewGetScriptDebugDelegateImplementations): Added. Returns the WebScriptDebugDelegateImplementations structure. (-[WebView setScriptDebugDelegate:]): Call _cacheScriptDebugDelegateImplementations. (CallDelegate): Added more overloaded versions that take different arguments. (CallScriptDebugDelegate): Added overloaded versions that take different arguments.
  • WebView/WebViewInternal.h:
14:29 Changeset [40629] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.


Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
paint.

The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
sure to do only a local setNeedsLayout inside that function.

Reviewed by Beth Dakin

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
  • rendering/RenderObject.h: (WebCore::RenderObject::isSetNeedsLayoutForbidden): (WebCore::RenderObject::setNeedsLayoutIsForbidden): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
14:27 Changeset [40628] by weinig@apple.com

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Rename RenderStyle::Diff to StyleDifference and move it to
RenderStyleConstants.h.

  • rendering/RenderBR.cpp: (WebCore::RenderBR::styleDidChange):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::styleWillChange): (WebCore::RenderButton::styleDidChange):
  • rendering/RenderButton.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::styleDidChange):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::styleDidChange):
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::styleWillChange): (WebCore::RenderListMarker::styleDidChange):
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::styleDidChange):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleWillChange): (WebCore::RenderScrollbarPart::styleDidChange):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleWillChange): (WebCore::RenderTableCell::styleDidChange):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleWillChange):
  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
  • rendering/RenderText.h: (WebCore::RenderText::styleWillChange):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::styleDidChange):
  • rendering/RenderWidget.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setClip):
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
13:12 Changeset [40627] by sfalken@apple.com

Merge r40365.

13:08 WikiStart edited by treat@kde.org
(diff)
13:08 UsingGitWithWebKit edited by treat@kde.org
(diff)
13:07 UsingGitWithWebKit edited by treat@kde.org
(diff)
13:04 Changeset [40626] by sfalken@apple.com

Merge r40511.

13:04 Moving to Git edited by treat@kde.org
My initial brainstorming… (diff)
13:02 Changeset [40625] by weinig@apple.com

2009-02-03 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass): (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSStyleSelector.h:
  • dom/Node.cpp: (WebCore::Node::diff):
  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
  • rendering/MediaControlElements.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::updateBeforeAfterContent): (WebCore::RenderBlock::firstLineBlock): (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderButton.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::isAfterContent): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createTimelineContainer):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::firstLineStyleSlowCase): (WebCore::RenderObject::getCachedPseudoStyle): (WebCore::RenderObject::getUncachedPseudoStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren): (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::pseudoForScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createResultsButtonStyle): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::createScrollbar):
  • rendering/style/RenderStyle.cpp: (WebCore::pseudoBit):
  • rendering/style/RenderStyle.h: (WebCore::):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
12:58 Changeset [40624] by sfalken@apple.com

2009-02-04 Steve Falkenburg <sfalken@apple.com>

Merge part of r40470.

2009-01-31 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fixes.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
12:48 Moving to Git created by treat@kde.org
12:47 WikiStart edited by treat@kde.org
Create a new page to coordinate discussion around possibly moving to Git (diff)
11:56 Changeset [40623] by ddkilzer@apple.com

CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706

<rdar://problem/6509514>

Reviewed by Mark Rowe.

  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Fix it correctly this time. Check for the value returned from WebCore::IconDatabase::iconForPageURL(), not WebCore::Image::data().
11:44 Changeset [40622] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.

Reviewed by Adam Roben

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): (WebCore::RenderBox::styleWillChange):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
  • rendering/RenderObject.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::removeChild):
11:43 Changeset [40621] by dglazkov@chromium.org

Fix WebCore/ChangeLog date discrepancy.

11:41 Changeset [40620] by dglazkov@chromium.org

WebCore:

2009-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.

Test: fast/css/text-overflow-ellipses.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement. (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations for rtl truncation.

LayoutTests:

2009-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.

Rebaseline LayoutTests/editing/spelling/inline_spelling_markers.html to reflect correct behavior.

  • fast/css/text-overflow-ellipses.html: Added.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
  • platform/mac/fast/css/text-overflow-ellipses-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipses-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipses-expected.txt: Added.
11:06 Changeset [40619] by dglazkov@chromium.org

2009-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23700
Upstream local changes to due to unforking of SimpleFontData
(corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
10:25 Changeset [40618] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

<rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook

Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
because, like, they point to a lot of stuff... like ... everything...

Reviewed by Darin Adler

  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes):
10:11 Changeset [40617] by darin@chromium.org

2009-02-04 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23731
Add JSCCustom and V8Custom as extended IDL attributes

This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
  • dom/Node.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPointList.idl:
  • svg/SVGTransformList.idl:
10:03 Changeset [40616] by mitz@apple.com
  • build fix
  • rendering/RenderImageGeneratedContent.h:
10:01 Changeset [40615] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
with assigning to uninitialized HashTable buckets.

https://bugs.webkit.org/show_bug.cgi?id=23669

09:39 Changeset [40614] by hyatt@apple.com

2009-02-04 David Hyatt <hyatt@apple.com>

Fix a crash in generated content when a generated image with an already-cached background image gets
created. It's not completely clear how to reproduce this crash.

Reviewed by Adam Roben

  • rendering/RenderImageGeneratedContent.h: (WebCore::RenderImageGeneratedContent::imagePtr):
07:06 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:56 Changeset [40613] by hausmann@webkit.org

2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed Qt build fix.

Changed ASSERT(image) to ASSERT(!image.isNull()).

06:23 Changeset [40612] by hausmann@webkit.org

2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>

Reviewed by Simon Hausmann.

Fix implementation of PluginViewMac::invalidateRect to update only the
specified rect, not the entire browser window.

06:04 Changeset [40611] by zecke@webkit.org

2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber stamped by Mark Rowe.

FramePrivate was removed in r40024 remove the forward
declaration as well.

  • page/Frame.h:
05:37 Changeset [40610] by zecke@webkit.org

Make isFrameSet virtual and by default return false, reimplement it in HTMLDocument.

https://bugs.webkit.org/show_bug.cgi?id=23426

01:34 Changeset [40609] by hausmann@webkit.org

2009-02-04 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Documented the return value of the evaluateJavaScript() function.

00:55 Changeset [40608] by ap@webkit.org

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23681
Worker tests crash in debug builds if run --singly

The crash happened because worker threads continued running while debug-only static objects
were already being destroyed on main thread.

  • runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get destroyed.
  • wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.

02/03/09:

22:58 WebCoreRendering created by amil.reyes@gmail.com
22:55 WikiStart edited by amil.reyes@gmail.com
(diff)
21:24 Changeset [40607] by oliver@apple.com

<rdar://problem/6554092> Slow script dialog starts coming up over and over again

Reviewed by John Sullivan.

Work around <rdar://problem/6554067> by consuming any exceptions that are
thrown by _web_localizedDescription

21:06 Changeset [40606] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.

Reviewed by Mark Rowe

  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
20:59 Changeset [40605] by bfulgham@webkit.org

2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.

20:26 Changeset [40604] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.

Reviewed by Mark Rowe

  • rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::bidiNext):
20:24 Changeset [40603] by mrowe@apple.com

Merge r40394.

20:24 Changeset [40602] by mrowe@apple.com

Merge r40392.

20:23 Changeset [40601] by mrowe@apple.com

Merge r40529.

20:23 Changeset [40600] by mrowe@apple.com

Merge r40528.

20:23 Changeset [40599] by mrowe@apple.com

Merge r40516.

20:23 Changeset [40598] by mrowe@apple.com

Merge r40514.

20:23 Changeset [40597] by mrowe@apple.com

Merge r40511.

20:23 Changeset [40596] by mrowe@apple.com

Merge r40508.

20:23 Changeset [40595] by mrowe@apple.com

Merge r40503.

20:23 Changeset [40594] by mrowe@apple.com

Merge r40382.

20:23 Changeset [40593] by mrowe@apple.com

Merge r40380.

20:23 Changeset [40592] by mrowe@apple.com

Merge r40436.

20:23 Changeset [40591] by mrowe@apple.com

Merge r40432.

20:23 Changeset [40590] by mrowe@apple.com

Merge r40424.

20:22 Changeset [40589] by mrowe@apple.com

Merge r40376.

20:22 Changeset [40588] by mrowe@apple.com

Merge r40373.

20:22 Changeset [40587] by mrowe@apple.com

Merge r40353.

20:22 Changeset [40586] by mrowe@apple.com

Merge r40558.

20:22 Changeset [40585] by mrowe@apple.com

Merge r40541.

20:22 Changeset [40584] by mrowe@apple.com

Merge r40522.

20:22 Changeset [40583] by mrowe@apple.com

Merge r40472.

20:22 Changeset [40582] by mrowe@apple.com

Merge r40448.

20:22 Changeset [40581] by mrowe@apple.com

Merge r40397.

20:22 Changeset [40580] by mrowe@apple.com

Merge r40396.

20:22 Changeset [40579] by mrowe@apple.com

Merge r40368.

20:22 Changeset [40578] by mrowe@apple.com

Merge r40366.

20:21 Changeset [40577] by mrowe@apple.com

Merge r40358.

20:21 Changeset [40576] by mrowe@apple.com

Merge r40356.

20:21 Changeset [40575] by mrowe@apple.com

Merge r40355.

20:21 Changeset [40574] by mrowe@apple.com

Merge r40354.

20:21 Changeset [40573] by mrowe@apple.com

Merge r40345.

20:21 Changeset [40572] by mrowe@apple.com

Merge r40343.

20:21 Changeset [40571] by mrowe@apple.com

Merge r40339.

20:21 Changeset [40570] by mrowe@apple.com

Merge r40335.

20:21 Changeset [40569] by mrowe@apple.com

Merge r40332.

20:21 Changeset [40568] by mrowe@apple.com

Merge r40313.

20:21 Changeset [40567] by mrowe@apple.com

Merge r40305.

20:20 Changeset [40566] by mrowe@apple.com

Merge r40304.

18:45 Changeset [40565] by simon.fraser@apple.com

Fix typo in Changelog

18:41 Changeset [40564] by simon.fraser@apple.com

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23628

Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.

Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.

RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.

18:06 Changeset [40563] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.

Reviewed by Darin Adler & Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
18:02 Changeset [40562] by barraclough@apple.com

2009-02-03 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=23715

Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:

jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32

Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).

This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branchPtrWithPatch): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchTest32): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchAdd32): (JSC::MacroAssembler::branchMul32): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchSub32): (JSC::MacroAssembler::set32): (JSC::MacroAssembler::setTest32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::jccRel32): (JSC::X86Assembler::setccOpcode): (JSC::X86Assembler::cmpq_mr): (JSC::X86Assembler::setcc_r): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::jne): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::jcc): (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference):
17:52 Changeset [40561] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.

Reviewed by Maciej

  • wtf/Vector.h: (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::allocateBuffer):
17:18 Changeset [40560] by justin.garcia@apple.com

WebCore:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)


Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::clear):
  • editing/Editor.h: (WebCore::Editor::setShouldStyleWithCSS): (WebCore::Editor::shouldStyleWithCSS):
  • editing/EditorCommand.cpp: (WebCore::executeStyleWithCSS): (WebCore::stateStyleWithCSS): (WebCore::CommandEntry::):

LayoutTests:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)

  • editing/execCommand/5685604-1-expected.txt: Added.
  • editing/execCommand/5685604-1.html: Added.
17:05 Changeset [40559] by krit@webkit.org

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig.

This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
16:55 Changeset [40558] by andersca@apple.com

2009-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

  • Fix for <rdar://problem/6549743>

On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].


  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
16:46 Changeset [40557] by kevino@webkit.org

ChangeLog date fix.

16:39 Changeset [40556] by kevino@webkit.org

Reviewed by Darin Adler.

Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).

https://bugs.webkit.org/show_bug.cgi?id=23701

16:31 Changeset [40555] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Back this change out since it is causing layout tests to crash. There is something subtle going on
here.

Reviewed by Darin Adler

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:57 Changeset [40554] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.

Reviewed by Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:56 Changeset [40553] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.

Reviewed by Darin Adler

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/KURL.cpp: (WebCore::KURL::invalidate): (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::isHTTPOrHTTPS):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::setAllowHTTPCookies):
15:53 Changeset [40552] by bfulgham@webkit.org

Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.

15:25 Changeset [40551] by zecke@webkit.org

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Add manual test for floating divs with scrollbars.

  • manual-tests/gtk/floatingdiv.html: Added.
15:25 Changeset [40550] by zecke@webkit.org

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.

Also do not disconnect the signals when destroying the widget,
it's superfluous.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk):
15:25 Changeset [40549] by zecke@webkit.org

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Declare scrollBar as GtkWidget* to avoid needless
casting.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk):
15:25 Changeset [40548] by zecke@webkit.org

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Properly calculate the scrollbar location for their
usage in RenderLayout.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
14:14 Changeset [40547] by hyatt@apple.com

2009-02-03 David Hyatt <hyatt@apple.com>

Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
of these methods up to RenderObject.


Reviewed by Beth Dakin

  • bindings/objc/DOM.mm: (-[DOMNode lineBoxRects]):
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuadsForRange):
  • rendering/RenderText.h:
13:26 Changeset [40546] by krit@webkit.org

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig and Oliver Hunt.

Added getImageData() support for QtWebKit.

[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
13:00 Changeset [40545] by zecke@webkit.org

2009-02-03 Eric Roman <eroman@chromium.org>

Reviewed by Holger Freyther.

Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
12:43 Changeset [40544] by simon.fraser@apple.com

2009-02-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23358

Hook accelerated compositing into RenderLayer.

12:14 Changeset [40543] by simon.fraser@apple.com

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23365

Hook up accelerated compositing layers the native
view system on Mac.

11:51 Changeset [40542] by krit@webkit.org

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Hans Peter Freyther.

Fixed getImageData and putImageData and respect pre-
multiplied colors.

Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
https://bugs.webkit.org/show_bug.cgi?id=21575

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
11:49 Changeset [40541] by mitz@apple.com

WebCore:

Reviewed by Brady Eidson.

  • fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)

Test: fast/history/window-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the missing lockBackForwardList parameter to FrameLoader::changeLocation().

LayoutTests:

Reviewed by Brady Eidson.

  • test for <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
  • fast/history/window-open-expected.txt: Added.
  • fast/history/window-open.html: Added.
11:40 Changeset [40540] by zecke@webkit.org

2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22988
[GTK] Need a public method to add a WebKitWebHistoryItem to
WebKitWebBackForwardList.

Wrap WebCore::BackForwardList::addItem.

  • tests/main.c: (test_webkit_web_back_forward_list_add_item): (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.h:
09:46 Changeset [40539] by treat@webkit.org

2009-02-03 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build after r40536.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
09:41 Changeset [40538] by mitz@apple.com
  • fix -Wmissing-prototypes builds
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidSendData): Marked this function static. (WebCore::workerContextDidReceiveResponse): Ditto. (WebCore::workerContextDidReceiveData): Ditto. (WebCore::workerContextDidFinishLoading): Ditto. (WebCore::workerContextDidFail): Ditto. (WebCore::workerContextDidGetCancelled): Ditto. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
09:29 Changeset [40537] by ddkilzer@apple.com

CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706

<rdar://problem/6509514>

Reviewed by Adam Roben.

  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Null check the value returned from WebCore::IconDatabase::iconForPageURL().
08:10 Changeset [40536] by hausmann@webkit.org

JavaScriptCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added accessor for JSByteArray storage.

WebCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix conversion of QByteArray to JavaScript and back. Instead of
converting it to a String (data loss!) we now map it to JSByteArray.

WebKit/qt:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added a unit test to verify the succesful conversion from QByteArray to
JSByteArray and back to QByteArray.

07:44 Changeset [40535] by ap@webkit.org

Build fix.

  • GNUmakefile.am: Removed WorkerTask.{h,cpp}.
02:32 Changeset [40534] by ap@webkit.org

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22718
Implement WindowTimers interface in Workers.

This patch moves timeoutID from Document to ScriptExecutionContext
and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
Also added a test for those methods.

Test: fast/workers/worker-timeout.html

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::setTimeoutOrInterval): Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.

(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::clearTimeout):
(WebCore::JSWorkerContext::setInterval):
(WebCore::JSWorkerContext::clearInterval):
Added methods exposed to JS.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addTimeout): (WebCore::ScriptExecutionContext::removeTimeout): (WebCore::ScriptExecutionContext::findTimeout):
  • dom/ScriptExecutionContext.h: The timerID map moves from Document to ScriptExecutionContext, to be available to Document and to WorkerContext.
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
  • dom/WorkerContext.h:
  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::removeById): Code change here reflects move of timeoutID map to the ScriptExecutionContext. Some checks and casts are no longer needed.
01:18 Changeset [40533] by ap@webkit.org

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer on WorkerRunLoop

  • JavaScriptCore.exp: Forgot to expose ThreadCondition::timedWait() in one of previous patches.
01:11 Changeset [40532] by ap@webkit.org

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer for Workers.

  • dom/WorkerRunLoop.cpp: Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads. (WebCore::WorkerSharedTimer::WorkerSharedTimer): (WebCore::WorkerSharedTimer::setFiredFunction): (WebCore::WorkerSharedTimer::setFireTime): (WebCore::WorkerSharedTimer::stop): (WebCore::WorkerSharedTimer::isActive): (WebCore::WorkerSharedTimer::fireTime): (WebCore::WorkerSharedTimer::fire): (WebCore::WorkerRunLoop::WorkerRunLoop): Initializes a WorkerSharedTimer instance. (WebCore::WorkerRunLoop::~WorkerRunLoop): The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer. (WebCore::WorkerRunLoop::run): Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
  • dom/WorkerRunLoop.h: Add member of type OwnPtr<WorkerSharedTimer>
00:57 Changeset [40531] by sfalken@apple.com

2009-02-03 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:24 Changeset [40530] by ap@webkit.org

Windows build fix.

  • dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where appropriate.
00:05 Changeset [40529] by ggaren@apple.com

2009-02-03 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):

02/02/09:

23:57 Changeset [40528] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):
23:41 Changeset [40527] by ap@webkit.org

Reviewed by Alexey Proskuryakov.

Part 2 of
Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>

Enable the async portion of ThreadableLoader for workers.

No observable change in behavior, so no test.

23:38 Changeset [40526] by ap@webkit.org

2009-02-02 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
<https://bugs.webkit.org/show_bug.cgi?id=23636>

No observable change in behavior, so no test.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Worker.cpp:
  • dom/Worker.h:
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postTask): (WebCore::WorkerContext::postTaskToWorkerObject):
  • dom/WorkerContext.h:
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Expose postTaskToWorkerContext for use by the worker object thread.

(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
with postMessageToWorkerObject.

  • dom/WorkerMessagingProxy.h:
  • dom/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::postTask):
  • dom/WorkerRunLoop.h:
  • dom/WorkerTask.cpp: Removed.
  • dom/WorkerTask.h: Removed. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.

The resulted in the class going away along with an adapter that made
a ScriptExecutionContext::Task look like a WorkerTask.

  • dom/WorkerThread.cpp:
  • dom/WorkerThread.h:
23:36 Changeset [40525] by ap@webkit.org

2009-02-02 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23618: Templated worker tasks should be more error proof to use.
<https://bugs.webkit.org/show_bug.cgi?id=23618>

Add the generic worker tasks templates needed for the WorkerThreadableLoader.

No observable change in behavior, so no test.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • dom/CrossThreadCopier.cpp: Added.
  • dom/CrossThreadCopier.h: Added. (WebCore::CrossThreadCopierPassThrough::copy):
  • dom/GenericWorkerTask.h: Stop doing the WorkerMessagingProxy::askedToTerminate call automatically in performTask because was not obvious that it would be done and not always needed.

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask1::GenericWorkerTask1):
(WebCore::GenericWorkerTask1::performTask):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask2::GenericWorkerTask2):
(WebCore::GenericWorkerTask2::performTask):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask3::GenericWorkerTask3):
(WebCore::GenericWorkerTask3::performTask):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask4::GenericWorkerTask4):
(WebCore::GenericWorkerTask4::performTask):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask5::GenericWorkerTask5):
(WebCore::GenericWorkerTask5::performTask):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask6::GenericWorkerTask6):
(WebCore::GenericWorkerTask6::performTask):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask7::GenericWorkerTask7):
(WebCore::GenericWorkerTask7::performTask):
(WebCore::createCallbackTask):

  • dom/WorkerContext.cpp: (WebCore::addMessageTask): (WebCore::WorkerContext::addMessage):
  • dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):
22:45 Changeset [40524] by weinig@apple.com

2009-02-02 Sam Weinig <sam@webkit.org>

Reviewed by David "The Barnabas Jones" Hyatt.

Move removeChildNode, appendChildNode and insertChildNode from
RenderContainer into RenderObjectChildList. Make moveChildNode
static in RenderBlock, as that was the only user.

  • rendering/RenderBlock.cpp: (WebCore::moveChild): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::handleRunInChild):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild):
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::childBecameNonInline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
  • rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper):
  • rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore::RenderSVGContainer::removeChild):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::removeChild):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChild):
  • rendering/RenderTableSection.h:
22:39 Changeset [40523] by ap@webkit.org

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=23697
Leaks seen on Worker tests

  • dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed() is called.
22:08 Changeset [40522] by oliver@apple.com

<https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
<rdar://problem/6543487>

Reviewed by Gavin Barraclough.

In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
itself recursively, it will incorrectly emit (and thus consume) the next single character
match in the current character class. As WREC uses a binary search this out of sequence
codegen could result in a character match being missed and so cause the regex to produce
incorrect results.

21:26 Changeset [40521] by hyatt@apple.com

2009-02-02 David Hyatt <hyatt@apple.com>

Move positionForCoordinates up from RenderContainer into RenderBox.

Reviewed by Sam Weinig

  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForCoordinates):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
20:47 Changeset [40520] by bfulgham@webkit.org

Incorrect handling of findstr results in *.vcproj.
Fixes https://bugs.webkit.org/show_bug.cgi?id=15813

20:46 Changeset [40519] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
  • WebKitSupport/FrameLoaderClientWx.h:
20:33 Changeset [40518] by hyatt@apple.com

2009-02-02 David Hyatt <hyatt@apple.com>

Refactor the handling of before/after content and generated content. Move most of the functions from
RenderContainer into RenderObjectChildList.

Reviewed by Sam Weinig

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::findBeforeAfterParent): (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderObjectChildList.h:
20:23 Changeset [40517] by dglazkov@chromium.org

2009-02-02 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23661
Fix Chromium build.

  • history/HistoryItem.h: need to include <wtf/OwnPtr.h>
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.
19:08 Changeset [40516] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • plugins/PluginView.cpp: (WebCore::PluginView::performRequest):
19:06 Changeset [40515] by ggaren@apple.com

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame): (QWebFrame::load): (QWebFrame::setHtml): (QWebFrame::setContent):

WebKit/wx:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebFrame.cpp: (wxWebFrame::LoadURL):
19:03 Changeset [40514] by ggaren@apple.com

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCore.base.exp:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
18:56 Changeset [40513] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • webkit/webkitwebview.cpp:
18:54 Changeset [40512] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • webkit/webkitwebframe.cpp:
18:52 Changeset [40511] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
18:52 Changeset [40510] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
18:49 Changeset [40509] by ggaren@apple.com

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
18:31 Changeset [40508] by ggaren@apple.com

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • WebCore.base.exp: Renamed some exports.


  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (windowProtoFuncOpen):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::assign): Treat any navigation that is not initiated by the user as a redirect from the perspective of global history.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect chain.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect): (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect): (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly, added yet another way to track redirect state during loading, since none of the others did what I wanted, and I didn't want to cause behavior changes in existing code.
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Stubbed out a client function to keep things building.


  • loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect => FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all the other meanings of "redirect" in the loading code.

(WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
redirect as a redirect from the perspective of global history.

(WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
parameter.

(WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.

(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load): Updated for rename and extra parameter.

(WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
in the DocumentLoader, so it's accessible to WebKit's global history code.

(WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
only has meaning to global history, and m_quickRedirectComing pertains
to other kinds of history.

(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.


(WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
navigations even if they don't create new history items, so we can track
the redirect in the existing history item.

  • loader/FrameLoader.h: See above.


  • loader/FrameLoaderClient.h: New client interface used by FrameLoader::updateHistory* to record a redirect even if it doesn't create a new history item of its own.
  • loader/FrameLoaderTypes.h: See above. (WebCore::):
  • page/DragController.cpp: (WebCore::DragController::performDrag):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Updated for extra parameter.

WebKit/gtk:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Track redirects in global history.

Keep GTK building.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate lastVisitedEntry]): (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history entry in case we're asked to add redirect information to it later.

(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
(-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
information in global history.

  • History/WebHistoryInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.h: See above and below.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect information in global history.
  • WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
  • WebView/WebFramePrivate.h: Updated for rename and extra parameter.

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

Keep Qt building.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientQt::createFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

  • Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Store redirect information in global history.

(WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.

  • WebCoreSupport/WebFrameLoaderClient.h: See above.
  • WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::loadData): Updated for extra parameter.
  • WebHistory.cpp: (WebHistory::visitedURL): (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect information in global history.
  • WebHistory.h: See above.
17:35 Changeset [40507] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Work around a limitation in MIG where two functions can't have the same name even if they're
not in the same subsystem.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
17:21 Changeset [40506] by hyatt@apple.com

2009-02-02 David Hyatt <hyatt@apple.com>

Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
Remove RenderSVGContainer's implementation, since it was never called.

Reviewed by Beth Dakin

  • rendering/RenderBox.cpp: (WebCore::RenderBox::minPrefWidth):
  • rendering/RenderBox.h: (WebCore::RenderBox::calcPrefWidths):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
  • rendering/RenderSVGContainer.h:
16:59 Changeset [40505] by andersca@apple.com

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.


  • WebCore.LP64.exp:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement): (WebCore::ScriptController::jsObjectForPluginElement):
  • bindings/js/ScriptController.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement WKPCGetPluginElementObject.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetPluginElementNPObject):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView WebCore::]):
16:45 Changeset [40504] by darin@chromium.org

2009-02-02 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel (and Ojan Vafai).

https://bugs.webkit.org/show_bug.cgi?id=23696
Select element doesn't show new value when focus is switched in
onchange event.

Fix PopupMenuChromium to hide itself before calling valueChanged. This
better matches the behavior of the other ports.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):
16:28 Changeset [40503] by beidson@apple.com

2009-02-02 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.

  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
  • WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
  • WebHistoryItem.h:
16:27 Changeset [40502] by hyatt@apple.com

2009-02-02 David Hyatt <hyatt@apple.com>

Make sure scrollWidth/Height just return 0 for inline flows.

Reviewed by Beth Dakin

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
16:27 Changeset [40501] by darin@apple.com

JavaScriptCore:

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

  • API/JSObjectRef.cpp: (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
  • parser/Lexer.cpp: (JSC::Lexer::Lexer): Ditto. (JSC::Lexer::clear): Ditto.
  • wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of reserveCapacity for use when the vector is brand new (still size 0 with no capacity other than the inline capacity).

WebCore:

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::sortMatchedRules):
  • dom/Document.cpp: (WebCore::Document::formElementsState):
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::reserveInitialCapacity):
  • editing/TextIterator.cpp: (WebCore::CharacterIterator::string): (WebCore::SearchBuffer::SearchBuffer): (WebCore::plainTextToMallocAllocatedBuffer):
  • editing/markup.cpp: (WebCore::joinMarkups):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
  • page/mac/AccessibilityObjectWrapper.mm: (convertToVector):
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::invalidate):
  • platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
  • platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::copyData):
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::formCreate):
  • xml/XPathNodeSet.cpp: (WebCore::XPath::NodeSet::sort): Use reserveInitialCapacity instead of of reserveCapacity in all these call sites, which are working on new vectors that are guaranteed not to be empty.
16:22 Changeset [40500] by jhoneycutt@apple.com

2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>

Build fix after r40486.

Rubber-stamped by Ada Chan.

  • dom/Document.h:
  • page/EventHandler.h:
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/RenderLayer.h:
16:07 Changeset [40499] by darin@apple.com

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode. (WebCore::ContainerNode::removedFromDocument): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node. (WebCore::EventTargetNode::removedFromDocument): Ditto.
  • dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Updated comment. (WebCore::Node::removedFromDocument): Ditto.
15:57 Changeset [40498] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • WebView/WebHTMLView.mm:
15:48 Changeset [40497] by andersca@apple.com

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More plug-in cleanup.


  • WebCore.NPAPI.exp: Add new symbols.


  • bindings/objc/DOM.mm:
  • bindings/objc/DOMPrivate.h: Remove methods that WebKit doesn't use anymore.

WebKit:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.


Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.


  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView dataSource]):
  • Plugins/WebKitPluginContainerView.h: Removed.
  • Plugins/WebKitPluginContainerView.mm: Removed.
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView getVariable:value:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
15:44 Changeset [40496] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • WebCoreSupport/FrameLoaderClientGtk.h:
15:30 Changeset [40495] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Fix build.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
15:07 Changeset [40494] by eric@webkit.org

2009-02-02 Jay Campan <jcampan@chromium.org>

Reviewed by Eric Seidel.

Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653

No functional changes, only code cleanup, thus no tests.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow): (WebCore::PopupMenu::show):
  • platform/chromium/PopupMenuChromium.h:
14:36 Changeset [40493] by andersca@apple.com

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
  • loader/FrameLoader.cpp: (WebCore::toPlugInElement): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/gtk:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

  • WebFrame.cpp: (WebFrame::createJavaAppletWidget):
  • WebFrame.h:
14:10 Changeset [40492] by ap@webkit.org

Adding bug URL for a recent check-in.

13:48 Changeset [40491] by staikos@webkit.org

Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank

Applies to Torch Mobile platform only right now, as per request.

13:35 Changeset [40490] by bfulgham@webkit.org
13:15 Changeset [40489] by christian@webkit.org

2009-02-02 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Holger Freyther.

Don't require Geolocation by default.

  • configure.ac:
12:59 Changeset [40488] by darin@apple.com

2009-02-02 Darin Adler <darin@apple.com>

Try to fix Wx build, and maybe Chromium build too.

  • WebCore.scons: Added IdentifierRep.cpp.
  • WebCoreSources.bkl: Ditto.
12:55 Changeset [40487] by darin@apple.com

2009-02-02 Darin Adler <darin@apple.com>

Try to fix Wx build.

  • html/HTMLAreaElement.cpp: Added missing include of "Path.h".
12:46 Changeset [40486] by treat@webkit.org

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.

  • dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
  • editing/SelectionController.cpp: (WebCore::SelectionController::contains):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
  • page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
  • page/EventHandler.h:
  • rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::HitTestRequest): (WebCore::HitTestRequest::readOnly): (WebCore::HitTestRequest::active): (WebCore::HitTestRequest::mouseMove): (WebCore::HitTestRequest::mouseUp): (WebCore::HitTestRequest::ignoreClipping):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState):
12:41 Changeset [40485] by staikos@webkit.org

Fix the WML build by including the inlined renderStyle().

12:11 Changeset [40484] by darin@apple.com

2009-02-02 Darin Adler <darin@apple.com>

Reviewed by Niko Zimmermann.

Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971

Also fix other XPath tests that are crashing.

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we need to make Attr nodes here. Yuck!
11:53 Changeset [40483] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

When a new Web View was not created, report back to the plug-in host.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest):
  • Plugins/Hosted/WebKitPluginHost.defs:
11:29 Changeset [40482] by staikos@webkit.org

Implement WML specific attributes of WMLInputElement.

11:14 Changeset [40481] by andersca@apple.com

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):
11:12 Changeset [40480] by darin@chromium.org

2009-01-29 Scott Violet <sky@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails

Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.

  • transitions/transition-end-event-helpers.js: (recordTransitionEndEvent): (runTransitionTest.startTest._endFunction): (runTransitionTest.startTest): (runTransitionTest):
  • transitions/transition-end-event-nested.html:
11:10 Changeset [40479] by zimmermann@webkit.org

Forgot to update ChangeLog in my last commit.

11:03 Changeset [40478] by bfulgham@webkit.org

Correct build regression.

10:45 Changeset [40477] by zimmermann@webkit.org

Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.

10:12 Changeset [40476] by ap@webkit.org

Reviewed by Darin Adler.

<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server

Not easily testable.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource handle in a manner that is closer to what CachedResource does. We now make conditional requests for better performance, and set max-age to ensure that stale responses are not used. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource is 304, take it from the newest cache. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for the manifest if the response code was 304 - it won't be needed. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that m_manifestResource is not null with a check. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as an indication that the response was 304. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().
  • loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().
09:29 Changeset [40475] by darin@apple.com

2009-02-01 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead of the old name, getCSSTarget. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than calling through to EventTargetNode::insertedIntoDocument. (WebCore::ContainerNode::removedFromDocument): Ditto. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit. (WebCore::ContainerNode::removedFromTree): Ditto.
  • dom/ContainerNode.h: Moved the constructor definition here and made it inline.
  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and its contents only to avoid the document type node. This allows us to remove the virtual function call to isEventTargetNode from the loop. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.
  • dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed getCSSTarget to cssTarget.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the rare data check into an assertion.
  • dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline. Also moved the constructor definition here and made it inline. And added toEventTargetNode, matching the design of the render tree checked casts. Later we can migrate all callers from EventTargetNodeCast to toEventTargetNode.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from clearAttributes, so we could use this loop in cases where we're not clearing the attributes. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of clearAttributes here. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of clearAttributes. We don't need to clear the attributes array just because the element is going away, so don't. (WebCore::NamedAttrMap::virtualLength): Added.
  • dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a non-virtual function. This was a fairly hot function.
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the m_element data member is private.
  • dom/NamedMappedAttrMap.h: Made a few functions private. Made the hasMappedAttributes function non-virtual.
  • dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.
  • dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's only non-empty in subclasses of ContainerNode. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.
  • dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and setPrefix function definitions into the header and made them inline.
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now an OwnPtr. (WebCore::HTMLAreaElement::accessKey): Use AtomicString. (WebCore::HTMLAreaElement::setAccessKey): Ditto. (WebCore::HTMLAreaElement::alt): Ditto. (WebCore::HTMLAreaElement::setAlt): Ditto. (WebCore::HTMLAreaElement::coords): Ditto. (WebCore::HTMLAreaElement::setCoords): Ditto. (WebCore::HTMLAreaElement::setHref): Ditto. (WebCore::HTMLAreaElement::shape): Ditto. (WebCore::HTMLAreaElement::setShape): Ditto. (WebCore::HTMLAreaElement::setTarget): Ditto.
  • html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize the common case where an area element is parsed but never hit-tested. This could also have been done by changing the Path class's null case to be more efficient, but this seems fine.
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead of insertAttribute. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead of its old name getCSSTarget.
  • platform/graphics/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.
  • platform/graphics/GlyphWidthMap.h: Made most of this class inline. Changed m_pages to use OwnPtr.
  • platform/text/PlatformString.h: Remove include no longer needed since StringImpl.h includes it.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored from createStrippingNullCharacters.
  • platform/text/StringImpl.h: Moved the definition of createStrippingNullCharacters here and made it inline.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from firstLineStyle.
  • rendering/RenderObject.h: Moved the definition of the firstLineStyle function here and made it inline. Moved the definition of the documentBeingDestroyed function here and made it inline.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of getNamedItem here since it accomplishes the same thing but is more efficient. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of getNamedItemNS.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.
07:29 Changeset [40474] by treat@webkit.org

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build to call forceLayout on the view instead.

  • Api/qwebpage.cpp: (QWebPage::setFixedLayoutSize): (QWebPage::setUseFixedLayout):
05:16 Changeset [40473] by zecke@webkit.org

Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView

https://bugs.webkit.org/show_bug.cgi?id=23428

FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...

Adjust the WebCore/WebKit consumers of these methods.

02/01/09:

12:30 Changeset [40472] by mitz@apple.com

Reviewed by John Sullivan.

  • fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il

Fixes http/tests/navigation/multiple-back-forward-entries.html

r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.

01/31/09:

22:23 Changeset [40471] by mitz@apple.com

Reviewed by Oliver Hunt.

  • fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()

On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().

  • rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
  • rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.
21:07 Changeset [40470] by pewtermoose@webkit.org

2009-01-31 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fixes.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
  • WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
  • WebView.cpp: (WebView::notifyPreferencesChanged):
17:30 Changeset [40469] by hyatt@apple.com

2009-01-31 David Hyatt <hyatt@apple.com>

Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.

Reviewed by Dan Bernstein

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):
16:59 Changeset [40468] by sullivan@apple.com

2009-01-31 John Sullivan <sullivan@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=23665

Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.

Reviewed by Darin Adler

  • WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes
16:55 Changeset [40467] by darin@apple.com

2009-01-31 Darin Adler <darin@apple.com>

Fix Mac build.

  • loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.
  • loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.
16:52 Changeset [40466] by hyatt@apple.com

Fix WIndows bustage.

16:14 Changeset [40465] by darin@apple.com

2009-01-31 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Fix code that assumes all command selectors end in colons.
rdar://problem/6545874

  • WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.
15:55 Changeset [40464] by treat@webkit.org

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
  • rendering/RenderTable.h:
14:03 Changeset [40463] by hyatt@apple.com

Update layout test results for 11363.

13:40 Changeset [40462] by hyatt@apple.com

Add RenderObjectChildList.cpp to all projects.

13:38 Changeset [40461] by hyatt@apple.com

2009-01-31 David Hyatt <hyatt@apple.com>

More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
  • rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
  • rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
  • rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
  • rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):
13:34 Changeset [40460] by hyatt@apple.com

Update layout test results for 11363.

13:34 Changeset [40459] by hyatt@apple.com

Update layout test results for 11363.

13:30 Changeset [40458] by hyatt@apple.com

Update layout test results for 11363.

13:28 Changeset [40457] by hyatt@apple.com

Update layout test results for 11363.

13:28 Changeset [40456] by hyatt@apple.com

Update layout test results for 11363.

13:26 Changeset [40455] by hyatt@apple.com

Update layout test results for 11363.

13:23 Changeset [40454] by hyatt@apple.com

Update layout test results for 11363.

13:20 Changeset [40453] by hyatt@apple.com

2009-01-31 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=11363


Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.

Reviewed by Oliver Hunt

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
  • rendering/RenderTableSection.h:
10:07 Changeset [40452] by treat@webkit.org

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
08:02 Changeset [40451] by darin@apple.com

2009-01-31 Darin Adler <darin@apple.com>

Build fix.

  • WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.
01:36 Changeset [40450] by jmalonzo@webkit.org

2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Nikolas Zimmermann.

[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136

  • GNUmakefile.am:
  • acinclude.m4: Removed.
  • autogen.sh:
  • autotools/acinclude.m4: Added.
  • autotools/dolt.m4: Added.
  • autotools/symbols.filter: Renamed from symbols.filter.
  • autotools/webkit.m4: Added.
  • configure.ac:
00:42 Changeset [40449] by abarth@webkit.org

WebCore:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
  • page/SecurityOrigin.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
  • page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):

WebKit/win:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit/mac:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
Note: See TracTimeline for information about the timeline view.