Timeline


and

02/07/09:

23:03 Changeset [40771] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-02-07 David Hyatt <hyatt@apple.com>

Shrink the size of all InlineTextBoxes and all InlineBoxes (for images and replaced elements) by four bytes.
Change the overflow variable on InlineFlowBoxes into a short and move the bits for InlineFlowBoxes out of the
base InlineBox class. Since the number of bits in the base class was 35, shoving the 3 bits for InlineFlowBoxes
back down into that class (into the 16 bits exposed by making the overflow variable into a short), all text
boxes and image boxes shrink by 4 bytes.

Reviewed by Anders

  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::maxHorizontalVisualOverflow): (WebCore::InlineFlowBox::hasTextChildren):
22:17 Changeset [40770] by dino@apple.com
  • 3 edits in trunk/WebCore

2009-02-07 Dean Jackson <dino@apple.com>

Attempted build fix for Qt. Not reviewed.

TransformationMatrix changes in r40761 broke non-Apple builds.

  • platform/graphics/qt/TransformationMatrixQt.cpp: (WebCore::TransformationMatrix::operator QMatrix):
  • platform/graphics/transforms/TransformationMatrix.h:
21:39 Changeset [40769] by hyatt@apple.com
  • 26 edits in trunk/WebCore

2009-02-07 David Hyatt <hyatt@apple.com>

This patch changes the base class of RenderInline from RenderBox to RenderBoxModelObject. This shift
in base class knocks 32 bytes off the size of every RenderInline. All of the necessary functions
for both RenderInline and RenderBox have either been pulled up into RenderBoxModelObject for sharing
or split into two functions (one in each derived class).

Reviewed by Anders and Antti

  • dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::renderBoxModelObject):
  • dom/Node.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight): (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::paddingLeft): (WebCore::InlineFlowBox::paddingRight):
  • rendering/RenderBlock.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::positionForCoordinates):
  • rendering/RenderBox.h: (WebCore::RenderBox::borderBoundingBox): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::marginTop): (WebCore::RenderBox::marginBottom): (WebCore::RenderBox::marginLeft): (WebCore::RenderBox::marginRight):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop): (WebCore::RenderBoxModelObject::paddingTop): (WebCore::RenderBoxModelObject::paddingBottom): (WebCore::RenderBoxModelObject::paddingLeft): (WebCore::RenderBoxModelObject::paddingRight): (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::calculateBackgroundSize): (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
  • rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::borderTop): (WebCore::RenderBoxModelObject::borderBottom): (WebCore::RenderBoxModelObject::borderLeft): (WebCore::RenderBoxModelObject::borderRight): (WebCore::RenderBoxModelObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderBoxModelObject::hasHorizontalBordersOrPadding): (WebCore::RenderBoxModelObject::childBecameNonInline): (WebCore::RenderBoxModelObject::isBoxModelObject):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::marginLeft): (WebCore::RenderInline::marginRight): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::computeRectForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline): (WebCore::RenderInline::updateHitTestResult): (WebCore::RenderInline::imageChanged): (WebCore::RenderInline::addFocusRingRects):
  • rendering/RenderInline.h: (WebCore::RenderInline::marginTop): (WebCore::RenderInline::marginBottom): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::enclosingCompositingLayer): (WebCore::RenderObject::setLayerNeedsFullRepaint): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::destroy): (WebCore::RenderObject::offsetParent):
  • rendering/RenderObject.h: (WebCore::RenderObject::isInlineContinuation):
  • rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
  • rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
  • rendering/RenderView.cpp: (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h:
  • rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::inlineWidth): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):
21:20 Changeset [40768] by bfulgham@webkit.org
  • 12 edits
    3 adds in trunk/WebCore

2009-02-07 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Timothy Hatcher <timothy@hatcher.name>

Partial fix for <https://bugs.webkit.org/show_bug.cgi?id=21051>
Include localStorage and sessionStorage in DatabasesPanel.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorDOMStorageResource::create): (WebCore::InspectorDOMStorageResource::setScriptObject): (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::removeDOMStorageScriptResource): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didUseDOMStorage):
  • inspector/InspectorController.h:
  • inspector/front-end/DOMStorage.js: Added. (WebInspector.DOMStorage): (WebInspector.DOMStorage.prototype.get domStorage): (WebInspector.DOMStorage.prototype.set domStorage): (WebInspector.DOMStorage.prototype.get domain): (WebInspector.DOMStorage.prototype.set domain): (WebInspector.DOMStorage.prototype.get isLocalStorage): (WebInspector.DOMStorage.prototype.set isLocalStorage):
  • inspector/front-end/DOMStorageItemsView.js: Added. (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.show): (WebInspector.DOMStorageItemsView.prototype.update):
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype._queryFinished): (WebInspector.DatabaseTableView.prototype._queryError):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.addDatabase): (WebInspector.DatabasesPanel.prototype.addDOMStorage): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.closeVisibleView): (WebInspector.DatabasesPanel.prototype.updateDatabaseTables): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): (WebInspector.DOMStorageSidebarTreeElement): (WebInspector.DOMStorageSidebarTreeElement.prototype.onselect): (WebInspector.DOMStorageSidebarTreeElement.prototype.get mainTitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.set mainTitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.get subtitle): (WebInspector.DOMStorageSidebarTreeElement.prototype.set subtitle):
  • inspector/front-end/Images/domStorage.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.addDOMStorage):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage):
18:47 Changeset [40767] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

2009-02-07 Feng Qian <feng@chromium.org>

Reviewed by Eric Seidel <eric@webkit.org>

Put #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor.
https://bugs.webkit.org/show_bug.cgi?id=23574

  • page/EventHandler.cpp:
  • page/EventHandler.h:
18:10 Changeset [40766] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-02-07 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Rob Buis <rwlbuis@gmail.com>


https://bugs.webkit.org/show_bug.cgi?id=23788
call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject.


  • rendering/bidi.cpp: (WebCore::RenderBlock::skipLeadingWhitespace):
14:06 Moving to Git edited by hausmann@webkit.org
(diff)
13:18 Changeset [40765] by darin@apple.com
  • 2 edits in trunk/WebKit

2009-02-07 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
13:13 Changeset [40764] by rwlbuis@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date.

13:10 Changeset [40763] by rwlbuis@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=3248
Bug 3248: Mouse events on OPTION element seem to be ignored

Support mouse events on options in a select when it forms a list box.

Test: fast/forms/option-mouseevents.html

12:46 Changeset [40762] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-07 Adam Treat <adam.treat@torchmobile.com>

Prospective build fix for all non-Apple platforms.

  • platform/graphics/transforms/TransformationMatrix.h:
10:40 Changeset [40761] by cmarrin@apple.com
  • 81 edits in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=6868

I have not only made TransformationMatrix platform independent
but I've also added 3D methods, which will be used when I update
WebKitCSSMatrix to include 3D (see https://bugs.webkit.org/show_bug.cgi?id=23689).
I am now keeping a full 4x4 matrix in TransformationMatrix. I'm also doing all
the math as doubles rather than floats. This makes a TransformationMatrix
go from 24 bytes to 128 bytes, but I don't think this class is used enough to
make this overhead will be significant.

The change from floats to doubles has caused some differences in rounding and
display (sometimes things that displayed as -0.0 now display as 0.0 or vice versa),
so I've had to change some LayoutTest results in the SVG tests.

09:53 Changeset [40760] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix Use toNormalizedRange().

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_get_contents_cb):
07:33 Changeset [40759] by hausmann@webkit.org
  • 4 edits in trunk/WebCore

2009-02-07 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

For the Qt port implement Image::drawPattern via
BitmapImage::drawPatterns' implementation and implement
Gradient::fill.

This partially fixes rendering of generated gradient content.

02/06/09:

20:19 Changeset [40758] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/mac

Merge r40727.

20:19 Changeset [40757] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40726.

20:19 Changeset [40756] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40713.

20:19 Changeset [40755] by mrowe@apple.com
  • 9 edits in branches/Safari-6528

Merge r40712.

20:19 Changeset [40754] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebKit/mac

Merge r40711.

20:19 Changeset [40753] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/mac

Merge r40680.

20:19 Changeset [40752] by mrowe@apple.com
  • 6 edits in branches/Safari-6528/WebCore

Merge r40629.

20:19 Changeset [40751] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40623.

20:19 Changeset [40750] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40537.

20:18 Changeset [40749] by mrowe@apple.com
  • 3 edits in branches/Safari-6528/WebCore

Merge r40606.

20:18 Changeset [40748] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40502.

18:44 Changeset [40747] by aroben@apple.com
  • 5 edits in trunk/WebKit/win

Build fix

Reviewed by Sam Weinig.

  • WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed incorrect .get(), and changed to use the new overload of WebHistory::itemForURLString.
  • WebHistory.cpp: (WebHistory::itemForURLString): Made this const. (WebHistory::itemForURLString): Added an overload that takes a WebCore::String and returns the IWebHistoryItem instead of using an out parameter.
  • WebHistory.h: Added public overload of itemForURLString.
  • WebView.cpp: (WebView::prepareCandidateWindow): (WebView::onIMERequestCharPosition): (WebView::onIMERequestReconvertString): Updated for toRange -> toNormalizedRange rename.
17:28 Changeset [40746] by eric@webkit.org
  • 27 edits
    5 adds in trunk

Reviewed by Justin Garcia.

DOMSelection.getRangeAt() returns a different range than the selection
https://bugs.webkit.org/show_bug.cgi?id=23601

Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range

Test: fast/dom/Selection/getRangeAt.html

  • WebCore.base.exp:
  • dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
  • editing/Editor.cpp: (WebCore::Editor::selectedRange): (WebCore::Editor::fontForSelection): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::insertLineBreak): (WebCore::Editor::insertParagraphSeparator): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::rangeForPoint):
  • editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): (WebCore::executeDeleteToMark): (WebCore::executeSelectToMark):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
  • editing/Selection.cpp: (WebCore::Selection::firstRange): (WebCore::Selection::toNormalizedRange):
  • editing/Selection.h:
  • editing/SelectionController.h: (WebCore::SelectionController::toNormalizedRange):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/markup.cpp: (WebCore::createMarkup):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode): (WebCore::DOMSelection::toString):
  • page/DragController.cpp: (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::startDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent):
  • page/Frame.cpp: (WebCore::Frame::selectedText): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::selectionTextRects): (WebCore::Frame::findString): (WebCore::Frame::respondToChangedSelection):
  • platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord):
17:26 Changeset [40745] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-02-06 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6563402> - Workaround a case where ::didReceiveData() might be called on a ResourceHandleClient
before ::didReceiveResponse().

No layout test, as we don't have a concrete way to reproduce these conditions. To that effect, I've added an ASSERT
to catch the conditions before the workaround takes effect in case any WebKit Debug-build developer runs across
this case and can come up with something more reproducible.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveData): If the response is null create a dummy response. This is much like the FrameLoader::init() response that is used for initial document creation.
17:16 Changeset [40744] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCore.base.exp:
17:10 Changeset [40743] by ggaren@apple.com
  • 9 edits in trunk/WebKit

WebKit/gtk:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/qt:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/wx:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryRedirectLinks):
  • WebKitSupport/FrameLoaderClientWx.h:
17:05 Changeset [40742] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-06 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23621

Do not use m_scrollOffset to check if we are setting the same
value than we already have.

m_scrollOffset starts at 0 for ScrollView, so when opening a new
page and scrolling to 0 (the usual case) the check will fail and
we won't update the adjustment value, resulting in a possibly
mispositioned scrollbar. Use the adjustment value directly
instead, which is what we are updating anyway.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformHandleHorizontalAdjustment): (WebCore::ScrollView::platformHandleVerticalAdjustment):
16:42 Changeset [40741] by justin.garcia@apple.com
  • 4 edits
    4 adds
    4 deletes in trunk

WebCore:

2009-02-06 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver Hunt.


https://bugs.webkit.org/show_bug.cgi?id=23800
Header elements are not always preserved during paste


At paste time, don't merge out of header elements. At copy time, be sure to include
headers in the list of special common ancestor blocks, so that copying a paragraph or less
of content inside a header will include the header element in the copied markup.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::areSameHeaderElements): (WebCore::ReplaceSelectionCommand::shouldMerge):
  • editing/markup.cpp: (WebCore::isSpecialAncestorBlock): (WebCore::createMarkup):

LayoutTests:

2009-02-06 Justin Garcia <justin.garcia@apple.com>

Reviewed by Oliver Hunt.


https://bugs.webkit.org/show_bug.cgi?id=23800
Header elements are not always preserved during paste

  • editing/execCommand/4128080-1-expected.txt: Added.
  • editing/execCommand/4128080-1.html: Added.
  • editing/execCommand/4128080-2-expected.txt: Added.
  • editing/execCommand/4128080-2.html: Added.
16:28 Changeset [40740] by ggaren@apple.com
  • 17 edits in trunk

WebCore:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Part III of <rdar://problem/6552272>.


Make redirect data available to WebKit. (I tried having WebKit track this
data for itself, but that went wrong -- it's just too hard to figure
out the weird corners of the WebCore loader from within another framework.)

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
  • loader/DocumentLoader.h: Store a flag indicating whether we created a global history entry. If we didn't, then we know that the next redirect should not link to us, since we're not in history.


(WebCore::DocumentLoader::clientRedirectSourceForHistory):
(WebCore::DocumentLoader::clientRedirectDestinationForHistory):
(WebCore::DocumentLoader::setClientRedirectSourceForHistory):
(WebCore::DocumentLoader::serverRedirectSourceForHistory):
(WebCore::DocumentLoader::serverRedirectDestinationForHistory):
(WebCore::DocumentLoader::didCreateGlobalHistoryEntry):
(WebCore::DocumentLoader::setDidCreateGlobalHistoryEntry): Added accessors
to help WebKit wade through the muck of WebCore history.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryRedirectLinks): Renamed this client function to say what it does, instead of when it's called.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithNavigationAction): In the case of a redirect, store a link to the previous history URL in the new DocumentLoader, so it can update WebKit with that link when the load commits.

(WebCore::FrameLoader::updateHistory*): Use our new flags and names,
described above.

  • loader/FrameLoader.h: (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::state): Inlined a few trivial functions because performance mistakes give me the itches.


  • loader/FrameLoaderClient.h: Renamed this client function to say what it does, instead of when it's called.

WebKit/mac:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Part III of <rdar://problem/6552272>.


Refactored to use the redirect data WebCore makes available, instead of
tracking loading state in WebKit.


  • History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
  • History/WebHistoryInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):

WebKit/win:

2009-02-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Part III of <rdar://problem/6552272>.


Refactored to use the redirect data WebCore makes available, instead of
tracking loading state in WebKit.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebHistory.cpp: (WebHistory::visitedURL):
  • WebHistory.h:
16:10 Changeset [40739] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-06 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

Reported by Daniel Macks.

https://bugs.webkit.org/show_bug.cgi?id=20412

Use positive numbers for the target info IDs, gtk_target_list_add
casts them to 'guint'. Also just start them from 0, since the
values are not relevant or magic in any way, they are just used as
tokens for the user of the API.

  • webkit/webkitwebview.h:
16:04 Changeset [40738] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Justin Garcia.

Minor refactoring and cleanup to Selection code
https://bugs.webkit.org/show_bug.cgi?id=23774

No functional changes, thus no tests.

  • editing/Editor.cpp: (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle):
  • editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::setBaseAndExtentToDeepEquivalents): (WebCore::Selection::setStartAndEndFromBaseAndExtentRespectingGranularity): (WebCore::Selection::updateSelectionType): (WebCore::Selection::validate): (WebCore::Selection::setWithoutValidation): (WebCore::Selection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/Selection.h: (WebCore::Selection::): (WebCore::Selection::selectionType): (WebCore::Selection::extent): (WebCore::Selection::isNone): (WebCore::Selection::isCaret): (WebCore::Selection::isRange): (WebCore::Selection::isCaretOrRange):
  • editing/SelectionController.h: (WebCore::SelectionController::selectionType):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • page/Frame.cpp: (WebCore::Frame::revealSelection):
15:39 Changeset [40737] by dglazkov@chromium.org
  • 1 edit
    3 adds in trunk/WebCore

2009-02-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23801
Add custom V8 bindings for SVG.

  • bindings/v8/custom/V8SVGElementInstanceCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGLengthCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
15:29 Changeset [40736] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-06 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Bug 23792: unused param is used in RenderLayer.cp but not #include'd
<https://bugs.webkit.org/show_bug.cgi?id=23792>

Add include file for UnusedParam which is used in this file.

  • rendering/RenderLayer.cpp:
15:25 Changeset [40735] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-02-06 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

<https://bugs.webkit.org/show_bug.cgi?id=23741>

Bug 23798: KURLGoogle needs support for protocolInHTTPFamily
<https://bugs.webkit.org/show_bug.cgi?id=23798>

Add protocolInHTTPFamily() to the KURLGoogle implementation.
This is another chromium build fix to mirror r40553.

While in this file, I did some style fixes and consistency fixes:
+ fixed many_occurences_of_underscoring_naming
+ usages of NULL
+ comparisons to 0
+ changed the copyright remove an extraneous , and capitalize the (C)

which was suggested for other files that I've submitted.

No observable change in behavior, so no test.

  • platform/KURL.h: (WebCore::KURL::protocolInHTTPFamily):
  • platform/KURLGoogle.cpp: (WebCore::KURLCharsetConverter::ConvertFromUTF16): (WebCore::lowerCaseEqualsASCII): (WebCore::KURLGooglePrivate::KURLGooglePrivate): (WebCore::KURLGooglePrivate::setUtf8): (WebCore::KURLGooglePrivate::setAscii): (WebCore::KURLGooglePrivate::init): (WebCore::KURLGooglePrivate::initProtocolInHTTPFamily): (WebCore::KURLGooglePrivate::copyTo): (WebCore::KURLGooglePrivate::replaceComponents): (WebCore::KURL::KURL): (WebCore::KURL::createCFURL): (WebCore::KURL::isEmpty): (WebCore::KURL::protocolInHTTPFamily): (WebCore::KURL::query): (WebCore::decodeURLEscapeSequences): (WebCore::KURL::protocolIs): (WebCore::encodeWithURLEscapeSequences): (WebCore::KURL::invalidate): (WebCore::equalIgnoringRef):
  • platform/KURLGooglePrivate.h:
14:48 Changeset [40734] by ddkilzer@apple.com
  • 5 edits in trunk/WebCore

Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

<https://bugs.webkit.org/show_bug.cgi?id=23741>

Reviewed by Darin Adler.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::contentDataEquivalent): Moved method to WebCore::StyleRareNonInheritedData class.
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::contentDataEquivalent): Replaced declaration with inline method that calls contentDataEquivalent() on WebCore::StyleRareNonInheritedData instead.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::operator==): This is the bug fix! Replaced pointer comparison of ContentData objects with call to StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added.
  • rendering/style/StyleRareNonInheritedData.h: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Added declaration.
14:42 Changeset [40733] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2009-02-06 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6562220>
CrashTracer: [USER] 21 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostProxy::port


Make the handling of crashes in the plug-in host more robust.


  • Plugins/Hosted/NetscapePluginHostProxy.h: Add m_portSet.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Initialize m_portSet.


(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
Free m_portSet.


(WebKit::NetscapePluginHostProxy::processRequests):
Listen for messages on the port set. If we get a message to the port death notification port,
then call pluginHostDied. Otherwise, process the message.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::cleanup): Factor code that should be shared between destroy() and pluginHostDied() into cleanup.


(WebKit::NetscapePluginInstanceProxy::destroy):
Call cleanup().


(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Call cleanup().


(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Call NetscapePluginHostProxy::processRequests.


  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invalidate): Add a null check for the host proxy.
14:17 Changeset [40732] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Factor code that checks whether the object is rooted in
repaint() and repaintRectangle() into a common isRooted()
method.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::isRooted):
  • rendering/RenderObject.h:
14:16 Changeset [40731] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-02-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Expose an isRootLayer() method on RenderLayer that works whether the
layer is rooted or not, and use that in a few places in the
accelerated compositing code.

  • rendering/RenderLayer.h: (WebCore::RenderLayer::isRootLayer):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintingGoesToWindow):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::requiresCompositingLayer):
14:13 Changeset [40730] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Make RenderStyle::transitionForProperty() const.

  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::transitionForProperty):
  • rendering/style/RenderStyle.h:
13:44 Changeset [40729] by mitz@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6552338> FontCache::releaseFontData() called on a small caps font that is not in the cache

Most platforms do not retrieve the small caps font from the FontCache,
but cross-platform code in ~SimpleFontData() assumes the the small caps
font data did come from the cache and therefore calls releaseFontData()
on it.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::~SimpleFontData): Reordered to call platformDestroy() before releasing the small caps font and pruning the glyph page tree. This allows platformDestroy() to reset m_smallCapsFontData to 0 if it was not obtained from the cache.
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformDestroy): Set m_smallCapsFontData to 0 after deleting it.
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::platformCommonDestroy): Ditto.
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformDestroy): Ditto.
13:30 Changeset [40728] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-02-06 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is turned on.

Remove font smoothing changes that will be committed
separately.

  • platform/graphics/mac/WebLayer.mm: (WebCore::if):
13:09 Changeset [40727] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • try to fix the Tiger build
  • Misc/WebNSArrayExtras.h:
12:49 Changeset [40726] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Anders Carlsson.

  • fix an assertion failure in Vector::at() beneath WebHistoryItem::dictionaryRepresentation.
  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial size. Also reduced the inline capacity of the vector used for weekly visit counts to 5, which is the expected maximum size.
12:33 Changeset [40725] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-02-06 Anders Carlsson <andersca@apple.com>

Build fix.


  • bridge/npapi.h:
12:16 Changeset [40724] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-06 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23790
Custom -> JSCCustom in SVGPointList.idl

  • svg/SVGPointList.idl:
11:22 Changeset [40723] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-06 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6563650>
Add Netscape plug-in API to tell the browser not to load streams (some plug-ins handle network loading manually)


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadStream]): (-[WebNetscapePluginView pluginView:receivedData:]): (-[WebNetscapePluginView _shouldCancelSrcStream]):
10:08 Changeset [40722] by dglazkov@chromium.org
  • 5 edits in trunk/WebCore

2009-02-06 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23309
Fix whitespace indent errors. The rest of the original patch has already
landed.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::clear):
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::clear):
09:37 Changeset [40721] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-06 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Hausmann.

Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
the context transparent.

[QT] clearRect fill's a given rect with white
https://bugs.webkit.org/show_bug.cgi?id=23728

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect):
09:32 Changeset [40720] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Build fix. Re-enable missing file in Release_Cairo target.

09:05 Changeset [40719] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-02-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23781

When the document is attached and detached, and when it becomes active/inactive
(e.g. coming out or going into the page cache) we need to call
RenderView::didMoveOnscreen()/willMoveOffscreen() to hook and unhook the composited
layers.

Also, if Document::recalcStyle() does not do a layout, it needs to
update the compositing layers.

  • dom/Document.cpp: (WebCore::Document::updateRendering): (WebCore::Document::updateLayout): (WebCore::Document::attach): (WebCore::Document::detach): (WebCore::Document::documentWillBecomeInactive): (WebCore::Document::documentDidBecomeActive):
05:50 Changeset [40718] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-02-06 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Doc - made 2 functions internal as they are not part of the API anymore (and this fixes 2 qdoc warnings)

04:35 Changeset [40717] by hausmann@webkit.org
  • 10 edits in trunk

WebCore:

2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added support for different ownership models for wrapped QObjects in
the JavaScript environment.

WebKit/qt:

2009-02-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added an overload of QWebFrame::addToJavaScriptWindowObject that takes a QScriptEngine::ValueOwnership parameter.

02:10 Changeset [40716] by ap@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-06 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23769

Do not use empty ResourceError errors.

Rather create bogus but non-null errors, since some codepaths
expect these. For example, see DocumentLoader::mainReceivedError.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
01:21 Changeset [40715] by ap@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-02-06 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23761

Use two-arg KURL ctor.

We are using the one-arg ctor currently, but:

  • It assumes the strings are already encoded, which is not necesarily the case for us.
  • The single-argument KURL ctors expect their input to already be the output of a previous KURL::parse call, so for the general case (ie, random user input) we need to use the two-arg ctor anyway.
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:
00:56 Changeset [40714] by zecke@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-02-06 Aaron Boodman <aa@chromium.org>

Reviewed by Holger Freyther.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::documentElementAvailable):) Fix compile error in Qt build introduced by the below change (r40694).
00:16 Changeset [40713] by mjs@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-06 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Dan Bernstein.

fix obvious problem in previous commit (
used instead of &&)
  • WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation):
00:11 Changeset [40712] by mjs@apple.com
  • 9 edits in trunk

WebCore:

2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein and Geoff Garen.

  • WebCore code to track per-day and per-week visit counts in history

The basic idea is as follows: we track daily visits for up to 13
days, and weekly visits for up to 5 weeks past the end of the
current daily visits. As soon as the number of daily counts goes
over 13, we squish them down into weeks, and then prune the excess weeks.

  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Remove bogus whitespace. (WebCore::timeToDay): Helper function: convert time to days from the epoch. (WebCore::HistoryItem::padDailyCountsForNewVisit): Insert 0 counts if a site is visited after a span of days. (WebCore::HistoryItem::collapseDailyVisitsToWeekly): Core day/week upgrade algorithm as described above. (WebCore::HistoryItem::recordVisitAtTime): Use above helpers to record all info about a visit to this history item. (WebCore::HistoryItem::setLastVisitedTime): Updated. (WebCore::HistoryItem::visited): Updated. (WebCore::HistoryItem::recordInitialVisit): New function to handle recording data about the very first visit, replacing the prior practice of explicitly setting visit count to 1. (WebCore::HistoryItem::adoptVisitCounts): Take ownership of daily and weekly visit count vectors. (WebCore::HistoryItem::mergeAutoCompleteHints): Added a comment noting that this function doesn't work properly now (though this shouldn't matter much in practice.)
  • history/HistoryItem.h: (WebCore::HistoryItem::dailyVisitCounts): Accessor for daily counts. (WebCore::HistoryItem::weeklyVisitCounts): Ditto for weekly counts.
  • WebCore.base.exp: Add new symbols and sort.

WebKit/win:

2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein and Geoff Garen..

  • WebKit code to track per-day and per-week visit counts in history

For now this data is only exposed via SPI for performance reasons.

  • Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
  • WebHistory.cpp: (WebHistory::visitedURL): Use new recordInitialVisit method.
  • WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support for new data. (WebHistoryItem::dictionaryRepresentation): Add saving support for new data. (WebHistoryItem::getDailyVisitCounts): SPI accessor. (WebHistoryItem::getWeeklyVisitCounts): SPI accessor. (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
  • WebHistoryItem.h:
00:04 Changeset [40711] by mjs@apple.com
  • 7 edits in trunk/WebKit/mac

2009-02-05 Maciej Stachowiak <mjs@apple.com> and Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein and Geoff Garen.

  • WebKit code to track per-day and per-week visit counts in history

For now this data is only exposed via SPI for performance reasons.


  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Add parsing support for new data. (-[WebHistoryItem _recordInitialVisit]): Tell WebCore to record an initial visit. (-[WebHistoryItem dictionaryRepresentation]): Add saving support for new data. (-[WebHistoryItem _getDailyVisitCounts:]): SPI accessor. (-[WebHistoryItem _getWeeklyVisitCounts:]): SPI accessor.
  • History/WebHistoryItemInternal.h: Declare new methods.
  • History/WebHistoryItemPrivate.h: Ditto.
  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): For the initial visit, use the new _recordInitialVisit method instead of setting visit count to 1.
  • Misc/WebNSArrayExtras.h:
  • Misc/WebNSArrayExtras.m: (-[NSArray _webkit_numberAtIndex:]): Helper to retrieve an NSNumber or nil from an NSArray (-[NSArray _webkit_stringAtIndex:]): Helper to retrieve an NSString of nil from an NSArray

02/05/09:

23:53 Changeset [40710] by ap@webkit.org
  • 10 edits
    2 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6438271> Improve backspace handling of accented characters

Test: platform/mac/editing/deleting/backward-delete.html

This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
because the current behavior matches their standards (tested on Windows, assumed elsewhere).

  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
  • dom/Position.h: Added a new option for previous(), used to move to a next position for backward deletion. Renamed EUsingComposedCharacters to PositionMoveType.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check surrounding this code a little.
  • editing/htmlediting.cpp: (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousVisuallyDistinctCandidate): Adjusted for renamed enum values.
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.h: Added previousOffsetForBackwardDeletion().
  • rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion): On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
22:06 Changeset [40709] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix a crash in RenderWidget::destroy when navigating away from a page with an <iframe>

This was a regression caused by r40679

Reviewed by Dave Hyatt.

Tested by many many tests.

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Only deref the RenderWidget after we finish accessing its members.
21:40 Changeset [40708] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Fix the #include file order, per review comments.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
21:37 Changeset [40707] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23362

If the WebHTMLView uses accelerated compositing, we need for force
the on-screen capture path and also force animations to start with -display
since the DRT window has autodisplay disabled.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
21:09 Changeset [40706] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

getAnimatedStyleForRenderer() should not create a new
CompositeAnimation if the object isn't already animating, and
it should just fall back to returning renderer->style().

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
21:03 Changeset [40705] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

Rubberstamped by Sam Weinig.

  • wtf/TypeTraits.h: Include Platform.h, since this header uses macros defined there.
20:30 Changeset [40704] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is turned on.

Give RenderLayerBacking some love after the great
RenderBoxModelObject split.

20:22 Changeset [40703] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is turned on.

writeIndent() needs to be static to avoid warnings on some OSes,
and remove unused CAToTransform3D() method.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::writeIndent):
  • platform/graphics/mac/GraphicsLayerCA.mm:
20:18 Changeset [40702] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Add some methods to the TransformOperation classes that are required
by GraphicsLayer when ACCELERATED_COMPOSITING is turned on.

20:12 Changeset [40701] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Minor clenaup: fix brace style in CompositeAnimationPrivate::updateTransitions(),
and correct a usage of UNUSED_PARAM().

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::startAnimation):
20:09 Changeset [40700] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Fix build when ACCELERATED_COMPOSITING is turned on.

animationOfPropertyIsAccelerated() needs to be public because
it is called from AnimationController.

  • page/animation/AnimationBase.h:
20:07 Changeset [40699] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Fix mis-typed enum value which is hidden inside #ifdefs so didn't break
the build.

  • page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayers):
16:26 Changeset [40698] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-02-05 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Sam Weinig.
Build fix.

16:17 Changeset [40697] by zimmermann@webkit.org
  • 4 edits in trunk/LayoutTests
16:15 Changeset [40696] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix missing checked toRenderBlock casts.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::availableHeightUsing):
16:11 Changeset [40695] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Patch from Darin Adler.
Reviewed by Sam Weinig.

Fix case where we were casting to RenderView.

No test case possible.

  • editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
15:59 Changeset [40694] by dglazkov@chromium.org
  • 23 edits in trunk

WebCore:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs): Add call to dispatchDocumentElementAvailable()
  • dom/XMLTokenizerQt.cpp: (WebCore::XMLTokenizer::parseStartElement): Ditto.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Ditto.
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable().
  • loader/FrameLoader.cpp: documentElementAvailable() callback plumbing.
  • loader/FrameLoader.h: Ditto.
  • loader/FrameLoaderClient.h: Add new documentElementAvailable() callback.

WebKit/gtk:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable()
  • WebCoreSupport/FrameLoaderClientGtk.h: Ditto.

WebKit/mac:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.h: Stub out documentElementAvailable().
  • WebCoreSupport/WebFrameLoaderClient.mm: Ditto.

WebKit/qt:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClient::documentElementAvailable): Stub out documentElementAvailable().
  • WebCoreSupport/FrameLoaderClientQt.h: Ditto.

WebKit/win:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • WebFrame.cpp: (WebFrame::documentElementAvailable): Stub out documentElementAvailable()
  • WebFrame.h: Ditto.

WebKit/wx:

2009-02-05 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23708
Adds documentElementAvailable() callback to FrameLoaderClient.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::documentElementAvailable): Stub out documentElementAvailable().
  • WebKitSupport/FrameLoaderClientWx.h: Ditto.
15:40 Changeset [40693] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-05 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23766
CanvasRenderingContext2D::setShadow needs else for other platforms.

Implements the CMYK variant of CanvasRenderingContext2D::setShadow for
other platforms using the CMYK color constructor.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow):
15:36 Changeset [40692] by dglazkov@chromium.org
  • 2 edits
    4 adds in trunk/WebCore

2009-02-05 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23687
Wires up Skia'a ImageBuffer::toDataURL to support pngs.
This helps Chromium pass a couple of layout tests.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/image-encoders: Added.
  • platform/image-encoders/skia: Added.
  • platform/image-encoders/skia/PNGImageEncoder.cpp: Added. (WebCore::): (WebCore::PngEncoderState::EncoderWriteCallback): (WebCore::PngEncoderState::ConvertBGRAtoRGB): (WebCore::PngEncoderState::PngWriteStructDestroyer::PngWriteStructDestroyer): (WebCore::PngEncoderState::PngWriteStructDestroyer::~PngWriteStructDestroyer): (WebCore::PNGImageEncoder::encode):
  • platform/image-encoders/skia/PNGImageEncoder.h: Added.
15:34 Changeset [40691] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix missing checked cast.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
15:31 Changeset [40690] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Not reviewed. Fix WML enabled builds.
FrameLoader::load() got an additional 'lockHistory' parameter, pass 'false'.

15:28 Changeset [40689] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-05 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23625
Additional fix: Skia platform doesn't render text to a canvas or support clipping to an image buffer

Fixes three bugs in PlatformContextSkia:

  • When a new layer was started clipped to an image we used the assignment operator to copy the SkBitmap. If the SkBitmap owns it's pixels, this is not the right thing to do. Instead we need to create a copy of the image.
  • State holds an SkBitmap by value. State's copy constructor does a memcpy. This is confusing and subtle, I've converted to use a member initializer list which I think is clearer and less error prone.
  • When creating a new layer there is no need to copy the clip image.
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::save): (PlatformContextSkia::beginLayerClippedToImage):
15:24 Changeset [40688] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-05 Scott Violet <sky@google.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=23462
Changes call from setFillColor to setStrokeColor.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
15:12 Changeset [40687] by dglazkov@chromium.org
  • 1 edit
    15 adds in trunk/WebCore

2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23767
Add custom V8 bindings for HTML5 database.

  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp: Added. (WebCore::V8CustomSQLStatementCallback::V8CustomSQLStatementCallback): (WebCore::V8CustomSQLStatementCallback::~V8CustomSQLStatementCallback): (WebCore::V8CustomSQLStatementCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementCallback.h: Added. (WebCore::V8CustomSQLStatementCallback::create):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Added. (WebCore::V8CustomSQLStatementErrorCallback::V8CustomSQLStatementErrorCallback): (WebCore::V8CustomSQLStatementErrorCallback::~V8CustomSQLStatementErrorCallback): (WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h: Added. (WebCore::V8CustomSQLStatementErrorCallback::create):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp: Added. (WebCore::V8CustomSQLTransactionCallback::V8CustomSQLTransactionCallback): (WebCore::V8CustomSQLTransactionCallback::~V8CustomSQLTransactionCallback): (WebCore::V8CustomSQLTransactionCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionCallback.h: Added. (WebCore::V8CustomSQLTransactionCallback::create):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: Added. (WebCore::V8CustomSQLTransactionErrorCallback::V8CustomSQLTransactionErrorCallback): (WebCore::V8CustomSQLTransactionErrorCallback::~V8CustomSQLTransactionErrorCallback): (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Added. (WebCore::V8CustomSQLTransactionErrorCallback::create):
  • bindings/v8/custom/V8CustomVoidCallback.cpp: Added. (WebCore::V8CustomVoidCallback::V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::~V8CustomVoidCallback): (WebCore::V8CustomVoidCallback::handleEvent): (WebCore::invokeCallback):
  • bindings/v8/custom/V8CustomVoidCallback.h: Added. (WebCore::V8CustomVoidCallback::create):
  • bindings/v8/custom/V8DatabaseCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8SQLTransactionCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
15:10 Changeset [40686] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 David Hyatt <hyatt@apple.com>

Fix crash on svg custom stop test. A virtual function didn't get patched properly.

Reviewed by Sam Weinig

  • rendering/RenderObject.cpp: (WebCore::RenderObject::clippedOverflowRectForRepaint):
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):
15:08 Changeset [40685] by simon.fraser@apple.com
  • 12 edits in trunk/WebCore

2009-02-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23765

Add toRenderBoxModelObject() so that we can cast objects that
can have layers.

Fix getComputedStyle to return the current value of style
properties that are undergoing accelerated animations, by
asking the AnimationController if the property has accelerated
animations, and, if so, asking it to generate an appropriate
style.

Tightened up some type safety (CSSPropertyID), and code clarity
(replace bool with enum).

15:03 Changeset [40684] by dglazkov@chromium.org
  • 4 edits
    3 adds in trunk

JavaScriptCore:

2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.

  • wtf/MainThread.cpp: Added platform guard to initializeMainThread.
  • wtf/chromium/ChromiumThreading.h: Added.
  • wtf/chromium/MainThreadChromium.cpp: Added. (WTF::initializeMainThread): (WTF::scheduleDispatchFunctionsOnMainThread):

WebCore:

2009-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23747
Add Chromium threading-related files.

  • platform/chromium/TemporaryLinkStubs.cpp: Removed theading-related stubs.
15:01 Changeset [40683] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix whitespace in the ChangeLog

14:45 Changeset [40682] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • build fix
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
14:43 Changeset [40681] by weinig@apple.com
  • 4 edits in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Reviewed by Adam Roben.

Add toRenderButton methods for casting RenderObjects to RenderButtons. The methods will assert if the object
is not a RenderButton. Also add a toRenderButton method that takes a RenderButton but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderButton.

  • rendering/RenderButton.h: (WebCore::RenderButton::isRenderButton): (WebCore::toRenderButton):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderObject.h: (WebCore::RenderObject::isRenderButton):
14:37 Changeset [40680] by bdakin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-05 Beth Dakin <bdakin@apple.com>

Reviewed by John Sullivan and Brady Eidson.

Fix for <rdar://problem/6557595> REGRESSION: In Mail, selecting a
mail note message doesn't display it in Mail's preview pane

This was failing because revision 36962 removed a version of
setVerticalScrollingMode that mail calls. This patch simply adds
that method back.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
14:26 Changeset [40679] by hyatt@apple.com
  • 17 edits in trunk/WebCore

2009-02-05 David Hyatt <hyatt@apple.com>

Move the m_layer member variable of RenderBox up into RenderBoxModelObject. Refactor styleDidChange'
of RenderObject, RenderBoxModelObject and RenderBox to get more of the code in the correct subclass.
In order to set the various RenderObject bits properly prior to the test for whether a layer is
required, I added an additional method, updateBoxModelInfoAfterStyleChange, that is responsible
for setting all of the bits.


Eliminate hasStaticX/Y, staticX/Y, and setStaticX/Y from the render tree. Move hasStaticX/Y to
RenderStyle, and just use the corresponding layer() methods for the
staticX/Y getters/setters.

Reviewed by Sam Weinig

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents): (WebCore::RenderBlock::calcPrefWidths): (WebCore::RenderBlock::baselinePosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::updateBoxModelInfoFromStyle): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::absoluteToLocal): (WebCore::RenderBox::localToContainerQuad): (WebCore::RenderBox::position): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::destroy): (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange): (WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
  • rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::layer): (WebCore::RenderBoxModelObject::requiresLayer):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::updateBoxModelInfoFromStyle): (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::relativePositionedInlineOffset):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setStaticY): (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleDidChange):
  • rendering/RenderObject.h: (WebCore::RenderObject::markContainingBlocksForLayout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
  • rendering/bidi.cpp: (WebCore::appendRunsForObject): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasStaticX): (WebCore::InheritedFlags::hasStaticY):
14:07 Changeset [40678] by bfulgham@webkit.org
  • 9 edits
    1 add in trunk/JavaScriptCore

2009-02-05 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 23713: COMPILE_ASSERTS should be moved out of TypeTraits.h and into .cpp file
<https://bugs.webkit.org/show_bug.cgi?id=23713>

  • wtf/HashTraits.h: Remove unnecessary header file that I missed when moving out the type traits form this file.
  • wtf/TypeTraits.cpp: Added. (WTF::):
  • wtf/TypeTraits.h: Moved the compile asserts into TypeTraits.cpp file.
13:18 Changeset [40677] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Fix the windows build.

  • bindings/scripts/CodeGeneratorCOM.pm:
  • dom/Node.idl:
12:58 Changeset [40676] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.


Update to match Gecko.


  • bridge/npapi.h:
  • plugins/npfunctions.h:
12:35 Changeset [40675] by weinig@apple.com
  • 33 edits
    3 deletes in trunk/WebCore

2009-02-05 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Finish merging EventTargetNode up into Node.

This also fixes a small recently introduced issue where EventListeners
would not be removed from the document if they were attached to comment
nodes outside of the documentElement.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSEventTargetNodeCustom.cpp: Removed.
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::pushEventHandlerScope):
  • bindings/scripts/CodeGenerator.pm:
  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData): (WebCore::CharacterData::rendererIsNeeded):
  • dom/CharacterData.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove): (WebCore::ContainerNode::attach): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::insertedIntoDocument): (WebCore::ContainerNode::removedFromDocument): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/ContainerNode.h: (WebCore::ContainerNode::ContainerNode):
  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): (WebCore::Document::removeAllDisconnectedNodeEventListeners): (WebCore::Document::setFocusedNode):
  • dom/EventTargetNode.cpp: Removed.
  • dom/EventTargetNode.h: Removed.
  • dom/Node.cpp: (WebCore::Node::scriptExecutionContext): (WebCore::Node::eventListeners): (WebCore::Node::insertedIntoDocument): (WebCore::Node::removedFromDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument): (WebCore::updateSVGElementInstancesAfterEventListenerChange): (WebCore::Node::addEventListener): (WebCore::Node::removeEventListener): (WebCore::Node::removeAllEventListenersSlowCase): (WebCore::Node::handleLocalEvents): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::dispatchEvent): (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchWindowEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchKeyEvent): (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchSimulatedMouseEvent): (WebCore::Node::dispatchSimulatedClick): (WebCore::Node::dispatchWheelEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchFocusEvent): (WebCore::Node::dispatchBlurEvent): (WebCore::Node::dispatchEventForType): (WebCore::Node::dispatchProgressEvent): (WebCore::Node::dispatchStorageEvent): (WebCore::Node::removeInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForTypeAndAttribute): (WebCore::Node::inlineEventListenerForType): (WebCore::Node::disabled): (WebCore::Node::defaultEventHandler): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::onblur): (WebCore::Node::setOnblur): (WebCore::Node::onchange): (WebCore::Node::setOnchange): (WebCore::Node::onclick): (WebCore::Node::setOnclick): (WebCore::Node::oncontextmenu): (WebCore::Node::setOncontextmenu): (WebCore::Node::ondblclick): (WebCore::Node::setOndblclick): (WebCore::Node::onerror): (WebCore::Node::setOnerror): (WebCore::Node::onfocus): (WebCore::Node::setOnfocus): (WebCore::Node::oninput): (WebCore::Node::setOninput): (WebCore::Node::onkeydown): (WebCore::Node::setOnkeydown): (WebCore::Node::onkeypress): (WebCore::Node::setOnkeypress): (WebCore::Node::onkeyup): (WebCore::Node::setOnkeyup): (WebCore::Node::onload): (WebCore::Node::setOnload): (WebCore::Node::onmousedown): (WebCore::Node::setOnmousedown): (WebCore::Node::onmousemove): (WebCore::Node::setOnmousemove): (WebCore::Node::onmouseout): (WebCore::Node::setOnmouseout): (WebCore::Node::onmouseover): (WebCore::Node::setOnmouseover): (WebCore::Node::onmouseup): (WebCore::Node::setOnmouseup): (WebCore::Node::onmousewheel): (WebCore::Node::setOnmousewheel): (WebCore::Node::onbeforecut): (WebCore::Node::setOnbeforecut): (WebCore::Node::oncut): (WebCore::Node::setOncut): (WebCore::Node::onbeforecopy): (WebCore::Node::setOnbeforecopy): (WebCore::Node::oncopy): (WebCore::Node::setOncopy): (WebCore::Node::onbeforepaste): (WebCore::Node::setOnbeforepaste): (WebCore::Node::onpaste): (WebCore::Node::setOnpaste): (WebCore::Node::ondragenter): (WebCore::Node::setOndragenter): (WebCore::Node::ondragover): (WebCore::Node::setOndragover): (WebCore::Node::ondragleave): (WebCore::Node::setOndragleave): (WebCore::Node::ondrop): (WebCore::Node::setOndrop): (WebCore::Node::ondragstart): (WebCore::Node::setOndragstart): (WebCore::Node::ondrag): (WebCore::Node::setOndrag): (WebCore::Node::ondragend): (WebCore::Node::setOndragend): (WebCore::Node::onreset): (WebCore::Node::setOnreset): (WebCore::Node::onresize): (WebCore::Node::setOnresize): (WebCore::Node::onscroll): (WebCore::Node::setOnscroll): (WebCore::Node::onsearch): (WebCore::Node::setOnsearch): (WebCore::Node::onselect): (WebCore::Node::setOnselect): (WebCore::Node::onselectstart): (WebCore::Node::setOnselectstart): (WebCore::Node::onsubmit): (WebCore::Node::setOnsubmit): (WebCore::Node::onunload): (WebCore::Node::setOnunload):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::updateMouseEventTargetNode): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::canMouseDownStartSelect): (WebCore::EventHandler::canMouseDragExtendSelect): (WebCore::eventTargetNodeForDocument): (WebCore::EventHandler::keyEvent):
  • page/FrameView.cpp: (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus):
  • page/FrameView.h:
  • page/Page.cpp: (WebCore::networkStateChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::updateOverflowStatus):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
  • rendering/RenderMedia.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionChanged):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::toNode):
  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate):
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult):
12:25 Changeset [40674] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-05 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build now that EventTargetNode.idl was removed in r40672.

  • WebCore.pro:
12:14 Changeset [40673] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-05 Scott Violet <sky@google.com>

Reviewed by Sam Weinig.

Bug 23462: Add RGB -> CMYK conversion algorithm
<https://bugs.webkit.org/show_bug.cgi?id=23462>

Adds an RGB -> CMYK converter. This isn't perfect, but better than
nothing.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor): (WebCore::CanvasStyle::cmykToRGB):
  • html/CanvasStyle.h:
10:38 Changeset [40672] by weinig@apple.com
  • 37 edits
    1 delete in trunk

WebCore:

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

First stage of merging EventTargetNode up into Node. The intent of this change
is to both simplify the inheritance hierarchy (at the same time making it more
closely match the spec which states that all Nodes are EventTargets) and save
4 bytes per Node that the polymorphic multiple-inheritance was costing us.

This does the bare minimum to get things compiling, the next patch will clean

  • DerivedSources.make:
  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
  • bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSEventTarget.cpp: (WebCore::toEventTarget):
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::pushEventHandlerScope):
  • bindings/js/JSStyleSheetCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Attr.idl:
  • dom/CharacterData.h:
  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toNode):
  • dom/EventTarget.h:
  • dom/EventTarget.idl:
  • dom/EventTargetNode.cpp: (WebCore::Node::scriptExecutionContext): (WebCore::Node::eventListeners): (WebCore::Node::insertedIntoDocument): (WebCore::Node::removedFromDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument): (WebCore::Node::addEventListener): (WebCore::Node::removeEventListener): (WebCore::Node::removeAllEventListenersSlowCase): (WebCore::Node::handleLocalEvents): (WebCore::Node::dispatchEvent): (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchWindowEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchKeyEvent): (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchSimulatedMouseEvent): (WebCore::Node::dispatchSimulatedClick): (WebCore::Node::dispatchWheelEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchFocusEvent): (WebCore::Node::dispatchBlurEvent): (WebCore::Node::dispatchEventForType): (WebCore::Node::dispatchProgressEvent): (WebCore::Node::dispatchStorageEvent): (WebCore::Node::removeInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForType): (WebCore::Node::setInlineEventListenerForTypeAndAttribute): (WebCore::Node::inlineEventListenerForType): (WebCore::Node::disabled): (WebCore::Node::defaultEventHandler): (WebCore::Node::onabort): (WebCore::Node::setOnabort): (WebCore::Node::onblur): (WebCore::Node::setOnblur): (WebCore::Node::onchange): (WebCore::Node::setOnchange): (WebCore::Node::onclick): (WebCore::Node::setOnclick): (WebCore::Node::oncontextmenu): (WebCore::Node::setOncontextmenu): (WebCore::Node::ondblclick): (WebCore::Node::setOndblclick): (WebCore::Node::onerror): (WebCore::Node::setOnerror): (WebCore::Node::onfocus): (WebCore::Node::setOnfocus): (WebCore::Node::oninput): (WebCore::Node::setOninput): (WebCore::Node::onkeydown): (WebCore::Node::setOnkeydown): (WebCore::Node::onkeypress): (WebCore::Node::setOnkeypress): (WebCore::Node::onkeyup): (WebCore::Node::setOnkeyup): (WebCore::Node::onload): (WebCore::Node::setOnload): (WebCore::Node::onmousedown): (WebCore::Node::setOnmousedown): (WebCore::Node::onmousemove): (WebCore::Node::setOnmousemove): (WebCore::Node::onmouseout): (WebCore::Node::setOnmouseout): (WebCore::Node::onmouseover): (WebCore::Node::setOnmouseover): (WebCore::Node::onmouseup): (WebCore::Node::setOnmouseup): (WebCore::Node::onmousewheel): (WebCore::Node::setOnmousewheel): (WebCore::Node::onbeforecut): (WebCore::Node::setOnbeforecut): (WebCore::Node::oncut): (WebCore::Node::setOncut): (WebCore::Node::onbeforecopy): (WebCore::Node::setOnbeforecopy): (WebCore::Node::oncopy): (WebCore::Node::setOncopy): (WebCore::Node::onbeforepaste): (WebCore::Node::setOnbeforepaste): (WebCore::Node::onpaste): (WebCore::Node::setOnpaste): (WebCore::Node::ondragenter): (WebCore::Node::setOndragenter): (WebCore::Node::ondragover): (WebCore::Node::setOndragover): (WebCore::Node::ondragleave): (WebCore::Node::setOndragleave): (WebCore::Node::ondrop): (WebCore::Node::setOndrop): (WebCore::Node::ondragstart): (WebCore::Node::setOndragstart): (WebCore::Node::ondrag): (WebCore::Node::setOndrag): (WebCore::Node::ondragend): (WebCore::Node::setOndragend): (WebCore::Node::onreset): (WebCore::Node::setOnreset): (WebCore::Node::onresize): (WebCore::Node::setOnresize): (WebCore::Node::onscroll): (WebCore::Node::setOnscroll): (WebCore::Node::onsearch): (WebCore::Node::setOnsearch): (WebCore::Node::onselect): (WebCore::Node::setOnselect): (WebCore::Node::onselectstart): (WebCore::Node::setOnselectstart): (WebCore::Node::onsubmit): (WebCore::Node::setOnsubmit): (WebCore::Node::onunload): (WebCore::Node::setOnunload):
  • dom/EventTargetNode.h: (WebCore::toEventTargetNode): (WebCore::EventTargetNodeCast):
  • dom/EventTargetNode.idl: Removed.
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent): (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
  • dom/MouseEvent.h: (WebCore::MouseEvent::create): (WebCore::MouseEvent::relatedTarget):
  • dom/Node.cpp: (WebCore::Node::~Node):
  • dom/Node.h: (WebCore::Node::isEventTargetNode): (WebCore::Node::toNode): (WebCore::Node::removeAllEventListeners): (WebCore::Node::refEventTarget): (WebCore::Node::derefEventTarget):
  • dom/Node.idl:
  • page/EventHandler.h:
  • page/FrameView.h:
  • xml/XPathResult.h: (WebCore::XPathResult::create):

LayoutTests:

2009-02-05 Sam Weinig <sam@webkit.org>

Reviewed by Darin Layer.

Fix after merging EventTargetNode up into Node.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:
09:24 Changeset [40671] by hyatt@apple.com
  • 48 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Convert RenderLayer from having a RenderBox* m_renderer to having a RenderBoxModelObject*. The
container-relative repaint methods all had to be changed as a result to use RenderBoxModelObject* also.

All of RenderLayer.cpp now uses what will be the new style for dealing with an object that can be a block
or an inline flow. x()/y()/width()/height() can't be queried on an inline flow, nor can many other
properties (like scrollWidth() / scrollHeight()), so the code has to be tightened up to convert to RenderBox
under the right conditions.

There was a bogus subtraction of renderer()->y() in localBounding box for RenderInlines. Since y was always
0, this subtraction wasn't necessary. It has been removed.

Reviewed by Adam Roben

  • page/animation/AnimationBase.cpp:
  • rendering/RenderBR.h: (WebCore::RenderBR::selectionRectForRepaint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRectsForRepaint): (WebCore::RenderBlock::rectWithOutlineForRepaint):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::selectionRectForRepaint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::outlineBoundsForRepaint): (WebCore::RenderBox::localToContainerQuad): (WebCore::RenderBox::clippedOverflowRectForRepaint): (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX): (WebCore::RenderBoxModelObject::relativePositionOffsetY):
  • rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::relativePositionOffset):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::computeRectForRepaint):
  • rendering/RenderForeignObject.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::resizerCornerRect): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::invalidateScrollbarRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::localBoundingBox):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::renderer): (WebCore::RenderLayer::renderBox): (WebCore::RenderLayer::renderBoxX): (WebCore::RenderLayer::renderBoxY):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::selectionRectForRepaint):
  • rendering/RenderListMarker.h:
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition): (WebCore::RenderMarquee::timerFired):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containerForRepaint): (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::rectWithOutlineForRepaint): (WebCore::RenderObject::clippedOverflowRectForRepaint): (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::localToContainerQuad):
  • rendering/RenderObject.h: (WebCore::RenderObject::selectionRectForRepaint): (WebCore::RenderObject::outlineBoundsForRepaint):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::clippedOverflowRectForRepaint): (WebCore::RenderPath::outlineBoundsForRepaint):
  • rendering/RenderPath.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRectForRepaint): (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint): (WebCore::RenderSVGContainer::outlineBoundsForRepaint):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::selectionRectForRepaint): (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
  • rendering/RenderSVGText.h:
  • rendering/RenderSelectionInfo.h: (WebCore::RenderSelectionInfoBase::repaintContainer):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::clippedOverflowRectForRepaint): (WebCore::RenderTableCell::computeRectForRepaint): (WebCore::RenderTableCell::localToContainerQuad):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint):
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::clippedOverflowRectForRepaint): (WebCore::RenderText::selectionRectForRepaint):
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/RenderView.cpp: (WebCore::RenderView::localToContainerQuad): (WebCore::RenderView::computeRectForRepaint):
  • rendering/RenderView.h:
06:38 Changeset [40670] by ap@webkit.org
  • 2 edits in trunk/WebCore

Build fix.

  • page/animation/KeyframeAnimation.h: A function prototype had two "fromStyle" arguments.
06:34 Changeset [40669] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-02-05 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Alexey Proskuryakov.
Landed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=23733

Use a 2 arguments constructor for KURL to avoid ASSERT failure.

06:06 Moving to Git edited by treat@kde.org
Flesh out why Git makes code review easier/better (diff)
00:44 Moving to Git edited by mrowe@apple.com
(diff)

02/04/09:

23:27 Changeset [40668] by bfulgham@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-02-04 Feng Qian <feng@chromium.org>

Reviewed by Darin Adler.

Add Android-specific files to WebCore/editing directory.
https://bugs.webkit.org/show_bug.cgi?id=23294

  • editing/android: Added.
  • editing/android/EditorAndroid.cpp: Added. (WebCore::Editor::newGeneralClipboard):
23:23 Changeset [40667] by bfulgham@webkit.org
  • 15 edits in trunk

WebCore:

2009-02-04 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Remove -webkit-animation-play-state
The AnimationController still has the code to execute the property, but
it is no longer parsed or recorded.
https://bugs.webkit.org/show_bug.cgi?id=22907

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseAnimationProperty):
  • css/CSSParser.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSStyleSelector.h:
  • platform/animation/Animation.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

2009-02-04 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler.

Remove animation-play-state from expected properties.
https://bugs.webkit.org/show_bug.cgi?id=22907

  • animations/computed-style-expected.txt:
  • animations/computed-style.html:
  • fast/css/computed-style-display-none-expected.txt:
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • fast/css/computed-style-without-renderer.html:
  • svg/css/getComputedStyle-basic-expected.txt:
22:41 Changeset [40666] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Darin Adler.

Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105

Test: media/remove-from-document-no-load.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

2009-02-04 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Darin Adler.

Make sure we don't load on removing the media element from the document
https://bugs.webkit.org/show_bug.cgi?id=22105.

  • media/remove-from-document-no-load-expected.txt: Added.
  • media/remove-from-document-no-load.html: Added.
22:15 Changeset [40665] by hyatt@apple.com
  • 9 edits
    2 adds in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines. For
now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy. RenderInline remains
derived from RenderBox for now.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::computeRectForRepaint):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: Added. (WebCore::RenderBoxModelObject::RenderBoxModelObject): (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
  • rendering/RenderBoxModelObject.h: Added.
  • rendering/RenderObject.h:
22:07 Changeset [40664] by simon.fraser@apple.com
  • 17 edits
    1 add in trunk/WebCore

2009-02-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Dave Hyatt

Added accelerated animation support to AnimationController and friends. The primary
changes are:

  • accelerated animations get their start time from the compositing engine, so we wait for a callback (notifyAnimationStarted()) in order to get the start time.
  • if software and accelerated animations start in the same cycle, they all need to use the same start time, which is that of the accelerated animations.

Added AnimationControllerPrivate to preserve the encapsulation under
AnimationController.

21:31 Changeset [40663] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver 'the nun' Hunt.

Add -e switch to jsc to enable evaluation of scripts passed on the command line.

  • jsc.cpp: (Script::Script): (runWithScripts): (printUsageStatement): (parseArguments): (jscmain):
21:11 Moving to Git edited by ben@meyerhome.net
(diff)
20:18 Changeset [40662] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Not reviewed, build fix.

Remove duplicate definition of msSans in FontCache::alternateFamilyName.

  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
20:07 Changeset [40661] by dglazkov@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2009-02-04 Dmitry Titov <dimich@chromium.org>

Not reviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=22806
Reverting the test that should not yet be landed since it depends on
changes in DRT which were not yet landed.

  • fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Removed.
  • fast/dom/Window/cached-timeout-stopped-on-close.html: Removed.
  • fast/dom/Window/resources/cached-timeout-page-1.html: Removed.
  • fast/dom/Window/resources/cached-timeout-page-2.html: Removed.
19:40 Changeset [40660] by barraclough@apple.com
  • 3 edits
    4 copies in trunk/JavaScriptCore

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Sam 'Big Mac' Weinig.

  • assembler/AbstractMacroAssembler.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86Common.h: Copied from assembler/MacroAssembler.h.
  • assembler/MacroAssemblerX86_64.h: Copied from assembler/MacroAssembler.h.
19:34 Changeset [40659] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

19:33 Changeset [40658] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.12

New tag.

19:32 Changeset [40657] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

18:40 WebCoreRendering edited by amil.reyes@gmail.com
(diff)
18:01 Changeset [40656] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-02-04 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam Weinig.

This patch tidies up the MacroAssembler, cleaning up the code and refactoring out the
platform-specific parts. The MacroAssembler gets split up like a beef burger, with the
platform-agnostic data types being the lower bun (in the form of the class AbstractMacroAssembler),
the plaform-specific code generation forming a big meaty patty of methods like 'add32',
'branch32', etc (MacroAssemblerX86), and finally topped off with the bun-lid of the
MacroAssembler class itself, providing covenience methods such as the stack peek & poke,
and backwards branch methods, all of which can be described in a platform independent
way using methods from the base class. The AbstractMacroAssembler is templated on the
type of the assembler class that will be used for code generation, and the three layers
are held together with the cocktail stick of inheritance.

The above description is a slight simplification since the MacroAssemblerX86 is actually
formed from two layers (in effect giving us a kind on bacon double cheeseburger) - with the
bulk of methods that are common between x86 & x86-64 implemented in MacroAssemblerX86Common,
which forms a base class for MacroAssemblerX86 and MacroAssemblerX86_64 (which add the methods
specific to the given platform).

I'm landing these changes first without splitting the classes across multiple files,
I will follow up with a second patch to split up the file MacroAssembler.h.

  • assembler/MacroAssembler.h: (JSC::AbstractMacroAssembler::): (JSC::AbstractMacroAssembler::DataLabelPtr::DataLabelPtr): (JSC::AbstractMacroAssembler::DataLabelPtr::patch): (JSC::AbstractMacroAssembler::DataLabel32::DataLabel32): (JSC::AbstractMacroAssembler::DataLabel32::patch): (JSC::AbstractMacroAssembler::Label::Label): (JSC::AbstractMacroAssembler::Jump::Jump): (JSC::AbstractMacroAssembler::Jump::link): (JSC::AbstractMacroAssembler::Jump::linkTo): (JSC::AbstractMacroAssembler::Jump::patch): (JSC::AbstractMacroAssembler::JumpList::link): (JSC::AbstractMacroAssembler::JumpList::linkTo): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::addressOf): (JSC::AbstractMacroAssembler::PatchBuffer::setPtr): (JSC::AbstractMacroAssembler::size): (JSC::AbstractMacroAssembler::copyCode): (JSC::AbstractMacroAssembler::label): (JSC::AbstractMacroAssembler::align): (JSC::AbstractMacroAssembler::differenceBetween): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::load32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::store32WithAddressOffsetPatch): (JSC::MacroAssemblerX86Common::move): (JSC::MacroAssemblerX86Common::swap): (JSC::MacroAssemblerX86Common::signExtend32ToPtr): (JSC::MacroAssemblerX86Common::zeroExtend32ToPtr): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::jump): (JSC::MacroAssemblerX86_64::add32): (JSC::MacroAssemblerX86_64::sub32): (JSC::MacroAssemblerX86_64::load32): (JSC::MacroAssemblerX86_64::store32): (JSC::MacroAssemblerX86_64::addPtr): (JSC::MacroAssemblerX86_64::andPtr): (JSC::MacroAssemblerX86_64::orPtr): (JSC::MacroAssemblerX86_64::rshiftPtr): (JSC::MacroAssemblerX86_64::subPtr): (JSC::MacroAssemblerX86_64::xorPtr): (JSC::MacroAssemblerX86_64::loadPtr): (JSC::MacroAssemblerX86_64::loadPtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::storePtr): (JSC::MacroAssemblerX86_64::storePtrWithAddressOffsetPatch): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::branchPtrWithPatch): (JSC::MacroAssemblerX86_64::storePtrWithPatch): (JSC::MacroAssemblerX86::add32): (JSC::MacroAssemblerX86::sub32): (JSC::MacroAssemblerX86::load32): (JSC::MacroAssemblerX86::store32): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::storePtrWithPatch): (JSC::MacroAssembler::pop): (JSC::MacroAssembler::peek): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::addPtr): (JSC::MacroAssembler::andPtr): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::rshiftPtr): (JSC::MacroAssembler::subPtr): (JSC::MacroAssembler::xorPtr): (JSC::MacroAssembler::loadPtr): (JSC::MacroAssembler::loadPtrWithAddressOffsetPatch): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::storePtrWithAddressOffsetPatch): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchSubPtr):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
17:49 Changeset [40655] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-04 Anders Carlsson <andersca@apple.com>

Build fix fix.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
17:26 Changeset [40654] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

Reverse the meaning of the if check so that Android
(dpad devices) do not scroll on focus and normal platforms do
http://trac.webkit.org/changeset/40647

This was caught by George Staikos, and I wrote the patch.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
17:18 Changeset [40653] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2009-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.


Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.


Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
17:02 Changeset [40652] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):
16:53 Changeset [40651] by hyatt@apple.com
  • 26 edits
    2 deletes in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Eliminate RenderContainer.

Reviewed by Sam and Anders

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::dirtyLineBoxes): (WebCore::RenderBlock::createInlineBox): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::calcInlinePrefWidths): (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState): (WebCore::RenderBlock::localCaretRect):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::virtualChildren): (WebCore::RenderBlock::children):
  • rendering/RenderContainer.cpp: Removed.
  • rendering/RenderContainer.h: Removed.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::nodeAtPoint): (WebCore::RenderFrameSet::layout):
  • rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::virtualChildren): (WebCore::RenderFrameSet::children):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::styleDidChange): (WebCore::nextContinuation): (WebCore::RenderInline::continuationBefore): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::addChildToContinuation): (WebCore::RenderInline::offsetLeft): (WebCore::RenderInline::offsetTop): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::clippedOverflowRectForRepaint): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline):
  • rendering/RenderInline.h: (WebCore::RenderInline::virtualChildren): (WebCore::RenderInline::children): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint): (WebCore::RenderSVGRoot::position):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::virtualChildren): (WebCore::RenderSVGRoot::children):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::removeChild):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::RenderTableCol):
  • rendering/RenderTableCol.h: (WebCore::RenderTableCol::virtualChildren): (WebCore::RenderTableCol::children):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::RenderTableRow): (WebCore::RenderTableRow::destroy): (WebCore::RenderTableRow::styleWillChange): (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::virtualChildren): (WebCore::RenderTableRow::children):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::destroy): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::removeChild): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::virtualChildren): (WebCore::RenderTableSection::children):
16:49 Changeset [40650] by dglazkov@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Rename layout test result to the correct name.

  • storage/transaction-callback-exception-crash-expected.txt: Renamed from LayoutTests/storage/transaction-callback-exception-crash.txt.
16:40 Changeset [40649] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-04 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Fix 64-bit build.


  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame):
16:40 Changeset [40648] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Mads Adger <mad@chromium.org>

Reviewed by Antti Koivisto.

Bug 23180 Reading freed memory at DocumentLoader::checkForPendingPreloads
https://bugs.webkit.org/show_bug.cgi?id=23180

Added a protector for the document potentially holding on the last reference to the loader we are interating with.

  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
16:35 Changeset [40647] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23163
Don't scroll to show current focus on devices that use
directional pads for navigation.

  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
16:31 Changeset [40646] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Darin Adler.

Change RenderBlock::columnGap() access permissions from protected to
public. ANDROID creates an array of focus rectangles for navigation
with a trackball or directional pad, and needs access to the column gap
to implement this logic.

Android has no testing harness @ webkit.org, thus no tests.

  • rendering/RenderBlock.h:
16:27 Changeset [40645] by eric@webkit.org
  • 3 edits in trunk

2009-02-04 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=22917

Add ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL to permit the ANDROID
platform to select all when focusing on a textarea. This matches
the user interface guidelines other applications on the platform.

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
16:19 Changeset [40644] by bdakin@apple.com
  • 4 edits in trunk/WebCore

2009-02-04 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6386112> Some inline-elements are not
becoming proper dashboard-regions

RenderInline needs its own implementation of addDashboardRegions
because otherwise all of the coordinate calculations are
inaccurate.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::addDashboardRegions):
  • rendering/RenderInline.h:
  • rendering/RenderObject.h:
16:12 Changeset [40643] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Move addChild/removeChild from RenderContainer to RenderObject.

Reviewed by Sam Weinig

  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChild):
  • rendering/RenderObject.h: (WebCore::RenderObject::addChildIgnoringContinuation):
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
16:05 Changeset [40642] by beidson@apple.com
  • 8 edits in trunk/WebCore

2009-02-04 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/3541409> - Further HistoryItem / BF cache cleanup

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::restore):
  • history/CachedFrame.h:
  • history/CachedPage.cpp: (WebCore::CachedPage::restore):
  • history/CachedPage.h: (WebCore::CachedPage::mainFrameView):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::isInPageCache):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::open):
16:00 Changeset [40641] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

2009-02-04 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23743
Fix memory corruption with open-source GIF decoders.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache):
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::clear):
15:56 Changeset [40640] by simon.fraser@apple.com
  • 13 edits in trunk/WebCore

2009-02-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23360

When using accelerated compositing, make repaints use the correct
repaint container. Hook up the RenderLayerCompositor in RenderView,
and add to RenderView a method that repaints both the view
contents, and any intersecting composited layers.

Make enclosingCompositingLayer() a method on RenderObject, and update
the compositor to use that. Add a helper method on the compositor to
get the non-self compositing ancestor: ancestorCompositingLayer().

Call repaintRectangleInViewAndCompositedLayers() in places that don't do
container-relative repainting: selection redraw on focus change, caret,
and widget updates.

Fix a bug in RenderLayerCompositor where the m_compositingLayersNeedUpdate flag
would get cleared for partial updates, thus preventing subsequent full updates.

Fix a bug in RenderLayer::ensureBacking() that made new backing every time.

15:55 Changeset [40639] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-02-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

Regression test for https://bugs.webkit.org/show_bug.cgi?id=22753

  • fast/dom/Window/cached-timeout-stopped-on-close-expected.txt: Added.
  • fast/dom/Window/cached-timeout-stopped-on-close.html: Added.
  • fast/dom/Window/resources/cached-timeout-page-1.html: Added.
  • fast/dom/Window/resources/cached-timeout-page-2.html: Added.
15:44 Changeset [40638] by weinig@apple.com
  • 13 edits in trunk/WebCore

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Add toRenderImage methods for casting RenderObjects to RenderImages. The methods will assert if the object
is not a RenderImage. Also add a toRenderImage method that takes a RenderImage but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderImage.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::setImage): (WebCore::ImageLoader::updateFromElement): (WebCore::ImageLoader::notifyFinished):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): (WebCore::AccessibilityRenderObject::addChildren):
  • page/DragController.cpp: (WebCore::getCachedImage): (WebCore::getImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • rendering/RenderImage.h: (WebCore::toRenderImage):
  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::parseMappedAttribute): (WebCore::WMLImageElement::attach):
15:28 Changeset [40637] by ggaren@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Part I of <rdar://problem/6552272>.

Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):

WebKit/win:

2009-02-04 Geoffrey Garen <ggaren@apple.com>

Reviewed by Mark Rowe.


Part I of <rdar://problem/6552272>.

Clear the redirectURLs entry when first visiting a site, so sites that
only redirect you the first time you visit them can later learn that
they don't redirect.

  • WebHistory.cpp: (WebHistory::visitedURL):
15:25 Changeset [40636] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel and Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=20531

Make alternateFamilyName customized for Windows and Chromium.

  • platform/graphics/FontCache.cpp: (WebCore::alternateFamilyName):
15:22 Changeset [40635] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-02-04 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

This comes from Chromium patch (http://codereview.chromium.org/17624).

Add m_disableFontFallback to UniscriberHelper class and set it
to true when filling up glyph pages for non-BMP code points.
When it's set true, UniscriberHelper does not do its own font
fallback. Neither does it do glyph placement. Font fallback
will be taken care of in the simple script font path and glyph
placement is not necessary for simple scripts.

Layout test is missing at the moment due to the lack of freely
distributable font covering a non-BMP code page. A test page
is available at http://i18nl10n.com/webkit/nonbmp2.html

See also https://bugs.webkit.org/show_bug.cgi?id=23602

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillNonBMPGlyphs):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::UniscribeHelper): (WebCore::UniscribeHelper::shape): (WebCore::UniscribeHelper::fillShapes):
  • platform/graphics/chromium/UniscribeHelper.h: (WebCore::UniscribeHelper::setDisableFontFallback):
15:20 Changeset [40634] by weinig@apple.com
  • 8 edits in trunk/WebCore

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Remove some unnecessary #includes of RenderStyle.h

  • css/CSSPrimitiveValueMappings.h:
  • css/SVGCSSComputedStyleDeclaration.cpp:
  • dom/Node.h:
  • rendering/PointerEventsHitRules.h:
  • rendering/RenderImageGeneratedContent.h:
  • rendering/RenderMarquee.h:
  • rendering/RenderScrollbar.h:
14:59 Changeset [40633] by dglazkov@chromium.org
  • 3 edits
    4 deletes in trunk/WebCore

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23657
Clean up WebCore/storage IDLs.

  • storage/SQLError.idl: Changed to match spec.
  • storage/SQLResultSet.idl: Changed to match spec.
  • storage/SQLStatementCallback.idl: Removed.
  • storage/SQLStatementErrorCallback.idl: Removed.
  • storage/SQLTransactionCallback.idl: Removed.
  • storage/SQLTransactionErrorCallback.idl: Removed.
14:52 Changeset [40632] by dglazkov@chromium.org
  • 6 edits
    2 moves in trunk/LayoutTests

2009-02-04 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23655
Clean up storage layout tests a bit.

  • storage/close-during-stress-test.html: Moved brace to new line.
  • storage/empty-statement.html: Moved brace to new line.
  • storage/execute-sql-args.html: Moved brace to new line.
  • storage/quota-tracking.html: Moved brace to new line.
  • storage/success-callback.html: Moved brace to new line, removed erroneous callback argument.
  • storage/transaction-callback-exception-crash.html: Added.
  • storage/transaction-callback-exception-crash.txt: Renamed from LayoutTests/storage/transaction_callback_exception_crash-expected.txt.
  • storage/transaction_callback_exception_crash.html: Removed.
14:34 Changeset [40631] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Change the WebSourceId typedef from int to intptr_t now that <rdar://problem/6263297> is fixed.

<rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for sourceId, not int

Reviewed by Oliver Hunt.

  • WebView/WebScriptDebugDelegate.h:
14:34 Changeset [40630] by timothy@apple.com
  • 6 edits
    2 deletes in trunk/WebKit

Switched over from using the WebSafeForwarder for the Script Debug delegate and added high performance CallScriptDebugDelegate functions.

WebKit:

2009-02-04 Timothy Hatcher <timothy@apple.com>

Removed the WebDefaultScriptDebugDelegate now that we have CallScriptDebugDelegate.

<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate

Reviewed by Oliver Hunt.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-02-04 Timothy Hatcher <timothy@apple.com>

Switched over from using the WebSafeForwarder for the Script Debug
delegate and added high performance CallScriptDebugDelegate functions.

<rdar://problem/6508457> Launching widget in Dashcode debugger is
super-slow due forwardInvocation: calling debug delegate

Reviewed by Oliver Hunt.

  • DefaultDelegates/WebDefaultScriptDebugDelegate.h: Removed.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: Removed.
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::initGlobalCallFrame): Use CallScriptDebugDelegate. (WebScriptDebugger::sourceParsed): Ditto. (WebScriptDebugger::callEvent): Ditto. (WebScriptDebugger::atStatement): Ditto. (WebScriptDebugger::returnEvent): Ditto. (WebScriptDebugger::exception): Ditto.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Removed scriptDebugDelegateForwarder. (-[WebView _cacheScriptDebugDelegateImplementations]): Added. Gets the method implementations for the script debug delegate. Also caches what didParseSource method to use. (WebViewGetScriptDebugDelegateImplementations): Added. Returns the WebScriptDebugDelegateImplementations structure. (-[WebView setScriptDebugDelegate:]): Call _cacheScriptDebugDelegateImplementations. (CallDelegate): Added more overloaded versions that take different arguments. (CallScriptDebugDelegate): Added overloaded versions that take different arguments.
  • WebView/WebViewInternal.h:
14:29 Changeset [40629] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=23734, blank content on blogs.msdn.com.


Add debugging code that will catch the incorrect dirtying of a table section immediately if it happens
during calcRowHeight or layoutRows. This should make it possible to discover future bugs where table sections don't
paint.

The bug in blogs.msdn.com, which was caused by a bad setNeedsLayout in RenderLayer::updateScrollInfoAtferLayout. Make
sure to do only a local setNeedsLayout inside that function.

Reviewed by Beth Dakin

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
  • rendering/RenderObject.h: (WebCore::RenderObject::isSetNeedsLayoutForbidden): (WebCore::RenderObject::setNeedsLayoutIsForbidden): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
14:27 Changeset [40628] by weinig@apple.com
  • 56 edits in trunk/WebCore

2009-02-04 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Rename RenderStyle::Diff to StyleDifference and move it to
RenderStyleConstants.h.

  • rendering/RenderBR.cpp: (WebCore::RenderBR::styleDidChange):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::styleDidChange):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::styleWillChange): (WebCore::RenderButton::styleDidChange):
  • rendering/RenderButton.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::styleDidChange):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::styleDidChange):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange):
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::styleDidChange):
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::styleWillChange): (WebCore::RenderListMarker::styleDidChange):
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::styleDidChange):
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::styleDidChange):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::styleDidChange):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::styleDidChange):
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleWillChange): (WebCore::RenderScrollbarPart::styleDidChange):
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::styleDidChange):
  • rendering/RenderSlider.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleWillChange): (WebCore::RenderTableCell::styleDidChange):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::styleWillChange):
  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::styleDidChange):
  • rendering/RenderText.h: (WebCore::RenderText::styleWillChange):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::styleDidChange):
  • rendering/RenderWidget.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setClip):
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
13:12 Changeset [40627] by sfalken@apple.com
  • 4 edits in branches/Safari-6528/WebKit/win

Merge r40365.

13:08 WikiStart edited by treat@kde.org
(diff)
13:08 UsingGitWithWebKit edited by treat@kde.org
(diff)
13:07 UsingGitWithWebKit edited by treat@kde.org
(diff)
13:04 Changeset [40626] by sfalken@apple.com
  • 3 edits in branches/Safari-6528/WebKit/win

Merge r40511.

13:04 Moving to Git edited by treat@kde.org
My initial brainstorming… (diff)
13:02 Changeset [40625] by weinig@apple.com
  • 30 edits in trunk/WebCore

2009-02-03 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Move PseudoId enum out of RenderStyle and into RenderStyleConstants.h

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass): (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSStyleSelector.h:
  • dom/Node.cpp: (WebCore::Node::diff):
  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
  • rendering/MediaControlElements.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::updateBeforeAfterContent): (WebCore::RenderBlock::firstLineBlock): (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderButton.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::isAfterContent): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createPanel): (WebCore::RenderMedia::createTimelineContainer):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionBackgroundColor): (WebCore::RenderObject::selectionForegroundColor): (WebCore::RenderObject::firstLineStyleSlowCase): (WebCore::RenderObject::getCachedPseudoStyle): (WebCore::RenderObject::getUncachedPseudoStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::isAnonymousBlock):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::destroyLeftoverChildren): (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::pseudoForScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::createThumbStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createResultsButtonStyle): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::createScrollbar):
  • rendering/style/RenderStyle.cpp: (WebCore::pseudoBit):
  • rendering/style/RenderStyle.h: (WebCore::):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
12:58 Changeset [40624] by sfalken@apple.com
  • 3 edits in branches/Safari-6528/WebKit/win

2009-02-04 Steve Falkenburg <sfalken@apple.com>

Merge part of r40470.

2009-01-31 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fixes.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
12:48 Moving to Git created by treat@kde.org
12:47 WikiStart edited by treat@kde.org
Create a new page to coordinate discussion around possibly moving to Git (diff)
11:56 Changeset [40623] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706

<rdar://problem/6509514>

Reviewed by Mark Rowe.

  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Fix it correctly this time. Check for the value returned from WebCore::IconDatabase::iconForPageURL(), not WebCore::Image::data().
11:44 Changeset [40622] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Rename removeFromObjectLists and move it into RenderBox, since it only applies to boxes.

Reviewed by Adam Roben

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists): (WebCore::RenderBox::styleWillChange):
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
  • rendering/RenderObject.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::removeChild):
11:43 Changeset [40621] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix WebCore/ChangeLog date discrepancy.

11:41 Changeset [40620] by dglazkov@chromium.org
  • 5 edits
    4 adds in trunk

WebCore:

2009-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.

Test: fast/css/text-overflow-ellipses.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): Add support for rtl placement. (WebCore::InlineTextBox::paintDecoration): Correctly draw decorations for rtl truncation.

LayoutTests:

2009-02-04 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23471
Fix text-overflow:ellipsis; for RTL case.

Rebaseline LayoutTests/editing/spelling/inline_spelling_markers.html to reflect correct behavior.

  • fast/css/text-overflow-ellipses.html: Added.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.checksum:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
  • platform/mac/fast/css/text-overflow-ellipses-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipses-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipses-expected.txt: Added.
11:06 Changeset [40619] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23700
Upstream local changes to due to unforking of SimpleFontData
(corresponds to Chromium check-in http://src.chromium.org/viewvc/chrome?view=rev&revision=8646).

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs): Removed extra checks for ZWS chars.
10:25 Changeset [40618] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

<rdar://problem/6554115> REGRESSION (r40475): World leak (JS global object) after viewing a photo on Facebook

Fix a ginormous leak. (GINORMOUS!) Make sure to disconnect the event listeners attached to the Document,
because, like, they point to a lot of stuff... like ... everything...

Reviewed by Darin Adler

  • dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes):
10:11 Changeset [40617] by darin@chromium.org
  • 7 edits in trunk/WebCore

2009-02-04 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23731
Add JSCCustom and V8Custom as extended IDL attributes

This helps avoid having to add #ifdefs to the IDL files to support V8 bindings.

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
  • dom/Node.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPointList.idl:
  • svg/SVGTransformList.idl:
10:03 Changeset [40616] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • rendering/RenderImageGeneratedContent.h:
10:01 Changeset [40615] by kevino@webkit.org
  • 8 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Switch to using a ref-counted wxFont pointer for FontPlatformData to fix a crash
with assigning to uninitialized HashTable buckets.

https://bugs.webkit.org/show_bug.cgi?id=23669

09:39 Changeset [40614] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-04 David Hyatt <hyatt@apple.com>

Fix a crash in generated content when a generated image with an already-cached background image gets
created. It's not completely clear how to reproduce this crash.

Reviewed by Adam Roben

  • rendering/RenderImageGeneratedContent.h: (WebCore::RenderImageGeneratedContent::imagePtr):
07:06 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:56 Changeset [40613] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed Qt build fix.

Changed ASSERT(image) to ASSERT(!image.isNull()).

06:23 Changeset [40612] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Trenton Schulz <trenton.schulz@nokia.com>

Reviewed by Simon Hausmann.

Fix implementation of PluginViewMac::invalidateRect to update only the
specified rect, not the entire browser window.

06:04 Changeset [40611] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-04 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber stamped by Mark Rowe.

FramePrivate was removed in r40024 remove the forward
declaration as well.

  • page/Frame.h:
05:37 Changeset [40610] by zecke@webkit.org
  • 5 edits in trunk/WebCore

Make isFrameSet virtual and by default return false, reimplement it in HTMLDocument.

https://bugs.webkit.org/show_bug.cgi?id=23426

01:34 Changeset [40609] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-02-04 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Documented the return value of the evaluateJavaScript() function.

00:55 Changeset [40608] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23681
Worker tests crash in debug builds if run --singly

The crash happened because worker threads continued running while debug-only static objects
were already being destroyed on main thread.

  • runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get destroyed.
  • wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.

02/03/09:

22:58 WebCoreRendering created by amil.reyes@gmail.com
22:55 WikiStart edited by amil.reyes@gmail.com
(diff)
21:24 Changeset [40607] by oliver@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6554092> Slow script dialog starts coming up over and over again

Reviewed by John Sullivan.

Work around <rdar://problem/6554067> by consuming any exceptions that are
thrown by _web_localizedDescription

21:06 Changeset [40606] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Move the isRenderInline checks for clientWidth/Height and scrollWidth/Height to the DOM element
versions of the functions. Since internal render tree usage doesn't ever (incorrectly) call these
functions on RenderInlines, this manages to get virtual function calls out of contentWidth/Height and
availableWidth/Height.

Reviewed by Mark Rowe

  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
20:59 Changeset [40605] by bfulgham@webkit.org
  • 4 edits
    3 adds in trunk

2009-02-03 Brad Garcia <bgarcia@google.com>
Remove call to canResize when trying to determine if pointer
is within a frame.

20:26 Changeset [40604] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Reduce the number of calls to virtualChildren (indirectly made via RenderObject::firstChild()).
This is a small gain on the PLT.

Reviewed by Mark Rowe

  • rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::bidiNext):
20:24 Changeset [40603] by mrowe@apple.com
  • 1 edit in branches/Safari-6528/WebKit/win/WebHistoryItem.cpp

Merge r40394.

20:24 Changeset [40602] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40392.

20:23 Changeset [40601] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40529.

20:23 Changeset [40600] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40528.

20:23 Changeset [40599] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40516.

20:23 Changeset [40598] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Merge r40514.

20:23 Changeset [40597] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40511.

20:23 Changeset [40596] by mrowe@apple.com
  • 37 edits in branches/Safari-6528

Merge r40508.

20:23 Changeset [40595] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebKit/win

Merge r40503.

20:23 Changeset [40594] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebKit

Merge r40382.

20:23 Changeset [40593] by mrowe@apple.com
  • 10 edits in branches/Safari-6528

Merge r40380.

20:23 Changeset [40592] by mrowe@apple.com
  • 9 edits in branches/Safari-6528/WebKit

Merge r40436.

20:23 Changeset [40591] by mrowe@apple.com
  • 16 edits in branches/Safari-6528

Merge r40432.

20:23 Changeset [40590] by mrowe@apple.com
  • 10 edits
    55 adds in branches/Safari-6528

Merge r40424.

20:22 Changeset [40589] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40376.

20:22 Changeset [40588] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40373.

20:22 Changeset [40587] by mrowe@apple.com
  • 9 edits in branches/Safari-6528

Merge r40353.

20:22 Changeset [40586] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40558.

20:22 Changeset [40585] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-6528

Merge r40541.

20:22 Changeset [40584] by mrowe@apple.com
  • 3 edits
    3 adds in branches/Safari-6528

Merge r40522.

20:22 Changeset [40583] by mrowe@apple.com
  • 5 edits in branches/Safari-6528/WebCore

Merge r40472.

20:22 Changeset [40582] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKitLibraries

Merge r40448.

20:22 Changeset [40581] by mrowe@apple.com
  • 6 edits in branches/Safari-6528

Merge r40397.

20:22 Changeset [40580] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40396.

20:22 Changeset [40579] by mrowe@apple.com
  • 5 edits
    2 copies
    5 adds in branches/Safari-6528

Merge r40368.

20:22 Changeset [40578] by mrowe@apple.com
  • 11 edits in branches/Safari-6528

Merge r40366.

20:21 Changeset [40577] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40358.

20:21 Changeset [40576] by mrowe@apple.com
  • 3 edits
    7 adds in branches/Safari-6528

Merge r40356.

20:21 Changeset [40575] by mrowe@apple.com
  • 6 edits
    1 copy
    2 adds in branches/Safari-6528

Merge r40355.

20:21 Changeset [40574] by mrowe@apple.com
  • 24 edits in branches/Safari-6528

Merge r40354.

20:21 Changeset [40573] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Merge r40345.

20:21 Changeset [40572] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40343.

20:21 Changeset [40571] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40339.

20:21 Changeset [40570] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40335.

20:21 Changeset [40569] by mrowe@apple.com
  • 13 edits
    3 adds in branches/Safari-6528

Merge r40332.

20:21 Changeset [40568] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40313.

20:21 Changeset [40567] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40305.

20:20 Changeset [40566] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40304.

18:45 Changeset [40565] by simon.fraser@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in Changelog

18:41 Changeset [40564] by simon.fraser@apple.com
  • 19 edits
    1 add in trunk/WebCore

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23628

Fix selection repainting to do container-relative repaints. RenderView now
repaints the seleciton using the containerForRepaint() for each RenderSelectionInfo.
selectionRect() is now a wrapper for selectionRectForRepaint() with no container.

Pull SelectionInfo out of RenderObject.h, and BlockSelectionInfo out
of RenderBlock.h and move them into RenderSelectionInfo.h, with some
sharing and refactoring.

RenderBlock::selectionGapRectsForRepaint() is not yet container-aware.

18:06 Changeset [40563] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Add inline capacity back to CSSMutableStyleDeclaration now that the bug in Vector has been fixed.

Reviewed by Darin Adler & Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
18:02 Changeset [40562] by barraclough@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-02-03 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=23715

Simplify MacroAssembler interface, by combining comparison methods.
Seprate operations are combined as follows:

jz32/jnz32/jzPtr/jnzPtr -> branchTest32/branchTestPtr,
j*(Add|Mul|Sub)32/j*(Add|Mul|Sub)Ptr -> branch(Add|Mul|Sub)32/branch(Add|Mul|Sub)Ptr
j*32/j*Ptr (all other two op combparisons) -> branch32/brnachPtr
set*32 -> set32

Also, represent the Scale of BaseIndex addresses as a plain enum (0,1,2,3),
instead of as multiplicands (1,2,4,8).

This patch singificantly reduces replication of code, and increases functionality supported
by the MacroAssembler. No performance impact.

  • assembler/MacroAssembler.h: (JSC::MacroAssembler::): (JSC::MacroAssembler::branchPtr): (JSC::MacroAssembler::branchPtrWithPatch): (JSC::MacroAssembler::branch32): (JSC::MacroAssembler::branch16): (JSC::MacroAssembler::branchTestPtr): (JSC::MacroAssembler::branchTest32): (JSC::MacroAssembler::branchAddPtr): (JSC::MacroAssembler::branchAdd32): (JSC::MacroAssembler::branchMul32): (JSC::MacroAssembler::branchSubPtr): (JSC::MacroAssembler::branchSub32): (JSC::MacroAssembler::set32): (JSC::MacroAssembler::setTest32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::jccRel32): (JSC::X86Assembler::setccOpcode): (JSC::X86Assembler::cmpq_mr): (JSC::X86Assembler::setcc_r): (JSC::X86Assembler::sete_r): (JSC::X86Assembler::setne_r): (JSC::X86Assembler::jne): (JSC::X86Assembler::je): (JSC::X86Assembler::jl): (JSC::X86Assembler::jb): (JSC::X86Assembler::jle): (JSC::X86Assembler::jbe): (JSC::X86Assembler::jge): (JSC::X86Assembler::jg): (JSC::X86Assembler::ja): (JSC::X86Assembler::jae): (JSC::X86Assembler::jo): (JSC::X86Assembler::jp): (JSC::X86Assembler::js): (JSC::X86Assembler::jcc): (JSC::X86Assembler::X86InstructionFormatter::putModRmSib):
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::checkStructure): (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber): (JSC::JIT::emitJumpIfImmediateInteger): (JSC::JIT::emitJumpIfNotImmediateInteger): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoadCharacter): (JSC::WREC::Generator::generateJumpIfNotEndOfInput): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference):
17:52 Changeset [40561] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-03 David Hyatt <hyatt@apple.com>

Fix a bug in Vector's shrinkCapacity method. It did not properly copy elements into the inline buffer
when shrinking down from a size that was greater than the inline capacity.

Reviewed by Maciej

  • wtf/Vector.h: (WTF::VectorBuffer::VectorBuffer): (WTF::VectorBuffer::allocateBuffer):
17:18 Changeset [40560] by justin.garcia@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)


Determine whether or not to use HTML formatting tags for styling on the new
boolean on Editor instead of whether or not the document is quirks mode.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyTextDecorationStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/Editor.cpp: (WebCore::Editor::Editor): (WebCore::Editor::clear):
  • editing/Editor.h: (WebCore::Editor::setShouldStyleWithCSS): (WebCore::Editor::shouldStyleWithCSS):
  • editing/EditorCommand.cpp: (WebCore::executeStyleWithCSS): (WebCore::stateStyleWithCSS): (WebCore::CommandEntry::):

LayoutTests:

2009-02-03 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=13490
Implement execCommand("styleWithCSS", ...)

  • editing/execCommand/5685604-1-expected.txt: Added.
  • editing/execCommand/5685604-1.html: Added.
17:05 Changeset [40559] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig.

This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
16:55 Changeset [40558] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

  • Fix for <rdar://problem/6549743>

On Tiger, create an autorelease pool before creating the NSGraphicsContext and drain it immediately
after the call to -[NSView displayRectIgnoringOpacity:inContext:].


  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
16:46 Changeset [40557] by kevino@webkit.org
  • 1 edit in trunk/WebKitTools/ChangeLog

ChangeLog date fix.

16:39 Changeset [40556] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Change the way wxWidgets build gets arguments.
Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
removed when --wx is checked for).

https://bugs.webkit.org/show_bug.cgi?id=23701

16:31 Changeset [40555] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Back this change out since it is causing layout tests to crash. There is something subtle going on
here.

Reviewed by Darin Adler

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:57 Changeset [40554] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Give the properties vector of mutable style declarations an initial inline capacity to reduce malloc churn.

Reviewed by Sam Weinig

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
15:56 Changeset [40553] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Avoid creating extra copies of NSURLRequests for non-HTTP URLs. Only mark platform requests
as needing updating when HTTP fields change if the scheme of the URL is actually HTTP or HTTPS.
Thus cuts down significantly on the number of copied NSURLRequests and is about a 1% gain on the PLT.

Reviewed by Darin Adler

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/KURL.cpp: (WebCore::KURL::invalidate): (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::isHTTPOrHTTPS):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::setAllowHTTPCookies):
15:53 Changeset [40552] by bfulgham@webkit.org
  • 3 edits in trunk/LayoutTests

Commit test cases for https://bugs.webkit.org/show_bug.cgi?id=23178.

15:25 Changeset [40551] by zecke@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Add manual test for floating divs with scrollbars.

  • manual-tests/gtk/floatingdiv.html: Added.
15:25 Changeset [40550] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

There's no need to hold an extra ref to the scrollbar, calling
setPlatformWidget takes ownership of it.

Also do not disconnect the signals when destroying the widget,
it's superfluous.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk):
15:25 Changeset [40549] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Declare scrollBar as GtkWidget* to avoid needless
casting.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::ScrollbarGtk): (ScrollbarGtk::~ScrollbarGtk):
15:25 Changeset [40548] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=23711

Properly calculate the scrollbar location for their
usage in RenderLayout.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
14:14 Changeset [40547] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-02-03 David Hyatt <hyatt@apple.com>

Rename addLineBoxRects to absoluteRectsForRange, and do the same thing for the corresponding quads methods. Move the RenderContainer implementations
of these methods up to RenderObject.


Reviewed by Beth Dakin

  • bindings/objc/DOM.mm: (-[DOMNode lineBoxRects]):
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
  • rendering/RenderContainer.cpp:
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuadsForRange):
  • rendering/RenderText.h:
13:26 Changeset [40546] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Sam Weinig and Oliver Hunt.

Added getImageData() support for QtWebKit.

[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::getImageData):
13:00 Changeset [40545] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Eric Roman <eroman@chromium.org>

Reviewed by Holger Freyther.

Fix FrameChromium.cpp following r40473 which moved Frame::adjustPageHeight to FrameView::adjustPageHeight.

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
12:43 Changeset [40544] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-02-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23358

Hook accelerated compositing into RenderLayer.

12:14 Changeset [40543] by simon.fraser@apple.com
  • 19 edits in trunk

2009-02-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23365

Hook up accelerated compositing layers the native
view system on Mac.

11:51 Changeset [40542] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Hans Peter Freyther.

Fixed getImageData and putImageData and respect pre-
multiplied colors.

Cairo's ImageBuffer::getImageData() does not handle alpha=0 case correctly
https://bugs.webkit.org/show_bug.cgi?id=21575

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
11:49 Changeset [40541] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Brady Eidson.

  • fix <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)

Test: fast/history/window-open.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the missing lockBackForwardList parameter to FrameLoader::changeLocation().

LayoutTests:

Reviewed by Brady Eidson.

  • test for <rdar://problem/6550530> REGRESSION (r40508): Window opened with window.open has no initial history item (global and back/forward)
  • fast/history/window-open-expected.txt: Added.
  • fast/history/window-open.html: Added.
11:40 Changeset [40540] by zecke@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22988
[GTK] Need a public method to add a WebKitWebHistoryItem to
WebKitWebBackForwardList.

Wrap WebCore::BackForwardList::addItem.

  • tests/main.c: (test_webkit_web_back_forward_list_add_item): (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
  • webkit/webkitwebbackforwardlist.h:
09:46 Changeset [40539] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-03 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build after r40536.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertQVariantToValue):
09:41 Changeset [40538] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix -Wmissing-prototypes builds
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidSendData): Marked this function static. (WebCore::workerContextDidReceiveResponse): Ditto. (WebCore::workerContextDidReceiveData): Ditto. (WebCore::workerContextDidFinishLoading): Ditto. (WebCore::workerContextDidFail): Ditto. (WebCore::workerContextDidGetCancelled): Ditto. (WebCore::workerContextDidReceiveAuthenticationCancellation): Ditto.
09:29 Changeset [40537] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

CrashTracer: [REGRESSION] 53 crashes in Safari at com.apple.WebCore: WebCore::LegacyWebArchive::create + 2706

<rdar://problem/6509514>

Reviewed by Adam Roben.

  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Null check the value returned from WebCore::IconDatabase::iconForPageURL().
08:10 Changeset [40536] by hausmann@webkit.org
  • 6 edits in trunk

JavaScriptCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added accessor for JSByteArray storage.

WebCore:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix conversion of QByteArray to JavaScript and back. Instead of
converting it to a String (data loss!) we now map it to JSByteArray.

WebKit/qt:

2009-02-03 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Added a unit test to verify the succesful conversion from QByteArray to
JSByteArray and back to QByteArray.

07:44 Changeset [40535] by ap@webkit.org
  • 2 edits in trunk/WebCore

Build fix.

  • GNUmakefile.am: Removed WorkerTask.{h,cpp}.
02:32 Changeset [40534] by ap@webkit.org
  • 11 edits
    3 adds in trunk

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22718
Implement WindowTimers interface in Workers.

This patch moves timeoutID from Document to ScriptExecutionContext
and exposes JS methods setTimeout/setInterval/clearTimeout/clearInterval inside of a Worker.
Also added a test for those methods.

Test: fast/workers/worker-timeout.html

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::setTimeoutOrInterval): Creates ScheduledAction and calls WorkerContext::installTimeout to actually add a timer.

(WebCore::JSWorkerContext::setTimeout):
(WebCore::JSWorkerContext::clearTimeout):
(WebCore::JSWorkerContext::setInterval):
(WebCore::JSWorkerContext::clearInterval):
Added methods exposed to JS.

  • dom/Document.cpp:
  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::addTimeout): (WebCore::ScriptExecutionContext::removeTimeout): (WebCore::ScriptExecutionContext::findTimeout):
  • dom/ScriptExecutionContext.h: The timerID map moves from Document to ScriptExecutionContext, to be available to Document and to WorkerContext.
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::installTimeout): Adds a DOMTimeout. (WebCore::WorkerContext::removeTimeout): Removes a DOMTimeout.
  • dom/WorkerContext.h:
  • page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::~DOMTimer): (WebCore::DOMTimer::removeById): Code change here reflects move of timeoutID map to the ScriptExecutionContext. Some checks and casts are no longer needed.
01:18 Changeset [40533] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer on WorkerRunLoop

  • JavaScriptCore.exp: Forgot to expose ThreadCondition::timedWait() in one of previous patches.
01:11 Changeset [40532] by ap@webkit.org
  • 3 edits in trunk/WebCore

2009-02-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23560
Implement SharedTimer for Workers.

  • dom/WorkerRunLoop.cpp: Added private class WorkerSharedTimer that implements SharedTimer interface for worker threads. (WebCore::WorkerSharedTimer::WorkerSharedTimer): (WebCore::WorkerSharedTimer::setFiredFunction): (WebCore::WorkerSharedTimer::setFireTime): (WebCore::WorkerSharedTimer::stop): (WebCore::WorkerSharedTimer::isActive): (WebCore::WorkerSharedTimer::fireTime): (WebCore::WorkerSharedTimer::fire): (WebCore::WorkerRunLoop::WorkerRunLoop): Initializes a WorkerSharedTimer instance. (WebCore::WorkerRunLoop::~WorkerRunLoop): The destructor is here so compiler is ok with having OwnPtr<WorkerSharedTimer> in .h file w/o defining WorkerSharedTimer. (WebCore::WorkerRunLoop::run): Set/reset shared timer interface on ThreadTimers, use MessageQueue::waitForMessageTimed() if timer is active.
  • dom/WorkerRunLoop.h: Add member of type OwnPtr<WorkerSharedTimer>
00:57 Changeset [40531] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2009-02-03 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:24 Changeset [40530] by ap@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix.

  • dom/CrossThreadCopier.h: Changed forward declarations to use struct instead of class where appropriate.
00:05 Changeset [40529] by ggaren@apple.com
  • 2 edits in trunk/WebKit/win

2009-02-03 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • WebHistory.cpp: (WebHistory::visitedURL):
Note: See TracTimeline for information about the timeline view.