Timeline



Feb 16, 2009:

7:38 PM Changeset in webkit [41036] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r41022 as it breaks qt and gtk builds

7:38 PM Changeset in webkit [41035] by Beth Dakin
  • 3 edits in trunk/WebCore

2009-02-16 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6386623>

I made m_numParsedProperties and m_maxParsedProperties unsigned
instead of int, and then added an early return from addPropery() if
m_maxParsedProperties exceeds the max value.

  • css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::deleteFontFaceOnlyValues):
  • css/CSSParser.h:
7:36 PM Changeset in webkit [41034] by justin.garcia@apple.com
  • 7 edits
    1 add
    3 deletes in trunk

WebCore:

2009-02-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored


When we originally implemented this command, MSDN documentation said that IE set the
id attribute of inserted lists to the third argument to execCommand, but IE doesn't
do this nor do any other browsers.

  • editing/EditorCommand.cpp: (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::create):

LayoutTests:

2009-02-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Mark Rowe.


​https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored

  • editing/execCommand/insert-list-with-id-expected.txt: Added.
  • editing/execCommand/insert-list-with-id.html:
  • platform/mac/editing/execCommand/insert-list-with-id-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.png: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.txt: Removed.
6:59 PM Changeset in webkit [41033] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-16 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Adam Roben

Actually use the installation prefix defined in WebKitInstallationPrefix,
in autotools builds.

  • Scripts/webkitdirs.pm:
6:00 PM Changeset in webkit [41032] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

5:59 PM Changeset in webkit [41031] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.15.1

New tag.

5:56 PM Changeset in webkit [41030] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

5:56 PM Changeset in webkit [41029] by mrowe@apple.com
  • 3 edits
    4 adds in branches/Safari-6528

Merge r41027.

4:40 PM Changeset in webkit [41028] by weinig@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-02-16 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

No performance regression.

  • runtime/Arguments.cpp: (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been overridden.

LayoutTests:

2009-02-16 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add tests for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

  • fast/js/function-apply-expected.txt:
  • fast/js/resources/function-apply.js: Add cases covering setting arugments.length and Array.length explicitly or implicitly using Array.prototype.unshift.
3:56 PM Changeset in webkit [41027] by mitz@apple.com
  • 3 edits
    1 copy
    3 adds in trunk

WebCore:

Reviewed by Geoffrey Garen.

  • fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse

Test: platform/mac/fast/events/pointer-events-dashboard.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Do not apply the pointer-events property in Dashboard backwards compatibility mode, in order to work around misuse of that property by the Stocks widget.

LayoutTests:

Reviewed by Geoffrey Garen.

  • test for <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
  • platform/mac/fast/events/pointer-events-dashboard-expected.checksum: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.png: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.txt: Added.
  • platform/mac/fast/events/pointer-events-dashboard.html: Copied from LayoutTests/fast/events/pointer-events.html.
3:33 PM Changeset in webkit [41026] by justin.garcia@apple.com
  • 4 edits
    3 adds
    3 deletes in trunk

WebCore:

2009-02-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just the body element, but any root editable element.

LayoutTests:

2009-02-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Eric Seidel.


​https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/execCommand/15381-expected.txt: Added.
  • editing/execCommand/15381.html: Added.


Made this test cross platform and changed it to reflect the fix:

  • editing/execCommand/5062376-expected.txt: Added.
  • editing/execCommand/5062376.html:
  • platform/mac/editing/execCommand/5062376-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5062376-expected.png: Removed.
  • platform/mac/editing/execCommand/5062376-expected.txt: Removed.
3:19 PM Changeset in webkit [41025] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 23979: AX: alt tag not returned for <input type="image">
​https://bugs.webkit.org/show_bug.cgi?id=23979

2:36 PM Changeset in webkit [41024] by mrowe@apple.com
  • 2 edits in tags/Safari-6530/JavaScriptCore

Merge r41023.

2:23 PM Changeset in webkit [41023] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

2:15 PM Changeset in webkit [41022] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 23787: Allow JIT to generate SSE2 code if using GCC
<​https://bugs.webkit.org/show_bug.cgi?id=23787>

Provided by Csaba Osztrogonac
Reviewed by Oliver Hunt

GCC version of the cpuid check.

2:06 PM Changeset in webkit [41021] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

The ref data is not properly set unless we use the CreateMatrix function.

​https://bugs.webkit.org/show_bug.cgi?id=23978

1:57 PM Changeset in webkit [41020] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
  • platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the FontPlatformData(float, bool, bool) constructor.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData): Changed to pass a valid NSFont to the FontPlatformData constructor, instead of implicitly passing 0 and then calling setFont().
  • platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter of the constructor mandatory.
2:57 AM Changeset in webkit [41019] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-02-16 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Avoid loading plugins when they're disabled in the settings.

Feb 15, 2009:

1:39 PM Changeset in webkit [41018] by ddkilzer@apple.com
  • 5 edits in trunk/WebCore

Move duplicate caretWidth constants to RenderObject.h

Reviewed by Dan Bernstein.

No test since no change in behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect): Ditto.
  • rendering/RenderObject.h: Added caretWidth definition.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Removed caretWidth.

Feb 14, 2009:

8:39 AM Changeset in webkit [41017] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23955
V8HTMLPlugInCustom returns undefined, which fools interceptors.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.

Feb 13, 2009:

6:17 PM Changeset in webkit [41016] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-02-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23954
Add V8 custom bindings for CanvasRenderingContext2D.

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Added. (WebCore::toV8): (WebCore::toCanvasStyle): (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER):
6:05 PM Changeset in webkit [41015] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

6:05 PM Changeset in webkit [41014] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.15

New tag.

5:48 PM Changeset in webkit [41013] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-13 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=23960
Crash Fix.

Don't depend on 'initializeThreading()' to come before a call to 'isMainThread()'
as QtWebKit only calls 'initializeThreading()' during QWebPage construction.

A client app may well make a call to QWebSettings::iconForUrl() for instance
before creating a QWebPage and that call to QWebSettings triggers an
ASSERT(isMainThread()) deep within WebCore.

  • wtf/ThreadingQt.cpp: (WTF::isMainThread):
5:19 PM Changeset in webkit [41012] by mrowe@apple.com
  • 3 edits in branches/Safari-6528/JavaScriptCore

Merge r40975.

5:19 PM Changeset in webkit [41011] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40945.

5:08 PM Changeset in webkit [41010] by mrowe@apple.com
  • 3 edits in branches/Safari-6528/JavaScriptCore

Merge r41000.

5:08 PM Changeset in webkit [41009] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40995.

5:08 PM Changeset in webkit [41008] by mrowe@apple.com
  • 13 edits
    3 adds in branches/Safari-6528

Merge r40993.

5:08 PM Changeset in webkit [41007] by mrowe@apple.com
  • 5 edits in branches/Safari-6528/JavaScriptCore

Merge r40968.

5:08 PM Changeset in webkit [41006] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40967.

5:08 PM Changeset in webkit [41005] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40937.

5:08 PM Changeset in webkit [41004] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40935.

5:08 PM Changeset in webkit [41003] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/JavaScriptCore

Merge r40932.

5:08 PM Changeset in webkit [41002] by mrowe@apple.com
  • 3 edits in branches/Safari-6528/WebKit/mac

Merge r40940.

5:08 PM Changeset in webkit [41001] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/mac

Merge r40920.

5:00 PM Changeset in webkit [41000] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-02-13 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Darin Adler.

Some data in the instruction stream is potentially uninitialized - fix this.

Change the OperandTypes constructor so that uninitialized memory in the int
is zeroed, and modify the Instruction constructor taking an Opcode so that
if !HAVE(COMPUTED_GOTO) (i.e. when Opcode is an enum, and is potentially only
a byte) it zeros the Instruction first before writing the opcode.

  • bytecode/Instruction.h: (JSC::Instruction::Instruction):
  • parser/ResultType.h: (JSC::OperandTypes::OperandTypes):
4:46 PM Changeset in webkit [40999] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/editing/deleting

Fix failing layout pixel test so bdash doesn't come to my house in the middle of the night and beat me up.

4:41 PM Changeset in webkit [40998] by andersca@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

4:35 PM Changeset in webkit [40997] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6583187>


  • page/NavigatorBase.cpp: Handle PPC64 and X86_64 as well.
4:04 PM Changeset in webkit [40996] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6584834> ESPN radio live stream link hangs Safari

When a plug-in invokes JavaScript code that will destroy the plug-in, we need to
defer destruction until we're done executing the script.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::PluginDestroyDeferrer::PluginDestroyDeferrer): (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer): Add a simple RAII object for deferring destruction of the plug-in instance.


(WKPCEvaluate):
(WKPCInvoke):
(WKPCInvokeDefault):
(WKPCConstruct):
(WKPCGetProperty):
(WKPCSetProperty):
(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
Use the PluginDestroyDeferrer.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::pluginID): Assert that the plug-in ID is not 0 here.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize the call depth.


(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Set the plug-in ID to 0 to aid debugging.


(WebKit::NetscapePluginInstanceProxy::willCallPluginFunction):
Increment the call depth.


(WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
Decrement the call depth, if it's 0 and we should stop the plug-in, do so.


(WebKit::NetscapePluginInstanceProxy::shouldStop):
If we're called this with a non-zero call depth, set shouldStopSoon to true.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView shouldStop]): Call the proxy.
4:01 PM Changeset in webkit [40995] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-13 Geoffrey Garen <​ggaren@apple.com>

Build fix for non_JIT platforms.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::setIsNumericCompareFunction): (JSC::CodeBlock::isNumericCompareFunction):
3:56 PM Changeset in webkit [40994] by Darin Adler
  • 2 edits in trunk/WebCore

2009-02-13 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Fix broken tokenizer regression test that reflected a lifetime bug
in the document.write optimization. The test failure was trivial to
reproduce in COLLECT_ON_EVERY_ALLOCATION mode.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite): Convert strings to String rather than passing the pointer and length to SegmentedString. The optimization is thus mostly gone. However, there are two ways to bring it back: 1) Apply the patch that makes UString and String share the same buffers. 2) Add a UString feature to SegmentedString; simple to do but might risk slowing down normal document parsing.
3:28 PM Changeset in webkit [40993] by ggaren@apple.com
  • 13 edits
    3 adds in trunk

JavaScriptCore:

2009-02-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/6584057> Optimize sort by JS numeric comparison
function not to run the comparison function


  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::setIsNumericCompareFunction): (JSC::CodeBlock::isNumericCompareFunction): Added the ability to track whether a CodeBlock performs a sort-like numeric comparison.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Set the isNumericCompareFunction bit after compiling.
  • parser/Nodes.cpp: (JSC::FunctionBodyNode::emitBytecode): Fixed a bug that caused us to codegen an extra return at the end of all functions (eek!), since this made it harder / weirder to detect the numeric comparison pattern in bytecode.
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSort): Use the isNumericCompareFunction bit to do a faster sort if we can.
  • runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): (JSC::constructFunction):
  • runtime/FunctionConstructor.h: Renamed and exported extractFunctionBody for use in initializing lazyNumericCompareFunction.
  • runtime/JSArray.cpp: (JSC::compareNumbersForQSort): (JSC::compareByStringPairForQSort): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort):
  • runtime/JSArray.h: Added a fast numeric sort. Renamed ArrayQSortPair to be more specific since we do different kinds of qsort now.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::numericCompareFunction): (JSC::JSGlobalData::ClientData::~ClientData):
  • runtime/JSGlobalData.h: Added helper data for computing the isNumericCompareFunction bit.

LayoutTests:

2009-02-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added a test for an edge case in <rdar://problem/6584057>.

  • fast/js/resources/sort-non-numbers.js: Added.
  • fast/js/sort-non-numbers.html: Added.
  • fast/js/sort-non-numbers-expected.txt: Added.
2:49 PM Changeset in webkit [40992] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-13 Adam Treat <​adam.treat@torchmobile.com>

Caught by Darin Adler.

No reason to check m_tokenizer twice for 0 in a row.

  • dom/Document.cpp: (WebCore::Document::write):
1:49 PM Changeset in webkit [40991] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-13 Lyon Chen <​lyon.chen@torchmobile.com>

Reviewed by Dave Hyatt.

Take into account y() + height() when calculating getLowerRightCorner.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
1:17 PM Changeset in webkit [40990] by Antti Koivisto
  • 3 edits in trunk/WebCore

2009-02-13 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

Most of this code was in RenderBox, restore the copyright lines.

  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
1:07 PM Changeset in webkit [40989] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Get rid of printBoxDecorations, since it is dead code.

Reviewed by Dan Bernstein

  • rendering/RenderObject.h:
1:01 PM Changeset in webkit [40988] by treat@webkit.org
  • 4 edits in trunk/WebCore

2009-02-13 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23952
Add Document::write overload which takes a SegmentedString since this
is what the tokenizer expects anyway. Modified JSHTMLDocument so it once
again calls Document::write instead of injecting the string directly into
the tokenizer. This ensures that all document.write's are funneled through
one method again, but should still be just as fast for JSHTMLDocumentCustom.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/Document.h:
12:38 PM Changeset in webkit [40987] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser

Remove updateWidgetPosition on RenderObject. Change RenderView's set of widgets
to have a tighter type: RenderWidget instead of RenderObject. Devirtualize
updateWidgetPosition, since all RenderWidgets (except for applets) are now
RenderParts also.


  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderPart.cpp:
  • rendering/RenderPart.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
  • rendering/RenderWidget.h:
12:11 PM Changeset in webkit [40986] by Darin Adler
  • 2 edits in trunk/WebKit

2009-02-13 Darin Adler <Darin Adler>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
12:04 PM Changeset in webkit [40985] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

Remove isEditable() on RenderObject. It is dead code.

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
11:49 AM Changeset in webkit [40984] by hyatt@apple.com
  • 13 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

Add isTextControl() to RenderObject. Patch call sites thats asked isTextField()
isTextArea() to just use

isTextControl() instead.


Add a toRenderTextControl converter for doing checked casting to RenderTextControls.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleReplacedElement):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::selection):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::select): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::appendFormData): (WebCore::HTMLTextAreaElement::updateValue): (WebCore::HTMLTextAreaElement::selection):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isNativeTextControl): (WebCore::AccessibilityRenderObject::text): (WebCore::AccessibilityRenderObject::selectedText): (WebCore::AccessibilityRenderObject::selectedTextRange): (WebCore::AccessibilityRenderObject::setSelectedTextRange): (WebCore::AccessibilityRenderObject::visiblePositionForIndex): (WebCore::AccessibilityRenderObject::indexForVisiblePosition): (WebCore::AccessibilityRenderObject::observableObject):
  • page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange):
  • rendering/RenderObject.h: (WebCore::RenderObject::isTextControl): (WebCore::objectIsRelayoutBoundary):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::isTextControl): (WebCore::toRenderTextControl):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::select): (WebCore::WMLInputElement::defaultEventHandler): (WebCore::WMLInputElement::isConformedToInputMask):
11:18 AM Changeset in webkit [40983] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Get rid of isEdited/setEdited on RenderObject. Devirtualize isEdited/setEdited on RenderTextControl.
Callers were already asking if the renderer was a text field (or a text area), so it was especially
pointless to waste a second virtual function call after making one just to determine the object type.


Reviewed by Simon Fraser

  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::isEdited): (WebCore::RenderTextControl::setEdited):
11:04 AM Changeset in webkit [40982] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-02-13 Scott Violet <​sky@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23934
Skia platform doesn't render text decoration shadows.

Makes Skia render text decoration shadows correctly. We weren't
preparing the SkPaint correctly and didn't have a couple of checks
CG has. Additionally makes the fillColor/strokeColor methods
consistent.

This behavior is covered by existing layout tests (see bug for list).

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::effectiveFillColor): (PlatformContextSkia::effectiveStrokeColor):
  • platform/graphics/skia/PlatformContextSkia.h:
11:01 AM Changeset in webkit [40981] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-12 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23944
KURLGoogle's pre-parsed canonicalSpec constructor should take a CString

  • platform/KURL.h:
  • platform/KURLGoogle.cpp: (WebCore::KURLGooglePrivate::setUtf8): (WebCore::KURLGooglePrivate::setAscii): (WebCore::KURLGooglePrivate::init): (WebCore::KURLGooglePrivate::replaceComponents): (WebCore::KURL::KURL):
  • platform/KURLGooglePrivate.h:
10:17 AM Changeset in webkit [40980] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2009-02-13 David Hyatt <​hyatt@apple.com>

Remove leftmost/rightmost/lowestPosition from RenderObject. They only need to be called on boxes.

Reviewed by Dan Bernstein

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::computeScrollDimensions):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
9:49 AM Changeset in webkit [40979] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Fix build with ACCELERATED_COMPOSITING turned on.

toRenderBox()->x() asserts for a layer on an inline; use
m_owningLayer->renderBoxX() instead.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
8:24 AM Changeset in webkit [40978] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-02-13 Darin Adler <Darin Adler>

  • Configurations/JavaScriptCore.xcconfig: Undo accidental commit of this file.
8:21 AM Changeset in webkit [40977] by cmarrin@apple.com
  • 4 edits in trunk/LayoutTests

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=23936

Fixed 3 more test cases

  • platform/win/fast/css/computed-style-expected.txt:
  • platform/win/fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
8:20 AM Changeset in webkit [40976] by Darin Adler
  • 4 edits in trunk/WebCore

2009-02-12 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Speed up document.write a bit.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite): Added. Uses SegmentedString to avoid conversion from UString to String and to avoid appending strings. Also added code to handle newlines efficiently. (WebCore::JSHTMLDocument::write): Changed to use documentWrite. (WebCore::JSHTMLDocument::writeln): Ditto.
  • dom/Document.cpp: (WebCore::Document::prepareToWrite): Added. Refactored the initialization part of write into a separate function for use in the JavaScript binding. (WebCore::Document::write): Changed to call prepareToWrite.
  • dom/Document.h: Added declaration for prepareToWrite.
8:16 AM Changeset in webkit [40975] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2009-02-12 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt and Alexey Proskuryakov.

Speed up a couple string functions.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncIndexOf): Added a fast path for cases where the second argument is either missing or an integer. (JSC::stringProtoFuncBig): Use jsNontrivialString since the string is guaranteed to be 2 or more characters long. (JSC::stringProtoFuncSmall): Ditto. (JSC::stringProtoFuncBlink): Ditto. (JSC::stringProtoFuncBold): Ditto. (JSC::stringProtoFuncItalics): Ditto. (JSC::stringProtoFuncStrike): Ditto. (JSC::stringProtoFuncSub): Ditto. (JSC::stringProtoFuncSup): Ditto. (JSC::stringProtoFuncFontcolor): Ditto. (JSC::stringProtoFuncFontsize): Make the fast path Sam recently added even faster by avoiding all but the minimum memory allocation. (JSC::stringProtoFuncAnchor): Use jsNontrivialString. (JSC::stringProtoFuncLink): Added a fast path.
  • runtime/UString.cpp: (JSC::UString::find): Added a fast path for single-character search strings.
7:53 AM Changeset in webkit [40974] by cmarrin@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23936

Fixed 2 more test cases (mac specific)

6:45 AM Changeset in webkit [40973] by treat@webkit.org
  • 5 edits in trunk/WebKit/qt

2009-02-13 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=23738
Expose the url elements target frame string. This is the sister function
to the existing linkTargetFrame which returns the QWebFrame*. When the
linkTargetFrame is 0 it is useful to know what the target was to be.

  • Api/qwebframe.cpp: (QWebHitTestResultPrivate::QWebHitTestResultPrivate): (QWebHitTestResult::linkTarget):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • tests/qwebframe/tst_qwebframe.cpp:
5:19 AM ApplicationsGtk edited by arthur.webkid@gmail.com
Update the correct URL for "Evolution RSS Reader Plugin" (diff)
4:02 AM Changeset in webkit [40972] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-02-13 David Boddie <​dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Removed documentation for internal functions.

4:02 AM Changeset in webkit [40971] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-02-13 Martin Smith <​msmith@trolltech.com>

Reviewed by Simon Hausmann.

Corrected some minor qdoc errors.

4:01 AM Changeset in webkit [40970] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-02-13 Prasanth Ullattil <​pullatti@trolltech.com>

Reviewed by Simon Hausmann.

Fixes crash in the Qt port on Windows with comboboxes

The focusWidget in the input context is not reset properly.
The QApplication::setFocusWidget() wont reset the IC if the reason is
PopupFocusReason, this is not ideal. For the time being we are going
to do this from webkit itself.

1:29 AM Changeset in webkit [40969] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-02-13 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 23926: Race condition in callOnMainThreadAndWait
<​https://bugs.webkit.org/show_bug.cgi?id=23926>

  • wtf/MainThread.cpp: Removed callOnMainThreadAndWait since it isn't used.
1:18 AM Changeset in webkit [40968] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

Math.random is really slow on windows.

Reviewed by Jon Honeycutt.

Math.random calls WTF::randomNumber which is implemented as
the secure rand_s on windows. Unfortunately rand_s is an order
of magnitude slower than arc4random. For this reason I've
added "weakRandomNumber" for use by JavaScript's Math Object.
In the long term we should look at using our own secure PRNG
in place of the system, but this will do for now.

30% win on SunSpider on Windows, resolving most of the remaining
disparity vs. Mac.

Feb 12, 2009:

11:30 PM Changeset in webkit [40967] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix the build for other platforms.

11:17 PM Changeset in webkit [40966] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix, typo while tweaking last patch for commit.

9:42 PM Changeset in webkit [40965] by kevino@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use Cairo/PANGO to fix text measurements and implement proper non-kerned text drawing on wxGTK.

​https://bugs.webkit.org/show_bug.cgi?id=17727

9:10 PM Changeset in webkit [40964] by Simon Fraser
  • 15 edits in trunk/WebCore

2009-02-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser

​https://bugs.webkit.org/show_bug.cgi?id=23942

Hook up 3D CSS transforms to the accelerated compositor backend.
Not enabled by default.

8:22 PM Changeset in webkit [40963] by barraclough@apple.com
  • 8 edits in trunk/JavaScriptCore

2009-02-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam Weinig.

Remove (/reduce) use of hard-wired register names from the JIT.
Currently there is no abstraction of registers used in the JIT,
which has a number of negative consequences. Hard-wiring x86
register names makes the JIT less portable to other platforms,
and prevents us from performing dynamic register allocation to
attempt to maintain more temporary values in machine registers.
(The latter will be more important on x86-64, where we have more
registers to make use of).

Also, remove MacroAssembler::mod32. This was not providing a
useful abstraction, and was not in keeping with the rest of the
MacroAssembler interface, in having specific register requirements.

  • assembler/MacroAssemblerX86Common.h:
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOp):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutVirtualRegister): (JSC::JIT::emitNakedCall): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
8:10 PM Changeset in webkit [40962] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2009-02-12 Horia Olaru <​olaru@adobe.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=23400

When throwing an exception within an eval argument string, the dst parameter was
modified in the functions below and the return value for eval was altered. Changed
the emitNode call in JSC::ThrowNode::emitBytecode to use a temporary register
to store its results instead of dst. The JSC::FunctionCallResolveNode::emitBytecode
would load the function within the dst registry, also altering the result returned
by eval. Replaced it with another temporary.

  • parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode): (JSC::ThrowNode::emitBytecode):

LayoutTests:

2009-02-12 Horia Olaru <​olaru@adobe.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=23400

Added a modified version of the test Chris Brichford attached to the bug.
Will test return values of various eval function calls, including some which
throw and catch errors in the string to evaluate.

  • fast/js/eval-throw-return-expected.txt: Added.
  • fast/js/eval-throw-return.html: Added.
  • fast/js/resources/eval-throw-return.js: Added. (throwFunc): (throwOnReturn): (twoFunc):
7:26 PM Changeset in webkit [40961] by mrowe@apple.com
  • 2 edits in tags/Safari-6530/WebKit/win

Merge r40886.

7:26 PM Changeset in webkit [40960] by mrowe@apple.com
  • 2 edits in tags/Safari-6530/WebKit/mac

Merge r40884.

7:26 PM Changeset in webkit [40959] by mrowe@apple.com
  • 6 edits in tags/Safari-6530/WebKit

Merge r40882.

7:26 PM Changeset in webkit [40958] by mrowe@apple.com
  • 2 edits in tags/Safari-6530/WebKit/mac

Merge r40851.

6:10 PM Changeset in webkit [40957] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

Get rid of containingBlockHeight(), since it had only one implementation (despite being virtual) and just returned
containingBlock()->availableHeight(). The latter reads better anyway. Rename containingBlockWidth() to
containingBlockWidthForContent() and move it to RenderBoxModelObject.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForContent): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcReplacedWidthUsing):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetX): (WebCore::RenderBoxModelObject::relativePositionOffsetY): (WebCore::RenderBoxModelObject::containingBlockWidthForContent):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::marginLeft): (WebCore::RenderInline::marginRight):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcReplacedWidth):
5:42 PM Changeset in webkit [40956] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

5:38 PM Changeset in webkit [40955] by mrowe@apple.com
  • 1 copy in tags/Safari-6530

New tag.

5:27 PM Changeset in webkit [40954] by Simon Fraser
  • 5 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Fix non-Mac builds by adding Matrix3DTransformOperation.* and
PerspectiveTransformOperation.*. Cleaned out some cruft in
the WebCore.vcproj fle.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
5:19 PM Changeset in webkit [40953] by dsmith@webkit.org
  • 5 edits in trunk

WebCore:

2009-02-12 David Smith <​catfish.man@gmail.com>

Reviewed by Dave Hyatt.


Fix ​https://bugs.webkit.org/show_bug.cgi?id=23935
Nested :not() and non-simple selectors in :not() should be invalid

  • css/CSSGrammar.y: Reject nested :not()
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ASSERT() rather than checking, since the parser enforces it now

LayoutTests:

2009-02-12 David Smith <​catfish.man@gmail.com>

Reviewed by David Hyatt.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Updated results now that we pass a few more
5:09 PM Changeset in webkit [40952] by beidson@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-02-12 Brady Eidson <​beidson@apple.com>

Reviewed by Kevin Decker

<rdar://problem/6582180> - Wrong HTTP method applied to history item.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any redirected request.

WebKit/win:

2009-02-12 Brady Eidson <​beidson@apple.com>

Reviewed by Kevin Decker

<rdar://problem/6582180> - Wrong HTTP method applied to history item.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any redirected request.
4:48 PM Changeset in webkit [40951] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fixes.

4:35 PM Changeset in webkit [40950] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Fix build with ACCELERATED_COMPOSITING turned on.

Need to cast toRenderBox() in order to call overflowClipRect().

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
4:22 PM Changeset in webkit [40949] by cmarrin@apple.com
  • 6 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23936

Fixed test results

4:19 PM Changeset in webkit [40948] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix windows build.

Reviewed by NOBODY(OOPS!)

3:53 PM Changeset in webkit [40947] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Rename getOverflowClipRect and getClipRect to overflowClipRect and clipRect. Move them to RenderBox, since these methods
only apply to boxes. Devirtualize clipRect, since it was not subclassed. Move controlClip stuff to RenderBox also.

Reviewed by Simon Fraser

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::overflowClipRect): (WebCore::RenderBox::clipRect):
  • rendering/RenderBox.h: (WebCore::RenderBox::hasControlClip): (WebCore::RenderBox::controlClipRect):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasClip): (WebCore::RenderObject::hasOverflowClip):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect):
  • rendering/RenderTable.h:
3:46 PM Changeset in webkit [40946] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Fix build with ACCELERATED_COMPOSITING turned on (simple copy/paste error)

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setBasicAnimation):
3:28 PM Changeset in webkit [40945] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Speed up String.prototype.fontsize.

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncFontsize): Specialize for defined/commonly used values.
3:18 PM Changeset in webkit [40944] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2009-02-12 Julien Chaffraix <​jchaffraix@webkit.org>

Not reviewed.

Release build fix when VIDEO is disabled (it should also
help those with WORKERS or XSLT disabled).

  • bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseAudio): Added an UNUSED_PARAM for exec and slot when VIDEO is disabled. (jsDOMWindowBaseWorker): Ditto for WORKERS. (jsDOMWindowBaseXSLTProcessor): Ditto for XSLT.
3:14 PM Changeset in webkit [40943] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-02-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23923
Implement mediaPlayerVolumeChanged so a media engine can report autonomous volume changes.
Supporting this requires that we know when we are processing a media engine callback so
we don't turn around and tell the media player to change the volume when it is reporting
a volume change.


  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): initialize m_processingMediaPlayerCallback (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): call begin/endProcessingMediaPlayerCallback (WebCore::HTMLMediaElement::setNetworkState): logic split out of mediaPlayerNetworkStateChanged to make it easier to maintain m_processingMediaPlayerCallback. (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): call begin/endProcessingMediaPlayerCallback (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto. (WebCore::HTMLMediaElement::mediaPlayerRepaint): Ditto. (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): New (WebCore::HTMLMediaElement::updateVolume): Don't change media engine volume if we are processing a callback from the engine.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::processingMediaPlayerCallback): New, return true if (m_processingMediaPlayerCallback>0) (WebCore::HTMLMediaElement::beginProcessingMediaPlayerCallback): New, increment m_processingMediaPlayerCallback (WebCore::HTMLMediaElement::endProcessingMediaPlayerCallback): New, decrement m_processingMediaPlayerCallback
2:55 PM Changeset in webkit [40942] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2009-02-12 Eric Carlson <​eric.carlson@apple.com>

Simon Fraser

Support MPEG content on Mac and Windows.
<rdar://problem/5917509>
​https://bugs.webkit.org/show_bug.cgi?id=23495

Test: media/audio-mpeg-supported.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h: fix typo added in r40925

2009-02-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.


Support MPEG content on Mac and Windows.
<rdar://problem/5917509>
​https://bugs.webkit.org/show_bug.cgi?id=23495

  • media/audio-mpeg-supported-expected.txt: Added.
  • media/audio-mpeg-supported.html: Added.
  • media/content/silence.mpg: Added.
2:54 PM Changeset in webkit [40941] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Reviewed by Sam Weinig

Move containsFloats, hasOverhangingFloats, shrinkToAvoidFloats and avoidsFloats down to
RenderBox, since these methods only apply to boxes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::calcBlockPrefWidths):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::hasOverhangingFloats):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::shrinkToAvoidFloats): (WebCore::RenderBox::avoidsFloats):
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::isFloatingOrPositioned):
  • rendering/RenderView.h:
2:43 PM Changeset in webkit [40940] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-02-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6579412>
REGRESSION (3.2.1-ToT): Crash in Silverlight viewing streaming lecture


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView userAgent]): Apply workaround for Silverlight workaround.


(-[WebNetscapePluginView _createPlugin]):
Check if the plug-in that we're creating is the silverlight plug-in.

2:33 PM Changeset in webkit [40939] by Simon Fraser
  • 23 edits in trunk

2009-02-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=23908

Added parsing of 3d transform functions and properties
(perspective, perspective-origin, transform-style-3d,
and backface-visibility).

Test: transforms/3d/cssmatrix-3d-interface.xhtml

2:28 PM Changeset in webkit [40938] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

2:28 PM Changeset in webkit [40937] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Correctness fix.

  • wtf/RandomNumber.cpp: (WTF::randomNumber): Divide by the maximum representable value, which is different on each platform now, to get values between 0 and 1.
2:25 PM Changeset in webkit [40936] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.14

New tag.

2:22 PM Changeset in webkit [40935] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-12 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
2:15 PM Changeset in webkit [40934] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

1:59 PM Changeset in webkit [40933] by beidson@apple.com
  • 8 edits in trunk

WebCore:

2009-02-12 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.

  • platform/mac/SharedBufferMac.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebCoreSharedBufferData dealloc]): (-[WebCoreSharedBufferData finalize]): (-[WebCoreSharedBufferData initWithSharedBuffer:]):

WebKit/mac:

2009-02-12 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.

  • History/WebBackForwardList.mm: (-[WebBackForwardList dealloc]): Null check before deref()'ing. (-[WebBackForwardList finalize]): Ditto.
  • Misc/WebIconFetcher.mm: (-[WebIconFetcher dealloc]): Null check before deref()'ing. (-[WebIconFetcher finalize]): Ditto.
  • WebCoreSupport/WebEditorClient.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebEditCommand initWithEditCommand:]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (-[WebEditCommand command]):
  • WebView/WebArchive.mm: Change to use RefPtr<> instead of ref()/deref(). (-[WebArchivePrivate init]): (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate coreArchive]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchivePrivate dealloc]): (-[WebArchivePrivate finalize]):
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Null check before deref()'ing. (-[WebDataSourcePrivate finalize]): Ditto.
1:56 PM Changeset in webkit [40932] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed <rdar://problem/6582048>.

  • wtf/RandomNumber.cpp: (WTF::randomNumber): Make only one call to the random number generator on platforms where the generator is cryptographically secure. The value of randomness over and above cryptographically secure randomness is not clear, and it caused some performance problems.
1:52 PM Changeset in webkit [40931] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Remove calcWidth from RenderObject. Nobody ever called it on RenderObjects.

Reviewed by Sam Weinig

  • rendering/RenderObject.h:
1:38 PM Changeset in webkit [40930] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Reviewed by Mark Rowe

Fix for regression where form controls would paint yellow highlights. The containsComposition check needs to
null check node() now.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
1:34 PM Changeset in webkit [40929] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Build fix

Change Animation::setDirection() to take the new enum value, and fix
the single caller.

Fix build error in MediaPlayerPrivateQTKit.h.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationDirection):
  • platform/animation/Animation.h: (WebCore::Animation::setDirection):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1:33 PM Changeset in webkit [40928] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2009-02-12 Simon Fraser <Simon Fraser>

No review.

Remove debugging code which was committed by mistake.

  • Scripts/run-webkit-tests:
1:26 PM Changeset in webkit [40927] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2009-02-12 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben

​https://bugs.webkit.org/show_bug.cgi?id=23928

Add detection of accelerated compositing and 3d transforms,
and add various directories to $ignoredDirectories when these
features are off.

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
1:18 PM Changeset in webkit [40926] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser

Remove the overrideSize methods from RenderObject. Devirtualize all of the accessors on RenderBox.

  • rendering/RenderBox.h:
  • rendering/RenderObject.h:
1:08 PM Changeset in webkit [40925] by eric.carlson@apple.com
  • 17 edits
    1 add in trunk/WebCore

2009-02-12 Eric Carlson <​eric.carlson@apple.com>

Darin Adler, Antti Koivisto, Holger Hans Peter Freyther


Bug 23797: A platform should be able to use more than one media engine for <video> and <audio>
​https://bugs.webkit.org/show_bug.cgi?id=23797

  • WebCore.xcodeproj/project.pbxproj: add MediaPlayerPrivate.h
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::load): selectMediaURL now also returns a MIME type, pass it to MediaPlayer::load so it can choose the right media engine (WebCore::HTMLMediaElement::selectMediaURL): renamed from pickMedia. use MIMETypeRegistry functions to strip params from the url and extract the codecs parameter. call MediaPlayer::supportsType to see if we can open the file since only a media engine can answer questions about supported type+codecs.
  • html/HTMLMediaElement.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getParameterFromMIMEType): New, find and return a MIME type parameter (WebCore::MIMETypeRegistry::stripParametersFromMIMEType): New, strip all parameters from a MIME type
  • platform/MIMETypeRegistry.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::NullMediaPlayerPrivate): (WebCore::NullMediaPlayerPrivate::load): (WebCore::NullMediaPlayerPrivate::cancelLoad): (WebCore::NullMediaPlayerPrivate::play): (WebCore::NullMediaPlayerPrivate::pause): (WebCore::NullMediaPlayerPrivate::naturalSize): (WebCore::NullMediaPlayerPrivate::hasVideo): (WebCore::NullMediaPlayerPrivate::setVisible): (WebCore::NullMediaPlayerPrivate::duration): (WebCore::NullMediaPlayerPrivate::currentTime): (WebCore::NullMediaPlayerPrivate::seek): (WebCore::NullMediaPlayerPrivate::seeking): (WebCore::NullMediaPlayerPrivate::setEndTime): (WebCore::NullMediaPlayerPrivate::setRate): (WebCore::NullMediaPlayerPrivate::paused): (WebCore::NullMediaPlayerPrivate::setVolume): (WebCore::NullMediaPlayerPrivate::networkState): (WebCore::NullMediaPlayerPrivate::readyState): (WebCore::NullMediaPlayerPrivate::maxTimeSeekable): (WebCore::NullMediaPlayerPrivate::maxTimeBuffered): (WebCore::NullMediaPlayerPrivate::dataRate): (WebCore::NullMediaPlayerPrivate::totalBytesKnown): (WebCore::NullMediaPlayerPrivate::totalBytes): (WebCore::NullMediaPlayerPrivate::bytesLoaded): (WebCore::NullMediaPlayerPrivate::setRect): (WebCore::NullMediaPlayerPrivate::paint): (WebCore::createNullMediaPlayer): Do nothing media player so MediaPlayer doesn't have to NULL check before calling current engine.

(WebCore::MediaPlayerFactory::MediaPlayerFactory): New, factory constructor.
(WebCore::installedMediaEngines): New, returns vector of all installed engines.
(WebCore::addMediaEngine): New, add a media engine to the cache.
(WebCore::chooseBestEngineForTypeAndCodecs): New, return an engine that might support a MIME type.
(WebCore::MediaPlayer::MediaPlayer): create NULL media player so we have a default. Initialize m_currentMediaEngine.
(WebCore::MediaPlayer::~MediaPlayer): don't need to delete m_private, it is now an OwnPtr.
(WebCore::MediaPlayer::load): Take MIME type as well as url, since we need it to find the right

media engine. If no MIME type is provided, try to devine one from the url. Choose a media engine
based on the MIME type and codecs parameter.

(WebCore::MediaPlayer::currentTime): Remove excess white space.
(WebCore::MediaPlayer::supportsType): Take codecs param as well as MIME type. Return enum so we can
indicate "maybe" condition.
(WebCore::MediaPlayer::getSupportedTypes): Build up list of MIME types by consulting all engines.
(WebCore::MediaPlayer::isAvailable): return true if any media engine is installed.

  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::): (WebCore::MediaPlayer::frameView): accessor function.
  • platform/graphics/MediaPlayerPrivate.h: New, declares abstract interface for media engines. (WebCore::MediaPlayerPrivateInterface::~MediaPlayerPrivateInterface): (WebCore::MediaPlayerPrivateInterface::totalBytesKnown):
  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: Add support for engine factory
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::create): New, media engine factory function (WebCore::MediaPlayerPrivate::registerMediaEngine): Register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::load): URL is a const String. (WebCore::MediaPlayerPrivate::duration): Declare const. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::networkState): Ditto. (WebCore::MediaPlayerPrivate::readyState): Ditto. (WebCore::MediaPlayerPrivate::maxTimeBuffered): Ditto. (WebCore::MediaPlayerPrivate::maxTimeSeekable): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::bytesLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytesKnown): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto. (WebCore::MediaPlayerPrivate::supportsType): Return MediaPlayer::SupportsType enum instead of bool.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: (WebCore::MediaPlayerPrivate::isAvailable):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create): New, media engine factory function (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::createQTMovieView): don't access MediaPlayer->m_frameView directly, use accessor function. (WebCore::MediaPlayerPrivate::setUpVideoRendering): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::mimeTypeCache): New. (WebCore::MediaPlayerPrivate::getSupportedTypes): New, media engine factory function. (WebCore::MediaPlayerPrivate::supportsType): return MediaPlayer::SupportsType enum instead of bool (-[WebCoreMovieObserver initWithCallback:]): fix formatting
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::create): (WebCore::MediaPlayerPrivate::registerMediaEngine): (WebCore::MediaPlayerPrivate::supportsType): (WebCore::MediaPlayerPrivate::load): URL is a const String.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h: (WebCore::MediaPlayerPrivate::isAvailable):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::create): New, media engine factory function (WebCore::MediaPlayerPrivate::registerMediaEngine): New, register engine with MediaPlayer factory (WebCore::MediaPlayerPrivate::load): URL is a const String. (WebCore::MediaPlayerPrivate::paint): don't access MediaPlayer->m_frameView directly, use accessor function. (WebCore::mimeTypeCache): New. (WebCore::MediaPlayerPrivateQTWin::getSupportedTypes): New, media engine factory function. (WebCore::MediaPlayerPrivateQTWin::supportsType): return MediaPlayer::SupportsType enum instead of bool
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
12:52 PM Changeset in webkit [40924] by jchaffraix@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-02-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test: fast/dom/prefixed-image-tag.xhtml

Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)

Instead we now directly propage the QualifiedName inside the generated Factory.

Test: fast/dom/prefixed-image-tag.xhtml

  • dom/Document.cpp: (WebCore::Document::createElement): Removed the setPrefix work-around and replaced it with an ASSERT to catch mistakes inside the Factory code. Remove the unneeded ExceptionCode argument.

(WebCore::Document::createElementNS): Removed ExceptionCode argument.

  • dom/Document.h: Updated the signature.
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs): Removed ExceptionCode argument.
  • dom/XMLTokenizerQt.cpp: Ditto. (WebCore::XMLTokenizer::parseStartElement): Ditto.
  • dom/make_names.pl: Implemented the QualifiedName propogation logic in the Factory.

LayoutTests:

2009-02-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23915: Remove setPrefix work-around in Document::createElement(QualifiedName, bool)

The test validates the <image> special treatment (using <img> tag) and see whether
it validates the previous behaviour and we do not ASSERT.

  • fast/dom/prefixed-image-tag-expected.txt: Added.
  • fast/dom/prefixed-image-tag.xhtml: Added.
12:47 PM Changeset in webkit [40923] by Simon Fraser
  • 5 edits in trunk/WebCore

2009-02-12 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=23188

Define enum values for Animation::direction(), and one for
IterationCountInfinite to make the code more self-documenting.

Order the member vars of Animation to optimize packing.

12:42 PM Changeset in webkit [40922] by christian@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Holger Freyther.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp): Don't use O_CLOEXEC for now.
12:31 PM Changeset in webkit [40921] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

WebCore:

2009-02-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23826: Potential bug with before/after rule while moving element from one document to another

Moved the document before/after toggle from the constructor to insertedIntoDocument.

Test: fast/css-generated-content/beforeAfter-interdocument.html

  • html/HTMLQuoteElement.cpp: (WebCore::HTMLQuoteElement::HTMLQuoteElement): (WebCore::HTMLQuoteElement::insertedIntoDocument):
  • html/HTMLQuoteElement.h:

LayoutTests:

2009-02-12 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23826: Potential bug with before/after rule while moving element from one document to another

  • fast/css-generated-content/beforeAfter-interdocument.html: Added.
  • platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.txt: Added.
12:30 PM Changeset in webkit [40920] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-12 Brady Eidson <​beidson@apple.com>

Reviewed by Kevin Decker

<rdar://problem/6579750> - Crash in WebArchivePrivate in Tiger TextEdit

NSHTMLReader tries to create a WebArchive from a random chunk of data. Previously, WebArchive creation would
fail and return nil and NSHTMLReader would try something else. When we changed the behavior to return an invalid
WebArchive object, things started getting weird.

  • WebView/WebArchive.mm: (-[WebArchivePrivate setCoreArchive:]): Null check the pointer before calling ->deref() (-[WebArchivePrivate dealloc]): Remove the ASSERT which is now invalid, and null check the pointer before ->deref(). (-[WebArchivePrivate finalize]): Ditto (-[WebArchive initWithData:]): If the LegacyWebArchive cannot be created, return nil instead of an invalid object.
12:18 PM Changeset in webkit [40919] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23912

I have no idea why this broke. As far as I can tell the old code never should have worked in
the first place. Add code to handleWheelEvent that will find an enclosing renderer for a node
in order to attempt a wheel scroll.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
11:44 AM Changeset in webkit [40918] by christian@webkit.org
  • 5 edits in trunk/WebKit/gtk

[GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
​http://bugs.webkit.org/show_bug.cgi?id=17176

Reviewed by Holger Freyther.

  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri,

webkit_web_frame_load_string, webkit_web_view_load_uri and
webkit_web_view_load_request and unify implementations.

11:41 AM Changeset in webkit [40917] by Adam Roben
  • 2 edits in trunk/LayoutTests

Try to fix dashboard-region-parser

  • platform/mac/fast/css/dashboard-region-parser.html: Fixed relative paths now that this test has moved.
11:28 AM Changeset in webkit [40916] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-02-12 David Hyatt <​hyatt@apple.com>

Move the functions that paint borders, box shadows and border images into RenderBoxModelObject. drawBorder and drawBorderArc, because they are used
for outlines as well as borders, need to stay in RenderObject. Rename them to drawLineForBoxSide and drawArcForBoxSide in order to reflect their
more generic use. Rename the BorderSide struct to BoxSide, since the concept of "side" is just a rectangle concept and not a border concept.

Reviewed by Simon Fraser

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxShadow): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBorderMinusLegend):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): (WebCore::RenderObject::drawArcForBoxSide): (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::CollapsedBorders::addBorder): (WebCore::RenderTableCell::paintCollapsedBorder):
11:25 AM Changeset in webkit [40915] by cmarrin@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23927

Skip 16 SVG tests that fail on PPC, until problem is resolved

  • platform/mac/Skipped:
11:21 AM Changeset in webkit [40914] by cmarrin@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=23927

This fixes one testcase on PPC Mac

  • svg/custom/getTransformToElement.svg:
10:43 AM Changeset in webkit [40913] by eric.carlson@apple.com
  • 2 edits
    1 add in trunk/WebCore

2009-02-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser

Bug 18322: video element should have ui when scripting is disabled
​https://bugs.webkit.org/show_bug.cgi?id=18322

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::controls): always return 'true' when JavaScript is disabled.
  • manual-tests/media-controls-when-javascript-disabled.html: Added.
10:32 AM Changeset in webkit [40912] by christian@webkit.org
  • 2 edits in trunk
  • configure.ac: Make soup the default HTTP backend for the Gtk port.
10:18 AM Changeset in webkit [40911] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-02-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23906
Add custom V8 bindings for HTMLPlugInElement.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::CALLBACK_FUNC_DECL): (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::INDEXED_PROPERTY_SETTER):
10:11 AM Changeset in webkit [40910] by christian@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Soup backend must handle upload of multiple files
​https://bugs.webkit.org/show_bug.cgi?id=18343

Reviewed by Mark Rowe.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): (WebCore::freeFileMapping): (WebCore::ResourceHandle::startHttp): Support multipart request bodies mmap'ing files to be uploaded.
9:27 AM Changeset in webkit [40909] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some tests that fail due to using the wrong font for Hebrew to the Windows Skipped list

  • platform/win/Skipped:
9:10 AM Changeset in webkit [40908] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix lots of Perl warnings when building JavaScriptCoreGenerated on Windows

Reviewed by John Sullivan.

  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Create the docs/ directory so that we can write bytecode.html into it. This matches what JavaScriptCore.xcodeproj does.
8:48 AM Changeset in webkit [40907] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove some passing tests from the Windows Skipped list

  • platform/win/Skipped: Removed two tests in http/tests/incremental (one of which had been renamed and so was running anyway).
8:48 AM Changeset in webkit [40906] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix Bug 23922: Warning message from run-webkit-tests when Skipped file contains non-existent tests is confusing and is given for disabled tests

<​https://bugs.webkit.org/show_bug.cgi?id=23922>

We now no longer warn about disabled tests. The warning now reads:

Skipped list contained '$item', but no file of that name could be
found

Reviewed by John Sullivan.

  • Scripts/run-webkit-tests: (top level): Pass the list name to processIgnoreTests so it can print out a reasonable warning message. (processIgnoreTests): Take a list name as a second parameter and use it to display a better warning message. Also check for a "-disabled" version of the test before warning about it not existing.
8:48 AM Changeset in webkit [40905] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a failing loader test to the Windows Skipped list

  • platform/win/Skipped: Added fast/loader/frame-creation-removal.html.
8:48 AM Changeset in webkit [40904] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add another failing drag-n-drop test to the Windows Skipped list

  • platform/win/Skipped: Added editing/selection/drag-in-iframe.html.
8:48 AM Changeset in webkit [40903] by Adam Roben
  • 1 edit
    2 moves in trunk/LayoutTests

Fix Bug 23919: Mac-specific test fast/css/dashboard-region-parser is in cross-platform location

<​https://bugs.webkit.org/show_bug.cgi?id=23919>

Moved the test and its results to platform/mac.

Reviewed by Dan Bernstein.

  • platform/mac/fast/css/dashboard-region-parser-expected.txt: Renamed from LayoutTests/fast/css/dashboard-region-parser-expected.txt.
  • platform/mac/fast/css/dashboard-region-parser.html: Renamed from LayoutTests/fast/css/dashboard-region-parser.html.
8:47 AM Changeset in webkit [40902] by Adam Roben
  • 3 edits
    4 copies
    1 add in trunk/LayoutTests

Fix Bug 23918: Mac-specific results for fast/css/computed-style[-without-renderer] are sitting in cross-platform location

<​https://bugs.webkit.org/show_bug.cgi?id=23918>

Move Mac-specific results for
fast/css/computed-style[-without-renderer] to platform/mac

Reviewed by John Sullivan.

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt: Made these results correct for non-Mac platforms by removing the -webkit-dashboard-region references.
  • platform/mac/fast/css/computed-style-expected.txt: Copied from LayoutTests/fast/css/computed-style-expected.txt.
  • platform/mac/fast/css/computed-style-without-renderer-expected.txt: Copied from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
  • platform/win/fast/css/computed-style-expected.txt:
  • platform/win/fast/css/computed-style-without-renderer-expected.txt: Copied the non-Mac results here, too, since on Windows we first check for Mac-specific results before checking for cross-platform results.
7:01 AM Changeset in webkit [40901] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-12 Adam Treat <​adam.treat@torchmobile.com>

Fix the Qt build following r40871 which changed RenderObject::element()
into RenderObject::node().

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getMediaElementFromRenderObject): (WebCore::RenderThemeQt::getMediaControlForegroundColor):
2:51 AM Changeset in webkit [40900] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2009-02-12 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Lars.

Re-enable the JIT in the Qt build with -fno-stack-protector on Linux.

2:45 AM Changeset in webkit [40899] by ap@webkit.org
  • 2 edits in trunk/WebCore

Build fix.

  • platform/graphics/transforms/RotateTransformOperation.cpp: Include <algorithm>.
1:14 AM Changeset in webkit [40898] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/win

Merge r40886.

1:14 AM Changeset in webkit [40897] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/mac

Merge r40884.

1:14 AM Changeset in webkit [40896] by mrowe@apple.com
  • 6 edits in branches/Safari-6528/WebKit

Merge r40882.

1:14 AM Changeset in webkit [40895] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebKit/mac

Merge r40851.

1:14 AM Changeset in webkit [40894] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40847.

1:14 AM Changeset in webkit [40893] by mrowe@apple.com
  • 2 edits in branches/Safari-6528/WebCore

Merge r40808.

1:13 AM Changeset in webkit [40892] by mrowe@apple.com
  • 2 edits
    4 adds in branches/Safari-6528

Merge r40778.

1:10 AM Changeset in webkit [40891] by mrowe@apple.com
  • 7 edits in branches/Safari-6528/WebCore

Merge r40729.

1:08 AM Changeset in webkit [40890] by ap@webkit.org
  • 13 edits in trunk/WebCore

2009-02-12 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Change worker code to use different proxy class pointers.
​https://bugs.webkit.org/show_bug.cgi?id=23859

This is a step towards using separate proxies in multi-process implementation.

  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::~Worker): (WebCore::Worker::postMessage): (WebCore::Worker::terminate): (WebCore::Worker::hasPendingActivity): (WebCore::Worker::notifyFinished): (WebCore::Worker::dispatchMessage):
  • dom/Worker.h:
  • dom/WorkerContext.cpp: (WebCore::WorkerContext::~WorkerContext): (WebCore::WorkerContext::reportException): (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postMessage): (WebCore::WorkerContext::dispatchMessage):
  • dom/WorkerContext.h:
  • dom/WorkerContextProxy.h:
  • dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::MessageWorkerTask::performTask): (WebCore::WorkerContextProxy::create): (WebCore::WorkerMessagingProxy::WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::~WorkerMessagingProxy): (WebCore::WorkerMessagingProxy::startWorkerContext): (WebCore::postConsoleMessageTask): (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject): (WebCore::WorkerMessagingProxy::workerThreadCreated):
  • dom/WorkerMessagingProxy.h:
  • dom/WorkerObjectProxy.h:
  • dom/WorkerThread.cpp: (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h: (WebCore::WorkerThread::workerObjectProxy):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
12:32 AM Changeset in webkit [40889] by ap@webkit.org
  • 8 edits in trunk/WebCore

2009-02-12 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23688: ThreadableLoader needs a sync implementation for Workers.
<​https://bugs.webkit.org/show_bug.cgi?id=23688>

Add ResourceError to ThreadableLoaderClient.

No observable change in behavior, so no test.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create): (WebCore::DocumentThreadableLoader::willSendRequest): (WebCore::DocumentThreadableLoader::didFail):
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didFail): (WebCore::ThreadableLoaderClient::didFailWillSendRequestCheck):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didFail):
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): (WebCore::workerContextDidFail): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
  • loader/WorkerThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFailWillSendRequestCheck):
  • xml/XMLHttpRequest.h:
Note: See TracTimeline for information about the timeline view.