Timeline


and

02/18/09:

19:36 Changeset [41075] by mrowe@apple.com

Versioning.

19:35 Changeset [41074] by mrowe@apple.com

New tag.

19:34 Changeset [41073] by mrowe@apple.com

Versioning.

19:34 Changeset [41072] by mrowe@apple.com

Merge r41071.

18:04 Changeset [41071] by mitz@apple.com

WebCore:

Reviewed by Brady Eidson.

  • WebCore part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle

The crash results from re-entry into
CSSMutableStyleDeclaration::setCssText, which in turn is caused by
the first style change causing a cached image to load from the memory
cache, causing load delegate dispatch, and iChat's delegate method
calling back into WebKit.

The workaround is to use defer delegate callbacks for memory cache. In
this case, deferring callbacks during image load event dispatch was
found to be sufficient.

The crash is a regression. See also the discussion in
<https://bugs.webkit.org/show_bug.cgi?id=22521>.

  • WebCore.base.exp: Added Settings::setNeedsIChatMemoryCacheCallsQuirk().
  • dom/Document.cpp: (WebCore::Document::dispatchImageLoadEventsNow): If the quirk is enabled, defer memory cache callbacks during image load event dispatch.
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize m_needsIChatMemoryCacheCallsQuirk. (WebCore::Settings::setNeedsIChatMemoryCacheCallsQuirk): Added this setter.
  • page/Settings.h: (WebCore::Settings::needsIChatMemoryCacheCallsQuirk): Added this getter.

WebKit/mac:

Reviewed by Brady Eidson.

  • WebKit part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Activate the WebCore workaround for this crash in iChat.
17:46 Changeset [41070] by andersca@apple.com

2009-02-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6542390>


There's no need to call setDefersLoading here - we already defer anything a plug-in can do that
would cause a load to begin.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
16:13 Changeset [41069] by dglazkov@chromium.org

2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24012
Convert inline-ignored-on-legend to text-only test.

  • fast/forms/inline-ignored-on-legend-expected.txt: Added.
  • fast/forms/inline-ignored-on-legend.html: Changed to text-only.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Removed.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Removed.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Removed.
15:26 Changeset [41068] by levin@chromium.org

2009-02-18 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23974: Deque::Remove would be a useful method.
<https://bugs.webkit.org/show_bug.cgi?id=23974>

Add Deque::remove and DequeIteratorBase<T>::operator=.

Why was operator= added? Every concrete iterator (DequeIterator..DequeConstReverseIterator)
was calling DequeIteratorBase::assign(), which called Base::operator=(). Base::operator=()
was not implemented. This went unnoticed because the iterator copy code has been unused.

  • wtf/Deque.h: (WTF::Deque<T>::remove): (WTF::DequeIteratorBase<T>::removeFromIteratorsList): (WTF::DequeIteratorBase<T>::operator=): (WTF::DequeIteratorBase<T>::~DequeIteratorBase):
14:59 Changeset [41067] by aroben@apple.com

Add SPI to get WebKit's custom pointing-hand cursor

WebCore:

Export WebCore::handCursor and Cursor.h

Reviewed by John Sullivan.

  • WebCore.base.exp: Added WebCore::handCursor.
  • WebCore.xcodeproj/project.pbxproj: Made Cursor.h private.

WebKit/mac:

Add SPI to get WebKit's custom pointing-hand cursor

Reviewed by John Sullivan.

  • WebView/WebView.mm: (+[WebView _pointingHandCursor]): Added. Returns the custom pointing-hand cursor that WebKit uses.
  • WebView/WebViewPrivate.h: Added +_pointingHandCursor.
14:12 Changeset [41066] by darin@chromium.org

2009-02-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23992
REGRESSION: crash on windows loading http://www.stickam.com/liveStreams.do

Unable to reduce to a layout test.

  • page/Frame.cpp: (WebCore::Frame::contentRenderer):
14:07 Changeset [41065] by darin@chromium.org

2009-02-18 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23861
Stroke font outlines on chromium linux

TEST=LayoutTests/svg/custom/pointer-events-text.svg

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
14:05 Changeset [41064] by darin@chromium.org

2009-02-18 Evan Stade <estade@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23860
Resync some graphics/skia files with their chromium counterparts

This comes from chromium patches <http://codereview.chromium.org/17633>
and <http://codereview.chromium.org/17454>

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::addPath): (PlatformContextSkia::currentPath):
  • platform/graphics/skia/PlatformContextSkia.h:
13:56 Changeset [41063] by kov@webkit.org

2009-02-18 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed.

Build fix after r41060.

  • GNUmakefile.am:
12:19 Changeset [41062] by eric@webkit.org

Rubber-stamped by Alexey Proskuryakov.

Add a few ignores to make-js-test-wrappers.

  • Scripts/make-js-test-wrappers:
11:20 Changeset [41061] by dglazkov@chromium.org

2009-02-18 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24005
Add an include to fix Chromium build.

  • page/animation/AnimationController.cpp: Add UnusedParam.h include.
11:18 Changeset [41060] by kov@webkit.org

2009-02-18 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Fix symbols.filter location, and add other missing files to the
autotools build, so that make dist works.

  • GNUmakefile.am:
08:45 Changeset [41059] by kov@webkit.org

2009-02-18 Zan Dobersek <zandobersek@gmail.com>

Rubber-stamped by Holger Hans Peter Freyther.

Allow POST method for local requests.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
08:36 Changeset [41058] by kov@webkit.org

2009-02-18 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Hans Peter Freyther.

Use KURL in startGio instead of passing a string with the URL, so
that we can handle removing refs and queries more elegantly. This
is fixing more regressions that came from the curl->soup switch.

Original work by Zan Dobersek.

  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::startGio):
07:02 Changeset [41057] by zecke@webkit.org

Implement ResourceHandle::loadResourceSynchronously in ResourceHandleSoup.cpp

The implementation is needed to have synchronous loading, e.g. for
JavaScript interaction. This is fixing various regressions that
came from the curl->soup switch.

06:58 Changeset [41056] by zecke@webkit.org

2009-02-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Alexey Proskuryakov.

Prepend file:// to the test result filename to make
GtkLauncher display the result page.

  • Scripts/run-webkit-tests:
04:17 Changeset [41055] by kov@webkit.org

2009-02-18 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=23989

Based on a patch by Bo Yang <techrazy.yang@gmail.com>

Make the cursor cache global, that's all we really need and
otherwise we can miss cursor transitions in some situations (see
the bug for one testcase). Also remove some now useless code.

  • platform/Widget.h:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setCursor):

02/17/09:

21:48 Changeset [41054] by aroben@apple.com

Windows build fix

  • loader/FrameLoader.cpp: (WebCore::toPlugInElement): Don't rely on #if being processed before ASSERT.
20:17 Changeset [41053] by ggaren@apple.com

2009-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed failure in js1_5/Regress/regress-168347.js, as seen on the Oliver
bot.


Technically, both behaviors are OK, but we might as well keep this test
passing.

  • runtime/FunctionPrototype.cpp: (JSC::insertSemicolonIfNeeded): No need to add a trailing semicolon after a trailing '}', since '}' ends a block, indicating the end of a statement.
20:03 Changeset [41052] by ggaren@apple.com

2009-02-17 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • runtime/FunctionPrototype.cpp:
19:36 Changeset [41051] by oliver@apple.com

Add assertion to guard against oversized pc relative calls.

Reviewed by Geoff Garen

18:15 Changeset [41050] by mrowe@apple.com

Versioning.

18:14 Changeset [41049] by mrowe@apple.com

Disable the JIT for x86_64 until <rdar://problem/6594577> is resolved.

Rubber-stamped by Oliver Hunt.

  • wtf/Platform.h:
17:20 Changeset [41048] by mrowe@apple.com

New tag.

16:50 Changeset [41047] by levin@chromium.org

2009-02-17 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23977: Unnecessary timer related headers in files.
<https://bugs.webkit.org/show_bug.cgi?id=23977>

No observable change in behavior, so no test.

  • dom/Document.cpp:
  • dom/WorkerRunLoop.cpp:
  • dom/WorkerRunLoop.h:
16:21 Changeset [41046] by dimich@chromium.org

WebCore:
2009-02-17 Peter Abrahamsen <rainhead@gmail.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23958
<rdar://problem/6587815>

Updated XMLHttpRequest with new header names from the latest Access
Control draft: http://www.w3.org/TR/access-control/

  • Access-Control-Origin becomes Access-Control-Allow-Origin
  • Access-Control-Credentials becomes Access-Control-Allow-Credentials
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck):

LayoutTests:
2009-02-17 Peter Abrahamsen <rainhead@gmail.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23958
<rdar://problem/6587815>

Updated XMLHttpRequests tests to match the newest Access Control draft.

  • http/tests/security/originHeader/resources/print-origin.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-access-control-origin-header.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-star.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-allow.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-non-get-allow.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
  • http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi:
16:14 Changeset [41045] by ggaren@apple.com

JavaScriptCore:

2009-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
fails to load.


amnestyusa.org uses the Optimist JavaScript library, which adds event
listeners by concatenating string-ified functions. This is only sure to
be syntactically valid if the string-ified functions end in semicolons.

  • parser/Lexer.cpp: (JSC::Lexer::isWhiteSpace):
  • parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator): Added some helper functions for examining whitespace.
  • runtime/FunctionPrototype.cpp: (JSC::appendSemicolonIfNeeded): (JSC::functionProtoFuncToString): When string-ifying a function, insert a semicolon in the last non-whitespace position, if one doesn't already exist.

LayoutTests:

2009-02-17 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Test for <rdar://problem/6595040> REGRESSION: http://www.amnestyusa.org/
fails to load.

  • fast/js/function-toString-semicolon-insertion-expected.txt: Added.
  • fast/js/function-toString-semicolon-insertion.html: Added.
  • fast/js/resources/function-toString-semicolon-insertion.js: Added. (compileAndSerialize):
14:59 Changeset [41044] by kevino@webkit.org

wx build fix. Add missing constructor used for empty values.

14:16 Changeset [41043] by antti@apple.com

2009-02-17 Antti Koivisto <antti@apple.com>

Reviewed by Dave Kilzer.

<rdar://problem/6592446> dynamically updating page doesn't seem to draw when updated


Need update after callback.

  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
12:43 Changeset [41042] by eric.carlson@apple.com

2009-02-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=23917
Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
element.

  • DerivedSources.make: add media element proxy exports to .exp file when feature is defined.
  • WebCore.VideoProxy.exp: New, define the informal protocol exported by a media element proxy.
  • WebCore.xcodeproj/project.pbxproj: Add MediaPlayerProxy.h.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_needWidgetUpdate. (WebCore::HTMLMediaElement::attributeChanged): Don't detach+attach when PLUGIN_PROXY_FOR_VIDEO, the proxy plug-in handles the poster frame. (WebCore::HTMLMediaElement::rendererIsNeeded): New logic for PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLMediaElement::createRenderer): Create RenderPartObject when PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLMediaElement::attach): Set m_needWidgetUpdate when PLUGIN_PROXY_FOR_VIDEO (WebCore::HTMLMediaElement::load): Don't reallocate MediaPlayer when PLUGIN_PROXY_FOR_VIDEO, we keep the same plug-in for the life of the element. (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): update m_networkState when media player network state changes to EMPTY, otherwise we can get out of sync with engine. (WebCore::HTMLMediaElement::defaultEventHandler): pass event to widget when PLUGIN_PROXY_FOR_VIDEO (WebCore::HTMLMediaElement::deliverNotification): New, deliver notification from proxy plug-in to media player. (WebCore::HTMLMediaElement::setMediaPlayerProxy): New, pass proxy object to media player. (WebCore::HTMLMediaElement::initialURL): New, return the url from the "src" attr or the appropriate <source> element to be used as the initial url for the proxy. (WebCore::HTMLMediaElement::finishParsingChildren): New, allocate MediaPlayer and update widget.
  • html/HTMLMediaElement.h: Declare new methods for proxy, add m_needWidgetUpdate. (WebCore::HTMLMediaElement::setNeedWidgetUpdate):
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::attach): Poster image is handled by proxy when PLUGIN_PROXY_FOR_VIDEO. (WebCore::HTMLVideoElement::parseMappedAttribute): Ditto.
  • html/HTMLVideoElement.h:
  • loader/FrameLoader.cpp: (WebCore::toPlugInElement): Allow cast if element is <video> or <audio>
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Remove white space. (WebCore::MediaPlayer::setPoster): New, forward call to private player. (WebCore::MediaPlayer::deliverNotification): Ditto. (WebCore::MediaPlayer::setMediaPlayerProxy): Ditto.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::mediaPlayerClient):
  • platform/graphics/mac/MediaPlayerProxy.h: New, defines media player proxy interface.
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Change constructor to take Element* instead of Node* as a non-element node doesn't need a renderer
  • rendering/RenderPart.h: Ditto.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Ditto. (WebCore::RenderPartObject::updateWidget): Package params for proxy plug-in when element is <video> or <audio>.
  • rendering/RenderPartObject.h:

2009-02-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=23917
Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
element.

  • Plugins/WebPluginContainerPrivate.h:
  • Plugins/WebPluginController.mm: (mediaProxyClient): New, cast to HTMLMediaElement if it is a video or audio element (-[WebPluginController _setMediaPlayerProxy:forElement:]): New, pass proxy to HTMLMediaElement (-[WebPluginController _postMediaPlayerNotification:forElement:]): New, deliver event to HTMLMediaElement
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Don't allow a media player proxy plug-in to be chosen by file extension, only want a match for the new MIME type proxy plug-ins should have.
11:33 Changeset [41041] by hyatt@apple.com

WebCore:

2009-02-17 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

Fix for https://bugs.webkit.org/show_bug.cgi?id=23985

Don't allow legends to be anything but display:block.

Added fast/forms/inline-ignored-on-legend.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/html4.css:
  • html/HTMLLegendElement.cpp:
  • html/HTMLLegendElement.h:
  • rendering/RenderLegend.cpp: Removed.
  • rendering/RenderLegend.h: Removed.
  • wml/WMLInsertedLegendElement.cpp:
  • wml/WMLInsertedLegendElement.h:

LayoutTests:

2009-02-17 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

Fix for https://bugs.webkit.org/show_bug.cgi?id=23985

Don't allow legends to be anything but display:block.

  • fast/forms/inline-ignored-on-legend.html: Added.
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/forms/006-expected.txt:
  • platform/mac/fast/forms/007-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/float-before-fieldset-expected.txt:
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Added.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Added.
  • platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Added.
  • platform/mac/fast/invalid/residual-style-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
10:14 Changeset [41040] by brettw@chromium.org

Reviewed by Simon Fraser.

https://bugs.webkit.org/attachment.cgi?id=27666
Fix Chromium build build: forgotten include in RenderObject, sync
RenderTheme to the recent changes in RenderObject.

  • rendering/RenderObject.cpp:
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::updatePressedState):
08:52 Changeset [41039] by kov@webkit.org

2009-02-17 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

Restoring change landed in r40715, which was accidentally undone
by r40918.

  • webkit/webkitwebframe.cpp:
04:43 Changeset [41038] by kov@webkit.org

2009-02-17 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23939
Release build being built with debugging symbols

  • configure.ac: Revert change done in revision 40790, since we already have a AC_PROG_CXX macro call as part of WEBKIT_INIT
04:32 Changeset [41037] by kov@webkit.org

2009-02-17 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22966
crash when destroying a webview that opened a page containing <script>
tags

Fix m_group being set to 0 instead of to m_singlePageGroup when
GroupName is set to empty

  • page/Page.cpp: (WebCore::Page::setGroupName):

02/16/09:

19:38 Changeset [41036] by oliver@apple.com

Roll out r41022 as it breaks qt and gtk builds

19:38 Changeset [41035] by bdakin@apple.com

2009-02-16 Beth Dakin <bdakin@apple.com>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6386623>

I made m_numParsedProperties and m_maxParsedProperties unsigned
instead of int, and then added an early return from addPropery() if
m_maxParsedProperties exceeds the max value.

  • css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::deleteFontFaceOnlyValues):
  • css/CSSParser.h:
19:36 Changeset [41034] by justin.garcia@apple.com

WebCore:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored


When we originally implemented this command, MSDN documentation said that IE set the
id attribute of inserted lists to the third argument to execCommand, but IE doesn't
do this nor do any other browsers.

  • editing/EditorCommand.cpp: (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::create):

LayoutTests:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Mark Rowe.


https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored

  • editing/execCommand/insert-list-with-id-expected.txt: Added.
  • editing/execCommand/insert-list-with-id.html:
  • platform/mac/editing/execCommand/insert-list-with-id-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.png: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.txt: Removed.
18:59 Changeset [41033] by kov@webkit.org

2009-02-16 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Adam Roben

Actually use the installation prefix defined in WebKitInstallationPrefix,
in autotools builds.

  • Scripts/webkitdirs.pm:
18:00 Changeset [41032] by mrowe@apple.com

Versioning.

17:59 Changeset [41031] by mrowe@apple.com

New tag.

17:56 Changeset [41030] by mrowe@apple.com

Versioning.

17:56 Changeset [41029] by mrowe@apple.com

Merge r41027.

16:40 Changeset [41028] by weinig@apple.com

JavaScriptCore:

2009-02-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

No performance regression.

  • runtime/Arguments.cpp: (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been overridden.

LayoutTests:

2009-02-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add tests for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

  • fast/js/function-apply-expected.txt:
  • fast/js/resources/function-apply.js: Add cases covering setting arugments.length and Array.length explicitly or implicitly using Array.prototype.unshift.
15:56 Changeset [41027] by mitz@apple.com

WebCore:

Reviewed by Geoffrey Garen.

  • fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse

Test: platform/mac/fast/events/pointer-events-dashboard.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Do not apply the pointer-events property in Dashboard backwards compatibility mode, in order to work around misuse of that property by the Stocks widget.

LayoutTests:

Reviewed by Geoffrey Garen.

  • test for <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
  • platform/mac/fast/events/pointer-events-dashboard-expected.checksum: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.png: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.txt: Added.
  • platform/mac/fast/events/pointer-events-dashboard.html: Copied from LayoutTests/fast/events/pointer-events.html.
15:33 Changeset [41026] by justin.garcia@apple.com

WebCore:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just the body element, but any root editable element.

LayoutTests:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel.


https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/execCommand/15381-expected.txt: Added.
  • editing/execCommand/15381.html: Added.


Made this test cross platform and changed it to reflect the fix:

  • editing/execCommand/5062376-expected.txt: Added.
  • editing/execCommand/5062376.html:
  • platform/mac/editing/execCommand/5062376-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5062376-expected.png: Removed.
  • platform/mac/editing/execCommand/5062376-expected.txt: Removed.
15:19 Changeset [41025] by cfleizach@apple.com

Bug 23979: AX: alt tag not returned for <input type="image">
https://bugs.webkit.org/show_bug.cgi?id=23979

14:36 Changeset [41024] by mrowe@apple.com

Merge r41023.

14:23 Changeset [41023] by mrowe@apple.com

Build fix.

14:15 Changeset [41022] by oliver@apple.com

Bug 23787: Allow JIT to generate SSE2 code if using GCC
<https://bugs.webkit.org/show_bug.cgi?id=23787>

Provided by Csaba Osztrogonac
Reviewed by Oliver Hunt

GCC version of the cpuid check.

14:06 Changeset [41021] by kevino@webkit.org

Reviewed by Kevin Ollivier.

The ref data is not properly set unless we use the CreateMatrix function.

https://bugs.webkit.org/show_bug.cgi?id=23978

13:57 Changeset [41020] by mitz@apple.com

Reviewed by John Sullivan.

  • fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
  • platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the FontPlatformData(float, bool, bool) constructor.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData): Changed to pass a valid NSFont to the FontPlatformData constructor, instead of implicitly passing 0 and then calling setFont().
  • platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter of the constructor mandatory.
02:57 Changeset [41019] by hausmann@webkit.org

2009-02-16 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Avoid loading plugins when they're disabled in the settings.

02/15/09:

13:39 Changeset [41018] by ddkilzer@apple.com

Move duplicate caretWidth constants to RenderObject.h

Reviewed by Dan Bernstein.

No test since no change in behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect): Ditto.
  • rendering/RenderObject.h: Added caretWidth definition.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Removed caretWidth.

02/14/09:

08:39 Changeset [41017] by dglazkov@chromium.org

2009-02-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23955
V8HTMLPlugInCustom returns undefined, which fools interceptors.

  • bindings/v8/custom/V8HTMLPlugInElementCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Use deferToInterceptor() return value. (WebCore::NAMED_PROPERTY_SETTER): Ditto. (WebCore::INDEXED_PROPERTY_GETTER): Ditto. (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
Note: See TracTimeline for information about the timeline view.