Timeline


and

03/01/09:

21:46 Changeset [41351] by timothy@apple.com

Fix the Mac build.

20:18 Changeset [41350] by ddkilzer@apple.com

<rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define it as a preprocessor macro by modifying GCC_PREPROCESSOR_DEFINITIONS.
  • JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate DTrace header" script phase to check for HAVE_DTRACE instead of MACOSX_DEPLOYMENT_TARGET.
  • wtf/Platform.h: Removed definition of HAVE_DTRACE macro since it's defined in Base.xcconfig now.
18:55 Changeset [41349] by cfleizach@apple.com

Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>

16:45 Changeset [41348] by andersca@apple.com

2009-03-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6449689>

Pass the visible name to the plug-in host.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
16:41 Changeset [41347] by levin@chromium.org

2009-03-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
<https://bugs.webkit.org/show_bug.cgi?id=24251>

Make RenderObject::positionForCoordinate non-virtual and
RenderObject::positionForPoint virtual in preparation for
removing positionFor* from RenderObject/RenderText.

  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::positionForPoint):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
  • rendering/RenderText.h:
16:41 Changeset [41346] by levin@chromium.org

2009-03-01 Larry Ewing <lewing@novell.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds

Make sure to cast the value to the correct type so that only
memory owned by the value is written to.

  • plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
  • plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): (PluginView::getValue):
16:41 Changeset [41345] by levin@chromium.org

2009-03-01 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24197 and
https://bugs.webkit.org/show_bug.cgi?id=23512

The Windows version of cgColor() is conditionally compiled using
!PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
can use the OS X version instead of the Windows version.

Also rename cgColor() -> createCGColor()

No observable change in behavior, so no test.

  • platform/graphics/Color.h:
  • platform/graphics/cg/ColorCG.cpp: (WebCore::createCGColor):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/ColorMac.mm: (WebCore::createCGColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::GraphicsLayerCA::setBackgroundColor):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm: (WebCore::ciColor):
13:09 Changeset [41344] by levin@chromium.org

WebCore:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Tests: http/tests/xmlhttprequest/workers/methods-async.html

http/tests/xmlhttprequest/workers/methods.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::getOwnPropertySlot): (jsWorkerContextBaseXMLHttpRequest): (setJSWorkerContextBaseXMLHttpRequest): Expose XMLHttpRequest to Workers.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::constructXMLHttpRequest): (WebCore::JSXMLHttpRequestConstructor::mark): Removed the dependencies on Document.
  • bindings/js/JSXMLHttpRequestConstructor.h: (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
  • dom/EventException.idl:
  • dom/EventListener.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): Fixed identifier to be unsigned long.
  • loader/WorkerThreadableLoader.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
  • xml/XMLHttpRequestUpload.cpp:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.

LayoutTests:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Some sanity checks for xhr done from workers. These are the same as
tests done for normal workers.

  • http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods-async.html: Added.
  • http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods.html: Added.
  • http/tests/xmlhttprequest/workers/resources/methods-async.js: Added. (onmessage): (log): (done): (onReqAbort): (onSyncReqError): (start): (processStateChange):
  • http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
  • http/tests/xmlhttprequest/workers/resources/methods.js: Added. (log): (done):
12:14 Changeset [41343] by timothy@apple.com

Build fix. Add isBlock() back since there was a new client since the patch was made.

11:37 Applications using WebKit edited by todd.ditchendorf@gmail.com
(diff)
11:35 Changeset [41342] by timothy@apple.com

JavaScriptCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.

Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
  • parser/Nodes.h:

WebCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

Adding manual debugger test cases for bug.

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-while-statements.html: Added.
  • manual-tests/inspector/resources/loop-statements.js: Added.
11:22 Changeset [41341] by jmalonzo@webkit.org

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Determine the frame's response and decide whether to dump as text
or the render tree

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Enable http tests, excluding tests/folders that fail or untested

  • platform/gtk/Skipped:
11:21 Changeset [41340] by jmalonzo@webkit.org

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Implement dumping of WebKitWebBackForwardList and its history
items.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (compareHistoryItems): (dumpHistoryItem): (dumpBackForwardListForWebView): (dump): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList):
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (BackForwardItem::invoke):
11:21 Changeset [41339] by jmalonzo@webkit.org

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
necessary.
Add necessary API additions for us to be able to dump a WebKitWebHistoryItem

  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): (WebKit::core): (WebKit::kit):
11:02 Changeset [41338] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

Test: fast/events/scroll-during-zoom-change.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Pause scheduled events during style reclaculation. Changes to the zoom property result in scroll events being generated during style recalc, and those events need to be deferred until the render tree is consistent.
  • page/FrameView.cpp: (WebCore::FrameView::layout): Changed to account for a case in which the post-layout tasks trigger a nested layout, which reactivates the post-layout task timer.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
  • fast/events/scroll-during-zoom-change-expected.txt: Added.
  • fast/events/scroll-during-zoom-change.html: Added.
11:00 Changeset [41337] by christian@webkit.org

2009-03-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
  • webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' properties as well as webkit_web_view_get_encoding.
10:47 Changeset [41336] by christian@webkit.org

2009-02-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
08:53 Changeset [41335] by timothy@apple.com

Alphabetically sort scripts in the Script's panel file popup menu.

https://bugs.webkit.org/show_bug.cgi?id=23395

Reviewed by Timothy Hatcher.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  • inspector/front-end/utilities.js: (insertionIndexForObjectInListSortedByFunction): (indexOfObjectInListSortedByFunction):
08:42 Changeset [41334] by timothy@apple.com

Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
when creating databases, localStorage or sessionStorage. Changing document.domain
should have no affect on databases, localStorage and sessionStorage in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23844

Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::didUseDOMStorage):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
08:22 Changeset [41333] by kov@webkit.org

2009-03-01 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Avoid leaking errors when reporting GIO errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
08:21 Changeset [41332] by kov@webkit.org

2009-03-01 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Fixes crash when the GIO backend is given the URI for a directory.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile):
08:04 Changeset [41331] by kov@webkit.org

Simple wording fix for the NEWS file.

07:39 Changeset [41330] by christian@webkit.org

2009-03-01 Christian Dywan <christian@twotoasts.de>

  • configure.ac: Bump GTK port version to 1.1.1.
07:38 Changeset [41329] by kov@webkit.org

2009-03-01 Xan Lopez <xan@gnome.org>

Add NEWS file to track progress between releases.

  • NEWS: Added.
07:29 Changeset [41328] by kov@webkit.org

2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.

  • Scripts/webkitdirs.pm:
07:28 Changeset [41327] by kov@webkit.org

2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Add a GTK+-only option to enable GNOME Keyring when building.

  • Scripts/build-webkit:

02/28/09:

22:21 Changeset [41326] by jmalonzo@webkit.org

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076

Refactor gtk lib detection and put it in builtDylibPathForName

  • Scripts/webkitdirs.pm:
21:28 Changeset [41325] by dglazkov@chromium.org

2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
Test: traversal/exception-forwarding.html
TesT: traversal/stay-within-root.html

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto.
20:27 Changeset [41324] by dglazkov@chromium.org

2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Remove dubious checks, left over from

incomplete conversion of parameter from pointer to pass-by-ref.

(WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
(WebCore::NAMED_PROPERTY_SETTER): Ditto.

18:47 Changeset [41323] by mitz@apple.com
  • correct a color profile mismatch in expected pixel results
  • platform/mac/fast/gradients/background-clipped-expected.checksum:
  • platform/mac/fast/gradients/background-clipped-expected.png:
12:29 Changeset [41322] by christian@webkit.org

Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

12:12 Changeset [41321] by christian@webkit.org

Use the new webkit_web_view_load_uri to open URIs.

12:04 Changeset [41320] by christian@webkit.org
  • webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a

locale path is passed for compatibility, since we used to support that.

06:43 Changeset [41319] by kov@webkit.org

2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24226
[SOUP] HTTP status text is never set

Set HTTP status text to SoupMessage reason_phrase.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
02:01 Changeset [41318] by mitz@apple.com
  • fix malformed project file
  • WebCore.xcodeproj/project.pbxproj:
01:44 Changeset [41317] by mitz@apple.com

WebCore:

Reviewed by Oliver Hunt.

Test: fast/layers/inline-dirty-z-order-lists.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): Moved the code that dirties a layer's and its stacking context's z-order lists when the layer's z-index or visibility change from here...
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that it will apply to RenderInline too.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/layers/inline-dirty-z-order-lists.html: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
00:45 Changeset [41316] by alice.liu@apple.com

2009-02-27 Alice Liu <alice.liu@apple.com>

Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
extension to images that already have .jpg extension

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm: (-[NSString matchesExtensionEquivalent:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Relax the check for the proper extension to allow for known equivalents, special-cased in matchesExtensionEquivalent function.
00:06 Changeset [41315] by ap@webkit.org

Reviewed by David Hyatt.

Don't include TextResourceDecoder.h in Document.h

This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

02/27/09:

19:44 Changeset [41314] by kov@webkit.org

2009-02-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
file to EXTRA_DIST to fix make dist.

  • GNUmakefile.am:
18:21 Changeset [41313] by kov@webkit.org

2009-02-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by David Hyatt.

Automatically ignore empty requests to avoid crashing. This fixes
the crash in fast/loader/empty-embed-src-attribute.html.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
17:28 Changeset [41312] by levin@chromium.org

WebCore:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.

Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
"Fixed elements have 0 as an offsetLeft property"


Code also brings offsetLeft/Top in full conformance with the spec.
Added two tests, one for fixed-position elements, and one for <html>.


Tests: fast/dom/Element/fixed-position-offset-parent.html

fast/dom/Element/offsetLeft-offsetTop-html.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.


Added two tests:

  1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
  2. Tests offsetLeft and offsetTop on static and positioned <html> elements.
  • fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
  • fast/dom/Element/fixed-position-offset-parent.html: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html.html: Added.
17:13 Changeset [41311] by dino@apple.com

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Pixel tests for previous commit
https://bugs.webkit.org/show_bug.cgi?id=24252

  • platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
  • platform/mac/transforms/no_transform_hit_testing-expected.png: Added.
17:07 Changeset [41310] by dino@apple.com

Forgot -expected file from last commit :(

17:05 Changeset [41309] by dino@apple.com

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

renderer()->hasTransform() returns true for elements
with perspective, but no transform, so test for transform
when hit testing. This fixes ASSERT from
https://bugs.webkit.org/show_bug.cgi?id=24252

Test: transforms/no_transform_hit_testing.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
16:01 Changeset [41308] by dglazkov@chromium.org

2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Fix scrubbing error -- a reversed condition.

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
15:46 Changeset [41307] by mrowe@apple.com

Versioning.

15:39 Changeset [41306] by mrowe@apple.com

New tag.

15:29 Changeset [41305] by levin@chromium.org

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add confirmMessageFromWorkerObject to WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=24152

  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
14:46 Changeset [41304] by andersca@apple.com

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
because it leads to assertion failures in the Mac port.


  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
14:37 Changeset [41303] by andersca@apple.com

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

<rdar://problem/6631436>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55


Port the NPN_Evaluate code over from WebCore instead of using the frame loader.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):
14:24 Changeset [41302] by abarth@webkit.org

Remove mysterious @ sign to fix Windows build.

14:15 Changeset [41301] by abarth@webkit.org

Attempt to fix Windows build.

13:58 Changeset [41300] by andersca@apple.com

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6626814>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): Make InvokeDefault async.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Handle passing NPObjects back to the plug-in host.


  • Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::objectID): Add objectID getter.


  • Plugins/Hosted/WebKitPluginClient.defs: Make InvokeDefault a simpleroutine.
13:53 Changeset [41299] by timothy@apple.com

Fixes an exception by null checking the WebResource before adding it to
the subresources array.

<rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

Reviewed by Geoff Garen and Anders Carlsson.

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Null check the WebResource before adding it.
13:01 Changeset [41298] by timothy@apple.com

Adds a workaround for Automator creating a WebView from a secondary thread.

<rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

Reviewed by Geoff Garen.

  • WebView/WebView.mm: (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.
12:52 Changeset [41297] by abarth@webkit.org

WebCore:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20249

Add a preference to allow universal access from local URLs to mitigate
some attacks. Some clients still want to allow this access, so we
expose this as a preference.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileUrls]): (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileUrls): (WebPreferences::setAllowUniversalAccessFromFileUrls):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:47 Changeset [41296] by treat@webkit.org

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
12:42 Changeset [41295] by treat@webkit.org

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
12:35 Changeset [41294] by krit@webkit.org

2009-02-27 Dirk Schulze <krit@webkit.org>

Reviewed by Zack Rusin.

Added support for gradients and pattern on Fonts for Qt.

[Qt] gradients and patterns for FontQt
https://bugs.webkit.org/show_bug.cgi?id=24243

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
12:02 Changeset [41293] by simon.fraser@apple.com

2009-02-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

https://bugs.webkit.org/show_bug.cgi?id=24242

setCursor(), and resetCursorRects() on Tiger, were using global, not local
coordinates for elementAtPoint:

  • WebView/WebHTMLView.mm: (resetCursorRects): (setCursor):
11:50 Changeset [41292] by levin@chromium.org

2009-02-27 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24213: Web Worker: Worker4 test: onmessage will never be called
<https://bugs.webkit.org/show_bug.cgi?id=24213>

  • fast/workers/worker-terminate-expected.txt:
  • fast/workers/worker-terminate.html: Added a log entry to the onmessage handler for worker4 to make it visible that the handler was called and removed the terminate call that happened outside of onmessage.
11:50 Changeset [41291] by levin@chromium.org

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
https://bugs.webkit.org/show_bug.cgi?id=24113

  • workers/WorkerMessagingProxy.cpp:
11:29 Changeset [41290] by timothy@apple.com

Commit a missing file.

10:56 Changeset [41289] by timothy@apple.com

Added a refresh button to storage views.

https://bugs.webkit.org/show_bug.cgi?id=24040

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype.get statusBarItems): (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/inspector.css:
10:28 Changeset [41288] by timothy@apple.com

Added support for editing/deleting localStorage and sessionStorage items
directly from Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23866.

Reviewed by Timothy Hatcher.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DOMStorageDataGrid.js: Added. (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._ondblclick): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
09:42 Changeset [41287] by brettw@chromium.org

Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

08:23 Changeset [41286] by dglazkov@chromium.org

2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24211
Add ScheduledAction for V8.

  • bindings/v8/ScheduledAction.cpp: Added. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: Added. (WebCore::ScheduledAction::ScheduledAction):
06:59 Changeset [41285] by treat@webkit.org

2009-02-27 Zack Rusin <zack@kde.org>

Reviewed by Nikolas Zimmermann.

Qt: be more reasonable about scrolled lines

cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll

  • platform/qt/WheelEventQt.cpp:
03:30 Changeset [41284] by jmalonzo@webkit.org

2009-02-27 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24221
[GTK] Do not emit load-finished when being disposed

webkit_web_view_stop_load() is called from dispose() on
WebKitWebView. This eventually calls postProgressFinishedNotification
in FrameLoaderClientGtk, which emits load-finished. Add
a 'disposing' flag to WebView that we can check here, so
we avoid emitting signals on objects on their way to be
destroyed. This fixes a bunch of critical warnings when
closing a loading WebView.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
03:18 Changeset [41283] by jmalonzo@webkit.org

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::setSubMenu):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::retainPlatformWidget):
  • platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
03:12 Changeset [41282] by mrowe@apple.com

Merge r41070.

03:12 Changeset [41281] by mrowe@apple.com

Merge r41190.

03:12 Changeset [41280] by mrowe@apple.com

Bump version number.

00:20 Changeset [41279] by krit@webkit.org

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Added support for Gradients and Patterns on filled or stroked Fonts
in Cairo. I also added support for globalAlpha on FontCairo.

[CAIRO] SVG/Canvas fonts miss gradients/pattern support
https://bugs.webkit.org/show_bug.cgi?id=18617

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

02/26/09:

20:00 Changeset [41278] by adele@apple.com

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Alice Liu.

Make the success/failure of this test more obvious.

  • editing/selection/designmode-no-caret.html:
  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
19:32 Changeset [41277] by barraclough@apple.com

JavaScriptCore:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix bug #23614. Switches on double precision values were incorrectly
truncating the scrutinee value. E.g.:

switch (1.1) { case 1: print("FAIL"); }

Was resulting in FAIL.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff Garen.

Layout test for bug #23614.

  • fast/js/resources/switch-behaviour.js:
  • fast/js/switch-behaviour-expected.txt:
17:15 Changeset [41276] by adele@apple.com

WebKit/mac:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were
fixed in r36919 and r38570 are still fixed.

  • WebView/WebHTMLView.mm: (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder. (-[WebHTMLView _isResigningFirstResponder]): Added.
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active if the document view is currently resigning first responder.

LayoutTests:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Updating results for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

We changed these results shortly after r36919, but the original result is actually correct.
The test's text indicates that we expect a caret to be placed in this case.

  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
17:09 Changeset [41275] by barraclough@apple.com

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Integer Immediate representation need not be canonical in x86 JIT code.
On x86-64 we already have loosened the requirement that the int immediate
representation in canonical, we should bring x86 into line.

This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
should reduce memory footoprint (reduces JIT code size).

  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h: (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber):
  • jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
16:20 Changeset [41274] by darin@chromium.org

2009-02-26 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23957

Fix for SVG gradient and pattern text for Chromium/skia.
Added accessors for the fill and stroke gradients to
GraphicsContext. Changed the paintSkiaText function to take a
GraphicsContext, so we can check for gradients/patterns.
Changed the skiaDrawText function to set the SkPaint shader
correctly, and to scale up the gradient shader matrix to
encompass the entire text string. Also offset each glyph
separately, rather than transforming the canvas, so that the
gradient/pattern stays fixed relative to the text origin.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::getFillGradient): (WebCore::GraphicsContext::getStrokeGradient): (WebCore::GraphicsContext::getFillPattern): (WebCore::GraphicsContext::getStrokePattern):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::paintSkiaText):
  • platform/graphics/skia/SkiaFontWin.h:
15:29 Changeset [41273] by dglazkov@chromium.org

Fix ChangeLog entry

15:27 Changeset [41272] by dglazkov@chromium.org

2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

http://codereview.chromium.org/27217
Add custom V8 bindings for Navigator, Clipboard, Document, and Node.

  • bindings/v8/custom/V8ClipboardCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
15:00 Changeset [41271] by kov@webkit.org

2009-02-26 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix for building with GNOME Keyring enabled.

  • platform/network/soup/webkit-soup-auth-dialog.c: (show_auth_dialog):
14:45 Changeset [41270] by kov@webkit.org

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Add HTTP authentication dialog with optional GNOME Keyring
storage.

  • GNUmakefile.am:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::currentToplevelCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start):
  • platform/network/soup/webkit-soup-auth-dialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
  • platform/network/soup/webkit-soup-auth-dialog.h: Added.
13:11 Changeset [41269] by eric@webkit.org

2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

Reviewed by Dave Hyatt.

After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
started failing because Ojan's new code was now *correctly* calling through to
SVG asking for the closest text offset in the last line box, instead of
just returning the offset at the end of the last line box when clicking below a box.

But! The SVG code was wrong, in that it returned the character offset of the last
character when you asked for a character offset after the end of the box, instead
it should return the offset *after* the last character. This patch fixes
that behavior by reordering the last two clauses in svgCharacterHitsPosition.

The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
to document what's wrong. I've also cleaned up the code a bit so it's clearer
what it is doing (which also makes more obvious what's wrong with it).

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForCoordinates):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter): (WebCore::SVGInlineTextBox::closestCharacterToPosition): (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
12:40 Changeset [41268] by darin@chromium.org

2009-02-26 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Minor cleanup of ChromiumBridge:
Removing unused matchesMIMEType method and s/Javascript/JavaScript/

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
12:36 Changeset [41267] by hyatt@apple.com

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

Added fast/inline/vertical-align-text-bottom.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

  • fast/inline/vertical-align-text-bottom.html: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.checksum: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.txt: Added.
12:11 Changeset [41266] by krit@webkit.org

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
just to implement this three methods to support SVG Masking now.


Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
  • svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
  • svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.

LayoutTests:
Corrected some tests after the new SVG Masking implementation for Mac.

Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • svg/custom/mask-excessive-malloc.svg:
12:09 Changeset [41265] by treat@webkit.org

2009-02-26 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.

Test: http/tests/misc/slow-preload-cancel.html

https://bugs.webkit.org/show_bug.cgi?id=24133
Clear all pending preloads in the DocLoader object when we decide to
cancel its all requests.

  • loader/DocLoader.cpp: (WebCore::DocLoader::clearPendingPreloads):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
12:07 Changeset [41264] by andersca@apple.com

2009-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6623697>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::print): Ask the plug-in host to print, create a CGImage of the returned bytes and draw the image into the passed in context.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): When printing, call NetscapePluginInstanceProxy::print.


  • Plugins/Hosted/WebKitPluginHost.defs:
11:43 Changeset [41263] by dglazkov@chromium.org

2009-02-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24182
Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.

  • bindings/v8/custom/V8NodeFilterCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
11:40 Changeset [41262] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string

  • platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
11:35 Changeset [41261] by dglazkov@chromium.org

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Kevin McCullough.

Manual test for inspector node highlighting.

  • manual-tests/inspector/highlight-nodes.html: Added.
11:32 Changeset [41260] by darin@chromium.org

2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23973
ScrollView::scrollContents can be invoked during view shutdown. In
this scenario the FrameView::hostWindow method can return NULL, which
indicates that the frame/page is being destroyed. This causes a crash
when we try to dereference a NULL hostWindow pointer. Fix is to add a
NULL check for this.

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
11:11 Changeset [41259] by dglazkov@chromium.org

WebCore:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

Test: fast/block/positioning/absolute-in-inline-rtl-4.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues):

LayoutTests:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

  • fast/block/positioning/absolute-in-inline-rtl-4-expected.txt: Added.
  • fast/block/positioning/absolute-in-inline-rtl-4.html: Added.
10:59 Changeset [41258] by dglazkov@chromium.org

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=24202
Have drawNodeHighlight clip instead of clearing. This makes it work for
both Safari and Chromium since Chromium draws the inspector highlighting
in the same buffer as the page.

  • inspector/InspectorController.cpp: (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox):
10:45 Changeset [41257] by hyatt@apple.com

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.


Added fast/inline/inline-continuation-borders.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

  • fast/inline/inline-continuation-borders.html: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.checksum: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.png: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.txt: Added.
10:30 Changeset [41256] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24024
REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
archiving a submission to about:blank

I don't know how to make an automated test for this bug.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
  • WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be non-empty for non-HTTP requests.
10:21 Changeset [41255] by simon.fraser@apple.com

2009-02-26 Simon Fraser <simon.fraser@apple.com>

Build fix, no review.

Try to fix the wx build after r41218.

  • WebCoreSources.bkl:
10:19 Changeset [41254] by pam@chromium.org

2009-02-25 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test that custom DOM properties survive garbage collection.
https://bugs.webkit.org/show_bug.cgi?id=24142

  • fast/dom/Window/customized-property-survives-gc-expected.txt: Added.
  • fast/dom/Window/customized-property-survives-gc.html: Added.
10:17 Changeset [41253] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19527
ASSERTION FAILED: containerA && containerB

Test: fast/dom/Range/bug-19527.html

  • dom/Range.cpp: (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): Bring the behavior in line with current Firefox, making it impossible for these methods to pass a null container to compareBoundaryPoints().
09:08 Changeset [41252] by zecke@webkit.org

2009-02-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24099
ARM Compiler Warnings in pcre_exec.cpp

  • pcre/pcre_exec.cpp: (match):
08:48 Changeset [41251] by zecke@webkit.org

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Take marshallers to be built from a manually maintained list
instead of grepping the sources.

It's much faster, especially so now that we want to add
marshallers from WebCore too. A system to only take into account
the modified files when generating the marshallers from sources
could be hacked, but I think it's overkill considering how rarely
a new marshaller is added.

08:40 Changeset [41250] by zecke@webkit.org

Fix the ChangeLog s/frame/content.

I should have read more about the bug history and should have
done the substitution before landing.

08:33 Changeset [41249] by zecke@webkit.org

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24193
[GTK] Checkbuttons not activated with space

Do not swallow key events with GtkIMContext for non-editable
frames (FIXME: I don't think frame is the right name here).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleInputMethodKeydown):
08:27 Changeset [41248] by zecke@webkit.org

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24103
[GTK] Use correct return value for WebView button-release handler

We are returning whatever the core code tells us it did, but this
does not play well with the GTK+ model. GTK+ in general expects it
will see a button-release if it saw a button-press and no
motion/leave/etc events in between. EventHandler.cpp will, in some
cases, not handle press but handle release, confusing the parent
container of the WebView.

As a workaround return always FALSE for button-release (this is
the same than the Windows port does).

  • webkit/webkitwebview.cpp:
08:21 Changeset [41247] by zecke@webkit.org

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=17585
[gtk] get|set encoding api

Add functions to get and set a custom encoding an a view.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_set_custom_encoding): (webkit_web_view_get_custom_encoding):
  • webkit/webkitwebview.h:
08:14 Changeset [41246] by zecke@webkit.org

Make font-variant:small-caps work properly (bug #20358)

Set the computed size of the small caps font data rather than the specified size
so that the small-caps text is rendered smaller

06:13 Changeset [41245] by treat@webkit.org

2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24062
QNetworkCookieJar expects the url and not the policy url. Sending the
policy url will cause QNetworkCookieJar to behave incorrectly. One
example would be a cookie that does not have a path or domain.
QNetworkCookieJar will use the url it is given to fill in default values.
This allows setting cookies on the url of the main frame from an iFrame
when the cookie should be set on the url of the iFrame.

Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do

  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
03:09 Changeset [41244] by staikos@webkit.org

2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

make WebKit/Qt compile with SVG disabled

  • WebCore.pro:
  • platform/graphics/qt/FontPlatformDataQt.cpp:

02/25/09:

23:04 Changeset [41243] by cwzwarich@webkit.org

2009-02-25 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Gavin Barraclough.

Bug 24086: Regression (r40993): WebKit crashes after logging in to lists.zenbe
<https://bugs.webkit.org/show_bug.cgi?id=24086>
<rdar://problem/6625111>

The numeric sort optimization in r40993 generated bytecode for a function
without generating JIT code. This breaks an assumption in some parts of
the JIT's function calling logic that the presence of a CodeBlock implies
the existence of JIT code.

In order to fix this, we simply generate JIT code whenever we check whether
a function is a numeric sort function. This only incurs an additional cost
in the case when the function is a numeric sort function, in which case it
is not expensive to generate JIT code for it.

JavaScriptCore:

  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):

LayoutTests:

  • fast/js/resources/sort-no-jit-code-crash.js: Added.
  • fast/js/sort-no-jit-code-crash-expected.txt: Added.
  • fast/js/sort-no-jit-code-crash.html: Added.
20:31 Changeset [41242] by kov@webkit.org

2009-02-25 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. Add WebCore/workers to the list of paths
searched by the bindings generator perl script.

  • GNUmakefile.am:
19:45 Changeset [41241] by weinig@apple.com

2009-02-25 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add canvas to the list of RenderObjects that can mark a page as
visually not empty.

  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
18:19 Changeset [41240] by eric.carlson@apple.com

2009-02-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Dave Hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer as RenderMedia with controls always has a layer.
18:12 Changeset [41239] by simon.fraser@apple.com

2009-02-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Fix spew about a WebView being deallocated while key value observers are
still registered with it by making sure that we always stop observing
_isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: (-[DumpRenderTreeWindow close]):
17:24 Changeset [41238] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

Test: fast/gradients/background-clipped.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the destination rectangle passed to drawTiledImage() with the dirty rectangle. This makes it more likely for the destination rect to be contained in a single tile rect, which results in a faster code path being taken down the road (just drawing a single tile instead of tiling).

LayoutTests:

Reviewed by Simon Fraser.

  • fast/gradients/background-clipped.html: Added.
  • platform/mac/fast/gradients/background-clipped-expected.checksum: Added.
  • platform/mac/fast/gradients/background-clipped-expected.png: Added.
  • platform/mac/fast/gradients/background-clipped-expected.txt: Added.
16:35 Changeset [41237] by eric@webkit.org

2009-02-25 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix test regressions from positionForCoordinates patch.
https://bugs.webkit.org/show_bug.cgi?id=24148

  • rendering/RenderBlock.cpp: (WebCore::positionForPointWithInlineChildren): Remove ASSERT that placeholder text codepath is hitting.
16:27 Changeset [41236] by cfleizach@apple.com

Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
https://bugs.webkit.org/show_bug.cgi?id=24143

When an AX object is marked dirty, do not create AX elements while going up the parent chain.
Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
Make sure the AXObjectWrapper's have an object before calling them
In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists

16:16 Changeset [41235] by bdakin@apple.com

2009-02-25 Beth Dakin <bdakin@apple.com>

Reviewed by Geoff Garen.

Re-working of <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

Fixes a bunch of layout test failures I caused!

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::CSSParser::parseBorderImage):
15:59 Changeset [41234] by dglazkov@chromium.org

2009-02-25 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24174
Add more V8 custom bindings.

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added. (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName): (WebCore::NAMED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_SETTER):
  • bindings/v8/custom/V8DOMStringListCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8EventCustom.cpp: Added. (WebCore::ACCESSOR_SETTER): (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added. (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_SETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added. (WebCore::INDEXED_PROPERTY_GETTER): (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8NodeListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8StyleSheetListCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER):
15:52 Changeset [41233] by dglazkov@chromium.org

2009-02-25 Scott Violet <sky@google.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24171
Provides a RenderTheme method for getting the scroll bar size and
changes RenderListBox to use it. RenderTheme returns a size of regular,
and Mac's override to return small. Changes ScrollbarThemeChromium to
use the scrollbarsize of the scrollbar when getting the size
instead of passing in no-args.

  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::trackRect): (WebCore::ScrollbarThemeChromium::buttonSize):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::createScrollbar):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::scrollbarControlSizeForPart):
  • rendering/RenderThemeChromiumMac.h: (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
  • rendering/RenderThemeMac.h: (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
15:44 Changeset [41232] by ggaren@apple.com

JavaScriptCore:

2009-02-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/6611174> REGRESSION (r36701): Unable to select
messages on hotmail (24052)


The bug was that for-in enumeration used a cached prototype chain without
validating that it was up-to-date.


This led me to refactor prototype chain caching so it was easier to work
with and harder to get wrong.


After a bit of inlining, this patch is performance-neutral on SunSpider
and the v8 benchmarks.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_get_by_id_proto_list): Use the new refactored goodness. See lines beginning with "-" and smile.
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup): A shout out to const.
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next): We can use a pointer comparison to see if our cached structure chain is equal to the object's structure chain, since in the case of a cache hit, we share references to the same structure chain.
  • runtime/Operations.h: (JSC::countPrototypeChainEntriesAndCheckForProxies): Use the new refactored goodness.
  • runtime/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setShouldCache): (JSC::PropertyNameArray::shouldCache): Renamed "cacheable" to "shouldCache" to communicate that the client is specifying a recommendation, not a capability.


  • runtime/Structure.cpp: (JSC::Structure::Structure): No need to initialize a RefPtr. (JSC::Structure::getEnumerablePropertyNames): Moved some code into helper functions.

(JSC::Structure::prototypeChain): New centralized accessor for a prototype
chain. Revalidates on every access, since the objects in the prototype
chain may have mutated.

(JSC::Structure::isValid): Helper function for revalidating a cached
prototype chain.

(JSC::Structure::getEnumerableNamesFromPropertyTable):
(JSC::Structure::getEnumerableNamesFromClassInfoTable): Factored out of
getEnumerablePropertyNames.

  • runtime/Structure.h:
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):
  • runtime/StructureChain.h: (JSC::StructureChain::create): No need for structureChainsAreEqual, since we use pointer equality now. Refactored StructureChain to make a little more sense and eliminate special cases for null prototypes.

LayoutTests:

2009-02-24 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added a test for <rdar://problem/6611174> REGRESSION (r36701): Unable to
select messages on hotmail (24052)

  • fast/js/for-in-cached-expected.txt: Added.
  • fast/js/for-in-cached.html: Added.
  • fast/js/resources/for-in-cached.js: Added. (forIn):
14:58 Changeset [41231] by bdakin@apple.com

WebCore:

2009-02-25 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Null-check m_styleSheet

LayoutTests:

2009-02-25 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/6487249> repro crash in
WebCore::CSSParser::parseFillImage copying entire contents of this
page
-and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172

  • editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt: Added.
  • editing/pasteboard/copy-crash-with-extraneous-attribute.html: Added.
13:37 Changeset [41230] by treat@webkit.org

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build.

  • WebCore.pro:
12:59 Changeset [41229] by simon.fraser@apple.com

2009-02-25 Simon Fraser <simon.fraser@apple.com>

Build fix with ACCELERATED_COMPOSITING turned on.

I missed a spot in my last commit in renaming to
_stoppedAcceleratedCompositingForFrame:

  • WebView/WebHTMLView.mm: (-[WebHTMLView close]):
12:45 Changeset [41228] by treat@webkit.org

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Alexey Proskuryakov.

Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open):
12:39 Changeset [41227] by jmalonzo@webkit.org

2009-02-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

Add files to the build per r41218.
Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp

  • GNUmakefile.am:
  • page/DOMWindow.cpp:
12:29 Changeset [41226] by kov@webkit.org

2009-02-25 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24043
When faced with URLs with unsupported protocol on Gtk port,
report the error through an idle function and return true, so
a proper resource handle is created.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start):
12:22 Changeset [41225] by sfalken@apple.com

Windows build fix.
Use struct to forward declare ResourceRequest.

  • history/HistoryItem.h:
  • inspector/InspectorController.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h:
  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.h:
  • platform/CrossThreadCopier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.h:
  • platform/network/cf/ResourceRequestCFNet.h:
  • xml/XMLHttpRequest.h:
12:12 Changeset [41224] by simon.fraser@apple.com

2009-02-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23854

Make an observable property, _isUsingAcceleratedCompositing, on
WebView that DumpRenderTree can use to specialize behavior.

This is implemented via a count of Frames that are using
accelerated compositing.

11:56 Changeset [41223] by alp@webkit.org

2009-02-25 Andreia Gaita <shana@jitted.com>

Reviewed by Alp Toker.

Update Win def files with recent JavaScriptCore API additions.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_Cairo.def:
  • WebKit.vcproj/WebKit_debug.def:
11:50 Changeset [41222] by sfalken@apple.com

Partial Windows build fix.


  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
11:43 Changeset [41221] by krit@webkit.org

2009-02-25 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Ported arcTo to Qt. Qt has no native support for arcTo. This changes
calculate the behavior of arcTo and draws it with lineTo and arc.

[QT] implement Canvas arcTo
https://bugs.webkit.org/show_bug.cgi?id=23873

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):
11:29 Changeset [41220] by simon.fraser@apple.com

2009-02-25 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

Remove idl files from Resources, and sort.

  • WebCore.xcodeproj/project.pbxproj:
11:11 Changeset [41219] by sfalken@apple.com

Use timeBeginPeriod to enable timing resolution greater than 16ms in command line jsc for Windows.
Allows more accurate reporting of benchmark times via command line jsc.exe. Doesn't affect WebKit's use of JavaScriptCore.


Reviewed by Adam Roben.

  • jsc.cpp: (main):
11:09 Changeset [41218] by cmarrin@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=23943

Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
the window object. Also added WebKitPoint object, which is passed in and out
of these functions.

10:06 Changeset [41217] by levin@chromium.org

2009-02-25 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
https://bugs.webkit.org/show_bug.cgi?id=24145

  • platform/CrossThreadCopier.cpp:
  • platform/CrossThreadCopier.h:
10:06 Changeset [41216] by levin@chromium.org

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23688: ThreadableLoader needs a sync implementation for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=23688>

No observable change in behavior, so no test.

  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::clearClient): (WebCore::ThreadableLoaderClientWrapper::done): (WebCore::ThreadableLoaderClientWrapper::didFinishLoading): (WebCore::ThreadableLoaderClientWrapper::didFail): (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck): (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): Expose whether the loader is done (based on what callbacks were done).
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Each loader is given its own mode so that only its callbacks get through the run loop.

The xhr spec says that the readystatechange events are synchronous, so in the case of a
nested sync xhr no readystatechange events should be fired for the outer xhr.

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):

  • loader/WorkerThreadableLoader.h: (WebCore::WorkerThreadableLoader::create): (WebCore::WorkerThreadableLoader::done):
  • workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::WorkerRunLoop):
  • workers/WorkerRunLoop.h: (WebCore::WorkerRunLoop::createUniqueId): Simple method to create a uniqueId on demand with respect to the run loop.
  • workers/WorkerThread.h:
10:06 Changeset [41215] by levin@chromium.org

WebCore:

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<https://bugs.webkit.org/show_bug.cgi?id=24089>

Make threadable loader callbacks to happen during the sync load call.

Changes the behavior of sync xhr for insecure redirects in two ways:
+ Sends an error event instead of an abort event (which is the same as async xhr's behavior).
+ Throws a network exception which is what other browsers do and what the spec
says to do (http://www.w3.org/TR/XMLHttpRequest/).

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp: (WebCore::ThreadableLoader::loadResourceSynchronously):
  • loader/ThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::loadRequestSynchronously): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFailRedirectCheck):
  • xml/XMLHttpRequest.h:

LayoutTests:

2009-02-25 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
<https://bugs.webkit.org/show_bug.cgi?id=24089>

Modified the test to account for behavior change and output more information to better detect
future changes in behavior.

  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt:
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html:
09:55 Changeset [41214] by cmarrin@apple.com

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23368

Added logic to correctly hit test accelerated layers.

09:01 Changeset [41213] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24067
REGRESSION: Crash in WebCore::Document::initSecurityContext

The crash started to happen when we removed a check for frame->document() being null.
However, the original document shouldn't be null here, because it is needed to alias
security origins. So, this patch fixes the crash by correcting security origin behavior.

Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
This tests for not crashing, and for inheriting the domain from the document being replaced.
Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
domain to remove a prefix from.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before clearing the frame, so that Document::initSecurityContext() could access the old one.
08:58 Changeset [41212] by darin@chromium.org

2009-02-25 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24066

Items in drop-downs were not painted correctly. Makes sure the
PopupListBox invalidates in the coordinates of the window as this is
FramelessScrollView::invalidateRect paints to.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::invalidateRow):
08:14 QtWebKitContrib edited by henrique@bastos.net
added Zack Rusin's irc nickname (diff)
06:12 Changeset [41211] by treat@webkit.org

2009-02-25 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Zack Rusin.

https://bugs.webkit.org/show_bug.cgi?id=24158
Implement the queue*() methods of the layoutTestController and begin
implementing the dump of the back/forward list. This results in 2% more
tests passing as well as 23 currently skipped tests now passing.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dumpBackForwardList): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/jsobjects.cpp: (findFrameNamed): (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::reset): (LayoutTestController::processWork): (LayoutTestController::maybeDump): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript):
  • DumpRenderTree/qt/jsobjects.h: (LayoutTestController::shouldDumpBackForwardList): (LayoutTestController::dumpBackForwardList):
04:12 Changeset [41210] by hausmann@webkit.org

2009-02-25 Kavindra Palaraja <kavindra.palaraja@nokia.com>

Reviewed by Simon Hausmann.

Fix the documentation for the linkHovered signal.

  • Api/qwebpage.cpp:
Note: See TracTimeline for information about the timeline view.