Timeline


and

03/03/09:

23:20 Changeset [41418] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage

  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):
22:49 Changeset [41417] by ddkilzer@apple.com
  • 11 edits in trunk

<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

Reviewed by Mark Rowe.

JavaScriptCore:

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
  • WebCore.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • WebKit.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
22:09 Changeset [41416] by darin@chromium.org
  • 6 edits
    2 moves in trunk/WebCore

2009-03-02 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: Switch to using Skia to render widgets.

In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.

Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.

https://bugs.webkit.org/show_bug.cgi?id=24244

  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
  • platform/graphics/skia/PlatformContextSkia.h:
  • rendering/RenderThemeChromiumGtk.cpp: Removed.
  • rendering/RenderThemeChromiumGtk.h: Removed.
  • rendering/RenderThemeChromiumLinux.cpp: Added.
  • rendering/RenderThemeChromiumLinux.h: Added.
21:39 Changeset [41415] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.

Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

  • bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.
17:10 Changeset [41414] by andersca@apple.com
  • 7 edits in trunk

WebCore:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Null check NPStream before dereferencing it.


  • plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Add destroyNullStream test function to the test plug-in.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):

LayoutTests:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari


Update tests.

  • plugins/destroy-stream-twice-expected.txt:
  • plugins/destroy-stream-twice.html:
17:06 Changeset [41413] by eric.carlson@apple.com
  • 117 edits in trunk/LayoutTests

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.


https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging


Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.

  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/broken-video-expected.txt:
  • media/broken-video.html:
  • media/constructors-expected.txt:
  • media/constructors.html:
  • media/loopend-limits-expected.txt:
  • media/loopstart-limits-expected.txt:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks-expected.txt:
  • media/unsupported-tracks.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-autoplay-expected.txt:
  • media/video-autoplay.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-autoplay.html:
  • media/video-dom-end-expected.txt:
  • media/video-dom-end.html:
  • media/video-dom-loopcount-expected.txt:
  • media/video-dom-loopcount.html:
  • media/video-dom-loopend-expected.txt:
  • media/video-dom-loopend.html:
  • media/video-dom-loopstart-expected.txt:
  • media/video-dom-loopstart.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-dom-start-expected.txt:
  • media/video-dom-start.html:
  • media/video-end-expected.txt:
  • media/video-end.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
  • media/video-load-readyState-expected.txt:
  • media/video-load-readyState.html:
  • media/video-loopcount-expected.txt:
  • media/video-loopcount.html:
  • media/video-loopend-expected.txt:
  • media/video-loopend.html:
  • media/video-loopstart-expected.txt:
  • media/video-loopstart.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-empty-events.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-events.html:
  • media/video-poster-expected.txt:
  • media/video-poster.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-size-expected.txt:
  • media/video-size.html:
  • media/video-source-expected.txt:
  • media/video-source-media-expected.txt:
  • media/video-source-media.html:
  • media/video-source-type-expected.txt:
  • media/video-source-type-params-expected.txt:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-src-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-remove.html:
  • media/video-src-set-expected.txt:
  • media/video-src-set.html:
  • media/video-src-source-expected.txt:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-start-expected.txt:
  • media/video-start.html:
  • media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
  • media/video-volume-expected.txt:
  • media/video-volume.html:
  • media/video-width-height-expected.txt:
  • media/video-width-height.html:
16:44 Changeset [41412] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
16:38 Changeset [41411] by kmccullough@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function

  • This no longer happens but I thought I'd make a test case anyway.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
  • fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):
16:08 Changeset [41410] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-03-03 Kevin McCullough <kmccullough@apple.com>

  • Spelling fix.
  • page/Console.cpp: (WebCore::Console::profile):
15:30 Changeset [41409] by ddkilzer@apple.com
  • 4 edits in trunk/WebKit

Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

Reviewed by Adam Roben.

Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.
14:57 Changeset [41408] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.

  • WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
14:47 Changeset [41407] by kmccullough@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.

WebCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • fast/profiler/profile-with-no-title-expected.txt: Added.
  • fast/profiler/profile-with-no-title.html: Added.
14:27 Changeset [41406] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add bug URLs for my last commit.

14:25 Changeset [41405] by pam@chromium.org
  • 1 edit
    6 deletes in trunk/LayoutTests

2009-03-03 Pamela Greene <pam@chromium.org>

Remove junk files that must have been accidentally committed.
Submitted without review.

  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.
14:24 Changeset [41404] by timothy@apple.com
  • 8 edits
    1 add in trunk/WebCore

Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-dir.html

  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
  • inspector/front-end/inspector.css: Tweak styles to look and work correctly.
  • inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
  • page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
13:07 Changeset [41403] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.

Makes sure a node is in the document during a move before using it.

Test: fast/events/crash-on-mutate-during-drop.html

  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop

Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.

  • fast/events/crash-on-mutate-during-drop-expected.txt: Added.
  • fast/events/crash-on-mutate-during-drop.html: Added.
11:53 Changeset [41402] by dglazkov@chromium.org
  • 4 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
11:48 Changeset [41401] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Adding new files related to WebKitDownload to the GTK+ port.

  • GNUmakefile.am:

WebCore:

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
  • webkit/webkitdownload.h: Added.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
11:29 Changeset [41400] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6633834>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.
11:18 Changeset [41399] by dglazkov@chromium.org
  • 2 edits
    4 copies
    1 add in trunk/WebCore

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

  • bindings/v8/custom/V8AttrCustom.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
  • bindings/v8/custom/V8ElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
11:08 Changeset [41398] by beidson@apple.com
  • 15 edits
    3 adds in trunk

WebCore:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6616664> - Quick looks of various file types is broken

In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Support layout test covering <rdar://problem/6616664>

Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.


  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

Added to test the changes:

  • fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • fast/loader/main-document-url-for-non-http-loads.html: Added.
  • fast/loader/resources/subframe-notify-done.html: Added.

Updated the following for the new info from dumpResourceLoadCallbacks():

  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac-leopard/security/block-test-expected.txt:
  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • security/block-test-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
10:55 Changeset [41397] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24256

Added a WebCoreForceSoftwareAnimation flag.

10:48 Changeset [41396] by cmarrin@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24257

Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.

10:46 Changeset [41395] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Create and update the action for SelectAll.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):
10:38 Changeset [41394] by dglazkov@chromium.org
  • 1 edit
    4 adds in trunk/WebCore

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.

  • bindings/v8/V8Binding.h: Added.
  • bindings/v8/V8Proxy.h: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added.
  • bindings/v8/custom/V8CustomEventListener.h: Added.
10:33 Changeset [41393] by dglazkov@chromium.org
  • 1 edit
    20 adds in trunk/LayoutTests

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.

css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html

On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.

  • fast/block/float/resources/se_arrow.png: Added.
  • fast/block/float/resources/yinyang.png: Added.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.
10:21 Changeset [41392] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:20 Changeset [41391] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog dates.

10:18 Changeset [41390] by dglazkov@chromium.org
  • 2 edits
    2 moves
    1 add in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1

  • Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
  • Adjust WebCore.vcproj accordingly.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/opentype: Added.
  • platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
  • platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
  • platform/graphics/win/OpenTypeUtilities.cpp: Removed.
  • platform/graphics/win/OpenTypeUtilities.h: Removed.
10:10 Changeset [41389] by simon.fraser@apple.com
  • 6 edits in trunk/WebCore

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Take 3D transforms into account when hit testing:

  1. Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.
  1. Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.

It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.

  1. Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.

The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.

09:54 Changeset [41388] by brettw@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog from last commit.

09:52 Changeset [41387] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
  • rendering/RenderObject.h:
09:50 Changeset [41386] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-03-02 Brett Wilson <brettw@chromium.org>

Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,

Reviewed by Darin Disher.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):
09:43 Changeset [41385] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24317

Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
09:31 Changeset [41384] by kov@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

09:26 Changeset [41383] by kov@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-03-03 Onne Gorter <onne.gorter@avinity.net>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed

Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.

manual test: manual-tests/gtk/plugin-resize-scroll.html

  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup
08:45 Changeset [41382] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=4343
XMLHttpRequest doesn't work in a JavaScript-created window

The problem was fixed a while ago (r34506), just adding a test.

  • http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
  • http/tests/xmlhttprequest/request-from-popup.html: Added.
08:44 Changeset [41381] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Adding bug URL and title to ChangeLog for a recent check-in.

08:06 Changeset [41380] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

  • dom/Document.idl:
  • html/HTMLCanvasElement.idl:

03/02/09:

22:15 Changeset [41379] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson

https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
18:24 Changeset [41378] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Scripts/build-webkit:
18:12 Changeset [41377] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Fix https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):
17:51 Changeset [41376] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

WebKit part of <rdar://problem/6638658>.


  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.


  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.


(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.
17:47 Changeset [41375] by weinig@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
  • page/Geolocation.h: (WebCore::Geolocation::):
  • platform/GeolocationService.cpp:
  • platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
  • platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
  • platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

Add SPI to ask the embedding application whether to allow
Geolocation for an origin.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
  • WebView/WebUIDelegatePrivate.h:
17:36 Changeset [41374] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Fix PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):
17:36 UsingGitWithWebKit edited by ojan@chromium.org
(diff)
16:20 Changeset [41373] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop

16:14 Changeset [41372] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan, Ada Chan.

Factor loading code out into its own method and get rid of a bunch of goots.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):
16:00 Changeset [41371] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Build fix.

  • Plugins/WebNetscapeDeprecatedFunctions.h:
15:58 Changeset [41370] by andersca@apple.com
  • 2 edits in trunk/WebKit

2009-03-02 Anders Carlsson <andersca@apple.com>

WebNetscapePluginPackage.mm is an Objective-C++ file.

  • WebKit.xcodeproj/project.pbxproj:
15:53 Changeset [41369] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

  • Plugins/WebNetscapePluginPackage.m: Removed.
  • Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.
15:29 Changeset [41368] by kevino@webkit.org
  • 11 edits in trunk

Build fixes for wxWidgets Mac trunk build.

15:25 Changeset [41367] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wxGTK missing header build fix.

13:55 Changeset [41366] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.
13:38 Changeset [41365] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a regression caused by splitting the input and output of console commands.

https://bugs.webkit.org/show_bug.cgi?id=24293

Reviewed by Kevin McCullough.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
13:38 Changeset [41364] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make exception messages and logged Error objects display consistently.

https://bugs.webkit.org/show_bug.cgi?id=18983

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Remove a string for line numbers.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
  • inspector/front-end/inspector.css: Tweaks to the styles.
13:38 Changeset [41363] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Allow for multiline quoted text in JavaScript files when looking for function names.

https://bugs.webkit.org/show_bug.cgi?id=24296

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog:
11:16 Changeset [41362] by levin@chromium.org
  • 10 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Bug 24048: extra windows button padding doesn't apply when there's no appearance
<https://bugs.webkit.org/show_bug.cgi?id=24048>

Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

No tests added as existing tests already cover this behavior.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
  • rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumGtk.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeWin.h:
10:26 Changeset [41361] by treat@webkit.org
  • 5 edits in trunk

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

  • Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.h:
08:55 Changeset [41360] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
08:30 Changeset [41359] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt port. Remove unnecessary assert.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
07:37 Changeset [41358] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
06:56 Changeset [41357] by kov@webkit.org
  • 4 edits in trunk

2009-03-02 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.

  • GNUmakefile.am:
06:38 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:38 Changeset [41356] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-03-02 Dirk Schulze <krit@webkit.org>

Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.

06:22 Changeset [41355] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

Added putImageData to Qt.

[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
05:26 Changeset [41354] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix after r41349

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):
00:22 Changeset [41353] by timothy@apple.com
  • 2 edits in trunk/WebCore

Show exception messages again when evaluating bad expressions in the
Web Inspector's console.

https://bugs.webkit.org/show_bug.cgi?id=19890

Reviewed by Oliver Hunt.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.
00:22 Changeset [41352] by timothy@apple.com
  • 3 edits
    1 add in trunk/WebCore

Make input in the Web Inspector console print before any output
that might be added by the called function.

https://bugs.webkit.org/show_bug.cgi?id=19931

Reviewed by Oliver Hunt.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
  • inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.

03/01/09:

21:46 Changeset [41351] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

Fix the Mac build.

20:18 Changeset [41350] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

<rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define it as a preprocessor macro by modifying GCC_PREPROCESSOR_DEFINITIONS.
  • JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate DTrace header" script phase to check for HAVE_DTRACE instead of MACOSX_DEPLOYMENT_TARGET.
  • wtf/Platform.h: Removed definition of HAVE_DTRACE macro since it's defined in Base.xcconfig now.
18:55 Changeset [41349] by cfleizach@apple.com
  • 6 edits in trunk

Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>

16:45 Changeset [41348] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6449689>

Pass the visible name to the plug-in host.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
16:41 Changeset [41347] by levin@chromium.org
  • 19 edits in trunk

2009-03-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
<https://bugs.webkit.org/show_bug.cgi?id=24251>

Make RenderObject::positionForCoordinate non-virtual and
RenderObject::positionForPoint virtual in preparation for
removing positionFor* from RenderObject/RenderText.

  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::positionForPoint):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
  • rendering/RenderText.h:
16:41 Changeset [41346] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-01 Larry Ewing <lewing@novell.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds

Make sure to cast the value to the correct type so that only
memory owned by the value is written to.

  • plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
  • plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): (PluginView::getValue):
16:41 Changeset [41345] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-03-01 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24197 and
https://bugs.webkit.org/show_bug.cgi?id=23512

The Windows version of cgColor() is conditionally compiled using
!PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
can use the OS X version instead of the Windows version.

Also rename cgColor() -> createCGColor()

No observable change in behavior, so no test.

  • platform/graphics/Color.h:
  • platform/graphics/cg/ColorCG.cpp: (WebCore::createCGColor):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/ColorMac.mm: (WebCore::createCGColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::GraphicsLayerCA::setBackgroundColor):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm: (WebCore::ciColor):
13:09 Changeset [41344] by levin@chromium.org
  • 17 edits
    9 adds in trunk

WebCore:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Tests: http/tests/xmlhttprequest/workers/methods-async.html

http/tests/xmlhttprequest/workers/methods.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::getOwnPropertySlot): (jsWorkerContextBaseXMLHttpRequest): (setJSWorkerContextBaseXMLHttpRequest): Expose XMLHttpRequest to Workers.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::constructXMLHttpRequest): (WebCore::JSXMLHttpRequestConstructor::mark): Removed the dependencies on Document.
  • bindings/js/JSXMLHttpRequestConstructor.h: (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
  • dom/EventException.idl:
  • dom/EventListener.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): Fixed identifier to be unsigned long.
  • loader/WorkerThreadableLoader.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
  • xml/XMLHttpRequestUpload.cpp:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.

LayoutTests:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Some sanity checks for xhr done from workers. These are the same as
tests done for normal workers.

  • http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods-async.html: Added.
  • http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods.html: Added.
  • http/tests/xmlhttprequest/workers/resources/methods-async.js: Added. (onmessage): (log): (done): (onReqAbort): (onSyncReqError): (start): (processStateChange):
  • http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
  • http/tests/xmlhttprequest/workers/resources/methods.js: Added. (log): (done):
12:14 Changeset [41343] by timothy@apple.com
  • 1 edit in trunk/JavaScriptCore/parser/Nodes.h

Build fix. Add isBlock() back since there was a new client since the patch was made.

11:37 Applications using WebKit edited by todd.ditchendorf@gmail.com
(diff)
11:35 Changeset [41342] by timothy@apple.com
  • 4 edits
    5 adds in trunk

JavaScriptCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.

Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
  • parser/Nodes.h:

WebCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

Adding manual debugger test cases for bug.

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-while-statements.html: Added.
  • manual-tests/inspector/resources/loop-statements.js: Added.
11:22 Changeset [41341] by jmalonzo@webkit.org
  • 7 edits in trunk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Determine the frame's response and decide whether to dump as text
or the render tree

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Enable http tests, excluding tests/folders that fail or untested

  • platform/gtk/Skipped:
11:21 Changeset [41340] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKitTools

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Implement dumping of WebKitWebBackForwardList and its history
items.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (compareHistoryItems): (dumpHistoryItem): (dumpBackForwardListForWebView): (dump): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList):
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (BackForwardItem::invoke):
11:21 Changeset [41339] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
necessary.
Add necessary API additions for us to be able to dump a WebKitWebHistoryItem

  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): (WebKit::core): (WebKit::kit):
11:02 Changeset [41338] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

Test: fast/events/scroll-during-zoom-change.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Pause scheduled events during style reclaculation. Changes to the zoom property result in scroll events being generated during style recalc, and those events need to be deferred until the render tree is consistent.
  • page/FrameView.cpp: (WebCore::FrameView::layout): Changed to account for a case in which the post-layout tasks trigger a nested layout, which reactivates the post-layout task timer.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
  • fast/events/scroll-during-zoom-change-expected.txt: Added.
  • fast/events/scroll-during-zoom-change.html: Added.
11:00 Changeset [41337] by christian@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
  • webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' properties as well as webkit_web_view_get_encoding.
10:47 Changeset [41336] by christian@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
08:53 Changeset [41335] by timothy@apple.com
  • 3 edits in trunk/WebCore

Alphabetically sort scripts in the Script's panel file popup menu.

https://bugs.webkit.org/show_bug.cgi?id=23395

Reviewed by Timothy Hatcher.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  • inspector/front-end/utilities.js: (insertionIndexForObjectInListSortedByFunction): (indexOfObjectInListSortedByFunction):
08:42 Changeset [41334] by timothy@apple.com
  • 3 edits in trunk/WebCore

Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
when creating databases, localStorage or sessionStorage. Changing document.domain
should have no affect on databases, localStorage and sessionStorage in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23844

Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::didUseDOMStorage):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
08:22 Changeset [41333] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Avoid leaking errors when reporting GIO errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
08:21 Changeset [41332] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Fixes crash when the GIO backend is given the URI for a directory.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile):
08:04 Changeset [41331] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Simple wording fix for the NEWS file.

07:39 Changeset [41330] by christian@webkit.org
  • 2 edits in trunk

2009-03-01 Christian Dywan <christian@twotoasts.de>

  • configure.ac: Bump GTK port version to 1.1.1.
07:38 Changeset [41329] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk

2009-03-01 Xan Lopez <xan@gnome.org>

Add NEWS file to track progress between releases.

  • NEWS: Added.
07:29 Changeset [41328] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.

  • Scripts/webkitdirs.pm:
07:28 Changeset [41327] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

Add a GTK+-only option to enable GNOME Keyring when building.

  • Scripts/build-webkit:

02/28/09:

22:21 Changeset [41326] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076

Refactor gtk lib detection and put it in builtDylibPathForName

  • Scripts/webkitdirs.pm:
21:28 Changeset [41325] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
Test: traversal/exception-forwarding.html
TesT: traversal/stay-within-root.html

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto.
20:27 Changeset [41324] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Remove dubious checks, left over from

incomplete conversion of parameter from pointer to pass-by-ref.

(WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
(WebCore::NAMED_PROPERTY_SETTER): Ditto.

18:47 Changeset [41323] by mitz@apple.com
  • 3 edits in trunk/LayoutTests
  • correct a color profile mismatch in expected pixel results
  • platform/mac/fast/gradients/background-clipped-expected.checksum:
  • platform/mac/fast/gradients/background-clipped-expected.png:
12:29 Changeset [41322] by christian@webkit.org
  • 2 edits in trunk/WebCore

Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

12:12 Changeset [41321] by christian@webkit.org
  • 2 edits in trunk/WebKitTools

Use the new webkit_web_view_load_uri to open URIs.

12:04 Changeset [41320] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk
  • webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a

locale path is passed for compatibility, since we used to support that.

06:43 Changeset [41319] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24226
[SOUP] HTTP status text is never set

Set HTTP status text to SoupMessage reason_phrase.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
02:01 Changeset [41318] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix malformed project file
  • WebCore.xcodeproj/project.pbxproj:
01:44 Changeset [41317] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/layers/inline-dirty-z-order-lists.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): Moved the code that dirties a layer's and its stacking context's z-order lists when the layer's z-index or visibility change from here...
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that it will apply to RenderInline too.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/layers/inline-dirty-z-order-lists.html: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
00:45 Changeset [41316] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Alice Liu <alice.liu@apple.com>

Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
extension to images that already have .jpg extension

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm: (-[NSString matchesExtensionEquivalent:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Relax the check for the proper extension to allow for known equivalents, special-cased in matchesExtensionEquivalent function.
00:06 Changeset [41315] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by David Hyatt.

Don't include TextResourceDecoder.h in Document.h

This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

02/27/09:

19:44 Changeset [41314] by kov@webkit.org
  • 2 edits in trunk

2009-02-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
file to EXTRA_DIST to fix make dist.

  • GNUmakefile.am:
18:21 Changeset [41313] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by David Hyatt.

Automatically ignore empty requests to avoid crashing. This fixes
the crash in fast/loader/empty-embed-src-attribute.html.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
17:28 Changeset [41312] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.

Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
"Fixed elements have 0 as an offsetLeft property"


Code also brings offsetLeft/Top in full conformance with the spec.
Added two tests, one for fixed-position elements, and one for <html>.


Tests: fast/dom/Element/fixed-position-offset-parent.html

fast/dom/Element/offsetLeft-offsetTop-html.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.


Added two tests:

  1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
  2. Tests offsetLeft and offsetTop on static and positioned <html> elements.
  • fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
  • fast/dom/Element/fixed-position-offset-parent.html: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html.html: Added.
17:13 Changeset [41311] by dino@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Pixel tests for previous commit
https://bugs.webkit.org/show_bug.cgi?id=24252

  • platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
  • platform/mac/transforms/no_transform_hit_testing-expected.png: Added.
17:07 Changeset [41310] by dino@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt

Forgot -expected file from last commit :(

17:05 Changeset [41309] by dino@apple.com
  • 3 edits
    1 add in trunk

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

renderer()->hasTransform() returns true for elements
with perspective, but no transform, so test for transform
when hit testing. This fixes ASSERT from
https://bugs.webkit.org/show_bug.cgi?id=24252

Test: transforms/no_transform_hit_testing.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
16:01 Changeset [41308] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

Fix scrubbing error -- a reversed condition.

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
15:46 Changeset [41307] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

15:39 Changeset [41306] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.28.3

New tag.

15:29 Changeset [41305] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add confirmMessageFromWorkerObject to WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=24152

  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
14:46 Changeset [41304] by andersca@apple.com
  • 9 edits in trunk/WebCore

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
because it leads to assertion failures in the Mac port.


  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
14:37 Changeset [41303] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

<rdar://problem/6631436>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55


Port the NPN_Evaluate code over from WebCore instead of using the frame loader.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):
14:24 Changeset [41302] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebPreferenceKeysPrivate.h

Remove mysterious @ sign to fix Windows build.

14:15 Changeset [41301] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebView.cpp

Attempt to fix Windows build.

13:58 Changeset [41300] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6626814>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): Make InvokeDefault async.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Handle passing NPObjects back to the plug-in host.


  • Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::objectID): Add objectID getter.


  • Plugins/Hosted/WebKitPluginClient.defs: Make InvokeDefault a simpleroutine.
13:53 Changeset [41299] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes an exception by null checking the WebResource before adding it to
the subresources array.

<rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

Reviewed by Geoff Garen and Anders Carlsson.

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Null check the WebResource before adding it.
13:01 Changeset [41298] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Adds a workaround for Automator creating a WebView from a secondary thread.

<rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

Reviewed by Geoff Garen.

  • WebView/WebView.mm: (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.
12:52 Changeset [41297] by abarth@webkit.org
  • 17 edits in trunk

WebCore:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20249

Add a preference to allow universal access from local URLs to mitigate
some attacks. Some clients still want to allow this access, so we
expose this as a preference.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileUrls]): (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileUrls): (WebPreferences::setAllowUniversalAccessFromFileUrls):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:47 Changeset [41296] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
12:42 Changeset [41295] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
12:35 Changeset [41294] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Dirk Schulze <krit@webkit.org>

Reviewed by Zack Rusin.

Added support for gradients and pattern on Fonts for Qt.

[Qt] gradients and patterns for FontQt
https://bugs.webkit.org/show_bug.cgi?id=24243

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
12:02 Changeset [41293] by simon.fraser@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

https://bugs.webkit.org/show_bug.cgi?id=24242

setCursor(), and resetCursorRects() on Tiger, were using global, not local
coordinates for elementAtPoint:

  • WebView/WebHTMLView.mm: (resetCursorRects): (setCursor):
11:50 Changeset [41292] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-02-27 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24213: Web Worker: Worker4 test: onmessage will never be called
<https://bugs.webkit.org/show_bug.cgi?id=24213>

  • fast/workers/worker-terminate-expected.txt:
  • fast/workers/worker-terminate.html: Added a log entry to the onmessage handler for worker4 to make it visible that the handler was called and removed the terminate call that happened outside of onmessage.
11:50 Changeset [41291] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
https://bugs.webkit.org/show_bug.cgi?id=24113

  • workers/WorkerMessagingProxy.cpp:
11:29 Changeset [41290] by timothy@apple.com
  • 1 add in trunk/WebCore/inspector/front-end/DOMStorageDataGrid.js

Commit a missing file.

10:56 Changeset [41289] by timothy@apple.com
  • 5 edits in trunk/WebCore

Added a refresh button to storage views.

https://bugs.webkit.org/show_bug.cgi?id=24040

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype.get statusBarItems): (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/inspector.css:
10:28 Changeset [41288] by timothy@apple.com
  • 7 edits in trunk/WebCore

Added support for editing/deleting localStorage and sessionStorage items
directly from Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23866.

Reviewed by Timothy Hatcher.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DOMStorageDataGrid.js: Added. (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._ondblclick): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
09:42 Changeset [41287] by brettw@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

08:23 Changeset [41286] by dglazkov@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-02-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24211
Add ScheduledAction for V8.

  • bindings/v8/ScheduledAction.cpp: Added. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: Added. (WebCore::ScheduledAction::ScheduledAction):
06:59 Changeset [41285] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Zack Rusin <zack@kde.org>

Reviewed by Nikolas Zimmermann.

Qt: be more reasonable about scrolled lines

cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll

  • platform/qt/WheelEventQt.cpp:
03:30 Changeset [41284] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-27 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24221
[GTK] Do not emit load-finished when being disposed

webkit_web_view_stop_load() is called from dispose() on
WebKitWebView. This eventually calls postProgressFinishedNotification
in FrameLoaderClientGtk, which emits load-finished. Add
a 'disposing' flag to WebView that we can check here, so
we avoid emitting signals on objects on their way to be
destroyed. This fixes a bunch of critical warnings when
closing a loading WebView.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
03:18 Changeset [41283] by jmalonzo@webkit.org
  • 10 edits in trunk

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::setSubMenu):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::retainPlatformWidget):
  • platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
03:12 Changeset [41282] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r41070.

03:12 Changeset [41281] by mrowe@apple.com
  • 13 edits in branches/Safari-3-2-branch

Merge r41190.

03:12 Changeset [41280] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

00:20 Changeset [41279] by krit@webkit.org
  • 3 edits in trunk/WebCore

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Added support for Gradients and Patterns on filled or stroked Fonts
in Cairo. I also added support for globalAlpha on FontCairo.

[CAIRO] SVG/Canvas fonts miss gradients/pattern support
https://bugs.webkit.org/show_bug.cgi?id=18617

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
Note: See TracTimeline for information about the timeline view.