Timeline


and

03/06/09:

20:58 Changeset [41508] by barraclough@apple.com

2009-03-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

When preforming an op_mov, preserve any existing register mapping.

~0.5% progression on v8 tests x86-64.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
16:26 Changeset [41507] by pkasting@chromium.org

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24405
Horizontal scrolling on Windows was reversed from Mac (and intuition).

  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
16:15 Changeset [41506] by mrowe@apple.com

Versioning.

15:47 Changeset [41505] by pkasting@chromium.org

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Sam Weinig.

Convert some C-style casts to static_cast<>()s.

  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
15:05 Changeset [41504] by mrowe@apple.com

Versioning.

15:03 Changeset [41503] by mrowe@apple.com

New tag.

15:01 Changeset [41502] by darin@apple.com

2009-03-06 Darin Adler <darin@apple.com>

Fixed broken test I just landed for bug 24422.

  • fast/dom/location-new-window-no-crash-expected.txt: Updated.
  • fast/dom/resources/location-new-window-no-crash.js: Added code to make the window opening and closing work in DumpRenderTree.
14:12 Changeset [41501] by adele@apple.com

2009-03-06 Adele Peterson <adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)

I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.

  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element. That is no longer true, so we should return the document element for a truly empty document.
13:32 Changeset [41500] by darin@chromium.org

2009-03-06 Jay Campan <jcampan@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24306

Adding a flag to ResourceRequestBase to indicate whether or not upload
progress notifications are needed for a resource. This is useful to
avoid sending these notifications when there are no consumers
(especially in the Chromium case where IPC is involved).

  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::reportUploadProgress): (WebCore::ResourceRequestBase::setReportUploadProgress): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
13:21 Changeset [41499] by dimich@chromium.org

WebCore:

2009-03-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test: http/tests/workers/text-encoding.html

  • dom/Document.cpp: (WebCore::Document::encoding):
  • dom/Document.h: (WebCore::Document::inputEncoding): (WebCore::Document::charset): (WebCore::Document::characterSet): Add new virtual method and route DOM synonym functions on Document through it.
  • dom/ScriptExecutionContext.h:
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::encoding): (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
  • workers/WorkerContext.h: (WebCore::WorkerContext::create):
  • workers/WorkerContextProxy.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • workers/WorkerThread.h: All of the above route the 'encoding' parameter of parent context to the new instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.

LayoutTests:

2009-03-04 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test to verify how the text encoding in workers is used.
Script decoding and url completion is checked, with and
w/o http 'Content-Type: ...;charset=...' header.

  • http/tests/workers/resources/worker-encoded.php: Added.
  • http/tests/workers/resources/xhr-query-utf8.php: Added.
  • http/tests/workers/resources/xhr-response.php: Added.
  • http/tests/workers/text-encoding-expected.txt: Added.
  • http/tests/workers/text-encoding.html: Added.
12:43 Changeset [41498] by pkasting@chromium.org

2009-03-06 Peter Kasting <pkasting@google.com>

Build bustage fix.

  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):
12:17 Changeset [41497] by eric.carlson@apple.com

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.
12:08 Changeset [41496] by justin.garcia@apple.com

WebCore:

2009-03-06 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.


https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.
Tested manually in Mail and Safari; automated tests to come later.


  • editing/Editor.cpp: (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
  • editing/Editor.h:
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
  • page/EditorClient.h:
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

WebKit/mac:

2009-03-06 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.

https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingAndGrammarOfParagraph):
11:52 Changeset [41495] by pkasting@chromium.org

2009-03-06 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24407
Windows scroll amount was too small, and wheel scroll distance
conversion code was overly complex.

  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
  • platform/PlatformWheelEvent.h: (WebCore::):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/Scrollbar.h:
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/WheelEventWin.cpp: (WebCore::horizontalScrollChars): (WebCore::verticalScrollLines): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
11:18 Changeset [41494] by treat@webkit.org

2009-03-06 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

When building QtWebKit in release mode make sure that QT_SHARED is defined
otherwise none of the public API will be exported. This leads to missing
symbols and link errors if hidden-visibility is used.

  • Scripts/webkitdirs.pm:
11:14 Changeset [41493] by dglazkov@chromium.org

2009-03-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Roben.

Generate valid bindings with HTML5 database support disabled.

  • inspector/InspectorController.idl: Added feature guard around databaseTableNames definition.
11:06 Changeset [41492] by xan@webkit.org

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Do not take into account the case of being a ScrollView scrollbar,
since those are native in our case.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
11:06 Changeset [41491] by xan@webkit.org

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
specific and it's our only Widget anyway.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
  • platform/gtk/ScrollbarGtk.h:
  • platform/gtk/WidgetGtk.cpp:
11:06 Changeset [41490] by xan@webkit.org

2009-03-04 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Use correct clip rectangle and apply coordinate translation needed
for non-ScrollView scrollbars.

We were ignoring the clip rectangle passed as parameter, which is
wrong in the case of non coalesced expose events. This, in turn,
uncovers the fact that we were not applying coordinate translation
to our position.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):
11:05 Changeset [41489] by aroben@apple.com

Change the isCygwin check in update-webkit to isAppleWinWebKit

This matches a similar check in build-webkit, and is more correct.

Reviewed by Alexey Proskuryakov.

  • Scripts/update-webkit: Only call update-webkit-auxiliary-libs if isAppleWinWebKit is true.
11:05 Changeset [41488] by aroben@apple.com

Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is present but out of date

Reviewed by Alexey Proskuryakov.

  • Scripts/update-webkit-support-libs: Changed to use dieAndInstructToDownload when the zip file doesn't exist. Added an MD5 check to make sure the file is up-to-date. If it is out of date, print an error message and quit. (sub dieAndInstructToDownload): Added. Prints an error message and quits with an error.
11:03 Changeset [41487] by eric.carlson@apple.com

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Build fix, no review

  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
10:55 Changeset [41486] by eric.carlson@apple.com

2009-03-06 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=22790
Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
Replace media engine setRect with setSize since they don't use about the
position anyway.

  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect. (WebCore::MediaPlayer::setSize): Ditto.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::size): Changed from rect().
  • platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): update comment
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect. (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so the movie is drawn in the correct location.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
10:55 Changeset [41485] by cmarrin@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24363

Fixed test and fixed expected results to reflect the fix

09:22 Changeset [41484] by darin@apple.com

WebCore:

2009-03-06 Darin Adler <darin@apple.com>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

Test: fast/dom/location-new-window-no-crash.html

The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
to add some checks for empty URLs. We could also put the empty URL checks at some
other bottleneck level and add more assertions over time. I tried adding a few more
assertions to functions like loadURL and hit them while running the regression tests,
so it's probably going to be a bit tricky to clean this up throughout the loader.

  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct immutable by making all its members const. Added assertions about the arguments, including that the URL is not empty. Initialized one uninitialized member in one of the constructors. (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this a no-op if passed an empty URL. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::scheduleRefresh): Ditto.

LayoutTests:

2009-03-06 Darin Adler <darin@apple.com>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

The new test manipulates all the properties of the location object on a new window which
has no location yet. I tested Firefox too and added comments about how its behavior differs
from WebKit. At some point we may want to tweak our behavior to be a bit closer to theirs,
or check IE's behavior or if HTML 5 or some other W3 specification has something to say
about this, but for now the main purpose of the test is to verify we don't crash.

  • fast/dom/location-new-window-no-crash-expected.txt: Added.
  • fast/dom/location-new-window-no-crash.html: Added.
  • fast/dom/resources/location-new-window-no-crash.js: Added.
08:35 Changeset [41483] by kov@webkit.org

2009-03-06 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Disable accumulating chunks for request_body on file uploads,
using the new soup API.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
08:35 Changeset [41482] by kov@webkit.org

2009-03-06 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
the new soup_message_body_set_accumulate API in soup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
07:54 Changeset [41481] by kov@webkit.org

2009-03-06 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24051
Soup backend needs content sniffing capabilities

Perform content sniffing when using soup, so that we have a chance
of figuring out the Content-Type of the file if it's not sent by
the server.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback):
07:42 Changeset [41480] by darin@apple.com

2009-03-06 Darin Adler <darin@apple.com>

  • fast/dom/Window/window-properties-expected.txt: Updated for recent addition of canPlayType.
05:27 Changeset [41479] by kov@webkit.org

2009-03-05 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Olliej.

https://bugs.webkit.org/show_bug.cgi?id=24295
webkit_web_back_forward_list_add_item needs a Since tag

Add missing Since tag to webkit_web_back_forward_list_add_item
documentation.

  • webkit/webkitwebbackforwardlist.cpp:
05:24 Changeset [41478] by kov@webkit.org

2009-03-05 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24417
[GTK] WebKitDownload's _cancel and _dispose methods may emit warnings

NULL-check for timer on _cancel and _dispose, to avoid bad
warnings.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_cancel):
03:13 Changeset [41477] by ap@webkit.org

2009-03-06 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24342
Cannot insert a Thai character after a Thai prepend character when using ICU 4.0

This change creates a new break iterator "cursorMovementIterator" for
moving cursors and use it when moving an input cursor.
In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
based on the one of ICU 3.8.
On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
just calls the characterBreakIterator() function.

Test: editing/inserting/insert-thai-characters-001.html

  • platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
  • platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU. (WebCore::setUpIteratorWithRules): Ditto. (WebCore::cursorMovementIterator): Ditto.
  • platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt. (WebCore::cursorMovementIterator): Ditto.
  • rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.

03/05/09:

23:28 Changeset [41476] by ap@webkit.org

Reviewed by Oliver Hunt.

<rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
Characters (a compatibility issue with widgets).

Test: http/tests/xmlhttprequest/broken-xml-encoding.html

Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
responses.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode): (WebCore::TextResourceDecoder::flush):
  • loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::useLenientXMLDecoding): Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML decoding errors. This behavior is now limited to other kinds of XML content.
23:17 Changeset [41475] by ddkilzer@apple.com

JavaScriptCore:

2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

  • wtf/Platform.h: Added support for SH4 platform.

WebCore:

2009-03-05 Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

  • platform/text/AtomicString.cpp: (WebCore::equal): Aligned memory access on SH4 platform.
23:02 Changeset [41474] by barraclough@apple.com

2009-03-05 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Writes of constant values to SF registers should be made with direct memory
writes where possible, rather than moving the value via a hardware register.

~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movq_i32m):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
21:15 Changeset [41473] by darin@chromium.org

2009-03-05 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24215

Gears expects an object tag with display:none to instantiate the plugin,
so we add a workaround to make this work and fix Gears on WebKit trunk.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
21:13 Changeset [41472] by darin@chromium.org

2009-03-05 Avi Drissman <avi@chromium.org>

Reviewed by Darin Fisher.

Need to have Chromium Mac match Safari Mac's accesskey handling
https://bugs.webkit.org/show_bug.cgi?id=24404

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
20:12 Changeset [41471] by simon.fraser@apple.com

2009-03-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24412

Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
but no transform. We need to make localTransformState if we see preserve-3d.
Also need to call update3DTransformedDescendantStatus() before we test
m_has3DTransformedDescendant.

Test: transforms/3d/hit-testing/hit-preserves-3d.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
20:12 Changeset [41470] by justin.garcia@apple.com

When we replace a bit of selected text with a string of the same length, we now send a selection change notification. The selection endpoints aren't changing their positions in the DOM or their offsets in the document, but they're probably changing visually (unless the text is fixed width), so it seems right to send the notification.

On the other hand, this happens during a setMarkedText call, which shouldn't even touch the selection. But that's a different (and known) bug.

18:40 Changeset [41469] by eric@webkit.org

Reviewed by David Hyatt.

Changes to RenderLayer destruction to hopefully help catch an elusive crasher
https://bugs.webkit.org/show_bug.cgi?id=24409

Added a new RenderBoxModelObject::destroyLayer() call which is
now the only way which RenderLayers should ever be destroyed.
This ensures that the pointer to the layer is cleared in the
RenderObject after destruction, allowing us to ASSERT in the
RenderBoxModelObject destructor.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::destroyLayer): (WebCore::RenderBoxModelObject::destroy): (WebCore::RenderBoxModelObject::styleDidChange):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
18:35 Changeset [41468] by eric@webkit.org

Reviewed by David Hyatt.

Remove old, unused IE 5.5 scrollbar-* CSS properties.
Sort the unimplemented getComputedStyle properties so it's
easier to see which ones actually need implementation.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
17:42 Changeset [41467] by adele@apple.com

2009-03-05 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24079
<rdar://problem/6611233> REGRESSION (r39549): Page loads cannot be interrupted with Command-. or Escape
<rdar://problem/6636563> Ctrl-tab shortcut doesn't switch tabs when focus is in text field


  • WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): If WebKit does not support the command, we need to pass the selector to super. In this case, we'll consider the event not to be handled. This is not perfect because in theory, [super doCommandBySelector:] can do some action that would cause WebKit to need to consider the event handled. But in practice, I've found no example of that happening and causing broken behavior.
17:25 Changeset [41466] by justin.garcia@apple.com

Make changes to previous checkin from the code review.

17:00 Changeset [41465] by justin.garcia@apple.com

WebCore:

2009-03-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
within the document without changing its position in the DOM. For example, pressing return in (caret marked by ):
<div contentEditable="true"><div>
Hello</div></div>
Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
for example).

Changes to layout tests demonstrate fix.


  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or not it did work that needs to be applied.
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position in the document.
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing. (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to. (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like adding to the killring and responding to a change in selections if the delete was a no-op. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/TypingCommand.h:

LayoutTests:

2009-03-05 Justin Garcia <justin.garcia@apple.com>

Reviewed by Darin Adler.


WebViewDidChangeSelectionNotification isn't always called.
Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.

  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-hr-expected.txt:
  • platform/mac/editing/deleting/delete-tab-004-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
  • platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-br-004-expected.txt:
  • platform/mac/editing/inserting/insert-br-005-expected.txt:
  • platform/mac/editing/inserting/insert-br-006-expected.txt:
  • platform/mac/editing/inserting/insert-br-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-006-expected.txt:
  • platform/mac/editing/inserting/insert-div-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-011-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-div-021-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
  • platform/mac/editing/inserting/insert-tab-004-expected.txt:
  • platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/mac/editing/inserting/line-break-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-010-expected.txt:
  • platform/mac/editing/style/block-style-006-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
16:35 Changeset [41464] by eric@webkit.org

Rubber-stamped by Adam Roben.

Move all of the fast/css/*computed* tests into fast/css/getComputedStyle
in preparation for adding a bunch more getComputedStyle tests.

  • fast/css/getComputedStyle/computed-style-display-none-expected.txt: Renamed from LayoutTests/fast/css/computed-style-display-none-expected.txt.
  • fast/css/getComputedStyle/computed-style-display-none.html: Renamed from LayoutTests/fast/css/computed-style-display-none.html.
  • fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/fast/css/computed-style-expected.txt.
  • fast/css/getComputedStyle/computed-style-negative-top-expected.txt: Renamed from LayoutTests/fast/css/computed-style-negative-top-expected.txt.
  • fast/css/getComputedStyle/computed-style-negative-top.html: Renamed from LayoutTests/fast/css/computed-style-negative-top.html.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
  • fast/css/getComputedStyle/computed-style-without-renderer.html: Renamed from LayoutTests/fast/css/computed-style-without-renderer.html.
  • fast/css/getComputedStyle/computed-style.html: Renamed from LayoutTests/fast/css/computed-style.html.
  • fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-position-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-background-position.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-position.html.
  • fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-size-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-background-size.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-size.html.
  • fast/css/getComputedStyle/getComputedStyle-border-box-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-box-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-box.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-box.html.
  • fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-image-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-image.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-image.html.
  • fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-spacing.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing.html.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius.html: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius.html.
  • fast/css/getComputedStyle/getComputedStyle-relayout-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-relayout-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-relayout.html: Renamed from LayoutTests/fast/css/getComputedStyle-relayout.html.
  • fast/css/getComputedStyle/getComputedStyle-transform-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-transform-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-transform.html: Renamed from LayoutTests/fast/css/getComputedStyle-transform.html.
  • fast/css/getComputedStyle/getComputedStyle-zIndex-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-zIndex-auto.html: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto.html.
  • fast/css/marginComputedStyle.html: Removed.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-expected.txt.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.checksum.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.png.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.txt.
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-expected.txt.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-without-renderer-expected.txt.
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-expected.txt.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt.
15:18 Changeset [41463] by dglazkov@chromium.org

2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Roben.

Eliminate a ref-counting leak in InspectorController.

  • inspector/InspectorController.h: Made constructor private, added static create method.
  • page/Page.cpp: (WebCore::Page::Page): Change initializer to use static create method.
14:58 Changeset [41462] by dglazkov@chromium.org

2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24355
Add InspectorController.idl and convert InspectorController.cpp to use
JSC bindings.

  • DerivedSources.make: Added InspectorController.idl
  • WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
  • bindings/js/JSInspectorControllerCustom.cpp: Added.
  • bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
  • inspector/InspectorController.cpp: Removed hand-rolled bindings.
  • inspector/InspectorController.h: Added platform and addSourceToFrame methods.
  • inspector/InspectorController.idl: Added.
  • page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
14:56 Changeset [41461] by eric.carlson@apple.com

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

Test: media/video-loop.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::loadInternal): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::playInternal): (WebCore::HTMLMediaElement::loop): (WebCore::HTMLMediaElement::setLoop): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updatePlayState):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

  • media/loopend-limits-expected.txt: Removed.
  • media/loopend-limits.html: Removed.
  • media/loopstart-limits-expected.txt: Removed.
  • media/loopstart-limits.html: Removed.
  • media/video-dom-end-expected.txt: Removed.
  • media/video-dom-end.html: Removed.
  • media/video-dom-loopcount-expected.txt: Removed.
  • media/video-dom-loopcount.html: Removed.
  • media/video-dom-loopend-expected.txt: Removed.
  • media/video-dom-loopend.html: Removed.
  • media/video-dom-loopstart-expected.txt: Removed.
  • media/video-dom-loopstart.html: Removed.
  • media/video-dom-start-expected.txt: Removed.
  • media/video-dom-start.html: Removed.
  • media/video-end-expected.txt: Removed.
  • media/video-end.html: Removed.
  • media/video-loop.html: Added, test for new "loop" attribute.
  • media/video-loopcount-expected.txt: Removed.
  • media/video-loopcount.html: Removed.
  • media/video-loopend-expected.txt: Removed.
  • media/video-loopend.html: Removed.
  • media/video-loopstart-expected.txt: Removed.
  • media/video-loopstart.html: Removed.
  • media/video-seek-past-end-paused-expected.txt: Updated for loop changes, add more tests.
  • media/video-seek-past-end-paused.html: Ditto.
  • media/video-seek-past-end-playing-expected.txt: Ditto.
  • media/video-seek-past-end-playing.html: Ditto.
  • media/video-start-expected.txt: Removed.
  • media/video-start.html: Removed.
14:16 Changeset [41460] by sfalken@apple.com

<rdar://problem/6651112> Safari asks about re-posting a form even when page is cached


Reviewed by Ada Chan.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
14:11 Changeset [41459] by pam@chromium.org

2009-03-05 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
https://bugs.webkit.org/show_bug.cgi?id=24339

  • fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
  • fast/dom/Window/window-collection-length-no-crash.html: Added.
12:37 Changeset [41458] by hyatt@apple.com

2009-03-05 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24248

Make sure painting of overflow controls checks that visibility:visible is set on the block before
painting. Pixel tests caught this regression.

Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
to do to their bounds (which had nothing to do with overflow).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer):
11:58 Changeset [41457] by treat@webkit.org

2009-03-05 Yong Li <yong.li@torchmobile.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24386
A faster implementation of extractMIMETypeFromMediaType.

  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType):
11:58 Changeset [41456] by treat@webkit.org

2009-03-05 Yong Li <yong.li@torchmobile.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24392
Do not get the current time for unless we're doing PRELOAD_DEBUG as this
can be unnecessarily expensive.

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::write):
11:39 Changeset [41455] by simon.fraser@apple.com

2009-03-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24327

When mapping points and hit testing through transforms, work
correctly when acclerated animations of transforms are running.

Tested by LayoutTests/animations/animation-hit-test-transform.html,
which only failed when ACCELERATED_COMPOSITING was turned on.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::currentTransform):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
11:17 Changeset [41454] by darin@chromium.org

2009-03-05 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24391
Frame.cpp uses JSC specific includes

  • page/Frame.cpp:
10:40 Changeset [41453] by kov@webkit.org

2009-03-05 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24389
WebKitGTK+ crashes when cancelling plugin loads

Remove bogus calls to the client's didFinishLoading method from
our ResourceHandle::cancel implementation. Calling
didFinishLoading here is mostly inoffensive for most loads, but
causes crashes when plugin loads are cancelled.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel):
10:34 Changeset [41452] by sfalken@apple.com

2009-03-05 Steve Falkenburg <sfalken@apple.com>

Windows build fix.


  • WebCore.vcproj/QTMovieWin.vcproj:
10:16 Changeset [41451] by treat@webkit.org

2009-03-05 Adam Treat <adam.treat@torchmobile.com>

Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
protected by an #if and uses HTMLPlugInElement so it must be included.

  • bindings/js/ScriptController.cpp:
09:34 Changeset [41450] by dglazkov@chromium.org

2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>

GTK Build fix.

  • inspector/ConsoleMessage.h: Use proper header.
09:14 Changeset [41449] by dglazkov@chromium.org

2009-03-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24376
Split InspectorController.cpp file into separate classes.

  • GNUmakefile.am: Modified to include new files.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • inspector/ConsoleMessage.cpp: Added.
  • inspector/ConsoleMessage.h: Added.
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMStorageResource.cpp: Added.
  • inspector/InspectorDOMStorageResource.h: Added.
  • inspector/InspectorDatabaseResource.cpp: Added.
  • inspector/InspectorDatabaseResource.h: Added.
  • inspector/InspectorResource.cpp: Added.
  • inspector/InspectorResource.h: Added.
09:12 Changeset [41448] by eric.carlson@apple.com

2009-03-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24387
Remove media element bufferingRate attribute. No test necessary as there
were none for this attribute.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
  • html/HTMLMediaElement.h: Remove m_bufferingRate.
  • html/HTMLMediaElement.idl: Ditto.
04:47 Changeset [41447] by xan@webkit.org

2009-03-05 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24377
[GTK] Comply better with coding style guidelines in ResourceHandleSoup

Use C++ booleans, 0 instead of NULL, prefix boolean variables with
'is', do not use 'else if' if the previous if had a return, delete
trailing whitespace, etc.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::fillResponseFromMessage): (WebCore::restartedCallback): (WebCore::finishedCallback): (WebCore::parseDataUrl): (WebCore::ensureSessionIsInitialized): (WebCore::ResourceHandle::startHttp): (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start): (WebCore::cleanupGioOperation): (WebCore::closeCallback): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):
02:06 Changeset [41446] by ariya@webkit.org

2009-03-05 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] NPAPI plugins are supported, adjust the API documentation.

  • Api/qwebsettings.cpp:
00:05 Changeset [41445] by mrowe@apple.com

Fix the build.

Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.

  • runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

03/04/09:

23:28 Changeset [41444] by mrowe@apple.com

<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu

Reviewed by Dan Bernstein.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

22:04 Changeset [41443] by mrowe@apple.com

<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space

Reviewed by Oliver Hunt.

The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.

Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.

PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.

TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.

A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call. A similar approach is also used by AdminRegionRecorder.

  • wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):

  • wtf/TCPageMap.h:

(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):

19:10 Changeset [41442] by oliver@apple.com

Added a few more tests to ubench

RS=Gavin Barraclough

Adding a couple of test to cover too few and too many arguments. This
is needed to prevent regressions in all call paths from my current refactoring.

18:36 Changeset [41441] by simon.fraser@apple.com

2009-03-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24328

If an element has backface-visibility: hidden, hit testing should not
hit the back sides of elements. Test for that by inverting the accumulated
transform and looking at the z vector.

Tested by transforms/3d/hit-testing/backface-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
18:11 Changeset [41440] by simon.fraser@apple.com

2009-03-04 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Eric Seidel.

New layout tests for point mapping and hit testing through 3d transforms.
Not run by default yet.

  • platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
  • transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
  • transforms/3d/cssmatrix-3d-interface.xhtml: Added.
  • transforms/3d/hit-testing/backface-hit-test.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping.html: Added.
  • transforms/3d/point-mapping/point-mapping-helpers.js: Added. (mousemoved): (dispatchEvent): (clicked): (log): (runTest):
17:13 Changeset [41439] by eric.carlson@apple.com

2009-03-04 Eric Carlson <eric.carlson@apple.com>

  • Correct bogus result checked in as part of r41432.
  • media/video-can-play-type-expected.txt:
16:57 Changeset [41438] by eric@webkit.org

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

r41362 mistakenly added functions "RenderThemeWin::" into
RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
them to void return types. This patch switches them back to ints.

https://bugs.webkit.org/show_bug.cgi?id=24360

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
16:57 Changeset [41437] by eric@webkit.org

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: change some metrics to better match Windows after
r41416. Aesthetically this may be worse, but web-compat is king.

Also, the previous code had an off by one error when drawing
scrollbars which caused the scrollbar to overflow it's bounds by 1px
at the right and bottom edges.

https://bugs.webkit.org/show_bug.cgi?id=24369

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::): (WebCore::RenderThemeChromiumLinux::systemFont):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::paintTrackPiece):
15:48 Changeset [41436] by pam@chromium.org

2009-03-04 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test to ensure that window.frames is self-referential
https://bugs.webkit.org/show_bug.cgi?id=24341

  • fast/dom/Window/window-frames-self-referential-expected.txt: Added.
  • fast/dom/Window/window-frames-self-referential.html: Added.
14:58 Changeset [41435] by eric@webkit.org

Reviewed by Adam Roben.

Add an ASSERT to better demonstrate the cause of the crash in
https://bugs.webkit.org/show_bug.cgi?id=23736

  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):
14:29 Changeset [41434] by levin@chromium.org

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html

http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.
14:29 Changeset [41433] by levin@chromium.org

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html

  • dom/ExceptionCode.cpp: (WebCore::xmlHttpRequestExceptionNames): Added missing ABORT_ERR whose absence caused an assert.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Add more logic to handle the termination case for sync xhr.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Added test to verify to terminate a worker while it is doing a synchronous xhr.
It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
to actually do this.

  • http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
  • http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
  • http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.
14:21 Changeset [41432] by eric.carlson@apple.com

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Add support for HTMLMediaElement canPlayType method. Make
MediaPlayer::supportsType take a ContentType instead of a
separate mime type and codecs parameter.

Test: media/video-can-play-type.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
  • html/HTMLMediaElement.h: Add prototype.
  • html/HTMLMediaElement.idl: Ditto.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. (WebCore::MediaPlayer::supportsType): Ditto.
  • platform/graphics/MediaPlayer.h:

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Test HTMLMediaElement canPlayType method.

  • media/video-can-play-type-expected.txt: Added.
  • media/video-can-play-type.html: Added.
14:01 Changeset [41431] by antti@apple.com

JavaScriptCore:

2009-03-04 Antti Koivisto <antti@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism


Set ENABLE_REPAINT_THROTTLING to 0 by default.

  • wtf/Platform.h:

WebCore:

2009-03-04 Antti Koivisto <antti@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism


Excessive repainting can slow down page loadind. This implements a timer
based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
enabled by default.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::doDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay): (WebCore::FrameView::resetDeferredRepaintDelay): (WebCore::FrameView::adjustedDeferredRepaintDelay): (WebCore::FrameView::deferredRepaintTimerFired): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
13:53 Changeset [41430] by weinig@apple.com

2009-03-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Antti Koivisto.

Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
13:24 Changeset [41429] by kmccullough@apple.com

2009-03-04 Kevin McCullough <kmccullough@apple.com>

  • Build bot fix.
  • fast/profiler/many-calls-in-the-same-scope-expected.txt:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
  • fast/profiler/nested-start-and-stop-profiler-expected.txt:
  • fast/profiler/profile-calls-in-included-file-expected.txt:
12:57 Changeset [41428] by xan@webkit.org

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog files to build.

  • GNUmakefile.am:

WebCore:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Remove WebKitSoupAuthDialog files from build and stop using it.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
  • platform/network/soup/webkit-soup-auth-dialog.c: Removed.
  • platform/network/soup/webkit-soup-auth-dialog.h: Removed.

WebKit/gtk:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog and add it to the session in webkit_init.

  • webkit/webkitprivate.cpp: (currentToplevelCallback): (webkit_init):
  • webkit/webkitsoupauthdialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (table_add_entry): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
  • webkit/webkitsoupauthdialog.h: Added.
11:58 Changeset [41427] by simon.fraser@apple.com

2009-03-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24361

Reinstate code that sets result.innerNode when hitTest() returns true,
but never filled in the innerNode. Fixes hit testing of generated content.

Test: fast/css-generated-content/hit-test-generated-content.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
11:56 Changeset [41426] by abarth@webkit.org

WebCore:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs):

WebKit/mac:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/qt:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

WebKit/win:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
10:25 Changeset [41425] by beidson@apple.com

2009-03-04 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.

I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
consolidated some of the various decision making pieces of the Cache into the new method
FrameLoader::cachePolicy().

Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
same URL for this image every time and expects it to be reloaded with each new card.

The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible condition for returning CachePolicyReload.
09:59 Changeset [41424] by timothy@apple.com
  • English.lproj/localizedStrings.js: Update strings to include "DATABASES", "LOCAL STORAGE" and "SESSION STORAGE".
09:59 Changeset [41423] by timothy@apple.com

Fix a regression where the Web Inspector console would not animate
in or out correctly.

Reviewed by Anders Carlsson.

  • inspector/front-end/inspector.css: Move a z-index to a child element to get the correct stacking order during the animation.
09:56 Changeset [41422] by hyatt@apple.com

WebCore:

2009-03-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
the final position against the y position estimate until after the clear has happened. This gets rid
of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

Reviewed by Dan Bernstein

Added fast/block/float/nested-clearance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::getClearDelta):
  • rendering/RenderBlock.h:

LayoutTests:

2009-03-03 David Hyatt <hyatt@apple.com>

Test case for https://bugs.webkit.org/show_bug.cgi?id=24201

Reviewed by Dan Bernstein

  • fast/block/float/nested-clearance.html: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.png: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.txt: Added.
09:39 Changeset [41421] by abarth@webkit.org

2009-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24340

Expose AllowUniversalAccessFromFileUrls to Qt clients.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
06:42 Changeset [41420] by hausmann@webkit.org

2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

Improvement to 3d transformations rendering in QtWebKit. QTransform is used
instead of QMatrix. This allows perspective transformations since QTransform is
a true 3x3 matrix.

06:21 Changeset [41419] by hausmann@webkit.org

2009-02-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24151
Fix Qt/S60 build break

01:56 BuildingGtk edited by oszi@inf.u-szeged.hu
(diff)
01:54 QtWebKitTodo edited by hausmann@webkit.org
(diff)

03/03/09:

23:20 Changeset [41418] by darin@chromium.org

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage

  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):
22:49 Changeset [41417] by ddkilzer@apple.com

<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

Reviewed by Mark Rowe.

JavaScriptCore:

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
  • WebCore.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • WebKit.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
22:09 Changeset [41416] by darin@chromium.org

2009-03-02 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: Switch to using Skia to render widgets.

In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.

Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.

https://bugs.webkit.org/show_bug.cgi?id=24244

  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
  • platform/graphics/skia/PlatformContextSkia.h:
  • rendering/RenderThemeChromiumGtk.cpp: Removed.
  • rendering/RenderThemeChromiumGtk.h: Removed.
  • rendering/RenderThemeChromiumLinux.cpp: Added.
  • rendering/RenderThemeChromiumLinux.h: Added.
21:39 Changeset [41415] by dglazkov@chromium.org

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.

Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

  • bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.
17:10 Changeset [41414] by andersca@apple.com

WebCore:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Null check NPStream before dereferencing it.


  • plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Add destroyNullStream test function to the test plug-in.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):

LayoutTests:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari


Update tests.

  • plugins/destroy-stream-twice-expected.txt:
  • plugins/destroy-stream-twice.html:
17:06 Changeset [41413] by eric.carlson@apple.com

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.


https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging


Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.

  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/broken-video-expected.txt:
  • media/broken-video.html:
  • media/constructors-expected.txt:
  • media/constructors.html:
  • media/loopend-limits-expected.txt:
  • media/loopstart-limits-expected.txt:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks-expected.txt:
  • media/unsupported-tracks.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-autoplay-expected.txt:
  • media/video-autoplay.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-autoplay.html:
  • media/video-dom-end-expected.txt:
  • media/video-dom-end.html:
  • media/video-dom-loopcount-expected.txt:
  • media/video-dom-loopcount.html:
  • media/video-dom-loopend-expected.txt:
  • media/video-dom-loopend.html:
  • media/video-dom-loopstart-expected.txt:
  • media/video-dom-loopstart.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-dom-start-expected.txt:
  • media/video-dom-start.html:
  • media/video-end-expected.txt:
  • media/video-end.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
  • media/video-load-readyState-expected.txt:
  • media/video-load-readyState.html:
  • media/video-loopcount-expected.txt:
  • media/video-loopcount.html:
  • media/video-loopend-expected.txt:
  • media/video-loopend.html:
  • media/video-loopstart-expected.txt:
  • media/video-loopstart.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-empty-events.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-events.html:
  • media/video-poster-expected.txt:
  • media/video-poster.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-size-expected.txt:
  • media/video-size.html:
  • media/video-source-expected.txt:
  • media/video-source-media-expected.txt:
  • media/video-source-media.html:
  • media/video-source-type-expected.txt:
  • media/video-source-type-params-expected.txt:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-src-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-remove.html:
  • media/video-src-set-expected.txt:
  • media/video-src-set.html:
  • media/video-src-source-expected.txt:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-start-expected.txt:
  • media/video-start.html:
  • media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
  • media/video-volume-expected.txt:
  • media/video-volume.html:
  • media/video-width-height-expected.txt:
  • media/video-width-height.html:
16:44 Changeset [41412] by eric.carlson@apple.com

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
16:38 Changeset [41411] by kmccullough@apple.com

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function

  • This no longer happens but I thought I'd make a test case anyway.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
  • fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):
16:08 Changeset [41410] by kmccullough@apple.com

2009-03-03 Kevin McCullough <kmccullough@apple.com>

  • Spelling fix.
  • page/Console.cpp: (WebCore::Console::profile):
15:30 Changeset [41409] by ddkilzer@apple.com

Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

Reviewed by Adam Roben.

Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.
14:57 Changeset [41408] by dglazkov@chromium.org

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.

  • WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
14:47 Changeset [41407] by kmccullough@apple.com

JavaScriptCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.

WebCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • fast/profiler/profile-with-no-title-expected.txt: Added.
  • fast/profiler/profile-with-no-title.html: Added.
14:27 Changeset [41406] by timothy@apple.com

Add bug URLs for my last commit.

14:25 Changeset [41405] by pam@chromium.org

2009-03-03 Pamela Greene <pam@chromium.org>

Remove junk files that must have been accidentally committed.
Submitted without review.

  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.
14:24 Changeset [41404] by timothy@apple.com

Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-dir.html

  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
  • inspector/front-end/inspector.css: Tweak styles to look and work correctly.
  • inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
  • page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
13:07 Changeset [41403] by dglazkov@chromium.org

WebCore:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.

Makes sure a node is in the document during a move before using it.

Test: fast/events/crash-on-mutate-during-drop.html

  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop

Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.

  • fast/events/crash-on-mutate-during-drop-expected.txt: Added.
  • fast/events/crash-on-mutate-during-drop.html: Added.
11:53 Changeset [41402] by dglazkov@chromium.org

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
11:48 Changeset [41401] by kov@webkit.org

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Adding new files related to WebKitDownload to the GTK+ port.

  • GNUmakefile.am:

WebCore:

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
  • webkit/webkitdownload.h: Added.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
11:29 Changeset [41400] by andersca@apple.com

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6633834>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.
11:18 Changeset [41399] by dglazkov@chromium.org

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

  • bindings/v8/custom/V8AttrCustom.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
  • bindings/v8/custom/V8ElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
11:08 Changeset [41398] by beidson@apple.com

WebCore:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6616664> - Quick looks of various file types is broken

In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Support layout test covering <rdar://problem/6616664>

Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.


  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

Added to test the changes:

  • fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • fast/loader/main-document-url-for-non-http-loads.html: Added.
  • fast/loader/resources/subframe-notify-done.html: Added.

Updated the following for the new info from dumpResourceLoadCallbacks():

  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac-leopard/security/block-test-expected.txt:
  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • security/block-test-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
10:55 Changeset [41397] by cmarrin@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24256

Added a WebCoreForceSoftwareAnimation flag.

10:48 Changeset [41396] by cmarrin@apple.com

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24257

Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.

10:46 Changeset [41395] by ariya@webkit.org

2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Create and update the action for SelectAll.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):
10:38 Changeset [41394] by dglazkov@chromium.org

2009-03-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.

  • bindings/v8/V8Binding.h: Added.
  • bindings/v8/V8Proxy.h: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added.
  • bindings/v8/custom/V8CustomEventListener.h: Added.
10:33 Changeset [41393] by dglazkov@chromium.org

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.

css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html

On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.

  • fast/block/float/resources/se_arrow.png: Added.
  • fast/block/float/resources/yinyang.png: Added.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.
10:21 Changeset [41392] by dglazkov@chromium.org

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:20 Changeset [41391] by dglazkov@chromium.org

Fix ChangeLog dates.

10:18 Changeset [41390] by dglazkov@chromium.org

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1

  • Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
  • Adjust WebCore.vcproj accordingly.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/opentype: Added.
  • platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
  • platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
  • platform/graphics/win/OpenTypeUtilities.cpp: Removed.
  • platform/graphics/win/OpenTypeUtilities.h: Removed.
10:10 Changeset [41389] by simon.fraser@apple.com

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Take 3D transforms into account when hit testing:

  1. Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.
  1. Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.

It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.

  1. Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.

The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.

09:54 Changeset [41388] by brettw@chromium.org

Fix typo in ChangeLog from last commit.

09:52 Changeset [41387] by simon.fraser@apple.com

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
  • rendering/RenderObject.h:
09:50 Changeset [41386] by brettw@chromium.org

2009-03-02 Brett Wilson <brettw@chromium.org>

Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,

Reviewed by Darin Disher.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):
09:43 Changeset [41385] by simon.fraser@apple.com

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24317

Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
09:31 Changeset [41384] by kov@webkit.org

Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

09:26 Changeset [41383] by kov@webkit.org

2009-03-03 Onne Gorter <onne.gorter@avinity.net>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed

Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.

manual test: manual-tests/gtk/plugin-resize-scroll.html

  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup
08:45 Changeset [41382] by ap@webkit.org

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=4343
XMLHttpRequest doesn't work in a JavaScript-created window

The problem was fixed a while ago (r34506), just adding a test.

  • http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
  • http/tests/xmlhttprequest/request-from-popup.html: Added.
08:44 Changeset [41381] by ap@webkit.org

Adding bug URL and title to ChangeLog for a recent check-in.

08:06 Changeset [41380] by darin@chromium.org

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

  • dom/Document.idl:
  • html/HTMLCanvasElement.idl:

03/02/09:

22:15 Changeset [41379] by simon.fraser@apple.com

2009-03-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson

https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
18:24 Changeset [41378] by weinig@apple.com

JavaScriptCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Scripts/build-webkit:
18:12 Changeset [41377] by eric@webkit.org

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Fix https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):
17:51 Changeset [41376] by andersca@apple.com

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

WebKit part of <rdar://problem/6638658>.


  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.


  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.


(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.
17:47 Changeset [41375] by weinig@apple.com

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
  • page/Geolocation.h: (WebCore::Geolocation::):
  • platform/GeolocationService.cpp:
  • platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
  • platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
  • platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

Add SPI to ask the embedding application whether to allow
Geolocation for an origin.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
  • WebView/WebUIDelegatePrivate.h:
17:36 Changeset [41374] by andersca@apple.com

2009-03-02 Anders Carlsson <andersca@apple.com>

Fix PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):
17:36 UsingGitWithWebKit edited by ojan@chromium.org
(diff)
16:20 Changeset [41373] by andersca@apple.com

Fix tyop

16:14 Changeset [41372] by andersca@apple.com

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan, Ada Chan.

Factor loading code out into its own method and get rid of a bunch of goots.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):
16:00 Changeset [41371] by andersca@apple.com

2009-03-02 Anders Carlsson <andersca@apple.com>

Build fix.

  • Plugins/WebNetscapeDeprecatedFunctions.h:
15:58 Changeset [41370] by andersca@apple.com

2009-03-02 Anders Carlsson <andersca@apple.com>

WebNetscapePluginPackage.mm is an Objective-C++ file.

  • WebKit.xcodeproj/project.pbxproj:
15:53 Changeset [41369] by andersca@apple.com

WebKit:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

  • Plugins/WebNetscapePluginPackage.m: Removed.
  • Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.
15:29 Changeset [41368] by kevino@webkit.org

Build fixes for wxWidgets Mac trunk build.

15:25 Changeset [41367] by kevino@webkit.org

wxGTK missing header build fix.

13:55 Changeset [41366] by mitz@apple.com

Reviewed by Adam Roben.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.
13:38 Changeset [41365] by timothy@apple.com

Fixes a regression caused by splitting the input and output of console commands.

https://bugs.webkit.org/show_bug.cgi?id=24293

Reviewed by Kevin McCullough.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
13:38 Changeset [41364] by timothy@apple.com

Make exception messages and logged Error objects display consistently.

https://bugs.webkit.org/show_bug.cgi?id=18983

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Remove a string for line numbers.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
  • inspector/front-end/inspector.css: Tweaks to the styles.
13:38 Changeset [41363] by timothy@apple.com

Allow for multiline quoted text in JavaScript files when looking for function names.

https://bugs.webkit.org/show_bug.cgi?id=24296

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog:
11:16 Changeset [41362] by levin@chromium.org

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Bug 24048: extra windows button padding doesn't apply when there's no appearance
<https://bugs.webkit.org/show_bug.cgi?id=24048>

Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

No tests added as existing tests already cover this behavior.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
  • rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumGtk.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeWin.h:
10:26 Changeset [41361] by treat@webkit.org

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

  • Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.h:
08:55 Changeset [41360] by treat@webkit.org

2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
08:30 Changeset [41359] by treat@webkit.org

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt port. Remove unnecessary assert.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
07:37 Changeset [41358] by treat@webkit.org

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
06:56 Changeset [41357] by kov@webkit.org

2009-03-02 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.

  • GNUmakefile.am:
06:38 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:38 Changeset [41356] by krit@webkit.org

2009-03-02 Dirk Schulze <krit@webkit.org>

Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.

06:22 Changeset [41355] by krit@webkit.org

2009-03-02 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

Added putImageData to Qt.

[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
05:26 Changeset [41354] by aroben@apple.com

Windows build fix after r41349

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):
00:22 Changeset [41353] by timothy@apple.com

Show exception messages again when evaluating bad expressions in the
Web Inspector's console.

https://bugs.webkit.org/show_bug.cgi?id=19890

Reviewed by Oliver Hunt.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.
00:22 Changeset [41352] by timothy@apple.com

Make input in the Web Inspector console print before any output
that might be added by the called function.

https://bugs.webkit.org/show_bug.cgi?id=19931

Reviewed by Oliver Hunt.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
  • inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.
Note: See TracTimeline for information about the timeline view.