Timeline



Mar 10, 2009:

11:46 PM Changeset in webkit [41578] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2009-03-10 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Ken Kocienda.

  • dom/Range.cpp: (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects would include rects for the divs contents. Set the correct RenderObject to stop at.
11:28 PM Changeset in webkit [41577] by ap@webkit.org
  • 5 edits in trunk

Reviewed by Sam Weinig.

<rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR

WebCore:

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and there are security concerns with exposing them for cross-origin requests, so it's not clear if we want to change anything here.

LayoutTests:

  • http/tests/security/cookies/xmlhttprequest.html: We don't expose cookies for documents retrieved via XMLHttpRequest. Added a check to make sure that we don't forget about cross- origin restrictions if we ever decide to change that.
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi: While at it, fixed a broken check for Set-Cookie2.
10:43 PM Changeset in webkit [41576] by Simon Fraser
  • 7 edits
    2 adds in trunk

2009-03-10 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=24503

Fix hit testing of absolutely positioned single line text controls by
ensuring that we set result.innerNode() correctly. If the hit node is
a descendant of the inner text element or if it is the <input> itself,
then we say we hit the innerTextElement.

Rename hitInnerTextBlock() to hitInnerTextElement() to match the
'innerTextElement' terminology used elsewhere.

Assert that if renderer()->hitTest() returns false, no-one set
result.innerNode().

Test: fast/forms/search-abs-pos-cancel-button.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
9:03 PM Changeset in webkit [41575] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

9:01 PM Changeset in webkit [41574] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.17

New tag.

7:20 PM Changeset in webkit [41573] by Antti Koivisto
  • 2 edits in trunk/WebCore

2009-03-10 Antti Koivisto <Antti Koivisto>

Reviewed by Mark Rowe.

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.


Another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isNonByteBasedEncoding):
5:19 PM Changeset in webkit [41572] by mrowe@apple.com
  • 13 edits in branches/Safari-6528

Merge r41190.

5:19 PM Changeset in webkit [41571] by mrowe@apple.com
  • 10 edits
    3 adds in branches/Safari-6528

Merge r41232.

5:08 PM Changeset in webkit [41570] by justin.garcia@apple.com
  • 1 edit in trunk/WebCore/page/Frame.cpp

Fix build.

5:05 PM Changeset in webkit [41569] by Beth Dakin
  • 118 edits
    4 adds in trunk

WebCore:

2009-03-10 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
scroll bar appears for long line of text with NOWRAP set

This is a regression from ​http://trac.webkit.org/changeset/32226
I talked with Dan about the original change, and we decided that
the best fix was to remove his small potential-optimization that
only created a separate line box for whitespace under certain
circumstances. This new code will always create a separate line
box.

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

2009-03-10 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB):
No scroll bar appears for long line of text with NOWRAP set

New test:

  • fast/inline/long-wrapped-line.html: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.


These tests all have changed results from the patch. Now trailing
whitespace always has its own linebox instead of sometimes sharing
a linebox with text.

  • platform/mac/editing/deleting/5206311-1-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/execCommand/5482023-expected.txt:
  • platform/mac/editing/execCommand/boldSelection-expected.txt:
  • platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
  • platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • platform/mac/editing/execCommand/print-expected.txt:
  • platform/mac/editing/execCommand/selectAll-expected.txt:
  • platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
  • platform/mac/editing/input/emacs-ctrl-o-expected.txt:
  • platform/mac/editing/inserting/12882-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-div-020-expected.txt:
  • platform/mac/editing/inserting/insert-div-021-expected.txt:
  • platform/mac/editing/inserting/insert-div-022-expected.txt:
  • platform/mac/editing/inserting/insert-div-023-expected.txt:
  • platform/mac/editing/inserting/insert-div-024-expected.txt:
  • platform/mac/editing/inserting/insert-div-025-expected.txt:
  • platform/mac/editing/inserting/insert-div-027-expected.txt:
  • platform/mac/editing/inserting/typing-003-expected.txt:
  • platform/mac/editing/pasteboard/4989774-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-3-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/selection/4947387-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5081257-1-expected.txt:
  • platform/mac/editing/selection/5081257-2-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5234383-1-expected.txt:
  • platform/mac/editing/selection/5234383-2-expected.txt:
  • platform/mac/editing/selection/7152-1-expected.txt:
  • platform/mac/editing/selection/7152-2-expected.txt:
  • platform/mac/editing/selection/after-line-wrap-expected.txt:
  • platform/mac/editing/selection/click-start-of-line-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/editable-html-element-expected.txt:
  • platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
  • platform/mac/editing/selection/end-of-document-expected.txt:
  • platform/mac/editing/selection/extend-by-character-003-expected.txt:
  • platform/mac/editing/selection/extend-by-character-005-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/editing/selection/mixed-editability-1-expected.txt:
  • platform/mac/editing/selection/move-by-character-003-expected.txt:
  • platform/mac/editing/selection/move-by-character-005-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/create-block-for-style-001-expected.txt:
  • platform/mac/editing/style/create-block-for-style-002-expected.txt:
  • platform/mac/editing/style/create-block-for-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-004-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-007-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/create-block-for-style-009-expected.txt:
  • platform/mac/editing/style/create-block-for-style-010-expected.txt:
  • platform/mac/editing/style/create-block-for-style-011-expected.txt:
  • platform/mac/editing/style/create-block-for-style-012-expected.txt:
  • platform/mac/editing/style/create-block-for-style-013-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-001-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/negativeLineHeight-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/lists/drag-into-marker-expected.txt:
  • platform/mac/fast/parser/comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
  • platform/mac/fast/repaint/selection-after-delete-expected.txt:
  • platform/mac/fast/repaint/selection-after-remove-expected.txt:
  • platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
  • platform/mac/fast/text/trailing-white-space-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
  • platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
  • platform/mac/http/tests/navigation/anchor-goback-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
  • platform/mac/http/tests/navigation/post-goback2-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
  • platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
  • platform/mac/http/tests/navigation/success200-goback-expected.txt:
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
4:57 PM Changeset in webkit [41568] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-03-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6166844>
​https://bugs.webkit.org/show_bug.cgi?id=24495

Use same rule for loading java applets as we do for images.

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
4:23 PM Changeset in webkit [41567] by justin.garcia@apple.com
  • 1 edit in trunk/WebCore/page/Frame.h

Fix the build.

3:59 PM Changeset in webkit [41566] by justin.garcia@apple.com
  • 5 edits in trunk/WebCore

2009-03-10 Justin Garcia <​justin.garcia@apple.com>

Reviewed by David Kilzer.

Get rid of revealCaret and use revealSelection instead.

  • WebCore.base.exp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
  • page/Frame.cpp: (WebCore::Frame::revealSelection):
  • page/Frame.h:
3:48 PM Changeset in webkit [41565] by cwzwarich@webkit.org
  • 3 edits
    5 adds in trunk

2009-03-10 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
<​https://bugs.webkit.org/show_bug.cgi?id=24291>
<rdar://problem/6663472>

Add an extra newline to the end of the body of the program text constructed
by the Function constructor for parsing. This allows single line comments to
be handled correctly by the parser.

JavaScriptCore:

  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):

LayoutTests:

  • fast/events/onload-single-line-comment-expected.txt: Added.
  • fast/events/onload-single-line-comment.html: Added.
  • fast/js/function-constructor-single-line-comment-expected.txt: Added.
  • fast/js/function-constructor-single-line-comment.html: Added.
  • fast/js/resources/function-constructor-single-line-comment.js: Added.
2:46 PM Changeset in webkit [41564] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults


Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.


This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
saying there was browsing history for a particular day, and then return no history items when we requested a
list of sites visited that day.


Reviewed by Ada Chan.

  • MarshallingHelpers.cpp: (MarshallingHelpers::DATEToCFAbsoluteTime): (MarshallingHelpers::CFAbsoluteTimeToDATE):
12:49 PM Changeset in webkit [41563] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2009-03-10 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23736: WebKit Crashes on ​http://g-conquest.fr/~server2
<​https://bugs.webkit.org/show_bug.cgi?id=23736>
<rdar://problem/6560278>

Before replacing the document, FrameLoader::executeIfJavaScriptURL()
should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().

WebCore:

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):

LayoutTests:

  • http/tests/misc/javascript-url-stop-loaders-expected.txt: Added.
  • http/tests/misc/javascript-url-stop-loaders.html: Added.
12:31 PM Changeset in webkit [41562] by Darin Adler
  • 4 edits
    2 adds in trunk

WebCore:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

Test: editing/deleting/merge-at-end-of-document.html

  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to use && in assertions since we'd like to know which condition is failing.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the function doesn't know which value to return.

LayoutTests:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
​https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

  • editing/deleting/merge-at-end-of-document-expected.txt: Added.
  • editing/deleting/merge-at-end-of-document.html: Added.
11:46 AM Changeset in webkit [41561] by krit@webkit.org
  • 5 edits in trunk/WebCore

2009-03-10 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel. Math checked by Oliver Hunt.

Implement the Cairo version of the checkForSolidColor() method. This halfes the
time to draw on 1x1 px background images.
I added two new calls to Color for the pixel manipulation on cairo_surface's.
They are neede to premultiply/unpremultiply the colors of the surface.

[CAIRO] Introduce single-pixel image optimizations
​https://bugs.webkit.org/show_bug.cgi?id=17284

  • platform/graphics/Color.cpp: (WebCore::colorFromPremultipliedARGB): (WebCore::premultipliedARGBFromColor):
  • platform/graphics/Color.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
11:38 AM Changeset in webkit [41560] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-10 Adam Treat <​adam.treat@torchmobile.com>

Build fix for Qt after r41555.

  • Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
11:22 AM Changeset in webkit [41559] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use g_hash_table_new_full so we can save the manual unref on the
values when removing them from the table.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
10:34 AM Changeset in webkit [41558] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
guidelines.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
10:00 AM Changeset in webkit [41557] by xan@webkit.org
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Build fix, no review.

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

WebKit/qt:

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Build fix, no review.

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
9:38 AM Changeset in webkit [41556] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Correct return value to false instead of NULL.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
9:23 AM Changeset in webkit [41555] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-03-06 Darin Fisher <​darin@chromium.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=24437

Add support for registering noAccess URL schemes:
1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
that list upon construction (similar to how isLocal is implemented).
2- Make InspectorController call grantUniversalAccess on its Document's
SecurityOrigin at the time when windowScriptObjectAvailable is called.

This enables content such as the inspector to be loaded from a custom (non-file)
URL, which is how Chromium loads the inspector. It also allows other URL schemes
to be treated like data: URLs, which Chromium utilizes for its various HTML-based
UI panels.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable):
  • loader/FrameLoader.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal):
9:19 AM Changeset in webkit [41554] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Build fix, no review

  • page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):
9:10 AM Changeset in webkit [41553] by xan@webkit.org
  • 30 edits in trunk/WebCore

2009-03-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24491
Rename posOffset to m_offset, get rid of accessor

As suggested in dom/Position.h, this patch gets rid of the
'offset()' accessor and renames posOffset to m_offset. I've used
m_offset instead of offset to follow the style guide lines, since
Position is still a class and not a structure. If the long term
plan is still to make it a structure it would be pretty easy to
just s/m_offset/offset/ globally when that is achieved.

  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atStart): (WebCore::Position::atEnd): (WebCore::Position::renderedOffset): (WebCore::Position::isCandidate): (WebCore::Position::inRenderedText): (WebCore::Position::isRenderedCharacter): (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
  • dom/Position.h: (WebCore::Position::Position):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
  • dom/Range.cpp:
  • dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::position): (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setOffset): (WebCore::RangeBoundaryPoint::setToChild): (WebCore::RangeBoundaryPoint::setToStart): (WebCore::RangeBoundaryPoint::setToEnd): (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
  • editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
7:46 AM Changeset in webkit [41552] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
​https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

  • editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets call to the one of the two overloads of this function that wasn't calling it. This fixes this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
​https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

  • fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
  • fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.
7:10 AM Changeset in webkit [41551] by ap@webkit.org
  • 16 edits
    2 deletes in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24285
Text resource loading checks for BOM twice

This removes TextDecoder class, since its only purpose was to check for BOM, which is
already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
BOM checked, but I didn't find any cases where it would significantly change behavior.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Remove TextDecoder.{h,cpp}.
  • platform/text/TextDecoder.cpp: Removed.
  • platform/text/TextDecoder.h: Removed.
  • loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and TextCodec separately.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member. (WebCore::TextResourceDecoder::setEncoding): Ditto. (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override even a user-chosen encoding - this is how it already worked due to TextDecoder checking for BOM again. Made this function return the detected BOM length. (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of a text resource. (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode): Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer checks for BOM, which was a counter-intuitive feature.
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setEncoding): (WebCore::CachedScript::encoding): (WebCore::CachedScript::script):
  • loader/CachedScript.h:
  • loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM. A side effect of this is that these resources will now be subject to encoding auto-detection.
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • page/Page.cpp: (WebCore::Page::userStyleSheet): Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder re-usable (for repeated decoding of the same resource).
  • platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
5:58 AM Changeset in webkit [41550] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24488
An assertion failure when updating an offline application cache after emptying caches

Emptying appcache cannot be performed automatically, so no test.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk storage, even if the application wasn't updated server side.
2:44 AM Changeset in webkit [41549] by oliver@apple.com
  • 19 edits
    9 adds in trunk

<rdar://problem/6425807> Implement WorkerUtils.importScripts()
<​https://bugs.webkit.org/show_bug.cgi?id=22721>

Reviewed by Alexey Proskuryakov

Implement importScripts, currently uses a series of synchronous loads
to fetch the scripts, but this is simpler than a synchronous load of
multiple loads in parallel. In future we'll want to switch to parallel
loading, but this will do for now.

Test: http/tests/workers/worker-importScripts.html

1:11 AM Changeset in webkit [41548] by ap@webkit.org
  • 9 edits
    4 adds in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24462
Move cross-origin access control code out of XMLHttpRequest

Step 1: move preflight result cache and access control helper functions.

No change in behavior, so no test.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/CrossOriginAccessControl.cpp: Added. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::isSimpleCrossOriginAccessRequest): (WebCore::createAllowedCrossOriginResponseHeadersSet): (WebCore::isOnAccessControlResponseHeaderWhitelist): (WebCore::passesAccessControlCheck):
  • loader/CrossOriginAccessControl.h: Added.
  • loader/CrossOriginPreflightResultCache.cpp: Added. (WebCore::parseAccessControlMaxAge): (WebCore::addToAccessControlAllowList): (WebCore::parseAccessControlAllowList): (WebCore::CrossOriginPreflightResultCacheItem::parse): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest): (WebCore::CrossOriginPreflightResultCache::shared): (WebCore::CrossOriginPreflightResultCache::appendEntry): (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
  • loader/CrossOriginPreflightResultCache.h: Added. (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem): (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  • xml/XMLHttpRequest.h:
12:46 AM Changeset in webkit [41547] by ap@webkit.org
  • 5 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19797
Bring the list of forbidden headers in sync with XMLHttpRequest spec draft

Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from XMLHttpRequest 2 draft.
12:03 AM Changeset in webkit [41546] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical scrollbar rect calculation.

Mar 9, 2009:

10:50 PM Changeset in webkit [41545] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Oliver Hunt

​https://bugs.webkit.org/show_bug.cgi?id=24475

When repainting replaced elements, need to union the selection
and overflow rects because either may extend outside the other.

Test: fast/repaint/transform-replaced-shadows.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
6:09 PM Changeset in webkit [41544] by oliver@apple.com
  • 5 edits
    3 adds in trunk

Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>

Reviewed by Gavin Barraclough

r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets. This causes problems when condition loads occur in an

expression -- namely through the ?: and
operators. This patch corrects these issues

by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.

I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug. That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.

5:38 PM Changeset in webkit [41543] by Stephanie Lewis
  • 2 edits in trunk/WebCore

2009-03-09 Stephanie Lewis <Stephanie Lewis>

Fix build.

  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::markAllMisspellingsAndBadGrammarInRanges):
5:22 PM Changeset in webkit [41542] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-09 Kim Christensen <​kimworking@gmail.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24276
Dropdown / select boxes do not consider the windows task bar in Chromium.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup):
3:49 PM Changeset in webkit [41541] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.1

Tagging WebKitGTK+'s 1.1.1 release.

3:40 PM Changeset in webkit [41540] by kov@webkit.org
  • 1 add in releases/WebKitGTK

Creating a place to tag WebKitGTK+ releases.

3:34 PM Changeset in webkit [41539] by weinig@apple.com
  • 2 edits
    14 deletes in trunk/LayoutTests

2009-03-09 Sam Weinig <​sam@webkit.org>

Roll out r41393. It has been causing failures on the bots for about a week.

  • fast/block/float/resources/se_arrow.png: Removed.
  • fast/block/float/resources/yinyang.png: Removed.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
3:20 PM Changeset in webkit [41538] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Adele Peterson and Dave Hyatt.

  • fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields

Test: fast/forms/legend-display-none.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display property of legend elements to 'block' unless it is 'none'.
  • css/html4.css: Do not force the display property of legend elements to 'block' using CSS, because that prevents style rules from setting it to 'none'.

LayoutTests:

Reviewed by Adele Peterson and Dave Hyatt.

  • test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields
  • fast/forms/legend-display-none-expected.txt: Added.
  • fast/forms/legend-display-none.html: Added.
2:01 PM Changeset in webkit [41537] by levin@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-09 Alpha Lam <​hclam@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=23024

Fix an incorrect criteria in the if statement that leaves references to
deleted floating objects in RenderBlock.

Test: fast/block/float/crash-on-absolute-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

2009-03-09 Alpha Lam <​hclam@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=23024

Added regression test for a bug that causes crashes.

  • fast/block/float/crash-on-absolute-positioning.html: Added.
  • platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.
2:01 PM Changeset in webkit [41536] by levin@chromium.org
  • 3 edits
    1 add in trunk/JavaScriptCore

2009-03-09 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 23175: String and UString should be able to share a UChar* buffer.
<​https://bugs.webkit.org/show_bug.cgi?id=23175>

Add CrossThreadRefCounted.

  • wtf/CrossThreadRefCounted.h: Added. (WTF::CrossThreadRefCounted::create): (WTF::CrossThreadRefCounted::isShared): (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe): (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread): (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::CrossThreadRefCounted::~CrossThreadRefCounted): (WTF::CrossThreadRefCounted::ref): (WTF::CrossThreadRefCounted::deref): (WTF::CrossThreadRefCounted::release): (WTF::CrossThreadRefCounted::copy): (WTF::CrossThreadRefCounted::threadSafeDeref):
  • wtf/RefCounted.h:
  • wtf/Threading.h: (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase): (WTF::ThreadSafeSharedBase::derefBase): (WTF::ThreadSafeShared::ThreadSafeShared): (WTF::ThreadSafeShared::deref):
12:48 PM Changeset in webkit [41535] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-09 Mike Belshe <​mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 idl file.
​https://bugs.webkit.org/show_bug.cgi?id=24424

  • page/Location.idl:
12:48 PM Changeset in webkit [41534] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-09 Mike Belshe <​mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 for History.idl.

  • page/History.idl:
12:48 PM Changeset in webkit [41533] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-09 Mike Belshe <​mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 implementations of DOMWindow.idl.

  • page/DOMWindow.idl:
11:39 AM Changeset in webkit [41532] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

2009-03-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

WebKit side of <rdar://problem/6530007>


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEnumerate): Call NetscapePluginInstanceProxy::enumerate.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): Enumerate the JS object and serialize its values.


  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): Ask the plug-in host to get the property names and deserialize them.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
11:06 AM Changeset in webkit [41531] by Simon Fraser
  • 16 edits in trunk/WebCore

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24163

Implement mapping of FloatQuads through 3D transforms.

Removed the redundant localToContainerQuad() methods, which can now
shared code with the old mapLocalToAbsolutePoint(), which was
renamed to mapLocalToContainer(). This can now convert a point,
and optionally a FloatQuad, which are carried along in the TransformState.

Optimized TransformState to reduce to simple FloatPoint.move()
if there are no transforms, and to heap-allocate a transform only if
necessary to accumulate transforms (when using preserve-3d).

Tested by 3d point mapping tests, and the inspector highlight (which now shows
the correct quads for 3d-transformed elements).

10:01 AM Changeset in webkit [41530] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24433

During hit testing with transforms, if a layer has backface-visibility: hidden,
we need to check for it whether or not the layer has a transform, because it
might be an ancestor that is transformed.

Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
9:53 AM Changeset in webkit [41529] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-03-09 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt and Cameron Zwarich

​https://bugs.webkit.org/show_bug.cgi?id=24440

The sublayer added to WebHTMLView to host accelerated compositing layers needs to
be a subclass of NSView which allows context menu clicks through.

  • WebView/WebHTMLView.mm: (-[WebLayerHostingView rightMouseDown:]): (-[WebHTMLView attachRootLayer:]):
9:37 AM Changeset in webkit [41528] by treat@webkit.org
  • 4 edits in trunk

2009-03-09 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=24353
Allow to overrule default build options for Qt build.

  • WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
  • JavaScriptCore.pri: Allow to overrule ENABLE_JIT
9:32 AM Changeset in webkit [41527] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-09 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=24463
WebCore::qstring is detaching and copying twice for every single
WebCore::TextRun that is processed and drawn. This elevates this method
to one of the top-ten most expensive methods in all of QtWebKit according
to profiling. This changes the method so that QString only detaches
when absolutely necessary.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):

Mar 8, 2009:

11:29 PM Changeset in webkit [41526] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Mark Rowe.

[Gtk] Skip failing tests that require the eventSender.

The Gtk+ platform is lacking an implementation of the
eventSender. We will enable the tests once there is an
implementation of that class.

  • platform/gtk/Skipped:
10:36 PM Changeset in webkit [41525] by mrowe@apple.com
  • 33 edits
    2 adds in trunk

Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
Frame.h no longer needs to include it. This cuts the size of the symbols
for a debug build by around 3%.

Reviewed by Oliver Hunt.

  • dom/Element.cpp:

(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):

  • editing/Editor.cpp:

(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::setSelection):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::gotoAnchor):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

  • page/Frame.cpp:

(WebCore::Frame::revealSelection):
(WebCore::Frame::revealCaret):

  • page/Frame.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::autoscroll):

  • rendering/RenderLayer.h:
  • rendering/ScrollBehavior.cpp: Added.

(WebCore::):

  • rendering/ScrollBehavior.h: Added.

(WebCore::):
(WebCore::ScrollAlignment::getVisibleBehavior):
(WebCore::ScrollAlignment::getPartialBehavior):
(WebCore::ScrollAlignment::getHiddenBehavior):

Add the new files to the build systems:

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:

Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:

  • dom/Clipboard.cpp:
  • editing/EditorCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/TypingCommand.cpp:
  • html/HTMLFormControlElement.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/icon/IconLoader.cpp:
  • page/animation/AnimationController.cpp:
  • rendering/RenderSlider.cpp:
  • rendering/RenderTextControl.cpp:

WebKit/mac:

  • Plugins/WebNetscapePluginView.mm:
  • WebView/WebFrame.mm:

(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):

WebKit/win:

  • WebView.cpp:

(WebView::centerSelectionInVisibleArea):

8:44 PM Changeset in webkit [41524] by mrowe@apple.com
  • 9 edits in trunk/WebCore

Push the include of Frame.h out of RenderView.h and down to those files
that need it. This cuts the size of symbols for RenderFoo object files
by around 15% in a debug build.

Reviewed Dan Bernstein.

  • bindings/objc/DOM.mm:
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderView.cpp:

(WebCore::RenderView::zoomFactor):

  • rendering/RenderView.h:
8:18 PM Changeset in webkit [41523] by mrowe@apple.com
  • 12 edits in trunk/WebCore

Remove some unnecessary or redundant includes from files related to the JS bindings.
This cuts the size of the symbols for a debug build by around 3%.

Rubber-stamped by Dan Bernstein.

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSPluginElementFunctions.cpp:
  • bindings/js/JSSVGPODTypeWrapper.h:
8:17 PM Changeset in webkit [41522] by zecke@webkit.org
  • 9 edits in trunk

[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled

setJavaScriptProfilingEnabled is implemented by enabling the
developer extras using the WebKitWebSettings and adding the
JavaScript Profiling option to the WebKitWebInspector.

4:21 PM Changeset in webkit [41521] by cwzwarich@webkit.org
  • 5 edits in trunk/WebCore

2009-03-08 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
and provisionalHistoryItem() from FrameLoader.

  • WebCore.base.exp:
  • WebCore.order:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
12:35 PM Changeset in webkit [41520] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-03-08 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Implement proper logging for the GTK+ port, inspired by the one in
Qt. We use the WEBKIT_DEBUG environment variable which was already
being used to decide whether to setup a logger for soup or not.

  • platform/gtk/LoggingGtk.cpp: (WebCore::getChannelFromName): (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
6:01 AM Changeset in webkit [41519] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

Reviewed by NOBODY(Build fix)

3:47 AM Changeset in webkit [41518] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 24268: RuntimeArray is not a fully implemented JSArray
<​https://bugs.webkit.org/show_bug.cgi?id=24268>

Reviewed by Cameron Zwarich.

Don't cast a type to JSArray, just because it reportsArray as a supertype
in the JS type system. Doesn't appear feasible to create a testcase
unfortunately as setting up the failure conditions requires internal access
to JSC not present in DRT.

Mar 7, 2009:

4:05 PM Changeset in webkit [41517] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Mark Rowe.

  • WebCore part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit):
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didSendBodyData): (WebCore::shouldUseCredentialStorageCallback): (WebCore::ResourceHandle::start):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::filterCookies):

WebKit/win:

Reviewed by Mark Rowe.

  • WebKit part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics
  • WebView.cpp: (WebView::setCacheModel):

WebKitLibraries:

Reviewed by Mark Rowe.

  • WebKitSystemInterface part of removing build-time and run-time support for legacy versions of CFNetwork and Core Graphics
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
2:16 PM Changeset in webkit [41516] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Updated Skipped list per r41464. Not reviewed.
This should remove the warnings that come up everytime we run the gtk layout tests.
​http://trac.webkit.org/changeset/41464

The ff. tests have been moved to fast/css/getComputedStyle in the Skipped list:

fast/css/computed-style-without-renderer.html
fast/css/computed-style.html
fast/css/getComputedStyle-border-box.html

The ff. test has been removed from the Skipped list:

fast/css/marginComputedStyle.html

  • platform/gtk/Skipped:
2:15 PM Changeset in webkit [41515] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Holger Freyther.

Remove fast/canvas/gradient-empty-path.html from the skipped
list as it was removed by r39288.

  • platform/gtk/Skipped:
2:15 PM Changeset in webkit [41514] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http security, plugins and ssl tests
​https://bugs.webkit.org/show_bug.cgi?id=24393

Enable http tests for security, plugins and ssl, skipping tests
that are failing/crashing.

  • platform/gtk/Skipped:
2:15 PM Changeset in webkit [41513] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-03-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http history tests
​https://bugs.webkit.org/show_bug.cgi?id=24394

Get the index of the current item from the list of (history) items
to print before adding the back history items to the list. This
will make the 'curr' pointer point to the correct item in the
actual results, therefore, passing some of the http/tests/history
tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpBackForwardListForWebView):

2009-03-07 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Enable http history tests
​https://bugs.webkit.org/show_bug.cgi?id=24394

Enable http/tests/history, adding failing tests to the Skipped list.

  • platform/gtk/Skipped:
1:28 PM Changeset in webkit [41512] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Alexey Proskuryakov.

  • fix a bug where debug builds were clearing the HTML5 application cache on application termination
  • WebView/WebView.mm: (-[WebView _close]): Call -[WebCache setDisabled:YES] instead of -[WebCache empty].
11:46 AM Changeset in webkit [41511] by adele@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

2009-03-07 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=24444
No multiple JS property for <input type="file" multiple />

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::multiple): (WebCore::HTMLInputElement::setMultiple):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:

LayoutTests:

2009-03-07 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=24444
No multiple JS property for <input type="file" multiple />

  • fast/forms/input-multiple-expected.txt: Added.
  • fast/forms/input-multiple.html: Added.
10:42 AM Changeset in webkit [41510] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-07 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Cameron Zwarich.

These methods are clearly returning the wrong values as the two were
returning swapped information.

  • Api/qwebpage.cpp: (QWebPage::totalBytes): (QWebPage::bytesReceived):
4:03 AM Changeset in webkit [41509] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-03-07 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

ScrollView scrollbars in subframes are *not* native, so take that
into account again.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::getLocationInParentWindow): (ScrollbarGtk::frameRectsChanged): (ScrollbarGtk::paint):
  • platform/gtk/ScrollbarGtk.h:

Mar 6, 2009:

8:58 PM Changeset in webkit [41508] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-03-06 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

When preforming an op_mov, preserve any existing register mapping.

~0.5% progression on v8 tests x86-64.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
4:26 PM Changeset in webkit [41507] by pkasting@chromium.org
  • 3 edits in trunk/WebCore

2009-03-06 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24405
Horizontal scrolling on Windows was reversed from Mac (and intuition).

  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
4:15 PM Changeset in webkit [41506] by mrowe@apple.com
  • 4 edits in tags/Safari-6530.2

Versioning.

3:47 PM Changeset in webkit [41505] by pkasting@chromium.org
  • 5 edits in trunk/WebCore

2009-03-06 Peter Kasting <​pkasting@google.com>

Reviewed by Sam Weinig.

Convert some C-style casts to static_cast<>()s.

  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3:05 PM Changeset in webkit [41504] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:03 PM Changeset in webkit [41503] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.2

New tag.

3:01 PM Changeset in webkit [41502] by Darin Adler
  • 3 edits in trunk/LayoutTests

2009-03-06 Darin Adler <Darin Adler>

Fixed broken test I just landed for bug 24422.

  • fast/dom/location-new-window-no-crash-expected.txt: Updated.
  • fast/dom/resources/location-new-window-no-crash.js: Added code to make the window opening and closing work in DumpRenderTree.
2:12 PM Changeset in webkit [41501] by adele@apple.com
  • 2 edits in trunk/WebCore

2009-03-06 Adele Peterson <​adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)

I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.

  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element. That is no longer true, so we should return the document element for a truly empty document.
1:32 PM Changeset in webkit [41500] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-06 Jay Campan <​jcampan@google.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24306

Adding a flag to ResourceRequestBase to indicate whether or not upload
progress notifications are needed for a resource. This is useful to
avoid sending these notifications when there are no consumers
(especially in the Chromium case where IPC is involved).

  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::reportUploadProgress): (WebCore::ResourceRequestBase::setReportUploadProgress): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously):
1:21 PM Changeset in webkit [41499] by dimich@chromium.org
  • 13 edits
    7 adds in trunk

WebCore:

2009-03-04 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test: http/tests/workers/text-encoding.html

  • dom/Document.cpp: (WebCore::Document::encoding):
  • dom/Document.h: (WebCore::Document::inputEncoding): (WebCore::Document::charset): (WebCore::Document::characterSet): Add new virtual method and route DOM synonym functions on Document through it.
  • dom/ScriptExecutionContext.h:
  • workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::encoding): (WebCore::WorkerContext::completeURL): Added comment on why this is different from Document::completeURL
  • workers/WorkerContext.h: (WebCore::WorkerContext::create):
  • workers/WorkerContextProxy.h:
  • workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
  • workers/WorkerThread.h: All of the above route the 'encoding' parameter of parent context to the new instance of WorkerContext - from Worker::notifyFinished() via WorkerMessagingProxy through WorkerThread through WorkerThreadStartupData and into constructor of WorkerContext.

LayoutTests:

2009-03-04 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24150
Add virtual ScriptExecutionContext::encoding()

Test to verify how the text encoding in workers is used.
Script decoding and url completion is checked, with and
w/o http 'Content-Type: ...;charset=...' header.

  • http/tests/workers/resources/worker-encoded.php: Added.
  • http/tests/workers/resources/xhr-query-utf8.php: Added.
  • http/tests/workers/resources/xhr-response.php: Added.
  • http/tests/workers/text-encoding-expected.txt: Added.
  • http/tests/workers/text-encoding.html: Added.
12:43 PM Changeset in webkit [41498] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-03-06 Peter Kasting <​pkasting@google.com>

Build bustage fix.

  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):
12:17 PM Changeset in webkit [41497] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): Delay callback while setting up movieview.
12:08 PM Changeset in webkit [41496] by justin.garcia@apple.com
  • 13 edits in trunk

WebCore:

2009-03-06 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Justin Garcia.


​https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.
Tested manually in Mail and Safari; automated tests to come later.


  • editing/Editor.cpp: (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
  • editing/Editor.h:
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph):
  • page/EditorClient.h:
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

WebKit/mac:

2009-03-06 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Justin Garcia.

​https://bugs.webkit.org/show_bug.cgi?id=24108

Update spelling and grammar checking to use the new combined text
checking (with automatic language identification) on Snow Leopard.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingAndGrammarOfParagraph):
11:52 AM Changeset in webkit [41495] by pkasting@chromium.org
  • 10 edits in trunk/WebCore

2009-03-06 Peter Kasting <​pkasting@google.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24407
Windows scroll amount was too small, and wheel scroll distance
conversion code was overly complex.

  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent):
  • platform/PlatformWheelEvent.h: (WebCore::):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/Scrollbar.h:
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/WheelEventWin.cpp: (WebCore::horizontalScrollChars): (WebCore::verticalScrollLines): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
11:18 AM Changeset in webkit [41494] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-03-06 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

When building QtWebKit in release mode make sure that QT_SHARED is defined
otherwise none of the public API will be exported. This leads to missing
symbols and link errors if hidden-visibility is used.

  • Scripts/webkitdirs.pm:
11:14 AM Changeset in webkit [41493] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-06 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

Generate valid bindings with HTML5 database support disabled.

  • inspector/InspectorController.idl: Added feature guard around databaseTableNames definition.
11:06 AM Changeset in webkit [41492] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-03-04 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Do not take into account the case of being a ScrollView scrollbar,
since those are native in our case.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::frameRectsChanged):
11:06 AM Changeset in webkit [41491] by xan@webkit.org
  • 4 edits in trunk/WebCore

2009-03-04 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Move Widget::paint to ScrollbarGtk::paint, since it's scrollbar
specific and it's our only Widget anyway.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::paint):
  • platform/gtk/ScrollbarGtk.h:
  • platform/gtk/WidgetGtk.cpp:
11:06 AM Changeset in webkit [41490] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-03-04 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24358
[GTK] Scrollbars not clipped correctly

Use correct clip rectangle and apply coordinate translation needed
for non-ScrollView scrollbars.

We were ignoring the clip rectangle passed as parameter, which is
wrong in the case of non coalesced expose events. This, in turn,
uncovers the fact that we were not applying coordinate translation
to our position.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):
11:05 AM Changeset in webkit [41489] by Adam Roben
  • 2 edits in trunk/WebKitTools

Change the isCygwin check in update-webkit to isAppleWinWebKit

This matches a similar check in build-webkit, and is more correct.

Reviewed by Alexey Proskuryakov.

  • Scripts/update-webkit: Only call update-webkit-auxiliary-libs if isAppleWinWebKit is true.
11:05 AM Changeset in webkit [41488] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is present but out of date

Reviewed by Alexey Proskuryakov.

  • Scripts/update-webkit-support-libs: Changed to use dieAndInstructToDownload when the zip file doesn't exist. Added an MD5 check to make sure the file is up-to-date. If it is out of date, print an error message and quit. (sub dieAndInstructToDownload): Added. Prints an error message and quits with an error.
11:03 AM Changeset in webkit [41487] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-06 Eric Carlson <​eric.carlson@apple.com>

Build fix, no review

  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: fix setSize declaration
10:55 AM Changeset in webkit [41486] by eric.carlson@apple.com
  • 14 edits in trunk/WebCore

2009-03-06 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=22790
Bug 22790: [Transforms] MediaPlayer::setRect() makes no sense with transforms
Replace media engine setRect with setSize since they don't use about the
position anyway.

  • platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setSize): Changed from setRect. (WebCore::MediaPlayer::setSize): Ditto.
  • platform/graphics/MediaPlayer.h: (WebCore::MediaPlayer::size): Changed from rect().
  • platform/graphics/MediaPlayerPrivate.h: Changed setRect to setSize.
  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: Ditto.
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_size instead of m_rect (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): update comment
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: m_rect -> m_size.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: m_rect
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_rect. (WebCore::MediaPlayerPrivate::createQTMovieView): setRect-> setSize. (WebCore::MediaPlayerPrivate::setSize): Changed from setRect (WebCore::MediaPlayerPrivate::paint): Call view:setFrame: when in a media document so the movie is drawn in the correct location.
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::setSize): Changed from setRect
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::updatePlayer): Call setSize instead of setRect.
10:55 AM Changeset in webkit [41485] by cmarrin@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24363

Fixed test and fixed expected results to reflect the fix

9:22 AM Changeset in webkit [41484] by Darin Adler
  • 3 edits
    3 adds in trunk

WebCore:

2009-03-06 Darin Adler <Darin Adler>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
​https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

Test: fast/dom/location-new-window-no-crash.html

The issue here is empty (or null) URLs. I picked the "schedule navigation" bottleneck
to add some checks for empty URLs. We could also put the empty URL checks at some
other bottleneck level and add more assertions over time. I tried adding a few more
assertions to functions like loadURL and hit them while running the regression tests,
so it's probably going to be a bit tricky to clean this up throughout the loader.

  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Explicitly marked this struct immutable by making all its members const. Added assertions about the arguments, including that the URL is not empty. Initialized one uninitialized member in one of the constructors. (WebCore::FrameLoader::scheduleHTTPRedirection): Added an early exit to make this a no-op if passed an empty URL. (WebCore::FrameLoader::scheduleLocationChange): Ditto. (WebCore::FrameLoader::scheduleRefresh): Ditto.

LayoutTests:

2009-03-06 Darin Adler <Darin Adler>

Reviewed by Darin Fisher.

Bug 24422: REGRESSION: null-URL crash in FrameLoader setting location.hash on new window
​https://bugs.webkit.org/show_bug.cgi?id=24422
rdar://problem/6402208

The new test manipulates all the properties of the location object on a new window which
has no location yet. I tested Firefox too and added comments about how its behavior differs
from WebKit. At some point we may want to tweak our behavior to be a bit closer to theirs,
or check IE's behavior or if HTML 5 or some other W3 specification has something to say
about this, but for now the main purpose of the test is to verify we don't crash.

  • fast/dom/location-new-window-no-crash-expected.txt: Added.
  • fast/dom/location-new-window-no-crash.html: Added.
  • fast/dom/resources/location-new-window-no-crash.js: Added.
8:35 AM Changeset in webkit [41483] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Disable accumulating chunks for request_body on file uploads,
using the new soup API.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
8:35 AM Changeset in webkit [41482] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24423
Use new soup_message_body_set_accumulate API in soup backend

Replace use of deprecated SOUP_MESSAGE_OVERWRITE_CHUNKS flag with
the new soup_message_body_set_accumulate API in soup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
7:54 AM Changeset in webkit [41481] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-03-06 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24051
Soup backend needs content sniffing capabilities

Perform content sniffing when using soup, so that we have a chance
of figuring out the Content-Type of the file if it's not sent by
the server.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback):
7:42 AM Changeset in webkit [41480] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-03-06 Darin Adler <Darin Adler>

  • fast/dom/Window/window-properties-expected.txt: Updated for recent addition of canPlayType.
5:27 AM Changeset in webkit [41479] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Olliej.

​https://bugs.webkit.org/show_bug.cgi?id=24295
webkit_web_back_forward_list_add_item needs a Since tag

Add missing Since tag to webkit_web_back_forward_list_add_item
documentation.

  • webkit/webkitwebbackforwardlist.cpp:
5:24 AM Changeset in webkit [41478] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24417
[GTK] WebKitDownload's _cancel and _dispose methods may emit warnings

NULL-check for timer on _cancel and _dispose, to avoid bad
warnings.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_cancel):
3:13 AM Changeset in webkit [41477] by ap@webkit.org
  • 6 edits
    2 adds in trunk

2009-03-06 Hironori Bono <​hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24342
Cannot insert a Thai character after a Thai prepend character when using ICU 4.0

This change creates a new break iterator "cursorMovementIterator" for
moving cursors and use it when moving an input cursor.
In "TextBreakIteratorICU.cpp", this break iterator uses custom ruleset
based on the one of ICU 3.8.
On the other hand, in "TextBreakIteratorQt.cpp", this break iterator
just calls the characterBreakIterator() function.

Test: editing/inserting/insert-thai-characters-001.html

  • platform/text/TextBreakIterator.h: Added a new function cursorMovementIterator().
  • platform/text/TextBreakIteratorICU.cpp: Implemented the cursorMovementIterator() function for ICU. (WebCore::setUpIteratorWithRules): Ditto. (WebCore::cursorMovementIterator): Ditto.
  • platform/text/qt/TextBreakIteratorQt.cpp: Implemented the cursorMovementIterator() function for Qt. (WebCore::cursorMovementIterator): Ditto.
  • rendering/RenderText.cpp: Call the cursorMovementIterator() function when moving an input cursor. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.
Note: See TracTimeline for information about the timeline view.