Timeline


and

03/13/09:

23:17 Changeset [41698] by mrowe@apple.com

Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

  • Configurations/DebugRelease.xcconfig:
23:17 Changeset [41697] by mrowe@apple.com

Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

23:17 Changeset [41696] by mrowe@apple.com

Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it. This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

  • Scripts/build-webkit: Remove architecture-related code.
  • Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
  • Scripts/run-javascriptcore-tests: Remove architecture-related code.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments. The --32-bit argument will set the

architecture preference to the 32-bit architecture of the machine. The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.

  • Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the

auto-detection.

23:17 Changeset [41695] by mrowe@apple.com

Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings. When building in Xcode, this setting isn't present so
Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

  • JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is

already newer than the input file.

17:53 Changeset [41694] by dimich@chromium.org

2009-03-13 John Abd-El-Malek <jam@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24593
Added requestorID so we can track the request to its WebView without using frame (which was removed).

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::requestorID): (WebCore::ResourceRequest::setRequestorID): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::policyURL): (WebCore::ResourceRequest::setPolicyURL): (WebCore::ResourceRequest::requestorPid): (WebCore::ResourceRequest::setRequestorPid):
16:07 Changeset [41693] by dglazkov@chromium.org

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24561
Add custom V8 bindings for HTMLElementCanvas, Location.

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
  • bindings/v8/custom/V8LocationCustom.cpp: Added.
15:47 Changeset [41692] by eric@webkit.org

2009-03-13 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24584

Fix transparent text rendering on Chromium. FontChromiumWin
was calling beginTransparencyLayer()/endTransparencyLayer(), with
a TransparencyWin inside to do GDI ClearType rendering over an
opaque background. TransparencyWin does its special sauce
in the destructor, but it was being called too late to be used
correctly in the layer. Put the special sauce into a new function,
composite(), and call that explicitly instead.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::~TransparencyWin): (WebCore::TransparencyWin::composite): (WebCore::TransparencyWin::init):
  • platform/graphics/chromium/TransparencyWin.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::):
15:46 Changeset [41691] by dglazkov@chromium.org

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24562
Add custom implementation for getCSSCanvasContext to V8 bindings.

  • bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
15:43 Changeset [41690] by eric@webkit.org

2009-03-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Add tests for various types of textareas. Tests in both
quirks and standards modes. Although only the standards
modes tests fit in the pixel results.
https://bugs.webkit.org/show_bug.cgi?id=24370

  • fast/forms/basic-textareas.html: Added.
  • platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/mac/fast/forms/basic-textareas-expected.png: Added.
  • platform/mac/fast/forms/basic-textareas-expected.txt: Added.
15:42 Changeset [41689] by dglazkov@chromium.org

2009-03-13 Mike Belshe <mike@belse.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior.

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): remove extra logic around question mark.
15:32 Changeset [41688] by andersca@apple.com

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Geoffrey Garen.

<rdar://problem/6590384>
REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting


When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call,
and thus calling -[WebView hostWindow] will crash since _private is nil.


  • WebView/WebView.mm: (-[WebView hostWindow]):
15:20 Changeset [41687] by cfleizach@apple.com

Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
https://bugs.webkit.org/show_bug.cgi?id=24474

15:01 WebKit Team edited by ojan@chromium.org
(diff)
15:00 Changeset [41686] by dimich@chromium.org

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24589
Upstream changes to V8 event listeners (Chromium r11133) in order to
fix worker functionality break in Chromium.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
14:53 WebKit Team edited by dglazkov@chromium.org
Ego-tuning. (diff)
14:52 Changeset [41685] by dimich@chromium.org

2009-03-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

Resolved name conflict with globally defined tzname in Symbian.
Replaced with different name instead of using namespace qualifier
(appeared to be less clumsy).

  • runtime/DateMath.cpp:
14:48 WebKit Team edited by pam@chromium.org
(diff)
14:45 WebKit Team edited by abarth@webkit.org
(diff)
14:31 Changeset [41684] by dglazkov@chromium.org

2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24524
Introduce ScriptObject and ScriptFunctionCall abstractions.

  • GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/ScriptFunctionCall.cpp: Added.
  • bindings/js/ScriptFunctionCall.h: Added.
  • bindings/js/ScriptObject.cpp: Added.
  • bindings/js/ScriptObject.h: Added.
  • bindings/js/ScriptObjectQuarantine.cpp: Added.
  • bindings/js/ScriptObjectQuarantine.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind. (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind. (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
  • inspector/InspectorController.h: Removed addScriptDatabaseResource and removeScriptDatabaseResource declarations.
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): Added. (WebCore::InspectorDatabaseResource::unbind): Added.
  • inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
14:26 Changeset [41683] by pkasting@chromium.org

2009-03-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24467
Make Skia drawRect() and stroke behavior match CG.

This makes drawRect() ignore the stroke width (like CG does), and
adds a warning comment about that to the appropriate header.

It also eliminates some hacky code in Skia's stroke preparation,
which tried to adjust odd-width strokes to fall on pixel boundaries.
Not only did this not match CG, it wouldn't necessarily work right,
because there could be other transforms (e.g. full-page zoom) that
would affect the stroke before it reached the device pixel level.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintForStroking):
13:45 Changeset [41682] by dimich@chromium.org

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24583
Need to change scope of constructor and destructor of V8ObjectEventListener from private
to protected so that they could be used in its derived class V8WorkerContextEventListener.

  • bindings/v8/V8ObjectEventListener.h:
12:53 Changeset [41681] by andersca@apple.com

2009-03-13 Anders Carlsson <andersca@apple.com>

And yet another attempt...


  • Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler):
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
12:52 Changeset [41680] by andersca@apple.com

2009-03-13 Anders Carlsson <andersca@apple.com>

Another attempt at fixing the build.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
12:39 Changeset [41679] by andersca@apple.com

2009-03-13 Anders Carlsson <andersca@apple.com>

Try to fix the SL build.

  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown):
12:13 Changeset [41678] by levin@chromium.org

2009-03-13 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24579
Many V8*Event* files are misplaced.

This code is infrastructure for supporting the bindings and thus should
be in the bindings/v8 directory.

  • bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
  • bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
  • bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
  • bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
  • bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
  • bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
  • bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
  • bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
12:06 Changeset [41677] by adele@apple.com

WebCore:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

Test: editing/pasteboard/5089327.html

Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans):

LayoutTests:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

  • editing/pasteboard/5089327.html: Added.
  • platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5089327-expected.png: Added.
  • platform/mac/editing/pasteboard/5089327-expected.txt: Added.

Updated colors for pasted content.

  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:
11:57 Changeset [41676] by andersca@apple.com

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Update to match new API.


  • NetscapeInputMethodPlugin/main.m: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleDraw): (invalidatePlugin): (handleFocusChanged): (handleMouseMoved): (handleMouseDown): (handleTextFieldKeyDown): (handleTextInput): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
11:56 Changeset [41675] by bolsinga@apple.com

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.


WebChromeClient now calls the private UI delegate method
-webView:frame:requestGeolocationPermission:securityOrigin:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestGeolocationPermissionForFrame):
  • WebCoreSupport/WebGeolocation.mm: Added. (WebCore::if): (-[WebGeolocation shouldClearCache]): (-[WebGeolocation setIsAllowed:]): (-[WebGeolocation dealloc]):
  • WebCoreSupport/WebGeolocationInternal.h: Added.
  • WebCoreSupport/WebGeolocationPrivate.h: Added.
  • WebView/WebUIDelegatePrivate.h:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.

  • WebKit.xcodeproj/project.pbxproj:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Geolocation now requests permission from the Chrome asynchronously.
The Chrome is passed the Geolocation object, and the Chrome sets the permission
on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
of SecurityOrigins with geolocation permission. This is so that the GeolocationService
can inform the Chrome of its request, and the Chrome is also free to implement its
own policy.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::requestGeolocationPermissionForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::displayChallengeIfNecessary): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h: (WebCore::Geolocation::isAllowed): (WebCore::Geolocation::setShouldClearCache): (WebCore::Geolocation::shouldClearCache): (WebCore::Geolocation::):
11:44 Changeset [41674] by andersca@apple.com

WebCore:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Add a NPCocoaEventTextInput event type. Remove the text input variables.


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Remove nptextinput.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Replace the text input API with a simpler API that uses a separate text input window.


  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): Initialize m_keyEventHandler to 0.


(WebNetscapePluginEventHandlerCocoa::keyDown):
If the plug-in returns 0 from NPP_HandleEvent, pass the event to the TSM machinery.


(WebNetscapePluginEventHandlerCocoa::focusChanged):
Install/remove the key event handler as needed.


(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
Get the text and send a TextInput event.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Remove the old text input API.


(-[WebNetscapePluginView inputContext]):
Always return nil here.


  • Plugins/npapi.mm:
  • Plugins/nptextinput.h: Removed.

WebKitTools:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Add a case statement for NPCocoaEventTextInput.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa):
11:18 Changeset [41673] by kdecker@apple.com

Reviewed by Anders.

<rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed


The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
for x-oleobject.


  • rendering/RenderPartObject.cpp: (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
10:57 WebKit Team edited by abarth@webkit.org
(diff)
10:47 WebKit Team edited by dimich@chromium.org
(diff)
10:45 Changeset [41672] by pam@chromium.org

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add tests for window property lookup precedence in the presence of
conflicting names in a child frame and in a named document element.

https://bugs.webkit.org/show_bug.cgi?id=24170

  • fast/dom/Window/resources/window-properties.js: Added.
  • fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • fast/dom/Window/window-lookup-precedence.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldEvaluateTo): Added. Compares expected values of various types.
10:32 Changeset [41671] by levin@chromium.org

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24559
Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.

  • bindings/v8/custom/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
10:32 Changeset [41670] by levin@chromium.org

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24557
This is to support running multiple workers in a single worker process in chromium.

  • bindings/v8/custom/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): Add locker to v8 event listener of worker context.
10:09 Changeset [41669] by pam@chromium.org

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to ensure that DOM constructors have higher lookup
precedence than a document element with the same name.

https://bugs.webkit.org/show_bug.cgi?id=24520

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
09:52 WebKit Team edited by pam@chromium.org
(diff)
09:20 Changeset [41668] by pam@chromium.org

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that the JS wrapper for the document in an
inner frame is created in the correct context when it's accessed
from the outer frame first.

https://bugs.webkit.org/show_bug.cgi?id=24564

  • fast/dom/resources/wrapper-context-inner.html: Added.
  • fast/dom/wrapper-context-expected.txt: Added.
  • fast/dom/wrapper-context.html: Added.
09:11 WebKit Team edited by treat@kde.org
Update with new reviewers and affiliations (diff)
06:25 Changeset [41667] by ap@webkit.org

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24575
XHR response is incorrect after a network error.

Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html

http/tests/xmlhttprequest/cross-site-denied-response-sync.html
http/tests/xmlhttprequest/cross-site-denied-response.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request. (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note that since internalAbort() can drop GC protection, it is not safe to use the object after this call. (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and return early if it was. This can happen during sync requests, as the loader does not know that it was aborted, and just synthesizes all callbacks.
05:57 Changeset [41666] by ap@webkit.org

Updating results after the fix for bug 3547.

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: The status text for a failed local file load is no longer "OK", which is good.
04:06 Changeset [41665] by ap@webkit.org

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=3547
XMLHttpRequest.statusText returns always "OK"

Covered by existing tests (which now pass on all platforms but Mac).

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up to each platform to correctly set the status text or set it to "OK" to retain current behavior.
03:05 Changeset [41664] by ap@webkit.org

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24349
[QT] HTTP status text is never set

Set HTTP status text to the reason phrase attribute of QNetworkReply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

03/12/09:

23:23 Changeset [41663] by mitz@apple.com
  • Skipped file fix
  • platform/mac-tiger/Skipped:
23:07 Changeset [41662] by simon.fraser@apple.com

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe

<rdar://problem/6622300>: Reproducible crash on
<http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>

Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
deleted from under itself. The sheetLoaded() notification can allow scripts
to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
which can cause the last ref to the CSSStyleSheet to be released.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
22:28 Changeset [41661] by kevino@webkit.org

wx build fix. Let DerivedSources.make know we want database APIs.

20:33 Changeset [41660] by mrowe@apple.com

<rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages

  • wtf/FastMalloc.cpp:

(WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
span as well so that the flag in the merged span is accurate.

  • wtf/Platform.h:
  • wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.

(TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
(TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.

  • wtf/TCSystemAlloc.h:
20:10 Changeset [41659] by treat@webkit.org

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=24498
Fix the Qt port to use the same algorithm for drawing dashed and dotted
borders as the other ports. This makes the Qt port pixel-for-pixel perfect
compared to border drawing with Apple's canonical mac port and much closer
to konqueror and firefox behavior.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine):
17:15 Changeset [41658] by mitz@apple.com

Reviewed by Anders Carlsson.

  • skip editing/selection/word-thai.html on Tiger because it has an older version of Unicode.
  • platform/mac-tiger/Skipped:
16:05 Changeset [41657] by eric@webkit.org

Reviewed by Justin Garcia.

Clean up DOMSelection to use some helper functions
making the code smaller, and less error-prone.
https://bugs.webkit.org/show_bug.cgi?id=19221

I tried moving DOMSelection off of rangeCompliantEquivalent
but failed. VisibleSelection holds positions like (table, 1) to mean
"after the table".

  • page/DOMSelection.cpp: (WebCore::DOMSelection::visibleSelection): (WebCore::anchorPosition): (WebCore::focusPosition): (WebCore::basePosition): (WebCore::extentPosition): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::extentOffset):
  • page/DOMSelection.h:
15:47 Changeset [41656] by dimich@chromium.org

2009-03-12 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24563
Change ResourceRequest to be a struct rather then a class to match other declarations.

  • platform/network/chromium/ResourceRequest.h:
15:15 Changeset [41655] by andersca@apple.com

Add Mark.

15:13 Changeset [41654] by andersca@apple.com

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Mike Thole.

Fix <rdar://problem/6624105>.


Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
15:05 Changeset [41653] by levin@chromium.org

2009-03-12 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

Bug 16348: @font-face does not affect the default style
<https://bugs.webkit.org/show_bug.cgi?id=16348>

  • fast/css/font-face-default-font.html: Handle the default font being either 'Times' or 'Times New Roman'.
15:05 Changeset [41652] by levin@chromium.org

2009-03-12 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

Bug 24530: width100percent-searchfield.html should be fixed for chromium.
<https://bugs.webkit.org/show_bug.cgi?id=24530>

Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html

  • css/themeChromiumWin.css: Added. Overrides the changes to start supporting input[type="search"] on Windows (since Chromium doesn't do anything special for this).
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::supportsFocus): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::determineState): (WebCore::RenderThemeChromiumWin::getThemeData):
15:01 Changeset [41651] by pam@chromium.org

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that an invalid second argument of
window.postMessage is ignored. Note that this is probably not the
correct behavior according to the HTML5 spec, so this test will
need to be changed once we support that.

https://bugs.webkit.org/show_bug.cgi?id=24523

  • fast/dom/Window/window-postmessage-args-expected.txt: Added.
  • fast/dom/Window/window-postmessage-args.html: Added.
14:21 Changeset [41650] by bolsinga@apple.com

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position


Get up to date.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions):
  • page/Coordinates.cpp: Added. (WebCore::Coordinates::toString):
  • page/Coordinates.h: Added. (WebCore::Coordinates::create): (WebCore::Coordinates::latitude): (WebCore::Coordinates::longitude): (WebCore::Coordinates::altitude): (WebCore::Coordinates::accuracy): (WebCore::Coordinates::altitudeAccuracy): (WebCore::Coordinates::heading): (WebCore::Coordinates::speed): (WebCore::Coordinates::Coordinates):
  • page/Coordinates.idl: Added.
  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
  • page/Geoposition.h: (WebCore::Geoposition::create): (WebCore::Geoposition::coords): (WebCore::Geoposition::Geoposition):
  • page/Geoposition.idl:
  • page/PositionOptions.h: (WebCore::PositionOptions::create): (WebCore::PositionOptions::maximumAge): (WebCore::PositionOptions::setMaximumAge): (WebCore::PositionOptions::PositionOptions):
  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
14:10 Changeset [41649] by dglazkov@chromium.org

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string, for V8 bindings.

Test: fast/js/console-non-string-values.html

  • bindings/v8/ScriptValue.cpp: Added toString method. (WebCore::ScriptValue::toString):
  • bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes

and toString declaration.

14:08 Changeset [41648] by darin@chromium.org

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate ChromiumBridge::uiResourceProtocol
https://bugs.webkit.org/show_bug.cgi?id=24558

  • platform/chromium/ChromiumBridge.h:
13:44 Changeset [41647] by bolsinga@apple.com

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Missing breaks in switch statement
https://bugs.webkit.org/show_bug.cgi?id=24556

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
13:39 Changeset [41646] by darin@chromium.org

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24554
Remove some unused functions from ChromiumBridge.

  • platform/chromium/ChromiumBridge.h:
13:29 Changeset [41645] by eric@webkit.org

Reviewed by Darin Fisher and Justin Garcia.

Safari crashes during drag and drop in Google presentations
due to mutation event handlers removing DOM content during insertNode
https://bugs.webkit.org/show_bug.cgi?id=22634

Added a bunch of "null" checks to make sure nodes are still
in the document before we operate on them. This is an
inelegant solution, but it's the best we have for now.

Test: editing/selection/crash-on-drag-with-mutation-events.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
13:11 Changeset [41644] by simon.fraser@apple.com

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=24508

Fix updating of text field with placeholder text when value is set
by ensuring that updatePlaceholderVisibility() is called after
the value has been updated, not before.

Test: fast/forms/placeholder-set-value.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
12:52 Changeset [41643] by dglazkov@chromium.org

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=24525
REGRESSION: Inspector window doesn't close when inspected page is
destroyed. This is a revert of r41158, which became unnecessary when
InspectorController became ref-counted in r41462.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage

after calling close().

(WebCore::InspectorController::stopUserInitiatedProfiling): Remove

m_inspectedPage check guard around profile logic.

12:41 Changeset [41642] by pkasting@chromium.org

WebCore:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/win:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

  • WebView.cpp: (WebView::mouseWheel): (WebViewWndProc):
  • WebView.h:
12:36 Changeset [41641] by andersca@apple.com

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6607801>


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Pass a requestID to _WKPCDestroyPluginInstance and wait until we get a reply back.


  • Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameter.
12:34 Changeset [41640] by dglazkov@chromium.org

WebCore:

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string.

Test: fast/js/console-non-string-values.html

  • bindings/js/ScriptValue.cpp: Removed PlatformString include.
  • bindings/js/ScriptValue.h: Added toString method. (WebCore::ScriptValue::toString):
  • page/Console.cpp: (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use

ScriptValue::toString.

(WebCore::Console::addMessage): added extra ScriptState argument to callsite.
(WebCore::Console::count): Ditto.

LayoutTests:

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24496
Test for logging non-string values.

  • fast/js/console-non-string-values-expected.txt: Added.
  • fast/js/console-non-string-values.html: Added.
12:32 Changeset [41639] by kov@webkit.org

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Rename 'state' to 'status' to match the naming in the frame
loader rework that we plan to land soonish, and make it a
property, for the same reason.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_status): (_WebKitDownloadPrivate::webkit_download_set_status): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error):
  • webkit/webkitdownload.h:
12:32 Changeset [41638] by kov@webkit.org

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Improved documentation for the download-requested signal, to make
its usage clear.

  • webkit/webkitwebview.cpp:
12:27 Changeset [41637] by simon.fraser@apple.com

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24552

Hit testing involving normal flow, self-painting layers (e.g. reflections)
was broken because it was not null-testing the result of hitTestLayer(),
so bailing early with a nil hit layer.

Test: fast/layers/normal-flow-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
11:33 Changeset [41636] by pam@chromium.org

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to make sure window.location and window.navigator
have higher lookup precedence than a DOM element with that ID.

https://bugs.webkit.org/show_bug.cgi?id=24522

  • fast/dom/Window/window-special-properties-expected.txt:
  • fast/dom/Window/window-special-properties.html:
11:30 Changeset [41635] by kdecker@apple.com

Reviewed by Anders Carlsson.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Simply a small SUPPORT_CFM code block.
11:20 Changeset [41634] by kdecker@apple.com

Reviewed by Anders Carlsson.

Fixed: <rdar://problem/5815862> Opening a subclassed NSWindow from a Safari plugin causes Safari to crash on Quit


This fix addresses crashes in both Silverlight and ChemDraw. This type of crash would occur because AppKit still
had a reference to open windows that the plugin created (which no longer exist).


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Do not unload the plug-in bundle on browser shutdown.
11:08 Changeset [41633] by dglazkov@chromium.org

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Cameron Zwarich.

Removed zero-sized files, left over from improperly applied patch.

  • platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
  • platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.
11:04 Changeset [41632] by treat@webkit.org

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by NOBODY (Build fix).

Include string.h for strlen usage.

  • wtf/Threading.cpp:
10:24 Changeset [41631] by pam@chromium.org

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Add a test to make sure GC doesn't drop XHR wrappers too soon.
https://bugs.webkit.org/show_bug.cgi?id=24528

  • fast/dom/xmlhttprequest-gc-expected.txt: Added.
  • fast/dom/xmlhttprequest-gc.html: Added.
09:35 Changeset [41630] by treat@webkit.org

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Do not ignore alpha color in optimization. Hard to believe, but there
are websites that fill the entire page with a tiled image consisting of
nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
09:22 Changeset [41629] by aroben@apple.com

Implement DOMHTMLDocument::title

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp: (DOMHTMLDocument::title): Call through to WebCore::Document (with obligatory COM error checking/type conversions).
08:28 Changeset [41628] by ddkilzer@apple.com

Fixed ChangeLog date.

08:26 Changeset [41627] by ddkilzer@apple.com

Add NO_RETURN attribute to runInteractive() when not using readline

Reviewed by Darin Adler.

  • jsc.cpp: (runInteractive): If the readline library is not used, this method will never return, thus the NO_RETURN attribute is needed to prevent a gcc warning.
08:01 Changeset [41626] by aroben@apple.com

Adopt setThreadNameInternal on Windows

Also changed a Windows-only assertion about thread name length to an
all-platform log message.

Reviewed by Adam Treat.

  • wtf/Threading.cpp: (WTF::createThread): Warn if the thread name is longer than 31 characters, as Visual Studio will truncate names longer than that length.
  • wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Renamed from setThreadName and changed to always operate on the current thread. (WTF::initializeThreading): Changed to use setThreadNameInternal. (WTF::createThreadInternal): Removed call to setThreadName. This is now handled by threadEntryPoint and setThreadNameInternal.
08:00 Changeset [41625] by kov@webkit.org

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Also make page up and page down keys be handled by the webview key
event code, so that they also work in cases where the GTK+
scrollbars don't handle them directly, like in the bugzill's patch
review page.

  • webkit/webkitwebview.cpp:
08:00 Changeset [41624] by kov@webkit.org

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Make home and end keys behave more consistently for scrolling the
view.

  • webkit/webkitwebview.cpp:
07:46 Changeset [41623] by ddkilzer@apple.com

Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs

<https://bugs.webkit.org/show_bug.cgi?id=24378>

Reviewed by Adam Roben.

Scripts/resolve-ChangeLogs: If -ffix-merged is not passed

and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.

06:18 Changeset [41622] by kov@webkit.org

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24254
[GTK] spacebar doesn't scroll down

Make spacebar and shift+spacebar scroll like page up and down
respectively would.

  • webkit/webkitwebview.cpp:
05:42 Changeset [41621] by jchaffraix@webkit.org

2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 24110: cloneNode should call cloneElement and not the reverse

  • Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren. Now cloneNode calls one of the 2 previous methods.
  • Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.
  • Moved cloneNode to the Element private section so that WebCore callers cannot use it.
  • Removed Element::cloneNode usage through WebCore.
  • dom/Element.cpp: (WebCore::Element::cloneNode): Moved to Element's private section and it now calls the two next methods. (WebCore::Element::cloneElementWithChildren): Added. (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement to avoid ambiguity.
  • dom/Element.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement to call to cloneElementWithoutChildren.
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Ditto.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Ditto.
  • editing/markup.cpp: (WebCore::createFragmentFromText): Ditto.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): Ditto. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
04:08 Changeset [41620] by krit@webkit.org

2009-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Fixed a crash on the 1x1 pixel check for background image in gtk.
We need to load the image first and need to be sure that the image
is not null before checking the type.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
01:46 Changeset [41619] by xan@webkit.org

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24544
Rename setUrl to setURL

Use proper case for setUrl method, rename it to setURL.

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt):
  • platform/network/ResourceResponseBase.h:
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):
00:58 Changeset [41618] by xan@webkit.org

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24519
[GTK] Use two argument KURL ctor in ResourceHandleSoup

Use two argument KURL ctor, the single argument ctor expects its
input to be the output of a previous KURL::parse call, which is
not the case here.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):
00:41 Changeset [41617] by jhoneycutt@apple.com

2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>

Fix for <rdar://6418681>
https://bugs.webkit.org/show_bug.cgi?id=22644

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA Client plug-in to the blacklist; it requires a Mozilla-based browser.
00:26 Changeset [41616] by oliver@apple.com

Build fix

03/11/09:

23:39 Changeset [41615] by oliver@apple.com

<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4

Reviewed by Adele Peterson.

A number of dashboard widgets rely on canvas failing silently when given invalid
colors for gradient stops, but both the spec and firefox throw exceptions here.
So we work around this by creating a dashboard quirk that will only suppress the
exception in dashboard compatibility mode.

Test: fast/canvas/canvas-gradient-addStop-error.html

23:02 Changeset [41614] by ddkilzer@apple.com

Remove duplicate header include

Rubber-stamped by Mark Rowe.

  • WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>. Also realphabetized lowercase #include statements.
22:14 Changeset [41613] by ddkilzer@apple.com

Clarify comments regarding order of FEATURE_DEFINES

Rubber-stamped by Mark Rowe.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebCore:

  • Configurations/WebCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKitTools:

  • Scripts/build-webkit: Added warning about keeping FEATURE_DEFINES in order and the consequences when they are not.
21:39 Changeset [41612] by mrowe@apple.com

Merge r41592.

21:37 Changeset [41611] by mrowe@apple.com

Merge r41576.

21:27 Changeset [41610] by kov@webkit.org

2009-03-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24515
[GTK] soup backend should use GMappedFile instead of mmap directly

Rewrite mmap code used to upload files to use GMappedFile, so that
it is platform-independent.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
21:06 Changeset [41609] by mrowe@apple.com

Versioning.

21:05 Changeset [41608] by mrowe@apple.com

New tag.

20:39 Changeset [41607] by mitz@apple.com

JavaScriptCore:

Reviewed by Darin Adler.

  • WTF support for fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns whether the character has Unicode line breaking property value SA ("Complex Context").
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an implementation that always returns false.

WebCore:

Reviewed by Darin Adler.

  • WebCore part of fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect

Test: platform/mac/editing/selection/word-thai.html

Tested on Mac, but should work on all ICU platforms (or more precisely
on all platforms that implement
WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).

  • editing/TextIterator.cpp: (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Added. (WebCore::BackwardsCharacterIterator::range): Added. (WebCore::BackwardsCharacterIterator::advance): Added.
  • editing/TextIterator.h: Added BackwardsCharacterIterator with the minimal functionality required for this patch. (WebCore::BackwardsCharacterIterator::atEnd): Added.
  • editing/visible_units.cpp: (WebCore::firstNonComplexContextLineBreak): Added this helper function that returns the index of the first character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or the length of the string if there is no such character. (WebCore::lastNonComplexContextLineBreak): Added this helper function that returns the index of the last character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or -1 if there is no such character. (WebCore::previousBoundary): Changed the signature of the search function to include an offset parameter. Renamed the 'exception' local variable to 'ec' and changed its type to ExceptionCode. Extend the string forwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the forward direction. Changed to use a BackwardsCharacterIterator for translating the backwards offset into a position. (WebCore::nextBoundary): Changed the signature of the search function to include an offset parameter. Extend the string backwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the backwards direction. Restricted the workaround for <rdar://5192593> only to the line break case, because it was causing an extra character to be selected following a word that ended with a combining mark. (WebCore::startWordBoundary): Added an offset parameter. Check that going backwards from the given offset, there is a character with Unicode line breaking property value other than SA, and otherwise return 0 to request more context. (WebCore::endWordBoundary): Similar, but in reverse. (WebCore::previousWordPositionBoundary): Similar. (WebCore::nextWordPositionBoundary): Similar. (WebCore::startSentenceBoundary): Updated for the new search function signature. (WebCore::endSentenceBoundary): Ditto. (WebCore::previousSentencePositionBoundary): Ditto. (WebCore::nextSentencePositionBoundary): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/3919124> Thai text selection in Safari is incorrect
  • platform/mac/editing/selection/word-thai-expected.txt: Added.
  • platform/mac/editing/selection/word-thai.html: Added.
18:29 Changeset [41606] by darin@apple.com

2009-03-11 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Don't use "::" in thread names because it is ugly!

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make it clear this is a WebCore-created thread.
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
18:26 Changeset [41605] by darin@apple.com

2009-03-11 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Give threads names on platforms with pthread_setname_np.

  • wtf/Threading.cpp: (WTF::NewThreadContext::NewThreadContext): Initialize thread name. (WTF::threadEntryPoint): Call setThreadNameInternal. (WTF::createThread): Pass thread name.
  • wtf/Threading.h: Added new comments, setThreadNameInternal.
  • wtf/ThreadingGtk.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingNone.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Call pthread_setname_np when available.
  • wtf/ThreadingQt.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Added. Empty.
17:53 Changeset [41604] by mrowe@apple.com

<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex

Rubber-stamped by Darin Adler.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenIsMonochrome): Return false.

17:51 Changeset [41603] by simon.fraser@apple.com

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24531

Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
returns a null style if it has a valid renderer, which could happen if a
CompositeAnimation existed, but wasn't running any animations or transitions.

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
16:25 Changeset [41602] by bdakin@apple.com

WebCore:

2009-03-11 Beth Dakin <bdakin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

  • and corresponding - <rdar://problem/6172925>
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

2009-03-11 Beth Dakin <bdakin@apple.com>

Reviewed by Dan Bernstein.

Test for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

  • and corresponding - <rdar://problem/6172925>
  • fast/css/percent-top-value-with-relative-position.html: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.checksum: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.png: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt: Added.
14:54 Changeset [41601] by levin@chromium.org

2009-03-11 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Implement ScriptValue::hasNoValue for V8.
https://bugs.webkit.org/show_bug.cgi?id=24507

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::hasNoValue):
14:54 Changeset [41600] by levin@chromium.org

2009-03-11 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 24459: Add v8 bindings for event.
<https://bugs.webkit.org/show_bug.cgi?id=24459>

Adding custom event bindings.

  • bindings/v8/custom/V8AbstractEventListener.cpp: Added.
  • bindings/v8/custom/V8AbstractEventListener.h: Added.
  • bindings/v8/custom/V8AttrCustom.cpp: Fixed messed up copyright header.
  • bindings/v8/custom/V8CustomEventListener.cpp: Added.
  • bindings/v8/custom/V8CustomEventListener.h: Replaced forwarding header with the real implementation.
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8LazyEventListener.cpp: Added.
  • bindings/v8/custom/V8LazyEventListener.h: Added.
  • bindings/v8/custom/V8ObjectEventListener.cpp: Added.
  • bindings/v8/custom/V8ObjectEventListener.h: Added.
  • bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
  • bindings/v8/custom/V8WorkerContextEventListener.h: Added.
14:40 Changeset [41599] by darin@chromium.org

2009-03-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24521
Add some missing includes for the non-JSC build.

  • platform/text/PlatformString.h: added OwnPtr.h
  • xml/XMLHttpRequest.cpp: added SecurityOrigin.h
14:17 Changeset [41598] by pam@chromium.org

2009-03-11 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
These files were accidentally left out of r41459.

https://bugs.webkit.org/show_bug.cgi?id=24339

  • fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
  • fast/dom/Window/window-collection-length-no-crash.html: Added.
13:58 Changeset [41597] by andersca@apple.com

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6656147>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Pass the requestID to _WKPHInstantiatePlugin.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: Pass the requestID to setCurrentReply.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::setCurrentReply): Store the reply in a map with the requestID as the key.


(WebKit::NetscapePluginInstanceProxy::waitForReply):
Wait for a reply that matches the given requestID.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize member variables.


(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Delete all requests.


(WebKit::NetscapePluginInstanceProxy::print):
Pass the requestID to _WKPHPluginInstancePrint.


(WebKit::NetscapePluginInstanceProxy::loadRequest):
Rename m_currentRequestID to m_currentURLRequestID.


(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Process requests until we find a reply with the right requestID.


(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Pass a requestID to the _WKPH function.


(WebKit::NetscapePluginInstanceProxy::nextRequestID):
Ditto.


  • Plugins/Hosted/ProxyInstance.mm: Pass a requestID to the _WKPH functions.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameters.
13:41 Changeset [41596] by simon.fraser@apple.com

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Fix Scons build. Patch from Alexander Guy.

  • WebCore.scons:
13:39 Changeset [41595] by aroben@apple.com

Export functions needed by ThreadSpecific from WebKit

Reviewed by John Sullivan.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Export WTF::tlsKeyCount and WTF::tlsKeys.
13:39 Changeset [41594] by aroben@apple.com

Change the Windows implementation of ThreadSpecific to use functions instead of extern globals

This will make it easier to export ThreadSpecific from WebKit.

Reviewed by John Sullivan.

  • API/JSBase.cpp: (JSEvaluateScript): Touched this file to force ThreadSpecific.h to be copied into $WebKitOutputDir.
  • wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount() and g_tls_keys with tlsKeys().

(WTF::::ThreadSpecific):
(WTF::::~ThreadSpecific):
(WTF::::get):
(WTF::::set):
(WTF::::destroy):
Updated to use the new functions.

  • wtf/ThreadSpecificWin.cpp: (WTF::tlsKeyCount): (WTF::tlsKeys): Added.

(WTF::ThreadSpecificThreadExit): Changed to use the new functions.

12:45 Changeset [41593] by simon.fraser@apple.com

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24366

Make this test more reliable by only calling runAnimationTest() once
the animation starts, not before some setTimeout().

  • animations/change-keyframes-name-expected.txt:
  • animations/change-keyframes-name.html:
12:09 Changeset [41592] by andersca@apple.com

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6620064>.


  • Plugins/WebPluginContainerPrivate.h:
12:04 Changeset [41591] by simon.fraser@apple.com

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24266

Land new expected results for transform-absolute-in-positioned-container.html,
and new pixel results for reflection-masks.html. Both are progressions.

  • platform/mac/fast/reflections/reflection-masks-expected.checksum:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
12:00 Changeset [41590] by simon.fraser@apple.com

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23093

When the cancel button in the search field is shown or hidden,
we need to explicitly setStyle() on the cancel button's renderer,
to ensure that repaint happens. Changing the style without telling
the renderer won't work.

Test: fast/repaint/search-field-cancel.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
  • rendering/RenderTextControlSingleLine.h:
10:58 Changeset [41589] by pam@chromium.org

2009-03-11 Marc-André Decoste <mad@chromium.org>

Reviewed by Eric Seidel.

Fixed the positions of the list boxes so that the size of their
rendering doesn't affect the test coordinates.
https://bugs.webkit.org/show_bug.cgi?id=24006

  • fast/forms/option-mouseevents-expected.txt:
  • fast/forms/option-mouseevents.html:
09:05 Changeset [41588] by ap@webkit.org

2009-03-11 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=15790
Ligatures aren't accounted for when manipulating VisiblePositions

Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
Indic ligature which uses a virama sign.


Test: editing/deleting/skip-virama-001.html

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
08:46 Changeset [41587] by ap@webkit.org

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24513
REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)

Fixes existing tests on Tiger.

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Use characterBreakIterator on Tiger (like we used to do).
07:53 Changeset [41586] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Only run code in dispose once per instance.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
07:53 Changeset [41585] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Call deref() on our internal HistoryItem on dispose, as we always
acquire it with a releaseRef() call to a PassRefPtr, which passes
ownership.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
07:52 Changeset [41584] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

return foo? foo : NULL == return foo

  • webkit/webkitwebhistoryitem.cpp: (WebKit::core):
05:27 Changeset [41583] by jmalonzo@webkit.org

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Enable http/tests/security/cross-frame-access-private-browsing.html test.

  • platform/gtk/Skipped:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Add private browsing option "enable-private-browsing" to WebKitWebSettings.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Also reset WebSettings to its default state for JavaScript
profiling, Developer Extras and Private Browsing before running
the test (can be after each test but we want to be consistent with
other ports in this regard)

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPrivateBrowsingEnabled):
05:06 Changeset [41582] by jmalonzo@webkit.org

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] BackForward history leak?
https://bugs.webkit.org/show_bug.cgi?id=19528

Don't ref the history items when returning the back/forward list
Added test_webkit_web_history_item_lifetime test case for this.

  • tests/main.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): Style fix. (test_webkit_web_back_forward_list_add_item): Style fix. (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
04:58 Changeset [41581] by ap@webkit.org

Reviewed by Oliver Hunt.

<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name in instancesRespondToSelector.
04:57 Changeset [41580] by jmalonzo@webkit.org

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Fix make clean targets
https://bugs.webkit.org/show_bug.cgi?id=24450

Fix 'make' clean targets. We shouldn't be removing DerivedSources
if it's only clean. Only remove it if it's distclean or
maintainer-clean. Also remove build-related auxillary files on
dist/maintainer clean.

  • GNUmakefile.am:
04:52 Changeset [41579] by jmalonzo@webkit.org

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

pangoft2 is also used in directfb builds so use it for all targets

  • configure.ac:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add missing stdio.h include to get the build going

  • plugins/gtk/PluginPackageGtk.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add plugin support only for X11 builds

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
  • GNUmakefile.am:

03/10/09:

23:46 Changeset [41578] by justin.garcia@apple.com

2009-03-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by Ken Kocienda.

  • dom/Range.cpp: (WebCore::Range::addLineBoxRects): If the range ended at [div, 0], addLineBoxRects would include rects for the divs contents. Set the correct RenderObject to stop at.
23:28 Changeset [41577] by ap@webkit.org

Reviewed by Sam Weinig.

<rdar://problem/6123770> Restrict access to document.cookie when making a cross-site XHR

WebCore:

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Removed an incorrect comment about cookie support. Firefox doesn't expose cookies on responseXML at all, and there are security concerns with exposing them for cross-origin requests, so it's not clear if we want to change anything here.

LayoutTests:

  • http/tests/security/cookies/xmlhttprequest.html: We don't expose cookies for documents retrieved via XMLHttpRequest. Added a check to make sure that we don't forget about cross- origin restrictions if we ever decide to change that.
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi: While at it, fixed a broken check for Set-Cookie2.
22:43 Changeset [41576] by simon.fraser@apple.com

2009-03-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24503

Fix hit testing of absolutely positioned single line text controls by
ensuring that we set result.innerNode() correctly. If the hit node is
a descendant of the inner text element or if it is the <input> itself,
then we say we hit the innerTextElement.

Rename hitInnerTextBlock() to hitInnerTextElement() to match the
'innerTextElement' terminology used elsewhere.

Assert that if renderer()->hitTest() returns false, no-one set
result.innerNode().

Test: fast/forms/search-abs-pos-cancel-button.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
21:03 Changeset [41575] by mrowe@apple.com

Versioning.

21:01 Changeset [41574] by mrowe@apple.com

New tag.

19:20 Changeset [41573] by antti@apple.com

2009-03-10 Antti Koivisto <antti@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.


Another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::isNonByteBasedEncoding):
17:19 Changeset [41572] by mrowe@apple.com

Merge r41190.

17:19 Changeset [41571] by mrowe@apple.com

Merge r41232.

17:08 Changeset [41570] by justin.garcia@apple.com

Fix build.

17:05 Changeset [41569] by bdakin@apple.com

WebCore:

2009-03-10 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No
scroll bar appears for long line of text with NOWRAP set

This is a regression from http://trac.webkit.org/changeset/32226
I talked with Dan about the original change, and we decided that
the best fix was to remove his small potential-optimization that
only created a separate line box for whitespace under certain
circumstances. This new code will always create a separate line
box.

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

2009-03-10 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB):
No scroll bar appears for long line of text with NOWRAP set

New test:

  • fast/inline/long-wrapped-line.html: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.


These tests all have changed results from the patch. Now trailing
whitespace always has its own linebox instead of sometimes sharing
a linebox with text.

  • platform/mac/editing/deleting/5206311-1-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-to-select-table-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/execCommand/5482023-expected.txt:
  • platform/mac/editing/execCommand/boldSelection-expected.txt:
  • platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
  • platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • platform/mac/editing/execCommand/print-expected.txt:
  • platform/mac/editing/execCommand/selectAll-expected.txt:
  • platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
  • platform/mac/editing/input/emacs-ctrl-o-expected.txt:
  • platform/mac/editing/inserting/12882-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-div-020-expected.txt:
  • platform/mac/editing/inserting/insert-div-021-expected.txt:
  • platform/mac/editing/inserting/insert-div-022-expected.txt:
  • platform/mac/editing/inserting/insert-div-023-expected.txt:
  • platform/mac/editing/inserting/insert-div-024-expected.txt:
  • platform/mac/editing/inserting/insert-div-025-expected.txt:
  • platform/mac/editing/inserting/insert-div-027-expected.txt:
  • platform/mac/editing/inserting/typing-003-expected.txt:
  • platform/mac/editing/pasteboard/4989774-expected.txt:
  • platform/mac/editing/pasteboard/5028447-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-3-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-012-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-013-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-014-expected.txt:
  • platform/mac/editing/selection/4947387-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5081257-1-expected.txt:
  • platform/mac/editing/selection/5081257-2-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/5234383-1-expected.txt:
  • platform/mac/editing/selection/5234383-2-expected.txt:
  • platform/mac/editing/selection/7152-1-expected.txt:
  • platform/mac/editing/selection/7152-2-expected.txt:
  • platform/mac/editing/selection/after-line-wrap-expected.txt:
  • platform/mac/editing/selection/click-start-of-line-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/editable-html-element-expected.txt:
  • platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
  • platform/mac/editing/selection/end-of-document-expected.txt:
  • platform/mac/editing/selection/extend-by-character-003-expected.txt:
  • platform/mac/editing/selection/extend-by-character-005-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/editing/selection/mixed-editability-1-expected.txt:
  • platform/mac/editing/selection/move-by-character-003-expected.txt:
  • platform/mac/editing/selection/move-by-character-005-expected.txt:
  • platform/mac/editing/selection/select-all-001-expected.txt:
  • platform/mac/editing/selection/select-all-002-expected.txt:
  • platform/mac/editing/selection/select-all-003-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/mac/editing/style/apple-style-editable-mix-expected.txt:
  • platform/mac/editing/style/create-block-for-style-001-expected.txt:
  • platform/mac/editing/style/create-block-for-style-002-expected.txt:
  • platform/mac/editing/style/create-block-for-style-003-expected.txt:
  • platform/mac/editing/style/create-block-for-style-004-expected.txt:
  • platform/mac/editing/style/create-block-for-style-005-expected.txt:
  • platform/mac/editing/style/create-block-for-style-006-expected.txt:
  • platform/mac/editing/style/create-block-for-style-007-expected.txt:
  • platform/mac/editing/style/create-block-for-style-008-expected.txt:
  • platform/mac/editing/style/create-block-for-style-009-expected.txt:
  • platform/mac/editing/style/create-block-for-style-010-expected.txt:
  • platform/mac/editing/style/create-block-for-style-011-expected.txt:
  • platform/mac/editing/style/create-block-for-style-012-expected.txt:
  • platform/mac/editing/style/create-block-for-style-013-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-001-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-002-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-003-expected.txt:
  • platform/mac/editing/style/relative-font-size-change-004-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
  • platform/mac/fast/clip/outline-overflowClip-expected.txt:
  • platform/mac/fast/forms/negativeLineHeight-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-rows-cols-expected.txt:
  • platform/mac/fast/lists/drag-into-marker-expected.txt:
  • platform/mac/fast/parser/comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
  • platform/mac/fast/repaint/selection-after-delete-expected.txt:
  • platform/mac/fast/repaint/selection-after-remove-expected.txt:
  • platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
  • platform/mac/fast/text/trailing-white-space-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
  • platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
  • platform/mac/http/tests/navigation/anchor-goback-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
  • platform/mac/http/tests/navigation/post-goback2-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
  • platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
  • platform/mac/http/tests/navigation/success200-goback-expected.txt:
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
16:57 Changeset [41568] by weinig@apple.com

2009-03-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6166844>
https://bugs.webkit.org/show_bug.cgi?id=24495

Use same rule for loading java applets as we do for images.

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
16:23 Changeset [41567] by justin.garcia@apple.com

Fix the build.

15:59 Changeset [41566] by justin.garcia@apple.com

2009-03-10 Justin Garcia <justin.garcia@apple.com>

Reviewed by David Kilzer.

Get rid of revealCaret and use revealSelection instead.

  • WebCore.base.exp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
  • page/Frame.cpp: (WebCore::Frame::revealSelection):
  • page/Frame.h:
15:48 Changeset [41565] by cwzwarich@webkit.org

2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 24291: REGRESSION (r38635): Single line JavaScript comment prevents HTML button click handler execution
<https://bugs.webkit.org/show_bug.cgi?id=24291>
<rdar://problem/6663472>

Add an extra newline to the end of the body of the program text constructed
by the Function constructor for parsing. This allows single line comments to
be handled correctly by the parser.

JavaScriptCore:

  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):

LayoutTests:

  • fast/events/onload-single-line-comment-expected.txt: Added.
  • fast/events/onload-single-line-comment.html: Added.
  • fast/js/function-constructor-single-line-comment-expected.txt: Added.
  • fast/js/function-constructor-single-line-comment.html: Added.
  • fast/js/resources/function-constructor-single-line-comment.js: Added.
14:46 Changeset [41564] by sfalken@apple.com

<rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults


Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.


This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
saying there was browsing history for a particular day, and then return no history items when we requested a
list of sites visited that day.


Reviewed by Ada Chan.

  • MarshallingHelpers.cpp: (MarshallingHelpers::DATEToCFAbsoluteTime): (MarshallingHelpers::CFAbsoluteTimeToDATE):
12:49 Changeset [41563] by cwzwarich@webkit.org

2009-03-10 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23736: WebKit Crashes on http://g-conquest.fr/~server2
<https://bugs.webkit.org/show_bug.cgi?id=23736>
<rdar://problem/6560278>

Before replacing the document, FrameLoader::executeIfJavaScriptURL()
should call stopAllLoaders(), just like continueLoadAfterNavigationPolicy().

WebCore:

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::executeIfJavaScriptURL):

LayoutTests:

  • http/tests/misc/javascript-url-stop-loaders-expected.txt: Added.
  • http/tests/misc/javascript-url-stop-loaders.html: Added.
12:31 Changeset [41562] by darin@apple.com

WebCore:

2009-03-10 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

Test: editing/deleting/merge-at-end-of-document.html

  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints): Split out assertion. It's better not to use && in assertions since we'd like to know which condition is failing.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Added a null check before calling compareBoundaryPoints, since a 0 for the node is ambiguous and so the function doesn't know which value to return.

LayoutTests:

2009-03-10 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Bug 24494: crash when deleting at end of document and merging paragraphs
https://bugs.webkit.org/show_bug.cgi?id=24494
rdar://problem/6571537

  • editing/deleting/merge-at-end-of-document-expected.txt: Added.
  • editing/deleting/merge-at-end-of-document.html: Added.
11:46 Changeset [41561] by krit@webkit.org

2009-03-10 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel. Math checked by Oliver Hunt.

Implement the Cairo version of the checkForSolidColor() method. This halfes the
time to draw on 1x1 px background images.
I added two new calls to Color for the pixel manipulation on cairo_surface's.
They are neede to premultiply/unpremultiply the colors of the surface.

[CAIRO] Introduce single-pixel image optimizations
https://bugs.webkit.org/show_bug.cgi?id=17284

  • platform/graphics/Color.cpp: (WebCore::colorFromPremultipliedARGB): (WebCore::premultipliedARGBFromColor):
  • platform/graphics/Color.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
11:38 Changeset [41560] by treat@webkit.org

2009-03-10 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt after r41555.

  • Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
11:22 Changeset [41559] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use g_hash_table_new_full so we can save the manual unref on the
values when removing them from the table.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
10:34 Changeset [41558] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
guidelines.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_history_item_remove): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
10:00 Changeset [41557] by xan@webkit.org

WebKit/mac:

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review.

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):

WebKit/qt:

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review.

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
09:38 Changeset [41556] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Correct return value to false instead of NULL.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
09:23 Changeset [41555] by darin@chromium.org

2009-03-06 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24437

Add support for registering noAccess URL schemes:
1- Add FrameLoader::registerURLSchemeAsNoAccess, and have SecurityOrigin check
that list upon construction (similar to how isLocal is implemented).
2- Make InspectorController call grantUniversalAccess on its Document's
SecurityOrigin at the time when windowScriptObjectAvailable is called.

This enables content such as the inspector to be loaded from a custom (non-file)
URL, which is how Chromium loads the inspector. It also allows other URL schemes
to be treated like data: URLs, which Chromium utilizes for its various HTML-based
UI panels.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable):
  • loader/FrameLoader.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal):
09:19 Changeset [41554] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Build fix, no review

  • page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):
09:10 Changeset [41553] by xan@webkit.org

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24491
Rename posOffset to m_offset, get rid of accessor

As suggested in dom/Position.h, this patch gets rid of the
'offset()' accessor and renames posOffset to m_offset. I've used
m_offset instead of offset to follow the style guide lines, since
Position is still a class and not a structure. If the long term
plan is still to make it a structure it would be pretty easy to
just s/m_offset/offset/ globally when that is achieved.

  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atStart): (WebCore::Position::atEnd): (WebCore::Position::renderedOffset): (WebCore::Position::isCandidate): (WebCore::Position::inRenderedText): (WebCore::Position::isRenderedCharacter): (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
  • dom/Position.h: (WebCore::Position::Position):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
  • dom/Range.cpp:
  • dom/RangeBoundaryPoint.h: (WebCore::RangeBoundaryPoint::position): (WebCore::RangeBoundaryPoint::set): (WebCore::RangeBoundaryPoint::setOffset): (WebCore::RangeBoundaryPoint::setToChild): (WebCore::RangeBoundaryPoint::setToStart): (WebCore::RangeBoundaryPoint::setToEnd): (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::removePlaceholderAt): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
  • editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
07:46 Changeset [41552] by darin@apple.com

WebCore:

2009-03-10 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

Test: fast/dom/HTMLElement/innerHTML-selection-crash.html

  • editing/markup.cpp: (WebCore::createMarkup): Added updateLayoutIgnorePendingStylesheets call to the one of the two overloads of this function that wasn't calling it. This fixes this crash and other possible crashes inside innerHTML.

LayoutTests:

2009-03-10 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 23564: REGRESSION (r39230-39286): crash loading page that changes <input> display type and then calls innerHTML
https://bugs.webkit.org/show_bug.cgi?id=23564
rdar://problem/6537238

  • fast/dom/HTMLElement/innerHTML-selection-crash-expected.txt: Added.
  • fast/dom/HTMLElement/innerHTML-selection-crash.html: Added.
07:10 Changeset [41551] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24285
Text resource loading checks for BOM twice

This removes TextDecoder class, since its only purpose was to check for BOM, which is
already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
BOM checked, but I didn't find any cases where it would significantly change behavior.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Remove TextDecoder.{h,cpp}.
  • platform/text/TextDecoder.cpp: Removed.
  • platform/text/TextDecoder.h: Removed.
  • loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and TextCodec separately.
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member. (WebCore::TextResourceDecoder::setEncoding): Ditto. (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override even a user-chosen encoding - this is how it already worked due to TextDecoder checking for BOM again. Made this function return the detected BOM length. (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of a text resource. (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode): Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer checks for BOM, which was a counter-intuitive feature.
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setEncoding): (WebCore::CachedScript::encoding): (WebCore::CachedScript::script):
  • loader/CachedScript.h:
  • loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM. A side effect of this is that these resources will now be subject to encoding auto-detection.
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • page/Page.cpp: (WebCore::Page::userStyleSheet): Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder re-usable (for repeated decoding of the same resource).
  • platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
05:58 Changeset [41550] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24488
An assertion failure when updating an offline application cache after emptying caches

Emptying appcache cannot be performed automatically, so no test.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Ensure that the cache is in disk storage, even if the application wasn't updated server side.
02:44 Changeset [41549] by oliver@apple.com

<rdar://problem/6425807> Implement WorkerUtils.importScripts()
<https://bugs.webkit.org/show_bug.cgi?id=22721>

Reviewed by Alexey Proskuryakov

Implement importScripts, currently uses a series of synchronous loads
to fetch the scripts, but this is simpler than a synchronous load of
multiple loads in parallel. In future we'll want to switch to parallel
loading, but this will do for now.

Test: http/tests/workers/worker-importScripts.html

01:11 Changeset [41548] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24462
Move cross-origin access control code out of XMLHttpRequest

Step 1: move preflight result cache and access control helper functions.

No change in behavior, so no test.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/CrossOriginAccessControl.cpp: Added. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::isSimpleCrossOriginAccessRequest): (WebCore::createAllowedCrossOriginResponseHeadersSet): (WebCore::isOnAccessControlResponseHeaderWhitelist): (WebCore::passesAccessControlCheck):
  • loader/CrossOriginAccessControl.h: Added.
  • loader/CrossOriginPreflightResultCache.cpp: Added. (WebCore::parseAccessControlMaxAge): (WebCore::addToAccessControlAllowList): (WebCore::parseAccessControlAllowList): (WebCore::CrossOriginPreflightResultCacheItem::parse): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest): (WebCore::CrossOriginPreflightResultCache::shared): (WebCore::CrossOriginPreflightResultCache::appendEntry): (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
  • loader/CrossOriginPreflightResultCache.h: Added. (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem): (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
  • xml/XMLHttpRequest.h:
00:46 Changeset [41547] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19797
Bring the list of forbidden headers in sync with XMLHttpRequest spec draft

Added new checks to http/tests/xmlhttprequest/set-dangerous-headers.html.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Added all headers from XMLHttpRequest 2 draft.
00:03 Changeset [41546] by mitz@apple.com

Reviewed by Adele Peterson.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect): Corrected the vertical scrollbar rect calculation.

03/09/09:

22:50 Changeset [41545] by simon.fraser@apple.com

2009-03-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein, Oliver Hunt

https://bugs.webkit.org/show_bug.cgi?id=24475

When repainting replaced elements, need to union the selection
and overflow rects because either may extend outside the other.

Test: fast/repaint/transform-replaced-shadows.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
18:09 Changeset [41544] by oliver@apple.com

Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>

Reviewed by Gavin Barraclough

r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets. This causes problems when condition loads occur in an

expression -- namely through the ?: and
operators. This patch corrects these issues

by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.

I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug. That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.

17:38 Changeset [41543] by slewis@apple.com

2009-03-09 Stephanie Lewis <slewis@apple.com>

Fix build.

  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::markAllMisspellingsAndBadGrammarInRanges):
17:22 Changeset [41542] by darin@chromium.org

2009-03-09 Kim Christensen <kimworking@gmail.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24276
Dropdown / select boxes do not consider the windows task bar in Chromium.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup):
15:49 Changeset [41541] by kov@webkit.org

Tagging WebKitGTK+'s 1.1.1 release.

15:40 Changeset [41540] by kov@webkit.org

Creating a place to tag WebKitGTK+ releases.

15:34 Changeset [41539] by weinig@apple.com

2009-03-09 Sam Weinig <sam@webkit.org>

Roll out r41393. It has been causing failures on the bots for about a week.

  • fast/block/float/resources/se_arrow.png: Removed.
  • fast/block/float/resources/yinyang.png: Removed.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
15:20 Changeset [41538] by mitz@apple.com

WebCore:

Reviewed by Adele Peterson and Dave Hyatt.

  • fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields

Test: fast/forms/legend-display-none.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display property of legend elements to 'block' unless it is 'none'.
  • css/html4.css: Do not force the display property of legend elements to 'block' using CSS, because that prevents style rules from setting it to 'none'.

LayoutTests:

Reviewed by Adele Peterson and Dave Hyatt.

  • test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields
  • fast/forms/legend-display-none-expected.txt: Added.
  • fast/forms/legend-display-none.html: Added.
14:01 Changeset [41537] by levin@chromium.org

WebCore:

2009-03-09 Alpha Lam <hclam@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23024

Fix an incorrect criteria in the if statement that leaves references to
deleted floating objects in RenderBlock.

Test: fast/block/float/crash-on-absolute-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

2009-03-09 Alpha Lam <hclam@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23024

Added regression test for a bug that causes crashes.

  • fast/block/float/crash-on-absolute-positioning.html: Added.
  • platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.
14:01 Changeset [41536] by levin@chromium.org

2009-03-09 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 23175: String and UString should be able to share a UChar* buffer.
<https://bugs.webkit.org/show_bug.cgi?id=23175>

Add CrossThreadRefCounted.

  • wtf/CrossThreadRefCounted.h: Added. (WTF::CrossThreadRefCounted::create): (WTF::CrossThreadRefCounted::isShared): (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe): (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread): (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::CrossThreadRefCounted::~CrossThreadRefCounted): (WTF::CrossThreadRefCounted::ref): (WTF::CrossThreadRefCounted::deref): (WTF::CrossThreadRefCounted::release): (WTF::CrossThreadRefCounted::copy): (WTF::CrossThreadRefCounted::threadSafeDeref):
  • wtf/RefCounted.h:
  • wtf/Threading.h: (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase): (WTF::ThreadSafeSharedBase::derefBase): (WTF::ThreadSafeShared::ThreadSafeShared): (WTF::ThreadSafeShared::deref):
12:48 Changeset [41535] by eric@webkit.org

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 idl file.
https://bugs.webkit.org/show_bug.cgi?id=24424

  • page/Location.idl:
12:48 Changeset [41534] by eric@webkit.org

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 for History.idl.

  • page/History.idl:
12:48 Changeset [41533] by eric@webkit.org

2009-03-09 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Unify JSC/V8 implementations of DOMWindow.idl.

  • page/DOMWindow.idl:
11:39 Changeset [41532] by andersca@apple.com

2009-03-09 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

WebKit side of <rdar://problem/6530007>


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEnumerate): Call NetscapePluginInstanceProxy::enumerate.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): Enumerate the JS object and serialize its values.


  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): Ask the plug-in host to get the property names and deserialize them.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
11:06 Changeset [41531] by simon.fraser@apple.com

2009-03-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24163

Implement mapping of FloatQuads through 3D transforms.

Removed the redundant localToContainerQuad() methods, which can now
shared code with the old mapLocalToAbsolutePoint(), which was
renamed to mapLocalToContainer(). This can now convert a point,
and optionally a FloatQuad, which are carried along in the TransformState.

Optimized TransformState to reduce to simple FloatPoint.move()
if there are no transforms, and to heap-allocate a transform only if
necessary to accumulate transforms (when using preserve-3d).

Tested by 3d point mapping tests, and the inspector highlight (which now shows
the correct quads for 3d-transformed elements).

10:01 Changeset [41530] by simon.fraser@apple.com

2009-03-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24433

During hit testing with transforms, if a layer has backface-visibility: hidden,
we need to check for it whether or not the layer has a transform, because it
might be an ancestor that is transformed.

Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
09:53 Changeset [41529] by simon.fraser@apple.com

2009-03-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt and Cameron Zwarich

https://bugs.webkit.org/show_bug.cgi?id=24440

The sublayer added to WebHTMLView to host accelerated compositing layers needs to
be a subclass of NSView which allows context menu clicks through.

  • WebView/WebHTMLView.mm: (-[WebLayerHostingView rightMouseDown:]): (-[WebHTMLView attachRootLayer:]):
09:37 Changeset [41528] by treat@webkit.org

2009-03-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24353
Allow to overrule default build options for Qt build.

  • WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
  • JavaScriptCore.pri: Allow to overrule ENABLE_JIT
09:32 Changeset [41527] by treat@webkit.org

2009-03-09 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24463
WebCore::qstring is detaching and copying twice for every single
WebCore::TextRun that is processed and drawn. This elevates this method
to one of the top-ten most expensive methods in all of QtWebKit according
to profiling. This changes the method so that QString only detaches
when absolutely necessary.

  • platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
Note: See TracTimeline for information about the timeline view.