Timeline


and

03/15/09:

19:04 Changeset [41730] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6668875> Normalize Geolocation results

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
18:02 Changeset [41729] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

Update ::toString format as suggested by Darin Adler.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
17:31 Changeset [41728] by simon.fraser@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-03-15 Simon Fraser <simon.fraser@apple.com>

Revert r41718 because it broke DumpRenderTree on Tiger.

  • JavaScriptCorePrefix.h:
  • wtf/Platform.h:
16:55 Changeset [41727] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Reviewed by Darin Adler.

Yet another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encodingForFormSubmission):
16:41 Changeset [41726] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Simon Fraser <simon.fraser@apple.com>

Build fix: no review.

  • rendering/style/ContentData.h:
16:32 Changeset [41725] by ddkilzer@apple.com
  • 9 edits in trunk/WebCore

Bug 24542: Improve ContentData encapsulation

<https://bugs.webkit.org/show_bug.cgi?id=24542>

Reviewed by Simon Fraser.

No tests since there is no change in behavior.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Used getter methods instead of data members on ContentData class. Used isImage() convenience method.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Extracted code into deleteContent() method. (WebCore::ContentData::dataEquivalent): Added. Extracted code from StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::ContentData::deleteContent): Added. Used by setter methods.
  • rendering/style/ContentData.h: Made m_type, m_content and m_next private. (WebCore::ContentData::isCounter): Added. (WebCore::ContentData::isImage): Added. (WebCore::ContentData::isNone): Added. (WebCore::ContentData::isText): Added. (WebCore::ContentData::type): Added. (WebCore::ContentData::dataEquivalent): Added. (WebCore::ContentData::image): Added. (WebCore::ContentData::setImage): Added. (WebCore::ContentData::text): Added. (WebCore::ContentData::setText): Added. (WebCore::ContentData::counter): Added. (WebCore::ContentData::setCounter): Added. (WebCore::ContentData::next): Added. (WebCore::ContentData::setNext): Added.
  • rendering/style/CounterContent.h: (WebCore::operator!=): Removed. (WebCore::operator==): Renamed operator!=() and reversed its logic after extracting code from StyleRareNonInheritedData::contentDataEquivalent() to create ContentData::dataEquivalent().
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Used new getters and setters on ContentData class. Changed first argument from a StringImpl* to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::setContent): Updated declaration.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Extracted most logic in while() loop into ContentData::dataEquivalent().
15:39 Changeset [41724] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.3

Tagging 1.1.3.

15:26 Changeset [41723] by xan@webkit.org
  • 2 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version to 1.1.3 for release and fix soversion
calculation (oops). Thanks to Frederik Himpe for pointing this
out.

  • configure.ac:
13:15 Changeset [41722] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-15 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Mark Rowe.

  • config.ini: fix my blog's feed address.
11:51 Changeset [41721] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.2

Tagging 1.1.2.

10:40 Changeset [41720] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-15 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Anders Carlsson.

Fix default policy decision to be ignore, on MIME checks, if
WebKit doesn't know how to handle the MIME type. The documentation
is already correct, and this was an oversight when the policy
decision code was first committed. Since 1.1.2 will be the first
release to support download, there is no practical change in
behavior.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
10:40 Changeset [41719] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-15 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:23 Changeset [41718] by kevino@webkit.org
  • 3 edits in trunk/JavaScriptCore

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

08:30 Changeset [41717] by xan@webkit.org
  • 4 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version and libtool version for release.

  • configure.ac:

WebKit/gtk:

2009-03-15 Xan Lopez <xlopez@igalia.com>

  • NEWS: update for 1.1.2.
04:26 Changeset [41716] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/editing/selection/5354455-2.html

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

02:22 Changeset [41715] by ap@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19737
No cursor and paste not enabled right clicking text field/area

Test: fast/events/right-click-focus.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
01:56 Changeset [41714] by ap@webkit.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Suggested by Mark Rowe.

Move results for security/block-test.html to their correct locations. Results for other
platforms will need to be generated.

  • platform/mac-leopard/security/block-test-expected.txt: Removed.
  • platform/mac-tiger/security: Added.
  • platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
  • platform/mac/security: Added.
  • platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
  • security/block-test-expected.txt: Removed.
01:42 Changeset [41713] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=23949
HTMLSelectElement is in inconsistent state when handling mutation events

Test: fast/forms/mutation-event-recalc.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::appendChild): Call childrenChanged() before dispatching modification events, not after.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::insertBefore): (WebCore::HTMLSelectElement::replaceChild): (WebCore::HTMLSelectElement::removeChild): (WebCore::HTMLSelectElement::appendChild): (WebCore::HTMLSelectElement::removeChildren): Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events were already dispatched.
01:23 Changeset [41712] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adele Peterson.

  • fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately

Made WebHTMLView validate user interface items with the selector
-makeBaseWritingDirectionNatural: by returning NO and, if the item is
a menu item, setting its state to "off".

Strictly speaking, since -makeBaseWritingDirectionNatural: is never
valid for WebViews, WebHTMLView should not need to respond to it and
validate it, however because other responders respond to all three
-makeBaseWritingDirection*: messages and set the menu item state, having
WebHTMLView do the same makes application developers' lives easier.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]):
01:16 Changeset [41711] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Add svn:executable property to recently added cgi scripts.

  • http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

03/14/09:

20:23 Changeset [41710] by mrowe@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

  • platform/mac-snowleopard/Skipped: Added.
19:55 Changeset [41709] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <bolsinga@apple.com>

<rdar://problem/6683465>

Geolocation has to be able to handle NULL Frames.

Reviewed by Mark Rowe

18:58 Changeset [41708] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

Geoposition::toString was missing the Coordinates after the update.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
16:44 Changeset [41707] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[Gtk] Build fix - pass a Coordinate to Geoposition::create
https://bugs.webkit.org/show_bug.cgi?id=24603

Gtk build fix per r41650
https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position

Pass a Coordinate to Geoposition::create.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
16:14 Changeset [41706] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] use of confirm dialog (yes/no) causes segfault
https://bugs.webkit.org/show_bug.cgi?id=20940

Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
OBJECT,STRING,POINTER

  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
15:02 Changeset [41705] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Remove two now working tests from GTK's Skipped list.

  • platform/gtk/Skipped:
13:22 Changeset [41704] by xan@webkit.org
  • 2 edits in trunk

2009-03-14 Xan Lopez <xlopez@igalia.com>

No review, build fix.

Split clean rules to make distcheck pass.

  • GNUmakefile.am:
05:50 Changeset [41703] by mrowe@apple.com
  • 21 edits
    20 copies
    7 adds in trunk/LayoutTests

Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

  • fast/dom/getElementsByClassName/011-expected.txt:
  • fast/parser/external-entities-expected.txt:
  • platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
  • platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
  • platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
  • platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
  • platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
  • platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
  • platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
  • platform/mac/fast/invalid/missing-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.checksum:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.checksum:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.checksum:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/hixie/error/012-expected.txt:
05:19 Changeset [41702] by mrowe@apple.com
  • 8 edits
    25 copies
    8 moves
    5 adds
    1 delete in trunk

Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory. The
results for older versions of Mac OS X are structured as a series of overlays. When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

  • Scripts/run-webkit-tests:
05:02 Changeset [41701] by ap@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24545
Make cross-site XHR simple request definition match current spec draft

Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language. (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those that could be sent via form submission.
04:56 Changeset [41700] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=15172
object fallback - empty string for first argument of setAttributeNS does not work like null

https://bugs.webkit.org/show_bug.cgi?id=24548
createElementNS("", name) should create an element in null namespace

Tests: fast/dom/createElementNS-empty-namespace.html

fast/dom/setAttributeNS-empty-namespace.html

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Convert empty namespaces to null.
04:54 Changeset [41699] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24591
Add my blog to Planet WebKit

Add my blog to the planet.

  • config.ini:

03/13/09:

23:17 Changeset [41698] by mrowe@apple.com
  • 10 edits in trunk

Take advantage of the ability of recent versions of Xcode to easily switch the active
architecture.

Rubber-stamped by Dan Bernstein.

  • Configurations/DebugRelease.xcconfig:
23:17 Changeset [41697] by mrowe@apple.com
  • 4 edits in trunk

Remove rarely used Makefile targets from the Makefile.

There are many situations in which the targets don't work as expected,
and their primary use is addressed by having the build system default
to building the appropriate architecture.

23:17 Changeset [41696] by mrowe@apple.com
  • 8 edits in trunk/WebKitTools

Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.

Reviewed by Timothy Hatcher.

The scripts will automatically target 64-bit if the system and hardware support it. This can be
overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
to make the override persistent.

  • Scripts/build-webkit: Remove architecture-related code.
  • Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
  • Scripts/run-javascriptcore-tests: Remove architecture-related code.
  • Scripts/run-safari: Ditto.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments. The --32-bit argument will set the

architecture preference to the 32-bit architecture of the machine. The --64-bit argument will remove any architecture
override that is in effect so that 64-bit support will be automatically detected.

  • Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the

auto-detection.

23:17 Changeset [41695] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Prevent AllInOneFile.cpp and ProfileGenerator.cpp from rebuilding unnecessarily when
switching between building in Xcode and via build-webkit.

Reviewed by David Kilzer.

build-webkit passes FEATURE_DEFINES to xcodebuild, resulting in it being present in the
Derived Sources build settings. When building in Xcode, this setting isn't present so
Xcode reruns the script build phases. This results in a new version of TracingDtrace.h
being generated, and the files that include it being rebuilt.

  • JavaScriptCore.xcodeproj/project.pbxproj: Don't regenerate TracingDtrace.h if it is

already newer than the input file.

17:53 Changeset [41694] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 John Abd-El-Malek <jam@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24593
Added requestorID so we can track the request to its WebView without using frame (which was removed).

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::requestorID): (WebCore::ResourceRequest::setRequestorID): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::policyURL): (WebCore::ResourceRequest::setPolicyURL): (WebCore::ResourceRequest::requestorPid): (WebCore::ResourceRequest::setRequestorPid):
16:07 Changeset [41693] by dglazkov@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24561
Add custom V8 bindings for HTMLElementCanvas, Location.

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: Added.
  • bindings/v8/custom/V8LocationCustom.cpp: Added.
15:47 Changeset [41692] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-03-13 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24584

Fix transparent text rendering on Chromium. FontChromiumWin
was calling beginTransparencyLayer()/endTransparencyLayer(), with
a TransparencyWin inside to do GDI ClearType rendering over an
opaque background. TransparencyWin does its special sauce
in the destructor, but it was being called too late to be used
correctly in the layer. Put the special sauce into a new function,
composite(), and call that explicitly instead.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::~TransparencyWin): (WebCore::TransparencyWin::composite): (WebCore::TransparencyWin::init):
  • platform/graphics/chromium/TransparencyWin.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::):
15:46 Changeset [41691] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24562
Add custom implementation for getCSSCanvasContext to V8 bindings.

  • bindings/v8/custom/V8DocumentCustom.cpp: Added new method.
15:43 Changeset [41690] by eric@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2009-03-13 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Add tests for various types of textareas. Tests in both
quirks and standards modes. Although only the standards
modes tests fit in the pixel results.
https://bugs.webkit.org/show_bug.cgi?id=24370

  • fast/forms/basic-textareas.html: Added.
  • platform/mac/fast/forms/basic-textareas-expected.checksum: Added.
  • platform/mac/fast/forms/basic-textareas-expected.png: Added.
  • platform/mac/fast/forms/basic-textareas-expected.txt: Added.
15:42 Changeset [41689] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Mike Belshe <mike@belse.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior.

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): remove extra logic around question mark.
15:32 Changeset [41688] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker and Geoffrey Garen.

<rdar://problem/6590384>
REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting


When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call,
and thus calling -[WebView hostWindow] will crash since _private is nil.


  • WebView/WebView.mm: (-[WebView hostWindow]):
15:20 Changeset [41687] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

Bug 24474: AX: in multi-body tables, asking for a cell at a specific coordinate can return nil
https://bugs.webkit.org/show_bug.cgi?id=24474

15:01 WebKit Team edited by ojan@chromium.org
(diff)
15:00 Changeset [41686] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24589
Upstream changes to V8 event listeners (Chromium r11133) in order to
fix worker functionality break in Chromium.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
14:53 WebKit Team edited by dglazkov@chromium.org
Ego-tuning. (diff)
14:52 Changeset [41685] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-03-13 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

Resolved name conflict with globally defined tzname in Symbian.
Replaced with different name instead of using namespace qualifier
(appeared to be less clumsy).

  • runtime/DateMath.cpp:
14:48 WebKit Team edited by pam@chromium.org
(diff)
14:45 WebKit Team edited by abarth@webkit.org
(diff)
14:31 Changeset [41684] by dglazkov@chromium.org
  • 11 edits
    5 copies
    1 add in trunk/WebCore

2009-03-13 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24524
Introduce ScriptObject and ScriptFunctionCall abstractions.

  • GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/ScriptFunctionCall.cpp: Added.
  • bindings/js/ScriptFunctionCall.h: Added.
  • bindings/js/ScriptObject.cpp: Added.
  • bindings/js/ScriptObject.h: Added.
  • bindings/js/ScriptObjectQuarantine.cpp: Added.
  • bindings/js/ScriptObjectQuarantine.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind. (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind. (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
  • inspector/InspectorController.h: Removed addScriptDatabaseResource and removeScriptDatabaseResource declarations.
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): Added. (WebCore::InspectorDatabaseResource::unbind): Added.
  • inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
14:26 Changeset [41683] by pkasting@chromium.org
  • 4 edits in trunk/WebCore

2009-03-13 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24467
Make Skia drawRect() and stroke behavior match CG.

This makes drawRect() ignore the stroke width (like CG does), and
adds a warning comment about that to the appropriate header.

It also eliminates some hacky code in Skia's stroke preparation,
which tried to adjust odd-width strokes to fall on pixel boundaries.
Not only did this not match CG, it wouldn't necessarily work right,
because there could be other transforms (e.g. full-page zoom) that
would affect the stroke before it reached the device pixel level.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintForStroking):
13:45 Changeset [41682] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24583
Need to change scope of constructor and destructor of V8ObjectEventListener from private
to protected so that they could be used in its derived class V8WorkerContextEventListener.

  • bindings/v8/V8ObjectEventListener.h:
12:53 Changeset [41681] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

And yet another attempt...


  • Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler):
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
12:52 Changeset [41680] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Another attempt at fixing the build.


  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
12:39 Changeset [41679] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-13 Anders Carlsson <andersca@apple.com>

Try to fix the SL build.

  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown):
12:13 Changeset [41678] by levin@chromium.org
  • 1 edit
    8 moves in trunk/WebCore

2009-03-13 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24579
Many V8*Event* files are misplaced.

This code is infrastructure for supporting the bindings and thus should
be in the bindings/v8 directory.

  • bindings/v8/V8AbstractEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.cpp.
  • bindings/v8/V8AbstractEventListener.h: Renamed from WebCore/bindings/v8/custom/V8AbstractEventListener.h.
  • bindings/v8/V8LazyEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.cpp.
  • bindings/v8/V8LazyEventListener.h: Renamed from WebCore/bindings/v8/custom/V8LazyEventListener.h.
  • bindings/v8/V8ObjectEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.cpp.
  • bindings/v8/V8ObjectEventListener.h: Renamed from WebCore/bindings/v8/custom/V8ObjectEventListener.h.
  • bindings/v8/V8WorkerContextEventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.cpp.
  • bindings/v8/V8WorkerContextEventListener.h: Renamed from WebCore/bindings/v8/custom/V8WorkerContextEventListener.h.
12:06 Changeset [41677] by adele@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

Test: editing/pasteboard/5089327.html

Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): (WebCore::ReplaceSelectionCommand::handleStyleSpans):

LayoutTests:

2009-03-13 Adele Peterson <adele@apple.com>

Reviewed by Justin Garcia.

Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content

  • editing/pasteboard/5089327.html: Added.
  • platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5089327-expected.png: Added.
  • platform/mac/editing/pasteboard/5089327-expected.txt: Added.

Updated colors for pasted content.

  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:
11:57 Changeset [41676] by andersca@apple.com
  • 2 edits in trunk/WebKitExamplePlugins

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Update to match new API.


  • NetscapeInputMethodPlugin/main.m: (NPP_New): (NPP_Destroy): (NPP_SetWindow): (handleDraw): (invalidatePlugin): (handleFocusChanged): (handleMouseMoved): (handleMouseDown): (handleTextFieldKeyDown): (handleTextInput): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
11:56 Changeset [41675] by bolsinga@apple.com
  • 14 edits
    3 adds in trunk

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.


WebChromeClient now calls the private UI delegate method
-webView:frame:requestGeolocationPermission:securityOrigin:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestGeolocationPermissionForFrame):
  • WebCoreSupport/WebGeolocation.mm: Added. (WebCore::if): (-[WebGeolocation shouldClearCache]): (-[WebGeolocation setIsAllowed:]): (-[WebGeolocation dealloc]):
  • WebCoreSupport/WebGeolocationInternal.h: Added.
  • WebCoreSupport/WebGeolocationPrivate.h: Added.
  • WebView/WebUIDelegatePrivate.h:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the
coding style set by WebSecurityOrigin.

  • WebKit.xcodeproj/project.pbxproj:

2009-03-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Update Geolocation perimission dialogs to be asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=24505

Geolocation now requests permission from the Chrome asynchronously.
The Chrome is passed the Geolocation object, and the Chrome sets the permission
on the Geolocation. Geolocation also tracks if the Chrome should clear its cache
of SecurityOrigins with geolocation permission. This is so that the GeolocationService
can inform the Chrome of its request, and the Chrome is also free to implement its
own policy.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::requestGeolocationPermissionForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::requestGeolocationPermissionForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::displayChallengeIfNecessary): (WebCore::Geolocation::geolocationServicePositionChanged):
  • page/Geolocation.h: (WebCore::Geolocation::isAllowed): (WebCore::Geolocation::setShouldClearCache): (WebCore::Geolocation::shouldClearCache): (WebCore::Geolocation::):
11:44 Changeset [41674] by andersca@apple.com
  • 12 edits
    1 delete in trunk

WebCore:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Add a NPCocoaEventTextInput event type. Remove the text input variables.


  • bridge/npapi.h: (_NPCocoaEvent::):

WebKit:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API


Remove nptextinput.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Replace the text input API with a simpler API that uses a separate text input window.


  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): Initialize m_keyEventHandler to 0.


(WebNetscapePluginEventHandlerCocoa::keyDown):
If the plug-in returns 0 from NPP_HandleEvent, pass the event to the TSM machinery.


(WebNetscapePluginEventHandlerCocoa::focusChanged):
Install/remove the key event handler as needed.


(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
Get the text and send a TextInput event.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: Remove the old text input API.


(-[WebNetscapePluginView inputContext]):
Always return nil here.


  • Plugins/npapi.mm:
  • Plugins/nptextinput.h: Removed.

WebKitTools:

2009-03-13 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6610666> Revise the Cocoa event model text API

Add a case statement for NPCocoaEventTextInput.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (handleEventCocoa):
11:18 Changeset [41673] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/6630340> REGRESSION (39114-39115): Unity Web Player no longer works if Flip4Mac is also installed


The code assumed if we have a plug-in that supports "application/x-oleobject" we should always prefer the object tag
over of an embed tag. That assumption can cause the Mac platform to load the wrong plug-in, as Flip4Mac claims supports
for x-oleobject.


  • rendering/RenderPartObject.cpp: (WebCore::shouldUseEmbedDescendant): Made the Mac platform always return true here.
10:57 WebKit Team edited by abarth@webkit.org
(diff)
10:47 WebKit Team edited by dimich@chromium.org
(diff)
10:45 Changeset [41672] by pam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add tests for window property lookup precedence in the presence of
conflicting names in a child frame and in a named document element.

https://bugs.webkit.org/show_bug.cgi?id=24170

  • fast/dom/Window/resources/window-properties.js: Added.
  • fast/dom/Window/window-lookup-precedence-expected.txt: Added.
  • fast/dom/Window/window-lookup-precedence.html: Added.
  • fast/js/resources/js-test-pre.js: (shouldEvaluateTo): Added. Compares expected values of various types.
10:32 Changeset [41671] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24559
Need to port JSC fix (r41565) to V8 in order to fix layout test onload-single-line-comment.html.

  • bindings/v8/custom/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
10:32 Changeset [41670] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-13 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24557
This is to support running multiple workers in a single worker process in chromium.

  • bindings/v8/custom/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent): Add locker to v8 event listener of worker context.
10:09 Changeset [41669] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to ensure that DOM constructors have higher lookup
precedence than a document element with the same name.

https://bugs.webkit.org/show_bug.cgi?id=24520

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
09:52 WebKit Team edited by pam@chromium.org
(diff)
09:20 Changeset [41668] by pam@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-03-13 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that the JS wrapper for the document in an
inner frame is created in the correct context when it's accessed
from the outer frame first.

https://bugs.webkit.org/show_bug.cgi?id=24564

  • fast/dom/resources/wrapper-context-inner.html: Added.
  • fast/dom/wrapper-context-expected.txt: Added.
  • fast/dom/wrapper-context.html: Added.
09:11 WebKit Team edited by treat@kde.org
Update with new reviewers and affiliations (diff)
06:25 Changeset [41667] by ap@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24575
XHR response is incorrect after a network error.

Tests: http/tests/xmlhttprequest/cross-site-denied-response-sync-2.html

http/tests/xmlhttprequest/cross-site-denied-response-sync.html
http/tests/xmlhttprequest/cross-site-denied-response.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::networkError): Call internalAbort() to fully reset the request. (WebCore::XMLHttpRequest::didFailRedirectCheck): No need to call internalAbort() here. Note that since internalAbort() can drop GC protection, it is not safe to use the object after this call. (WebCore::XMLHttpRequest::didReceiveData): Check that the request wasn't aborted, and return early if it was. This can happen during sync requests, as the loader does not know that it was aborted, and just synthesizes all callbacks.
05:57 Changeset [41666] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Updating results after the fix for bug 3547.

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: The status text for a failed local file load is no longer "OK", which is good.
04:06 Changeset [41665] by ap@webkit.org
  • 5 edits
    4 adds in trunk

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=3547
XMLHttpRequest.statusText returns always "OK"

Covered by existing tests (which now pass on all platforms but Mac).

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::statusText): Return ResourceResponse status text. It is now up to each platform to correctly set the status text or set it to "OK" to retain current behavior.
03:05 Changeset [41664] by ap@webkit.org
  • 2 edits in trunk/WebCore

2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24349
[QT] HTTP status text is never set

Set HTTP status text to the reason phrase attribute of QNetworkReply.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

03/12/09:

23:23 Changeset [41663] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • Skipped file fix
  • platform/mac-tiger/Skipped:
23:07 Changeset [41662] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe

<rdar://problem/6622300>: Reproducible crash on
<http://www.editgrid.com/explore/tnc/dave/FusionChart%3A_Candlestick>

Prevent CSSStyleSheet::checkLoaded() writing to freed memory when it gets
deleted from under itself. The sheetLoaded() notification can allow scripts
to run via HTMLTokenizer::executeScriptsWaitingForStylesheets(),
which can cause the last ref to the CSSStyleSheet to be released.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
22:28 Changeset [41661] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Let DerivedSources.make know we want database APIs.

20:33 Changeset [41660] by mrowe@apple.com
  • 5 edits in trunk/JavaScriptCore

<rdar://problem/6548446> TCMalloc_SystemRelease should use madvise rather than re-mmaping span of pages

  • wtf/FastMalloc.cpp:

(WTF::mergeDecommittedStates): If either of the spans has been released to the system, release the other
span as well so that the flag in the merged span is accurate.

  • wtf/Platform.h:
  • wtf/TCSystemAlloc.cpp: Track decommitted spans when using MADV_FREE_REUSABLE / MADV_FREE_REUSE.

(TCMalloc_SystemRelease): Use madvise with MADV_FREE_REUSABLE when it is available.
(TCMalloc_SystemCommit): Use madvise with MADV_FREE_REUSE when it is available.

  • wtf/TCSystemAlloc.h:
20:10 Changeset [41659] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=24498
Fix the Qt port to use the same algorithm for drawing dashed and dotted
borders as the other ports. This makes the Qt port pixel-for-pixel perfect
compared to border drawing with Apple's canonical mac port and much closer
to konqueror and firefox behavior.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine):
17:15 Changeset [41658] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • skip editing/selection/word-thai.html on Tiger because it has an older version of Unicode.
  • platform/mac-tiger/Skipped:
16:05 Changeset [41657] by eric@webkit.org
  • 5 edits in trunk

Reviewed by Justin Garcia.

Clean up DOMSelection to use some helper functions
making the code smaller, and less error-prone.
https://bugs.webkit.org/show_bug.cgi?id=19221

I tried moving DOMSelection off of rangeCompliantEquivalent
but failed. VisibleSelection holds positions like (table, 1) to mean
"after the table".

  • page/DOMSelection.cpp: (WebCore::DOMSelection::visibleSelection): (WebCore::anchorPosition): (WebCore::focusPosition): (WebCore::basePosition): (WebCore::extentPosition): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::extentOffset):
  • page/DOMSelection.h:
15:47 Changeset [41656] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-12 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24563
Change ResourceRequest to be a struct rather then a class to match other declarations.

  • platform/network/chromium/ResourceRequest.h:
15:15 Changeset [41655] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Add Mark.

15:13 Changeset [41654] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Mike Thole.

Fix <rdar://problem/6624105>.


Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
15:05 Changeset [41653] by levin@chromium.org
  • 2 edits in trunk/LayoutTests

2009-03-12 Aaron Boodman <aa@chromium.org>

Reviewed by Dave Hyatt.

Bug 16348: @font-face does not affect the default style
<https://bugs.webkit.org/show_bug.cgi?id=16348>

  • fast/css/font-face-default-font.html: Handle the default font being either 'Times' or 'Times New Roman'.
15:05 Changeset [41652] by levin@chromium.org
  • 4 edits
    1 copy in trunk/WebCore

2009-03-12 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

Bug 24530: width100percent-searchfield.html should be fixed for chromium.
<https://bugs.webkit.org/show_bug.cgi?id=24530>

Compensate for r39924 in chromium, which broke LayoutTests/fast/replaced/width100percent-searchfield.html

  • css/themeChromiumWin.css: Added. Overrides the changes to start supporting input[type="search"] on Windows (since Chromium doesn't do anything special for this).
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::supportsFocus): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::determineState): (WebCore::RenderThemeChromiumWin::getThemeData):
15:01 Changeset [41651] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a test to check that an invalid second argument of
window.postMessage is ignored. Note that this is probably not the
correct behavior according to the HTML5 spec, so this test will
need to be changed once we support that.

https://bugs.webkit.org/show_bug.cgi?id=24523

  • fast/dom/Window/window-postmessage-args-expected.txt: Added.
  • fast/dom/Window/window-postmessage-args.html: Added.
14:21 Changeset [41650] by bolsinga@apple.com
  • 14 edits
    3 adds in trunk/WebCore

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position


Get up to date.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions):
  • page/Coordinates.cpp: Added. (WebCore::Coordinates::toString):
  • page/Coordinates.h: Added. (WebCore::Coordinates::create): (WebCore::Coordinates::latitude): (WebCore::Coordinates::longitude): (WebCore::Coordinates::altitude): (WebCore::Coordinates::accuracy): (WebCore::Coordinates::altitudeAccuracy): (WebCore::Coordinates::heading): (WebCore::Coordinates::speed): (WebCore::Coordinates::Coordinates):
  • page/Coordinates.idl: Added.
  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
  • page/Geoposition.h: (WebCore::Geoposition::create): (WebCore::Geoposition::coords): (WebCore::Geoposition::Geoposition):
  • page/Geoposition.idl:
  • page/PositionOptions.h: (WebCore::PositionOptions::create): (WebCore::PositionOptions::maximumAge): (WebCore::PositionOptions::setMaximumAge): (WebCore::PositionOptions::PositionOptions):
  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
14:10 Changeset [41649] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string, for V8 bindings.

Test: fast/js/console-non-string-values.html

  • bindings/v8/ScriptValue.cpp: Added toString method. (WebCore::ScriptValue::toString):
  • bindings/v8/ScriptValue.h: Added PlatformString, ScriptState includes

and toString declaration.

14:08 Changeset [41648] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Eliminate ChromiumBridge::uiResourceProtocol
https://bugs.webkit.org/show_bug.cgi?id=24558

  • platform/chromium/ChromiumBridge.h:
13:44 Changeset [41647] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-12 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

Missing breaks in switch statement
https://bugs.webkit.org/show_bug.cgi?id=24556

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
13:39 Changeset [41646] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-12 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24554
Remove some unused functions from ChromiumBridge.

  • platform/chromium/ChromiumBridge.h:
13:29 Changeset [41645] by eric@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Fisher and Justin Garcia.

Safari crashes during drag and drop in Google presentations
due to mutation event handlers removing DOM content during insertNode
https://bugs.webkit.org/show_bug.cgi?id=22634

Added a bunch of "null" checks to make sure nodes are still
in the document before we operate on them. This is an
inelegant solution, but it's the best we have for now.

Test: editing/selection/crash-on-drag-with-mutation-events.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
13:11 Changeset [41644] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=24508

Fix updating of text field with placeholder text when value is set
by ensuring that updatePlaceholderVisibility() is called after
the value has been updated, not before.

Test: fast/forms/placeholder-set-value.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
12:52 Changeset [41643] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=24525
REGRESSION: Inspector window doesn't close when inspected page is
destroyed. This is a revert of r41158, which became unnecessary when
InspectorController became ref-counted in r41462.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Reset m_inspectedPage

after calling close().

(WebCore::InspectorController::stopUserInitiatedProfiling): Remove

m_inspectedPage check guard around profile logic.

12:41 Changeset [41642] by pkasting@chromium.org
  • 6 edits in trunk

WebCore:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

  • platform/PlatformWheelEvent.h:
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/win:

2009-03-12 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24502
Make horizontal scrolling on Windows always go the correct direction.

  • WebView.cpp: (WebView::mouseWheel): (WebViewWndProc):
  • WebView.h:
12:36 Changeset [41641] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-12 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6607801>


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Pass a requestID to _WKPCDestroyPluginInstance and wait until we get a reply back.


  • Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameter.
12:34 Changeset [41640] by dglazkov@chromium.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24496
Fix console logging of non-string values by coercing the argument to
a string.

Test: fast/js/console-non-string-values.html

  • bindings/js/ScriptValue.cpp: Removed PlatformString include.
  • bindings/js/ScriptValue.h: Added toString method. (WebCore::ScriptValue::toString):
  • page/Console.cpp: (WebCore::getFirstArgumentAsString): Changed firstArgumentAsString method to use

ScriptValue::toString.

(WebCore::Console::addMessage): added extra ScriptState argument to callsite.
(WebCore::Console::count): Ditto.

LayoutTests:

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24496
Test for logging non-string values.

  • fast/js/console-non-string-values-expected.txt: Added.
  • fast/js/console-non-string-values.html: Added.
12:32 Changeset [41639] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Rename 'state' to 'status' to match the naming in the frame
loader rework that we plan to land soonish, and make it a
property, for the same reason.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_status): (_WebKitDownloadPrivate::webkit_download_set_status): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error):
  • webkit/webkitdownload.h:
12:32 Changeset [41638] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24553
[GTK] Improvements to WebKitDownload

Improved documentation for the download-requested signal, to make
its usage clear.

  • webkit/webkitwebview.cpp:
12:27 Changeset [41637] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-03-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24552

Hit testing involving normal flow, self-painting layers (e.g. reflections)
was broken because it was not null-testing the result of hitTestLayer(),
so bailing early with a nil hit layer.

Test: fast/layers/normal-flow-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
11:33 Changeset [41636] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test cases to make sure window.location and window.navigator
have higher lookup precedence than a DOM element with that ID.

https://bugs.webkit.org/show_bug.cgi?id=24522

  • fast/dom/Window/window-special-properties-expected.txt:
  • fast/dom/Window/window-special-properties.html:
11:30 Changeset [41635] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Simply a small SUPPORT_CFM code block.
11:20 Changeset [41634] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

Fixed: <rdar://problem/5815862> Opening a subclassed NSWindow from a Safari plugin causes Safari to crash on Quit


This fix addresses crashes in both Silverlight and ChemDraw. This type of crash would occur because AppKit still
had a reference to open windows that the plugin created (which no longer exist).


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Do not unload the plug-in bundle on browser shutdown.
11:08 Changeset [41633] by dglazkov@chromium.org
  • 1 edit
    2 deletes in trunk/WebCore

2009-03-12 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Cameron Zwarich.

Removed zero-sized files, left over from improperly applied patch.

  • platform/graphics/chromium/ThemeHelperChromiumWin.cpp: Removed.
  • platform/graphics/chromium/ThemeHelperChromiumWin.h: Removed.
11:04 Changeset [41632] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by NOBODY (Build fix).

Include string.h for strlen usage.

  • wtf/Threading.cpp:
10:24 Changeset [41631] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-03-12 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Add a test to make sure GC doesn't drop XHR wrappers too soon.
https://bugs.webkit.org/show_bug.cgi?id=24528

  • fast/dom/xmlhttprequest-gc-expected.txt: Added.
  • fast/dom/xmlhttprequest-gc.html: Added.
09:35 Changeset [41630] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-12 Adam Treat <adam.treat@torchmobile.com>

Reviewed by George Staikos.

Do not ignore alpha color in optimization. Hard to believe, but there
are websites that fill the entire page with a tiled image consisting of
nothing but a 100% transparent 1x1 image. <cough>orbitz.com</cough>

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
09:22 Changeset [41629] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Implement DOMHTMLDocument::title

Reviewed by Dan Bernstein.

  • DOMHTMLClasses.cpp: (DOMHTMLDocument::title): Call through to WebCore::Document (with obligatory COM error checking/type conversions).
08:28 Changeset [41628] by ddkilzer@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Fixed ChangeLog date.

08:26 Changeset [41627] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Add NO_RETURN attribute to runInteractive() when not using readline

Reviewed by Darin Adler.

  • jsc.cpp: (runInteractive): If the readline library is not used, this method will never return, thus the NO_RETURN attribute is needed to prevent a gcc warning.
08:01 Changeset [41626] by aroben@apple.com
  • 3 edits in trunk/JavaScriptCore

Adopt setThreadNameInternal on Windows

Also changed a Windows-only assertion about thread name length to an
all-platform log message.

Reviewed by Adam Treat.

  • wtf/Threading.cpp: (WTF::createThread): Warn if the thread name is longer than 31 characters, as Visual Studio will truncate names longer than that length.
  • wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Renamed from setThreadName and changed to always operate on the current thread. (WTF::initializeThreading): Changed to use setThreadNameInternal. (WTF::createThreadInternal): Removed call to setThreadName. This is now handled by threadEntryPoint and setThreadNameInternal.
08:00 Changeset [41625] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Also make page up and page down keys be handled by the webview key
event code, so that they also work in cases where the GTK+
scrollbars don't handle them directly, like in the bugzill's patch
review page.

  • webkit/webkitwebview.cpp:
08:00 Changeset [41624] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24541
Scrolling with home and end keys not always works

Make home and end keys behave more consistently for scrolling the
view.

  • webkit/webkitwebview.cpp:
07:46 Changeset [41623] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs

<https://bugs.webkit.org/show_bug.cgi?id=24378>

Reviewed by Adam Roben.

Scripts/resolve-ChangeLogs: If -ffix-merged is not passed

and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.

06:18 Changeset [41622] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-12 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Alp Toker.

https://bugs.webkit.org/show_bug.cgi?id=24254
[GTK] spacebar doesn't scroll down

Make spacebar and shift+spacebar scroll like page up and down
respectively would.

  • webkit/webkitwebview.cpp:
05:42 Changeset [41621] by jchaffraix@webkit.org
  • 11 edits in trunk/WebCore

2009-03-12 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 24110: cloneNode should call cloneElement and not the reverse

  • Splitted the code from cloneNode into cloneElementWithChildren and cloneElementWithChildren. Now cloneNode calls one of the 2 previous methods.
  • Renamed cloneElement to cloneElementWithoutChildren as it was the previous behaviour.
  • Moved cloneNode to the Element private section so that WebCore callers cannot use it.
  • Removed Element::cloneNode usage through WebCore.
  • dom/Element.cpp: (WebCore::Element::cloneNode): Moved to Element's private section and it now calls the two next methods. (WebCore::Element::cloneElementWithChildren): Added. (WebCore::Element::cloneElementWithoutChildren): Renamed from cloneElement to avoid ambiguity.
  • dom/Element.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Changed call to cloneElement to call to cloneElementWithoutChildren.
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Ditto.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Ditto.
  • editing/markup.cpp: (WebCore::createFragmentFromText): Ditto.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): Ditto. (WebCore::SVGUseElement::expandUseElementsInShadowTree): Ditto.
04:08 Changeset [41620] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-12 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Fixed a crash on the 1x1 pixel check for background image in gtk.
We need to load the image first and need to be sure that the image
is not null before checking the type.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::checkForSolidColor):
01:46 Changeset [41619] by xan@webkit.org
  • 5 edits in trunk/WebCore

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24544
Rename setUrl to setURL

Use proper case for setUrl method, rename it to setURL.

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt):
  • platform/network/ResourceResponseBase.h:
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):
00:58 Changeset [41618] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-03-12 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24519
[GTK] Use two argument KURL ctor in ResourceHandleSoup

Use two argument KURL ctor, the single argument ctor expects its
input to be the output of a previous KURL::parse call, which is
not the case here.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage): (WebCore::queryInfoCallback):
00:41 Changeset [41617] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-03-11 Jon Honeycutt <jhoneycutt@apple.com>

Fix for <rdar://6418681>
https://bugs.webkit.org/show_bug.cgi?id=22644

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): Add the Citrix ICA Client plug-in to the blacklist; it requires a Mozilla-based browser.
00:26 Changeset [41616] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix

03/11/09:

23:39 Changeset [41615] by oliver@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/6673852> Widget "Simple World Clock" does not display with Safari 4

Reviewed by Adele Peterson.

A number of dashboard widgets rely on canvas failing silently when given invalid
colors for gradient stops, but both the spec and firefox throw exceptions here.
So we work around this by creating a dashboard quirk that will only suppress the
exception in dashboard compatibility mode.

Test: fast/canvas/canvas-gradient-addStop-error.html

23:02 Changeset [41614] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Remove duplicate header include

Rubber-stamped by Mark Rowe.

  • WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>. Also realphabetized lowercase #include statements.
22:14 Changeset [41613] by ddkilzer@apple.com
  • 8 edits in trunk

Clarify comments regarding order of FEATURE_DEFINES

Rubber-stamped by Mark Rowe.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebCore:

  • Configurations/WebCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync.

WebKitTools:

  • Scripts/build-webkit: Added warning about keeping FEATURE_DEFINES in order and the consequences when they are not.
21:39 Changeset [41612] by mrowe@apple.com
  • 2 edits in tags/Safari-6530.3/WebKit/mac

Merge r41592.

21:37 Changeset [41611] by mrowe@apple.com
  • 7 edits
    2 copies in tags/Safari-6530.3

Merge r41576.

21:27 Changeset [41610] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-11 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24515
[GTK] soup backend should use GMappedFile instead of mmap directly

Rewrite mmap code used to upload files to use GMappedFile, so that
it is platform-independent.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
21:06 Changeset [41609] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

21:05 Changeset [41608] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.3

New tag.

20:39 Changeset [41607] by mitz@apple.com
  • 8 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

  • WTF support for fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns whether the character has Unicode line breaking property value SA ("Complex Context").
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an implementation that always returns false.

WebCore:

Reviewed by Darin Adler.

  • WebCore part of fixing <rdar://problem/3919124> Thai text selection in Safari is incorrect

Test: platform/mac/editing/selection/word-thai.html

Tested on Mac, but should work on all ICU platforms (or more precisely
on all platforms that implement
WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).

  • editing/TextIterator.cpp: (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator): Added. (WebCore::BackwardsCharacterIterator::range): Added. (WebCore::BackwardsCharacterIterator::advance): Added.
  • editing/TextIterator.h: Added BackwardsCharacterIterator with the minimal functionality required for this patch. (WebCore::BackwardsCharacterIterator::atEnd): Added.
  • editing/visible_units.cpp: (WebCore::firstNonComplexContextLineBreak): Added this helper function that returns the index of the first character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or the length of the string if there is no such character. (WebCore::lastNonComplexContextLineBreak): Added this helper function that returns the index of the last character in the string whose Unicode line breaking property value is not SA ("Complex Context"), or -1 if there is no such character. (WebCore::previousBoundary): Changed the signature of the search function to include an offset parameter. Renamed the 'exception' local variable to 'ec' and changed its type to ExceptionCode. Extend the string forwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the forward direction. Changed to use a BackwardsCharacterIterator for translating the backwards offset into a position. (WebCore::nextBoundary): Changed the signature of the search function to include an offset parameter. Extend the string backwards until the first character with Unicode line breaking property value other than SA. This gives the boundary search function enough context in the backwards direction. Restricted the workaround for <rdar://5192593> only to the line break case, because it was causing an extra character to be selected following a word that ended with a combining mark. (WebCore::startWordBoundary): Added an offset parameter. Check that going backwards from the given offset, there is a character with Unicode line breaking property value other than SA, and otherwise return 0 to request more context. (WebCore::endWordBoundary): Similar, but in reverse. (WebCore::previousWordPositionBoundary): Similar. (WebCore::nextWordPositionBoundary): Similar. (WebCore::startSentenceBoundary): Updated for the new search function signature. (WebCore::endSentenceBoundary): Ditto. (WebCore::previousSentencePositionBoundary): Ditto. (WebCore::nextSentencePositionBoundary): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/3919124> Thai text selection in Safari is incorrect
  • platform/mac/editing/selection/word-thai-expected.txt: Added.
  • platform/mac/editing/selection/word-thai.html: Added.
18:29 Changeset [41606] by darin@apple.com
  • 6 edits in trunk/WebCore

2009-03-11 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Don't use "::" in thread names because it is ugly!

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Use "WebCore: " instead of "WebCore::".
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loaderRunLoop): Call this "WebCore: CFNetwork Loader" to make it clear this is a WebCore-created thread.
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): Use "WebCore: " instead of "WebCore::".
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): Use "WebCore: " instead of "WebCore::".
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::start): Use "WebCore: " instead of "WebCore::".
18:26 Changeset [41605] by darin@apple.com
  • 8 edits in trunk/JavaScriptCore

2009-03-11 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Give threads names on platforms with pthread_setname_np.

  • wtf/Threading.cpp: (WTF::NewThreadContext::NewThreadContext): Initialize thread name. (WTF::threadEntryPoint): Call setThreadNameInternal. (WTF::createThread): Pass thread name.
  • wtf/Threading.h: Added new comments, setThreadNameInternal.
  • wtf/ThreadingGtk.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingNone.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Call pthread_setname_np when available.
  • wtf/ThreadingQt.cpp: (WTF::setThreadNameInternal): Added. Empty.
  • wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Added. Empty.
17:53 Changeset [41604] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6653286> WebCore's implementation of screenIsMonochrome is needlessly complex

Rubber-stamped by Darin Adler.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenIsMonochrome): Return false.

17:51 Changeset [41603] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24531

Make sure that AnimationControllerPrivate::getAnimatedStyleForRenderer() never
returns a null style if it has a valid renderer, which could happen if a
CompositeAnimation existed, but wasn't running any animations or transitions.

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
16:25 Changeset [41602] by bdakin@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-03-11 Beth Dakin <bdakin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

  • and corresponding - <rdar://problem/6172925>
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests:

2009-03-11 Beth Dakin <bdakin@apple.com>

Reviewed by Dan Bernstein.

Test for https://bugs.webkit.org/show_bug.cgi?id=14749 percentage
top value on position:relative child not calculated correctly if
parent has percentage height

  • and corresponding - <rdar://problem/6172925>
  • fast/css/percent-top-value-with-relative-position.html: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.checksum: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.png: Added.
  • platform/mac/fast/css/percent-top-value-with-relative-position-expected.txt: Added.
14:54 Changeset [41601] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-11 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Implement ScriptValue::hasNoValue for V8.
https://bugs.webkit.org/show_bug.cgi?id=24507

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::hasNoValue):
14:54 Changeset [41600] by levin@chromium.org
  • 5 edits
    2 copies
    7 adds in trunk/WebCore

2009-03-11 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 24459: Add v8 bindings for event.
<https://bugs.webkit.org/show_bug.cgi?id=24459>

Adding custom event bindings.

  • bindings/v8/custom/V8AbstractEventListener.cpp: Added.
  • bindings/v8/custom/V8AbstractEventListener.h: Added.
  • bindings/v8/custom/V8AttrCustom.cpp: Fixed messed up copyright header.
  • bindings/v8/custom/V8CustomEventListener.cpp: Added.
  • bindings/v8/custom/V8CustomEventListener.h: Replaced forwarding header with the real implementation.
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8LazyEventListener.cpp: Added.
  • bindings/v8/custom/V8LazyEventListener.h: Added.
  • bindings/v8/custom/V8ObjectEventListener.cpp: Added.
  • bindings/v8/custom/V8ObjectEventListener.h: Added.
  • bindings/v8/custom/V8WorkerContextEventListener.cpp: Added.
  • bindings/v8/custom/V8WorkerContextEventListener.h: Added.
14:40 Changeset [41599] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-11 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24521
Add some missing includes for the non-JSC build.

  • platform/text/PlatformString.h: added OwnPtr.h
  • xml/XMLHttpRequest.cpp: added SecurityOrigin.h
14:17 Changeset [41598] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-03-11 Pamela Greene <pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
These files were accidentally left out of r41459.

https://bugs.webkit.org/show_bug.cgi?id=24339

  • fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
  • fast/dom/Window/window-collection-length-no-crash.html: Added.
13:58 Changeset [41597] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6656147>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Pass the requestID to _WKPHInstantiatePlugin.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: Pass the requestID to setCurrentReply.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::setCurrentReply): Store the reply in a map with the requestID as the key.


(WebKit::NetscapePluginInstanceProxy::waitForReply):
Wait for a reply that matches the given requestID.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize member variables.


(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Delete all requests.


(WebKit::NetscapePluginInstanceProxy::print):
Pass the requestID to _WKPHPluginInstancePrint.


(WebKit::NetscapePluginInstanceProxy::loadRequest):
Rename m_currentRequestID to m_currentURLRequestID.


(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Process requests until we find a reply with the right requestID.


(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Pass a requestID to the _WKPH function.


(WebKit::NetscapePluginInstanceProxy::nextRequestID):
Ditto.


  • Plugins/Hosted/ProxyInstance.mm: Pass a requestID to the _WKPH functions.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameters.
13:41 Changeset [41596] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Fix Scons build. Patch from Alexander Guy.

  • WebCore.scons:
13:39 Changeset [41595] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Export functions needed by ThreadSpecific from WebKit

Reviewed by John Sullivan.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def: Export WTF::tlsKeyCount and WTF::tlsKeys.
13:39 Changeset [41594] by aroben@apple.com
  • 4 edits in trunk/JavaScriptCore

Change the Windows implementation of ThreadSpecific to use functions instead of extern globals

This will make it easier to export ThreadSpecific from WebKit.

Reviewed by John Sullivan.

  • API/JSBase.cpp: (JSEvaluateScript): Touched this file to force ThreadSpecific.h to be copied into $WebKitOutputDir.
  • wtf/ThreadSpecific.h: Replaced g_tls_key_count with tlsKeyCount() and g_tls_keys with tlsKeys().

(WTF::::ThreadSpecific):
(WTF::::~ThreadSpecific):
(WTF::::get):
(WTF::::set):
(WTF::::destroy):
Updated to use the new functions.

  • wtf/ThreadSpecificWin.cpp: (WTF::tlsKeyCount): (WTF::tlsKeys): Added.

(WTF::ThreadSpecificThreadExit): Changed to use the new functions.

12:45 Changeset [41593] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24366

Make this test more reliable by only calling runAnimationTest() once
the animation starts, not before some setTimeout().

  • animations/change-keyframes-name-expected.txt:
  • animations/change-keyframes-name.html:
12:09 Changeset [41592] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-11 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6620064>.


  • Plugins/WebPluginContainerPrivate.h:
12:04 Changeset [41591] by simon.fraser@apple.com
  • 6 edits in trunk/LayoutTests

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24266

Land new expected results for transform-absolute-in-positioned-container.html,
and new pixel results for reflection-masks.html. Both are progressions.

  • platform/mac/fast/reflections/reflection-masks-expected.checksum:
  • platform/mac/fast/reflections/reflection-masks-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
12:00 Changeset [41590] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2009-03-11 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23093

When the cancel button in the search field is shown or hidden,
we need to explicitly setStyle() on the cancel button's renderer,
to ensure that repaint happens. Changing the style without telling
the renderer won't work.

Test: fast/repaint/search-field-cancel.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::subtreeHasChanged): (WebCore::RenderTextControlSingleLine::updateFromElement): (WebCore::RenderTextControlSingleLine::createCancelButtonStyle): (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility): (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
  • rendering/RenderTextControlSingleLine.h:
10:58 Changeset [41589] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-11 Marc-André Decoste <mad@chromium.org>

Reviewed by Eric Seidel.

Fixed the positions of the list boxes so that the size of their
rendering doesn't affect the test coordinates.
https://bugs.webkit.org/show_bug.cgi?id=24006

  • fast/forms/option-mouseevents-expected.txt:
  • fast/forms/option-mouseevents.html:
09:05 Changeset [41588] by ap@webkit.org
  • 4 edits
    2 adds in trunk

2009-03-11 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=15790
Ligatures aren't accounted for when manipulating VisiblePositions

Changed cursorMovementIterator rules to prevent a cursor from moving in the middle of an
Indic ligature which uses a virama sign.


Test: editing/deleting/skip-virama-001.html

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator):
08:46 Changeset [41587] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24513
REGRESSION: Cursor movement doesn't work on Tiger (ICU 3.2)

Fixes existing tests on Tiger.

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Use characterBreakIterator on Tiger (like we used to do).
07:53 Changeset [41586] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Only run code in dispose once per instance.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
07:53 Changeset [41585] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

Call deref() on our internal HistoryItem on dispose, as we always
acquire it with a releaseRef() call to a PassRefPtr, which passes
ownership.

  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
07:52 Changeset [41584] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24493
[GTK] Misc patches for WebKitWebHistoryItem

return foo? foo : NULL == return foo

  • webkit/webkitwebhistoryitem.cpp: (WebKit::core):
05:27 Changeset [41583] by jmalonzo@webkit.org
  • 8 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Enable http/tests/security/cross-frame-access-private-browsing.html test.

  • platform/gtk/Skipped:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Add private browsing option "enable-private-browsing" to WebKitWebSettings.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Also reset WebSettings to its default state for JavaScript
profiling, Developer Extras and Private Browsing before running
the test (can be after each test but we want to be consistent with
other ports in this regard)

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setPrivateBrowsingEnabled):
05:06 Changeset [41582] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] BackForward history leak?
https://bugs.webkit.org/show_bug.cgi?id=19528

Don't ref the history items when returning the back/forward list
Added test_webkit_web_history_item_lifetime test case for this.

  • tests/main.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): Style fix. (test_webkit_web_back_forward_list_add_item): Style fix. (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
04:58 Changeset [41581] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Correct selector name in instancesRespondToSelector.
04:57 Changeset [41580] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Fix make clean targets
https://bugs.webkit.org/show_bug.cgi?id=24450

Fix 'make' clean targets. We shouldn't be removing DerivedSources
if it's only clean. Only remove it if it's distclean or
maintainer-clean. Also remove build-related auxillary files on
dist/maintainer clean.

  • GNUmakefile.am:
04:52 Changeset [41579] by jmalonzo@webkit.org
  • 7 edits in trunk

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

pangoft2 is also used in directfb builds so use it for all targets

  • configure.ac:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add missing stdio.h include to get the build going

  • plugins/gtk/PluginPackageGtk.cpp:

2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
https://bugs.webkit.org/show_bug.cgi?id=2260

Add plugin support only for X11 builds

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
  • GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.