Timeline


and

03/19/09:

22:57 Changeset [41854] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.


SunSpider reports no change. I also verified in the disassembly that
we end up with a single compare to constant.

  • runtime/Collector.cpp: (JSC::Heap::heapAllocate):
21:31 Changeset [41853] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Remove #ifndef BUILDING_ON_TIGER around code that schedules runloop modes
for Page, so the new RunLoopTimer in WebCore always gets a default mode.
Fixes the layout test failures on the Tiger build bots.

Reviewed by Mark Rowe.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView scheduleInRunLoop:forMode:]): (-[WebView unscheduleFromRunLoop:forMode:]):
21:28 Changeset [41852] by ggaren@apple.com
  • 4 edits
    1 move in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
fast/workers/use-machine-stack.html (22531)

Dialed down the re-entry allowance to 64 (from 128).


On a 512K stack, this leaves about 64K for other code on the stack while
JavaScript is running. Not perfect, but it solves our crash on PPC.

Different platforms may want to dial this down even more.

Also, substantially shrunk BytecodeGenerator. Since we allocate one on
the stack in order to throw a stack overflow exception -- well, let's
just say the old code had an appreciation for irony.

SunSpider reports no change.

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.h: (JSC::):

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Re-enabled this test, since it no longer crashes when JavaScriptCore is
compiled in non-JIT mode.

  • fast/workers/use-machine-stack.html: Copied from fast/workers/use-machine-stack.html-disabled.
  • fast/workers/use-machine-stack.html-disabled: Removed.
19:04 Changeset [41851] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24350: REGRESSION: Safari 4 breaks SPAW wysiwyg editor multiple instances
<https://bugs.webkit.org/show_bug.cgi?id=24350>
<rdar://problem/6674182>

The SPAW editor's JavaScript assumes that toString() on a function
constructed with the Function constructor produces a function with
a newline after the opening brace.

JavaScriptCore:

  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): Add a newline after the opening brace of the function's source code.

LayoutTests:

  • fast/js/function-constructor-newline-after-brace-expected.txt: Added.
  • fast/js/function-constructor-newline-after-brace.html: Added.
  • fast/js/resources/function-constructor-newline-after-brace.js: Added.
18:50 Changeset [41850] by mrowe@apple.com
  • 1 edit
    3 moves
    6 adds in trunk/LayoutTests

Fix fast/text/Geeza-Pro-vertical-metrics-adjustment.html on Leopard by moving the results in to the location
that run-webkit-tests currently looks for them.

Reviewed by Stephanie Lewis.

17:52 Changeset [41849] by ggaren@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

  • API/tests/testapi.c: (main): Add a test for this bug.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed <rdar://problem/6279213> Regular expression run-time complexity
limit too low for long inputs (21485)


Added a test for a complex regexp match that should succeed, and one
that should fail.

  • fast/js/regexp-overflow-expected.txt:
  • fast/js/resources/regexp-overflow.js:
17:44 Changeset [41848] by mrowe@apple.com
  • 3 edits
    1 copy
    1 add in trunk/LayoutTests

Update test results for changes in handling of CMYK.

Reviewed by Sam Weinig.

  • fast/canvas/resources/set-colors.js:
  • fast/canvas/set-colors-expected.txt:
  • platform/mac-leopard/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/fast/canvas/set-colors-expected.txt.
17:16 Changeset [41847] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-03-19 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)


If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
that object would never be updated.


  • page/FrameView.cpp: (WebCore::FrameView::updateWidgets): Factor the widget updating code out into this method. Return true if the update set is empty.


(WebCore::FrameView::performPostLayoutTasks):
Loop over the update set multiple times until all widgets have been updated or until we reach the cap.


  • page/FrameView.h:
17:03 Changeset [41846] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

  • API/tests/testapi.c: (main): Add a test for this bug.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.
16:45 Changeset [41845] by timothy@apple.com
  • 6 edits
    2 adds in trunk

Make the defered data loading timer honor the Page's scheduled runloop pairs.
Introduces a new RunLoopTimer class that has an API mimicking Timer but
allows it to be scheduled with one or more SchedulePairs.

<rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef. (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on Mac platforms also schedule with the Page's SchedulePairs. (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer(). (WebCore::MainResourceLoader::setDefersLoading): Ditto.
  • loader/MainResourceLoader.h:
  • platform/cf/RunLoopTimerCF.cpp: Added. (WebCore::RunLoopTimerBase::~RunLoopTimerBase): (WebCore::timerFired): (WebCore::RunLoopTimerBase::start): (WebCore::RunLoopTimerBase::schedule): (WebCore::RunLoopTimerBase::stop): (WebCore::RunLoopTimerBase::isActive):
  • platform/RunLoopTimer.h: Added. (WebCore::RunLoopTimerBase::RunLoopTimerBase): (WebCore::RunLoopTimerBase::startRepeating): (WebCore::RunLoopTimerBase::startOneShot): (WebCore::RunLoopTimer::RunLoopTimer): (WebCore::RunLoopTimer::fired):
14:08 Changeset [41844] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-03-19 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

Make determinePassedArchitecture always consume the --32-bit
option, also in non-AppleMacWebkit platforms. Solution pointed out
by Mark Rowe.

  • Scripts/webkitdirs.pm:
13:47 Changeset [41843] by hyatt@apple.com
  • 1 add in trunk/WebKitSite/blog-files/scrollbarpicture.png

Adding scrollbar images for blog post.

13:32 Changeset [41842] by ggaren@apple.com
  • 7 edits in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)


Bumped the pattern size limit to 1MB, and standardized it between PCRE
and WREC. (Empirical testing says that we can easily compile a 1MB regular
expression without risking a hang. Other browsers support bigger regular
expressions, but also hang.)


SunSpider reports no change.


I started with a patch posted to Bugzilla by Erik Corry (erikcorry@google.com).


  • pcre/pcre_internal.h: (put3ByteValue): (get3ByteValue): (put3ByteValueAndAdvance): (putLinkValueAllowZero): (getLinkValueAllowZero): Made PCRE's "LINK_SIZE" (the number of bytes used to record jumps between bytecodes) 3, to accomodate larger potential jumps. Bumped PCRE's "MAX_PATTERN_SIZE" to 1MB. (Technically, at this LINK_SIZE, we can support even larger patterns, but we risk a hang during compilation, and it's not clear that such large patterns are important on the web.)
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Match PCRE's maximum pattern size, to avoid quirks between platforms.

LayoutTests:

2009-03-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Made two layout tests less agressive, to accomodate a change I made
for <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)

  • fast/js/regexp-charclass-crash-expected.txt:
  • fast/js/regexp-charclass-crash.html: Explicitly limit the number of iterations in the test loop. Otherwise, regular expression engines supporting very long patterns take a very very very long time to run this test.
  • fast/js/resources/regexp-overflow.js: Made the "too big" regexp in this test even bigger, to match our new limit.
12:56 Changeset [41841] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-03-19 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24702
Upstream miscellaneous bindings changes.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
  • bindings/v8/ScriptCallStack.h: Added an extra include.
12:14 Changeset [41840] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-03-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24686

When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
we need to compare the computed z-offset with the depth-test z-offset before
deciding that such a RenderLayer was hit. This fixes an issue, tested by the
3d-point-mapping-overlapping.html test, where the child of a transformed element
is found by hit testing, even when some other element with greater Z overlaps
them both.

Improved the code by adding a utility method, isHitCandidate(), which computes and tests
z-depth when necessary.

Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html

transforms/3d/point-mapping/3d-point-mapping-overlapping.html

  • rendering/RenderLayer.cpp: (WebCore::isHitCandidate): (WebCore::RenderLayer::hitTestLayer):
09:43 Changeset [41839] by dglazkov@chromium.org
  • 2 edits
    1 add in trunk/WebCore

2009-03-19 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24456
Split ColorChromium.cpp into Mac & Windows variants.
Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
ultimately need to take a different approach. For now, createCGColor()
is copied from ColorMac.mm.

No observable change in behavior, so no test.

  • platform/graphics/chromium/ColorChromium.cpp: (WebCore::focusRingColor):
  • platform/graphics/chromium/ColorChromiumMac.mm: Added.
09:36 Changeset [41838] by dglazkov@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix WebCore/ChangeLog entry, add missing reviewer line.

09:35 Changeset [41837] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2009-03-19 Scott Violet <sky@google.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24678
Transitions tests somewhat flakey on Chromium.

Modifies transitions/transition-end-event-helpers.js to only process
results once.

  • transitions/transition-end-event-helpers.js:
09:29 Changeset [41836] by dglazkov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-03-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24675
Unforking frontend: add custom InspectorController methods
implementation.

  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.
09:26 Changeset [41835] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-03-19 Jay Campan <jcampan@google.com>

https://bugs.webkit.org/show_bug.cgi?id=24625
Adding an accessor to the currently selected index in the PopupMenuChromium.
This is required for implementing the deletion of an autocomplete entry in Chromium.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::selectedIndex):
  • platform/chromium/PopupMenuChromium.h:
09:09 Changeset [41834] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-19 Evan Stade <estade@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24526
Improve windows skia text stroking.

Test: LayoutTests/svg/custom/struct-use-09-b.svg

  • platform/graphics/skia/SkiaFontWin.cpp: Close the path representing each font glyph polygon, rather than only closing the path once per letter. This fixes stroking for letters with multiple polygons, such as 'A' or 'D'. (WebCore::getPathForGlyph): (WebCore::skiaDrawText):
09:06 Changeset [41833] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Oops, bail out last patch, that was incorrect.

08:59 Changeset [41832] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-03-19 Laurent Montel <montel@kde.org>

Reviewed by Simon Hausmann.

Another fix for pedantic compilation in QtWebKit

(patch from qt-copy)

08:16 Changeset [41831] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-03-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Fixes pedantic compilation in QtWebKit.

There are no semi-colons after namespace declarations.

08:16 Changeset [41830] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-19 David Boddie <dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Removed obsolete warning about Flash and other plugins.

08:16 Changeset [41829] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-19 Paul Olav Tvete <paul.tvete@nokia.com>

Reviewed by Simon Hausmann.

Properly escape tooltip text

ManualTest: http://xkcd.com/554/

08:08 Changeset [41828] by hausmann@webkit.org
  • 6 edits in trunk/WebCore

2009-03-19 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.

Removed dead code for distinguishing between Widget and PluginView in the Qt port.

01:06 Changeset [41827] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Work around <rdar://problem/6698023> by activating fonts from disk.

Reviewed by Oliver Hunt.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources

in the built products directory.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate the fonts from disk.

00:55 Changeset [41826] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2009-03-19 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
<https://bugs.webkit.org/show_bug.cgi?id=24596>
<rdar://problem/6686493>

JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
set twice, once to the value that is illegal to access, and then to undefined
This causes an assertion failure in property access caching code.

The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().

WebCore:

  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):

LayoutTests:

  • http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt: Added.
  • http/tests/security/cross-frame-access-get-custom-property-cached.html: Added.
  • http/tests/security/resources/cross-frame-access-get-custom-property-cached-iframe.html: Added.
  • http/tests/security/resources/cross-frame-access.js: (shouldBeUndefined):
00:32 Changeset [41825] by ap@webkit.org
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24676
Simple cross-origin requests shouldn't dispatch upload progress events

Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment explaining the somewhat unexpected behavior of this function.
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
  • xml/XMLHttpRequestUpload.h: Report whether there are any event listeners registered.
  • xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto. (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be non-empty for POST requests. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto. (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed. (WebCore::XMLHttpRequest::networkError): Ditto. (WebCore::XMLHttpRequest::abortError): Ditto. (WebCore::XMLHttpRequest::didSendData): Ditto.

03/18/09:

23:18 Changeset [41824] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-18 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24398
Fix a crash when loading a svg file in Chromium's test_shell and
then reloading the page.

  • history/BackForwardListChromium.cpp: (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::close):
23:04 BuildingGtk edited by arthur.webkid@gmail.com
WebKitGTK doesn't depend on curl anymore. (diff)
21:42 Changeset [41823] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Rolling out r41818 since it broke the windows build.
Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
18:54 Changeset [41822] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/netscape-throw-exception.html due to <rdar://problem/6530010>.

Reviewed by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
18:29 Changeset [41821] by mrowe@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disable pluginDocumentView-deallocated-dataSource.html as it has not tested
what it was designed to test for some time, and is failing on some machines.
Fixing the test is tracked by <https://bugs.webkit.org/show_bug.cgi?id=24690>.

Rubber-stamped by Dan Bernstein.

  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html.
17:57 Changeset [41820] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

WebKit side of <rdar://problem/6688244>.


Try reinitializing the vendor port if it's invalid.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
17:49 Changeset [41819] by mrowe@apple.com
  • 8 edits in trunk

<rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results

Reviewed by Dan Bernstein.

Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(log): Invoke console.log via the NPAPI.
(NPP_Destroy): Call log instead of printf.
(NPP_SetWindow): Ditto.
(handleEventCarbon): Ditto.
(handleEventCocoa): Ditto.
(NPP_HandleEvent): Pass the instance in to the event handler.

Update test results for change to address <rdar://problem/6693300>.

  • plugins/mouse-events-expected.txt:
  • plugins/netscape-destroy-plugin-script-objects-expected.txt:
  • plugins/netscape-plugin-setwindow-size-2-expected.txt:
  • plugins/netscape-plugin-setwindow-size-expected.txt:
  • plugins/open-and-close-window-with-plugin-expected.txt:
16:21 Changeset [41818] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-03-18 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24674
Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations

Make sure strftime never returns 2-digits years to avoid ambiguity and
a crash.

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
16:09 Changeset [41817] by sfalken@apple.com
  • 4 edits in trunk/WebKit/win

Add webViewClosing to private UI delegate.

Reviewed by Adam Roben.

  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::close):
13:41 Changeset [41816] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-18 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6685235>
<video> element poster cannot be set dynamically if not originally set up in HTML


Allocate the media engine immediately so the plug-in proxy is available for
scripting right away.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
13:33 Changeset [41815] by bdakin@apple.com
  • 3 edits in trunk/LayoutTests

2009-03-18 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Dan Bernstein.

Updating test to reflect our joy.

  • fast/dom/offset-parent-positioned-and-inline-expected.txt:
  • fast/dom/offset-parent-positioned-and-inline.html:
13:30 Changeset [41814] by bdakin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-18 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/

This was a regression from http://trac.webkit.org/changeset/40769,
which changed the base class of RenderInline to
RenderBoxModelObject rather than RenderBox.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent): offsetParent should return a RenderBoxModelObject rather than just a RenderBox, which is more restrictive.

LayoutTests:

2009-03-18 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at http://
www.signonsandiego.com/

  • fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
  • fast/dom/offset-parent-positioned-and-inline.html: Added.
13:15 Changeset [41813] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...

Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit/mac:

2009-03-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...


If the m_pluginView member was zeroed out as a result of making a call into the plug-in, the pluginFunctionCallDepth would be off
causing the plug-in never to be stopped. Simplify the code by using a RAII object.

  • Plugins/WebBaseNetscapePluginStream.mm: (PluginStopDeferrer::PluginStopDeferrer): (PluginStopDeferrer::~PluginStopDeferrer): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::wantsAllStreams): (WebNetscapePluginStream::destroyStream):
13:08 Changeset [41812] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-03-18 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24664
Upstreaming v8 collection.h

No change in behavior, so no test.

  • bindings/v8/V8Collection.h: Added.
13:02 Changeset [41811] by weinig@apple.com
  • 5 edits in trunk

WebCore:

2009-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

Match the CSSOM spec for getClientRects and getBoundingClientRect by
returning a 0x0 rect at the correct top/left position for empty inline
boxes.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):

LayoutTests:

2009-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Simon Fraser.

Update test results for https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

  • fast/dom/getBoundingClientRect-expected.txt:
  • fast/dom/getClientRects-expected.txt:
11:02 Changeset [41810] by ap@webkit.org
  • 1 edit
    20 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24670
Add tests for XHR progress events during cross-origin requests.

  • http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-2.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events.html: Added.
10:41 Changeset [41809] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-18 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Match the changes done for windows in the bug
https://bugs.webkit.org/show_bug.cgi?id=24530.

No change in behavior, so no test.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
08:58 Changeset [41808] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-18 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther.

Added support for SVG's stroked texts to Qt.

[Qt] SVGs stroked text support missing
https://bugs.webkit.org/show_bug.cgi?id=24262

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
01:15 Changeset [41807] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix fast/encoding/char-decoding.html with recent ICU.

Reviewed by Alexey Proskuryakov.

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
as newer versions of ICU use GB18030 as the canonical name.

00:24 Changeset [41806] by oliver@apple.com
  • 6 edits
    1 add in trunk

<rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
<https://bugs.webkit.org/show_bug.cgi?id=24654>

Reviewed by Cameron Zwarich.

If the return value for a function is in a local register we need
to copy it before executing any finalisers, otherwise it is possible
for the finaliser to clobber the result.

03/17/09:

23:00 Changeset [41805] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-17 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24662
Chromium build fixes.

Bug https://bugs.webkit.org/show_bug.cgi?id=24663 tracks
the invalid implementation of ScriptCallStack.

No change in behavior, so no test.

  • bindings/v8/ScriptCallStack.h: (WebCore::ScriptCallStack::state):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect):
22:14 Changeset [41804] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Use the normal search rules for tests inside the platform directory.

Reviewed by Oliver Hunt.

This allows tests inside the platform directory to have different results
on different versions of Mac OS X.

  • Scripts/run-webkit-tests:
21:58 Changeset [41803] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

Update layout test to avoid depending on formatting of -[NSAttributedString description].

Rubber-stamped by Dan Bernstein.

The attributes aren't important to the test.

  • platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
  • platform/mac/fast/text/attributed-substring-from-range-001.html:
21:34 Changeset [41802] by mrowe@apple.com
  • 6 edits
    5 copies
    10 moves
    1 add in trunk/LayoutTests

Land updated results for tests involving Geeza Pro.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum.
  • platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png.
  • platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
  • platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
20:54 Changeset [41801] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/LayoutTests

Move the results out of platform/mac since they're a cross-platform progression,
and non-Mac platforms are already skipping the tests.

Rubber-stamped by Dan Bernstein.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
20:54 Changeset [41800] by mrowe@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

Update layout test results now that the test passes.

Rubber-stamped by Sam Weinig.

  • fast/xsl/mozilla-tests-expected.txt:
  • platform/mac-leopard/fast/xsl/mozilla-tests-expected.txt: Copied from LayoutTests/fast/xsl/mozilla-tests-expected.txt.
19:53 Changeset [41799] by mrowe@apple.com
  • 1 edit
    4 copies
    1 add in trunk/LayoutTests

Add platform-specific layout test results to accommodate geolocation.

Reviewed by Sam Weinig.

  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
  • platform/mac/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
19:53 Changeset [41798] by mrowe@apple.com
  • 2 edits
    1 delete in trunk/LayoutTests

Remove geolocation-not-implemented.html.

Reviewed by Sam Weinig.

  • geolocation/geolocation-not-implemented-expected.txt: Removed.
  • geolocation/geolocation-not-implemented.html: Removed.
  • geolocation/geolocation-test.js: Removed.
  • platform/gtk/Skipped:
19:53 Changeset [41797] by mrowe@apple.com
  • 3 edits
    2 copies
    4 moves
    3 adds in trunk/LayoutTests

Update layout test results to accommodate the updated Unicode text segmentation rules.

Rubber-stamped by Sam Weinig.

  • platform/mac-leopard/css1/text_properties/text_transform-expected.checksum: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.checksum.
  • platform/mac-leopard/css1/text_properties/text_transform-expected.png: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.png.
  • platform/mac-leopard/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.txt.
  • platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum.
  • platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.png.
  • platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt.
  • platform/mac/css1/text_properties/text_transform-expected.txt:
  • platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt:
17:58 Changeset [41796] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

2009-03-17 David Carson <dacarson@apple.com>

Reviewed by David Hyatt.

Add anchor elements to the simple style sheet so that applications that
are using WebKit just for simple text and links will also take advantage
of the fast path.

  • css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle):
17:54 Changeset [41795] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

resolve-ChangeLogs should not die on unmerged non-ChangeLog files

Reviewed by Adam Roben.

Fixes the following bug in resolve-ChangeLogs:

Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.

  • Scripts/resolve-ChangeLogs: (findUnmergedChangeLogs): Check the result of findChangeLog() to make sure we don't add undef values to the list of files being returned.
17:42 Changeset [41794] by darin@apple.com
  • 5 edits in trunk

WebCore:

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6687005> Need support for new move-left/right selectors.

  • editing/EditorCommand.cpp: (WebCore::executeMoveToLeftEndOfLine): Added. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added. (WebCore::executeMoveToRightEndOfLine): Added. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added. Added command entries for the functions above.

WebKit/mac:

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6687005> Need support for new move-left/right selectors.

  • WebView/WebHTMLView.mm: Added the four new selectors to the command-forwarding list.
  • WebView/WebView.mm: Ditto.
17:06 Changeset [41793] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 24477: REGRESSION (r41467): Page Down key scrolls two pages
https://bugs.webkit.org/show_bug.cgi?id=24477
rdar://problem/6674184

  • WebView/WebHTMLView.mm: (responderChainRespondsToSelector): Added. (-[WebHTMLView doCommandBySelector:]): Set eventWasHandled based on whether we can find a responder that responds to this selector rather than always assuming the selector will not be handled.
16:44 Changeset [41792] by eric@webkit.org
  • 77 edits
    3 adds in trunk

2009-03-17 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Put the padding inside scrollbars on textareas.
https://bugs.webkit.org/show_bug.cgi?id=24370

Put the padding inside the scrollbars on textareas. This is done by moving the
overflow from the shadowNode to the RenderTextControlMultiline. As a result,
all of the scroll handing methods that RenderTextControl overrides can be moved
down into RenderTextControlSingleLine since RenderTextControlMultiline can now
just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
no longer need a custom layout method since the shadowNode can now just size
like a regular DIV.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange): (WebCore::RenderTextControl::selection): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextElement):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint): (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::autoscroll): (WebCore::RenderTextControlSingleLine::scrollWidth): (WebCore::RenderTextControlSingleLine::scrollHeight): (WebCore::RenderTextControlSingleLine::scrollLeft): (WebCore::RenderTextControlSingleLine::scrollTop): (WebCore::RenderTextControlSingleLine::setScrollLeft): (WebCore::RenderTextControlSingleLine::setScrollTop): (WebCore::RenderTextControlSingleLine::scroll):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): (WebCore::RenderTextControlInnerBlock::positionForPoint): (WebCore::TextControlInnerTextElement::createRenderer):
16:34 Changeset [41791] by darin@apple.com
  • 5 edits in trunk/WebCore

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by David Hyatt.

Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
https://bugs.webkit.org/show_bug.cgi?id=24517

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since determining whether to display the delete button involves style and updateRendering also updates style (should probably be named updateStyle, in fact). Not needed to fix this bug, but would have prevented the crash that led to this bug in the first place.
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have delete button controllers.
  • editing/Editor.cpp: (WebCore::Editor::rangeForPoint): Ditto.
  • editing/markup.cpp: (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup doesn't depend on renderers at all when the convertBlocksToInlines boolean is false. This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the createMarkup function that's called by innerHTML. (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member function. Added a feature where the accumulator will skip a node. Moved arguments that don't change during recursion into an object. This function still is a bit inefficient, since it creates a new HashMap at every level as it recurses, but for now I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly for consistency and clarity. (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets. Instead of calling disable/enable on the delete button controller's container element, pass it in to the markup accumulator as a node to skip.
15:24 Changeset [41790] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-03-17 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Simon Fraser.

Fix the usage of the $architecture variable for non-Apple-Mac
ports.

  • Scripts/webkitdirs.pm:
15:17 Changeset [41789] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-03-17 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24651
Skia does not always render text fill/stroke pattern/gradient/color correctly

Changes Skia's font rendering to only render gradient/pattern if current
color space indicates the gradient/pattern should be used.
This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::strokeColorSpace): (WebCore::GraphicsContext::fillColorSpace):
  • platform/graphics/GraphicsContext.h: (WebCore::):
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText):
15:05 Changeset [41788] by adele@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2009-03-17 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
<rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

Test: editing/inserting/6633727.html

This changes does a few things:
1) Renames pos to insertionPosition.
2) Eliminates "startNode". It doesn't work well to consider the node separately from the insertionPosition.

The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.

3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest

representation of the insertionPosition, so all ancestor nodes are correctly included.

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-03-17 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=24655
<rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

  • editing/inserting/6633727.html: Added.
  • platform/mac/editing/inserting/6633727-expected.checksum: Added.
  • platform/mac/editing/inserting/6633727-expected.png: Added.
  • platform/mac/editing/inserting/6633727-expected.txt: Added.

Updated results. The behavior for these tests doesn't change, but the render tree is slightly different.

  • platform/mac/editing/inserting/insert-div-021-expected.txt:
  • platform/mac/editing/style/block-styles-007-expected.txt:
14:48 Changeset [41787] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the build.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:
13:16 Changeset [41786] by kevino@webkit.org
  • 2 edits
    3 adds
    3 deletes in trunk/WebCore

Reviewed by Kevin Ollivier.

https://bugs.webkit.org/show_bug.cgi?id=24115
Introduce platform independent stubs for plugins.

13:14 Changeset [41785] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)

<https://bugs.webkit.org/show_bug.cgi?id=24645>

Reviewed by Mark Rowe.

  • Scripts/bisect-builds: (makeNightlyList): Added checks for Safari 4 Public Beta on Tiger and Leopard.
13:13 Changeset [41784] by ddkilzer@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fixed ChangeLog date.

13:09 Changeset [41783] by ddkilzer@apple.com
  • 8 edits in trunk/WebKit/mac

Use -[NSURLResponse(WebCoreURLResponse) _webcore_MIMEType] consistently

Reviewed by Darin Adler.

WebKit r30323 added -_webcore_MIMEType to fix issues with
incorrect MIME types in NS[HTTP]URLResponse objects. However,
uses of -[NSURLResponse MIMEType] still persist in WebKit that
should be switched to use -_webcore_MIMEType. Note that
-[WebDataSource _responseMIMEType] calls back into WebCore to
get the MIME type from the ResourceResponse object, which has
already retrieved it via -_webcore_MIMEType.

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse): Use -_webcore_MIMEType.
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse): Ditto.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]): Ditto.
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Ditto.
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation _isDisplayingWebArchive]): Use -[WebDataSource _responseMIMEType] instead.
  • WebView/WebPDFRepresentation.m: (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Ditto.
  • WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto.
13:01 Changeset [41782] by simon.fraser@apple.com
  • 8 edits in trunk/WebCore

2009-03-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24632

Fix repaint issues when composited layers come and go (only applies
when ACCELERATED_COMPOSITING is turned on).

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::mustOverlayCompositedLayers): (WebCore::RenderLayer::setMustOverlayCompositedLayers):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking):
  • rendering/RenderLayerBacking.h:

Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
when setting this flag.

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateLayerCompositingState): When a RenderLayer flips into or out of compositing mode, compute a repaint rect relative to the containerForRepaint, and repaint it.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().

(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

  • rendering/RenderLayerCompositor.h:

Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
and make it a class static method to match requiresCompositingForAnimation(). Both
now take RenderObjects, rathern than RenderLayers.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::hasTransformRelatedProperty): Minor tidyup using convenience methods added in an earlier commit.
12:42 Changeset [41781] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-17 Darin Adler <darin@apple.com>

Earlier version reviewed by Adele Peterson.

Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
or push an <input type=button> or <button> causes the page to scroll down.

Would be best to add a regression test for Windows eventually; tested that this has
no effect on the Mac OS X platform.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting. Use the code that calls the base class's defaultEventHandler early only in the cases where it's needed: keydown and keypress events in text fields. In other cases, do the more typical thing and call the default handler only at the end of the function. This function already had code to make sure the keypress event for space never gets through, but it was running too late since the scrolling code was moved into the base class default event handler.
12:24 Changeset [41780] by simon.fraser@apple.com
  • 18 edits in trunk

2009-03-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24396

  • config.h: Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some comments to make the #ifdefs more readable.
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform): Add a comment to mention that we don't flatten the matrix.
  • css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval): Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering is supported.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform): No need for the #ifdef here. If we don't support 3d, we will have already flattened the matrix.
  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::makeAffine):
  • platform/graphics/transforms/TransformationMatrix.h: New method to convert the matrix to an affine matrix by throwing a way the non-affine parts.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform): If 3d rendering is not supported, convert the matrix to an affine matrix which can be rendered, and used for hit testing.
  • rendering/RenderLayerCompositor.cpp: Change the name of the exported symbol that webkitdirs.pm uses to know if 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer): Only take perspective into account if 3d rendering is supported.
  • rendering/RenderObject.h: (WebCore::makeMatrixRenderable): Utility method that flattens a matrix if 3d rendering is not supported.
12:22 Changeset [41779] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Fix typo after mouse wheel changes.

11:57 Changeset [41778] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/repaint/subtree-root-clip-expected.txt

Update failing layout test after float painting fix.

11:26 Changeset [41777] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-17 Darin Adler <darin@apple.com>

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual): Fix build, remove stray parenthesis.
11:22 Changeset [41776] by kov@webkit.org
  • 4 edits in trunk

2009-03-17 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

Enable HTML5 media elements support by default in the GTK+ port.

  • configure.ac:

WebKitTools:

2009-03-17 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

Enable HTML5 media elements support by default also for the GTK+
port.

  • Scripts/build-webkit:
11:16 Changeset [41775] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-17 Darin Adler <darin@apple.com>

Fix crash seen right away when running run-webkit-tests.

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual): Restore assertion to its behavior pre-refactoring. Also tweaked formatting a bit.
11:06 Changeset [41774] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

HTMLSelectElement::add() doesn't look at exception code returned from insertBefore(), so
it doesn't need to zero it out before calling.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): Removed "ec = 0" line.
11:01 Changeset [41773] by mitz@apple.com
  • 14 edits
    2 adds in trunk

WebCore:

Reviewed by Adam Roben.

  • WebCore part of adding a mechanism for controlling the caching of responses through WebFrameLoaderClient

Mac already has such a mechanism, and this adds one for CFNetwork ports.

  • WebCore.vcproj/WebCore.vcproj: Added EmptyClients.h and ResourceLoaderCFNet.cpp.
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::shouldCacheResponse): Added an implementation that always returns true.
  • loader/FrameLoaderClient.h: Declared shouldCacheResponse().
  • loader/ResourceLoader.h: Ditto.
  • loader/cf/ResourceLoaderCFNet.cpp: Added. (WebCore::ResourceLoader::shouldCacheResponse): Added. Calls through to FrameLoaderClient::shouldCacheResponse().
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::shouldCacheResponse): Added an implementation that always returns true.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Added a call to ResourceHandleClient::shouldCacheResponse(). If the client returns false, return 0, which will prevent CFNetwork from caching the response.

WebKit/win:

Reviewed by Adam Roben.

  • WebKit part of adding a mechanism for controlling the caching of responses through WebFrameLoaderClient
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the IWebResourceLoadDelegatePrivate3 interface, containing the new delegate method shouldCacheResponse().
  • Interfaces/IWebURLRequest.idl: Added the isEqual() method.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldCacheResponse): Implemented this new FrameLoaderDelegate method by calling through to the resource load delegate, if it implements shouldCacheResponse(), and returning true otherwise.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::isEqual): Added. (WebMutableURLRequest::setValue): Implemented.
  • WebMutableURLRequest.h: Declared isEqual().
10:57 Changeset [41772] by ap@webkit.org
  • 7 edits
    8 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=13287
Cannot change SELECT to a dynamically created option

Tests: fast/forms/add-and-remove-option.html

fast/forms/add-remove-option-modification-event.html
fast/forms/add-selected-option.html
fast/forms/select-cache-desynchronization.html

  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): Increment DOM tree version. This will happen when dispatching DOMSubtreeModified again, but the version should be incremented for event listeners to have an up to date view of the DOM. (WebCore::dispatchChildRemovalEvents): Ditto.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoTree): Make sure that the select element knows about its new selected option.
  • html/HTMLOptionElement.h: Use insertedIntoTree() instead of insertedIntoDocument(), because DOM also needs to be updated for forms that are not in document yet. Similar problems exist for node removing, but removedFromTree() is called at a wrong time, so those problems cannot be fixed without deeper refactoring.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset m_activeSelectionAnchorIndex - it doesn't make sense to keep the anchor after programmatically changing the selection, and keeping it was causing a failure in fast/forms/listbox-selection.html.
  • html/HTMLSelectElement.h: Removed overrides for ContainerNode methods that only called base class versions.
10:47 Changeset [41771] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6690324> Accessing FTP sites reads unallocated memory, can result in garbled entries or crashes


Reviewed by Darin Adler.

  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::parseAndAppendOneLine): Assign CString to a local while we hold pointers into it.
10:36 Changeset [41770] by hyatt@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog comment.

10:30 Changeset [41769] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2009-03-16 David Hyatt <hyatt@apple.com>

<rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
layers that don't paint themselves. This is done by adding a new boolean parameter to enclosingLayer
so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
themselves.

Reviewed by Darin Adler.

Added fast/block/float/overlapping-floats-with-overflow-hidden.html

  • WebCore.base.exp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addOverhangingFloats):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::enclosingSelfPaintingLayer):
  • rendering/RenderObject.h:

LayoutTests:

2009-03-16 David Hyatt <hyatt@apple.com>

<rdar://problem/6648411> REGRESSION: Layout of page is wrong at http://www.popcap.com/

Make sure that the initial shouldPaint check that looks at enclosingLayers properly skips over
layers that don't paint themselves. This is done by adding a new enclosingSelfPaintingLayer method
so that RenderObjects can walk up the enclosing layer chain and skip any layers that don't paint
themselves.

Reviewed by Darin Adler.

  • fast/block/float/overlapping-floats-with-overflow-hidden.html: Added.
  • platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.checksum: Added.
  • platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.png: Added.
  • platform/mac/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt: Added.
10:25 Changeset [41768] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-03-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Style fixes.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::operator=):
  • platform/graphics/gtk/FontPlatformDataPango.cpp:
10:24 Changeset [41767] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-03-17 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Sanitize memory management in pango fonts.

Release memory allocated by FontPlatformDataPango in its own
destructor instead of doing it from other classes, and add copy
constructor and '=' operator to be able to track referenced
objects properly.

  • platform/graphics/gtk/FontPlatformDataPango.cpp: (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::FontPlatformData):
  • platform/graphics/gtk/SimpleFontDataPango.cpp:
10:02 Changeset [41766] by darin@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
seen with inspector, which uses adoptNode
https://bugs.webkit.org/show_bug.cgi?id=24624
rdar://problem/6422850

Test: fast/dom/HTMLImageElement/image-load-cross-document.html

  • dom/Document.cpp: (WebCore::Document::Document): Removed m_imageLoadEventTimer. (WebCore::Document::detach): Removed m_imageLoadEventDispatchSoonList and m_imageLoadEventDispatchingList. (WebCore::Document::implicitClose): Called ImageLoader::dispatchPendingLoadEvents instead of dispatchImageLoadEventsNow.
  • dom/Document.h: Removed ImageLoader, dispatchImageLoadEventSoon, dispatchImageLoadEventsNow, removeImage, m_imageLoadEventDispatchSoonList, m_imageLoadEventDispatchingList, m_imageLoadEventTimer, and imageLoadEventTimerFired.
  • loader/ImageLoader.cpp: (WebCore::loadEventSender): Added. Returns the single global ImageLoadEventSender object used privately as the target of the load event timer. (WebCore::ImageLoader::~ImageLoader): Call ImageLoadEventSender::cancelLoadEvent rather than Document::removeImage. (WebCore::ImageLoader::setImage): Use m_element directly, not element(). (WebCore::ImageLoader::updateFromElement): Ditto. Also name the local variable document instead of doc. (WebCore::ImageLoader::notifyFinished): Call ImageLoadEventSender::dispatchLoadEventSoon rather than Document::dispatchImageLoadEventSoon. (WebCore::ImageLoader::dispatchPendingLoadEvent): Added. Handles the common logic about when load events can be dispatched so that dispatchLoadEvent only has to have the specific part for each derived class. This includes a check that the document is attached, which used to be handled by having documents empty out the image load event vectors in the detach function. (WebCore::ImageLoader::dispatchPendingLoadEvents): Added. Calls the appropriate function on the ImageLoadEventSender, which avoids the need to have that class be public in the ImageLoader header. (WebCore::ImageLoadEventSender::ImageLoadEventSender): Added. Has the code that was previously in the Document constructor. (WebCore::ImageLoadEventSender::dispatchLoadEventSoon): Added. Has the code that was previously in Document::dispatchImageLoadEventSoon. (WebCore::ImageLoadEventSender::cancelLoadEvent): Added. Has the code that was previously in Document::removeImage. (WebCore::ImageLoadEventSender::dispatchPendingLoadEvents): Added. Has the code that was previously in Document::dispatchImageLoadEventsNow. (WebCore::ImageLoadEventSender::timerFired): Added. Calls dispatchPendingLoadEvents.
  • loader/ImageLoader.h: Improved comments. Made the virtual functions private or protected rather than public. Added static dispatchPendingLoadEvents function for use by Document and private dispatchPendingLoadEvent function for use by ImageLoadEventSender. Made setLoadingImage private and eliminated setHaveFiredLoadEvent since that can all be done inside the class without any member functions.
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent): Removed logic to check whether a load event already fired and whether image() is 0. These are now both base class responsibilities.
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent): Ditto.
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::dispatchLoadEvent): Ditto.

LayoutTests:

2009-03-17 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Bug 24624: Crash in imageLoadEventTimerFired after adoptNode used on <img>,
seen with inspector, which uses adoptNode
https://bugs.webkit.org/show_bug.cgi?id=24624
rdar://problem/6422850

This test has one significant disadvantage. When it fails, the crash typically
occurs during a subsequent test, not this one. It would be great if someone figured
out at some point how to improve that.

  • fast/dom/HTMLImageElement/image-load-cross-document-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-load-cross-document.html: Added.
  • fast/dom/HTMLImageElement/resources/image-load-subframe.html: Added.
09:17 Changeset [41765] by dglazkov@chromium.org
  • 11 edits in trunk/WebCore

2009-03-17 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24623
Refactor ConsoleMessage to use ScriptFuncitonCall and eliminate JSC
dependencies.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added uint and ScriptString-taking methods.
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::quarantineValue): Added generic ScriptValue quarantine helper.
  • bindings/js/ScriptObjectQuarantine.h:
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual): Added.
  • bindings/js/ScriptValue.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToConsole): Added. (WebCore::ConsoleMessage::isEqual): Changed to use ScriptValue::isEqual.
  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::incrementCount): Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addConsoleMessage): Changed to use ConsoleMessage::addToConsole. (WebCore::InspectorController::populateScriptObjects): Ditto.
  • inspector/InspectorController.h:
09:06 Changeset [41764] by kevino@webkit.org
  • 9 edits in trunk

Reviewed by Mark Rowe.

Move BUILDING_ON_* defines into Platform.h to make them available to other ports.
Also tweak the defines so that they work with the default values set by
AvailabilityMacros.h.

https://bugs.webkit.org/show_bug.cgi?id=24630

08:40 Changeset [41763] by kov@webkit.org
  • 2 edits in trunk

2009-03-17 Mike Hommey <glandium@debian.org>

Reviewed by Holger Freyther.

Do not export cti* symbols.
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=519924.

  • autotools/symbols.filter:
07:43 Changeset [41762] by xan@webkit.org
  • 4 edits in trunk/WebCore

2009-03-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24592
[GTK] Crash in FcPatternHash

Sanitize memory management in gtk fonts.

Release memory allocated by FontPlatformDataGtk in its own
destructor instead of doing it from other classes, and add copy
constructor and '=' operator to be able to track referenced
objects properly.

  • platform/graphics/gtk/FontPlatformData.h:
  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformDestroy):
06:22 Changeset [41761] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-03-17 Ariya Hidayat <ariya.hidayat@nokia.com>

Build fix for Qt < 4.5.

As reported by Yael Aharon <yael.aharon@nokia.com>

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLine):
05:08 QtWebKitTodo edited by ariya@webkit.org
(diff)
02:15 Changeset [41760] by oliver@apple.com
  • 3 edits in trunk/WebKitTools

Fix coverage builds

Reviewed by Alexey Proskuryakov

Make coverage testing more reliable by ensuring --coverage does not
clobber configuration settings, and by removing the unnecessary
dependency on matplotlib.

00:29 Changeset [41759] by ap@webkit.org
  • 8 edits
    2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24614
Access control checks are different in cached and uncached cases

Test: http/tests/xmlhttprequest/access-control-basic-non-simple-deny-cached.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestMethodWhitelist): Factored out simple method check for use in both cached and uncached cases. In cached case, an old definition that omitted HEAD was still used. (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Check that content type has an allowed value. This is needed in all call sites. Also changed to compare MIME type, not content type. (WebCore::isSimpleCrossOriginAccessRequest): Use the above methods.
  • loader/CrossOriginAccessControl.h: Expose isOnAccessControlSimpleRequestMethodWhitelist.
  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod): (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders): Use the new checks for simple method and header.
00:23 Changeset [41758] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-16 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Remove the blacklisting of the media/ directory, now that we have
a working MediaPlayer; skip only the tests that are still failing
because MediaPlayerPrivateGStreamer is not completely implemented.

  • platform/gtk/Skipped:
00:11 Changeset [41757] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Add a repaint-requested signal to the video sink, and use it to
call MediaPlayerPrivate::repaint, so that the video actually
plays.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateRepaintCallback): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
  • platform/graphics/gtk/VideoSinkGStreamer.cpp: (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_class_init):
00:02 Changeset [41756] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-16 Gustavo Noronha Silva <gns@gnome.org> and Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24638
[GTK] HTML5 media tags do not work

Work-around the fact that gst_element_query_duration returns true even
though it is unable to figure out the duration when in stream (push)
mode.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::duration):

03/16/09:

18:26 Changeset [41755] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip media tests that are currently failing.

Rubber-stamped by Adele Peterson.

  • platform/mac-snowleopard/Skipped:
17:10 Changeset [41754] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6642742> Top Sites malfunction when switching text zoom mode

  • page/Frame.cpp: (WebCore::Frame::setNeedsReapplyStyles): Don’t do anything if the frame is currently showing a non-HTML view.
16:55 Changeset [41753] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is currently crashing.

Rubber-stamped by Beth Dakin.

  • platform/mac-snowleopard/Skipped:
16:55 Changeset [41752] by mrowe@apple.com
  • 7 edits in trunk/LayoutTests

Update test results for six accessibility tests.

Rubber-stamped by Beth Dakin.

  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
  • platform/mac/accessibility/table-with-rules-expected.txt:
16:55 Changeset [41751] by mrowe@apple.com
  • 1 edit
    1 copy
    37 moves
    1 add in trunk/LayoutTests

Move platform-specific acessibility tests and results into platform/mac.

Rubber-stamped by Beth Dakin.

  • platform/mac/accessibility/accesskey-expected.txt: Renamed from LayoutTests/accessibility/accesskey-expected.txt.
  • platform/mac/accessibility/accesskey.html: Renamed from LayoutTests/accessibility/accesskey.html.
  • platform/mac/accessibility/aria-describedby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-describedby-on-input-expected.txt.
  • platform/mac/accessibility/aria-labelledby-on-input-expected.txt: Renamed from LayoutTests/accessibility/aria-labelledby-on-input-expected.txt.
  • platform/mac/accessibility/aria-range-expected.txt: Renamed from LayoutTests/accessibility/aria-range-expected.txt.
  • platform/mac/accessibility/aria-range-value-expected.txt: Renamed from LayoutTests/accessibility/aria-range-value-expected.txt.
  • platform/mac/accessibility/aria-range-value.html: Renamed from LayoutTests/accessibility/aria-range-value.html.
  • platform/mac/accessibility/aria-range.html: Renamed from LayoutTests/accessibility/aria-range.html.
  • platform/mac/accessibility/aria-roles-expected.txt: Renamed from LayoutTests/accessibility/aria-roles-expected.txt.
  • platform/mac/accessibility/aria-slider-expected.txt: Renamed from LayoutTests/accessibility/aria-slider-expected.txt.
  • platform/mac/accessibility/aria-slider.html: Renamed from LayoutTests/accessibility/aria-slider.html.
  • platform/mac/accessibility/aria-spinbutton-expected.txt: Renamed from LayoutTests/accessibility/aria-spinbutton-expected.txt.
  • platform/mac/accessibility/aria-spinbutton.html: Renamed from LayoutTests/accessibility/aria-spinbutton.html.
  • platform/mac/accessibility/bounds-for-range-expected.txt: Renamed from LayoutTests/accessibility/bounds-for-range-expected.txt.
  • platform/mac/accessibility/bounds-for-range.html: Renamed from LayoutTests/accessibility/bounds-for-range.html.
  • platform/mac/accessibility/content-editable-expected.txt: Renamed from LayoutTests/accessibility/content-editable-expected.txt.
  • platform/mac/accessibility/content-editable.html: Renamed from LayoutTests/accessibility/content-editable.html.
  • platform/mac/accessibility/document-attributes-expected.txt: Renamed from LayoutTests/accessibility/document-attributes-expected.txt.
  • platform/mac/accessibility/document-attributes.html: Renamed from LayoutTests/accessibility/document-attributes.html.
  • platform/mac/accessibility/document-links-expected.txt: Renamed from LayoutTests/accessibility/document-links-expected.txt.
  • platform/mac/accessibility/document-links.html: Renamed from LayoutTests/accessibility/document-links.html.
  • platform/mac/accessibility/double-title-expected.txt: Renamed from LayoutTests/accessibility/double-title-expected.txt.
  • platform/mac/accessibility/double-title.html: Renamed from LayoutTests/accessibility/double-title.html.
  • platform/mac/accessibility/frame-with-title-expected.txt: Renamed from LayoutTests/accessibility/frame-with-title-expected.txt.
  • platform/mac/accessibility/frame-with-title.html: Renamed from LayoutTests/accessibility/frame-with-title.html.
  • platform/mac/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/image-map1-expected.txt.
  • platform/mac/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/image-map2-expected.txt.
  • platform/mac/accessibility/input-image-url-expected.txt: Renamed from LayoutTests/accessibility/input-image-url-expected.txt.
  • platform/mac/accessibility/input-image-url.html: Renamed from LayoutTests/accessibility/input-image-url.html.
  • platform/mac/accessibility/internal-link-anchors-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors-expected.txt.
  • platform/mac/accessibility/internal-link-anchors.html: Renamed from LayoutTests/accessibility/internal-link-anchors.html.
  • platform/mac/accessibility/internal-link-anchors2-expected.txt: Renamed from LayoutTests/accessibility/internal-link-anchors2-expected.txt.
  • platform/mac/accessibility/legend-expected.txt: Renamed from LayoutTests/accessibility/legend-expected.txt.
  • platform/mac/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/plugin-expected.txt.
  • platform/mac/accessibility/radio-button-group-members-expected.txt: Renamed from LayoutTests/accessibility/radio-button-group-members-expected.txt.
  • platform/mac/accessibility/resources/cake.png: Copied from LayoutTests/accessibility/resources/cake.png.
  • platform/mac/accessibility/resources/test.swf: Renamed from LayoutTests/accessibility/resources/test.swf.
  • platform/mac/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/table-one-cell-expected.txt.
16:30 Changeset [41750] by darin@apple.com
  • 7 edits in trunk/WebKit

WebKit:

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • English.lproj/Localizable.strings: Updated.
  • StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit/mac:

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard. (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here.

WebKit/win:

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”

For now, change only the localized strings, not the terminology in the code.

  • WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here. (WebCore::contextMenuItemTagTextDirectionMenu): And here.
16:15 Changeset [41749] by darin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

Test: editing/selection/move-paragraph-document-edges.html

  • editing/visible_units.cpp: (WebCore::previousParagraphPosition): Use the last result from previousLinePosition rather than going all the way back to what was originally passed in when we hit exception cases like null or not moving. This correctly inherits the behavior of previousLinePosition when we are in a paragraph at the edge of a document. (WebCore::nextParagraphPosition): Ditto.

LayoutTests:

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 24629: moving forward or backward a paragraph fails at edge of document
https://bugs.webkit.org/show_bug.cgi?id=24629
rdar://problem/6544413

  • editing/selection/move-paragraph-document-edges-expected.txt: Added.
  • editing/selection/move-paragraph-document-edges.html: Added.
15:41 Changeset [41748] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-16 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

Bug 24619: RenderObject::selectionStartEnd does not need to be a virtual function
https://bugs.webkit.org/show_bug.cgi?id=24619

  • rendering/RenderObject.h: Remove virtual keyword from selectionStartEnd declaration.
  • rendering/RenderView.h: Ditto.
15:37 Changeset [41747] by christian@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-16 Christian Dywan <christian@twotoasts.de>

Reviewed by Adam Roben.

[gtk] API implementation: url and title
http://bugs.webkit.org/show_bug.cgi?id=14807

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: Implement "title" and "uri" properties as well as according functions. "uri" always reflects the current location including navigation inside the same page. title-changed is deprecated.
15:19 Changeset [41746] by pkasting@chromium.org
  • 10 edits in trunk/WebCore

2009-03-16 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24368
DOM scroll events should be based off the actual number of wheel
ticks, not off the number of lines scrolled. This matches IE.

  • dom/Node.cpp: (WebCore::Node::dispatchWheelEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::wheelTicksX): (WebCore::PlatformWheelEvent::wheelTicksY):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/MouseWheelEventWx.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
15:07 Changeset [41745] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-03-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel

Clean up a few issues in the Animation code:

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine): Whitespace

(WebCore::AnimationBase::willNeedService):
Don't round to float, use std::max

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startTimeResponse): Fix erroneously copied line to null out m_lastResponseWaiter.
14:58 Changeset [41744] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Don't mig_deallocate random data in case an instance proxy method returns false.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCEnumerate):
14:49 Changeset [41743] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and John Sullivan.

When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.


Instead, just zero out the member variable in invalidate.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvalidate): (pluginDeallocate):
14:34 Changeset [41742] by hyatt@apple.com
  • 63 edits in trunk

WebCore:

2009-03-12 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

Existing tests cover this.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition):

LayoutTests:

2009-03-16 David Hyatt <hyatt@apple.com>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=13632

Overflow scrolling needs to account for the bottom/right padding on the object itself as well
as for bottom/right margins on children.

  • platform/mac/fast/body-propagation/overflow/002-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-expected.txt:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-expected.txt:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-expected.txt:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-expected.txt:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/overflow/003-expected.checksum:
  • platform/mac/fast/overflow/003-expected.png:
  • platform/mac/fast/overflow/003-expected.txt:
  • platform/mac/fast/overflow/004-expected.checksum:
  • platform/mac/fast/overflow/004-expected.png:
  • platform/mac/fast/overflow/007-expected.checksum:
  • platform/mac/fast/overflow/007-expected.png:
  • platform/mac/fast/overflow/007-expected.txt:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
14:19 Changeset [41741] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-16 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

Test: fast/forms/select-max-length.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):

LayoutTests:

2009-03-16 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Test for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.

  • fast/forms/select-max-length-expected.txt: Added.
  • fast/forms/select-max-length.html: Added.
13:56 Changeset [41740] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

REGRESSION: undo-iframe-location-change.html is failing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=24626

Added a call to [[webview undoManager] removeAllActions]
to make sure anything left on the undo stack after one test
will not affect any later test.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
13:09 Changeset [41739] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6633944>
REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin


Defer loading while calling webPlugInInitialize since it can end up spinning the run loop.


  • Plugins/WebPluginController.mm: (-[WebPluginController addPlugin:]):
13:03 Changeset [41738] by aroben@apple.com
  • 4 edits in trunk/WebKit/win

Add IWebFramePrivate::isDisplayingStandaloneImage

This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
uses.

Reviewed by Darin Adler.

  • Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
  • WebFrame.cpp: (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our Document is an image document.
  • WebFrame.h: Added isDisplayingStandaloneImage.
12:56 Changeset [41737] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6686721> Media document crash in 64-bit WebKit

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): QTMovieContentViewClass is only used when rendering inline with old versions of QuickTime, so don't look for it when we are in a media document.
12:55 Changeset [41736] by pam@chromium.org
  • 3 edits in trunk/LayoutTests

2009-03-16 Pamela Greene <pam@chromium.org>

Reviewed by Dimitri Glazkov.

Remove test dependency on precise window location and size. It's not
clear to me why these vary, but they're not what the test is checking,
so it need not depend on them in any case.
https://bugs.webkit.org/show_bug.cgi?id=24170

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
11:54 Changeset [41735] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6622601>


Make sure to update both the window frame and the plug-in frame.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView addWindowObservers]):
09:47 Changeset [41734] by dglazkov@chromium.org
  • 9 edits in trunk/WebCore

2009-03-16 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24590
Refactor InspectorDOMStorageResource to use ScriptFunctionCall.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added method for bool argument.
  • bindings/js/ScriptFunctionCall.h: Ditto, also cleaned up.
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject): Added Storage helper.
  • bindings/js/ScriptObjectQuarantine.h: Ditto.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): Changed to use bind method. (WebCore::InspectorController::resetScriptObjects): Changed to use unbind method. (WebCore::InspectorController::didUseDOMStorage): Changed to use isSameHostAndType and bind methods.
  • inspector/InspectorController.h: Removed add/remove methods for DOM storage.
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::isSameHostAndType): Added. (WebCore::InspectorDOMStorageResource::bind): Added. (WebCore::InspectorDOMStorageResource::unbind): Added.
  • inspector/InspectorDOMStorageResource.h:
09:13 Changeset [41733] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-03-16 Mike Belshe <mike@belse.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24580
Fix query() to match KURL behavior, this time with the code that
compiles.

  • platform/KURLGoogle.cpp: (WebCore::KURL::query): Fix copy/paste mistake.
00:39 Changeset [41732] by ap@webkit.org
  • 12 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=21752
REGRESSION: referencing XHR constructor for a not yet loaded frame permanently breaks it

Test: fast/dom/Window/window-early-properties-xhr.html

For some transitions, the Window object is not replaced, but Document is. When this happened,
window.document property was updated, but references to Document kept in cached constructors
were not.

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): (WebCore::JSAudioConstructor::document): (WebCore::JSAudioConstructor::mark):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): (WebCore::JSImageConstructor::document): (WebCore::JSImageConstructor::mark):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::scriptExecutionContext): (WebCore::JSMessageChannelConstructor::mark):
  • bindings/js/JSMessageChannelConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): (WebCore::JSOptionConstructor::document): (WebCore::JSOptionConstructor::mark):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext): (WebCore::JSXMLHttpRequestConstructor::mark):
  • bindings/js/JSXMLHttpRequestConstructor.h: Changed cached constructors to keep a reference to Window, not Document.
00:12 Changeset [41731] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24549
Impose a limit on Access-Control-Max-Age value

  • loader/CrossOriginPreflightResultCache.cpp: (WebCore::CrossOriginPreflightResultCacheItem::parse):

03/15/09:

19:04 Changeset [41730] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6668875> Normalize Geolocation results

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
18:02 Changeset [41729] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <bolsinga@apple.com>

Reviewed by David Kilzer.

Update ::toString format as suggested by Darin Adler.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
17:31 Changeset [41728] by simon.fraser@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-03-15 Simon Fraser <simon.fraser@apple.com>

Revert r41718 because it broke DumpRenderTree on Tiger.

  • JavaScriptCorePrefix.h:
  • wtf/Platform.h:
16:55 Changeset [41727] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Reviewed by Darin Adler.

Yet another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encodingForFormSubmission):
16:41 Changeset [41726] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Simon Fraser <simon.fraser@apple.com>

Build fix: no review.

  • rendering/style/ContentData.h:
16:32 Changeset [41725] by ddkilzer@apple.com
  • 9 edits in trunk/WebCore

Bug 24542: Improve ContentData encapsulation

<https://bugs.webkit.org/show_bug.cgi?id=24542>

Reviewed by Simon Fraser.

No tests since there is no change in behavior.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Used getter methods instead of data members on ContentData class. Used isImage() convenience method.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Extracted code into deleteContent() method. (WebCore::ContentData::dataEquivalent): Added. Extracted code from StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::ContentData::deleteContent): Added. Used by setter methods.
  • rendering/style/ContentData.h: Made m_type, m_content and m_next private. (WebCore::ContentData::isCounter): Added. (WebCore::ContentData::isImage): Added. (WebCore::ContentData::isNone): Added. (WebCore::ContentData::isText): Added. (WebCore::ContentData::type): Added. (WebCore::ContentData::dataEquivalent): Added. (WebCore::ContentData::image): Added. (WebCore::ContentData::setImage): Added. (WebCore::ContentData::text): Added. (WebCore::ContentData::setText): Added. (WebCore::ContentData::counter): Added. (WebCore::ContentData::setCounter): Added. (WebCore::ContentData::next): Added. (WebCore::ContentData::setNext): Added.
  • rendering/style/CounterContent.h: (WebCore::operator!=): Removed. (WebCore::operator==): Renamed operator!=() and reversed its logic after extracting code from StyleRareNonInheritedData::contentDataEquivalent() to create ContentData::dataEquivalent().
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Used new getters and setters on ContentData class. Changed first argument from a StringImpl* to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::setContent): Updated declaration.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Extracted most logic in while() loop into ContentData::dataEquivalent().
15:39 Changeset [41724] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.3

Tagging 1.1.3.

15:26 Changeset [41723] by xan@webkit.org
  • 2 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version to 1.1.3 for release and fix soversion
calculation (oops). Thanks to Frederik Himpe for pointing this
out.

  • configure.ac:
13:15 Changeset [41722] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-15 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Mark Rowe.

  • config.ini: fix my blog's feed address.
11:51 Changeset [41721] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.2

Tagging 1.1.2.

10:40 Changeset [41720] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-15 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Anders Carlsson.

Fix default policy decision to be ignore, on MIME checks, if
WebKit doesn't know how to handle the MIME type. The documentation
is already correct, and this was an oversight when the policy
decision code was first committed. Since 1.1.2 will be the first
release to support download, there is no practical change in
behavior.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
10:40 Changeset [41719] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-15 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:23 Changeset [41718] by kevino@webkit.org
  • 3 edits in trunk/JavaScriptCore

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

08:30 Changeset [41717] by xan@webkit.org
  • 4 edits in trunk

2009-03-15 Xan Lopez <xlopez@igalia.com>

Bump version and libtool version for release.

  • configure.ac:

WebKit/gtk:

2009-03-15 Xan Lopez <xlopez@igalia.com>

  • NEWS: update for 1.1.2.
04:26 Changeset [41716] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/editing/selection/5354455-2.html

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

02:22 Changeset [41715] by ap@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19737
No cursor and paste not enabled right clicking text field/area

Test: fast/events/right-click-focus.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
01:56 Changeset [41714] by ap@webkit.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Suggested by Mark Rowe.

Move results for security/block-test.html to their correct locations. Results for other
platforms will need to be generated.

  • platform/mac-leopard/security/block-test-expected.txt: Removed.
  • platform/mac-tiger/security: Added.
  • platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
  • platform/mac/security: Added.
  • platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
  • security/block-test-expected.txt: Removed.
01:42 Changeset [41713] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=23949
HTMLSelectElement is in inconsistent state when handling mutation events

Test: fast/forms/mutation-event-recalc.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::appendChild): Call childrenChanged() before dispatching modification events, not after.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::insertBefore): (WebCore::HTMLSelectElement::replaceChild): (WebCore::HTMLSelectElement::removeChild): (WebCore::HTMLSelectElement::appendChild): (WebCore::HTMLSelectElement::removeChildren): Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events were already dispatched.
01:23 Changeset [41712] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adele Peterson.

  • fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately

Made WebHTMLView validate user interface items with the selector
-makeBaseWritingDirectionNatural: by returning NO and, if the item is
a menu item, setting its state to "off".

Strictly speaking, since -makeBaseWritingDirectionNatural: is never
valid for WebViews, WebHTMLView should not need to respond to it and
validate it, however because other responders respond to all three
-makeBaseWritingDirection*: messages and set the menu item state, having
WebHTMLView do the same makes application developers' lives easier.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]):
01:16 Changeset [41711] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Add svn:executable property to recently added cgi scripts.

  • http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:
Note: See TracTimeline for information about the timeline view.