Timeline


and

03/31/09:

23:43 Changeset [42148] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-31 Darin Adler <darin@apple.com>

Rolled out that last change until I can investigate the regression test failures it seems
to have caused.

  • dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
21:41 Changeset [42147] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-31 Darin Adler <darin@apple.com>

Reviewed by Eric Seidel.

Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
https://bugs.webkit.org/show_bug.cgi?id=24621

  • dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward iterator, but also should never arise because of the fix below.
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when the passed-in node has no children. Like the change above, this is consistent with the rest of the class, although in the long run I think it's a bit strange to treat a <p> element with no children differently than a <p> element with children.
17:13 Changeset [42146] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Make resolve-ChangeLogs -f work when the working tree has spaces in its path

Reviewed by Mark Rowe and David Kilzer.

  • Scripts/resolve-ChangeLogs: (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in case it contains spaces.
15:57 Changeset [42145] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WebKit side of <rdar://problem/6500266>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Send the event.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView scrollWheel:]): Call NetscapePluginInstanceProxy::wheelEvent. If the plug-in processed the event, don't call super.


  • Plugins/Hosted/WebKitPluginHost.defs: Add definition.
15:13 Changeset [42144] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24965
Bug 24965: HTMLMediaElement: network state changes can be missed


  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the state changes, even when no event needs to be fired.
14:55 Changeset [42143] by eric.carlson@apple.com
  • 5 edits in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state drops below HAVE_FUTURE_DATA.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

  • http/tests/media/video-play-stall.html: Fail if 'waiting' fires more than once.
  • media/video-test.js: Fix a typo. (failTest):
14:39 Changeset [42142] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24777
WebKit tools are broken on Tiger

  • Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
14:26 Changeset [42141] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
the author recommends downloading the entire resource optimistically, so the
attribute is made available to the media engine to use if it is able.

Test: media/video-dom-autobuffer.html

  • html/HTMLAttributeNames.in: Add autobuffer.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): New. (WebCore::HTMLMediaElement::autobuffer): Ditto. (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
  • html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
  • html/HTMLMediaElement.idl: Add autobuffer.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer. (WebCore::MediaPlayer::autobuffer): New. (WebCore::MediaPlayer::setAutobuffer): Ditto.
  • platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

  • media/video-dom-autobuffer-expected.txt: Added.
  • media/video-dom-autobuffer.html: Added.
13:24 Changeset [42140] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-31 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail

  • WebView/WebHTMLView.mm: (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:] calls tryToPerform on the next responder.
13:23 Changeset [42139] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24550
Check return value of vasprintf. This should keep gcc 4.3.3
happy rather than have it complain about attribute warn_unused_result.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
13:11 Changeset [42138] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Style guide violation!

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
13:05 Changeset [42137] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Fix Tiger build.

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
12:56 Changeset [42136] by dimich@chromium.org
  • 2 adds in trunk/WebCore/bindings/v8

Fixing previous commit - forgot to 'git add' new files.

12:55 Changeset [42135] by dimich@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-03-31 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8DOMMap for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24951

  • bindings/v8/V8DOMMap.cpp: Added.
  • bindings/v8/V8DOMMap.h: Added.
12:50 Changeset [42134] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24955

Spacebar didn't play/pause in standalone MediaDocument

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
12:10 Changeset [42133] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-31 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24901
Added the following methods to MediaPlayerPrivate for Chromium port.
void sizeChanged();
void rateChanged();
void durationChanged();

The above changes are to reflect changes in MediaPlayer.cpp.
More details can be found in the original changeset.
http://trac.webkit.org/changeset/41907

  • platform/graphics/chromium/MediaPlayerPrivateChromium.h:
09:54 Changeset [42132] by darin@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

2009-03-31 Darin Adler <darin@apple.com>

  • Scripts/add-include: Added.
09:46 Changeset [42131] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-31 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24947

Special-case drawing text-shadow on win32, to let GDI draw in cases
when both fill & shadow color are opaque and the shadow has no blur.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::windowsCanHandleTextDrawing):
  • platform/graphics/skia/SkiaFontWin.h:
09:21 Changeset [42130] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

r42055 removed some functions in FrameLoader used by Chrome,
this CL backs out some of those changes to unbreak the Chrome build.

https://bugs.webkit.org/show_bug.cgi?id=24949

  • WebCore.base.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
09:13 Changeset [42129] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Build fixes for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=24945

  • dom/Document.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::imageToMarkup):
05:42 QtWebKitTodo edited by hausmann@webkit.org
(diff)
03:26 Changeset [42128] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

01:11 QtWebKitTodo edited by hausmann@webkit.org
(diff)
00:55 QtWebKitTodo edited by hausmann@webkit.org
(diff)
00:02 Changeset [42127] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix use of incorrect constant.

  • BuildSlaveSupport/built-product-archive:

03/30/09:

23:29 Changeset [42126] by mrowe@apple.com
  • 1 edit
    1 add in trunk/WebKitTools

Add a script in support of the new build.webkit.org configuration.

Rubber-stamped by Stephanie Lewis.

  • BuildSlaveSupport/built-product-archive: Added.
20:21 Changeset [42125] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
and 1.1.4 versions of WebKitGTK+.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
20:16 Changeset [42124] by kov@webkit.org
  • 7 edits
    1 add in trunk/WebKit/gtk

2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=17045
[GTK] Documentation

Added header documentation for WebKitWebNavigationAction and
WebKitWebPolicyDecision.

Added missing documentation pieces for WebKitSoupAuthDialog,
WebKitDownload and WebKitWebPolicyDecision.

Wrote a section about using the WEBKIT_DEBUG environment variable.

  • docs/GNUmakefile.am:
  • docs/webkitenvironment.xml: Added.
  • docs/webkitgtk-docs.sgml:
  • webkit/webkitdownload.cpp:
  • webkit/webkitsoupauthdialog.c:
  • webkit/webkitwebnavigationaction.cpp:
  • webkit/webkitwebpolicydecision.cpp:
19:41 Changeset [42123] by kov@webkit.org
  • 5 edits
    2 adds in trunk

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Integrate gtk-doc into the Gtk+ buildsystem.

Based on original work by Holger Freyther.

Integrate gtk-doc into our buildsystem. We are forced to
use recursive make for gtk-doc itself as the to be installed
gtk-doc.make (done by gtkdocize) is not working in a non
recursive environment.

The documentation can only be generated when srcdir == builddir.
In all other cases the generated files will not be found. This
limitation can be found in pango and gtk+ as well. There is no
easy way around. The resulting html documentation will be saved
in the srcdir as well.

  • docs/GNUmakefile.am: Added.
  • docs/version.xml.in: Added.
  • docs/webkitgtk-docs.sgml:
19:37 Changeset [42122] by kevino@webkit.org
  • 7 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add events to allow apps to override handling for JS prompts and
window object cleared events.

https://bugs.webkit.org/show_bug.cgi?id=24948

19:29 Changeset [42121] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Don't create CFDataRef with a fixed size.
Fixes synchronous XMLHTTPRequests on Windows.


Reviewed by Ada Chan.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::didReceiveData):
17:19 Changeset [42120] by darin@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2009-03-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110

Test: fast/loader/reload-policy-delegate.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's the policy loader and can use m_policyLoadType rather than letting it get set inside checkNavigationPolicy.

LayoutTests:

2009-03-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110

  • fast/frames/resources/iframe-focus.html: Removed bogus but harmless "layoutTestController.loadCount" code.
  • fast/loader/reload-policy-delegate-expected.txt: Added.
  • fast/loader/reload-policy-delegate.html: Added.
17:17 Changeset [42119] by darin@apple.com
  • 3 edits in trunk/WebKitTools

2009-03-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Make policy-delegate logging work even for local files by processing the URLs as we
do for other delegates.

  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Use _drt_descriptionSuitableForTestResult on the URL.
  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.
15:49 Changeset [42118] by timothy@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
in Finder (painting without up to date layout)

Reviewed by Dan Bernstein.

  • page/FrameView.cpp: (WebCore::FrameView::paintContents): Add an early return when painting is attempted when layout is needed.
13:14 Changeset [42117] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.4

Tagging WebKitGTK+ 1.1.4.

12:59 Changeset [42116] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938


Sort alphabetically.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
11:33 Changeset [42115] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938


Build fixes for building --3d-rendering and --no-svg

  • rendering/RenderLayerBacking.cpp:
11:27 Changeset [42114] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

2009-03-30 Steve Falkenburg <sfalken@apple.com>

Bump version to 530.

  • win/tools/scripts/VERSION:
11:21 Changeset [42113] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Documenting what changed since the 1.1.3 release, in
the GTK+ port.

  • NEWS:
11:04 Changeset [42112] by bolsinga@apple.com
  • 10 edits in trunk

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.


https://bugs.webkit.org/show_bug.cgi?id=24938

Build fixes when building --no-svg


  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Add missing CSS properties
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
  • dom/Node.cpp: (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
  • platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Handle unused param
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Handle unused param

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.


https://bugs.webkit.org/show_bug.cgi?id=24938


Build fixes when building --no-svg


DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h are only available with ENABLE_SVG.

  • MigrateHeaders.make:
10:46 Changeset [42111] by xan@webkit.org
  • 2 edits in trunk

2009-03-30 Xan Lopez <xlopez@igalia.com>

Unreviewed: bump version to 1.1.4 for release.

  • configure.ac:
10:41 Changeset [42110] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add information on the bug-fix-only 1.1.3 release.

  • NEWS:
10:37 Changeset [42109] by aroben@apple.com
  • 3 edits in trunk/WebKitTools

Windows build fix

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::waitForPolicyDelegate): Added this empty stub.
  • DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): (ScriptItem::invoke): Changed to use data members instead of removed member functions.
10:26 Changeset [42108] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-30 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

Bug 24916: REGRESSION: NavigationAction policy dispatch broken
https://bugs.webkit.org/show_bug.cgi?id=24916

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr is not used twice. This also optimizes the case where a frame name is specified, but it's the name of the frame being loaded. Also called release in all the final uses of FormState.
10:22 Changeset [42107] by darin@apple.com
  • 24 edits in trunk/WebCore

2009-03-30 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
https://bugs.webkit.org/show_bug.cgi?id=24937

Also should fix the Windows COM bindings build.

  • bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • dom/NamedAttrMap.h: Renamed class from NamedAttrMap to NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap functions all public and non-virtual. Removed virtualLength.
  • dom/NamedNodeMap.h: Replaced file with just an include of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap files and remove this file.
  • bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
  • dom/Attr.h: Ditto.
  • dom/Attribute.h: Ditto.
  • dom/Document.cpp: (WebCore::Document::importNode): Ditto.
  • dom/Element.cpp: (WebCore::Element::attributes): Ditto. (WebCore::Element::setAttributeMap): Ditto. (WebCore::Element::createAttributeMap): Ditto. (WebCore::Element::insertedIntoDocument): Ditto. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::openTagStartToString): Ditto. (WebCore::Element::removeAttributeNode): Ditto. (WebCore::Element::getAttributeNode): Ditto. (WebCore::Element::getAttributeNodeNS): Ditto. (WebCore::Element::hasAttribute): Ditto. (WebCore::Element::hasAttributeNS): Ditto. (WebCore::Element::normalizeAttributes): Ditto.
  • dom/Element.h: Ditto.
  • dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto. (WebCore::NamedNodeMap::~NamedNodeMap): Ditto. (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto. (WebCore::NamedNodeMap::getNamedItem): Ditto. (WebCore::NamedNodeMap::getNamedItemNS): Ditto. (WebCore::NamedNodeMap::removeNamedItem): Ditto. (WebCore::NamedNodeMap::removeNamedItemNS): Ditto. (WebCore::NamedNodeMap::setNamedItem): Ditto. (WebCore::NamedNodeMap::item): Ditto. (WebCore::NamedNodeMap::getAttributeItem): Ditto. (WebCore::NamedNodeMap::clearAttributes): Ditto. (WebCore::NamedNodeMap::detachFromElement): Ditto. (WebCore::NamedNodeMap::setAttributes): Ditto. (WebCore::NamedNodeMap::addAttribute): Ditto. (WebCore::NamedNodeMap::removeAttribute): Ditto. (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
  • dom/Node.cpp: (WebCore::Node::dumpStatistics): Ditto. (WebCore::Node::isEqualNode): Ditto. (WebCore::Node::isDefaultNamespace): Ditto. (WebCore::Node::lookupNamespaceURI): Ditto. (WebCore::Node::lookupNamespacePrefix): Ditto. (WebCore::Node::compareDocumentPosition): Ditto.
  • dom/Node.h: Ditto.
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
  • editing/ApplyStyleCommand.cpp: (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto. (WebCore::isEmptyFontTag): Ditto. (WebCore::areIdenticalElements): Ditto.
  • editing/markup.cpp: (WebCore::appendStartMarkup): Ditto. (WebCore::completeURLs): Ditto.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
  • svg/SVGAnimatedProperty.h: (WebCore::synchronizeProperty): Ditto.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Ditto.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Ditto.
09:35 Changeset [42106] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24750
[GTK] requests download instead of displaying page

Use soup facilities to append parameters to the content type, to
make that more robust;

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
09:24 Changeset [42105] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

<rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig

Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.

  • Configurations/Base.xcconfig: Moved Production definition of SECTORDER_FLAGS to here from Xcode project file.
  • Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS in Base.xcconfig to the empty string since it is not used for Debug and Release configurations.
  • WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.
08:58 Changeset [42104] by aroben@apple.com
  • 4 edits in trunk/WebKit/win

Build fixes after recent FrameLoader changes

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated to match urlSelected's current signature. We pass true for the userGesture parameter, since the user must have selected this item from the context menu.
  • WebCoreSupport/WebFrameLoaderClient.cpp: Removed loadURLIntoChildFrame. (WebFrameLoaderClient::createFrame): Changed to call FrameLoader::loadURLIntoChildFrame. This probably should have been done way back around r31281 when that function was added.
  • WebCoreSupport/WebFrameLoaderClient.h: Removed loadURLIntoChildFrame.
08:58 Changeset [42103] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix after recent Node.idl changes

  • bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources of classes that derive from Node to rebuild.
08:48 Changeset [42102] by xan@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24878
[GTK] Use GtkBinding system to handle key events in WebView

Use GtkBinding system for key events in WebKitWebView. Allows the
user to reconfigure the bindings and fixes a bunch of bugs along
the way (we were not checking modifier keys in most actions).

  • webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
  • webkit/webkitwebview.h:
  • webkitmarshal.list:
08:22 Changeset [42101] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • svg/graphics/SVGImage.cpp: Added a missing #include.
07:49 Changeset [42100] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2009-03-30 Mads Ager <ager@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24879
Add frame accessor to Screen, Console, and BarInfo objects. Add type
accessor to BarInfo objects.

In the V8 JavaScript bindings, we need access to the frame and
type for already created Screen, Console, and BarInfo objects in
order to keep their wrappers alive across GCs.

  • page/BarInfo.cpp: (WebCore::BarInfo::frame): Added. (WebCore::BarInfo::type): Added.
  • page/BarInfo.h:
  • page/Console.cpp: (WebCore::Console::frame): Added.
  • page/Console.h:
  • page/Screen.cpp: (WebCore::Screen::frame): Added.
  • page/Screen.h:
05:21 QtWebKitJournal edited by hausmann@webkit.org
(diff)
02:25 Changeset [42099] by hausmann@webkit.org
  • 3 edits in trunk/WebKit/qt

Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Document that setHtml/setContent loads only the html/data immediately, not external objects.

02:13 Changeset [42098] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk DRT build fix per changeset
http://trac.webkit.org/changeset/42082. Not reviewed.

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): (ScriptItem::invoke):

03/29/09:

19:49 Changeset [42097] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <darin@apple.com>

Requested by Antti Koivisto.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added a better comment.
19:21 Changeset [42096] by darin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

Test: editing/pasteboard/copy-display-none.html

  • editing/markup.cpp: (WebCore::createMarkup): Added a check for the case where adjusting the start node moves the start of the selection past the end of the range entirely. If we try to iterate we'll never hit the end of the range and will probably crash iterating the rest of the document.

LayoutTests:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

  • editing/pasteboard/copy-display-none-expected.txt: Added.
  • editing/pasteboard/copy-display-none.html: Added.
18:59 Changeset [42095] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
https://bugs.webkit.org/show_bug.cgi?id=24672
rdar://problem/6574263

I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
but there is an Apple-internal website I was able to use to reproduce and fix.

  • loader/CachedResource.h: Made makePurgeable public.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable so we can get its data if it hasn't yet been purged.
17:06 Changeset [42094] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <darin@apple.com>

Fix build again.

  • loader/EmptyClients.h: Fix typo in name of FormState.h.
16:53 Changeset [42093] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <darin@apple.com>

Try to fix the release build.

  • history/CachedPage.cpp: Make include unconditional, not debug-only.
16:51 Changeset [42092] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

Undo the previous build fix.

16:44 Changeset [42091] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

Fix build break.

16:29 Changeset [42090] by darin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

16:29 Changeset [42089] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-29 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
16:26 Changeset [42088] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-29 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
11:09 Changeset [42087] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <darin@apple.com>

Another attempt to fix the Qt build.

  • WebCore.pro: Added CheckedRadioButtons.cpp.
11:00 Changeset [42086] by darin@apple.com
  • 3 edits in trunk/WebKit/qt

2009-03-29 Darin Adler <darin@apple.com>

Try to fix Qt build.

  • WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.
  • WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h. (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): Removed unneeded call to detachChildren, which is called by FrameLoader right after this. (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame as other platforms do in the corresponding functions.
10:31 Changeset [42085] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2009-03-29 Darin Adler <darin@apple.com>

  • DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix Qt building of DumpRenderTree.
10:15 Changeset [42084] by darin@apple.com
  • 34 edits
    2 copies in trunk

WebCore:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 24921: remove include of HTMLFormElement.h from Document.h
https://bugs.webkit.org/show_bug.cgi?id=24921

  • GNUmakefile.am: Added CheckedRadioButtons source files.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
  • dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
  • dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
  • dom/Document.h: Removed unneeded includes, including HTMLFormElement.h. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
  • dom/Node.idl: Changed the type of parentElement from Node to Element for two reasons. 1) Node was incorrect, since parentElement returns an Element. 2) The bindings won't compile any more unless they know parentElement's return value is an Element due to include changes.
  • html/HTMLFormElement.cpp: Moved definitions of the functions in the CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
  • html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons class to the new CheckedRadioButtons.h.
  • html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
  • page/Chrome.cpp: (WebCore::Chrome::createWindow): Tweaked formatting.
  • css/CSSGrammar.y: Added newly-needed include.
  • dom/Range.cpp: Ditto.
  • editing/BreakBlockquoteCommand.cpp: Ditto.
  • editing/CompositeEditCommand.cpp: Ditto.
  • editing/InsertLineBreakCommand.cpp: Ditto.
  • editing/ModifySelectionListLevel.cpp: Ditto.
  • editing/RemoveFormatCommand.cpp: Ditto.
  • editing/TextIterator.cpp: Ditto.
  • editing/VisiblePosition.cpp: Ditto.
  • loader/DocLoader.cpp: Ditto.
  • page/AccessibilityRenderObject.cpp: Ditto.
  • page/Page.cpp: Ditto.
  • rendering/RenderBlock.cpp: Ditto.
  • rendering/RenderLayer.cpp: Ditto.
  • rendering/RenderObject.h: Ditto.
  • storage/LocalStorageArea.cpp: Ditto.
  • storage/SessionStorageArea.cpp: Ditto.

WebKit/mac:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

  • Plugins/WebNullPluginView.mm: Added now-needed includes.
  • WebView/WebHTMLRepresentation.mm: Ditto.
  • WebView/WebHTMLView.mm: Ditto.
10:14 Changeset [42083] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

  • fast/forms/targeted-frame-submission.html: Fixes from review comments.
10:11 Changeset [42082] by darin@apple.com
  • 22 edits in trunk

WebKitTools:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922

Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.

  • DumpRenderTree/LayoutTestController.cpp: (queueLoadingScriptCallback): Added. Version for scripts that perform loads. (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads. (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and queueNonLoadingScript. (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now. (LayoutTestController::queueForwardNavigation): Ditto. (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's platform-independent. (LayoutTestController::queueNonLoadingScript): Ditto. (LayoutTestController::queueReload): Moved here since it's platform-independent now.
  • DumpRenderTree/LayoutTestController.h: Ditto.
  • DumpRenderTree/WorkQueue.cpp: (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
  • DumpRenderTree/WorkQueue.h: Ditto.
  • DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item started a load. Removed unused getter functions. Made invoke functions private. Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (processWork): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement the new rule. Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): Return false when we fail, true when we succeed. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.

LayoutTests:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922

  • fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
  • http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately.
  • http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
  • http/tests/navigation/onload-navigation-iframe.html: Ditto.
  • http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form.
08:37 Changeset [42081] by darin@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

Test: fast/css/attr-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out identifiers that start with "-".
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test case works. This has the pleasant side effect of fixing a bug too.

LayoutTests:

2009-03-29 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

  • fast/css/attr-parsing-expected.txt: Added.
  • fast/css/attr-parsing.html: Added.
08:17 Changeset [42080] by darin@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2009-03-29 Darin Adler <darin@apple.com>

Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104

Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.

  • fast/forms/range-thumb-height-percentage.html: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.
02:45 Changeset [42079] by ap@webkit.org
  • 2 edits in trunk/WebCore

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Forgot to save the file after applying changes for review comments.

02:16 Changeset [42078] by ap@webkit.org
  • 5 edits
    4 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::load): Match Mac behavior more closely - we shouldn't rely on underlying library handling of synchronous requests.
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest delegate method for a redirect.
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Match async behavior more closely.

03/28/09:

22:27 Changeset [42077] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.

17:16 Changeset [42076] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-03-28 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Bug 24914: empty-string assertion crash when running storage tests
https://bugs.webkit.org/show_bug.cgi?id=24914

  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Don't store empty version strings in the map, since empty strings are per-thread.
14:16 Changeset [42075] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24790
[GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function

Set the right visibility to the WebKitSoupAuthDialog get_type
function.

  • webkit/webkitsoupauthdialog.h:
13:17 Changeset [42074] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Remove call to now private method.

11:43 Changeset [42073] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-03-28 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24910
Fixes for Chromium build.

  • bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
  • bindings/v8/custom/V8CustomEventListener.h: ditto.
  • dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
09:59 Changeset [42072] by dglazkov@chromium.org
  • 2 edits
    1 delete in trunk/WebCore

2009-03-28 Dimitri Glazkov <dglazkov@chromium.org>

Not reviewed, correcting landing error.

https://bugs.webkit.org/show_bug.cgi?id=24812
Custom bindings should be in v8/custom, not v8.

  • bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
09:48 Changeset [42071] by dglazkov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-03-28 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24616
Add V8 custom bindings for DOMWindow.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
09:24 Changeset [42070] by dglazkov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-03-28 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24812
Add V8 custom bindings for HTMLDocument.

  • bindings/v8/V8HTMLDocumentCustom.cpp: Added.
01:55 Changeset [42069] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

FrameLoader::loadURL and FrameLoader::detachChildren went private
per changes in http://trac.webkit.org/changeset/42055. Follow
Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
loadURL and FrameLoader::detachParent for detachChildrem.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
  • webkit/webkitwebview.cpp:

03/27/09:

22:11 Changeset [42068] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix non-AllInOneFile builds.

21:04 Changeset [42067] by mrowe@apple.com
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Update text-content-type-with-binary-extension.html to use a .sitx file of random data rather
than a .m4a to ensure that WebKit doesn't handle the resource as a full-frame media element if the network
layer sniffs it as audio/mp4 rather than application/octet-stream.

Rubber-stamped by Dan Bernstein.

  • http/tests/loading/resources/.htaccess:
  • http/tests/loading/resources/binaryData.m4a: Removed.
  • http/tests/loading/resources/binaryData.sitx: Added.
  • http/tests/loading/text-content-type-with-binary-extension.html:
21:04 Changeset [42066] by mrowe@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac-snowleopard/Skipped

Fix syntax of Skipped file.

20:50 Changeset [42065] by oliver@apple.com
  • 16 edits
    3 adds in trunk

Improve performance of Function.prototype.call
<https://bugs.webkit.org/show_bug.cgi?id=24907>

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

19:54 Changeset [42064] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip two plug-in tests that are failing due to <rdar://problem/6733642>.

Rubber-stamped by Oliver Hunt.

  • platform/mac-snowleopard/Skipped:
19:46 Changeset [42063] by mrowe@apple.com
  • 3 edits
    2 copies
    4 moves
    1 add in trunk/LayoutTests

Land updated results for two SVG tests involving Geeza Pro.

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • platform/mac-leopard/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.checksum.
  • platform/mac-leopard/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
  • platform/mac-leopard/svg/text/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
19:40 Changeset [42062] by mrowe@apple.com
  • 4 edits in trunk/WebCore

Fix two SVG test failures in 64-bit.

Reviewed by Sam Weinig.

getSubStringLength's arguments were declared as unsigned in the IDL and as signed long in the implementation.
This led to a value of -1 in JavaScript being converted to MAX_UINT in the bindings. In 32-bit this was
identical to -1 when interpeted as signed long, but in 64-bit it was still equal to MAX_UINT.

The solution for this is to use the IsIndex attribute on arguments that the SVG spec declares as "unsigned long"
but requires an exception be thrown when a negative value is passed. This results in the JS bindings handling the
check for a negative value and lets the implementation treat the arguments purely as unsigned values.

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::getNumberOfChars):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getStartPositionOfChar):
(WebCore::SVGTextContentElement::getEndPositionOfChar):
(WebCore::SVGTextContentElement::getExtentOfChar):
(WebCore::SVGTextContentElement::getRotationOfChar):
(WebCore::SVGTextContentElement::getCharNumAtPosition):
(WebCore::SVGTextContentElement::selectSubString):

  • svg/SVGTextContentElement.h:
  • svg/SVGTextContentElement.idl:
17:49 Changeset [42061] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Get mailto code out of FrameLoader.

  • html/HTMLFormElement.cpp: (WebCore::transferMailtoPostFormDataToURL): Added. Factored out the mailto logic so HTMLFormElement::submit isn't full of ugly bits. This includes the part of the logic that involves transformeing the URL that was previously inside FrameLoader. (WebCore::HTMLFormElement::submit): Call transferMailtoPostFormDataToURL and also release the data for slightly less refcount churn.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed all the special casing for mailto, since HTMLFormElement now properly prepares both the URL and the form data.
17:41 Changeset [42060] by mitz@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Mark Rowe.

  • fix <rdar://problem/6724514> A bit of OpenTypeUtilities cleanup
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
  • platform/graphics/opentype/OpenTypeUtilities.cpp: (WebCore::EOTHeader::EOTHeader): Added. Initializes the buffer size to the size of an EOTPrefix. (WebCore::EOTHeader::updateEOTSize): Added. Updates the size field in the prefix. (WebCore::EOTHeader::appendBigEndianString): Changed the static appendBigEndianStringToEOTHeader() into this member function. (WebCore::EOTHeader::appendPaddingShort): Added. (WebCore::getEOTHeader): Changed to use EOTHeader.
  • platform/graphics/opentype/OpenTypeUtilities.h: (WebCore::EOTHeader::size): (WebCore::EOTHeader::data): (WebCore::EOTHeader::prefix):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Changed to use EOTHeader. (WebCore::createFontCustomPlatformData): Ditto.
17:06 Changeset [42059] by darin@apple.com
  • 2 edits in trunk/WebKit

2009-03-27 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes.
17:06 Changeset [42058] by darin@apple.com
  • 2 edits in trunk/WebKitTools

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
16:55 Changeset [42057] by darin@apple.com
  • 19 edits in trunk/LayoutTests

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Made our mailto form submission tests work more reliably by using the new
layoutTestController.waitForPolicyDelegate function.

  • fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate rather than relying on the form submission happening immediately.
  • fast/forms/mailto/advanced-get.html: Ditto.
  • fast/forms/mailto/advanced-put.html: Ditto.
  • fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
  • fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
  • fast/forms/mailto/get-multiple-items.html: Ditto.
  • fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
  • fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
  • fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
  • fast/forms/mailto/get-non-ascii.html: Ditto.
  • fast/forms/mailto/get-overwrite-query.html: Ditto.
  • fast/forms/mailto/post-append-query.html: Ditto.
  • fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
  • fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
  • fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
  • fast/forms/mailto/post-multiple-items.html: Ditto.
  • fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
  • fast/forms/mailto/post-text-plain.html: Ditto.
16:55 Changeset [42056] by darin@apple.com
  • 15 edits in trunk/WebKitTools

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
tests work.

  • DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's no reason to use reinterpret_cast just to get from void* to a specific type. (getRootElementCallback): Ditto.
  • DumpRenderTree/AccessibilityUIElement.cpp: (toAXElement): Ditto.
  • DumpRenderTree/GCController.cpp: (collectCallback): Ditto. (collectOnAlternateThreadCallback): Ditto. (getJSObjectCountCallback): Ditto.
  • DumpRenderTree/LayoutTestController.cpp: (many functions): Ditto. (waitForPolicyDelegateCallback): Added. (LayoutTestController::staticFunctions): Sorted functions by name. Added waitForPolicyDelegate.
  • DumpRenderTree/LayoutTestController.h: Sorted functions by name. Added waitForPolicyDelegate.
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just before loading an empty page. This prevents extra policy delegate calls from being logged.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then tells the policy delegate to notify when done, then points the web view at the policy delegate.
  • DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Added code to do notifyDone if controllerToNotifyDone is set. (-[PolicyDelegate setControllerToNotifyDone:]): Added.
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the policy delegate. Also moved the call to resetUndoManager in here. (runTest): Removed the call to resetUndoManager (see above). Added an additional call to resetWebViewToConsistentStateBeforeTesting to match the Mac code.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0. (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if m_controllerToNotifyDone is set.
  • DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and m_controllerToNotifyDone.
16:37 Changeset [42055] by darin@apple.com
  • 6 edits in trunk/WebCore

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

To prepare for work on a form loading fix, remove some unused functions,
consolidate some functions, and make many more functions private in
FrameLoader.

  • WebCore.base.exp: Remove some unused entry points, update another.
  • dom/Document.cpp: (WebCore::Document::detach): Clear m_frame directly instead of using clearFramePointer.
  • dom/Document.h: Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected): Consolidate the two functions of this name into a single function. Also changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::submitForm): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::scheduleLocationChange): Call completeURL explicitly so we can remove the version of changeLocation that does completeURL for us. (WebCore::FrameLoader::redirectionTimerFired): Ditto. (WebCore::FrameLoader::loadURLIntoChildFrame): Set m_provisionalHistoryItem directly so we don't need a setProvisionalHistoryItem function. (WebCore::FrameLoader::canCachePageContainingThisFrame): Get at m_quickRedirectComing directly so we don't need a isQuickRedirectComing function. (WebCore::FrameLoader::logCanCacheFrameDecision): Ditto. (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadURL): Move the logic of the continueLoadWithData function here because this is the only caller. If we want to make the resulting function smaller we should refactor some other way. Also streamlined the user-chosen encoding logic, but did not change what it does. (WebCore::FrameLoader::finishedLoadingDocument): Changed the event argument to be PassRefPtr<Event>. (WebCore::FrameLoader::loadPostRequest): Ditto. (WebCore::FrameLoader::receivedMainResourceError): Moved the logic from the didNotOpenURL function here, since this was the only caller.
  • loader/FrameLoader.h: Removed include of FormState.h and used a forward declaration instead. Removed unneeded forward declation of Element. Moved many functions into the private section, and removed some other unused or uneeded functions.
16:23 Changeset [42054] by darin@chromium.org
  • 4 edits
    2 adds in trunk

2009-03-27 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=24303
Using keyboard select RTL text, Highlights goes to opposite direction from Firefox and IE.

Test: editing/selection/extend-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::directionOfEnclosingBlock): Added (WebCore::SelectionController::modifyExtendingRight): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "forward". (WebCore::SelectionController::modifyExtendingForward): Renamed modifyExtendingRightForward() to this. (WebCore::SelectionController::modifyExtendingLeft): Added. Currenctly implemented for character and word granularity, all other granularities are treated as "backward". (WebCore::SelectionController::modifyExtendingBackward): Renamed modifyExtendingLeftBackward() to this. (WebCore::SelectionController::modify): Change to call either the left/right or backward/forward methods depending on the 'dir' argument for extends.
  • editing/SelectionController.h:
16:15 Changeset [42053] by weinig@apple.com
  • 3 edits in trunk/WebKitTools

2009-03-27 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6

  • Scripts/prepare-ChangeLog:
  • Scripts/svn-create-patch:
15:34 Changeset [42052] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-27 John Abd-El-Malek <jam@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24836
Fix navigator.plugins.refresh(false) in Chromium.

  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::refresh):
15:31 Changeset [42051] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make scrollLeft, scrollTop, scrollWidth, and scrollHeight
virtual to fix the broken layout tests from my last commit.

Reviewed by Mark Rowe.

  • dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • dom/Element.h:
  • html/HTMLBodyElement.h:
14:34 Changeset [42050] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=24876>.
Bug 24876: fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N2)

Reviewed by Sam Weinig.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setLength): Repeatedly calling remove to remove elements causes us to recalculate the list
items after each node is removed, leading to O(N2) behaviour. By inlining the batch removal in to setLength we can avoid
this gratuitous recalcuation.

13:45 Changeset [42049] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-27 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

We don't support images for GtkCursors yet. We need a placeholder to avoid crashes.
I took crosshair to have a common behavior with firefox.

[GTK] SVG - Crash on setting the cursor icon
https://bugs.webkit.org/show_bug.cgi?id=24565

  • platform/gtk/CursorGtk.cpp: (WebCore::Cursor::Cursor):
13:36 Changeset [42048] by timothy@apple.com
  • 7 edits in trunk

Remove redundant attributes and functions from IDL files that have the
same attributes and functions defined in the super class.

Reviewed by Simon Fraser.

  • WebCore.xcodeproj/project.pbxproj: Remove DOMHTMLBodyElementPrivate.h.
  • bindings/objc/PublicDOMInterfaces.h: Remove focus and blur from DOMHTMLElement.
  • html/HTMLBodyElement.idl: Remove scrollLeft, scrollTop, scrollWidth and scrollHeight.
  • html/HTMLElement.idl: Remove blur and focus.
11:44 Changeset [42047] by timothy@apple.com
  • 2 edits in trunk/WebKitTools/DumpRenderTree/mac

Fix the Mac DumpRenderTree build.

11:37 Changeset [42046] by aroben@apple.com
  • 6 edits in trunk

Don't include substitute data URLs in global history redirect chains

WebCore:

Don't include substitute data URLs in global history redirect chains

<rdar://6690169>

Reviewed by Darin Adler.

This might be testable if:

  • support were added to DRT for providing substitute data on failed loads
  • support were added to DRT for dumping redirect chains

I tried doing the above and was still unable to make a test.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Call updateGlobalHistoryRedirectLinks only if the load succeeded (i.e., there is no unreachableURL). Previous the FrameLoaderClient implementations were unconditionally calling updateGlobalHistoryRedirectLinks from within updateGlobalHistory.

WebKit/mac:

Don't include substitute data URLs in global history redirect chains

<rdar://6690169>

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.

WebKit/win:

Don't include substitute data URLs in global history redirect chains

<rdar://6690169>

Reviewed by Darin Adler.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): Don't call updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now. (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Added an assertion to help catch cases where we might be adding a substitute data URL into a redirect chain.
11:27 Changeset [42045] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6541923> REGRESSION (r38629): Tab cycle in empty tab is broken

  • WebView/WebHTMLView.mm: (-[WebHTMLView _wantsKeyDownForEvent:]): Only return YES when we have a Frame.
11:07 Changeset [42044] by pkasting@chromium.org
  • 5 edits
    1 delete in trunk/WebCore

2009-03-27 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24861
Chromium port did not render decorations for <input type="search">.
This copies RenderThemeWin.*.

  • css/themeChromiumWin.css: Removed.
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumLinux::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumLinux::paintSearchFieldResultsButton):
  • rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::paintSearchField):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::): (WebCore::RenderThemeChromiumWin::extraDefaultStyleSheet): (WebCore::RenderThemeChromiumWin::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumWin::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumWin::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeChromiumWin::paintSearchFieldResultsButton):
  • rendering/RenderThemeChromiumWin.h: (WebCore::RenderThemeChromiumWin::paintSearchField):
11:02 Changeset [42043] by hyatt@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

2009-03-27 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser

If an object has a self-painting layer, don't count it as part of a block's visual overflow.
This fix has only been made for block-level children. The inline-level case is still broken
(and covered by an existing bug).

Added fast/block/positioning/negative-rel-position.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):

LayoutTests:

2009-03-27 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser

Test case for relative positioning bug.

  • fast/block/positioning/negative-rel-position.html: Added.
  • platform/mac/fast/block/positioning/negative-rel-position-expected.checksum: Added.
  • platform/mac/fast/block/positioning/negative-rel-position-expected.png: Added.
  • platform/mac/fast/block/positioning/negative-rel-position-expected.txt: Added.
11:00 Changeset [42042] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-03-27 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6642221>
REGRESSION: With the Movie widget, movie trailer fails to load if movie had been previously viewed


Add a dashboard specific workaround so that we always create renderers for object elements, even if display:none is set.


I've filed <rdar://problem/6731022> against the Movies widget.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
10:53 Changeset [42041] by darin@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-27 Darin Adler <darin@apple.com>

Reviewed by John Sullivan and Anders Carlsson.

<rdar://problem/5987442> Pasteboard not exposed to WebEditingDelegate for WebViewInsertActionPasted (needed for system services)

Added SPI to tell which pasteboard is currently being inserted.
I chose to put it on WebView to be forward-looking since we're migrating things
from WebHTMLView to WebView in the future.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Add calls to _setInsertionPasteboard. (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Assert the pasteboard is nil. (-[WebViewPrivate finalize]): Ditto. (-[WebView _insertionPasteboard]): Return the pastebaord. (-[WebView _setInsertionPasteboard:]): Set the pasteboard.
  • WebView/WebViewInternal.h: Added _setInsertionPasteboard.
  • WebView/WebViewPrivate.h: Added _insertionPasteboard.
10:50 Changeset [42040] by timothy@apple.com
  • 8 edits
    1 add in trunk

Expose new DOM methods as public Objective-C API.

WebCore:

2009-03-25 Timothy Hatcher <timothy@apple.com>

Expose new DOM methods as public Objective-C API.

<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)

Reviewed by NOBODY (OOPS!).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:

WebKit/mac:

2009-03-25 Timothy Hatcher <timothy@apple.com>

Expose new DOM methods as public Objective-C API.

<rdar://problem/5837350> Expose new DOM classes and methods
as public API (match the additions to the JavaScript DOM)

Reviewed by NOBODY (OOPS!).

  • MigrateHeaders.make:
10:45 Changeset [42039] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-03-27 Zack Rusin <zack@kde.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24280

Fix propagation of fill rules when rendering paths in the Qt build.

10:40 Changeset [42038] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-03-27 Zack Rusin <zack@kde.org>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=24275

Fix text field theming in the Qt build with the KDE 4 Oxygen
style by adjusting the size vertically and horizontally to
set padding on the element equal to the width of the style painted border.

09:23 Changeset [42037] by hausmann@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Bug 24884: Include strings.h for strcasecmp()
https://bugs.webkit.org/show_bug.cgi?id=24884

06:05 Changeset [42036] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-03-27 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24852
Build fix for GNU mode RVCT compilation

05:59 Changeset [42035] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-27 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24869

Fixes an incorrect case in tst_qwebpage.

05:50 Changeset [42034] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-03-27 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24868

Make text of the writing direction items more user friendly.

05:47 Changeset [42033] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-03-27 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24274

Fixed the Qt 4.4 Mac build with netscape plugins enabled.

04:54 Changeset [42032] by hausmann@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-03-27 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24746

Add new editing related QWebPage::WebActions

  • Clipboard: PasteAndMatchStyle
  • Formatting: RemoveFormat, ToggleStrikethrough, ToggleSubscript, and ToggleSuperscript
  • List Editing: InsertUnorderedList, InsertOrderedList, Indent, Outdent
  • Paragraph Justification: AlignCenter, AlignJustified, AlignLeft, AlignRight

Improved selection and editing tests.

Note: See TracTimeline for information about the timeline view.