Timeline



Apr 4, 2009:

8:56 PM Changeset in webkit [42230] by kevino@webkit.org
  • 9 edits in trunk

Build fixes for wxMac/Tiger.

5:06 PM Changeset in webkit [42229] by kevino@webkit.org
  • 8 edits in trunk

wx build fixes for the Windows port.

1:25 PM Changeset in webkit [42228] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-04-04 Simon Fraser <Simon Fraser>

Reviewed by Cameron Zwarich

https://bugs.webkit.org/show_bug.cgi?id=24648

Ensure that mapPoint(const IntPoint&) calls the FloatPoint
version to avoid infinite recursion.

No test because mapPoint(const IntPoint&) isn't ever called
on Mac, so I can't reproduce.

  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
12:33 AM Changeset in webkit [42227] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

  • fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character

Test: fast/text/international/thai-offsetForPosition-inside-character.html

  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Changed to use cursorMovementIterator instead of characterBreakIterator, allowing this function to return a valid cursor position even if it is not at a character boundary.

LayoutTests:

Reviewed by Mark Rowe.

  • test for <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character
  • fast/text/international/thai-offsetForPosition-inside-character-expected.txt: Added.
  • fast/text/international/thai-offsetForPosition-inside-character.html: Added.
12:27 AM Changeset in webkit [42226] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

  • fix an assertion failure when clicking at the beginning of a glyph cluster at the beginning of a text run

Test: fast/text/offsetForPosition-cluster-at-zero.html

  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Corrected the bound check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less than -1.

LayoutTests:

Reviewed by Mark Rowe.

  • test for a bug where computing the text offset for a position at the beginning of a glyph cluster at the beginning of a Core Text run resulted in an attempt to read past the end of a vector
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt: Added.
  • fast/text/offsetForPosition-cluster-at-zero.html: Added.
12:20 AM Changeset in webkit [42225] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-04 Sam Weinig <sam@webkit.org>

Update test result.

  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt:

Apr 3, 2009:

6:06 PM Changeset in webkit [42224] by timothy@apple.com
  • 2 edits in trunk/WebCore

Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
when the names are given.

https://bugs.webkit.org/show_bug.cgi?id=25044

Reviewed by Timothy Hatcher.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
5:56 PM Changeset in webkit [42223] by weinig@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

<rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456

Don't update the document pointer for all inactive windows on navigations.
This change causes us to differ slightly from Firefox when accessing the
document from within a closure tied to a navigated context, but as all
browsers differ on this edge case, I don't foresee compatibility issues.

Test: http/tests/security/cross-frame-access-document-direct.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::initScript): (WebCore::ScriptController::updateDocument):
  • bindings/js/ScriptController.h:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Update tests for <rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456

  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
  • fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
  • fast/dom/Window/dom-access-from-closure-window-expected.txt:
  • http/tests/security/cross-frame-access-document-direct-expected.txt: Added.
  • http/tests/security/cross-frame-access-document-direct.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-document-direct-test-victim.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-document-direct-test.html: Added.
5:49 PM Changeset in webkit [42222] by cmarrin@apple.com
  • 4 edits
    2 adds in trunk

Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.

We were starting transitions with 0 duration and delay, which is
useless. With accelerated compositing on, this went through a code
path that tried to use m_toStyle, which never got set because the
transitions was short circuited before it had a chance to. So I
both protect against using that null pointer and avoid starting
the transition in the first place.

5:41 PM Changeset in webkit [42221] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where you could not type any more in the Web Inspector's
search field after the first match is selected in the Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=23982
rdar://problem/6592367

Reviewed by Darin Adler.

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._jumpToSearchResult): Use the window object of the frame to set the selection, not the main window.
5:37 PM Changeset in webkit [42220] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-03 Kevin Decker <kdecker@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/6756512>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
5:34 PM Changeset in webkit [42219] by Stephanie Lewis
  • 2 edits in trunk/WebKitTools

2009-04-03 Stephanie Lewis <Stephanie Lewis>

Reviewed by Mark Rowe.

Fix running DumpRenderTree with a root.

  • Scripts/run-webkit-tests:
4:49 PM Changeset in webkit [42218] by weinig@apple.com
  • 7 edits
    40 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.

Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html

fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
fast/dom/Window/Location/location-override-toString-on-proto.html
fast/dom/Window/Location/location-override-toString-using-defineGetter.html
fast/dom/Window/Location/location-override-toString-using-with.html
fast/dom/Window/Location/location-override-toString.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
fast/dom/Window/Location/location-override-valueOf-on-proto.html
fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-using-with.html
fast/dom/Window/Location/location-override-valueOf.html
fast/dom/Window/Location/window-override-location-using-defineGetter.html
fast/dom/Window/Location/window-override-window-using-defineGetter.html
fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
fast/dom/Window/Location/window-shadow-location-using-string.html
fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::defineGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::customPut): (WebCore::JSLocation::defineGetter): (WebCore::JSLocationPrototype::customPut): (WebCore::JSLocationPrototype::defineGetter):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/Location.idl:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Tests for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.

  • fast/dom/Window/Location: Added.
  • fast/dom/Window/Location/location-override-toString-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-with.html: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto.html: Added.
  • fast/dom/Window/Location/location-override-toString-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-toString-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-using-with.html: Added.
  • fast/dom/Window/Location/location-override-toString.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-with.html: Added.
  • fast/dom/Window/Location/location-override-valueOf.html: Added.
  • fast/dom/Window/Location/resources: Added.
  • fast/dom/Window/Location/resources/location-tests-functions.js: Added. (normalizeURL):
  • fast/dom/Window/Location/resources/pass.html: Added.
  • fast/dom/Window/Location/resources/window-shadow-location-using-js-object-with-toString-iframe.html: Added.
  • fast/dom/Window/Location/resources/window-shadow-location-using-string-iframe.html: Added.
  • fast/dom/Window/Location/window-override-location-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/window-override-location-using-defineGetter.html: Added.
  • fast/dom/Window/Location/window-override-window-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/window-override-window-using-defineGetter.html: Added.
  • fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html: Added.
  • fast/dom/Window/Location/window-shadow-location-using-string-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-location-using-string.html: Added.
  • fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html: Added.
  • http/tests/security/cross-frame-access-location-put-expected.txt:
4:19 PM Changeset in webkit [42217] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-03 Geoffrey Garen <ggaren@apple.com>

Rolled out r42214 since it seems to have caused crashes on the buildbot.

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
4:13 PM Changeset in webkit [42216] by weinig@apple.com
  • 23 edits
    6 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148

  • Use the window object the Location and History objects are directly associated with instead of the lexical global object to pick the object prototype to serve as the base of the their respective prototype chains.
  • Re-factor as necessary to allow passing the correct global object to the createPrototype functions.

Tests: http/tests/security/cross-frame-access-history-prototype.html

http/tests/security/cross-frame-access-location-prototype.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMStructure): (WebCore::getDOMPrototype):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createPrototype):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createPrototype):
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createPrototype):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createPrototype):
  • bridge/runtime_object.h: (JSC::RuntimeObjectImp::createPrototype):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Tests for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148

Test for using the correct global object for location and history object
prototype chain creation.

  • http/tests/security/cross-frame-access-history-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-history-prototype.html: Added.
  • http/tests/security/cross-frame-access-location-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-location-prototype.html: Added.
  • http/tests/security/resources/cross-frame-history-prototype-iframe.html: Added.
  • http/tests/security/resources/cross-frame-location-prototype-iframe.html: Added.
3:24 PM Changeset in webkit [42215] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-04-03 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25009
Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
3:09 PM Changeset in webkit [42214] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed irrelevant ExecState* parameter from event handler registration code.


No change in behavior.

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
3:00 PM Changeset in webkit [42213] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

<rdar://problem/6756512>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
2:21 PM Changeset in webkit [42212] by Adam Roben
  • 4 edits in trunk/LayoutTests

Skip tests that rely on layoutTestController.waitForPolicyDelegate on platforms that don't implement that functionality

Implementing is covered by the following bugs:
<https://bugs.webkit.org/show_bug.cgi?id=25036>
<https://bugs.webkit.org/show_bug.cgi?id=25037>
<https://bugs.webkit.org/show_bug.cgi?id=25038>

Rubber-stamped by Mark Rowe.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Skip tests that use layoutTestController.waitForPolicyDelegate.
2:09 PM Changeset in webkit [42211] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

  • fix <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list

Test: fast/css/zoom-in-length-round-trip.html

  • dom/Element.cpp: (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure that the returned value is equal to the original unscaled value. (WebCore::adjustForAbsoluteZoom): Ditto.

LayoutTests:

Reviewed by Simon Fraser.

  • test for <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list
  • fast/css/zoom-in-length-round-trip-expected.txt: Added.
  • fast/css/zoom-in-length-round-trip.html: Added.
1:44 PM Changeset in webkit [42210] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-03 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6355573> [WebView _setCacheModel:] leaks the result of _CFURLCacheCopyCacheDirectory

Reviewed by Adam Roben

  • WebView/WebView.mm: (+[WebView _setCacheModel:]): use WebCFAutorelease rather than autorelease on result of method that returns CFStringRef
1:35 PM Changeset in webkit [42209] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2009-04-03 Simon Fraser <Simon Fraser>

Update expected result due to rounding difference after r42207.

  • platform/mac/svg/hixie/perf/007-expected.txt:
12:29 PM Changeset in webkit [42208] by cmarrin@apple.com
  • 9 edits in trunk

Fixed https://bugs.webkit.org/show_bug.cgi?id=24941

This fix essentially does a -viewWillDraw call for layout. It adds
a CFRunLoopObserver which performs layout just before drawing on the
Mac platform. This makes sure layout is complete before rendering and
avoids a flash.

11:57 AM Changeset in webkit [42207] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24648

Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapPoint): (WebCore::TransformationMatrix::mapRect): (WebCore::TransformationMatrix::mapQuad):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
11:39 AM Changeset in webkit [42206] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25018

Add containsPoint() and containsQuad() methods to FloatQuad.

  • platform/graphics/FloatQuad.cpp: (WebCore::dot): (WebCore::isPointInTriangle): (WebCore::FloatQuad::containsPoint): (WebCore::FloatQuad::containsQuad):
  • platform/graphics/FloatQuad.h:
11:28 AM Changeset in webkit [42205] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-03 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

WebKit side of <rdar://problem/6752953>.


Pass the clip rect to the plug-in host.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
  • Plugins/Hosted/WebKitPluginHost.defs:
11:16 AM Changeset in webkit [42204] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • loader/ProgressTracker.cpp: Included DocumentLoader.h (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to documents that use WebCore's layout system.
11:06 AM Changeset in webkit [42203] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2009-04-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6336092> REGRESSION: movie does not resize correctly

Test: media/video-size-intrinsic-scale.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead of QTMovieNaturalSizeAttribute so we return the correct size for movies saved with a non-default matrix. (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView because [QTMovieView setFrame] also resizes the movie itself, and as the renderer calls setSize immediately when a movie reports a size change (QTMovieSizeDidChangeNotification) we can get into a feedback loop observing the size change and resetting the size, and this can cause QuickTime to miss correctly setting a movie's size when the media size changes after opening (as happens with an rtsp movie once the server sends the track sizes). Instead, remember the size passed to paint() and resize the view when it changes. (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect so we return the correct size for movies saved with non-default matrix.

2009-04-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6336092> REGRESSION: movie does not resize correctly

  • media/content/scaled-matrix.mov: Added. QuickTime movie saved with 2x scale.
  • media/video-size-intrinsic-scale-expected.txt: Added.
  • media/video-size-intrinsic-scale.html: Added, test that element with a scaled movie is sized correctly.
  • media/video-test.js: Modify so it can be included in <head> element. (logConsole): New, wraps creating console <div>, doesn't assume document.body exists. (consoleWrite): Call logConsole().
10:52 AM Changeset in webkit [42202] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-03 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=25028

  • loader/FrameLoader.h: (WebCore::FrameLoader::policyDocumentLoader):
9:58 AM Changeset in webkit [42201] by Darin Adler
  • 2 edits in trunk/WebCore

Fixed a backwards comment in ChangeLog.

9:28 AM Changeset in webkit [42200] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-02 Michael Nordman <Michael Nordman>

Reviewed by Alexey Proskuryakov.

Use long long, not int64, when working in webcore (sorry).
https://bugs.webkit.org/show_bug.cgi?id=25011

No change in functionality, so no tests.

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
8:33 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:00 AM Changeset in webkit [42199] by kov@webkit.org
  • 14 edits in trunk

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Require GTK+ >= 2.10; 2.8 is already very old, and some very
useful APIs are only available since 2.10.

  • configure.ac:

WebCore/

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll):
  • platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/gtk

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:

Apr 2, 2009:

11:49 PM Changeset in webkit [42198] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25021

Fix repainting an element with a reflection and transform after layout.
Telling the reflection to repaint directly is wrong, because, with
LayoutState enabled, it only takes the reflection's transform into account,
not that of the element. We can fix this, and keep the benefits of LayoutState,
by computing the reflected repaint rect, and repainting that using the original
renderer.

Test: fast/repaint/reflection-repaint-test.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
10:39 PM Changeset in webkit [42197] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23307

When repainting during layout (when LayoutState is enabled), we need
to apply the transform to the dirty rect, before applying x(), y() and
the offset storted in the LayoutState.

Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
since LayoutState is always root-relative.

Test: fast/repaint/transform-layout-repaint.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
8:10 PM Changeset in webkit [42196] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6684745> Crash in -[WebView removeSizeObservers] when loading NIB file

Reviewed by Dan Bernstein and Timothy Hatcher.

The implementation of -[NSView initWithCoder:] can result in -viewWillMoveToSuperview:/-viewDidMoveToSuperview: being sent to
our view before we've had a chance to initialize _private, so we need to ensure it is non-nil before dereferencing it in those
methods.

  • WebView/WebView.mm:

(-[WebView removeSizeObservers]): Nil-check _private before dereferencing it.
(-[WebView addSizeObservers]): Ditto.

6:07 PM Changeset in webkit [42195] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Mac build after r42191.

  • WebCore.base.exp:
6:01 PM Changeset in webkit [42194] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build after r42190.

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent): Update to use the new name of the constant.

5:42 PM Changeset in webkit [42193] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog.

2009-04-02 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

Test: http/tests/navigation/onload-navigation-iframe-2.html

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
  • html/HTMLFrameElement.h: Ditto.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
  • html/HTMLFrameElementBase.h: Ditto.
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
  • html/HTMLFrameOwnerElement.h: Ditto.
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
  • html/HTMLIFrameElement.h: Ditto.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag. The original change that introduced this, http://trac.webkit.org/changeset/25410, does not make it clear why this check was needed. And it seems it is needed.
5:41 PM Changeset in webkit [42192] by Darin Adler
  • 13 edits
    2 copies in trunk

WebCore:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
  • dom/Document.h:

LayoutTests:

2009-04-02 Darin Adler <Darin Adler>

Reviewed by Brady Eidson.

<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

  • http/tests/navigation/onload-navigation-iframe-2-expected.txt: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt. Updated for slight difference in the new test.
  • http/tests/navigation/onload-navigation-iframe-2.html: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe.html. Changed test to use an iframe element already in the HTML.
5:39 PM Changeset in webkit [42191] by adele@apple.com
  • 9 edits
    1 add in trunk

WebCore:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
  • dom/Document.h:

WebKit:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

  • WebKit.xcodeproj/project.pbxproj: Add WebDOMOperationsInternal.h and make WebDOMOperationsPrivate.h private.

WebKit/mac:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • DOM/WebDOMOperations.mm: (-[DOMDocument _focusableNodes]):
  • DOM/WebDOMOperationsInternal.h: Added.
  • DOM/WebDOMOperationsPrivate.h: Make this a private header. Move old methods to WebDOMOperationsInternal.h
  • WebView/WebHTMLView.mm: Use methods from WebDOMOperationsInternal.h
5:19 PM Changeset in webkit [42190] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-02 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6654255> crash due to null FrameView in EventHandler

Lots of code was added to EventHandler that used view() and page() without
null checking, but both of those can become null due to the frame lifetime.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::setPanScrollCursor): (WebCore::EventHandler::allowDHTMLDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::prepareMouseEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleTextInputEvent): (WebCore::EventHandler::addPendingFrameUnloadEventCount): (WebCore::EventHandler::removePendingFrameUnloadEventCount): (WebCore::EventHandler::clearPendingFrameUnloadEventCount): (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount): Added null checks for view() and page(). Made minor code cleanups.
2:58 PM Changeset in webkit [42189] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt.

Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
still considers it an error for the purposes of firing onerror.

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
2:58 PM Changeset in webkit [42188] by pam@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Split no-port test case into separate file, since its result may
depend on the behavior of a DNS proxy on some systems.
https://bugs.webkit.org/show_bug.cgi?id=21530

  • platform/mac-tiger/security/block-test-expected.txt: updated
  • platform/mac-tiger/security/block-test-no-port-expected.txt: Added.
  • platform/mac/security/block-test-expected.txt: updated
  • platform/mac/security/block-test-no-port-expected.txt: Added.
  • security/block-test-no-port.html: Added.
  • security/block-test.html: removed no-port test case
2:48 PM Changeset in webkit [42187] by Dimitri Glazkov
  • 7 edits in trunk/WebCore

2009-04-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25010
Refactor InspectorController to replace all JS function invocations with
ScriptFunctionCall.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,

and JSValuePtr methods.

(WebCore::ScriptFunctionCall::call): Added simplified, exception-eating

method.

  • bindings/js/ScriptFunctionCall.h: Decls for above.
  • bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow. (WebCore::getQuarantinedScriptObject):
  • bindings/js/ScriptObjectQuarantine.h: Decls for above.
  • inspector/InspectorController.cpp: (WebCore::callSimpleFunction): Made into a static. (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall. (WebCore::InspectorController::toggleRecordButton): Ditto. (WebCore::InspectorController::startGroup): Ditto. (WebCore::InspectorController::setAttachedWindow): Ditto. (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto. (WebCore::InspectorController::addScriptProfile): Ditto. (WebCore::InspectorController::didParseSource): Ditto. (WebCore::InspectorController::failedToParseSource): Ditto. (WebCore::InspectorController::didPause): Ditto.
  • inspector/InspectorController.h: Removed callFunction and callSimpleFunction

decls.

2:30 PM Changeset in webkit [42186] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream changes to V8WorkerContextEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25007

  • bindings/v8/V8ObjectEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp:
2:29 PM Changeset in webkit [42185] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8WorkerContextObjectEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25005

  • bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
  • bindings/v8/V8WorkerContextObjectEventListener.h: Added.
2:29 PM Changeset in webkit [42184] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8EventListenerList for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25004

  • bindings/v8/V8EventListenerList.cpp: Added.
  • bindings/v8/V8EventListenerList.h: Added.
1:59 PM BadContent created by wsiegrist@apple.com
1:45 PM Changeset in webkit [42183] by Adam Roben
  • 2 edits in trunk/WebKitTools

Build fix for Windows machines that don't have WebKitTools/Scipts in their PATH

  • Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching Visual Studio/VC++ Express.
1:31 PM Changeset in webkit [42182] by Adam Roben
  • 2 edits in trunk/WebKitTools

Use pdevenv when building .vcproj files via our scripts

Reviewed by Mark Rowe.

  • Scripts/webkitdirs.pm: (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual Studio/VC++ Express directly.
1:22 PM Changeset in webkit [42181] by hyatt@apple.com
  • 1 edit in trunk/WebCore/html/HTMLImageLoader.cpp

Fix release build bustage.

1:00 PM Changeset in webkit [42180] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-04-02 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

Chromium's ResourceRequest and ResourceResponse structs need some new data members.
https://bugs.webkit.org/show_bug.cgi?id=24897

These fields are needed to facilitate Chromium's implementation of the HTML5
ApplicationCache feature. We need to know what frame (or context) is doing the
requesting, and from what cache the resulting resource was retrieved.

No change in functionality, so no tests.

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
12:57 PM Changeset in webkit [42179] by hyatt@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.


Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
else just ignores it and displays the image anyway.

Added http/tests/misc/image-error.html

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h: (WebCore::CachedImage::httpStatusCodeError): (WebCore::CachedImage::httpStatusCodeErrorOccurred):
  • loader/CachedResource.h: (WebCore::CachedResource::httpStatusCodeError):
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveData):

LayoutTests:

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler

Add test for https://bugs.webkit.org/show_bug.cgi?id=24643

  • http/tests/misc/image-error-expected.txt: Added.
  • http/tests/misc/image-error.html: Added.
11:42 AM Changeset in webkit [42178] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Add XHR constructor in WorkerContext.idl for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24962

  • workers/WorkerContext.idl:
11:22 AM Changeset in webkit [42177] by pam@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Split long-running regexp out of the main regexp-overflow test file
so VMs (such as V8) that don't limit execution time can still run
the rest of the test cases.
https://bugs.webkit.org/show_bug.cgi?id=18327

  • fast/js/regexp-overflow-expected.txt: updated
  • fast/js/regexp-overflow-too-big-expected.txt: Added.
  • fast/js/regexp-overflow-too-big.html: Added.
  • fast/js/resources/regexp-overflow-too-big.js: Added.
  • fast/js/resources/regexp-overflow.js: removed one test case
11:18 AM Changeset in webkit [42176] by pam@chromium.org
  • 2 edits in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Minor cleanup: remove unneeded "toLower" on typeof.

  • fast/dom/Window/window-lookup-precedence.html:
10:30 AM Changeset in webkit [42175] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

2009-04-01 Ben Murdoch <benm@google.com>

Fix Bug 19743: Release build fails on 32-bit Windows

<https://bugs.webkit.org/show_bug.cgi?id=19743>

Combines all the HTML element cpp files into one to help reduce the
size of WebCore.lib so we can build in release mode on 32bit Windows.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.vcproj: Excluded all the separate HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp to the build.
  • html/HTMLElementsAllInOne.cpp: Added.
9:47 AM Changeset in webkit [42174] by Simon Fraser
  • 7 edits in trunk/WebCore

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24999

Optimize hit testing with transforms.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): getTransformFromContainer() change to return the matrix by reference.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::update3DTransformedDescendantStatus): The method failed to set m_3DTransformedDescendantStatusDirty to false, so did the work every time.

(WebCore::RenderLayer::createLocalTransformState):
Only call the expensive getTransformFromContainer() if there is a transform,
otherwise we just have a translation.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
  • rendering/RenderObject.h: Change transformFromContainer() to getTransformFromContainer(), and return the matrix by reference to reduce copying. New enum values for arguments for readability.
  • rendering/TransformState.cpp: (WebCore::TransformState::move): (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::translate): New method that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform().

(WebCore::HitTestingTransformState::applyTransform):
(WebCore::HitTestingTransformState::flatten):
(WebCore::HitTestingTransformState::flattenWithTransform):
Add flattenWithTransform(), which is a helper that allows us to
avoid doing the inverse() twice.

  • rendering/TransformState.h: (WebCore::TransformState::): (WebCore::TransformState::move): (WebCore::HitTestingTransformState::): New method on HitTestingTransformState that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform(). New enum values for arguments for readability.
9:35 AM Changeset in webkit [42173] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-04-02 Darin Adler <Darin Adler>

Reviewed by Kevin Decker.

<rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize callFunction as we do the other data members that are used in the mark function.
9:25 AM Changeset in webkit [42172] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24648

Optimize common code paths in TransformationMatrix.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::translate): (WebCore::TransformationMatrix::translate3d): Optimize to avoid matrix copy.

(WebCore::TransformationMatrix::isInvertible):
Test for identity and translation matrices before computing
the determinant.

(WebCore::TransformationMatrix::inverse):
Optimize for identity matrix and translations.

  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation): Utility method.
9:23 AM QtWebKitTodo edited by Simon Hausmann
(diff)
9:01 AM Changeset in webkit [42171] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24930
[Gtk] ISO files content is displayed inside the webview instead of being downloaded

Also sniff content of types declared as text/plain. This is
justified by the fact that it is common to have Apache HTTP
servers configured to send text/plain as Content-Type by default.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
9:00 AM Changeset in webkit [42170] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Protect the handle when notifying the client that the response was
received also in gotChunkCallback, or we crash in didReceiveData
when the load is cancelled in didReceiveResponse.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
8:50 AM Changeset in webkit [42169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24844
Unit test WebKitDownload

Extra checks to avoid crashing and a critical message when
property accessor functions are called before the download is
started.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
8:42 AM Changeset in webkit [42168] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=25001
Crash when content type parameters have no value

Handle the case where a Content-Type header parameter has no
value (i.e. no = character), to work-around a bug in libsoup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
3:29 AM Changeset in webkit [42167] by Simon Hausmann
  • 4 edits in trunk

JavaScriptCore:

2009-04-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann

https://bugs.webkit.org/show_bug.cgi?id=24490

Implement WTF::ThreadSpecific in the Qt build using
QThreadStorage.

WebCore:

2009-04-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24490

Enable web workers in Qt.

12:54 AM Changeset in webkit [42166] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix the Qt build

12:54 AM Changeset in webkit [42165] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-04-02 Takumi Asaki <takumi.asaki@nokia.com>

Reviewed by Simon Hausmann.

Fix pre-edit handling of text fields with input methods.

The input method sends an empty preeditString() if all characters of
the preedit should be deleted. So inputMethodEvent() has to use
preeditString() if it's empty.

12:12 AM Changeset in webkit [42164] by ap@webkit.org
  • 8 edits
    17 moves
    6 adds in trunk

Reviewed by Darin Adler. Based on work of Julien Chaffraix.

https://bugs.webkit.org/show_bug.cgi?id=22475
REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore

https://bugs.webkit.org/show_bug.cgi?id=24886
XHR requests opened when offline never return

WebCore:

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this wasn't an error. (WebCore::XMLHttpRequest::abort): Fixed formatting. (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange. The comment saying that this doesn't match Firefox was added in r33559 without explanation or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt that any code depends on this, so I went with the spec here.

LayoutTests:

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Removed.
  • fast/loader/xmlhttprequest-missing-file-exception.html: Removed.
  • http/tests/xmlhttprequest/state-after-network-error-expected.txt: Added.
  • http/tests/xmlhttprequest/state-after-network-error.html: Added. Added tests for these issues.
  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: As with other errors, the request now reaches DONE state now. This makes the results closer to Firefox again (they changed multiple times recently).
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Firefox dispatches cancellation events at a later point, when window.parent is already undefined. Changed the test to log all events, making the difference with Firefox less confusing.
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Fixed a mistake in the test, which could call a non-existent function in some code paths.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: State now reaches DONE on cross-origin check failure, as it should per the spec. This matches Firefox in async case (and in sync case, it simply doesn't dispatch any onreadystatechange events, not sure why).
  • fast/dom/null-document-xmlhttprequest-open-expected.txt: Removed.
  • fast/dom/null-document-xmlhttprequest-open.html: Removed.
  • fast/dom/resources/1251.html: Removed.
  • fast/dom/resources/xmlhttprequest-get-data.xml: Removed.
  • fast/dom/xmlhttprequest-gc-expected.txt: Removed.
  • fast/dom/xmlhttprequest-gc.html: Removed.
  • fast/dom/xmlhttprequest-get-expected.txt: Removed.
  • fast/dom/xmlhttprequest-get.xhtml: Removed.
  • fast/dom/xmlhttprequest-html-response-encoding-expected.txt: Removed.
  • fast/dom/xmlhttprequest-html-response-encoding.html: Removed.
  • fast/dom/xmlhttprequest-invalid-values-expected.txt: Removed.
  • fast/dom/xmlhttprequest-invalid-values.html: Removed.
  • fast/loader/resources/plist.app: Removed.
  • fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Removed.
  • fast/loader/xmlhttprequest-bad-mimetype.html: Removed.
  • fast/xmlhttprequest: Added.
  • fast/xmlhttprequest/null-document-xmlhttprequest-open-expected.txt: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open-expected.txt.
  • fast/xmlhttprequest/null-document-xmlhttprequest-open.html: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open.html.
  • fast/xmlhttprequest/resources: Added.
  • fast/xmlhttprequest/resources/1251.html: Copied from LayoutTests/fast/dom/resources/1251.html.
  • fast/xmlhttprequest/resources/plist.app: Copied from LayoutTests/fast/loader/resources/plist.app.
  • fast/xmlhttprequest/resources/xmlhttprequest-get-data.xml: Copied from LayoutTests/fast/dom/resources/xmlhttprequest-get-data.xml.
  • fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-bad-mimetype.html: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype.html.
  • fast/xmlhttprequest/xmlhttprequest-gc-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-gc-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-gc.html: Copied from LayoutTests/fast/dom/xmlhttprequest-gc.html.
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-get-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-get.xhtml: Copied from LayoutTests/fast/dom/xmlhttprequest-get.xhtml.
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding.html.
  • fast/xmlhttprequest/xmlhttprequest-invalid-values-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-invalid-values.html: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values.html.
  • fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception.html.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Added.
  • platform/gtk/Skipped: Moved non-HTTP XMLHttpRequest tests to fast/xmlhttprequest.

Apr 1, 2009:

11:49 PM QtWebKitTodo edited by Simon Hausmann
(diff)
9:51 PM Changeset in webkit [42163] by sfalken@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=24997
Race conditions in icon database threading code


m_syncThreadRunning set was mistakenly eliminated in r27717.
This reintroduces it.

Reviewed by Oliver Hunt.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Set m_syncThreadRunning.
7:58 PM Changeset in webkit [42162] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Windows support for built-product-archive.

  • BuildSlaveSupport/built-product-archive:
6:20 PM Changeset in webkit [42161] by Antti Koivisto
  • 6 edits in trunk/WebCore

2009-04-01 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.

<rdar://problem/6748609> Use ActiveDOMObject to suspend marquees


Make marquees ActiveDOMObjects, get rid of the special suspension code.

  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::canSuspend): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume):
  • html/HTMLMarqueeElement.h:
  • page/Frame.cpp: (WebCore::Frame::clearTimers):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h: (WebCore::RenderLayer::marquee):
6:10 PM Changeset in webkit [42160] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-04-01 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler

Make constant values static in previous commit, as suggested
by Darin.

  • rendering/RenderVideo.cpp:
5:57 PM Changeset in webkit [42159] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-04-01 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

https://bugs.webkit.org/show_bug.cgi?id=24993

Standalone media should have a smaller instrinsic
height.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):
5:30 PM Changeset in webkit [42158] by Darin Adler
  • 23 edits
    1 copy
    1 move
    6 adds in trunk

WebCore:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

Tests: fast/loader/submit-form-while-parsing-1.xhtml

fast/loader/submit-form-while-parsing-2.html

  • WebCore.base.exp: Updated.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children. Used uncheckedAppend because we reserveInitialCapacity. (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children. Added an assertion that this is only used to add items that don't have duplicate frame names. (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item if any, preserving the isTargetItem flag. (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName for consistency with the other functions here that all call the frame name the "target". Also updated for rename of m_subItems to m_children. (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem. Removed unneeded size check. (WebCore::HistoryItem::targetItem): Changed to always return the top item if no item has the isTargetItem flag set. The old version would instead return 0 in some cases, but return the top item if it had no children. (WebCore::HistoryItem::children): Renamed m_subItems to m_children. (WebCore::HistoryItem::hasChildren): Ditto. (WebCore::HistoryItem::showTreeWithIndent): Ditto.
  • history/HistoryItem.h: Name changes.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of attaching "recorded form values" and "form about to be submitted" to the frame loader. Parameter work fine for this; there's no need to store state on the FrameLoader.
  • loader/FormState.cpp: (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map. (WebCore::FormState::create): Ditto.
  • loader/FormState.h: Update to use a vector that we adopt instead of hash map that we copy for auto-fill text field values.
  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for form submissions and turned the "wasDuringLoad" state into a separate boolean instead of using a special redirection type to track it. (WebCore::FrameLoader::createWindow): Updated for name and argument change of loadFrameRequest. (WebCore::FrameLoader::urlSelected): Ditto. (WebCore::FrameLoader::submitForm): Removed the "deferred form submission" machinery, replacing it with the "scheduled redirection" mechanism, shared with other kinds of redirection and navigation. Moved frame targeting here so we can schedule the redirection on the right frame. Moved the multiple form submission protection here. Moved the code to implement the rule that m_navigationDuringLoad was used for here too. (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead of the locationChangeDuringLoad type to detect location change during a load. (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading out of this function into scheduleRedirection, so it can be shared with the new scheduleFormSubmission function. (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as scheduleLocationChange, but with the arguments for a form submission. (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the duringLoad flag. (WebCore::FrameLoader::isLocationChange): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded completeURL call and just use KURL constructor to match the other cases. (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up the m_navigationDuringLoad, which is no longer needed. The new version of this is in the submitForm function and sets the lockHistory boolean. (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load in here that used to be in scheduleLocationChange. (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::stopRedirectionTimer): Ditto. (WebCore::FrameLoader::completed): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::loadFrameRequest): Renamed from loadFrameRequestWithFormAndValues. Replaced form element and form values argument with a single FormState argument. Changed frame targeting code to use the source frame in the case of a form submission to better match the actual target frame. (WebCore::FrameLoader::loadURL): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::clientRedirected): Changed to work with the m_isExecutingJavaScriptFormAction data member directly instead of taking it as a function parameter. (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment in here that was misplaced elsewhere in the file. (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early return idiom. (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes. (WebCore::FrameLoader::childFramesMatchItem): Ditto. (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the m_navigationDuringLoad logic; that's now handled by setting lockHistory to true in the submitForm function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Use the new setChildItem function so we don't get multiple items for the same frame name in the history item tree in the back/forward list.
  • loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to loadFrameRequest and made it take a form state object instead of the form element and form values. Removed the unused functions loadEmptyDocumentSynchronously, provisionalDocumentLoader, notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the submitForm function to take a form state argument. Eliminated the clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue functions, which are replaced by the form state arguments to submitForm and loadFrameRequest. Removed the isJavaScriptFormAction argument from the clientRedirected function; instead it looks at a data member directly. Eliminated the submitFormAgain and overload of the submitForm function; these are now subsumed into the remaining submitForm function and the scheduleFormSubmission function. Removed unused and obsolete data members m_navigationDuringLoad, m_deferredFormSubmission, m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Updated for name and argument change of loadFrameRequest.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed call to the now-unneeded clearRecordedFormValues function.

WebKit/mac:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

  • History/WebHistoryItem.mm: (-[WebHistoryItem targetItem]): Call targetItem directly instead of callling isTargetItem, hasChildren, and recurseToFindTargetItem.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for name and argument change of loadFrameRequest.

WebKit/win:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.

LayoutTests:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

  • fast/loader/onunload-form-submit-crash-2-expected.txt: Updated for change to the test.
  • fast/loader/onunload-form-submit-crash-2.html: Updated test to expect the form submission during the onunload handler to be ineffective.
  • fast/loader/onunload-form-submit-crash-expected.txt: Updated for change to the test.
  • fast/loader/onunload-form-submit-crash.html: Updated test to expect the form submission during the onunload handler to be ineffective.
  • fast/loader/resources/onunload-form-submit-crash2.html: Removed.
  • fast/loader/resources/onunload-form-submit-failure.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
  • fast/loader/resources/onunload-form-submit-success.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
  • fast/loader/resources/submit-form-while-parsing-subframe.html: Added.
  • fast/loader/resources/submit-form-while-parsing-success.html: Added.
  • fast/loader/submit-form-while-parsing-1-expected.txt: Added.
  • fast/loader/submit-form-while-parsing-1.xhtml: Added.
  • fast/loader/submit-form-while-parsing-2-expected.txt: Added.
  • fast/loader/submit-form-while-parsing-2.html: Added.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Updated to expect proper results, without the duplicate history items for the same frame name that were present before.
4:49 PM Changeset in webkit [42157] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, fixing previous commit.

https://bugs.webkit.org/show_bug.cgi?id=24994
Revert V8DOMMap.cpp change which accidentally snuck into the previous
commit.

  • bindings/v8/V8DOMMap.cpp: Revert change in previous commit.
4:43 PM Changeset in webkit [42156] by Dimitri Glazkov
  • 5 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24994
Fix miscellaneous merge/upstreaming divergencies in Chromium port.

  • bindings/v8/V8Collection.h: Added an include.
  • platform/KURLGoogle.cpp: (WebCore::KURL::baseAsString): Added to match KURL.cpp.
  • platform/chromium/ClipboardChromium.cpp: Added an include.
3:47 PM Changeset in webkit [42155] by Dimitri Glazkov
  • 11 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24989
Refactor InspectorResource to use ScriptObject/FunctionCall.

  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use

a more appropriate type conversion.

(WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to

accommodate for InspectorResource refactoring.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match

existing jsNumber call signature.

  • bindings/js/ScriptFunctionCall.h: Declaration for above.
  • bindings/js/ScriptObject.cpp: (WebCore::createEmptyObject): Added. (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): Added a bunch of property setters.
  • bindings/js/ScriptObject.h: Declarations for above.
  • inspector/InspectorController.cpp: Moved all InspectorResource-managing code

to InspectorResource.cpp

(WebCore::InspectorController::populateScriptObjects): Changed to use

refactored InspectorResource.

(WebCore::InspectorController::resetScriptObjects): Ditto.
(WebCore::InspectorController::pruneResources): Ditto.
(WebCore::InspectorController::didCommitLoad): Ditto.
(WebCore::InspectorController::addResource): Ditto.
(WebCore::InspectorController::removeResource): Ditto.
(WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
(WebCore::InspectorController::identifierForInitialRequest): Ditto.
(WebCore::InspectorController::willSendRequest): Ditto.
(WebCore::InspectorController::didReceiveResponse): Ditto.
(WebCore::InspectorController::didReceiveContentLength): Ditto.
(WebCore::InspectorController::didFinishLoading): Ditto.
(WebCore::InspectorController::didFailLoading): Ditto,
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
(WebCore::InspectorController::scriptImported): Ditto.

  • inspector/InspectorController.h: Removed InspectorResource-managing code decls

and tweaked some signatures to use ScriptString and long long for identifier.

  • inspector/InspectorController.idl: Changed to use long long for identifier.
  • inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall. (WebCore::InspectorResource::InspectorResource): Ditto. (WebCore::InspectorResource::~InspectorResource): Ditto. (WebCore::InspectorResource::createCached): Added. (WebCore::InspectorResource::updateRequest): Added. (WebCore::InspectorResource::updateResponse): Added. (WebCore::createHeadersObject): Added. (WebCore::InspectorResource::createScriptObject): Added. (WebCore::InspectorResource::updateScriptObject): Added. (WebCore::InspectorResource::releaseScriptObject): Added. (WebCore::InspectorResource::type): Tweaked to use ScriptString. (WebCore::InspectorResource::setXMLHttpResponseText): Added. (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString. (WebCore::InspectorResource::startTiming): Added. (WebCore::InspectorResource::markResponseReceivedTime): Added. (WebCore::InspectorResource::endTiming): Added. (WebCore::InspectorResource::markFailed): Added. (WebCore::InspectorResource::addLength): Added.
  • inspector/InspectorResource.h: Added decls for newly refactored-in methods. (WebCore::InspectorResource::create): Added. (WebCore::InspectorResource::isSameLoader): Added. (WebCore::InspectorResource::markMainResource): Added. (WebCore::InspectorResource::identifier): Added. (WebCore::InspectorResource::requestURL): Added. (WebCore::InspectorResource::frame): Added. (WebCore::InspectorResource::mimeType): Added. (WebCore::InspectorResource::Changes::Changes): Added new class to track

resource changes.

(WebCore::InspectorResource::Changes::hasChange): Added.
(WebCore::InspectorResource::Changes::set): Added.
(WebCore::InspectorResource::Changes::clear): Added.
(WebCore::InspectorResource::Changes::setAll): Added.
(WebCore::InspectorResource::Changes::clearAll): Added.

2:17 PM Changeset in webkit [42154] by darin@chromium.org
  • 3 edits
    4 adds in trunk

2009-04-01 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Ensure the right click doesn't deselect text under it. This was
happening in the Chromium and GTK+ ports because they don't select
the text under the cursor on right click.


This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737


https://bugs.webkit.org/show_bug.cgi?id=24946

Test: fast/events/context-no-deselect.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
12:48 PM Changeset in webkit [42153] by christian@webkit.org
  • 3 edits
    1 add in trunk

2009-04-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

Unit test WebKitDownload
http://bugs.webkit.org/show_bug.cgi?id=24844

  • GNUmakefile.am: Add a unit test for downloading.

2009-04-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

  • tests/testdownload.c: Added. (test_webkit_download_create): (main): Add an initial unit test for downloading.
12:32 PM Changeset in webkit [42152] by bolsinga@apple.com
  • 9 edits in trunk

2009-04-01 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24990
Put SECTORDER_FLAGS into xcconfig files.

12:26 PM Changeset in webkit [42151] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-04-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24991

Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
when getting the transform.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
9:55 AM Changeset in webkit [42150] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed typo fixes, and naming normalization in the
documentation.

  • docs/webkitenvironment.xml:
  • webkit/webkitwebview.cpp:
9:37 AM Changeset in webkit [42149] by kov@webkit.org
  • 2 edits in trunk

2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Fix make distcheck, after the gtk-doc
integration.

  • GNUmakefile.am:
8:58 AM QtWebKitTodo edited by Simon Hausmann
(diff)
4:41 AM QtWebKitTodo edited by Simon Hausmann
(diff)

Mar 31, 2009:

11:43 PM Changeset in webkit [42148] by Darin Adler
  • 3 edits in trunk/WebCore

2009-03-31 Darin Adler <Darin Adler>

Rolled out that last change until I can investigate the regression test failures it seems
to have caused.

  • dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
9:41 PM Changeset in webkit [42147] by Darin Adler
  • 3 edits in trunk/WebCore

2009-03-31 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
https://bugs.webkit.org/show_bug.cgi?id=24621

  • dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward iterator, but also should never arise because of the fix below.
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when the passed-in node has no children. Like the change above, this is consistent with the rest of the class, although in the long run I think it's a bit strange to treat a <p> element with no children differently than a <p> element with children.
5:13 PM Changeset in webkit [42146] by Adam Roben
  • 2 edits in trunk/WebKitTools

Make resolve-ChangeLogs -f work when the working tree has spaces in its path

Reviewed by Mark Rowe and David Kilzer.

  • Scripts/resolve-ChangeLogs: (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in case it contains spaces.
3:57 PM Changeset in webkit [42145] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WebKit side of <rdar://problem/6500266>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Send the event.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView scrollWheel:]): Call NetscapePluginInstanceProxy::wheelEvent. If the plug-in processed the event, don't call super.


  • Plugins/Hosted/WebKitPluginHost.defs: Add definition.
3:13 PM Changeset in webkit [42144] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24965
Bug 24965: HTMLMediaElement: network state changes can be missed


  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the state changes, even when no event needs to be fired.
2:55 PM Changeset in webkit [42143] by eric.carlson@apple.com
  • 5 edits in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.


https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state drops below HAVE_FUTURE_DATA.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

  • http/tests/media/video-play-stall.html: Fail if 'waiting' fires more than once.
  • media/video-test.js: Fix a typo. (failTest):
2:39 PM Changeset in webkit [42142] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24777
WebKit tools are broken on Tiger

  • Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
2:26 PM Changeset in webkit [42141] by eric.carlson@apple.com
  • 9 edits
    2 adds in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
the author recommends downloading the entire resource optimistically, so the
attribute is made available to the media engine to use if it is able.

Test: media/video-dom-autobuffer.html

  • html/HTMLAttributeNames.in: Add autobuffer.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): New. (WebCore::HTMLMediaElement::autobuffer): Ditto. (WebCore::HTMLMediaElement::setAutobuffer): Ditto.
  • html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.
  • html/HTMLMediaElement.idl: Add autobuffer.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer. (WebCore::MediaPlayer::autobuffer): New. (WebCore::MediaPlayer::setAutobuffer): Ditto.
  • platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

  • media/video-dom-autobuffer-expected.txt: Added.
  • media/video-dom-autobuffer.html: Added.
1:24 PM Changeset in webkit [42140] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-03-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

<rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail

  • WebView/WebHTMLView.mm: (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:] calls tryToPerform on the next responder.
1:23 PM Changeset in webkit [42139] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24550
Check return value of vasprintf. This should keep gcc 4.3.3
happy rather than have it complain about attribute warn_unused_result.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
1:11 PM Changeset in webkit [42138] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Style guide violation!

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
1:05 PM Changeset in webkit [42137] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Fix Tiger build.

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
12:56 PM Changeset in webkit [42136] by dimich@chromium.org
  • 2 adds in trunk/WebCore/bindings/v8

Fixing previous commit - forgot to 'git add' new files.

12:55 PM Changeset in webkit [42135] by dimich@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-03-31 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8DOMMap for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24951

  • bindings/v8/V8DOMMap.cpp: Added.
  • bindings/v8/V8DOMMap.h: Added.
12:50 PM Changeset in webkit [42134] by dino@apple.com
  • 2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24955

Spacebar didn't play/pause in standalone MediaDocument

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
12:10 PM Changeset in webkit [42133] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-31 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24901
Added the following methods to MediaPlayerPrivate for Chromium port.
void sizeChanged();
void rateChanged();
void durationChanged();

The above changes are to reflect changes in MediaPlayer.cpp.
More details can be found in the original changeset.
http://trac.webkit.org/changeset/41907

  • platform/graphics/chromium/MediaPlayerPrivateChromium.h:
9:54 AM Changeset in webkit [42132] by Darin Adler
  • 1 edit
    1 add in trunk/WebKitTools

2009-03-31 Darin Adler <Darin Adler>

  • Scripts/add-include: Added.
9:46 AM Changeset in webkit [42131] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-31 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24947

Special-case drawing text-shadow on win32, to let GDI draw in cases
when both fill & shadow color are opaque and the shadow has no blur.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::windowsCanHandleTextDrawing):
  • platform/graphics/skia/SkiaFontWin.h:
9:21 AM Changeset in webkit [42130] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Fisher.

r42055 removed some functions in FrameLoader used by Chrome,
this CL backs out some of those changes to unbreak the Chrome build.

https://bugs.webkit.org/show_bug.cgi?id=24949

  • WebCore.base.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
9:13 AM Changeset in webkit [42129] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Darin Adler.

Build fixes for Chromium.

https://bugs.webkit.org/show_bug.cgi?id=24945

  • dom/Document.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::imageToMarkup):
5:42 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:26 AM Changeset in webkit [42128] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-03-31 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build.

1:11 AM QtWebKitTodo edited by Simon Hausmann
(diff)
12:55 AM QtWebKitTodo edited by Simon Hausmann
(diff)
12:02 AM Changeset in webkit [42127] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix use of incorrect constant.

  • BuildSlaveSupport/built-product-archive:
Note: See TracTimeline for information about the timeline view.