Timeline


and

04/06/09:

16:43 Changeset [42261] by weinig@apple.com
  • 5 edits in trunk/WebCore

2009-04-06 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Bottleneck dispatching mutation events in a new dispatchMutationEvent
function.

  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchMutationEvent):
  • dom/Node.h:
16:11 Changeset [42260] by dglazkov@chromium.org
  • 9 edits in trunk/WebCore

2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25059
Remove references to dominantScript, getGenericFontForScript.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references

to getGenericFontForScript.

(WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.

  • platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::defaultGUIFont): Removed Document* arg. (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
  • rendering/RenderThemeChromiumLinux.h: Ditto.
  • rendering/RenderThemeChromiumMac.h: Ditto.
  • rendering/RenderThemeChromiumMac.mm: Ditto. (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::defaultGUIFont): Ditto. (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
  • rendering/RenderThemeChromiumWin.h: Ditto.
16:04 Changeset [42259] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

16:02 Changeset [42258] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.5

New tag.

15:42 Changeset [42257] by christian@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-04-06 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Oliver Hunt.

  • de.po: Added German translation for WebKitGTK+.
14:56 Changeset [42256] by ggaren@apple.com
  • 4 edits in trunk/WebCore

2009-04-06 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.


Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions

The problem was that a protected event listener's scope chain would end
up with a reference to the Node protecting it, causing a cycle. The
solution is to stop protecting event listeners and rely on marking instead.

This patch converts most Node event listeners to use marking instead of
GC protection.

  • bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node needs marking, and added a case for marking the node in order to mark its event listeners.
  • bindings/js/JSNodeCustom.cpp: (WebCore::markEventListeners): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::mark): Added code to mark a Node's event listeners when marking the Node. Changed code using protected event listeners to use event listeners.
  • dom/Node.idl: Changed code using protected event listeners to use event listeners.
13:58 Changeset [42255] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-04-06 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Remove unchecked bool return values for some dispatch event functions.

  • dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchProgressEvent):
  • dom/Node.h:
13:48 Changeset [42254] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-04-06 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
12:48 Changeset [42253] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2009-04-06 Dimitri Glazkov <dglazkov@chromium.org>

Not reviewed because it's stupidly obvious.

Correct the expected result by adding an extra line break.

  • fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added

an extra line.

12:39 Changeset [42252] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

  • pt_BR.po: Added Brazilian Portuguese translation for WebKitGTK+.
12:39 Changeset [42251] by kov@webkit.org
  • 12 edits
    6 adds in trunk

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

Added rules to maintain the localization support. We cannot simply
use whatever gettextize gives us because our build system is
non-recursive.

  • GNUmakefile.am:
  • configure.ac:

WebCore/

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk

  • platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h, since there are not translatable strings.
  • platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header that is specific for libraries.

WebKit/gtk/

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk

Implemented localization support for WebKitGTK+.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • po/POTFILES: Added.
  • po/README: Added.
  • po/webkit.pot: Added.
  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitwebframe.cpp:

WebKit/gtk/po/

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Sam Weinig.

  • GNUmakefile.am, POTFILES, webkit.pot: Initial setup of the localization infra-structure.
11:41 Changeset [42250] by darin@chromium.org
  • 2 edits in trunk/WebCore

Revert r42249 to fix the build.

11:23 Changeset [42249] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-06 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216

  • page/DOMWindow.idl:
11:08 Changeset [42248] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-04-06 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24978
Use custom implementations of a few Node methods so that
we don't over-aggressively create JS wrappers here.

  • bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
  • dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
11:01 Changeset [42247] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-06 Dave Moore <davemoore@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25031
Make the V8 element collections check for named properties *before*
checking if there are any elements with the same name. Otherwise
it is both incorrect and slow.

Test: fast/dom/HTMLSelectElement/length-not-overridden.html

Both of these interceptors were attempting to find an element in the
collection that had a name or id of the property name before checking
for a JS property with that name.

  • bindings/v8/V8Collection.h: (WebCore::collectionNamedPropertyGetter): (WebCore::nodeCollectionNamedPropertyGetter):

LayoutTests:

2009-04-06 Dave Moore <davemoore@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25031
Test for ensuring that named elements don't override properties on collections

  • fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
  • fast/dom/HTMLSelectElement/length-not-overridden.html: Added.
10:51 Changeset [42246] by simon.fraser@apple.com
  • 5 edits
    4 adds in trunk

2009-04-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25052

Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
because we need to call it at the end of rebuildCompositingLayerTree() once
we've determined which descendant layers are composited, otherwise
calculateCompositedBounds() can give the wrong answer.

Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
call that explicitly from styleChanged(), if we know a layer update is not pending,
and similarly from updateAfterLayout().

Test: compositing/overflow/overflow-positioning.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayers): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
09:01 Changeset [42245] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-06 Mike Belshe <mike@belshe.com>

Reviewed by Alexey Proskuryakov.

Add accessors to AtomicString which take String/const char* arguments
so that we don't accidentally thrash the AtomicString table.

https://bugs.webkit.org/show_bug.cgi?id=24979

  • platform/text/AtomicString.h:
08:47 Changeset [42244] by vestbo@webkit.org
  • 7 edits in trunk/WebKit/qt

2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Rename DOM API select function to findFirst, findAll, etc.

08:37 Changeset [42243] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Tor Arne Vestbø.

Add /Programs to the productDir for GTK+, instead of adding
/JavaScriptCore, when running jsc.

  • Scripts/run-sunspider:
07:17 Changeset [42242] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK+] Correct the column and row cursor

Make col and row work in WebCore/manual-tests/cursor.html. The issue
was spotted in the WebKit inspector.

05:59 Changeset [42241] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Don't show and hide the platformPluginWidget, as it's our QWebView

05:50 QtWebKitContrib edited by hausmann@webkit.org
(diff)
05:50 QtWebKitContrib edited by hausmann@webkit.org
(diff)
05:49 QtWebKitContrib edited by hausmann@webkit.org
(diff)
04:58 Changeset [42240] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.

Do not connect the WebView to its own screen-changed signal, set a
default handler instead.

  • webkit/webkitwebview.cpp:
04:57 Changeset [42239] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.

GtkWidget::screen-changed can be emitted when a widget is being
destroyed, protect against it.

  • webkit/webkitwebview.cpp:
04:25 Changeset [42238] by hausmann@webkit.org
  • 9 edits
    5 adds in trunk

WebCore:

2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Add new files to the Qt build.
Export helper function from the Qt JSC binding, needed in WebKit/qt.

WebKit/qt:

2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>

Ariya Hidayat <ariya.hidayat@nokia.com>
Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Genevieve Mak <gen@staikos.net>

Reviewed by Tor Arne Vestbø, Simon Hausmann

First revision of new API in the Qt port to access the DOM.

04:13 Changeset [42237] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.

Internally the function name is stored as a WebCore::String and the Qt port wants to use this
constructor programmatically where the function name is also a WebCore::String.

02:51 Changeset [42236] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-04-06 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

HTMLCanvasElement crash when ImageBuffer creation fails.
https://bugs.webkit.org/show_bug.cgi?id=23212

Check for NULL before using the ImageBuffer as we might
be low on memory and creation may have failed.

Test case creation blocked by:
https://bugs.webkit.org/show_bug.cgi?id=25055

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):

04/05/09:

15:48 Changeset [42235] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-05 Geoffrey Garen <ggaren@apple.com>

[Originally] Reviewed by Sam Weinig.

Rolled back in r42214 with crashes fixed.

[Removed irrelevant ExecState* parameter from event handler registration code.]


[No change in behavior.]

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
10:26 Changeset [42234] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-04-05 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=25050

Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.

07:56 Changeset [42233] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt build

01:21 Changeset [42232] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-04-05 Mike Hommey <glandium@debian.org>

Reviewed by Holger Freyther.

Filter out all C++ symbols
https://bugs.webkit.org/show_bug.cgi?id=24960

Considering the public API is all C, we can just filter out all
C++ mangled symbols, which will avoid exporting symbols in some
corner cases such as gcc bugs on specific architectures, etc.

  • autotools/symbols.filter:
01:16 Changeset [42231] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487

Updated documentation and put more information about the
private-browsing setting for WebKitGtk.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):

04/04/09:

20:56 Changeset [42230] by kevino@webkit.org
  • 9 edits in trunk

Build fixes for wxMac/Tiger.

17:06 Changeset [42229] by kevino@webkit.org
  • 8 edits in trunk

wx build fixes for the Windows port.

13:25 Changeset [42228] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-04-04 Simon Fraser <simon.fraser@apple.com>

Reviewed by Cameron Zwarich

https://bugs.webkit.org/show_bug.cgi?id=24648

Ensure that mapPoint(const IntPoint&) calls the FloatPoint
version to avoid infinite recursion.

No test because mapPoint(const IntPoint&) isn't ever called
on Mac, so I can't reproduce.

  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
00:33 Changeset [42227] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

  • fix <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character

Test: fast/text/international/thai-offsetForPosition-inside-character.html

  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Changed to use cursorMovementIterator instead of characterBreakIterator, allowing this function to return a valid cursor position even if it is not at a character boundary.

LayoutTests:

Reviewed by Mark Rowe.

  • test for <rdar://problem/6757862> REGRESSION: Cannot use the mouse to place the insertion point inside a Thai character
  • fast/text/international/thai-offsetForPosition-inside-character-expected.txt: Added.
  • fast/text/international/thai-offsetForPosition-inside-character.html: Added.
00:27 Changeset [42226] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

  • fix an assertion failure when clicking at the beginning of a glyph cluster at the beginning of a text run

Test: fast/text/offsetForPosition-cluster-at-zero.html

  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::offsetForPosition): Corrected the bound check on firstGlyphBeforeCluster, letting it be 0 or -1, but not less than -1.

LayoutTests:

Reviewed by Mark Rowe.

  • test for a bug where computing the text offset for a position at the beginning of a glyph cluster at the beginning of a Core Text run resulted in an attempt to read past the end of a vector
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt: Added.
  • fast/text/offsetForPosition-cluster-at-zero.html: Added.
00:20 Changeset [42225] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-04 Sam Weinig <sam@webkit.org>

Update test result.

  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt:

04/03/09:

18:06 Changeset [42224] by timothy@apple.com
  • 2 edits in trunk/WebCore

Allows 16 HTML/CSS standard colors to be shown as swatch backgrounds
when the names are given.

https://bugs.webkit.org/show_bug.cgi?id=25044

Reviewed by Timothy Hatcher.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
17:56 Changeset [42223] by weinig@apple.com
  • 8 edits
    4 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

<rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456

Don't update the document pointer for all inactive windows on navigations.
This change causes us to differ slightly from Firefox when accessing the
document from within a closure tied to a navigated context, but as all
browsers differ on this edge case, I don't foresee compatibility issues.

Test: http/tests/security/cross-frame-access-document-direct.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::initScript): (WebCore::ScriptController::updateDocument):
  • bindings/js/ScriptController.h:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Update tests for <rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456

  • dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
  • fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
  • fast/dom/Window/dom-access-from-closure-window-expected.txt:
  • http/tests/security/cross-frame-access-document-direct-expected.txt: Added.
  • http/tests/security/cross-frame-access-document-direct.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-document-direct-test-victim.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-document-direct-test.html: Added.
17:49 Changeset [42222] by cmarrin@apple.com
  • 4 edits
    2 adds in trunk

Fixed https://bugs.webkit.org/show_bug.cgi?id=24787.

We were starting transitions with 0 duration and delay, which is
useless. With accelerated compositing on, this went through a code
path that tried to use m_toStyle, which never got set because the
transitions was short circuited before it had a chance to. So I
both protect against using that null pointer and avoid starting
the transition in the first place.

17:41 Changeset [42221] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where you could not type any more in the Web Inspector's
search field after the first match is selected in the Resources panel.

https://bugs.webkit.org/show_bug.cgi?id=23982
rdar://problem/6592367

Reviewed by Darin Adler.

  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._jumpToSearchResult): Use the window object of the frame to set the selection, not the main window.
17:37 Changeset [42220] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-03 Kevin Decker <kdecker@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/6756512>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
17:34 Changeset [42219] by slewis@apple.com
  • 2 edits in trunk/WebKitTools

2009-04-03 Stephanie Lewis <slewis@apple.com>

Reviewed by Mark Rowe.

Fix running DumpRenderTree with a root.

  • Scripts/run-webkit-tests:
16:49 Changeset [42218] by weinig@apple.com
  • 7 edits
    40 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.

Tests: fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html

fast/dom/Window/Location/location-override-toString-on-proto-using-with.html
fast/dom/Window/Location/location-override-toString-on-proto.html
fast/dom/Window/Location/location-override-toString-using-defineGetter.html
fast/dom/Window/Location/location-override-toString-using-with.html
fast/dom/Window/Location/location-override-toString.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html
fast/dom/Window/Location/location-override-valueOf-on-proto.html
fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html
fast/dom/Window/Location/location-override-valueOf-using-with.html
fast/dom/Window/Location/location-override-valueOf.html
fast/dom/Window/Location/window-override-location-using-defineGetter.html
fast/dom/Window/Location/window-override-window-using-defineGetter.html
fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html
fast/dom/Window/Location/window-shadow-location-using-string.html
fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::defineGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::customPut): (WebCore::JSLocation::defineGetter): (WebCore::JSLocationPrototype::customPut): (WebCore::JSLocationPrototype::defineGetter):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/Location.idl:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Tests for https://bugs.webkit.org/show_bug.cgi?id=22081
<rdar://problem/6346030>
Don't allow overriding the return value of window.location.

  • fast/dom/Window/Location: Added.
  • fast/dom/Window/Location/location-override-toString-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto-using-with.html: Added.
  • fast/dom/Window/Location/location-override-toString-on-proto.html: Added.
  • fast/dom/Window/Location/location-override-toString-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-toString-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-toString-using-with.html: Added.
  • fast/dom/Window/Location/location-override-toString.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto-using-with.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-on-proto.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-defineGetter.html: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-with-expected.txt: Added.
  • fast/dom/Window/Location/location-override-valueOf-using-with.html: Added.
  • fast/dom/Window/Location/location-override-valueOf.html: Added.
  • fast/dom/Window/Location/resources: Added.
  • fast/dom/Window/Location/resources/location-tests-functions.js: Added. (normalizeURL):
  • fast/dom/Window/Location/resources/pass.html: Added.
  • fast/dom/Window/Location/resources/window-shadow-location-using-js-object-with-toString-iframe.html: Added.
  • fast/dom/Window/Location/resources/window-shadow-location-using-string-iframe.html: Added.
  • fast/dom/Window/Location/window-override-location-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/window-override-location-using-defineGetter.html: Added.
  • fast/dom/Window/Location/window-override-window-using-defineGetter-expected.txt: Added.
  • fast/dom/Window/Location/window-override-window-using-defineGetter.html: Added.
  • fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-location-using-js-object-with-toString.html: Added.
  • fast/dom/Window/Location/window-shadow-location-using-string-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-location-using-string.html: Added.
  • fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field-expected.txt: Added.
  • fast/dom/Window/Location/window-shadow-window-using-js-object-with-location-field.html: Added.
  • http/tests/security/cross-frame-access-location-put-expected.txt:
16:19 Changeset [42217] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-03 Geoffrey Garen <ggaren@apple.com>

Rolled out r42214 since it seems to have caused crashes on the buildbot.

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
16:13 Changeset [42216] by weinig@apple.com
  • 23 edits
    6 adds in trunk

WebCore:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148

  • Use the window object the Location and History objects are directly associated with instead of the lexical global object to pick the object prototype to serve as the base of the their respective prototype chains.
  • Re-factor as necessary to allow passing the correct global object to the createPrototype functions.

Tests: http/tests/security/cross-frame-access-history-prototype.html

http/tests/security/cross-frame-access-location-prototype.html

  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::getCachedDOMStructure): (WebCore::cacheDOMStructure):
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMStructure): (WebCore::getDOMPrototype):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
  • bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createPrototype):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createPrototype):
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::JSWorkerConstructor::JSWorkerConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXSLTProcessorConstructor.cpp: (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createPrototype):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createPrototype):
  • bridge/runtime_object.h: (JSC::RuntimeObjectImp::createPrototype):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-03 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Tests for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148

Test for using the correct global object for location and history object
prototype chain creation.

  • http/tests/security/cross-frame-access-history-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-history-prototype.html: Added.
  • http/tests/security/cross-frame-access-location-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-location-prototype.html: Added.
  • http/tests/security/resources/cross-frame-history-prototype-iframe.html: Added.
  • http/tests/security/resources/cross-frame-location-prototype-iframe.html: Added.
15:24 Changeset [42215] by dimich@chromium.org
  • 3 edits in trunk/WebCore

2009-04-03 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25009
Upstream changes to WorkerContextExecutionProxy for V8 bindings in order to use V8EventListenerList as container.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
15:09 Changeset [42214] by ggaren@apple.com
  • 13 edits in trunk/WebCore

2009-04-03 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed irrelevant ExecState* parameter from event handler registration code.


No change in behavior.

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/scripts/CodeGeneratorJS.pm:
15:00 Changeset [42213] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

<rdar://problem/6756512>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): Tweaked the visibleName property.
14:21 Changeset [42212] by aroben@apple.com
  • 4 edits in trunk/LayoutTests

Skip tests that rely on layoutTestController.waitForPolicyDelegate on platforms that don't implement that functionality

Implementing is covered by the following bugs:
<https://bugs.webkit.org/show_bug.cgi?id=25036>
<https://bugs.webkit.org/show_bug.cgi?id=25037>
<https://bugs.webkit.org/show_bug.cgi?id=25038>

Rubber-stamped by Mark Rowe.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped: Skip tests that use layoutTestController.waitForPolicyDelegate.
14:09 Changeset [42211] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

  • fix <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list

Test: fast/css/zoom-in-length-round-trip.html

  • dom/Element.cpp: (WebCore::adjustForLocalZoom): For zoom factors greater than 1, ensure that the returned value is equal to the original unscaled value. (WebCore::adjustForAbsoluteZoom): Ditto.

LayoutTests:

Reviewed by Simon Fraser.

  • test for <rdar://problem/6634771> Under full-page zoom, cannot scroll MobileMe contact list
  • fast/css/zoom-in-length-round-trip-expected.txt: Added.
  • fast/css/zoom-in-length-round-trip.html: Added.
13:44 Changeset [42210] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-03 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6355573> [WebView _setCacheModel:] leaks the result of _CFURLCacheCopyCacheDirectory

Reviewed by Adam Roben

  • WebView/WebView.mm: (+[WebView _setCacheModel:]): use WebCFAutorelease rather than autorelease on result of method that returns CFStringRef
13:35 Changeset [42209] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-03 Simon Fraser <simon.fraser@apple.com>

Update expected result due to rounding difference after r42207.

  • platform/mac/svg/hixie/perf/007-expected.txt:
12:29 Changeset [42208] by cmarrin@apple.com
  • 9 edits in trunk

Fixed https://bugs.webkit.org/show_bug.cgi?id=24941

This fix essentially does a -viewWillDraw call for layout. It adds
a CFRunLoopObserver which performs layout just before drawing on the
Mac platform. This makes sure layout is complete before rendering and
avoids a flash.

11:57 Changeset [42207] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24648

Optimize mapPoint(), mapRect() and mapQuad() for identity matrix and translations.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapPoint): (WebCore::TransformationMatrix::mapRect): (WebCore::TransformationMatrix::mapQuad):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::mapPoint):
11:39 Changeset [42206] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25018

Add containsPoint() and containsQuad() methods to FloatQuad.

  • platform/graphics/FloatQuad.cpp: (WebCore::dot): (WebCore::isPointInTriangle): (WebCore::FloatQuad::containsPoint): (WebCore::FloatQuad::containsQuad):
  • platform/graphics/FloatQuad.h:
11:28 Changeset [42205] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-03 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

WebKit side of <rdar://problem/6752953>.


Pass the clip rect to the plug-in host.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resize):
  • Plugins/Hosted/WebKitPluginHost.defs:
11:16 Changeset [42204] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • loader/ProgressTracker.cpp: Included DocumentLoader.h (WebCore::ProgressTracker::incrementProgress): Limit the 50%-clamp rule to documents that use WebCore's layout system.
11:06 Changeset [42203] by eric.carlson@apple.com
  • 5 edits
    3 adds in trunk

2009-04-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6336092> REGRESSION: movie does not resize correctly

Test: media/video-size-intrinsic-scale.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize): Use QTMovieCurrentSizeAttribute instead of QTMovieNaturalSizeAttribute so we return the correct size for movies saved with a non-default matrix. (WebCore::MediaPlayerPrivate::setSize): Don't resize the QTMovieView because [QTMovieView setFrame] also resizes the movie itself, and as the renderer calls setSize immediately when a movie reports a size change (QTMovieSizeDidChangeNotification) we can get into a feedback loop observing the size change and resetting the size, and this can cause QuickTime to miss correctly setting a movie's size when the media size changes after opening (as happens with an rtsp movie once the server sends the track sizes). Instead, remember the size passed to paint() and resize the view when it changes. (WebCore::MediaPlayerPrivate::paint): Resize the view when passed a new size.
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::getNaturalSize): Use GetMovieBox instead of GetMovieNaturalBoundsRect so we return the correct size for movies saved with non-default matrix.

2009-04-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6336092> REGRESSION: movie does not resize correctly

  • media/content/scaled-matrix.mov: Added. QuickTime movie saved with 2x scale.
  • media/video-size-intrinsic-scale-expected.txt: Added.
  • media/video-size-intrinsic-scale.html: Added, test that element with a scaled movie is sized correctly.
  • media/video-test.js: Modify so it can be included in <head> element. (logConsole): New, wraps creating console <div>, doesn't assume document.body exists. (consoleWrite): Call logConsole().
10:52 Changeset [42202] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-03 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Restore FrameLoader::policyDocumentLoader to fix the Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=25028

  • loader/FrameLoader.h: (WebCore::FrameLoader::policyDocumentLoader):
09:58 Changeset [42201] by darin@apple.com
  • 2 edits in trunk/WebCore

Fixed a backwards comment in ChangeLog.

09:28 Changeset [42200] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-02 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

Use long long, not int64, when working in webcore (sorry).
https://bugs.webkit.org/show_bug.cgi?id=25011

No change in functionality, so no tests.

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
08:33 QtWebKitTodo edited by hausmann@webkit.org
(diff)
06:00 Changeset [42199] by kov@webkit.org
  • 14 edits in trunk

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Require GTK+ >= 2.10; 2.8 is already very old, and some very
useful APIs are only available since 2.10.

  • configure.ac:

WebCore/

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll):
  • platform/gtk/MouseEventGtk.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

WebKit/gtk

2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

Remove pre-processor checks for GTK+ >= 2.10, since we now require
at least that version.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::clipboard_clear_contents_cb): (WebKit::EditorClient::respondToChangedSelection):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:

04/02/09:

23:49 Changeset [42198] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25021

Fix repainting an element with a reflection and transform after layout.
Telling the reflection to repaint directly is wrong, because, with
LayoutState enabled, it only takes the reflection's transform into account,
not that of the element. We can fix this, and keep the benefits of LayoutState,
by computing the reflected repaint rect, and repainting that using the original
renderer.

Test: fast/repaint/reflection-repaint-test.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
22:39 Changeset [42197] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=23307

When repainting during layout (when LayoutState is enabled), we need
to apply the transform to the dirty rect, before applying x(), y() and
the offset storted in the LayoutState.

Also bypass LayoutState in mapLocalToContainer() if we have a repaintContainer,
since LayoutState is always root-relative.

Test: fast/repaint/transform-layout-repaint.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::computeRectForRepaint):
20:10 Changeset [42196] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6684745> Crash in -[WebView removeSizeObservers] when loading NIB file

Reviewed by Dan Bernstein and Timothy Hatcher.

The implementation of -[NSView initWithCoder:] can result in -viewWillMoveToSuperview:/-viewDidMoveToSuperview: being sent to
our view before we've had a chance to initialize _private, so we need to ensure it is non-nil before dereferencing it in those
methods.

  • WebView/WebView.mm:

(-[WebView removeSizeObservers]): Nil-check _private before dereferencing it.
(-[WebView addSizeObservers]): Ditto.

18:07 Changeset [42195] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the Mac build after r42191.

  • WebCore.base.exp:
18:01 Changeset [42194] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build after r42190.

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent): Update to use the new name of the constant.

17:42 Changeset [42193] by darin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fixed ChangeLog.

2009-04-02 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

Test: http/tests/navigation/onload-navigation-iframe-2.html

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): Removed unneeded createdByParser flag.
  • html/HTMLFrameElement.h: Ditto.
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Ditto.
  • html/HTMLFrameElementBase.h: Ditto.
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Ditto.
  • html/HTMLFrameOwnerElement.h: Ditto.
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Ditto.
  • html/HTMLIFrameElement.h: Ditto.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Removed unneeded check of the createdByParser flag. The original change that introduced this, http://trac.webkit.org/changeset/25410, does not make it clear why this check was needed. And it seems it is needed.
17:41 Changeset [42192] by darin@apple.com
  • 13 edits
    2 copies in trunk

WebCore:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
  • dom/Document.h:

LayoutTests:

2009-04-02 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6625840> Previous Page isn't loaded after hitting back button at http://www.breakingnews.ie/

  • http/tests/navigation/onload-navigation-iframe-2-expected.txt: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe-expected.txt. Updated for slight difference in the new test.
  • http/tests/navigation/onload-navigation-iframe-2.html: Copied from LayoutTests/http/tests/navigation/onload-navigation-iframe.html. Changed test to use an iframe element already in the HTML.
17:39 Changeset [42191] by adele@apple.com
  • 9 edits
    1 add in trunk

WebCore:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): (WebCore::Document::getFocusableNodes):
  • dom/Document.h:

WebKit:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

  • WebKit.xcodeproj/project.pbxproj: Add WebDOMOperationsInternal.h and make WebDOMOperationsPrivate.h private.

WebKit/mac:

2009-04-02 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Add a way to get a list of focusable nodes.

  • DOM/WebDOMOperations.mm: (-[DOMDocument _focusableNodes]):
  • DOM/WebDOMOperationsInternal.h: Added.
  • DOM/WebDOMOperationsPrivate.h: Make this a private header. Move old methods to WebDOMOperationsInternal.h
  • WebView/WebHTMLView.mm: Use methods from WebDOMOperationsInternal.h
17:19 Changeset [42190] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-04-02 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6654255> crash due to null FrameView in EventHandler

Lots of code was added to EventHandler that used view() and page() without
null checking, but both of those can become null due to the frame lifetime.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::setPanScrollCursor): (WebCore::EventHandler::allowDHTMLDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::prepareMouseEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleTextInputEvent): (WebCore::EventHandler::addPendingFrameUnloadEventCount): (WebCore::EventHandler::removePendingFrameUnloadEventCount): (WebCore::EventHandler::clearPendingFrameUnloadEventCount): (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount): (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount): Added null checks for view() and page(). Made minor code cleanups.
14:58 Changeset [42189] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt.

Fix regression in <object> layout test. Make sure that even though a 404 image loads, that <object>
still considers it an error for the purposes of firing onerror.

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
14:58 Changeset [42188] by pam@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Split no-port test case into separate file, since its result may
depend on the behavior of a DNS proxy on some systems.
https://bugs.webkit.org/show_bug.cgi?id=21530

  • platform/mac-tiger/security/block-test-expected.txt: updated
  • platform/mac-tiger/security/block-test-no-port-expected.txt: Added.
  • platform/mac/security/block-test-expected.txt: updated
  • platform/mac/security/block-test-no-port-expected.txt: Added.
  • security/block-test-no-port.html: Added.
  • security/block-test.html: removed no-port test case
14:48 Changeset [42187] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2009-04-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25010
Refactor InspectorController to replace all JS function invocations with
ScriptFunctionCall.

  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added int, UString,

and JSValuePtr methods.

(WebCore::ScriptFunctionCall::call): Added simplified, exception-eating

method.

  • bindings/js/ScriptFunctionCall.h: Decls for above.
  • bindings/js/ScriptObjectQuarantine.cpp: Added helper for Node and DOMWindow. (WebCore::getQuarantinedScriptObject):
  • bindings/js/ScriptObjectQuarantine.h: Decls for above.
  • inspector/InspectorController.cpp: (WebCore::callSimpleFunction): Made into a static. (WebCore::InspectorController::focusNode): Refactored to use ScriptFunctionCall. (WebCore::InspectorController::toggleRecordButton): Ditto. (WebCore::InspectorController::startGroup): Ditto. (WebCore::InspectorController::setAttachedWindow): Ditto. (WebCore::InspectorController::inspectedWindowScriptObjectCleared): Ditto. (WebCore::InspectorController::addScriptProfile): Ditto. (WebCore::InspectorController::didParseSource): Ditto. (WebCore::InspectorController::failedToParseSource): Ditto. (WebCore::InspectorController::didPause): Ditto.
  • inspector/InspectorController.h: Removed callFunction and callSimpleFunction

decls.

14:30 Changeset [42186] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream changes to V8WorkerContextEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25007

  • bindings/v8/V8ObjectEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/V8WorkerContextEventListener.cpp:
14:29 Changeset [42185] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8WorkerContextObjectEventListener for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25005

  • bindings/v8/V8WorkerContextObjectEventListener.cpp: Added.
  • bindings/v8/V8WorkerContextObjectEventListener.h: Added.
14:29 Changeset [42184] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8EventListenerList for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=25004

  • bindings/v8/V8EventListenerList.cpp: Added.
  • bindings/v8/V8EventListenerList.h: Added.
13:59 BadContent created by wsiegrist@apple.com
13:45 Changeset [42183] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Build fix for Windows machines that don't have WebKitTools/Scipts in their PATH

  • Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching Visual Studio/VC++ Express.
13:31 Changeset [42182] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Use pdevenv when building .vcproj files via our scripts

Reviewed by Mark Rowe.

  • Scripts/webkitdirs.pm: (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual Studio/VC++ Express directly.
13:22 Changeset [42181] by hyatt@apple.com
  • 1 edit in trunk/WebCore/html/HTMLImageLoader.cpp

Fix release build bustage.

13:00 Changeset [42180] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-04-02 Michael Nordman <michaeln@google.com>

Reviewed by Darin Fisher.

Chromium's ResourceRequest and ResourceResponse structs need some new data members.
https://bugs.webkit.org/show_bug.cgi?id=24897

These fields are needed to facilitate Chromium's implementation of the HTML5
ApplicationCache feature. We need to know what frame (or context) is doing the
requesting, and from what cache the resulting resource was retrieved.

No change in functionality, so no tests.

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::appCacheContextID): (WebCore::ResourceRequest::setAppCacheContextID):
  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::getAppCacheID): (WebCore::ResourceResponse::setAppCacheID):
12:57 Changeset [42179] by hyatt@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=24643.


Make sure images just ignore HTTP error codes and keep loading anyway. Only <object> checks http error codes and falls back. Everyone
else just ignores it and displays the image anyway.

Added http/tests/misc/image-error.html

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h: (WebCore::CachedImage::httpStatusCodeError): (WebCore::CachedImage::httpStatusCodeErrorOccurred):
  • loader/CachedResource.h: (WebCore::CachedResource::httpStatusCodeError):
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveData):

LayoutTests:

2009-04-02 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler

Add test for https://bugs.webkit.org/show_bug.cgi?id=24643

  • http/tests/misc/image-error-expected.txt: Added.
  • http/tests/misc/image-error.html: Added.
11:42 Changeset [42178] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-04-02 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

Add XHR constructor in WorkerContext.idl for V8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24962

  • workers/WorkerContext.idl:
11:22 Changeset [42177] by pam@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Split long-running regexp out of the main regexp-overflow test file
so VMs (such as V8) that don't limit execution time can still run
the rest of the test cases.
https://bugs.webkit.org/show_bug.cgi?id=18327

  • fast/js/regexp-overflow-expected.txt: updated
  • fast/js/regexp-overflow-too-big-expected.txt: Added.
  • fast/js/regexp-overflow-too-big.html: Added.
  • fast/js/resources/regexp-overflow-too-big.js: Added.
  • fast/js/resources/regexp-overflow.js: removed one test case
11:18 Changeset [42176] by pam@chromium.org
  • 2 edits in trunk/LayoutTests

2009-04-02 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Minor cleanup: remove unneeded "toLower" on typeof.

  • fast/dom/Window/window-lookup-precedence.html:
10:30 Changeset [42175] by aroben@apple.com
  • 2 edits
    1 add in trunk/WebCore

2009-04-01 Ben Murdoch <benm@google.com>

Fix Bug 19743: Release build fails on 32-bit Windows

<https://bugs.webkit.org/show_bug.cgi?id=19743>

Combines all the HTML element cpp files into one to help reduce the
size of WebCore.lib so we can build in release mode on 32bit Windows.

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.vcproj: Excluded all the separate HTML*Element.cpp files from the build. Added HTMLElementsAllInOne.cpp to the build.
  • html/HTMLElementsAllInOne.cpp: Added.
09:47 Changeset [42174] by simon.fraser@apple.com
  • 7 edits in trunk/WebCore

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24999

Optimize hit testing with transforms.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint): getTransformFromContainer() change to return the matrix by reference.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::update3DTransformedDescendantStatus): The method failed to set m_3DTransformedDescendantStatusDirty to false, so did the work every time.

(WebCore::RenderLayer::createLocalTransformState):
Only call the expensive getTransformFromContainer() if there is a transform,
otherwise we just have a translation.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
  • rendering/RenderObject.h: Change transformFromContainer() to getTransformFromContainer(), and return the matrix by reference to reduce copying. New enum values for arguments for readability.
  • rendering/TransformState.cpp: (WebCore::TransformState::move): (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::translate): New method that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform().

(WebCore::HitTestingTransformState::applyTransform):
(WebCore::HitTestingTransformState::flatten):
(WebCore::HitTestingTransformState::flattenWithTransform):
Add flattenWithTransform(), which is a helper that allows us to
avoid doing the inverse() twice.

  • rendering/TransformState.h: (WebCore::TransformState::): (WebCore::TransformState::move): (WebCore::HitTestingTransformState::): New method on HitTestingTransformState that adds a translation to the accumulated matrix, optionally without flattening. Cheaper than applyTransform(). New enum values for arguments for readability.
09:35 Changeset [42173] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-02 Darin Adler <darin@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/6744471> crash in GC due to uninitialized callFunction pointer

  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Initialize callFunction as we do the other data members that are used in the mark function.
09:25 Changeset [42172] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-04-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24648

Optimize common code paths in TransformationMatrix.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::translate): (WebCore::TransformationMatrix::translate3d): Optimize to avoid matrix copy.

(WebCore::TransformationMatrix::isInvertible):
Test for identity and translation matrices before computing
the determinant.

(WebCore::TransformationMatrix::inverse):
Optimize for identity matrix and translations.

  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::isIdentityOrTranslation): Utility method.
09:23 QtWebKitTodo edited by hausmann@webkit.org
(diff)
09:01 Changeset [42171] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24930
[Gtk] ISO files content is displayed inside the webview instead of being downloaded

Also sniff content of types declared as text/plain. This is
justified by the fact that it is common to have Apache HTTP
servers configured to send text/plain as Content-Type by default.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
09:00 Changeset [42170] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Protect the handle when notifying the client that the response was
received also in gotChunkCallback, or we crash in didReceiveData
when the load is cancelled in didReceiveResponse.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotChunkCallback):
08:50 Changeset [42169] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24844
Unit test WebKitDownload

Extra checks to avoid crashing and a critical message when
property accessor functions are called before the download is
started.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
08:42 Changeset [42168] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=25001
Crash when content type parameters have no value

Handle the case where a Content-Type header parameter has no
value (i.e. no = character), to work-around a bug in libsoup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
03:29 Changeset [42167] by hausmann@webkit.org
  • 4 edits in trunk

JavaScriptCore:

2009-04-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann

https://bugs.webkit.org/show_bug.cgi?id=24490

Implement WTF::ThreadSpecific in the Qt build using
QThreadStorage.

WebCore:

2009-04-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24490

Enable web workers in Qt.

00:54 Changeset [42166] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

Fix the Qt build

00:54 Changeset [42165] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-04-02 Takumi Asaki <takumi.asaki@nokia.com>

Reviewed by Simon Hausmann.

Fix pre-edit handling of text fields with input methods.

The input method sends an empty preeditString() if all characters of
the preedit should be deleted. So inputMethodEvent() has to use
preeditString() if it's empty.

00:12 Changeset [42164] by ap@webkit.org
  • 8 edits
    17 moves
    6 adds in trunk

Reviewed by Darin Adler. Based on work of Julien Chaffraix.

https://bugs.webkit.org/show_bug.cgi?id=22475
REGRESSION: Async XMLHttpRequest never finishes on nonexistent files anymore

https://bugs.webkit.org/show_bug.cgi?id=24886
XHR requests opened when offline never return

WebCore:

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): Only dispatch load event if this wasn't an error. (WebCore::XMLHttpRequest::abort): Fixed formatting. (WebCore::XMLHttpRequest::genericError): Change state to DONE and dispatch readystatechange. The comment saying that this doesn't match Firefox was added in r33559 without explanation or tests, and I don't think that it's accurate. Also, Firefox and Safari 3 both change state to HEADERS_RECEIVED before DONE on error - this doesn't match the spec, and I doubt that any code depends on this, so I went with the spec here.

LayoutTests:

  • fast/loader/xmlhttprequest-missing-file-exception-expected.txt: Removed.
  • fast/loader/xmlhttprequest-missing-file-exception.html: Removed.
  • http/tests/xmlhttprequest/state-after-network-error-expected.txt: Added.
  • http/tests/xmlhttprequest/state-after-network-error.html: Added. Added tests for these issues.
  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: As with other errors, the request now reaches DONE state now. This makes the results closer to Firefox again (they changed multiple times recently).
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Firefox dispatches cancellation events at a later point, when window.parent is already undefined. Changed the test to log all events, making the difference with Firefox less confusing.
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Fixed a mistake in the test, which could call a non-existent function in some code paths.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: State now reaches DONE on cross-origin check failure, as it should per the spec. This matches Firefox in async case (and in sync case, it simply doesn't dispatch any onreadystatechange events, not sure why).
  • fast/dom/null-document-xmlhttprequest-open-expected.txt: Removed.
  • fast/dom/null-document-xmlhttprequest-open.html: Removed.
  • fast/dom/resources/1251.html: Removed.
  • fast/dom/resources/xmlhttprequest-get-data.xml: Removed.
  • fast/dom/xmlhttprequest-gc-expected.txt: Removed.
  • fast/dom/xmlhttprequest-gc.html: Removed.
  • fast/dom/xmlhttprequest-get-expected.txt: Removed.
  • fast/dom/xmlhttprequest-get.xhtml: Removed.
  • fast/dom/xmlhttprequest-html-response-encoding-expected.txt: Removed.
  • fast/dom/xmlhttprequest-html-response-encoding.html: Removed.
  • fast/dom/xmlhttprequest-invalid-values-expected.txt: Removed.
  • fast/dom/xmlhttprequest-invalid-values.html: Removed.
  • fast/loader/resources/plist.app: Removed.
  • fast/loader/xmlhttprequest-bad-mimetype-expected.txt: Removed.
  • fast/loader/xmlhttprequest-bad-mimetype.html: Removed.
  • fast/xmlhttprequest: Added.
  • fast/xmlhttprequest/null-document-xmlhttprequest-open-expected.txt: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open-expected.txt.
  • fast/xmlhttprequest/null-document-xmlhttprequest-open.html: Copied from LayoutTests/fast/dom/null-document-xmlhttprequest-open.html.
  • fast/xmlhttprequest/resources: Added.
  • fast/xmlhttprequest/resources/1251.html: Copied from LayoutTests/fast/dom/resources/1251.html.
  • fast/xmlhttprequest/resources/plist.app: Copied from LayoutTests/fast/loader/resources/plist.app.
  • fast/xmlhttprequest/resources/xmlhttprequest-get-data.xml: Copied from LayoutTests/fast/dom/resources/xmlhttprequest-get-data.xml.
  • fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-bad-mimetype.html: Copied from LayoutTests/fast/loader/xmlhttprequest-bad-mimetype.html.
  • fast/xmlhttprequest/xmlhttprequest-gc-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-gc-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-gc.html: Copied from LayoutTests/fast/dom/xmlhttprequest-gc.html.
  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-get-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-get.xhtml: Copied from LayoutTests/fast/dom/xmlhttprequest-get.xhtml.
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-html-response-encoding.html: Copied from LayoutTests/fast/dom/xmlhttprequest-html-response-encoding.html.
  • fast/xmlhttprequest/xmlhttprequest-invalid-values-expected.txt: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-invalid-values.html: Copied from LayoutTests/fast/dom/xmlhttprequest-invalid-values.html.
  • fast/xmlhttprequest/xmlhttprequest-missing-file-exception-expected.txt: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception-expected.txt.
  • fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html: Copied from LayoutTests/fast/loader/xmlhttprequest-missing-file-exception.html.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html: Added.
  • platform/gtk/Skipped: Moved non-HTTP XMLHttpRequest tests to fast/xmlhttprequest.
Note: See TracTimeline for information about the timeline view.