Timeline


and

04/12/09:

17:41 Changeset [42430] by weinig@apple.com
  • 8 edits in trunk

WebCore:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move the event and crypto attributes and the captureEvents and releaseEvents
functions out of JSDOMWindowBase by partially generating them.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::currentEvent): Make const.
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::crypto): Not implemented. (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::captureEvents): Not implemented. (WebCore::JSDOMWindow::releaseEvents): Ditto.
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update test result for new nop window.crypto behavior.

  • http/tests/security/cross-frame-access-get-expected.txt:
16:42 Changeset [42429] by weinig@apple.com
  • 4 edits in trunk/LayoutTests

2009-04-12 Sam Weinig <sam@webkit.org>

Update results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
16:10 Changeset [42428] by weinig@apple.com
  • 10 edits in trunk

WebCore:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move more attributes out of JSDOMWindowBase by
partially generating them.

  • Expose the MessagePort constructor.
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xMLHttpRequest): (WebCore::JSDOMWindow::xSLTProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update tests after making MessageChannel completely missing when not
compiling with support for it (and removing it from the tests because
we never compile with support for it right now) and exposing the MessagePort
constructor.

  • fast/dom/constructors-cached-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/resources/constructors-cached.js:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
10:57 Changeset [42427] by timothy@apple.com
  • 2 edits in trunk/WebCore

A resource's filename is not correct after a redirect in the Inspector.

Reviewed by Dan Bernstein.

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): Fix a typo in the lastPathComponent property name.
09:24 Changeset [42426] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-12 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test: editing/inserting/6609479-1.html

Follow-up to <rdar://problem/6609479>.

Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
at the start of a paragraph.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):

LayoutTests:

2009-04-12 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Another test for <rdar://problem/6609479>. This covers inserting HTML in a quoted table.

  • editing/inserting/6609479-1-expected.txt: Added.
  • editing/inserting/6609479-1.html: Added.

04/11/09:

22:49 Changeset [42425] by adele@apple.com
  • 8 edits
    2 adds in trunk

WebCore:

2009-04-11 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

Test: editing/inserting/6609479.html

Don't break a blockquote if pasting or inserting into a table.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):

LayoutTests:

2009-04-11 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

  • editing/inserting/5418891.html: Changed test so it doesn't involve tables.
  • editing/inserting/6609479-expected.txt: Added.
  • editing/inserting/6609479.html: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5418891-expected.txt:
18:11 Changeset [42424] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6643103> Unscaled values from body.scrollHeight

Test: fast/css/zoom-body-scroll.html

Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
setters.

  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6643103> Unscaled values from body.scrollHeight
  • fast/css/zoom-body-scroll-expected.txt: Added.
  • fast/css/zoom-body-scroll.html: Added.

04/10/09:

22:40 Changeset [42423] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Jon Honeycutt.

  • fix <rdar://problem/6752340> Light blue-green background in content area in Mail
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Use device white, rather than calibrated white, as the default background color.
22:31 Changeset [42422] by timothy@apple.com
  • 8 edits in trunk/WebCore

Allow page navigation and reload while stopped at a breakpoint.

<rdar://problem/6781108> Having a breakpoint active prevents page reload

Reviewed by Darin Adler.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue): Call the resumedScript function.
  • inspector/InspectorController.h: Added didContinue.
  • inspector/JavaScriptDebugListener.h: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
  • inspector/front-end/inspector.js: (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
19:18 Changeset [42421] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Land corrected results for complex-character-based-fallback.html

  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
17:56 Changeset [42420] by darin@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2009-04-10 Darin Adler <darin@apple.com>

Rubber stamped by Adam Roben.

Disabled fast/dom/gc-8.html, which was using Timer in an unsafe way that now
triggers an assertion.

We'll reenable the test after fixing the problem. But this is a test-only problem.

  • fast/dom/gc-8.html: Removed.
  • fast/dom/gc-8.html-disabled: Copied from fast/dom/gc-8.html.
17:47 Changeset [42419] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC


r21436 changed the semantics of AXObjectCache::get() to not create
objects on demand. Changing this get() call into a getOrCreate() call
fixes the crash.


Rubber stamped by Jon Honeycutt.

  • AccessibleDocument.cpp: (AccessibleDocument::AccessibleDocument):
17:43 Changeset [42418] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Remove unused include for JSLock.

  • page/mac/FrameMac.mm:
17:41 Changeset [42417] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Add back the keepAlive timer for after the script execution to
protect the callers of evaluate, as was part of the original intent
of timer.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • page/mac/FrameMac.mm:
17:39 Changeset [42416] by mitz@apple.com
  • 7 edits
    3 adds in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • test and expected result updates following r42379
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt: Updated results.
  • fast/text/offsetForPosition-cluster-at-zero.html: Removed font-dependent alert that was accidently left in this test.
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.txt: Added.
  • platform/win/Skipped:
17:26 Changeset [42415] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Fixed https://bugs.webkit.org/show_bug.cgi?id=25137

If we reload, the animation controller sticks around and has
a stale animation time. So the needed delay is computed wrong.
I added a reset of the animation timer on load.

I did not do a test case because this only happens on reload so I
couldn't make an automated test. I tried using an iframe and using
reload() but that doesn't tickle the bug.

17:13 Changeset [42414] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Add our new test font to the list that DRT knows about

Reviewed by Dan Bernstein.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Added WebKit Layout Tests 2.ttf.
17:10 Changeset [42413] by darin@apple.com
  • 4 edits in trunk/WebCore

2009-04-10 Grace Kloba <klobag@gmail.com>

Reviewed by Darin Adler.

Move WORKERS header files inside ENABLE(WORKERS).
So if WORKERS is not enabled and the generated files are not generated, the build is still working.

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSMessageChannelConstructor.cpp:
  • bindings/js/ScheduledAction.cpp:
16:59 Changeset [42412] by darin@apple.com
  • 7 edits in trunk

WebCore:

2009-04-10 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.
This adds some diagnostics so we'll catch that kind of mistake immediately.

  • platform/Timer.cpp: (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions. (WebCore::TimerBase::start): Assert it's the same thread the timer was created on. (WebCore::TimerBase::stop): Ditto. (WebCore::TimerBase::isActive): Ditto. (WebCore::TimerBase::setNextFireTime): Ditto.
  • platform/Timer.h: Added the thread identifier data member.

WebKit/mac:

2009-04-10 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.

  • History/WebHistoryItem.mm: (-[WebWindowWatcher windowWillClose:]): Call later on main thread, if called on non-main thread.
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView _updateControlTints]): Added. Factored out the non-thread-safe part of our override of _windowChangedKeyState. (-[WebHTMLView _windowChangedKeyState]): Call _updateControlTints later on main thread, if called on non-main thread.
  • WebView/WebPreferences.mm: (-[WebPreferences _postPreferencesChangesNotification]): Call later on main thread, if called on non-main thread
16:39 Changeset [42411] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Add our invidual IDL files back to Interfaces.vcproj, but disable them

This allows the IDL files to be found in Solution Explorer.

Rubber-stamped in advance by Steve Falkenburg.

  • WebKit.vcproj/Interfaces.vcproj:
16:19 Changeset [42410] by simon.fraser@apple.com
  • 5 edits
    2 adds in trunk

2009-04-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25108

If you remove a class with a transition while that transition is running
the animation timer will continue to fire after the transition is finished.
This has no visual indication, but it does drain the processor. And in some
cases it might even cause a glitch in future animations. Unfortunately there
is no way to test this without putting in printfs.

This happens because the animation logic is never traversed after a transition
is removed, so we never get a chance to cleanup. So I added cleanup in the logic
that fires the dispatch of the last style change when the animation finishes.

Test: transitions/remove-transition-style.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
15:52 Changeset [42409] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6648858>
CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241

The Frame (and therefore ScriptController) were being destroyed
during JavaScript execution causing the JSDOMWindowShell to become
null.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame instead of the keep-alive timer, since a nested event loop used from with-in JavaScript execution could cause the timer to fire before returning.
15:30 ApplicationsGtk edited by evandrofisico@gmail.com
Correct claws-mail webkit plugin URL (diff)
15:27 Changeset [42408] by dglazkov@chromium.org
  • 7 edits in trunk/WebCore

2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25133
Fix an error in InspectorController's bindings, clean up a few header
includes, make empty object construction in ScriptObject less ambiguous.

  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::setSetting): Send correct argument from

the bindings.

  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::createNew): Added.
  • bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
  • inspector/ConsoleMessage.cpp: Remove unused header.
  • inspector/ConsoleMessage.h: Ditto.
  • inspector/InspectorResource.cpp: (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
14:50 Changeset [42407] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Reviewed by Adam Roben.

  • re-enable css2.1 tests that were disabled following r42379 and make them use a different fallback font for certain characters, to get the vertical metrics to match Mac
  • platform/win/Skipped:
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
14:44 Changeset [42406] by cmarrin@apple.com
  • 3 edits in trunk/WebCore

Fixed https://bugs.webkit.org/show_bug.cgi?id=25134

This both fixes a bug where I was not sending in the right time
to continue the animation and was not recomputing current time
when coming out of suspend.

13:48 Changeset [42405] by eric.carlson@apple.com
  • 3 edits in trunk/WebKitLibraries

2009-04-10 Eric Carlson <eric.carlson@apple.com>

WebKitSystemInterface changes for <rdar://problem/6646998>

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:41 Changeset [42404] by timothy@apple.com
  • 1 edit in trunk/WebCore/bindings/js/ScriptCachedFrameData.cpp

Revert an unintentional logic change in r42400.

13:17 Changeset [42403] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitLibraries

2009-04-10 Simon Fraser <simon.fraser@apple.com>

Fix the leopard build by updating WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
13:07 Changeset [42402] by timothy@apple.com
  • 3 edits
    1 delete in trunk/WebKit

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

WebKit:

2009-04-10 Timothy Hatcher <timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-04-10 Timothy Hatcher <timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • Misc/DOMDocumentPrivate.h: Removed.
13:05 Changeset [42401] by aroben@apple.com
  • 2 edits in trunk/WebCore

Give Windows's <select> popup menus drop shadows

Rubber-stamped by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
13:00 Changeset [42400] by timothy@apple.com
  • 4 edits in trunk/WebCore

Fix a bug in the Web Inspector where it would show scripts
from previous pages when toggling the debugger off and back on.

https://bugs.webkit.org/show_bug.cgi?id=25095
rdar://problem/6769970

Reviewed by John Sullivan.

  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the debugger for the scriptController. This balances the attachDebugger that was already in ScriptCachedFrameData::restore. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Clear the debugger from the current window before setting the new window.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate source providers for code associated this as the debugger.
12:17 Changeset [42399] by eric.carlson@apple.com
  • 7 edits in trunk

2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

When possible avoid asking QTKit for the MIME types that require QTKitServer
when running 64-bit.

  • WebCore.base.exp: Added new entry point.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add an NSArray of types to the cache. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does not start QTKitServer if it is not already running). (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid starting QTKitServer if possible.
  • platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes.
11:55 Changeset [42398] by aroben@apple.com
  • 2 edits in trunk/WebCore

Turn on window animations for <select> popup menus

We turned these off back when <select> popup menus were partially
transparent. Now that they're opaque, there's no reason not to
animate them.

Reviewed by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the window animation.
11:39 Changeset [42397] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • skip failures following r42379 until they are addressed by code changes or test changes
  • platform/win/Skipped:
11:32 Changeset [42396] by mitz@apple.com
  • 6 edits in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix a regression from r42379 which made zero-width characters affect line height

Test: fixes fast/text/wide-zero-width-space.html

  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation): Add to the fallback font list set here, and only if the glyph is not zero-width... (WebCore::ATSULayoutParameters::initialize): ...instead of doing it here. This matches WidthIterator's behavior.

LayoutTests:

Reviewed by Sam Weinig.

  • revert broken test results that were checked in with r42379, now that the regression is fixed
  • platform/mac/fast/text/wide-zero-width-space-expected.checksum:
  • platform/mac/fast/text/wide-zero-width-space-expected.png:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt:
11:31 Changeset [42395] by aroben@apple.com
  • 4 edits in trunk/LayoutTests

Update Windows results for complex-character-based-fallback.html

Rubber-stamped by Dan Bernstein.

  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Updated.
10:39 Changeset [42394] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-10 Darin Fisher <darin@chromium.org>

Fixing build bustage caused by warnings being treated as errors.
1- A local variable was only be used inside a debug assertion, which

caused grief for the release build.

2- Missing initializer for member 'DocumentMarker::activeMatch'

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::setMarkersActive):
10:24 Changeset [42393] by darin@chromium.org
  • 9 edits in trunk/WebCore

2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by John Sullivan.

Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
(TextMatches don't have a concept of active match)

For the ports that use the DocumentMarker as highlighting for FindInPage it is
useful to have a flag that specifies which marker is active, so it can be drawn
in a different color.

This allows me to remove the hack to use the SelectionController to highlight
the active match (in the ChromiumWin port).

  • dom/Document.cpp: (WebCore::Document::setMarkersActive):
  • dom/Document.h:
  • dom/DocumentMarker.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformActiveTextSearchHighlightColor): (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
  • rendering/RenderThemeChromiumWin.h:
10:13 Changeset [42392] by pam@chromium.org
  • 2 edits in trunk/WebCore

2009-04-10 Pamela Greene <pam@chromium.org>

Reviewed by Dimitri Glazkov.

Build fix for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=12440

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
05:03 Changeset [42391] by kov@webkit.org
  • 13 edits in trunk/WebKit/gtk

WebKit/gtk/

2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Mark the missing strings for translation.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_cancel):
  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
  • webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp:

WebKit/gtk/po/

2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Extracting translation for the files that got translation calls.

  • POTFILES:
  • de.po:
  • pt_BR.po:
  • webkit.pot:

04/09/09:

22:42 Changeset [42390] by mitz@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests
  • remove two files I just checked in by accident
  • platform/mac/fast/events/pointer-events-expected.txt: Removed.
  • platform/mac/fast/events/pointer-events.html: Removed.
22:36 Changeset [42389] by mitz@apple.com
  • 7 edits
    9 copies
    17 adds in trunk/LayoutTests

Reviewed by Mark Rowe.

  • moved some Leopard-and-earlier results into platform/mac-leopard and added new results under platform/mac
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.checksum.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
  • platform/mac/fast/events/pointer-events-expected.txt: Added.
  • platform/mac/fast/events/pointer-events.html: Added.
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum: Replaced.
  • platform/mac/fast/text/complex-text-opacity-expected.png: Replaced.
  • platform/mac/fast/text/complex-text-opacity-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
20:58 Changeset [42388] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-09 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed Gtk build fix for undefined reference: g_thread_init.
Add GLIB_LIBS to DRT and GtkLauncher build config.

  • GNUmakefile.am:
20:38 Changeset [42387] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Remove two tests from the skipped list now that <rdar://problem/6718460> has been addressed.

  • platform/mac-snowleopard/Skipped:
20:38 Changeset [42386] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip a few tests that are currently failing.

Rubber-stamped by Oliver Hunt.

  • platform/mac-snowleopard/Skipped:
20:23 Changeset [42385] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • update Tiger-only test results after r42379
  • platform/mac-tiger/fast/lists/w3-list-styles-expected.txt:
  • platform/mac-tiger/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
20:15 Changeset [42384] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt

Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
following DOM events and JavaScript timeouts. Eventually these calls will be removed.

Where the timer will really kick in and be useful is for clients that do style changes from
Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::styleRecalcTimerFired): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach):
19:24 Changeset [42383] by mrowe@apple.com
  • 1 edit
    3 copies
    1 add in trunk/LayoutTests

Land Windows-specific results for three forms tests since the Windows results match the Leopard results.

Rubber-stamped by Adam Roben.

  • platform/win/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
  • platform/win/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt.
  • platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt.
18:49 Changeset [42382] by oliver@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6586787> JS debugger does not work in 64-bit

Reviewed by Gavin Barraclough

Don't truncate the source id in JSCallFrame

18:17 Changeset [42381] by aroben@apple.com
  • 6 edits in trunk

Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

Start compiling HistoryPropertyList on Windows

Reviewed by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its dependencies to the project. Copy headers from history/cf to $WebKitOutputDir.
  • history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that this file will compile on Windows.

WebKit/win:

Windows part 1 of <rdar://problem/5438063> Saving history containing
100,000 entries causes pauses of 2s while browsing

Use HistoryPropertyListWriter to implement IWebHistory::saveToURL.

Reviewed by Darin Adler.

  • WebHistory.cpp: (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through the entries for each date, and pass the corresponding WebCore::HistoryItem to writeHistoryItem. (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize m_entriesByDate, then write the serialized data to disk using CFWriteStream.
  • WebHistory.h: Removed datesArray.
18:13 Changeset [42380] by mrowe@apple.com
  • 5 edits
    4 copies
    8 moves
    1 add in trunk/LayoutTests

Update test results to account for a slight change in +[NSColor disabledControlTextColor].

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.checksum.
  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png.
  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.checksum.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.checksum.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.png.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.txt.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.checksum.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.png.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.txt.
  • platform/mac/fast/forms/disabled-select-change-index-expected.txt:
  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
18:00 Changeset [42379] by mitz@apple.com
  • 260 edits in trunk

WebCore:

2009-04-09 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font

Covered by many existing layout tests

  • platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the platform supports collecting fallback fonts in its complex font path and fallbackFonts is not null, all fallback fonts used for the text run will be added to it.
  • platform/graphics/Font.h: (WebCore::Font::width): Ditto.
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace qualifier. (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts parameter, which is passed down to WidthIterator.
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::WidthIterator::advance): Track the fonts being used and add any fallback fonts to the m_fallbackFonts set. Make sure to only add non-small-caps fonts.
  • platform/graphics/WidthIterator.h:
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
  • platform/graphics/chromium/FontLinux.cpp: Ditto.
  • platform/graphics/gtk/FontGtk.cpp: Ditto.
  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add fallback fonts to m_fallbackFonts.
  • platform/graphics/mac/CoreTextController.h:
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the Mac implementations of floatWidthForComplexText() populate the fallbackFonts set.
  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to m_fallbackFonts. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to ATSULayoutParameters.
  • platform/graphics/mac/FontMacCoreText.cpp: (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to CoreTextController.
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the UniscribeController-based implementations of floatWidthForComplexText() populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to UniscribeController.
  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): Added a fallbackfonts parameter and used it to initialize m_fallbackFonts. (WebCore::UniscribeController::advance): Add fallback fonts to m_fallbackFonts.
  • platform/graphics/win/UniscribeController.h:


  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox with multiple fonts, compute a common baseline and line height by considering all fonts' ascents and descents (and line spacing, if applicable).
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores the set of fallback fonts in a vector. (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback fonts previously stored and removes them from storage.
  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Initialized the m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::styleDidChange): Reset m_knownNotToUseFallbackFonts to false if the style difference is such that affects layout. (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter, which is passed down to Font::width(). (WebCore::RenderText::trimmedPrefWidths): Updated for the change to widthFromCache(). (WebCore::RenderText::calcPrefWidths): Made this call a private version of calcPrefWidths() that takes a fallbackFonts parameter and set the m_knownNotToUseFallbackFonts to true if the set comes back empty. The private version passes the fallbackFonts set to widthFromCache(). (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::createFallbackFontMetricsBox): Added. (WebCore::RenderText::width): Added a fallbackFonts parameter, which is passed down to calcPrefWidths(), widthFromCache() and Font::width(). Set m_knownNotToUseFallbackFonts to true when appropriate.
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): Added an assertion and a continue statement to remove one level of indentation. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily store the set of fallback fonts in the InlineTextBox. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an assertion.

LayoutTests:

2009-04-09 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

  • updated results for <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font
  • editing/selection/extend-selection-bidi-expected.txt:
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/editing/deleting/5144139-2-expected.checksum:
  • platform/mac/editing/deleting/5144139-2-expected.png:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/mac/editing/input/devanagari-ligature-expected.checksum:
  • platform/mac/editing/input/devanagari-ligature-expected.png:
  • platform/mac/editing/input/devanagari-ligature-expected.txt:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/lists/w3-list-styles-expected.checksum:
  • platform/mac/fast/lists/w3-list-styles-expected.png:
  • platform/mac/fast/lists/w3-list-styles-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/fast/text/wide-zero-width-space-expected.checksum:
  • platform/mac/fast/text/wide-zero-width-space-expected.png:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt:
17:24 Changeset [42378] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Hyatt.

<rdar://problem/4680397> tearing seen because deferred updates are disabled


  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Don't call WKDisableCGDeferredUpdates on post-Leopard if NSAppKitVersionNumberWithDeferredWindowDisplaySupport is defined.
17:05 Changeset [42377] by hyatt@apple.com
  • 68 edits in trunk/WebCore

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben

Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
explicitly instead.

  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptControllerMac.mm: (WebCore::updateStyleIfNeededForBindings): (WebCore::ScriptController::initJavaJSBindings):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged): (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
  • css/CSSVariablesDeclaration.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::recalcStyle): (WebCore::Document::updateStyleIfNeeded): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::updateLayout): (WebCore::Document::implicitClose): (WebCore::Document::prepareMouseEvent): (WebCore::Document::setFocusedNode): (WebCore::Document::setCSSTarget):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges):
  • dom/InputElement.cpp: (WebCore::InputElement::parseMaxLengthAttribute):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h: (WebCore::Node::needsStyleRecalc): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::setChildNeedsStyleRecalc):
  • dom/OptionElement.cpp: (WebCore::OptionElement::setSelectedState):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable):
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::layout): (WebCore::SelectionController::focusedOrActiveStateChanged):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable): (WebCore::HTMLElement::contentEditable):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::recalcStyle):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setAutofilled):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::finishParsingChildren):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::typeAheadFind):
  • html/HTMLTableElement.cpp: (WebCore::setTableCellsChanged): (WebCore::HTMLTableElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::gotoAnchor):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt):
  • page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired):
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout):
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setNeedsStyleRecalc): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer): (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::animationTimerFired): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationController::cancelAnimations):
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::sendAnimationEvent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateDragState):
  • rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::svgAttributeChanged):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::svgAttributeChanged):
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::setNeedsUpdate):
  • svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap):
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::childrenChanged): (WebCore::SVGUseElement::recalcStyle):
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::parseMappedAttribute):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
16:53 Changeset [42376] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-09 John Sullivan <sullivan@apple.com>

<rdar://problem/6775682> WebKit's support for SnowLeopard sudden termination for
downloads is broken and should be removed

Reviewed by Darin Adler

  • Misc/WebDownload.m: (-[WebDownloadInternal downloadDidBegin:]): remove disableSuddenTermination call (-[WebDownloadInternal downloadDidFinish:]): remove enableSuddenTermination call (-[WebDownloadInternal download:didFailWithError:]): remove enableSuddenTermination call
16:52 Changeset [42375] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-04-09 Brett Wilson <brettw@chromium.org>

Reviewed by NOBODY (OOPS!).

When there is a shadow set but it specifies "no shadow", clear the
shadow shader. This will prevent Chromium from thinking there's a
shadow and using the Skia codepath rather than Windows.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
16:01 Changeset [42374] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Simon Fraser.

Crash when accessing svg.viewport on a detached SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=25105

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as t

o what behavior we should have in this case, and I doubt anyone cares for now).

15:42 Changeset [42373] by dimich@chromium.org
  • 5 edits in trunk/WebCore

2009-04-09 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25084
Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
15:40 Changeset [42372] by darin@apple.com
  • 6 edits
    5 adds in trunk

WebCore:

2009-04-09 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson and Sam Weinig.

Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.

  • WebCore.base.exp: Added new entry points.
  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • history/cf: Added.
  • history/cf/HistoryPropertyList.cpp: Added.
  • history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also have code for reading here too.
  • platform/cf/BinaryPropertyList.cpp: Added.
  • platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.

WebKit/mac:

2009-04-09 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson and Sam Weinig.

Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.

  • History/WebHistory.mm: (-[WebHistoryPrivate data]): Added. Returns the NSData object containing serialized history. For creating new SPI so you can get the data in memory instead of on disk. Uses WebHistoryWriter. (-[WebHistoryPrivate saveToURL:error:]): Changed to call [self data (-[WebHistory _data]): Added. (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added.
  • History/WebHistoryPrivate.h: Added a new _data method.
15:25 Changeset [42371] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-04-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=25122

If deferred repainting is active, we need to ensure that there are no repaints
pending at the end of layoutIfNeededRecursive, which is called just before
painting via -viewWillDraw.

  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive):
15:08 Changeset [42370] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/dom/Document.cpp

Removed duplicate header include.

14:35 Changeset [42369] by mthole@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-09 Mike Thole <mthole@apple.com>

Rubber-stamped by Mark Rowe.

Fix 64-bit build

  • Panels/WebAuthenticationPanel.h:

Declare the 'separateRealmLabel' IBOutlet as an NSTextField instead of 'id'.
This fixes a duplicate method warning (setAutoresizingMask: on NSView and CALayer)

13:45 Changeset [42368] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-09 John Grabowski <jrg@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25117
Fix Mac Chromium form controls.

  • rendering/RenderThemeChromiumMac.mm: When rendering native controls in Mac Chromium, use a clean NSGraphicsContext. Properly save and restore native graphics context. (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
13:45 Changeset [42367] by levin@chromium.org
  • 7 edits
    1 add in trunk/WebCore

2009-04-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=25030
Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
instead of a real MessagePort for the entangledPort, since it could
theoretically live in a separate process.

The goal of this refactoring is to remove all assumptions that the object
representing the entangled port is actually of type MessagePort. All
operations that were previously directly modifying private MessagePort member
variables in the entangled port (i.e. entangle(), postMessage()) have been changed
to invoke functions in the MessagePortProxy interface instead which will allow
the Chrome bindings to proxy these calls to another process.

No new layout tests, as this is just a refactoring with no bug fixes
or new functionality.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • dom/MessagePort.cpp: (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::deliverMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::unentangle):
  • dom/MessagePort.h: (WebCore::MessagePort::entangledPort):
  • dom/MessagePortProxy.h: Added. (WebCore::MessagePortProxy::~MessagePortProxy):
13:45 Changeset [42366] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-04-09 Ben Murdoch <benm@google.com>

Reviewed by Alexey Proskuryakov.

The Android platform requires threads to be registered with the VM.
This patch implements this behaviour inside ThreadingPthreads.cpp.

  • wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM. (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards. (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly.
11:30 Changeset [42365] by weinig@apple.com
  • 4 edits
    7 adds in trunk

WebCore:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Big Boy" Garen.

Fix for <rdar://problem/5745677> Possible to stop load during an unload event
Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605

Tests: fast/events/stop-load-in-unload-handler-using-document-write.html

fast/events/stop-load-in-unload-handler-using-window-stop.html

Don't allow calling methods that would stop the new load inside the unload
event.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
  • loader/FrameLoader.h:

LayoutTests:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Big Boy" Garen.

Tests for <rdar://problem/5745677> Possible to stop load during an unload event

  • fast/events/resources/pass.html: Added.
  • fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
  • fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
  • fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
  • fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
  • fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
  • fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
10:32 Changeset [42364] by mthole@apple.com
  • 2 edits in trunk/WebKit

2009-04-09 Mike Thole <mthole@apple.com>

Reviewed by Adam Roben.

  • WebKit.xcodeproj/project.pbxproj:

Set the Localizable.strings encoding to UTF-16.

10:06 Changeset [42363] by mthole@apple.com
  • 6 edits in trunk/WebKit

2009-04-09 Mike Thole <mthole@apple.com>

Reviewed by Ada Chan.

<rdar://problem/5697111> Basic authentication dialog spoofing vulnerability

  • Panels/WebAuthenticationPanel.h:

Added IBOutlet for separateRealmLabel

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):

In the realm case, decide if it is a simple or complex realm name. A realm name
is considered complex if it has any whitespace or newline characters. Present
alternative text and layout for the complex case, where the realm name isn't inline
with the rest of the sheet's text.


  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

Updated the nib with a new 'separateRealmLabel' outlet.
Updated the File's Owner to correctly be WebAuthenticationPanel.
Fixed springs on the sheet's icon to keep it from moving during a resize.

09:43 Changeset [42362] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Update results for createDocument-namespace-err.html

It looks like the test was changed without updating the results before
it was committed.

Rubber-stamped by Adele Peterson.

  • fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt: Updated.
09:33 Changeset [42361] by ddkilzer@apple.com
  • 20 edits in trunk

Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings

Rolled r42345 back in. The build failure was caused by an
internal script which had not been updated the same way that
build-webkit was updated.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

  • Configurations/WebCore.xcconfig:
  • DerivedSources.make:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _wrapNode:WebCore::]):
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:

WebKit/mac:

  • Configurations/WebKit.xcconfig:
  • DOM/WebDOMOperations.mm:
  • MigrateHeaders.make:

WebKitTools:

  • Scripts/build-webkit:
09:30 Changeset [42360] by simon.fraser@apple.com
  • 10 edits in trunk/WebCore

2009-04-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25109

Eliminate CompositeAnimationPrivate, which was a needless level
of abstraction. Remove the methods like addToStyleAvailableWaitList()
that simply turn around and call the animation controller.

Rename animationControllerPriv() to animationController().
Rename willNeedService() to timeToNextService().

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::~AnimationBase): (WebCore::AnimationBase::updateStateMachine): (WebCore::AnimationBase::timeToNextService): (WebCore::AnimationBase::beginAnimationUpdateTime):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
  • page/animation/CompositeAnimation.h: (WebCore::CompositeAnimation::animationController): (WebCore::CompositeAnimation::isSuspended): (WebCore::CompositeAnimation::hasAnimations): (WebCore::CompositeAnimation::CompositeAnimation):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::timeToNextService):
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::timeToNextService):
  • page/animation/KeyframeAnimation.h:
09:13 Changeset [42359] by levin@chromium.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-04-09 David Levin <levin@chromium.org>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=25101

Launch DumpRenderTree and the image diff tool in a way that will work from perl threads.
This is a workaround due to a perl limitation. When perl does open* calls on a thread, it ignores
the environment of the current thread and simply uses the environment of the main thread instead.

  • Scripts/execAppWithEnv: Added.
  • Scripts/run-webkit-tests:
06:49 Changeset [42358] by ap@webkit.org
  • 20 edits in trunk

Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
It broke Mac build, and I don't know how to fix it.

06:17 Changeset [42357] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

RenderView::docWidth() was made private by r42334. That commit
changes its usage for overflowWidth(), so do that here too.

  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
05:29 Changeset [42356] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-04-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Checking for GLIBCXX being bigger than some date is not enough
to get std::tr1, C++0x has to be in use too. Add another check for
GXX_EXPERIMENTAL_CXX0X.

  • wtf/TypeTraits.h:
04:20 Changeset [42355] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Implement AtkObject::ref_state_set. Still quite a few states not
implemented.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
04:17 Changeset [42354] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Move fallback object creation to its own function, as it will be
used in several places.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp: (fallbackObject):
04:15 Changeset [42353] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Move AccessibilityObject methods to their file.

  • page/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::wrapper): (WebCore::AccessibilityObject::setWrapper):
  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
04:08 Changeset [42352] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Rework accessibility type generation code, based on Mozilla a11y
implementation.

Have one base a11y type, and generate derived types that implement
only the necessary interfaces at runtime, based on the specific
object we are wrapping. This allows to save a lot of code while
covering all possible cases.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
03:40 Changeset [42351] by eric@webkit.org
  • 4 edits
    3 adds in trunk

Reviewed by Oliver Hunt.

Fix document.implementation.createDocument(null, "a:b") not to crash!
https://bugs.webkit.org/show_bug.cgi?id=25096

Test: fast/dom/DOMImplementation/createDocument-namespace-err.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): check the exception code before using the result
00:21 Changeset [42350] by aroben@apple.com
  • 2 edits in trunk/WebCore

Make <select>s in application chrome documents match the Vista system dialog look

Reviewed by Dave Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::documentIsInApplicationChromeMode): Added this simple helper function. (WebCore::RenderThemeWin::getThemeData): In application chrome mode, the drop down button never uses any look but the "normal" look. (WebCore::RenderThemeWin::paintMenuList): In application chrome mode, use the "readonly" style to match system dialogs.
00:20 Changeset [42349] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow showing after clicking "Go Back" in phishing alert

RenderButton's m_timer is not stopped when its Document enters the
page cache. When the WebView was torn down, the timer would fire after
the Frame's Page had been destroyed, leading to a crash. This patch
just makes the timer do nothing when it fires. Making the timer not
fire when in the page cache is covered by bug 25110.

Reviewed by Dave Hyatt.

No test possible.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::timerFired): Do nothing when we're in the page cache.
00:11 Changeset [42348] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben

Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
caused the checks to be triggered too early in the loading process of the frame.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):

04/08/09:

21:17 Changeset [42347] by oliver@apple.com
  • 5 edits in trunk

Fix assertion failure in function.apply

Reviewed by Adam Roben.

The result of excess arguments to function.apply is irrelevant
so we don't need to provide a result register. We were providing
temporary result register but not ref'ing it resulting in an
assertion failure.

18:33 Changeset [42346] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Cameron Zwarich

https://bugs.webkit.org/show_bug.cgi?id=25106

Fix signature of virtual function on AnimationBase so that it matches
those in the derived classes, by removing unused parameter.

  • page/animation/AnimationBase.h: (WebCore::AnimationBase::endAnimation):
18:27 Changeset [42345] by ddkilzer@apple.com
  • 20 edits in trunk

<rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings

Reviewed by Darin Adler and Maciej Stachowiak.

Introduce the ENABLE_SVG_DOM_OBJC_BINDINGS feature define so
that SVG DOM Objective-C bindings may be optionally disabled.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES.

WebCore:

  • Configurations/WebCore.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES and EXCLUDED_SOURCE_FILE_NAMES. When SVG DOM Objective-C bindings are disabled, two generated header files no longer exist and none of the generated DOMSVG*.mm files should be compiled.
  • DerivedSources.make: All of the WebCore.SVG*.exp files contain SVG DOM Objective-C bindings classes, so exclude them unless ENABLE_SVG_DOM_OBJC_BINDINGS is set.
  • bindings/objc/DOM.mm: Switched from using ENABLE(SVG) to using ENABLE(SVG_DOM_OBJC_BINDINGS). (WebCore::createElementClassMap): (+[DOMNode _wrapNode:WebCore::]):
  • bindings/objc/DOMCSS.mm: Ditto. (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  • bindings/objc/DOMEvents.mm: Ditto. (+[DOMEvent _wrapEvent:WebCore::]):
  • bindings/objc/DOMInternal.h: Ditto.
  • bindings/objc/ExceptionHandlers.mm: Added use of ENABLE(SVG_DOM_OBJC_BINDINGS). (WebCore::raiseDOMException):
  • html/HTMLEmbedElement.idl: Excluded -getSVGDocument method in generated Objective-C DOM classes if SVG DOM Objective-C bindings are disabled.
  • html/HTMLFrameElement.idl: Ditto.
  • html/HTMLIFrameElement.idl: Ditto.
  • html/HTMLObjectElement.idl: Ditto.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Added ENABLE_SVG_DOM_OBJC_BINDINGS variable and use it in FEATURE_DEFINES.
  • DOM/WebDOMOperations.mm: Removed unused header.
  • MigrateHeaders.make: Switched from using ENABLE_SVG to using ENABLE_SVG_DOM_OBJC_BINDINGS.

WebKitTools:

  • Scripts/build-webkit: Added --[no-]svg-dom-objc-bindings command-line argument. Set special ENABLE_SVG_DOM_OBJC_BINDINGS Xcode variable required by WebCore.xcconfig.
18:14 Changeset [42344] by levin@chromium.org
  • 8 edits
    1 add in trunk/JavaScriptCore

2009-04-08 Paul Pedriana <ppedriana@ea.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20422
Allow custom memory allocation control.

  • wtf/FastAllocBase.h: New added file. Implements allocation base class.
  • wtf/TypeTraits.h: Augments existing type traits support as needed by FastAllocBase.
  • wtf/FastMalloc.h: Changed to support FastMalloc match validation.
  • wtf/FastMalloc.cpp: Changed to support FastMalloc match validation.
  • wtf/Platform.h: Added ENABLE_FAST_MALLOC_MATCH_VALIDATION; defaults to 0.
  • GNUmakefile.am: Updated to include added FastAllocBase.h.
  • JavaScriptCore.xcodeproj/project.pbxproj: Updated to include added FastAllocBase.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Updated to include added FastAllocBase.h.
17:07 Changeset [42343] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/js/toString-stack-overflow.html on Windows

This test sometimes crashes in Debug builds.

Rubber-stamped by Geoff Garen.

  • platform/win/Skipped: Skip toString-stack-overflow.html.
16:43 Changeset [42342] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • limit the workaround for <rdar://problem/5781372> to Mac OS X versions that need it
  • platform/mac/WebFontCache.mm: (fixUpWeight): Changed this function to be a no-op post-Leopard.
16:37 Changeset [42341] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6771547> Appending to a RenderText causes all its lines to be dirtied

Test: fast/repaint/text-append-dirty-lines.html

  • rendering/RenderText.cpp: (WebCore::RenderText::setTextWithOffset): If no text boxes intersected with or came after the new text, dirty the last root box, since the new text may begin there. Having at least one dirty line prevents the incorrect dirtying of all lines later during layoutInlineChildren().

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/6771547> Appending to a RenderText causes all its lines to be dirtied
  • fast/repaint/text-append-dirty-lines.html: Added.
  • platform/mac/fast/repaint/text-append-dirty-lines-expected.checksum: Added.
  • platform/mac/fast/repaint/text-append-dirty-lines-expected.png: Added.
  • platform/mac/fast/repaint/text-append-dirty-lines-expected.txt: Added.
16:24 Changeset [42340] by darin@chromium.org
  • 7 edits in trunk

2009-04-08 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25100

Fixes a Chromium-specific crash in WebCore::ImageBuffer::context that
occurs when rendering semi-transparent RTL text.

Test: fast/text/complex-text-opacity.html

  • platform/graphics/chromium/FontChromiumWin.cpp: Handle RTL when computing text bounds. (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds):
16:17 Changeset [42339] by weinig@apple.com
  • 1 edit
    7 adds in trunk/LayoutTests

2009-04-08 Sam Weinig <sam@webkit.org>

Add Windows specific results.

  • platform/win/http/tests/security: Added.
  • platform/win/http/tests/security/XFrameOptions: Added.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
16:14 Changeset [42338] by weinig@apple.com
  • 1 edit
    6 adds in trunk/LayoutTests

2009-04-08 Sam Weinig <sam@webkit.org>

Add Tiger specific results.

  • platform/mac-tiger/http/tests/security: Added.
  • platform/mac-tiger/http/tests/security/XFrameOptions: Added.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
16:08 Changeset [42337] by oliver@apple.com
  • 24 edits
    3 adds in trunk

Improve function.apply performance

Reviewed by Geoff Garen.

Jump through a few hoops to improve performance of function.apply in the general case.

In the case of zero or one arguments, or if there are only two arguments and the
second is an array literal we treat function.apply as function.call.

Otherwise we use the new opcodes op_load_varargs and op_call_varargs to do the .apply call
without re-entering the virtual machine.

16:06 Changeset [42336] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin

Fix a porting error in my previous patch. A != was supposed to be an ==.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
16:02 Changeset [42335] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/cookies/local-file-can-set-cookies.html on Windows

Reviewed by John Sullivan.

  • platform/win/Skipped: Skip local-file-can-set-cookies.html, which is failing due to a bug in one of our dependencies.
15:33 Changeset [42334] by hyatt@apple.com
  • 22 edits
    4 adds in trunk

WebCore:

2009-04-08 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben and Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, repaints inconsistent for
fixed positioned elements.

Rewrite the updateScrollers method to be more correct in its results.

Test: fast/block/positioning/fixed-positioning-scrollbar-bug.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::implicitClose):
  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout): (WebCore::FrameView::adjustPageHeight):
  • page/FrameView.h:
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
  • platform/ScrollView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::layout): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth):
  • rendering/RenderView.h:

WebKit/mac:

2009-04-08 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben and Darin Adler

Fix for https://bugs.webkit.org/show_bug.cgi?id=12440, fixed positioned elements end up in
inconsistent positions. Rewrite updateScrollers to improve the correctness.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):

LayoutTests:

2009-04-08 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben and Darin Adler

Updated results and new tests for https://bugs.webkit.org/show_bug.cgi?id=12440.

  • fast/block/positioning/fixed-positioning-scrollbar-bug.html: Added.
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.checksum: Added.
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.txt: Added.
  • platform/mac/fast/flexbox/016-expected.checksum:
  • platform/mac/fast/flexbox/016-expected.png:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/flexbox/flex-hang-expected.checksum:
  • platform/mac/fast/flexbox/flex-hang-expected.png:
  • platform/mac/fast/flexbox/flex-hang-expected.txt:
  • platform/mac/fast/lists/001-expected.checksum:
  • platform/mac/fast/lists/001-expected.png:
  • platform/mac/fast/lists/001-expected.txt:
15:16 Changeset [42333] by weinig@apple.com
  • 6 edits
    23 adds in trunk

WebCore:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense

Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html

http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse the X-FRAME-OPTIONS parameter.
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and a X-FRAME-OPTIONS header and its parameter dictate that we should.

LayoutTests:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Tests for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense

  • http/tests/security/XFrameOptions: Added.
  • http/tests/security/XFrameOptions/resources: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-allow.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-deny.cgi: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-deny.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-deny.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html: Added.
13:57 Changeset [42332] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Fix security/block-test-no-port.html on Windows

Reviewed by Beth Dakin.

  • WebMutableURLRequest.cpp: (WebMutableURLRequest::mainDocumentURL): Return the ResourceRequest's mainDocumentURL, not its URL.
13:31 Changeset [42331] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fix http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html on Windows

Reviewed by Sam Weinig.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Mimic the ResourceHandleMac code by propagating the CFError's error code for kCFErrorDomainCFNetwork errors to the ResourceResponse.
11:56 Changeset [42330] by abarth@webkit.org
  • 1 edit
    6 copies
    3 moves
    4 adds in trunk/LayoutTests

2009-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

More tests for our handling of MIME types and style sheets.

  • http/tests/mime/resources/style-with-charset.php: Added.
  • http/tests/mime/resources/style-with-empty-content-type.cgi: Renamed from LayoutTests/http/tests/mime/resources/style.cgi.
  • http/tests/mime/resources/style-with-text-plain.php: Added.
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt: Added.
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension.html: Added.
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt: Added.
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain.html: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension-expected.txt: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension.html: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset-expected.txt: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset.html: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type-expected.txt: Renamed from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt.
  • http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html: Removed.
11:54 Changeset [42329] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 Anders Carlsson <andersca@apple.com>

Try to fix the PPC build.


  • plugins/npfunctions.h:
11:36 Changeset [42328] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/5908616> tokenizer resizer should handle edge cases consistently

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::enlargeBuffer): Handle edge cases the same way as a failed fastMalloc. (WebCore::HTMLTokenizer::enlargeScriptBuffer): Ditto.
11:28 Changeset [42327] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler

Make sure that cloneNode works with SVG attributes that require synchronization. This fixes
issues with <use> element shadow tree cloning where the clones can end up not obtaining the
correct attribute values.

A subsequent patch of mine will expose this problem and cause it to be covered by existing
layout tests, so no test is required at this time for this problem.

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren):
10:58 Changeset [42326] by aroben@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Check in Windows-specific results for an SVG test that was failing due to rounding issues

Rubber-stamped by Dave Hyatt.

  • platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
10:52 Changeset [42325] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-04-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25093
REGRESSION: some scripts are showing in the Inspector with only "true"
as the source.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): Fixed conversion issue. (WebCore::InspectorController::failedToParseSource): Ditto.
10:07 Changeset [42324] by darin@chromium.org
  • 15 edits
    2 deletes in trunk

Reverting r42321 because it broke some layout tests.

09:39 Changeset [42323] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add a failing test to the Windows Skipped file

  • platform/win/Skipped: Added media/video-size-intrinsic-scale.html.
09:25 Changeset [42322] by abarth@webkit.org
  • 3 edits
    5 adds in trunk

WebCore:

2009-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24904

Verify the MIME type of stylesheets (in standards mode) by looking
at the Content-Type header directly. This bypasses any content
sniffing that might be confusing the issue.

Test: http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::canUseSheet):

LayoutTests:

2009-04-08 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24904

Test that we apply style sheets in standards mode even if
those style sheets have an empty Content-Type header.

  • http/tests/mime/resources/style.cgi: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header-expected.txt: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-without-content-type-header.html: Added.
09:04 Changeset [42321] by darin@chromium.org
  • 15 edits
    2 adds in trunk

2009-04-07 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

Added support for returning plugins which support the wildcard mime type (*).
This is on the same lines as Firefox, which uses a wildcard plugin (npnul32.dll) for
plugin installation. The changes to support wildcard mime type matching are in
PluginDatabase.cpp which is used by Webkit's plugin implementation, and
PluginData.cpp/.h which is used by Chromium.

https://bugs.webkit.org/show_bug.cgi?id=24988

Test: plugins/netscape-plugin-wildcard-plugin.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • plugins/PluginData.cpp: (WebCore::PluginData::supportsMimeType): (WebCore::PluginData::supportsMimeTypeIgnoringWildCards):
  • plugins/PluginData.h:
  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::pluginForMIMEType):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted):
07:42 Changeset [42320] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-08 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=25041
<rdar://problem/6697754>
Bug 25041: HTMLMediaElement: OSX autoplay broken by r41907


OSX media player should set readyState to HAVE_ENOUGH_DATA when the movie's load state
reaches QTMovieLoadStatePlaythroughOK, not when the entire file has been downloaded,
so autoplay can begin when it should.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Set readState to HAVE_ENOUGH_DATA when QTMovie load state reaches QTMovieLoadStatePlaythroughOK. (WebCore::MediaPlayerPrivate::paint): Add braces missed in r42203.
07:35 Changeset [42319] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by David Kilzer. Based on a patch by Grace Kloba.

https://bugs.webkit.org/show_bug.cgi?id=24656
cacheControlContainsNoCache() in ResourceResponseBase.h is wrong

  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::parseCacheControlDirectives): Removed misused code for parsing directive values, fixing parsing of directives that we care about.
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::cacheControlContainsNoCache): Fixed a copy/paste mistake, m_cacheControlContainsMustRevalidate was returned instead of m_cacheControlContainsNoCache.
06:21 Changeset [42318] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-08 Alejandro Piñeiro <apinheiro@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Use getOrCreate instead of just get, as we need to actually create
the wrapper object the first time this function is called.

  • webkit/webkitwebview.cpp:
00:48 Changeset [42317] by aroben@apple.com
  • 2 edits in trunk/WebCore

Make text fields match the system look on Vista

Reviewed by Dave Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Use the new-to-Vista EP_EDITBORDER_NOSCROLL part for text fields.
00:47 Changeset [42316] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Print the number of files being compiled when using pdevenv

  • Scripts/parallelcl:
00:06 Changeset [42315] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25073
JavaScriptCore tests don't run if time zone is not PST

  • API/tests/testapi.c: (timeZoneIsPST): Added a function that checks whether the time zone is PST, using the same method as functions in DateMath.cpp do for formatting the result. (main): Skip date string format test if the time zone is not PST.
00:02 Changeset [42314] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=24957
REGRESSION: Google calendar widget no longer shows upcoming events

Test: http/tests/xmlhttprequest/authorization-header.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData): Removed Authorization from the list of forbidden headers.
Note: See TracTimeline for information about the timeline view.