Timeline


and

04/13/09:

23:39 Changeset [42480] by oliver@apple.com

Missed code from last patch

23:33 Changeset [42479] by hyatt@apple.com

2009-04-13 David Hyatt <hyatt@apple.com>

Reviewed by Cameron Zwarich.

Remove an outdated comment in ScrollView.h

  • platform/ScrollView.h:
23:24 Changeset [42478] by oliver@apple.com

BUG 25171: It should be possible to manually set the name of an anonymous function
<https://bugs.webkit.org/show_bug.cgi?id=25171>

Submitted by Francisco Tolmasky <francisco@280north.com>
Reviewed by Oliver Hunt.

This change adds the displayName property to functions, which when set overrides the
normal name when appearing in the console.

22:30 Moving to Git edited by jhaitas@gmail.com
trivial fix incorrect 'there' replaced with correct 'their' (diff)
22:03 Changeset [42477] by eric.carlson@apple.com

2009-04-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25177

QTTrack's -media method always return NULL in 64-bit QTKit, so
MediaPlayerPrivate::disableUnsupportedTracks should use
QTTrackMediaTypeAttribute to get a track's type.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
21:52 Changeset [42476] by ggaren@apple.com

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions

Stop using protected event listeners on the window object.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're no longer protected.

(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Create unprotected event
listeners, since we mark them now.

  • bindings/js/JSEventListener.h: Made some functions public so DOMWindow could call them.
  • bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header, so it could be shared.
  • bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking and invalidating code for the DOMWindow.
  • dom/RegisteredEventListener.h: (WebCore::markEventListeners): (WebCore::invalidateEventListeners): Added helper functions.
  • page/DOMWindow.idl: Make the window's event listener attributes not protected.
21:13 Changeset [42475] by eric.carlson@apple.com

2009-04-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Mark Rowe.

OS X standalone media documents should not switch from <video> to <embed> when
QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
with a slow network connection or when a movie is not saved fast-start.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
18:03 Changeset [42474] by dimich@chromium.org

2009-04-13 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24453
REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
the main document that timer callback makes are not flushed.

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded() since timers may affect documents other then their own.
17:21 Changeset [42473] by kov@webkit.org

2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by David Hyatt.

Check document for nullity to avoid crashing on GTK+, when
creating the WebView.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
17:19 Changeset [42472] by adachan@apple.com

Forgot to capitalize the "US".

  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
17:10 Changeset [42471] by adachan@apple.com

<rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
Revert back to the old word breaking behavior by using en_US_POSIX locale.

Reviewed by Steve Falkenburg.

  • platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
16:42 Changeset [42470] by kdecker@apple.com

Reviewed by Darin.

<rdar://problem/6784955> REGRESSION: closing a tab containing a PDF causes world leaks


Simplify the _trackFirstResponder method by just caching the value instead of retaining
a Cocoa object.


  • WebView/WebPDFView.h: Eliminated trackedFirstResponder object and replaced it with a firstResponderIsPDFDocumentView boolean.
  • WebView/WebPDFView.mm: (-[WebPDFView dealloc]): Removed no longer necessary ASSERT. (-[WebPDFView viewWillMoveToWindow:]): Removed call to release and nil-out trackedFirstResponder, which no longer exists. In the new code all we do now is set firstResponderIsPDFDocumentView to NO. (-[WebPDFView _trackFirstResponder]): Rewrote this method to just cache the value instead of retaining an object.
15:36 Changeset [42469] by darin@apple.com

2009-04-13 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to make these scripts work better with the build window in new versions of Xcode.
  • Scripts/check-for-global-initializers: Ditto.
  • Scripts/check-for-weak-vtables: Ditto.
15:18 Changeset [42468] by darin@apple.com

2009-04-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • platform/cf/BinaryPropertyList.cpp: Added comment.
  • platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
15:16 Changeset [42467] by darin@apple.com

WebCore:

2009-04-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693

Test: editing/selection/click-after-nested-block.html

  • rendering/RenderBlock.cpp: (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint can share code. (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first child box. Changed special case for last child box to propertly handle the various types of child box that are not hit test candidates (the same ones already handled by the hit test loop below), adding in a loop so we find the last candidate.

LayoutTests:

2009-04-13 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693

  • editing/selection/click-after-nested-block-expected.txt: Added.
  • editing/selection/click-after-nested-block.html: Added.
  • fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
  • fast/events/pointer-events.html: Changed this to a plain-text test, because the old results reflected a difference in hit testing behavior that this test was not intended to exercise and it's better to have the test be more cross-platform. Also removed unneeded use of waitUntilDone.
  • fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by running the make-js-test-wrappers script. If we want to include type and charset attributes in the script elements, we can change make-js-test-wrappers to do that for all tests at some point.
  • fast/js/function-apply-aliased.html: Ditto.
  • fast/js/function-call-aliased.html: Ditto.
14:44 Changeset [42466] by ggaren@apple.com

JavaScriptCore:

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.

  • tests/mozilla/expected.html:

WebKitTools:

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.

  • Scripts/run-javascriptcore-tests:
14:39 Changeset [42465] by hyatt@apple.com

Update accessibility layout test from last checkin.

14:34 Changeset [42464] by hyatt@apple.com

Webcore:

2009-04-13 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

  • WebCore.base.exp:
  • page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
  • platform/ScrollView.h:

WebKit/mac:

2009-04-13 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

This patch also eliminates WebHTMLView's separate notion of needing a layout and just consolidates it with
WebCore's notion of needing layout.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]): (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _needsLayout]):
  • WebView/WebHTMLViewInternal.h:
14:31 Changeset [42463] by aroben@apple.com

Windows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

Add SharedBuffer::wrapCFData

This is the CF-equivalent of wrapNSData.

Reviewed by Brady Eidson.

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::wrapCFData):

WebKit/win:

Windows part 2 of <rdar://5438063> Saving history containing 100,000
entries causes pauses of 2s while browsing

Reviewed by Brady Eidson.

  • Interfaces/IWebHistoryPrivate.idl: Added data, analagous to WebKit/mac's -[WebHistory _data] method.
  • WebHistory.cpp: (WebHistory::saveHistoryGuts): Changed to call data() to get the data for saving. (WebHistory::data): Added. Returns the data for saving as an IStream. (WebHistory::data): Added. Returns the data for saving as a CFDataRef.
  • WebHistory.h: Added data.
14:27 Changeset [42462] by kov@webkit.org

2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Further massage tests to disable tests that are failingto make the
results more useful.

  • platform/gtk/Skipped:
14:09 Changeset [42461] by ggaren@apple.com

JavaScriptCore:

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.

  • tests/mozilla/expected.html: Updated expected results.

WebKitTools:

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.

  • Scripts/run-javascriptcore-tests:
13:57 Changeset [42460] by justin.garcia@apple.com

Adding a comment to my previous code change.

13:55 Changeset [42459] by darin@apple.com

2009-04-13 Darin Adler <darin@apple.com>

  • WebView/WebViewPrivate.h: Updated comments.
13:48 Changeset [42458] by mitz@apple.com
  • build fix
  • page/EventHandler.cpp: (WebCore::documentPointForWindowPoint):
13:46 Changeset [42457] by antti@apple.com

WebCore:

2009-04-13 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6740294> Increase the connection count per host


Try to use six connections per host if possible.

  • WebCore.base.exp:
  • loader/loader.cpp: (WebCore::Loader::Loader):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceRequestBase.cpp: (WebCore::initMaximumHTTPConnectionCountPerHost):
  • platform/network/ResourceRequestBase.h:
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::initMaximumHTTPConnectionCountPerHost):

WebKit/mac:

2009-04-13 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6740294> Increase the connection count per host

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

2009-04-13 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6740294> Increase the connection count per host

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:38 Changeset [42456] by justin.garcia@apple.com

WebCore:

2009-04-13 Justin Garcia <justin.garcia@apple.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=25153
Can't place the caret into text field that scrolls the window on focus


We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
coordinate) and use that any time we refetch.

  • page/EventHandler.cpp: (WebCore::documentPointForWindowPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::prepareMouseEvent):

LayoutTests:

2009-04-13 Justin Garcia <justin.garcia@apple.com>

Reviewed by Adele Peterson.


<rdar://problem/6748324> REGRESSION (Kirkwood): Can't type in Netflix search field

  • fast/forms/25153-expected.txt: Added.
  • fast/forms/25153.html: Added.
13:29 Changeset [42455] by weinig@apple.com

2009-04-13 Sam Weinig <sam@webkit.org>

Fix bad expected result.

  • fast/frames/frame-unload-crash-expected.txt:
13:26 Changeset [42454] by weinig@apple.com

2009-04-13 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
to conform to our style guidelines.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::allowPopUp):
  • page/Settings.h: (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
13:24 Changeset [42453] by ggaren@apple.com

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Mac build fix: Made another header private.

  • WebCore.xcodeproj/project.pbxproj:
13:20 Changeset [42452] by dimich@chromium.org

2009-04-13 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25121
Upstream changes to handle error messages from V8 when running worker script.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::reportFatalErrorInV8): (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate):
  • bindings/v8/WorkerContextExecutionProxy.h:
13:18 Changeset [42451] by beidson@apple.com

2009-04-13 Brady Eidson <beidson@apple.com>

Reviewed by Tim Hatcher

Tweak my last check-in, moving the thread violation check up to the API-level calls so the logging is more
useful to developers/users.

  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not on the main thread, only perform the "call on main thead" workaround, as the log/exception raising is now up at the API level. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Perform a thread violation check here so logging is more meaningful. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
13:16 Changeset [42450] by ggaren@apple.com

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Build fix: Made setInlineEventListenerForType not inline, since Document
calls it now. Made RegisteredEventListener.h a private header on Mac,
so WebKit can use it.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType):
13:14 Changeset [42449] by mitz@apple.com

Reviewed by Sam Weinig.

  • fix <rdar://problem/6404439> REGRESSION: Overlapping text and other layout issues in View Sample feature of MYOB FIrstEdge v3
  • page/Navigator.cpp: (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of JavaScript files this quirk applies to.
13:03 Changeset [42448] by beidson@apple.com

2009-04-13 Brady Eidson <beidson@apple.com>

Reviewed by Kevin Decker

<rdar://problem/6712063> Garmin WebUpdater crashes

  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not called on the main thread, add a ThreadViolationCheckRoundTwo() call to either log or raise an exception. In the case where it's only a log, reschedule the _loadData call to occur on the main thread.
12:50 Changeset [42447] by weinig@apple.com

WebCore:

2009-04-13 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Move open and showModalDialog functions out of JSDOMWindowBase
and into JSDOMWindow by partially generating them.

This slightly changes the behavior of getting window.showModalDialog
when the embedding app does not support it to return undefined regardless
of shadowing. This should not be an issue in a practice, but will be addressed
when we add a generic way to handle runtime specialization of property
access.

  • DerivedSources.make: Remove JSDOMWindowBase.lut.h
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::): (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from here to JSDOMWindow::customGetOwnPropertySlot. (WebCore::JSDOMWindowBase::put): Remove dead code.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase. (WebCore::DOMWindow::allowPopUp): Ditto. (WebCore::DOMWindow::canShowModalDialog): Ditto. (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

2009-04-13 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Update tests after moving showModalDialog from JSDOMWindowBase to
JSDOMWindow and slightly changing the behavior when showModalDialog
is not available, as is the case for DumpRenderTree.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
12:43 Changeset [42446] by ggaren@apple.com

2009-04-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved storage for window event listeners into the window object.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): Add / remove window event listeners to / from the window object.
  • dom/Document.cpp: (WebCore::Document::removeAllEventListeners): (WebCore::Document::clear): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved a bunch of code to the DOMWindow class, and left behind a few calls through to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
  • dom/Document.h: ditto.
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window object, not the document.
  • dom/Node.h:
  • dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector declaration, since it's required in more places now.
  • history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Updated for rename. Also, remove event listeners before detaching and clearing the document's window pointer, since the the document needs its window pointer in order to tell the window to clear its event listeners.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and movement of window event listeners into the window.
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for movement of window event listeners into the window.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::handleEvent): (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners): (WebCore::DOMWindow::hasEventListener): (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::removeInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::addPendingFrameUnloadEventCount): (WebCore::DOMWindow::removePendingFrameUnloadEventCount): (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount): (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
  • page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
  • page/Frame.cpp: (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
12:05 Changeset [42445] by bolsinga@apple.com

2009-04-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=25149

The Geolocation timer needs to start after the UA has granted permission.

  • bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions> (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions> where needed. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::startTimer): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows (WebCore::Geolocation::startTimer): (WebCore::Geolocation::startTimersForOneShots): (WebCore::Geolocation::startTimersForWatchers): (WebCore::Geolocation::startTimers):
  • page/Geolocation.h: (WebCore::Geolocation::GeoNotifier::create):
11:01 Changeset [42444] by pam@chromium.org

2009-04-13 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Fix Chromium (V8) build by renaming methods to match changes
in http://trac.webkit.org/changeset/42377.

https://bugs.webkit.org/show_bug.cgi?id=25141

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
10:52 Changeset [42443] by darin@apple.com

2009-04-13 Darin Adler <darin@apple.com>

  • Scripts/make-js-test-wrappers: Added another exception.
10:47 Changeset [42442] by darin@chromium.org

2009-04-13 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25136
CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame

Test: fast/frames/frame-unload-crash.html

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
10:38 Changeset [42441] by weinig@apple.com

WebCore:

2009-04-13 Sam Weinig <sam@webkit.org>

Reviewed by Tim Hatcher.

Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.

  • page/DOMWindow.idl:

LayoutTests:

2009-04-13 Sam Weinig <sam@webkit.org>

Reviewed by Tim Hatcher.

Update test results after putting the MessagePort constructor
back in ENABLE_CHANNEL_MESSAGING.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
10:24 Changeset [42440] by bolsinga@apple.com

2009-04-13 Greg Bolsinga <bolsinga@apple.com>

Fix GTK build break.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
10:14 Changeset [42439] by hyatt@apple.com

2009-04-13 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler and Dan Bernstein.

Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
Schedule a style recalc if needed when an object comes out of the page cache.

  • dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::setInPageCache):
10:11 Changeset [42438] by timothy@apple.com

Correctly sort (program) scripts in the Scripts panel popup menu.

Reviewed by Ada Chan.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code and sort "(program)" options by the sourceID to maintain some order.
  • inspector/front-end/utilities.js: (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction. Just set 'first' and break so the correct result will be returned.
10:07 Changeset [42437] by bolsinga@apple.com

2009-04-13 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24770


Add custom code for Coordinates that returns null when required by the
Geolocation spec.


http://dev.w3.org/geo/api/spec-source.html#coordinates

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCoordinatesCustom.cpp: Added. (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided. (WebCore::JSCoordinates::altitudeAccuracy): Ditto (WebCore::JSCoordinates::heading): Ditto (WebCore::JSCoordinates::speed): Ditto
  • page/Coordinates.h: (WebCore::Coordinates::create): Add 'canProvide' parameters and values (WebCore::Coordinates::canProvideAltitude): (WebCore::Coordinates::canProvideAltitudeAccuracy): (WebCore::Coordinates::canProvideHeading): (WebCore::Coordinates::canProvideSpeed): (WebCore::Coordinates::Coordinates):
  • page/Coordinates.idl: specify custom getters
  • platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
09:27 Changeset [42436] by kov@webkit.org

2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing

Added simple printing unit tests.

  • tests/testwebframe.c: (print_requested_cb): (print_timeout): (test_webkit_web_frame_printing): (main):
09:26 Changeset [42435] by kov@webkit.org

2009-04-13 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing

Implement proper printing API, using the GTK+ printing API.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
09:15 Changeset [42434] by kov@webkit.org

2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Holger Freyther.

Reworked the skipped tests listing so that it is easier to find
tests that are skipped but pass using diff. Enable all tests that
are passing, and disable failing tests except for a few crashers
and known regressions. This is an effort to make the build slave
output more useful when it is back.

  • platform/gtk/Skipped:
08:12 Changeset [42433] by adele@apple.com

WebCore:

2009-04-13 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

Test: editing/inserting/5510537.html

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.

LayoutTests:

2009-04-13 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

  • editing/inserting/5510537.html: Added.
  • platform/mac/editing/inserting/5510537-expected.checksum: Added.
  • platform/mac/editing/inserting/5510537-expected.png: Added.
  • platform/mac/editing/inserting/5510537-expected.txt: Added.
07:46 Changeset [42432] by darin@apple.com

2009-04-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Fix problem when encoding history files with duplicate integer arrays near the end of the file.
This results in an assertion failure, and if assertions are turned off, corrupted output.

When writing an integer array it's important not to add an object reference to the
aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
more importantly, it's possible this instance integer array is a duplicate and won't be
written out. If so, there's no guarantee there's enough space in the aggregate buffer to
store the object references (the references will be ignored). In some cases the aggregate
buffer can then overrun the data being written; normally this is prevented by the fact that
the data being written will include a copy of the aggregate buffer.

Also removed a bit of unneeded dead code to handle the integer -1.

  • platform/cf/BinaryPropertyList.cpp: (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded m_integerNegativeOneObjectReference, since property lists support only non-negative integers. (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for m_integerNegativeOneObjectReference. (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto. (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference): Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling addAggregateObjectReference. (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new writeIntegerWithoutAddingAggregateObjectReference function. (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the code to save and restore m_currentAggregateBufferByte, which is no longer needed.
04:31 Changeset [42431] by zecke@webkit.org

Unreviewed Qt build fix

04/12/09:

17:41 Changeset [42430] by weinig@apple.com

WebCore:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move the event and crypto attributes and the captureEvents and releaseEvents
functions out of JSDOMWindowBase by partially generating them.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::currentEvent): Make const.
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::crypto): Not implemented. (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::captureEvents): Not implemented. (WebCore::JSDOMWindow::releaseEvents): Ditto.
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update test result for new nop window.crypto behavior.

  • http/tests/security/cross-frame-access-get-expected.txt:
16:42 Changeset [42429] by weinig@apple.com

2009-04-12 Sam Weinig <sam@webkit.org>

Update results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
16:10 Changeset [42428] by weinig@apple.com

WebCore:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move more attributes out of JSDOMWindowBase by
partially generating them.

  • Expose the MessagePort constructor.
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xMLHttpRequest): (WebCore::JSDOMWindow::xSLTProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-12 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Update tests after making MessageChannel completely missing when not
compiling with support for it (and removing it from the tests because
we never compile with support for it right now) and exposing the MessagePort
constructor.

  • fast/dom/constructors-cached-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • fast/dom/resources/constructors-cached.js:
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
10:57 Changeset [42427] by timothy@apple.com

A resource's filename is not correct after a redirect in the Inspector.

Reviewed by Dan Bernstein.

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): Fix a typo in the lastPathComponent property name.
09:24 Changeset [42426] by adele@apple.com

WebCore:

2009-04-12 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test: editing/inserting/6609479-1.html

Follow-up to <rdar://problem/6609479>.

Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
at the start of a paragraph.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):

LayoutTests:

2009-04-12 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Another test for <rdar://problem/6609479>. This covers inserting HTML in a quoted table.

  • editing/inserting/6609479-1-expected.txt: Added.
  • editing/inserting/6609479-1.html: Added.

04/11/09:

22:49 Changeset [42425] by adele@apple.com

WebCore:

2009-04-11 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

Test: editing/inserting/6609479.html

Don't break a blockquote if pasting or inserting into a table.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):

LayoutTests:

2009-04-11 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

  • editing/inserting/5418891.html: Changed test so it doesn't involve tables.
  • editing/inserting/6609479-expected.txt: Added.
  • editing/inserting/6609479.html: Added.
  • platform/mac/editing/inserting/5418891-expected.checksum:
  • platform/mac/editing/inserting/5418891-expected.png:
  • platform/mac/editing/inserting/5418891-expected.txt:
18:11 Changeset [42424] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6643103> Unscaled values from body.scrollHeight

Test: fast/css/zoom-body-scroll.html

Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
setters.

  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6643103> Unscaled values from body.scrollHeight
  • fast/css/zoom-body-scroll-expected.txt: Added.
  • fast/css/zoom-body-scroll.html: Added.

04/10/09:

22:40 Changeset [42423] by mitz@apple.com

Reviewed by Jon Honeycutt.

  • fix <rdar://problem/6752340> Light blue-green background in content area in Mail
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Use device white, rather than calibrated white, as the default background color.
22:31 Changeset [42422] by timothy@apple.com

Allow page navigation and reload while stopped at a breakpoint.

<rdar://problem/6781108> Having a breakpoint active prevents page reload

Reviewed by Darin Adler.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue): Call the resumedScript function.
  • inspector/InspectorController.h: Added didContinue.
  • inspector/JavaScriptDebugListener.h: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
  • inspector/front-end/inspector.js: (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.
19:18 Changeset [42421] by aroben@apple.com

Land corrected results for complex-character-based-fallback.html

  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
17:56 Changeset [42420] by darin@apple.com

2009-04-10 Darin Adler <darin@apple.com>

Rubber stamped by Adam Roben.

Disabled fast/dom/gc-8.html, which was using Timer in an unsafe way that now
triggers an assertion.

We'll reenable the test after fixing the problem. But this is a test-only problem.

  • fast/dom/gc-8.html: Removed.
  • fast/dom/gc-8.html-disabled: Copied from fast/dom/gc-8.html.
17:47 Changeset [42419] by sfalken@apple.com

<rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC


r21436 changed the semantics of AXObjectCache::get() to not create
objects on demand. Changing this get() call into a getOrCreate() call
fixes the crash.


Rubber stamped by Jon Honeycutt.

  • AccessibleDocument.cpp: (AccessibleDocument::AccessibleDocument):
17:43 Changeset [42418] by weinig@apple.com

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Adele Peterson.

Remove unused include for JSLock.

  • page/mac/FrameMac.mm:
17:41 Changeset [42417] by weinig@apple.com

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Add back the keepAlive timer for after the script execution to
protect the callers of evaluate, as was part of the original intent
of timer.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • page/mac/FrameMac.mm:
17:39 Changeset [42416] by mitz@apple.com

Reviewed by Anders Carlsson.

  • test and expected result updates following r42379
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt: Updated results.
  • fast/text/offsetForPosition-cluster-at-zero.html: Removed font-dependent alert that was accidently left in this test.
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Added.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.txt: Added.
  • platform/win/Skipped:
17:26 Changeset [42415] by cmarrin@apple.com

Fixed https://bugs.webkit.org/show_bug.cgi?id=25137

If we reload, the animation controller sticks around and has
a stale animation time. So the needed delay is computed wrong.
I added a reset of the animation timer on load.

I did not do a test case because this only happens on reload so I
couldn't make an automated test. I tried using an iframe and using
reload() but that doesn't tickle the bug.

17:13 Changeset [42414] by aroben@apple.com

Add our new test font to the list that DRT knows about

Reviewed by Dan Bernstein.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize): Added WebKit Layout Tests 2.ttf.
17:10 Changeset [42413] by darin@apple.com

2009-04-10 Grace Kloba <klobag@gmail.com>

Reviewed by Darin Adler.

Move WORKERS header files inside ENABLE(WORKERS).
So if WORKERS is not enabled and the generated files are not generated, the build is still working.

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSMessageChannelConstructor.cpp:
  • bindings/js/ScheduledAction.cpp:
16:59 Changeset [42412] by darin@apple.com

WebCore:

2009-04-10 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.
This adds some diagnostics so we'll catch that kind of mistake immediately.

  • platform/Timer.cpp: (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions. (WebCore::TimerBase::start): Assert it's the same thread the timer was created on. (WebCore::TimerBase::stop): Ditto. (WebCore::TimerBase::isActive): Ditto. (WebCore::TimerBase::setNextFireTime): Ditto.
  • platform/Timer.h: Added the thread identifier data member.

WebKit/mac:

2009-04-10 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

<rdar://problem/6773515> crash in push_heap inside WebCore when printing

The crash was due to manipulating a timer on a different thread than the one it was created on.

  • History/WebHistoryItem.mm: (-[WebWindowWatcher windowWillClose:]): Call later on main thread, if called on non-main thread.
  • WebView/WebHTMLView.mm: (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView windowWillClose:]): Ditto. (-[WebHTMLView _updateControlTints]): Added. Factored out the non-thread-safe part of our override of _windowChangedKeyState. (-[WebHTMLView _windowChangedKeyState]): Call _updateControlTints later on main thread, if called on non-main thread.
  • WebView/WebPreferences.mm: (-[WebPreferences _postPreferencesChangesNotification]): Call later on main thread, if called on non-main thread
16:39 Changeset [42411] by aroben@apple.com

Add our invidual IDL files back to Interfaces.vcproj, but disable them

This allows the IDL files to be found in Solution Explorer.

Rubber-stamped in advance by Steve Falkenburg.

  • WebKit.vcproj/Interfaces.vcproj:
16:19 Changeset [42410] by simon.fraser@apple.com

2009-04-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=25108

If you remove a class with a transition while that transition is running
the animation timer will continue to fire after the transition is finished.
This has no visual indication, but it does drain the processor. And in some
cases it might even cause a glitch in future animations. Unfortunately there
is no way to test this without putting in printfs.

This happens because the animation logic is never traversed after a transition
is removed, so we never get a chance to cleanup. So I added cleanup in the logic
that fires the dispatch of the last style change when the animation finishes.

Test: transitions/remove-transition-style.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
15:52 Changeset [42409] by weinig@apple.com

2009-04-10 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6648858>
CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241

The Frame (and therefore ScriptController) were being destroyed
during JavaScript execution causing the JSDOMWindowShell to become
null.

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame instead of the keep-alive timer, since a nested event loop used from with-in JavaScript execution could cause the timer to fire before returning.
15:30 ApplicationsGtk edited by evandrofisico@gmail.com
Correct claws-mail webkit plugin URL (diff)
15:27 Changeset [42408] by dglazkov@chromium.org

2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25133
Fix an error in InspectorController's bindings, clean up a few header
includes, make empty object construction in ScriptObject less ambiguous.

  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::setSetting): Send correct argument from

the bindings.

  • bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::createNew): Added.
  • bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
  • inspector/ConsoleMessage.cpp: Remove unused header.
  • inspector/ConsoleMessage.h: Ditto.
  • inspector/InspectorResource.cpp: (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.
14:50 Changeset [42407] by mitz@apple.com

Reviewed by Adam Roben.

  • re-enable css2.1 tests that were disabled following r42379 and make them use a different fallback font for certain characters, to get the vertical metrics to match Mac
  • platform/win/Skipped:
  • platform/win/css2.1/resources/Mac-compatible-font-fallback.css:
14:44 Changeset [42406] by cmarrin@apple.com

Fixed https://bugs.webkit.org/show_bug.cgi?id=25134

This both fixes a bug where I was not sending in the right time
to continue the animation and was not recomputing current time
when coming out of suspend.

13:48 Changeset [42405] by eric.carlson@apple.com

2009-04-10 Eric Carlson <eric.carlson@apple.com>

WebKitSystemInterface changes for <rdar://problem/6646998>

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
13:41 Changeset [42404] by timothy@apple.com

Revert an unintentional logic change in r42400.

13:17 Changeset [42403] by simon.fraser@apple.com

2009-04-10 Simon Fraser <simon.fraser@apple.com>

Fix the leopard build by updating WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
13:07 Changeset [42402] by timothy@apple.com

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

WebKit:

2009-04-10 Timothy Hatcher <timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-04-10 Timothy Hatcher <timothy@apple.com>

Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

Rubber-stamped by Mark Rowe.

  • Misc/DOMDocumentPrivate.h: Removed.
13:05 Changeset [42401] by aroben@apple.com

Give Windows's <select> popup menus drop shadows

Rubber-stamped by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.
13:00 Changeset [42400] by timothy@apple.com

Fix a bug in the Web Inspector where it would show scripts
from previous pages when toggling the debugger off and back on.

https://bugs.webkit.org/show_bug.cgi?id=25095
rdar://problem/6769970

Reviewed by John Sullivan.

  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the debugger for the scriptController. This balances the attachDebugger that was already in ScriptCachedFrameData::restore. (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Clear the debugger from the current window before setting the new window.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate source providers for code associated this as the debugger.
12:17 Changeset [42399] by eric.carlson@apple.com

2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

When possible avoid asking QTKit for the MIME types that require QTKitServer
when running 64-bit.

  • WebCore.base.exp: Added new entry point.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): Add an NSArray of types to the cache. (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache. (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does not start QTKitServer if it is not already running). (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored. (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid starting QTKitServer if possible.
  • platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6646998> Avoid starting QTKitServer if possible

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes.
11:55 Changeset [42398] by aroben@apple.com

Turn on window animations for <select> popup menus

We turned these off back when <select> popup menus were partially
transparent. Now that they're opaque, there's no reason not to
animate them.

Reviewed by Steve Falkenburg.

No test possible.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the window animation.
11:39 Changeset [42397] by mitz@apple.com
  • skip failures following r42379 until they are addressed by code changes or test changes
  • platform/win/Skipped:
11:32 Changeset [42396] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

  • fix a regression from r42379 which made zero-width characters affect line height

Test: fixes fast/text/wide-zero-width-space.html

  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::overrideLayoutOperation): Add to the fallback font list set here, and only if the glyph is not zero-width... (WebCore::ATSULayoutParameters::initialize): ...instead of doing it here. This matches WidthIterator's behavior.

LayoutTests:

Reviewed by Sam Weinig.

  • revert broken test results that were checked in with r42379, now that the regression is fixed
  • platform/mac/fast/text/wide-zero-width-space-expected.checksum:
  • platform/mac/fast/text/wide-zero-width-space-expected.png:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt:
11:31 Changeset [42395] by aroben@apple.com

Update Windows results for complex-character-based-fallback.html

Rubber-stamped by Dan Bernstein.

  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt: Updated.
10:39 Changeset [42394] by darin@chromium.org

2009-04-10 Darin Fisher <darin@chromium.org>

Fixing build bustage caused by warnings being treated as errors.
1- A local variable was only be used inside a debug assertion, which

caused grief for the release build.

2- Missing initializer for member 'DocumentMarker::activeMatch'

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::setMarkersActive):
10:24 Changeset [42393] by darin@chromium.org

2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by John Sullivan.

Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
(TextMatches don't have a concept of active match)

For the ports that use the DocumentMarker as highlighting for FindInPage it is
useful to have a flag that specifies which marker is active, so it can be drawn
in a different color.

This allows me to remove the hack to use the SelectionController to highlight
the active match (in the ChromiumWin port).

  • dom/Document.cpp: (WebCore::Document::setMarkersActive):
  • dom/Document.h:
  • dom/DocumentMarker.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformActiveTextSearchHighlightColor): (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor): (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
  • rendering/RenderThemeChromiumWin.h:
10:13 Changeset [42392] by pam@chromium.org

2009-04-10 Pamela Greene <pam@chromium.org>

Reviewed by Dimitri Glazkov.

Build fix for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=12440

  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()
05:03 Changeset [42391] by kov@webkit.org

WebKit/gtk/

2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Mark the missing strings for translation.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_cancel):
  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
  • webkit/webkitwebnavigationaction.cpp: (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
  • webkit/webkitwebview.cpp:

WebKit/gtk/po/

2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25124
[GTK] many strings still missing translation calls

Extracting translation for the files that got translation calls.

  • POTFILES:
  • de.po:
  • pt_BR.po:
  • webkit.pot:

04/09/09:

22:42 Changeset [42390] by mitz@apple.com
  • remove two files I just checked in by accident
  • platform/mac/fast/events/pointer-events-expected.txt: Removed.
  • platform/mac/fast/events/pointer-events.html: Removed.
22:36 Changeset [42389] by mitz@apple.com

Reviewed by Mark Rowe.

  • moved some Leopard-and-earlier results into platform/mac-leopard and added new results under platform/mac
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.checksum.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
  • platform/mac-leopard/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
  • platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
  • platform/mac/fast/events/pointer-events-expected.txt: Added.
  • platform/mac/fast/events/pointer-events.html: Added.
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum: Replaced.
  • platform/mac/fast/text/complex-text-opacity-expected.png: Replaced.
  • platform/mac/fast/text/complex-text-opacity-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Replaced.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
20:58 Changeset [42388] by jmalonzo@webkit.org

2009-04-09 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed Gtk build fix for undefined reference: g_thread_init.
Add GLIB_LIBS to DRT and GtkLauncher build config.

  • GNUmakefile.am:
20:38 Changeset [42387] by mrowe@apple.com

Remove two tests from the skipped list now that <rdar://problem/6718460> has been addressed.

  • platform/mac-snowleopard/Skipped:
20:38 Changeset [42386] by mrowe@apple.com

Skip a few tests that are currently failing.

Rubber-stamped by Oliver Hunt.

  • platform/mac-snowleopard/Skipped:
20:23 Changeset [42385] by mitz@apple.com

Rubber-stamped by Mark Rowe.

  • update Tiger-only test results after r42379
  • platform/mac-tiger/fast/lists/w3-list-styles-expected.txt:
  • platform/mac-tiger/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
20:15 Changeset [42384] by hyatt@apple.com

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt

Add a timer for style recalc (similar to the one used for scheduling layouts). For now in order
to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
following DOM events and JavaScript timeouts. Eventually these calls will be removed.

Where the timer will really kick in and be useful is for clients that do style changes from
Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::styleRecalcTimerFired): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::detach):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach):
19:24 Changeset [42383] by mrowe@apple.com

Land Windows-specific results for three forms tests since the Windows results match the Leopard results.

Rubber-stamped by Adam Roben.

  • platform/win/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
  • platform/win/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt.
  • platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt.
18:49 Changeset [42382] by oliver@apple.com

<rdar://problem/6586787> JS debugger does not work in 64-bit

Reviewed by Gavin Barraclough

Don't truncate the source id in JSCallFrame

18:17 Changeset [42381] by aroben@apple.com

Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

Start compiling HistoryPropertyList on Windows

Reviewed by Darin Adler.

  • WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its dependencies to the project. Copy headers from history/cf to $WebKitOutputDir.
  • history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that this file will compile on Windows.

WebKit/win:

Windows part 1 of <rdar://problem/5438063> Saving history containing
100,000 entries causes pauses of 2s while browsing

Use HistoryPropertyListWriter to implement IWebHistory::saveToURL.

Reviewed by Darin Adler.

  • WebHistory.cpp: (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through the entries for each date, and pass the corresponding WebCore::HistoryItem to writeHistoryItem. (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize m_entriesByDate, then write the serialized data to disk using CFWriteStream.
  • WebHistory.h: Removed datesArray.
18:13 Changeset [42380] by mrowe@apple.com

Update test results to account for a slight change in +[NSColor disabledControlTextColor].

Rubber-stamped by Dan Bernstein.

  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.checksum.
  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png.
  • platform/mac-leopard/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.checksum.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
  • platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.checksum.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.png.
  • platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.txt.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.checksum.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.png.
  • platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.txt.
  • platform/mac/fast/forms/disabled-select-change-index-expected.txt:
  • platform/mac/fast/forms/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/input-text-maxlength-expected.txt:
  • platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
18:00 Changeset [42379] by mitz@apple.com

WebCore:

2009-04-09 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font

Covered by many existing layout tests

  • platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the platform supports collecting fallback fonts in its complex font path and fallbackFonts is not null, all fallback fonts used for the text run will be added to it.
  • platform/graphics/Font.h: (WebCore::Font::width): Ditto.
  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace qualifier. (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts parameter, which is passed down to WidthIterator.
  • platform/graphics/WidthIterator.cpp: (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::WidthIterator::advance): Track the fonts being used and add any fallback fonts to the m_fallbackFonts set. Make sure to only add non-small-caps fonts.
  • platform/graphics/WidthIterator.h:
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
  • platform/graphics/chromium/FontLinux.cpp: Ditto.
  • platform/graphics/gtk/FontGtk.cpp: Ditto.
  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add fallback fonts to m_fallbackFonts.
  • platform/graphics/mac/CoreTextController.h:
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the Mac implementations of floatWidthForComplexText() populate the fallbackFonts set.
  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a fallbackFonts parameter and used it to initialize the m_fallbackFonts member. (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to m_fallbackFonts. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to ATSULayoutParameters.
  • platform/graphics/mac/FontMacCoreText.cpp: (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to CoreTextController.
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns true, indicating that the UniscribeController-based implementations of floatWidthForComplexText() populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts parameter, which is passed down to UniscribeController.
  • platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): Added a fallbackfonts parameter and used it to initialize m_fallbackFonts. (WebCore::UniscribeController::advance): Add fallback fonts to m_fallbackFonts.
  • platform/graphics/win/UniscribeController.h:


  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::canReturnFallbackFontsForComplexText): Added an implementation that returns false, meaning this platform's implementation of floatWidthForComplexText() does not populate the fallbackFonts set. (WebCore::Font::floatWidthForComplexText): Updated for the new prototype.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox with multiple fonts, compute a common baseline and line height by considering all fonts' ascents and descents (and line spacing, if applicable).
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores the set of fallback fonts in a vector. (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback fonts previously stored and removes them from storage.
  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Initialized the m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::styleDidChange): Reset m_knownNotToUseFallbackFonts to false if the style difference is such that affects layout. (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter, which is passed down to Font::width(). (WebCore::RenderText::trimmedPrefWidths): Updated for the change to widthFromCache(). (WebCore::RenderText::calcPrefWidths): Made this call a private version of calcPrefWidths() that takes a fallbackFonts parameter and set the m_knownNotToUseFallbackFonts to true if the set comes back empty. The private version passes the fallbackFonts set to widthFromCache(). (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to false. (WebCore::RenderText::createFallbackFontMetricsBox): Added. (WebCore::RenderText::width): Added a fallbackFonts parameter, which is passed down to calcPrefWidths(), widthFromCache() and Font::width(). Set m_knownNotToUseFallbackFonts to true when appropriate.
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): Added an assertion and a continue statement to remove one level of indentation. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily store the set of fallback fonts in the InlineTextBox. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an assertion.

LayoutTests:

2009-04-09 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

  • updated results for <rdar://problem/6166612> Text boxes' metrics should be based on the actual fonts used in them, not just the primary font
  • editing/selection/extend-selection-bidi-expected.txt:
  • fast/text/offsetForPosition-cluster-at-zero-expected.txt:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/editing/deleting/5144139-2-expected.checksum:
  • platform/mac/editing/deleting/5144139-2-expected.png:
  • platform/mac/editing/deleting/5144139-2-expected.txt:
  • platform/mac/editing/input/devanagari-ligature-expected.checksum:
  • platform/mac/editing/input/devanagari-ligature-expected.png:
  • platform/mac/editing/input/devanagari-ligature-expected.txt:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
  • platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-2-expected.png:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-expected.checksum:
  • platform/mac/editing/selection/caret-rtl-expected.png:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
  • platform/mac/editing/selection/extend-selection-bidi-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/lists/w3-list-styles-expected.checksum:
  • platform/mac/fast/lists/w3-list-styles-expected.png:
  • platform/mac/fast/lists/w3-list-styles-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/fast/text/wide-zero-width-space-expected.checksum:
  • platform/mac/fast/text/wide-zero-width-space-expected.png:
  • platform/mac/fast/text/wide-zero-width-space-expected.txt:
17:24 Changeset [42378] by kdecker@apple.com

Reviewed by Hyatt.

<rdar://problem/4680397> tearing seen because deferred updates are disabled


  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Don't call WKDisableCGDeferredUpdates on post-Leopard if NSAppKitVersionNumberWithDeferredWindowDisplaySupport is defined.
17:05 Changeset [42377] by hyatt@apple.com

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben

Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
explicitly instead.

  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScriptControllerMac.mm: (WebCore::updateStyleIfNeededForBindings): (WebCore::ScriptController::initJavaJSBindings):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
  • css/CSSMutableStyleDeclaration.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged): (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::setVariable): (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
  • css/CSSVariablesDeclaration.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::detach): (WebCore::ContainerNode::setFocus): (WebCore::ContainerNode::setActive): (WebCore::ContainerNode::setHovered):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::unscheduleStyleRecalc): (WebCore::Document::recalcStyle): (WebCore::Document::updateStyleIfNeeded): (WebCore::Document::updateStyleForAllDocuments): (WebCore::Document::updateLayout): (WebCore::Document::implicitClose): (WebCore::Document::prepareMouseEvent): (WebCore::Document::setFocusedNode): (WebCore::Document::setCSSTarget):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges):
  • dom/InputElement.cpp: (WebCore::InputElement::parseMaxLengthAttribute):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setNeedsStyleRecalc): (WebCore::Node::lazyAttach): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h: (WebCore::Node::needsStyleRecalc): (WebCore::Node::childNeedsStyleRecalc): (WebCore::Node::setChildNeedsStyleRecalc):
  • dom/OptionElement.cpp: (WebCore::OptionElement::setSelectedState):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::evaluateScript):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): (WebCore::StyledElement::classAttributeChanged): (WebCore::StyledElement::parseMappedAttribute):
  • dom/Text.cpp: (WebCore::Text::recalcStyle):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::enable):
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::layout): (WebCore::SelectionController::focusedOrActiveStateChanged):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable): (WebCore::HTMLElement::contentEditable):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::recalcStyle):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::setIndeterminate): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::setAutofilled):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::finishParsingChildren):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::restoreState): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::typeAheadFind):
  • html/HTMLTableElement.cpp: (WebCore::setTableCellsChanged): (WebCore::HTMLTableElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::gotoAnchor):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::alert): (WebCore::DOMWindow::confirm): (WebCore::DOMWindow::prompt):
  • page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired):
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout):
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::setNeedsStyleRecalc): (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer): (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::animationTimerFired): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime): (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList): (WebCore::AnimationController::cancelAnimations):
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::sendAnimationEvent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateDragState):
  • rendering/RenderView.cpp: (WebCore::RenderView::selectionBounds):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::svgAttributeChanged):
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::svgAttributeChanged):
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::setNeedsUpdate):
  • svg/SVGForeignObjectElement.cpp: (WebCore::addCSSPropertyAndNotifyAttributeMap):
  • svg/SVGStopElement.cpp: (WebCore::SVGStopElement::parseMappedAttribute):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::childrenChanged): (WebCore::SVGUseElement::recalcStyle):
  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::parseMappedAttribute):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::setValue): (WebCore::WMLInputElement::parseMappedAttribute):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
16:53 Changeset [42376] by sullivan@apple.com

2009-04-09 John Sullivan <sullivan@apple.com>

<rdar://problem/6775682> WebKit's support for SnowLeopard sudden termination for
downloads is broken and should be removed

Reviewed by Darin Adler

  • Misc/WebDownload.m: (-[WebDownloadInternal downloadDidBegin:]): remove disableSuddenTermination call (-[WebDownloadInternal downloadDidFinish:]): remove enableSuddenTermination call (-[WebDownloadInternal download:didFailWithError:]): remove enableSuddenTermination call
16:52 Changeset [42375] by brettw@chromium.org

2009-04-09 Brett Wilson <brettw@chromium.org>

Reviewed by NOBODY (OOPS!).

When there is a shadow set but it specifies "no shadow", clear the
shadow shader. This will prevent Chromium from thinking there's a
shadow and using the Skia codepath rather than Windows.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):
16:01 Changeset [42374] by eric@webkit.org

Reviewed by Simon Fraser.

Crash when accessing svg.viewport on a detached SVGSVGElement
https://bugs.webkit.org/show_bug.cgi?id=25105

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent. (The spec is unclear as t

o what behavior we should have in this case, and I doubt anyone cares for now).

15:42 Changeset [42373] by dimich@chromium.org

2009-04-09 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25084
Upstream changes to V8 bindings for XHR so that it can work under either DOMWindow or WorkerContext.

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::findOrCreateObjectEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
15:40 Changeset [42372] by darin@apple.com

WebCore:

2009-04-09 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson and Sam Weinig.

Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.

  • WebCore.base.exp: Added new entry points.
  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • history/cf: Added.
  • history/cf/HistoryPropertyList.cpp: Added.
  • history/cf/HistoryPropertyList.h: Added. Code to write history files. In the future we'll also have code for reading here too.
  • platform/cf/BinaryPropertyList.cpp: Added.
  • platform/cf/BinaryPropertyList.h: Added. Code to write binary property list files.

WebKit/mac:

2009-04-09 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson and Sam Weinig.

Part of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

Longer term solution is to change the design so Safari doesn't read and write all of history.
This patch is step one: Do the serializing, which is done on the main thread, much faster.

  • History/WebHistory.mm: (-[WebHistoryPrivate data]): Added. Returns the NSData object containing serialized history. For creating new SPI so you can get the data in memory instead of on disk. Uses WebHistoryWriter. (-[WebHistoryPrivate saveToURL:error:]): Changed to call [self data (-[WebHistory _data]): Added. (WebHistoryWriter::WebHistoryWriter): Added. (WebHistoryWriter::writeHistoryItems): Added.
  • History/WebHistoryPrivate.h: Added a new _data method.
15:25 Changeset [42371] by simon.fraser@apple.com

2009-04-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Antti Koivisto

https://bugs.webkit.org/show_bug.cgi?id=25122

If deferred repainting is active, we need to ensure that there are no repaints
pending at the end of layoutIfNeededRecursive, which is called just before
painting via -viewWillDraw.

  • page/FrameView.cpp: (WebCore::FrameView::layoutIfNeededRecursive):
15:08 Changeset [42370] by ddkilzer@apple.com

Removed duplicate header include.

14:35 Changeset [42369] by mthole@apple.com

2009-04-09 Mike Thole <mthole@apple.com>

Rubber-stamped by Mark Rowe.

Fix 64-bit build

  • Panels/WebAuthenticationPanel.h:

Declare the 'separateRealmLabel' IBOutlet as an NSTextField instead of 'id'.
This fixes a duplicate method warning (setAutoresizingMask: on NSView and CALayer)

13:45 Changeset [42368] by levin@chromium.org

2009-04-09 John Grabowski <jrg@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25117
Fix Mac Chromium form controls.

  • rendering/RenderThemeChromiumMac.mm: When rendering native controls in Mac Chromium, use a clean NSGraphicsContext. Properly save and restore native graphics context. (WebCore::RenderThemeChromiumMac::paintCheckbox): (WebCore::RenderThemeChromiumMac::paintRadio): (WebCore::RenderThemeChromiumMac::paintMenuList): (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
13:45 Changeset [42367] by levin@chromium.org

2009-04-09 Drew Wilson <atwilson@google.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=25030
Refactor MessagePort code to enable Chrome to use a MessagePortProxy object
instead of a real MessagePort for the entangledPort, since it could
theoretically live in a separate process.

The goal of this refactoring is to remove all assumptions that the object
representing the entangled port is actually of type MessagePort. All
operations that were previously directly modifying private MessagePort member
variables in the entangled port (i.e. entangle(), postMessage()) have been changed
to invoke functions in the MessagePortProxy interface instead which will allow
the Chrome bindings to proxy these calls to another process.

No new layout tests, as this is just a refactoring with no bug fixes
or new functionality.

  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
  • dom/MessagePort.cpp: (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::deliverMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::unentangle):
  • dom/MessagePort.h: (WebCore::MessagePort::entangledPort):
  • dom/MessagePortProxy.h: Added. (WebCore::MessagePortProxy::~MessagePortProxy):
13:45 Changeset [42366] by levin@chromium.org

2009-04-09 Ben Murdoch <benm@google.com>

Reviewed by Alexey Proskuryakov.

The Android platform requires threads to be registered with the VM.
This patch implements this behaviour inside ThreadingPthreads.cpp.

  • wtf/ThreadingPthreads.cpp: Add a level above threadEntryPoint that takes care of (un)registering threads with the VM. (WTF::runThreadWithRegistration): register the thread and run entryPoint. Unregister the thread afterwards. (WTF::createThreadInternal): call runThreadWithRegistration instead of entryPoint directly.
11:30 Changeset [42365] by weinig@apple.com

WebCore:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Big Boy" Garen.

Fix for <rdar://problem/5745677> Possible to stop load during an unload event
Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605

Tests: fast/events/stop-load-in-unload-handler-using-document-write.html

fast/events/stop-load-in-unload-handler-using-window-stop.html

Don't allow calling methods that would stop the new load inside the unload
event.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
  • loader/FrameLoader.h:

LayoutTests:

2009-04-08 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Big Boy" Garen.

Tests for <rdar://problem/5745677> Possible to stop load during an unload event

  • fast/events/resources/pass.html: Added.
  • fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
  • fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
  • fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
  • fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
  • fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
  • fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
10:32 Changeset [42364] by mthole@apple.com

2009-04-09 Mike Thole <mthole@apple.com>

Reviewed by Adam Roben.

  • WebKit.xcodeproj/project.pbxproj:

Set the Localizable.strings encoding to UTF-16.

10:06 Changeset [42363] by mthole@apple.com

2009-04-09 Mike Thole <mthole@apple.com>

Reviewed by Ada Chan.

<rdar://problem/5697111> Basic authentication dialog spoofing vulnerability

  • Panels/WebAuthenticationPanel.h:

Added IBOutlet for separateRealmLabel

  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForChallenge:]):

In the realm case, decide if it is a simple or complex realm name. A realm name
is considered complex if it has any whitespace or newline characters. Present
alternative text and layout for the complex case, where the realm name isn't inline
with the rest of the sheet's text.


  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

Updated the nib with a new 'separateRealmLabel' outlet.
Updated the File's Owner to correctly be WebAuthenticationPanel.
Fixed springs on the sheet's icon to keep it from moving during a resize.

09:43 Changeset [42362] by aroben@apple.com

Update results for createDocument-namespace-err.html

It looks like the test was changed without updating the results before
it was committed.

Rubber-stamped by Adele Peterson.

  • fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt: Updated.
09:33 Changeset [42361] by ddkilzer@apple.com

Reinstating <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings

Rolled r42345 back in. The build failure was caused by an
internal script which had not been updated the same way that
build-webkit was updated.

JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

  • Configurations/WebCore.xcconfig:
  • DerivedSources.make:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _wrapNode:WebCore::]):
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _wrapCSSValue:WebCore::]):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:

WebKit/mac:

  • Configurations/WebKit.xcconfig:
  • DOM/WebDOMOperations.mm:
  • MigrateHeaders.make:

WebKitTools:

  • Scripts/build-webkit:
09:30 Changeset [42360] by simon.fraser@apple.com

2009-04-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25109

Eliminate CompositeAnimationPrivate, which was a needless level
of abstraction. Remove the methods like addToStyleAvailableWaitList()
that simply turn around and call the animation controller.

Rename animationControllerPriv() to animationController().
Rename willNeedService() to timeToNextService().

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::~AnimationBase): (WebCore::AnimationBase::updateStateMachine): (WebCore::AnimationBase::timeToNextService): (WebCore::AnimationBase::beginAnimationUpdateTime):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::~CompositeAnimation): (WebCore::CompositeAnimation::clearRenderer): (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::getAnimatedStyle): (WebCore::CompositeAnimation::setAnimating): (WebCore::CompositeAnimation::timeToNextService): (WebCore::CompositeAnimation::getAnimationForProperty): (WebCore::CompositeAnimation::cleanupFinishedAnimations): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations): (WebCore::CompositeAnimation::overrideImplicitAnimations): (WebCore::CompositeAnimation::resumeOverriddenImplicitAnimations): (WebCore::CompositeAnimation::isAnimatingProperty): (WebCore::CompositeAnimation::pauseAnimationAtTime): (WebCore::CompositeAnimation::pauseTransitionAtTime): (WebCore::CompositeAnimation::numberOfActiveAnimations):
  • page/animation/CompositeAnimation.h: (WebCore::CompositeAnimation::animationController): (WebCore::CompositeAnimation::isSuspended): (WebCore::CompositeAnimation::hasAnimations): (WebCore::CompositeAnimation::CompositeAnimation):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::sendTransitionEvent): (WebCore::ImplicitAnimation::timeToNextService):
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::timeToNextService):
  • page/animation/KeyframeAnimation.h:
09:13 Changeset [42359] by levin@chromium.org

2009-04-09 David Levin <levin@chromium.org>

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=25101

Launch DumpRenderTree and the image diff tool in a way that will work from perl threads.
This is a workaround due to a perl limitation. When perl does open* calls on a thread, it ignores
the environment of the current thread and simply uses the environment of the main thread instead.

  • Scripts/execAppWithEnv: Added.
  • Scripts/run-webkit-tests:
06:49 Changeset [42358] by ap@webkit.org

Reverting <rdar://problem/6718589> Option to turn off SVG DOM Objective-C bindings.
It broke Mac build, and I don't know how to fix it.

06:17 Changeset [42357] by xan@webkit.org

2009-04-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

RenderView::docWidth() was made private by r42334. That commit
changes its usage for overflowWidth(), so do that here too.

  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
05:29 Changeset [42356] by xan@webkit.org

2009-04-09 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Checking for GLIBCXX being bigger than some date is not enough
to get std::tr1, C++0x has to be in use too. Add another check for
GXX_EXPERIMENTAL_CXX0X.

  • wtf/TypeTraits.h:
04:20 Changeset [42355] by xan@webkit.org

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Implement AtkObject::ref_state_set. Still quite a few states not
implemented.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
04:17 Changeset [42354] by xan@webkit.org

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Move fallback object creation to its own function, as it will be
used in several places.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp: (fallbackObject):
04:15 Changeset [42353] by xan@webkit.org

2009-04-09 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Move AccessibilityObject methods to their file.

  • page/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::wrapper): (WebCore::AccessibilityObject::setWrapper):
  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
04:08 Changeset [42352] by xan@webkit.org

2009-04-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Rework accessibility type generation code, based on Mozilla a11y
implementation.

Have one base a11y type, and generate derived types that implement
only the necessary interfaces at runtime, based on the specific
object we are wrapping. This allows to save a lot of code while
covering all possible cases.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
03:40 Changeset [42351] by eric@webkit.org

Reviewed by Oliver Hunt.

Fix document.implementation.createDocument(null, "a:b") not to crash!
https://bugs.webkit.org/show_bug.cgi?id=25096

Test: fast/dom/DOMImplementation/createDocument-namespace-err.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::addChild): add ASSERT() to give a better crash next time
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): check the exception code before using the result
00:21 Changeset [42350] by aroben@apple.com

Make <select>s in application chrome documents match the Vista system dialog look

Reviewed by Dave Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::documentIsInApplicationChromeMode): Added this simple helper function. (WebCore::RenderThemeWin::getThemeData): In application chrome mode, the drop down button never uses any look but the "normal" look. (WebCore::RenderThemeWin::paintMenuList): In application chrome mode, use the "readonly" style to match system dialogs.
00:20 Changeset [42349] by aroben@apple.com

Fix <rdar://6592515> Crash closing tab with Top Sites or Cover Flow showing after clicking "Go Back" in phishing alert

RenderButton's m_timer is not stopped when its Document enters the
page cache. When the WebView was torn down, the timer would fire after
the Frame's Page had been destroyed, leading to a crash. This patch
just makes the timer do nothing when it fires. Making the timer not
fire when in the page cache is covered by bug 25110.

Reviewed by Dave Hyatt.

No test possible.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::timerFired): Do nothing when we're in the page cache.
00:11 Changeset [42348] by hyatt@apple.com

2009-04-09 David Hyatt <hyatt@apple.com>

Reviewed by Adam Roben

Fix bugs where we would mistakenly turn off blitting for iframes if an external paint
caused the checks to be triggered too early in the loading process of the frame.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
Note: See TracTimeline for information about the timeline view.