Timeline


and

04/27/09:

23:05 Changeset [42921] by weinig@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2009-04-27 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Disable test intermittent failing test.

  • svg/custom/filter-source-alpha.svg: Removed.
  • svg/custom/filter-source-alpha.svg-disabled: Copied from svg/custom/filter-source-alpha.svg.
22:14 Changeset [42920] by simon.fraser@apple.com
  • 3 edits
    5 adds in trunk/LayoutTests

2009-04-27 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser

Fix video-played.html layout test.

https://bugs.webkit.org/show_bug.cgi?id=25424

We implement playForMillisecs() which makes sure the video
will have been playing for a minimum time.

Note, this does not ensure a strict synchronization between the time
asked and the media playback. But given that media playback is the
slow part we just need to compensate for the delay involved by playback.
(And not the other way around.)

Moreover, we split the test in 3 in order to be more gentle which
slower machines that may tend to timeout more easily on those tests.

  • media/video-played-collapse-expected.txt: Added.
  • media/video-played-collapse.html: Added.
  • media/video-played-expected.txt:
  • media/video-played-reset-expected.txt: Added.
  • media/video-played-reset.html: Added.
  • media/video-played.html:
  • Split tests in multiple files.
  • Makes sure we always play as much as requested by using playForMillisecs();
  • media/video-played.js: Added. (testRanges): (nextTest): (pause): (canplay): (willCreateNewRange): (startPlayingInNewRange): (startPlaying): (secToMilli): (milliToSecs): (playForMillisecs.callPauseIfTimeIsReached): (playForMillisecs): (videoPlayedMain):
20:39 Changeset [42919] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-04-27 Eric Roman <eroman@chromium.org>

Reviewed by Darin Fisher.

Fix a compile breakage.
<https://bugs.webkit.org/show_bug.cgi?id=25384>

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
18:01 Changeset [42918] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-04-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash

QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
multiplier to scale from natural size to current size when a movie is opened and use that to
return the correct value from the naturalSize() method.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor. (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale. (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches QTMovieLoadStateLoaded for the first time.
17:54 Changeset [42917] by bdakin@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-04-27 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

The problem here is that we had a self-painting layer nested inside
a non-self-painting layer. We ended up ignoring the self-painting
layer both during painting and hit-testing. This patch corrects
that.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):

LayoutTests:

2009-04-27 Beth Dakin <bdakin@apple.com>

Reviewed by Dave Hyatt.

Test for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work

  • fast/css/nested-layers-with-hover.html: Added.
  • platform/mac/fast/css/nested-layers-with-hover-expected.checksum: Added.
  • platform/mac/fast/css/nested-layers-with-hover-expected.png: Added.
  • platform/mac/fast/css/nested-layers-with-hover-expected.txt: Added.
17:23 Changeset [42916] by adachan@apple.com
  • 2 edits in trunk/WebCore

If it has been set to allow any HTTPS certificates for this host, set
kCFStreamSSLAllowsExpiredCertificates to true to allow expired
certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
certificate chain validation. (<rdar://problem/6382059>)

Reviewed by John Sullivan.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest):
17:12 Changeset [42915] by simon.fraser@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2009-04-23 Simon Fraser <simon.fraser@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=22242

Add pixel test for zoomed video with controls, with and without a transform.

  • media/video-zoom-controls.html: Added.
  • platform/mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac/media/video-zoom-controls-expected.png: Added.
  • platform/mac/media/video-zoom-controls-expected.txt: Added.
17:08 Changeset [42914] by simon.fraser@apple.com
  • 4 edits in trunk

2009-04-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adele Peterson

<rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well

Fix a 'size changed' notification thrash that caused standalone video elements
to continually resize after full page zooming, by using the movie's natual size (which is independent
of zooming), rather than its current size (which is not).

Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
<rdar://problem/6822344>.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize):
16:58 Changeset [42913] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-04-27 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

<rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
load if movie had been previously viewed

Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
16:33 Changeset [42912] by weinig@apple.com
  • 14 edits in trunk/WebCore

2009-04-27 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Move more window event related code into DOMWindow.

  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setWindowAttributeEventListener): (WebCore::Document::dispatchWindowEvent): (WebCore::Document::dispatchLoadEvent):
  • dom/Document.h:
  • dom/Element.cpp:
  • dom/Element.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::dispatchEvent): (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget): (WebCore::DOMWindow::dispatchLoadEvent): (WebCore::DOMWindow::dispatchUnloadEvent): (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
  • page/DOMWindow.h:
  • page/Frame.cpp: (WebCore::Frame::shouldClose):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
16:14 Changeset [42911] by adele@apple.com
  • 25 edits in trunk

WebCore:

2009-04-27 Douglas R. Davidson <ddavidso@apple.com>

Implement the editing mechanisms and add context menu items for
<rdar://problem/6724106> WebViews need to implement text checking

Reviewed by Justin Garcia.

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/TypingCommand.cpp:
  • loader/EmptyClients.h:
  • page/ContextMenuController.cpp:
  • page/EditorClient.h:
  • page/mac/WebCoreViewFactory.h:
  • platform/ContextMenu.cpp:
  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm:

WebKit:

2009-04-27 Douglas R. Davidson <ddavidso@apple.com>

Add localizable strings for
<rdar://problem/6724106> WebViews need to implement text checking

Reviewed by Justin Garcia.

  • English.lproj/Localizable.strings:

WebKit/mac:

2009-04-27 Douglas R. Davidson <ddavidso@apple.com>

Add the various switches and context menu items needed for
<rdar://problem/6724106> WebViews need to implement text checking
and adopt updatePanels in place of old SPI _updateGrammar.

Reviewed by Justin Garcia.

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::uppercaseWord): (WebEditorClient::lowercaseWord): (WebEditorClient::capitalizeWord): (WebEditorClient::showSubstitutionsPanel): (WebEditorClient::substitutionsPanelIsShowing): (WebEditorClient::toggleSmartInsertDelete): (WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebEditorClient::toggleAutomaticQuoteSubstitution): (WebEditorClient::isAutomaticLinkDetectionEnabled): (WebEditorClient::toggleAutomaticLinkDetection): (WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebEditorClient::toggleAutomaticDashSubstitution): (WebEditorClient::isAutomaticTextReplacementEnabled): (WebEditorClient::toggleAutomaticTextReplacement): (WebEditorClient::isAutomaticSpellingCorrectionEnabled): (WebEditorClient::toggleAutomaticSpellingCorrection): (WebEditorClient::checkTextOfParagraph):
  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagShowColors]): (-[WebViewFactory contextMenuItemTagCorrectSpellingAutomatically]): (-[WebViewFactory contextMenuItemTagSubstitutionsMenu]): (-[WebViewFactory contextMenuItemTagShowSubstitutions:]): (-[WebViewFactory contextMenuItemTagSmartCopyPaste]): (-[WebViewFactory contextMenuItemTagSmartQuotes]): (-[WebViewFactory contextMenuItemTagSmartDashes]): (-[WebViewFactory contextMenuItemTagSmartLinks]): (-[WebViewFactory contextMenuItemTagTextReplacement]): (-[WebViewFactory contextMenuItemTagTransformationsMenu]): (-[WebViewFactory contextMenuItemTagMakeUpperCase]): (-[WebViewFactory contextMenuItemTagMakeLowerCase]): (-[WebViewFactory contextMenuItemTagCapitalize]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView isAutomaticQuoteSubstitutionEnabled]): (-[WebHTMLView setAutomaticQuoteSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticQuoteSubstitution:]): (-[WebHTMLView isAutomaticLinkDetectionEnabled]): (-[WebHTMLView setAutomaticLinkDetectionEnabled:]): (-[WebHTMLView toggleAutomaticLinkDetection:]): (-[WebHTMLView isAutomaticDashSubstitutionEnabled]): (-[WebHTMLView setAutomaticDashSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticDashSubstitution:]): (-[WebHTMLView isAutomaticTextReplacementEnabled]): (-[WebHTMLView setAutomaticTextReplacementEnabled:]): (-[WebHTMLView toggleAutomaticTextReplacement:]): (-[WebHTMLView isAutomaticSpellingCorrectionEnabled]): (-[WebHTMLView setAutomaticSpellingCorrectionEnabled:]): (-[WebHTMLView toggleAutomaticSpellingCorrection:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebUIDelegatePrivate.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView setGrammarCheckingEnabled:]): (-[WebView isAutomaticQuoteSubstitutionEnabled]): (-[WebView isAutomaticLinkDetectionEnabled]): (-[WebView isAutomaticDashSubstitutionEnabled]): (-[WebView isAutomaticTextReplacementEnabled]): (-[WebView isAutomaticSpellingCorrectionEnabled]): (-[WebView setAutomaticQuoteSubstitutionEnabled:]): (-[WebView toggleAutomaticQuoteSubstitution:]): (-[WebView setAutomaticLinkDetectionEnabled:]): (-[WebView toggleAutomaticLinkDetection:]): (-[WebView setAutomaticDashSubstitutionEnabled:]): (-[WebView toggleAutomaticDashSubstitution:]): (-[WebView setAutomaticTextReplacementEnabled:]): (-[WebView toggleAutomaticTextReplacement:]): (-[WebView setAutomaticSpellingCorrectionEnabled:]): (-[WebView toggleAutomaticSpellingCorrection:]):
  • WebView/WebViewPrivate.h:
16:12 Changeset [42910] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-27 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower

Be slightly less eager in collecting after page close/navigation by increasing
the time before collection from 0 seconds to .5 seconds.

3% speedup on the PLT.

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon):
16:06 Changeset [42909] by ddkilzer@apple.com
  • 10 edits
    2 adds in trunk

Consolidate runtime application checks for Apple Mail and Safari

Reviewed by Mark Rowe and Darin Adler.

WebCore:

  • WebCore.base.exp: Added exports.
  • WebCore.xcodeproj/project.pbxproj: Added RuntimeApplicationChecks.{h|mm} source files to the project.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Removed local checkedSafari and isSafari variables and switched to use applicationIsSafari().
  • platform/mac/RuntimeApplicationChecks.h: Added.
  • platform/mac/RuntimeApplicationChecks.mm: Added. (WebCore::applicationIsAppleMail): Runtime application check for Apple Mail. (WebCore::applicationIsSafari): Runtime application check for Safari.

WebKit:

  • WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): Removed. (fixMenusToSendToOldClients): Switched to use applicationIsAppleMail().
  • WebView/WebFrame.mm: (-[WebFrame reload]): Switched to use applicationIsSafari().
  • WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto.
  • WebView/WebResource.mm: (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Switched to use applicationIsAppleMail().
  • WebView/WebView.mm: (runningLeopardMail): Ditto. (runningTigerMail): Ditto. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Switched to use applicationIsSafari().
15:34 Changeset [42908] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374

Updated to fix regression test failures

14:56 Changeset [42907] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Cover more WebCore role -> ATK role conversions.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
14:40 Changeset [42906] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Do not call ATK setters in the getters, just return the
value. Among other things calling the setter will emit the notify
signal, which is wrong.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
14:33 Changeset [42905] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-04-16 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements

Based on a patch by Alp Toker.

Implement AtkImage interface.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp:
14:25 Changeset [42904] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-27 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed debug build fix.

  • platform/gtk/gtk2drawing.c: (moz_gtk_toggle_paint):
13:12 Changeset [42903] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>

Build fix.

https://bugs.webkit.org/show_bug.cgi?id=25382
Remove direct reference to CallFrame.h include to pacify Win build.

  • bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
  • bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
12:49 Changeset [42902] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374

12:46 Changeset [42901] by dglazkov@chromium.org
  • 10 edits in trunk/WebCore

2009-04-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25382
Move scriptStateFromNode to ScriptState.

  • bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
  • bindings/js/JSDOMBinding.h: Ditto.
  • bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
  • bindings/js/ScriptState.h: Ditto.
  • bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
  • bindings/v8/ScriptState.h: Ditto.
  • dom/NodeFilter.h: Removed JSDOMBinding header include.
  • dom/NodeIterator.h: Ditto.
  • dom/TreeWalker.h: Ditto.
12:44 Changeset [42900] by cfleizach@apple.com
  • 4 edits in trunk

Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
https://bugs.webkit.org/show_bug.cgi?id=25428

12:33 Changeset [42899] by andersca@apple.com
  • 2 edits in trunk/WebKitExamplePlugins

2009-04-27 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Update the example plug-in for new changes to the Cocoa event model.


  • NetscapeCocoaPlugin/main.m: (handleDraw): (handleMouseEvent): (NPP_HandleEvent):
11:54 Changeset [42898] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build.


  • Plugins/WebNetscapePluginView.mm: The base class of WebNetscapePluginView.mm, WebBaseNetscapePluginView, already implemented the two methods below. But the Tiger compiler didn't know that. (-[WebNetscapePluginView webView]): (-[WebNetscapePluginView webFrame]):
10:50 Changeset [42897] by kdecker@apple.com
  • 10 edits
    2 adds in trunk/WebKit

Reviewed by Anders Carlsson.

<rdar://problem/6352982>


  • Plugins/WebBaseNetscapePluginView.mm: Removed checkIfAllowedToLoadURL:frame:callbackFunc, cancelCheckIfAllowedToLoadURL, and _webPluginContainerCancelCheckIfAllowedToLoadRequest from the base class. These methods now exist in the subclass WebNetscapePluginView.


Added WebNetscapeContainerCheckContextInfo, which is used as a "contextInfo" object in
-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]

  • Plugins/WebNetscapeContainerCheckContextInfo.h: Added.
  • Plugins/WebNetscapeContainerCheckContextInfo.mm: Added. (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:]): Added desiginated initializer. (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Added. Returns the checkRequestID. (-[WebNetscapeContainerCheckContextInfo callback]): Added. Returns the callback.


  • Plugins/WebNetscapePluginView.h: Added two new ivars: _containerChecksInProgress and _currentContainerCheckRequestID.
  • Plugins/WebNetscapePluginView.mm: #import both WebPluginContainerCheck.h and WebNetscapeContainerCheckContextInfo.h


(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added. This is the implementation of WKN_CheckIfAllowedToLoadURL.
Here, we increment the request ID and start the container check.


(-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Added. This is a callback method for WebPluginContainerCheck.
It's where we actually call into the plug-in and provide the allow-or-deny result.


(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Added. This is the implementation of WKN_CancelCheckIfAllowedToLoadURL.
Here we lookup the check, cancel it, and remove it from _containerChecksInProgress.


(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added. WebPluginContainerCheck automatically calls
this method after invoking our _containerCheckResult: selector. It works this way because calling -[WebPluginContainerCheck cancel] allows
it to do it's teardown process.


(-[WebNetscapePluginView fini]): Release _containerChecksInProgress ivar.


  • Plugins/WebPluginContainerCheck.h: Removed initWithRequest: method from header; no client was using this method directly.
  • Plugins/WebPluginContainerCheck.mm: (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:contextInfo:]): Added optional contextInfo parameter. (-[WebPluginContainerCheck _continueWithPolicy:]): If there's a contextInfo object, pass it as a parameter to resultSelector. (-[WebPluginContainerCheck cancel]): Release _contextInfo ivar. (-[WebPluginContainerCheck contextInfo]): Added new method. Returns the contextInfo object, if one so exists.
  • Plugins/WebPluginController.mm: (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Pass nil for contextInfo. WebKit-style plug-ins do not need additional context information.
09:57 Changeset [42896] by ap@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25399
<rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
beneath WebCore::Cache::evict

The crash happened because a cached resource handle was removed from a document's cached
resources map twice recursively, so a destructor was called for a value in a deleted bucket.
The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
an inconsistent state.

I couldn't fully reconstruct the loading sequence to make a test.

  • loader/Cache.cpp: (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache (it makes no sense to revalidate one that isn't). (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource from the cache in no way implies that documents no longer use the old version. This fixes the crash, and also fixes many cases of resource content being unavailable in Web Inspector.
  • loader/CachedResource.h: (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache, reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases, switchClientsToRevalidatedResource() results in the same resource being requested again, but we were only enforcing CachedResource invariants after calling this function. (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
  • loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed resource is removed, not some other resource that happens to have the same URL (this used to fail on LexisNexis search before this patch).
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED with notImplemented(). This method can be legally called via document.write(), and should work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it doesn't affect site functionality.
  • loader/CachedResource.cpp: (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate is being revalidated - this may no longer be true, because we now reset this member in CachedResource::setInCache().
09:24 Changeset [42895] by mitz@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • make BidiContext a RefCounted class, starting with a refcount of 1, and share the root BidiContexts.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
  • platform/text/BidiContext.cpp: (WebCore::BidiContext::create): Added. For the four "root" contexts, returns a reference to a shared static BidiContext.
  • platform/text/BidiContext.h: (WebCore::BidiContext::BidiContext):
  • platform/text/BidiResolver.h: (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
  • rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Ditto.
08:23 Changeset [42894] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Build fix for r42893: change GDK_exclaim to GDK_exclam

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
08:08 Changeset [42893] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-04-27 Fumitoshi Ukai <ukai@google.com>

Reviewed by Xan Lopez.

Fix wrong key code conversion.

Missing conversion for GDK_exlaim ('!').
Parens are opposite: GDK_parenleft is open paren '('
and GDK_parenright is close paren ')'.
https://bugs.webkit.org/show_bug.cgi?id=25367

  • platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
  • platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
08:08 Changeset [42892] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[Gtk] gtkdrawing update
https://bugs.webkit.org/show_bug.cgi?id=25408

Update to the 25 Apr 2009 version of gtk2drawing.c and
gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)

  • platform/gtk/gtk2drawing.c: (setup_widget_prototype): (moz_gtk_get_combo_box_entry_arrow): (ensure_toolbar_widget): (ensure_tree_header_cell_widget): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_menu_separator_paint): (moz_gtk_get_widget_border): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_toolbar_separator_width): (moz_gtk_get_menu_separator_height): (moz_gtk_widget_paint): (moz_gtk_shutdown):
  • platform/gtk/gtkdrawing.h:
08:08 Changeset [42891] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

[GTK] Make layout tests / jsc tests usable without build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21784

This requires WEBKITOUTPUTDIR to be set to the build directory.
Set the location of the product dir to the location pointed to by
WEBKITOUTPUTDIR.

  • Scripts/webkitdirs.pm:
07:54 Changeset [42890] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Adam Roben.

Use libsoup's facilities to resolve relative URLs, instead, since
it is a more robust method.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
07:53 Changeset [42889] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation

Check whether we should fallback also on didFailLoad, so that we
don't get error pages showing up in parts of the content of some
sites because of, for instance, location changes.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
07:53 Changeset [42888] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation

Correctly handle cancellation and frame loading interruption
caused by policy change. This also fixes
fast/frames/location-change.html.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::shouldFallBack):
06:55 Changeset [42887] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=18475

[Qt] Widget painting should follow the layout direction (LTR, RTL)
of the element style, not the application layout direction.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
06:27 Changeset [42886] by aroben@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows Debug build fix

Not sure why the buildbots weren't affected by this problem.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS re-order the file list, and added JavaScriptCore[_debug].def to the project. This was not necessary for the fix, but made making the fix easier.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed a function that no longer exists.

04/26/09:

22:58 Changeset [42885] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

Plug memory leak.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
22:17 Changeset [42884] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Weinig Sam.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25416
"Cached prototype accesses unsafely hoist property storage load above structure checks."


Do not hoist the load of the pointer to the property storage array.

No performance impact.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList):
21:32 Changeset [42883] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoffrey "Gaffe or energy?" Garen.

Randomize address requested by ExecutableAllocatorFixedVMPool.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
17:03 Changeset [42882] by weinig@apple.com
  • 10 edits
    3 adds in trunk

WebCore:

2009-04-26 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget

Test: fast/dom/Window/dispatchEvent.html

  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Add DOMWindow case. (WebCore::toEventTarget): Ditto.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDOMWindow): Added.
  • dom/EventTarget.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document. (WebCore::DOMWindow::dispatchEvent): Added.
  • page/DOMWindow.h: (WebCore::DOMWindow::toDOMWindow): (WebCore::DOMWindow::refEventTarget): (WebCore::DOMWindow::derefEventTarget):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-26 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget

  • fast/dom/Window/dispatchEvent-expected.txt: Added.
  • fast/dom/Window/dispatchEvent.html: Added.
  • fast/dom/Window/resources/dispatchEvent.js: Added.
  • fast/dom/Window/window-properties-expected.txt
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
14:09 Changeset [42881] by weinig@apple.com
  • 2 edits
    2 deletes in trunk

JavaScriptCore:

2009-04-26 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Remove scons-based build system.

WebCore:

2009-04-26 Sam Weinig <sam@webkit.org>

Reviewed by Eric Seidel.

Remove scons-based build system.

  • WebCore.scons: Removed.
11:11 Changeset [42880] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-26 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Resolve relative URLs when queueing loads. This fixes
post-goback-same-url.html timing out.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
10:23 Changeset [42879] by xan@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25391
G_SIGNAL_ACTION flag in WebKitWebView signals

Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag,
but I don't think this makes sense. The flag is meant for those
signals that can be emitted by the user to trigger some action in
the view, as if it were a normal API, which is not the case for
most of them.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
  • webkit/webkitwebview.cpp:
10:11 Changeset [42878] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <xlopez@igalia.com>

Unreviewed, actually apply the right patch.

  • webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
10:05 Changeset [42877] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Pass a variable to hold the return value of the 'move-cursor'
signal, otherwise a crash can happen.

  • webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
07:25 Changeset [42876] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-04-26 Darin Adler <darin@apple.com>

Suggested by Darin Fisher.

Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0. Not sure if when this case can really arise in practice, but it's good to match the original logic more closely.
00:02 QtWebKitTodo edited by hausmann@webkit.org
(diff)
00:01 Changeset [42875] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-04-25 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

A width or height of zero for the destination or source rect of an
image causes a not invertible pattern matrix.
This crahes newer versions of Cairo and give some graphic gliches in
Canvas.
With this patch we check if there is something to draw and return if not.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):

04/25/09:

21:35 Changeset [42874] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <gns@gnome.org>

Go back to disabling accessibility tests as a whole, since we have
no real way of checking them, and no accessibilityController
implementation.

  • platform/gtk/Skipped:
21:25 Changeset [42873] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <gns@gnome.org>

Disable tests that need eventSender, not yet implemented in our
DumpRenderTree.

  • platform/gtk/Skipped:
21:11 Changeset [42872] by simon.fraser@apple.com
  • 6 edits
    2 adds in trunk

2009-04-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25390

Fix point mapping and hit testing through transforms and perspective
with ENABLE_3D_RENDERING. Previously the code did the more efficient
move(), rather than getTransformFromContainer(), when the object had
no transform. However, this skipped the application of perspective
when the immediate child of the perspective element had no transform
itself.

Test: transforms/3d/point-mapping/3d-point-mapping-3.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): Call shouldUseTransformFromContainer() to determine if we need to go through the more expensive getTransformFromContainer() code path.
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldUseTransformFromContainer): New method that indicates whether we need use getTransformFromContainer() when mapping points through renderers, and hit testing.
16:30 Changeset [42871] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Some *obvious* style cleanup in my last patch.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded):
16:24 Changeset [42870] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <beidson@apple.com>

Reviewed by Oliver Hunt

<rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)

BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
tried to go to it. In some cases it would be dealloc'ed first.
When WebHistoryItems were pure Objective-C they probably got away with this more often.
With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded): (-[WebBackForwardList backListWithLimit:]): If this is BumperCar, hang on to the NSArray of WebHistoryItems until the next time this method is called. (-[WebBackForwardList forwardListWithLimit:]): Ditto.
  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
12:00 Changeset [42869] by adele@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-04-25 Adele Peterson <adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
https://bugs.webkit.org/show_bug.cgi?id=25396

Test: editing/deleting/delete-br-013.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Only preserve an empty paragraph's style when moving paragraphs around if the selection is still in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite the previous paragraph's style during a delete of an empty paragraph.

LayoutTests:

2009-04-25 Adele Peterson <adele@apple.com>

Reviewed by Oliver Hunt.

Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
https://bugs.webkit.org/show_bug.cgi?id=25396

  • editing/deleting/delete-br-013.html: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.png: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
10:48 Changeset [42868] by eric.carlson@apple.com
  • 8 edits in trunk/WebCore

2009-04-25 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
properly display non-linear media

If a media engine claims it can support the MIME type, WebCore now creates a <video>
element for document mode media files instead of an <embed> element. Because WebCore's
QuickTime backed media players do not support every kind of media the QuickTime plug-in
supports, and because it is not always possible to tell what type of media is in a file
without opening and parsing it, some types of media that used to be displayed properly
by a plug-in are no longer supported properly. To fix this, if the media engine
sees that it can not completely support a media file it now informs the media
document, which replaces the <video> element with an <embed>.


r42301 landed support for OSX. This patch modifies those changes slighly and adds support
for Windows.

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> element immediately. (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed. Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
  • loader/MediaDocument.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::rateChanged): Ditto. (WebCore::MediaPlayerPrivate::timeChanged): Ditto. (WebCore::MediaPlayerPrivate::didEnd): Ditto. (WebCore::MediaPlayerPrivate::repaint): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported media type(s) or if it fails completely. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the media player client we won't play this movie correctly. (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::setSize): Ditto. (WebCore::MediaPlayerPrivate::setVisible): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::movieEnded): Ditto. (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto. (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto. (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state change callback. (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled. (QTMovieWin::QTMovieWin): Initialize m_disabled. (QTMovieWin::disableUnsupportedTracks): Return total number of tracks. (QTMovieWin::setDisabled): New, set m_disabled flag.
  • platform/graphics/win/QTMovieWin.h:
07:02 Changeset [42867] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames

Refactor the emission of the download-requested signal so that we
have less code duplication.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
02:19 Changeset [42866] by jmalonzo@webkit.org
  • 6 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344

Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
errors and G_IO_ERROR for gio errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344

Update FrameLoad errors to use WebKitErrors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError): (WebKit::FrameLoaderClient::shouldFallBack):
  • webkit/webkiterror.h: Added.
  • webkit/webkiterror.cpp: Added.

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344

Add webkiterror to the build.

  • GNUmakefile.am:
02:19 Changeset [42865] by jmalonzo@webkit.org
  • 4 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344

Add the default error page for installation.

  • GNUmakefile.am:

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Display a default error page for load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • resources/error.html: Added.
02:19 Changeset [42864] by jmalonzo@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
https://bugs.webkit.org/show_bug.cgi?id=18344

Add a WebKitWebFrame API to load alternate content for unreachable URLs.
Also add a new signal "load-error" for handling load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::dispatchDidFailLoading): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
02:04 Changeset [42863] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

01:44 Changeset [42862] by jmalonzo@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk build fix - check if we have MADV_FREE before using it.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity):
  • wtf/Platform.h:

04/24/09:

21:03 Changeset [42861] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Mark Rowe.

Only set the new URL once for the request. Doing it a second time
after the call to willSendRequest was causing crashes when
redirected requests got cancelled.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
20:44 Changeset [42860] by kevino@webkit.org
  • 8 edits in trunk

wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.

20:19 Changeset [42859] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding ScriptEventListener.cpp.

17:27 Changeset [42858] by jmalonzo@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25337
Move ThreadingQt.cpp under the qt directory.

17:18 Changeset [42857] by jmalonzo@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2009-04-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25338
Move ThreadingGtk.cpp under the gtk directory.

  • GNUmakefile.am:
  • wtf/ThreadingGtk.cpp: Removed.
  • wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
17:05 Changeset [42856] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Fix braces to comply with style guidelines.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getClipboard): (WebKit::PasteboardHelperGtk::getCopyTargetList): (WebKit::PasteboardHelperGtk::getPasteTargetList):
17:05 Changeset [42855] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Copy the link location to the primary selection as well as the
clipboard selection when using the "copy link selection" context
menu entry.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL):
  • platform/gtk/PasteboardHelper.h:

2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Add a method for getting the primary selection.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getPrimary):
  • WebCoreSupport/PasteboardHelperGtk.h:
16:54 Changeset [42854] by eric@webkit.org
  • 7 edits in trunk

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=25383
Changing SVG size via JS does not update CSS width/height

Add an ugly hack to fix CSS width/height updates from JS.

We can't easily call setAttribute when width/height changes
as that would cause infinite recursion (as we'd try to set
the animation storage from the attributes)

For now, when we get notification that JS changed width/height
we copy what parseMappedAttribute does and update the CSS values as well.

A better fix for this would be:
https://bugs.webkit.org/show_bug.cgi?id=25383

  • svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute): (WebCore::SVGSVGElement::svgAttributeChanged):
16:51 Changeset [42853] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-04-24 Gavin Barraclough <barraclough@apple.com>

Reviewed by Sam "Wesley" Weinig.

Improve performance to YARR interpreter.
(From about 3x slower than PCRE on regex-dna to about 30% slower).

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::checkCharacter): (JSC::Yarr::Interpreter::checkCasedCharacter): (JSC::Yarr::Interpreter::backtrackPatternCharacter): (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter): (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin): (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::regexEnd): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::): (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd): (JSC::Yarr::ByteTerm::SubpatternBegin): (JSC::Yarr::ByteTerm::SubpatternEnd):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
  • yarr/RegexPattern.h:
16:41 Changeset [42852] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-04-24 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

We should not show the deletion UI for blockquotes in mail but they do
show now that we only check for one visible border.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
16:28 Changeset [42851] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com>

Rubber-stamped by Mark Rowe.

  • wtf/CurrentTime.h: Fix a typo in a comment.
16:05 Changeset [42850] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • address Hyatt's review comments on the last patch
  • rendering/RenderLayer.cpp: (WebCore::performOverlapTests): (WebCore::RenderLayer::paintLayer):
16:00 Changeset [42849] by mitz@apple.com
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Dave Hyatt.

  • WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
  • page/FrameView.cpp: (WebCore::FrameView::reset): Initialize m_isOverlapped. (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped. (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints() so overlapping is taken into account. (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and enables or disables copy-on-scroll accordingly.
  • page/FrameView.h: Added setIsOverlapped() and m_isOverlapped.
  • rendering/OverlapTestRequestClient.h: Added. During foreground painting, an OverlapTestRequestClient can make a request to test if any subsequently- painted layers overlap a rect. The test result is delivered to the requestClient via setOverlapTestResult(). (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to paintLayer(). When done painting, inform any remaining requestClients that they are not overlapped.

(WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
pass it down to child and reflection layers. Inform requestClients if this
layer overlaps their requested rects.

  • rendering/RenderLayer.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): Added an OverlapTestRequestMap member.
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap to paintLayer().
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): For FrameViews, request an overlap test with the frame. (WebCore::RenderWidget::setOverlapTestResult): Call FrameView::setIsOverlapped() with the result of the overlap test.
  • rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
15:52 Changeset [42848] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser

https://bugs.webkit.org/show_bug.cgi?id=25380

Fixed a race condition on the first 'played' attribute test start.

Previously we were starting nearly right away to play, and probably
before receiving the 'canplay' event. Now we ensure we'll wait for
that 'canplay' event before attempting to play.

  • media/video-played-expected.txt: Updated
  • media/video-played.html:
15:45 Changeset [42847] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-24 Geoffrey Garen <ggaren@apple.com>

Rubber stamped by Eric Seidel.


Updated test to turn the buildbot green after Eric's last check-in.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
15:30 Changeset [42846] by hyatt@apple.com
  • 22 edits
    2 deletes in trunk/WebCore

2009-04-24 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser, Dan Bernstein.

Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
a ~0.5% slowdown. This patch does the following to get the speed back:


(a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
then be removed.
(b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
(c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isSVG): (WebCore::InlineBox::setIsSVG): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::svgBoxHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/ListMarkerBox.cpp: Removed.
  • rendering/ListMarkerBox.h: Removed.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
  • rendering/RenderText.cpp: (WebCore::RenderText::createInlineTextBox):
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::svgBoxHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::svgBoxHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::svgBoxHeight):
15:25 Changeset [42845] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Add PrettyPatch support to run-webkit-tests

  • Scripts/run-webkit-tests:
15:09 Changeset [42844] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

15:00 Changeset [42843] by dglazkov@chromium.org
  • 24 edits
    4 adds in trunk/WebCore

2009-04-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25370
Introduce ScriptEventListener to refactor away direct references to
JSLazyEventListener in WebCore code.

  • GNUmakefile.am: Added ScriptEventListener to project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
  • bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers

to ScriptEventListener.

  • bindings/js/JSLazyEventListener.h: Ditto.
  • bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
  • bindings/js/ScriptEventListener.cpp: Added.
  • bindings/js/ScriptEventListener.h: Added.
  • bindings/v8/ScriptEventListener.cpp: Added.
  • bindings/v8/ScriptEventListener.h: Added.
  • dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
  • html/HTMLBodyElement.cpp: Ditto.
  • html/HTMLButtonElement.cpp: Ditto.
  • html/HTMLElement.cpp: Ditto.
  • html/HTMLFormElement.cpp: Ditto.
  • html/HTMLFrameElementBase.cpp: Ditto.
  • html/HTMLFrameSetElement.cpp: Ditto.
  • html/HTMLImageElement.cpp: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLScriptElement.cpp: Ditto.
  • html/HTMLSelectElement.cpp: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • svg/SVGElement.cpp: Ditto.
  • svg/SVGSVGElement.cpp: Ditto.
14:53 Changeset [42842] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion

Reviewed by Geoff Garen

We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity. If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.

14:52 Changeset [42841] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-04-24 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Added a null check.
14:34 Changeset [42840] by eric@webkit.org
  • 44 edits in trunk

Reviewed by Simon Fraser.

Fix RenderSVGImage to dump with full bounds and style information.
https://bugs.webkit.org/show_bug.cgi?id=25377

No functional changes, we're just now including more info in render tree dumps.

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGImage):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::isSVGImage):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
  • rendering/SVGRenderTreeAsText.h:
14:30 Changeset [42839] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-24 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6761635>.


Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
we're waiting for a reply.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy):
14:18 Changeset [42838] by levin@chromium.org
  • 7 edits in trunk/WebCore

2009-04-24 David Levin <levin@chromium.org>

Reviewed by NOBODY (chromium build fix).

Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::add): (WebCore::V8EventListenerList::remove): (WebCore::V8EventListenerList::clear):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::virtualisAttribute):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): (WebCore::V8EventListener::virtualisAttribute):
14:16 Changeset [42837] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Johan Bilien <jobi@via.ecp.fr>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25373
Popup menu has the wrong size when popped up near the edge
of the screen

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event): Let GTK place the popup menu instead of trying to do better and failing
13:48 Changeset [42836] by simon.fraser@apple.com
  • 19 edits in trunk/LayoutTests

2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser

<rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit

Use better mp4 test file for media tests. The original mp4 file had an unusual
edit (non-zero start time) which is not supported by all media engines. The new
movie should also give more useful pixel test results.

  • media/content/test.mp4: Update the movie.
  • media/progress-event-total-expected.txt: Update test results to match movie duration and content changes.
  • media/progress-event-total.html: Ditto.
  • media/video-currentTime-set-expected.txt: Ditto.
  • media/video-loop-expected.txt: Ditto.
  • platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
  • platform/mac/media/video-aspect-ratio-expected.png: Ditto.
  • platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
  • platform/mac/media/video-controls-rendering-expected.png: Ditto.
  • platform/mac/media/video-display-toggle-expected.checksum: Ditto.
  • platform/mac/media/video-display-toggle-expected.png: Ditto.
  • platform/mac/media/video-empty-source-expected.checksum: Ditto.
  • platform/mac/media/video-layer-crash-expected.checksum: Ditto.
  • platform/mac/media/video-layer-crash-expected.png: Ditto.
  • platform/mac/media/video-transformed-expected.checksum: Ditto.
  • platform/mac/media/video-transformed-expected.png: Ditto.
  • platform/mac/media/video-zoom-expected.checksum: Ditto.
  • platform/mac/media/video-zoom-expected.png: Ditto.
13:08 Changeset [42835] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Fix nightly for Windows x64 users.
Installed browser location is written to a slightly different registry key in that case.


  • FindSafari/FindSafari.cpp: (getInstalledWebKitDirectory):
12:13 Changeset [42834] by kmccullough@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-04-24 Kevin McCullough <kmccullough@apple.com>

When I moved the files I forgot to update the location of the image!

  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Added.
11:43 Changeset [42833] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-04-24 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25343
Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
ignores blur.

  • WebCore\platform\graphics\skia\GraphicsContextSkia.cpp (WebCore::GraphicsContext::setPlatformShadow): Add check against blur before clearing looper.
11:41 Changeset [42832] by kmccullough@apple.com
  • 1 edit
    3 deletes in trunk/LayoutTests

2009-04-24 Kevin McCullough <kmccullough@apple.com>

  • Build fix. Removed this test until I can figure out why it's failing.
  • platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
11:40 Changeset [42831] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-24 Eric Roman <eroman@chromium.org>

Reviewed by Darin Adler.

Initialize TextIterator::m_textLength to 0.

This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).

<https://bugs.webkit.org/show_bug.cgi?id=25335>

Test: editing/selection/doubleclick-whitespace-img-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator):

LayoutTests:

2009-04-24 Eric Roman <eroman@chromium.org>

Reviewed by Darin Adler.

Add a test for <https://bugs.webkit.org/show_bug.cgi?id=25335>.

To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).

  • editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
  • editing/selection/doubleclick-whitespace-img-crash.html: Added.
11:38 Changeset [42830] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitLibraries

2009-04-24 Simon Fraser <simon.fraser@apple.com>

Source changes reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=22242

Update WebKitSystemInterface for Mac with fixes for video controller drawing.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:36 Changeset [42829] by dglazkov@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-04-24 Fumitoshi Ukai <ukai@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25329
Add indexed access method in v8 binding of ClientRectList.

  • bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
11:32 Changeset [42828] by dglazkov@chromium.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-04-24 Fumitoshi Ukai <ukai@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25257
Use null for unspecified event listener attributes of XMLHttpRequest
and XMLHttpRequestUpload in v8 binding.

cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
An event handler attribute, unless otherwise specified, can either
have the value null or be set to a Function object.
Initially, an event handler attribute must be set to null.

Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24 Fumitoshi Ukai <ukai@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25257
Verify XMLHttpRequest has correct attribute value by default.

  • fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
  • fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.
11:02 Changeset [42827] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Gustavo Noronha.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the description of the enable-spell-checking property and correct the mentioning of the default language used.
10:42 Changeset [42826] by kmccullough@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2009-04-24 Kevin McCullough <kmccullough@apple.com>

Speculative fix for leopard build-bot until I have a fix on leopard.

  • platform/mac-leopard/editing: Added.
  • platform/mac-leopard/editing/deleting: Added.
  • platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.
09:38 Changeset [42825] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-04-24 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException): Added a null check.
09:13 Changeset [42824] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-24 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
I added this assertion to help catch the case as soon as it happens instead of random
issues downstream. Figured it's worth checking in by itself.

  • History/WebHistoryItem.mm: (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have this WebHistoryItem as a wrapper.
09:10 Changeset [42823] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2009-04-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=23219

Add support for transtions and animations of background-position, -webkit-background-size,
-webkit-mask-position and -webkit-mask-size.

Tests: transitions/background-transitions.html

transitions/mask-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Add a blend func for LengthSize.

(WebCore::ensurePropertyMap):
Add wrappers for the new properties.

(WebCore::addShorthandProperties):
Add a shorthand property for CSSPropertyBackgroundPosition to map to
CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
CSSPropertyWebkitMaskPositionY.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBackgroundXPosition): (WebCore::InheritedFlags::setBackgroundYPosition): (WebCore::InheritedFlags::setBackgroundSize): (WebCore::InheritedFlags::setMaskXPosition): (WebCore::InheritedFlags::setMaskYPosition): (WebCore::InheritedFlags::setMaskSize): Add setters for the properties that can be animated now.
08:55 Changeset [42822] by adele@apple.com
  • 7 edits in trunk/LayoutTests

2009-04-24 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Updating these pixel results to the generated results on Leopard.

  • platform/mac/editing/inserting/5510537-expected.checksum:
  • platform/mac/editing/inserting/5510537-expected.png:
  • platform/mac/editing/inserting/6703873-expected.checksum:
  • platform/mac/editing/inserting/6703873-expected.png:
  • platform/mac/editing/selection/select-all-iframe-expected.checksum:
  • platform/mac/editing/selection/select-all-iframe-expected.png:
08:39 Changeset [42821] by adele@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

2009-04-24 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

Test: editing/pasteboard/paste-blockquote-after-blockquote.html

When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs. (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
  • editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

  • editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
06:16 Changeset [42820] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Implement EditorClient::ignoreWordInSpellDocument,
EditorClient::learnWord and EditorClient::getGuessesForWord. This
enables the corresponding user actions.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::getGuessesForWord):
06:16 Changeset [42819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Implement EditorClient::checkSpellingOfString; enabling spell checking
to actually happen, this is the basis for other spelling functions.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
06:16 Changeset [42818] by kov@webkit.org
  • 6 edits in trunk

2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add enchant support for spell-checking-languages property to work
properly.

  • GNUmakefile.am:
  • configure.ac:

WebKit/gtk

2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add spell-checking-languages property to WebKitWebSettings.

  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_init): (_WebKitWebSettingsPrivate::webkit_web_settings_finalize): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy): (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):
06:16 Changeset [42817] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add enable-spell-checking property to WebKitWebSettings and implement
EditorClient::isContinuousSpellCheckingEnabled and
EditorClient::toggleContinuousSpellChecking to allow the UI to
enable check as you type spell checking.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isContinuousSpellCheckingEnabled): (WebKit::EditorClient::toggleContinuousSpellChecking):
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
04:12 Changeset [42816] by ariya@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-04-24 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Added Qt-specific expected result for color conversion.

This is to compensate the lack of color profile in Qt to do
color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
instead of very dark black.

  • platform/qt/fast/canvas/set-colors-expected.txt: Added.
04:08 Changeset [42815] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Fix qdoc warning about link to QAction::isEnabled.

03:30 Changeset [42814] by hausmann@webkit.org
  • 5 edits
    13 adds in trunk

2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Added support for generating API docs in the Qt build using "make docs"

Added code snippets and overview from the Qt sources references in the API docs.

01:24 QtWebKitJournal edited by hausmann@webkit.org
(diff)

04/23/09:

23:38 Changeset [42813] by adele@apple.com
  • 5 edits in trunk/LayoutTests

2009-04-23 Adele Peterson <adele@apple.com>

Reviewed by Dan Bernstein.

Updating test to make it easier to see the blockquote in the results.

  • editing/pasteboard/paste-blockquote-into-blockquote-3.html:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
23:03 Changeset [42812] by mrowe@apple.com
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Move deletionUI-helpers.js in to the correct location so that the
tests that use it can find it.

  • platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.
22:12 Changeset [42811] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

With great sadness and a heavy heart I switch us back from YARR to WREC in
order to restore greenness to the world once more.

  • wtf/Platform.h:
22:04 Changeset [42810] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

More Windows build fixage.

21:16 Changeset [42809] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove a symbol that no longer exists.
20:47 Changeset [42808] by timothy@apple.com
  • 25 edits
    3 adds
    2 deletes in trunk

BUG 24604: WebKit profiler reports incorrect total times

JavaScriptCore:

2009-04-23 Francisco Tolmasky <francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash): (JSC::CallIdentifier::Hash::equal): (JSC::CallIdentifier::hash): (WTF::):
  • profiler/HeavyProfile.cpp: Removed.
  • profiler/HeavyProfile.h: Removed.
  • profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile (JSC::Profile::create):
  • profiler/Profile.h:
  • profiler/ProfileNode.cpp:
  • profiler/ProfileNode.h:
  • profiler/TreeProfile.cpp: Removed.
  • profiler/TreeProfile.h: Removed.

WebCore:

2009-04-23 Francisco Tolmasky <francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
displays flattened statistics for a particular function that ran during the profile, and each child
of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
nodes should show how much of the root nodes values came from it. For example, if you had the following to
stacks take place during the profile:

A ->calls 1 times-> B ->calls 2 times-> C
D ->calls 4 times-> C

The tree for the C root node would look like this:

C -> B -> A

-> D

The number of calls values would look like this:

C (6) -> B (2) -> A(2)

-> D (4)

What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
"4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
is the reason that we would get things like 40000% previously with recursion.

This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
can't know exactly how many calls came from where, etc).

  • English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
  • inspector/JavaScriptProfile.cpp: (WebCore::ProfileClass):
  • inspector/JavaScriptProfileNode.cpp: (WebCore::getParent): (WebCore::getHead): (WebCore::getCallUID): (WebCore::ProfileNodeClass):
  • inspector/front-end/BottomUpProfileDataGridTree.js: Added. (WebInspector.BottomUpProfileDataGridTree): (WebInspector.BottomUpProfileDataGridTree.prototype.focus): (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGrid.prototype.removeChild): (WebInspector.DataGrid.prototype.removeChildren): (WebInspector.DataGridNode.prototype.set hasChildren): (WebInspector.DataGridNode.prototype.get hasChildren):
  • inspector/front-end/ProfileDataGridTree.js: Added. (WebInspector.ProfileDataGridNode): (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data): (WebInspector.ProfileDataGridNode.prototype.createCell): (WebInspector.ProfileDataGridNode.prototype.select): (WebInspector.ProfileDataGridNode.prototype.deselect): (WebInspector.ProfileDataGridNode.prototype.expand): (WebInspector.ProfileDataGridNode.prototype.insertChild): (WebInspector.ProfileDataGridNode.prototype.removeChild): (WebInspector.ProfileDataGridNode.prototype.removeChildren): (WebInspector.ProfileDataGridNode.prototype.findChild): (WebInspector.ProfileDataGridNode.prototype.get averageTime): (WebInspector.ProfileDataGridNode.prototype.get averagePercent): (WebInspector.ProfileDataGridNode.prototype.get selfPercent): (WebInspector.ProfileDataGridNode.prototype.get totalPercent): (WebInspector.ProfileDataGridNode.prototype._save): (WebInspector.ProfileDataGridNode.prototype._restore): (WebInspector.ProfileDataGridNode.prototype._merge): (WebInspector.ProfileDataGridTree): (WebInspector.ProfileDataGridTree.prototype.get expanded): (WebInspector.ProfileDataGridTree.prototype.appendChild): (WebInspector.ProfileDataGridTree.prototype.insertChild): (WebInspector.ProfileDataGridTree.prototype.removeChildren): (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save): (WebInspector.ProfileDataGridTree.propertyComparator.comparator): (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator): (WebInspector.ProfileDataGridTree.propertyComparator):
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.set profile): (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree): (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree): (WebInspector.ProfileView.prototype.get currentTree): (WebInspector.ProfileView.prototype.set currentTree): (WebInspector.ProfileView.prototype.get topDownTree): (WebInspector.ProfileView.prototype.get bottomUpTree): (WebInspector.ProfileView.prototype.refresh): (WebInspector.ProfileView.prototype.refreshVisibleData): (WebInspector.ProfileView.prototype.refreshShowAsPercents): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): (WebInspector.ProfileView.prototype.performSearch): (WebInspector.ProfileView.prototype._changeView): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked): (WebInspector.ProfileView.prototype._sortProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype.searchMatchFound):
  • inspector/front-end/TopDownProfileDataGridTree.js: Added. (WebInspector.TopDownProfileDataGridNode): (WebInspector.TopDownProfileDataGridNode.prototype._populate): (WebInspector.TopDownProfileDataGridNode.prototype._exclude): (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:

LayoutTests:

2009-04-23 Francisco Tolmasky <francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
but rather just a different display of the normal treeProfile in the JS data grid.

  • fast/profiler/heavy-view-expected.txt: Removed.
  • fast/profiler/heavy-view.html: Removed.
  • fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile (printProfilesDataWithoutTime):
18:50 Changeset [42807] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Use static functions (and a couple templates)
to further reduce the amount of copy/paste code in SVGRenderTreeAsText

No test changes, only code cleanup.

  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeNameValuePair): (WebCore::writeNameAndQuotedValue): (WebCore::writeIfNotEmpty): (WebCore::writeIfNotDefault): (WebCore::writeStyle): (WebCore::writePositionAndStyle): (WebCore::operator<<):
18:42 Changeset [42806] by kmccullough@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

2009-04-23 Kevin McCullough <kmccullough@apple.com>

  • Windows build fix. Mac only tests go in platform/mac
  • editing/deleting/deletionUI-borders.html: Removed.
  • editing/deleting/deletionUI-differing-background.html: Removed.
  • editing/deleting/deletionUI-minimum-size.html: Removed.
  • platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
  • platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
18:09 Changeset [42805] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <barraclough@apple.com>

Not Reviewed.

Speculative Windows build fix II.

  • yarr/RegexInterpreter.cpp:
17:53 Changeset [42804] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <barraclough@apple.com>

Not Reviewed.

Speculative Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • runtime/RegExp.cpp:
17:50 Changeset [42803] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Simon Fraser.

SVGRenderTreeAsText cleanup/code sharing.

No test changes, only code cleanup.

  • rendering/RenderText.cpp: (WebCore::RenderText::firstRunOrigin):
  • rendering/RenderText.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStandardPrefix): (WebCore::writeChildren): (WebCore::write): (WebCore::writeRenderResources):
17:39 Changeset [42802] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by salty sea dogs Sam & Geoff.

Enable YARR_JIT by default (where supported), replacing WREC.

  • wtf/Platform.h:
17:37 Changeset [42801] by darin@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-04-23 Darin Adler <darin@apple.com>

Removed some stray files that Geoff missed when rolling out changes.

  • svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
  • svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
17:32 Changeset [42800] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-04-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff "Dread Pirate Roberts" Garen.

Various small fixes to YARR JIT, in preparation for enabling it by default.

  • Correctly index into the callframe when storing restart addresses for nested alternatives.
  • Allow backtracking back into matched alternatives of parentheses.
  • Fix callframe offset calculation for parenthetical assertions.
  • When a set of parenthese are quantified with a fixed and variable portion, and the variable portion is quantified once, this should not reset the pattern match on failure to match (the last match from the firxed portion should be preserved).
  • Up the pattern size limit to match PCRE's new limit.
  • Unlclosed parentheses should be reported with the message "missing )".
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::quantifyAtom): (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::loadFromFrameAndJump): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::executeRegex):
  • yarr/RegexParser.h: (JSC::Yarr::Parser::): (JSC::Yarr::Parser::parseTokens): (JSC::Yarr::Parser::parse):
  • yarr/RegexPattern.h: (JSC::Yarr::PatternTerm::): (JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

2009-04-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff "Dread Pirate Roberts" Garen.

This test tries to force itself into PCRE; modify the
test so that as well as dodging WREC it can also avoid
YARR!

  • fast/js/resources/regexp-overflow-too-big.js:
17:25 Changeset [42799] by bdakin@apple.com
  • 5 edits in trunk

WebCore:

2009-04-23 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

WebCore part of fix for <rdar://problem/6333461> REGRESSION
(r36864-r36869): Dragging stocks widget scrollbar drags the whole
widget

  • platform/Scrollbar.h: (WebCore::Scrollbar::isScrollbar):
  • platform/Widget.h: (WebCore::Widget::isScrollbar):

WebKit/mac:

2009-04-23 Beth Dakin <bdakin@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6333461> REGRESSION (r36864-r36869):
Dragging stocks widget scrollbar drags the whole widget

Look for our new WebCore scrollbars in the WebHTMLView and add
proper Dashboard regions for them.

  • WebView/WebView.mm: (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): (-[WebView _addScrollerDashboardRegions:from:]):
16:59 Changeset [42798] by kmccullough@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

2009-04-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content

This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):

LayoutTests:

2009-04-23 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content

This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.

  • editing/deleting/deletionUI-borders.html: Added.
  • editing/deleting/deletionUI-differing-background.html: Added.
  • editing/deleting/deletionUI-minimum-size.html: Added.
  • editing/deleting/resources: Added.
  • editing/deleting/resources/deletionUI-helpers.js: Added. (debug): (determineDeletionUIExistence):
  • platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
16:53 Changeset [42797] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding XMLTokenizer.cpp to the build.

16:32 Changeset [42796] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-23 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6822479> Assertion failure after Reset Safari in new history-writing code

Reviewed by Oliver Hunt

  • History/WebHistory.mm: (-[WebHistoryPrivate data]): Return nil immediately if there are no entries; this matches a recent Windows-platform fix.
16:14 Changeset [42795] by mrowe@apple.com
  • 2 edits in tags/Safari-6530.7/JavaScriptCore

Temporarily work around <rdar://problem/6812854> by forcing our 2GB allocation up in to high memory.

Rubber-stamped by Geoff Garen.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):

15:46 Changeset [42794] by adele@apple.com
  • 2 edits in trunk/WebCore

2009-04-23 Adele Peterson <adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
https://bugs.webkit.org/show_bug.cgi?id=25312

I was unable to reproduce the problem, but I'm pretty sure this will fix it.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
15:38 Changeset [42793] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

15:38 Changeset [42792] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.7

New tag.

15:33 Changeset [42791] by dglazkov@chromium.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

Test: fast/overflow/overflow-y-scroll.html

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn scroll mode.

LayoutTests:

2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

  • fast/overflow/overflow-y-scroll-expected.txt: Added.
  • fast/overflow/overflow-y-scroll.html: Added.

WebKit/mac:

2009-04-23 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn

scroll mode.

15:17 Changeset [42790] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build

15:03 Changeset [42789] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-23 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

Fix <rdar://problem/6821992>

Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
when m_inDestroy is true.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
14:22 Changeset [42788] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Justin Garcia.

  • fix <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing

Test: editing/selection/extend-by-line-anonymous-content-crash.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition): Null-check node. If p is not an editable position, then closestLeafChildForXPos() may have returned a non-editable box, and in particular one belonging to anonymous content. If node is 0, fall back on RenderObject::positionForPoint, which finds the closest position in non-anonymous content. (WebCore::nextLinePosition): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Fixed a typo.

LayoutTests:

Reviewed by Justin Garcia.

  • test for <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing
  • editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
  • editing/selection/extend-by-line-anonymous-content-crash.html: Added.
13:49 Changeset [42787] by hyatt@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-23 David Hyatt <hyatt@apple.com>

Reviewed by Maciej.

Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit


Make the Mac platform the same as all the other platforms. Instead of (incorrectly) marking a FrameView for layout
when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView addSuperviewObservers]):
  • WebView/WebView.mm: (-[WebView _boundsChanged]): (-[WebView removeSizeObservers]): (-[WebView addSizeObservers]):
13:08 Changeset [42786] by kdecker@apple.com
  • 6 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

Second part of the fix for <rdar://problem/6352982>

  • Plugins/WebBaseNetscapePluginView.h: Make this class conform to WebPluginContainerCheckController
  • Plugins/WebBaseNetscapePluginView.mm: Likewise. (-[WebBaseNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added skeleton method.
  • Plugins/WebPluginContainerCheck.h: Added protocol for <WebPluginContainerCheckController>
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]):
  • Plugins/WebPluginController.h: Make this class conform to WebPluginContainerCheckController
12:58 Changeset [42785] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Adele Peterson.

<rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail

Test: http/tests/history/back-to-post.php

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Apply a new cache policy if it changed after the platform request was first created. While at it, also made sure to update timeout.
12:02 Changeset [42784] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2009-04-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

  • pt_BR.po: translation update.
11:45 Changeset [42783] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-23 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

When creating a new drawable object, collect system's
information about the best depth it can provide and use it
in a new colormap that the new drawable requires.

  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
11:06 Changeset [42782] by kdecker@apple.com
  • 8 edits
    2 adds in trunk/WebKit

Reviewed by Anders Carlsson.


First part of <rdar://problem/6352982>

  • Plugins/WebBaseNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h; Added two new method: checkIfAllowedToLoadURL:url:frame:callbackFunc: and cancelCheckIfAllowedToLoadURL:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added skeleton method, does nothing interesting yet. (-[WebBaseNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Likewise.
  • Plugins/WebNetscapeContainerCheckPrivate.h: Added.
  • Plugins/WebNetscapeContainerCheckPrivate.mm: Added. (browserContainerCheckFuncs): Added.
  • Plugins/WebNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h;
  • Plugins/WebNetscapePluginView.mm: Imported #WebNetscapeContainerCheckPrivate.h; added WKN_CheckIfAllowedToLoadURL and WKN_CancelCheckIfAllowedToLoadURL functions. (-[WebNetscapePluginView getVariable:value:]): Return vtable for container check functions.
  • Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL): Added new private function. (WKN_CancelCheckIfAllowedToLoadURL): Ditto.
09:42 Changeset [42781] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip a newly-added test that fails on Windows

See Bug 25344: http/tests/misc/redirect-to-external-url.html fails on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25344>

Reviewed by Brady Eidson.

  • platform/win/Skipped: Added http/tests/misc/redirect-to-external-url.html.
08:39 Changeset [42780] by kov@webkit.org
  • 4 edits in trunk/WebCore

2009-04-23 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15654
GdkPixbuf support for ImageCairo

Add support for converting a Cairo surface to a GdkPixbuf.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h: (WebCore::Image::getGdkPixbuf):
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
08:07 Changeset [42779] by vestbo@webkit.org
  • 1 edit in trunk/WebKit/qt/Api/qwebelement.cpp

Fix Qt build warning

07:55 Changeset [42778] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.

Basically, what we want is to send wheel events to the plugin *only*
when it has focus, or else send it to the parent frame.

This is a work around, and basically what we do, is to steal the
wheel events from the plugin, modify the window ID, and put the
event back into the Qt event loop.

  • plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::PluginClientWrapper): (PluginClientWrapper::~PluginClientWrapper): (PluginClientWrapper::x11Event): (PluginContainerQt::PluginContainerQt): (PluginContainerQt::~PluginContainerQt): (PluginContainerQt::on_clientClosed): (PluginContainerQt::on_clientIsEmbedded): (PluginContainerQt::redirectWheelEventsToParent): (PluginContainerQt::x11Event): (PluginContainerQt::focusInEvent):
  • plugins/qt/PluginContainerQt.h:
06:53 Changeset [42777] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-04-23 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] Added QWebElement::computedStyleProperty method.

  • Api/qwebelement.cpp: (QWebElement::computedStyleProperty):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::computedStyle):
05:46 QtWebKitTodo edited by vestbo@webkit.org
(diff)
05:36 QtWebKitJournal edited by vestbo@webkit.org
(diff)
04:30 Changeset [42776] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-04-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Ariya Hidayat.

[Qt] Rename QWebElement arguments from html to markup

00:25 Changeset [42775] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix the Windows DRT build.

  • DumpRenderTree/win/PolicyDelegate.h:
00:10 Changeset [42774] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-04-23 Brady Eidson <beidson@apple.com>

Fix Windows DRT build.

  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError):
00:09 Changeset [42773] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-23 Brady Eidson <beidson@apple.com>

Update my just-landed layout test to agree with Tiger's CFNetwork

  • http/tests/misc/resources/redirect-to-external-url.php:
Note: See TracTimeline for information about the timeline view.