Timeline


and

05/03/09:

23:46 Changeset [43172] by sfalken@apple.com

Merged r43169.

23:39 Changeset [43171] by eric@webkit.org

No review, just adding missing results.

Add Win results for editing/spelling/spellcheck-attribute
Pixel results are still missing, but I have no easy way
to add them, and the bots aren't generating them currently.

  • platform/win/editing/spelling/spellcheck-attribute-expected.txt: Added.
23:37 Changeset [43170] by sfalken@apple.com

New tag.

23:36 Changeset [43169] by sfalken@apple.com

Windows build fix.

23:05 Changeset [43168] by eric@webkit.org

2009-05-03 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Test: editing/spelling/spellcheck-attribute.html

Bug 14552: Add a way to disable spell checking for specific element
https://bugs.webkit.org/show_bug.cgi?id=14552

For compatibility with Firefox, this code ascends the DOM tree when an element does
not have its "spellcheck" attribute.

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck" attribute of an element before calling a spell checker or a grammar checker.
  • html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
19:00 Changeset [43167] by kov@webkit.org

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Three more failing tests caused by the disabling of the others.

  • platform/gtk/Skipped:
18:38 Changeset [43166] by kov@webkit.org

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Disable more tests that fail on the bot, and those which fail when
we disable some. Hopefully this finishes our massage to the
skipped list and we can go back to working on fixing tests now.

  • platform/gtk/Skipped:
17:42 Changeset [43165] by mrowe@apple.com

Fix the 64-bit build.

  • API/APICast.h:

(toJS):
(toRef):

  • runtime/JSNumberCell.cpp:

(JSC::jsAPIMangledNumber):

  • runtime/JSNumberCell.h:
16:25 Changeset [43164] by eric@webkit.org

Reviewed by Sam Weinig.

Dump more metrics from svgsvgelement-ctm test.
(And break up the first SVG into two SVGs for easier reading of the metrics)

  • svg/custom/svgsvgelement-ctm-expected.txt:
  • svg/custom/svgsvgelement-ctm.xhtml:
14:57 QtWebKitJournal edited by hausmann@webkit.org
(diff)
14:54 QtWebKitTodo edited by hausmann@webkit.org
(diff)
14:44 Changeset [43163] by kov@webkit.org

2009-05-03 Gustavo Noronha Silva <gns@gnome.org>

Some tests are still failing on the bot, despite working
locally. Disabling for now.

  • platform/gtk/Skipped:
14:41 Changeset [43162] by weinig@apple.com

New branch

14:32 Changeset [43161] by kov@webkit.org

2009-05-03 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Enable more tests that succeed and style up the list a bit.

  • platform/gtk/Skipped:
14:02 Changeset [43160] by weinig@apple.com

JavaScriptCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

WebCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

13:59 Changeset [43159] by weinig@apple.com

2009-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Don't pass an exception parameter if we don't care about the value.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
12:56 Changeset [43158] by weinig@apple.com

JavaScriptCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

WebCore:

2009-05-03 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

12:27 Changeset [43157] by weinig@apple.com

JavaScriptCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in.

WebCore:

2009-05-02 Sam Weinig <sam@webkit.org>

Roll JSC API number marshaling back in.

09:49 Changeset [43156] by darin@apple.com

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Maciej Stachowiak.

Bug 25519: streamline lexer by handling BOMs differently
https://bugs.webkit.org/show_bug.cgi?id=25519

Roughly 1% faster SunSpider.

  • parser/Grammar.y: Tweak formatting a bit.
  • parser/Lexer.cpp: (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members that are set up by setCode. (JSC::Lexer::currentOffset): Added. Used where the old code would look at m_currentOffset. (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything to handle BOM characters. (JSC::Lexer::shift2): Ditto. (JSC::Lexer::shift3): Ditto. (JSC::Lexer::shift4): Ditto. (JSC::Lexer::setCode): Updated for name change from yylineno to m_line. Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword. Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code to scan for a BOM character and call copyCodeWithoutBOMs() if we find any. (JSC::Lexer::copyCodeWithoutBOMs): Added. (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line. (JSC::Lexer::makeIdentifier): Moved up higher in the file. (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to use a switch statement instead of just if statements. (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to have fewer branches. (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old m_restrKeyword boolean. (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use fewer branches in the ASCII but not identifier case. (JSC::Lexer::isIdentPart): Ditto. (JSC::Lexer::singleEscape): Moved up higher in the file. (JSC::Lexer::convertOctal): Moved up higher in the file. (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use toASCIIHexValue instead of rolling our own here. (JSC::Lexer::convertUnicode): Ditto. (JSC::Lexer::record8): Moved up higher in the file. (JSC::Lexer::record16): Moved up higher in the file. (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF and m_skipCR with m_skipLineEnd, which requires fewer branches in the main lexer loop. Use currentOffset instead of m_currentOffset. Removed unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit. Split out the two cases for InIdentifierOrKeyword and InIdentifier. Added special case tight loops for identifiers and other simple states. Removed a branch from the code that sets m_atLineStart to false using goto. Streamlined the number-handling code so we don't check for the same types twice for non-numeric cases and don't add a null to m_buffer8 when it's not being used. Removed m_eatNextIdentifier, which wasn't working anyway, and m_restrKeyword, which is redundant with m_lastToken. Set the m_delimited flag without using a branch. (JSC::Lexer::scanRegExp): Tweaked style a bit. (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after parsing. Clear out UString objects in the more conventional way. (JSC::Lexer::sourceCode): Made this no-longer inline since it has more work to do in the case where we stripped BOMs.
  • parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex function, which is the same as toASCIIHexValue. Removed isHexDigit function, which is the same as isASCIIHedDigit. Replaced shift with four separate shift functions. Removed isWhiteSpace function that passes m_current, instead just passing m_current explicitly. Removed isOctalDigit, which is the same as isASCIIOctalDigit. Eliminated unused arguments from matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the makeIdentifier function out of the header. Added lastTokenWasRestrKeyword function. Added new constants for m_skipLineEnd. Removed unused yycolumn, m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken, m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2, m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and m_codeWithoutBOMs.
  • parser/SourceProvider.h: Added hasBOMs function. In the future this can be used to tell the lexer about strings known not to have BOMs.
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
  • wtf/ASCIICType.h: Added using statements to match the design of the other WTF headers.

05/02/09:

21:17 Changeset [43155] by adachan@apple.com

Fix windows build (when doing a clean build)

21:09 Changeset [43154] by mitz@apple.com

WebCore:

Reviewed by Darin Adler.

  • another fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

Test: editing/deleting/type-delete-after-quote-2.html

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_startsAtEmptyLine. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): When the selection starts at an empty line, do not prevent the merging of blocks. This is what allows the text after the line break to be merged into the block containing the line break. Also set m_startsAtEmptyLine to true. (WebCore::DeleteSelectionCommand::mergeParagraphs): If m_startsAtEmptyLine is true, create a placeholder BR to serve as the merge destination.
  • editing/DeleteSelectionCommand.h:

LayoutTests:

Reviewed by Darin Adler.

  • another test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
  • editing/deleting/type-delete-after-quote-2-expected.txt: Added.
  • editing/deleting/type-delete-after-quote-2.html: Added.
18:58 Changeset [43153] by ggaren@apple.com

JavaScriptCore:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Replaced almost all uses of jsImpossibleValue() with uses of JSValue().
Its one remaining use is for construction of hash table deleted values.
For that specific task, I made a new, private constructor with a special
tag. Removed jsImpossibleValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • API/JSCallbackObjectFunctions.h: (JSC::::call):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
  • bytecompiler/BytecodeGenerator.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame):
  • interpreter/CallFrame.h: (JSC::ExecState::clearException):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller):
  • interpreter/Register.h: (JSC::Register::Register):
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_vm_throw):
  • profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute):
  • runtime/ArrayPrototype.cpp: (JSC::getProperty):
  • runtime/Completion.cpp: (JSC::evaluate):
  • runtime/Completion.h: (JSC::Completion::Completion):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::getPrimitiveNumber):
  • runtime/JSArray.cpp: (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting):
  • runtime/JSCell.cpp: (JSC::JSCell::getJSNumber):
  • runtime/JSCell.h: (JSC::JSValue::getJSNumber):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSImmediate.h: (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from):
  • runtime/JSNumberCell.cpp: (JSC::jsNumberCell):
  • runtime/JSObject.cpp: (JSC::callDefaultValueFunction):
  • runtime/JSObject.h: (JSC::JSObject::getDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::next):
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValueHashTraits::constructDeletedValue): (JSC::JSValueHashTraits::isDeletedValue): (JSC::JSValue::JSValue):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject):
  • runtime/Operations.h: (JSC::resolveBase):
  • runtime/PropertySlot.h: (JSC::PropertySlot::clearBase): (JSC::PropertySlot::clearValue):

WebCore:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • bindings/js/JSDOMBinding.cpp: (WebCore::setDOMException):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::dispatchSetValueToInstance):
  • bridge/runtime.h: (JSC::Bindings::Instance::invokeConstruct):

WebKit/mac:

2009-05-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Simplified null-ish JSValues.


Replaced calls to noValue() with calls to JSValue() (which is what
noValue() returned). Removed noValue().


Removed "JSValue()" initialiazers, since default construction happens...
by default.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame evaluateWebScript:]):
16:43 Changeset [43152] by antti@apple.com

2009-05-02 Antti Koivisto <antti@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6631735> Crash in WebCore::CSSStyleSelector::applyProperty(int, WebCore::CSSValue*) (RenderStyle.h:454)


Avoid re-entering style selector from load delegates by not issuing resource loads synchronously during attach().

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks): (WebCore::ContainerNode::attach):
  • dom/Element.cpp: (WebCore::Element::attach):
  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::servePendingRequests): (WebCore::Loader::suspendPendingRequests): (WebCore::Loader::resumePendingRequests): (WebCore::Loader::Host::servePendingRequests):
  • loader/loader.h: (WebCore::Loader::isSuspendingPendingRequests):
14:59 Changeset [43151] by darin@apple.com

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Another cut at getting tests passing on Windows again.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didStartProvisionalLoadForFrame): Tweak formatting. (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto. (FrameLoadDelegate::didCommitLoadForFrame): Ditto. (FrameLoadDelegate::didFinishLoadForFrame): Ditto. (FrameLoadDelegate::didFailLoadWithError): Added missing logging.
14:38 Changeset [43150] by darin@apple.com

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Try to get tests passing on Windows again.

  • DumpRenderTree/win/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Allow either "/" or "\" as a path separator. Also require separator before as well as after path name.
14:14 Changeset [43149] by darin@apple.com

WebCore:

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239

Test: http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html

  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType): Allow comma as a separator.

LayoutTests:

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Bug 25352: REGRESSION(r42322): style isn't applied at bmwusa.com
https://bugs.webkit.org/show_bug.cgi?id=25352
rdar://problem/6823239

  • http/tests/mime/resources/style-with-text-css-and-invalid-type.php: Copied from LayoutTests/http/tests/mime/resources/style-with-charset.php and adapted.
  • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type-expected.txt: Added.
  • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html: Copied from LayoutTests/http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html and adapted.
12:58 Changeset [43148] by darin@apple.com

WebCore:

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

Test: fast/loading/subframe-removes-itself.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true, treat load as complete, even if isLoadingInAPISense is still returning true.

LayoutTests:

2009-05-02 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson (except for the non-fast/loading test fixes).

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

  • fast/loading: Added.
  • fast/loading/resources: Added.
  • fast/loading/resources/subframe-that-removes-itself.html: Added.
  • fast/loading/subframe-removes-itself-expected.txt: Added.
  • fast/loading/subframe-removes-itself.html: Added.
  • fast/frames/location-put-after-removal-expected.txt: Updated. For some reason, fixing the loader sequence results in output that has one more blank line.
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Updated tests so they don't terminate when the partial load of the subframe completes, but rather wait until the subsequent load of about:blank occurs.
  • platform/gtk/Skipped: Skip loading tests.
12:50 Changeset [43147] by kov@webkit.org

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Skip test that sometimes fails in GTK+.

  • platform/gtk/Skipped:
12:39 Changeset [43146] by kov@webkit.org

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25466
WebKitGtk+ 1.1.6 prints weird error messages in Liferea

Use strlen instead of g_utf8_strlen when calculating the size of
the data that is being given to webkit_web_frame_load_string to be
loaded, so that we don't miss any of the content.

  • webkit/webkitwebframe.cpp:
05:47 Changeset [43145] by kov@webkit.org

2009-05-02 Gustavo Noronha Silva <gns@gnome.org>

Skip new test that does not represent a regression.

  • platform/gtk/Skipped:
04:33 Changeset [43144] by mjs@apple.com

2009-05-02 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.

  • speed up the lexer in various ways

~2% command-line SunSpider speedup

  • parser/Lexer.cpp: (JSC::Lexer::setCode): Moved below shift() so it can inline. (JSC::Lexer::scanRegExp): Use resize(0) instead of clear() on Vectors, since the intent here is not to free the underlying buffer. (JSC::Lexer::lex): ditto; also, change the loop logic a bit for the main lexing loop to avoid branching on !m_done twice per iteration. Now we only check it once. (JSC::Lexer::shift): Make this ALWAYS_INLINE and tag an unusual branch as UNLIKELY
  • parser/Lexer.h: (JSC::Lexer::makeIdentifier): force to be ALWAYS_INLINE
  • wtf/Vector.h: (WTF::::append): force to be ALWAYS_INLINE (may have helped in ways other than parsing but it wasn't getting inlined in a hot code path in the lexer)
02:06 Changeset [43143] by ap@webkit.org

Reviewed by Dan Bernstein.

<rdar://problem/6741615> REGRESSION (r38629): Shortcut "Flag/Junk" in MobileMe does not work
when Kotoeri is used.

  • WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Return a nil input context when focus is not in editable content.
00:00 Changeset [43142] by sfalken@apple.com

Merged r43140.

05/01/09:

23:52 Changeset [43141] by sfalken@apple.com

New tag.

23:45 Changeset [43140] by sfalken@apple.com

Windows build fix.

22:56 Changeset [43139] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Fix 64bit build.

  • runtime/JSNumberCell.h: (JSC::JSValue::JSValue):
  • runtime/JSValue.h: (JSC::jsNumber):
21:52 Changeset [43138] by weinig@apple.com

JavaScriptCore:

2009-05-01 Sam Weinig <sam@webkit.org>

Roll out JavaScriptCore API number marshaling.

  • API/APICast.h: (toJS): (toRef):
  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
  • API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): (JSC::::put): (JSC::::deleteProperty): (JSC::::construct): (JSC::::hasInstance): (JSC::::call): (JSC::::toNumber): (JSC::::toString): (JSC::::staticValueGetter): (JSC::::callbackGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeArray): (JSObjectMakeDate): (JSObjectMakeError): (JSObjectMakeRegExp): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSValue.h:

WebCore:

2009-05-01 Sam Weinig <sam@webkit.org>

Roll out JavaScriptCore API number marshaling.

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual):
  • inspector/JavaScriptProfile.cpp: (WebCore::getHeadCallback):
  • inspector/JavaScriptProfileNode.cpp: (WebCore::getChildren): (WebCore::getParent): (WebCore::getHead):
20:12 Changeset [43137] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Fix build.

  • workers/WorkerContext.idl:
19:33 Changeset [43136] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Cleanup workers code a bit.

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJS):
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::customGetOwnPropertySlot):
  • workers/WorkerContext.h: (WebCore::WorkerContext::toWorkerContext): (WebCore::WorkerContext::self): (WebCore::WorkerContext::setOnmessage): (WebCore::WorkerContext::onmessage):
  • workers/WorkerContext.idl:
19:31 Changeset [43135] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Fix windows build.

19:19 Changeset [43134] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

A little clean up.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget):
19:17 Changeset [43133] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Fix the build.

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isEqual):
  • inspector/JavaScriptProfile.cpp: (WebCore::getHeadCallback):
  • inspector/JavaScriptProfileNode.cpp: (WebCore::getChildren): (WebCore::getParent): (WebCore::getHead):
19:16 Changeset [43132] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Fix the build.

17:48 Changeset [43131] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Too Far!" Garen.

Move JS number construction into JSValue.

  • runtime/JSImmediate.h:
  • runtime/JSNumberCell.h: (JSC::JSValue::JSValue):
  • runtime/JSValue.h: (JSC::jsNumber):
17:25 Changeset [43130] by weinig@apple.com

2009-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoff "The Minneapolis" Garen.

Add mechanism to vend heap allocated JS numbers to JavaScriptCore API clients with a
representation that is independent of the number representation in the VM.

  • Numbers leaving the interpreter are converted to a tagged JSNumberCell.
  • The numbers coming into the interpreter (asserted to be the tagged JSNumberCell) are converted back to the VM's internal number representation.
  • API/APICast.h: (toJS): (toRef):
  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
  • API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlot): (JSC::::put): (JSC::::deleteProperty): (JSC::::construct): (JSC::::hasInstance): (JSC::::call): (JSC::::toNumber): (JSC::::toString): (JSC::::staticValueGetter): (JSC::::callbackGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeArray): (JSObjectMakeDate): (JSObjectMakeError): (JSObjectMakeRegExp): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
  • runtime/JSNumberCell.cpp: (JSC::jsAPIMangledNumber):
  • runtime/JSNumberCell.h: (JSC::JSNumberCell::isAPIMangledNumber): (JSC::JSNumberCell::): (JSC::JSNumberCell::JSNumberCell): (JSC::JSValue::isAPIMangledNumber):
  • runtime/JSValue.h:
17:12 Changeset [43129] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 6.

17:07 Changeset [43128] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 5.

16:59 Changeset [43127] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 4.

16:57 Changeset [43126] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 3.

16:55 Changeset [43125] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 2.

16:42 Changeset [43124] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Windows build fix take 1.

16:03 Changeset [43123] by beidson@apple.com

2009-05-01 Brady Eidson <beidson@apple.com>

Reviewed by Oliver Hunt and Sam "Jon 'The Belly' Honeycutt" Weinig

Fix <rdar://problem/6848867> Addition of DOCTYPE node breaks Tiger Mail

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument firstChild]): Add a Tiger Mail version of this method that skips DOCTYPE nodes.
15:43 Changeset [43122] by ggaren@apple.com

JavaScriptCore:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • API/APICast.h: (toJS): (toRef):
  • API/JSCallbackConstructor.h: (JSC::JSCallbackConstructor::createStructure):
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackFunction.h: (JSC::JSCallbackFunction::createStructure):
  • API/JSCallbackObject.h: (JSC::JSCallbackObject::createStructure):
  • API/JSCallbackObjectFunctions.h: (JSC::::asCallbackObject): (JSC::::put): (JSC::::hasInstance): (JSC::::call): (JSC::::staticValueGetter): (JSC::::staticFunctionGetter): (JSC::::callbackGetter):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrototype): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::constantName): (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addConstant): (JSC::BytecodeGenerator::addUnexpectedConstant): (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitGetScopedVar): (JSC::BytecodeGenerator::emitPutScopedVar): (JSC::BytecodeGenerator::emitNewError): (JSC::keyForImmediateSwitch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/Debugger.h:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::put): (JSC::DebuggerActivation::putWithAttributes): (JSC::DebuggerActivation::lookupGetter): (JSC::DebuggerActivation::lookupSetter):
  • debugger/DebuggerActivation.h: (JSC::DebuggerActivation::createStructure):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • debugger/DebuggerCallFrame.h: (JSC::DebuggerCallFrame::DebuggerCallFrame): (JSC::DebuggerCallFrame::exception):
  • interpreter/CachedCall.h: (JSC::CachedCall::CachedCall): (JSC::CachedCall::call): (JSC::CachedCall::setThis): (JSC::CachedCall::setArgument):
  • interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue): (JSC::CallFrame::dumpCaller):
  • interpreter/CallFrame.h: (JSC::ExecState::setException): (JSC::ExecState::exception): (JSC::ExecState::exceptionSlot):
  • interpreter/CallFrameClosure.h: (JSC::CallFrameClosure::setArgument):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::resolveBaseAndFunc): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments): (JSC::Interpreter::retrieveCaller): (JSC::Interpreter::retrieveLastCaller):
  • interpreter/Interpreter.h:
  • interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue):
  • jit/JIT.cpp: (JSC::): (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITCode.h: (JSC::): (JSC::JITCode::execute):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::getConstantOperand): (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitInitRegister):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_vm_throw):
  • jit/JITStubs.h:
  • jsc.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionSetSamplingFlag): (functionClearSamplingFlag): (functionReadline): (functionQuit):
  • parser/Nodes.cpp: (JSC::processClauseList):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
  • profiler/Profiler.cpp: (JSC::Profiler::willExecute): (JSC::Profiler::didExecute): (JSC::Profiler::createCallIdentifier):
  • profiler/Profiler.h:
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::slowAppend):
  • runtime/ArgList.h: (JSC::MarkedArgumentBuffer::at): (JSC::MarkedArgumentBuffer::append): (JSC::ArgList::ArgList): (JSC::ArgList::at):
  • runtime/Arguments.cpp: (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::createStructure): (JSC::asArguments):
  • runtime/ArrayConstructor.cpp: (JSC::callArrayConstructor):
  • runtime/ArrayPrototype.cpp: (JSC::getProperty): (JSC::putProperty): (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanConstructor.cpp: (JSC::callBooleanConstructor): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanConstructor.h:
  • runtime/BooleanObject.h: (JSC::asBooleanObject):
  • runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
  • runtime/CallData.cpp: (JSC::call):
  • runtime/CallData.h:
  • runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap):
  • runtime/Collector.h:
  • runtime/Completion.cpp: (JSC::evaluate):
  • runtime/Completion.h: (JSC::Completion::Completion): (JSC::Completion::value): (JSC::Completion::setValue):
  • runtime/ConstructData.cpp: (JSC::construct):
  • runtime/ConstructData.h:
  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::callDate): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
  • runtime/DateInstance.h: (JSC::asDateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetMilliSeconds): (JSC::dateProtoFuncSetUTCMilliseconds): (JSC::dateProtoFuncSetSeconds): (JSC::dateProtoFuncSetUTCSeconds): (JSC::dateProtoFuncSetMinutes): (JSC::dateProtoFuncSetUTCMinutes): (JSC::dateProtoFuncSetHours): (JSC::dateProtoFuncSetUTCHours): (JSC::dateProtoFuncSetDate): (JSC::dateProtoFuncSetUTCDate): (JSC::dateProtoFuncSetMonth): (JSC::dateProtoFuncSetUTCMonth): (JSC::dateProtoFuncSetFullYear): (JSC::dateProtoFuncSetUTCFullYear): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
  • runtime/DatePrototype.h: (JSC::DatePrototype::createStructure):
  • runtime/ErrorConstructor.cpp: (JSC::callErrorConstructor):
  • runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
  • runtime/ExceptionHelpers.cpp: (JSC::createInterruptedExecutionException): (JSC::createError): (JSC::createStackOverflowError): (JSC::createUndefinedVariableError): (JSC::createErrorMessage): (JSC::createInvalidParamError): (JSC::createNotAConstructorError): (JSC::createNotAFunctionError):
  • runtime/ExceptionHelpers.h:
  • runtime/FunctionConstructor.cpp: (JSC::callFunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::callFunctionPrototype): (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
  • runtime/FunctionPrototype.h: (JSC::FunctionPrototype::createStructure):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::toPrimitive): (JSC::GetterSetter::getPrimitiveNumber):
  • runtime/GetterSetter.h: (JSC::asGetterSetter):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::displayName):
  • runtime/InternalFunction.h: (JSC::InternalFunction::createStructure): (JSC::asInternalFunction):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot): (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes): (JSC::JSActivation::argumentsGetter):
  • runtime/JSActivation.h: (JSC::JSActivation::createStructure): (JSC::asActivation):
  • runtime/JSArray.cpp: (JSC::storageSize): (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::mark): (JSC::compareNumbersForQSort): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::compactForSorting): (JSC::JSArray::checkConsistency): (JSC::constructArray):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::createStructure): (JSC::asArray): (JSC::isJSArray):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::createStructure): (JSC::JSByteArray::put):
  • runtime/JSByteArray.h: (JSC::JSByteArray::getIndex): (JSC::JSByteArray::setIndex): (JSC::asByteArray): (JSC::isJSByteArray):
  • runtime/JSCell.cpp: (JSC::JSCell::put): (JSC::JSCell::getJSNumber):
  • runtime/JSCell.h: (JSC::asCell): (JSC::JSValue::asCell): (JSC::JSValue::isString): (JSC::JSValue::isGetterSetter): (JSC::JSValue::isObject): (JSC::JSValue::getString): (JSC::JSValue::getObject): (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData): (JSC::JSValue::getUInt32): (JSC::JSValue::getTruncatedInt32): (JSC::JSValue::getTruncatedUInt32): (JSC::JSValue::mark): (JSC::JSValue::marked): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::toBoolean): (JSC::JSValue::toNumber): (JSC::JSValue::toString): (JSC::JSValue::toObject): (JSC::JSValue::toThisObject): (JSC::JSValue::needsThisConversion): (JSC::JSValue::toThisString): (JSC::JSValue::getJSNumber):
  • runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::put): (JSC::JSFunction::construct):
  • runtime/JSFunction.h: (JSC::JSFunction::createStructure): (JSC::asFunction):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::put): (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createStructure): (JSC::JSGlobalObject::GlobalPropertyInfo::GlobalPropertyInfo): (JSC::asGlobalObject): (JSC::Structure::prototypeForLookup): (JSC::Structure::prototypeChain): (JSC::Structure::isValid):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncDecodeURI): (JSC::globalFuncDecodeURIComponent): (JSC::globalFuncEncodeURI): (JSC::globalFuncEncodeURIComponent): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
  • runtime/JSImmediate.h: (JSC::JSImmediate::isImmediate): (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDoubleNumber): (JSC::JSImmediate::isPositiveIntegerNumber): (JSC::JSImmediate::isBoolean): (JSC::JSImmediate::isUndefinedOrNull): (JSC::JSImmediate::isEitherImmediate): (JSC::JSImmediate::areBothImmediate): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeValue): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::makeBool): (JSC::JSImmediate::makeUndefined): (JSC::JSImmediate::makeNull): (JSC::JSImmediate::doubleValue): (JSC::JSImmediate::intValue): (JSC::JSImmediate::uintValue): (JSC::JSImmediate::boolValue): (JSC::JSImmediate::rawValue): (JSC::JSImmediate::trueImmediate): (JSC::JSImmediate::falseImmediate): (JSC::JSImmediate::undefinedImmediate): (JSC::JSImmediate::nullImmediate): (JSC::JSImmediate::zeroImmediate): (JSC::JSImmediate::oneImmediate): (JSC::JSImmediate::impossibleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::getTruncatedUInt32): (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::getTruncatedInt32): (JSC::JSImmediate::toDouble): (JSC::JSImmediate::getUInt32): (JSC::JSValue::JSValue): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32): (JSC::JSValue::isCell): (JSC::JSValue::isInt32Fast): (JSC::JSValue::getInt32Fast): (JSC::JSValue::isUInt32Fast): (JSC::JSValue::getUInt32Fast): (JSC::JSValue::makeInt32Fast): (JSC::JSValue::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::equal): (JSC::JSFastMath::notEqual): (JSC::JSFastMath::andImmediateNumbers): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::orImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers): (JSC::JSFastMath::incImmediateNumber): (JSC::JSFastMath::decImmediateNumber):
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::put):
  • runtime/JSNotAnObject.h: (JSC::JSNotAnObject::createStructure):
  • runtime/JSNumberCell.cpp: (JSC::JSNumberCell::toPrimitive): (JSC::JSNumberCell::getPrimitiveNumber): (JSC::JSNumberCell::getJSNumber): (JSC::jsNumberCell):
  • runtime/JSNumberCell.h: (JSC::JSNumberCell::createStructure): (JSC::isNumberCell): (JSC::asNumberCell): (JSC::jsNumber): (JSC::JSValue::isDoubleNumber): (JSC::JSValue::getDoubleNumber): (JSC::JSValue::isNumber): (JSC::JSValue::uncheckedGetNumber): (JSC::jsNaN): (JSC::JSValue::toJSNumber): (JSC::JSValue::getNumber): (JSC::JSValue::numberToInt32): (JSC::JSValue::numberToUInt32):
  • runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defaultValue): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString): (JSC::JSObject::fillGetterPropertySlot):
  • runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset): (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::createStructure): (JSC::asObject): (JSC::JSObject::prototype): (JSC::JSObject::setPrototype): (JSC::JSValue::isObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSObject::get): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::toPrimitive): (JSC::JSValue::get): (JSC::JSValue::put): (JSC::JSObject::allocatePropertyStorageInline):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::toPrimitive): (JSC::JSPropertyNameIterator::getPrimitiveNumber):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::next):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put): (JSC::JSStaticScopeObject::putWithAttributes):
  • runtime/JSStaticScopeObject.h: (JSC::JSStaticScopeObject::JSStaticScopeObject): (JSC::JSStaticScopeObject::createStructure):
  • runtime/JSString.cpp: (JSC::JSString::toPrimitive): (JSC::JSString::getPrimitiveNumber): (JSC::JSString::getOwnPropertySlot):
  • runtime/JSString.h: (JSC::JSString::createStructure): (JSC::asString): (JSC::isJSString): (JSC::JSValue::toThisJSString):
  • runtime/JSValue.cpp: (JSC::JSValue::toInteger): (JSC::JSValue::toIntegerPreserveNaN):
  • runtime/JSValue.h: (JSC::JSValue::makeImmediate): (JSC::JSValue::asValue): (JSC::noValue): (JSC::jsImpossibleValue): (JSC::jsNull): (JSC::jsUndefined): (JSC::jsBoolean): (JSC::operator==): (JSC::operator!=): (JSC::JSValue::encode): (JSC::JSValue::decode): (JSC::JSValue::JSValue): (JSC::JSValue::operator bool): (JSC::JSValue::operator==): (JSC::JSValue::operator!=): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull):
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::symbolTablePut): (JSC::JSVariableObject::symbolTablePutWithAttributes):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
  • runtime/MathObject.h: (JSC::MathObject::createStructure):
  • runtime/NativeErrorConstructor.cpp: (JSC::callNativeErrorConstructor):
  • runtime/NumberConstructor.cpp: (JSC::numberConstructorNaNValue): (JSC::numberConstructorNegInfinity): (JSC::numberConstructorPosInfinity): (JSC::numberConstructorMaxValue): (JSC::numberConstructorMinValue): (JSC::callNumberConstructor):
  • runtime/NumberConstructor.h: (JSC::NumberConstructor::createStructure):
  • runtime/NumberObject.cpp: (JSC::NumberObject::getJSNumber): (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
  • runtime/ObjectConstructor.cpp: (JSC::constructObject): (JSC::callObjectConstructor):
  • runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
  • runtime/ObjectPrototype.h:
  • runtime/Operations.cpp: (JSC::JSValue::equalSlowCase): (JSC::JSValue::strictEqualSlowCase): (JSC::throwOutOfMemoryError): (JSC::jsAddSlowCase): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType):
  • runtime/Operations.h: (JSC::JSValue::equal): (JSC::JSValue::equalSlowCaseInline): (JSC::JSValue::strictEqual): (JSC::JSValue::strictEqualSlowCaseInline): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::resolveBase):
  • runtime/PropertySlot.cpp: (JSC::PropertySlot::functionGetter):
  • runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::getValue): (JSC::PropertySlot::putValue): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setCustom): (JSC::PropertySlot::setCustomIndex): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::setBase): (JSC::PropertySlot::):
  • runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect): (JSC::ProtectedPtr::operator JSValue): (JSC::ProtectedJSValue::ProtectedJSValue): (JSC::ProtectedJSValue::get): (JSC::ProtectedJSValue::operator JSValue): (JSC::ProtectedJSValue::operator->): (JSC::ProtectedJSValue::~ProtectedJSValue): (JSC::ProtectedJSValue::operator=): (JSC::operator==): (JSC::operator!=):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext): (JSC::regExpConstructorDollar1): (JSC::regExpConstructorDollar2): (JSC::regExpConstructorDollar3): (JSC::regExpConstructorDollar4): (JSC::regExpConstructorDollar5): (JSC::regExpConstructorDollar6): (JSC::regExpConstructorDollar7): (JSC::regExpConstructorDollar8): (JSC::regExpConstructorDollar9): (JSC::regExpConstructorInput): (JSC::regExpConstructorMultiline): (JSC::regExpConstructorLastMatch): (JSC::regExpConstructorLastParen): (JSC::regExpConstructorLeftContext): (JSC::regExpConstructorRightContext): (JSC::RegExpConstructor::put): (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp): (JSC::callRegExpConstructor):
  • runtime/RegExpConstructor.h: (JSC::RegExpConstructor::createStructure): (JSC::asRegExpConstructor):
  • runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::put):
  • runtime/RegExpObject.cpp: (JSC::regExpObjectGlobal): (JSC::regExpObjectIgnoreCase): (JSC::regExpObjectMultiline): (JSC::regExpObjectSource): (JSC::regExpObjectLastIndex): (JSC::RegExpObject::put): (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::test): (JSC::RegExpObject::exec): (JSC::callRegExpObject):
  • runtime/RegExpObject.h: (JSC::RegExpObject::createStructure): (JSC::asRegExpObject):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
  • runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::callStringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::put):
  • runtime/StringObject.h: (JSC::StringObject::createStructure): (JSC::asStringObject):
  • runtime/StringObjectThatMasqueradesAsUndefined.h: (JSC::StringObjectThatMasqueradesAsUndefined::createStructure):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::changePrototypeTransition):
  • runtime/Structure.h: (JSC::Structure::create): (JSC::Structure::setPrototypeWithoutTransition): (JSC::Structure::storedPrototype):

JavaScriptGlue:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • JSObject.cpp: (nativeCallFunction):
  • JSUtils.cpp: (KJSValueToJSObject): (JSObjectKJSValue): (KJSValueToCFTypeInternal): (KJSValueToCFType):
  • JSUtils.h:
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction):
  • JSValueWrapper.h:
  • UserObjectImp.cpp: (UserObjectImp::callAsFunction): (UserObjectImp::userObjectGetter): (UserObjectImp::getOwnPropertySlot): (UserObjectImp::put): (UserObjectImp::toPrimitive):
  • UserObjectImp.h: (UserObjectImp::createStructure):

WebCore:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue):
  • bindings/js/JSCDATASectionCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
  • bindings/js/JSCSSValueCustom.cpp: (WebCore::toJS):
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toJS): (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::strokeStyle): (WebCore::JSCanvasRenderingContext2D::setStrokeStyle): (WebCore::JSCanvasRenderingContext2D::fillStyle): (WebCore::JSCanvasRenderingContext2D::setFillStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profiles):
  • bindings/js/JSCoordinatesCustom.cpp: (WebCore::JSCoordinates::altitude): (WebCore::JSCoordinates::altitudeAccuracy): (WebCore::JSCoordinates::heading): (WebCore::JSCoordinates::speed):
  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMBinding.cpp: (WebCore::jsStringOrNull): (WebCore::jsOwnedStringOrNull): (WebCore::jsStringOrUndefined): (WebCore::jsStringOrFalse): (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException): (WebCore::reportCurrentException): (WebCore::setDOMException): (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMObjectWrapper): (WebCore::getDOMNodeWrapper): (WebCore::toJS):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::createJSAttributeEventListener):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::getByIndex): (WebCore::JSDOMStringList::item):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::childFrameGetter): (WebCore::JSDOMWindowBase::indexGetter): (WebCore::JSDOMWindowBase::namedItemGetter): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::setReturnValueSlot): (WebCore::toJS): (WebCore::toJSDOMWindow):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::lookupGetter): (WebCore::JSDOMWindow::lookupSetter): (WebCore::JSDOMWindow::history): (WebCore::JSDOMWindow::location): (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::crypto): (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xmlHttpRequest): (WebCore::JSDOMWindow::xsltProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker): (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): (WebCore::JSDOMWindow::postMessage): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow):
  • bindings/js/JSDOMWindowCustom.h: (WebCore::nonCachingStaticFunctionGetter): (WebCore::JSDOMWindow::customPut):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::put): (WebCore::JSDOMWindowShell::putWithAttributes): (WebCore::JSDOMWindowShell::lookupGetter): (WebCore::JSDOMWindowShell::lookupSetter): (WebCore::toJS):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::createStructure):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation): (WebCore::toJS):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS): (WebCore::toJSNewlyCreated):
  • bindings/js/JSEventCustom.cpp: (WebCore::JSEvent::clipboardData): (WebCore::toJS):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): (WebCore::toEventTarget):
  • bindings/js/JSEventTarget.h:
  • bindings/js/JSEventTargetBase.h:
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSHTMLAllCollection.h: (WebCore::JSHTMLAllCollection::createStructure):
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): (WebCore::JSHTMLAppletElement::nameGetter):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::getNamedItems): (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::open): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln):
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): (WebCore::JSHTMLEmbedElement::nameGetter):
  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::nameGetter): (WebCore::JSHTMLFormElement::submit):
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::JSHTMLFrameElement::setSrc): (WebCore::JSHTMLFrameElement::setLocation):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc):
  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::setSelectionStart): (WebCore::JSHTMLInputElement::selectionEnd): (WebCore::JSHTMLInputElement::setSelectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): (WebCore::JSHTMLObjectElement::nameGetter):
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter): (WebCore::JSHTMLOptionsCollection::add): (WebCore::JSHTMLOptionsCollection::remove):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter): (WebCore::JSHTMLSelectElement::indexSetter):
  • bindings/js/JSHTMLSelectElementCustom.h:
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter): (WebCore::JSHistory::customPut):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  • bindings/js/JSInspectedObjectWrapper.h: (WebCore::JSInspectedObjectWrapper::wrapOutgoingValue):
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap): (WebCore::JSInspectorCallbackWrapper::prepareIncomingValue):
  • bindings/js/JSInspectorCallbackWrapper.h: (WebCore::JSInspectorCallbackWrapper::wrapOutgoingValue):
  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::highlightDOMNode): (WebCore::JSInspectorController::addResourceSourceToFrame): (WebCore::JSInspectorController::addSourceToFrame): (WebCore::JSInspectorController::getResourceDocumentNode): (WebCore::JSInspectorController::search): (WebCore::JSInspectorController::databaseTableNames): (WebCore::JSInspectorController::inspectedWindow): (WebCore::JSInspectorController::setting): (WebCore::JSInspectorController::setSetting): (WebCore::JSInspectorController::wrapCallback): (WebCore::JSInspectorController::currentCallFrame): (WebCore::JSInspectorController::profiles):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate): (WebCore::JSJavaScriptCallFrame::thisObject): (WebCore::JSJavaScriptCallFrame::type): (WebCore::JSJavaScriptCallFrame::scopeChain):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customPut): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
  • bindings/js/JSNamedNodeMapCustom.cpp: (WebCore::JSNamedNodeMap::nameGetter):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::JSNamedNodesCollection::lengthGetter): (WebCore::JSNamedNodesCollection::indexGetter):
  • bindings/js/JSNamedNodesCollection.h: (WebCore::JSNamedNodesCollection::createStructure):
  • bindings/js/JSNavigatorCustom.cpp: (WebCore::needsYouTubeQuirk): (WebCore::JSNavigator::appVersion):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::JSNodeFilterCondition): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h: (WebCore::JSNodeFilterCondition::create):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode): (WebCore::toNodeFilter):
  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): (WebCore::JSNodeIterator::previousNode):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList): (WebCore::JSNodeList::nameGetter):
  • bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
  • bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::runtimeObjectGetter): (WebCore::runtimeObjectPropertyGetter): (WebCore::runtimeObjectCustomPut): (WebCore::callPlugin):
  • bindings/js/JSPluginElementFunctions.h:
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::cachedValueGetter): (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): (WebCore::JSQuarantinedObjectWrapper::put): (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::hasInstance): (WebCore::JSQuarantinedObjectWrapper::call):
  • bindings/js/JSQuarantinedObjectWrapper.h: (WebCore::JSQuarantinedObjectWrapper::createStructure):
  • bindings/js/JSRGBColor.cpp: (WebCore::getJSRGBColor): (jsRGBColorRed): (jsRGBColorGreen): (jsRGBColorBlue):
  • bindings/js/JSRGBColor.h: (WebCore::JSRGBColor::createStructure):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener): (WebCore::toJS):
  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::inverse): (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/JSSVGPathSegCustom.cpp: (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::clear): (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGPointList::clear): (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::finishGetter): (WebCore::finishSetter): (WebCore::finishSetterReadOnlyResult): (WebCore::JSSVGTransformList::clear): (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::nameGetter): (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/JSStyleSheetListCustom.cpp: (WebCore::JSStyleSheetList::nameGetter):
  • bindings/js/JSTextCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::parentNode): (WebCore::JSTreeWalker::firstChild): (WebCore::JSTreeWalker::lastChild): (WebCore::JSTreeWalker::nextSibling): (WebCore::JSTreeWalker::previousSibling): (WebCore::JSTreeWalker::previousNode): (WebCore::JSTreeWalker::nextNode):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::self): (WebCore::JSWorkerContext::setSelf): (WebCore::JSWorkerContext::xmlHttpRequest): (WebCore::JSWorkerContext::importScripts): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener): (WebCore::JSXMLHttpRequest::responseText):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptCallStack.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::jsObjectForPluginElement):
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): (WebCore::ScriptFunctionCall::call): (WebCore::ScriptFunctionCall::construct):
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::get):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::jsValue):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bindings/objc/WebScriptObjectPrivate.h:
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_HasMethod): (_NPN_Construct):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct): (JSC::Bindings::CInstance::defaultValue): (JSC::Bindings::CInstance::stringValue): (JSC::Bindings::CInstance::numberValue): (JSC::Bindings::CInstance::booleanValue): (JSC::Bindings::CInstance::valueOf):
  • bridge/c/c_instance.h:
  • bridge/c/c_runtime.cpp: (JSC::Bindings::CField::valueFromInstance): (JSC::Bindings::CField::setValueToInstance):
  • bridge/c/c_runtime.h:
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant): (JSC::Bindings::convertNPVariantToValue):
  • bridge/c/c_utility.h:
  • bridge/jni/jni_instance.cpp: (JavaInstance::stringValue): (JavaInstance::numberValue): (JavaInstance::booleanValue): (JavaInstance::invokeMethod): (JavaInstance::defaultValue): (JavaInstance::valueOf):
  • bridge/jni/jni_instance.h:
  • bridge/jni/jni_jsobject.h:
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval): (JavaJSObject::getMember): (JavaJSObject::getSlot): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
  • bridge/jni/jni_objc.mm: (JSC::Bindings::dispatchJNICall):
  • bridge/jni/jni_runtime.cpp: (JavaArray::convertJObjectToArray): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance): (JavaArray::setValueAt): (JavaArray::valueAt):
  • bridge/jni/jni_runtime.h:
  • bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
  • bridge/jni/jni_utility.h:
  • bridge/objc/WebScriptObject.h:
  • bridge/objc/objc_class.h:
  • bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::fallbackObject):
  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue): (ObjcInstance::stringValue): (ObjcInstance::numberValue): (ObjcInstance::booleanValue): (ObjcInstance::valueOf):
  • bridge/objc/objc_runtime.h: (JSC::Bindings::ObjcFallbackObjectImp::createStructure):
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcField::valueFromInstance): (JSC::Bindings::convertValueToObjcObject): (JSC::Bindings::ObjcField::setValueToInstance): (JSC::Bindings::ObjcArray::setValueAt): (JSC::Bindings::ObjcArray::valueAt): (JSC::Bindings::ObjcFallbackObjectImp::put): (JSC::Bindings::callObjCFallbackObject): (JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue): (JSC::Bindings::convertNSStringToString): (JSC::Bindings::convertObjcValueToValue):
  • bridge/runtime.h: (JSC::Bindings::Class::fallbackObject): (JSC::Bindings::Instance::setValueOfUndefinedField): (JSC::Bindings::Instance::invokeDefaultMethod): (JSC::Bindings::Instance::invokeConstruct): (JSC::Bindings::Instance::put):
  • bridge/runtime_array.cpp: (JSC::RuntimeArray::lengthGetter): (JSC::RuntimeArray::indexGetter): (JSC::RuntimeArray::put):
  • bridge/runtime_array.h: (JSC::RuntimeArray::createStructure):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::lengthGetter): (JSC::callRuntimeMethod):
  • bridge/runtime_method.h: (JSC::RuntimeMethod::createStructure):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fallbackObjectGetter): (JSC::RuntimeObjectImp::fieldGetter): (JSC::RuntimeObjectImp::methodGetter): (JSC::RuntimeObjectImp::put): (JSC::RuntimeObjectImp::defaultValue): (JSC::callRuntimeObject): (JSC::callRuntimeConstructor):
  • bridge/runtime_object.h: (JSC::RuntimeObjectImp::createStructure):
  • inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::evaluate):
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptProfile.cpp: (WebCore::toJS):
  • inspector/JavaScriptProfile.h:
  • inspector/JavaScriptProfileNode.cpp: (WebCore::toJS):
  • inspector/JavaScriptProfileNode.h:

WebKit/mac:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::addValueToArray): (WebKit::NetscapePluginInstanceProxy::marshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): (WebKit::NetscapePluginInstanceProxy::demarshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValues):
  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyField::valueFromInstance): (WebKit::ProxyField::setValueToInstance): (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::invokeMethod): (WebKit::ProxyInstance::invokeDefaultMethod): (WebKit::ProxyInstance::invokeConstruct): (WebKit::ProxyInstance::defaultValue): (WebKit::ProxyInstance::stringValue): (WebKit::ProxyInstance::numberValue): (WebKit::ProxyInstance::booleanValue): (WebKit::ProxyInstance::valueOf): (WebKit::ProxyInstance::fieldValue): (WebKit::ProxyInstance::setFieldValue):
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame _convertValueToObjcValue:]): (-[WebScriptCallFrame exception]): (-[WebScriptCallFrame evaluateWebScript:]):
  • WebView/WebView.mm: (aeDescFromJSValue): (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

WebKit/qt:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • Api/qwebelement.cpp: (setupScriptContext): (setupScriptObject): (QWebElement::evaluateScript): (QWebElement::functions): (QWebElement::scriptableProperty): (QWebElement::setScriptableProperty): (QWebElement::scriptableProperties):

WebKit/win:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

WebKit/wx:

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Sam Weinig.


Renamed JSValuePtr => JSValue.

  • WebFrame.cpp: (wxWebFrame::RunScript):
14:20 Changeset [43121] by ggaren@apple.com

2009-05-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam "That doesn't look like what I thought it looks like" Weinig.


Beefed up the JSValuePtr class and removed some non-JSValuePtr dependencies
on JSImmediate, in prepapration for making JSImmediate an implementation
detail of JSValuePtr.


SunSpider reports no change.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_mod):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt): Updated for interface changes.
  • runtime/JSImmediate.h: (JSC::JSValuePtr::JSValuePtr):
  • runtime/JSValue.h: (JSC::JSValuePtr::): (JSC::jsImpossibleValue): (JSC::jsNull): (JSC::jsUndefined): (JSC::jsBoolean): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator bool): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::isUndefined): (JSC::JSValuePtr::isNull): Changed jsImpossibleValue(), jsNull(), jsUndefined(), and jsBoolean() to operate in terms of JSValuePtr instead of JSImmediate.
  • wtf/StdLibExtras.h: (WTF::bitwise_cast): Fixed up for clarity.
14:18 Changeset [43120] by dglazkov@chromium.org

2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25485
Only use visitedURL in Qt. This is a follow-up change to http://trac.webkit.org/changeset/43052,
which broke Chromium build.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkPseudoState): Moved guards around to

provide separate code paths for Qt and non-Qt ports. Also restored original
order of execution.

14:04 Changeset [43119] by andersca@apple.com

2009-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

<rdar://problem/6839222>
CrashTracer: Lots of crashes in Safari in hash table remove function inside DocumentLoader::removeSubresourceLoader


After calling m_client->didFail(), check if the subresource loader has reached its terminal state. If that's the case,
return early to avoid calling removeSubresourceLoader on a null document loader. I don't think this is allowed to happen
which is why I've added the ASSERT.


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didCancel):
13:15 Changeset [43118] by timothy@apple.com

Disallow the deletion UI for elements that have any overflow clipping.
Also disallow the UI for the body element it isn't practical to delete,
and the deletion UI would be clipped.

<rdar://problem/6840161> Deletion UI can be clipped by some
elements (with overflow: hidden)

Reviewed by Darin Adler.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
13:15 Changeset [43117] by timothy@apple.com

Decrease the minimum height for deleteable elements to 16px, and increase the
minimum width to 48px. This allows deleting shorter items like navigation bars.

<rdar://problem/6840735> Deletion UI does not show up for short
elements (22px or less)

Reviewed by Adele Peterson.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
13:14 Changeset [43116] by timothy@apple.com

Clean up the comments and logic in the code for picking a
deleteable element for the deletion UI.

Reviewed by Adele Peterson.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
12:17 Changeset [43115] by kmccullough@apple.com

WebCore:

2009-05-01 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson and Darin Adler.

<rdar://problem/4815598> Stuck in double spacing mode after pasting a
paragraph with padding/margin (or table mode !)

A lot of the issues in this bug were resolved on Mail's side by using
WebKit to convert to plain text. This is the final issue, that floating
style stays on copied nodes causing them to float when they are pasted
which is not what the user intended.

  • editing/markup.cpp: (WebCore::removeExteriorStyles): (WebCore::): (WebCore::appendStartMarkup): (WebCore::getStartMarkup): (WebCore::createMarkup):

LayoutTests:

2009-04-30 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adele Peterson and Darin Adler.

<rdar://problem/4815598> Stuck in double spacing mode after pasting a
paragraph with padding/margin (or table mode !)

A lot of the issues in this bug were resolved on Mail's side by using
WebKit to convert to plain text. This is the final issue, that floating
style stays on copied nodes causing them to float when they are pasted
which is not what the user intended.

  • editing/pasteboard/copy-paste-float-expected.txt: Added.
  • editing/pasteboard/copy-paste-float.html: Added.
09:38 Changeset [43114] by dglazkov@chromium.org

2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, bulid fix.

Fix mis-applied patch.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
08:24 Changeset [43113] by dglazkov@chromium.org

WebCore:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
This is the only resource-related information that is available in InspectorController
and is missing in the FrameLoaderClient.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebCore.xcodeproj/project.pbxproj: Made ScriptSource private.
  • dom/Document.cpp: Made a call to a client along with the call to the InspectorController. (WebCore::Document::resourceRetrievedByXMLHttpRequest):
  • loader/EmptyClients.h: Added stub implementation. (WebCore::EmptyFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
  • loader/FrameLoader.cpp: Call initiating dispatches. (WebCore::FrameLoader::resourceRetrievedByXMLHttpRequest):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/gtk:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):

WebKit/qt:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidLoadResourceByXMLHttpRequest):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wx:

2009-05-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.

https://bugs.webkit.org/show_bug.cgi?id=25347

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidLoadResourceByXMLHttpRequest):
  • WebKitSupport/FrameLoaderClientWx.h:
04:29 Changeset [43112] by jmalonzo@webkit.org

2009-05-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip the following failing tests:
fast/replaced/table-percent-height-text-controls.html
media/video-document-types.html

  • platform/gtk/Skipped:

04/30/09:

21:15 Changeset [43111] by bdakin@apple.com

2009-04-30 Beth Dakin <bdakin@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6841106> REGRESSION: Crash drag selecting
To Do's in a Mail note (excessive recursion in mouse drag tracking)

Oliver's recent change to dragging seems to have revealed a long-
time bug in passSubframeEventToSubframe where we did not set
m_sendingEventToSubview to true before calling
handleMouseMoveEvent() in the NSMouseMoved case. This patch fixes
that and adds ASSERTions around all of the places where
m_sendingEventToSubview is set to true and then false to make sure
we are not trampling its state.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget):
21:10 Changeset [43110] by barraclough@apple.com

JavaScriptCore:

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Bug fix for rdar:/68455379. If a case-insensitive regex contains
a character class containing a range with an upper bound of \uFFFF
the parser will infinite-loop whist adding other-case characters
for characters in the range that do have another case.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::CharacterClassConstructor::putRange):

LayoutTests:

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Add layout test for rdar:/68455379.

  • fast/js/regexp-range-bound-ffff-expected.txt: Added.
  • fast/js/regexp-range-bound-ffff.html: Added.
  • fast/js/resources/regexp-range-bound-ffff.js: Added.
20:55 Changeset [43109] by eric.carlson@apple.com

2009-04-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.


MediaDocument falls back to plug-in unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=25504
<rdar://problem/6844702>


Don't allow harmless media types to cause a MediaDocument to fall
back to PluginDocument.

Test: media/video-document-types.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks): add timecode, timecode 64, odsm, and sdsm to allowed track types.
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::disableUnsupportedTracks): Ditto.

2009-04-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

MediaDocument falls back to plug-in unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=25504
<rdar://problem/6844702>

Test case for MediaDocument with previously unsupported track
types. Disabled on Windows for now until https://bugs.webkit.org/show_bug.cgi?id=25220
has been fixed.


  • media/content/counting.mp4: Added.
  • media/video-document-types-expected.txt: Added.
  • media/video-document-types.html: Added.
  • platform/win/Skipped:
20:48 Changeset [43108] by kevino@webkit.org

wx build fix, define ENABLE_JAVASCRIPT_DEBUGGER and remove JSCore dynamic library references.

18:57 Changeset [43107] by mrowe@apple.com

Roll out r43106 as it introduced four regression test failures.

17:06 Changeset [43106] by darin@apple.com

WebCore:

2009-04-30 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

Test: fast/loading/subframe-removes-itself.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): When isStopping is true, treat load as complete, even if isLoadingInAPISense is still returning true.

LayoutTests:

2009-04-30 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Bug 25491: WebFrame leak when a subframe removes itself
https://bugs.webkit.org/show_bug.cgi?id=25491
rdar://problem/6833859

  • fast/loading: Added.
  • fast/loading/resources: Added.
  • fast/loading/resources/subframe-that-removes-itself.html: Added.
  • fast/loading/subframe-removes-itself-expected.txt: Added.
  • fast/loading/subframe-removes-itself.html: Added.
  • platform/gtk/Skipped: Skip loading tests.
16:55 Changeset [43105] by barraclough@apple.com

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

OPCODE_SAMPLING without CODEBLOCK_SAMPLING is currently broken,
since SamplingTool::Sample::isNull() checks the m_codeBlock
member (which is always null without CODEBLOCK_SAMPLING).

Restructure the checks so make this work again.

  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::doRun):
  • bytecode/SamplingTool.h: (JSC::SamplingTool::Sample::isNull):
16:36 Changeset [43104] by mjs@apple.com

2009-04-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Gavin Barraclough.

  • Concatenate final three strings in simple replace case at one go

~0.2% SunSpider speedup

  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): Use new replaceRange helper instead of taking substrings and concatenating three strings.
  • runtime/UString.cpp: (JSC::UString::replaceRange): New helper function.
  • runtime/UString.h:
15:58 Changeset [43103] by ggaren@apple.com

2009-04-30 Geoffrey Garen <ggaren@apple.com>

Rubber Stamped by Gavin Barraclough.


Changed JSValueEncodedAsPtr* => EncodedJSValuePtr to support a non-pointer
encoding for JSValuePtrs.

  • API/APICast.h: (toJS):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
  • interpreter/Register.h: (JSC::Register::):
  • jit/JIT.cpp: (JSC::):
  • jit/JIT.h:
  • jit/JITCode.h: (JSC::):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_vm_throw):
  • jit/JITStubs.h:
  • runtime/JSValue.h: (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode):
15:37 Changeset [43102] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Add CHROMIUM guard to unfork Document.cpp

  • dom/Document.cpp: (WebCore::Document::setFocusedNode): Added guard.
15:27 Changeset [43101] by ddkilzer@apple.com

Use OwnPtr<HTMLParserQuirks> for m_parserQuirks

Reviewed by Geoff Garen.

  • html/HTMLParser.cpp: (WebCore::HTMLParser::~HTMLParser): Removed unneeded code.
  • html/HTMLParser.h: Made m_parserQuirks an OwnPtr.
14:51 Changeset [43100] by barraclough@apple.com

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver "Abandon Ship!" Hunt.

Fix a leak in Yarr.

All Disjunctions should be recorded in RegexPattern::m_disjunctions,
so that they can be freed at the end of compilation - copyDisjunction
is failing to do so.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::copyDisjunction):
14:45 Changeset [43099] by ojan@chromium.org

2009-04-30 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Fix tests that depend on Mac-specific metrics now that text controls
are sized according to font metrics (r43007).

Fixes https://bugs.webkit.org/show_bug.cgi?id=25474.

  • fast/forms/textarea-appearance-wrap-expected.txt:
  • fast/forms/textarea-appearance-wrap.html: This test only really cares that a line-wrap character is submitted with forms that have the appropriate wrap value and not with other forms. So checking that the submit contents have a line-wrap character, instead of looking for it in a specific place, is sufficient. This gets around that we wrap in a different place in some cases on Mac and Windows.
  • fast/forms/textarea-hard-linewrap-expected.txt: Removed.
  • fast/forms/textarea-hard-linewrap.html: Removed. This test is redundant with fast/forms/textarea-appearance-wrap.html.
  • fast/replaced/table-percent-height-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt: Added.
  • fast/replaced/table-percent-height-text-controls.html: Added.
  • fast/replaced/table-percent-height.html: Pulled out the cases in table-percent-height.html that had text controls and moved them into their own test. The new test doesn't assert specific metrics, it just spits them out. This allows us to have different expected results for Windows and Mac without having "FAIL" messages in the expected results. It's not perfect, but it seems better than any alternatives I could come up with. We do still print "FAIL" if the results don't match any platform.
  • platform/win/Skipped:
  • platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
14:39 Changeset [43098] by timothy@apple.com

Merge r43040.

14:38 Changeset [43097] by timothy@apple.com

Merge r43039.

14:38 Changeset [43096] by oliver@apple.com

Add function to CallFrame for dumping the current JS caller

Reviewed by Gavin Barraclough.

Added debug only method CallFrame::dumpCaller() that provide the call location
of the deepest currently executing JS function.

14:36 Changeset [43095] by timothy@apple.com

Merge r43026.

14:34 Changeset [43094] by timothy@apple.com

Merge r42945.

14:28 Changeset [43093] by dglazkov@chromium.org

Fixed ChangeLog entry, added comments.

14:26 Changeset [43092] by ddkilzer@apple.com

Provide a mechanism to create a quirks delegate for HTMLParser

Reviewed by David Hyatt.

WebCore:

No tests since there is no change in behavior.

HTMLParserQuirks.h defines an abstract base class that may be
extended as needed. The ChromeClient::createHTMLParserQuirks()
factory method should be used to return an HTMLParserQuirks
subclassed object when needed.

  • WebCore.xcodeproj/project.pbxproj: Added HTMLParserQuirks.h.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): Initialize m_parserQuirks using ChromeClient::createHTMLParserQuirks(). (WebCore::HTMLParser::~HTMLParser): Delete m_parserQuirks if set. (WebCore::HTMLParser::reset): Call HTMLParserQuirks::reset() if m_parserQuirks is set. (WebCore::HTMLParser::insertNode): Call HTMLParserQuirks::shouldInsertNode() if m_parserQuirks is set, and return early if it returns false. (WebCore::HTMLParser::popBlock): Call HTMLParserQuirks::shouldPopBlock() if m_parserQuirks is set, and return early if it returns false.
  • html/HTMLParser.h: Added m_parserQuirks.
  • html/HTMLParserQuirks.h: Added. (WebCore::HTMLParserQuirks::HTMLParserQuirks): (WebCore::HTMLParserQuirks::~HTMLParserQuirks):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Added.
  • page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Added.

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.

WebKit/win:

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.

WebKit/wx:

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Added. The default implementation of this factory method returns 0.
14:20 Changeset [43091] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25492
Add JSC guards around node wrapper cache calls. These are not used by V8.

  • dom/Document.cpp: (WebCore::Document::~Document): Added JSC guard.
  • dom/Node.cpp: (WebCore::Node::setDocument): Ditto and removed JSDOMBinding include.
14:18 Changeset [43090] by mjs@apple.com

2009-04-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff Garen.

  • make BaseStrings have themselves as a base, instead of nothing, to remove common branches

~0.7% SunSpider speedup

  • runtime/UString.h: (JSC::UString::Rep::Rep): For the constructor without a base, set self as base instead of null. (JSC::UString::Rep::baseString): Just read m_baseString - no more branching.
14:11 Changeset [43089] by timothy@apple.com

Versioning.

14:11 Changeset [43088] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25493
Remove debugger/profiler custom method stubs, catching V8 bindings up to
http://trac.webkit.org/changeset/43072.

  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Removed method stubs.
14:02 Changeset [43087] by barraclough@apple.com

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Two quick improvements to SamplingFlags mechanism.

SamplingFlags::ScopedFlag class to provide support for automagically
clearing a flag as it goes out of scope, and add a little more detail
to the output generated by the tool.

  • bytecode/SamplingTool.cpp: (JSC::SamplingFlags::stop):
  • bytecode/SamplingTool.h: (JSC::SamplingFlags::ScopedFlag::ScopedFlag): (JSC::SamplingFlags::ScopedFlag::~ScopedFlag):
13:59 Changeset [43086] by timothy@apple.com

New tag.

13:50 Changeset [43085] by simon.fraser@apple.com

2009-04-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

<rdar://problem/6839338> VoiceOver does not take into account transforms when drawing outlines

Use transform-aware quad methods when computing the boundingBoxRect for
an AccessibilityRenderObject. The code follows RenderObject::absoluteBoundingBoxRect().

Test: accessibility/transformed-element.html

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect):
13:47 Changeset [43084] by aroben@apple.com

Restore build event steps that were truncated in r43082

Rubber-stamped by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
  • JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Re-copied the command lines for the build events from the pre-r43082 .vcproj files.
  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Removed an unnecessary attribute.
13:38 Changeset [43083] by jmalonzo@webkit.org

2009-04-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed build GTK build fix

  • configure.ac: typo fix - javascript_debugger should be enable_javascript_debugger
13:24 Changeset [43082] by aroben@apple.com

Move settings from .vcproj files to .vsprops files within the JavaScriptCore directory

Moving the settings to a .vsprops file means that we will only have to
change a single setting to affect all configurations, instead of one
setting per configuration.

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.vcproj/jsc/jsc.vcproj:
  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Moved settings from these files to the new .vsprops files. Note that testapi.vcproj had a lot of overrides of default settings that were the same as the defaults, which I've removed.
13:18 Changeset [43081] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, Chromium build fix.

Catch up to ScriptObject changes from http://trac.webkit.org/changeset/42512.

  • bindings/v8/ScriptObject.cpp: (WebCore::ScriptGlobalObject::get): Renamed from getObject. (WebCore::ScriptGlobalObject::remove): Added.
  • bindings/v8/ScriptObject.h: Ditto.
13:02 Changeset [43080] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • WebCore.pro: Fix copy-paste error.
12:55 Changeset [43079] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • GNUmakefile.am: Add ENABLE_JAVASCRIPT_DEBUGGER definitions.
  • WebCore.pro: Ditto.
12:49 Changeset [43078] by ariya@webkit.org

2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed build fix after r43072.

  • Api/qwebframe.cpp: (qt_drt_setJavaScriptProfilingEnabled): Enclose with JAVASCRIPT_DEBUGGER.
12:49 Changeset [43077] by ariya@webkit.org

2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed build fix after r43063.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
  • WebCoreSupport/ChromeClientQt.h:
12:48 Changeset [43076] by darin@apple.com

2009-04-30 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Add a first text iterator test. We'll add more later.
This test includes some known expected failures. At some point we'll fix those.

  • editing/text-iterator: Added.
  • editing/text-iterator/basic-iteration-expected.txt: Added.
  • editing/text-iterator/basic-iteration.html: Added.
  • editing/text-iterator/resources: Added.
  • editing/text-iterator/resources/TEMPLATE.html: Copied from editing/selection/resources/TEMPLATE.html.
  • editing/text-iterator/resources/basic-iteration.js: Added.
  • platform/gtk/Skipped: Skip editing/text-iterator since only Mac DumpRenderTree has this at the moment.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.
12:40 Changeset [43075] by eric@webkit.org

Reviewed by Darin Adler.

Change Position to pre-compute the AnchorType and store it.
Also store a "legacy editing mode" bit on the Position.
https://bugs.webkit.org/show_bug.cgi?id=24763

The old Postion(node, offset) constructor creates legacy positions
but there are new constructors to create explicitly anchored positions
which the next patch will use.

Once we fix all the "position-fixup" functions (like rangeCompliantEquivalent) to
only affect legacy positions, we will be able to distinguish
between [table, 1] and [table, after] in the code correctly!

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Position.cpp: (WebCore::Position::Position): (WebCore::Position::moveToPosition): (WebCore::Position::moveToOffset): (WebCore::Position::anchorTypeForLegacyEditingPosition): (WebCore::Position::element):
  • dom/Position.h: (WebCore::Position::): (WebCore::Position::Position): (WebCore::Position::anchorType): (WebCore::Position::deprecatedEditingOffset):
12:02 Changeset [43074] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • configure.ac: Add autoconfig options, missed in the first commit.
11:57 Changeset [43073] by weinig@apple.com

WebCore:

2009-04-30 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix bug where the WorkerLocation and WorkerNavigator wrappers would be
collected even if the WorkerContext is still alive.

Test: fast/workers/worker-context-gc.html

  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::mark):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::completeURL): (WebCore::WorkerContext::location):
  • workers/WorkerContext.h: (WebCore::WorkerContext::optionalNavigator): (WebCore::WorkerContext::optionalLocation):

LayoutTests:

2009-04-30 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Test for bug where the WorkerLocation and WorkerNavigator wrappers would be
collected even if the WorkerContext is still alive.

  • fast/workers/worker-context-gc-expected.txt: Added.
  • fast/workers/worker-context-gc.html: Added.
11:28 Changeset [43072] by dglazkov@chromium.org

JavaScriptCore:

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.

WebCore:

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
  • bindings/js/JSConsoleCustom.cpp: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
  • bindings/js/JSDOMWindowBase.cpp: Ditto.
  • bindings/js/JSInspectorControllerCustom.cpp: Ditto.
  • inspector/InspectorController.cpp: Moved profiler/debugger methods under

ENABLE(JAVASCRIPT_DEBUGGER) flag.

  • inspector/InspectorController.h: Ditto.
  • inspector/InspectorController.idl: Added ENABLE(JAVASCRIPT_DEBUGGER) guard.
  • page/Console.cpp: Replaced USE(JSC) with ENABLE(JAVASCRIPT_DEBUGGER) guard.

WebKit/mac:

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • Configurations/FeatureDefines.xcconfig: Added ENABLE_JAVASCRIPT_DEBUGGER define.

WebKitTools:

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25470
Extend the cover of ENABLE_JAVASCRIPT_DEBUGGER to profiler.

  • Scripts/build-webkit: Added ENABLE_JAVASCRIPT_DEBUGGER define.
11:28 Changeset [43071] by mrowe@apple.com

Merge r43040.

11:27 Changeset [43070] by mrowe@apple.com

Merge r43026.

11:09 Changeset [43069] by mrowe@apple.com

Versioning.

11:02 Changeset [43068] by mrowe@apple.com

New tag.

10:57 Changeset [43067] by kdecker@apple.com

Reviewed by Anders Carlson.

<rdar://problem/6823049>


Fix an issue where some plug-ins would cause the application icon to constantly bounce
up and down in the Dock.


  • Plugins/Hosted/NetscapePluginHostProxy.h: Change m_placeholderWindow ivar to be a subclass of NSWindow, WebPlaceholderModalWindow.
  • Plugins/Hosted/NetscapePluginHostProxy.mm: Added WebPlaceholderModalWindow NSWindow subclass. (-[WebPlaceholderModalWindow _wantsUserAttention]): Prevent NSApp from calling requestUserAttention: when the window is shown modally, even if the app is inactive. (WebKit::NetscapePluginHostProxy::beginModal): NSWindow -> WebPlaceholderModalWindow.
10:27 Changeset [43066] by dglazkov@chromium.org

2009-04-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25275
This patch snuck in a re-definition of a local.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER): Removed re-definition.
10:16 Changeset [43065] by weinig@apple.com

2009-04-30 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix a leak introduced yesterday. Don't allocate a ScheduledAction
if the toString()ing throws an exception.

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
09:55 Changeset [43064] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25379
<rdar://problem/6809460> REGRESSION (r41772): Selecting a bank in American Express Pay Bill fails

Test: fast/forms/multiple-selected-options-innerHTML.html

This problem was caused by an inconsistency at when Node::instertedIntoTree() is called.
For normal HTML parsing, it is called immediately after an element is inserted, but for
innerHTML, it is only called after the whole subtree is inserted into a document.

It may make sense to harmonize these cases one day, but for now, I only made the minimal
changes necessary to fix the bug.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::insertedIntoTree):
  • html/HTMLSelectElement.h: Recalculate list items when a SELECT element is inserted. OPTION elements cannot decide which one to keep selected themselves, because their logic assumes normal parsing, with insertedIntoTree() called after each element is inserted.
09:41 Changeset [43063] by dglazkov@chromium.org

WebCore:

2009-04-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

Chromium async/out-of-process version of WebInspector is currently not based on
InspectorController. The reason was that we did not want to interfere with
the unforking effort, yet wanted to experiment. So we came up with these
agents concept that basically mimic InspectorController, but separating 'agent'
nature from the 'transport'. Now that InspectorController is unforked, I am
planning to bring these concepts into the WebKit land and use what we have in
Chromium as a proof of concept / experimental playground.

  • loader/EmptyClients.h: added MessageSource and MessageLevel parameters. (WebCore::EmptyChromeClient::addMessageToConsole): ditto
  • page/ChromeClient.h: ditto
  • page/Console.cpp: Used new method signature. (WebCore::Console::addMessage): ditto

WebKit/gtk:

2009-04-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::addMessageToConsole):
  • WebCoreSupport/ChromeClientGtk.h:

WebKit/mac:

2009-04-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):

WebKit/win:

2009-04-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
  • WebCoreSupport/WebChromeClient.h:

WebKit/wx:

2009-04-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25342
Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::addMessageToConsole):
  • WebKitSupport/ChromeClientWx.h:
09:36 Changeset [43062] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

Reverted r42987.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):

LayoutTests:

Reviewed by Simon Fraser.

  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/mac/svg/custom/image-small-width-height-expected.png:
09:20 Changeset [43061] by beidson@apple.com

WebCore:

2009-04-30 Brady Eidson <beidson@apple.com>

Reviewed by Maciej Stachowiak

<rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
https://bugs.webkit.org/show_bug.cgi?id=21193

Some websites use for attributes in script elements to specify events that the script
should be run for. One example is greekembassy.org which has the following in their <head>:

<script for=window event=onresize>

location.reload(false);

</script>

Since we don't support the full for attribute syntax, we would just blissfully ignore the
condition and execute the code unconditionally. This caused breakage on multiple real-world
sites besides greekembassy.org.

https://bugs.webkit.org/show_bug.cgi?id=16915 and <rdar://problem/4471751> track adding full
support for the for attribute in scripts. In the meantime it's best to not execute them
unconditionally.

Test: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::shouldExecuteAsJavaScript): After all other checks have passed, only return true if there is no for attribute in the script element.
  • dom/ScriptElement.h:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::forAttributeValue): Return the attribute value, if any.
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::forAttributeValue): Return an empty string (like the other attribute getters do for SVGScriptElement)
  • svg/SVGScriptElement.h:

LayoutTests:

2009-04-30 Brady Eidson <beidson@apple.com>

Reviewed by Maciej Stachowiak

Test for <rdar://problem/3785248> http://www.greekembassy.org/ gets in an infinite reload loop
https://bugs.webkit.org/show_bug.cgi?id=21193

  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html: Added.
08:56 Changeset [43060] by kov@webkit.org

2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip one more video test that sometimes fails.

  • platform/gtk/Skipped:
08:43 Changeset [43059] by aroben@apple.com

Add a sometimes-timing-out test to the Windows skipped file

See Bug 25483: http/tests/navigation/redirect-cycle.html sometimes
times out on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25483>

  • platform/win/Skipped: Added http/tests/navigation/redirect-cycle.html.
08:01 Changeset [43058] by hausmann@webkit.org

2009-04-30 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Implement encloseContentsWith and rename wrap to encloseWith.

Also in encloseWith, make sure that you cannot enclose with
non-enclosable elements.

07:56 Changeset [43057] by kov@webkit.org

2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Skip two more tests that I had accidentaly generated results for,
locally.

  • platform/gtk/Skipped:
07:06 Changeset [43056] by kov@webkit.org

2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Also disable new tests, and tests that are using stderr.

  • platform/gtk/Skipped:
06:12 Changeset [43055] by kov@webkit.org

2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disabling more video tests that seem to come and go.

  • platform/gtk/Skipped:
05:06 Changeset [43054] by kov@webkit.org

2009-04-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Hopefully last try making the bot green.

  • platform/gtk/Skipped:
04:09 Changeset [43053] by ariya@webkit.org

2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Exclude canvas-putImageData.html from the skipped list since
Canvas's putImageData is implemented in r41355 already.

  • platform/qt/Skipped: Removed canvas-putImageData.html.
03:26 Changeset [43052] by hausmann@webkit.org

2009-04-30 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

The Qt API exposes a global history patch CSSStyleSelector to make API consumers work again

https://bugs.webkit.org/show_bug.cgi?id=20952

The QtWebKit port made the mistake of exposing a global history. This broke
with the addition of PageGroup and LinkHash. This needs to be repaired
for Qt4.5.

Add a function to LinkHash.cpp that is resolving a URL. Use this
function from within CSSStyleSelector to forward the url to the
QWebHistoryInterface API.

It is sad that there is a path within visitedLinkHash which is now
doing a memcpy, it is sad to add a PLATFORM(QT) define to CSSStyleSelector
and using QtWebKit types within WebCore is a layering violation as well.

PageGroup::setShouldTrackVisitedLinks is currently not enabled. For
Qt4.6 a second version of the QWebHistoryInterface is going to be
added which will fix things up.

03:08 Changeset [43051] by hausmann@webkit.org

Fix the Qt build.

03:04 Changeset [43050] by ariya@webkit.org

2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed build fix, after r43035.

Temporarily use Position::deprecatedEditingOffset().

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery):
03:00 Changeset [43049] by ariya@webkit.org

2009-04-30 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreview build fix after r43037.

Use MarkedArgumentBuffer instead of ArgList.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
02:15 Changeset [43048] by mjs@apple.com

2009-04-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Alexey Proskuryakov.

  • speed up string concatenation by reorganizing some simple cases

0.7% SunSpider speedup

  • runtime/UString.cpp: (JSC::concatenate): Put fast case for appending a single character before the empty string special cases; streamline code a bit to delay computing values that are not needed in the fast path.
00:52 Changeset [43047] by barraclough@apple.com

2009-04-30 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

Add SamplingFlags mechanism.

This mechanism allows fine-grained JSC and JavaScript program aware
performance measurement. The mechanism provides a set of 32 flags,
numbered #1..#32. Flag #16 is initially set, and all other flags
are cleared. Flags may be set and cleared from within

Enable by setting ENABLE_SAMPLING_FLAGS to 1 in wtf/Platform.h.
Disabled by default, no performance impact. Flags may be modified
by calling SamplingFlags::setFlag() and SamplingFlags::clearFlag()
from within JSC implementation, or by calling setSamplingFlag() and
clearSamplingFlag() from JavaScript.

The flags are sampled with a frequency of 10000Hz, and the highest
set flag in recorded, allowing multiple events to be measured (with
the highest flag number representing the highest priority).

Disabled by default; no performance impact.

  • JavaScriptCore.exp:
  • bytecode/SamplingTool.cpp: (JSC::SamplingFlags::sample): (JSC::SamplingFlags::start): (JSC::SamplingFlags::stop): (JSC::SamplingThread::threadStartFunc): (JSC::SamplingThread::start): (JSC::SamplingThread::stop): (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::doRun): (JSC::SamplingTool::sample): (JSC::SamplingTool::start): (JSC::SamplingTool::stop):
  • bytecode/SamplingTool.h: (JSC::SamplingFlags::setFlag): (JSC::SamplingFlags::clearFlag): (JSC::SamplingTool::SamplingTool):
  • jsc.cpp: (GlobalObject::GlobalObject): (functionSetSamplingFlag): (functionClearSamplingFlag): (runWithScripts):
  • wtf/Platform.h:

04/29/09:

23:47 Changeset [43046] by weinig@apple.com

WebCore:

2009-04-29 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments

Test: fast/dom/Window/setTimeout-string-argument.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
  • bindings/js/ScheduledAction.h:

LayoutTests:

2009-04-29 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Test for https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments

  • fast/dom/Window/setTimeout-string-argument-expected.txt: Added.
  • fast/dom/Window/setTimeout-string-argument.html: Added.
20:38 Changeset [43045] by mrowe@apple.com

More build fixing after r43037.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

20:03 Changeset [43044] by mitz@apple.com

WebCore:

Reviewed by Simon Fraser.

  • WebCore part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message

Test: editing/deleting/in-visibly-empty-root.html

  • WebCore.base.exp: Exported VisibleSelection::isAll(bool).
  • editing/SelectionController.h: (WebCore::SelectionController::isAll): Added. Calls through to VisibleSelection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children of the root editable element the selection is in, other than a placeholder. Returns true iff it did anything. (WebCore::TypingCommand::deleteKeyPressed): When there is only a single visible position in the root editable element, but it has children other than a placeholder, remove those children.
  • editing/TypingCommand.h:
  • editing/VisiblePosition.h: Added a StayInEditableContent enum and a FIXME.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Added. Returns whether the selection encompasses all visible positions, either in the document or in the editable root.
  • editing/VisibleSelection.h:

WebKit/mac:

Reviewed by Simon Fraser.

  • WebKit part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
  • WebView/WebView.mm: (-[WebView _selectionIsCaret]): Added. (-[WebView _selectionIsAll]): Added. Returns whether the selection encompasses the entire document.
  • WebView/WebViewPrivate.h:

LayoutTests:

Reviewed by Simon Fraser.

  • test and updated results for <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
  • editing/deleting/in-visibly-empty-root-expected.txt: Added.
  • editing/deleting/in-visibly-empty-root.html: Added.
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
19:19 Changeset [43043] by weinig@apple.com

2009-04-29 Sam Weinig <sam@webkit.org>

Another attempt to fix the windows build.

19:12 Changeset [43042] by weinig@apple.com

2009-04-29 Sam Weinig <sam@webkit.org>

Fix style nit.

  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder):
19:10 Changeset [43041] by weinig@apple.com

2009-04-29 Sam Weinig <sam@webkit.org>

Try and fix the windows build.

19:02 Changeset [43040] by hyatt@apple.com

2009-04-29 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
assertions.

Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
and not do it (which is basically what was happening before).

  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize): (WebCore::FrameView::needsLayout):
18:35 Changeset [43039] by justin.garcia@apple.com

WebCore:

2009-04-29 Douglas Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.

<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly


Updates to the text checking code to enable text checking even if spellchecking is turned off
and fix an off-by-one error in selection handling.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping):

WebKit/mac:

2009-04-29 Douglas Davidson <ddavidso@apple.com>

Reviewed by Justin Garcia.


<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView orderFrontSubstitutionsPanel:]):
  • WebView/WebView.mm: (-[WebView validateUserInterfaceItemWithoutDelegate:]):
18:34 Changeset [43038] by barraclough@apple.com

2009-04-29 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver "Peg-Leg" Hunt.

Coallesce input checking and reduce futzing with the index position
between alternatives and iterations of the main loop of a regex,
when run in YARR.

Consider the following regex: /foo|bar/


Prior to this patch, this will be implemented something like this pseudo-code description:


loop:

check_for_available_input(3) this increments the index by 3, for the first alterantive.

if (available) { test "foo" }

decrement_index(3)
check_for_available_input(3) this increments the index by 3, for the second alterantive.

if (available) { test "bar" }

decrement_index(3)
check_for_available_input(1) can we loop again?

if (available) { goto loop }

With these changes it will look more like this:

check_for_available_input(3) this increments the index by 3, for the first alterantive.
if (!available) { goto fail }

loop:

test "foo"
test "bar"
check_for_available_input(1) can we loop again?

if (available) { goto loop }

fail:

This gives about a 5% gain on v8-regex, no change on Sunspider.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo): (JSC::Yarr::RegexGenerator::generateDisjunction):
18:21 Changeset [43037] by oliver@apple.com

Clean up ArgList to be a trivial type

Reviewed by Gavin Barraclough

Separate out old ArgList logic to handle buffering and marking arguments
into a distinct MarkedArgumentBuffer type. ArgList becomes a trivial
struct of a pointer and length.

18:16 Changeset [43036] by eric@webkit.org

No review, build fix only.

Fix m_offset uses added while I wasn't looking.

  • editing/visible_units.cpp: (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
18:09 Changeset [43035] by eric@webkit.org

Reviewed by Darin Adler.

Make m_offset private and change all callers to use deprecatedEditingOffset().
https://bugs.webkit.org/show_bug.cgi?id=25472

Per Darin's suggestion, this was just a simple search replace
of .m_offset with .deprecatedEditingOffset().

There was one change in InsertParagraphSeparatorCommand::doApply to use
Position::moveToOffset(0) instead of .m_offset = 0;

  • dom/Position.cpp: (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition):
  • dom/Position.h: (WebCore::Position::deprecatedEditingOffset): (WebCore::Position::moveToOffset): (WebCore::operator==):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
  • dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::compareBoundaryPoints):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
  • editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentOffset):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
18:07 Changeset [43034] by eric@webkit.org

Reviewed by Oliver Hunt.

Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)

  • platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
  • platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
  • platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
  • platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
  • svg/custom/image-clipped-hit.svg:
17:51 Changeset [43033] by kov@webkit.org

2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Second try at making the bot green.

  • platform/gtk/Skipped:
17:48 Changeset [43032] by mitz@apple.com

WebCore:

2009-04-29 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

Test: editing/selection/home-end.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  • editing/visible_units.h:

LayoutTests:

2009-04-29 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

  • editing/selection/extend-selection-expected.txt: Added result for extend in lineBoundary.
  • editing/selection/extend-selection.html: Added test cases and script for extend in lineBoundary.
  • editing/selection/home-end-expected.txt: Added.
  • editing/selection/home-end.html: Added.
17:24 Changeset [43031] by ojan@chromium.org

2009-04-29 Ojan Vafai <ojan@chromium.org>

Reviewed by NOBODY (OOPS!).

Fix this test to only use a setTimeout in IE.
It doesn't need a timeout in WebKit and the
timeout requires using waitUntilDone/notifyDone,
which doesn't play nicely with JS tests.

See https://bugs.webkit.org/show_bug.cgi?id=25471

  • fast/forms/resources/textarea-metrics.js: (assertTextareaMetrics):
  • fast/forms/textarea-metrics-expected.txt:
  • platform/win/fast/forms/textarea-metrics-expected.txt:
  • platform/win/Skipped:
16:52 Changeset [43030] by ojan@chromium.org

Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Put this file in the right place to fix the bot failure.

  • platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.
16:50 Changeset [43029] by ojan@chromium.org

2009-04-29 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
before the test is finished. There's a race with any JS tests that
use setTimeout. Fortunately, this test doesn't need the setTimeout,
so it's easy to fix.

See https://bugs.webkit.org/show_bug.cgi?id=25471

  • platform/win/Skipped:
16:34 Changeset [43028] by eric@webkit.org

2009-04-29 Eric Seidel <eric@webkit.org>

No review, rolling out a patch.

Revert http://trac.webkit.org/changeset/43019

New tests failed because I removed the tabs from them
when landing (since we avoid tabs in WebKit files).
I couldn't tell if the new results were correct with
spaces or not.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
  • editing/visible_units.cpp:
  • editing/visible_units.h:
16:27 Changeset [43027] by eric@webkit.org

2009-04-29 Eric Seidel <eric@webkit.org>

No review, rolling out a patch.

Revert 43020 as it caused accessibility/lists.html to fail
and no one is around to tell me if it's a progression or not.

  • page/AccessibilityObject.h: (WebCore::):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue): (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  • page/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):
16:21 Changeset [43026] by hyatt@apple.com

2009-04-29 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
flag on Mac.


FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::setContentsSize): (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
16:20 Changeset [43025] by hyatt@apple.com

2009-04-29 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes. The superview
of the WebView was being incorrectly checked instead of the WebView itself.

  • WebView/WebView.mm: (-[WebView _boundsChanged]):
16:09 Changeset [43024] by ojan@chromium.org

Fix ChangeLog description.

16:04 Changeset [43023] by ojan@chromium.org

2009-04-29 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Add expected results for failing tests.

15:48 Changeset [43022] by eric@webkit.org

2009-04-29 Antony Sargent <asargent@chromium.org>

Reviewed by Dimitri Glazkov and Eric Seidel.

Use AtomicString to speed up window and document interceptors.
https://bugs.webkit.org/show_bug.cgi?id=25275

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_GETTER):
15:28 Changeset [43021] by mrowe@apple.com

Update build.webkit.org configuration for the addition of the new GTK buildbot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
15:22 Changeset [43020] by eric@webkit.org

2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>

Reviewed by Jon Honeycutt.

Add a new accessibility role for list items. Part of
http://bugs.webkit.org/show_id.cgi?id=20013

  • win/AccessibleBase.cpp: (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
15:16 Changeset [43019] by eric@webkit.org

2009-04-29 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

Test: editing/selection/home-end.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  • editing/visible_units.h:
15:14 Changeset [43018] by eric@webkit.org

2009-04-29 Sankar Aditya Tanguturi <sankaraditya@gmail.com>

Reviewed by Adele Peterson.

https://bugs.webkit.org/show_bug.cgi?id=23583
Populate role attribute for document objects correctly
on Windows platform.

  • AccessibleDocument.cpp: (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for document objects on windows. (Matching Firefox).
  • AccessibleDocument.h: Add the role function prototype in header file.
15:11 Changeset [43017] by mrowe@apple.com

Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.

  • Scripts/run-webkit-tests:
14:54 Changeset [43016] by mrowe@apple.com

Implement test-result-archive for GTK.

  • BuildSlaveSupport/test-result-archive:
14:38 Changeset [43015] by eric@webkit.org

2009-03-27 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Simon Hausmann.

Update the page actions when a finishing loading even if the frame is
not the top frame such as when browsing inside of a website with frames.
https://bugs.webkit.org/show_bug.cgi?id=24890

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
  • tests/qwebpage/frametest/frame_a.html: Added.
  • tests/qwebpage/frametest/index.html: Added.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::backActionUpdate):
14:31 Changeset [43014] by eric@webkit.org

2009-04-29 Mike Belshe <mike@belshe.com>

Reviewed by Eric Seidel.

Update location while page is loading.
https://bugs.webkit.org/show_bug.cgi?id=21597

Tested by:

  • fast/dom/location-new-window-no-crash
  • fast/dom/Window/window-open-pending-url
  • page/Location.cpp:
14:28 Changeset [43013] by kov@webkit.org

2009-04-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Mark Rowe.

Disable failing tests to make the bot green for its new debut, so
that we can more easily track regressions.

  • platform/gtk/Skipped:
14:25 Changeset [43012] by eric@webkit.org

2009-04-29 Feng Qian <feng@chromium.org>

Reviewed by Darin Adler.

Add Android port files to WebCore/platform.
https://bugs.webkit.org/show_bug.cgi?id=23296

  • platform/android: Added.
  • platform/android/ClipboardAndroid.cpp: Added.
  • platform/android/ClipboardAndroid.h: Added.
14:23 Changeset [43011] by eric@webkit.org

2009-04-29 Feng Qian <feng@chromium.org>

Reviewed by Darin Adler.

Add Android-specific files to the WebCore/page directory.
https://bugs.webkit.org/show_bug.cgi?id=23295

  • page/android: Added.
  • page/android/DragControllerAndroid.cpp: Added.
  • page/android/EventHandlerAndroid.cpp: Added.
  • page/android/InspectorControllerAndroid.cpp: Added.
14:00 Changeset [43010] by eric@webkit.org

2009-04-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Extract PageGroupLoadDeferrer from Chrome.cpp

  • GNUmakefile.am: added PageGroupLoadDeferrer
  • WebCore.pro: ditto
  • WebCore.scons: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
  • page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
  • page/PageGroupLoadDeferrer.cpp: Added. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  • page/PageGroupLoadDeferrer.h: Added.
13:55 Changeset [43009] by kdecker@apple.com

Reviewed by Anders Carlson.

Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.


  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm: (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): (-[WebNetscapeContainerCheckContextInfo callback]): (-[WebNetscapeContainerCheckContextInfo context]):
  • Plugins/WebNetscapeContainerCheckPrivate.h:
  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
  • Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL):
13:43 Changeset [43008] by eric@webkit.org

2009-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=25334

Fix Qt build when ENABLE_JIT is explicitly set to 1
to overrule defaults.

13:31 Changeset [43007] by ojan@chromium.org

Reviewed by Dan Bernstein.

Make textarea and text input metrics more closely match IEs.

This involves:
-set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
-set textarea width to cols*avgCharWidth
-Make default CSS match IEs
-Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

Those values for textarea and inputs were derived by doing a ton of manual
testing of IE's width values for various textareas and fonts. On Windows we match
IE exactly except for a couple fonts of the ~12 tested.

To get the average and max character width of a font, we do the following
for each platform:
-Win: TextMetrics expose avgCharWidth and maxCharWidth
-SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight

maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent

-Linux: avgCharWidth = width of an '0', fallback on m_xHeight

maxCharWidth = max of avgCharWidth and m_ascent

-Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.

If either one is non-positive, then calculate the value using the Linux approach.

Tests: fast/forms/text-control-intrinsic-widths.html

fast/forms/textarea-metrics.html
svg/custom/svg-fonts-in-text-controls.html

  • css/html4.css:
  • css/themeWin.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::maxCharWidth): (WebCore::SimpleFontData::avgCharWidth):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
13:25 Changeset [43006] by oliver@apple.com

Crash in profiler due to incorrect assuming displayName would be a string.

Reviewed by Steve Falkenburg

Fixed by adding a type guard.

13:23 Changeset [43005] by beidson@apple.com

2009-04-29 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

  • bindings/objc/DOMCSS.mm: (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore type and not the binding type.
13:21 Changeset [43004] by eric@webkit.org

2009-04-29 John Abd-El-Malek <jam@google.com>

Reviewed by Dimitri Glazkov.

Reverted my previous change to add resetChromiumPluginCache().
https://bugs.webkit.org/show_bug.cgi?id=25318

  • plugins/chromium/PluginDataChromium.cpp:
13:21 Changeset [43003] by beidson@apple.com

2009-04-29 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail

Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>

Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
13:14 Changeset [43002] by eric@webkit.org

2009-04-29 Alpha Lam <hclam@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25430

Provide style sheet for UI controls of media elements for Chromium port.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
13:12 Changeset [43001] by eric@webkit.org

2009-04-29 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Adler.

Expose sudden termination to Chromium port.
https://bugs.webkit.org/show_bug.cgi?id=25457

  • platform/SuddenTermination.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/SuddenTerminationChromium.cpp: Added. (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
13:00 Changeset [43000] by weinig@apple.com

2009-04-29 Sam Weinig <sam@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unused EventListeners.

  • page/DOMWindow.idl:
11:38 Changeset [42999] by hyatt@apple.com

2009-04-29 David Hyatt <hyatt@apple.com>

Reviewed by John Sullivan.

Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized. Make sure
not to resize the interior views of a WebView in response to its bounds changing when not using
viewless WebKit. Auto-resizing rules were already in place to handle size adjustments for us.
Just mark as needing layout and do nothing else.

This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
Safari change (using a new API that will enable clients to define the edges of the content area as offsets
from the sides of the WebView).

  • WebView/WebView.mm: (-[WebView _boundsChanged]):
10:41 Changeset [42998] by eric.carlson@apple.com

2009-04-29 Eric Carlson <eric.carlson@apple.com>

Disable media/video-zoom-controls.html on Windows for now.

  • platform/win/Skipped: add media/video-zoom-controls.html.
10:38 Changeset [42997] by timothy@apple.com

Reveal current execution line once SourceFrame content is loaded.

https://bugs.webkit.org/show_bug.cgi?id=25448

Reviewed by Timothy Hatcher.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
10:27 Changeset [42996] by ariya@webkit.org

WebCore:

2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Fraser.

[Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
the default values of canvas attributes.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):

LayoutTests:

2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Fraser.

Updated expected results after Qt's GraphicsContext fixes.

  • platform/qt/fast/canvas/set-colors-expected.txt:
07:56 QtWebKitTodo edited by ariya@webkit.org
(diff)
06:55 Changeset [42995] by ariya@webkit.org

2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Implement QWebElement::evaluateScript.

  • Api/qwebelement.cpp: (setupScriptContext): (QWebElement::evaluateScript):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::evaluateScript):
06:46 Changeset [42994] by hausmann@webkit.org

2009-04-29 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Replaced QWebElementCollection with QList<QWebElement>.

03:20 QtWebKitTodo edited by vestbo@webkit.org
(diff)
03:09 QtWebKitTodo edited by vestbo@webkit.org
(diff)
Note: See TracTimeline for information about the timeline view.