Timeline


and

05/15/09:

23:57 Changeset [43798] by darin@apple.com
  • 5 edits in trunk/LayoutTests

2009-05-15 Darin Adler <darin@apple.com>

Fix some failures from recent changes.

  • platform/gtk/Skipped: Added recently-added test to the "no expected results" section.
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
  • svg/css/getComputedStyle-basic-expected.txt: Ditto.
23:06 Changeset [43797] by darin@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-15 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list

Test: fast/css/getComputedStyle/computed-style-font-family.html

  • css/CSSComputedStyleDeclaration.cpp: Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak. (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers. (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family property as specified in the CSS standard. Fixed clip to return "auto" when there is no clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties internal linkage since there was no reason for them to have external linkage.

LayoutTests:

2009-05-15 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font-family.html: Added.
  • fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump that are not visible when iterating the computed style object. Removed pointless unused array of unimplemented properties.
  • fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
19:17 Changeset [43796] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-15 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Jan Alonzo.

Plug memory leak.

  • webkit/webkitwebsettings.cpp: (free_spell_checking_language): (webkit_web_settings_finalize): (webkit_web_settings_set_property):
18:06 Changeset [43795] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25741

Append instead of throwing when insertItemBefore gets an out-of-bound
index.

Test: svg/dom/svglist-insertItemBefore-appends.html

  • svg/SVGList.h: (WebCore::SVGList::insertItemBefore):

LayoutTests:

2009-05-15 Adam Barth <abarth@webkit.org>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25741

Test that insertBeforeItem behaves properly for out of bounds indices.

  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svglist-insertItemBefore-appends-expected.txt: Added.
  • svg/dom/svglist-insertItemBefore-appends.html: Added.
17:33 Changeset [43794] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Don't parse args using getopt since it isn't available on Windows.

17:31 Changeset [43793] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-05-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25829

Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.

Test: fast/backgrounds/background-clip-text.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
17:06 Changeset [43792] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message

Test: editing/selection/move-by-line-004.html

  • editing/visible_units.cpp: (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper function. (WebCore::previousLinePosition): When advancing to the next candidate node, stop when leaving the closest ancestor of the original node that is not an inline. The code, incorrectly, was trying to exit the closest ancestor of that type which was editable, and therefore missing other blocks in the same editable root. (WebCore::nextLinePosition): Ditto.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
  • editing/selection/move-by-line-004-expected.txt: Added.
  • editing/selection/move-by-line-004.html: Added.
16:50 Changeset [43791] by jmalonzo@webkit.org
  • 5 edits in trunk

2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Converting filename to uri by concatenating strings is broken
on Windows. So, don't do it for that platform.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):

2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Converting filename to uri by concatenating strings is broken
on Windows. Use proper glib conversion functions.

  • webkit/webkitwebview.cpp: (webkit_web_view_open):
  • tests/testdownload.c: (test_webkit_download_create):
16:49 Changeset [43790] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Fix <rdar://problem/6875398>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): If we failed to instantiate the plug-in, call cleanup() so that any streams created by the plug-in from its NPP_New callback are destroyed.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Make cleanup() public.
15:40 Changeset [43789] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Looking like MSVC doesn't like static variables in inline methods?
Make the state of the SSE2 check a static variable on the class
MacroAssemblerX86Common as a speculative build fix for Windows.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::isSSE2Present): (JSC::MacroAssemblerX86Common::):
  • jit/JIT.cpp:
15:28 Changeset [43788] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-15 Gustavo Noronha Silva <gns@gnome.org>

Disable new tests.

  • platform/gtk/Skipped:
15:27 Changeset [43787] by dglazkov@chromium.org
  • 3 edits
    2 adds in trunk/WebCore

2009-05-15 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=25739

  • bindings/v8/V8Collection.cpp: Added. (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
  • bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
15:22 Changeset [43786] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6649936> Add *.exp export files to WebCore Xcode project

Reviewed by Darin Adler and Timothy Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Added Exports group, moved WebCore.base.exp into the group, and added 10 other *.exp files in WebCore.
15:15 Changeset [43785] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Add some assembler headers to JavaScriptCore.vcproj

This is just a convenience for Windows developers.

15:03 Changeset [43784] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-15 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25826
Change type to only have custom getter in JCS.

  • html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
14:54 Changeset [43783] by antti@apple.com
  • 5 edits in trunk/WebCore

2009-05-15 Antti Koivisto <antti@apple.com>

Reviewed by Dave Kilzer.

Add a settings entry to en/disable web font support
https://bugs.webkit.org/show_bug.cgi?id=25239

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
14:28 Changeset [43782] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-15 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented fast path for op_put_by_val when putting to arrays.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val):
14:11 Changeset [43781] by barraclough@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-05-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
other methods ASSERT_NOT_REACHED().

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::MacroAssemblerX86): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::supportsFloatingPoint):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::storeDouble): (JSC::MacroAssemblerX86Common::addDouble): (JSC::MacroAssemblerX86Common::subDouble): (JSC::MacroAssemblerX86Common::mulDouble): (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set32): (JSC::MacroAssemblerX86Common::setTest32): (JSC::MacroAssemblerX86Common::x86Condition): (JSC::MacroAssemblerX86Common::isSSE2Present):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::movePtrToDouble): (JSC::MacroAssemblerX86_64::moveDoubleToPtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
  • assembler/X86Assembler.h:
  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
13:43 Changeset [43780] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-05-15 Sam Weinig <sam@webkit.org>

Reviewed by Steve Falkenburg.

Remove dead youtube site specific hack that was commented out.

  • bindings/js/JSNavigatorCustom.cpp:
  • page/Navigator.idl:
13:09 Changeset [43779] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-05-15 Sam Weinig <sam@webkit.org>

Reviewed by Beth Dakin.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
<rdar://problem/6884742>
REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)

Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>

  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::needsGmailQuirk): (WebCore::JSHTMLInputElement::type):
  • html/HTMLInputElement.idl:
12:40 Changeset [43778] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25810
Upstream V8 DOM Wrapper map declarations.

No behavior change, so no tests.

  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): Added. (WebCore::WeakReferenceMap::~WeakReferenceMap): Added. (WebCore::WeakReferenceMap::get): Added. (WebCore::WeakReferenceMap::set): Added. (WebCore::WeakReferenceMap::forget): Added. (WebCore::WeakReferenceMap::contains): Added. (WebCore::WeakReferenceMap::impl): Added. (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
12:10 Changeset [43777] by simon.fraser@apple.com
  • 5 edits in trunk/WebCore

2009-05-13 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=25773

Rename GraphicsLayer::graphicsContextsFlipped() to
GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.

Clean up code around the GraphicsLayer "contents" layer that makes use of this
flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
which can then always do the flipping if necessary.

Only affects ACCELERATED_COMPOSITING builds.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsLayer):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::compositingCoordinatesOrientation): (WebCore::GraphicsLayerCA::setBackgroundColor): (WebCore::GraphicsLayerCA::clearBackgroundColor): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::clearContents): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setContentsLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
12:00 Changeset [43776] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-15 Geoffrey Garen <ggaren@apple.com> (Mostly by Sam)

Reviewed by Sam Weinig.


Implemented fast path for op_get_by_val when accessing array.

  • jit/JIT.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val):
11:17 Changeset [43775] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=25765

Avoid calling setNeedsStyleRecalc() when we are
putting an animated page in the cache. This avoids
the assert and subsequent problems with a dirty
page going into the cache.

11:13 Changeset [43774] by aroben@apple.com
  • 8 edits in trunk

2009-05-15 Francisco Tolmasky <francisco@280north.com>

BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
<https://bugs.webkit.org/show_bug.cgi?id=25467>

Reviewed by Adam Roben.

JavaScriptCore:

  • JavaScriptCore.exp: Added calculatedFunctionName
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
  • debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode. (JSC::DebuggerCallFrame::calculatedFunctionName):
  • debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.

WebCore:

  • inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
inspector/front-end/CallStackSidebarPane.js: Remove "
anonymous function" since it is handled internally just like in profiles

(WebInspector.CallStackSidebarPane.prototype.update):

10:59 Changeset [43773] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-15 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/6889823> hash table iterator used after hash table modified in
ProxyInstance::fieldNamed() when viewing movie trailer

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): Move add call after the waitForReply call. Anders says that by the time we return someone else might have done the same add for us. (WebKit::ProxyInstance::fieldNamed): Ditto.
10:41 Changeset [43772] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2009-05-15 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6892055>
Replace WKN_GetLocation with WKN_ResolveURL (WKN_GetLocation was confusing and did not take the base URL into account)


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCResolveURL): New MIG callback.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resolveURL): Use FrameLoader::complete URL here.


  • Plugins/Hosted/WebKitPluginClient.defs: Add new MIG definition.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
  • Plugins/WebNetscapeContainerCheckPrivate.h:
  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView resolveURL:forTarget:]):
  • Plugins/npapi.mm: (WKN_ResolveURL):
10:27 Changeset [43771] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/6892052> WebTextIterator should not “emit characters between all visible positions”
  • WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): Changed to construct a TextIterator with emitCharactersBetweenAllVisiblePositions set to false.
09:45 Changeset [43770] by ap@webkit.org
  • 3 edits in trunk/WebCore

Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Check strings with isEmpty(), not relying on any implicit conversions.
09:06 Changeset [43769] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler, Brady Eidson and Eric Carlson.

<rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
username and password (Lightwave 9.6 for Mac from Newtek site)

CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
for other protocols (including FTP) should be included as part of the URL.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Put credentials in URL for non-HTTP requests.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP headers to be received, so they cannot work with other protocols.
08:33 Changeset [43768] by simon.fraser@apple.com
  • 2 edits in trunk/BugsSite

2009-05-15 Simon Fraser <simon.fraser@apple.com>

Carrying forwards Darin Adler's rubber stamp

Make the comment field wider too.

  • skins/custom/global.css:
08:16 Changeset [43767] by simon.fraser@apple.com
  • 3 edits in trunk/BugsSite

2009-05-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

Make the URL, Summary and Keyword fields wider to mitigate the
effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
things generally better.

  • skins/custom/global.css:
  • template/en/custom/bug/edit.html.tmpl:
05:43 Changeset [43766] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Use AC_CANONICAL_HOST instead of AC_CANONICAL_SYSTEM, since
the JIT compiler is not a cross-compiler

  • configure.ac:
04:53 Changeset [43765] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Look for libWebKitSystemInterface.a in a more reasonable location.

Reviewed by Dave Kilzer.

  • Configurations/DebugRelease.xcconfig:
04:47 Changeset [43764] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] In the image decoder, remove the raw image data represented as QImage
once the image is converted to QPixmap and inserted in the pixmap cache.
This effectively reduces the heap usage when running on graphics system
other than raster (i.e the case where QImage != QPixmap).

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
  • platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
04:46 Changeset [43763] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] Refactor alpha channel detection the image decoder.
Sets the boolean flag as soon as the image is being read.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel. (WebCore::ImageDecoderQt::setData): Set the flag when appropriate. (WebCore::ImageDecoderQt::supportsAlpha): Simplified. (WebCore::ImageDecoderQt::reset): Resetted the flag.
  • platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
01:34 Changeset [43762] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

Mark Rowe says skipping tests doesn't need review. :)

Add new tests from r43759 to windows and tiger skipped lists until bug 25816 can be resolved.
https://bugs.webkit.org/show_bug.cgi?id=25816

Original bug: http://bugs.webkit.org/show_bug.cgi?id=25464

  • platform/win/Skipped:
  • platform/mac-tiger/Skipped:
01:08 Changeset [43761] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

Finish support for disabling the JavaScript Debugger and Profiler
at compile time in WebCore
https://bugs.webkit.org/show_bug.cgi?id=24917

  • bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
  • inspector/JavaScriptCallFrame.cpp: Ditto.
  • inspector/JavaScriptCallFrame.h: Ditto.
  • inspector/JavaScriptCallFrame.idl: Ditto.
  • inspector/JavaScriptDebugListener.h: Ditto.
  • inspector/JavaScriptDebugServer.cpp: Ditto.
  • inspector/JavaScriptDebugServer.h: Ditto.
  • inspector/JavaScriptProfile.cpp: Ditto.
  • inspector/JavaScriptProfile.h: Ditto.
  • inspector/JavaScriptProfileNode.cpp: Ditto.
  • inspector/JavaScriptProfileNode.h: Ditto.
  • page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
  • page/Console.h: Ditto.
  • page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
00:55 Changeset [43760] by eric@webkit.org
  • 6 edits in trunk

2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] Implement layoutTestController.waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=25036

Connect to 'navigation-policy-decision-requested' and handle
waitForPolicy in the callback.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): (webViewNavigationPolicyDecisionRequested): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
00:49 Changeset [43759] by eric@webkit.org
  • 3 edits
    8 adds in trunk

2009-05-15 Jungshik Shin <jshin@chromium.org>

Reviewed by Dimitri Glazkov

http://bugs.webkit.org/show_bug.cgi?id=25464

Improve the font fallback for characters belonging to 'common' scripts
in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
marks in North Indian scripts) and currency signs (e.g. Thai Baht)
rendered correctly in Chromium on Win.

Tests: fast/text/international/danda-space.html

fast/text/international/thai-baht-space.html

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::FontMap::getScriptBasedOnUnicodeBlock): (WebCore::FontMap::getScript): (WebCore::getFallbackFamily):
00:06 Changeset [43758] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25731
[Qt] Cleanup - move files exclusive to XPATH and XSLT under the
appropriate build section

  • WebCore.pro:
00:02 Changeset [43757] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp

Partial revert of 43604. Turns out we need some V8 magic for this to work right.

00:02 Changeset [43756] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-14 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel and Darin Fisher.

Fix a font-related leak in Chromium's Skia backend found by Valgrind.
https://bugs.webkit.org/show_bug.cgi?id=25760

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Use caches instead of "new" on every call.

05/14/09:

22:38 Changeset [43755] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Eric Seidel.

Initialize m_spreadMethod in the second constructor too. Not sure if
a test case can be written, so no test case.
https://bugs.webkit.org/show_bug.cgi?id=25814

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
22:19 Changeset [43754] by eric@webkit.org
  • 4 edits
    1 delete in trunk/LayoutTests

No review, rollout only.

Roll out r43753 as it caused a test to fail
Turns out more than one test was using the modified JS file.

  • editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
  • editing/pasteboard/paste-blockquote-before-blockquote.html:
  • editing/pasteboard/resources/TEMPLATE.html: Removed.
  • editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (copyAndPasteNode):
21:34 Changeset [43753] by eric@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-05-14 Julie Parent <jparent@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25716
Convert a test located in the resources directory into being a regular js test,
so we can add add more tests there and run make-js-test-wrappers without clobbering this one.

  • editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
  • editing/pasteboard/paste-blockquote-before-blockquote.html:
  • editing/pasteboard/resources/TEMPLATE.html: Added.
  • editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (createLine): (copyAndPasteNode):
20:54 Changeset [43752] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-05-14 Simon Fraser <simon.fraser@apple.com>

No review.

Fix Windows build after renaming MediaControlElements to MediaControlElementType.

  • rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
  • rendering/RenderMediaControls.h:
20:44 Changeset [43751] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-14 Gavin Barraclough <barraclough@apple.com>

Build fix, not reviewed.

Quick fixes for JIT builds with OPTIMIZE flags disabled.

  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compilePutByIdHotPath):
20:33 Changeset [43750] by sfalken@apple.com
  • 90 edits in tags/Safari-6530.10.1/JavaScriptCore

Merge r43749.

20:29 Changeset [43749] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Back out incorrect Windows build fix

20:16 Changeset [43748] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.10.1

New tag.

20:10 Changeset [43747] by simon.fraser@apple.com
  • 3 edits in trunk/WebCore

2009-05-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

<rdar://problem/6739671> Movie controller’s play button does not change into a pause
button

Fix a controls repaint issue when the playing state of a video changes by
educating the MediaControlInputElements about the state they are currently
displaying, and making them repaint when that state changes. This applies
to the play/pause and mute/unmute buttons, which both have two states.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Pass in and initialize the MediaControlElementType.

(WebCore::MediaControlInputElement::update):
Update the display type too

(WebCore::MediaControlInputElement::setDisplayType):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
Choose muted vs. unmuted display.

(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
Choose play vs. paused display.

  • rendering/MediaControlElements.h: Renamed the MediaControlElements enum to MediaControlElementType. (WebCore::MediaControlInputElement::updateDisplayType): Add a MediaControlElementType member variable with a setter to allow the element to know what type it is displaying.
20:02 Changeset [43746] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a failure in fast/js/math-transforms.html caused by failing to
preserve -0 in multiplication.

  • assembler/X86Assembler.h: (JSC::X86Assembler::jz):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): Check both for overflow and for zero when doing multiplication. Use a slow case to get these right.
19:07 Changeset [43745] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a bug in the varargs calling convention.

  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): Move the argument count into regT1, since that's where ctiVirtualCall expects it to be.
17:51 Changeset [43744] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed a small bug in instanceof's looping code.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): NULL means the object has no prototype, so only loop when *not* equal to NULL.
17:38 Changeset [43743] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed a small bug in instanceof's result writing code.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): Make sure to fill out the payload bits in all cases.
17:09 Changeset [43742] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Removed an invalid assertion in cti_op_urshift which
depended on a fast path for op_urshift which has
never existed.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_urshift):
17:04 Changeset [43741] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed loop_if_true, which had the same reversed test that jtrue had.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true):
16:56 Changeset [43740] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

In op_neq, we apparently want to check that one value
does *not* equal another. Go figure.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_neq):
16:14 Changeset [43739] by dino@apple.com
  • 5 edits
    8 adds in trunk

2009-05-14 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=25197

Add support for aspect-ratio and orientation
media queries.

Tests: fast/media/mq-aspect-ratio.html

fast/media/mq-orientation.html

  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp: (WebCore::orientationMediaFeatureEval): (WebCore::aspect_ratioMediaFeatureEval): (WebCore::min_aspect_ratioMediaFeatureEval): (WebCore::max_aspect_ratioMediaFeatureEval):
  • css/MediaQueryExp.h: (WebCore::MediaQueryExp::isViewportDependent):
16:04 Changeset [43738] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

The slow case of op_mod should call op_mod's jit stub,
not op_mul. That would be dumb.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_mod):
16:04 Changeset [43737] by kmccullough@apple.com
  • 4 edits
    9 copies in trunk

WebCore:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

  • Resubmitting previous patch, correctly this time.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):

LayoutTests:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

  • Resubmitting previous patch, correctly this time.
  • editing/execCommand/outdent-blockquote-test1.html: Copied from editing/execCommand/outdent-blockquote-test1.html.
  • editing/execCommand/outdent-blockquote-test2.html: Copied from editing/execCommand/outdent-blockquote-test2.html.
  • editing/execCommand/outdent-blockquote-test3.html: Copied from editing/execCommand/outdent-blockquote-test3.html.
  • editing/execCommand/outdent-blockquote-test4.html: Copied from editing/execCommand/outdent-blockquote-test4.html.
  • platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt.
  • platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt.
  • platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt.
  • platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt.
  • platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt.
16:03 Changeset [43736] by ggaren@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed problems when using 'arguments' due to a half-initialized register.

  • interpreter/CallFrame.h: (JSC::ExecState::setCalleeArguments): (JSC::ExecState::init): Require a full JSValue when setting up the 'arguments' virtual register, since this register is accessible from JIT code and bytecode, and needs to be a true JSValue.
  • interpreter/CallFrameClosure.h: (JSC::CallFrameClosure::resetCallFrame): ditto
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): ditto
  • interpreter/Register.h: Removed the constructor that allowed assignment of a JSArguments* to a register. That is not safe. See above.
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): ditto
15:18 Changeset [43735] by timothy@apple.com
  • 4 edits in trunk

Versioning.

15:17 Changeset [43734] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

We really want to go to the slow case in op_jfalse and
op_jtrue if the value is *not* boolean.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
15:08 Changeset [43733] by timothy@apple.com
  • 3 edits in tags/Safari-6530.10/JavaScriptCore

Merge r43711.

14:56 Changeset [43732] by kmccullough@apple.com
  • 5 edits
    9 deletes in trunk

WebCore:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

  • Rolling out to fix a bug and the build
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):

LayoutTests:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

  • Rolled out for bug and build fix.
  • editing/execCommand/outdent-blockquote-test1.html: Removed.
  • editing/execCommand/outdent-blockquote-test2.html: Removed.
  • editing/execCommand/outdent-blockquote-test3.html: Removed.
  • editing/execCommand/outdent-blockquote-test4.html: Removed.
  • platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed.
  • platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed.
  • platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed.
  • platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed.
  • platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Removed.
14:40 Changeset [43731] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Flipped the condition when emitting a an op_loop_if_less or op_loop_if_lesseq
if the first operand is a constant.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq):
14:28 Changeset [43730] by timothy@apple.com
  • 1 copy in tags/Safari-6530.10

New tag.

14:28 Changeset [43729] by kmccullough@apple.com
  • 4 edits
    9 adds in trunk

WebCore:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively here served to do nothing because this function will return if the second argument is the parent of the first. Not only does this now work as intended, but is necessary for the rest of this fix.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we are the last node in a <blockquote>, and can therefore remove the <blockquote> we need the endOfEnclosingBlock to extend to the end of the <blockquote> not just the next block, which could be a <div>, for example.
  • Also If a <blockquote> is removed, but it's the child of another <blockquote> then its children are now children of the top <blockquote>. In this case we want to split the parent <blockquote> because the next paragraph assumes that it is the first node in its <blockquote> and if that is not true, various bugs arise.

LayoutTests:

2009-05-14 Kevin McCullough <kmccullough@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased

  • These tests are the various combinations of <blockquote>s that revealed bugs in our old logic.
  • editing/execCommand/outdent-blockquote-test1.html: Added.
  • editing/execCommand/outdent-blockquote-test2.html: Added.
  • editing/execCommand/outdent-blockquote-test3.html: Added.
  • editing/execCommand/outdent-blockquote-test4.html: Added.
  • platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
  • platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
  • platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
  • platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
  • platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Added.
13:50 Changeset [43728] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Added missing return in op_jnless and op_jnlesseq.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
13:47 Changeset [43727] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-14 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

Fix for <rdar://problem/6886217> REGRESSION (S4 beta-ToT): Adium chat window contents no longer resize.

Technically this is a bug in Adium. It appears that Adium has subclassed the WebView and implemented
viewDidMoveToWindow in its subclass improperly. It doesn't call up to the base class WebView like it
should and so our boundsChanged notification never gets added.

Reduce the dependence on viewDidMoveToWindow by moving the registration of observers into
viewWillMoveToWindow instead.

  • WebView/WebView.mm: (-[WebView addSizeObserversForWindow:]): (-[WebView removeWindowObservers]): (-[WebView addWindowObserversForWindow:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):
13:42 Changeset [43726] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-14 Brady Eidson <beidson@apple.com>

Build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType):
13:34 Changeset [43725] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Load constants into the the register file as a temorary measure to
aid bring up. This allows us to use to treat constants like any
other virtual register.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
13:09 Changeset [43724] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-14 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben.

Fix http/tests/xmlhttprequest/cache-override.html on Windows

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data. (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed. (WebCore::WebCoreSynchronousLoader::load): Ditto.
12:55 Changeset [43723] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-14 Paul Godavari <paul@chromium.org>

Reviewed by Dimitri Glazkov.

Bug: Mac Chromium popup menus are not positioned correctly
on scrolled pages:
https://bugs.webkit.org/show_bug.cgi?id=25772

Fix Mac Chromium popup menu placement by taking into
account any scrolling in the current window. This mirrors
the positioning done in PopupContainer::show(), which is
used on Chromium Windows and linux.

Also fixed indenting for this method.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):
12:55 Changeset [43722] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-05-14 Drew Wilson <atwilson@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25774
Upstream V8MessagePortCustom.cpp from the chromium repository.

  • bindings/v8/custom/V8MessagePortCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
12:54 Changeset [43721] by levin@chromium.org
  • 6 edits in trunk

WebKit/mac:

2009-05-14 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24704

Allow the local cache directory to be set using a defaults key.

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
  • WebKit.exp:

WebKitTools:

2009-05-14 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24704

Make paths where data is saved be scoped to the ~ directory,
so that one can run independent instances by setting CFFIXED_USER_HOME.

  • DumpRenderTree/mac/DumpRenderTree.mm: (libraryPath): (setDefaultsToConsistentValuesForTesting): (dumpFrameAsPDF):
12:21 Changeset [43720] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2009-05-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=25777

StyleGeneratedImage::imageSize() needs to take zooming into account for
fixed-size images (i.e. canvas) so that canvas-as-image-background
renders correctly with zooming.

Test: fast/canvas/canvas-bg-zoom.html

  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::imageSize):
12:09 Changeset [43719] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin Adler.

Patch originally by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25796
<rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().

Test: http/tests/security/credentials-in-referer.html

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in SubresourceLoader::create() anyway.
12:07 Changeset [43718] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disabling tests that are failing intermittently.

  • platform/gtk/Skipped:
12:01 Changeset [43717] by cfleizach@apple.com
  • 6 edits in trunk

Bug 25797: Pages with image maps are not properly read with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=25797

11:56 Changeset [43716] by beidson@apple.com
  • 6 edits in trunk

WebCore:

2009-05-14 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniff):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::didReceiveResponse):

LayoutTests:

2009-05-14 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790

  • platform/win/Skipped: Renable these tests.
10:51 Changeset [43715] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

2009-05-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute


Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
value that only the media engine can know, so we just need to add the attribute
to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
the engine can make it available.

Test: media/media-startTime.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::startTime): New.
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::startTime): New.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::startTime): New.

2009-05-14 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute

Add test for 'startTime' attribute.

  • media/media-startTime-expected.txt: Added.
  • media/media-startTime.html: Added.
10:44 Changeset [43714] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Add a comment to QWebView::iconChanged(), mentioning that you will
need to set the icon database path for icons to be loaded, and thus
receive the signal.

  • Api/qwebview.cpp:
10:35 Changeset [43713] by dglazkov@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2009-05-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

Move iframe content to a file because Chromium has
AllowLocalLoadsForLocalOnly enabled. This prevents the parent
frame from modifying the iframe content if it is a data: URL.

https://bugs.webkit.org/show_bug.cgi?id=25766

  • fast/frames/content-opacity-2.html:
  • fast/frames/resources/empty-body.html: Added.
10:34 Changeset [43712] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add a failing text control metrics test to the Windows Skipped file

See Bug 25794: fast/replaced/table-percent-height-text-controls fails
on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25794>

  • platform/win/Skipped: Added fast/replaced/table-percent-height-text-controls.html.
10:29 Changeset [43711] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix

10:27 Changeset [43710] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Only create a QWidget wrapper for the plugin in the case it is not
in the Qt window mapper, and thus receiving events from the Qt
event system. Native Qt based plugins running in process, will
already be in the window mapper, and thus creating a wrapper,
stops them from getting events from Qt, as they are redirected
to the wrapper.

09:45 Changeset [43709] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25784
Leaks seen on HTTP tests

We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for disabling content sniffing, matching the normal code path. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user and m_pass before overwriting. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
09:39 Changeset [43708] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-14 Darin Adler <darin@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6879999> Automator actions that use WebKit on a background thread fail when run outside of Automator

  • WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Added. Contains new broader rule. (needsWebViewInitThreadWorkaround): Changed to call clientNeedsWebViewInitThreadWorkaround.
09:14 Changeset [43707] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25418
Remove new lines from event handler wrapper to make line numbers
in the wrapped script conside with the lines in the original script.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
09:11 Changeset [43706] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add a timing-out test to the Windows Skipped file

See Bug 25792: fast/encoding/percent-escaping.html times out on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25792>

  • platform/win/Skipped: Added fast/encoding/percent-escaping.html.
09:11 Changeset [43705] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove a JSC-specific include that is already added by including
ScriptController.

No change in behavior, so no tests.

  • dom/Document.cpp: Removed JSDOMBinding include.
09:05 Changeset [43704] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled

Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
CFString function was used, so a user-friendly name was stored in encoding fallback array.

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
08:59 Changeset [43703] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add new Hebrew-using tests to the Windows Skipped file

See Bug 23925: Tests that use Hebrew text fail on Windows because
Lucida Grande is not used for Hebrew
<https://bugs.webkit.org/show_bug.cgi?id=23925>

  • platform/win/Skipped: Added tests added in r43664.
08:23 Changeset [43702] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip XHR tests that crash in Windows Debug builds

See:

Bug 25790: REGRESSION (r43518): Multiple XHR tests asserting in
createCFURLResponseWithDefaultMIMEType on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25790>

Bug 25344: Some http tests crash in Debug Windows builds due to an
assertion in CFNetwork when releasing a CFURLConnection
<https://bugs.webkit.org/show_bug.cgi?id=25344>

  • platform/win/Skipped: Added crashing XHR tests.
08:19 Changeset [43701] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Ariya Hidayat.

Fix setHtml test case by adding <head> tag to the expected result. This tag is automatically added by WebKit.

  • tests/qwebframe/tst_qwebframe.cpp:
08:04 Changeset [43700] by aroben@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows jsc build fix

r43648 modified jsc.vcproj's post-build event not to try to copy files
that aren't present. Then r43661 mistakenly un-did that modification.
This patch restores the modification from r43648, but puts the code in
jscCommon.vsprops (where it should have been added in r43648).

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty VCPostBuildEventTool tags.
  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build event command line to match the one in jsc.vcproj from r43648.
07:49 Changeset [43699] by kov@webkit.org
  • 29 edits in trunk/WebCore

2009-05-14 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Add more ENABLE_DATABASE guards.
https://bugs.webkit.org/show_bug.cgi?id=25616

See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)

  • bindings/js/JSSQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementCallback.h:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionCallback.h:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
  • bindings/v8/custom/V8DatabaseCustom.cpp:
  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
  • bindings/v8/custom/V8SQLTransactionCustom.cpp:
  • storage/Database.cpp:
  • storage/DatabaseDetails.h:
  • storage/OriginUsageRecord.cpp:
  • storage/OriginUsageRecord.h:
  • storage/SQLError.h:
  • storage/SQLError.idl:
  • storage/SQLResultSet.cpp:
  • storage/SQLResultSet.h:
  • storage/SQLResultSet.idl:
  • storage/SQLResultSetRowList.cpp:
  • storage/SQLResultSetRowList.h:
  • storage/SQLResultSetRowList.idl:
  • storage/SQLStatementCallback.h:
  • storage/SQLStatementErrorCallback.h:
  • storage/SQLTransactionCallback.h:
  • storage/SQLTransactionErrorCallback.h:
07:23 Changeset [43698] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25325

Make sure pthread_self() is declared before it gets called in Collector.cpp

  • runtime/Collector.cpp: Include pthread.h in most Unix-like platforms (not just for OPENBSD)
07:22 Changeset [43697] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25787

Gtk was the last platform to not unregister plugins when
the plugin is stopped. Catch up with r43550.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop):
07:17 Changeset [43696] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-14 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Ariya Hidayat.

Add a test case for the signal urlChanged().

  • tests/qwebframe/tst_qwebframe.cpp:
07:10 Changeset [43695] by aroben@apple.com
  • 2 edits in trunk/WebCore

Make WebCore.vcproj's pre-build event work again

  • WebCore.vcproj/WebCore.vcproj: Removed empty override of the pre-build event that was accidentally left in when the pre-build event was moved to WebCoreCommon.vsprops.
06:29 Changeset [43694] by aroben@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove old render tree dumps for http tests that are now text-only

Beth made the tests text-only in r43677 but forgot to remove these
Windows-specific render tree dumps.

Rubber-stamped by Dave Hyatt.

  • platform/win/http/tests/navigation/anchor-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/anchor-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
  • platform/win/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
  • platform/win/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
  • platform/win/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
  • platform/win/http/tests/navigation/post-goback2-expected.txt: Removed.
  • platform/win/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
  • platform/win/http/tests/navigation/redirect302-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/redirect302-frames-expected.txt: Removed.
  • platform/win/http/tests/navigation/redirect302-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
  • platform/win/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
  • platform/win/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-frames-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-loadsame-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-reload-expected.txt: Removed.
  • platform/win/http/tests/navigation/success200-subframeload-expected.txt: Removed.
  • platform/win/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
  • platform/win/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
  • platform/win/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
  • platform/win/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
04:50 Changeset [43693] by darin@apple.com
  • 3 edits
    1 add in trunk

WebCore:

2009-05-14 Darin Adler <darin@apple.com>

  • manual-tests/right-click-crash.html: Added.

WebKit/mac:

2009-05-14 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

Bug 24049: Second right-click crashes safari when alert invoked
https://bugs.webkit.org/show_bug.cgi?id=24049
rdar://problem/6878977

  • WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]): Added a retain/autorelease of the event. (-[WebHTMLView menuForEvent:]): Ditto. Also cleaned up the logic here and eliminated some use of pointers that might be invalid after calling through to WebCore. (-[WebHTMLView scrollWheel:]): Ditto. (-[WebHTMLView acceptsFirstMouse:]): Ditto. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView mouseDragged:]): Ditto. (-[WebHTMLView mouseUp:]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView keyUp:]): Ditto. (-[WebHTMLView flagsChanged:]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Ditto.
04:14 Changeset [43692] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark when using JSObjectMakeConstructor

Reviewed by Oliver Hunt.

  • API/JSObjectRef.cpp:

(JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does.

  • API/tests/testapi.c:

(main): Add a test case.

  • runtime/JSObject.h:

(JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this,
but the cause of the failure is not clear from the assertion itself.

04:14 Changeset [43691] by mrowe@apple.com
  • 8 edits in trunk

<rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2

Rubber-stamped by Darin Adler.

The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.

03:55 Changeset [43690] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-05-14 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Added new tests to the skipped list.
01:58 Changeset [43689] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-14 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Checking register file bounds should be a ptr comparison (m_end is a Register*).
Also, the compare should be unsigned, pointers don'ts go negative.

  • jit/JIT.cpp: (JSC::JIT::privateCompile):
01:21 Changeset [43688] by ggaren@apple.com
  • 7 edits in branches/nitro-extreme/JavaScriptCore

2009-05-14 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented op_strict_eq. Original patch by Snowy, by way of Sam and Gavin.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): Added set8, since it's slightly faster than set32, and the new value representation usually doesn't need set32.
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): Added helper functions for dealing with constants. Eventually, we should write special cases for all constants, but these are helpful in the short term.
  • jit/JITOpcodes.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emitSlow_op_nstricteq): teh opcodez.
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValue::isDouble): Added a LowestTag for clarity.

05/13/09:

23:25 Changeset [43687] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some bugs in host function calls.


testapi now passes!

  • jit/JIT.cpp: Changed some registers around to avoid overwriting edx:eax, which is how JSValues are now returned. Also changed the code that passes thisValue to pass the full 64bits of the value. Also added an #error compiler directive to other platform builds, since the JSValue return signature probably won't return in edx:eax on those platforms, and we'll have to investigate a solution.
22:44 Changeset [43686] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2009-05-13 Simon Fraser <simon.fraser@apple.com>

No review.

Fix pixel result after test was changed in r43664.

  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
22:12 Changeset [43685] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Removed parameters from functions that are intended never to use their
parameters.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_put_by_val):
21:39 Changeset [43684] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Ported op_instance_of from TOT. It's basically the same, but some register
stuff changed to memory stuff.

  • jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitStore): Changed to use helper functions.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof): Ported from TOT.
21:00 Changeset [43683] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.


Added a comment to explain an exception-handling subtelty that we found
hard to remember when reviewing my last patch.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
20:52 Changeset [43682] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented try/catch.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw): Updated to use JITStackFrame abstraction. (JSC::JIT::emit_op_catch): Filled out.
19:38 Changeset [43681] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-05-13 Anders Carlsson <andersca@apple.com>

Fix build.

  • WebCore.NPAPI.exp:
19:21 Changeset [43680] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_loop_if_true, op_jfalse, op_jtrue, op_jeq_null and op_jneq_null

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_instanceof): Moved from below to be next to its fast brother.

(JSC::JIT::emit_op_loop_if_true): Similar to the old version
in that it tries to do the integer case first and reduce the
number of jumps you might need to take.
(JSC::JIT::emitSlow_op_loop_if_true):

(JSC::JIT::emit_op_jfalse): Very similar to op_loop_if_true, only
the inverse and without a timeout check.
(JSC::JIT::emitSlow_op_jfalse):

(JSC::JIT::emit_op_jtrue): Very similar to op_loop_if_true except
without the timeout check.
(JSC::JIT::emitSlow_op_jtrue):

(JSC::JIT::emit_op_jeq_null): Very similar to the implementation
of op_eq, except it takes jumps instead of copying the condition
to a dst.
(JSC::JIT::emit_op_jneq_null): Ditto but for op_neq.

19:06 Changeset [43679] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented op_call_varargs.

  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::emit_op_call): (JSC::JIT::emit_op_call_eval): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emit_op_call_varargs): (JSC::JIT::emit_op_construct):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
18:44 Changeset [43678] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix invalid memory write seen in HTMLCanvasElement by Valgrind
https://bugs.webkit.org/show_bug.cgi?id=25759

I can't think of any way to catch this with a layout test, so no test.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
  • css/CSSCanvasValue.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
  • html/HTMLCanvasElement.h:
18:14 Changeset [43677] by bdakin@apple.com
  • 33 edits
    32 adds
    96 deletes in trunk/LayoutTests

2009-05-13 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Oliver Hunt.

Change a bunch of http tests to dumpAsText(). They are currently
failing on the Windown Build Bot because of textarea metrics
changes, and we have decided that these tests are most valuable as
text test anyway.

  • http/tests/navigation/anchor-basic-expected.txt: Added.
  • http/tests/navigation/anchor-basic.html:
  • http/tests/navigation/anchor-goback-expected.txt: Added.
  • http/tests/navigation/anchor-goback.html:
  • http/tests/navigation/anchor-subframeload-expected.txt: Added.
  • http/tests/navigation/anchor-subframeload.html:
  • http/tests/navigation/javascriptlink-basic-expected.txt: Added.
  • http/tests/navigation/javascriptlink-basic.html:
  • http/tests/navigation/javascriptlink-goback-expected.txt: Added.
  • http/tests/navigation/javascriptlink-goback.html:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
  • http/tests/navigation/javascriptlink-subframeload.html:
  • http/tests/navigation/metaredirect-basic-expected.txt: Added.
  • http/tests/navigation/metaredirect-basic.html:
  • http/tests/navigation/metaredirect-frames-expected.txt: Added.
  • http/tests/navigation/metaredirect-frames.html:
  • http/tests/navigation/metaredirect-goback-expected.txt: Added.
  • http/tests/navigation/metaredirect-goback.html:
  • http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/metaredirect-subframeload.html:
  • http/tests/navigation/post-goback2-expected.txt: Added.
  • http/tests/navigation/post-goback2.html:
  • http/tests/navigation/postredirect-goback2-expected.txt: Added.
  • http/tests/navigation/postredirect-goback2.html:
  • http/tests/navigation/redirect302-basic-expected.txt: Added.
  • http/tests/navigation/redirect302-basic.html:
  • http/tests/navigation/redirect302-frames-expected.txt: Added.
  • http/tests/navigation/redirect302-frames.html:
  • http/tests/navigation/redirect302-goback-expected.txt: Added.
  • http/tests/navigation/redirect302-goback.html:
  • http/tests/navigation/redirect302-subframeload-expected.txt: Added.
  • http/tests/navigation/redirect302-subframeload.html:
  • http/tests/navigation/relativeanchor-basic-expected.txt: Added.
  • http/tests/navigation/relativeanchor-basic.html:
  • http/tests/navigation/relativeanchor-frames-expected.txt: Added.
  • http/tests/navigation/relativeanchor-frames.html:
  • http/tests/navigation/relativeanchor-goback-expected.txt: Added.
  • http/tests/navigation/relativeanchor-goback.html:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowmetaredirect-basic.html:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowtimerredirect-basic.html:
  • http/tests/navigation/success200-basic-expected.txt: Added.
  • http/tests/navigation/success200-basic.html:
  • http/tests/navigation/success200-frames-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame.html:
  • http/tests/navigation/success200-frames.html:
  • http/tests/navigation/success200-goback-expected.txt: Added.
  • http/tests/navigation/success200-goback.html:
  • http/tests/navigation/success200-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-loadsame.html:
  • http/tests/navigation/success200-reload-expected.txt: Added.
  • http/tests/navigation/success200-reload.html:
  • http/tests/navigation/success200-subframeload-expected.txt: Added.
  • http/tests/navigation/success200-subframeload.html:
  • http/tests/navigation/timerredirect-basic-expected.txt: Added.
  • http/tests/navigation/timerredirect-basic.html:
  • http/tests/navigation/timerredirect-frames-expected.txt: Added.
  • http/tests/navigation/timerredirect-frames.html:
  • http/tests/navigation/timerredirect-goback-expected.txt: Added.
  • http/tests/navigation/timerredirect-goback.html:
  • http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/timerredirect-subframeload.html:
  • platform/mac/http/tests/navigation/anchor-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.txt: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.png: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
18:10 Changeset [43676] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2009-05-13 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6884476>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetLocation): Forward this to the plug-in instance proxy.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getLocation): Ask the plug-in view for the location.


  • Plugins/Hosted/WebKitPluginClient.defs: Add MIG definition.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView locationStringForTarget:]): Return the URL for a given frame.


  • Plugins/WebNetscapeContainerCheckPrivate.h: Bump version. Add new declaration to the vtable.


  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs): Add new declaration to the vtable.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView locationForTarget:]): Call the base class method.


  • Plugins/npapi.mm: (WKN_GetLocation): Forward this to the plug-in view.
18:02 Changeset [43675] by darin@apple.com
  • 3 edits in trunk/WebKit/mac

2009-05-13 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6871587> Smart Copy/Paste setting should persist as continuous
spell checking setting does

  • WebView/WebPreferenceKeysPrivate.h: Added WebSmartInsertDeleteEnabled.
  • WebView/WebView.mm: (-[WebViewPrivate init]): Initialize based on WebSmartInsertDeleteEnabled default. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Removed code that initialized here. (-[WebView setSmartInsertDeleteEnabled:]): Set default here was with continuous spell checking setting.
17:50 Changeset [43674] by ggaren@apple.com
  • 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog

ChangeLog reverse-o

17:49 Changeset [43673] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Implemented op_not. (Gavin did most of the work!)

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
17:44 Changeset [43672] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet

Test: platform/mac/fast/loader/user-stylesheet-fast-path.html

  • page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): For data URLs with base64-encoded UTF-8 data, just decode the style sheet here an apply it synchronously instead of invoking an asynchronous loader.

LayoutTests:

Reviewed by Anders Carlsson.

  • test for <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet
  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Added.
  • platform/mac/fast/loader/user-stylesheet-fast-path.html: Added.
17:11 Changeset [43671] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Implemented op_not. (Gavin did most of the work!)

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
16:50 Changeset [43670] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755

Fix windows build bustage

16:44 Changeset [43669] by cfleizach@apple.com
  • 24 edits
    9 adds in trunk

Bug 25755: Implement ARIA grid role
https://bugs.webkit.org/show_bug.cgi?id=25755

16:22 Changeset [43668] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented op_global_resolve.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): Added back accidentally removed early returns.

(JSC::JIT::emit_op_resolve_global):

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_resolve_global): Pretty similar to the old code, but we need two reads and a TimesEight step in order to account for the 64bit value size.
  • jit/JITStubs.h: (JSC::): Slightly tweaked this code to specialize for a JSGlobalObject*, to avoid having to pass an irrelevant tag pointer to the stub.
16:08 Changeset [43667] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)

op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
This leads to bad happen.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less):
15:44 Changeset [43666] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebCore

2009-05-13 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25763: Need to move v8 custom binding to the custom directory.
https://bugs.webkit.org/show_bug.cgi?id=25763

No test due to no change in behavior.

  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
15:39 Changeset [43665] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-13 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
https://bugs.webkit.org/show_bug.cgi?id=25758

  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
15:30 Changeset [43664] by dglazkov@chromium.org
  • 14 edits
    8 adds in trunk

WebCore:

2009-05-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.

This CL fixes 3 fundamental issues:

  • Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
  • Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
  • Full truncation on InlineBoxes in RTL flow - bug 24186
  • Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.

The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.

To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.

The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.

https://bugs.webkit.org/show_bug.cgi?id=24186
https://bugs.webkit.org/show_bug.cgi?id=25135
https://bugs.webkit.org/show_bug.cgi?id=24206

Tests: fast/css/text-overflow-ellipsis-bidi.html

fast/css/text-overflow-ellipsis-strict.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::placeEllipsisBox):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): (WebCore::InlineFlowBox::placeEllipsisBox):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::placeEllipsisBox):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

2009-05-13 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Dave Hyatt.

Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.

This CL fixes 3 fundamental issues:

  • Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
  • Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
  • Full truncation on InlineBoxes in RTL flow - bug 24186
  • Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.

The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.

To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.

The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.

https://bugs.webkit.org/show_bug.cgi?id=24186
https://bugs.webkit.org/show_bug.cgi?id=25135
https://bugs.webkit.org/show_bug.cgi?id=24206

  • fast/css/text-overflow-ellipsis-bidi.html: Added.
  • fast/css/text-overflow-ellipsis-strict.html: Added.
  • fast/css/text-overflow-ellipsis.html:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
15:09 Changeset [43663] by dimich@chromium.org
  • 23 edits in trunk

JavaScriptCore:

2009-05-13 Dmitry Titov <dimich@chromium.org>

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • bytecode/SamplingTool.cpp: (JSC::SamplingThread::start): (JSC::SamplingThread::stop):
  • bytecode/SamplingTool.h:
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::ref): (WTF::::deref):
  • wtf/Threading.h:
  • wtf/ThreadingNone.cpp:
  • wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::clearPthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
  • wtf/ThreadingWin.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::clearThreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
  • wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByGthreadHandle): (WTF::establishIdentifierForThread): (WTF::threadForIdentifier): (WTF::clearThreadForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/qt/ThreadingQt.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByQthreadHandle): (WTF::establishIdentifierForThread): (WTF::clearThreadForIdentifier): (WTF::threadForIdentifier): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):

WebCore:

2009-05-13 Dmitry Titov <dimich@chromium.org>

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser): (WebCore::createMemoryParser):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::localStorageThread): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):

WebKit/win:

2009-05-13 Dmitry Titov <dimich@chromium.org>

Rubber-stamped by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25746
Revert http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
14:55 Changeset [43662] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-13 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus


Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
(which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
content.


Added fast/overflow/border-radius-clipping.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):

LayoutTests:

2009-05-13 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin.

Add layout test for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus.

  • fast/overflow/border-radius-clipping.html: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.txt: Added.
14:53 Changeset [43661] by darin@apple.com
  • 52 edits in trunk

JavaScriptCore:

2009-05-13 Darin Adler <darin@apple.com>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebCore:

2009-05-13 Darin Adler <darin@apple.com>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebKit/mac:

2009-05-13 Darin Adler <darin@apple.com>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

14:25 Changeset [43660] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_to_jsnumber.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber):
14:12 Changeset [43659] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.7

Tagging 1.1.7.

14:08 Changeset [43658] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt

uploading new results. when I added this test, i committed outdated results.

13:56 Changeset [43657] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2009-05-13 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin and Darin Adler.

Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.


Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
to a non-self-painting layer (and vice versa).


Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
repaint properly on opacity changes, etc.

Added fast/repaint/opacity-change-on-overflow-float.html.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange):
  • rendering/RenderBoxModelObject.h:

LayoutTests:

2009-05-13 David Hyatt <hyatt@apple.com>

Reviewed by Beth Dakin and Darin Adler.

Add a repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.

  • fast/repaint/opacity-change-on-overflow-float.html: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
13:49 Changeset [43656] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_convert_this.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
13:46 Changeset [43655] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disable new tests. We are not going to be adding more new test
results for now, for we want to better sort out things such as
fixed DPI, and easily reproducible font configuration.

  • platform/gtk/Skipped:
13:38 Changeset [43654] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Darin Adler <darin@apple.com>

Tiger build fix.

  • parser/Grammar.y: Add back empty code blocks, needed by older versions of bison on certain rules.
13:31 Changeset [43653] by ggaren@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Got basic JS function and constructor calls working.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_call): (JSC::JIT::emitSlow_op_call_eval): (JSC::JIT::emitSlow_op_call_varargs): (JSC::JIT::emitSlow_op_construct): (JSC::JIT::compileOpCall): Filled out these cases, with call_eval #if'd out.
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitLoad): Restored some legacy "*CTIArg*" functions, since I wanted to avoid the complexity of revamping the API here while trying to bring it up. Eventually, we should re-remove all of these functions.

(JSC::JIT::recordJumpTarget): Removed unnecessary macro cruft. You will
not silence me, Sam Weinig! The world will know that you are a crufty,
crufty, crufty programmer!!!

  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::):
  • jit/JITStubs.h: Changed up some offsets in the JITStackFrame class, since and off-by-one error was causing stack misalignment.
12:40 Changeset [43652] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-13 Dimitri Glazkov <dglazkov@chromium.org>

Not reviewed, build fix.

Move an include, needed by Debugger under the corresponding guard.

  • inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER

guard.

12:38 Changeset [43651] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_eq_null and op_neq_null.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): (JSC::MacroAssemblerX86Common::setTest8):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_stricteq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emit_op_nstricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
  • jsc.cpp:
12:15 Changeset [43650] by levin@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-13 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
https://bugs.webkit.org/show_bug.cgi?id=25394

Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Add another check to subresource loader to avoid doing any loads in frames when the loaders are being stopped.

LayoutTests:

2009-05-13 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
https://bugs.webkit.org/show_bug.cgi?id=25394

Request a subresource load for an IMG after 'unload' and before the next
page load completes to expose the crash.

  • http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/frame-unload-abort-crash.html: Added.
  • http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload.html: Added.
12:13 Changeset [43649] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-13 Stephan Haller <nomad@froevel.de>

Reviewed by Gustavo Noronha.

Wrong handling of file upload if no file selected
https://bugs.webkit.org/show_bug.cgi?id=25649

Fixed returned path if path is empty

  • WebCore/platform/gtk/FileSystemGtk.cpp:
12:08 Changeset [43648] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

11:42 Changeset [43647] by aroben@apple.com
  • 10 edits in trunk/JavaScriptCore

Windows build fixes after r43642

  • debugger/Debugger.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/JSArray.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/StringPrototype.cpp: Added missing #includes.
11:33 Changeset [43646] by mitz@apple.com
  • 5 edits
    8 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading

Tests: fast/frames/content-opacity-1.html

fast/frames/content-opacity-2.html

  • page/FrameView.cpp: (WebCore::FrameView::reset): Reset m_contentIsOpaque to false. (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content is not known to be opaque. (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque and enables or disables fast repaints accordingly.
  • page/FrameView.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the document()->haveStylesheetsLoaded() condition in determining whether the root is opaque. This is what was causing the bug, as iframes were considered to be opaque, and thus painted an opaque white background, whenever they were pending a style sheet load. Changed to call FrameView::setContentIsOpaqe() instead of setUseSlowRepaints(), which allows the frame to go back to fast repaints if the content becomes opaque. Corrected the check for background color opacity: any alpha value other than 255--not just zero--is not opaque.

LayoutTests:

Reviewed by Dave Hyatt.

  • tests for <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading
  • fast/frames/content-opacity-1.html: Added.
  • fast/frames/content-opacity-2.html: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.checksum: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.png: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.txt: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.checksum: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.png: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.txt: Added.
11:30 Changeset [43645] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Sam Weinig.

[Qt] Fix "lighther" composition mode.
QPainter::CompositionMode_Plus is the right match.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
11:19 Changeset [43644] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not handle KeyEvents with Ctrl or Alt modifiers that we
otherwise know nothing about. Otherwise shortcuts defined in the
WebView will never be executed.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
11:15 Changeset [43643] by darin@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Darn, Cameron caught it but I forgot to fix it.

11:14 Changeset [43642] by darin@apple.com
  • 43 edits in trunk

JavaScriptCore:

2009-05-13 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674

Step 3: Add some actual arena allocation. About 1% SunSpider speedup.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack contains const Identifier* now. (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const Identifier&.
  • bytecompiler/BytecodeGenerator.h: Ditto
  • bytecompiler/SegmentedVector.h: Added isEmpty.
  • debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Moved this function here from WebCore so WebCore doesn't need the details of FunctionBodyNode.
  • debugger/Debugger.h: Ditto.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): Updated since VarStack contains const Identifier* now.
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body rather than on the function object, since we can't easily have inlined access to the FunctionBodyNode in JSFunction.h since WebCore needs access to that header. (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
  • profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): Ditto.
  • parser/Grammar.y: Use JSGlobalData* to pass the global data pointer around whenever possible instead of using void*. Changed SET_EXCEPTION_LOCATION from a macro to an inline function. Marked the structure-creating functions inline. Changed the VarStack to use identifier pointers instead of actual identifiers. This takes advantage of the fact that all identifier pointers come from the arena and avoids referenc count churn. Changed Identifier* to const Identifier* to make sure we don't modify any by accident. Used identifiers for regular expression strings too, using the new scanRegExp that has out parameters instead of the old one that relied on side effects in the Lexer. Move the creation of numeric identifiers out of this file and into the PropertyNode constructor.
  • parser/Lexer.cpp: (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers. (JSC::Lexer::makeIdentifier): Changed return type to const Identifier* and changed to call ParserArena. (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier* as well as a prefix character argument so we can handle the /= case without a string append. (JSC::Lexer::skipRegExp): Added. Skips a regular expression without allocating Identifier objects. (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern, and m_flags, and added code to set m_arena to 0.
  • parser/Lexer.h: Updated for changes above.
  • parser/NodeConstructors.h: (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable on the arena. (JSC::ParserArenaDeletable::operator new): Changed to call the allocateDeletable function on the arena instead of deleteWithArena. (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead of UString since these come from the parser which makes identifiers. (JSC::PropertyNode::PropertyNode): Added new constructor that makes numeric identifiers. Some day we might want to optimize this for integers so it doesn't create a string for each one. (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier since it's now a const Identifier& so it can't be left uninitialized. (JSC::BreakNode::BreakNode): Ditto. (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements* to keep track of the statements rather than a separate statement vector. (JSC::BlockNode::BlockNode): Ditto. (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
  • parser/Nodes.cpp: Moved the comment explaining emitBytecode in here. It seemed strangely out of place in the header. (JSC::ThrowableExpressionData::emitThrowError): Added an overload for UString as well as Identifier. (JSC::SourceElements::singleStatement): Added. (JSC::SourceElements::lastStatement): Added. (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags are now Identifier instead of UString. Also changed the throwError code to use the substitution mechanism instead of doing a string append. (JSC::SourceElements::emitBytecode): Added. Replaces the old statementListEmitCode function, since we now keep the SourceElements objects around. (JSC::BlockNode::lastStatement): Added. (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of statementListEmitCode. (JSC::CaseClauseNode::emitBytecode): Added. (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode instead of statementListEmitCode. (JSC::ScopeNodeData::ScopeNodeData): Changed to store the SourceElements* instead of using releaseContentsIntoVector. (JSC::ScopeNode::emitStatementsBytecode): Added. (JSC::ScopeNode::singleStatement): Added. (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead of statementListEmitCode. (JSC::EvalNode::emitBytecode): Ditto. (JSC::EvalNode::generateBytecode): Removed code to clear the children vector. This optimization is no longer possible since everything is in a single arena. (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode insetad of statementListEmitCode and check for the return node using the new functions.
  • parser/Nodes.h: Changed VarStack to store const Identifier* instead of Identifier and rely on the arena to control lifetime. Added a new ParserArenaFreeable class. Made ParserArenaDeletable inherit from FastAllocBase instead of having its own operator new. Base the Node class on ParserArenaFreeable. Changed the various Node classes to use const Identifier& instead of Identifier to avoid the need to call their destructors and allow them to function as "freeable" in the arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions. Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode, CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable as a base class since they do not descend from Node. Eliminated the StatementVector type and instead have various classes use SourceElements* instead of StatementVector. This prevents those classes from having th use ParserArenaDeletable to make sure the vector destructor is called.
  • parser/Parser.cpp: (JSC::Parser::parse): Pass the arena to the lexer.
  • parser/Parser.h: Added an include of ParserArena.h, which is no longer included by Nodes.h.
  • parser/ParserArena.cpp: (JSC::ParserArena::ParserArena): Added. Initializes the new members, m_freeableMemory, m_freeablePoolEnd, and m_identifiers. (JSC::ParserArena::freeablePool): Added. Computes the pool pointer, since we store only the current pointer and the end of pool pointer. (JSC::ParserArena::deallocateObjects): Added. Contains the common memory-deallocation logic used by both the destructor and the reset function. (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects. (JSC::ParserArena::reset): Ditto. Also added code to zero out the new structures, and switched to use clear() instead of shrink(0) since we don't really reuse arenas. (JSC::ParserArena::makeNumericIdentifier): Added. (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool is empty. (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine since this is used only for assertions at the moment.
  • parser/ParserArena.h: Added an actual arena of "freeable" objects, ones that don't need destructors to be called. Also added the segmented vector of identifiers that used to be in the Lexer.
  • runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Use singleStatement function rather than getting at a StatementVector.
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): Call isHostFunction on the body rather than the function object.
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): Moved the structure version of this in here from the header. It's not hot enough that it needs to be inlined. (JSC::JSFunction::isHostFunction): Moved this in here from the header. It's now a helper to be used only within the class. (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that it needs to be inlined, and we want to be able to compile the header without the definition of FunctionBodyNode.
  • runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was exposing too much JavaScriptCore dependency to WebCore. Because of this change and some changes made to WebCore, we could now export a lot fewer headers from JavaScriptCore, but I have not done that yet in this check-in. Made a couple functions non-inline. Removes some isHostFunction() assertions.


  • wtf/FastAllocBase.h: Added the conventional using statements we use in WTF so we can use identifiers from the WTF namespace without explicit namespace qualification or namespace directive. This is the usual WTF style, although it's unconventional in the C++ world. We use the namespace primarily for link-time disambiguation, not compile-time.
  • wtf/FastMalloc.cpp: Fixed an incorrect comment.

WebCore:

2009-05-13 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674

  • bindings/js/JSDOMBinding.h: Removed include of JSFunction.h. We don't want the entire DOM binding to depend on that file.
  • bindings/js/JSAudioConstructor.cpp: Added include of Error.h. Before we inherited this automatically because JDDOMBinding.h included JSFunction.h, but that was excessive.
  • bindings/js/JSDOMWindowCustom.cpp: Ditto.
  • bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
  • bindings/js/JSImageConstructor.cpp: Ditto.
  • bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
  • bindings/js/JSMessageChannelConstructor.cpp: Ditto.
  • bindings/js/JSOptionConstructor.cpp: Ditto.
  • bindings/js/JSWorkerConstructor.cpp: Ditto.
  • bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
  • bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
  • inspector/InspectorController.cpp: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Moved mose of this function into the base class in JavaScriptCore, so the details of compilation don't have to be exposed.

WebKit/mac:

2009-05-13 Darin Adler <darin@apple.com>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
https://bugs.webkit.org/show_bug.cgi?id=25674

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes. New ones needed due to reducing includes of JSDOMBinding.h.
  • WebView/WebScriptDebugger.mm: Ditto.
11:05 Changeset [43641] by xan@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Forgot to add ChangeLog.

11:03 Changeset [43640] by xan@webkit.org
  • 1 edit in trunk/JavaScriptCore/GNUmakefile.am

2009-05-13 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix: add JITStubCall.h to files list.

  • GNUmakefile.am:
11:02 Changeset [43639] by darin@apple.com
  • 17 edits in trunk

WebCore:

2009-05-13 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.

  • dom/DocumentMarker.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
  • editing/Editor.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/mac/WebCoreViewFactory.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::contextMenuItemTagChangeBack):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::replacedString):
  • rendering/HitTestResult.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:

WebKit/mac:

2009-05-13 Douglas R. Davidson <ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagChangeBack:]):
  • WebView/WebUIDelegatePrivate.h:
10:56 Changeset [43638] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-13 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Ariya Hidayat.

Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
This is to ensure that urlChanged() is emitted even if the frame has no title.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
10:13 Changeset [43637] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed build fix, as suggested by Yael Aharon <yael.aharon@nokia.com>.

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): renamed IsValid to isValid.
09:35 Changeset [43636] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Fix resolve-ChangeLogs when used with Subversion

Reviewed by Darin Adler.

Fixes the following issue when run on a Subversion repository:

$ ./WebKitTools/Scripts/resolve-ChangeLogs
ERROR: --continue may only be used with a git repository

  • Scripts/resolve-ChangeLogs: Check for the boolean value of $gitRebaseContinue, not whether it's defined, when validating command-line switches.
09:21 Changeset [43635] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Add information about the SVG index bounds check committed in
r43590.

  • NEWS:
09:19 Changeset [43634] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Fix Gtk+/X11 build on OSX

Including the CoreFoundation header here and X11 headers
later will result in different definitions for Boolean. The
CoreFoundation include does not seem to be necessary here
and my mac build was successfull without it. I will remove
it for now. If the build bots disagree this will be replaced
by a #if PLATFORM(CF).

09:19 Changeset [43633] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX

When building Gtk+ on OSX we ended up declaring
setNPWindowIfNeeded twice. Fix that by moving
the #if PLATFORM(GTK) up and using elif instead of
else.

09:15 Changeset [43632] by kov@webkit.org
  • 1 edit in trunk/WebKit/gtk/NEWS

Small typo fix superseed -> supersede

09:08 Changeset [43631] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25749
Add a test for non-same origin appcache manifest URL

  • http/tests/appcache/different-origin-manifest-expected.txt: Added.
  • http/tests/appcache/different-origin-manifest.html: Added.
09:08 Changeset [43630] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Note changes since 1.1.6.

  • NEWS:
08:25 Changeset [43629] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Updated control file, and main file for the 1.1.7
release.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
07:54 Changeset [43628] by xan@webkit.org
  • 2 edits in trunk

2009-05-13 Xan Lopez <xlopez@igalia.com>

Unreviewed: bump versions in preparation for 1.1.7 release.

  • configure.ac:
07:49 Changeset [43627] by xan@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-05-13 Luca Ferretti <elle.uca@libero.it>

Rubber-stamped by Xan Lopez.

New Italian translation.

  • it.po: Added.
07:22 Changeset [43626] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert "2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>"

This reverts commit Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
WebCore/config.h.

  • wtf/Platform.h:
07:20 Changeset [43625] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-13 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Rubberstamped by Ariya Hidayat.

Fix coding style: Add {} to contents of if, containing a for loop.

07:04 Changeset [43624] by xan@webkit.org
  • 8 edits in trunk

WebCore:

2009-05-13 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard

The kit wants to paste from at least two different
clipboards. By introducing getCurrentTarget to the
PasteboardHelper interface we can make this decision
in the kit.
Use the new method in PasteboardGtk to get the right
GdkClipboard for the paste operation.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::plainText):
  • platform/gtk/PasteboardHelper.h:

WebKit/gtk:

2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard

For paste from middle button (button==2) we want to use
the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
method in PasteboardHelperGtk by asking the WebView which
clipboard to use.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getCurrentTarget):
  • WebCoreSupport/PasteboardHelperGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): (webkit_web_view_use_primary_for_paste):
06:49 Changeset [43623] by xan@webkit.org
  • 2 edits in trunk

2009-05-13 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Revert commit r43563, since it breaks WebKitGTK+ when compiled
with gcc 4.4.

  • GNUmakefile.am:
06:34 Changeset [43622] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-05-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
<rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard

QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
on Tiger or Leopard.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD. (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
05:12 Changeset [43621] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Fixed a possible crash @styleProperty when there is no embedded/external CSS set.

  • Api/qwebelement.cpp: (QWebElement::styleProperty):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
05:07 Changeset [43620] by ariya@webkit.org
  • 3 edits
    3 adds in trunk/WebKit/qt

2009-05-12 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Added external CSS test cases to QWebElement::styleProperty() method.

Also some ::styleProperty() tests cleanup.

  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
02:10 Changeset [43619] by barraclough@apple.com
  • 14 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
(enabled using ENABLE(SAMPLING_COUNTERS)). To count events within a single function
use the class 'SamplingCounter', where the counter may be incremented from multiple
functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
Further description of these classes is provided alongside their definition in
SamplingTool.h.

Counters may be incremented from c++ by calling the 'count()' method on the counter,
or may be incremented by JIT code by using the 'emitCount()' method within the JIT.

This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.

  • JavaScriptCore.exp:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::addWithCarry32): (JSC::MacroAssemblerX86::and32): (JSC::MacroAssemblerX86::or32):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::or32):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::addPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::adcl_im): (JSC::X86Assembler::addq_im): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::orl_im):
  • bytecode/SamplingTool.cpp: (JSC::AbstractSamplingCounter::dump):
  • bytecode/SamplingTool.h: (JSC::AbstractSamplingCounter::count): (JSC::GlobalSamplingCounter::name): (JSC::SamplingCounter::SamplingCounter):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::):
  • jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag): (JSC::JIT::emitCount):
  • jsc.cpp: (runWithScripts):
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode):
  • wtf/Platform.h:
00:11 Changeset [43618] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.3/JavaScriptCore

Merged r43616.

00:06 Changeset [43617] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.3

New tag.

00:05 Changeset [43616] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

05/12/09:

23:00 Changeset [43615] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.2/SunSpider

Merge r43607.

22:58 Changeset [43614] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_new_error.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add a version of addArgument that takes a constant JSValue.
22:58 Changeset [43613] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.2/JavaScriptCore

Merged r43611.

22:47 Changeset [43612] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.2

New tag.

22:46 Changeset [43611] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

22:35 Changeset [43610] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove now unused emitGetVariableObjectRegister and emitPutVariableObjectRegister.

  • jit/JIT.cpp:
  • jit/JIT.h:
22:32 Changeset [43609] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_to_primitive and op_next_pname.

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emitSlow_op_loop_if_true): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_next_pname):
21:46 Changeset [43608] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-05-12 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

Bug 25738: Skia: CSS border style not cleared for SVG object
https://bugs.webkit.org/show_bug.cgi?id=25738

If no dashing is set, this change reverts to solid stroke
(previously the code bailed and left the old setting, whatever it was)

Test case listed in above bug entry.
(Additional complications due to each platform rendering dotted lines differently -
c.f. https://bugs.webkit.org/show_bug.cgi?id=25737)

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setLineDash):
21:36 Changeset [43607] by sfalken@apple.com
  • 2 edits in trunk/SunSpider

Build fix.

  • SunSpider.make:
20:53 Changeset [43606] by oliver@apple.com
  • 5 edits in trunk

<rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading http://www.sears.com

Reviewed by Gavin Barraclough

We created the arguments objects before an op_push_scope but not
before op_push_new_scope, this meant a null arguments object could
be resolved inside catch blocks.

20:38 Changeset [43605] by eric@webkit.org
  • 9 edits
    3 adds in trunk

2009-05-11 Erik Arvidsson <arv@chromium.org>

Reviewed by Eric Seidel.

Bug 21903: Adds DOM bindings for the placeholder property of the
HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=21903

Test: fast/forms/placeholder-dom-property.html

  • dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::placeholder): (WebCore::HTMLInputElement::setPlaceholder):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::placeholder): (WebCore::WMLInputElement::setPlaceholder):
20:13 Changeset [43604] by abarth@webkit.org
  • 3 edits
    6 adds in trunk

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
19:39 Changeset [43603] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

<rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading http://www.monster.com; http://www.cnet.com
<https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)

Reviewed by Gavin Barraclough.

Following on from the lazy arguments creation patch, it's now
possible for an activation to to have a null register in the callframe
so we can't just blindly mark the local registers in an activation,
and must null check first instead.

18:38 Changeset [43602] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add op_get_global_var, op_put_global_var, emit_op_get_scoped_var, emit_op_put_scoped_var and
op_unexpected_load.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitStore): (JSC::JIT::emitLoadReturnValue):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_unexpected_load):
17:31 Changeset [43601] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21418: resolve-ChangeLogs should have a --continue option which does git rebase --continue

<https://bugs.webkit.org/show_bug.cgi?id=21418>

Reviewed by Darin Adler.

Scripts/resolve-ChangeLogs: Added -ccontinue switch that

runs "git rebase --continue" before exiting the script.
(hasGitUnmergedFiles): Added. Returns true if there are
unmerged files in the git repository.

17:31 Changeset [43600] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff Garen.

WTF_USE_CTI_REPATCH_PIC is no longer used, remove.

  • jit/JIT.h:
  • jit/JITStubCall.h:
17:27 Changeset [43599] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Maciej Stachowiak.

We've run into some problems where changing the size of the class JIT leads to
performance fluctuations. Try forcing alignment in an attempt to stabalize this.

  • jit/JIT.h:
17:20 Changeset [43598] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added overflow handling to op_sub.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft):
17:06 Changeset [43597] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

2009-05-12 Simon Fraser <simon.fraser@apple.com>

No review.

media/video-size-intrinsic-scale.html fails on Tiger, so add it to the skipped
list.

  • platform/mac-tiger/Skipped:
16:52 Changeset [43596] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove a function call by folding op_get_by_id and op_put_by_id into
their respective compile functions.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id):
16:30 Changeset [43595] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Make JITStubCall work in 64bit by making the stack index
step dependent on the size of void*.

  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument):
16:28 Changeset [43594] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-12 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Fix <rdar://problem/6878105>.


When instantiating the QT plug-in under Dashboard, force "kiosk mode".


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
16:16 Changeset [43593] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement simple version of property access opcodes
which just call a stub functions.

  • jit/JITOpcodes.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument):
  • jsc.cpp:
16:14 Changeset [43592] by simon.fraser@apple.com
  • 21 edits
    16 copies
    3 adds
    2 deletes in trunk/LayoutTests

2009-05-12 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein

<rdar://problem/6497461> Many media layout tests failing on SnowLeopard.

Turn media tests back on for SnowLeopard, and generate new pixel results. Put override
results in platform/mac-leopard when necessary.

media/video-size-intrinsic-scale.html fails and is still skipped: <rdar://problem/6877291>

  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum: Added.
  • platform/mac-leopard/media/audio-controls-rendering-expected.png: Added.
  • platform/mac-leopard/media/video-aspect-ratio-expected.checksum: Added.
  • platform/mac-leopard/media/video-aspect-ratio-expected.png: Added.
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum: Added.
  • platform/mac-leopard/media/video-controls-rendering-expected.png: Added.
  • platform/mac-leopard/media/video-display-toggle-expected.checksum: Added.
  • platform/mac-leopard/media/video-display-toggle-expected.png: Added.
  • platform/mac-leopard/media/video-empty-source-expected.checksum: Added.
  • platform/mac-leopard/media/video-empty-source-expected.png: Added.
  • platform/mac-leopard/media/video-layer-crash-expected.checksum: Added.
  • platform/mac-leopard/media/video-layer-crash-expected.png: Added.
  • platform/mac-leopard/media/video-transformed-expected.checksum: Added.
  • platform/mac-leopard/media/video-transformed-expected.png: Added.
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac-leopard/media/video-zoom-controls-expected.png: Added.
  • platform/mac-leopard/media/video-zoom-expected.checksum: Added.
  • platform/mac-leopard/media/video-zoom-expected.png: Added.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-visible-audio-only-expected.checksum: Removed.
  • platform/mac/media/video-controls-visible-audio-only-expected.png: Removed.
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-layer-crash-expected.checksum:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
  • platform/mac/media/video-zoom-controls-expected.checksum:
  • platform/mac/media/video-zoom-controls-expected.png:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
16:02 Changeset [43591] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix. Add ParserArena.cpp to the build.

15:23 Changeset [43590] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore

Reviewed by Darin Adler.

SVGList::insertItemBefore would not perform a bounds check on the
index it was provided, potentially leading to a buffer overflow.

15:18 Changeset [43589] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added work-around for XCode debugging echo problem.

  • jsc.cpp: (runInteractive):
15:17 Changeset [43588] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added overflow handling to op_add.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace):
14:54 Changeset [43587] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-12 Paul Godavari <paul@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25708: Cannot choose menu items in popups with many entries in Chromium
https://bugs.webkit.org/show_bug.cgi?id=25708

This change sets the window size for popups on Mac to include all items
in the menu. This is required for hit testing on Mac, where we use native
controls to manage the popups and don't want to artificially limit the
valid hit testing region to a limited scroll window.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
14:07 Changeset [43586] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add slow cases for op_jnless or emit_op_jnlesseq.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq):
14:03 Changeset [43585] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add implementations for op_jnless, emit_op_jnlesseq, op_loop_if_less and op_loop_if_lesseq.
No slow cases for op_jnless or emit_op_jnlesseq yet.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_loop_if_lesseq):
13:36 Changeset [43584] by dglazkov@chromium.org
  • 4 edits in trunk/WebCore

2009-05-12 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

Fixes to build with latest skia: SkTypeface::Create() is now
SkTypeface::CreateFromName(); computeBounds() has been reworked
as getBounds(). The changes are placed behind an #ifdef for now,
so that we can roll back the skia version in Chromium if necessary
without having to roll back this change.

https://bugs.webkit.org/show_bug.cgi?id=25705

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
13:27 Changeset [43583] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Unsigned underflow on 64bit cannot be treated as a negative number

Reviewed by Geoff Garen

This code included some placeswhere we deliberately create negative offsets
from unsigned values, on 32bit this is "safe", but in 64bit builds much
badness occurs. Solution is to use signed types as nature intended.

13:22 Changeset [43582] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Turn the RECORD_JUMP_TARGET macro into an inline function.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::recordJumpTarget):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_jmp_scopes):
13:21 Changeset [43581] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Add MacroAssemblerX86Common::set8 to fix the build.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8):
13:16 Changeset [43580] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • declare a forgotten method
  • DOM/WebDOMOperationsPrivate.h: Declare -[DOMNode markupString] in the WebDOMNodeOperationsPendingPublic category.
13:15 Changeset [43579] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added overflow recovery for pre_inc and pre_dec.


Turned some short-circuit code into early returns, as is the WebKit style.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emitSlow_op_pre_dec):
13:08 Changeset [43578] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_jmp, op_loop, op_eq and op_neq.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
12:57 Changeset [43577] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement the slow cases for arithmetic opcodes.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_mod):
12:34 Changeset [43576] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_bitnot.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::not32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::notl_m):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot):
12:26 Changeset [43575] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add arithmetic opcode implementations from the old nitro-extreme branch.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
  • jit/JITOpcodes.cpp:
11:44 Changeset [43574] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-12 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25732
Update V8ElementCustom.cpp to match the current API of V8Proxy.

(WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().

11:26 Changeset [43573] by ggaren@apple.com
  • 4 edits
    2 adds in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Removed JIT_OPTIMIZE_ARITHMETIC setting, since it was all about 32bit
value representations.


Added JSAPIValueWrapper to the repository.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • runtime/JSAPIValueWrapper.cpp: Added. (JSC::JSAPIValueWrapper::toPrimitive): (JSC::JSAPIValueWrapper::getPrimitiveNumber): (JSC::JSAPIValueWrapper::toBoolean): (JSC::JSAPIValueWrapper::toNumber): (JSC::JSAPIValueWrapper::toString): (JSC::JSAPIValueWrapper::toObject):
  • runtime/JSAPIValueWrapper.h: Added. (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::isAPIValueWrapper): (JSC::JSAPIValueWrapper::JSAPIValueWrapper): (JSC::jsAPIValueWrapper):
  • wtf/Platform.h:
11:13 Changeset [43572] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-12 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Many methods were not considering the case of the element not having
siblings or children when inserting nodes, and thus broke in some
situations. This patch fixes that.

11:02 Changeset [43571] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-08 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Make is possible to mark a style property as important while setting
it. Also support the normal CSS property syntax "!important", while
accepting spaces between the ! and the important keyword.

10:56 Changeset [43570] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-08 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Working with Antonio Gomes.

Add support for finding the style property actually applied to the element.

10:16 Changeset [43569] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix for Windows nightlies.
Change link order to work around CFNetwork bug.

  • WebKit.vcproj/WebKit.vcproj:
09:21 Changeset [43568] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=25694
HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
to the document NULL ptr

Test: fast/parser/implicit-head-in-fragment-crash.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly create <head> when parsing a fragment.
08:58 Changeset [43567] by ariya@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Dimitri Glazkov.

Added Qt-specific expected result for toDataURL test, since Qt
does not support saving pixmaps to GIF.

  • platform/qt/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
08:54 Changeset [43566] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-12 Soren Gjesse <sgjesse@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25687
Missing check for valid function in V8 bindings for toString function for event listeners.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
05:42 Changeset [43565] by ariya@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

Added Qt-specific expected result for Canvas getImageData's test.

https://bugs.webkit.org/show_bug.cgi?id=22150

Since Qt is internally using premultiplied ARGB32 for doing
alpha-blending painting, reading the color back will not
necessarily give the same exact color.

  • platform/qt/Skipped: Excluded canvas-getImageData.
  • platform/qt/fast/canvas/canvas-getImageData-expected.txt: Added.
05:06 Changeset [43564] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Add glib-2.0 to the list of required package.

  • webkit.pc.in:
05:06 Changeset [43563] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Refactor use of CFLAGS, CXXFLAGS, LIBADD and LDFLAGS.

  • GNUmakefile.am:
05:05 Changeset [43562] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Define WTF_USE_JSC for the Gtk port.

  • wtf/Platform.h:
03:35 Changeset [43561] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • allow all of strictEqual to be inlined into cti_op_stricteq once again


We had this optimization once but accidentally lost it at some point.

  • runtime/Operations.h: (JSC::JSValue::strictEqualSlowCaseInline): (JSC::JSValue::strictEqual):
02:18 Changeset [43560] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-05-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

instanceof should throw if the constructor being tested does not implement
'HasInstance" (i.e. is a function). Instead we were returning false.

  • interpreter/Interpreter.cpp: (JSC::isInvalidParamForIn): (JSC::isInvalidParamForInstanceOf): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_instanceof):
  • tests/mozilla/ecma_2/instanceof/instanceof-003.js:

Fix broken test case.

  • tests/mozilla/ecma_2/instanceof/regress-7635.js:

Remove broken test case (was an exact duplicate of a test in instanceof-003.js).

LayoutTests:

2009-05-12 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Test was checked in with one test case disabled since it exposed an existing bug;
enable it now.

  • fast/js/instance-of-immediates-expected.txt:
  • fast/js/resources/instance-of-immediates.js:
01:58 Changeset [43559] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Improve function call forwarding performance

Reviewed by Gavin Barraclough

Make creation of the Arguments object occur lazily, so it
is not necessarily created for every function that references
it. Then add logic to Function.apply to allow it to avoid
allocating the Arguments object at all. Helps a lot with
the function forwarding/binding logic in jQuery, Prototype,
and numerous other JS libraries.

01:58 Changeset [43558] by ggaren@apple.com
  • 17 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <ggaren@apple.com>

Turned on the JIT and got it building and running the most trivial of
programs.


All configurable optimizations are turned off, and a few opcodes are ad
hoc #if'd out.


So far, I've only merged op_mov and op_end, but some stub-reliant
opcodes work as-is from TOT.


  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h:
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt): (JSC::JIT::emitInitRegister): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot): (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitLoadReturnValue): (JSC::JIT::emitStore): (JSC::JIT::emitStoreReturnValue):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_unexpected_load): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_throw): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_push_scope): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_instanceof):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_switch_imm):
  • jit/JITStubs.h:
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):
  • runtime/JSValue.h: (JSC::JSValue::payload):
  • wtf/Platform.h:

05/11/09:

23:45 Changeset [43557] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-07 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add some new MacroAssembler and assembler functions that will be needed shortly.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::neg32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::addl_rm): (JSC::X86Assembler::andl_mr): (JSC::X86Assembler::andl_rm): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::negl_r): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::orl_rm): (JSC::X86Assembler::orl_im): (JSC::X86Assembler::subl_rm): (JSC::X86Assembler::xorl_mr): (JSC::X86Assembler::xorl_rm): (JSC::X86Assembler::xorl_im): (JSC::X86Assembler::imull_mr):
23:41 Changeset [43556] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove the NumberHeap.

  • JavaScriptCore.exp:
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::heapAllocate): (JSC::Heap::markConservatively): (JSC::Heap::sweep): (JSC::Heap::collect): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::typeName): (JSC::Heap::isBusy):
  • runtime/Collector.h: (JSC::Heap::globalData):
  • runtime/JSCell.h:
23:35 Changeset [43555] by beidson@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Update my ChangeLog entry to make Mark Rowe happy. Mark Rowe - who is supposed to be on vacation. Mark Rowe - who probably didn't even get to watch House tonight. Oh, I see - that's why he's grumpy.

23:33 Changeset [43554] by ggaren@apple.com
  • 38 edits
    1 copy
    3 deletes in branches/nitro-extreme

JavaScriptCore:

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Land initial commit of new number representation for 32 bit platforms,
with JIT disabled.

  • API/APICast.h: (toJS): (toRef):
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): (JSC::::toNumber): (JSC::::toString):
  • API/tests/testapi.c: (EvilExceptionObject_convertToType):
  • AllInOneFile.cpp:
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::valueToSourceString):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitUnexpectedLoad): (JSC::keyForImmediateSwitch):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::privateExecute):
  • parser/Nodes.cpp: (JSC::ArrayNode::emitBytecode): (JSC::processClauseList):
  • runtime/ArgList.h:
  • runtime/Collector.h: (JSC::sizeof):
  • runtime/DateMath.cpp:
  • runtime/ExceptionHelpers.h:
  • runtime/InitializeThreading.cpp:
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSCell.cpp:
  • runtime/JSCell.h: (JSC::JSCell::isAPIValueWrapper): (JSC::JSValue::isString): (JSC::JSValue::isGetterSetter): (JSC::JSValue::isObject): (JSC::JSValue::getString): (JSC::JSValue::getObject): (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData): (JSC::JSValue::getUInt32): (JSC::JSValue::marked): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::toBoolean): (JSC::JSValue::toNumber): (JSC::JSValue::toString): (JSC::JSValue::needsThisConversion): (JSC::JSValue::toThisString): (JSC::JSValue::getJSNumber): (JSC::JSValue::toObject): (JSC::JSValue::toThisObject):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
  • runtime/JSImmediate.h:
  • runtime/JSNumberCell.cpp: Removed.
  • runtime/JSNumberCell.h: Removed.
  • runtime/JSObject.h: (JSC::JSValue::get): (JSC::JSValue::put):
  • runtime/JSString.h: (JSC::JSValue::toThisJSString):
  • runtime/JSValue.cpp: (JSC::JSValue::toInteger): (JSC::JSValue::toIntegerPreserveNaN): (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::toThisObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype): (JSC::JSValue::description): (JSC::nonInlineNaN):
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::EncodedJSValueHashTraits::emptyValue): (JSC::jsNaN): (JSC::operator==): (JSC::operator!=): (JSC::toInt32): (JSC::toUInt32): (JSC::JSValue::encode): (JSC::JSValue::decode): (JSC::JSValue::JSValue): (JSC::JSValue::operator bool): (JSC::JSValue::operator==): (JSC::JSValue::operator!=): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isCell): (JSC::JSValue::isInt32): (JSC::JSValue::isUInt32): (JSC::JSValue::isDouble): (JSC::JSValue::isTrue): (JSC::JSValue::isFalse): (JSC::JSValue::tag): (JSC::JSValue::asInt32): (JSC::JSValue::asUInt32): (JSC::JSValue::asDouble): (JSC::JSValue::asCell): (JSC::JSValue::isNumber): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::uncheckedGetNumber): (JSC::JSValue::toJSNumber): (JSC::JSValue::getNumber): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32):
  • runtime/Operations.h: (JSC::JSValue::equal): (JSC::JSValue::equalSlowCaseInline): (JSC::JSValue::strictEqual): (JSC::JSValue::strictEqualSlowCaseInline): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd):
  • runtime/PropertySlot.h:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncIndexOf):
  • wtf/Platform.h:

WebCore:

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Make WebCore compile with the new JS number representation.

  • ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
  • ForwardingHeaders/runtime/JSNumberCell.h: Removed.
  • bindings/js/ScriptEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
23:21 Changeset [43553] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Enable use of SamplingFlags directly from JIT code.

  • bytecode/SamplingTool.h:
  • jit/JIT.h: (JSC::JIT::sampleCodeBlock): (JSC::JIT::sampleInstruction):
  • jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag):
22:49 Changeset [43552] by beidson@apple.com
  • 1 edit
    3 copies
    1 add in trunk/LayoutTests

2009-05-11 Brady Eidson <beidson@apple.com>

Add a third copy of this test to make Tiger bots happy.

  • platform/mac-tiger/fast/images: Added.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
22:31 Changeset [43551] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2009-05-11 Gavin Barraclough <barraclough@apple.com>

Reviewed by Cameron Zwarich.

Implement JIT generation for instanceof for non-objects (always returns false).
Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.

0.5% progression on v8 tests overall, due to 3.5% on early-boyer.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • runtime/JSObject.cpp: (JSC::JSObject::hasInstance):
  • runtime/TypeInfo.h: (JSC::TypeInfo::TypeInfo):

LayoutTests:

2009-05-11 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add a layout test for instanceof.

  • fast/js/instance-of-immediates-expected.txt: Added.
  • fast/js/instance-of-immediates.html: Added.
  • fast/js/resources/instance-of-immediates.js: Added. (testInstanceOf): (): (testSet):
22:07 Changeset [43550] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-11 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Holger Freyther.

Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
Not doing that can cause assersion failure.
https://bugs.webkit.org/show_bug.cgi?id=25702

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::stop):
22:02 Changeset [43549] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Bug 25714: [Qt] Decouple HTML5 Database support from the
SQLite/generic database support in the Qt port

<https://bugs.webkit.org/show_bug.cgi?id=25714>

  • WebCore.pro:
21:37 Changeset [43548] by weinig@apple.com
  • 1 copy in branches/nitro-extreme

Create a new nitro-extreme branch

21:35 Changeset [43547] by weinig@apple.com
  • 1 move in branches/nitro-extreme-old

Move asside nitro-extreme branch

21:34 Changeset [43546] by weinig@apple.com
  • 1 delete in branches/nitro-extreme-rebase-1

Remove branch created in error

21:32 Changeset [43545] by weinig@apple.com
  • 1 copy in branches/nitro-extreme-rebase-1

Create new branch for rebasing

21:28 Changeset [43544] by mitz@apple.com
  • 44 edits in trunk/LayoutTests

Updated the svn:mime-type property of recently-updated PNG files to image/png

21:20 Changeset [43543] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


A little more JIT refactoring.


Rearranged code to more clearly indicate what's conditionally compiled
and why. Now, all shared code is at the top of our JIT files, and all
#if'd code is at the bottom. #if'd code is delineated by large comments.


Moved functions that relate to the JIT but don't explicitly do codegen
into JIT.cpp. Refactored SSE2 check to store its result as a data member
in the JIT.

  • jit/JIT.cpp: (JSC::isSSE2Present): (JSC::JIT::JIT): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
  • jit/JIT.h: (JSC::JIT::isSSE2Present):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase):
21:18 Changeset [43542] by beidson@apple.com
  • 3 edits
    5 copies
    4 adds in trunk/LayoutTests

2009-05-11 Brady Eidson <beidson@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6876226> - Cleanup the fast/images/favicon situation a bit.

First off, copy fast/images/favicon-as-image.html over to http/tests/misc so it covers the original test case on all Mac platforms.
Second, add Leopard-specific results for the original test.
Then, remove it from the Leopard skipped list.
Finally, add it to the SnowLeopard skipped list (<rdar://problem/6877633> covers re-enabling it when we're no longer blocked).

  • http/tests/misc/favicon-as-image.html: Copied from fast/images/favicon-as-image.html.
  • http/tests/misc/resources/favicon.ico: Copied from fast/images/resources/favicon.ico.
  • platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Added.
  • platform/mac/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/mac-leopard/fast/images: Added.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
20:25 Changeset [43541] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix. Build JITOpcodes.cpp to resolve linking errors

19:31 Changeset [43540] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Disable layouttest that requires an AccessibilityController

DRT/GTK+ lacks an AccessibilityController do not run the
accessibility/onclick-handlers.thtml test.

  • platform/gtk/Skipped:
18:52 Changeset [43539] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

More re-factoring of JIT code generation. Use a macro to
forward the main switch-statement cases to the helper functions.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
18:50 Changeset [43538] by cfleizach@apple.com
  • 3 edits
    2 adds in trunk

Bug 25713: AX: Control Elements not identified in HTML content
https://bugs.webkit.org/show_bug.cgi?id=25713

18:40 Changeset [43537] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

More re-factoring of JIT code generation to move opcode generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch covers the remaining
slow cases.

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
18:33 Changeset [43536] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • GNUmakefile.am: Added JITOpcodes.cpp and JITStubCall.h to the project.
18:30 Changeset [43535] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JITOpcodes.cpp and JITStubCall.h to the project.
18:26 Changeset [43534] by ggaren@apple.com
  • 9 edits
    1 copy in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Some JIT refactoring.


Moved JITStubCall* into its own header.


Modified JITStubCall to ASSERT that its return value is handled correctly.
Also, replaced function template with explicit instantiations to resolve
some confusion.


Replaced all uses of emit{Get,Put}CTIArgument with explicit peeks, pokes,
and calls to killLastResultRegister().

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITCall.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITPropertyAccess.cpp:
  • jit/JITStubCall.h: Copied from jit/JIT.h. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::):
18:25 Changeset [43533] by darin@apple.com
  • 4 edits in trunk

WebCore:

2009-05-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Check startPos for null, not just currPos.

LayoutTests:

2009-05-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body

  • editing/text-iterator/basic-iteration-expected.txt: Expect success, not failure.
18:09 Changeset [43532] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
https://bugs.webkit.org/show_bug.cgi?id=25700

18:06 Changeset [43531] by weinig@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Start re-factoring JIT code generation to move op_code generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch only covers the main
pass and all the arithmetic opcodes in the slow path.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
  • jit/JITPropertyAccess.cpp:
17:48 Changeset [43530] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-11 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25697
[GTK] Warnings building WebKit/gtk/tests/testwebframe.c

  • tests/testwebframe.c: (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget* to fix pointer type incompatibility warnings.
17:28 Changeset [43529] by kov@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Enable the new passing test, and skip two new failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/css/compare-content-style-expected.txt: Added.
17:14 Changeset [43528] by ddkilzer@apple.com
  • 54 edits in trunk/WebCore

Bug 25087: Test for ENABLE_FOO macros consistently in IDL files

<https://bugs.webkit.org/show_bug.cgi?id=25087>

Reviewed by Timothy Hatcher.

Change tests for ENABLE macros to check for both existence and
value:

Negative: #if !defined(ENABLE_FOO)
!ENABLE_FOO
  • Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
  • css/CSSCharsetRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/RGBColor.idl:
  • dom/Attr.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Range.idl:
  • dom/RangeException.idl:
  • dom/WheelEvent.idl:
  • html/CanvasPixelArray.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/ImageData.idl:
  • inspector/InspectorController.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/Coordinates.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/Geoposition.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGException.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
17:03 Changeset [43527] by darin@apple.com
  • 2 edits in trunk

Added missing bug titles and URLs.

17:01 Changeset [43526] by darin@apple.com
  • 11 edits in trunk

WebCore:

2009-05-11 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

class/struct mix-up in forward declarations

  • inspector/InspectorResource.h:
  • loader/CachedFont.h:
  • loader/appcache/ApplicationCache.h:
  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineTextBox.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:

WebKit/qt:

2009-05-11 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

class/struct mix-up in forward declarations

  • Api/qwebpage.h:
16:57 Changeset [43525] by sfalken@apple.com
  • 93 edits in tags/Safari-6530.9.1/JavaScriptCore

Merge r43520.

16:57 Changeset [43524] by sfalken@apple.com
  • 2 edits
    2 copies in tags/Safari-6530.9.1/SunSpider

Merge r43519.

16:54 Changeset [43523] by darin@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

The Symbian tools can't compile and link this without this include.
It's not clear why this is different from other toolsets or why it affects
only this header file, but adding the include for now.

  • editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
16:35 Changeset [43522] by alice.liu@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2009-05-11 Alice Liu <alice.liu@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

Test: fast/forms/search-styled.html

  • css/themeWin.css: Remove the overriding of -webkit-appearance for searchfields. This will cause background images to not be honored when styling searchfields
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSearchFieldStyle):
  • rendering/RenderThemeWin.h: Re-instate final adjustments to searchfield styling that were removed in r42020

LayoutTests:

2009-05-11 Alice Liu <alice.liu@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

  • fast/forms/search-styled.html: Added.
  • platform/mac/fast/forms/search-styled-expected.txt: Added.
  • platform/win/fast/forms/search-styled-expected.txt: Added.
16:33 Changeset [43521] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.1

New tag.

16:02 Changeset [43520] by sfalken@apple.com
  • 7 edits in trunk/JavaScriptCore

Re-add experimental PGO configs.


Reviewed by Adam Roben.

15:54 Changeset [43519] by sfalken@apple.com
  • 1 edit
    2 adds in trunk/SunSpider

Include SunSpider tests in production builds.


Reviewed by Adam Roben.

  • SunSpider.make: Added.
  • xcopy.excludes: Added.
15:00 Changeset [43518] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
15:00 Changeset [43517] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-11 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25626
Update V8ElementCustom.cpp to match the current API of Node.

  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names. (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
14:49 Changeset [43516] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "1" Garen.

Rip out the !USE(CTI_REPATCH_PIC) code. It was untested and unused.

  • jit/JIT.h: (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compileCTIMachineTrampolines):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID):
14:49 Changeset [43515] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::WebCoreSynchronousLoader::load):
14:36 Changeset [43514] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
14:35 Changeset [43513] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-11 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

V8CustomBinding.cpp is missing a header file

https://bugs.webkit.org/show_bug.cgi?id=25644

  • bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
14:30 Changeset [43512] by dglazkov@chromium.org
  • 4 edits in trunk/WebCore

2009-05-11 Aaron Boodman <aa@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25634
Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().

Also, change instances of ScriptController::retrieveActiveFrame() to
V8::retrieveFrameForEnteredContext() for consistency.

See http://codereview.chromium.org/113085 for the corresponding Chromium change.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
14:06 Changeset [43511] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2009-05-11 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.

First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".

  • platform/MIMETypeRegistry.cpp: (WebCore::defaultMIMEType): "application/octet-stream"
  • platform/MIMETypeRegistry.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which might override it to false. (WebCore::ResourceHandle::shouldContentSniffURL): Return false for file:// urls, true for everything else.
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead of null. (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type. (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if it hasn't been set up yet. (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by the new mechanism.

LayoutTests:

2009-05-11 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

  • platform/mac-leopard/Skipped: Skip fast/images/favicon-as-image.html until we can come up with a better solution to its new failure.
13:37 Changeset [43510] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Dmitry Titov <dimich@chromium.org>

GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.

  • wtf/ThreadingPthreads.cpp: added #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().
13:34 Changeset [43509] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"

This was added in r39816 to disable dynamic entries. They are
still disabled after fixing the typo since this feature define
is never set anywhere.

  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • loader/appcache/DOMApplicationCache.idl:
13:28 Changeset [43508] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix for newer versions of GCC

  • wtf/ThreadingPthreads.cpp: Added a declaration of waitForThreadCompletion before its definition to silence a warning.
12:49 Changeset [43507] by dimich@chromium.org
  • 23 edits in trunk

JavaScriptCore:

2009-05-11 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

  • wtf/Threading.h: (WTF::ThreadIdentifier::ThreadIdentifier): (WTF::ThreadIdentifier::isValid): (WTF::ThreadIdentifier::invalidate): (WTF::ThreadIdentifier::platformId): ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and methods that are used across the code on thread ids: construction, comparisons, check for 'valid' state etc. '0' is used as invalid id, which happens to just work with all platform-specific thread id implementations.

All the following files repeatedly reflect the new ThreadIdentifier for each platform.
We remove ThreadMap and threadMapMutex from all of them, remove the functions that
populated/searched/cleared the map and add platform-specific comparison operators
for ThreadIdentifier.

There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
public build uses WTF threading functions with old type of ThreadingIdentifier.
The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
functions so the deprecated ones can be removed.

  • wtf/gtk/ThreadingGtk.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/ThreadingNone.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=):
  • wtf/ThreadingPthreads.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread): (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac. Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t. This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t. This function will be removed as soon as Safari 4 will release next public build.
  • wtf/qt/ThreadingQt.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/ThreadingWin.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): All the platforms (except Windows) used a sequential counter as a thread ID and mapped it into platform ID. Windows was using native thread id and mapped it into thread handle. Since we can always obtain a thread handle by thread id, createThread now closes the handle. (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle, it means the thread already exited. (WTF::detachThread): (WTF::currentThread): (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now). (WTF::waitForThreadCompletionDeprecated): same. (WTF::currentThreadDeprecated): same. (WTF::createThreadDeprecated): same.
  • bytecode/SamplingTool.h:
  • bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
  • JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions since they now take a different type as a parameter.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.

WebCore:

2009-05-11 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

Most of the change is in WTF.
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
is now a class rather then an integer.
Also, there is no need to initialize threadID in constructors to 0 now.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id, since now ThreadIdentifier needs construction and we avoid having global initializers. (WebCore::matchFunc): use the new accessor function. (WebCore::openFunc): ditto. (WebCore::createStringParser): ditto. (WebCore::createMemoryParser): ditto.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::start): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):

WebKit/win:

2009-05-11 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

Most of the change is in WTF and WebCore.

  • WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones. Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones can be removed.
  • WebKit.vcproj/WebKit_debug.def: same.
11:54 Changeset [43506] by darin@apple.com
  • 4 edits
    3 adds in trunk

JavaScriptCore:

2009-05-11 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069

I missed this case back a year ago when I sped up handling
of JavaScript wrappers. Easy to fix.

  • runtime/JSObject.h: (JSC::JSValue::get): Return the prototype itself if the property name is proto.
  • runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot): Ditto.

LayoutTests:

2009-05-11 Darin Adler <darin@apple.com>

Reviewed by Oliver Hunt.

Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069

  • fast/js/prototypes-expected.txt: Added.
  • fast/js/prototypes.html: Added.
  • fast/js/resources/prototypes.js: Added.
11:37 S60Reindeer edited by aozoren@gmail.com
BUG REPORT? (diff)
11:05 Changeset [43505] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr

Reviewed by Maciej Stachowiak

10:41 Changeset [43504] by weinig@apple.com
  • 80 edits in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Roll out improperly merged strcat code.

10:28 Changeset [43503] by beidson@apple.com
  • 3 edits
    1 delete in trunk/WebCore

2009-05-11 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Remove unused header that declared one function which was never defined anywhere.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means platform/network/cf/ResourceResponse.h)
  • platform/network/cf/ResourceResponseCFNet.h: Removed.
10:24 Changeset [43502] by weinig@apple.com
  • 57 edits
    1 delete in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <sam@webkit.org>

Roll out improperly merged native function thunk code.

10:06 Changeset [43501] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Added webarchive/test-link-rel-icon.html to gtk Skipped list

  • platform/gtk/Skipped: Added webarchive/test-link-rel-icon.html.
10:00 Changeset [43500] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-11 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=25213
Fix assert during Inspector destruction.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Moved closing

inspector above removing InspectorController object to fix JS errors,
added clearing inspector page ptr.

09:44 Changeset [43499] by ddkilzer@apple.com
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots

<https://bugs.webkit.org/show_bug.cgi?id=23331>

Reviewed by Brady Eidson.

  • webarchive/test-link-rel-icon-expected.webarchive: Updated results after removing workaround in the test.
  • webarchive/test-link-rel-icon.html: Copied from webarchive/test-link-rel-icon.html-disabled. Removed workaround for Bug 21026 / <rdar://problem/6240826>.
  • webarchive/test-link-rel-icon.html-disabled: Removed.
09:41 EFLWebKit edited by kenneth.christiansen@gmail.com
(diff)
09:41 EFLWebKit edited by kenneth.christiansen@gmail.com
(diff)
09:41 EFLWebKit created by kenneth.christiansen@gmail.com
09:35 WikiStart edited by kenneth.christiansen@gmail.com
(diff)
09:22 Changeset [43498] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix, build ParserArena.cpp

09:22 Changeset [43497] by zecke@webkit.org
  • 4 edits in trunk

WebCore
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Make sure that public APIs are properly exported on all Qt platforms
https://bugs.webkit.org/show_bug.cgi?id=25601

  • WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win

WebKitTools
2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

[Qt] Make sure that public APIs are properly exported on all Qt platforms
https://bugs.webkit.org/show_bug.cgi?id=25601

  • Scripts/webkitdirs.pm: Remove QT_SHARED define from Qt builds, define QT_MAKEDLL in WebCore.pro instead
09:22 Changeset [43496] by zecke@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

Fix Qt build when ENABLE_DATABASE is turned off

https://bugs.webkit.org/show_bug.cgi?id=25587

  • Api/qwebdatabase.cpp: (QWebDatabase::displayName): (QWebDatabase::expectedSize): (QWebDatabase::size): (QWebDatabase::fileName): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase_p.h:
  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::allOrigins): (QWebSecurityOrigin::databases):
09:22 Changeset [43495] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24536

Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
unless Profile.h is included.

  • profiler/ProfileGenerator.h:
09:21 Changeset [43494] by zecke@webkit.org
  • 5 edits in trunk

JavaScriptCore
2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24284

  • JavaScriptCore.pri: coding style modified
  • jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES

WebCore
2009-05-11 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24284

  • WebCore.pro: duplicated values removed from INCLUDEPATH
09:21 Changeset [43493] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-05-11 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
https://bugs.webkit.org/show_bug.cgi?id=24688

  • WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
  • platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
09:10 Changeset [43492] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-05-11 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Fix failure seen on most of the buildbots.

  • fast/forms/text-control-intrinsic-widths-expected.txt: Rolled back to the version before Hyatt's recent intrinsic margin check-in. According to Dan, that should not have had any effect on this test, so these results reflect some other sort of difference on Hyatt's computer.
08:17 Changeset [43491] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by NOBODY (build fix).

Also add ParserArena, in addition to AllInOne, for release builds,
since adding it to AllInOne breaks Mac.

  • GNUmakefile.am:
07:55 Changeset [43490] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Adding ParserArena to the autotools build.

  • GNUmakefile.am:
07:50 Changeset [43489] by aroben@apple.com
  • 3 edits in trunk/JavaScriptCore

More Windows build fixes after r43479

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Export ParserArena::reset.
07:36 Changeset [43488] by aroben@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fixes after r43479

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added ParserArena to the project.
  • parser/NodeConstructors.h: Added a missing include. (JSC::ParserArenaDeletable::operator new): Marked these as inline.
06:57 Changeset [43487] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-05-11 Anton Shestakov <engored@ya.ru>

Rubber-stamped by Gustavo Noronha.

New Russian translation.

  • ru.po: Added.
03:55 Changeset [43486] by jmalonzo@webkit.org
  • 5 edits in trunk/JavaScriptCore

Revert "2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>"

This reverts commit r43485 as it fails the mac bots.

03:34 Changeset [43485] by jmalonzo@webkit.org
  • 5 edits in trunk/JavaScriptCore

2009-05-11 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by NOBODY (BuildFix).

Add ParserArena to AllInOneFile as well as gtk, qt and wx build
scripts.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCoreSources.bkl:
00:06 Changeset [43484] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added unary slow cases.


Fixed a macro-related bug that cased unary postfix ops always to be
noops in codegen.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
Note: See TracTimeline for information about the timeline view.