Timeline
May 18, 2009:
- 11:06 PM Changeset in webkit [43855] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Gavin Barraclough.
- for polymorphic prototype lookups, increase the number of slots from 4 to 8
~4% faster on v8 raytrace benchmark
- bytecode/Instruction.h:
- 10:39 PM Changeset in webkit [43854] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver Hunt.
- tighten up the code for the load_varargs stub
~1-2% on v8-raytrace
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that the compiler didn't feel like hoisting for us. Remove unneeded exception check.
- 10:17 PM Changeset in webkit [43853] by
-
- 2 edits in trunk/LayoutTests
Added cookie test to Skipped list for Windows
See Bug 25861. <https://bugs.webkit.org/show_bug.cgi?id=25861>
- platform/win/Skipped: Added http/tests/cookies/simple-cookies-expired.html.
- 10:02 PM Changeset in webkit [43852] by
-
- 2 edits in trunk/WebCore
Tiger build fix for r43850
- platform/mac/ClipboardMac.mm: Added typedef for NSUinteger when building on Tiger.
- 9:52 PM Changeset in webkit [43851] by
-
- 4 edits18 adds in trunk
Bug 24569: Add some cookies tests
LayoutTests:
Reviewed and tweaked by David Kilzer.
This modification adds a cookie framework to check setting cookies.
It is a simple modification over the js test framework. It uses some XHRs and custom server-side script
to set / get / clear cookies.
It also adds some very basic tests to check that everything works.
- http/tests/cookies: Added.
- http/tests/cookies/multiple-cookies-expected.txt: Added.
- http/tests/cookies/multiple-cookies.html: Added.
- http/tests/cookies/resources: Added.
- http/tests/cookies/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
- http/tests/cookies/resources/clearCookies.cgi: Added.
- http/tests/cookies/resources/cookies-test-post.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
- http/tests/cookies/resources/cookies-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js. (setCookies): Internal method to set a cookie (multiple cookies are not supported). (testCookies): Internal method to check if the cookie were set.
(clearAllCookies): Used to clear all pre-existing cookies for this domain.
(clearCookies): Used to clear the cookies set with cookiesShouldBe.
(cookiesShouldBe): Used to set a cookie and check the "Cookie" header sent. It is inspired from shouldBe from the js test framework.
- http/tests/cookies/resources/cookies-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
- http/tests/cookies/resources/getCookies.cgi: Added.
- http/tests/cookies/resources/multiple-cookies.js: Added.
- http/tests/cookies/resources/setCookies.cgi: Added.
- http/tests/cookies/resources/simple-cookies-expired.js: Added.
- http/tests/cookies/resources/simple-cookies-max-age.js: Added.
- http/tests/cookies/simple-cookies-expired-expected.txt: Added.
- http/tests/cookies/simple-cookies-expired.html: Added.
- http/tests/cookies/simple-cookies-max-age-expected.txt: Added.
- http/tests/cookies/simple-cookies-max-age.html: Added.
- platform/mac-tiger/Skipped: Added http/tests/cookies/simple-cookies-max-age.html since CFNetwork on Tiger doesn't support expiring cookies with Max-Age=0.
WebKitTools:
Patch by David Kilzer.
- Scripts/make-js-test-wrappers: Added regex to skip cookies-test-(post|pre).js files.
- 9:17 PM Changeset in webkit [43850] by
-
- 2 edits in trunk/WebCore
2009-05-17 Eric Seidel <eric@webkit.org>
Reviewed by Darin Adler.
ClipboardMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=25847
I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.
No functional changes, so no tests.
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::clearData): (WebCore::absoluteURLsFromPasteboardFilenames): Broke out logic for filenames into its own function to make the caller more readable. (WebCore::absoluteURLsFromPasteboard): Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray so that we can use -[NSArray componentsJoinedByString] in the caller (which is cleaner than the manual "\n" addition before). This also access to the full list of file urls for future callers. (WebCore::ClipboardMac::getData): unsigned count = (type == "URL") ? 1 : [fileList count]; is now an explicit check for "URL", before it was a check for != "text/uri-list" which was much more confusing in my opinion. text/uri-list and URL are the only two types which map to NSURLPboardType in cocoaTypeFromMIMEType(). (WebCore::ClipboardMac::types): I removed an extra if (!types) check, right before [types count]. In Obj-C messaging nil will return 0 (size of a pointer), so it's safe to message nil here and expect it to return 0.
- 8:40 PM Changeset in webkit [43849] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-18 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff Garen.
- Improve code generation for access to prototype properties
~0.4% speedup on SunSpider.
Based on a suggestion from Geoff Garen.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 8:23 PM Changeset in webkit [43848] by
-
- 4 edits in trunk/WebKit
WebKit/mac:
2009-05-18 Sam Weinig <sam@webkit.org>
<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent
Add user agent hack for pointroll.com.
Reviewed by Steve Falkenburg.
- WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):
WebKit/win:
2009-05-18 Steve Falkenburg <sfalken@apple.com>
<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent
Add user agent hack for pointroll.com.
Reviewed by Sam Weinig.
- WebView.cpp:
- 5:42 PM Changeset in webkit [43847] by
-
- 1 edit2 adds in trunk/WebCore
2009-05-18 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859
- bindings/v8/ScriptController.cpp: Added.
- bindings/v8/ScriptController.h: Added.
- 5:27 PM Changeset in webkit [43846] by
-
- 5 edits in trunk
2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Gavin Barraclough.
Enable YARR, and disable WREC for GTK+.
- configure.ac:
- 5:10 PM Changeset in webkit [43845] by
-
- 4 edits in trunk/WebCore
2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
Change ScriptElement to support XHTMLMP in a better way
- 5:00 PM Changeset in webkit [43844] by
-
- 4 edits in trunk
wx build fix. Use python-config to get Python linking info on Unix OSes.
- 4:51 PM Changeset in webkit [43843] by
-
- 2 edits in trunk/WebCore
wx build fix, finish up changes after the accessibility dir split.
- 4:48 PM Changeset in webkit [43842] by
-
- 16 edits2 adds in trunk/WebCore
2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos (and others).
Add XHTMLMP support to Webkit
XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
functionality. Most of the functionalities have already been implemented by Webkit.
The changes include:
1) Adding <noscript> support
2) Document conformance validation
3) User Agent conformance validation
- 3:35 PM Changeset in webkit [43841] by
-
- 2 edits in trunk/WebCore
Fix the build.
- WebCore.xcodeproj/project.pbxproj:
- 1:40 PM Changeset in webkit [43840] by
-
- 2 edits in trunk/WebCore
2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Rubber-stamped by Gustavo Noronha.
Fixed build for the Qt port by adding the WebCore/accessibility
directory to the includepath.
- WebCore.pro:
- 1:22 PM Changeset in webkit [43839] by
-
- 17 edits in trunk/JavaScriptCore
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.
- GNUmakefile.am:
- 1:12 PM Changeset in webkit [43838] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-18 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (speculative build fix).
- JavaScriptCore.xcodeproj/project.pbxproj:
- 12:46 PM Changeset in webkit [43837] by
-
- 16 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.
Rationalization of all this:
- Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
- Change the JIT & Yarr to internally handle code using CodeRefs.
- Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
- Remove the (now) redundant code pointer from FunctionBodyNode.
While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
- parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
- parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
- 12:11 PM Changeset in webkit [43836] by
-
- 2 edits in trunk/WebKitTools
wx build fix, initialize variable that doesn't get set on Windows.
- 12:10 PM Changeset in webkit [43835] by
-
- 2 edits in trunk/WebCore
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776
Speculative fix for windows build failure.
- 11:59 AM Changeset in webkit [43834] by
-
- 8 edits2 adds in trunk
Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon
Reviewed by Darin Adler.
WebCore:
Test: http/tests/misc/favicon-as-image.html
- inspector/front-end/inspector.js: Added image/vnd.microsoft.icon to WebInspector.MIMETypes.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): Added image/vnd.microsoft.icon to list of supported image and image resource MIME types.
LayoutTests:
Updated existing favicon-as-image.html test to display a third
image having MIME type image/vnd.microsoft.icon.
- http/tests/misc/favicon-as-image.html: Updated.
- http/tests/misc/resources/.htaccess: Added.
- http/tests/misc/resources/favicon-vnd-ms.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
- platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Updated.
- platform/mac/http/tests/misc/favicon-as-image-expected.png: Updated.
- platform/mac/http/tests/misc/favicon-as-image-expected.txt: Updated.
- 11:48 AM Changeset in webkit [43833] by
-
- 6 edits46 moves7 adds in trunk/WebCore
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776
- 10:26 AM Changeset in webkit [43832] by
-
- 2 edits in trunk/WebCore
2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25854
[GTK] Should tell servers we only support identity as content encoding
Let servers know we only support identity as content
encoding. We will implement this in libsoup.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
- 8:30 AM Changeset in webkit [43831] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
CAPTCHA failure.
The problem was that after loading and displaying a CAPTCHA image, it was loaded from
the server again due to preloading. So, the server expected the last loaded (invisible)
CAPTCHA text to be typed and posted back.
I don't know how to make tests for preloading.
- loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason to preload after loading for real - and if cache policy is CachePolicyReload, that actually results in another load from network layer.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy() to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
- 7:13 AM Changeset in webkit [43830] by
-
- 2 edits in trunk/WebCore
2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
[Qt] Reuse FontPlatformData for the same FontDescription.
This effectively prevents growing heap usage for loading every web page.
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::qHash): Necessary for FontPlatformDataCache. (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if it exists, otherwise create a new one and insert it in the cache.
- 5:11 AM Changeset in webkit [43829] by
-
- 2 edits in trunk/WebKit/qt
2009-05-18 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
Makes QtLauncher to accept multiple urls in command line and opens these in separate windows.
- QtLauncher/main.cpp: (MainWindow::newWindow): (main):
- 4:33 AM Changeset in webkit [43828] by
-
- 2 edits in trunk/WebCore
2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Fix the leak in FontFallbackList::fontDataAt() function.
When creating a new instance of SimpleFontData, put it in the font list
so that it can deleted later on.
- platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
- 4:30 AM Changeset in webkit [43827] by
-
- 2 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add support for running unit tests. Also run the tests whenever
the 'check' target runs.
- GNUmakefile.am:
- 4:30 AM Changeset in webkit [43826] by
-
- 4 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Style fixes
- GNUmakefile.am:
- WebCore/GNUmakefile.am
- 4:30 AM Changeset in webkit [43825] by
-
- 6 edits in trunk
2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.
- GNUmakefile.am:
- JavaScriptCore/GNUmakefile.am:
- WebKitTools/GNUmakefile.am:
- 4:30 AM Changeset in webkit [43824] by
-
- 4 edits in trunk
2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Add JavaScriptCore/ to JSC include path only since it's not
required when building WebCore.
- GNUmakefile.am:
2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor library cflags
- GNUmakefile.am:
- 4:11 AM Changeset in webkit [43823] by
-
- 2 edits in trunk/LayoutTests
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
Skip new tests from r43822 on Gtk
https://bugs.webkit.org/show_bug.cgi?id=25780
- platform/gtk/Skipped:
- 3:55 AM Changeset in webkit [43822] by
-
- 1 edit6 adds in trunk/LayoutTests
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Oliver Hunt.
Add missing files from r43821
https://bugs.webkit.org/show_bug.cgi?id=25780
- editing/pasteboard/get-data-text-plain-drop-expected.txt: Added.
- editing/pasteboard/get-data-text-plain-drop.html: Added.
- editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
- editing/pasteboard/get-data-text-plain-paste.html: Added.
- editing/pasteboard/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
- editing/pasteboard/resources/get-data-text-plain-paste.js: Added. (handlePaste):
- 3:29 AM Changeset in webkit [43821] by
-
- 5 edits in trunk
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
- Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
- 3:11 AM Changeset in webkit [43820] by
-
- 2 edits in trunk/WebKitTools
2009-05-18 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
- Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
May 17, 2009:
- 10:24 PM Changeset in webkit [43819] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-17 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unneeded ExecState parameter from the number JSValue constructors.
- runtime/JSValue.h: (JSC::jsNumber): (JSC::jsNaN): (JSC::JSValue::JSValue):
- 6:20 PM Changeset in webkit [43818] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 5:31 PM Changeset in webkit [43817] by
-
- 90 edits1 move in trunk/LayoutTests
Reviewed by David Kilzer.
- move fast/repaint/repaint.js into the resources subdirectory
- fast/repaint/repaint.js: Removed.
- fast/repaint/resources/repaint.js: Copied from fast/repaint/repaint.js.
- (89 tests changed to load the script from the new location)
- 1:11 PM Changeset in webkit [43816] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for WML: constr->const
- 1:06 PM Changeset in webkit [43815] by
-
- 2 edits1 add in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Fix done by Simon Fraser (reviewed by me).
<rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
transitions has bad layout and overlapping garbled text when printing
- manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
- page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
- 12:12 PM Changeset in webkit [43814] by
-
- 2 edits1 add in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Reviewed by Simon Fraser.
<rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
- manual-tests/select-option-in-onload.html: Added.
- 11:34 AM Changeset in webkit [43813] by
-
- 2 edits in trunk/WebCore
2009-05-17 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson
Rename local variables for readability.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
- 10:50 AM Changeset in webkit [43812] by
-
- 2 edits in trunk/LayoutTests
2009-05-17 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Disable another media test that seems to be failing at least intermittently.
- 10:47 AM Changeset in webkit [43811] by
-
- 4 edits in trunk/WebCore
2009-05-17 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
Bug 25840: fix some warnings seen on the GTK bot
https://bugs.webkit.org/show_bug.cgi?id=25840
- platform/ScrollView.cpp: (WebCore::ScrollView::platformScrollbarModes): Initialize results here. This is really just to quiet warnings. I think this code is unreachable. Someone could put ASSERT_NOT_REACHED() in here too at some point.
- plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Use proper printf format for int here, %d, not %lu. This could cause a real problem when compiled 64-bit, so it's good to fix.
- rendering/RenderTextControl.cpp: (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is really just to quiet the warning, but still seems like a good idea.
- 9:50 AM Changeset in webkit [43810] by
-
- 3 edits in trunk/WebCore
2009-05-17 Chris Fleizach <Chris Fleizach>
Reviewed by Darin Adler.
Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769
- page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::columnCount): Get rid of excess const. (WebCore::AccessibilityTable::rowCount): Ditto.
- page/AccessibilityTable.h: Ditto.
- 9:47 AM Changeset in webkit [43809] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-17 Kai Brüning <kai@granus.net>
Reviewed by Darin Adler.
bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822
Test: fast/dom/Node/normalize.html
- dom/Node.cpp: (WebCore::Node::normalize): Changed to remove any empty text nodes.
LayoutTests:
2009-05-17 Kai Brüning <kai@granus.net>
Reviewed by Darin Adler.
Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822
The test case strives to test the whole functionality of Node's normalize().
- fast/dom/Node/normalize-expected.txt: Added.
- fast/dom/Node/normalize.html: Added.
May 16, 2009:
- 8:44 PM Changeset in webkit [43808] by
-
- 4 edits in trunk/WebCore
2009-05-16 Dave Moore <davemoore@google.com>
Reviewed by Darin Adler.
Allow Strings to be created with one malloc node with no copying
https://bugs.webkit.org/show_bug.cgi?id=25779
Add new methods to String and StringImpl, refactoring existing
methods in StringImpl to use new createUninitialized() method.
- platform/text/PlatformString.h: (WebCore::String::createUninitialized):
- platform/text/StringImpl.cpp: (WebCore::StringImpl::createUninitialized): (WebCore::StringImpl::create):
- platform/text/StringImpl.h:
- 8:38 PM Changeset in webkit [43807] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance
Reviewed by Darin Adler.
Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.
This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- 2:51 PM Changeset in webkit [43806] by
-
- 4 edits in trunk/WebKit
WebKit:
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Dan Bernstein.
Fix <rdar://problem/6889644>.
- English.lproj/Localizable.strings:
WebKit/mac:
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig and Dan Bernstein.
Fix <rdar://problem/6889644>
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
- 1:21 PM Changeset in webkit [43805] by
-
- 9 edits in trunk/LayoutTests/platform/mac
Set the svn:mime-type property of recently-added PNG files to image/png
- 1:06 PM Changeset in webkit [43804] by
-
- 2 edits in trunk/WebKit/mac
- revert an accidental change from r43802.
- WebInspector/WebInspector.mm:
- 12:58 PM Changeset in webkit [43803] by
-
- 2 edits in trunk/WebKit/mac
2009-05-16 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page
Fix logic. The plug-in returns true if it handled the event.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
- 12:56 PM Changeset in webkit [43802] by
-
- 7 edits2 adds in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
Test: platform/mac/editing/pasteboard/text-precomposed.html
Ensure that "text/plain" data retrieved from the clipboard is always
precomposed. This makes Clipboard::getData() and
Pasteboard::documentFragment() consistent with Pasteboard::plainText()
and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].
- platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):
WebKit/mac:
Reviewed by Alexey Proskuryakov.
- fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
- WebView/WebHTMLView.mm: (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text. This is consistent with -_documentFragmentFromPasteboard:forType:inContext:subresources:.
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test for <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
- platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
- platform/mac/editing/pasteboard/text-precomposed.html: Added.
- 2:11 AM Changeset in webkit [43801] by
-
- 4 edits in trunk
[GTK] Merge r41819 into Gtk to log through the JS console
https://bugs.webkit.org/show_bug.cgi?id=25787
Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.
- 2:10 AM Changeset in webkit [43800] by
-
- 4 edits in trunk
[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html
WebKitTools:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
Forward port r39877 from main.c of OSX to TestNetscapePlugin
of Gtk.
- DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):
LayoutTests:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Jan Michael Alonzo.
Enable plugins/npruntime.html
- platform/gtk/Skipped:
- 12:56 AM Changeset in webkit [43799] by
-
- 2 edits in trunk/WebCore
Build fix.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily): Declare valueForFamily as static.
May 15, 2009:
- 11:57 PM Changeset in webkit [43798] by
-
- 5 edits in trunk/LayoutTests
2009-05-15 Darin Adler <Darin Adler>
Fix some failures from recent changes.
- platform/gtk/Skipped: Added recently-added test to the "no expected results" section.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- svg/css/getComputedStyle-basic-expected.txt: Ditto.
- 11:06 PM Changeset in webkit [43797] by
-
- 7 edits2 adds in trunk
WebCore:
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list
Test: fast/css/getComputedStyle/computed-style-font-family.html
- css/CSSComputedStyleDeclaration.cpp: Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak. (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers. (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family property as specified in the CSS standard. Fixed clip to return "auto" when there is no clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties internal linkage since there was no reason for them to have external linkage.
LayoutTests:
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list
- fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
- fast/css/getComputedStyle/computed-style-font-family.html: Added.
- fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump that are not visible when iterating the computed style object. Removed pointless unused array of unimplemented properties.
- fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- 7:17 PM Changeset in webkit [43796] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
Plug memory leak.
- webkit/webkitwebsettings.cpp: (free_spell_checking_language): (webkit_web_settings_finalize): (webkit_web_settings_set_property):
- 6:06 PM Changeset in webkit [43795] by
-
- 5 edits2 adds in trunk
WebCore:
2009-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Append instead of throwing when insertItemBefore gets an out-of-bound
index.
Test: svg/dom/svglist-insertItemBefore-appends.html
- svg/SVGList.h: (WebCore::SVGList::insertItemBefore):
LayoutTests:
2009-05-15 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Test that insertBeforeItem behaves properly for out of bounds indices.
- svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
- svg/dom/svglist-exception-on-out-bounds-error.html:
- svg/dom/svglist-insertItemBefore-appends-expected.txt: Added.
- svg/dom/svglist-insertItemBefore-appends.html: Added.
- 5:33 PM Changeset in webkit [43794] by
-
- 2 edits in trunk/WebKitTools
wx build fix. Don't parse args using getopt since it isn't available on Windows.
- 5:31 PM Changeset in webkit [43793] by
-
- 3 edits4 adds in trunk
2009-05-15 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.
Test: fast/backgrounds/background-clip-text.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- 5:06 PM Changeset in webkit [43792] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
Test: editing/selection/move-by-line-004.html
- editing/visible_units.cpp: (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper function. (WebCore::previousLinePosition): When advancing to the next candidate node, stop when leaving the closest ancestor of the original node that is not an inline. The code, incorrectly, was trying to exit the closest ancestor of that type which was editable, and therefore missing other blocks in the same editable root. (WebCore::nextLinePosition): Ditto.
LayoutTests:
Reviewed by Sam Weinig.
- test for <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
- editing/selection/move-by-line-004-expected.txt: Added.
- editing/selection/move-by-line-004.html: Added.
- 4:50 PM Changeset in webkit [43791] by
-
- 5 edits in trunk
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Converting filename to uri by concatenating strings is broken
on Windows. So, don't do it for that platform.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Converting filename to uri by concatenating strings is broken
on Windows. Use proper glib conversion functions.
- webkit/webkitwebview.cpp: (webkit_web_view_open):
- tests/testdownload.c: (test_webkit_download_create):
- 4:49 PM Changeset in webkit [43790] by
-
- 3 edits in trunk/WebKit/mac
2009-05-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Fix <rdar://problem/6875398>.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): If we failed to instantiate the plug-in, call cleanup() so that any streams created by the plug-in from its NPP_New callback are destroyed.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Make cleanup() public.
- 3:40 PM Changeset in webkit [43789] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Looking like MSVC doesn't like static variables in inline methods?
Make the state of the SSE2 check a static variable on the class
MacroAssemblerX86Common as a speculative build fix for Windows.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::isSSE2Present): (JSC::MacroAssemblerX86Common::):
- jit/JIT.cpp:
- 3:28 PM Changeset in webkit [43788] by
-
- 2 edits in trunk/LayoutTests
2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>
Disable new tests.
- platform/gtk/Skipped:
- 3:27 PM Changeset in webkit [43787] by
-
- 3 edits2 adds in trunk/WebCore
2009-05-15 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
https://bugs.webkit.org/show_bug.cgi?id=25739
- bindings/v8/V8Collection.cpp: Added. (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
- bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
- bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
- bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
- 3:22 PM Changeset in webkit [43786] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6649936> Add *.exp export files to WebCore Xcode project
Reviewed by Darin Adler and Timothy Hatcher.
- WebCore.xcodeproj/project.pbxproj: Added Exports group, moved WebCore.base.exp into the group, and added 10 other *.exp files in WebCore.
- 3:15 PM Changeset in webkit [43785] by
-
- 2 edits in trunk/JavaScriptCore
Add some assembler headers to JavaScriptCore.vcproj
This is just a convenience for Windows developers.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 3:03 PM Changeset in webkit [43784] by
-
- 2 edits in trunk/WebCore
2009-05-15 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
https://bugs.webkit.org/show_bug.cgi?id=25826
Change type to only have custom getter in JCS.
- html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
- 2:54 PM Changeset in webkit [43783] by
-
- 5 edits in trunk/WebCore
2009-05-15 Antti Koivisto <Antti Koivisto>
Reviewed by Dave Kilzer.
Add a settings entry to en/disable web font support
https://bugs.webkit.org/show_bug.cgi?id=25239
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
- 2:28 PM Changeset in webkit [43782] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Implemented fast path for op_put_by_val when putting to arrays.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val):
- 2:11 PM Changeset in webkit [43781] by
-
- 10 edits in trunk/JavaScriptCore
2009-05-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
other methods ASSERT_NOT_REACHED().
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::MacroAssemblerX86): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::supportsFloatingPoint):
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::storeDouble): (JSC::MacroAssemblerX86Common::addDouble): (JSC::MacroAssemblerX86Common::subDouble): (JSC::MacroAssemblerX86Common::mulDouble): (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set32): (JSC::MacroAssemblerX86Common::setTest32): (JSC::MacroAssemblerX86Common::x86Condition): (JSC::MacroAssemblerX86Common::isSSE2Present):
- assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::movePtrToDouble): (JSC::MacroAssemblerX86_64::moveDoubleToPtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
- assembler/X86Assembler.h:
- jit/JIT.cpp: (JSC::JIT::JIT):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- 1:43 PM Changeset in webkit [43780] by
-
- 3 edits in trunk/WebCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Remove dead youtube site specific hack that was commented out.
- bindings/js/JSNavigatorCustom.cpp:
- page/Navigator.idl:
- 1:09 PM Changeset in webkit [43779] by
-
- 3 edits in trunk/WebCore
2009-05-15 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25826
<rdar://problem/6884742>
REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)
Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::needsGmailQuirk): (WebCore::JSHTMLInputElement::type):
- html/HTMLInputElement.idl:
- 12:40 PM Changeset in webkit [43778] by
-
- 2 edits in trunk/WebCore
2009-05-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25810
Upstream V8 DOM Wrapper map declarations.
No behavior change, so no tests.
- bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): Added. (WebCore::WeakReferenceMap::~WeakReferenceMap): Added. (WebCore::WeakReferenceMap::get): Added. (WebCore::WeakReferenceMap::set): Added. (WebCore::WeakReferenceMap::forget): Added. (WebCore::WeakReferenceMap::contains): Added. (WebCore::WeakReferenceMap::impl): Added. (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
- 12:10 PM Changeset in webkit [43777] by
-
- 5 edits in trunk/WebCore
2009-05-13 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Rename GraphicsLayer::graphicsContextsFlipped() to
GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.
Clean up code around the GraphicsLayer "contents" layer that makes use of this
flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
which can then always do the flipping if necessary.
Only affects ACCELERATED_COMPOSITING builds.
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::):
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsLayer):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::compositingCoordinatesOrientation): (WebCore::GraphicsLayerCA::setBackgroundColor): (WebCore::GraphicsLayerCA::clearBackgroundColor): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::clearContents): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setContentsLayer):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
- 12:00 PM Changeset in webkit [43776] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-15 Geoffrey Garen <ggaren@apple.com> (Mostly by Sam)
Reviewed by Sam Weinig.
Implemented fast path for op_get_by_val when accessing array.
- jit/JIT.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val):
- 11:17 AM Changeset in webkit [43775] by
-
- 2 edits in trunk/WebCore
Avoid calling setNeedsStyleRecalc() when we are
putting an animated page in the cache. This avoids
the assert and subsequent problems with a dirty
page going into the cache.
- 11:13 AM Changeset in webkit [43774] by
-
- 8 edits in trunk
2009-05-15 Francisco Tolmasky <francisco@280north.com>
BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
<https://bugs.webkit.org/show_bug.cgi?id=25467>
Reviewed by Adam Roben.
- JavaScriptCore.exp: Added calculatedFunctionName
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
- debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode. (JSC::DebuggerCallFrame::calculatedFunctionName):
- debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.
WebCore:
- inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
inspector/front-end/CallStackSidebarPane.js: Remove " anonymous function" since it is handled internally just like in profiles (WebInspector.CallStackSidebarPane.prototype.update):
- 10:59 AM Changeset in webkit [43773] by
-
- 2 edits in trunk/WebKit/mac
2009-05-15 Darin Adler <Darin Adler>
Reviewed by Anders Carlsson.
<rdar://problem/6889823> hash table iterator used after hash table modified in
ProxyInstance::fieldNamed() when viewing movie trailer
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): Move add call after the waitForReply call. Anders says that by the time we return someone else might have done the same add for us. (WebKit::ProxyInstance::fieldNamed): Ditto.
- 10:41 AM Changeset in webkit [43772] by
-
- 12 edits in trunk/WebKit/mac
2009-05-15 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6892055>
Replace WKN_GetLocation with WKN_ResolveURL (WKN_GetLocation was confusing and did not take the base URL into account)
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCResolveURL): New MIG callback.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resolveURL): Use FrameLoader::complete URL here.
- Plugins/Hosted/WebKitPluginClient.defs: Add new MIG definition.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
- Plugins/WebNetscapeContainerCheckPrivate.h:
- Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
- Plugins/WebNetscapePluginView.h:
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView resolveURL:forTarget:]):
- Plugins/npapi.mm: (WKN_ResolveURL):
- 10:27 AM Changeset in webkit [43771] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fix <rdar://problem/6892052> WebTextIterator should not “emit characters between all visible positions”
- WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): Changed to construct a TextIterator with emitCharactersBetweenAllVisiblePositions set to false.
- 9:45 AM Changeset in webkit [43770] by
-
- 3 edits in trunk/WebCore
Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Check strings with isEmpty(), not relying on any implicit conversions.
- 9:06 AM Changeset in webkit [43769] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler, Brady Eidson and Eric Carlson.
<rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
username and password (Lightwave 9.6 for Mac from Newtek site)
CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
for other protocols (including FTP) should be included as part of the URL.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Put credentials in URL for non-HTTP requests.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP headers to be received, so they cannot work with other protocols.
- 8:33 AM Changeset in webkit [43768] by
-
- 2 edits in trunk/BugsSite
2009-05-15 Simon Fraser <Simon Fraser>
Carrying forwards Darin Adler's rubber stamp
Make the comment field wider too.
- skins/custom/global.css:
- 8:16 AM Changeset in webkit [43767] by
-
- 3 edits in trunk/BugsSite
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Make the URL, Summary and Keyword fields wider to mitigate the
effects of https://bugs.webkit.org/show_bug.cgi?id=25566 and make
things generally better.
- skins/custom/global.css:
- template/en/custom/bug/edit.html.tmpl:
- 5:43 AM Changeset in webkit [43766] by
-
- 2 edits in trunk
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Jan Alonzo.
Use AC_CANONICAL_HOST instead of AC_CANONICAL_SYSTEM, since
the JIT compiler is not a cross-compiler
- configure.ac:
- 4:53 AM Changeset in webkit [43765] by
-
- 2 edits in trunk/WebKit/mac
Look for libWebKitSystemInterface.a in a more reasonable location.
Reviewed by Dave Kilzer.
- Configurations/DebugRelease.xcconfig:
- 4:47 AM Changeset in webkit [43764] by
-
- 3 edits in trunk/WebCore
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] In the image decoder, remove the raw image data represented as QImage
once the image is converted to QPixmap and inserted in the pixmap cache.
This effectively reduces the heap usage when running on graphics system
other than raster (i.e the case where QImage != QPixmap).
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
- platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
- 4:46 AM Changeset in webkit [43763] by
-
- 3 edits in trunk/WebCore
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] Refactor alpha channel detection the image decoder.
Sets the boolean flag as soon as the image is being read.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel. (WebCore::ImageDecoderQt::setData): Set the flag when appropriate. (WebCore::ImageDecoderQt::supportsAlpha): Simplified. (WebCore::ImageDecoderQt::reset): Resetted the flag.
- platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
- 1:34 AM Changeset in webkit [43762] by
-
- 3 edits in trunk/LayoutTests
Mark Rowe says skipping tests doesn't need review. :)
Add new tests from r43759 to windows and tiger skipped lists until bug 25816 can be resolved.
https://bugs.webkit.org/show_bug.cgi?id=25816
Original bug: http://bugs.webkit.org/show_bug.cgi?id=25464
- platform/win/Skipped:
- platform/mac-tiger/Skipped:
- 1:08 AM Changeset in webkit [43761] by
-
- 16 edits in trunk/WebCore
2009-05-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Finish support for disabling the JavaScript Debugger and Profiler
at compile time in WebCore
https://bugs.webkit.org/show_bug.cgi?id=24917
- bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
- bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
- inspector/JavaScriptCallFrame.cpp: Ditto.
- inspector/JavaScriptCallFrame.h: Ditto.
- inspector/JavaScriptCallFrame.idl: Ditto.
- inspector/JavaScriptDebugListener.h: Ditto.
- inspector/JavaScriptDebugServer.cpp: Ditto.
- inspector/JavaScriptDebugServer.h: Ditto.
- inspector/JavaScriptProfile.cpp: Ditto.
- inspector/JavaScriptProfile.h: Ditto.
- inspector/JavaScriptProfileNode.cpp: Ditto.
- inspector/JavaScriptProfileNode.h: Ditto.
- page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
- page/Console.h: Ditto.
- page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
- 12:55 AM Changeset in webkit [43760] by
-
- 6 edits in trunk
2009-05-15 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[GTK] Implement layoutTestController.waitForPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=25036
Connect to 'navigation-policy-decision-requested' and handle
waitForPolicy in the callback.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): (webViewNavigationPolicyDecisionRequested): (main):
- DumpRenderTree/gtk/DumpRenderTreeGtk.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
- 12:49 AM Changeset in webkit [43759] by
-
- 3 edits8 adds in trunk
2009-05-15 Jungshik Shin <jshin@chromium.org>
Reviewed by Dimitri Glazkov
Improve the font fallback for characters belonging to 'common' scripts
in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
marks in North Indian scripts) and currency signs (e.g. Thai Baht)
rendered correctly in Chromium on Win.
Tests: fast/text/international/danda-space.html
fast/text/international/thai-baht-space.html
- platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::FontMap::getScriptBasedOnUnicodeBlock): (WebCore::FontMap::getScript): (WebCore::getFallbackFamily):
- 12:06 AM Changeset in webkit [43758] by
-
- 2 edits in trunk/WebCore
2009-05-15 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25731
[Qt] Cleanup - move files exclusive to XPATH and XSLT under the
appropriate build section
- WebCore.pro:
- 12:02 AM Changeset in webkit [43757] by
-
- 1 edit in trunk/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp
Partial revert of 43604. Turns out we need some V8 magic for this to work right.
- 12:02 AM Changeset in webkit [43756] by
-
- 2 edits in trunk/WebCore
2009-05-14 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel and Darin Fisher.
Fix a font-related leak in Chromium's Skia backend found by Valgrind.
https://bugs.webkit.org/show_bug.cgi?id=25760
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Use caches instead of "new" on every call.
May 14, 2009:
- 10:38 PM Changeset in webkit [43755] by
-
- 2 edits in trunk/WebCore
2009-05-14 Rahul Kuchhal <kuchhal@chromium.org>
Reviewed by Eric Seidel.
Initialize m_spreadMethod in the second constructor too. Not sure if
a test case can be written, so no test case.
https://bugs.webkit.org/show_bug.cgi?id=25814
- platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
- 10:19 PM Changeset in webkit [43754] by
-
- 4 edits1 delete in trunk/LayoutTests
No review, rollout only.
Roll out r43753 as it caused a test to fail
Turns out more than one test was using the modified JS file.
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
- editing/pasteboard/paste-blockquote-before-blockquote.html:
- editing/pasteboard/resources/TEMPLATE.html: Removed.
- editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (copyAndPasteNode):
- 9:34 PM Changeset in webkit [43753] by
-
- 4 edits1 add in trunk/LayoutTests
2009-05-14 Julie Parent <jparent@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25716
Convert a test located in the resources directory into being a regular js test,
so we can add add more tests there and run make-js-test-wrappers without clobbering this one.
- editing/pasteboard/paste-blockquote-before-blockquote-expected.txt:
- editing/pasteboard/paste-blockquote-before-blockquote.html:
- editing/pasteboard/resources/TEMPLATE.html: Added.
- editing/pasteboard/resources/paste-blockquote-before-blockquote.js: (createLine): (copyAndPasteNode):
- 8:54 PM Changeset in webkit [43752] by
-
- 3 edits in trunk/WebCore
2009-05-14 Simon Fraser <Simon Fraser>
No review.
Fix Windows build after renaming MediaControlElements to MediaControlElementType.
- rendering/RenderMediaControls.cpp: (WebCore::RenderMediaControls::paintMediaControlsPart):
- rendering/RenderMediaControls.h:
- 8:44 PM Changeset in webkit [43751] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-14 Gavin Barraclough <barraclough@apple.com>
Build fix, not reviewed.
Quick fixes for JIT builds with OPTIMIZE flags disabled.
- jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITPropertyAccess.cpp: (JSC::JIT::compilePutByIdHotPath):
- 8:33 PM Changeset in webkit [43750] by
-
- 90 edits in tags/Safari-6530.10.1/JavaScriptCore
Merge r43749.
- 8:29 PM Changeset in webkit [43749] by
-
- 3 edits in trunk/JavaScriptCore
Back out incorrect Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 8:16 PM Changeset in webkit [43748] by
-
- 1 copy in tags/Safari-6530.10.1
New tag.
- 8:10 PM Changeset in webkit [43747] by
-
- 3 edits in trunk/WebCore
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6739671> Movie controller’s play button does not change into a pause
button
Fix a controls repaint issue when the playing state of a video changes by
educating the MediaControlInputElements about the state they are currently
displaying, and making them repaint when that state changes. This applies
to the play/pause and mute/unmute buttons, which both have two states.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): (WebCore::MediaControlTimelineElement::MediaControlTimelineElement): (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Pass in and initialize the MediaControlElementType.
(WebCore::MediaControlInputElement::update):
Update the display type too
(WebCore::MediaControlInputElement::setDisplayType):
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
(WebCore::MediaControlMuteButtonElement::updateDisplayType):
Choose muted vs. unmuted display.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlPlayButtonElement::updateDisplayType):
Choose play vs. paused display.
- rendering/MediaControlElements.h: Renamed the MediaControlElements enum to MediaControlElementType. (WebCore::MediaControlInputElement::updateDisplayType): Add a MediaControlElementType member variable with a setter to allow the element to know what type it is displaying.
- 8:02 PM Changeset in webkit [43746] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a failure in fast/js/math-transforms.html caused by failing to
preserve -0 in multiplication.
- assembler/X86Assembler.h: (JSC::X86Assembler::jz):
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): Check both for overflow and for zero when doing multiplication. Use a slow case to get these right.
- 7:07 PM Changeset in webkit [43745] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a bug in the varargs calling convention.
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): Move the argument count into regT1, since that's where ctiVirtualCall expects it to be.
- 5:51 PM Changeset in webkit [43744] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's looping code.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): NULL means the object has no prototype, so only loop when *not* equal to NULL.
- 5:38 PM Changeset in webkit [43743] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed a small bug in instanceof's result writing code.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): Make sure to fill out the payload bits in all cases.
- 5:09 PM Changeset in webkit [43742] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Removed an invalid assertion in cti_op_urshift which
depended on a fast path for op_urshift which has
never existed.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_urshift):
- 5:04 PM Changeset in webkit [43741] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed loop_if_true, which had the same reversed test that jtrue had.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true):
- 4:56 PM Changeset in webkit [43740] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
In op_neq, we apparently want to check that one value
does *not* equal another. Go figure.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_neq):
- 4:14 PM Changeset in webkit [43739] by
-
- 5 edits8 adds in trunk
2009-05-14 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add support for aspect-ratio and orientation
media queries.
Tests: fast/media/mq-aspect-ratio.html
fast/media/mq-orientation.html
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp: (WebCore::orientationMediaFeatureEval): (WebCore::aspect_ratioMediaFeatureEval): (WebCore::min_aspect_ratioMediaFeatureEval): (WebCore::max_aspect_ratioMediaFeatureEval):
- css/MediaQueryExp.h: (WebCore::MediaQueryExp::isViewportDependent):
- 4:04 PM Changeset in webkit [43738] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
The slow case of op_mod should call op_mod's jit stub,
not op_mul. That would be dumb.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_mod):
- 4:04 PM Changeset in webkit [43737] by
-
- 4 edits9 copies in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Resubmitting previous patch, correctly this time.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Resubmitting previous patch, correctly this time.
- editing/execCommand/outdent-blockquote-test1.html: Copied from editing/execCommand/outdent-blockquote-test1.html.
- editing/execCommand/outdent-blockquote-test2.html: Copied from editing/execCommand/outdent-blockquote-test2.html.
- editing/execCommand/outdent-blockquote-test3.html: Copied from editing/execCommand/outdent-blockquote-test3.html.
- editing/execCommand/outdent-blockquote-test4.html: Copied from editing/execCommand/outdent-blockquote-test4.html.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Copied from platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt.
- 4:03 PM Changeset in webkit [43736] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed problems when using 'arguments' due to a half-initialized register.
- interpreter/CallFrame.h: (JSC::ExecState::setCalleeArguments): (JSC::ExecState::init): Require a full JSValue when setting up the 'arguments' virtual register, since this register is accessible from JIT code and bytecode, and needs to be a true JSValue.
- interpreter/CallFrameClosure.h: (JSC::CallFrameClosure::resetCallFrame): ditto
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): ditto
- interpreter/Register.h: Removed the constructor that allowed assignment of a JSArguments* to a register. That is not safe. See above.
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): ditto
- 3:18 PM Changeset in webkit [43735] by
-
- 4 edits in trunk
Versioning.
- 3:17 PM Changeset in webkit [43734] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
We really want to go to the slow case in op_jfalse and
op_jtrue if the value is *not* boolean.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue):
- 3:08 PM Changeset in webkit [43733] by
-
- 3 edits in tags/Safari-6530.10/JavaScriptCore
Merge r43711.
- 2:56 PM Changeset in webkit [43732] by
-
- 5 edits9 deletes in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Rolling out to fix a bug and the build
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
- Rolled out for bug and build fix.
- editing/execCommand/outdent-blockquote-test1.html: Removed.
- editing/execCommand/outdent-blockquote-test2.html: Removed.
- editing/execCommand/outdent-blockquote-test3.html: Removed.
- editing/execCommand/outdent-blockquote-test4.html: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Removed.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Removed.
- 2:40 PM Changeset in webkit [43731] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Flipped the condition when emitting a an op_loop_if_less or op_loop_if_lesseq
if the first operand is a constant.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq):
- 2:28 PM Changeset in webkit [43730] by
-
- 1 copy in tags/Safari-6530.10
New tag.
- 2:28 PM Changeset in webkit [43729] by
-
- 4 edits9 adds in trunk
WebCore:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Calling recursively here served to do nothing because this function will return if the second argument is the parent of the first. Not only does this now work as intended, but is necessary for the rest of this fix.
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): To determine if we are the last node in a <blockquote>, and can therefore remove the <blockquote> we need the endOfEnclosingBlock to extend to the end of the <blockquote> not just the next block, which could be a <div>, for example.
- Also If a <blockquote> is removed, but it's the child of another <blockquote> then its children are now children of the top <blockquote>. In this case we want to split the parent <blockquote> because the next paragraph assumes that it is the first node in its <blockquote> and if that is not true, various bugs arise.
LayoutTests:
2009-05-14 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6510362> In some situations message content is messed up
when indentation is decreased
- These tests are the various combinations of <blockquote>s that revealed bugs in our old logic.
- editing/execCommand/outdent-blockquote-test1.html: Added.
- editing/execCommand/outdent-blockquote-test2.html: Added.
- editing/execCommand/outdent-blockquote-test3.html: Added.
- editing/execCommand/outdent-blockquote-test4.html: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
- platform/mac/editing/execCommand/outdent-blockquote-test5-expected.txt: Added.
- 1:50 PM Changeset in webkit [43728] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added missing return in op_jnless and op_jnlesseq.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
- 1:47 PM Changeset in webkit [43727] by
-
- 2 edits in trunk/WebKit/mac
2009-05-14 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
Fix for <rdar://problem/6886217> REGRESSION (S4 beta-ToT): Adium chat window contents no longer resize.
Technically this is a bug in Adium. It appears that Adium has subclassed the WebView and implemented
viewDidMoveToWindow in its subclass improperly. It doesn't call up to the base class WebView like it
should and so our boundsChanged notification never gets added.
Reduce the dependence on viewDidMoveToWindow by moving the registration of observers into
viewWillMoveToWindow instead.
- WebView/WebView.mm: (-[WebView addSizeObserversForWindow:]): (-[WebView removeWindowObservers]): (-[WebView addWindowObserversForWindow:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]): (-[WebView viewDidMoveToSuperview]):
- 1:42 PM Changeset in webkit [43726] by
-
- 2 edits in trunk/WebCore
2009-05-14 Brady Eidson <beidson@apple.com>
Build fix.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType):
- 1:34 PM Changeset in webkit [43725] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Load constants into the the register file as a temorary measure to
aid bring up. This allows us to use to treat constants like any
other virtual register.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
- 1:09 PM Changeset in webkit [43724] by
-
- 2 edits in trunk/WebCore
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
Fix http/tests/xmlhttprequest/cache-override.html on Windows
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::setDefaultMIMEType): Modify the previous response so it maintains all of its data. (WebCore::didReceiveResponse): Call setDefaultMIMEType() when needed. (WebCore::WebCoreSynchronousLoader::load): Ditto.
- 12:55 PM Changeset in webkit [43723] by
-
- 2 edits in trunk/WebCore
2009-05-14 Paul Godavari <paul@chromium.org>
Reviewed by Dimitri Glazkov.
Bug: Mac Chromium popup menus are not positioned correctly
on scrolled pages:
https://bugs.webkit.org/show_bug.cgi?id=25772
Fix Mac Chromium popup menu placement by taking into
account any scrolling in the current window. This mirrors
the positioning done in PopupContainer::show(), which is
used on Chromium Windows and linux.
Also fixed indenting for this method.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):
- 12:55 PM Changeset in webkit [43722] by
-
- 1 edit1 add in trunk/WebCore
2009-05-14 Drew Wilson <atwilson@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25774
Upstream V8MessagePortCustom.cpp from the chromium repository.
- bindings/v8/custom/V8MessagePortCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
- 12:54 PM Changeset in webkit [43721] by
-
- 6 edits in trunk
WebKit/mac:
2009-05-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Allow the local cache directory to be set using a defaults key.
- Misc/WebKitNSStringExtras.h:
- Misc/WebKitNSStringExtras.m: (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
- WebKit.exp:
WebKitTools:
2009-05-14 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Make paths where data is saved be scoped to the ~ directory,
so that one can run independent instances by setting CFFIXED_USER_HOME.
- DumpRenderTree/mac/DumpRenderTree.mm: (libraryPath): (setDefaultsToConsistentValuesForTesting): (dumpFrameAsPDF):
- 12:21 PM Changeset in webkit [43720] by
-
- 3 edits4 adds in trunk
2009-05-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
StyleGeneratedImage::imageSize() needs to take zooming into account for
fixed-size images (i.e. canvas) so that canvas-as-image-background
renders correctly with zooming.
Test: fast/canvas/canvas-bg-zoom.html
- rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::imageSize):
- 12:09 PM Changeset in webkit [43719] by
-
- 3 edits4 adds in trunk
Reviewed by Darin Adler.
Patch originally by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25796
<rdar://problem/6886654> Shouldn't set referer and origin in Loader::Host::servePendingRequests().
Test: http/tests/security/credentials-in-referer.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): This will be done in SubresourceLoader::create() anyway.
- 12:07 PM Changeset in webkit [43718] by
-
- 2 edits in trunk/LayoutTests
2009-05-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disabling tests that are failing intermittently.
- platform/gtk/Skipped:
- 12:01 PM Changeset in webkit [43717] by
-
- 6 edits in trunk
Bug 25797: Pages with image maps are not properly read with Voiceover
https://bugs.webkit.org/show_bug.cgi?id=25797
- 11:56 AM Changeset in webkit [43716] by
-
- 6 edits in trunk
WebCore:
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
Nuke the bogus ASSERT and add a legitimate ASSERT with a little help from a new accessor.
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniff):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::didReceiveResponse):
LayoutTests:
2009-05-14 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6887762> and https://bugs.webkit.org/show_bug.cgi?id=25790
- platform/win/Skipped: Renable these tests.
- 10:51 AM Changeset in webkit [43715] by
-
- 8 edits2 adds in trunk
2009-05-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute
Support the recently added HTMLMediaElement 'startTime' attribute. This is a read-only
value that only the media engine can know, so we just need to add the attribute
to HTMLMediaElement and add methods to MediaPlayer and MediaPlayerPrivateInterface so
the engine can make it available.
Test: media/media-startTime.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::startTime): New.
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::startTime): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::startTime): New.
2009-05-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25791
Bug 25791: HTMLMediaElement: implement 'startTime' attribute
Add test for 'startTime' attribute.
- media/media-startTime-expected.txt: Added.
- media/media-startTime.html: Added.
- 10:44 AM Changeset in webkit [43714] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Add a comment to QWebView::iconChanged(), mentioning that you will
need to set the icon database path for icons to be loaded, and thus
receive the signal.
- Api/qwebview.cpp:
- 10:35 AM Changeset in webkit [43713] by
-
- 2 edits1 add in trunk/LayoutTests
2009-05-14 Tony Chang <tony@chromium.org>
Reviewed by Dimitri Glazkov.
Move iframe content to a file because Chromium has
AllowLocalLoadsForLocalOnly enabled. This prevents the parent
frame from modifying the iframe content if it is a data: URL.
- fast/frames/content-opacity-2.html:
- fast/frames/resources/empty-body.html: Added.
- 10:34 AM Changeset in webkit [43712] by
-
- 2 edits in trunk/LayoutTests
Add a failing text control metrics test to the Windows Skipped file
See Bug 25794: fast/replaced/table-percent-height-text-controls fails
on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25794>
- platform/win/Skipped: Added fast/replaced/table-percent-height-text-controls.html.
- 10:29 AM Changeset in webkit [43711] by
-
- 3 edits in trunk/JavaScriptCore
Windows build fix
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 10:27 AM Changeset in webkit [43710] by
-
- 2 edits in trunk/WebCore
2009-05-14 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Ariya Hidayat.
Only create a QWidget wrapper for the plugin in the case it is not
in the Qt window mapper, and thus receiving events from the Qt
event system. Native Qt based plugins running in process, will
already be in the window mapper, and thus creating a wrapper,
stops them from getting events from Qt, as they are redirected
to the wrapper.
- 9:45 AM Changeset in webkit [43709] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25784
Leaks seen on HTTP tests
We should change ResourceHandleMac.mm to use smart pointers some day, but this is a minimal fix.
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Release mutable request copy made for disabling content sniffing, matching the normal code path. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Release m_user and m_pass before overwriting. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
- 9:39 AM Changeset in webkit [43708] by
-
- 2 edits in trunk/WebKit/mac
2009-05-14 Darin Adler <Darin Adler>
Reviewed by Adam Roben.
<rdar://problem/6879999> Automator actions that use WebKit on a background thread fail when run outside of Automator
- WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Added. Contains new broader rule. (needsWebViewInitThreadWorkaround): Changed to call clientNeedsWebViewInitThreadWorkaround.
- 9:14 AM Changeset in webkit [43707] by
-
- 2 edits in trunk/WebCore
2009-05-14 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25418
Remove new lines from event handler wrapper to make line numbers
in the wrapped script conside with the lines in the original script.
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
- 9:11 AM Changeset in webkit [43706] by
-
- 2 edits in trunk/LayoutTests
Add a timing-out test to the Windows Skipped file
See Bug 25792: fast/encoding/percent-escaping.html times out on
Windows
<https://bugs.webkit.org/show_bug.cgi?id=25792>
- platform/win/Skipped: Added fast/encoding/percent-escaping.html.
- 9:11 AM Changeset in webkit [43705] by
-
- 2 edits in trunk/WebCore
2009-05-14 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Alexey Proskuryakov.
Remove a JSC-specific include that is already added by including
ScriptController.
No change in behavior, so no tests.
- dom/Document.cpp: Removed JSDOMBinding include.
- 9:05 AM Changeset in webkit [43704] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady Eidson.
<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
Hopefully, a final stroke. When updating ResourceRequest from a platform request, a wrong
CFString function was used, so a user-friendly name was stored in encoding fallback array.
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest):
- 8:59 AM Changeset in webkit [43703] by
-
- 2 edits in trunk/LayoutTests
Add new Hebrew-using tests to the Windows Skipped file
See Bug 23925: Tests that use Hebrew text fail on Windows because
Lucida Grande is not used for Hebrew
<https://bugs.webkit.org/show_bug.cgi?id=23925>
- platform/win/Skipped: Added tests added in r43664.
- 8:23 AM Changeset in webkit [43702] by
-
- 2 edits in trunk/LayoutTests
Skip XHR tests that crash in Windows Debug builds
See:
Bug 25790: REGRESSION (r43518): Multiple XHR tests asserting in
createCFURLResponseWithDefaultMIMEType on Windows
<https://bugs.webkit.org/show_bug.cgi?id=25790>
Bug 25344: Some http tests crash in Debug Windows builds due to an
assertion in CFNetwork when releasing a CFURLConnection
<https://bugs.webkit.org/show_bug.cgi?id=25344>
- platform/win/Skipped: Added crashing XHR tests.
- 8:19 AM Changeset in webkit [43701] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Fix setHtml test case by adding <head> tag to the expected result. This tag is automatically added by WebKit.
- tests/qwebframe/tst_qwebframe.cpp:
- 8:04 AM Changeset in webkit [43700] by
-
- 3 edits in trunk/JavaScriptCore
Windows jsc build fix
r43648 modified jsc.vcproj's post-build event not to try to copy files
that aren't present. Then r43661 mistakenly un-did that modification.
This patch restores the modification from r43648, but puts the code in
jscCommon.vsprops (where it should have been added in r43648).
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Restored empty VCPostBuildEventTool tags.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Modified the post-build event command line to match the one in jsc.vcproj from r43648.
- 7:49 AM Changeset in webkit [43699] by
-
- 29 edits in trunk/WebCore
2009-05-14 Ben Murdoch <benm@google.com>
Reviewed by Darin Adler.
Add more ENABLE_DATABASE guards.
https://bugs.webkit.org/show_bug.cgi?id=25616
See also https://bugs.webkit.org/show_bug.cgi?id=24776 (original set of guards)
- bindings/js/JSSQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementCallback.h:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionCallback.h:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
- bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h:
- bindings/v8/custom/V8DatabaseCustom.cpp:
- bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
- storage/Database.cpp:
- storage/DatabaseDetails.h:
- storage/OriginUsageRecord.cpp:
- storage/OriginUsageRecord.h:
- storage/SQLError.h:
- storage/SQLError.idl:
- storage/SQLResultSet.cpp:
- storage/SQLResultSet.h:
- storage/SQLResultSet.idl:
- storage/SQLResultSetRowList.cpp:
- storage/SQLResultSetRowList.h:
- storage/SQLResultSetRowList.idl:
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
- 7:23 AM Changeset in webkit [43698] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-14 Laszlo Gombos <Laszlo Gombos>
Reviewed by Darin Adler.
Make sure pthread_self() is declared before it gets called in Collector.cpp
- runtime/Collector.cpp: Include pthread.h in most Unix-like platforms (not just for OPENBSD)
- 7:22 AM Changeset in webkit [43697] by
-
- 2 edits in trunk/WebCore
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
Gtk was the last platform to not unregister plugins when
the plugin is stopped. Catch up with r43550.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::stop):
- 7:17 AM Changeset in webkit [43696] by
-
- 2 edits in trunk/WebKit/qt
2009-05-14 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Ariya Hidayat.
Add a test case for the signal urlChanged().
- tests/qwebframe/tst_qwebframe.cpp:
- 7:10 AM Changeset in webkit [43695] by
-
- 2 edits in trunk/WebCore
Make WebCore.vcproj's pre-build event work again
- WebCore.vcproj/WebCore.vcproj: Removed empty override of the pre-build event that was accidentally left in when the pre-build event was moved to WebCoreCommon.vsprops.
- 6:29 AM Changeset in webkit [43694] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove old render tree dumps for http tests that are now text-only
Beth made the tests text-only in r43677 but forgot to remove these
Windows-specific render tree dumps.
Rubber-stamped by Dave Hyatt.
- platform/win/http/tests/navigation/anchor-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/anchor-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/post-goback2-expected.txt: Removed.
- platform/win/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-loadsame-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-reload-expected.txt: Removed.
- platform/win/http/tests/navigation/success200-subframeload-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
- platform/win/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
- 4:50 AM Changeset in webkit [43693] by
-
- 3 edits1 add in trunk
WebCore:
2009-05-14 Darin Adler <Darin Adler>
- manual-tests/right-click-crash.html: Added.
WebKit/mac:
2009-05-14 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Bug 24049: Second right-click crashes safari when alert invoked
https://bugs.webkit.org/show_bug.cgi?id=24049
rdar://problem/6878977
- WebView/WebHTMLView.mm: (-[WebHTMLView rightMouseUp:]): Added a retain/autorelease of the event. (-[WebHTMLView menuForEvent:]): Ditto. Also cleaned up the logic here and eliminated some use of pointers that might be invalid after calling through to WebCore. (-[WebHTMLView scrollWheel:]): Ditto. (-[WebHTMLView acceptsFirstMouse:]): Ditto. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Ditto. (-[WebHTMLView mouseDown:]): Ditto. (-[WebHTMLView mouseDragged:]): Ditto. (-[WebHTMLView mouseUp:]): Ditto. (-[WebHTMLView keyDown:]): Ditto. (-[WebHTMLView keyUp:]): Ditto. (-[WebHTMLView flagsChanged:]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Ditto.
- 4:14 AM Changeset in webkit [43692] by
-
- 4 edits in trunk/JavaScriptCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=25785>. Bug 25785: Segfault in mark when using JSObjectMakeConstructor
Reviewed by Oliver Hunt.
- API/JSObjectRef.cpp:
(JSObjectMakeConstructor): OpaqueJSClass::prototype can return 0. We need to use the default object prototype when it does.
- API/tests/testapi.c:
(main): Add a test case.
- runtime/JSObject.h:
(JSC::JSObject::putDirect): Add a clearer assertion for a null value. The assertion on the next line does catch this,
but the cause of the failure is not clear from the assertion itself.
- 4:14 AM Changeset in webkit [43691] by
-
- 8 edits in trunk
<rdar://problem/6681868> When building with Xcode 3.1.3 should be using gcc 4.2
Rubber-stamped by Darin Adler.
The meaning of XCODE_VERSION_ACTUAL is more sensible in newer versions of Xcode.
Update our logic to select the compiler version to use the more appropriate XCODE_VERSION_MINOR
if the version of Xcode supports it, and fall back to XCODE_VERSION_ACTUAL if not.
- 3:55 AM Changeset in webkit [43690] by
-
- 2 edits in trunk/LayoutTests
2009-05-14 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Added new tests to the skipped list.
- 1:58 AM Changeset in webkit [43689] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-14 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Checking register file bounds should be a ptr comparison (m_end is a Register*).
Also, the compare should be unsigned, pointers don'ts go negative.
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- 1:21 AM Changeset in webkit [43688] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-14 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Implemented op_strict_eq. Original patch by Snowy, by way of Sam and Gavin.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): Added set8, since it's slightly faster than set32, and the new value representation usually doesn't need set32.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitLoadTag): (JSC::JIT::emitLoadPayload): Added helper functions for dealing with constants. Eventually, we should write special cases for all constants, but these are helpful in the short term.
- jit/JITOpcodes.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emitSlow_op_nstricteq): teh opcodez.
- runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValue::isDouble): Added a LowestTag for clarity.
