Timeline


and

05/20/09:

22:52 Changeset [43960] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Cleanup the JSGlobalData when exiting early with the usage statement in jsc.

  • jsc.cpp: (printUsageStatement): (parseArguments): (jscmain):
22:46 Changeset [43959] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Update the patchOffsetGetByIdSlowCaseCall constant for the
case that OPCODE_SAMPLING is enabled.

  • jit/JIT.h:
21:06 Changeset [43958] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25706

It turns out the CurrentContext wasn't currect either because it gave
us the frame for the write() function itself. We actually want the
*calling* context.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
19:52 Changeset [43957] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <gns@gnome.org>

Skipping a new test.

  • platform/gtk/Skipped:
19:45 Changeset [43956] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <gns@gnome.org>

Skipping test that fails intermitently.

  • platform/gtk/Skipped:
19:43 Changeset [43955] by zecke@webkit.org
  • 4 edits
    1 add in trunk/WebCore

[GTK] Implement Image::loadPlatformResource.

Install the four resources we are using. For the icons
where an icon name is specified by freedeskop.org try to
map the WebCore name to that name and fallback to the
internal icon. For everything else use the internal icon
name. Remove the temporary link stub as this is not
required any more.

19:42 Changeset [43954] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Gtk+ wants to have a themable urlIcon too.

https://bugs.webkit.org/show_bug.cgi?id=19357

19:41 Changeset [43953] by kov@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <gns@gnome.org>

Rubber-stamped by Mark Rowe.

Add GTK+-specific results for canvas-composite-alpha. This test
has 'failing' cases that pass on GTK+/cairo.

  • platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Added.
19:28 Changeset [43952] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added support for inline subtraction of doubles.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft): (JSC::JIT::emitBinaryDoubleOp):
19:22 Changeset [43951] by slewis@apple.com
  • 6 edits in trunk

2009-05-20 Stephanie Lewis <slewis@apple.com>

Update the order files. <rdar://problem/6881750> Generate new order files.

  • WebCore.order:
    • WebKit.order:
19:19 Changeset [43950] by weinig@apple.com
  • 9 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Added support for inline division.

  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::divsd_rr): (JSC::X86Assembler::divsd_mr):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitBinaryOp):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div): (JSC::JIT::emitSlow_op_div):
19:14 Changeset [43949] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix some assertion failures in plug-in tests on the Windows debug build bot.

Reviewed by Gavin Barraclough.

  • plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.

  • plugins/PluginView.cpp:

(WebCore::scriptStringIfJavaScriptURL): Ditto.

18:31 Changeset [43948] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added support for inline addition of doubles.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
17:16 Changeset [43947] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Factored inline double operations into a helper function, so that we
can reuse this code for other math operations.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame):
16:58 Changeset [43946] by beidson@apple.com
  • 4 edits in trunk

WebCore:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

More protocolInHTTPFamily() cleanup.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

WebKit/win:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

More protocolInHTTPFamily() cleanup.

  • WebHistory.cpp: (WebHistory::visitedURL):
16:57 Changeset [43945] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added support for inline multiplication of doubles.

  • assembler/X86Assembler.h: (JSC::X86Assembler::cvtsi2sd_mr): New function, useful for loading an int32 into a double register.
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): Filled out these cases for double arithmetic.
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::addressFor): New function, useful for addressing a JSValue's full 64bits as a double.
16:57 Changeset [43944] by mrowe@apple.com
  • 3 edits in trunk/WebKitSite

Prevent search engines from getting creative in their descriptions of webkit.org content.

Rubber-stamped by Eric Seidel.

  • blog/wp-content/themes/webkit/header.php:
  • header.inc:
16:37 Changeset [43943] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-05-21 Christian Dywan <christian@twotoasts.de>

Reviewed by Jan Alonzo.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl): Always use Glib Base64 decoding.
16:36 Changeset [43942] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6905475>
Office 2008: Entourage: Crash when you switch to "My Day" view

The host function callback callObjCFallbackObject was not annotated
with JSC_HOST_CALL which meant that when it was called by the JIT, which
expects the JSC_HOST_CALL calling convention, the arguments are not in the
expected places.

  • bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL annotation on callObjCFallbackObject.
16:32 Changeset [43941] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Need to disable this assert while the chormium code is fixed for it.

  • platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs):
16:13 Changeset [43940] by ddkilzer@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Added bugs.webkit.org URL

16:09 Changeset [43939] by ddkilzer@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Test for <rdar://problem/5666078> Cookie parsing terminates at the first semicolon, ignoring quotes (16699)

Reviewed by Brady Eidson.

  • http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
  • http/tests/cookies/double-quoted-value-with-semi-colon.html: Added.
  • http/tests/cookies/resources/double-quoted-value-with-semi-colon.js: Added.
  • platform/mac-tiger/Skipped: Added double-quoted-value-with-semi-colon.html since CFNetwork on Tiger stops parsing cookie values when it sees a semi-colon, even inside double quotes.
16:01 Changeset [43938] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
http://trac.webkit.org/changeset/43929. Fix assert placement.

  • platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs): (WebCore::protocolIs):
15:35 Changeset [43937] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6905336> REGRESSION: "Clear History" does not save empty history to disk

  • History/WebHistory.mm: (-[WebHistoryPrivate data]): If there are no entries, return an empty NSData instead of nil.
15:26 Changeset [43936] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-20 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

Upstream V8 bindings for V8DomWindow.
https://bugs.webkit.org/show_bug.cgi?id=25869

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp. (WebCore::isAscii): Moved from v8_custom.cpp. (WebCore::convertBase64): Moved from v8_custom.cpp. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp. (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp. (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
15:18 Changeset [43935] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-05-21 Christian Dywan <christian@twotoasts.de>

Rubberstamped by Gustavo Noronha.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
15:04 Changeset [43934] by christian@webkit.org
  • 2 edits
    2 deletes in trunk/WebCore

2009-05-20 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

  • GNUmakefile.am:
  • platform/gtk/guriescape.c:
  • platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and g_uri_unescape_string now that we require Glib 2.16.
13:55 Changeset [43933] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Change KURLGoogle.cpp to mirror changes done in
http://trac.webkit.org/changeset/43929.

  • platform/KURLGoogle.cpp: (WebCore::protocolIsJavaScript): (WebCore::protocolIs):
12:53 Changeset [43932] by beidson@apple.com
  • 5 edits in trunk/WebCore

2009-05-20 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

At all call sites that check if a KURL has either the http or https protocol,
use the KURL::protocolInHTTPFamily() accessor, instead.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::open):
  • loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
  • loader/loader.cpp: (WebCore::Loader::load):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
12:39 Changeset [43931] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

WebKit side of <rdar://problem/6895072>


Pass the localization as a launch property.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
12:36 Changeset [43930] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typo

12:31 Changeset [43929] by beidson@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300

KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
"javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
invalid, you can no longer ask it a question such as "is your protocol javascript?"
Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
navigated to them.

URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
being a high profile example) and actually represent valid javascript.

Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
as it functions on a String which doesn't have to pass KURLs parsing rules.

Test: fast/loader/javascript-url-hierarchical-execution.html

  • bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
  • bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Ditto.
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Ditto.
  • bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): Ditto. (WebCore::JSLocation::reload): Ditto.
  • editing/markup.cpp: (WebCore::appendQuotedURLAttributeValue): Ditto.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto. (WebCore::FrameLoader::submitForm): Ditto. (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.


  • platform/KURL.cpp: (WebCore::KURL::init): Use protocolIsJavaScript(). (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.

Such checks should go through protocolIsJavaScript() instead.

(WebCore::encodeRelativeString): Use protocolIsJavaScript().
(WebCore::protocolIsJavaScript):

  • platform/KURL.h:

LayoutTests:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300

  • fast/loader/javascript-url-hierarchical-execution-expected.txt: Added.
  • fast/loader/javascript-url-hierarchical-execution.html: Added.
12:30 Changeset [43928] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

12:29 Changeset [43927] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.11

New tag.

12:27 Changeset [43926] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

12:21 Changeset [43925] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r43886.

12:21 Changeset [43924] by mrowe@apple.com
  • 3 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r43885.

10:35 Changeset [43923] by zecke@webkit.org
  • 6 edits
    2 adds in trunk

[plugins] PluginPackage*.cpp for Gtk+/Qt misassigned hasproperty and hasmethod

https://bugs.webkit.org/show_bug.cgi?id=24510

PluginPackageGtk.cpp and PluginPackageQt.cpp assigned _NPN_HasMethod
to hasproperty and _NPN_HasProperty to hashmethod. This commit is fixing
it. It is also adding test code to PluginObject.cpp and it will invoke
this code from a new test.

10:31 Changeset [43922] by weinig@apple.com
  • 6 edits in trunk/WebCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Timothy Hatcher.

Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
and only exist on RenderText.

  • dom/Range.cpp: (WebCore::Range::textRects):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead of absoluteQuadsForRange since no range is being specifiec.
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.h:
10:05 Changeset [43921] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::setCursor):
09:59 Changeset [43920] by xan@webkit.org
  • 4 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Implement AtkObject::focus-event and
AtkObject::state-changed:focused signal emission.

Adds a new handleFocusedUIElementChangedWithRenderers, only in the
GTK port, called at the same point than
handleFocusedUIElementChanged but with two parameters, the old and
the newly focused RenderObjects. We need this, since the ATK
signals require us to pass the objects involved in the focus
change as arguments.

  • accessibility/AXObjectCache.h:
  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
  • dom/Document.cpp: (WebCore::Document::setFocusedNode):
09:23 Changeset [43919] by ariya@webkit.org
  • 4 edits
    3 adds in trunk/WebKit/qt

2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann and Holger Freyther.

[Qt] Add renderHints property to QWebView.

  • Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate): (QWebView::renderHints): (QWebView::setRenderHints): (QWebView::setRenderHint): (QWebView::paintEvent):
  • Api/qwebview.h:
  • tests/qwebview/qwebview.pro: Added.
  • tests/qwebview/tst_qwebview.cpp: Added. (tst_QWebView::tst_QWebView): (tst_QWebView::~tst_QWebView): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::renderHints):
  • tests/tests.pro:
09:04 Changeset [43918] by zecke@webkit.org
  • 15 edits in trunk

[architecture] Make ChromeClient a interface again

https://bugs.webkit.org/show_bug.cgi?id=25834

With recent additions to ChromeClient.h empty defaults were
added. This is bad for porters as these changes go unnoticed
and at runtime no notImplemented warning is logged and grepping
for notImplemented will not show anything. Change this Client
to be like the other Clients again and always have pure virtuals
(but for stuff inside #ifdef PLATFORM(MAC)).

Update the various WebKit/* implementations to compile again.

08:34 Changeset [43917] by hausmann@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Fix a plugin bug in the WebKit code, similar to the one in WebCore.

The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer

08:34 Changeset [43916] by hausmann@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Fix a bug where a non visible plugin would show it self in a
sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer

Added manual test.

08:32 Changeset [43915] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.

08:26 Changeset [43914] by hausmann@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Replace WREC with YARR + YARR_JIT for the Qt port. This is only
used when compiled with JIT support for now, so it is a drop-in
replacement for the WREC usage. Still including the wrec headers
as they are being referred from RegExp.h, though the contents of
that header it protected by "#if ENABLE(WREC)".

08:08 Changeset [43913] by staikos@webkit.org
  • 5 edits in trunk/WebCore

2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=23452
Change the implementation of HTMLNoScriptElement to avoid the pain of
adding virtual function for XHTMLMP support

Includes changes suggested by Simon Fraser.

08:06 Changeset [43912] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-20 Darin Adler <darin@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4023899> Shift-Tab skips key views in toolbar in Safari, although Tab
iterates through them properly

  • WebView/WebView.mm: (-[WebView previousValidKeyView]): Work around a bug in -[NSView previousValidKeyView].
08:00 Changeset [43911] by kevino@webkit.org
  • 2 edits in trunk/WebCore

CURL backend build fix. Make sure URL is always set.

07:54 Changeset [43910] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by George Staikos.

Fix Qt WebKit build break in Mac OS.

  • platform/FileSystem.h:
07:51 Changeset [43909] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Eric Seidel.

Enable code that was commented out waiting for a way to get a
GdkPixbuf from an image, effectively enabling copying images to
the clipboard.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
07:33 Changeset [43908] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.

Implement Atk list item role for list items.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
07:33 Changeset [43907] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.

Implement Atk paragraph role for paragraph elements.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
05:42 Changeset [43906] by eric@webkit.org
  • 2 edits in trunk

2009-05-20 Eric Seidel <eric@webkit.org>

Fix bug URL in ChangeLogs in r43903.
https://bugs.webkit.org/show_bug.cgi?id=25742

05:37 Changeset [43905] by eric@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2009-05-20 Eric Seidel <eric@webkit.org>

No review, build fix only.

Add files I missed in r43903.

Takeshi's patch was right, I just failed to add the files when landing.

  • platform/mac/fast/forms/search-styled-expected.checksum: Added.
  • platform/mac/fast/forms/search-styled-expected.png: Added.
05:37 Changeset [43904] by eric@webkit.org
  • 2 adds in trunk/LayoutTests/platform/mac/fast/forms

Add files I missed in r43903

05:33 Changeset [43903] by eric@webkit.org
  • 6 edits in trunk

2009-05-20 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Eric Seidel.

Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
https://bugs.webkit.org/show_bug.cgi?id=24539

Fix RenderThemeChromiumWin::paintTextFieldInternal().

We shouldn't paint the content area of text fields when o->style() has
background image or transparent background color. paintTextFieldInternal() is
used for painting inner area of HTML option elements by Chromium.

When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
the background image rendered by RenderBoxModelObject. So, we should set
fillContentArea = false in such case.

Besides, when background-color:transparent is specified for CSS property,
o->style().backgroundColor returns black color with alpha channel == 0. But
since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
recognize alpha channel, it fills the rect with black. I made workaround to set
fillContentArea = false when alpha channel == 0 to avoid this.

And more, I'd like to fallback the color passed to ChromiumBridge to white when
o->style()->backgroundColor() is invalid.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
05:26 Changeset [43902] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-05-20 Shinichiro Hamaji <hamaji@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25417
Map CompositeCopy to Skia's kSrc_Mode composite operation.

Test: fast/canvas/canvas-composite-alpha.html

  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::):
04:38 Changeset [43901] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

Fix GTK debug build.

The function dumpDisjunction, compiled with debug enabled, uses
printf, which needs stdio.h to be included.

  • yarr/RegexInterpreter.cpp:
04:30 Changeset [43900] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Xan Lopez.

Remove misplaced extern "C"

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
04:16 Changeset [43899] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Expose password field with role of PASSWORD_TEXT
https://bugs.webkit.org/show_bug.cgi?id=25682

Check if input type is a password field and return
ATK_ROLE_PASSWORD_TEXT if it is.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
03:09 Changeset [43898] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
<https://bugs.webkit.org/show_bug.cgi?id=25845>

  • WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
03:08 Changeset [43897] by eric@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2009-05-20 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Remove dragging subtest from 43890 which used ? char

? is a reserved char on Windows. After removing both the ü and now the ? this
subtest is now useless, so I'm removing it entirely.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Removed.
  • editing/pasteboard/resources/file-input-files-access.js: (runTest):
02:58 Changeset [43896] by ariya@webkit.org
  • 7 edits in trunk

2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

BUG 25843: [Qt] Remove qt-port build flag
<https://bugs.webkit.org/show_bug.cgi?id=25843>

  • bridge/testbindings.pro:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • Scripts/webkitdirs.pm:
02:49 Changeset [43895] by eric@webkit.org
  • 3 edits
    1 move in trunk/LayoutTests

2009-05-20 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Fix windows and tiger builds after r43890

Commit r43890 caused:
svn: Can't convert string from 'UTF-8' to native encoding:
svn: LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra?\204?\136gging?.gif
On both the windows and tiger buildbots. According to:
http://svnbook.red-bean.com/en/1.2/svn.advanced.l10n.html
this is intentional behavior, and due to the fact that the default
LC_CTYPE for Tiger and Windows makes Subversion think the filesystems
do not support utf8.

The fix would be to execute:
export LC_CTYPE=en_US.UTF-8
On all affected machines. But since that's not going to happen,
I'm removing the utf8 chars from this filename.

This makes the drag-drop test weaker, but I see no other option.

  • editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Renamed from "LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra\314\210gging?.gif".
  • editing/pasteboard/resources/file-input-files-access.js: (moveMouseToCenterOfElement): use the unused argument (runTest): fix to use the ansii name
02:02 Changeset [43894] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=25824

[Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
and WORKERS under the appropriate build section

  • WebCore.pro:
01:40 Changeset [43893] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed Qt build fix, after r43892.

  • platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
01:22 Changeset [43892] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=25856
[Qt] notify an image has been drawn, to help Cache purge alive decoded data.

00:32 Changeset [43891] by darin@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2009-05-20 Darin Adler <darin@apple.com>

Removed stray file left after some check-ins earlier today.

  • fast/tokenizer/preload-scanner-entities.html-disabled: Removed.
00:32 Changeset [43890] by eric@webkit.org
  • 11 edits
    8 adds
    4 deletes in trunk

2009-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=25852

This allows us to now test multi-file file drags in DumpRenderTree per:
https://bugs.webkit.org/show_bug.cgi?id=25862

I removed the existing tests using addFileToPasteboardOnDrag()
and replaced them with a new test (editing/pasteboard/file-input-files-access)
which covers several more drag-drop cases.

I added a DumpRenderTreeFileDraggingSource class to avoid
the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]

New Test: editing/pasteboard/file-input-files-access.html

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
  • DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added. (-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
  • DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support (LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): ASSERT that draggingInfo has been cleared
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors. (+[EventSendingController webScriptNameForSelector:]): Sorted selectors. (-[EventSendingController beginDragWithFiles:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController keyDown:withModifiers:]): (-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support
00:24 Changeset [43889] by levin@chromium.org
  • 7 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=23727
This reverts commit r43888.

Once that change was checked in many of the fast/flexbox0*.html
tests (and others) started failing.

  • WebCore.pro:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::timerFired):

05/19/09:

21:32 Changeset [43888] by staikos@webkit.org
  • 7 edits in trunk/WebCore

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add WCSS marquee extension support to Webkit
refer to the specification: WAP-239-WCSS-20011026-a.pdf


Since WCSS is the companion of XHTML Mobile Profile (XHTML MP),
this change depends on https://bugs.webkit.org/show_bug.cgi?id=23452

https://bugs.webkit.org/show_bug.cgi?id=23727

20:49 Changeset [43887] by staikos@webkit.org
  • 5 edits
    5 adds in trunk/LayoutTests

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add tests for WCSS marquee extension support
https://bugs.webkit.org/show_bug.cgi?id=23727

20:31 Changeset [43886] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-19 Geoffrey Garen <ggaren@apple.com>

Windows build fix.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.
20:25 Changeset [43885] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
Mac OS X at <unknown binary> • 0x9274241c


(Original patch by Joe Sokol and Ronnie Misra.)


SunSpider says 1.004x faster.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated math that sometimes used to overflow, just release the full range of the register file.
  • interpreter/RegisterFile.h: (JSC::isPageAligned): (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's safe to release the full range of the register file.

(JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
new end is not smaller than the old end. (Also, doing so used to cause
numeric overflow, unmapping basically the whole process from memory.)

20:02 Changeset [43884] by eric@webkit.org
  • 2 edits in trunk/BugsSite

2009-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Make PrettyPatch understand quoted filenames in git diffs.
https://bugs.webkit.org/show_bug.cgi?id=25881

  • PrettyPatch/PrettyPatch.rb:
19:33 Changeset [43883] by weinig@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-19 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement and enable optimized calls.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Add ENABLE(JIT_OPTIMIZE_CALL) guards around the the optimize call only trampolines (virtualCallPreLink and virtualCallLink). Update the trampolines to account for the new JSValue representation. (JSC::JIT::unlinkCall): Use NULL instead of JSValue noValue.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): Update to account for the new JSValue representation (JSC::JIT::compileOpCallSlowCase): Ditto.
  • jit/JITStubs.h: Remove incorrect !ENABLE(JIT_OPTIMIZE_CALL) guard.
  • wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_CALL.
19:02 Changeset [43882] by staikos@webkit.org
  • 5 edits in trunk/WebCore

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add XHTMLMP support to Webkit
Update the configure files for building XHTMLMP-enabled WebKit on different platform
https://bugs.webkit.org/show_bug.cgi?id=23452

18:18 Changeset [43881] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
<https://bugs.webkit.org/show_bug.cgi?id=25717>

RS=Mark Rowe.

Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
resulting in weird bugs in the nightly builds.

17:44 Changeset [43880] by antti@apple.com
  • 2 edits
    1 add
    1 delete in trunk

WebCore:

2009-05-19 Antti Koivisto <antti@apple.com>

I can't figure out how to make this not timing dependent, making it manual test instead.

  • manual-tests/preload-scanner-entities.html: Added.

LayoutTests:

2009-05-19 Antti Koivisto <antti@apple.com>

I can't figure out how to make this not timing dependent, making it manual test instead.

  • fast/tokenizer/preload-scanner-entities-expected.txt: Removed.
  • fast/tokenizer/preload-scanner-entities.html: Removed.
17:43 Changeset [43879] by darin@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

2009-05-19 Darin Adler <darin@apple.com>

Renamed test failing on many buildbots to disable it.
Antti can move it back once he gets it working more consistently.

  • fast/tokenizer/preload-scanner-entities.html: Removed.
  • fast/tokenizer/preload-scanner-entities.html-disabled: Copied from fast/tokenizer/preload-scanner-entities.html.
16:41 Changeset [43878] by beidson@apple.com
  • 4 edits in trunk/WebCore

2009-05-19 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.

<rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.

This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
in QuickLooks (rdar://problem/6619630).

We need to respect the DocumentLoader's request cache policy when deciding the cache policy
for subresources, but the check (originally removed in r39304 and added back in in the same
place in r41424) needs to be tweaked and relocated a bit.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking the DocumentLoader's request to a more appropriate place. Add code to handle the recently added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code cleaner in the future.
  • loader/FrameLoader.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().
15:31 Changeset [43877] by cfleizach@apple.com
  • 5 edits
    2 adds in trunk

Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
https://bugs.webkit.org/show_bug.cgi?id=25872

14:57 Changeset [43876] by antti@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-19 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler).


<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)


Push characters back in correct order when entity parsing fails after 3 characters.

Test: fast/tokenizer/preload-scanner-entities.html

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::consumeEntity):

LayoutTests:

2009-05-19 Antti Koivisto <antti@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

  • fast/tokenizer/preload-scanner-entities-expected.txt: Added.
  • fast/tokenizer/preload-scanner-entities.html: Added.
14:53 Changeset [43875] by weinig@apple.com
  • 12 edits in branches/nitro-extreme/JavaScriptCore

2009-05-19 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement and enable optimized property access.

  • assembler/AbstractMacroAssembler.h: Fix comment.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Remove array length trampoline and implement the string length trampoline.
  • jit/JIT.h: Add new constants for patch offsets.
  • jit/JITInlineMethods.h: Remove FIELD_OFFSET which is now in StdLibExtras.h.
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add version of addArgument that takes two registers for the tag and payload.
  • jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): Remove array length trampoline pointer. (JSC::JITStubs::cti_op_get_by_id_self_fail):
  • jit/JITStubs.h:
  • runtime/JSObject.h: (JSC::JSObject::JSObject): Move m_inheritorID below the property storage to align it to a 16 byte boundary.
  • wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
  • wtf/StdLibExtras.h: Move FIELD_OFFSET here.
14:13 Changeset [43874] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-19 Paul Godavari <paul@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash in Mac Chromium when displaying an HTML select element
with no items.
https://bugs.webkit.org/show_bug.cgi?id=25874

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):
13:54 Changeset [43873] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

wxMSW build fixes for DRT.

13:53 Changeset [43872] by darin@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Restore mistaken deletion of an entry in ChangeLog

13:51 Changeset [43871] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-19 Nate Chapin <japhet@google.com>

Reviewed by Darin Fisher.

Upstream V8 bindings for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=25858

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.
13:46 Changeset [43870] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2009-05-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Mark Rowe.

Windows Build Fix.

  • WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.
12:18 Changeset [43869] by timothy@apple.com
  • 5 edits in trunk

Add a new private API method that will dispatch pending loads that have been scheduled because of recent DOM additions or style changes.

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not loaded because willSendRequest doesn't happen immediately

WebCore:

2009-05-19 Timothy Hatcher <timothy@apple.com>

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately

Reviewed by Antti Koivisto.

  • WebCore.base.exp: Export Loader::servePendingRequests().

WebKit/mac:

2009-05-19 Timothy Hatcher <timothy@apple.com>

Add a new private API method that will dispatch pending loads that have been scheduled
because of recent DOM additions or style changes.

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately

Reviewed by Antti Koivisto.

  • WebView/WebView.mm: (-[WebView _dispatchPendingLoadRequests]): Call Loader::servePendingRequests().
  • WebView/WebViewPrivate.h: Added _dispatchPendingLoadRequests.
12:08 Changeset [43868] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-19 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859

Fixing the header file (which I accidentally made identical to the cpp file).

  • bindings/v8/ScriptController.h:
11:54 Changeset [43867] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Adding a Radar URL.

11:14 Changeset [43866] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler and Brady Eidson.

REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls

The problem was that Document::removeAllEventListeners() was called for a wrong document
when a CachedFrame was destroyed.

Cannot be tested automatically, because DRT doesn't have a b/f cache.

  • dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an unrelated window even if document's m_frame pointer is stale.
  • history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.
10:53 Changeset [43865] by staikos@webkit.org
  • 5 edits
    6 adds in trunk/LayoutTests

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.


Add the XHTML MP tests but put them in skipped since they are not active
by default on any platforms.
https://bugs.webkit.org/show_bug.cgi?id=23452

09:58 Changeset [43864] by dglazkov@chromium.org
  • 16 edits
    2 adds in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.

https://bugs.webkit.org/show_bug.cgi?id=25419

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setAttachedWindow): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addScriptProfile): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didContinue):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorFrontend.cpp: Added. (WebCore::callSimpleFunction): (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::newJSONObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
  • inspector/InspectorFrontend.h: Added.
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
  • inspector/InspectorResource.h:
09:50 Changeset [43863] by mrowe@apple.com
  • 9 moves in branches/old

Clean up some old, unused branches.

09:47 Changeset [43862] by mrowe@apple.com
  • 1 copy in branches/WWDC-2009-branch

New branch.

09:45 Changeset [43861] by dglazkov@chromium.org
  • 10 edits
    1 copy
    1 add in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization

https://bugs.webkit.org/show_bug.cgi?id=25419

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
  • inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
  • inspector/JSONObject.cpp: Added. (WebCore::JSONObject::JSONObject): (WebCore::JSONObject::set): (WebCore::JSONObject::scriptObject): (WebCore::JSONObject::createNew):
  • inspector/JSONObject.h: Added.
09:36 Changeset [43860] by staikos@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Correct two changelog entries to show the bug report

09:08 Changeset [43859] by dglazkov@chromium.org
  • 11 edits in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.

https://bugs.webkit.org/show_bug.cgi?id=25419

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::bind): (WebCore::InspectorDOMStorageResource::unbind):
  • inspector/InspectorDOMStorageResource.h:
  • inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): (WebCore::InspectorDatabaseResource::unbind):
  • inspector/InspectorDatabaseResource.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
  • inspector/InspectorResource.h:
  • inspector/front-end/Console.js: (WebInspector.ConsoleMessage):
  • inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.updateResource): (WebInspector.removeResource): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.reset): (WebInspector.addMessageToConsole):
08:11 Changeset [43858] by ariya@webkit.org
  • 4 edits in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

The Qt port has code that disables scrolling optimizations
when the root contains native windows, such as windowed plugins.

This code broke when detaching iframes containing windowed
plugins.

Each ScrollView now knows how many native windows it and its
children contain, and when it is detached, that number is
substracted from its old parents.

04:45 Changeset [43857] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Do not try to free enchant broker and dictionary if they do not
exist, those functions aren't NULL-safe.

  • webkit/webkitwebsettings.cpp: (free_spell_checking_language):
01:01 Changeset [43856] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Gavin Barraclough.


  • speed up string comparison, especially for short strings


~1% on SunSpider

  • JavaScriptCore.exp:
  • runtime/UString.cpp:
  • runtime/UString.h: (JSC::operator==): Inline UString's operator==, since it is called from hot places in the runtime. Also, specialize 2-char strings in a similar way to 1-char, since we're taking the hit of a switch anyway.

05/18/09:

23:06 Changeset [43855] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Gavin Barraclough.


  • for polymorphic prototype lookups, increase the number of slots from 4 to 8


~4% faster on v8 raytrace benchmark

  • bytecode/Instruction.h:
22:39 Changeset [43854] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.


  • tighten up the code for the load_varargs stub


~1-2% on v8-raytrace


  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that the compiler didn't feel like hoisting for us. Remove unneeded exception check.
22:17 Changeset [43853] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Added cookie test to Skipped list for Windows

See Bug 25861. <https://bugs.webkit.org/show_bug.cgi?id=25861>

  • platform/win/Skipped: Added http/tests/cookies/simple-cookies-expired.html.
22:02 Changeset [43852] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix for r43850

  • platform/mac/ClipboardMac.mm: Added typedef for NSUinteger when building on Tiger.
21:52 Changeset [43851] by ddkilzer@apple.com
  • 4 edits
    18 adds in trunk

Bug 24569: Add some cookies tests

<https://bugs.webkit.org/show_bug.cgi?id=24569>

LayoutTests:

Reviewed and tweaked by David Kilzer.

This modification adds a cookie framework to check setting cookies.
It is a simple modification over the js test framework. It uses some XHRs and custom server-side script
to set / get / clear cookies.

It also adds some very basic tests to check that everything works.

  • http/tests/cookies: Added.
  • http/tests/cookies/multiple-cookies-expected.txt: Added.
  • http/tests/cookies/multiple-cookies.html: Added.
  • http/tests/cookies/resources: Added.
  • http/tests/cookies/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
  • http/tests/cookies/resources/clearCookies.cgi: Added.
  • http/tests/cookies/resources/cookies-test-post.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
  • http/tests/cookies/resources/cookies-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js. (setCookies): Internal method to set a cookie (multiple cookies are not supported). (testCookies): Internal method to check if the cookie were set.

(clearAllCookies): Used to clear all pre-existing cookies for this domain.
(clearCookies): Used to clear the cookies set with cookiesShouldBe.
(cookiesShouldBe): Used to set a cookie and check the "Cookie" header sent. It is inspired from shouldBe from the js test framework.

  • http/tests/cookies/resources/cookies-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
  • http/tests/cookies/resources/getCookies.cgi: Added.
  • http/tests/cookies/resources/multiple-cookies.js: Added.
  • http/tests/cookies/resources/setCookies.cgi: Added.
  • http/tests/cookies/resources/simple-cookies-expired.js: Added.
  • http/tests/cookies/resources/simple-cookies-max-age.js: Added.
  • http/tests/cookies/simple-cookies-expired-expected.txt: Added.
  • http/tests/cookies/simple-cookies-expired.html: Added.
  • http/tests/cookies/simple-cookies-max-age-expected.txt: Added.
  • http/tests/cookies/simple-cookies-max-age.html: Added.
  • platform/mac-tiger/Skipped: Added http/tests/cookies/simple-cookies-max-age.html since CFNetwork on Tiger doesn't support expiring cookies with Max-Age=0.

WebKitTools:

Patch by David Kilzer.

  • Scripts/make-js-test-wrappers: Added regex to skip cookies-test-(post|pre).js files.
21:17 Changeset [43850] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

ClipboardMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=25847

I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.

No functional changes, so no tests.

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::clearData): (WebCore::absoluteURLsFromPasteboardFilenames): Broke out logic for filenames into its own function to make the caller more readable. (WebCore::absoluteURLsFromPasteboard): Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray so that we can use -[NSArray componentsJoinedByString] in the caller (which is cleaner than the manual "\n" addition before). This also access to the full list of file urls for future callers. (WebCore::ClipboardMac::getData): unsigned count = (type == "URL") ? 1 : [fileList count]; is now an explicit check for "URL", before it was a check for != "text/uri-list" which was much more confusing in my opinion. text/uri-list and URL are the only two types which map to NSURLPboardType in cocoaTypeFromMIMEType(). (WebCore::ClipboardMac::types): I removed an extra if (!types) check, right before [types count]. In Obj-C messaging nil will return 0 (size of a pointer), so it's safe to message nil here and expect it to return 0.
20:40 Changeset [43849] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff Garen.

  • Improve code generation for access to prototype properties


~0.4% speedup on SunSpider.


Based on a suggestion from Geoff Garen.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
20:23 Changeset [43848] by sfalken@apple.com
  • 4 edits in trunk/WebKit

WebKit/mac:

2009-05-18 Sam Weinig <sam@webkit.org>

<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent


Add user agent hack for pointroll.com.

Reviewed by Steve Falkenburg.

  • WebView/WebView.mm: (-[WebView WebCore::_userAgentForURL:WebCore::]):

WebKit/win:

2009-05-18 Steve Falkenburg <sfalken@apple.com>

<rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent


Add user agent hack for pointroll.com.


Reviewed by Sam Weinig.

  • WebView.cpp:
17:42 Changeset [43847] by levin@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-05-18 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859

  • bindings/v8/ScriptController.cpp: Added.
  • bindings/v8/ScriptController.h: Added.
17:27 Changeset [43846] by kov@webkit.org
  • 5 edits in trunk

2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Gavin Barraclough.

Enable YARR, and disable WREC for GTK+.

  • configure.ac:
17:10 Changeset [43845] by staikos@webkit.org
  • 4 edits in trunk/WebCore

2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Change ScriptElement to support XHTMLMP in a better way

17:00 Changeset [43844] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Use python-config to get Python linking info on Unix OSes.

16:51 Changeset [43843] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix, finish up changes after the accessibility dir split.

16:48 Changeset [43842] by staikos@webkit.org
  • 16 edits
    2 adds in trunk/WebCore

2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos (and others).

Add XHTMLMP support to Webkit
XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
functionality. Most of the functionalities have already been implemented by Webkit.

The changes include:
1) Adding <noscript> support
2) Document conformance validation
3) User Agent conformance validation

15:35 Changeset [43841] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the build.

  • WebCore.xcodeproj/project.pbxproj:
13:40 Changeset [43840] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Rubber-stamped by Gustavo Noronha.

Fixed build for the Qt port by adding the WebCore/accessibility
directory to the includepath.

  • WebCore.pro:
13:22 Changeset [43839] by barraclough@apple.com
  • 17 edits in trunk/JavaScriptCore

2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.

  • GNUmakefile.am:
13:12 Changeset [43838] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-18 Gavin Barraclough <barraclough@apple.com>

Reviewed by NOBODY (speculative build fix).

12:46 Changeset [43837] by barraclough@apple.com
  • 16 edits in trunk/JavaScriptCore

2009-05-15 Gavin Barraclough <barraclough@apple.com>

Reviewed by Darin Adler.

Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.

Rationalization of all this:

  • Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
  • Change the JIT & Yarr to internally handle code using CodeRefs.
  • Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
  • Remove the (now) redundant code pointer from FunctionBodyNode.

While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.

This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
  • interpreter/CallFrameClosure.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
  • jit/JIT.h:
  • jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
  • parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
  • parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
12:11 Changeset [43836] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix, initialize variable that doesn't get set on Windows.

12:10 Changeset [43835] by cfleizach@apple.com
  • 2 edits in trunk/WebCore

Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776

Speculative fix for windows build failure.

11:59 Changeset [43834] by ddkilzer@apple.com
  • 8 edits
    2 adds in trunk

Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon

<https://bugs.webkit.org/show_bug.cgi?id=20652>

Reviewed by Darin Adler.

WebCore:

Test: http/tests/misc/favicon-as-image.html

  • inspector/front-end/inspector.js: Added image/vnd.microsoft.icon to WebInspector.MIMETypes.
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): Added image/vnd.microsoft.icon to list of supported image and image resource MIME types.

LayoutTests:

Updated existing favicon-as-image.html test to display a third
image having MIME type image/vnd.microsoft.icon.

  • http/tests/misc/favicon-as-image.html: Updated.
  • http/tests/misc/resources/.htaccess: Added.
  • http/tests/misc/resources/favicon-vnd-ms.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
  • platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Updated.
  • platform/mac/http/tests/misc/favicon-as-image-expected.png: Updated.
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt: Updated.
11:48 Changeset [43833] by cfleizach@apple.com
  • 6 edits
    46 moves
    7 adds in trunk/WebCore

Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776

10:26 Changeset [43832] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25854
[GTK] Should tell servers we only support identity as content encoding

Let servers know we only support identity as content
encoding. We will implement this in libsoup.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
08:30 Changeset [43831] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
CAPTCHA failure.

The problem was that after loading and displaying a CAPTCHA image, it was loaded from
the server again due to preloading. So, the server expected the last loaded (invisible)
CAPTCHA text to be typed and posted back.

I don't know how to make tests for preloading.

  • loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason to preload after loading for real - and if cache policy is CachePolicyReload, that actually results in another load from network layer.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy() to lie, but I don't know how to re-do r41425 properly. Added a FIXME.
07:13 Changeset [43830] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.

https://bugs.webkit.org/show_bug.cgi?id=24551

[Qt] Reuse FontPlatformData for the same FontDescription.
This effectively prevents growing heap usage for loading every web page.

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::qHash): Necessary for FontPlatformDataCache. (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if it exists, otherwise create a new one and insert it in the cache.
05:11 Changeset [43829] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-18 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

Makes QtLauncher to accept multiple urls in command line and opens these in separate windows.

  • QtLauncher/main.cpp: (MainWindow::newWindow): (main):
04:33 Changeset [43828] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=24551

[Qt] Fix the leak in FontFallbackList::fontDataAt() function.
When creating a new instance of SimpleFontData, put it in the font list
so that it can deleted later on.

  • platform/graphics/qt/FontFallbackListQt.cpp: (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt):
04:30 Changeset [43827] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Add support for running unit tests. Also run the tests whenever
the 'check' target runs.

  • GNUmakefile.am:
04:30 Changeset [43826] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Style fixes

  • GNUmakefile.am:
  • WebCore/GNUmakefile.am
04:30 Changeset [43825] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Add -no-install and -no-fast-install to programs and tests that we
don't install. Also remove -O2 since this is already handled at
configure time.

  • GNUmakefile.am:
  • JavaScriptCore/GNUmakefile.am:
  • WebKitTools/GNUmakefile.am:
04:30 Changeset [43824] by jmalonzo@webkit.org
  • 4 edits in trunk

2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Add JavaScriptCore/ to JSC include path only since it's not
required when building WebCore.

  • GNUmakefile.am:

2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Refactor library cflags

  • GNUmakefile.am:
04:11 Changeset [43823] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-18 Julie Parent <jparent@google.com>

Reviewed by Eric Seidel.

Skip new tests from r43822 on Gtk
https://bugs.webkit.org/show_bug.cgi?id=25780

  • platform/gtk/Skipped:
03:55 Changeset [43822] by eric@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2009-05-18 Julie Parent <jparent@google.com>

Reviewed by Oliver Hunt.

Add missing files from r43821
https://bugs.webkit.org/show_bug.cgi?id=25780

  • editing/pasteboard/get-data-text-plain-drop-expected.txt: Added.
  • editing/pasteboard/get-data-text-plain-drop.html: Added.
  • editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
  • editing/pasteboard/get-data-text-plain-paste.html: Added.
  • editing/pasteboard/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
  • editing/pasteboard/resources/get-data-text-plain-paste.js: Added. (handlePaste):
03:29 Changeset [43821] by eric@webkit.org
  • 5 edits in trunk

2009-05-18 Julie Parent <jparent@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25716

  • Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.
03:11 Changeset [43820] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-18 Julie Parent <jparent@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25716

  • Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.

05/17/09:

22:24 Changeset [43819] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-17 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove unneeded ExecState parameter from the number JSValue constructors.

  • runtime/JSValue.h: (JSC::jsNumber): (JSC::jsNaN): (JSC::JSValue::JSValue):
18:20 Changeset [43818] by sfalken@apple.com
  • 3 edits in trunk/JavaScriptCore

Windows build fix

17:31 Changeset [43817] by mitz@apple.com
  • 90 edits
    1 move in trunk/LayoutTests

Reviewed by David Kilzer.

  • move fast/repaint/repaint.js into the resources subdirectory
  • fast/repaint/repaint.js: Removed.
  • fast/repaint/resources/repaint.js: Copied from fast/repaint/repaint.js.
  • (89 tests changed to load the script from the new location)
13:11 Changeset [43816] by staikos@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for WML: constr->const

13:06 Changeset [43815] by darin@apple.com
  • 2 edits
    1 add in trunk/WebCore

2009-05-17 Darin Adler <darin@apple.com>

Fix done by Simon Fraser (reviewed by me).

<rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
transitions has bad layout and overlapping garbled text when printing

  • manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.
  • page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.
12:12 Changeset [43814] by darin@apple.com
  • 2 edits
    1 add in trunk/WebCore

2009-05-17 Darin Adler <darin@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and also a type check on the selected index to avoid a bad cast to HTMLOptionElement.
  • manual-tests/select-option-in-onload.html: Added.
11:34 Changeset [43813] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2009-05-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson

Rename local variables for readability.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):
10:50 Changeset [43812] by darin@apple.com
  • 2 edits in trunk/LayoutTests

2009-05-17 Darin Adler <darin@apple.com>

  • platform/gtk/Skipped: Disable another media test that seems to be failing at least intermittently.
10:47 Changeset [43811] by darin@apple.com
  • 4 edits in trunk/WebCore

2009-05-17 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Bug 25840: fix some warnings seen on the GTK bot
https://bugs.webkit.org/show_bug.cgi?id=25840

  • platform/ScrollView.cpp: (WebCore::ScrollView::platformScrollbarModes): Initialize results here. This is really just to quiet warnings. I think this code is unreachable. Someone could put ASSERT_NOT_REACHED() in here too at some point.
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Use proper printf format for int here, %d, not %lu. This could cause a real problem when compiled 64-bit, so it's good to fix.
  • rendering/RenderTextControl.cpp: (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is really just to quiet the warning, but still seems like a good idea.
09:50 Changeset [43810] by darin@apple.com
  • 3 edits in trunk/WebCore

2009-05-17 Chris Fleizach <cfleizach@apple.com>

Reviewed by Darin Adler.

Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769

  • page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::columnCount): Get rid of excess const. (WebCore::AccessibilityTable::rowCount): Ditto.
  • page/AccessibilityTable.h: Ditto.
09:47 Changeset [43809] by darin@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-17 Kai Brüning <kai@granus.net>

Reviewed by Darin Adler.

bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822

Test: fast/dom/Node/normalize.html

  • dom/Node.cpp: (WebCore::Node::normalize): Changed to remove any empty text nodes.

LayoutTests:

2009-05-17 Kai Brüning <kai@granus.net>

Reviewed by Darin Adler.


Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822


The test case strives to test the whole functionality of Node's normalize().

  • fast/dom/Node/normalize-expected.txt: Added.
  • fast/dom/Node/normalize.html: Added.

05/16/09:

20:44 Changeset [43808] by mrowe@apple.com
  • 4 edits in trunk/WebCore

2009-05-16 Dave Moore <davemoore@google.com>

Reviewed by Darin Adler.

Allow Strings to be created with one malloc node with no copying
https://bugs.webkit.org/show_bug.cgi?id=25779

Add new methods to String and StringImpl, refactoring existing
methods in StringImpl to use new createUninitialized() method.

  • platform/text/PlatformString.h: (WebCore::String::createUninitialized):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::createUninitialized): (WebCore::StringImpl::create):
  • platform/text/StringImpl.h:
20:38 Changeset [43807] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance

Reviewed by Darin Adler.

Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.

This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

14:51 Changeset [43806] by andersca@apple.com
  • 4 edits in trunk/WebKit

WebKit:

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>.


  • English.lproj/Localizable.strings:

WebKit/mac:

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
13:21 Changeset [43805] by mitz@apple.com
  • 9 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png

13:06 Changeset [43804] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • revert an accidental change from r43802.
  • WebInspector/WebInspector.mm:
12:58 Changeset [43803] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page


Fix logic. The plug-in returns true if it handled the event.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
12:56 Changeset [43802] by mitz@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

  • fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget

Test: platform/mac/editing/pasteboard/text-precomposed.html

Ensure that "text/plain" data retrieved from the clipboard is always
precomposed. This makes Clipboard::getData() and
Pasteboard::documentFragment() consistent with Pasteboard::plainText()
and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):

WebKit/mac:

Reviewed by Alexey Proskuryakov.

  • fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
  • WebView/WebHTMLView.mm: (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text. This is consistent with -_documentFragmentFromPasteboard:forType:inContext:subresources:.

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • test for <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
  • platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
  • platform/mac/editing/pasteboard/text-precomposed.html: Added.
02:11 Changeset [43801] by zecke@webkit.org
  • 4 edits in trunk

[GTK] Merge r41819 into Gtk to log through the JS console

https://bugs.webkit.org/show_bug.cgi?id=25787

Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.

02:10 Changeset [43800] by zecke@webkit.org
  • 4 edits in trunk

[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html

WebKitTools:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Jan Michael Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25787

Forward port r39877 from main.c of OSX to TestNetscapePlugin
of Gtk.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):

LayoutTests:
2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Jan Michael Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25787

Enable plugins/npruntime.html

  • platform/gtk/Skipped:
00:56 Changeset [43799] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily): Declare valueForFamily as static.

Note: See TracTimeline for information about the timeline view.