Timeline


and

05/25/09:

23:20 Changeset [44147] by ap@webkit.org

Reviewed by Darin Adler.

<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
23:03 Changeset [44146] by ggaren@apple.com

JavaScriptCore:

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed a regression when comparing to NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.

LayoutTests:

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added test for NaN comparisons.


  • fast/js/nan-expected.txt: Added.
  • fast/js/nan.html: Added.
  • fast/js/resources/nan.js: Added. ():
21:21 Changeset [44145] by levin@chromium.org

JavaScriptCore:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.

In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds

+ m_sharedBuffer -- a pointer to the shared ref counted buffer

if the class is BaseString and the buffer is being shared OR

+ m_baseString -- the BaseString if the class is only UString::Rep

but not a UString::BaseString

Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.

No change in sunspider perf.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
  • runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
  • wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):

JavaScriptGlue:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25126

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.

WebCore:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
21:00 Changeset [44144] by ggaren@apple.com

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


SunSpider says no change.


Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
17:20 Changeset [44143] by oliver@apple.com

Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it

Reviewed by Maciej Stachowiak

17:08 Changeset [44142] by weinig@apple.com

2009-05-25 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
16:52 Changeset [44141] by mrowe@apple.com

Merge r44136.

16:52 Changeset [44140] by mrowe@apple.com

Merge r44132.

16:52 Changeset [44139] by mrowe@apple.com

Merge r44075.

16:52 Changeset [44138] by mrowe@apple.com

Merge r44069.

16:51 Changeset [44137] by mrowe@apple.com

Merge r44066.

15:48 Changeset [44136] by andersca@apple.com

WebCore:

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • WebCore side of <rdar://problem/6914001>.

Add a new m_allowPopupsFromPlugin flag.


  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

WebKit/mac:

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • WebKit side of <rdar://problem/6914001>.
  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".


  • Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
14:33 Changeset [44135] by abarth@webkit.org

WebCore:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26006

Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:

1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.

Tests: http/tests/security/frameNavigation/context-for-location-assign.html

http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
  • bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <abarth@webkit.og>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26006

Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.

  • http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-assign.html: Added.
  • http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href.html: Added.
  • http/tests/security/frameNavigation/context-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/target-for-location.html: Added.
14:11 Changeset [44134] by abarth@webkit.org

Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)

12:33 Changeset [44133] by abarth@webkit.org

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26011

Try to make test less flaky.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
  • http/tests/security/postMessage/origin-follows-lexical-scope.html:
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
  • http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
11:48 Changeset [44132] by andersca@apple.com

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • Fix <rdar://problem/6915849>.


Release the placeholder window after -[NSApplication runModalForWindow] returns.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
08:41 Changeset [44131] by xan@webkit.org

2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

The functions written in assembly need to have a leading
underscore on Windows too.

  • jit/JITStubs.cpp:
08:41 Changeset [44130] by xan@webkit.org

2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
05:55 Changeset [44129] by hausmann@webkit.org

2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Simon Hausmann.

Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.

05:39 Changeset [44128] by hausmann@webkit.org

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=25612

Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.

Made the Audio and Video elements conditional in the tag factories

04:45 Changeset [44127] by hausmann@webkit.org

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Gtk build when video is disabled.

04:35 Changeset [44126] by hausmann@webkit.org

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build when video is disabled.

  • WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
01:36 Changeset [44125] by abarth@webkit.org

Fix ChangeLog typo.

01:29 Changeset [44124] by abarth@webkit.org

WebCore:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26004

The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.

Test: http/tests/security/postMessage/origin-follows-lexical-scope.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26004

Test that the origin for postMessage follows the lexical scope.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.

05/24/09:

23:27 Changeset [44123] by darin@chromium.org

2009-05-24 Darin Fisher <darin@chromium.org>

Reviewed by Mark Rowe.

Fix build bustage related to PassOwnPtr changes.

https://bugs.webkit.org/show_bug.cgi?id=25999

  • platform/graphics/chromium/TransparencyWin.cpp:
22:20 Changeset [44122] by mitz@apple.com
  • revert an accidental change from r43964.
  • WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
20:29 Changeset [44121] by zecke@webkit.org

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
20:29 Changeset [44120] by zecke@webkit.org

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.

  • GNUmakefile.am:
  • WebCore.pro:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/qt/PluginPackageQt.cpp:
20:28 Changeset [44119] by zecke@webkit.org

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.

The PluginPackageWin version got copied to PluginPackage

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
15:43 Changeset [44118] by krit@webkit.org

2009-05-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Added standard input for filter system.

No testcases were added. Filter system is still off.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
  • platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
  • platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
  • platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
  • svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
  • svg/FilterBuilder.h:
12:35 QtWebKitContrib edited by hausmann@webkit.org
(diff)
11:13 Changeset [44117] by sfalken@apple.com

2009-05-24 Steve Falkenburg <sfalken@apple.com>

Build fix for experimental PGO Windows target.


11:10 Changeset [44116] by hausmann@webkit.org

2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25612

Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.

Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).

09:34 Changeset [44115] by darin@apple.com

2009-05-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein and Tim Hatcher.

<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a

  • Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
08:34 Changeset [44114] by darin@apple.com

2009-05-24 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
00:48 Changeset [44113] by xan@webkit.org

2009-05-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation

Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):

05/23/09:

23:38 Changeset [44112] by zecke@webkit.org

Unreviewed build fix for Qt. Change signature to have PassOwnPtr.

22:14 Changeset [44111] by mrowe@apple.com

Land the updated version of WebKitLauncher that the nightly builds have been using.

Reviewed by Oliver Hunt.

Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the

launch process to be detected by the extension-detection code.

  • WebKitLauncher/Configurations/Base.xcconfig: Added.
  • WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
  • WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
  • WebKitLauncher/Info.plist:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitNightlyEnabler.h: Added.
  • WebKitLauncher/WebKitNightlyEnabler.m:

(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):

  • WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
  • WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.

(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):

  • WebKitLauncher/main.m:

(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):

21:21 Changeset [44110] by jmalonzo@webkit.org

Fix typo "am" -> "an" in the Changelog of my previous commit

21:06 Changeset [44109] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed build fix. Add gstreamer-video-0.10 libs to
GSTREAMER_LIBS to resolve am undefined reference to gst_video_get_size

  • symbol used in MediaPlayerPrivateGstreamer.
  • configure.ac:
16:28 Changeset [44108] by mitz@apple.com

Reviewed by Darin Adler.

  • clean up ColorMac a little
  • platform/graphics/mac/ColorMac.h: Whitespace change.
  • platform/graphics/mac/ColorMac.mm: Removed redundant #import statements and sorted the remaining ones. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls with a single call and removed redundant casts to int. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats. In one case, this avoids an intermediate conversion to float before conversion to double on 64-bit. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls with a single call. (WebCore::focusRingColor): (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
15:55 Changeset [44107] by ggaren@apple.com

2009-05-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Refactored new slow case codegen for == and !=.


SunSpider reports no change, maybe a tiny speedup.

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation, instead of *32, to make it portable to 64bit. Reorganized the string and generic cases to make their control flow a little clearer.
15:39 Changeset [44106] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Break the switch once private browsing is selected.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property): (webkit_web_settings_get_property):
15:35 Changeset [44105] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Enable storage/ tests for Gtk.

  • platform/gtk/Skipped:

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Add settings to enable or disable database and localStorage
support and enable them by default. This allows databases to be
shown in the WebInspector as well as allow us to run the storage
layout tests.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Enable database and localStorage for running the storage/ tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
15:22 Changeset [44104] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
https://bugs.webkit.org/show_bug.cgi?id=25900

Use ATK_ROLE_TEXT for ListMarkerRole.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
15:20 Changeset [44103] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Refactor library LIBS. Move third-party libs in libwebkit instead
of libWebCore.

  • GNUmakefile.am:
15:08 Changeset [44102] by ddkilzer@apple.com

Reformat WebCore::requiresContextForWordBoundary()

  • platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary):
14:29 Changeset [44101] by zimmermann@webkit.org

Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.

14:25 Changeset [44100] by zimmermann@webkit.org

Reviewed by Darin Adler.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808

After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.

WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
HTMLSelectElement/WMLSelectElement.

10:32 Changeset [44099] by ddkilzer@apple.com

Fix Gtk/Qt builds for PassOwnPtr

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer> instead of an std::auto_ptr<ImageBuffer> to store the result of ImageBuffer::create() now that it returns a PassOwnPtr<ImageBuffer>.
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): Ditto. (WebCore::Path::strokeBoundingRect): Ditto.
10:16 Changeset [44098] by ddkilzer@apple.com

Windows build fix for PassOwnPtr

  • WebHistory.cpp: (WebHistory::visitedURL): Changed std::auto_ptr<Vector<String> >() to 0.
  • WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Changed type of redirectURLsVector from std::auto_ptr<Vector<String> > to OwnPtr<Vector<String> >.
10:06 Changeset [44097] by ggaren@apple.com

2009-05-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Optimized == and != for our new value representation -- especially for strings.


14% speedup on date-format-tofte.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_eq_strings): (JSC::JITStubs::cti_op_call_eval):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSValue.h:
09:39 Changeset [44096] by ddkilzer@apple.com

Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr

<https://bugs.webkit.org/show_bug.cgi?id=25495>

Reviewed by Oliver Hunt.

WebCore:

No test cases added since there is no change in behavior.

  • WebCore.base.exp: Updated export for HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
  • dom/Node.cpp: (WebCore::Node::childNodes): Use NodeListsNodeData::create() instead of new NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::getElementsByTagNameNS): Ditto. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto.
  • dom/NodeRareData.h: (WebCore::NodeListsNodeData::create): Added. Implements create() pattern popularized by RefCounted classes. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared private constructor. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<> instead of an auto_ptr<>.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::setRedirectURLs): Ditto.
  • history/HistoryItem.h: (WebCore::HistoryItem::setRedirectURLs): Ditto.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
  • page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/text/TextCodec.h: (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of auto_ptr<>.
  • platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): Ditto.
  • platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
  • platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): Ditto. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
  • platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined): Ditto.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::newTextCodec): Ditto.
  • platform/text/TextEncodingRegistry.h: (WebCore::newTextCodec): Ditto.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac): Ditto.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return OwnPtr<> instead of auto_ptr<>.
  • svg/SVGMaskElement.h: (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<> instead of auto_ptr<>.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>.
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask): Updated to use assignment operator now that SVGMaskElement::drawMaskerContent() returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/mac:

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Return 0 instead of an empty auto_ptr<>.
  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/win:

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/wx:

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
09:39 Changeset [44095] by ddkilzer@apple.com

Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr

<https://bugs.webkit.org/show_bug.cgi?id=25495>

Reviewed by Oliver Hunt.

JavaScriptCore:

  • GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/OwnPtr.h: (WTF::OwnPtr::OwnPtr): Added constructors that take a PassOwnPtr. Also added a copy constructor declaration that's required when assigning a PassOwnPtr to a stack-based OwnPtr. (WTF::operator=): Added assignment operator methods that take a PassOwnPtr. (WTF::swap): Reformatted. (WTF::operator==): Whitespace changes. (WTF::operator!=): Ditto.
  • wtf/OwnPtrCommon.h: Added. (WTF::deleteOwnedPtr):
  • wtf/PassOwnPtr.h: Added. (WTF::PassOwnPtr::PassOwnPtr): (WTF::PassOwnPtr::~PassOwnPtr): (WTF::PassOwnPtr::get): (WTF::PassOwnPtr::clear): (WTF::PassOwnPtr::release): (WTF::PassOwnPtr::operator*): (WTF::PassOwnPtr::operator->): (WTF::PassOwnPtr::operator!): (WTF::PassOwnPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):

JavaScriptGlue:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.

WebCore:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.
  • WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and PassOwnPtr.h.

WebKit/mac:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
09:15 Changeset [44094] by ddkilzer@apple.com

Fix Mac builds by backing out r44093

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp:
  • page/Geolocation.idl:
  • page/Geoposition.cpp:
  • page/Geoposition.h:
  • page/Geoposition.idl:
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
  • page/PositionError.idl:
  • platform/GeolocationService.cpp: (WebCore::GeolocationService::create):
08:28 Changeset [44093] by zecke@webkit.org

2009-05-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Add GEOLOCATION guards around Geolocation API code
https://bugs.webkit.org/show_bug.cgi?id=25756

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp:
  • page/Geolocation.idl:
  • page/Geoposition.cpp:
  • page/Geoposition.h:
  • page/Geoposition.idl:
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
  • page/PositionError.idl:
  • platform/GeolocationService.cpp:
08:21 Changeset [44092] by ddkilzer@apple.com

resolve-ChangeLogs: Add missing newline to status message

  • Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -ccontinue switch is used but there

are unmerged files remaining in the git working directory.

08:07 Changeset [44091] by ddkilzer@apple.com

Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher

In r42377, startUpdateRenderingDispatcher() was renamed to
startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
dropped. This change restores it.

  • WebCore.order:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  • page/animation/AnimationControllerPrivate.h:
07:03 Changeset [44090] by zecke@webkit.org

2009-05-23 Jakob Truelsen <antialize@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25863

Expose the default text encoding property to Qt.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setDefaultTextEncoding): (QWebSettings::defaultTextEncoding):
  • Api/qwebsettings.h:
06:55 Changeset [44089] by zecke@webkit.org

Unreviewed build-fix for Qt. Disable SVG Filters.

SVG Filters can not be built right now and Qt should not have
them enabled anyway as they did not carry out any filtering.

04:08 Changeset [44088] by oliver@apple.com

Remove interpreter specific logic from the JIT builds

Reviewed by Maciej Stachowiak.

This saves ~100k in JSC release builds.

02:06 Changeset [44087] by oliver@apple.com

Add tests to cover exceptions thrown from non-object results of get_by_id

Reviewed by Maciej Stachowiak

01:25 Changeset [44086] by eric@webkit.org

Add an error message to a die statement

00:32 Changeset [44085] by krit@webkit.org

2009-05-23 Dirk Schulze <krit@webkit.org>

Unreviewed build-fix for gtk. Remove source input files
for SVG filter system from the build for the moment and
add them later again.

  • GNUmakefile.am:
00:22 Changeset [44084] by jmalonzo@webkit.org

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed. Skip new tests introduced in r44010. These tests
require an eventSender implementation which the gtk port
currently do not have.

Also remove gtk-specific result for
fast/canvas/canvas-composite-alpha. The non-platform specific
result now works.

  • platform/gtk/Skipped:
  • platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Removed.
00:19 Changeset [44083] by krit@webkit.org

2009-05-23 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Preparing Filter primitves for the new filter system.

No testcases were added. SVG filters are off by default.

  • GNUmakefile.am:
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • svg/Filter.h:
  • svg/FilterBuilder.h: (WebCore::FilterBuilder::lastFilter):
  • svg/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
  • svg/FilterEffect.h: (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:

05/22/09:

23:25 Changeset [44082] by krit@webkit.org

2009-05-22 Dirk Schulze <krit@webkit.org>

Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
23:00 Changeset [44081] by krit@webkit.org

2009-05-22 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added the use of tileRect() for a correct drawing of
border-images.

Testcases for border-image are in fast/borders like
border-image-01.html and will be activated for cairo, once
gtk supports pixel tests.

https://bugs.webkit.org/show_bug.cgi?id=19652
[CAIRO] wrong drawing of border-image

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
22:47 Changeset [44080] by mrowe@apple.com

Part two of an attempted Windows build fix.

22:47 Changeset [44079] by zecke@webkit.org

Ask the Scrollbar for the orientation.

https://bugs.webkit.org/show_bug.cgi?id=25684

Use Scrollbar::orientation to figure out the
direction of scrolling.

22:13 Changeset [44078] by mrowe@apple.com

Part one of an attempted Windows build fix.

21:51 Changeset [44077] by kov@webkit.org

Improve network request docs

18:48 Changeset [44076] by barraclough@apple.com

2009-05-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

op_method_check

Optimize method calls, by caching specific function values within the Structure.
The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
where the property access is being used to read a function to be passed to op-call (i.e.
'foo.bar();'). This patch modifies the Structure class such that when a property is
put to an object for the first time we will check if the value is a function. If it is,
we will cache the function value on the Structure. A Structure in such a state guarantees
that not only does a property with the given identifier exist on the object, but also that
its value is unchanged. Upon any further attempt to put a property with the same identifier
(but a different value) to the object, it will transition back to a normal Structure (where
it will guarantee the presence but not the value of the property).

op_method_check makes use of the new information made available by the Structure, by
augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
check will be emitted prior to the property access reading the function value, and the JIT
will generate an extra (initially unlinked but patchable) set of checks prior to the regular
JIT code for get_by_id. The new code will do inline structure and prototype structure check
(unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
an immediate load of the function value, rather than using memory accesses to load the value
from the obejct's property storage array. If the method check fails it will revert, or if
the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
just as any other regular op_get_by_id would.

~2.5% on v8-tests, due to a ~9% progression on richards.

  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor):
  • JavaScriptCore.exp:
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::differenceBetween):
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::moveWithPatch):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::getMethodCallLinkInfoReturnLocation): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::addMethodCallLinkInfos): (JSC::CodeBlock::methodCallLinkInfo):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitMethodCheck):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
  • jit/JIT.h: (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
  • jit/JITOpcodes.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchMethodCallProto):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check): (JSC::JITStubs::cti_op_get_by_id_method_check_second):
  • jit/JITStubs.h:
  • jsc.cpp: (GlobalObject::GlobalObject):
  • parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
  • runtime/Arguments.cpp: (JSC::Arguments::put):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): (JSC::constructError):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSActivation.cpp: (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::mark):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::methodCallDummy):
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::getPropertySpecificFunction): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition):
  • runtime/JSObject.h: (JSC::getJSFunction): (JSC::JSObject::getDirectLocation): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parseObject):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::): (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::setDespecifyFunctionProperty): (JSC::PutPropertySlot::isCacheable): (JSC::PutPropertySlot::cachedOffset):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changeFunctionTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::put): (JSC::Structure::remove):
  • runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::specificFunction):
  • runtime/StructureTransitionTable.h: (JSC::StructureTransitionTableHashTraits::emptyValue):
  • wtf/Platform.h:
18:34 Changeset [44075] by mitz@apple.com

WebCore:

2009-05-22 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6916082> Incorrect handling of % as CSS value.

Test: fast/css/percent-character-as-value.html

  • css/CSSGrammar.y: Make a stray % character reliably cause CSS parsing to succeed, but the CSS value to be ignored because of incorrect type. A type of 0 has this effect.

LayoutTests:

2009-05-22 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6916082> Incorrect handling of % as CSS value.

  • fast/css/percent-character-as-value-expected.txt: Added.
  • fast/css/percent-character-as-value.html: Added.
18:01 Changeset [44074] by ddkilzer@apple.com

Add bugs.webkit.org URL for r44046

17:59 Changeset [44073] by bfulgham@webkit.org

WebCore:

2009-05-22 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25971
Correct a handful of build errors in the Windows Cairo variant
due to missing VIDEO support.

  • WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for the Cairo-based Windows target.
  • rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls for non-VIDEO builds.

WebKit/win:

2009-05-22 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=25971
Correct some build errors for Windows Cairo variant.

  • WebKit.vcproj/WebKit.vcproj: Remove WTF.lib link commands as the new JavaScriptCore.dll supplies this now.
17:54 Changeset [44072] by mrowe@apple.com

Versioning.

17:53 Changeset [44071] by mrowe@apple.com

New tag.

17:48 Changeset [44070] by ddkilzer@apple.com

One <limits> is enough

  • html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
15:58 Changeset [44069] by mitz@apple.com

2009-05-22 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • Fix <rdar://problem/6913765> REGRESSION (r42331-r42334): Extra scroll bars appearing on Welcome panels of iLife '09 apps
  • WebView/WebView.mm: (needsUnwantedScrollBarWorkaround): Added. Checks if this is a panel where scroll bars are unwanted. For safety, limited to only Apple applications. (-[WebView viewDidMoveToWindow]): If the workaround is needed, disallow scrolling the main frame. This prevents scroll bars from appearing.
14:57 Changeset [44068] by weinig@apple.com

2009-05-22 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Fix non-SSE enabled builds.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): Don't early return here, we still need to call the JIT stub. (JSC::JIT::emitSlow_op_sub): Ditto.
14:54 Changeset [44067] by ggaren@apple.com

2009-05-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Here's a thought: let's not take a jit stub call just to multiply by 1,
bokay?


imul doesn't set the zero flag, so to test for a zero result, we need
an explicit instruction. (Luckily, it does set the overflow flag, so
we can still use that.)

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32InPlace):
14:30 Changeset [44066] by jhoneycutt@apple.com

2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>

<rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
plug-in

Reviewed by Steve Falkenburg.

  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Look for the VLC plug-in's new name.
14:15 Changeset [44065] by abarth@webkit.org

2009-05-22 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25966

Remove redudant member from Chromium's ResourceRequest. We already
have this data in the cross-platform ResourceRequestBase. Also, rename
ChromiumBridge parameter to be consistant with the new name for this
piece of data.

  • platform/chromium/ChromiumBridge.h:
  • platform/network/chromium/ResourceRequest.h:
14:14 Changeset [44064] by weinig@apple.com

2009-05-22 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey "Premature Commit" Garen.

Add back constant integer cases for op_add.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateDouble): (JSC::JIT::isOperandConstantImmediateDouble):
14:11 Changeset [44063] by bfulgham@webkit.org

Modify projects to use CFLite when not building the Apple Windows port.

14:07 Changeset [44062] by ggaren@apple.com

2009-05-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Added fast double cases for op_jnless and op_jnlesseq.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::JumpList::jumps): New accesor, used by addSlowCase.
  • assembler/X86Assembler.h: (JSC::X86Assembler::ucomisd_rm): New method for comparing register to memory.
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_div): Modified emitBinaryDoubleOp to accept comparison/jump operations in addition to operations with explicit result registers.
  • jit/JITInlineMethods.h: (JSC::JIT::addSlowCase): Added an "addSlowCase" for JumpLists, so clients can track multiple jumps to the same slow case condition together.
13:48 Changeset [44061] by mitz@apple.com

2009-05-22 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • Made the global-function-resolve test independent of hashing order by using a fixed set of properties. This also removes the need for us to update this test every time we add something to the window object or the js-test-pre.js family of scripts.
  • fast/js/global-function-resolve-expected.txt: Updated.
  • fast/js/resources/global-function-resolve.js: Use a fixed array instead of using all property names from the global object; also made other small changes that don't have an effect on the substance of the test.
13:35 Changeset [44060] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Triple-click support for wx port. Also, switch to allocating GraphicsContext
on the stack in OnPaint since we only need it within that function.

https://bugs.webkit.org/show_bug.cgi?id=25962

13:32 Changeset [44059] by kevino@webkit.org

Date fix on ChangeLog.

13:31 Changeset [44058] by mitz@apple.com

Reviewed by Darin Adler.

  • remove a test that was supposed to test the text/* change to MIME types from r43979, since the change was rolled out, and the test seems to be ineffective anyway, since it was passing on Mac after rolling out the change.
  • http/tests/mime/accept-all-text-types-expected.txt: Removed.
  • http/tests/mime/accept-all-text-types.html: Removed.
13:11 Changeset [44057] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Only account for overhang for multi-character strings.

https://bugs.webkit.org/show_bug.cgi?id=25961

13:03 Changeset [44056] by kevino@webkit.org

wx build fix. Switch to CURL cookies so we can benefit from API updates.

12:41 Changeset [44055] by kov@webkit.org

Fixing changelog message

12:40 Changeset [44054] by kov@webkit.org

2009-05-22 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

Make Gtk build not bail out if gtk-doc-tools is not installed.

Warning message dumped instead.

  • autogen.sh:
12:07 Changeset [44053] by kov@webkit.org

2009-05-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Add big warnings about the glib unicode backend being slow and
incomplete, since it is a work in progress.

  • autotools/webkit.m4:
  • configure.ac:
12:06 Changeset [44052] by xan@webkit.org

2009-05-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=24818
[GTK] http auth dialog pops up twice after a cancelled atempt

Workaround libsoup bug
http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
libsoup emit the 'authenticate' signal more often than it was
expected.

We'll be able to remove this when we depend on libsoup > 2.26.2.

  • webkit/webkitsoupauthdialog.c: (session_authenticate):
11:39 Changeset [44051] by pkasting@chromium.org

2009-05-22 Peter Kasting <pkasting@google.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=25709 part one
Indent contents of namespaces in header files, to comply with the
style guide. No functional change.

  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::ensureHeight): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::m_failed): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache):
  • platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
  • platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
  • platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader): (WebCore::JPEGImageDecoder::setSize):
  • platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader): (WebCore::PNGImageDecoder::decodingFailed):
  • platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
11:06 Changeset [44050] by kov@webkit.org

WebCore

2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib

Minor changes that allow building a hybrid version of WebKit
that has WTF Unicode backend based on GLib functions while
text codecs and TextBreakIterator remain based on ICU.

Fixed some includes that were assuming a WTF ICU backend and
introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
macro.

  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
  • platform/ThreadGlobalData.h:
  • platform/text/TextBoundariesICU.cpp:
  • platform/text/TextCodecICU.h:
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):

JavaScriptCore

2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib

Original patch by Jürg Billeter and Naiem Shaik.
Implementing WTF Unicode functionality based on GLib.

  • GNUmakefile.am:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/glib: Added.
  • wtf/unicode/glib/UnicodeGLib.cpp: Added. (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::direction): (WTF::Unicode::umemcasecmp):
  • wtf/unicode/glib/UnicodeGLib.h: Added. (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isArabicChar): (WTF::Unicode::isFormatChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::isLower): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType):
  • wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
09:59 Changeset [44049] by abarth@webkit.org

Unreviewed build fix.

09:45 Changeset [44048] by abarth@webkit.org

WebCore:

2009-05-22 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25955

Remove the policyBaseURL parameter from setCookie. This parameter is
redundant with the document parameter.

  • WebCore.base.exp:
  • WebCore.order:
  • dom/Document.cpp: (WebCore::Document::setCookie):
  • platform/CookieJar.h:
  • platform/mac/CookieJar.mm: (WebCore::setCookies):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::setCookies):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::setCookies):
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies):
  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies):

WebKit/mac:

2009-05-22 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25955

Remove the policyBaseURL parameter from setCookie. This parameter is
redudant with the document parameter.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::setCookies):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setVariable:forURL:value:length:]):
09:44 Changeset [44047] by abarth@webkit.org

2009-05-22 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
previous names were confusing and inaccurate.

  • WebCore.order:
  • dom/Document.cpp: (WebCore::Document::setCookie):
  • dom/Document.h: (WebCore::Document::firstPartyForCookies): (WebCore::Document::setFirstPartyForCookies):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::setFirstPartyForCookies): (WebCore::FrameLoader::open): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
  • platform/CookieJar.h:
  • platform/mac/CookieJar.mm: (WebCore::setCookies):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies): (WebCore::equalIgnoringHeaderFields):
  • platform/network/ResourceRequestBase.h:
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
09:08 Changeset [44046] by timothy@apple.com

Fix the call to editingCancelled to be this._editingCancelled, since
editingCancelled doesn't exist and throws an exception.

Reviewed by Timothy Hatcher.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
08:33 Changeset [44045] by hausmann@webkit.org

2009-05-22 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Simon Hausmann.

Fixed --makeargs usage in Qt build.

08:00 Changeset [44044] by ap@webkit.org

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25928
Several errors detected by cppcheck

Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
should take a look at other reports.

  • css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there are billions of those.
07:26 Changeset [44043] by hausmann@webkit.org

2009-05-22 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Correcting error message on missing WEBKIT_TESTFONTS
environment varible in Qt-port.

07:26 Changeset [44042] by hausmann@webkit.org

2009-05-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Skip tests depending on platform dependent results.

06:24 Changeset [44041] by eric@webkit.org

2009-05-22 Shinichiro Hamaji <hamaji@google.com>

Reviewed by Oliver Hunt.

Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).

https://bugs.webkit.org/show_bug.cgi?id=25956

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::strokeRect):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
06:12 Changeset [44040] by hausmann@webkit.org

2009-05-21 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Additional test for resource load (CSS file) for QWebFrame.

  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/style.css: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
06:03 QtWebKitContrib edited by hausmann@webkit.org
(diff)
02:10 QtWebKitContrib edited by hausmann@webkit.org
(diff)
01:37 Changeset [44039] by xan@webkit.org

2009-05-22 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Revert the whole thing, since we can't figure out a way to make it
work in all platforms.

  • rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
01:36 Changeset [44038] by hausmann@webkit.org

2009-05-22 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed Qt build fix.

Provide dummy implementation of pure virtual EditorClient method.

01:20 Changeset [44037] by xan@webkit.org

2009-05-22 Xan Lopez <xlopez@igalia.com>

Try to fix Windows build.

Apparently it can't tell if '1.0f' is float or double, so cast to
float.

  • rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
01:11 Changeset [44036] by xan@webkit.org

2009-05-22 Xan Lopez <xlopez@igalia.com>

Try to fix breakage from the previous patch.

  • rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
00:28 Changeset [44035] by xan@webkit.org

2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25805
In debug build, mingw win32 build has problems with powf

Change C-style calls to powf and sqrtf to C++-style calls to
overloaded pow and sqrt. This solves also a problem with mingw
compiler during the debug build.

  • rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):

05/21/09:

23:20 Changeset [44034] by xan@webkit.org

2009-05-21 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

Add MacroAssemblerCodeRef.h to file list.

  • GNUmakefile.am:
21:44 Changeset [44033] by mrowe@apple.com

Merge r44031.

21:44 Changeset [44032] by mrowe@apple.com

Build fix.

20:57 Changeset [44031] by slewis@apple.com

2009-05-21 Stephanie Lewis <slewis@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6913680> Update image caching options.
Disable extra ImageIO cache because we already handle caching decoded image data.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
19:34 Changeset [44030] by barraclough@apple.com

2009-05-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Darin Adler.
Addition of MacroAssemblerCodeRef.h rubber stamped by Geoff Garen.

Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.

Rationalization of all this:

  • Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
  • Change the JIT & Yarr to internally handle code using CodeRefs.
  • Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
  • Remove the (now) redundant code pointer from FunctionBodyNode.

While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.

This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.

No performance impact.

  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
  • interpreter/CallFrameClosure.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
  • jit/JIT.h:
  • jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
  • parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
  • parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
18:55 Changeset [44029] by levin@chromium.org

2009-05-21 Albert J. Wong <ajwong@chromium.org>

Reviewed by Eric Seidel.

Bug 25903: Create a default UI theme for media controls in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=25903

Implement a default UI for chromium. Add a style sheet for Chromium
media controls with good defaults and implemented basic draw functions
for play/pause & mute buttons.

  • css/mediaControlsChromium.css: Added.
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint specific to mute button.
  • rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific to mute button. (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate header changes.
  • rendering/RenderThemeChromiumWin.h:
18:48 Changeset [44028] by mrowe@apple.com

Merge r44027.

18:46 Changeset [44027] by ggaren@apple.com

Checked in layout tests I accidentally left out of my last check-in.

18:39 Changeset [44026] by mrowe@apple.com

Merge r44016.

18:39 Changeset [44025] by mrowe@apple.com

Merge r44011.

18:39 Changeset [44024] by mrowe@apple.com

Merge r44010.

18:38 Changeset [44023] by mrowe@apple.com

Merge r43993.

18:38 Changeset [44022] by mrowe@apple.com

Merge r43976.

18:38 Changeset [44021] by mrowe@apple.com

Merge r43970.

18:35 Changeset [44020] by eric@webkit.org

2009-05-21 Eric Seidel <eric@webkit.org>

Rubber-stamped by Antti Koivisto.

Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915

Second attempt at landing, now using -c instead of -C to make sure
that mod_alias is loaded on Apache 1.x instances before using Alias.

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
18:33 Changeset [44019] by weinig@apple.com

2009-05-21 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Implement op_negate inline fast cases.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::neg32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::negl_m): (JSC::X86Assembler::xorpd_rr):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
18:10 Changeset [44018] by kevino@webkit.org

Reviewed by Kevin Ollivier.

When stripping the query from a file:// URL, do not leave a trailing question mark.

https://bugs.webkit.org/show_bug.cgi?id=25940

17:57 Changeset [44017] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Notify ImageObserver::didDraw to help the cache purge alive resources.

https://bugs.webkit.org/show_bug.cgi?id=25942

17:28 Changeset [44016] by oliver@apple.com

<rdar://problem/6910264> REGRESSION: Cached DOM global object property access fails in browser (25921)
<https://bugs.webkit.org/show_bug.cgi?id=25921>

Reviewed by Maciej Stachowiak.

When caching properties on the global object we need to ensure that we're
not attempting to cache through a shell object.

17:15 Changeset [44015] by levin@chromium.org

2009-05-21 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Flesh out font fallback for Chromium's Skia port.
getLastResortFallbackFont should fall back on well-known fonts.
https://bugs.webkit.org/show_bug.cgi?id=25860

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getLastResortFallbackFont): try known font names.
17:09 Changeset [44014] by sfalken@apple.com

Windows build fix.

16:36 Changeset [44013] by mrowe@apple.com

Merge r43891.

16:36 Changeset [44012] by mrowe@apple.com

Merge r43880.

16:32 Changeset [44011] by mitz@apple.com

Reviewed by John Sullivan.

  • speculative fix for <rdar://problem/6890716> crash at FontCache::purgeInactiveFontData + 199
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData can cause releaseFontData() to be called, which modifies gInactiveFontData. Therefore, avoid deleting SimpleFontData instances while iterating over gInactiveFontData and delete them afterwards.
16:26 Changeset [44010] by ggaren@apple.com

WebCore:

2009-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file

  • page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL, since that only looks at the text of the document's URL. Do base our decision on the securityOrigin(), which knows more about the document's actual origin.

LayoutTests:

2009-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.


Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file

  • http/tests/local/drag-over-remote-content-expected.txt: Added.
  • http/tests/local/drag-over-remote-content.html: Added.
  • http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
  • http/tests/security/drag-over-remote-content-iframe.html: Added.
16:23 Changeset [44009] by mitz@apple.com

Correct change log

16:23 Changeset [44008] by mrowe@apple.com

Merge r43973.

16:23 Changeset [44007] by mrowe@apple.com

Merge r43969.

16:22 Changeset [44006] by mrowe@apple.com

Merge r43964.

16:22 Changeset [44005] by mrowe@apple.com

Merge r43951.

16:22 Changeset [44004] by mrowe@apple.com

Merge r43942.

16:22 Changeset [44003] by mrowe@apple.com

Merge r43937.

16:22 Changeset [44002] by mrowe@apple.com

Merge r43931.

16:22 Changeset [44001] by mrowe@apple.com

Merge r43949.

16:22 Changeset [44000] by mitz@apple.com

Rubber-stamped by Mark Rowe.

Rolled out r43985.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
16:22 Changeset [43999] by mrowe@apple.com

Merge r43929.

16:22 Changeset [43998] by mrowe@apple.com

Merge r43912.

16:22 Changeset [43997] by mrowe@apple.com

Merge r43878.

16:22 Changeset [43996] by mrowe@apple.com

Merge r43876.

16:22 Changeset [43995] by mrowe@apple.com

Merge r43869.

16:21 Changeset [43994] by mrowe@apple.com

Merge r43866.

16:00 Changeset [43993] by weinig@apple.com

2009-05-21 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson and Mark Rowe.

Fix for <rdar://problem/6901522>
REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari

If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
the MIME type to be text/html.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
15:56 Changeset [43992] by kevino@webkit.org

Blind windows fix after last commit.

15:42 Changeset [43991] by kov@webkit.org

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Fixing test to actually use the correct names for the frames.

  • http/tests/mime/accept-all-text-types.html:
15:29 Changeset [43990] by kevino@webkit.org

Reviewed by Kevin Ollivier.

Use an environment variable to control which logs are on and off.
Also, make a generic function for translating channel name to its log.

https://bugs.webkit.org/show_bug.cgi?id=25936

15:15 Changeset [43989] by kov@webkit.org

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disable 2 more tests that sometimes fail.

  • platform/gtk/Skipped:
15:12 Changeset [43988] by cwzwarich@webkit.org

2009-05-21 Cameron Zwarich <zwarich@apple.com>

Reviewed by Mark Rowe.

Bug 25945: Add support for MADV_FREE to TCMalloc
<https://bugs.webkit.org/show_bug.cgi?id=25945>
<rdar://problem/6910754>

Add support for MADV_FREE to TCMalloc_SystemRelease for platforms that
don't also support MADV_FREE_REUSE. The code is identical to the MADV_DONTNEED
case except for the advice passed to madvise(), so combining the two cases
makes the most sense.

  • wtf/Platform.h: Only define HAVE_MADV_FREE when not building on Tiger or Leopard, because while it is defined on these platforms it actually does nothing.
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): use MADV_FREE if it is available; otherwise use MADV_DONTNEED.
15:07 Changeset [43987] by kevino@webkit.org

wx build fix after method added to EditorClient.

14:54 Changeset [43986] by kov@webkit.org

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Adding file I forgot to add to last commit.

  • http/tests/mime/resources/accept-all-text-types.cgi: Added.
14:47 Changeset [43985] by kov@webkit.org

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Darin Adler.

Test that WebKit accepts any text/* type.

  • http/tests/mime/accept-all-text-types-expected.txt: Added.
  • http/tests/mime/accept-all-text-types.html: Added.
14:36 Changeset [43984] by darin@chromium.org

2009-05-21 Darin Fisher <darin@chromium.org>

Fix-up coding style.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
14:36 Changeset [43983] by darin@chromium.org

2009-05-21 Darin Fisher <darin@chromium.org>

Fix-up coding style.

  • WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
14:35 Changeset [43982] by darin@chromium.org

2009-05-21 Darin Fisher <darin@chromium.org>

Fix build bustage.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
  • WebCoreSupport/EditorClientGtk.h:
14:19 Changeset [43981] by levin@chromium.org

2009-05-21 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
https://bugs.webkit.org/show_bug.cgi?id=25946

A very simple implementation to keep it working. A bug has been filed in the chromium db
(http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
complete.

  • platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
14:02 Changeset [43980] by darin@chromium.org

2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>

Reviewed by Justin Garcia.


Add automatic spell correction support in WebKit

https://bugs.webkit.org/show_bug.cgi?id=24953

  • editing/Editor.cpp: (WebCore::findFirstMisspellingInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markMisspellingsAndBadGrammar):
  • editing/Editor.h:
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
  • page/EditorClient.h:
13:57 Changeset [43979] by christian@webkit.org

2009-05-21 Christian Dywan <christian@twotoasts.de>

Reviewed by Darin Adler.

Text files which have sub MIME types are treated as not displayable
http://bugs.webkit.org/show_bug.cgi?id=24903

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any MIME type beginning with "text/" as supported and remove all "text/" types from the list.
13:54 Changeset [43978] by kov@webkit.org

LayoutTests

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Disable failing HTTP tests now that we are enabling HTTP on the
bot.

  • platform/gtk/Skipped:

WebKitTools

2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Default to running HTTP tests for GTK+.

  • Scripts/run-webkit-tests:
13:30 Changeset [43977] by darin@apple.com

2009-05-21 Darin Adler <darin@apple.com>

Rolled the httpd changes out, since many machines (including the bots)
have an older version of Apache that does not support the Alias command.
Or maybe it's something else, but the bots are failing.

  • Scripts/run-webkit-httpd: Rolled back.
  • Scripts/run-webkit-tests: Ditto.
12:57 Changeset [43976] by mrowe@apple.com

Fix <https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page

Reviewed by Oliver Hunt.

The debugger currently retrieves the arguments object from an activation rather than pulling
it from a call frame. This is unreliable to due to the recent optimization to lazily create
the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
but for now we force eager creation of the arguments object when debugging.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

12:25 Changeset [43975] by ggaren@apple.com

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Geoffrey Garen.

Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915

  • Scripts/run-webkit-httpd:
  • Scripts/run-webkit-tests:
11:51 Changeset [43974] by ap@webkit.org

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=25890
Implement Network logging channel on Mac

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Added logging for async requests (as these are most interesting).
11:19 Changeset [43973] by ap@webkit.org

Reviewed by Darin Adler.

<rdar://problem/6907542> REGRESSION (r43143): Hang in RenderLineBoxList::dirtyLinesFromChangedChild
when clicking link to load Flash animation (http://www.roambi.com)

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Don't call -[NSApplication updateWindows] here, WebHTMLView can take care of this.
  • WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Use a precomputed boolean stored in WebHTMLViewPrivate, as calling isTextInput() is not always safe. (-[WebHTMLView textStorage]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Update _private->exposeInputContext when selection changes, and let AppKit update its cache if necessary.
11:17 Changeset [43972] by eric.carlson@apple.com

2009-05-21 Eric Carlson <eric.carlson@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit


Add a static table to map from some common file extensions to their MIME types so it
is possible to detect support even when the platform mapping is incomplete. Use the
table to lookup types not found by UTI on the OSX, and when looking for a media engine
with a generic or missing type.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap. (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified MIME type in the static mapping table if the platform specific getMIMETypeForExtension doesn't find a match.
  • platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension to MIME type if UTI fails.
09:36 Changeset [43971] by kov@webkit.org

2009-05-21 Andre Pedralho <andre.pedralho@openbossa.org>

Reviewed by Gustavo Noronha.

Added --makeargs flag to the build script.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
09:29 Changeset [43970] by ap@webkit.org

Reviewed by Darin Adler.

<rdar://problem/5579292> REGRESSION (2-3): "Default default" encoding for Korean changed
from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites

  • WebView/WebPreferences.mm:

(+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Update the existing fix
for the changed result of CFStringConvertEncodingToIANACharSetName().

09:03 Changeset [43969] by ap@webkit.org

Reviewed by Darin Adler.

<rdar://problem/6883758> REGRESSION (r43143): First character typed with input method does
not go into inline hole (seen with Chinese & Kotoeri on top Chinese website www.baidu.com)

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Call -[NSApplication updateWindows] to make AppKit re-fetch the input context when selection changes. Since we use SelectionController to check whether the view is editable, it is important not to re-fetch the context too early, e.g. from a focus changed notification.
07:05 Changeset [43968] by eric@webkit.org

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Clean up DragController
https://bugs.webkit.org/show_bug.cgi?id=25926

I renamed m_document to m_documentUnderMouse to better document what it does
I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
long enough.

I also saw copy/paste code involving clearing the selection when moving out of
one document and into another. I moved that code into a function called
mouseMovedIntoDocument.

I also got rid of a couple needless null-checks after confirming via source
inspection they were not ever possible.
In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
It's also not possible to return a document from documentAtPoint that is not
in a frame (as such a document would not be rendered).

No functional changes, thus no tests.

  • page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragIsMove): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::mouseMovedIntoDocument): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::placeDragCaret):
  • page/DragController.h: (WebCore::DragController::documentUnderMouse):
05:50 Changeset [43967] by eric@webkit.org

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Rename DragController::dragOperation() to sourceDragOperation() for clarity
Remove unused setDragOperation()

There are two times DragOperation is used. The source specifies
what drag operations it supports (in a mask) and the destination
picks a subset of those as DragOperations it supports if a drop were
to occur. I was confused when I first saw this accessor as to which
it meant. It turns out that this is only used when WebKit starts a
drag, and we keep it around so that we can provide this information
to other Mac OS X applications when they ask. I've renamed the method
for clarity so the next person in this code will be less confused.

No functional changes, thus no tests.

  • page/DragController.h: (WebCore::DragController::sourceDragOperation):
05:34 Changeset [43966] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19517
<rdar://problem/6007112> DOM modification of textArea causes Access Violation (NULL pointer?)

This no longer happens with ToT, just adding a test.

  • fast/parser/head-parsing-19517-expected.txt: Added.
  • fast/parser/head-parsing-19517.html: Added.
02:30 Changeset [43965] by mitz@apple.com

Rubber-stamped by Mark Rowe.

  • correct a copyright header accidently reverted in r43964
  • WebKitSystemInterface.h:
02:16 Changeset [43964] by mitz@apple.com

WebCore:

Reviewed by Anders Carlsson.

  • WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com

A bug in old versions of Core Graphics causes memory corruption to occur
when clipping under certain conditions. Make the clipping functions
fail silently under those conditions.

Test: fast/block/float/selection-gap-clip-out-tiger-crash.html

  • WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that, on Tiger, bails out if wkCGContextIsSafeToClip() returns false. (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip. (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect. (WebCore::GraphicsContext::fillPath): Changed to call the safe variants of CGContextClip, CGContextEOClip and CGContextClipToRect. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::clip): Ditto. (WebCore::GraphicsContext::clipOut): Ditto. (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto. (WebCore::GraphicsContext::clipPath): Ditto. (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto. (WebCore::GraphicsContext::strokeRect): Ditto.
  • platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
  • platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.

WebKit/mac:

Reviewed by Anders Carlsson.

  • WebKit part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added CGContextIsSafeToClip.

WebKitLibraries:

Reviewed by Anders Carlsson.

  • WebKitSystemInterface part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests:

Reviewed by Anders Carlsson.

  • test for <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
  • fast/block/float/selection-gap-clip-out-tiger-crash-expected.txt: Added.
  • fast/block/float/selection-gap-clip-out-tiger-crash.html: Added.
02:08 Changeset [43963] by xan@webkit.org

2009-05-21 Xan Lopez <xlopez@igalia.com>

Unreviewed build fix.

https://bugs.webkit.org/show_bug.cgi?id=25910
WebkitGTK r43960 cannot compile

Do not include local copy of guriescape header, which was
removed. We now use the copy in glib.

  • platform/gtk/FileSystemGtk.cpp:
01:41 Changeset [43962] by cwzwarich@webkit.org

2009-05-21 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
<https://bugs.webkit.org/show_bug.cgi?id=25912>

This causes no change on SunSpider.

  • runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the temporary buffer has sufficient space to store the result, and move the explicit null-termination closer to the memcpy() for easier visual inspection of the code. (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT that the temporary buffer has sufficient space to store the result. There is no explicit null-termination because this is done by the caller. The same is already true for exponentialPartToString(). (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly null-terminate the result, and ASSERT that the temporary buffer has sufficient space to store the result.
01:02 Changeset [43961] by eric@webkit.org

2009-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix file-input-files-access which was passing for the wrong reasons.

The log was pushing the drop target off screen and the drops were failing!

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/resources/file-input-files-access.js: (testOrderedDraggingWithDirectory): (runTest):
Note: See TracTimeline for information about the timeline view.