Timeline


and

05/27/09:

23:36 Changeset [44223] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a

Fix MIME type.

23:31 Changeset [44222] by mrowe@apple.com
  • 5 edits
    1 add in trunk

Update build-webkit to handle a new version of WebKitSystemInterface.

Rubber-stamped by Dan Bernstein.

  • Scripts/build-webkit:

Update WebKitSystemInterface.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a: Added.
  • libWebKitSystemInterfaceTiger.a:
23:25 Changeset [44221] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
23:02 Changeset [44220] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=26056
XPath string() function can be very slow

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
22:30 Changeset [44219] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <mjs@apple.com>

Not reviewed, demo content.


  • Add doctype to Calendar demo.
  • demos/calendar/Calendar.html:
22:25 Changeset [44218] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible

Test: fast/forms/isindex-placeholder.html

  • css/html4.css: Added a default style for <isindex> placeholder text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call the new protected function updatePlaceholderVisibility().
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this protected function to allow HTMLIsIndexElement::parseMappedAttribute() to invoke InputElement::updatePlaceholderVisibility().
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call updatePlaceholderVisibility() when parsing the placeholder attribute.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there is no placeholder pseudo-element style, use the normal style.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible
  • fast/forms/isindex-placeholder.html: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.txt: Added.
22:06 Changeset [44217] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <sam@webkit.org>

Reviewed by Maciej Stachowiak.

More cleanup of DOMWindow related functions.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog): Update Comment.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove JSDOMWindowShell::clear(). It was unused.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
20:36 Changeset [44216] by oliver@apple.com
  • 4 edits in trunk

<rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz

Reviewed by Mark Rowe

Add an additional exception check for stack overflow in String.replace

20:17 Changeset [44215] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Miscellaneous cleanup of DOMWindow related functions.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops checking for null frames if the build does not support profiling. (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling clearHelperObjectProperties(). It is clearer.
  • bindings/js/JSDOMWindowBase.h: Removed now unused clearHelperObjectProperties() function, empty disconnectFrame() function, and the empty destructor.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): Remove calls to JSDOMWindowShell::disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
18:50 Changeset [44214] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

18:49 Changeset [44213] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.13

New tag.

17:28 Changeset [44212] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44194.

17:27 Changeset [44211] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44189.

17:27 Changeset [44210] by mrowe@apple.com
  • 7 edits in branches/WWDC-2009-branch

Merge r44181.

17:27 Changeset [44209] by mrowe@apple.com
  • 6 edits
    3 adds in branches/WWDC-2009-branch

Merge r44174.

17:27 Changeset [44208] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44172.

17:27 Changeset [44207] by mrowe@apple.com
  • 11 edits in branches/WWDC-2009-branch

Merge r44170.

17:27 Changeset [44206] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44169.

17:27 Changeset [44205] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44164.

17:27 Changeset [44204] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44122.

17:13 Changeset [44203] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Xan Lopez.

Add comment to clarify why scrolling is done as it is and not with
gdk_window_scroll.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
15:16 Changeset [44202] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-27 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=25974
Remove extra qualifiers from the ScheduledAction decl.

  • bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
14:23 Changeset [44201] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed make distcheck fix. One more missing file.

  • GNUmakefile.am:
14:09 Changeset [44200] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Fixed trunk build on Linux after r44126.

13:46 Changeset [44199] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6926046> REGRESSION (r43972): http://www.youtube.com/html5 crashes on open

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
13:04 Changeset [44198] by mjs@apple.com
  • 1 edit
    18 adds in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <mjs@apple.com>

Not reviewed, demo content.


  • add Calendar demo.
  • demos/calendar: Added.
  • demos/calendar/Boom.aiff: Added.
  • demos/calendar/Calendar.css: Added.
  • demos/calendar/Calendar.html: Added.
  • demos/calendar/Calendar.js: Added.
  • demos/calendar/Calendar.manifest: Added.
  • demos/calendar/CalendarApp.icns: Added.
  • demos/calendar/Images: Added.
  • demos/calendar/Images/AirPort4.png: Added.
  • demos/calendar/Images/AirPortError.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallDown.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallRight.png: Added.
  • demos/calendar/Images/statusbarBackground.png: Added.
  • demos/calendar/Images/statusbarResizerVertical.png: Added.
  • demos/calendar/LocationImage.js: Added.
  • demos/calendar/Utilities.js: Added.
  • demos/calendar/favicon.ico: Added.
  • demos/calendar/mime.types: Added.
12:20 Changeset [44197] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed (make distcheck) build fix; adding missing headers.

  • GNUmakefile.am:
12:14 Changeset [44196] by jberlin@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-27 Jessie Berlin <jberlin@apple.com>

Reviewed by aroben


Fix the Windows build.

12:03 Changeset [44195] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-05-27 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak.

Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
https://bugs.webkit.org/show_bug.cgi?id=26029

No functional changes, so no tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
11:01 Changeset [44194] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=26009
<rdar://problem/6925656> REGRESSION (r43973): Problems While Working With OpenVanilla

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): Don't call updateWindows if the selection is None. This routinely happens during editing, and it doesn't mean that we left an editable area (in which case the selection changes to a non-editable one).
10:57 Changeset [44193] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix.

Remove file that does not exist from the build.

  • GNUmakefile.am:
10:33 Changeset [44192] by zimmermann@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.

10:27 Changeset [44191] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Adding new symbols index for 1.1.8.

  • docs/webkitgtk-docs.sgml:
10:21 Changeset [44190] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=17725
XPath should be case insensitive for HTML

Test: fast/xpath/node-name-case-sensitivity.html

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive for HTML elements in HTML documents.
10:00 Changeset [44189] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 John Sullivan <sullivan@apple.com>

fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)

Reviewed by Kevin Decker

  • page/DragController.cpp: (WebCore::DragController::dragExited): nil check m_documentUnderMouse and take the "local file" case if it's nil
07:02 Changeset [44188] by kov@webkit.org
  • 4 edits in trunk

WebCore and JavaScriptCore

2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Gustavo Noronha.

When building on Windows, consider Windows specific files.

  • GNUmakefile.am:
05:25 Changeset [44187] by zimmermann@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26031

InputElementData is too heavy, save storing two pointers by passing them
directly to the static helper functions (the only place which needs them).

05:23 Changeset [44186] by zimmermann@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26033

OptionElementData saves an Element pointer, which is unnessary.
Just pass it to the static function calls directly.

05:17 Changeset [44185] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Disabling new tests to make the bot green.

  • platform/gtk/Skipped:
05:04 Changeset [44184] by kov@webkit.org
  • 6 edits in trunk

2009-05-27 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

When building with MinGW, don't use the declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.

03:21 Changeset [44183] by zecke@webkit.org
  • 9 edits
    2 adds in trunk

JavaScripCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25613

Be able to use GOwnPtr for GHashTable as well. The assumption
is that the hash table has been created with g_hash_table_new_full
and has proper destruction functions.

  • wtf/GOwnPtr.cpp: (WTF::GHashTable):
  • wtf/GOwnPtr.h:

WebCore:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25613

Add a WebCore::Widget that can embed GtkWidget with and
without a GdkWindow. This can be used to embed any GtkWidget.

Some bits are directly copied from the Scrollbar implementation
but can not be easily shared here.

  • GNUmakefile.am:
  • platform/gtk/GtkPluginWidget.cpp: Added. (WebCore::GtkPluginWidget::GtkPluginWidget): (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::frameRectsChanged): (WebCore::GtkPluginWidget::paint):
  • platform/gtk/GtkPluginWidget.h: Added.

WebKit:
2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25613

Add a new signal called "create-plugin-widget" and emit it from
within the FrameLoaderClientGtk::createPlugin method. If a
GtkWidget gets returned it will be embedded as a WebCore::Widget
using the new GtkPluginWidget.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
  • webkit/webkitwebview.cpp: (webkit_signal_accumulator_object_handled): (webkit_web_view_class_init):
  • webkitmarshal.list:
03:21 Changeset [44182] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Gustavo Noronha.

https://bugs.webkit.org/show_bug.cgi?id=25613

Implement Widget::setIsSelected for Gtk+ by searching
for a property of the name "webkit-widget-is-selected" and if
such property exists we are going to set it. We expect
the property to take a boolean.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setIsSelected):

05/26/09:

23:53 Changeset [44181] by weinig@apple.com
  • 7 edits in trunk

WebCore:

2009-05-26 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe

Add ability to force content sniffing for all urls (including file: urls)

  • WebCore.base.exp:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniffURL): (WebCore::ResourceHandle::forceContentSniffing):
  • platform/network/ResourceHandle.h:

WebKit/mac:

2009-05-26 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe

Add linked-on-or-after check to allow older WebKit apps to use the
old behavior of sniffing everything (including file: urls)

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
23:35 Changeset [44180] by zecke@webkit.org
  • 5 edits
    1 add in trunk/WebKit/qt

2009-05-26 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25823

Add an API to generate a QUrl out of a string correcting for errors and missing information.
See the API documentation for more details about the function.

Autotests: included

  • Api/qwebview.cpp: (QWebView::guessUrlFromString):
  • Api/qwebview.h:
  • QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation):
  • tests/qwebview/.gitignore: Added.
  • tests/qwebview/qwebview.pro:
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::initTestCase): (tst_QWebView::cleanupTestCase): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::guessUrlFromString_data): (tst_QWebView::guessUrlFromString):
23:35 Changeset [44179] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25996

[Qt] Dead-code stripping for unix

  • WebCore.pro: Turn on GCC dead-code stripping flags for Unix
23:25 Changeset [44178] by bdakin@apple.com
  • 8 edits in branches/WWDC-2009-branch/WebCore

2009-05-26 Beth Dakin <bdakin@apple.com>

Rubber-stamped by Dan Bernstein and Darin Adler.

Fix for <rdar://problem/6922919> Revert back to Safari 3 text
control metrics calculations

We're rolling this change out of the branch because we think it
needs more bake time.

  • css/html4.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::lineGap):
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
22:25 Changeset [44177] by zecke@webkit.org
  • 6 edits in trunk/WebCore

[GTK] Send onscroll events for the main FrameView

2009-05-10 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=25646

[GTK] Send onscroll events for the main FrameView

WebKit/GTK+ is currently not sending any onscroll
events for a frame with external adjustments. This is
due the fact that the value-changed signal of the GtkAdjustment
is handled by WebCore::ScrollView directly and is not going through
the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
path.

Fix the above problem by wrapping the GtkAdjustment we get
assigned from GTK+ in a ScrollbarGtk that will not have any
visual appearance. Remove code from ScrollView that knows
about adjustments and create a special case for
WebCore::ScrollView::createScrollbar that will create such
a special WebCore::ScrollbarGtk.

  • platform/ScrollView.cpp: Remove adjustment code (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: Remove adjustment code
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::createScrollbar): (WebCore::ScrollView::setGtkAdjustments):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::createScrollbar): Special case. (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment (ScrollbarGtk::~ScrollbarGtk): Disconnect signal (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
  • platform/gtk/ScrollbarGtk.h:
22:20 Changeset [44176] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Cameron Zwarich <zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
<https://bugs.webkit.org/show_bug.cgi?id=26035>
<rdar://problem/6924087>

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image is JPEG, there is no image type, or m_decoder is null.
21:30 Changeset [44175] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Fix build breakage of JPEGImageDecoder.cpp by including stdio.h again.

2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix for the JPEGImageDecoder.

Revision 44167 removed stdio.h from the included headers and
this will lead to an error that FILE is not known inside the
jpeglib.h Put back the stdio.h include.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
20:22 Changeset [44174] by oliver@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/6924033> REGRESSION: Assertion failure due to forward references

Reviewed by Gavin Barraclough.

Add a pattern type for forward references to ensure that we don't confuse the
quantifier alternatives assertion.

19:54 Changeset [44173] by staikos@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Fix the crash issue while running layout tests after enabled XHTMLMP
https://bugs.webkit.org/show_bug.cgi?id=26017

19:47 Changeset [44172] by slewis@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-26 Stephanie Lewis <slewis@apple.com>

Reviewed by Ada Chan and Oliver Hunt.

Remove WebView observers in during fast teardown.
<rdar://problem/6922619> REGRESSION (Tiger-only?): After restoring windows from the previous session, a crash occurs while attempting to quit Safari

  • WebView/WebView.mm: (-[WebView _closeWithFastTeardown]):
19:47 Changeset [44171] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-05-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
and also an ASSERT failure on http://ihasahotdog.com/.

When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.

Export the new symbols.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check_second):

Close dictionary prototypes upon caching a method access, as would happen when caching
a regular get_by_id.

  • runtime/JSObject.h: (JSC::JSObject::propertyStorage): (JSC::JSObject::locationForOffset):

Make these methods private.

(JSC::JSObject::putDirectInternal):

When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.

  • runtime/Structure.cpp: (JSC::Structure::despecifyDictionaryFunction):

Reset the specific value field for a given property in a dictionary.

(JSC::Structure::despecifyFunctionTransition):

Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).

  • runtime/Structure.h:

Declare new method.

17:45 Changeset [44170] by andersca@apple.com
  • 11 edits in trunk

WebCore:

2009-05-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com


Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
the improved selection drawing on Tiger.


  • WebCore.Tiger.exp:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillSelectionGaps):

WebKit/mac:

2009-05-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com

Remove WKCGContextIsSafeToClip.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

2009-05-26 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com

Remove WKCGContextIsSafeToClip.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:
17:33 Changeset [44169] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver "pieces of eight" Hunt.

When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.

  • yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::reset):
17:29 Changeset [44168] by bfulgham@webkit.org
  • 3 edits in trunk/SunSpider

2009-05-26 Olivier DOLE <odole@pleyo.com>

Reviewed by Maciej.

Store sunspider test suite results in a specific directory for each
different type of benchmark (sunspider, V8 or ubench).

  • sunspider:
  • sunspider-compare-results:
17:20 Changeset [44167] by bfulgham@webkit.org
  • 22 edits in trunk/WebCore

2009-05-26 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25709 part two
Mostly cosmetic changes, mainly to get image decoders for Cairo build to
comply with WebKit style guidelines:

  • Fix header guard names
  • Fix initializer list wrapping
  • Fix class/function "{" wrapping
  • Fix wrapping of long boolean expressions
  • Fix whitespace around operators
  • Eliminate whitespace on otherwise-blank lines
  • No {} on single-line conditional arms
  • Use 0 instead of NULL
  • Don't #include "config.h" in headers

Also a few non-cosmetic changes:

  • Remove unneeded #ifdef protecting the contents of these files. The platforms listed don't match who uses these files anymore (even without considering Skia), and platforms which don't use them at all (like CG) aren't harmed by the files, since they don't have equivalently-named classes. It's simpler to just ditch these.
  • Convert a use of Vector<>& into SharedBuffer*, since that's how the data is really stored anyway.
  • Use size() instead of m_size, for consistency with Skia code, and future-proofing (if a particular decoder wants to specialize this).
  • Move an ASSERT that was slightly more aggressive than necessary.
  • Change variable names/types for clarity/accuracy and to match Skia.
  • Remove unnecessary macro magic to work around a problem which no longer exists in the third-party JPEG headers.
  • Stop silencing a portability warning about setjmp (the vcproj/vsprops are the right place for this)
  • In Skia code, don't explicitly check |m_failed| before calling isSizeAvailable(), which itself checks |m_failed|.
  • platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement. (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer. (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping. (WebCore::GIFImageDecoder::frameCount): Add comment. (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators. (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer. (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size. (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name. (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
  • platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef. (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning. (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageReader::close): Add comment, zero another member for consistency. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h. (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
  • platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
  • platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL. (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::rowAvailable):
  • platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
17:13 Changeset [44166] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning.

16:57 Changeset [44165] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a regression caused by my recent fix for NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): Actually do the comparison in reverse order, like the ChangeLog said we would, bokay?
16:57 Changeset [44164] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/6922371> REGRESSION (r43973): Can't type first character with an umlaut, circumflex, or accent in Mail or in a wiki
  • WebView/WebHTMLView.mm: (isTextInput): Moved here. (isInPasswordField): Moved here. (-[WebHTMLView becomeFirstResponder]): Update the exposeInputContext flag and let NSApplication update the input manager with the new input context if necessary. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the NSApp global instead of +[NSApplication sharedApplication].
16:06 Changeset [44163] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Brent Fulgham <bfulgham@webkit.org>

Build fix to correct r44161.

  • wtf/FastAllocBase.h:
15:58 Changeset [44162] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-05-26 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25944
Remove the uses of V8 Locker in worker execution code. No additional test is needed.
The normal WebKit layout tests should cover it. However, layout tests that start
multiple workers will fail to pass due to test shell limitation in Chromium. To cover
this, UI tests will be added (http://code.google.com/p/chromium/issues/detail?id=12554).

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
15:25 Changeset [44161] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>

Reviewed by Maciej Stachowiak.

Inherite HashTable from FastAllocBase, because it has been instantiated by
'new' in JavaScriptCore/runtime/JSGlobalData.cpp.

  • wtf/HashTable.h:
  • wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
14:41 Changeset [44160] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-05-26 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25974
Enable timers in Chromuim workers.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
  • bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer. Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
14:19 Changeset [44159] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-05-26 Adam Barth <abarth@webkit.org>

https://bugs.webkit.org/show_bug.cgi?id=26011

Unreviewed change to disable flaky test as requested by Sam Weinig.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Removed.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Removed.
13:43 Changeset [44158] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build.

  • Misc/WebNSObjectExtras.mm:

(-[NSInvocation _webkit_invokeAndHandleException:]): Rename the local variable so that
it doesn't conflict with a member variable on Tiger.

13:28 Changeset [44157] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=23649
Update V8 bindings to match SQLTransactionErrorCallback change.

  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
13:05 Changeset [44156] by krit@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/WebCore

2009-05-26 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move FilterEffect to platform/graphics/filters. First step to get an
SVG independent filter system.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FilterEffect.cpp: Added. (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::~FilterEffect): (WebCore::FilterEffect::externalRepresentation):
  • platform/graphics/filters/FilterEffect.h: Added. (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
  • svg/FilterEffect.cpp: Removed.
  • svg/FilterEffect.h: Removed.
12:37 Changeset [44155] by dglazkov@chromium.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=23649
Update SQLTransactionErrorCallback to not return a value per changes in
HTML5 spec.

Test: storage/transaction-error-callback.html

  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionErrorCallback.h:

LayouTests:

2009-05-26 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=23649
Add layout test for various cases of SQLTransactionErrorCallback
invocation.

  • storage/transaction-error-callback-expected.txt: Added.
  • storage/transaction-error-callback.html: Added.
11:29 Changeset [44154] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-26 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

<rdar://problem/6921835> REGRESSION (r44115): Crash in Leopard Mail viewing message

Fix case where we autorelease an object on the main thread that we are returning
to another thread when using our _webkit_invokeOnMainThread method.

  • Misc/WebNSObjectExtras.mm: (returnTypeIsObject): Added. (-[WebMainThreadInvoker forwardInvocation:]): Autorelease the object on the calling thread, balancing a retain done on the main thread. (-[NSInvocation _webkit_invokeAndHandleException:]): Retain the object on the main thread.
11:26 Changeset [44153] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-26 David Hyatt <hyatt@apple.com>

Back out the workaround for Mail crashing. Darin is working on the real fix.

  • Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]):
11:16 Changeset [44152] by hyatt@apple.com
  • 7 edits
    8 adds in trunk

WebCore:

2009-05-26 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25969

Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
continue to show scrollbars.

Added two tests in fast/dynamic.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2009-05-26 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=25969.

Stop using notifications for boundsChanged, since the notifications are being sent too late.
Since subviews get resized before parents do, the notification comes in telling the WebHTMLView
that its size has changed *before* we've done setNeedsLayout in the WebView size change callback.

Become more like the Windows platform and just do the bounds changed immediately as our size is
being altered by subclassing setFrameSize in WebView.

Also patch WebDynamicScrollbarsView to detect the case where neither axis is really spilling out
past the viewport, so that in shrinking situations we figure out that we don't need scrollbars
any more.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
  • WebView/WebView.mm: (-[WebView _boundsChangedToNewSize:]): (-[WebView setFrameSize:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]):

LayoutTests:

2009-05-26 David Hyatt <hyatt@apple.com>

Reviewed by Darin Adler.

Fix for bug 25969, scrollbars remain after document shrinks. Add a couple of layout tests
written by Dan that show various problems with scrollbars following resizes.

  • fast/dynamic/window-resize-scrollbars-test.html: Added.
  • fast/dynamic/window-scrollbars-test.html: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.png: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.txt: Added.
10:49 Changeset [44151] by cfleizach@apple.com
  • 8 edits
    6 moves in trunk/WebCore

Bug 25801: change AccessibilityAria -> AccessibilityARIA
https://bugs.webkit.org/show_bug.cgi?id=25801

09:00 Changeset [44150] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2009-05-26 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=26012

Fix the Skia path to normalize the given source rect when
drawing patterns, so it accepts negative width/height (as CG does).
Fixes Chromium bug http://www.crbug.com/6167.

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
05:23 Changeset [44149] by ap@webkit.org
  • 6 edits in trunk/WebCore

2009-05-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Serialize calls to WebInspector. This is the first step where method
calls are being serialized to arrays (not yet JSON stringified ones) and
are being dispatched on the client. This change also allows client to override
InspectorFrontend, so that the serialized calls can be made on a given object
instead of in-process WebInspector global. This will be the main control flow
when InspectorController is decoupled from the in-process frontend.

https://bugs.webkit.org/show_bug.cgi?id=26010

  • inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::overrideFrontendObject): (WebCore::InspectorController::show): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::newFunctionCall): (WebCore::InspectorFrontend::callSimpleFunction):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.dispatch):
00:30 Changeset [44148] by ggaren@apple.com
  • 3 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig and Oliver Hunt.


Fixed two edge cases in %:


  • Don't do -2147483648 % x as a fast case, since you might do -2147483648 % -1, which will signal a hardware exception due to overflow.
  • In the case of a zero remainder, be sure to store negative zero if the dividend was zero.


SunSpider reports no change.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):

LayoutTests:

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig and Oliver Hunt.


Added test for arithmetic edge cases.


  • fast/js/arithmetic-expected.txt: Added.
  • fast/js/arithmetic.html: Added.
  • fast/js/resources/arithmetic.js: Added.

05/25/09:

23:20 Changeset [44147] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
23:03 Changeset [44146] by ggaren@apple.com
  • 3 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed a regression when comparing to NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.

LayoutTests:

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added test for NaN comparisons.


  • fast/js/nan-expected.txt: Added.
  • fast/js/nan.html: Added.
  • fast/js/resources/nan.js: Added. ():
21:21 Changeset [44145] by levin@chromium.org
  • 8 edits
    5 adds in trunk

JavaScriptCore:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.

In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds

+ m_sharedBuffer -- a pointer to the shared ref counted buffer

if the class is BaseString and the buffer is being shared OR

+ m_baseString -- the BaseString if the class is only UString::Rep

but not a UString::BaseString

Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.

No change in sunspider perf.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
  • runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
  • wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):

JavaScriptGlue:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=25126

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.

WebCore:

2009-05-25 David Levin <levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
21:00 Changeset [44144] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


SunSpider says no change.


Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
17:20 Changeset [44143] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it

Reviewed by Maciej Stachowiak

17:08 Changeset [44142] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
16:52 Changeset [44141] by mrowe@apple.com
  • 15 edits in branches/WWDC-2009-branch

Merge r44136.

16:52 Changeset [44140] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44132.

16:52 Changeset [44139] by mrowe@apple.com
  • 3 edits
    2 adds in branches/WWDC-2009-branch

Merge r44075.

16:52 Changeset [44138] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44069.

16:51 Changeset [44137] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44066.

15:48 Changeset [44136] by andersca@apple.com
  • 15 edits in trunk

WebCore:

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • WebCore side of <rdar://problem/6914001>.

Add a new m_allowPopupsFromPlugin flag.


  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

WebKit/mac:

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • WebKit side of <rdar://problem/6914001>.
  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".


  • Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
14:33 Changeset [44135] by abarth@webkit.org
  • 10 edits
    8 adds in trunk

WebCore:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26006

Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:

1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.

Tests: http/tests/security/frameNavigation/context-for-location-assign.html

http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
  • bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <abarth@webkit.og>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26006

Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.

  • http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-assign.html: Added.
  • http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href.html: Added.
  • http/tests/security/frameNavigation/context-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/target-for-location.html: Added.
14:11 Changeset [44134] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests/http/tests/security/postMessage

Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)

12:33 Changeset [44133] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26011

Try to make test less flaky.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
  • http/tests/security/postMessage/origin-follows-lexical-scope.html:
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
  • http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
11:48 Changeset [44132] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • Fix <rdar://problem/6915849>.


Release the placeholder window after -[NSApplication runModalForWindow] returns.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
08:41 Changeset [44131] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

The functions written in assembly need to have a leading
underscore on Windows too.

  • jit/JITStubs.cpp:
08:41 Changeset [44130] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-05-25 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
05:55 Changeset [44129] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-25 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Simon Hausmann.

Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.

05:39 Changeset [44128] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=25612

Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.

Made the Audio and Video elements conditional in the tag factories

04:45 Changeset [44127] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Gtk build when video is disabled.

04:35 Changeset [44126] by hausmann@webkit.org
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <simon.hausmann@nokia.com>

Fix the Qt build when video is disabled.

  • WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
01:36 Changeset [44125] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typo.

01:29 Changeset [44124] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26004

The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.

Test: http/tests/security/postMessage/origin-follows-lexical-scope.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26004

Test that the origin for postMessage follows the lexical scope.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.

05/24/09:

23:27 Changeset [44123] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-24 Darin Fisher <darin@chromium.org>

Reviewed by Mark Rowe.

Fix build bustage related to PassOwnPtr changes.

https://bugs.webkit.org/show_bug.cgi?id=25999

  • platform/graphics/chromium/TransparencyWin.cpp:
22:20 Changeset [44122] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • revert an accidental change from r43964.
  • WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
20:29 Changeset [44121] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
20:29 Changeset [44120] by zecke@webkit.org
  • 6 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.

  • GNUmakefile.am:
  • WebCore.pro:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/qt/PluginPackageQt.cpp:
20:28 Changeset [44119] by zecke@webkit.org
  • 6 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25988

So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.

The PluginPackageWin version got copied to PluginPackage

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
15:43 Changeset [44118] by krit@webkit.org
  • 5 edits
    5 adds in trunk/WebCore

2009-05-24 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Added standard input for filter system.

No testcases were added. Filter system is still off.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
  • platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
  • platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
  • platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
  • svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
  • svg/FilterBuilder.h:
12:35 QtWebKitContrib edited by hausmann@webkit.org
(diff)
11:13 Changeset [44117] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-24 Steve Falkenburg <sfalken@apple.com>

Build fix for experimental PGO Windows target.


11:10 Changeset [44116] by hausmann@webkit.org
  • 3 edits in trunk/WebCore

2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=25612

Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.

Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).

09:34 Changeset [44115] by darin@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-24 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein and Tim Hatcher.

<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a

  • Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
08:34 Changeset [44114] by darin@apple.com
  • 2 edits in trunk/WebKit

2009-05-24 Darin Adler <darin@apple.com>

  • StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
00:48 Changeset [44113] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-24 Xan Lopez <xlopez@igalia.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation

Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):

05/23/09:

23:38 Changeset [44112] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build fix for Qt. Change signature to have PassOwnPtr.

22:14 Changeset [44111] by mrowe@apple.com
  • 5 edits
    7 adds in trunk/WebKitTools

Land the updated version of WebKitLauncher that the nightly builds have been using.

Reviewed by Oliver Hunt.

Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the

launch process to be detected by the extension-detection code.

  • WebKitLauncher/Configurations/Base.xcconfig: Added.
  • WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
  • WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
  • WebKitLauncher/Info.plist:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitNightlyEnabler.h: Added.
  • WebKitLauncher/WebKitNightlyEnabler.m:

(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):

  • WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
  • WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.

(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):

  • WebKitLauncher/main.m:

(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):

21:21 Changeset [44110] by jmalonzo@webkit.org
  • 1 edit in trunk/ChangeLog

Fix typo "am" -> "an" in the Changelog of my previous commit

21:06 Changeset [44109] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed build fix. Add gstreamer-video-0.10 libs to
GSTREAMER_LIBS to resolve am undefined reference to gst_video_get_size

  • symbol used in MediaPlayerPrivateGstreamer.
  • configure.ac:
16:28 Changeset [44108] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • clean up ColorMac a little
  • platform/graphics/mac/ColorMac.h: Whitespace change.
  • platform/graphics/mac/ColorMac.mm: Removed redundant #import statements and sorted the remaining ones. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls with a single call and removed redundant casts to int. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats. In one case, this avoids an intermediate conversion to float before conversion to double on 64-bit. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls with a single call. (WebCore::focusRingColor): (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
15:55 Changeset [44107] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Refactored new slow case codegen for == and !=.


SunSpider reports no change, maybe a tiny speedup.

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation, instead of *32, to make it portable to 64bit. Reorganized the string and generic cases to make their control flow a little clearer.
15:39 Changeset [44106] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Break the switch once private browsing is selected.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property): (webkit_web_settings_get_property):
15:35 Changeset [44105] by jmalonzo@webkit.org
  • 7 edits in trunk

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Enable storage/ tests for Gtk.

  • platform/gtk/Skipped:

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Add settings to enable or disable database and localStorage
support and enable them by default. This allows databases to be
shown in the WebInspector as well as allow us to run the storage
layout tests.

  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Gustavo Noronha and Xan Lopez.

[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629

Enable database and localStorage for running the storage/ tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
15:22 Changeset [44104] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
https://bugs.webkit.org/show_bug.cgi?id=25900

Use ATK_ROLE_TEXT for ListMarkerRole.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
15:20 Changeset [44103] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286

Refactor library LIBS. Move third-party libs in libwebkit instead
of libWebCore.

  • GNUmakefile.am:
15:08 Changeset [44102] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Reformat WebCore::requiresContextForWordBoundary()

  • platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary):
14:29 Changeset [44101] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.

14:25 Changeset [44100] by zimmermann@webkit.org
  • 23 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808

After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.

WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
HTMLSelectElement/WMLSelectElement.

10:32 Changeset [44099] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Fix Gtk/Qt builds for PassOwnPtr

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer> instead of an std::auto_ptr<ImageBuffer> to store the result of ImageBuffer::create() now that it returns a PassOwnPtr<ImageBuffer>.
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): Ditto. (WebCore::Path::strokeBoundingRect): Ditto.
10:16 Changeset [44098] by ddkilzer@apple.com
  • 3 edits in trunk/WebKit/win

Windows build fix for PassOwnPtr

  • WebHistory.cpp: (WebHistory::visitedURL): Changed std::auto_ptr<Vector<String> >() to 0.
  • WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Changed type of redirectURLsVector from std::auto_ptr<Vector<String> > to OwnPtr<Vector<String> >.
10:06 Changeset [44097] by ggaren@apple.com
  • 6 edits in branches/nitro-extreme/JavaScriptCore

2009-05-23 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Optimized == and != for our new value representation -- especially for strings.


14% speedup on date-format-tofte.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_eq_strings): (JSC::JITStubs::cti_op_call_eval):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSValue.h:
09:39 Changeset [44096] by ddkilzer@apple.com
  • 42 edits in trunk

Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr

<https://bugs.webkit.org/show_bug.cgi?id=25495>

Reviewed by Oliver Hunt.

WebCore:

No test cases added since there is no change in behavior.

  • WebCore.base.exp: Updated export for HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
  • dom/Node.cpp: (WebCore::Node::childNodes): Use NodeListsNodeData::create() instead of new NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::getElementsByTagNameNS): Ditto. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto.
  • dom/NodeRareData.h: (WebCore::NodeListsNodeData::create): Added. Implements create() pattern popularized by RefCounted classes. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared private constructor. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<> instead of an auto_ptr<>.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::setRedirectURLs): Ditto.
  • history/HistoryItem.h: (WebCore::HistoryItem::setRedirectURLs): Ditto.
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
  • page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • platform/text/TextCodec.h: (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of auto_ptr<>.
  • platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): Ditto.
  • platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
  • platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): Ditto. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
  • platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined): Ditto.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::newTextCodec): Ditto.
  • platform/text/TextEncodingRegistry.h: (WebCore::newTextCodec): Ditto.
  • platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac): Ditto.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return OwnPtr<> instead of auto_ptr<>.
  • svg/SVGMaskElement.h: (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<> instead of auto_ptr<>.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>.
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask): Updated to use assignment operator now that SVGMaskElement::drawMaskerContent() returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/mac:

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Return 0 instead of an empty auto_ptr<>.
  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use OwnPtr<> instead of auto_ptr<> for stack variable.
  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/win:

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.

WebKit/wx:

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
09:39 Changeset [44095] by ddkilzer@apple.com
  • 10 edits
    10 adds in trunk

Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr

<https://bugs.webkit.org/show_bug.cgi?id=25495>

Reviewed by Oliver Hunt.

JavaScriptCore:

  • GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • wtf/OwnPtr.h: (WTF::OwnPtr::OwnPtr): Added constructors that take a PassOwnPtr. Also added a copy constructor declaration that's required when assigning a PassOwnPtr to a stack-based OwnPtr. (WTF::operator=): Added assignment operator methods that take a PassOwnPtr. (WTF::swap): Reformatted. (WTF::operator==): Whitespace changes. (WTF::operator!=): Ditto.
  • wtf/OwnPtrCommon.h: Added. (WTF::deleteOwnedPtr):
  • wtf/PassOwnPtr.h: Added. (WTF::PassOwnPtr::PassOwnPtr): (WTF::PassOwnPtr::~PassOwnPtr): (WTF::PassOwnPtr::get): (WTF::PassOwnPtr::clear): (WTF::PassOwnPtr::release): (WTF::PassOwnPtr::operator*): (WTF::PassOwnPtr::operator->): (WTF::PassOwnPtr::operator!): (WTF::PassOwnPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):

JavaScriptGlue:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.

WebCore:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.
  • WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and PassOwnPtr.h.

WebKit/mac:

  • ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • ForwardingHeaders/wtf/PassOwnPtr.h: Added.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
09:15 Changeset [44094] by ddkilzer@apple.com
  • 14 edits in trunk/WebCore

Fix Mac builds by backing out r44093

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp:
  • page/Geolocation.idl:
  • page/Geoposition.cpp:
  • page/Geoposition.h:
  • page/Geoposition.idl:
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
  • page/PositionError.idl:
  • platform/GeolocationService.cpp: (WebCore::GeolocationService::create):
08:28 Changeset [44093] by zecke@webkit.org
  • 14 edits in trunk/WebCore

2009-05-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Add GEOLOCATION guards around Geolocation API code
https://bugs.webkit.org/show_bug.cgi?id=25756

  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSGeolocationCustom.cpp:
  • page/Geolocation.cpp:
  • page/Geolocation.idl:
  • page/Geoposition.cpp:
  • page/Geoposition.h:
  • page/Geoposition.idl:
  • page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
  • page/PositionError.idl:
  • platform/GeolocationService.cpp:
08:21 Changeset [44092] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

resolve-ChangeLogs: Add missing newline to status message

  • Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -ccontinue switch is used but there

are unmerged files remaining in the git working directory.

08:07 Changeset [44091] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher

In r42377, startUpdateRenderingDispatcher() was renamed to
startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
dropped. This change restores it.

  • WebCore.order:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
  • page/animation/AnimationControllerPrivate.h:
07:03 Changeset [44090] by zecke@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-05-23 Jakob Truelsen <antialize@gmail.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=25863

Expose the default text encoding property to Qt.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setDefaultTextEncoding): (QWebSettings::defaultTextEncoding):
  • Api/qwebsettings.h:
06:55 Changeset [44089] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed build-fix for Qt. Disable SVG Filters.

SVG Filters can not be built right now and Qt should not have
them enabled anyway as they did not carry out any filtering.

04:08 Changeset [44088] by oliver@apple.com
  • 5 edits in trunk

Remove interpreter specific logic from the JIT builds

Reviewed by Maciej Stachowiak.

This saves ~100k in JSC release builds.

02:06 Changeset [44087] by oliver@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add tests to cover exceptions thrown from non-object results of get_by_id

Reviewed by Maciej Stachowiak

01:25 Changeset [44086] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Add an error message to a die statement

00:32 Changeset [44085] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-05-23 Dirk Schulze <krit@webkit.org>

Unreviewed build-fix for gtk. Remove source input files
for SVG filter system from the build for the moment and
add them later again.

  • GNUmakefile.am:
00:22 Changeset [44084] by jmalonzo@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>

Unreviewed. Skip new tests introduced in r44010. These tests
require an eventSender implementation which the gtk port
currently do not have.

Also remove gtk-specific result for
fast/canvas/canvas-composite-alpha. The non-platform specific
result now works.

  • platform/gtk/Skipped:
  • platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Removed.
00:19 Changeset [44083] by krit@webkit.org
  • 38 edits in trunk/WebCore

2009-05-23 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991

Preparing Filter primitves for the new filter system.

No testcases were added. SVG filters are off by default.

  • GNUmakefile.am:
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • svg/Filter.h:
  • svg/FilterBuilder.h: (WebCore::FilterBuilder::lastFilter):
  • svg/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
  • svg/FilterEffect.h: (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
  • svg/graphics/filters/SVGFETurbulence.h:
Note: See TracTimeline for information about the timeline view.